[15:09:34] 10Tool-Zppixbot, 10User-MacFan4000, 10User-Zppix: Update join.py to get channels from local config file - https://phabricator.wikimedia.org/T244935 (10MacFan4000) a:03MacFan4000 [15:11:41] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03MacFan4000-patch-1 [+0/-0/±1] 13https://git.io/Jf76B [15:11:43] [02ZppixBot-Source] 07MacFan4000 03d9ba895 - Update join.py [15:12:05] [02ZppixBot-Source] 07MacFan4000 opened pull request 03#196: Update join.py per T244935 - 13https://git.io/Jf76R [15:13:09] Pix1234/ZppixBot-Source/MacFan4000-patch-1/d9ba895 - MacFan4000 The build failed. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/698577404 [15:20:16] [02ZppixBot-Source] 07MacFan4000 synchronize pull request 03#196: Update join.py per T244935 - 13https://git.io/Jf76R [15:20:17] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03MacFan4000-patch-1 [+0/-0/±1] 13https://git.io/Jf76j [15:20:19] [02ZppixBot-Source] 07MacFan4000 03e671e21 - fixes [15:27:35] [02ZppixBot-Source] 07MacFan4000 review_requested pull request 03#196: Update join.py per T244935 - 13https://git.io/Jf76R [15:28:23] [02ZppixBot-Source] 07MacFan4000 labeled pull request 03#196: Update join.py per T244935 - 13https://git.io/Jf76R [15:29:50] [02ZppixBot-Source] 07RhinosF1 closed pull request 03#140: Update and rename join.py to forcejoin.py - 13https://git.io/Jf2tt [15:30:25] 10Tool-Zppixbot, 10User-MacFan4000: Evaluate join.py - https://phabricator.wikimedia.org/T253301 (10RhinosF1) a:05TheVoidwalker→03MacFan4000 [15:30:39] MacFan4000: ^ [15:30:56] k [15:32:30] I think we still need Voidwalkers thoughts in that though [15:33:11] as he is the one that added it [15:33:25] MacFan4000: it was as sopel wasn't rate limiting enough [15:33:42] The bug is fixed now if we have the limits set high enough in .cfg [15:35:13] we have throttle_join = 1 in config currently [15:35:53] there's also throttle_wait which defaults to 1 [15:37:38] its how many channels at a time vs how long between joining batches of channels [15:39:29] currently with join.py, we are waiting one seccond between joining each channel [15:41:15] MacFan4000: I would up throttle_wait to 2 [15:41:39] k [15:42:40] I would do it on -test first, but it has the module disabled, and is in too few channels to be an issue [15:44:24] MacFan4000: re-enable then once you merge [15:44:31] And add a few ##test* entries [15:45:34] RhinosF1: its a config change that would eliminate the need for the module [15:45:53] MacFan4000: I know [15:46:10] but I want to keep joinall [15:46:47] weren't we trying to not have single command modules? [15:47:22] because renaming to joinall.py and removing auto join is making it just that [15:48:33] MacFan4000: single command, response only plugins [15:48:40] Join doesn't fit anywhere else [15:52:19] [02ZppixBot-Source] 07MacFan4000 synchronize pull request 03#196: Update join.py per T244935 - 13https://git.io/Jf76R [15:52:20] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03MacFan4000-patch-1 [+1/-1/±0] 13https://git.io/Jf7Pb [15:52:22] [02ZppixBot-Source] 07MacFan4000 03b4c8fdf - Update and rename join.py to joinall.py [15:54:06] [02ZppixBot-Source] 07RhinosF1 edited pull request 03#196: Remove join hack and rename to joinall.py - 13https://git.io/Jf76R [15:54:30] MacFan4000: +1 [15:54:37] [02ZppixBot-Source] 07MacFan4000 closed pull request 03#196: Remove join hack and rename to joinall.py - 13https://git.io/Jf76R [15:54:38] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03dev [+1/-1/±0] 13https://git.io/Jf7XJ [15:54:40] [02ZppixBot-Source] 07MacFan4000 03ea7784c - Remove join hack and rename to joinall.py (#196) * Update join.py * fixes * Update and rename join.py to joinall.py [16:03:36] it works [16:03:46] .joinall [16:04:00] .help [16:04:02] I've posted a list of my commands at https://clbin.com/6X08b - You can see more info about any of these commands by doing .help (e.g. .help time) [16:30:00] .version [16:30:00] RhinosF1: Sopel v7.0.4 (Python 3.5.3) [16:34:52] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03master [+1/-1/±0] 13https://git.io/Jf7M4 [16:34:54] [02ZppixBot-Source] 07MacFan4000 03299c5bb - Remove join hack and rename to joinall.py (#196) * Update join.py * fixes * Update and rename join.py to joinall.py [16:47:58] there we go [16:48:25] [02ZppixBot-Source] 07MacFan4000 deleted branch 03MacFan4000-patch-1 [16:48:45] 10Tool-Zppixbot, 10User-MacFan4000, 10User-Zppix: Update join.py to get channels from local config file - https://phabricator.wikimedia.org/T244935 (10MacFan4000) 05Open→03Resolved [16:49:50] 10Tool-Zppixbot, 10User-MacFan4000: Evaluate join.py - https://phabricator.wikimedia.org/T253301 (10MacFan4000) 05Open→03Resolved [16:49:53] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Replace Core-Overrides with addon plugins - https://phabricator.wikimedia.org/T253299 (10MacFan4000) [16:49:55] 10Tool-Zppixbot, 10User-MacFan4000, 10User-Zppix: Update join.py to get channels from local config file - https://phabricator.wikimedia.org/T244935 (10MacFan4000) [16:50:14] 10Tool-Zppixbot, 10User-MacFan4000: Evaluate join.py - https://phabricator.wikimedia.org/T253301 (10RhinosF1) Undeployed and replaced! [16:50:50] 10Tool-Zppixbot, 10User-MacFan4000: Evaluate join.py - https://phabricator.wikimedia.org/T253301 (10RhinosF1) [16:51:02] 10Tool-Zppixbot, 10User-MacFan4000: Evaluate join.py - https://phabricator.wikimedia.org/T253301 (10MacFan4000) [16:51:09] 10Tool-Zppixbot, 10User-MacFan4000, 10User-Zppix: Update join.py to get channels from local config file - https://phabricator.wikimedia.org/T244935 (10RhinosF1) [16:51:57] 10Tool-Zppixbot, 10Upstream, 10User-Zppix: Do something about ping.py - https://phabricator.wikimedia.org/T253386 (10RhinosF1) >>! In T253386#6178158, @RhinosF1 wrote: > @Zppix: Can you approve pulling this with 7.1? > > If so, we can migrate off. @Zppix: ??? [16:52:44] now the only blocker to releasing ZppixBot v7 are ping and mhphab [16:52:57] s/blocker/blockers [16:52:58] MacFan4000 meant to say: now the only blockers to releasing ZppixBot v7 are ping and mhphab [16:53:12] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Replace Core-Overrides with addon plugins - https://phabricator.wikimedia.org/T253299 (10RhinosF1) 05Open→03Resolved All plugins have been replaced or will be in the next upstream update [16:53:14] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) [16:53:42] MacFan4000: ping is sopel 7.1 [16:53:46] Mh phab is soon [16:53:58] k [16:54:34] 10Tool-Zppixbot, 10User-RhinosF1, 10User-Zppix: Code review for ZppixBot's mhphab.py - https://phabricator.wikimedia.org/T253111 (10RhinosF1) [16:54:36] 10Tool-Zppixbot, 10User-RhinosF1: make mentioning a task directly link it - https://phabricator.wikimedia.org/T253401 (10RhinosF1) 05Open→03Resolved a:05RhinosF1→03Examknow [16:54:47] 10Tool-Zppixbot, 10User-RhinosF1: make mentioning a task directly link it - https://phabricator.wikimedia.org/T253401 (10RhinosF1) [16:57:20] MacFan4000: T253398 is probably the more complex one [16:57:36] The add status back is easy [17:03:34] [02ZppixBot-Source] 07Pix1234 pushed 031 commit to 03dev [+0/-0/±1] 13https://git.io/Jf7Dt [17:03:35] [02ZppixBot-Source] 07RhinosF1 03a312f1c - Update Python Comments in Travis (#192) * Update .travis.yml * Update .travis.yml [17:03:37] [02ZppixBot-Source] 07Pix1234 closed pull request 03#192: Update Python Comments in Travis - 13https://git.io/JfDxS [17:03:38] [02ZppixBot-Source] 07Pix1234 deleted branch 03RhinosF1-patch-3 [17:48:08] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03dev [+0/-0/±1] 13https://git.io/Jf7Sk [17:48:10] [02ZppixBot-Source] 07MacFan4000 038a1e2cb - attempt to fix when owner is none [17:49:36] Pix1234/ZppixBot-Source/dev/8a1e2cb - MacFan4000 The build was broken. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/698635541 [17:50:01] MacFan4000: author has the same bug [17:50:33] author should never be none anyway [17:50:45] True [17:51:15] MacFan4000: I'd just check that any unexpected response is handled [17:52:01] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03dev [+0/-0/±1] 13https://git.io/Jf7SG [17:52:03] [02ZppixBot-Source] 07MacFan4000 032e76986 - fix [17:53:39] Pix1234/ZppixBot-Source/dev/2e76986 - MacFan4000 The build is still failing. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/698636839 [17:54:49] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03dev [+0/-0/±1] 13https://git.io/Jf7SC [17:54:51] [02ZppixBot-Source] 07MacFan4000 03f7e48b6 - Update mh_phab.py [17:55:34] MacFan4000: None not null [17:56:16] Pix1234/ZppixBot-Source/dev/f7e48b6 - MacFan4000 The build is still failing. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/698637705 [17:56:29] ah [17:56:41] i was looking at conduit [17:56:53] (test api outputs) [17:57:53] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03dev [+0/-0/±1] 13https://git.io/Jf7Sa [17:57:55] [02ZppixBot-Source] 07MacFan4000 03fc5c1db - Update mh_phab.py [17:59:27] Pix1234/ZppixBot-Source/dev/fc5c1db - MacFan4000 The build was fixed. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/698638547 [18:00:34] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03dev [+0/-0/±1] 13https://git.io/Jf7SS [18:00:35] [02ZppixBot-Source] 07MacFan4000 03b32f9fc - Update mh_phab.py [18:24:07] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03dev [+0/-0/±1] 13https://git.io/Jf79y [18:24:09] [02ZppixBot-Source] 07MacFan4000 03b80c654 - add priority [18:26:19] 10Tool-Zppixbot, 10User-MacFan4000: mh_phab check if OwnerPHID is none - https://phabricator.wikimedia.org/T253398 (10MacFan4000) 05Open→03Resolved a:03MacFan4000 fixed [18:26:21] 10Tool-Zppixbot, 10User-RhinosF1, 10User-Zppix: Code review for ZppixBot's mhphab.py - https://phabricator.wikimedia.org/T253111 (10MacFan4000) [18:27:02] 10Tool-Zppixbot, 10User-MacFan4000, 10User-RhinosF1: make task status work - https://phabricator.wikimedia.org/T253400 (10MacFan4000) 05Open→03Resolved a:03MacFan4000 done [18:27:04] 10Tool-Zppixbot, 10User-RhinosF1, 10User-Zppix: Code review for ZppixBot's mhphab.py - https://phabricator.wikimedia.org/T253111 (10MacFan4000) [18:27:19] RhinosF1: ^^ [18:33:44] MacFan4000: see -logs [18:37:28] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03dev [+0/-0/±1] 13https://git.io/Jf7HC [18:37:30] [02ZppixBot-Source] 07MacFan4000 03ff62e87 - add status [18:39:08] Pix1234/ZppixBot-Source/dev/ff62e87 - MacFan4000 The build was broken. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/698651223 [18:39:51] ugh, 9 chars too long [18:40:17] MacFan4000: up travis 10 then! [18:40:46] [02ZppixBot-Source] 07MacFan4000 pushed 031 commit to 03dev [+0/-0/±1] 13https://git.io/Jf7HR [18:40:48] [02ZppixBot-Source] 07MacFan4000 036158b7c - Update .travis.yml [18:42:21] Zppix: https://phabricator.wikimedia.org/T253386 is pending your approval [18:42:22] [ ⚓ T253386 Do something about ping.py ] - phabricator.wikimedia.org [18:42:24] Pix1234/ZppixBot-Source/dev/6158b7c - MacFan4000 The build was fixed. https://travis-ci.org/Pix1234/ZppixBot-Source/builds/698652101 [18:42:55] MacFan4000: for now we are not staying at our version, i dont see any improvement by using upstreams [18:43:04] we are staying* [18:43:05] RhinosF1: ^^ [18:49:44] 10Tool-Zppixbot, 10Upstream, 10User-Zppix: Do something about ping.py - https://phabricator.wikimedia.org/T253386 (10MacFan4000) 05Open→03Declined Declined per @Zppix comment on IRX [18:49:47] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Replace Core-Overrides with addon plugins - https://phabricator.wikimedia.org/T253299 (10MacFan4000) [18:53:02] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) [18:53:49] 10Tool-Zppixbot, 10User-RhinosF1, 10User-Zppix: Code review for ZppixBot's mhphab.py - https://phabricator.wikimedia.org/T253111 (10RhinosF1) I will complete a review of the new code and deploy to master later this week. [18:55:27] 10Tool-Zppixbot: Release ZppixBot 7 - https://phabricator.wikimedia.org/T253381 (10RhinosF1) [18:55:29] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) 05Open→03Resolved a:03RhinosF1 Code Evaluated, The final checks will be done later this week or have open plans to deal with. [18:55:33] 10Tool-Zppixbot, 10Epic, 10Patch-For-Review, 10User-RhinosF1: Convert to new plugins system in Sopel - https://phabricator.wikimedia.org/T243698 (10RhinosF1) [18:55:53] 10Tool-Zppixbot, 10Epic, 10User-RhinosF1: Evaluate ZppixBot Code - https://phabricator.wikimedia.org/T253297 (10RhinosF1) [18:57:03] Zppix, MacFan4000: Once I check over mh_phab and tidy up some loose ends, we can release version 7. [18:57:17] k [19:27:39] http://wm-bot.wmflabs.org/dump/%23ZppixBot.htm [19:27:39] @info [19:27:41] [ #ZppixBot ] - wm-bot.wmflabs.org [23:25:16] 10Tool-Zppixbot: Block pinging sites on url blacklist - https://phabricator.wikimedia.org/T241484 (10MacFan4000) Is this still needed now that we aren’t switching to the upstream module?