[17:14:51] <se4598>	 petan: ping; about the github-pullrequest
[18:02:52] <petan>	 se4598 hi
[18:02:59] <se4598>	 hi
[18:03:17] <petan>	 there was a line changing something for all wikis
[18:03:35] <petan>	 you changed it so that it changes stuff for 3 wikis only, are you sure other dont need it
[18:04:43] <se4598>	 first of all, As far as I see a lot of code in this file switches for this 3 wikis
[18:05:30] <se4598>	 I haven't coded in VB, so correct my if I'm wrong: ' Links &= "" ' does nothing
[18:05:39] <se4598>	 so then it would ony change it for enwiki
[18:06:12] <petan>	 you removed Return Links & "</span>" 
[18:06:28] <se4598>	 and as far as i see this span got only openend on enwiki by that switch before, so why should it be closed for every wiki?
[18:06:31] <petan>	 which is equal of return Links + "</span>" ; in c++
[18:06:56] <petan>	 and you replaced it with code that works for 3 wikis only...
[18:07:08] <petan>	 that means the other wikis would never get that "</span>"  tah
[18:07:14] <petan>	 *tag
[18:07:45] <petan>	 ok, if that span is opened only for enwiki, then it is correct to close it only for enwiki
[18:07:55] <se4598>	 petan: btw, is this line even do something: Case "es.wikipedia", "de.wikipedia" : Links &= "" 
[18:08:10] <petan>	 this line makes no sense to me Case "es.wikipedia", "de.wikipedia" : Links &= "" 
[18:08:22] <petan>	 no it doesnt do anything at all
[18:08:34] <petan>	 if you need to close it for enwiki only, you should do:
[18:08:51] <se4598>	 petan: It's the eqivalent to line 309: Case "es.wikipedia", "de.wikipedia" : Links = ""
[18:09:07] <se4598>	 which doesn't make anything because of line 305
[18:09:09] <petan>	 if Config.Project ="e.wikipedia" then
[18:09:19] <petan>	 Return  Links &= "</span>" 
[18:09:24] <petan>	 end if
[18:09:38] <petan>	 Links = "" makes sense
[18:09:45] <petan>	 Links &= ""  doesnt
[18:10:10] <se4598>	 petan: Even if you declare it some line above as: Dim Links As String = ""
[18:10:15] <se4598>	 ?
[18:10:52] <petan>	 I dont really know history of this block :/ maybe it was used for something in past
[18:11:32] <se4598>	 I don't know it either, so i just copied the exiting logic
[18:26:46] <se4598>	 petan: https://github.com/se4598/huggle/commit/d4dbee3cfe1cf36ca2a0154f2e00b367567eb4a4
[18:27:00] <se4598>	 as followup, could be pulled, too
[18:28:30] <Not-001>	 [02huggle] 07benapetr pushed 033 commits to 03master [+0/-0/±3] 13http://git.io/vvWa3g
[18:28:31] <Not-001>	 [02huggle] 07se4598 038c6f38a - only close span-tag if it had been opened
[18:28:32] <Not-001>	 [02huggle] 07se4598 03d4dbee3 - removed useless code leaving select-case statement for easy extending for other projects
[18:28:33] <Not-001>	 [02huggle] 07benapetr 03395ae3b - Merge pull request #2 from se4598/master fix generated report-text
[18:33:26] <se4598>	 thanks :)
[18:47:39] <petan>	 yw