[01:04:37] <Not-004>	 [02huggle3-qt-lx] 07benapetr pushed 032 commits to 03master [+0/-0/±12] 13https://github.com/huggle/huggle3-qt-lx/compare/2225c82d19b6...e0bdc33cba68
[01:04:38] <Not-004>	 [02huggle3-qt-lx] 07benapetr 0305dc2a6 - more cache for HAN
[01:04:39] <Not-004>	 [02huggle3-qt-lx] 07benapetr 03e0bdc33 - history load on next edit
[03:22:33] <Clarkcj>	 I just got an error using huggle the error is http://toolserver.org/~mmovchin/paste/index.php?id=ff6bd54bff
[12:35:16] <Not-004>	 [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±2] 13http://git.io/XnjDwQ
[12:35:17] <Not-004>	 [02huggle3-qt-lx] 07benapetr 030ed7674 - layout hide a push buttons so that there is more space for list
[18:25:38] <wm-bot>	 Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Darkwind link https://en.wikipedia.org/w/index.php?diff=584088277 edit summary: /* HG3 feedback */ new section
[18:53:00] <wm-bot>	 Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by My name is not dave link https://en.wikipedia.org/w/index.php?diff=584092281 edit summary: /* HG3 feedback */
[18:54:28] <wm-bot>	 Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by My name is not dave link https://en.wikipedia.org/w/index.php?diff=584092507 edit summary: /* HG3 feedback */
[19:01:23] <Not-004>	 [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±7] 13http://git.io/uWLEKA
[19:01:24] <Not-004>	 [02huggle3-qt-lx] 07benapetr 03febf397 - preferences new option to pick what action you want on change
[19:06:55] <wm-bot>	 Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by My name is not dave link https://en.wikipedia.org/w/index.php?diff=584094313 edit summary: /* HG3 feedback */ oops
[19:21:30] <Not-004>	 [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±3] 13http://git.io/2aImWQ
[19:21:32] <Not-004>	 [02huggle3-qt-lx] 07benapetr 03d6aff59 - prevent it being rendered in a loop
[19:54:26] <mynameisnotdave>	 petan: You there?
[19:54:40] <petan>	 yes
[19:55:15] <mynameisnotdave>	 petan: Is it me, or are you getting a seg fault when loading an edit from the queue?
[19:55:25] <petan>	 what build
[19:56:54] <mynameisnotdave>	 d6aff59
[19:58:07] <mynameisnotdave>	 Well, just got that one
[19:58:31] <petan>	 I am running it too now and so far I didn't get it, why don't you analyse the core dump?
[19:58:43] <petan>	 or just run it in debugger
[20:08:49] <mynameisnotdave>	 petan: Huggle crashed in WikiEdit::IsPostProcessed
[20:09:06] <mynameisnotdave>	  if (this->Status == StatusPostProcessed)
[20:09:16] <petan>	 ok can you post me full stack trace
[20:09:48] <mynameisnotdave>	 The core dump?
[20:10:00] <petan>	 eh that would be probably too large
[20:10:12] <petan>	 just type backtrace
[20:10:16] <petan>	 in gdb
[20:12:39] <petan>	 this sounds like if this-> was NULL or whatever
[20:19:53] <mynameisnotdave>	 petan: http://pastebin.com/t2AM0ws3
[20:31:18] <petan>	 ha I knew that hehe 0x0000000000462e30 in Huggle::WikiEdit::IsPostProcessed (this=0x0)
[20:31:32] <petan>	 now how in the world it could happen
[20:32:08] <petan>	 aha so it didn't crash when you loaded edit from queue
[20:32:15] <petan>	 it crashed when you loaded it from history
[20:36:01] <mynameisnotdave>	 Appears so, yes
[20:39:20] <petan>	 HAH
[20:39:24] <petan>	 I found it
[20:40:10] <mynameisnotdave>	 Was WikiEdit NULL in the function, or was it something else?
[20:41:38] <Not-004>	 [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/FIg0Rg
[20:41:40] <Not-004>	 [02huggle3-qt-lx] 07benapetr 03a5cd604 - undefined variable
[20:42:02] <petan>	 it was missing this->RetrievingEdit = false in constructor
[20:42:14] <petan>	 so that it was random value
[20:42:33] <mynameisnotdave>	 Ah, thought it might also be that as well
[20:42:34] <petan>	 btw I found 2 more bugs which were rather minor, but fortified that too
[20:43:37] <mynameisnotdave>	 Great, I can get to work now with testing what I promised to do (https://en.wikipedia.org/wiki/Wikipedia:Huggle/Feedback#HG3_feedback)
[21:00:57] <petan>	 mynameisnotdave: wait with #1
[21:01:00] <petan>	 its already done lol
[21:01:34] <petan>	 there is Message::SectionKeep
[21:01:52] <petan>	 it just needs to be finished there is no interface for this
[21:08:20] <wm-bot>	 Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=584111570 edit summary: /* HG3 feedback */ re
[21:11:26] <petan>	 mynameisnotdave: so I don't really mind if you finish that but keep the current design pls
[21:11:46] <mynameisnotdave>	 In which one?
[21:12:12] <petan>	 basically, what you should do: 1) finish implementation of KeepSection 2) create an option in preferences where user can decide what they like to do 3) implemented this option
[21:12:27] <petan>	 mynameisnotdave: I am talking about Message::KeepSection
[21:12:39] <petan>	 I think it currently doesn't keep section, but not sure
[21:13:05] <petan>	 it needs to be finished and once it is you can apply this, but it needs to be user configurable, not default for every message
[21:13:25] <petan>	 there may be messages that always needs to be in own section
[21:13:32] <petan>	 like custom messages etc
[21:13:42] <petan>	 or mesages of type "You were blocked"
[21:14:09] <mynameisnotdave>	 petan: Block notices can go in the same section as the warnings
[21:14:24] <petan>	 ok, anyway it needs to be user configurable and project configurable
[21:14:45] <petan>	 which is easy to implement, it's just about switching the KeepSection variable
[21:14:53] <mynameisnotdave>	 Okaydokay
[21:15:28] <petan>	 first what needs to be done is to ensure that when KeepSection is true, the message is first downloaded, then parsed and new message inserted to bottom of that section
[21:15:38] <petan>	 and if section doesn't exist it should behave like if it was false
[21:15:52] <petan>	 and if there are multiple sections with same name it should go to last one
[21:18:22] <petan>	 I see I already made it download the page if KeepSection is true
[21:19:36] <mynameisnotdave>	 Yes, that's convenient
[21:20:19] <petan>	 mynameisnotdave: I think that most simple is if you insert on line 251 new code that check if KeepSection is true and if it's true, it call a function that parses the current text and append the new text and then return this as QString
[21:20:26] <petan>	 so that you just append there something like
[21:21:25] <petan>	 if (this->KeepSection) { this-text = this->AppendToSection(this->Page, this->title) ...
[21:21:58] <petan>	 AppendToSection could be either static or it wouldn't need to work with variables at all
[21:22:06] <petan>	 that's up to you :P
[21:22:09] <mynameisnotdave>	 petan: Doesn't line 254 do this already?
[21:22:20] <petan>	 no
[21:22:56] <petan>	 that append new text in case that user didn't request to create a section at all (neither merge the existing section)
[21:23:12] <petan>	 for example when you want to send a message that itself contains header (thus it makes new section)
[21:23:15] <petan>	 this is useful
[21:23:31] <petan>	 some welcome templates contain headers so you must not use api that creates new section, or you get 2 headers
[21:23:37] <petan>	 that was bug in older version
[21:26:22] <petan>	 mynameisnotdave: https://etherpad.wikimedia.org/p/huggle_section
[21:26:55] <mynameisnotdave>	 petan: Ooh, what this?
[21:27:16] <mynameisnotdave>	 Oh oh
[21:27:18] <petan>	 multiplayer notepad heh
[21:29:50] <petan>	 mynameisnotdave: ok you see that now? :P
[21:30:18] <mynameisnotdave>	 Yes
[21:30:29] <mynameisnotdave>	 Why, that was tremendously fun
[22:30:50] <wm-bot>	 Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Yaris678 link https://en.wikipedia.org/w/index.php?diff=584123703 edit summary: /* HG3 feedback */ In terms of item 3 - more recent edits...