[09:52:25] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±3] 13http://git.io/vUgizA [09:52:26] [02huggle3-qt-lx] 07benapetr 036113bb0 - cleanup [11:46:30] 3Huggle / 3Other: php lint for wl and updater page - 10https://bugzilla.wikimedia.org/65219 (10Peter Bena) 3NEW p:3Unprio s:3normal a:3Peter Bena https://github.com/huggle/updater https://github.com/huggle/wl [11:46:44] 3Huggle / 3Other: php lint for wl and updater page - 10https://bugzilla.wikimedia.org/65219 (10Peter Bena) p:5Unprio>3Normal s:5normal>3minor a:5Peter Bena>3Addshore [11:48:42] 3Huggle / 3Other: php lint for wl and updater page - 10https://bugzilla.wikimedia.org/65219#c1 (10Addshore) 5NEW>3RES/FIX https://github.com/huggle/updater/commit/9a6ce075960262a3abf827c1580639b1ac511975 https://travis-ci.org/huggle/updater https://github.com/huggle/wl/commit/fc8134e68889199433a731af6f8... [12:08:53] addshore: so boring here at hostel meh [12:09:02] literally it's just me here now [12:10:37] you totally missed the most funny part when the teams were doing summary of what they did [12:10:52] like everyone was basically just working on huggle lol [12:16:49] really? xD [12:17:35] for everyone just working on huggle not much got done ;p [12:18:02] I guess we got i18n, RTL new buttons and new loading UI actually... and phplint [16:41:26] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/UCFPWA [16:41:27] [02huggle3-qt-lx] 07benapetr 03c306119 - foxed old tags [16:46:00] that is something like "fixed" or "focked" you know [16:46:05] :P [17:12:01] :P [17:12:25] "what does the fox-ed say?" [17:25:27] petan|hack you here? [17:40:59] hi addshore [17:41:05] hi :) [17:42:50] either they don't like your new hg2 version or IRC :) , but on dewiki's talkpage are users who are complaining about new "bugs" / abnormal behaviour [17:43:07] link? [17:43:22] never looked on that talk page... [17:43:27] https://de.wikipedia.org/wiki/Wikipedia_Diskussion:Huggle [17:43:48] section "Huggle extrem träge" and "Mehr Fehler in der Version 2.1.23" [17:45:47] from the source code afaik there wasn't much changed in this version: beside updated whitelist there were only IRC-activation and the exception handling on url-parse, right? [17:46:23] why not just "kill" HG 2 now? [17:47:30] se4598: indeed https://github.com/huggle/huggle/compare/2.1.22...2.1.23 [17:48:57] se4598: replied on de [17:51:43] btw: I haven't the same setups as them as I kill the HG-editsuffix on my client, so some action detections based on edit summary doesn't work for me [17:58:22] * se4598 is sorry that he repeatedly mention some things again and again [18:04:13] [02huggle] 07addshore tagged 038eafa9a as 032.1.19 13http://git.io/H2Wtqw [18:04:50] fjkhfas [18:05:07] se4598: I know ;p [18:06:10] addshore: for a short moment as I opened the link from the github mail it says: 2.1.19 released 8 days ago O.o [18:06:20] Now the link is 404 [18:06:21] yup, tagged the wrong revision.... [18:06:50] now the tag is "huggle"? [18:06:56] thats what it was before :P [18:07:15] im sorting out of releases and download locations [18:07:45] no, https://github.com/huggle/huggle/releases lists it: 2 years ago huggle … (subtext: Tagged 2.1.19) [18:07:51] all downloads for releases will from now be on huggle [18:08:04] hmm...when was rc2 supposed to be released again? [18:08:08] yes se4598 but the tag name is 'huggle' [18:08:12] Josve05a: for windows? [18:08:14] yep [18:08:16] :P [18:08:24] I will make rc2 once I have finished tidying all of these other releases [= [18:08:47] Yay! [18:09:19] !bug 59982 addshore do know how to "fix" this? [18:09:19] link https://bugzilla.wikimedia.org/show_bug.cgi?id=59982 [18:09:36] mhhm, it wil need some testing [18:10:21] [02huggle] 07addshore pushed 0310 commits [+1080/-0/±0] 13http://git.io/g3Vb-A [18:10:23] I'm pretty sure that my comment 6 does still make a valid point [18:10:23] [02huggle] 07adamshorland@gmail.com 03e924cc3 - create huggle tag folder [18:10:24] [02huggle] 07adamshorland@gmail.com 03e452b5f - move tags to new folder [18:10:25] [02huggle] 07adamshorland@gmail.com 0327ae1ea - tag (with lang fixes) [18:10:26] [02huggle] ... and 7 more commits. [18:10:33] I am afraid to use HG 3 until it is "fixed! [18:12:18] now it's tagged 2.1.19^^ [18:12:56] I don't understand: tags have folders? [18:17:46] ? [18:17:53] tags have folders? [18:18:03] oh, ignore the commits [18:18:05] :P [18:18:41] and why are they dated back to Oct 2011? O.o [18:19:04] and the git.io is also half-invalid... wtf [18:19:48] :P [18:20:15] right, the tags are correct now [18:20:24] but we are still missing lots of released version in tags :P [18:21:17] 0.8.1 is 6 years ago :P [18:21:30] addshore: what about all beta releases of HG3? xD [18:21:45] we are just tagging the RCs now :) [18:21:49] the others dont count ; [18:21:50] ;p [18:22:35] right, building the new RC now then [18:22:41] poping out for a few mins but will be back [18:48:55] [02huggle3-qt-lx] 07addshore tagged 03c306119 as 033.0.0rc2 13http://git.io/7REvZA [18:48:56] [02huggle3-qt-lx] 07addshore tagged 031a590ce as 033.0.0rc1 13http://git.io/WB00IQ [18:59:43] im so confused with the rc right now... [19:02:45] ffs [19:02:49] will wait for petrb... [19:03:37] [travis-ci] huggle/huggle3-qt-lx#878 (3.0.0rc1 - 1a590ce : Petr Bena): The build passed. [19:03:37] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/3.0.0rc1 [19:03:37] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/25002083 [19:04:09] [travis-ci] huggle/huggle3-qt-lx#877 (3.0.0rc2 - c306119 : Petr Bena): The build passed. [19:04:09] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/3.0.0rc2 [19:04:09] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/25002080 [19:06:07] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c39 (10Excirial) I see the same warning level issue in RC1: - https://en.wikipedia.org/wiki/User_talk:50.203.89.169 (Level 1 where a level 4 should be placed) - https://en.wikipedia.org/wik... [19:06:08] travis-ci, I never know whether you post that a build has (not) passed... [19:06:34] se4598: you have rc1 for windows right? [19:06:43] addshore: Whats confusing about the RC? [19:07:14] addshore: no, I build and run via Qt creator and haven't a standalone [19:07:26] okay :P [19:07:38] Excirial: cant get the build number to do the right thing ;p [19:08:43] I suggest +1 every time you press build. ;) [19:08:53] What do you have wanted? [19:09:28] heh, its not that, well, the version on the login for should jut contain 3.0.0rc2 but instead still contains much of the hash [19:10:01] addshore: look at version.txt and configure-scripts who output that hased [19:10:08] *hashes [19:10:17] yee [19:11:13] Hmm. I found a terrible bug in RC1 just now. [19:11:20] Excirial: what is it? :P [19:11:44] The "Addshore" and "Gurch" hyperlinks on the about screen don't work. :P [19:11:50] lol :p [19:12:36] addshore: update.sh for unix and configure.ps1, they use "git describe --always" [19:15:37] addshore: my current head is Release_3.0.0.0rc2-56-gc306119 [19:16:25] grgh configsure make my version build: 1359 c306119 even with the tag checkedout [19:17:56] you're right, running configure.ps1 gives me: "c306119a6303b1728f9c6156d66868d56c6c6890" [19:18:14] so what was it I was meant to run? xD [19:19:10] but if I run git describe --always manually in git-console I get "Release_3.0.0.0rc2-56-gc306119" [19:19:21] $hash = git describe --always [19:19:47] I dont ... [19:19:51] wrong IF branch :P [19:20:17] i dont understand what is happening :P [19:20:58] addshore: Do you have git on your path-var? [19:21:22] I will try to add it manually for me and then run again and look [19:23:42] rc1 has a smaller string for its version... [19:24:32] Huggle 3 QT [3.0.0.0 build:1282 Release_3.0.0.0rc1 Production] [19:25:35] oh petan|hack is here [19:26:00] I tried to ping im an hour ago, he didn't respond to me... :'( [19:26:05] him* [19:26:09] oh :P [19:27:16] addshore: on windows, I had added git to path in powershell I now get the normal "build: 1359 Release_3.0.0.0rc2-56-gc306119" in version.txt [19:27:40] is -56-gc306119 meant to be there? [19:28:38] thats 56 commits after tag and the gc is the actual rev I assume [19:28:58] lemme check out tag [19:29:12] 56 commits after the rc tag? [19:29:17] se4598: your on the wrong tag [19:29:26] Release_3.0.0.0rc2 is what we didnt actually release [19:29:31] see tag 3.0.0rc2 [19:29:35] do a pull [19:30:09] on rc2-tag checkout I get "build: 1303 Release_3.0.0.0rc2" [19:30:41] seems pretty close to your in-app "Huggle 3 QT [3.0.0.0 build:1282 Release_3.0.0.0rc1 Production]" [19:30:42] but Release_3.0.0.0rc2 is nowhere [19:30:59] I changed the namming convention for the tag [19:31:02] tags [19:35:19] That confuses me: smartgit shows your new "3.0.0rc2" but git console not [19:35:50] git pull --tags [19:36:27] right i dont understand this at all [19:36:41] >git pull --tags [19:36:41] Current branch develop is up to date. [19:36:41] >git describe [19:36:41] Release_3.0.0.0rc2-56-gc306119 [19:37:08] that git describe is tjust all wrong [19:37:15] thats still describing the wrong tag [19:37:39] > git describe --tags [19:37:46] 3.0.0rc2 [19:37:58] ........ [19:38:04] hmm. were these tags I made meant to be 'annotated' [19:38:49] that would I ask next, they seem not to be annotated according to reading behaviour in docs [19:39:13] reading behaviour in docs? [19:40:00] did you "git tag -a"? [19:40:10] no >.> [19:40:11] ffs [19:40:29] currently reading http://git-scm.com/book/en/Git-Basics-Tagging [19:41:21] I dislike the way we generate this version number :p [19:42:32] just add "--tags" in the configure script? [19:43:48] so it does git describe --always [19:44:34] git describe --always --tags [19:44:48] but then checkout master and it still has 3.0.0rc2 [19:44:52] should do it correctly with your lightweight tags [19:45:03] which seems odd :P [19:45:29] might have to expand the script a bit more, i guess for tags we want tags and for branches we want the hash [19:45:50] build: 1359 3.0.0rc2 [19:46:17] well build is just the rev count [19:46:27] rev count - tagname - hash might be nice [19:46:35] or [19:46:42] build: 1360 3.0.0rc2-1-gd2b187f with one commit more [19:47:02] tagname/branch - build - hash [19:48:03] If you have the tag, why would you need the hash? [19:48:24] oh soory nevermid [19:48:54] blergh [19:49:18] [02huggle3-qt-lx] 07se4598 pushed 031 commit to 03master [+0/-0/±2] 13http://git.io/gCIN4w [19:49:19] [02huggle3-qt-lx] 07se4598 03d2b187f - also consider lightweight tags [19:50:48] build: 1360 3.0.0rc2-1-gd2b187f [19:51:03] yep, one commit after the tag [19:51:07] so, is that what we are going with? :P [19:51:11] looks good :P [19:51:17] *rebuilds everything* [19:52:22] * se4598 changes version.txt back to "se4598" [19:52:57] se4598? xD [19:52:58] lol [19:54:28] better than having some outdated hash written to huggle3.css :D [19:54:37] right, i should actually be able to upload rc2 in a sec then :P [19:55:01] se4598: you seen the new buttons then? :P [19:55:29] which new buttons? [19:55:39] i guess not :P [19:55:47] not build master since the weekend? :P [19:56:22] a that new buttons you're talking about: I don't like them but if you break with hg2, then completly, right? [19:56:44] if you break with hg2, then completly, right? ?? [19:58:09] a mistranslated saying :P [19:58:44] guess I have to take some english lessons again before Wikimania [19:59:09] :P [20:03:19] lo, just built it but I have debug output ;p [20:03:22] go me! [20:04:02] what's wrong? [20:04:22] debug level get's set by command line args, not? [20:04:53] true, I forgot that ;p [20:05:02] urgh, still sleepy after the weened ;P [20:05:06] time to make the installer then! [20:06:15] I always have this notices on startup: [20:06:15] QEventLoop: Cannot be used without QApplication [20:06:15] QObject::connect: Cannot connect (null)::aboutToQuit() to QNativeWifiEngine::closeHandle() [20:06:15] OpenType support missing for script 19 [20:06:15] OpenType support missing for script 15 [20:06:26] hmmm [20:06:35] will take a look once I have uploaded the rc installer [20:07:25] uploading now [20:07:38] Josve05a: ^^ [20:09:09] yay!!! [20:09:25] its 25% uploaded ;p apparently my internet is nice and slow [20:09:52] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982 (10gladjonatan) s:5minor>3normal [20:10:33] mhhhm bugzilla [20:10:43] feels odd it not being on github :P [20:10:48] addshore: thats full console output from qt creator until login form: http://pastebin.com/raw.php?i=rX2BBjSh [20:11:23] https://github.com/huggle/huggle3-qt-lx/issues/42 ^^^^ needs to be fixed until I use Huggle anomre...so I wait for rc3... [20:12:00] hmm se4598 mine does that too, but without the numbers [20:13:08] I'm more curious about the first two lines [20:15:15] ahh, I dont have those! [20:16:24] Josve05a: rc2 is at https://github.com/huggle/huggle3-qt-lx/releases/tag/3.0.0rc2 [20:18:02] addshore: ^^^^ needs to be fixed until I use Huggle anomre...so I wait for rc3... [20:18:04] :P [20:18:10] oh :< [20:18:38] you probably want to test that bug if you're system language is not english [20:18:51] *when (fits better) [20:42:42] [02huggle3-qt-lx] 07addshore pushed 031 commit to 03master [+0/-0/±3] 13http://git.io/LR3R3Q [20:42:43] [02huggle3-qt-lx] 07addshore 0324031e9 - Disable login button if incomplete details [20:44:15] what a great new feature :D [20:46:55] [02huggle3-qt-lx] 07addshore pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/EcF_JQ [20:46:56] [02huggle3-qt-lx] 07addshore 03979882b - Use Q_UNUSED() in login.cpp [20:47:33] you broke the "Developer Mode" login unless you type a pw :P [20:47:45] haha lol true [20:48:10] I could fix that? :P [20:48:17] meh [20:48:54] it's a IMMEDIATE BLOCKER xD [20:50:20] that now additional typed char in the pw-field will kill people!!1!!11 [20:50:28] :P [20:51:04] done [20:51:06] [02huggle3-qt-lx] 07addshore pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/BwOq_Q [20:51:09] [02huggle3-qt-lx] 07addshore 037b42fe0 - Continue allowing 'Developer mode' [20:52:18] cool, a spell-check for "Developer Mode" [20:53:01] mh, I wonder when the next l10n update from twn comes [20:54:30] haha [20:54:43] daily / nightly? [20:57:12] maybe external like github irregular? or not daily b/c just added on hackathon, who knows? (siebrand knows) [21:17:15] addshore: what about creating about a "portable" build, so that all relevant config files etc in the same directory and not somewhere buried in AppData? [21:17:46] might be able to [21:17:58] ("portable build" can also mean a cmd line arg) [21:25:53] yum, just got the new version of QT creator [21:25:58] *goes to look at the changelog* [21:28:37] how do you create with them a standalone exe? some secret script? [21:42:13] [02huggle3-qt-lx] 07addshore pushed 031 commit to 03master [+0/-0/±2] 13http://git.io/tfhDWw [21:42:14] [02huggle3-qt-lx] 07addshore 03e4492f7 - Rename login labels [21:42:28] se4598: you mean an installer exe or standalone? [21:43:59] standalone as in "have everything to run in the folder" like installer does [21:44:31] no need to pack them all in one exe [21:44:43] (currently at least :P) [21:46:08] i dont follow :P [21:46:10] re commit: that's a good change, renaming a lot of used ui-objects to meaningful names [21:46:18] the standalone exe doesnt work unless you have the QT sdk installed [21:46:38] the installer bring the bit of QT you need with it [21:46:59] that's what i need, what does the installer ship? [21:47:21] it lists what it installs if you install with it (click show details) [21:49:23] yeah, I could install it and then use the files from there but thats a dirty hack I think [21:50:21] :P [21:52:24] se4598: this should help you http://pastebin.com/Eia4RL5w [21:52:26] do you know WHY you can use brackets in the localize-key? [21:52:55] I don't get the intention behind it [21:53:57] which brackets? [21:55:56] https://github.com/huggle/huggle3-qt-lx/commit/741dc9cd87ff1aeb5ec5e1e309b6a7b788da13c6 [21:56:14] the ones I removed in login.cpp [21:56:38] I don't see that there would be a reason to use them [21:57:16] probably there is none [21:58:13] btw thanks for the log [22:00:01] * se4598 discovers there is a folder called windows with a Huggle.nsi in it. crazy! [22:00:19] * se4598 never saw it before [22:09:17] haha se4598_2 [22:09:32] not sure about our localisation, not actually looked at that bit of the code at all yet [22:09:50] brackets could be a legacy thing left over from HG2 [22:10:31] HG2 was coded in C++? [22:10:31] ;) [22:11:25] vb.net [22:11:40] dont think we ever made a release in c# [22:11:42] I also have to look at the code how to handle parameters. Hadn't time yet [22:13:45] but now i'm lying in bed, so why not now? just a "quick" look. [22:18:02] night :D