[01:35:28] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Lowercase sigmabot III link https://en.wikipedia.org/w/index.php?diff=608310878 edit summary: Archiving 1 discussion(s) to [[Wikipedia:Huggle/Feedback/Archive 18]]) (bot [01:35:31] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback/Archive 18 was modified, changed by Lowercase sigmabot III link https://en.wikipedia.org/w/index.php?diff=608310886 edit summary: Archiving 1 discussion(s) from [[Wikipedia:Huggle/Feedback]]) (bot [09:13:05] petan|hack: ? :P [09:16:50] petan|hack: why you no on irc [10:00:49] Change on 12en_wikipedia a page Wikipedia:Huggle/Huggle3 Beta was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=608357048 edit summary: /* Windows */ up [11:34:07] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c40 (10Peter Bena) I will create a unit test for these but I am pretty sure this was already fixed long time ago, it's just that you are not running latest version [11:59:13] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/9c7G-w [11:59:14] [02huggle3-qt-lx] 07benapetr 03b5a2fb5 - default login screen should not be oauth [12:02:21] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±2] 13http://git.io/nB0pDA [12:02:22] [02huggle3-qt-lx] 07benapetr 03264efd2 - renamed the function on_ functions are special autoconnecting functions that needs to match relevant ui component if they don't, qt internal reflection mechanisms will fail to produce the code for connect and instead build a warning message into binary which you can see in terminal [12:08:03] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±2] 13http://git.io/2uEKkQ [12:08:04] [02huggle3-qt-lx] 07benapetr 0302770de - fixes there was a label that wasn't matching its autoconnect function, also I fixed some code in your functions to be more effective and conform to our "CodingStyle" :P [12:12:21] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c41 (10Excirial) (In reply to Peter Bena from comment #40) > I will create a unit test for these but I am pretty sure this was already > fixed long time ago, it's just that you are not runn... [12:28:13] . [12:28:41] :P [12:29:24] translate wiki is a weekly update [12:29:26] once a week [12:29:45] they do it by hand :P [12:29:50] so siebrand will push it [12:54:21] addshore: isn't there some kind of review system so that we could keep a track of commits that nobody looked at / audited other than typing +2 to every commit in a comment? :D [12:54:40] because that is like the only way to make it visible that someone actually reviewed the commit [12:55:20] not really [12:55:30] google code has that [12:55:39] there are +1 -1 buttons in every single commit [12:55:53] so that you can see how many other developers approve / decline that change [13:20:26] Change on 12en_wikipedia a page Wikipedia:Huggle/Config was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=608377348 edit summary: /* Warning */ delete [13:21:35] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+5/-0/±3] 13http://git.io/MFljcg [13:21:37] [02huggle3-qt-lx] 07benapetr 035e8c28e - created unit tests [13:23:21] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c42 (10Peter Bena) I made a test for every single of these talk pages and all passed, so please update your huggle, it works. [13:23:36] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c43 (10Peter Bena) I am on rc2 [13:36:27] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/a9GIUA [13:36:29] [02huggle3-qt-lx] 07benapetr 037dc337d - changed the default preferences tab to proper one [13:49:35] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/UIWqrA [13:49:37] [02huggle3-qt-lx] 07benapetr 033ad1ea4 - split some extra long lines [14:00:20] !translate is https://translatewiki.net/w/i.php?title=Special:Translate&group=out-huggle&language=qqq&filter=!translated&action=translate [14:00:20] Key was added [14:00:51] addshore, se4598_2, ToAruShiroiNeko, petan: this is needed to be done ^ [14:00:55] :o [14:01:25] hmm? [14:01:48] it's a description for every localization string so that people who localize huggle know what they are wokring on [14:01:55] yee the QQQ :) [14:02:19] I found it extremely hard to navigate through that as translate wiki doesn't show the original key [14:03:09] :P [14:03:32] nah, it does [14:03:38] we just call them stupid XD [14:03:47] heh [14:05:30] lol [14:05:33] we will have to fix them sometime [14:09:55] petan are you here? [14:13:22] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c44 (10gladjonatan) Still a bug in rc2. See: https://en.wikipedia.org/w/index.php?title=User_talk:173.73.16.15&diff=608383593&oldid=608381602 and https://en.wikipedia.org/w/index.php?tit... [14:20:35] Josve05a: no [14:20:37] :P [14:21:04] ok, I will come back later :P [14:22:49] what u need [14:23:44] I just wanted to let you know about 59982 (above), that the warnings is still wrong in rc2, and thought I could post in IRC instead of bz, since it so cluttered there... [14:29:44] addshore: there is 12 unit tests for that function and it still fail sometimes :D there must be something wrong lol [14:30:08] I am going to add more unit tests... [14:39:35] Josve05a: what version of huggle you have? [14:40:09] because I just made a unit test on the EXACTLY SAME talk page as you now reported and it parsed it as level 2 warning (Assuming you triggered it yesterday) [14:40:39] Huggle 3 QT [3.0.0.0 build: 1360 3.0.0rc2-1-gd2b187f] [14:41:03] the last comment is from today [14:41:36] try using the same user_config as me...if there is any differences between us... [14:42:06] this has nothing to do with user config [14:42:13] only with project config [14:42:41] ok...I'm just...'thinking'...I have no idea about...stuff. I just report them. [14:42:49] mhm [14:43:45] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+1/-0/±2] 13http://git.io/hYRtqA [14:43:47] [02huggle3-qt-lx] 07benapetr 03ceae2c3 - more unit tests for more fun [14:45:17] ok at least 1 failed :P [14:52:05] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±2] 13http://git.io/bDe7Hg [14:52:06] [02huggle3-qt-lx] 07benapetr 03a26f4dd - rather big unit test, though it passes just fine [14:52:46] should I find some more edits, that you can do unit tests on? [14:53:25] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+1/-0/±0] 13http://git.io/L46ChA [14:53:26] [02huggle3-qt-lx] 07benapetr 0337cb9e4 - follow up a26f4dd [14:55:21] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c45 (10Peter Bena) I can't reproduce it, both unit tests are just fine. Can you find some errors in logs? Something like "unable to retrieve talk page of bla bla" or something like that. [15:05:46] petan How about this: https://en.wikipedia.org/wiki/User_talk:207.250.60.193 [15:06:38] howcome MY huggle saw it as correct level and YOUR not [15:06:46] that must some problem related to windows :/ [15:06:52] so bad we can't run travis for windows [15:07:18] I'm posting logs now [15:08:07] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c46 (10gladjonatan) Created attachment 15367 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15367&action=edit System logs for Comment 46 [15:08:50] [travis-ci] huggle/huggle3-qt-lx#891 (master - a26f4dd : Petr Bena): The build has errored. [15:08:50] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/ceae2c307491...a26f4dd5c503 [15:08:50] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/25075496 [15:09:07] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c47 (10gladjonatan) In rc2 on Windows 7. https://en.wikipedia.org/w/index.php?title=User_talk%3A207.250.60.193&diff=608392913&oldid=608392366 Added lvl 1, should have added a lvl 3 [15:13:37] petan (Me being stupid again...) Could it have something to do with 'DEBUG[1]: Expired 70.112.37.247 reparsing it now' ? [15:14:03] that is correct [15:14:17] that just mean a talkpage was too old and that it reparsed it from fresh one [15:14:33] which is a workaround for mediawiki bug [15:15:01] ok ... me in the shame corner...again [15:15:08] why [15:15:26] I'm being stupid... [15:15:34] o.O [15:15:58] Asking stupid question which has nothing to do with the bug... [15:23:14] One thing it sure...it was fine before rc1 [15:23:40] petan https://en.wikipedia.org/wiki/User_talk:67.128.203.3 wtf? [15:34:37] Josve05a: but... we didn't change anything since then in this [15:35:38] I am unable to run this unit test on windows, it doesn't want to start [15:36:22] "it doesn't want to start"? Show the stupid computer who is boss! [15:37:07] well it like... crashes, so nope [15:37:20] ASSERT failure in QList::at: "index out of range", file ..\..\..\..\..\..\libs\qt\5.1.1\mingw48_32\include/QtCore/qlist.h, line 452 [15:37:21] This application has requested the Runtime to terminate it in an unusual way. [15:37:22] Please contact the application's support team for more information. [15:37:33] where is the huggle support team? [15:37:35] :P [15:37:52] Welcom to Huggle's support team, how may we help you? [15:37:59] fix it [15:38:10] Have you tried to reboot your computer? [15:38:15] rebooting* [15:38:46] (I ment restarting....) [15:47:22] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c48 (10gladjonatan) In rc2 using Windows 7. - https://en.wikipedia.org/w/index.php?title=User_talk:67.128.203.3&diff=608395745&oldid=608395527 (added a lvl 1, should have been a 1vl 4) -... [15:47:38] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982 (10gladjonatan) [15:48:07] 3Huggle / 3Application: Adding level 2 warning, even if level 2 warning exists - 10https://bugzilla.wikimedia.org/59982#c49 (10gladjonatan) Created attachment 15370 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15370&action=edit System logs for Comment 48 [15:49:03] On EVERY talk page were another warning has been given within the last 5 days HG adds a lvl 1 warning. [16:04:31] but... [16:04:36] did you see my contributions? [16:04:41] I am using latest huggle as well [16:05:22] (cur | prev) 15:03, 13 May 2014‎ Petrb (talk | contribs)‎ . . (3,047 bytes) (+452)‎ . . (Level 4 warning re. Acrophobia (HG 3)) (undo) [16:05:24] (cur | prev) 15:02, 13 May 2014‎ Petrb (talk | contribs)‎ . . (2,595 bytes) (+532)‎ . . (Level 3 warning re. Acrophobia (HG 3)) (undo) [16:05:24] (cur | prev) 15:02, 13 May 2014‎ Josve05a (talk | contribs)‎ . . (2,063 bytes) (+966)‎ . . (Level 2 warning re. Acrophobia (HG 3)) (undo | thank) [16:05:26] (cur | prev) 15:01, 13 May 2014‎ Josve05a (talk | contribs)‎ . . (1,097 bytes) (+1,097)‎ . . (Message re. Acrophobia (HG 3)) (thank) [16:05:54] if it's a bug it must be only on windows [16:07:02] addshore: can you confirm it's happening there? [16:08:59] Excirial seems to have the same problem [16:20:30] I have a solution to your Windows-problem petan! Borrow your neighbors computer! 49.27% are using Windows 7. [16:20:37] :P [17:07:45] addshore is using windows too [17:11:57] well addshore seems to be afk [17:17:35] Change on 12en_wikipedia a page Wikipedia:Huggle was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=608412957 edit summary: new release [17:27:21] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/nIfomQ [17:27:23] [02huggle3-qt-lx] 07benapetr 036d71d65 - dropped a release version from definitions [18:20:25] Hmm. RC2 sure looks... different. [18:29:35] petan: I've upgraded to RC2 earlier today, but it seems the warning levels are still incorrect. :/ [18:29:48] https://en.wikipedia.org/wiki/User_talk:38.96.243.39 - Level 1 where a level 2 should be placed. [18:30:02] https://en.wikipedia.org/wiki/User_talk:75.151.176.33 - Level 1 where a level 2 should be placed. [18:30:09] Apperaently it's only on Windows according to petan [18:31:30] ... It seems that i am a tad late to the draw. I only just noticed the massive expansion of the related bug report. [18:40:04] !bug 59982 Excirial do you mean [18:40:05] link https://bugzilla.wikimedia.org/show_bug.cgi?id=59982 [18:40:45] Josve05a: Yep, thats the one i meant. [18:42:16] just keep expanding it, so that petan get forced to run more unit tests :P [19:20:33] petan is it ok to downgrade Huggle to "befode rc*"? [19:25:33] I don't care [19:25:50] it won't...break anything? [19:26:06] no [19:28:18] Change on 12en_wikipedia a page Wikipedia:Huggle3 was created, changed by Josve05a link https://en.wikipedia.org/w/index.php?title=Wikipedia%3aHuggle3 edit summary: [[WP:AES|←]]Redirected page to [[Wikipedia:Huggle/Huggle3 Beta]] [19:28:23] Change on 12en_wikipedia a page Wikipedia:Huggle 3 was created, changed by Josve05a link https://en.wikipedia.org/w/index.php?title=Wikipedia%3aHuggle+3 edit summary: [[WP:AES|←]]Redirected page to [[Wikipedia:Huggle/Huggle3 Beta]] [19:28:34] Change on 12en_wikipedia a page Wikipedia:Huggle/Huggle3 Beta was modified, changed by Josve05a link https://en.wikipedia.org/w/index.php?diff=608432865 edit summary: {{shortcut|WP:HG3|WP:Huggle3|WP:HG 3|WP:Huggle 3}} [19:31:30] Josve05a: petan im here now [19:32:03] Excirial: indeed, it looks different :P [19:33:29] addshore: The grouping of buttons on the toolbar is quite neat - same for the simple to understand icons. [19:33:42] :) you like it then? :D [19:34:37] I do! But it will take me a white to click the "Revert and warn" instead of the "Back" button half of the times. ^^ [19:34:42] *While [19:34:58] haha :P Indeed! I was scared people would hate it just because it was different :) [19:35:14] but its definatly a better look than previous versions, especially if you have never used it before! [19:35:30] I like lit (very much) but as Excirial says, it will take some time to get used to it. [19:35:36] indeed :) [19:35:38] like it* [19:36:31] I had a moment at the hackathon when I was testing them and I was repeatedly clicking one button only to find out it was the delete button (when we had a different version to the one used now), and I was like, shit, please tell me I havnt just been deleting 10 / 20 articles :P [19:38:00] well? Did you delete 10/20 articles? [19:39:03] That button displays a popup window. Or er... It should have at least. :) [19:40:08] Josve05a: no :P and Excirial indeed! lucky it was actually disabled as I was on my ALT testing account :P [19:41:35] Tssk, i just noticed that the bug ratio on the about screen went up from 50% to 60% in RC2. :P [19:44:32] the bug ration? [19:44:34] ratio? [19:46:28] (Well, remember i mentioned that 2 out of 4 user links didn't work in RC1 when you click on them? Now its 3 out of 5). ;) [19:46:39] hmm, they all work for me >.> [19:46:42] let me go and try now... [19:47:07] Right clicking and copying em works a-ok though. [19:48:08] hmmm [19:48:17] the code that generates them looks fine [19:48:28] yes it's broken lol [19:48:34] I see [19:50:08] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±2] 13http://git.io/3go_Sg [19:50:08] no longer [19:50:09] [02huggle3-qt-lx] 07benapetr 03e0dffc9 - fixed broken links [19:50:28] \o/ [19:51:04] oh lol [19:51:20] so even if its a html link you need to make it open it :P [19:52:05] yes [19:52:10] that is actually GOOD [19:52:19] because you can make it open it in any way you want [19:52:39] eg. you can use the clickable links to for example execute some code instead of opening a browser [19:53:07] Axiom: Bug detection depends on the frequency a functionality is used and the impact if it does not work. Corollary: If people testing software start to report silly issues the software must be relatively bug free. [19:53:39] I suppose we are nearly ready for gold gentleman. ;) [19:54:03] !bug 59982 addshore Can you confirm this? petan can't since he doesn't have access to a working Windows-computer. [19:54:03] link https://bugzilla.wikimedia.org/show_bug.cgi?id=59982 [19:54:36] Just a Fyi - i can confirm this one on a Vista SP 2 system as well. [19:54:54] mhm [19:55:01] (On RC2 that is) [19:55:04] I really would like travis for windows [19:55:17] because on linux everything is fine and apparently only CI we have is for linux [19:55:24] so this seems to be related to windows somehow [19:55:40] I guess the parser on windows just... doesn't parse [19:56:19] hah [19:56:27] Does the parser check for linebreaks? Just a silly thought? [19:57:47] yes [19:57:53] it pretty much is all about line breaks [19:57:59] which are possibly different on windows [19:58:03] They are [19:58:35] I would expect Qt being smart enough to use some "cross-platform" line breaks [19:58:49] Windows: Carriage return + Line feed [19:59:07] If i recall correctly, linux only uses a line feed. [20:00:16] I remember some fun times debugging a regular expression because of that. Wasn't until i broke out a hex editor that i figured what the problem was... *Sighs*. Good times. [20:01:16] But i am sure it worked some time prior to RC1 [20:01:57] addshore: it could be this line in parser.cpp if (!page.contains("\n\n")) [20:02:16] not got the code open [20:02:19] I think on windows you only have '\r\n\r\n' and never '\n\n' [20:02:20] whats the point of that if? [20:02:38] it's looking for blank lines that would separate different sections / warnings [20:03:01] ahh okay [20:03:03] you know we need to split the templates by something [20:03:19] you can't really split it just by newlines because some templates are multi-line, like most of them [20:03:33] and they are mostly in same section [20:05:16] split at every {{ and every }} [20:05:32] determine whats inside them and that is a template [20:05:32] scrap everything else? [20:06:07] eh [20:06:10] there are no {{ [20:06:14] these are substituted [20:06:23] it's parser of warning templates [20:06:55] oh yeh >.> [20:07:08] dont the templates have comments in them? [20:07:16] yes they do [20:07:24] but I need to know which template which comment belongs to [20:07:39] I dont follow [20:07:51] how would you split it then [20:07:51] the comments are different for each template...? [20:07:56] yes [20:08:06] every template has own type of comments [20:08:09] so there is a direct template > comment relation [20:08:14] that's why we have zillions of them in config [20:08:27] some templates even contain multiple comments [20:08:38] I still dont see why thats an issue then :P [20:09:03] because I need to parse 2 things from every template: timestamp and something that identifies what level is that [20:09:36] in order to do that I need to have an array of these templates, where each templates has it's own level and own timestamp [20:09:38] so parse each comment, the comment should tell you the level, the timestamp should be the first timestamp you match after the comment [20:09:47] not true [20:10:03] what if you have timestamp [20:10:11] first comment would have no timestamp [20:10:25] Well, technically it would have. [20:10:33] well... I could find first