[07:18:15] se4598_2: you need to undo edits that you didn't make, as I said [07:35:40] petan: O.o, where? But thats a undo function for your own edits? [07:36:10] yes, I mean, if you have multiple edits to 1 page now, undo will remove them all [07:36:31] so if you want to test it yourself, you need to modify some page using huggle, which was modified by someone else before [07:36:36] I am going to fix that [07:38:27] I have done that, I did a speedy (w/o warning) on a new page using huggle [07:39:55] on a related note: the delete-button should be speedy for non-admins and there was the described issue with the form not closing [11:27:47] se4598_2: what issue? [11:27:54] "described issue" ?? [11:28:15] I don't know about any issue which there is no ticket for [11:29:40] there is no ticket for, it's just the comment in the log I posted: for whatever reason the speedy form didn't close after submitting, had to click on cancel to close. [11:38:17] that's correct, but cancel should be renamed to close [11:38:54] there is big chance that anything there is no ticket for will not be fixed before release, I am not reading irc logs, only bugzilla [12:16:55] se4598: can you edit some existing page on enwiki now? [12:18:11] petan: what do you mean exactly? [12:18:39] I need some page I can rollback, that mean a page with multiple edits from 2 or more people [12:18:47] for example, edit [[User:Petrb]] [12:21:33] petan: done [12:21:35] :P [12:21:48] on test wiki? [12:21:52] I don't see it [12:22:06] oh, I thought you mean on enwiki [12:22:10] on [12:22:12] test wiki [12:22:23] https://test.wikipedia.org/wiki/User:Petrb [12:24:08] "...edit some existing page on enwiki..." <-- you can rollback on enwiki. unless you want your userpage with blank paragraphs in between [12:24:12] done for testwiki [12:24:54] aha true [12:24:56] my fail [12:27:02] se4598: once more [12:32:00] petan: done [12:32:08] too late :P it's already fixed [12:32:15] I figured out I can edit using IP XD [12:32:51] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03selfundo [+0/-0/±9] 13http://git.io/Gk1iew [12:32:52] [02huggle3-qt-lx] 07benapetr 03522a03c - fixed the revert query now revert only 1 revision in case we require that [12:33:16] so... undoing basically works now, but it's less smart than I want it to be [12:33:20] there is still some work to do [12:33:32] also I found some extra bugs, which are rather minor, but needs a fix too [12:34:35] btw: what is the difference between NULL and nullptr, or why are you changing it? [12:35:14] http://stackoverflow.com/questions/1282295/what-exactly-is-nullptr [12:35:17] c++11 feature [12:35:37] petan: also the undo then replace userpage with welcome doesn't function? https://github.com/huggle/huggle3-qt-lx/commit/31dfa38bea25cf8daae2c814cbfc72767993d313 https://test.wikipedia.org/w/index.php?title=User_talk:90.183.23.27&action=history [12:36:13] or clicked no [12:36:19] there are no welcome templates on test wiki [12:36:27] so it said: no welcome templates defined [12:36:31] ok [12:38:04] we should have nullptr everywhere but I don't want to spam commit, because it's low priority, so I just update it in files which I modify [12:38:28] there is little difference between NULL and nullptr so for now we don't have to replace it immediately [12:38:44] but all new code should use nullptr only [12:41:00] addshore: some review needed https://github.com/huggle/huggle3-qt-lx/pull/61 ty [12:41:31] so bad github can't count a number of lines that changed in merge request [12:41:39] but I think it's few hundreds long [12:41:50] oh lol it can [12:41:52] 646 [12:44:39] petan: indeed it can :P [12:50:34] petan: can you please update the huggle-updater repo on github? [12:51:04] yes [12:51:09] what should I update there? [12:51:53] https://github.com/huggle/updater [12:51:59] I see no changes there [12:55:00] lol addshore how is this possible https://github.com/huggle/updater/commit/bfa6c779c3884bb087a6ea20537ac11891f8a89c [12:55:21] I just pushed something to our repository from tools.huggle without having any access to repository :D [12:55:32] :O [12:55:46] it must have an ssh key or something [12:55:49] tools.huggle authored 2 minutes ago [12:55:52] :o [12:56:03] I thought it display name of person who pushed it [12:56:14] like, the person who matches the key in github [12:56:25] I don't know maybe I uploaded key there ages ago [12:56:44] hover over the question mark next to the name and it has the email attached to the commit [12:57:20] I can't copy paste it but it's some nonsense email [12:58:36] thanks tools.huggle for the update ;) [18:05:02] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03selfundo [+2/-0/±8] 13http://git.io/lGVphg [18:05:03] [02huggle3-qt-lx] 07benapetr 03e2bc1d3 - split history items and fixed [18:05:45] I knew that self-undoable history is going to be hard, but not that hard [18:06:00] almost 1000 lines :o [18:18:38] [travis-ci] huggle/huggle3-qt-lx#981 (selfundo - e2bc1d3 : Petr Bena): The build has errored. [18:18:38] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/522a03c24696...e2bc1d35ce04 [18:18:38] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/26321720 [21:00:47] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03selfundo [+0/-0/±1] 13http://git.io/Sh0zDg [21:00:48] [02huggle3-qt-lx] 07benapetr 03cd81b10 - travis phox [21:20:35] [travis-ci] huggle/huggle3-qt-lx#982 (selfundo - cd81b10 : Petr Bena): The build passed. [21:20:35] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/e2bc1d35ce04...cd81b102cb14 [21:20:35] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/26336075