[01:55:34] isitcalled huggle or Huggle? [01:55:39] (H/h) [01:59:46] 3Huggle / 3Setup: Huggle for tr.wikipedia.org - 10https://bugzilla.wikimedia.org/66334 (10Serdar Karaman) 3UNCO p:3Unprio s:3normal a:3Peter Bena Hi, Peter. We finished translation of Huggle to Turkish in translatewiki.net. And I create copies of all huggle templates(https://tr.wikipedia.org/wiki/%C3... [03:04:26] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Lowercase sigmabot III link https://en.wikipedia.org/w/index.php?diff=612027804 edit summary: Archiving 1 discussion(s) to [[Wikipedia:Huggle/Feedback/Archive 18]]) (bot [03:04:28] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback/Archive 18 was modified, changed by Lowercase sigmabot III link https://en.wikipedia.org/w/index.php?diff=612027811 edit summary: Archiving 1 discussion(s) from [[Wikipedia:Huggle/Feedback]]) (bot [05:06:34] Change on 12mediawiki a page Manual:Huggle/Installation/zh was created, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?title=Manual%3aHuggle%2fInstallation%2fzh edit summary: Created page with "安装Huggle非常简单。" [05:37:57] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was created, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?title=Manual%3aHuggle%2fKeyboard+Shortcuts%2fzh edit summary: Created page with "== 其他 ==" [05:38:28] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030475 edit summary: Created page with "* '''A''' – 查看用户讨论页 * '''N''' – 管理用户 * '''B''' – 举报用户/封禁用户" [05:38:48] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030478 edit summary: Created page with "* '''I''' – 忽略用户 * '''Ctrl + I''' – 取消忽略用户 * '''/ (?)''' - 显示用户信息" [05:41:23] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030484 edit summary: Created page with "使用键盘快捷键可以使操作更加迅速。请注意当浏览器窗口处于激活状态时快捷键不会工作。点击任何按钮可以取消浏览器窗口的激..." [05:41:31] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030487 edit summary: Created page with "== 主要快捷键 ==" [05:42:06] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030490 edit summary: Created page with "* '''Space''' – 显示下一个差异页面 * '''Q''' – 回退并警告用户 * '''R''' – 回退 * '''Y''' – 回退并自定义编辑摘要" [05:42:36] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030492 edit summary: Created page with "* '''T''' – 添加模版信息 * '''W''' – 警告 * '''Escape''' – 取消" [05:42:47] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030494 edit summary: Created page with "== 导航 ==" [05:43:22] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030496 edit summary: Created page with "* '''[''' – 后退 * ''']''' – 前进 * '''Z''' – 前一个修订版本 * '''X''' – 后一个修订版本 * '''C''' – 当前修订版本" [05:44:12] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030498 edit summary: Created page with "* '''Ctrl + Z''' – 上一个用户贡献 * '''Ctrl + X''' – 下一个用户贡献 * '''Ctrl + C''' – 最新的用户贡献 * '''D''' – 显示与当前版本的差异 *..." [05:45:34] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030500 edit summary: Created page with "* '''+''' – 创建标签 * ''' – ''' – 关闭标签 * '''Tab''' – 下一个标签 * '''Shift + Tab''' – 上一个标签" [05:45:35] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030502 edit summary: Created page with "== 页面 ==" [05:46:31] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030504 edit summary: Created page with "* '''V''' – 查看页面（这个版本） * '''Ctrl + V''' – 查看页面（最新版本） * '''E''' – 编辑页面 * '''G''' – 标记页面 * '''S''' – 标记应..." [05:46:41] Change on 12mediawiki a page Manual:Huggle/Keyboard Shortcuts/zh was modified, changed by Eland Zhou link https://www.mediawiki.org/w/index.php?diff=1030507 edit summary: Created page with "==用户==" [11:07:26] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±2] 13http://git.io/OMduXQ [11:07:27] [02huggle3-qt-lx] 07benapetr 03bf4f5c6 - replaced wiki URL function to be edit specific so that we can use different edits from different wikis in same queue [11:09:28] 3Huggle / 3Setup: Huggle for tr.wikipedia.org - 10https://bugzilla.wikimedia.org/66334#c1 (10Peter Bena) p:5Unprio>3Normal Let me set up your config files [11:17:44] 3Huggle / 3Setup: Huggle for tr.wikipedia.org - 10https://bugzilla.wikimedia.org/66334#c2 (10Peter Bena) Missing page: https://tr.wikipedia.org/wiki/Vikipedi:Huggle/Message https://tr.wikipedia.org/wiki/Vikipedi:Huggle You need to translate the messages that are on page: https://tr.wikipedia.org/wiki/Vikip... [11:56:31] 3Huggle / 3Application: Huggle for Mac: Unexpected quit after logging in - 10https://bugzilla.wikimedia.org/66304 (10Krinkle) 3NEW p:3Unprio s:3normal a:3Peter Bena 1. Downloaded, extracted and installed into Applications folder from https://helpfulhosting.net/huggle.dmg 2. Open huggle.app 3. Log i... [13:10:11] Change on 12meta_wiki a page Huggle/Config was modified, changed by Matma Rex link https://meta.wikimedia.org/w/index.php?diff=8813077 edit summary: +pl.wp (will it work when I do this?) [13:40:54] hi. huggle doesn't support flaggedrevs patrolling, only native MW patrolling, right? [13:51:46] what do i do to get one of you all to implement flaggedrevs support? :D [13:52:22] looking at the code, it's like an hour of work for someone who knows what they're doing [13:52:59] and like a day or two for me, so it'd be totally better if someone else did it [14:03:11] * se4598 thinks that MatmaRex already volunteered [14:04:44] i can trade you bugfixes/features in mediawiki core ;) [14:05:33] I would have asked you to help me get jqmigrate working on my localhost. But I found the solution right now :P [14:06:04] turns out that you have to activate js in browser/on that domain to get JS messages [14:08:30] i already fixed a typo for you! https://github.com/huggle/huggle3-qt-lx/pull/70 [14:23:58] hmm, this might be easier than it looked [14:37:32] THERE. [14:37:39] "Support for FlaggedRevs patrolling". https://github.com/huggle/huggle3-qt-lx/pull/71 [14:37:42] petan: o hi. [14:37:59] petan: i need to you merge #70 and #71. :D [14:40:12] could anybody here build the code from #71 from windows and get me the executable? i really don't feel like downloading gigabytes of qt libraries to test one patch [14:40:19] on windows* [14:40:25] travis is happy about #70, good [14:40:57] duh, my code is always flawless. :> [14:41:15] [02huggle3-qt-lx] 07benapetr pushed 032 commits to 03master [+0/-0/±4] 13http://git.io/qR3tig [14:41:16] [02huggle3-qt-lx] 07MatmaRex 03e0e4bcd - Fixed a typo: patroled → patrolled [14:41:17] [02huggle3-qt-lx] 07benapetr 03e326ce6 - Merge pull request #70 from MatmaRex/master Fixed a typo: patroled → patrolled [14:41:59] MatmaRex: install the hg-installer to get the libraries out of that install directory. [14:42:09] then i will get you an exe [14:42:32] "the hg-installer"? [14:42:51] you mean the normal release version of huggle, via windows installer? i have it already, yes :) [14:43:11] MatmaRex: https://travis-ci.org/huggle/huggle3-qt-lx/jobs/27068902 [14:43:46] I think you have to rebase your change, at least looks like [14:46:46] hmph [14:49:35] also I get a: ..\huggle\mainwindow.cpp:447:63: error: invalid conversion from 'const char*' to 'char*' [-fpermissive] (at >"patroltoken") [14:50:13] for strings we mostly also use QString [14:50:15] hm [14:50:37] yeah, i noticed, but you were using char* literals in this one place [14:50:46] so i used the same just in case, not to change anything [14:50:51] * MatmaRex adds the 'const' [14:51:17] unless you can tell me that QString is going to work there [14:51:41] i have absolutely no idea what these apis accept [14:53:35] my version of yours is now compiling.... changed header file [14:54:22] http://xkcd.com/303/ [14:54:25] (i pushed a s/char */const char */) [14:59:07] wow, is that slow to push to a new branch. [14:59:44] hmm, still failing [15:00:09] apparently i need to register the new config option in one more place [15:00:27] I didn't get your code, but did you actually insert that bool to configuration.hpp :P I guess you didn't [15:00:30] yes, in the hpp. [15:00:51] MatmaRex: I'm currently pushing my version to a new branch, but it is soooo slow [15:00:58] heh [15:01:13] i just pushed the fix, hopefully that's it [15:05:33] MatmaRex: I'm currently uploading for you an exe with that fix: https://github.com/se4598/huggle3-qt-lx/commit/9249261acfeeafa7b91b0a6dc9ad2c7d2fa8d22f [15:06:08] se4598: yay, thank you [15:06:12] But to say, I'm currently also having this annoying bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=66316 [15:08:17] se4598: how can I reproduce it? [15:08:20] when it happens to you [15:08:34] (i just reverted a few edits with 3.0.1 and got no crashes) [15:08:59] 3Huggle / 3Application: Crash on revert - 10https://bugzilla.wikimedia.org/66316#c5 (10Peter Bena) ok does it happen on every revert? [15:09:02] 3.0.1 is fine [15:09:09] petan: so far, yes [15:09:27] this problem is caused by multi threaded GC which I implemented in 3.0.2 and which works fine to me :P [15:09:35] but TBH I didn't try it on windows yet [15:09:38] yes, I though that will be it [15:10:11] ok, if that really is a problem I can fix it right now [15:10:33] petan: you may fix also this: remove logging or remove config afterwards: https://bugzilla.wikimedia.org/show_bug.cgi?id=66313 [15:10:57] that was also comming with that change of mt-GC [15:11:21] unrelated: is it possible to fill huggle's "queue" with all edits made by a given user? [15:11:44] (or recent edits, rather) [15:13:17] [02huggle3-qt-lx] 07benapetr pushed 032 commits to 03master [+0/-0/±22] 13http://git.io/h6MJJQ [15:13:18] [02huggle3-qt-lx] 07benapetr 035fb8821 - some cleanup I was sleeping and now I have no idea what I did before, but it looks just as some generic code fixes [15:13:19] [02huggle3-qt-lx] 07benapetr 03424233f - Merge branch 'master' of github.com:huggle/huggle3-qt-lx [15:23:12] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±3] 13http://git.io/N_JctQ [15:23:13] [02huggle3-qt-lx] 07benapetr 03cfaa99f - disable multithreaded GC there are some problems with it in windows, needs to fix [15:23:59] se4598: let me know if that fixed it [15:36:38] petan: compiling yours now. I compiled the exe for MatmaRex before: 41 MB size with Debug, 1,6 without. [15:40:37] petan: It didn't crash. yay! [15:42:45] goddammit, how do i disable user welcoming and make it stick [15:43:10] it keeps reverting it when dumping settings [15:43:44] 3Huggle / 3Application: Crash on revert - 10https://bugzilla.wikimedia.org/66316#c6 (10se4598) "fixed" with disabling the new multithreaded GC : https://github.com/huggle/huggle3-qt-lx/commit/cfaa99fe1507ea4c4f6983c703974c4e502be4ad [15:45:48] https://pl.wikipedia.org/w/index.php?title=Wikipedysta:Matma_Rex/huggle3.css&diff=39615003&oldid=39614750 [15:45:52] whyyyyyy [15:48:28] "welcome-on-good-edit" is currently only read from project config [15:50:52] :o [15:56:37] se4598: aww yeah, it works [15:56:39] damn, i'm good [15:57:09] thanks for the help! :D [16:09:15] so. is it possible to fill huggle's "queue" with all edits made by a given user? [16:09:54] i want to review all of the orange items here. https://pl.wikipedia.org/w/index.php?title=Specjalna:Wk%C5%82ad/217.96.115.78&offset=&limit=500&target=217.96.115.78 [16:13:20] MatmaRex: look at the options menu-> queue filter. There you see the options. Not much [16:15:22] https://github.com/huggle/huggle3-qt-lx/blob/master/huggle/hugglequeuefilter.cpp [16:18:38] yeah… [16:19:15] i guess i'd need to write a custom HuggleFeed or something? ugh… [16:21:28] i wonder if huggle would mind if i spoofed its requests with a local proxy… [16:21:31] nah, I think the filter must be only extended by a regexp to (not) match a username. [16:21:32] [02huggle3-qt-lx] 07benapetr pushed 034 commits to 03master [+0/-0/±11] 13http://git.io/rqcDFw [16:21:33] [02huggle3-qt-lx] 07MatmaRex 031e74b58 - Support for FlaggedRevs patrolling Replaces basic built-in MediaWiki patrolling. Will always only review at the most basic "accuracy level", which is what every Wikimedia wiki uses. Added 'ActionReview' to 'enum Action' to support FlaggedRevs API queries. Added config option 'PatrollingFlaggedRevs' / 'patrolling-flaggedrevs' to enable this feature, false by default. [16:21:34] [02huggle3-qt-lx] 07MatmaRex 03d0f3d1a - s/char */const char */ [16:21:35] [02huggle3-qt-lx] 07MatmaRex 0382716f8 - Register PatrollingFlaggedRevs in configuration.hpp too [16:21:36] [02huggle3-qt-lx] ... and 1 more commits. [16:21:56] se4598: but it's limited to latest 200 edits (the 200 is hardcoded) [16:22:09] petan: :D [16:22:39] se4598: and i want all unreviewed/unpatrolled edits by given user, which are not necessarily among the last 200 edits on the wiki [16:23:17] MatmaRex: is it? [16:23:25] I was thinking that 200 is in local config [16:23:31] MatmaRex: Huggle is for current edits happening, not for past edits [16:23:41] petan: "&rcshow=" + QUrl::toPercentEncoding("!bot") + "&rclimit=200"; [16:24:01] MatmaRex: there is a number of things you can do, but given you have windows... :P you could create a python extension if you were on linux and create own provider [16:24:11] ah that [16:24:12] se4598: these are current enough. [16:24:18] that is not a queue limit [16:24:25] that is a number of recent changes [16:24:54] yeah, but it limits me anyway :P [16:24:59] petan: y u no support python on windows? [16:25:10] I do, I just can't compile it :P python suck [16:25:24] I can only compile it on linux and even that with problems [16:25:39] i probably could run it in a VM [16:25:39] the header files of python are pure evil [16:25:57] they aren't just not cross-platform they are literally wrong [16:25:59] but let me try some magic first to change the responses to huggle's requests on the fly :P [16:26:02] heh [16:26:32] there is a number of things you can do, but I recommend you to create own provider for this case, it would make it easier [16:26:53] you can replace defaul primary feed provider with some that only grabs the edits of that user you need [16:27:00] i don't even really know c++ [16:27:03] Also I wonder if not a javascript app onwiki would be the best thing in that special usercase [16:27:04] and i totally don't know qt [16:27:06] ah [16:27:10] :D [16:27:32] ok I think it's pretty simple, you could also change the current provider [16:27:39] hardcode some api query that matches your need [16:27:50] replace that rcshow code [16:27:55] just don't push it to repo :D [16:28:38] (ooh...I'm feeling a 3.0.2 coming up...) [16:31:49] Josve05a: changed that and everything will coming up: https://github.com/huggle/huggle3-qt-lx/blob/master/huggle/definitions_prod.hpp#L19 [16:33:05] Yay! [16:34:59] hmph, does huggle not use system proxy settings? :( [16:36:53] hahaha....when I opened HG3 I saw this: "UPDATED! IMPORTANT NOTICE - If you are using Huggle 3, ensure you are running at least revision 1076 or newer. If you are running an older version of Huggle 3, please upgrade it. Users of Huggle 2.x.x are not affected by this." [16:46:08] I think we can remove that [16:47:12] Maybe say 3.0.1 is the latest version. Go ahead and update to it nowby using *thislink*. [16:47:52] Josve05a: https://en.wikipedia.org/wiki/Wikipedia:Huggle/Message [16:49:34] when was 3.0.1 released....wait I can llok it up [16:49:38] look* [16:51:11] Change on 12en_wikipedia a page Wikipedia:Huggle/Message was modified, changed by Josve05a link https://en.wikipedia.org/w/index.php?diff=612099427 edit summary: [16:52:27] Change on 12en_wikipedia a page Wikipedia:Huggle/Message was modified, changed by Josve05a link https://en.wikipedia.org/w/index.php?diff=612099546 edit summary: [16:53:03] Change on 12en_wikipedia a page Wikipedia:Huggle/Message was modified, changed by Josve05a link https://en.wikipedia.org/w/index.php?diff=612099612 edit summary: oops, 3.0.1 [17:01:30] petan: https://github.com/huggle/updater/commit/9c7011d262a0b6ee4f09ee209e9ca8c80dcbfda5 [17:03:46] if the updater is extended by a "notify of rc/beta" then it is super handy, too [17:06:49] MatmaRex: you need the system proxy? [17:07:24] i've already got it [17:19:10] ha. i've just tricked huggle into accepting input straight from me. [18:11:41] MatmaRex: "i don't even really know c++" [18:11:50] oi in pascal?! :o [18:12:28] or not know that good? [18:15:32] lazowik: i can read it, and write it well enough when it's just the language and STL, but when something like qt comes into picture i give up :) [18:15:58] MatmaRex: kinda strange talking with you in english :p [18:16:30] heh [18:27:28] hmmm [18:27:36] are huggle's localisation messages actually used anywhere [18:27:37] ? [18:27:46] i tried grepping for a few and they don't seem to be… e.g. "shortcutaction" [18:34:09] MatmaRex: many of them in the l10n-files are leftovers from HG2 and HG3 isn't yet fully translatable either [18:34:36] https://github.com/huggle/huggle3-qt-lx/pull/72 ~ [18:34:55] se4598: are you going to reuse them all? or should they be pruned? [18:35:25] right now they all show up on translatewiki, i wanted to do some translating, but got rather confused when i saw strings that don't appear in the UI [18:37:34] if they reasonable match I will use them, but chances are high that the original will be modified. I don't make thoughts about it know [18:38:20] MatmaRex: they is a option to use the lang qqx, also there may is a feature to load a own custom l10n file from a external directory, but I never tested it [18:38:27] *there is [18:39:03] To use qqx, start huggle with huggle.exe -v and it should appear in the list [18:39:40] my point is, at https://translatewiki.net/wiki/Special:Translate/out-huggle?filter=%21translated&action=translate there are like 500 messages and apparently like a half of them is not used [18:51:13] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±3] 13http://git.io/cxTMrw [18:51:14] [02huggle3-qt-lx] 07benapetr 03f2935e4 - wikiprovider now we can change the rc size in config so that people with slow internet can adjust it to work faster [18:52:39] MatmaRex: fix it? [18:53:02] [02huggle3-qt-lx] 07benapetr pushed 033 commits to 03master [+0/-0/±3] 13http://git.io/Y6f3QQ [18:53:03] [02huggle3-qt-lx] 07MatmaRex 031735aff - Capitalize 'Huggle' in messages [18:53:04] [02huggle3-qt-lx] 07MatmaRex 039f8163e - Capitalize 'MediaWiki' too [18:53:05] [02huggle3-qt-lx] 07benapetr 0348878c4 - Merge pull request #72 from MatmaRex/master Capitalize 'Huggle' in messages [18:53:23] petan: you saw my update on the updater? [18:53:29] sec [18:53:31] petan: that's what i'm asking :) would you be okay with it if i went and removed the unused messages? [18:53:35] updater is currently broken and down [18:53:40] it's like it needs a fix [18:53:59] for some reason it say everyone their hugge is outdated [18:55:21] [travis-ci] huggle/huggle3-qt-lx#1078 (master - f2935e4 : Petr Bena): The build has errored. [18:55:21] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/b4e6c595780a...f2935e455bb0 [18:55:21] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/27080621 [18:55:24] aha. Guess I have a new task: learn basic OO-php [18:56:16] [travis-ci] huggle/huggle3-qt-lx#1079 (master - 48878c4 : Petr Bena): The build has errored. [18:56:16] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/f2935e455bb0...48878c4af7c6 [18:56:16] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/27080682 [18:58:25] [02huggle3-qt-lx] 07benapetr pushed 032 commits to 03master [+0/-0/±2] 13http://git.io/iKxUVQ [18:58:26] [02huggle3-qt-lx] 07benapetr 032baf8fc - fix [18:58:27] [02huggle3-qt-lx] 07benapetr 034d64b68 - Merge branch 'master' of github.com:huggle/huggle3-qt-lx [18:59:07] petan: se4598: would it be okay if i removed all the unused messages? [18:59:39] NO [18:59:41] don't do that [18:59:52] people already localized some and we are going to use most of them [19:00:07] if you remove them translate wiki delete their localizations too [19:00:26] you should rather replace hardcoded messages with them :P [19:07:29] [travis-ci] huggle/huggle3-qt-lx#1080 (master - 4d64b68 : Petr Bena): The build passed. [19:07:29] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/48878c4af7c6...4d64b6880546 [19:07:29] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/27080944 [19:13:55] petan: eh, such translations probably aren't worth shit if they were done without context, without any way to check if what you wrote makes sense [19:15:38] and they can always be restored [19:15:53] hmm if we are going to use them for something that has same meaning as before [19:17:10] i'm going to get you a list of message names that don't grep in a second, either way [19:17:20] 368 of them. [19:17:43] http://pastebin.com/nkME3i6d [19:18:07] do with it what you wish :) [19:21:07] there are 631 messages in total, so that's more than a half. huh. [19:21:40] MatmaRex: some can be indeed deleted as they already replaced, other indicate missing features [19:23:20] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/UvpNeQ [19:23:21] [02huggle3-qt-lx] 07benapetr 03cf4b73d - fixes this is throwing exception as we didn't change the pointer after deleting object, so we might double delete it later [19:24:27] MatmaRex: hmm grep in windows :P [19:24:59] petan: yeah. i have mingw installed :P [19:25:44] i built a .bat file that went like: "@grep -rq "name" . || echo name" (and 600 more lines for each message) with sublime text and ran it, that's the output [19:38:26] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/WS6xgg [19:38:27] [02huggle3-qt-lx] 07benapetr 0313e56e7 - fixed wl variable init. was missing and that caused random numer being there [19:39:14] MatmaRex: you know how to localize UI? [19:39:41] just replace the string with _l("key"); and make sure #include "localization.hpp" is there in .cpp file, that's it :D [19:39:42] um. yes, i guess? i'm not sure what's the question you're asking [19:40:03] yeah, i figured this out when grepping for message names :P [19:40:03] so if you find some ui string that is hardcoded now, just fix it :P [19:40:09] nooooo [19:40:15] that'd be effort [19:40:32] yes, that is reason why HG 3 isn't localized well :P [19:41:25] it's less effort to do it right the first time 'round than to fix up later, heh [19:42:19] that isn't hard to do now also, choose qqx and look for any text that looks not like a msg-key. [19:42:38] Searching 300 files for ""[A-Z][a-z]+" (regex, case sensitive) [19:42:47] 978 matches across 120 files [19:43:04] (tons of false positives, but probably a hundred of so messages) [19:43:14] most of the hardcoded text is hidden in the *.ui files [19:43:43] there's no shortage in .cpp files as well :P [19:45:18] how would you even localise the ones in .ui files? [19:45:19] exclude Configuration.cpp /hpp [19:47:13] ui is localized via endless "this->ui->labelProject->setText(_l("login-project"));" calls [19:47:40] where you're happy that "labelProject" is a meaningfull name [19:48:00] eeeek [19:48:16] * MatmaRex hides [19:53:01] petan: can I kill it or do you fix it: https://github.com/huggle/huggle3-qt-lx/blob/master/huggle/core.cpp#L379 (the SIGSEGV) [20:18:14] se4598? [20:18:18] where is sigsegv [20:19:03] petan: https://bugzilla.wikimedia.org/show_bug.cgi?id=66313 [20:19:53] howcome it works to me o.O [20:21:30] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/cZaUpw [20:21:31] [02huggle3-qt-lx] 07benapetr 03812d40a - delete conf as last [20:21:44] 3Huggle / 3Application: segfault on shutdown: Logging after HuggleConfiguration was deleted - 10https://bugzilla.wikimedia.org/66313 (10Peter Bena) 5NEW>3RESO/FIX [20:21:44] meh linux kernel XD [20:21:52] it's getting worse [20:21:55] It doesn't _always_ crash, only if I debug it everytime [20:22:01] aha [20:30:14] Change on 12en_wikipedia a page Wikipedia:Huggle was modified, changed by Artichoker link https://en.wikipedia.org/w/index.php?diff=612123614 edit summary: wikilink and capitalize [[.NET]] [20:31:21] Change on 12en_wikipedia a page Wikipedia:Huggle/Message was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=612123751 edit summary: removed hard coded huggle version [20:47:24] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±4] 13http://git.io/dzQSAQ [20:47:25] [02huggle3-qt-lx] 07benapetr 0351514e8 - improved GC and fixed some memory leaks so that we can track the memory a little bit more [20:52:35] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±2] 13http://git.io/WlnmkA [20:52:36] [02huggle3-qt-lx] 07benapetr 036275a8c - memory leak in query pool bug fix we didn't remove a reference to list items in pool [20:58:43] petan: can I rewrite the updater if necessary without breaking too much? aka change xml-tagnames or so. When you currently do die() i think it's maybe ok. [20:59:00] eh [20:59:15] if it's going to be compatible with 3.0.0 huggle then it's ok [21:00:12] meh, ok, I try [21:01:53] @unjb Alchimista [21:02:00] I totaly forgot this guy [21:02:13] I need to implement some timer heh [21:10:19] petan: I don't get your "include" system on the updater: " $file = "includes/" . $c->client_os . "_" . $c->client_version . ".xml"; " [21:10:37] Is it update FROM a specific version or TO a specific version? [21:10:41] that's some code :D [21:10:55] it's update from a specific version [21:11:02] it's always TO last version [21:11:52] so that in case we introduce some extra files in version 3.0.2 people who have older huggle get these files as well, but people who have them already don't [21:12:37] you should always tell the updater what version you have and updater should reply with a list of commands that need to be done to upgrade [21:13:19] like "I am on windows with huggle 3.0.0, tell me what should I do?" updater respond: "shoot yourself" or eventually something more useful [21:13:42] ok [21:13:45] in best scenario it tell you "download huggle.exe from this location and replace yourself with it" [21:14:13] which isn't that simple because it requires admin rights in most cases and also it's not easy to replace file that is being executed [21:28:01] se4598: keep in mind that updater is only good for windows and mac [21:28:15] on ubuntu / debian huggle is maintained by package manager [21:28:56] so probably there should be extra .exe file for windows that would handle the upgrade (huggle should launch it as privileged user and let it upgrade itself) [22:26:56] [02huggle3-qt-lx] 07se4598 deleted branch 03feature/dropDownButtons [23:31:17] Change on 12meta_wiki a page Huggle/Changes was modified, changed by Se4598 link https://meta.wikimedia.org/w/index.php?diff=8818094 edit summary: /* Changes in 3.0.1 */ summary