[04:45:25] Hey [05:03:40] How do I get huggle to run after it installs? [06:10:52] !ping [06:10:52] poing [07:18:43] 3Huggle / 3Application: Huggle replaces Unicode-characters with garbage - 10https://bugzilla.wikimedia.org/66856#c2 (10Peter Bena) p:5Unprio>3Normal is that SR? [07:19:43] 3Huggle / 3Application: Huggle replaces Unicode-characters with garbage - 10https://bugzilla.wikimedia.org/66856#c3 (10Peter Bena) of course it is, otherwise it would be mw bug... [07:23:13] 3Huggle / 3Application: Huggle replaces Unicode-characters with garbage - 10https://bugzilla.wikimedia.org/66856#c4 (10Peter Bena) https://github.com/huggle/huggle3-qt-lx/blob/master/huggle/generic.cpp QString Generic::EvaluateWikiPageContents is what is responsible for parsing the output of MW api that con... [07:31:59] 3Huggle / 3Application: Huggle replaces Unicode-characters with garbage - 10https://bugzilla.wikimedia.org/66856#c5 (10Peter Bena) Question is: does huggle read the string malformed, or does it write it malformed? [08:58:31] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±3] 13http://git.io/GTeNhg [08:58:31] [02huggle3-qt-lx] 07benapetr 03ad4f598 - revert only last edit feature in menu [10:04:46] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±1] 13http://git.io/OOJB3w [10:04:47] [02huggle3-qt-lx] 07benapetr 037cb6f4c - relogin disabled in developer mode [14:09:30] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+1/-0/±8] 13http://git.io/vN20vQ [14:09:31] [02huggle3-qt-lx] 07benapetr 03768d4a2 - shortcuts can be now changed by user [14:10:14] 3Huggle / 3Application: improve keyboard shortcuts - 10https://bugzilla.wikimedia.org/34632#c1 (10Peter Bena) 5NEW>3PATC http://git.io/vN20vQ [14:15:55] se4598: here? [14:16:07] yep [14:16:08] se4598: how do I access these new items you made [14:16:12] I mean in buttons [14:16:14] dropdown [14:16:17] for what do you need them? [14:16:29] I need to access QAction pointer of each of them [14:16:34] preferably index based [14:16:46] most of the thing you could do, you can also do on the action [14:16:48] eg. "get me pointer of 2nd item in warn list" [14:17:03] pointer to QAction I mean [14:17:19] the Actions are still in some objec-vars [14:17:33] ok so how do I access them? [14:17:38] in the fashion I just described [14:19:44] this->RevertWarn, this->WarnMenu, this->RevertSummaries for the menus, this->ui->actionWarn ......... for the actions [14:19:58] I haven't changed that [14:21:12] ok, but I need a pointer to Nth item in submenu of these actions [14:21:20] eg. "Spam" [14:21:26] or "Editing tests" [14:21:37] not to parents [14:21:48] I think the code needs a fix [14:22:12] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±3] 13http://git.io/y475zA [14:22:13] [02huggle3-qt-lx] 07benapetr 039a9d12a - 2 more shortcuts [14:23:31] petan: QMenu has QMenu::actionAt(const QPoint & pt), but QPoint is a 2-dimensional point..... [14:23:46] I will fix [14:23:47] sec [14:24:31] petan: just use Configuration::HuggleConfiguration->ProjectConfig->WarningTypes.at(r) [14:24:41] that isn't going to work [14:24:45] they are in the order you added them [14:24:46] I need pointer to action not string [14:24:51] mh [14:25:04] for what you need it? [14:25:39] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±2] 13http://git.io/CwUVEA [14:25:40] [02huggle3-qt-lx] 07benapetr 038023823 - keep track of items we add to menus [14:25:47] to make it possible for user to define shortcut for these items [14:26:03] this commit implements 3 new arrays that contain these pointers [14:26:51] ok, but don't you need to create the lists first? [14:27:39] I just did [14:33:29] [travis-ci] huggle/huggle3-qt-lx#1193 (shortcut - 9a9d12a : Petr Bena): The build has errored. [14:33:29] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/768d4a23da25...9a9d12a5bccf [14:33:29] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/28047118 [14:37:04] [travis-ci] huggle/huggle3-qt-lx#1194 (shortcut - 8023823 : Petr Bena): The build has errored. [14:37:04] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/9a9d12a5bccf...8023823382ec [14:37:04] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/28047435 [14:46:02] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±4] 13http://git.io/pHpA7g [14:46:03] [02huggle3-qt-lx] 07benapetr 032e8f315 - new shortcuts [14:46:05] se4598: ^ [14:46:13] now it's possible to create shortcuts for these items too :P [14:46:31] it's a evil hack but... :P [14:47:27] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/HFBH1A [14:47:28] [02huggle3-qt-lx] 07benapetr 03546b804 - these are wrong [14:47:31] um, fixed [14:48:38] I didn't see yet that you create/delete this->RevertAndWarnItems and other two before appending them. [14:48:49] *appending on them [14:48:58] it works :D [14:48:59] yay [14:49:33] hm, really? :) [14:49:50] yes [14:49:52] I just tested [14:49:56] ok [14:49:59] 3Huggle / 3Application: Feature request: hotkey for Revert&Warn(Advanced) - 10https://bugzilla.wikimedia.org/34640#c1 (10Peter Bena) 5NEW>3RESO/FIX https://github.com/huggle/huggle3-qt-lx/commits/shortcut [15:01:09] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±3] 13http://git.io/5Qy_8w [15:01:10] "When you create an object, the default constructors of all of its (non-pointer) member variables are run first. AFTER THAT, your object’s constructor is run.". Aha, everyday you'll learn something new [15:01:10] [02huggle3-qt-lx] 07benapetr 03846da4b - localized descriptions for all items [15:02:21] petan: are we confusing the user by counting from 0 onwards? [15:02:32] that's how I count :P [15:02:45] that's how programmers count [15:02:49] that's the only proper way to count [15:05:25] petan: The shortcuts are ordered weird in the options-menu [15:05:52] yeh... hashes [15:06:42] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/g2_cvw [15:06:44] [02huggle3-qt-lx] 07benapetr 03f001969 - sort the items before displaying them [15:08:38] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/eEwnUQ [15:08:39] [02huggle3-qt-lx] 07benapetr 030d95342 - tweaking save function so that it sort too [15:10:40] you could also use parameters for shortcut-x-raw, ... instead N [15:10:51] yes, but how would I pass them? [15:11:38] localize is already prepared to take parameters [15:11:56] maybe not your #define [15:12:25] my define is prepared too but did you even notice how I pass the localization string? [15:12:44] it's a member variable of shortcut class [15:12:53] how would I ever pass any parameter using 1 string? [15:13:10] I could maybe append them using some separator and then decode, but that is nasty hack [15:13:25] le't jsut leave it N it's ok [15:13:28] w = new QTableWidgetItem(_l(Configuration::HuggleConfiguration->Shortcuts[key].Description)); [15:13:38] yes, so where would you put the parameter? [15:14:36] hm, ok, there is no counter var [15:14:47] even if you had counter [15:14:52] it wouldn't help [15:15:07] btw there is counter row [15:15:10] :P [15:15:13] you could use that [15:15:24] but that counts row's not items in same category [15:15:32] it's technically not possible to count them [15:23:11] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/wUTgzQ [15:23:12] [02huggle3-qt-lx] 07benapetr 032ae0159 - resizing columns in preferences form [15:25:48] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/bMb4xQ [15:25:49] [02huggle3-qt-lx] 07benapetr 036724876 - way to make it possible to remove shortcut as well [15:28:25] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/G_Px0g [15:28:26] [02huggle3-qt-lx] 07benapetr 030f6532a - it seems I used wrong lists [15:30:11] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/TEBEpQ [15:30:12] [02huggle3-qt-lx] 07benapetr 03a46e3d5 - wrong list [15:33:05] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/kxS0qg [15:33:06] [02huggle3-qt-lx] 07benapetr 0315a3080 - fixed bug in GC which sometimes fuck up builds [15:45:24] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/70Dtsg [15:45:25] [02huggle3-qt-lx] 07benapetr 039204c00 - fixed do not allow to create same shortcuts for other keys [15:53:58] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/nWpgvQ [15:53:59] [02huggle3-qt-lx] 07benapetr 0359b5f2b - using message box is a better way [16:04:04] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±4] 13http://git.io/RFpykg [16:04:05] [02huggle3-qt-lx] 07benapetr 0366642b8 - new shortcuts [16:07:21] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±3] 13http://git.io/C4hj1w [16:07:22] [02huggle3-qt-lx] 07benapetr 03b7388ad - we can use these nice descriptions as tool tip [16:09:53] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/8e2_0w [16:09:55] [02huggle3-qt-lx] 07benapetr 03cdab2c9 - faster than my own compiler meh [16:17:36] [travis-ci] huggle/huggle3-qt-lx#1212 (shortcut - 15a3080 : Petr Bena): The build has errored. [16:17:36] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/a46e3d583e57...15a3080675eb [16:17:36] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/28053337 [16:17:47] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±2] 13http://git.io/UpeoTQ [16:17:48] [02huggle3-qt-lx] 07benapetr 0337d5a41 - more use of tips [16:19:01] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03shortcut [+0/-0/±1] 13http://git.io/I3oL1Q [16:19:02] [02huggle3-qt-lx] 07benapetr 032469b14 - unit test fix [16:23:28] 3Huggle / 3Application: improve keyboard shortcuts - 10https://bugzilla.wikimedia.org/34632 (10Peter Bena) 5PATC>3RESO/FIX [16:35:46] [travis-ci] huggle/huggle3-qt-lx#1225 (shortcut - 2469b14 : Petr Bena): The build passed. [16:35:46] [travis-ci] Change view : https://github.com/huggle/huggle3-qt-lx/compare/37d5a4152fa3...2469b143a5a3 [16:35:46] [travis-ci] Build details : http://travis-ci.org/huggle/huggle3-qt-lx/builds/28056659 [16:42:23] [02huggle3-qt-lx] 07benapetr pushed 0321 commits to 03master [+2/-0/±52] 13http://git.io/e2w9qw [16:42:25] [02huggle3-qt-lx] 07benapetr 031fe4268 - Merge branch 'shortcut' [16:55:56] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by K6ka link https://en.wikipedia.org/w/index.php?diff=613708335 edit summary: /* Huggle 3 refusing to revert */ new section [16:57:46] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=613708511 edit summary: /* Turning off requirement for rollback on english wp */ new section [16:59:46] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=613708722 edit summary: /* Huggle 3 refusing to revert */ re [17:01:02] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=613708854 edit summary: /* Turning off requirement for rollback on english wp */ fix [17:02:10] Change on 12en_wikipedia a page Wikipedia:Huggle/No you can't have instant reverts was modified, changed by K6ka link https://en.wikipedia.org/w/index.php?diff=613708999 edit summary: HG 3 uses a different method of rolling back edits. archiving page. [17:02:16] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=613709014 edit summary: /* Huggle 3 refusing to revert */ debug [17:23:27] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by K6ka link https://en.wikipedia.org/w/index.php?diff=613711359 edit summary: /* Turning off requirement for rollback on english wp */ [17:35:28] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by TutterMouse link https://en.wikipedia.org/w/index.php?diff=613712655 edit summary: /* New Logo */ [17:43:50] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by BethNaught link https://en.wikipedia.org/w/index.php?diff=613713477 edit summary: /* Turning off requirement for rollback on english wp */ probs not a good idea [17:45:55] petan, you're back! [18:47:37] Change on 12en_wikipedia a page Wikipedia:Huggle/Config was modified, changed by K6ka link https://en.wikipedia.org/w/index.php?diff=613720470 edit summary: /* Warning */ correct me if wrong, but the $1 ruins the AGF revert summary, in the rare times i've used huggle's AGF revert feature instead of Twinkle. removing. [20:47:47] Change on 12en_wikipedia a page Wikipedia:Huggle/Config was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=613733566 edit summary: Undid revision 613720470 by [[Special:Contributions/K6ka|K6ka]] ([[User talk:K6ka|talk]]) correcting you :P it substitute to reason [20:48:10] Josve05a: hey [20:49:01] hola! [20:50:29] What has you been up to lately? [20:50:32] petan [21:07:20] Josve05a: lot of things [21:07:38] I am working every day like 12 hours even on weekends [21:16:33] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=613736574 edit summary: /* New Logo */ re [21:37:49] [02huggle3-qt-lx] 07benapetr pushed 031 commit to 03master [+0/-0/±5] 13http://git.io/MdkktQ [21:37:50] [02huggle3-qt-lx] 07benapetr 034ce77a6 - fixed a bug in queue where we couldn't remove filter [21:38:45] Change on 12en_wikipedia a page Wikipedia:Huggle/Feedback was modified, changed by Petrb link https://en.wikipedia.org/w/index.php?diff=613738758 edit summary: /* Huggle 3 cannot scan Discusions */ fixd