[00:00:02] [HUGGLEBUILDER] Building a nightly build 20160121 x64 debian package [00:02:27] [HUGGLEBUILDER] Failed to build a win32 version see http://huggle.wmflabs.org/builds/windows/nightly.log [00:10:25] [HUGGLEBUILDER] huggle_20160121-nightly_amd64.deb is ready for download at http://huggle.wmflabs.org/builds/huggle_20160121-nightly_amd64.deb [03:04:13] Change on 12en.wikipedia.org a page Wikipedia:Huggle/Feedback/Archive 20 was modified, changed by Lowercase sigmabot III link https://en.wikipedia.org/w/index.php?diff=700866657 edit summary: Archiving 1 discussion(s) from [[Wikipedia:Huggle/Feedback]]) (bot [03:04:15] Change on 12en.wikipedia.org a page Wikipedia:Huggle/Feedback was modified, changed by Lowercase sigmabot III link https://en.wikipedia.org/w/index.php?diff=700866662 edit summary: Archiving 1 discussion(s) to [[Wikipedia:Huggle/Feedback/Archive 20]]) (bot [09:05:08] Change on 12en.wikipedia.org a page Wikipedia:Huggle/Users was modified, changed by Superbeecat link https://en.wikipedia.org/w/index.php?diff=700901251 edit summary: Adding [[Special:Contributions/superbeecat|superbeecat]] ([[WP:HG|HG]]) (3.1.18) [09:57:23] Change on 12en.wikipedia.org a page Wikipedia:Huggle/Users was modified, changed by DatGuy link https://en.wikipedia.org/w/index.php?diff=700906694 edit summary: Adding [[Special:Contributions/JonaQwer|JonaQwer]] ([[WP:HG|HG]]) (3.1.18) [11:16:30] Change on 12en.wikipedia.org a page Wikipedia:Huggle/Users was modified, changed by Simeon Dahl link https://en.wikipedia.org/w/index.php?diff=700915472 edit summary: Adding [[Special:Contributions/Simeon_Dahl|Simeon_Dahl]] ([[WP:HG|HG]]) (3.1.18) [12:43:41] petan, by 'tone' it means sound, right? [12:44:30] yes, there is a ticket for it [12:44:31] https://phabricator.wikimedia.org/T114710 [12:45:09] you can open comments to see some discussion as mentioned, implementing cross-platform solution to play real media files (such as wav) is extremely complex and probably overkill for GCI [12:45:16] so using beep function is probably enough [12:45:42] but do what you like [12:46:29] I already was looking at code, and I guess it's message.cpp where it should be added, right? [12:55:48] uh, no [12:55:57] message.cpp is for handling on-wiki messages [12:56:41] https://github.com/huggle/huggle3-qt-lx/blob/master/huggle/vandalnw.cpp [12:59:02] to save you some time here is the code you are looking for [12:59:03] https://github.com/huggle/huggle3-qt-lx/blob/master/huggle/vandalnw.cpp#L670 [12:59:40] on other hand you might want to check whether user messages are enabled [13:00:19] Configuration::HuggleConfiguration->UserConfig->HAN_DisplayUserTalk [13:00:37] that is a bool which is true in case user want to display user messages [13:00:46] the sound should only be emitted when it's true [13:03:00] But also when message is not by bot, doesn't it? [14:21:26] petan, is there a function to check if user is a bot, so dont need to check by username? [14:22:20] nope, but that piece of code I sent you is executed after verification if it's a bot so it's always user there [14:22:45] or wait [14:22:47] need to check [14:24:04] hmm I see [14:24:19] there is a variable mt which contains either HAN::MessageType_Bot or _User [14:24:31] it's not propagated though which isn't right [14:24:46] line 675 should have replaced message type with mt [14:25:06] however, that answers your question, if mt == HAN::MessageType_Bot it's a bot [14:38:32] Id ont know function to do beep at Irc as VisualStudio doesnt quite work well there, but I guess it is this->Irc->beep()? [14:38:35] dont* [14:46:13] petan, I've seen QApplication::beep() on comments on phabricator, but VisualStudio cant see definition of it, is that fine to just do it like that? [15:29:19] Georggi: are you on Windows? [15:29:21] I suppose yes [15:29:32] did you configure huggle and generated VS project files? [15:29:45] and no it's not this->Irc->beep() there is no such a function [15:29:59] I would like you to at least compile huggle as a first step [15:30:07] you need to be able to verify that your changes work [15:30:16] huggle is relatively easy to build on windows [15:30:39] https://github.com/huggle/huggle3-qt-lx/wiki/Building-on-Windows [15:31:31] Ok, I guess I will go and build it.. [15:31:41] I strongly recommend VisualStudio over QtCreator all huggle development is done primarily in VS [15:32:03] however you first need to download cmake and configure the project, that will generate sln files [15:32:49] once you downloaded cmake you need to launch it and add path to REPO/huggle as source directory and create some build directory then hit configure button and wait for errors, they will come [15:32:59] most likely they will be related to missing paths to Qt5 libs [15:33:16] you will need to provide them by hand, that's annoying, but mostly copy pasting 5 paths [19:27:15] Change on 12en.wikipedia.org a page Wikipedia:Huggle/Users was modified, changed by QEDK link https://en.wikipedia.org/w/index.php?diff=700977680 edit summary: Adding [[Special:Contributions/QEDK|QEDK]] ([[WP:HG|HG]]) (3.1.18) [23:39:13] petan: It's been mor than 2 years now since HG 3 was released :D Woohoo!