[00:50:34] <MaxSem>	 legoktm, so any comments about https://gerrit.wikimedia.org/r/#/c/289581/ ? :P
[00:54:36] <legoktm>	 MaxSem: it looked good, just haven't had time to go through my review queue yet
[17:19:02] <aude>	 ori: Krinkle i'm experimenting with the rcstream feeds and curious if wikitech wiki has them enabled?
[17:19:10] <aude>	 or how to find out? 
[17:19:37] <Krinkle>	 aude: https://github.com/wikimedia/operations-mediawiki-config/blob/7b5e6735467445f3876dbdfd94d6c2c6e6e323ee/wmf-config/CommonSettings.php#L3225-L3242
[17:20:10] <aude>	 thanks
[17:20:12] <Krinkle>	 It's only disabled on private wikis
[17:20:17] <Krinkle>	 https://github.com/wikimedia/operations-mediawiki-config/blob/7b5e6735467445f3876dbdfd94d6c2c6e6e323ee/wmf-config/InitialiseSettings.php#L7012-L7015
[17:20:20] <Krinkle>	 So should be fine
[17:20:21] <aude>	 ok
[17:21:01] <aude>	 it works (obviously) for wikidata but i must be doing somethign wrong for wikitech
[17:39:32] <Krinkle>	 aude: Hm. doesn't work for me either.
[17:39:38] <Krinkle>	 aude: Maybe it can't talk to the rcs server 
[17:39:51] <Krinkle>	 That's usually the problem with wikitech
[17:40:09] <aude>	 maybe
[17:40:21] <Krinkle>	 I did a subscription for '*' with on('change' -> /wikitech/.test(rc.server_name) and no matches when I made an edit
[17:40:23] <aude>	 the irc feed should be #wikitech.wikipedia or maybe #labs.wikipedia
[17:40:29] <aude>	 and doesn't seem to work either
[17:40:34] <Krinkle>	 no, wikitech.wikimedia
[17:40:39] <aude>	 oh
[17:40:54] <aude>	 that works
[17:41:22] <aude>	 and the irc stream works
[17:41:22] <Krinkle>	 https://github.com/wikimedia/operations-mediawiki-config/blob/7b5e6735467445f3876dbdfd94d6c2c6e6e323ee/wmf-config/InitialiseSettings.php#L7025-L7071
[17:41:26] <Krinkle>	 cool
[17:41:41] <Krinkle>	 legacy exceptions are listed there. the rest is all servername#.org
[17:41:41] <aude>	 i'm asking in #wikimedia-labs
[17:41:55] <aude>	 i know it's #wikidata.wikipedia
[17:42:06] <Krinkle>	 legacy exception :)
[17:42:19] <aude>	 :)
[17:42:33] <Krinkle>	 It used to be based on the now anti-pattern "$lang" and "$site".
[17:42:43] <Krinkle>	 But was changed to the more accurate servername
[17:42:57] <Krinkle>	 but existing mismatches were hardcoded so that it's not broken for new wikis every time.
[17:43:07] <Krinkle>	 Which was making this rather difficult for CVN bots
[17:51:22] <legoktm>	 ori: is it ok if I pick up and fix https://gerrit.wikimedia.org/r/#/c/271452/ ?
[17:52:12] <ori>	 legoktm: better than ok
[17:52:22] <ori>	 thanks
[19:33:14] <Krinkle>	 aude: Is it working now?
[21:02:07] <ori>	 anomie: I'd take a +2 on https://gerrit.wikimedia.org/r/#/c/289369/ . At +547, -493 lines it is getting unwieldy, so I'd prefer to do further optimizations in other patches