[19:07:51] Hi. Shouldn't we intercept memorly limit issues and throw an MWException with full stacktrace? We've the issue as apparently three places: https://phabricator.wikimedia.org/T144519 [19:59:55] so you have an OOM and you want to throw an exception... which requires memory allocation :P [20:03:38] we have logic that tries, but I don't think that delivery of the errors is actually deterministic [22:06:50] MaxSem: there is a kludge: allocate some memory in the error handler, then in the handler free it [22:07:29] http://stackoverflow.com/questions/8440439/safely-catch-a-allowed-memory-size-exhausted-error-in-php [22:08:19] http://stackoverflow.com/a/27581958/1930997 to be more precise [22:16:53] Dereckson: we do that -- https://phabricator.wikimedia.org/diffusion/MW/browse/master/includes/exception/MWExceptionHandler.php;aea84b1e3753553b47acce7558537e63edee719f$53 [22:17:25] but we can only log them if the error handler is called by the runtime [22:24:07] https://phabricator.wikimedia.org/rMW3ae8eb2416b3306346e2efc876a5cc124955ff54 nice [22:24:48] can I get a quick review please? :P https://gerrit.wikimedia.org/r/308082 [22:26:58] lego beat me :) [22:26:58] thanks! :) [22:35:01] anomie: any further concerns about https://gerrit.wikimedia.org/r/#/c/307893/ ? [22:35:10] would be nice to get it into SWAT