[07:36:18] <_joe_> if anyone's still around, I was looking at opcache optimizations, and it seems we can shave some cycles by setting opcache.save_comments to false [07:36:32] <_joe_> does mediawiki use docstrings in any ways? [08:34:12] _joe_: what do you mean by docstrings? Symfony-style annotations? [08:34:19] <_joe_> tgr: yes [08:34:28] phpunit uses them, I don't think anything in production does [08:35:03] <_joe_> ok, it's a second-order optimization anyways, I'm not really inclined to enable it, but I'll try to assess how big an effect it gives [08:35:50] the library behind shell.php can display docs, which is handy [08:36:04] but that's CLI mode so I guess no opcode cache anyway [08:36:42] <_joe_> yes, I'm not enabling opcache for CLI [19:26:41] Krinkle: I made some changes to the block notices patch. Can you please take a look when you get a chance? [19:26:42] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/472375 [20:29:34] !bash Hmm. A macro named ZEND_NORMALIZE_BOOL() actually normalizes an integer to -1, 0, or 1. [20:29:34] legoktm: Stored quip at https://tools.wmflabs.org/bash/quip/AWdcAzn4zCcrHSwq1vUD [20:31:50] anomie: https://thedailywtf.com/articles/What_Is_Truth_0x3f_ [20:42:43] heh [20:43:28] seems to mostly be really badly named. Should have been ZEND_NORMALIZE_COMPARE_RESULT() [20:43:55] usage in php core is primarily in compare() implementations