[11:58:03] <Amir1>	 Reedy: Hey, can I deploy for https://phabricator.wikimedia.org/T207814#4869175 ?
[15:07:25] <Reedy>	 Amir1: yeah, fine by me
[16:09:43] <anomie>	 AaronSchulz: Do you know of any code path in the Database or LoadBalancer that would ignore exceptions about failed connections? Maybe in waitForReplication(), trying to reconnect every time that's called? See T188327#4887781 and later comments.
[16:09:43] <stashbot>	 T188327: Deploy refactored actor storage - https://phabricator.wikimedia.org/T188327
[16:47:00] <anomie>	 bpirkle: Care to review PS3 on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/484516? I got some interesting data from backporting PS2 to wmf.12, but it raised more questions.
[20:52:47] <bpirkle>	 anomie: sorry for delay, Patch Set 3 worked fine for me locally, "virtual +2".  If that wasn't what you needed let me know.
[20:53:08] <anomie>	 bpirkle: That's exactly what I needed, thanks
[21:50:38] <AaronSchulz>	 anomie: LoadMonitor::getServerStates should log such errors rarely due to caching. safeWaitForMasterPos() seems like it would fatal and probably is missing a !$masterConn check. LB::waitForReplication() does look plausible. I guess if https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/394430/26/includes/libs/rdbms/loadbalancer/LoadBalancer.php was merged, the log spam would be a different message instead with less connection attempts.