[16:09:36] Reedy: I have one more IPUtils patch https://gerrit.wikimedia.org/r/518290 and then I think we're ready to tag a release? [16:09:56] I didn't look too closely as it was mostly copy paste for the originals [16:10:01] I'll have a look though yeah [16:13:42] it's a pretty trivial library, but PHP parsoid wants to use it [16:17:31] yeah, not a bad thing :) [16:22:19] legoktm: the packagist/license images are broken on https://github.com/wikimedia/mediawiki-libs-IPUtils [16:22:37] they wfm? [16:23:03] https://camo.githubusercontent.com/3c59754842f1555e81fde420f7686896976dbca9/68747470733a2f2f706f7365722e707567782e6f72672f77696b696d656469612f69702d7574696c732f762f737461626c652e737667 [16:23:24] legoktm: Also... IP::isIPv4( '124.24.52.13' ); [16:23:31] there's no class IP :) [16:23:44] There's also two @since tags left [16:23:53] https://i.imgur.com/UnPymV7.png [16:23:59] oops [16:24:51] https://imgur.com/a/wk3ZPNB [16:25:00] I'm guessing it's local and/or github CDN stuff then [16:25:07] https://imgur.com/yzEZkQP [16:25:16] o.o weird [16:25:25] https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/518292 https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/518293 [16:36:00] legoktm: late to the party, but a separate lib from IPSet seems a bit much? [16:36:45] Plans to merge? [16:37:15] hmm, I created a separate library because IPSet had a kinda narrowly scoped name [16:37:34] we could merge IPSet into IPUtils, should be straightforward [16:45:45] shouldn't need to mess about with re-namespacing anything [16:46:11] * legoktm afk -> food [17:09:28] legoktm: Images working now [17:09:37] Dunno if the pushed changes were enough to purge some cache [17:14:00] RE_IP_BYTE = '(?:25[0-5]|2[0-4][0-9]|1[0-9][0-9]|0?[0-9]?[0-9])'; [17:14:00] RE_IP_ADD = '(?:' + RE_IP_BYTE + '\\.){3}' + RE_IP_BYTE; [17:14:09] I see we have some JS that is similar, but not necessarily the same... [17:14:49] legoktm: Only outstanding ? from me is whether we should necessarily do something with all the constants [17:34:02] hmm [17:34:15] the only usage of them outside of the IPUtils class itself is https://gerrit.wikimedia.org/g/mediawiki/core/+/a8f302118184c543ff58e9a93c0cf03c84bf712a/includes/api/ApiBase.php#1716 [17:50:46] Reedy: https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/518306