[20:35:34] * anomie rolls eyes at https://sonarcloud.io/project/issues?branch=434718-10&id=mediawiki-core&issues=AW-qwow1LeG1MQqQqsPS&open=AW-qwow1LeG1MQqQqsPS [20:37:34] >10min effort [20:40:38] While not always true, I did find that often making code comply with what Phan, JSDuck or Doxygen can understand often also leads to a higher probability that humans understand it easily and quickly. [20:41:00] Eventhough it is of course annoying that some edge cases it just misses for no good reason and resulting in hacks like this is indeed not pretty. [20:45:40] Just curious, why is that obviois type hint a statement and not a comment? [20:45:48] *obvious [20:48:11] bd808: For some reason or other due to the library it uses to process source files, Phan can't see inline comments. So it requires a do-nothing string instead. Now SonarQube is whining about the do-nothing string that Phan requires. [20:48:36] tooling toil! the worst kind of 'help' [20:48:59] More specifically, that specific instance of an inline comment anyway. [21:38:34] that's T234143 [21:38:34] T234143: conflict between codehealth and use of @phan-var annotation - https://phabricator.wikimedia.org/T234143 [21:41:27] in general, it's a sensible check: an expression with no side effect is very likely a copypaste error or other mistake and the author actually wanted to assign it to something [21:41:51] we just need an exception for the weird phan pattern [21:42:19] (or make phan use the more capable php parser) [22:01:43] addshore: are you coming?