[00:02:42] (03CR) 10Catrope: Hack for preventing opacity-related rendering glitches (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 (owner: 10Trevor Parscal) [00:05:12] (03PS5) 10Catrope: Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 (owner: 10Trevor Parscal) [00:05:25] (03CR) 10Catrope: [C: 032] Force thumb and frameless images to default size in DM [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117106 (owner: 10Catrope) [00:06:20] (03CR) 10Catrope: [C: 032] Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 (owner: 10Trevor Parscal) [00:06:43] (03Merged) 10jenkins-bot: Force thumb and frameless images to default size in DM [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117106 (owner: 10Catrope) [00:06:47] (03Merged) 10jenkins-bot: Hack for preventing opacity-related rendering glitches [oojs/ui] - 10https://gerrit.wikimedia.org/r/117029 (owner: 10Trevor Parscal) [00:10:03] (03PS3) 10Jforrester: Update OOjs UI to v0.1.0-pre (e4f6ce0156) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116895 (owner: 10Trevor Parscal) [00:10:21] RoanKattouw: https://gerrit.wikimedia.org/r/117121 and https://gerrit.wikimedia.org/r/116895 [00:10:26] Thanks [00:10:45] RoanKattouw, what was that change? I'm confused [00:11:43] mooeypoo: That was a partial back-port of your big commit, just fixing the width:2px issue. [00:11:53] oh [00:12:09] mooeypoo: Rather than pull all of the changes in one go. [00:12:19] * mooeypoo nods [00:12:30] but.. oh, you separated it? [00:12:57] (03PS1) 10Catrope: Revert "Force thumb and frameless images to default size in DM" [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117122 [00:13:07] (03CR) 10Catrope: [C: 032] Revert "Force thumb and frameless images to default size in DM" [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117122 (owner: 10Catrope) [00:13:12] the change seems to be the entire thing [00:13:21] mooeypoo: I *tried* to [00:13:25] But forgot [00:13:54] oh.. I wasn't aware you wanted to, I'd have done it. Also, next time I'll make sure to split them up better ... [00:14:48] speaking of which -- there's this that fixes James' bug: https://gerrit.wikimedia.org/r/#/c/117025/ and all others if/when they come up I'll put on top [00:15:09] (03Merged) 10jenkins-bot: Revert "Force thumb and frameless images to default size in DM" [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117122 (owner: 10Catrope) [00:15:20] (03PS1) 10Catrope: Force thumb and frameless images to default size in DM [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117123 [00:15:42] I have to run to class :\ [00:15:45] (03CR) 10Catrope: [C: 032] Force thumb and frameless images to default size in DM [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117123 (owner: 10Catrope) [00:15:51] (03PS4) 10Trevor Parscal: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 [00:16:02] (03CR) 10jenkins-bot: [V: 04-1] Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal) [00:17:29] (03Merged) 10jenkins-bot: Force thumb and frameless images to default size in DM [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117123 (owner: 10Catrope) [00:17:51] RoanKattouw, thanks and sorry for the trouble [00:19:59] (03PS5) 10Trevor Parscal: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 [00:20:57] (03CR) 10jenkins-bot: [V: 04-1] Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal) [00:21:07] (03PS6) 10Trevor Parscal: Pass surface set into ve.ui.Dialog and ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116889 [00:21:21] (03CR) 10Jforrester: [C: 031] Pass surface set into ve.ui.Dialog and ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116889 (owner: 10Trevor Parscal) [00:22:24] (03CR) 10Jforrester: [C: 04-1] "We should probably remove the "border" type icon (I think we could use it, but it'll be a bit heavy), and we need a "basic" type icon." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 (owner: 10Esanders) [00:23:12] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (e4f6ce0156) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116895 (owner: 10Trevor Parscal) [00:23:32] (03CR) 10Catrope: [C: 032] Pass surface set into ve.ui.Dialog and ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116889 (owner: 10Trevor Parscal) [00:24:47] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e4f6ce0156) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116895 (owner: 10Trevor Parscal) [00:24:49] (03Merged) 10jenkins-bot: Pass surface set into ve.ui.Dialog and ve.ui.Inspector [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/116889 (owner: 10Trevor Parscal) [00:26:02] (03CR) 10Esanders: "Object alignment is the same whether it's media or something else. As for looking like a flag, that's somewhat unavoidable (see Trevor's d" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115664 (owner: 10Esanders) [00:29:54] (03CR) 10Jforrester: [C: 032] Update MWCommandHelpDialog now core supports multiple shortcuts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116968 (owner: 10Esanders) [00:31:03] (03Merged) 10jenkins-bot: Update MWCommandHelpDialog now core supports multiple shortcuts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116968 (owner: 10Esanders) [00:33:40] (03PS7) 10Catrope: Update VE core submodule to master (ab70193) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116897 (owner: 10Trevor Parscal) [00:33:48] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (ab70193) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116897 (owner: 10Trevor Parscal) [00:34:21] (03PS8) 10Catrope: Update VE core submodule to master (ab70193) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116897 (owner: 10Trevor Parscal) [00:34:38] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (ab70193) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116897 (owner: 10Trevor Parscal) [00:36:30] (03Merged) 10jenkins-bot: Update VE core submodule to master (ab70193) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116897 (owner: 10Trevor Parscal) [00:38:40] (03PS6) 10Catrope: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal) [00:50:23] (03PS7) 10Trevor Parscal: [WIP] Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 [00:52:16] (03CR) 10Catrope: [WIP] Merge TransclusionDialogs into one (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal) [00:53:31] (03PS3) 10Jforrester: Alignment icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115664 (owner: 10Esanders) [00:53:36] Object # has no method 'getSurface' ? [00:54:08] bah... outdated submodule again. [00:54:44] Krenair: No, we broke something [00:54:49] Trevor is looking into it [00:55:16] heh, okay. getting the latest copy of the submodule appeared to fix it for me [00:55:54] James_F, https://bugzilla.wikimedia.org/show_bug.cgi?id=59608 is another FlaggedRevs WFM from me. I wonder if this is related to https://bugzilla.wikimedia.org/show_bug.cgi?id=58057 [00:55:59] Krenair: Oh, right, looks like Trevor's submodule is not up to date [00:56:03] Thanks for flagging that :) [00:56:16] Link inspector is still broken though [00:56:29] (03CR) 10Catrope: [C: 04-1] "Minor inline comments on PS6." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal) [00:56:37] James_F, not really sure where you were seeing the missing message [00:58:46] Krenair: You need to be a review-approver to see the problem. [00:59:09] Krenair: I did it on https://de.wikipedia.org/w/index.php?title=Nicolas_Perrenot_de_Granvelle&action=edit&uselang=qqx [00:59:19] I see "Accept this version (includes 1 pending change)" on my wiki [00:59:21] (vs. https://de.wikipedia.org/w/index.php?title=Nicolas_Perrenot_de_Granvelle&veaction=edit ) [00:59:48] Wonder if I can reproduce it on mediawikiwiki [01:00:01] In VE I get: [] Nur Kleinigkeiten wurden verändert [] Diese Seite beobachten [01:00:22] In WT I get [] Nur Kleinigkeiten wurden verändert [] Diese Seite beobachten [] Sichte die letzten Änderungen [01:01:47] James_F, hm, I see the same thing at https://www.mediawiki.org/w/index.php?title=Manual:CloudFlare&action=edit [01:02:13] * James_F nods. [01:03:21] (03CR) 10Jforrester: [C: 032] "New icons by Trevor are fine, though eh re. being generic." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115664 (owner: 10Esanders) [01:04:19] James_F, ugh, I can also replicate https://bugzilla.wikimedia.org/show_bug.cgi?id=58057 on mediawikiwiki but not my own setup [01:04:19] (03Merged) 10jenkins-bot: Alignment icons [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115664 (owner: 10Esanders) [01:06:03] James_F, or I thought I could. That may have been the wrong tab (oops) [01:07:22] Krenair: I can replicate on MWwiki too. [01:07:32] (03PS1) 10Trevor Parscal: Update constructors of inspectors and dialogs as per changes in I345d6e6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117130 [01:08:31] (03PS1) 10Trevor Parscal: Update constructors of inspectors and dialogs as per changes in I345d6e6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117131 [01:09:03] (03CR) 10Jforrester: [C: 032] Update constructors of inspectors and dialogs as per changes in I345d6e6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117130 (owner: 10Trevor Parscal) [01:09:30] (03PS1) 10Catrope: Rename OO.ui.MenuSectonItemWidget.less to the right name [oojs/ui] - 10https://gerrit.wikimedia.org/r/117132 [01:09:54] (03CR) 10Jforrester: [C: 032] Update constructors of inspectors and dialogs as per changes in I345d6e6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117131 (owner: 10Trevor Parscal) [01:10:08] (03PS2) 10Catrope: Rename OO.ui.MenuSectonItemWidget.less to the right name [oojs/ui] - 10https://gerrit.wikimedia.org/r/117132 [01:10:14] (03Merged) 10jenkins-bot: Update constructors of inspectors and dialogs as per changes in I345d6e6 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117130 (owner: 10Trevor Parscal) [01:10:54] (03Merged) 10jenkins-bot: Update constructors of inspectors and dialogs as per changes in I345d6e6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117131 (owner: 10Trevor Parscal) [01:13:25] (03CR) 10Jforrester: [C: 032] Rename OO.ui.MenuSectonItemWidget.less to the right name [oojs/ui] - 10https://gerrit.wikimedia.org/r/117132 (owner: 10Catrope) [01:13:48] (03Merged) 10jenkins-bot: Rename OO.ui.MenuSectonItemWidget.less to the right name [oojs/ui] - 10https://gerrit.wikimedia.org/r/117132 (owner: 10Catrope) [01:13:57] (03CR) 10Catrope: [C: 032] Inline CR fixes for Media Edit Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117025 (owner: 10Mooeypoo) [01:15:05] (03Merged) 10jenkins-bot: Inline CR fixes for Media Edit Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117025 (owner: 10Mooeypoo) [01:18:45] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (e1b23620c0) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117136 [01:20:08] (03Abandoned) 10Jforrester: [WIP] Update VE core submodule to master (4513d9c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117018 (owner: 10Jforrester) [01:21:33] Krinkle: Any chance you could quickly +2 https://gerrit.wikimedia.org/r/#/c/117136/ and https://gerrit.wikimedia.org/r/#/c/117137/ to fix a regression? [01:21:38] (Yay for typos.) [01:23:04] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (e1b23620c0) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117136 (owner: 10Jforrester) [01:23:26] (03PS2) 10Alex Monk: Make new category suggestion section for hidden categories [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116132 [01:24:05] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (e1b23620c0) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117136 (owner: 10Jforrester) [01:25:14] (03PS2) 10Jforrester: Use align icons in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116471 (owner: 10Esanders) [01:25:16] (03PS1) 10Jforrester: Update VE core submodule to master (c81252c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117139 [01:27:10] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (c81252c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117139 (owner: 10Jforrester) [01:27:23] (03CR) 10Catrope: [C: 032] Use align icons in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116471 (owner: 10Esanders) [01:28:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (c81252c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117139 (owner: 10Jforrester) [01:29:43] (03Merged) 10jenkins-bot: Use align icons in media edit dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116471 (owner: 10Esanders) [01:30:19] (03PS3) 10Catrope: Make new category suggestion section for hidden categories [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116132 (owner: 10Alex Monk) [01:31:28] (03CR) 10Catrope: [C: 032] Make new category suggestion section for hidden categories [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116132 (owner: 10Alex Monk) [01:33:37] (03Merged) 10jenkins-bot: Make new category suggestion section for hidden categories [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116132 (owner: 10Alex Monk) [01:43:55] (03CR) 10Jforrester: [C: 04-1] "Needs rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/100520 (owner: 10Robmoen) [01:44:51] (03CR) 10Jforrester: [C: 04-2] "Needs to be moved to the VE-core repo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84441 (owner: 10Cscott) [01:45:05] (03CR) 10Jforrester: [C: 04-2] "Needs to be moved to the VE-core repo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84439 (owner: 10Cscott) [01:45:32] (03CR) 10Jforrester: [C: 04-2] "Needs to be moved to the VE-core repo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84440 (owner: 10Cscott) [01:45:36] (03PS1) 10Catrope: Work around DOM corruption for default-sized images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117144 [01:45:47] (03CR) 10Jforrester: [C: 04-2] "Needs to be moved to the VE-core repo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/84442 (owner: 10Cscott) [01:49:55] unimoo: When you get back, please read https://gerrit.wikimedia.org/r/#/c/117144/1/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js , in particular the FIXME comments [01:52:00] Krinkle: Ping. [01:54:31] James_F: pong [01:56:31] James_F: The ping before this one about +2, I see Roan did those already [01:57:46] Krinkle: Yeah, sorry. [01:57:59] Krinkle: https://gerrit.wikimedia.org/r/#/c/117144/1/modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js needs to merge tonight - could you look at it? [02:01:00] RoanKattouw: Can you provide me steps to reproduce the bug locally? [02:01:46] (03PS8) 10Robmoen: Create mixin for ce nodes that responds to dblclick [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 [02:02:25] Krinkle: Have wikitext [[File:Med 3.png|thumb]] on page, open in VE, make edit, undo edit (with backspace, not undo), click Save page, observe corruption warning in save dialog [02:02:25] James_F: Regarding slug styling, I think we should change it so that it doesn't look like a
[02:02:39] 	 found myself being irritated by it a few times today when working locally
[02:02:41] 	 Krinkle: (Assuming you have InstantCommons enabled)
[02:02:46] 	 Krinkle: James says yes
[02:02:47] 	 (I do)
[02:03:58] 	 RoanKattouw: Initial rendering in edit mode is already wrong (thumbnail is huge)
[02:04:14] 	 Yes, that's going unfixed in this commit
[02:04:23] 	 The second FIXME I add in my commit mentions this
[02:04:25] 	 What happened to the save dialog?
[02:04:33] 	 What's wrong with it?
[02:04:40] 	 http://i.imgur.com/Y8ugcbF.png
[02:04:51] 	 Krinkle: Update MW core
[02:04:53] 	 OOUI changed
[02:05:02] 	 Lots
[02:05:07] 	 I'm working on stuff in core :-/
[02:05:14] 	 This much, again?
[02:05:33] 	 That's too close, it's been only a few days. Nobody is gonna be able to use oojsui this way..
[02:05:34] 	 oh well,
[02:05:58] 	 fixed
[02:06:43] 	 RoanKattouw: Looks better now http://i.imgur.com/R2QVxum.png
[02:06:47] 	 though that focus line seems wrong
[02:07:27] 	 Yeah the focus line is a known issue
[02:07:35] 	 RoanKattouw: Saving/diffing didn't touch the img though (on master)
[02:07:36] 	 It looks reasonable for most text inputs but not this particular one
[02:07:46] 	 RoanKattouw: Is your change only supposed to fix the thumb as rendered in the surface?
[02:07:59] 	 Krinkle: Parsoid didn't touch it, no, but the DOM did change, hence the corruption warning. My patch makes the corruption warning go away
[02:08:10] 	 right
[02:08:12] 	 No, my patch is only supposed to make the corruption warning go away
[02:08:18] 	 It does not fix the massively distorted rendering of the image
[02:08:20] 	 (03PS8) 10Trevor Parscal: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 
[02:08:24] 	 I left that as a FIXME for Moriel
[02:08:30] 	 (03CR) 10jenkins-bot: [V: 04-1] Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal)
[02:08:38] 	 (03PS9) 10Catrope: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal)
[02:08:47] 	 (03CR) 10jenkins-bot: [V: 04-1] Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal)
[02:09:03] 	 (03CR) 10Krinkle: [C: 032] "Fixes the bug, code doesn't look suspicious." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117144 (owner: 10Catrope)
[02:09:11] 	 Krinkle: Yay, thank you.
[02:10:12] 	 (03Merged) 10jenkins-bot: Work around DOM corruption for default-sized images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117144 (owner: 10Catrope)
[02:12:16] 	 (03PS10) 10Trevor Parscal: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 
[02:12:25] 	 (03CR) 10jenkins-bot: [V: 04-1] Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal)
[02:15:21] 	 (03PS11) 10Catrope: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal)
[02:15:32] 	 (03CR) 10Catrope: [C: 032] Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal)
[02:17:32] 	 (03Merged) 10jenkins-bot: Merge TransclusionDialogs into one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116902 (owner: 10Trevor Parscal)
[02:18:17] 	 (03CR) 10Catrope: [C: 04-1] "Code looks reasonable but double clicks don't work for me :(" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen)
[02:43:38] 	 (03PS1) 10Jforrester: Re-label the "Transclusion" button to "Template", as that's now the default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117151 
[02:44:15] 	 (03PS2) 10Jforrester: Re-label "Transclusion" button to "Template", as that's now the default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117151 
[02:44:29] 	 Krinkle: ^^^ Could you merge that? I forgot to bug Trevor, and now he and Roan have gone for the day.
[02:44:33] 	 Krinkle: Trivial change.
[03:05:32] 	 James_F: checking
[03:05:51] 	 (03CR) 10Krinkle: [C: 032] Re-label "Transclusion" button to "Template", as that's now the default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117151 (owner: 10Jforrester)
[03:07:10] 	 (03Merged) 10jenkins-bot: Re-label "Transclusion" button to "Template", as that's now the default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117151 (owner: 10Jforrester)
[03:08:00] 	 Krinkle: Thanks so much. :-)
[05:02:01] 	 (03PS1) 10Mooeypoo: Enforce width-only default size only on larger images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 
[05:20:33] 	 (03PS2) 10Mooeypoo: Enforce width-only default size only on larger images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 
[05:27:31] 	 (03CR) 10Jforrester: [C: 031] Enforce width-only default size only on larger images [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 (owner: 10Mooeypoo)
[11:05:06] 	 (03CR) 10Esanders: "Roan: Isn't that because it's not mixed in to anything yet?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen)
[11:06:25] 	 (03CR) 10Esanders: "Better?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders)
[11:38:45] 	 (03CR) 10Ladsgroup: "Can you take a picture and put a link here? I have to install VE and Parsoid in order to check just an icon." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders)
[12:27:22] 	 (03CR) 10Esanders: "http://i.imgur.com/pp9W1jU.png" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders)
[12:31:16] 	 (03CR) 10Ladsgroup: [C: 031] "based on the image looks okay to me" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders)
[13:38:58] 	 (03CR) 10Esanders: "What is 'basic'?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 (owner: 10Esanders)
[13:47:33] 	 (03CR) 10Esanders: "This is very buggy and temperamental to what the state of the image was before the change:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo)
[14:41:08] 	 (03CR) 10Jforrester: [C: 032] Bold/italic icons for fa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders)
[14:42:10] 	 (03Merged) 10jenkins-bot: Bold/italic icons for fa [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/115660 (owner: 10Esanders)
[14:59:51] 	 (03PS1) 10Esanders: Documentation fix [oojs/ui] - 10https://gerrit.wikimedia.org/r/117192 
[15:23:50] 	 (03PS1) 10Krinkle: doc: Improve overall documentation and fix minor issues [oojs/core] - 10https://gerrit.wikimedia.org/r/117201 
[15:24:46] 	 (03PS2) 10Krinkle: Fix OO.ui.ButtonOptionWidget documentation header [oojs/ui] - 10https://gerrit.wikimedia.org/r/117192 (owner: 10Esanders)
[15:24:51] 	 (03CR) 10Krinkle: [C: 032] Fix OO.ui.ButtonOptionWidget documentation header [oojs/ui] - 10https://gerrit.wikimedia.org/r/117192 (owner: 10Esanders)
[15:25:18] 	 (03Merged) 10jenkins-bot: Fix OO.ui.ButtonOptionWidget documentation header [oojs/ui] - 10https://gerrit.wikimedia.org/r/117192 (owner: 10Esanders)
[15:28:01] 	 (03PS2) 10Krinkle: doc: Improve overall documentation and fix minor issues [oojs/core] - 10https://gerrit.wikimedia.org/r/117201 
[15:38:22] 	 (03PS3) 10Krinkle: doc: Improve overall documentation and fix minor issues [oojs/core] - 10https://gerrit.wikimedia.org/r/117201 
[15:39:00] 	 (03CR) 10Krinkle: doc: Improve overall documentation and fix minor issues (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/117201 (owner: 10Krinkle)
[15:45:47] 	 (03PS4) 10Krinkle: doc: Improve overall documentation and fix minor issues [oojs/core] - 10https://gerrit.wikimedia.org/r/117201 
[15:48:49] 	 (03PS1) 10Esanders: Add text direction to SA demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117203 
[15:50:45] 	 (03PS5) 10Krinkle: doc: Improve overall documentation and fix minor issues [oojs/core] - 10https://gerrit.wikimedia.org/r/117201 
[16:04:24] 	 I AM SO CLOSE to having this working. I've got the edit and edit source buttons, but when I do veaction=edit it just displays the page. Who wants to read my mind and tell me the dumb I did
[16:05:28] 	 ulfr_: WMF wiki, or your personal one?
[16:05:37] 	 my personal one
[16:05:52] 	 I've got it set up on a testbed machine so the urls are a pain in the butt
[16:06:08] 	 then I can't help, sorry :)
[16:06:34] 	 :(
[16:17:11] 	 Ulfr_, are you getting any console errors?
[16:18:30] 	 Ulfr_: Which browser are you using?
[16:18:51] 	 And which version of mediawiki /  version of VisualEditor.
[16:24:17] 	 MW 1.22.2 and VisualEditor 0.1.0
[16:24:58] 	 No console errors, no errors in the webserver log
[16:25:05] 	 I just click edit, and the page refreshes
[16:26:09] 	 (03CR) 10Mooeypoo: "Are you talking about CE changes of things not looking right, or changes that apply to save as well?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/115939 (owner: 10Mooeypoo)
[16:30:39] 	 mooeypoo, Krinkle ^
[16:30:46] 	 thanks very much btw :)
[16:31:14] 	 Ulfr_: VisualEditor 0.1.0 doesn't mean much, that's the package.json file for dev dependencies
[16:31:22] 	 Ulfr_: Where did you install it from, git?
[16:31:36] 	 Krinkle: Yuh. Copy/pasta'd the install line on the install guide
[16:32:26] 	 Ulfr_: OK. Can you run "git pull && git submodule update --init" in the extensions/VisualEditor repository ?
[16:32:54] 	 Ulfr_: Anyway, if you see the tabs but no editor, that likely means the client side is malfunctioning but the PHP hook is working
[16:33:13] 	 Got a (temporary) public url?
[16:33:24] 	 http://ec2-50-19-198-137.compute-1.amazonaws.com:8000/index.php?title=Main_Page&veaction=edit
[16:33:44] 	 There's edit protection if you're not logged in, but that shouldn't be an issue right?
[16:36:41] 	 Ulfr_: VisualEditor isn't installed it seems
[16:36:44] 	 http://www.wikidoc.org/load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector&*
[16:36:51] 	 no where does it list ext.visualEditor
[16:37:00] 	 Do you have it under some kind of conditional?
[16:37:26] 	 Krinkle: *facepalm*
[16:38:13] 	 Assuming you do, make sure that that doesn't affect the inclusion of the extension itself. That has to be unconditional. You can control the enabling for the editor still on a per-user, skin, namespace and browser base, but the PHP file must be included unconditionally so that the cookie-less/context-less load.php entrypoint will regocnize it
[16:38:45] 	 Krinkle: It was a domain based config file
[16:38:48] 	 altering
[16:39:05] 	 Krinkle: Oh
[16:39:08] 	 You're on the main site
[16:39:09] 	 sorry
[16:39:09] 	 Oh, right. I didn't even see hte hostname was different
[16:39:42] 	 Ulfr_: Also, two other problems I see
[16:39:44] 	 Sorry about that. Have to have aggressive domain switching or people complain that they have to log in twice
[16:40:31] 	 Ulfr_: 1) All php responses have a spurious blank line on top. This is most likely caused by you accidentally creating an HTML buffer in one of your configuration files. Be sure to *never* use ?> close tags at the end of a file, as any line break after this is non-php and thus creates HTML buffer. Which is problematic sometimes.
[16:40:42] 	 2) It seems the query string perservation is being malformed
[16:40:45] 	 (03PS1) 10Esanders: Add oojs-ui-apex.css to modules.json [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117213 
[16:40:48] 	 view-source:ec2-50-19-198-137.compute-1.amazonaws.com:8000/load.php?modules=startup?only=scripts
[16:40:53] 	 redirects with a long string of stuff
[16:40:59] 	 to /load.php?modules=startup?only=scripts?modules=startup?only=scripts
[16:41:06] 	 Not sure what that is about
[16:41:17] 	 (03PS1) 10Esanders: Fix application of slug focus classes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117214 
[16:41:20] 	 (03PS1) 10Esanders: Use en-us spelling 'focused' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117218 
[16:41:21] 	 I see it installed now in load.php
[16:41:23] 	 (03PS1) 10Esanders: Have Protected/ResizableNode respond to rerender event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117215 
[16:41:25] 	 (03PS1) 10Esanders: Rerender focusedNode after slug collapse [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117216 
[16:41:27] 	 (03PS1) 10Esanders: Use en-us spelling 'focused' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117217 
[16:42:11] 	 Ulfr_: So you'll want to override the config for this install to have $wgServer set to the actual hostname in the url as opposed to your main one. As long as its ust for debugging you can set $wgServer=false; and Mediawiki will fill it in for you.
[16:42:27] 	 Don't do that in production though, but works perfect for dev environments where you might access you install in a number of different ways
[16:42:39] 	 Krinkle: I love you.
[16:42:39] 	 (03CR) 10Esanders: "Not the solution you suggested in the bug, but it works." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117214 (owner: 10Esanders)
[16:42:54] 	 Ulfr_: You're most welcome :)
[16:43:11] 	 Krinkle: Uh
[16:43:19] 	 I don't know what setting $wgServer to false did
[16:43:22] 	 but my server has teh derps now
[16:45:51] 	 (03CR) 10Krinkle: [C: 032] "Looks like Trevor added it manually before there, grunt-build is clean after this change. Nice catch." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117213 (owner: 10Esanders)
[16:45:59] 	 (03CR) 10Esanders: [C: 032] doc: Improve overall documentation and fix minor issues [oojs/core] - 10https://gerrit.wikimedia.org/r/117201 (owner: 10Krinkle)
[16:47:46] 	 Krinkle: How could that change have potentially enraged jQuery? Is there a 'cool it with the xss protection' magical boolean you know of?
[16:48:27] 	 jQuery didn't get enraged, something caused all scripts to not be loaded anymore on your page
[16:48:34] 	 including jquery and eerything else
[16:48:57] 	 Don't worry about the $ undefined, that's just the first point where it realises something is missing
[16:49:16] 	 the xss warning is about wikEd.js, harmless
[16:49:34] 	 Yar, but a lot of my scripts aren't designed to be run from *not* my server and might cause the issue
[16:49:34] 	  
[16:49:37] 	 the href="" ismissing
[16:49:50] 	 presumably you set the server to something that caused it to no longer be able to generate a valid url
[16:50:12] 	 it's having a problem accessing the url, the html output doesn't contain any url at all
[16:50:33] 	   it's supposed to look like that
[16:50:49] 	 Ulfr_: Maybe you set $wgServer = false; too late?
[16:51:05] 	 Krinkle: Yeah. The links are a little ugly on the main page
[16:51:09] 	 poking around
[16:51:11] 	 (03CR) 10Krinkle: [C: 031] Use en-us spelling 'focused' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117217 (owner: 10Esanders)
[16:57:52] 	 (03Merged) 10jenkins-bot: doc: Improve overall documentation and fix minor issues [oojs/core] - 10https://gerrit.wikimedia.org/r/117201 (owner: 10Krinkle)
[16:57:54] 	 (03Merged) 10jenkins-bot: Add oojs-ui-apex.css to modules.json [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117213 (owner: 10Esanders)
[17:00:10] 	 Krinkle: I had to set $wgServer to the current DNS and now it works when creating a page :D
[17:00:35] 	 Ulfr_: And it all works now I see
[17:00:39] 	 except Parsoid server request
[17:00:45] 	 but I think you'll figure that one out
[17:00:55] 	 Krinkle: I owe you many beverages
[17:01:00] 	 be they alcoholic or boring
[17:02:01] 	 (03CR) 10Jforrester: [C: 032] "Eww." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117217 (owner: 10Esanders)
[17:02:04] 	 (03CR) 10Jforrester: [C: 032] "Eww." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117218 (owner: 10Esanders)
[17:03:36] 	 (03CR) 10Jforrester: ""Basic" is a nicer term for "none". I.e. [[File:Foo.png]] vs. [[File:Foo.png|thumb]]. They're in-line, except when they aren't ([[File:Foo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 (owner: 10Esanders)
[17:03:51] 	 (03Merged) 10jenkins-bot: Use en-us spelling 'focused' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117218 (owner: 10Esanders)
[17:04:26] 	 edsanders: https://gerrit.wikimedia.org/r/#/c/117161/ would be great to get merged.
[17:04:39] 	 edsanders: And yeah, a bunch of this needs careful review and work.
[17:09:21] 	 (03CR) 10Esanders: "Surely we should be able find out what the intended behaviour is from the code?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 (owner: 10Mooeypoo)
[17:12:18] 	 (03PS1) 10Krinkle: mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117224 
[17:12:30] 	 (03CR) 10Krinkle: Use accesskey=s on the save buttons (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/110434 (owner: 10Alex Monk)
[17:14:25] 	 edsanders: YMBJ. MW's image handling is infamously buggy, complex and actively wrongly-documented.
[17:14:27] 	 Krinkle: She's workin' now, thanks captain! It really helps if you configure localsettings.js in parsiod intelligently
[17:14:42] 	 James_F: I'd call it benignly neglected.
[17:14:45] 	 (03CR) 10Alex Monk: [C: 032] mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117224 (owner: 10Krinkle)
[17:14:59] 	 Ulfr_: That's being kind.
[17:18:10] 	 (03Merged) 10jenkins-bot: mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117224 (owner: 10Krinkle)
[17:20:02] 	 (03CR) 10Jforrester: "Ed: Your optimism about MW parser's code belies your lack of work with it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117161 (owner: 10Mooeypoo)
[17:20:31] 	 Krinkle, Krenair: Nice speed on that fix. :-)
[17:20:59] 	 Krinkle, Krenair: Worth a backport? Wmf17 got cut about an hour ago…
[17:21:07] 	 James_F: yeah, I spotted it on Ulfr_'s website, and quicky after realised I remember reading that code before in Krenair's commit, so fixed it.
[17:21:07] 	 Would have been faster if Jenkins wasn't twiddling it's thumbs :P
[17:21:26] * James_F  grins.
[17:21:47] 	 Yeah, it's been really slow lately. Something is horribly wrong in Zuul/Jenkins job queue. Far too often is it doing literally nothing from what I can see.
[17:22:26] 	 Yeah, I was watching it just now when I approved https://gerrit.wikimedia.org/r/#/c/104711/ (which took 13 minutes, btw)
[17:22:28] 	 Krinkle: Don't worry about it. Let hashar fix it. :-)
[17:22:37] 	 There was lots of 'queued' markers and no activity
[17:22:42] 	 then suddenly it sprang into life
[17:22:59] 	 Blocked on disc IO or something?
[17:23:40] 	 (MW core has always been terribly slow.)
[17:25:03] 	 People deploying in #wikimedia-operations were complaining that theirs took 3/4 minutes, pff :p
[17:28:04] 	 (03PS1) 10Alex Monk: mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [extensions/VisualEditor] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/117228 
[17:28:14] 	 :)
[17:28:41] 	 greg-g: Chance of a crafty pre-deployment backport merge? Or would that break things for Bryan?
[17:28:58] 	 it might confuse things, but it might be good, for that reason
[17:29:01] 	 heh
[17:29:08] * James_F  grins.
[17:29:19] 	 bryan being the sane-maker
[17:29:35] 	 what's the backport?
[17:29:45] 	 greg-g: 117228
[17:30:13] 	 greg-g: Fixes a JS crash (console error) in VE code currently in prod.
[17:30:24] 	 yeah, good idea
[17:30:25] 	 Krenair: It's probably worth it doing wmf16 too, right?
[17:30:48] 	 hm
[17:31:14] 	 (03PS1) 10Jforrester: mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing [extensions/VisualEditor] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/117230 
[17:31:16] 	 yep
[17:31:30] 	 greg-g, does group 2 have 23wmf16 now?
[17:31:34] 	 Krenair: Yes.
[17:31:40] 	 ok, updating the page
[17:32:06] 	 well, almost
[17:32:09] 	 will
[17:32:22] 	 Oh, sorry, group 2 == phase 3 => no.
[17:32:36] 	 Groups are zero-indexed but the old phases weren't.
[17:32:38] * James_F  sighs.
[17:32:49] 	 So… yes.
[17:32:49] 	 James_F: Doh!, Remember updating the contribution.md file to point to lib/ve from mwext-ve
[17:32:53] 	 James_F: We failed, it points to itself
[17:33:01] 	 Krenair: Whoops. :-(
[17:33:04] 	 Err.
[17:33:08] 	 Krinkle: Whoops.
[17:33:15] 	 (Y'all gotta get different IRC nicks. ;-))
[17:35:52] 	 Krinkle: Could you do the hot-fix deploy now, if greg-g's OK?
[17:36:27] 	 James_F: fyi: I'm leaving right after the standup, having an early day today as I'm out in the evening.
[17:36:52] 	 Krinkle: OK. :-(
[17:36:53] 	 Krinkle: Wait, something was wrong with MW on MY website? :o
[17:37:14] 	 Ulfr_: No, I spotted a bug when loading VisualEditor on your site before you configured Parsoid.
[17:37:25] 	 An exception was thrown after discarding the error message
[17:37:29] 	 Oh. It's just a relief that *I* didn't break it
[17:37:44] 	 which turns out is a bug on our side that has other impacts as well
[17:40:51] 	 (03PS1) 10Krinkle: doc: Improve and fix minor issues in base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/117232 
[17:41:33] 	 (03CR) 10Krinkle: "Had these laying around in various outdated branches. Kept it limited to the base classes for now to avoid too many conflicts (and too muc" [oojs/ui] - 10https://gerrit.wikimedia.org/r/117232 (owner: 10Krinkle)
[17:43:08] 	 James_F: Was it you who initially put me onto using Varnish in place of squid?
[17:44:19] 	 (03CR) 10Krinkle: "It seems this brings back bug 59720." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117203 (owner: 10Esanders)
[17:44:47] 	 Ulfr_: Yes?
[17:45:02] 	 James_F: Thank you so very, very much :D
[17:45:24] 	 (03CR) 10Krinkle: "http://i.imgur.com/bMTG3RI.png" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117203 (owner: 10Esanders)
[17:46:31] 	 Made it child's play to knock out some serious things looming over me 
[17:46:42] 	 Ulfr_: Glad to help. :-)
[17:49:03] 	 (03CR) 10Jforrester: "Possible bugs this fixes:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117215 (owner: 10Esanders)
[17:50:06] 	 Krinkle: Was that bug meant to actually have a title? :-)
[17:50:07] 	 so, backport status?
[17:50:12] 	 Krinkle: ^^^
[17:50:40] 	 (03CR) 10Robmoen: "Rebased" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/100520 (owner: 10Robmoen)
[17:53:07] 	 You guys wanna see z-index bugs? Check this out: http://www.wikidoc.org/index.php?title=Alcohol_withdrawal_resident_survival_guide :P
[17:53:10] 	 Chrome bug
[17:53:22] 	 greg-g: Apparently Krinkle's not responding, so "not happening". :-(
[17:54:02] 	 James_F: oh, forgot to enter a title
[17:54:09] 	 filing my IE9 bugs from yesterday
[17:54:28] 	 Chrome's got worse issues :D
[17:54:28] 	 James_F: k, let me know if something changes later
[17:54:43] 	 greg-g: Krinkle's the only VE team deployer in today, so…
[17:54:49] 	 gotcha
[17:55:54] * Elitre  sad Krenair abandoned 54965 :(
[17:56:42] 	 Elitre, what were you expecting me to do about it?
[17:57:13] 	 fixing it? :D
[17:57:42] 	 I investigated the problem, worked out what was happening and decided that someone else should fix it.
[17:58:12] 	 Eventually I removed the assignee because no one had responded and people were expecting me to fix it
[17:58:22] 	 fair enough. thanks
[17:58:26] 	 Krenair: The fix to Monobook (adding height: 100% on ) seemed sensible. You decided against it?
[17:59:07] 	 Not really, I'm just not clear about what might break
[17:59:35] 	 And also we probably should not be relying on the style having body { height: 100%; }
[17:59:36] 	 It's Monobook. It's already got so many hacks (z-index, anyone?) it's true that it's unclear what might break.
[17:59:37] 	 But. :-(
[18:07:33] 	 I hate, hate, hate that VE still doesn't tell me when I'm adding a red link :-(
[18:07:49] 	 :(
[18:08:17] 	 I realize that if it's not included yet, it's because it's probably hard, but it makes me sad anyway.
[18:10:03] 	 guillom: It should tell you when you're making or editing a link (e.g wjen you're in the link editor).
[18:10:23] 	 It doesn't yet tell you about links on the page when just looking at the editor, that's an open issue.
[18:10:51] 	 yeah, that's what I mean :)
[18:10:54] 	 adding a link should always tell you though, doesn't it for you?
[18:13:37] 	 It probably does; I never really look at the link editor because most of the time, I'm copy/pasting links from another text. And sometimes, the pasting goes badly (probably my fault) and insert a red link.
[18:14:12] 	 It's stuff that I catch when previewing wikitext, but I I can't catch it with VE.
[18:14:38] 	 Sorry for ranting. I shouldn't :) You're doing a great job. I'm just frustrated with red links. I'll go have dinner and all will be better afterwards!
[18:16:46] 	 James_F|Away: k, I'm out. I'll be reachable via hangouts and could get online if needed within like 15 minutes.
[18:21:39] 	 Krinkle|detached: OK.
[18:21:56] 	 guillom: Roan's working on it tomorrow, he claims. :-)
[18:24:40] 	 :)
[18:25:15] * Elitre  hugs guillom
[18:27:25] * guillom  hugs Elitre.
[18:30:18] 	 James_F, I guess I'm just going to upload a patch for this bug and see if it gets approved or not
[18:32:26] 	 It's not ideal but if it gets approved, that's one less high/major bug
[18:38:23] 	 Krenair: Indeed! Thanks.
[18:39:36] 	 Krenair: (I added Krinkle|detached and MatmaRex as reviewers as they're good at spotting regressions and issues in skins.)
[18:40:04] * MatmaRex  just saw that patch scroll by
[18:40:10] 	 it smells a little bit :/
[18:41:04] 	 this should probably be special-cased in OOJS instead, or we should add such a rule to common styles instead of just for particular skins
[18:41:10] 	 MatmaRex: It's replicating code in Vector, Apex and other skins.
[18:41:15] 	 anyway i will investigate later
[18:41:26] 	 MatmaRex: But yes, adding to Common might be more sensible?
[18:41:46] 	 MatmaRex, well, if you want to provide the patch...
[18:41:55] 	 the real issue is, why the hell is body's height equal to 0 :P
[18:42:12] 	 (wild guess: because monobook has position:absolute for everything)
[18:42:43] 	 Wild guess: Because Monobook sucks. :-)
[18:43:39] * Elitre  promises she'll shout if she notices something wrong, if this manages to go live.
[18:44:56] 	 (03PS1) 10Mooeypoo: Get item data from change event in select widget items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117245 
[18:47:21] 	 Ugh, this patch was working when I looked into it a week ago
[18:47:26] 	 What's wrong with it now
[18:47:40] 	 Krenair: MW doesn't love you?
[18:48:03] 	 meh, I just remembered it slightly wrong. Probably should have committed it.
[19:02:34] 	 mooeypoo, were you able to reproduce https://bugzilla.wikimedia.org/show_bug.cgi?id=61282 later? 
[19:03:32] 	 ryasmee__, negative. I can't reproduce this bug. I see images as humongous, I never see an image as dot-size in either master or betalabs. :\
[19:04:10] 	 okay , you wont see it as dot size in read mode after saving.
[19:04:23] 	 so if you go to this page: http://en.wikipedia.beta.wmflabs.org/wiki/Imagedelete?veaction=edit
[19:04:39] 	 ryasmee__, I'm about to run off to class. CAn you add the link to the bug report?
[19:04:46] 	 and make the sizes of the image inside it to a huge size
[19:05:14] 	 then it will get resized to a dot size
[19:05:32] 	 ryasmee__, I just made the width of that image 481000000000
[19:05:33] 	 however, if you save the page it does not look that way
[19:05:36] 	 I see it as huge
[19:05:49] 	 I didn't save anything yet, just looking at VE
[19:06:58] 	 ryasmee__, I just tested this in both Chrome and Firefox on Ubuntu, with the link you gave me
[19:07:00] 	 I reproduced it by making it 4810000000000
[19:07:10] 	 ok hang on
[19:07:34] 	 still see it as huge in both Firefox and Chrome
[19:07:47] 	 :(
[19:08:02] 	 ok we will talk about it later maybe, since you have class now
[19:08:05] 	 but in any case, maybe it would be a good idea to limit the size at some point anyways
[19:08:43] 	 yup that will be a better option to implement i guess
[19:08:52] 	 ryasmee__, if James_F is next to you, can you check if he can look at it? It's hard for me from afar to guess, it might be a browser issue or even an OS thing? I am baffled :\
[19:09:09] 	 I can't manage to replicate this in linux and on Windows.
[19:09:23] 	 very weird. ryasmee__ can you try to replicate this from another computer?
[19:09:59] 	 Its metrics meeting time.So I will talk to him when it is over :)
[19:10:22] 	 oh hehe ok
[19:10:49] 	 ryasmee__, I'm running ot class, but if there's anything new, add it to the bug report. I will come back a bit late, not sure if you'll still be in the office
[19:11:09] 	 I will be on IRC
[19:11:22] 	 sure , I will add it in the bug report
[19:11:35] 	 this is really weird... 
[19:11:44] 	 ok, I really have to run :p I'm tearing myself away from the computer.... now.
[19:36:54] 	 (03CR) 10Trevor Parscal: "The border icon being inverted sort of throws me off." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/116475 (owner: 10Esanders)
[19:38:14] 	 (03CR) 10Trevor Parscal: [C: 032] Get item data from change event in select widget items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117245 (owner: 10Mooeypoo)
[19:40:00] 	 (03CR) 10Trevor Parscal: [C: 032] doc: Improve and fix minor issues in base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/117232 (owner: 10Krinkle)
[19:40:46] 	 (03Merged) 10jenkins-bot: doc: Improve and fix minor issues in base classes [oojs/ui] - 10https://gerrit.wikimedia.org/r/117232 (owner: 10Krinkle)
[19:40:48] 	 (03CR) 10Trevor Parscal: [C: 032] Use en-us spelling 'focused' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117217 (owner: 10Esanders)
[19:41:29] 	 (03Merged) 10jenkins-bot: Get item data from change event in select widget items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117245 (owner: 10Mooeypoo)
[20:10:51] 	 (03PS1) 10Trevor Parscal: Make parameter search widget case insensitive [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117305 
[21:19:50] 	 (03PS1) 10Trevor Parscal: Add icon and indicator widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/117315 
[21:33:49] 	 edsanders: could you look at this? https://gerrit.wikimedia.org/r/#/c/117315/1
[21:33:57] 	 hoping to get a quick review
[21:35:43] 	 sure
[21:36:36] 	 unrelated question, why doesn't SelectWidget have a getValue?
[21:38:13] 	 well
[21:38:15] 	 we could add one
[21:38:27] 	 why doesn't an HTML select element have a getValue?
[21:38:50] 	 not a defense, just saying
[21:39:03] 	 it depends on the access pattern
[21:39:12] 	 html select can be multi-select
[21:39:29] 	 usually you listen to it's change event, which passes the selected item in
[21:40:06] 	 for me something which can only ever have one value should have a simple get/set api
[21:40:09] 	 What is annoying is since getSelectedItem() may return null, getSelectedItem().getValue() is dangerous
[21:40:18] 	 that too
[21:40:34] 	 edsanders: even if it were multi-select, an array of values would be fine
[21:40:38] 	 anyway, I support adding it
[21:40:49] 	 it's not been added because we normally just listen for change events
[21:40:58] 	 so, reading the value is the less common case
[21:41:53] 	 although ours are but one subset of use cases hopefully
[21:42:21] 	 one thing, getValue should return what if nothing in selected? undefined probably
[21:42:28] 	 jQuery provides $.val() shortcut for selects, right?
[21:42:34] 	 it does
[21:42:59] 	 any of the special non-strings would be ok (null/undefined)
[21:43:12] 	 it also returns an array of values in the case of a multi-select
[21:43:29] 	 edsanders: well, the getData() method of an item can return anything
[21:43:39] 	 ah
[21:44:05] 	 null should be used as "normally an object, but currently nothing" and undefined as "we just don't have anything for you"
[21:44:09] 	 I guess undefined then
[21:55:06] 	 TrevorParscal, so Icon & IndicatorWidget share a *lot* of code (and identical css), can we give them a common base class?
[21:57:51] 	 I mean, we could, but they are so small
[21:58:07] 	 I realize they are super similar, identical in the CSS really
[21:58:39] 	 but there are a few other widgets that are just instantiations of element mixins, like LabelWidget
[21:58:50] 	 So, I was following that
[22:01:27] 	 (03PS1) 10Trevor Parscal: Add required indicators to parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117327 
[22:01:53] 	 edsanders: do you think it's really worth introducing another class?
[22:02:12] 	 on balance, it would likely be a net increase of code to reduce the duplication
[22:02:57] 	 slightly more lines, less duplication
[22:03:58] 	 (03CR) 10Esanders: [C: 032] "Personally I think these should inherit from an abstract base class in the future to reduce duplication. To be disucssed..." [oojs/ui] - 10https://gerrit.wikimedia.org/r/117315 (owner: 10Trevor Parscal)
[22:05:09] 	 or you could just give them a common css class, if that doesn't break your pattern too much
[22:05:21] 	 the CSS duplication concerns me more than the JS
[22:05:22] 	 (03Merged) 10jenkins-bot: Add icon and indicator widgets [oojs/ui] - 10https://gerrit.wikimedia.org/r/117315 (owner: 10Trevor Parscal)
[22:13:55] 	 (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (8b13d2b7f7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117329 
[22:14:59] 	 (03CR) 10Trevor Parscal: "I agree that we should seek to reduce the duplication this introduces." [oojs/ui] - 10https://gerrit.wikimedia.org/r/117315 (owner: 10Trevor Parscal)
[22:19:05] 	 edsanders: Please merge https://gerrit.wikimedia.org/r/117328 and https://gerrit.wikimedia.org/r/117329 kthxbai.
[22:19:07] 	 edsanders: I agree with you - I think it should be cleaned up later for sure
[22:21:42] 	 (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.1.0-pre (8b13d2b7f7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117329 (owner: 10Jforrester)
[22:23:00] 	 edsanders: You're wonderful.
[22:42:01] 	 (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (8b13d2b7f7) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/117329 (owner: 10Jforrester)
[22:45:11] 	 (03PS1) 10Jforrester: Update VE core submodule to master (beb5e43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117331 
[22:45:40] 	 (03CR) 10Jforrester: [C: 032] "Trivial pull-through (the OOjs UI change is already in effect in MW-core)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117331 (owner: 10Jforrester)
[22:49:32] 	 Hi, I'm looking to apply for the Outreach Program for Women for the VE plugins project here: https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#VisualEditor_plugins. Could someone point me in the right direction for this? (I'm Madhu and currently doing Hacker School at New York). 
[22:51:18] 	 (03Merged) 10jenkins-bot: Update VE core submodule to master (beb5e43) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117331 (owner: 10Jforrester)
[22:56:06] 	 James_F, TrevorParscal ^
[22:57:05] 	 madhuvishy: hi there
[22:57:14] 	 Hey!
[22:57:15] 	 James_F should be the person to help you
[22:57:18] 	 but, welcome
[22:57:27] 	 Ah great, thanks :)
[22:57:45] 	 he is around, I just poked him
[22:58:16] 	 yay
[23:03:14] 	 (03PS2) 10Trevor Parscal: Add required indicators to parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117327 
[23:03:22] 	 (03PS3) 10Jforrester: Add required indicators to parameter pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117327 (owner: 10Trevor Parscal)
[23:10:46] 	 (03PS8) 10Robmoen: Mixin ClickableNode with ce nodes that have tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 
[23:11:58] 	 (03CR) 10jenkins-bot: [V: 04-1] Mixin ClickableNode with ce nodes that have tools [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/103063 (owner: 10Robmoen)
[23:14:18] 	 (03PS9) 10Robmoen: Create mixin for ce nodes that responds to dblclick [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 
[23:17:27] 	 (03CR) 10Robmoen: "So after rebasing the parent commit, this works for me in FF and Chrome. Qunit tests on parent commit are failing atm though." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/103062 (owner: 10Robmoen)
[23:40:52] 	 (03PS1) 10Trevor Parscal: Keep label and disabled state of transclusion dialog apply button in sync [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117342 
[23:40:58] 	 (03PS1) 10Trevor Parscal: Add fallback template description with link to template page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/117343