somewhere [18:55:21] ah, on the div [18:55:25] ya [18:55:30] RoanKattouw, aren't some URLs valid titles though? [18:55:38] will emulate that on our body [18:55:45] gwicke: It has to be on that

because your UI could be in an LTR language [18:55:53] But yeah for Parsoid it should just be on the body [18:56:03] Krenair: Yes they are. But strings of length >255 are not valid titles [18:56:15] Oh, well yes [18:56:30] (03PS1) 10Jforrester: Move save panel init to getReadyProcess [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137978 [18:56:39] And if A is an invalid title, than A + (any string) will also be an invalid title [18:56:53] So there is no point doing a prefix search on something that contains a banned character, for instance [18:56:54] RoanKattouw, that's something the skin will have to deal with -- ESI or whatever will just inject the body content [18:57:07] Krenair: Limit to 255 sounds like a start, yeah. [18:57:16] Krenair: After all, that's mwTitle's limit anyway. [18:57:32] Actually forget what I said about A and A+(any string) , that's not universally true [18:57:37] Krenair: But also we shouldn't be sending external links to the API anyway. :-) [18:57:38] A nice counterexample is A = 'Talk:' [18:57:52] RoanKattouw: Or ":" as MSE. [18:57:55] So yeah let's just filter out >255 and URLs [18:58:05] James_F, I'm pretty sure URLs can be page titles... [18:58:17] (03CR) 10jenkins-bot: [V: 04-1] Move save panel init to getReadyProcess [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137978 (owner: 10Jforrester) [18:59:11] mediawiki seems to be quite happy letting me create 'Http://wikimedia.org' [18:59:16] Yeah they can be [18:59:21] Krenair: Hmm, true. [18:59:24] We can keep those if you like, and only drop >255 [18:59:48] (03PS5) 10Jforrester: Move save panel init to getReadyProcess [extensions/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/137971 [19:00:36] (03CR) 10Catrope: [C: 032] Move save panel init to getReadyProcess [extensions/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/137971 (owner: 10Jforrester) [19:02:20] (03PS2) 10Jforrester: Move save panel init to getReadyProcess [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137978 [19:02:45] (03Merged) 10jenkins-bot: Move save panel init to getReadyProcess [extensions/VisualEditor] (wmf/1.24wmf8) - 10https://gerrit.wikimedia.org/r/137971 (owner: 10Jforrester) [19:04:00] (03CR) 10Catrope: [C: 04-1] "Migrating debugBar to OO.ui.Element is a good change, but the other changes are all unnecessary or wrong." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137913 (owner: 10Esanders) [19:04:49] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/137978/ [19:05:17] 3VisualEditor / 3Initialisation: Javascript error when launching desktop VisualEditor (target.createSurface is not a function) - 10https://bugzilla.wikimedia.org/66276 (10Ryan Kaldari) 3NEW p:3Unprio s:3major a:3None Whenever I try to launch the desktop VE, I get a JS error... In Firefox: 'target.cr... [19:07:14] 3VisualEditor / 3Initialisation: Javascript error when launching desktop VisualEditor (target.createSurface is not a function) - 10https://bugzilla.wikimedia.org/66276#c1 (10Ryan Kaldari) 5NEW>3RESO/INV Nevermind. Had to update the VE submodules. [19:08:17] 3VisualEditor: VisualEditor: Need a way to add a non-functional label to the top of a popupToolGroup (within the popup) - 10https://bugzilla.wikimedia.org/65377#c3 (10Ryan Kaldari) 5NEW>3RESO/FIX Fixed by https://gerrit.wikimedia.org/r/#/c/134237/ [19:08:53] (03CR) 10Catrope: [C: 032] Move save panel init to getReadyProcess [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137978 (owner: 10Jforrester) [19:11:12] (03Merged) 10jenkins-bot: Move save panel init to getReadyProcess [extensions/VisualEditor] (wmf/1.24wmf7) - 10https://gerrit.wikimedia.org/r/137978 (owner: 10Jforrester) [19:12:44] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should not send invalid titles to the API for suggestions (because it won't be valuable) - 10https://bugzilla.wikimedia.org/66135#c6 (10Alex Monk) External URLs can be valid titles, we just want to ignore invalid titles (i.e. things over 255 charac... [19:15:52] (03PS4) 10Catrope: Calculate offset correctly in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137927 (owner: 10Esanders) [19:15:56] It seems my local wiki is just listing all pages in response to an invalid title... wat. [19:16:09] (no cirrussearch) [19:16:25] Useful. :-) [19:16:28] RoanKattouw: Can I bug you with a VE question when you have a minute? [19:16:37] kaldari: Go for it [19:16:54] (03CR) 10Catrope: "PS4 moves the check for inline slugs to where lengthSum is increased, rather than where lengthSum is used. This fixes bugs with multiple i" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137927 (owner: 10Esanders) [19:17:02] RoanKattouw: Can I show you on my computer? [19:17:06] Sure [19:29:44] 3OOjs UI: OOjs UI: Need a way to add a non-functional label to the top of a popupToolGroup (within the popup) - 10https://bugzilla.wikimedia.org/65377 (10James Forrester) p:5Unprio>3High s:5normal>3enhanc [19:38:58] You guys ruined me. I am so used to working on VE in English, I'm getting totally confused when dealing with the Hebrew version. fffP. [19:39:39] I keep clicking automatically on the wrong button because I go to the left of the page. Damn muscle memory. [19:41:46] mooeypoo: :-D [19:41:59] mooeypoo: You just need to make MW support he-ltr and you'll be fine. [19:42:57] I think that my head will spin into RTL madness if that's ever done. [19:47:58] TrevorParscal: I'm back [19:48:49] Hallo. [19:48:58] Is there a way to do a subst to a template in VE? [19:55:47] mvolz: give me a few minutes [19:57:38] what's the latest on VE's compatability now that Mediawiki 1.23 release has occurred? [19:57:47] aharoni: Ish. [19:57:47] aharoni: To add a template called "Foo", instead tell it to insert "subst:Foo". [19:57:47] aharoni: But it doesn't get the TemplateData (so it's pretty icky). [19:57:47] aharoni: There's a bug asking for an actual checkbox. [20:00:36] (https://bugzilla.wikimedia.org/show_bug.cgi?id=49904 ) [20:00:39] what version of mediawiki should i be using for optimal VE compatability [20:01:23] TrevorParscal: no problem, I'm free for the next two hours so whenever you're ready [20:01:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] Cannot switch to edit source mode , shows the message "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again." on top of the page - 10https://bugzilla.wikimedia.org/66231#c2 (10James Forrester... [20:01:23] thanks James_F [20:01:23] works for what I need for now [20:01:23] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] Cannot switch to edit source mode , shows the message "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again." on top of the page - 10https://bugzilla.wikimedia.org/66231#c3 (10ryasmeen) Veri... [20:01:24] jeffo: apparently minimum compatibility is 1.24 :( [20:02:35] (03PS1) 10Catrope: *Actual* death and/or *actual* destruction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138014 [20:03:06] so i should use the mediawiki master? [20:03:26] (03PS2) 10Catrope: *Actual* death and/or *actual* destruction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/138014 (https://bugzilla.wikimedia.org/66222) [20:03:57] mvolz: I need to get some lunch, so probably about 1 hour from now, we can continue then [20:04:04] ok sounds good! [20:04:06] thank you! [20:05:02] (03PS1) 10Alex Monk: Don't sent invalid titles from the link inspector to the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138016 (https://bugzilla.wikimedia.org/66135) [20:05:38] Krenair: Do you know about mw.Title.newFromText()? It's basically an exception-free version of the mw.Title constructor [20:05:44] (it returns null for invalid) [20:06:30] (03CR) 10Catrope: [C: 04-1] "You should change the try-catch to if ( !mw.Title.newFromText( ... ) ) { , otherwise good to go." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138016 (https://bugzilla.wikimedia.org/66135) (owner: 10Alex Monk) [20:07:26] RoanKattouw_away, I wasn't aware of that no. good to know, fixing in PS2 [20:07:27] (03CR) 10jenkins-bot: [V: 04-1] Don't sent invalid titles from the link inspector to the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138016 (https://bugzilla.wikimedia.org/66135) (owner: 10Alex Monk) [20:09:23] (03PS2) 10Alex Monk: Don't sent invalid titles from the link inspector to the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138016 (https://bugzilla.wikimedia.org/66135) [20:14:27] This patch is stupid. The entire in RTL only "calculate 'right' by using width and left and then delete 'left'" issue? Unnecessary anymore, and I don't even know *why*. [20:14:32] but it works. [20:17:29] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should catch 400 errors from sending overly-long queries to the API - 10https://bugzilla.wikimedia.org/66139#c1 (10Alex Monk) Gerrit change 138016 should make it so that these show invalid title warnings. Though I haven't got CirrusSearch installed... [20:17:36] (03PS3) 10Alex Monk: Don't sent invalid titles from the link inspector to the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138016 (https://bugzilla.wikimedia.org/66135) [20:25:30] 3VisualEditor / 3Editing Tools: VisualEditor: Remove gallery button from the Insert Menu - 10https://bugzilla.wikimedia.org/65936#c2 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [20:28:59] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For a left aligned thumbnail and Frame image, unchecking the wrapping option moves it to the right side of the page - 10https://bugzilla.wikimedia.org/65617#c3 (10ryasmeen) Verified the fix in production [20:29:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] For a left aligned thumbnail and Frame image, unchecking the wrapping option moves it to the right side of the page - 10https://bugzilla.wikimedia.org/65617 (10ryasmeen) 5RESO/?>3VERI [20:30:04] kaldari, is there a bug for the thumb alignment issue? [20:30:47] gwicke: Not currently. I'll create one [20:31:11] kaldari, thx! [20:31:30] gwicke: should I file it under parsoid or VE? [20:32:01] kaldari, parsoid I guess [20:32:05] or core [20:32:21] the CSS is used by VE, Flow, Parsoid etc [20:32:55] did you work on it yet? [20:33:07] could otherwise do so as well [20:33:38] it bugs me now that we have styling in the parsoid service ;) [20:36:48] gwicke: it turns out that VE can add the alignment class to the figure tag (even when none is specified by the parsoid), but it has to load certain JS files and recognize the figure as a content image. On mobile VE, we define images as alien nodes, so it doesn't load that JS. I'm doing some module refactoring in VE so that it can apply the proper HTML rewrites, but keep the image as an alien node. [20:38:19] gwicke: Got kicked off IRC for a second. Did you get my 2 messages above? [20:39:46] kaldari_, I might have missed one [20:39:57] I see " gwicke: it turns out that VE can [...]" [20:40:05] no second one [20:40:07] yeah, that's the last I saw [20:40:13] the other one was... [20:40:15] gwicke: Once I do that, it won't be necessary to change the CSS [20:40:50] kaldari_, VE is moving away from those rewrites, and other users like Flow certainly won't rewrite [20:41:02] so to me fixing the CSS is important [20:41:14] let me do that [20:41:22] gwicke: I could do both [20:41:45] gwicke: Or if you want to handle the CSS change, that's cool with me :) [20:41:48] okay, I won't object to that offer ;) [20:42:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] Left aligned Frameless/Basic image does not move to right upon changing the alignment to Right - 10https://bugzilla.wikimedia.org/65596#c9 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [20:42:24] gwicke: I'll go ahead and do both since I'm already in there [20:42:57] hey... [20:43:13] so what's this i am reading about parsoid php interpreter or some such [20:43:23] i.e. the web service is not used anymore? [20:43:44] as of two weeks ago the parsoid.php extension is no longer needed [20:43:56] but in older versions you'll need to include it, I believe. [20:44:10] oh [20:44:16] but the webservice is still used to post against? [20:44:42] having fits getting VE to work [20:44:46] the node.js service, yup [20:45:03] im not sure what im doing wrong i feel like an idiot [20:45:13] no, it's seriously really hard [20:45:16] :) [20:45:27] i provisioned a new mediawiki instance, brand new, new db new everything [20:45:47] have you got it working at all yet? maybe with vagrant? [20:45:51] i can create a new page and the editor works, but i cannot edit an existing or save the page [20:46:14] if i edit a page i get "Error loading data from server: prasoidserver-http-bad-status: 500" [20:46:30] hm. [20:49:55] Have you tried https://www.mediawiki.org/wiki/Parsoid/Troubleshooting yet? [20:50:55] I bet you didn't do a npm update or async is busted if you did [20:51:43] I used the parsoid extension instead of like the debian/ubuntu parsoid package, but I don't include the parsoid.php in the LocalSettings.config... [20:51:59] hm [20:52:02] The package never seems to have the proper node.js depends [20:52:10] thats not a bad idea [20:52:18] i used the debian package of parsoid [20:52:21] fucking packages, man [20:52:40] me too at first.. async is busted and it's missing like 10 depends [20:52:50] btw, where is this idea of Parsoid php extension installation coming from? [20:52:52] but it shows all appearences of working ;) [20:53:06] is that somewhere in VE instructions? [20:53:13] (it'd be out of date) [20:53:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf7] Making an image Frameless/Basic with centre alignment moves the image to the left - 10https://bugzilla.wikimedia.org/65836#c5 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [20:53:17] it was yesterday [20:53:24] then it was updated after I added a warning [20:53:33] the ve install instructions are impossible to follow [20:54:08] the VE project has forked off so far into WMF support that the install directions are completely wrong (atleast thats how i feel after spending hrs on this) [20:54:34] BUT [20:54:36] hopefully core will alleviate some of the complexities [20:54:39] im also an idiot [20:55:14] LeroyJenkins, just added a note about port 8142 when using the deb [20:55:43] I wouldn't even use the deb... [20:55:55] it avoids a lot of the common pitfalls [20:56:15] did you run into issues with it? [20:56:45] i am about to try a manual install after removing the apt install of parsoid [20:56:48] i will let you know [20:57:57] lemme post on postbin... you may identify as a PEBKAC issue [20:58:14] root [20:58:52] * LeroyJenkins shakes head [20:59:10] James_F: I donsubst [20:59:10] where should i put the parsoid files after i use git into my home dir? [20:59:17] also just pushed 0.1.12 to the repo [20:59:21] [20:59:25] just in /usr/bin/parsoid? [20:59:34] for the extension it should be in /www/wiki/extensions [20:59:44] LeroyJenkins, you don't need the extension [20:59:48] this is not the extension its the service [20:59:50] plus what he said [20:59:56] the extension has the service ;) [20:59:58] aharoni: ? [21:00:03] LeroyJenkins, no [21:00:12] James_F: about that subst thing: It doesn't seem to work. It inserts a literal {{subst:Foo}}. [21:00:57] aharoni: Huh. That's a regression, then. :-( [21:00:59] * James_F meetings. [21:01:31] okay this is getting ridiculous... I'm fixing the RTL at the cost of another issue, which I fix and causes a separate issue which causes a train of issues on top of issues. This whole thing worked before.. I don't understand what happened. [21:02:52] root@wikimedia:/var/www/ram/extensions/parsoid/api# ls s*.js server.js [21:03:04] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] The wrapping option is getting restored again after unchecking for all Image Types - 10https://bugzilla.wikimedia.org/65615#c7 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production [21:03:33] I do my node api/server.js from the extensions/parsoid directory [21:03:35] are ooui css files not subjected to cssjanus? anyone knows? James_F / TrevorP|Away [21:04:04] LeroyJenkins, the thing you checked out there is *not* the PHP extension, it's the node service [21:04:11] those are two different projects & repositories [21:05:41] I used git clone https://gerrit.wikimedia.org/r/p/mediawiki/services/parsoid [21:05:54] yup, that's the service [21:05:59] not mediawiki/extensions/Parsoid [21:06:21] you can also get -- more comfortably -- it via the deb [21:06:46] I tried to do that on another install and it always complains about async [21:06:52] mooeypoo: They… should be? [21:06:56] but that was from backports [21:07:01] s/-- it/--/ s/ --/it --/ [21:07:05] holy fucking shit [21:07:17] its working, but anonymous read/write is on [21:07:22] lol [21:07:26] let me turn that off and turn on cookie forwarding and see if it still works [21:07:30] not ready to celebrate yet [21:07:52] jeffo: Excellent. :-) [21:08:03] LeroyJenkins, we are packaging a recent async version in the deb [21:08:26] James_F, they don't seem to be [21:08:35] jeffo: What did you do differently, do you know? (And can we improve the documentation so others don't get stuck in the same way?) [21:08:41] James_F, oo-ui-window-overlay has left:0; and still left:0 in RTL [21:08:42] mooeypoo: This is in SA or VE-MW? [21:08:48] then again if I fix this, EVERYTHING changes [21:08:51] so we might as well not fix it [21:08:52] mooeypoo: Hmm. [21:08:57] no in ve-mw [21:09:07] That really should get flipped. [21:09:11] but this suggests there might be other problems [21:09:42] Yeah. [21:09:57] it has no @noflip either [21:09:59] very odd. [21:10:12] ah [21:10:16] broken [21:10:16] mooeypoo: maybe because it has svg in filename? [21:10:23] cookie forwarding not working [21:10:26] mooeypoo: @noflips don't work on classes, only on individual statements – there's an RL bug IIRC. [21:10:36] hmm [21:10:39] eranroz, perhaps [21:10:45] (03PS4) 10Catrope: Don't send invalid titles from the link inspector to the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138016 (https://bugzilla.wikimedia.org/66135) (owner: 10Alex Monk) [21:10:45] James_F: mooeypoo: this only affects LESS styles, not CSS [21:10:49] so this is new to me [21:10:51] a new error [21:10:54] im excited [21:10:55] warning/api][localhost/Main_Page] Failed API request, 8 retries remaining. [21:10:55] [warning/api][localhost/Main_Page] Failed API request, 7 retries remaining. [21:10:55] [warning/api][localhost/Main_Page] Failed API request, 6 retries remaining. [21:11:01] what does that mean on a private wiki [21:11:02] it's a lessc bug, or an interoperability bug between lessc and CSSJanus [21:11:04] MatmaRex: OOUI is LESS though. [21:11:12] the transparent blueish thing that covers the templates - what is it called? "sprite"? Or something else? [21:11:14] i've got cookie forwarding on [21:11:25] hrmm never worked with private before [21:11:26] * MatmaRex has no context, just saying [21:11:37] mvolz: hi [21:11:41] you got some time now? [21:11:44] TrevorParscal: heya [21:11:46] yup [21:11:47] there is a whole other article on modifying for private [21:11:50] hmm okay. Well. This is going to be an interesting fix. I'm fixing the position and the input gets smaller (Don't ask me why, it makes no sense) so I fix the width and the position goes all wonky, so I flip the screen properly and everything dies a horrible death full of RTLness. [21:12:13] I read your transclusion model thingy, do you mind if I put on on a media wiki page? [21:12:39] alright im going to pick this up monday [21:12:51] So I am wondering: Should I continue as-is or should we try to get janus to work on the css (which would probably mean changing a bunch of other things, *but* might be a more strategic approahc) or play with left/right mirroring the way things are right now. [21:12:54] James_F, ? ^ [21:12:54] James_F I think gwicke can translate what we did... I thought I was using a "Parsoid Extension" but apparently I was downloading a service [21:12:54] aharoni: The transparent blueish thing is a "highlight" [21:13:02] thanks RoanKattouw [21:13:22] mooeypoo: Where are you testing this? [21:13:27] * gwicke is happy that we got rid of the need for the Parsoid extension -- way too confusing [21:13:27] OOUI demo? VE demo? MW? [21:13:36] RoanKattouw, at home, on my comfortable computer chair. [21:13:41] RoanKattouw, in master ;) [21:13:50] mooeypoo: I think that's more a RoanKattouw question, sorry. [21:13:55] gwicke: Yeah. We desperately need to fix our install guide though, the installation process changed twice in a month [21:14:08] mooeypoo: So that means in VE-MW? [21:14:11] mv oojs-ui.svg.css oojs-ui.css [21:14:16] How did you get the OOJS-UI changes to apply? [21:14:19] RoanKattouw, https://www.mediawiki.org/wiki/Extension:VisualEditor seems to be okay [21:14:25] RoanKattouw, I'm playing around with the mw/resources/lib/oojs-ui files, and then I apply what I see works to the oojs repo files so I can create a patch [21:14:28] so yes, the ve-mw [21:14:42] it's not the standalone, janus should work.. but maybe not on svg.css files [21:14:50] mooeypoo: OK. Note that ve-mw uses oojs-ui from *MW core* so you'll have to mess with *its* oojs-ui build [21:14:58] aye I'm doing that [21:15:14] I'm editing the right files for sure, my edits affect things. [21:15:18] A command I often run is grunt build && yes | cp ~/git/oojs/ui/dist/*.{js,css} ~/git/mediawiki/core/resources/lib/oojs-ui/ [21:15:22] can't wait till I can just apt-get install Mediawiki and it installs/configures the parsoid service and everything just works. [21:15:25] OK good [21:15:32] You said left:0 wasn't being flipped? [21:15:32] they just seem to have unpredictable results [21:16:05] and it SEEMS that it's a mix of things not being flipped + some weird changes in jquery that I can't really understand why in god's name they're happening. [21:16:09] I don't know how BlueSpice depends on VE when it's in such of fluctuating state of development heh [21:16:30] things like this.$element.parent().position().left or offset().width that should have worked until now is suddenly undefined. [21:16:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: "manual subst" doesn't work - 10https://bugzilla.wikimedia.org/66281 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None It's not really possible to subst MediaWiki templates in VE yet (bug 49904). According to James F., it should be possible to... [21:16:43] mooeypoo: OK, so have you audited and replaced all of those? [21:16:48] I did [21:16:53] and there are several weirdnesses [21:17:02] so there are two places where the floating menu didn't work right [21:17:29] in the configuration dialog -- one was in the category add and the other in the first config page where you can refer the page to some other page [21:18:08] Right, the redirect thing [21:18:16] Those are both MWTitleInputWidgets I think [21:18:29] so the weirdness: if I touch nothing of the css files, RoanKattouw, and I just fix the 'width' and positions to things that actually work, the move to new page thing? works perfect. The categories? Semi. The position of the menu is good, but the input becomes 60% smaller. [21:18:39] And I don't even touch the width of anything! [21:18:43] friggin odd. [21:18:48] Weird [21:19:00] Could you put in a WIP patch that does that? [21:19:13] sure hang on [21:19:16] i.e. just fixes the width/position stuff and leaves the 60% smaller thing broken, but doesn't touch anything else [21:19:21] i tried so many things, let me clean my current attempt up [21:19:28] btw RoanKattouw also notice that "right" goes the other way now [21:19:37] because thw window isn't flipped [21:19:50] What isn't flipped? [21:19:56] so right: 100px will actually be 100px to the left of the screen. To show the window inside the screen you need right: negative number [21:20:15] I think that's because the overlay css is left:0 [21:20:18] instead of right:0 [21:20:28] but wait, let me make that wip patch [21:24:27] (03PS1) 10Mooeypoo: [wip] Correct TextInputMenuWidget position for RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/138041 (https://bugzilla.wikimedia.org/65483) [21:24:29] RoanKattouw, ^^ [21:24:34] Thank [21:24:35] s [21:24:46] I'm chasing a link inspector regression right now but I'll take a look at that when I have time [21:24:59] LeroyJenkins, I'm looking forward to nice packaging as well! [21:25:30] gwicke: https://gerrit.wikimedia.org/r/#/c/138038/ [21:25:33] nm, regression was my stupidity [21:25:54] RoanKattouw, I was wrong, the *previous* code made the category input too big. Now the size is right, but its own position is wrong. Anyways, check out my wip fix. It's so weird. [21:26:14] I think some of it is because things are not flipped and some are [21:26:25] some css flips and some didn't [21:26:37] gosh, my english is horrible today. s/flips/flipped [21:26:39] kaldari, thx! [21:26:42] (03CR) 10Catrope: [C: 032] Don't send invalid titles from the link inspector to the API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138016 (https://bugzilla.wikimedia.org/66135) (owner: 10Alex Monk) [21:27:25] mooeypoo: Why are you measuring $container instead of this.$element? [21:27:27] There might be a good reason [21:27:29] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should not send invalid titles to the API for suggestions (because it won't be valuable) - 10https://bugzilla.wikimedia.org/66135 (10James Forrester) 5PATC>3RESO/FIX [21:27:30] Just asking [21:27:43] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should catch 400 errors from sending overly-long queries to the API - 10https://bugzilla.wikimedia.org/66139 (10James Forrester) 5PATC>3RESO/FIX [21:27:54] Or rather, $container's parent rather than this.$element's parent [21:30:05] (03CR) 10Catrope: [C: 031] Calculate offset correctly in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137927 (owner: 10Esanders) [21:30:25] TrevorParscal: When you have time: https://gerrit.wikimedia.org/r/#/c/138014/ [21:32:48] mooeypoo: With that patch, suggestion dropdowns are completely broken for me [21:33:07] which suggestions [21:33:34] link? [21:33:55] and RoanKattouw, this.$element didn't work right [21:34:16] Both suggestions for redirects and categories are shown way off screen [21:34:24] Outside of the dialog anyway [21:34:32] really? [21:34:35] they work for me.. [21:35:01] wait [21:35:12] i have a mismatch between the resource/oojs and the actual patch [21:35:15] baaaaah. hang on [21:36:01] oh, no I don't [21:36:07] RoanKattouw, I am so confused. This works fine for me. [21:36:20] except for the position of the input [21:36:58] For me it's 2px wide and drawn way to the right of the dialog [21:37:05] :/ [21:37:12] Are you sure you have no other changes? [21:37:18] making sure now [21:38:09] mooeypoo, I just noticed that in ref dialog, the content it dir="ltr" and aligned to left in hewiki (I'm too lazy to open bug or report in the VE talk page) [21:38:19] is* [21:38:38] yeah something's up with alignment / flips in the dialogs [21:38:55] RoanKattouw, another point here: The popups are all the same element, right? for links and for the suggestions? [21:39:13] so, without my patch it works fine in links in RTL, but is all screwed up inside the dialog. Something's up with the *dialog* more likely [21:39:25] Links and dialogs are done a bit differently [21:39:35] no I mean the suggestion popup [21:39:38] For dialogs, the input and the dropdown are both in the iframe [21:39:48] For links, the input is in the iframe but the dropdown is in the main document [21:39:56] (because otherwise it would be clipped by the edge of the inspector) [21:40:09] hm [21:41:24] RoanKattouw, I just rebuilt the mw core oojs from the oojs patch I made [21:41:28] testing now to make sure [21:42:57] RoanKattouw, things work wonderfully for me. Resetting cache to make sure. [21:43:38] RoanKattouw, all popups work great in RTL with this patch, the only problem for me is that the categories input is aligned left [21:44:47] It's full width for me [21:44:49] And the suggestions don't appear at all [21:44:51] Did you use &uselang=he or did you change the language in LocalSettings.php? [21:44:55] no no [21:44:58] local settings [21:45:27] and hereby is another problem btw... if this isn't consistent in uselang=he it means the injection of the directionalities is wrong [21:45:33] Yes [21:45:37] it uses document direction instead of UI direction [21:45:44] But I have now set my language to he in LocalSettings and that doesn't help [21:45:46] * RoanKattouw tries disabling ULS [21:45:51] * mooeypoo mehs [21:45:58] RoanKattouw, want me to show you my screen? [21:46:06] this is baffling. [21:46:08] No dice [21:46:15] Could you send me a screenshot [21:46:15] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null - 10https://bugzilla.wikimedia.org/65616#c8 (10ryasmeen) 5RESO/?>3VERI Verified the fix in production. [21:46:16] ? [21:46:19] RoanKattouw, sure [21:50:20] (03PS1) 10Kaldari: Split off core image components from pieces needed for image inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138096 [21:50:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] Make full size button is getting disabled, the Default Size becomes empty after switching to custom size - 10https://bugzilla.wikimedia.org/65611 (10ryasmeen) 5RESO/?>3VERI [21:51:22] (03PS2) 10Kaldari: Split off core image components from pieces needed for image inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138096 [21:51:48] RoanKattouw, for some reason it won't take a screenshot of the redirect popup [21:52:08] i just noticed i sent you one without the popup in there, but it does appear right under the input [21:52:29] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/138096/ [21:54:27] mooeypoo: Link inspector WFM, category dialog looks the same except the dropdown doesn't appear at all for me [21:54:39] :\ [21:54:43] wtf? [21:54:52] RoanKattouw, we're both testing the same patch. [21:55:05] ... and it works for me in both chrome and firefox [21:55:09] what the hell? [21:56:01] RoanKattouw, btw, with my patch in oojs, when i built and copied the build files over to the mw resources, there are *other* changes in oojs that are completely unrelated [21:56:04] but they shouldn't affect anything [22:11:01] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: node is null appearing while trying to open an image which was modified to Right-Basic-Border just after inserting it in the previous edit session - 10https://bugzilla.wikimedia.org/66286 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created at... [22:11:31] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: node is null appearing while trying to open an image which was modified to Right-Basic-Border just after inserting it in the previous edit session - 10https://bugzilla.wikimedia.org/66286#c1 (10ryasmeen) 5NEW>3ASSI a:3Moriel Schottlender Try the... [22:14:58] mooeypoo: Let me check /that/ [22:15:03] mooeypoo: Do you have master of MW core BTW? [22:15:18] Cause I don't see any unrelated changes in oojs-ui outside of comments [22:16:36] (03CR) 10Catrope: [C: 032] Split off core image components from pieces needed for image inspector [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/138096 (owner: 10Kaldari) [22:19:17] mooeypoo/RoanKattouw: Getting this issue on en.wiki:https://bugzilla.wikimedia.org/show_bug.cgi?id=66286 :S [22:19:37] mooeypoo: If I change $container.parent() to this.$element.parent() it works perfectly for me [22:20:45] (03PS2) 10Catrope: [WIP] Correct TextInputMenuWidget position for RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/138041 (https://bugzilla.wikimedia.org/65483) (owner: 10Mooeypoo) [22:20:52] mooeypoo: See PS2, that works for me [22:28:40] (03CR) 10Esanders: [C: 032] Calculate offset correctly in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137927 (owner: 10Esanders) [22:30:44] 3VisualEditor / 3Editing Tools: VisualEditor: TypeError: node is null appearing while trying to open an image which was modified to Right-Basic-Border just after inserting it in the previous edit session - 10https://bugzilla.wikimedia.org/66286 (10James Forrester) p:5Unprio>3Normal [22:38:38] err [22:39:05] RoanKattouw, sorry, the super came by unexpectedly. I'm checking now [22:40:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "manual subst" hack doesn't work any more - 10https://bugzilla.wikimedia.org/66281 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor [22:40:00] 3VisualEditor / 3Editing Tools: VisualEditor: Support "substituting" templates in transclusion dialog - 10https://bugzilla.wikimedia.org/49904 (10James Forrester) [22:40:30] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf8] TypeError:this.documentView is null appearing after saving an edit and then reopening the VE again, also cannot switch to edit source mode after that in Firefox - 10https://bugzilla.wikimedia.org/66222 (10James Forrester) s:5critic>3major a:... [22:43:53] (03PS3) 10Esanders: Use this.$ where available [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137913 [22:43:55] (03PS3) 10Esanders: [BREAKING CHANGE] Debug bar refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137914 [22:43:57] (03PS8) 10Esanders: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [22:45:05] RoanKattouw, it works the same for me [22:45:24]