[00:27:13] 3VisualEditor / 3Mobile: VisualEditor Mobile: References require double tap to be selected on iOS Safari - 10https://bugzilla.wikimedia.org/66999#c4 (10James Forrester) (In reply to Ed Sanders from comment #3) > Isn't this fixed then (comment 1)? … no? Comment 1 says that the context being useless ("the ta... [00:29:47] 3VisualEditor: VisualEditor: Section headings look like they've been removed, but they're still present when the page is saved - 10https://bugzilla.wikimedia.org/67061 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None Created attachment 15721 --> https://bugzilla.wikimedia.org/attachment.cgi?id=1572... [00:30:28] 3VisualEditor: VisualEditor: Section headings look like they've been removed, but they're still present when the page is saved - 10https://bugzilla.wikimedia.org/67061#c1 (10WhatamIdoing) Created attachment 15722 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15722&action=edit What it looked like just... [00:30:58] 3VisualEditor: VisualEditor: Section headings look like they've been removed, but they're still present when the page is saved - 10https://bugzilla.wikimedia.org/67061#c2 (10WhatamIdoing) Created attachment 15723 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15723&action=edit One of these things is n... [00:31:14] 3VisualEditor: VisualEditor: Section headings look like they've been removed, but they're still present when the page is saved - 10https://bugzilla.wikimedia.org/67061 (10WhatamIdoing) [00:34:28] Anyone in? [00:34:46] 3VisualEditor: VisualEditor: Only part of the citation template is selected within the Insert > Reference dialog - 10https://bugzilla.wikimedia.org/67062 (10WhatamIdoing) 3NEW p:3Unprio s:3trivia a:3None Created attachment 15724 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15724&action=edit... [00:36:31] 3VisualEditor / 3Mobile: VisualEditor Mobile:The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3Ed Sanders Created attachment 15725 --> https://bugzilla.wikimedia.or... [00:36:44] atyp: Yes. How can I help? [00:36:59] 3VisualEditor / 3Mobile: VisualEditor Mobile:The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063#c1 (10ryasmeen) Created attachment 15726 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15726&action=edit Screen... [00:37:03] Hi James_F [00:40:46] I'm trynig to get a wiki running in our company and would like to use visual editor as every other time I have tryed to get a wiki adopted colleagues don't use it because they're scared of mark up [00:41:12] * James_F nods. [00:41:24] That's a common problem with wikitext on internal wikis, yes. [00:41:45] Is visual editor usable? [00:41:56] It seems quite involved to impliment [00:42:34] It's a bit more than a "normal" MediaWiki extension, but it's not too hard. [00:44:01] OK, I have been looking at potentially using turnkey linux mediawiki and node.js appliances as a base [00:44:18] do you think that's do-able [00:44:19] ? [00:44:34] Yes, that should work reasonably well. [00:44:43] Depending on the version of MediaWiki though. [00:45:06] VE only works really with MediaWiki 1.23 which is very new (< 1 month) so appliances may not be updated yet. [00:47:14] 3VisualEditor / 3ContentEditable: VisualEditor: Highlight for multi-line inline template only applies to the first line of it - 10https://bugzilla.wikimedia.org/67062 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [00:49:17] I'll check what MediaWiki version it uses [00:55:00] includes/DefaultSettings.php says 1.19.16+dfsg-0+deb7u1 [00:55:20] Well, that definitely won't work. :-( [00:56:47] That's the version of MediaWiki from May 2012. [01:09:04] Just upgraded it to 1.23.0 [01:09:40] I reckon there are a lot of out of dat mediawikis out there [01:11:44] 3VisualEditor / 3Editing Tools: VisualEditor: Turn lists dropdown into a "split button" with "make bulleted list" the primary action - 10https://bugzilla.wikimedia.org/66940#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal Hmm. Maybe. Is bulleted list the principal structure-action people will tak... [01:11:59] 3VisualEditor / 3Editing Tools: VisualEditor: Turn structure dropdown into a "split button" with "make bulleted list" the primary action - 10https://bugzilla.wikimedia.org/66940 (10James Forrester) [01:12:17] atyp: Probably. :-( 1.19.16 at least has the latest security updates. [01:15:59] so 1.23 is new enough to give VE a whirl? [01:17:25] Yes. [01:17:42] atyp: Follow the git instructions in https://www.mediawiki.org/wiki/Extension:VisualEditor#Download [01:20:33] atyp: Not the manual tarball, as it's wrong. [01:30:10] cool, cloning the got repo now [01:30:12] BRB [01:54:13] OK James_F I'm back (thank you too BTW) [01:57:23] atyp: No worries. [01:58:15] So the VE extension is git-ed do I need to get parsoid going now? [01:59:56] Yes. [02:00:16] (03CR) 10Jforrester: [C: 04-1] "SimpleModalDialog's line:" [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [02:04:33] ha, the deb intructions on https://www.mediawiki.org/wiki/Parsoid/Setup point to a 404 [02:06:53] atyp: Bah. gwicke ^^^ [02:10:12] gwicke? [02:13:12] atyp: gwicke is the lead of the Parsoid team, but he's not active on IRC right now; I was flagging it for him to find and fix when he's next online. [02:13:40] Ahuh, ta. [02:13:46] * James_F goes too now. [02:13:47] Sorry! [02:13:59] Isn't there a node specific package manager? npm or something? [02:14:18] There is, yes. You can easily install Parsoid from git, too. [02:14:33] The "Manual installation" steps on that page. [02:14:39] I will be around tomorrow to help more if you need it. [02:15:08] Thanks [03:13:58] atyp: works for me [03:15:25] atyp: which architecture are you using? [03:15:51] we currently distribute amd64 only [04:52:17] Anyone know if it's bad to run parsoid on a seperate host to mediawiki? [04:55:52] atyp: if the network between MediaWiki & Parsoid is reasonable, then that's normally a good thing [04:56:53] I'm intending they be 2 VMs on the same hypervisor (and the intended audiecne is internal to a company of around 12) [04:57:13] then the gain will be somewhat limited [04:58:24] if it's on the same physical machine I'd just run them in the same VM [04:59:08] assuming that VM can use all cores [05:38:16] thanx gwicke [08:50:34] 3VisualEditor / 3Editing Tools: Toolbar alignment out of whack - 10https://bugzilla.wikimedia.org/67071 (10Derk-Jan Hartman) 3NEW p:3Unprio s:3normal a:3None Created attachment 15732 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15732&action=edit screenshot of problem [08:51:46] 3VisualEditor / 3Editing Tools: Toolbar alignment out of whack - 10https://bugzilla.wikimedia.org/67071#c1 (10Derk-Jan Hartman) Created attachment 15733 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15733&action=edit Another problem The second problem i sometimes see after initially loading. Intera... [08:57:48] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (owner: 10Mooeypoo) [10:20:37] (03CR) 10Esanders: Merge Media Edit and Media Insert dialogs (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 (owner: 10Mooeypoo) [10:38:58] (03PS1) 10Esanders: Add missing TableCell CSS file and Vector-specific rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141923 (https://bugzilla.wikimedia.org/65416) [10:39:05] (03PS3) 10Krinkle: build: Update jscs and use new "wikimedia" preset [oojs/core] - 10https://gerrit.wikimedia.org/r/141443 [10:41:08] (03CR) 10jenkins-bot: [V: 04-1] Add missing TableCell CSS file and Vector-specific rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141923 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [11:01:02] 3VisualEditor / 3Editing Tools: VisualEditor: Turn structure dropdown into a "split button" with "make bulleted list" the primary action - 10https://bugzilla.wikimedia.org/66940#c2 (10This, that and the other) I think you're slightly misunderstanding what is meant by "split button". There is no single "prima... [11:07:35] (03PS1) 10Esanders: Add Table CSS file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141928 [11:07:44] (03PS1) 10Esanders: Use subtle border styling for unstyled tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141929 [11:08:12] (03PS1) 10Krinkle: build: Use Istanbul for code coverage [oojs/core] - 10https://gerrit.wikimedia.org/r/141930 [11:08:39] (03PS2) 10Krinkle: build: Use Istanbul for code coverage [oojs/core] - 10https://gerrit.wikimedia.org/r/141930 [11:08:44] (03CR) 10jenkins-bot: [V: 04-1] Add Table CSS file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141928 (owner: 10Esanders) [11:09:45] (03CR) 10jenkins-bot: [V: 04-1] build: Use Istanbul for code coverage [oojs/core] - 10https://gerrit.wikimedia.org/r/141930 (owner: 10Krinkle) [11:18:57] (03PS3) 10Krinkle: build: Use Istanbul for code coverage [oojs/core] - 10https://gerrit.wikimedia.org/r/141930 [11:20:03] (03CR) 10jenkins-bot: [V: 04-1] build: Use Istanbul for code coverage [oojs/core] - 10https://gerrit.wikimedia.org/r/141930 (owner: 10Krinkle) [11:26:07] (03PS4) 10Krinkle: build: Use Istanbul for code coverage [oojs/core] - 10https://gerrit.wikimedia.org/r/141930 [11:35:32] 3VisualEditor / 3Editing Tools: Toolbar alignment out of whack - 10https://bugzilla.wikimedia.org/67071#c2 (10Ed Sanders) WFM in Chrome & Firefox. What browser/version/OS are you using? [11:42:31] 3VisualEditor / 3ContentEditable: VisualEditor: Highlight for multi-line inline template only applies to the first line of it - 10https://bugzilla.wikimedia.org/67062#c1 (10Ed Sanders) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 52339 *** [11:42:46] 3VisualEditor / 3ContentEditable: VisualEditor: Selection highlighting breaks if an inline alien wraps - 10https://bugzilla.wikimedia.org/52339#c5 (10Ed Sanders) *** Bug 67062 has been marked as a duplicate of this bug. *** [11:43:01] 3VisualEditor / 3ContentEditable: VisualEditor: Highlight for multi-line inline template only applies to the first line of it - 10https://bugzilla.wikimedia.org/67062#c2 (10Ed Sanders) Works on beta labs. [11:48:02] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf10] Context menus are appearing and then disappearing right after adding cite options/references/formula/image - 10https://bugzilla.wikimedia.org/66855#c1 (10Ed Sanders) Verified working in master. [11:50:17] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf10] Context menus are appearing and then disappearing right after adding cite options/references/formula/image - 10https://bugzilla.wikimedia.org/66855#c2 (10Ed Sanders) Updated MW core and it broke, must be an OOJS regression. [12:00:40] (03PS1) 10Krinkle: test: Add test for mixinClass with static properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141936 [12:00:42] (03PS1) 10Krinkle: test: Add test for getObjectValues with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141937 [12:00:44] (03PS1) 10Krinkle: test: Add test for compare() with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141938 [12:07:01] (03PS1) 10Esanders: Revert "Accessibility: Restore element focus when a window closes" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141940 (https://bugzilla.wikimedia.org/66855) [12:07:04] (03CR) 10jenkins-bot: [V: 04-1] Revert "Accessibility: Restore element focus when a window closes" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141940 (https://bugzilla.wikimedia.org/66855) (owner: 10Esanders) [12:07:33] (03PS2) 10Esanders: Revert "Accessibility: Restore element focus when a window closes" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141940 (https://bugzilla.wikimedia.org/66855) [12:08:44] (03CR) 10jenkins-bot: [V: 04-1] Revert "Accessibility: Restore element focus when a window closes" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141940 (https://bugzilla.wikimedia.org/66855) (owner: 10Esanders) [12:25:40] (03PS1) 10Krinkle: test: Clean up test for copy() [oojs/core] - 10https://gerrit.wikimedia.org/r/141943 [12:25:42] (03PS1) 10Krinkle: test: Add test for copy( Object, Function callback ) [oojs/core] - 10https://gerrit.wikimedia.org/r/141944 [12:25:54] (03CR) 10jenkins-bot: [V: 04-1] test: Add test for copy( Object, Function callback ) [oojs/core] - 10https://gerrit.wikimedia.org/r/141944 (owner: 10Krinkle) [12:26:40] (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/141944 (owner: 10Krinkle) [12:40:43] (03PS1) 10Esanders: Cache block drop position data before setTimeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141949 (https://bugzilla.wikimedia.org/67040) [12:42:17] 3VisualEditor / 3Editing Tools: Toolbar alignment out of whack - 10https://bugzilla.wikimedia.org/67071#c3 (10Ed Sanders) *** Bug 66988 has been marked as a duplicate of this bug. *** [12:42:17] 3VisualEditor: VisualEditor: Toolbar is sometimes misaligned and ugly at Beta Labs in Safari - 10https://bugzilla.wikimedia.org/66988#c1 (10Ed Sanders) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 67071 *** [12:43:35] edsanders: Hm.. checking code coverage turns out to be useful. Found a bug in EventEmitter. [12:43:50] that's not good [12:43:53] .on() claims to not bound a function multiple times if you give it the same event name / callback. [12:44:12] e.g. on('a', callback).on('a', callback).emit('a') should that fire it once or twice? [12:44:20] Documentation says once, tests assert twice. [12:44:26] the code has a silly typo [12:44:43] https://github.com/wikimedia/oojs/blob/master/src/EventEmitter.js#L48 [12:44:48] asserts bindings. instead of binding. [12:44:54] which is always undefined / matches [12:45:06] It's subtle enough that it's not really a bug, theyre both understandable behaviour. [12:45:30] Dont' want to break it, but maybe fixing it will actually fix something, or maybe we're relying on this? [12:47:59] What'd ya think, should we repair it and introduce it as a feature? Or drop it. I'm inclined to remove it and say if youre binding it twice, that's either on purpose or an error I don't want to mask in EventEmitter. [13:03:43] I don't think we should be double binding anywhere [13:03:57] fix it [13:09:19] maybe throw an exception? [13:11:35] (03PS1) 10Krinkle: test: Clean up EventEmitter tests [oojs/core] - 10https://gerrit.wikimedia.org/r/141956 [13:11:37] (03PS1) 10Krinkle: EventEmitter: Remove dead code that claims to prevent double bindins [oojs/core] - 10https://gerrit.wikimedia.org/r/141957 [13:11:39] (03PS1) 10Krinkle: EventEmitter: Support events named "hasOwnProperty" [oojs/core] - 10https://gerrit.wikimedia.org/r/141958 [13:28:01] (03PS1) 10Krinkle: EventEmitter: Remove redundant 'if' statement in off() [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 [13:28:03] (03PS1) 10Krinkle: test: Add test for passing EventEmitter#connect a function [oojs/core] - 10https://gerrit.wikimedia.org/r/141961 [13:28:22] (03CR) 10jenkins-bot: [V: 04-1] test: Add test for passing EventEmitter#connect a function [oojs/core] - 10https://gerrit.wikimedia.org/r/141961 (owner: 10Krinkle) [13:28:31] (03CR) 10jenkins-bot: [V: 04-1] EventEmitter: Remove redundant 'if' statement in off() [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 (owner: 10Krinkle) [13:31:15] (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 (owner: 10Krinkle) [13:31:22] (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/141961 (owner: 10Krinkle) [13:34:02] (03PS2) 10Krinkle: EventEmitter: Remove dead code that claims to prevent double bindings [oojs/core] - 10https://gerrit.wikimedia.org/r/141957 [13:34:06] (03PS2) 10Krinkle: EventEmitter: Support events named "hasOwnProperty" [oojs/core] - 10https://gerrit.wikimedia.org/r/141958 [13:34:10] (03PS2) 10Krinkle: EventEmitter: Remove redundant 'if' statement in off() [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 [13:37:09] (03PS2) 10Krinkle: test: Add test for passing EventEmitter#connect a function [oojs/core] - 10https://gerrit.wikimedia.org/r/141961 [13:59:34] (03CR) 10Esanders: [C: 032] build: Update jscs and use new "wikimedia" preset [oojs/core] - 10https://gerrit.wikimedia.org/r/141443 (owner: 10Krinkle) [14:00:07] (03Merged) 10jenkins-bot: build: Update jscs and use new "wikimedia" preset [oojs/core] - 10https://gerrit.wikimedia.org/r/141443 (owner: 10Krinkle) [14:01:15] hi, how to parse wikitext to JSON and add it to document? [14:01:45] (parsefragment in API can parse it to html) [14:02:15] (03PS3) 10Esanders: Revert "Accessibility: Restore element focus when a window closes" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141940 (https://bugzilla.wikimedia.org/66855) [14:03:33] I tried newFromDocumentInsertion with the result from API, but it seems to be wrong way :) [14:04:50] (03CR) 10Krinkle: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 (owner: 10Krinkle) [14:04:54] (03CR) 10jenkins-bot: [V: 04-1] EventEmitter: Remove redundant 'if' statement in off() [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 (owner: 10Krinkle) [14:06:13] (03PS2) 10Krinkle: test: Add test for compare() with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141938 [14:06:15] (03PS2) 10Krinkle: test: Add test for getObjectValues with inherited properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141937 [14:06:17] (03PS2) 10Krinkle: test: Add test for mixinClass with static properties [oojs/core] - 10https://gerrit.wikimedia.org/r/141936 [14:06:19] (03PS2) 10Krinkle: test: Clean up test for copy() [oojs/core] - 10https://gerrit.wikimedia.org/r/141943 [14:06:21] (03PS3) 10Krinkle: EventEmitter: Remove redundant 'if' statement in off() [oojs/core] - 10https://gerrit.wikimedia.org/r/141960 [14:06:23] (03PS3) 10Krinkle: EventEmitter: Remove dead code that claims to prevent double bindings [oojs/core] - 10https://gerrit.wikimedia.org/r/141957 [14:06:25] (03PS5) 10Krinkle: build: Use Istanbul for code coverage [oojs/core] - 10https://gerrit.wikimedia.org/r/141930 [14:06:27] (03PS2) 10Krinkle: test: Clean up EventEmitter tests [oojs/core] - 10https://gerrit.wikimedia.org/r/141956 [14:06:29] (03PS3) 10Krinkle: EventEmitter: Support events named "hasOwnProperty" [oojs/core] - 10https://gerrit.wikimedia.org/r/141958 [14:06:31] (03PS2) 10Krinkle: test: Add test for copy( Object, Function callback ) [oojs/core] - 10https://gerrit.wikimedia.org/r/141944 [14:06:43] (rebase due to path conflict with package.json from the jscs upgrade) [14:08:42] (03PS2) 10Esanders: Add missing TableCell CSS file and Vector-specific rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141923 (https://bugzilla.wikimedia.org/65416) [14:08:44] (03PS2) 10Esanders: Add Table CSS file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141928 [14:09:59] (03CR) 10jenkins-bot: [V: 04-1] Add Table CSS file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141928 (owner: 10Esanders) [14:23:58] i can't beutify v.core in enwiki (chrome) [14:27:05] eranro: Works for me [14:27:40] eranro: What are you doing exactly? Writing a gadget that allows user to input wikitext, and then parse and add to the document? [14:28:22] yes [14:28:54] You'll need to create a transaction so the surface knows where to insert the new html (start, end, at cursor etc.) [14:28:59] +Krinkle, I'm actually trying to add backward compatability for a gadget that accept wikitext as input [14:29:24] Does the gadget activate while inside the editor? [14:29:35] If you're on a diferent page you can use the API to do to that [14:29:42] and let the server handle it [14:29:50] action=edit ; append; text= [14:29:52] something like that [14:30:44] eranro: I don't know how this gadget operates, but it seems reasonable to not support wikitext when using the gadget inside visualeditor. You could have it switch to wikitext mode when the user is on action=edit. [14:31:05] and manifest as visualeditor puginn when the user is on veaction=edit [14:32:08] I tried to add documet as follows: ve.dm.Transaction.newFromDocumentInsertion(doc, rng, parser.parseFromString(data.visualeditor.content,'text/html'),newRng); [14:33:22] I guess just adding document is probably wrong (and adding it with newFromInsertion/Replacement) should work, but then I have to parse it to json [14:34:03] I'm not too familiar with the transaction model in VE. I might be able to help with the larger issue though. Which gadget is this? [14:35:29] It is pathoschild.templatescript, which is actually a gadget framework more than a gadget by itself. I managed to make it work in VE and insert templates, but in the code configuration it is possible to set template as 'hi {{welcome}}' [14:36:09] so i thought it would be nice to keep backwrd compatability and use some ve magic to convert it to ['hi', {template: {name:'welcome' ....} } [14:36:56] and then use ve.insertFromReplacement( magic) :) [14:47:51] Hm.. looks like everything changed since I last looked at it. Spent 10 minutes searching but can't find it [14:48:31] edsanders: Do you know how ve.ui.MWTransclusionDialog (or its ancestors) actually do the transaction to insert one or more new template models in the DM? [14:49:06] I got it down to .fragment and .getSelectedNode() but don't see any calls to that from anywhere near a transaction. [14:50:46] Ah, nvm. It's the other way around. the model attaches itself [14:51:25] MWTransclusionModel#insertTransclusionNode is called from MWTemplateDialog#applyChanges [14:52:05] eranro: If you can get a SurfaceFragment instance, you can use SurfaceFragment#insertContent [14:53:52] +Krinkle, thanks. so insertContent can accept new document? [14:54:04] it takes a linear model I believe [14:54:57] example call https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/dm/models/ve.dm.MWTransclusionModel.js#L58-L67 [14:55:33] I'm not sure whether there is a more direct method, but I guess you can use ve.dm.Converter to convert the Parsoid HTML DOM to linear json [14:55:55] getModelFromDom() [14:56:35] thanks. I will try the ve.dm.Converter to convert [14:56:53] getDataFromDomClean() actually [14:57:04] since you'll want the flat json, not the dm objects [15:07:24] amm how to create a "correct" converter? I tried to simply use new ve.dm.Converter() and use it converter.getDataFromDomClean('
hi
') but it requires nodeFactory [15:12:48] nvm, I used Converter instead of converter :) [15:23:22] ve.dm.converter for DOM retrived using parsefragment API action, seems to clean most of the data [15:23:38] (it keeps only simple string, not the template itself) [15:24:32] 3VisualEditor / 3ContentEditable: VisualEditor: For an image inside sub-surfaces (e.g. caption of an image) the context menu appears aligned differently with the image shield - 10https://bugzilla.wikimedia.org/66494#c1 (10Ed Sanders) WFM in beta labs [15:35:34] 3VisualEditor / 3MediaWiki integration: VisualEditor: wikitext warning is displayed multiple times in one session - 10https://bugzilla.wikimedia.org/67083 (10Ed Sanders) 3NEW p:3Unprio s:3normal a:3Alex Monk 1. '[[' to a paragraph and dismiss the wikitext warning 2. type in another paragraph then re-... [15:40:48] (03PS1) 10Esanders: Don't try to change offset for vesection=0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141977 (https://bugzilla.wikimedia.org/66674) [15:47:17] 3VisualEditor / 3Editing Tools: VisualEditor: Make it easier to select a link in its entirety (instead of part it) - 10https://bugzilla.wikimedia.org/37939 (10Krinkle) [15:51:19] 3MediaWiki extensions / 3TemplateData: TemplateData table uses deprecated element - 10https://bugzilla.wikimedia.org/67084 (10Helder) 3NEW p:3Unprio s:3normal a:3None (Spotted thanks to https://en.wikipedia.org/w/index.php?oldid=609235561&diff=613424016 ) https://github.com/wikimedia/mediawiki-... [16:01:26] (03PS1) 10Esanders: Render a placeholder when extension contents are empty [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141985 (https://bugzilla.wikimedia.org/66813) [16:01:46] 3VisualEditor / 3Editing Tools: VisualEditor: Make it hard for users to partially-select some unlinked text for linking - 10https://bugzilla.wikimedia.org/37939#c14 (10James Forrester) (In reply to Krinkle) > VisualEditor: Make it hard for users to partially-select some text for linking > → > VisualEditor: M... [16:02:01] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should have bottom margin to avoid cutting the page (UX) - 10https://bugzilla.wikimedia.org/52436#c1 (10Krinkle) We have similar logic in the dropdown menus and dialogs already. They never touch the bottom of the window.. No Touching! [16:05:02] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery inspector/Link inspector opens with an animation from left to right for a specific case - 10https://bugzilla.wikimedia.org/60501#c4 (10Krinkle) This also happens when working with a list of links. 1. Have a page with a list containing a list item with a... [16:06:02] 3MediaWiki extensions / 3TemplateData: TemplateData table uses deprecated element - 10https://bugzilla.wikimedia.org/67084#c1 (10Technical 13) You might be amazed at how much Wikipedia looks like a battleground with that little bit of CSS... [16:07:47] 3VisualEditor / 3Editing Tools: VisualEditor: Link insertion dialog should preserve the case of the initial character - 10https://bugzilla.wikimedia.org/53495 (10Krinkle) [16:07:47] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should make it easier to change the label - 10https://bugzilla.wikimedia.org/51438 (10Krinkle) [16:07:47] 3VisualEditor / 3Editing Tools: VisualEditor: Wikilink editing does not permit easy alteration of display text - 10https://bugzilla.wikimedia.org/50945 (10Krinkle) [16:07:47] 3VisualEditor: Internal wikilinks should not have strange piping like "e[[Example|xample]]" - 10https://bugzilla.wikimedia.org/53193 (10Krinkle) [16:07:48] 3VisualEditor / 3Editing Tools: VisualEditor: Link input widget should have separate inputs for target and display text - 10https://bugzilla.wikimedia.org/53973 (10Krinkle) [16:07:49] 3VisualEditor: VisualEditor: Changing the first letter of wikilinked words is difficult - 10https://bugzilla.wikimedia.org/53210 (10Krinkle) [16:08:11] (03PS2) 10Jforrester: Use rather than elements for HTML5-ification [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140843 (https://bugzilla.wikimedia.org/67084) [16:08:18] 3MediaWiki extensions / 3TemplateData: TemplateData: Use rather than elements in the display table - 10https://bugzilla.wikimedia.org/67084 (10James Forrester) 5NEW>3PATC p:5Unprio>3Normal s:5normal>3trivia a:3James Forrester [16:12:00] Krinkle: https://gerrit.wikimedia.org/r/#/c/140843/ is a trivial review, BTW… [16:18:47] 3VisualEditor / 3ContentEditable: VisualEditor: For an image inside sub-surfaces (e.g. caption of an image) the context menu appears aligned differently with the image shield - 10https://bugzilla.wikimedia.org/66494#c3 (10James Forrester) But not for me (though the highlight is correctly aligned now). [16:18:47] 3VisualEditor / 3ContentEditable: VisualEditor: For an image inside sub-surfaces (e.g. caption of an image) the context menu appears aligned differently with the image shield - 10https://bugzilla.wikimedia.org/66494#c2 (10James Forrester) Created attachment 15743 --> https://bugzilla.wikimedia.org/attachme... [16:19:18] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector ignores selected value - 10https://bugzilla.wikimedia.org/65343#c3 (10Krinkle) 5RESO/FIX>3REOP Following the steps exactly as per comment #0 still exhibits this bug exactly. I can reproduce it locally on latest master by making a link to User:... [16:32:19] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a new link is unusable - 10https://bugzilla.wikimedia.org/67086 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None We have an imho fundamentally broken model for inserting links. I don't know why we show the Link tool in the toolbar when there is no se... [16:32:20] James_F: Ugh, http://cl.ly/3s460Q442L3S I hope you're laughing when watching that [16:33:16] Krinkle: Oh, lovely. [16:34:02] Krinkle: Also, that bug report is dreadful. If it wasn't filed by a team member, it would be INVALID'ed. [16:34:26] Krinkle: You seem to have written an e-mail and accidentally copied it into Bugzilla instead. Bugs are meant to be focussed. [16:34:32] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a new link is unusable - 10https://bugzilla.wikimedia.org/67086#c1 (10Krinkle) Regarding the pawn, that also ate the first character (see "bc" instead of "abc" appear in the recording). [16:34:42] James_F: I don't know where to start. I think we have bugs for these already. [16:34:49] I looked through 300 bugs for link inspector but found none [16:35:06] Krinkle: From inspection, about half of your comments are "this works", and another quarter are existing bugs. [16:35:20] It's going to take me hours to turn your report into actionable requests. [16:35:24] This is not cool. [16:35:47] I've tried to be as detailed an investigative as I can in the bottom list. [16:36:07] Maybe it can be the premise of a rewrite instead of dozens of bugs. [16:36:07] Why didn't you file them as separate bugs? [16:36:22] We just /did/ a rewrite two weeks ago. [16:36:33] edsanders, how do I attach a document to a node that's not attached to the document? You mean attaching the document separately? [16:36:42] I woudn't know where to begin. They'd either be overlapping bugs, or stories (use cases). IN which case I'd argue "inserting a link" is a story. [16:36:45] So probably, half of these are regressions rather than new bugs. [16:37:28] I find it very frustrating that every time I try to edit with VE with anything related to links, it takes a dozen tries to get it right. [16:37:44] And yet it works every time for most people. [16:37:48] I guess you have adapted your habits to work around those bugs and don't even notice it [16:37:52] I highly doubt that [16:37:58] I think you're over-estimating what "normal use cases" are. [16:38:19] I bet if we do some user testing with cams and have them insert a link like this, they will not succeed no matter how many times they try. [16:38:39] WTF? [16:38:49] Krinkle: Do you not even read the user testing we do do? [16:38:50] adding a link to a "See also" list, typing some new text with a link in it somewhere, adding an external url, etc. [16:39:03] Krinkle: We've done this a lot of times. They've never had pawning, for example. [16:39:13] (Which appears to be a selection issue.) [16:39:32] Yes, because it's not made for insertion. It's made to apply to text, like an annotation without boundaries. [16:39:44] Though the pre-annotation should work I guess. [16:39:58] eg. insert the link and type the label after (the way we do with bold/italic) [16:40:31] btu that doesn't work because the link isn't "there" until after you save it (by pressing Back) at which point the label is prefilled to the target and you can't change it [16:41:01] James_F: OK. Fair fresh. Where's the user testing we did? I have indeed missed that [16:41:53] Is that pawn bug related to https://bugzilla.wikimedia.org/show_bug.cgi?id=66548 ? [16:42:17] Krenair: Looks like it might be related, yes. [16:42:22] (03CR) 10Helder.wiki: [C: 031] Use rather than elements for HTML5-ification [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140843 (https://bugzilla.wikimedia.org/67084) (owner: 10Jforrester) [16:42:47] 3VisualEditor / 3Data Model: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [16:46:14] James_F, actually, which bug# are we talking about? (I only saw the video) [16:46:17] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a new link is unusable - 10https://bugzilla.wikimedia.org/67086#c2 (10James Forrester) Created attachment 15744 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15744&action=edit Example video showing that issues are caused by having a link immedia... [16:46:29] Krenair: 67086 [16:46:30] * Krinkle files bug for the pawn bug in his video [16:46:50] Ah. [16:47:47] Krinkle: Is it distinct from 66548? [16:48:56] James_F: Yes [16:48:59] They're separate bugs [16:49:04] 3VisualEditor / 3Editing Tools: VisualEditor: Pawn appears when inserting a link (no preselected text) - 10https://bugzilla.wikimedia.org/67088 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None (from bug 67086) 1. Press "Link" tool. 2. Enter a link target (url or page name). 3. Select the url or page nam... [16:52:52] (03PS16) 10Esanders: Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [16:54:27] (03CR) 10Jforrester: [C: 032] Don't try to change offset for vesection=0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141977 (https://bugzilla.wikimedia.org/66674) (owner: 10Esanders) [16:54:47] 3VisualEditor / 3ContentEditable: VisualEditor: Scrolling for &vesection=N works correctly except for N=0, where it scrolls to the bottom of the document - 10https://bugzilla.wikimedia.org/66674 (10James Forrester) 5PATC>3RESO/FIX [16:54:47] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a new link is unusable - 10https://bugzilla.wikimedia.org/67086#c3 (10Krinkle) (In reply to James Forrester from comment #2) > Created attachment 15744 [details] > Example video showing that issues are caused by having a link immediately > preceding the... [16:55:17] (03CR) 10Esanders: [C: 031] Grunt: Create a distribution files for the ve module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [16:56:05] (03Merged) 10jenkins-bot: Don't try to change offset for vesection=0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141977 (https://bugzilla.wikimedia.org/66674) (owner: 10Esanders) [16:58:02] 3VisualEditor / 3Editing Tools: VisualEditor: Wikilink editing does not permit easy alteration of display text - 10https://bugzilla.wikimedia.org/50945#c8 (10Krinkle) 5RESO/FIX>3REOP (removed a couple duplicate see-alsos) Unless I misunderstood the bug, we haven't really made any progress on this since... [16:58:17] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a new link is unusable - 10https://bugzilla.wikimedia.org/67086#c4 (10Krinkle) I've filed the pawn bug as bug 67088. [16:59:02] 3VisualEditor / 3Editing Tools: VisualEditor: Pawn appears when inserting a link (no preselected text) - 10https://bugzilla.wikimedia.org/67088#c1 (10Krinkle) Reduced test case video of only the steps for this bug (without existing links before the list item): http://cl.ly/2P2h473b2A20 [17:04:41] (03CR) 10Alex Monk: [C: 031] Revert "Accessibility: Restore element focus when a window closes" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141940 (https://bugzilla.wikimedia.org/66855) (owner: 10Esanders) [17:16:16] edsanders, I wonder if there is a way to do that correctly... [17:16:39] Krenair, is there a specific case you were looking at? [17:16:51] I know ve.ui.Dialog restores focus in close [17:17:05] It apparently wasn't? Hmm [17:20:18] wfm in chrome [17:21:42] & FF [17:33:17] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a new link is unusable - 10https://bugzilla.wikimedia.org/67086#c5 (10Trevor Parscal) The link inspector has long been our most concentrated area of bugs. UX changes are coming in response to user testing, and many bug fixes are on their way as well - mo... [17:34:32] 3VisualEditor / 3Editing Tools: VisualEditor: Creating a new link is unusable - 10https://bugzilla.wikimedia.org/67086#c6 (10James Forrester) 5NEW>3RESO/INV Better followed-up in specific bugs and proposed UX changes, as discussed. [17:57:56] (03CR) 10Catrope: [C: 032] Revert "Accessibility: Restore element focus when a window closes" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141940 (https://bugzilla.wikimedia.org/66855) (owner: 10Esanders) [17:59:16] (03Merged) 10jenkins-bot: Revert "Accessibility: Restore element focus when a window closes" [oojs/ui] - 10https://gerrit.wikimedia.org/r/141940 (https://bugzilla.wikimedia.org/66855) (owner: 10Esanders) [18:01:18] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (9aad824bd6) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/142019 [18:01:30] RoanKattouw: ^^^ and https://gerrit.wikimedia.org/r/142017 in core. [18:07:47] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf10] Context menus are appearing and then disappearing right after adding cite options/references/formula/image - 10https://bugzilla.wikimedia.org/66855 (10James Forrester) 5ASSI>3RESO/FIX [18:09:23] edsanders: Did you get anywhere with mobile highlights being mis-positioned? It's a pretty major bug. :-( [18:09:57] Oh, that reminds me [18:10:08] I should write a patch for highlights in IE being opaque [18:11:15] Yes! [18:11:20] But not today. ;-) [18:12:28] (03CR) 10Catrope: [C: 032] Add missing TableCell CSS file and Vector-specific rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141923 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [18:13:32] 3VisualEditor / 3ContentEditable: VisualEditor: Cells in tables are styled like regular paragraphs, and they shouldn't be - 10https://bugzilla.wikimedia.org/65416 (10James Forrester) 5PATC>3RESO/FIX [18:14:09] (03Merged) 10jenkins-bot: Add missing TableCell CSS file and Vector-specific rule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141923 (https://bugzilla.wikimedia.org/65416) (owner: 10Esanders) [18:14:47] (03CR) 10Catrope: [C: 032] Cache block drop position data before setTimeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141949 (https://bugzilla.wikimedia.org/67040) (owner: 10Esanders) [18:16:09] (03Merged) 10jenkins-bot: Cache block drop position data before setTimeout [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141949 (https://bugzilla.wikimedia.org/67040) (owner: 10Esanders) [18:19:32] 3VisualEditor / 3ContentEditable: VisualEditor: On Chrome, new relocatable node does not work - 10https://bugzilla.wikimedia.org/67040 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3High s:5normal>3major [18:39:43] Maybe I should just take a sabbatical for the next 2 months instead of bothering with the UI crap - maybe I could find something less stressful where people trust me more, like working at McDonalds [18:39:56] I saw the new relocatable node yesterday. Magic line FTW. Good job guys. [18:40:10] howdy BladeBro_ [18:40:44] hey, how's stuff? [18:40:50] Can I come with you for 2 months? [18:41:45] we could take an RV [18:41:54] good thinking. [18:42:24] I just ordered one of these: http://www.golittleguy.com/model?id=47&model=5x10-Silver-Shadow [18:42:46] Sleeps 2. :) [18:43:42] TrevorParscal: haha [18:44:33] MatmaRex: how's your skin reorg coming? [18:45:36] * James_F hugs TrevorParscal. [18:45:37] TrevorParscal: see gerrit :) it's going rather well, i managed to push through some reorganization of core skins [18:45:54] Well done [18:46:08] turns out lowercse vs CamelCase is not that important after all, heh [18:46:17] MatmaRex: How busy will you be for the next 2 months? [18:47:01] TrevorParscal: very busy for a week or two (stupid exams), completely bored afterwards [18:47:04] We were talking about collaborating a bit on part of your proposal, where it seems to coincide with mine [18:48:06] I will keep you in the loop [18:48:37] James_F, ryasmeen I know it's kind of last minute, but would you be against rescheduling our VE bugs meeting? It's not like we will fix them before tomorrow's train anyway, VE is still in beta [18:49:00] In all honesty, the drama that was going on between Tim Starling and Michael Dale before ResourceLoader was more epic [18:49:17] instead of having a pre-deployment meeting, we could just have a "mobile bugs overview" meeting to go through all that's in there and decide on priorities [18:49:18] jgonera, I think we can reschedule it [18:49:20] jgonera: Sure. [18:49:27] Roan and I stepped up and did a lot of diplomacy to get things done [18:49:38] TrevorParscal: :-( [18:49:54] But we ended up with a few concessions, bad designs in RL that were essentially demands from either Tim or Michael [18:50:03] I'm sure this will be no different [18:50:15] TrevorParscal: yay [18:50:30] heh [18:50:40] examples? i wasn;t around at the time, and this sounds interesting [18:50:40] I remember we actually had an all out flame war over whether JavaScript minification should strip newlines or not [18:50:52] James_F, ryasmeen OK, let's do that. Maryana is OK with rescheduling too [18:50:52] Useful. :-) [18:50:54] jgonera: The bugs that I was more concerned about are actually going to be taken care of by edsanders, so there is nothing new major bug to triage right at this moment :) [18:51:02] jgonera: When do you want to move it to? [18:51:17] James_F, let me talk to Maryana and we'll schedule something [18:51:25] Kk. [18:51:32] Tim and Michael also created their own hacked together ResourceLoader-ish things, ported all software in sight and merged it quietly only to have everything break on them [18:51:39] separately [18:51:42] ryasmeen, good to know, thank you [18:51:43] jgonera: FWIW the meetings are /review/ of whether things need to be reverted, not planning of what needs to be done. [18:51:51] TrevorParscal: Why do you need resources/src/mediawiki.skinning/content.parsoid.less - is it for VisualEditor at all? [18:52:17] InezK: it's for all users of Parsoid HTML [18:52:20] including VE [18:52:25] Parsoid output is structured slightly different, so without those styles the HTML doesn't look right [18:52:28] James_F, I see. But that makes me wonder if we need such a meeting if VE is not in mobile stable mode. [18:52:51] jgonera: It will be soon; getting into the practice of never having master broken is vital. [18:52:53] TrevorParscal: but in case of VE we are just processing that HTML - no one is looking at it.. [18:53:07] InezK: It displays in VE… [18:53:12] we display it in a contenteditable div, it's deisplayed [18:53:50] James_F, I understand, but right now it's kind of permanently broken because we haven't fixed really annoying iOS bugs yet ;) [18:53:56] InezK: the ce nodes only sometimes modify the output of parsoid, in many cases (like templates) we output it verbatim [18:54:13] jgonera: Sure. :-( [18:54:32] I'm heading in now [18:54:48] I need Roan's brain, and James's comforting embrace [18:55:41] c'yall in a bit [18:56:19] * James_F hugs TrevorParscal. [18:56:23] Also, I have a brain too! [18:56:32] lies [18:57:00] (03PS1) 10Jforrester: Update VE core submodule to master (1aa3143) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142037 [18:57:50] Eloquence: :-P [18:58:27] TrevorParscal: that makes sense, thanks for clarification [19:00:22] MatmaRex: A good example of a compromise feature that we're going to kill soon is the loader script thing [19:00:27] You can like add things to the startup module [19:00:46] Which TimedMediaHandler uses to add all the JavaScript under the freaking sun to the startup module [19:01:07] hm. [19:01:25] And so make Commons slow as anything. [19:01:27] (03CR) 10Catrope: [C: 032] Use rather than elements for HTML5-ification [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140843 (https://bugzilla.wikimedia.org/67084) (owner: 10Jforrester) [19:03:03] (03Merged) 10jenkins-bot: Use rather than elements for HTML5-ification [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140843 (https://bugzilla.wikimedia.org/67084) (owner: 10Jforrester) [19:04:17] 3MediaWiki extensions / 3TemplateData: TemplateData: Use rather than elements in the display table - 10https://bugzilla.wikimedia.org/67084 (10James Forrester) 5PATC>3RESO/FIX [19:04:42] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (1aa3143) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142037 (owner: 10Jforrester) [19:06:07] James_F, it's iOS only right? [19:06:22] (03Merged) 10jenkins-bot: Update VE core submodule to master (1aa3143) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142037 (owner: 10Jforrester) [19:10:46] because I don't have one [19:11:22] * mooeypoo drops a hammer on her computer [19:11:31] repeatedly. [19:15:18] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928#c8 (10ryasmeen) 5RESO/FIX>3REOP This is still happening on FireFox in Betalabs r... [19:20:35] (03PS11) 10Mooeypoo: Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [19:21:19] (03PS12) 10Mooeypoo: Merge Media Edit and Media Insert dialogs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/140813 [19:21:42] (03PS3) 10Mooeypoo: [wip] MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 [19:28:17] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Cursor jumps to the beginning of the document after adding citations/references - 10https://bugzilla.wikimedia.org/64041 (10Roan Kattouw) 5REOP>3RESO/FIX [19:29:18] 3VisualEditor / 3Editing Tools: VisualEditor: For large SVG images while trying to make it full size, it says "Size values are invalid" - 10https://bugzilla.wikimedia.org/66865 (10Roan Kattouw) 5NEW>3ASSI p:5Unprio>3Normal a:3Moriel Schottlender [19:37:26] edsanders: Chrome simulates it. You're the expert in highlights and shields… [19:40:25] chrome doesn't simulate iOS [19:40:29] it works in chrome mobile [19:41:26] edsanders: It doesn't? I thought it simulated dozens of UAs' behaviour? [19:43:13] I think it just emulates screen size [19:43:23] and ua string and events [19:43:58] and pixelratio [19:44:08] Ah. Helpful. [19:44:45] Krinkle: Can you test in Safari iOS-like environments given Ed can't? [19:45:02] Test what? [19:45:27] Krinkle: In general, but specifically positioning of shields and highlights right now. [19:46:07] On master? [19:46:13] or a patch [19:46:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden - 10https://bugzilla.wikimedia.org/65326 (10James Forrester) [19:46:43] Krinkle: We know the bug exists. See https://bugzilla.wikimedia.org/show_bug.cgi?id=65326 and the three related bugs. [19:46:47] 3VisualEditor / 3Mobile: VisualEditor Mobile:The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063 (10James Forrester) [19:46:47] 3VisualEditor / 3Mobile: VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari - 10https://bugzilla.wikimedia.org/67002 (10James Forrester) [19:47:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: The highlight for images are appearing in wrong position after tapping on any image with Safari in iOS - 10https://bugzilla.wikimedia.org/67063 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [19:47:42] Oh, I like the way the toolbar dims when the cursor is outside the surface (e.g. in the search field) [19:48:11] Krinkle: Essentially we need someone who can develop and test in iOS-like environments. Would CrossBrowserTesting or whatever help? [19:48:29] I'm testing it on Safari 7/Mac now, and in browserstack on iOS [19:48:45] * James_F nods. [19:49:50] I don't have my phone hooked up to localhost either. You can use browserstack or crossbrowsertesting to tunnel to your localhost and dev/test [19:50:05] Ah, this is mobile specific? [19:50:07] Yes. [19:50:14] I mean, mobile frontend specific? [19:50:21] … don't know. [19:50:22] Or can I use vector on iOS [19:50:24] edsanders: [19:50:57] mobile frontend [19:51:23] Krinkle: ryasmeen says it's MobileFrontend-specific. [19:51:43] edsanders: do you have mf installed locally? [19:51:46] Krinkle: Or, at least, desktop VE on iOS Safari 7 doesn't have the issue. [19:51:47] yes [19:51:56] what about standalone mobile demo? [19:52:48] 3VisualEditor / 3Editing Tools: VisualEditor: Fix tabindexes in the citation dialog - 10https://bugzilla.wikimedia.org/66824 (10James Forrester) a:3Alex Monk [19:53:03] 3VisualEditor / 3Data Model: VisualEditor: Link input widget outwits itself with the leading colon for Category/file links - 10https://bugzilla.wikimedia.org/50279 (10James Forrester) a:3Alex Monk [19:53:18] 3VisualEditor / 3Editing Tools: VisualEditor: You can't click on a scrollbar to move down a suggestions list to pick a lower item (because it closes on click) - 10https://bugzilla.wikimedia.org/65774 (10James Forrester) a:3Trevor Parscal [19:53:41] edsanders: The demos aren't running on a server we can point an iPad to, are they? [19:54:33] 3VisualEditor / 3ContentEditable: VisualEditor: Provide a way (beyond Ctrl-Click, middle-click, or right-click/tab) to open links in another window - 10https://bugzilla.wikimedia.org/54759 (10James Forrester) a:3Trevor Parscal [19:55:02] 3VisualEditor / 3Editing Tools: VisualEditor: Tool to set/unset text as big - 10https://bugzilla.wikimedia.org/51613 (10James Forrester) [19:55:02] 3VisualEditor / 3Editing Tools: VisualEditor: Support the tag as a text annotation - 10https://bugzilla.wikimedia.org/64376 (10James Forrester) [19:55:02] 3VisualEditor / 3Technical Debt: VisualEditor: Work out whether removing repositionOnly parameter in DesktopContext.update() was a good idea - 10https://bugzilla.wikimedia.org/66507 (10James Forrester) [19:55:17] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery inspector/Link inspector opens with an animation from left to right for a specific case - 10https://bugzilla.wikimedia.org/60501 (10James Forrester) [19:55:17] 3VisualEditor / 3Editing Tools: VisualEditor: Open formula inspector breaks when clicking onto a link/reference/image/template/… - 10https://bugzilla.wikimedia.org/56644 (10James Forrester) [19:55:17] 3VisualEditor / 3Editing Tools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - 10https://bugzilla.wikimedia.org/62850 (10James Forrester) [19:55:17] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf9] Making an image Frameless with out any wrap option deletes the content of the caption - 10https://bugzilla.wikimedia.org/66808 (10James Forrester) [19:55:18] 3VisualEditor / 3Editing Tools: VisualEditor: Gallery and Math inspector closes with an animation from right to left after clicking on "<" to close them - 10https://bugzilla.wikimedia.org/66552 (10James Forrester) [19:55:19] 3VisualEditor / 3Editing Tools: VisualEditor: Support the tag as a text annotation - 10https://bugzilla.wikimedia.org/52664 (10James Forrester) [19:55:21] 3VisualEditor / 3ContentEditable: VisualEditor: Centred images can appear in VE as overlapped by another image, then can't be selected - 10https://bugzilla.wikimedia.org/62590 (10James Forrester) [19:55:22] 3VisualEditor / 3Editing Tools: VisualEditor: Tool to set/unset text as small - 10https://bugzilla.wikimedia.org/51614 (10James Forrester) [19:56:02] (03PS4) 10Mooeypoo: [wip] MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 [19:56:05] edsanders: BTW https://bugzilla.wikimedia.org/show_bug.cgi?id=52171 looks to be a regression from your fix. :-( [19:56:54] James_F: Of course the standalone demo would work fine. [19:57:25] Krinkle: I'd be surprised if there was anything wrong in VE core, yeah. [19:57:34] Krinkle: Include VE-core-mobile. [19:57:36] James_F: the demos are in the /w/extensions/ve directory, same as mediaiwki itself. If you tunnel local hostname that runs meidawiki, and point the ipad to it, it'll serve it. Just like you can in your own browser. [19:57:36] Hey Krinkle, The issues with highlighting the image or reference is not mobile frontend specific which is reported in this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=67063 [19:57:49] James_F: I mean, work as in, you can point an iPad to it just as well. [19:58:18] Krinkle: OK, I nominate you to get ryasmeen set up to pull local patches and test them using a tunneled iPad. [19:58:22] ;-P [19:58:58] James_F: On a premise that you actually have a local mediawiki install and have access to browserstack.com, it is easy for you or Ed to do. [19:59:04] But the issue with tapping on link/reference :https://bugzilla.wikimedia.org/show_bug.cgi?id=67002 and https://bugzilla.wikimedia.org/show_bug.cgi?id=65326 , there are mobile frontend specific [19:59:36] Krinkle: The people involved, however, are ryasmeen and edsanders, one of who isn't a developer and the other of whom doesn't have an iPad. [20:00:09] * James_F believes you that edsanders could find a way using browserstack.com, but you'll need to convince him. :_) [20:00:14] I don't have an iPad either. If ed's working on something I else I can drop what I'm doing and give it a shot, but it it can be done with browserstack in a second. [20:00:26] * James_F nods. [20:00:28] edsanders? [20:01:17] http://imgur.com/uURzsWq [20:01:49] I can reproduce that clicking the link while in the edit mode on MF in VE opens the url [20:02:08] in read mode. I don't know the bugs in question though. [20:02:35] * James_F nods. [20:03:26] Krinkle: Could you drop your current work and instead work on that bug (65326)? Sorry to ask [20:03:44] Krinkle: The related ones are /possibly/ all the same bug, but possibly not (so we've not merged them). [20:04:32] 3VisualEditor / 3ContentEditable: VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article - 10https://bugzilla.wikimedia.org/65928#c9 (10James Forrester) 5REOP>3RESO/FIX WFM; cache issue, it appears. [20:05:16] I could, but it'd be rather inefficient. I don't know these areas of the code base well at all, and the bug reports don't have developer activity yet pointing in the right direction. I'd have no clue what I'm doing. [20:05:57] brbl, having late dinner. [20:06:21] Krinkle: Less inefficient than no-one working on a critical bug. [20:06:43] Wasn't ed working on it before being blocked by iPad-lack? [20:07:41] Krinkle|detached: Apparently not? [20:08:18] I have crossbrowsertesting but the proxy doesn't work anymore [20:13:09] edsanders: Do you need an account from us or something? [20:13:27] I have a cbt account, I could try browserstack if you send me the login [20:13:37] * James_F nods. [20:23:32] 3VisualEditor / 3Editing Tools: VisualEditor: Wikilink editing does not permit easy alteration of display text - 10https://bugzilla.wikimedia.org/50945#c9 (10James Forrester) 5REOP>3RESO/FIX (In reply to Krinkle from comment #8) > (removed a couple duplicate see-alsos) > > Unless I misunderstood the bug... [20:26:00] (03PS1) 10Alex Monk: Offer to retain changes when switching to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) [20:28:54] (03PS2) 10Alex Monk: Offer to retain changes when switching to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) [20:29:31] 3VisualEditor / 3Mobile: VisualEditor: In mobile integration, there is no text cursor activation on load - 10https://bugzilla.wikimedia.org/57177#c2 (10Ryan Kaldari) We would like to have this fixed before we push mobile VE to stable if possible. Any update on it? [20:30:47] 3VisualEditor / 3Mobile: VisualEditor: In mobile integration, there is no text cursor activation on load - 10https://bugzilla.wikimedia.org/57177#c3 (10James Forrester) (In reply to Ryan Kaldari from comment #2) > We would like to have this fixed before we push mobile VE to stable if > possible. Any update o... [20:34:18] 3VisualEditor / 3Mobile: VisualEditor: In mobile integration, there is no text cursor activation on load - 10https://bugzilla.wikimedia.org/57177 (10James Forrester) a:3Ed Sanders [20:36:21] Krenair: In 142064 (wikitext switch, yay), isn't "cancel" non-destructive? [20:37:05] you're right [20:37:18] Two reds + one blue is a bit much. :-) [20:37:20] (03PS3) 10Alex Monk: Offer to retain changes when switching to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) [20:39:32] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Pawn appears when inserting a link (no preselected text) and implicitly exiting from the inspector - 10https://bugzilla.wikimedia.org/67088 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [20:42:32] 3VisualEditor / 3Editing Tools: Toolbar alignment out of whack - 10https://bugzilla.wikimedia.org/67071#c4 (10Derk-Jan Hartman) Safari 7 [20:49:38] James_F, is anyone working on https://bugzilla.wikimedia.org/show_bug.cgi?id=64575 ? [20:58:11] (03CR) 10Trevor Parscal: [C: 032] Normalize titles in template descriptions in context menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141082 (https://bugzilla.wikimedia.org/66893) (owner: 10Catrope) [21:03:57] James_F, hey [21:04:25] So with https://bugzilla.wikimedia.org/show_bug.cgi?id=50279 - are you referring to the fact that if you open a category link and re-select the entry, you get an extra ':'? [21:06:41] Oh my god, someone invented an abstracted language that compiles to javascript (like coffeescript and typescript) and they named it LiveScript. [21:06:45] that's so funny. [21:10:36] (03Merged) 10jenkins-bot: Normalize titles in template descriptions in context menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141082 (https://bugzilla.wikimedia.org/66893) (owner: 10Catrope) [21:14:21] jgonera: Not currently. It's on Trevor's list. [21:15:05] (03CR) 10Trevor Parscal: [C: 032] Work around element sizing bug in Chrome [oojs/ui] - 10https://gerrit.wikimedia.org/r/141081 (owner: 10Catrope) [21:15:52] Krenair: Go to blank list; add link; enter "Category:Foo" for an extant category; on first return it matches and puts in ":Category:Foo"; on second return (close) it changes it to "::Category:Foo"; rinse and repeat on edit. [21:16:54] Err. [21:17:02] … blank *line*. [21:17:02] James_F, Yep, that sounds like what I found [21:17:06] * James_F nods. [21:17:53] (03Merged) 10jenkins-bot: Work around element sizing bug in Chrome [oojs/ui] - 10https://gerrit.wikimedia.org/r/141081 (owner: 10Catrope) [21:17:55] (03PS1) 10Alex Monk: Don't prepend extra colon to category/file links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142136 (https://bugzilla.wikimedia.org/50279) [21:18:10] ok, James_F, I'll add it to the email thread I started, this one is pretty crucial for stable VE on mobile too [21:18:52] * James_F nods. [21:19:02] This is what that meeting is for… [21:19:34] 3VisualEditor / 3Technical Debt: VisualEditor: mw.Title invocations for template titles should use template namespace as default namespace - 10https://bugzilla.wikimedia.org/66893 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Normal a:3Roan Kattouw [21:20:43] (03CR) 10Trevor Parscal: [C: 032] Work around IE DOMParser bug in ve.createDocumentFromHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140050 (owner: 10Mooeypoo) [21:22:10] ok, James_F, I see, we'll do the meeting from now on ;) [21:23:01] jgonera: Cool. ;-) [21:23:48] (03Merged) 10jenkins-bot: Work around IE DOMParser bug in ve.createDocumentFromHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140050 (owner: 10Mooeypoo) [21:36:17] 3VisualEditor / 3Editing Tools: Toolbar alignment out of whack - 10https://bugzilla.wikimedia.org/67071#c5 (10WhatamIdoing) I had this problem in Safari 6.1.4 on Mac OS 10.8.5 [21:38:49] 3VisualEditor / 3Editing Tools: VisualEditor: Section edit link is not appearing in Betalabs - 10https://bugzilla.wikimedia.org/67100 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15747 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15747&action=edit Screenshot Steps to re... [21:39:07] (03CR) 10Catrope: [C: 032] Render a placeholder when extension contents are empty [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141985 (https://bugzilla.wikimedia.org/66813) (owner: 10Esanders) [21:40:45] (03Merged) 10jenkins-bot: Render a placeholder when extension contents are empty [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141985 (https://bugzilla.wikimedia.org/66813) (owner: 10Esanders) [22:00:33] 3OOjs UI: OOjs UI: Selecting an item does something weird with the focus of the input on an iPad - 10https://bugzilla.wikimedia.org/64575#c8 (10ryasmeen) I am not sure , if I have understood this bug from the description given but is it same as:https://bugzilla.wikimedia.org/show_bug.cgi?id=66696 ? [22:12:18] 3OOjs UI: OOjs UI: Selecting an item does something weird with the focus of the input on an iPad - 10https://bugzilla.wikimedia.org/64575 (10James Forrester) a:3Trevor Parscal [22:12:47] 3VisualEditor / 3Editing Tools: VisualEditor: The Math and Heiro Inspector jumps to the beginning of the article while opening it for the first time of every edit session - 10https://bugzilla.wikimedia.org/66813 (10James Forrester) 5PATC>3RESO/FIX [22:14:33] TrevorParscal, so a few days ago I was wondering about having a popup on an icon from OOjs UI. You suggested PopupButtonWidget but obviously that makes a button. I wanted the popup on a simple icon [22:14:50] just configure the button [22:14:54] frameless: true [22:15:00] icon: 'some-icon' [22:15:06] don't specify a label [22:15:09] will try that, thanks. [22:15:09] specify a title [22:20:26] (03CR) 10Catrope: [C: 04-1] Only allow slugs where paragraphs are allowed (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140438 (owner: 10Esanders) [22:21:32] 3VisualEditor / 3Editing Tools: VisualEditor: Section edit link is not appearing in Betalabs - 10https://bugzilla.wikimedia.org/67100#c1 (10James Forrester) 5NEW>3RESO/WOR I can't reproduce in any of four browsers tested. :-( [22:23:17] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar is sometimes misaligned and ugly in Safari; corrects itself after interaction - 10https://bugzilla.wikimedia.org/66988 (10James Forrester) 5RESO/DUP>3REOP p:5Unprio>3High s:5trivia>3normal [22:23:32] 3VisualEditor / 3Editing Tools: Toolbar alignment out of whack - 10https://bugzilla.wikimedia.org/67071#c6 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 66988 *** [22:23:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar is sometimes misaligned and ugly in Safari; corrects itself after interaction - 10https://bugzilla.wikimedia.org/66988#c2 (10James Forrester) *** Bug 67071 has been marked as a duplicate of this bug. *** [22:23:46] 3VisualEditor / 3MediaWiki integration: VisualEditor: Toolbar is sometimes misaligned and ugly in Safari; corrects itself after interaction - 10https://bugzilla.wikimedia.org/66988 (10James Forrester) 5REOP>3ASSI [22:24:31] (03CR) 10Jforrester: [C: 031] "OK from Product POV. Not done code review." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/142064 (https://bugzilla.wikimedia.org/57462) (owner: 10Alex Monk) [22:25:32] omg,my computer is annoying. [22:25:38] RoanKattouw, are you around? [22:26:18] mooey: have we still not gotten you a new computer? [22:26:33] 3VisualEditor / 3Editing Tools: VisualEditor: Section edit link is not appearing in Betalabs - 10https://bugzilla.wikimedia.org/67100#c2 (10ryasmeen) 5RESO/WOR>3RESO/INV Ignore this bug, this is for adding a tempalte Country Showdata in the page. [22:26:42] RoanKattouw, I have a reply from my Microsoft contact -- she introduced me to one of the tech guys in the IE team, I'm going to forward/add you to the conversation so you can talk to him directly? [22:27:08] TrevorParscal, Terry asked IT for a laptop, I think itshould be ready in the next couple of days or so [22:27:12] my biggest worry is Wikimania [22:27:24] mooey: We'll just have to fly you out to pick it up. ;-) [22:27:38] my laptop crashes when I work with VM, and my PC at home is really REALLY slow. And is a little clunky to carry around. [22:27:54] James_F, I wouldn't argue against that..... :D [22:32:22] * James_F grins. [22:32:40] btw, TrevorParscal, I'm about to completely molest OOUI. I need a bunch of tools in the toolbar that don't exist... hoping I can figure out how to do that before I give up and switch to (shriek!) jquery UI [22:34:04] mooey: Sounds good, yeah add me to that thread [22:39:17] 3VisualEditor / 3MediaWiki integration: VisualEditor: Use gzip compression when POSTing HTML - 10https://bugzilla.wikimedia.org/59659#c2 (10Bartosz Dziewoński) 5ASSI>3RESO/DUP *** This bug has been marked as a duplicate of bug 66914 *** [22:39:30] MatmaRex: … [22:39:32] 3VisualEditor / 3MediaWiki integration: VisualEditor: Compress POST data in the client - 10https://bugzilla.wikimedia.org/66914#c4 (10Bartosz Dziewoński) *** Bug 59659 has been marked as a duplicate of this bug. *** [22:39:36] MatmaRex: Up-merging by 10000? [22:39:47] 3VisualEditor / 3Mobile: VisualEditor Mobile:Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2)/iOS - 10https://bugzilla.wikimedia.org/66753 (10ryasmeen) [22:39:48] James_F: the newer bug has a patch [22:39:50] MatmaRex: Sorry, 7000. [22:39:56] MatmaRex: The patch can be re-pointed. ;-) [22:40:07] and discussion [22:40:08] less effort to do it this way :) [22:40:15] The earlier bug has discussion and pointers to issues. [22:41:02] 3VisualEditor: VisualEditor: Performance issues (tracker) - 10https://bugzilla.wikimedia.org/49685 (10James Forrester) [22:41:03] 3VisualEditor / 3MediaWiki integration: VisualEditor: Compress POST data in the client - 10https://bugzilla.wikimedia.org/66914 (10James Forrester) p:5Unprio>3High s:5normal>3enhanc a:3Ed Sanders [22:42:20] (03CR) 10Catrope: [C: 032] Use subtle border styling for unstyled tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141929 (owner: 10Esanders) [22:42:32] 3VisualEditor / 3Mobile: VisualEditor Mobile:Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2)/iOS - 10https://bugzilla.wikimedia.org/66753#c1 (10ryasmeen) This is not android specific issue, its happening for iOS as well. Also, it has gone to pr... [22:43:40] (03Merged) 10jenkins-bot: Use subtle border styling for unstyled tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141929 (owner: 10Esanders) [22:44:17] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression] Link suggestions are not appearing while trying to add link target from link inspector in Nexus 7(Android 4.4.2) and iOS - 10https://bugzilla.wikimedia.org/66753 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [22:50:18] TrevorParscal, Great. How do I set the contents of the popup? [22:53:41] Krenair: That's the title parameter, I think. [22:53:50] Tried that [22:53:57] It doesn't work? [22:54:18] It sets the title attribute of the link [22:54:54] Krenair: Aha. Eww. [22:54:57] Krenair: "this.infoButton.getPopup().$body.append( this.$description );" [22:55:09] Ewww. [22:55:12] Krenair: Clearly that should be factored out into a method in OOUI. [22:55:13] Yeah. [22:55:25] (I found $popup instead of $body and got it working that way) [22:55:44] Not better. :-) [22:56:21] So it appears now [22:56:29] Partially hidden by the input below though :( [22:56:57] >> foo = {}; foo.static = 'bar'; [22:56:58] RoanKattouw: (string) 'bar' [22:57:01] >> var static = 'bar'; static; [22:57:02] RoanKattouw: (string) 'bar' [22:57:27] James_F, z-index: 0;... :) [22:57:43] Krenair: See ve.ui.MWParameterPage.css [22:57:44] uh, 1. Not 0. [22:57:58] Krenair: … which sets it to 100 (!) and inline-block. [23:03:10] heh. [23:03:11] Krenair: use $body, not $popup [23:03:28] or ClippableElement will fail [23:03:30] yeah, I changed it when James suggested that [23:03:34] that is to say, more than usual [23:03:40] Hey hey hey. [23:03:44] I didn't "suggest". [23:03:53] I just copied-and-pasted TrevorParscal's ghastly code. [23:03:56] Don't come blaming me. ;-) [23:30:34] 3VisualEditor / 3Editing Tools: VisualEditor: Cursor is appearing in the read mode after canceling the edit in VE - 10https://bugzilla.wikimedia.org/67106 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15748 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15748&action=edit Sc... [23:37:18] 3VisualEditor / 3Editing Tools: VisualEditor: Cursor is appearing in the read mode in Firefox after canceling the edit in VE - 10https://bugzilla.wikimedia.org/67106 (10ryasmeen) [23:43:33] RoanKattouw: Did you get anywhere with https://bugzilla.wikimedia.org/show_bug.cgi?id=66604 ? [23:44:20] No [23:44:39] Instead I was SWATting, responding to IE people mooey put me in touch with (including writing a jsfiddle for opacity issues) and talking about Mantle [23:44:48] 3VisualEditor / 3Data Model: VisualEditor: Pawns appear when undoing and redoing the highlighted character from text created in a blank link - 10https://bugzilla.wikimedia.org/66548 (10James Forrester) a:3Ed Sanders [23:45:28] Boo.