[00:11:47] 3VisualEditor / 3Editing Tools: VisualEditor:Disable "Apply changes" button on Media Search dialog now that the Edit and search dialog both are merged - 10https://bugzilla.wikimedia.org/67443 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15821 --> https://bugzilla.wikimedia.org/a... [00:30:47] 3OOjs UI: ClippableElement does not work in certain cases - 10https://bugzilla.wikimedia.org/67444 (10Roan Kattouw) 3NEW p:3Unprio s:3normal a:3Trevor Parscal For instance: * In VE-MW, MenuToolGroups clip correctly, but in VE core they don't clip, and in the OOUI toolbar demo they don't clip either *... [00:35:32] Krinkle: Ping. [00:35:50] Krinkle: https://github.com/jdforrester/grunt-banana-checker/pulls :-) [00:36:15] (03PS1) 10Catrope: Update VE core submodule to master (384618f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143800 [00:36:19] James_F: --^^ [00:36:40] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (384618f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143800 (owner: 10Catrope) [00:38:22] (03Merged) 10jenkins-bot: Update VE core submodule to master (384618f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143800 (owner: 10Catrope) [00:42:30] 3OOjs UI: OOjs UI: ClippableElement does not work in certain cases - 10https://bugzilla.wikimedia.org/67444 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [00:43:03] (03PS2) 10Jforrester: UX Improvements to the Media Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143749 (https://bugzilla.wikimedia.org/67443) (owner: 10Mooeypoo) [00:43:16] 3VisualEditor / 3Editing Tools: VisualEditor:Disable "Apply changes" button on Media Search dialog now that the Edit and search dialog both are merged - 10https://bugzilla.wikimedia.org/67443 (10James Forrester) 5NEW>3PATC p:5Unprio>3High s:5normal>3minor a:3Moriel Schottlender [00:43:44] James_F: first thing tomorrow [00:44:00] Krinkle: OK, thanks. :-) [00:55:02] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036#c5 (10Krinkle) Was about to report a similar bug for another template. Narrowed it down to the CSS property "column-count". It's not specific to... [00:55:30] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036#c6 (10Krinkle) Created attachment 15825 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15825&action=edit Screenshot of typical two-colum... [00:57:30] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036#c7 (10Krinkle) Created attachment 15826 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15826&action=edit Screenshot of case with more th... [01:05:30] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - 10https://bugzilla.wikimedia.org/48789 (10Krinkle) [01:05:33] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should indicate link target when applied via keyboard shortcut - 10https://bugzilla.wikimedia.org/67446 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Created attachment 15827 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15827&actio... [01:09:01] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036 (10James Forrester) p:5Low>3Normal [01:10:26] Does anyone remember which code is responsible for displaying cursor at the beginning of the article after ve loads? [01:10:32] 3VisualEditor / 3Editing Tools: VisualEditor: Link annotation gets cut off when label contains linktrail end characters - 10https://bugzilla.wikimedia.org/67447 (10Krinkle) 3NEW p:3Unprio s:3normal a:3None Created attachment 15828 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15828&action=ed... [01:10:45] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - 10https://bugzilla.wikimedia.org/48789 (10Krinkle) [01:11:07] It's this: ve.ce.Surface.prototype.onDocumentFocus [01:11:09] :) [01:11:37] (03PS1) 10Catrope: Followup 26fd3777: hide "Go back" in insertion mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143803 [01:12:16] (03CR) 10Jforrester: [C: 032] "Holding my nose." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143803 (owner: 10Catrope) [01:12:18] InezK: Yeah. If you have questions about focus handling, talk to Ed, he's been doing lots of painstaking work on that semi-recently [01:12:45] (03CR) 10Catrope: [C: 032] UX Improvements to the Media Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143749 (https://bugzilla.wikimedia.org/67443) (owner: 10Mooeypoo) [01:14:43] (03Merged) 10jenkins-bot: UX Improvements to the Media Dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143749 (https://bugzilla.wikimedia.org/67443) (owner: 10Mooeypoo) [01:14:51] (03Merged) 10jenkins-bot: Followup 26fd3777: hide "Go back" in insertion mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143803 (owner: 10Catrope) [01:15:31] 3VisualEditor / 3Editing Tools: VisualEditor:Disable "Apply changes" button on Media Search dialog now that the Edit and search dialog both are merged - 10https://bugzilla.wikimedia.org/67443 (10James Forrester) 5PATC>3RESO/FIX [01:15:45] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of div wrapping in template rendering - 10https://bugzilla.wikimedia.org/64780#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX Fixed by Ed in https://gerrit.wikimedia.org/r/#/c/140439/ [01:18:15] 3VisualEditor / 3Technical Debt: VisualEditor: mw.Title invocations for template titles should use template namespace as default namespace - 10https://bugzilla.wikimedia.org/66893#c3 (10Roan Kattouw) 5RESO/FIX>3REOP (In reply to Roan Kattouw from comment #0) > Right now we have things like mw.Title.newFr... [01:18:46] 3VisualEditor / 3Technical Debt: VisualEditor: Get rid of div wrapping in template rendering - 10https://bugzilla.wikimedia.org/64780 (10James Forrester) a:3Ed Sanders [01:20:03] (03PS4) 10Catrope: Try some more to handle template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143685 (https://bugzilla.wikimedia.org/67384) (owner: 10Alex Monk) [01:20:55] (03CR) 10Catrope: [C: 032] Try some more to handle template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143685 (https://bugzilla.wikimedia.org/67384) (owner: 10Alex Monk) [01:23:48] (03Merged) 10jenkins-bot: Try some more to handle template namespace properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143685 (https://bugzilla.wikimedia.org/67384) (owner: 10Alex Monk) [01:24:30] 3VisualEditor / 3Technical Debt: VisualEditor: Burn ve.ce.getElementOffset down to the ground - 10https://bugzilla.wikimedia.org/61567#c1 (10Roan Kattouw) 5ASSI>3RESO/FIX This function doesn't actually exist. I'm assuming this refers to getOffset/getOffsetFromElementNode/getOffsetFromTextNode which have... [01:24:45] 3VisualEditor / 3Editing Tools: VisualEditor: For all templates , "Template:" is getting added as a prefix while searching from Template dialog box - 10https://bugzilla.wikimedia.org/67384 (10Roan Kattouw) 5PATC>3RESO/FIX [01:25:16] 3VisualEditor / 3Technical Debt: VisualEditor: mw.Title invocations for template titles should use template namespace as default namespace - 10https://bugzilla.wikimedia.org/66893#c6 (10Roan Kattouw) 5PATC>3RESO/FIX (In reply to Roan Kattouw from comment #3) > (In reply to Roan Kattouw from comment #0) >... [01:25:26] Krenair: Dude thanks for inadvertently taking care of a technical debt bug :) (mw.Title use for template titles) [01:26:11] I kind of think we should have a function in mw.Title to format template names like this [01:27:09] Yeah [01:27:13] You duplicated the same thing a few times over [01:27:25] There should be a function that formats the title relative to a namespace [01:27:28] (other than the main namespace) [01:27:50] Yeah... [01:28:06] I did https://gerrit.wikimedia.org/r/143803 today though rather than adding a method to OO.ui.Dialog, so I'm not gonna complain too much ;) [01:36:31] 3VisualEditor / 3Editing Tools: VisualEditor: Ability to switch image used whilst maintaining the caption and other settings - 10https://bugzilla.wikimedia.org/51033 (10James Forrester) 5ASSI>3RESO/FIX a:3Moriel Schottlender [01:37:15] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switching to source mode should show a spinner - 10https://bugzilla.wikimedia.org/65012 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3enhanc [01:37:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: Switching to source mode should show a spinner - 10https://bugzilla.wikimedia.org/65012 (10James Forrester) a:3Alex Monk [01:39:21] Krenair, RoanKattouw: Now https://bugzilla.wikimedia.org/show_bug.cgi?id=67448 :-) [01:40:28] I can't think of any cases except templates right now... [01:41:23] Krenair: Images? [01:41:52] Maybe some extensions? [01:43:16] 3VisualEditor / 3Technical Debt: VisualEditor: Burn ve.ce.getElementOffset down to the ground - 10https://bugzilla.wikimedia.org/61567 (10James Forrester) a:3Roan Kattouw [01:43:30] Yeah I guess it makes sense for files. And maybe categories... [01:43:38] Yeah. Ish. [01:43:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] The icons for tabs and headings inside Media Settings dialog are missing in Betalabs - 10https://bugzilla.wikimedia.org/67429 (10James Forrester) 5ASSI>3RESO/FIX [01:43:57] But [[:Category:Foo]] doesn't work as [[Category:Foo]] in the Category: namespace… [01:44:02] s/context/ [01:44:03] Whatever. [01:44:26] Same for files [01:44:51] Yeah. [01:45:19] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [01:45:19] 3VisualEditor / 3Mobile: VisualEditor Mobile: Cursor jumps to the beginning of the article, irrespective of the position user trying to tap and put the cursor into - 10https://bugzilla.wikimedia.org/66697 (10James Forrester) [01:45:19] 3VisualEditor / 3Mobile: VisualEditor Mobile:In iOS Safari, the toolbar for Mobile VE also scrolls down when you try to scroll down the page having a node selected - 10https://bugzilla.wikimedia.org/67390 (10James Forrester) [01:45:19] 3VisualEditor / 3MediaWiki integration: VisualEditor: Floating toolbar is mis-aligned in non-HD vector css - 10https://bugzilla.wikimedia.org/67256 (10James Forrester) [01:45:20] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Pawn appears when inserting a link (no preselected text) and implicitly exiting from the inspector - 10https://bugzilla.wikimedia.org/67088 (10James Forrester) [01:45:33] 3VisualEditor / 3Mobile: VisualEditor Mobile:In Safari, the reference name for a newly added reference is not appearing in the dialog for "Use existing reference" while opening it for the first time - 10https://bugzilla.wikimedia.org/67342 (10James Forrester) [01:45:33] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, after adding a link, the cursor still blinks on CE in the position where it was appearing inside the search box for link inspector - 10https://bugzilla.wikimedia.org/67388 (10James Forrester) [01:45:33] 3VisualEditor / 3Mobile: VisualEditor: In mobile integration, there is no text cursor activation on load - 10https://bugzilla.wikimedia.org/57177 (10James Forrester) [01:45:33] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [01:45:34] 3VisualEditor / 3Mobile: VisualEditor Mobile: Tapping at the end of each link, does copy-paste of preceding link text in Nexus 7(Android 4.4.2) - 10https://bugzilla.wikimedia.org/66755 (10James Forrester) [01:45:35] 3VisualEditor / 3Mobile: VisualEditor Mobile: In iOS Safari, the semi-highlight is still happening on selection of a node when there is no text cursor activation upon opening a page on Mobile VE - 10https://bugzilla.wikimedia.org/67389 (10James Forrester) [01:45:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340 (10James Forrester) [01:45:37] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression] Typing when a block node is selected should replace the node with a new paragraph of the typed input - 10https://bugzilla.wikimedia.org/67177 (10James Forrester) [01:53:46] 3VisualEditor / 3Editing Tools: VisualEditor: "No results found" message appearing even before entering a search term inside Media Settings dialog - 10https://bugzilla.wikimedia.org/67438 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3trivia a:3Moriel Schottlender [02:07:00] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262#c7 (10James Forrester) (In reply to Ed Sanders from comment #6) > It looks like the above commit to Chrome for Mobile has been merged, which > solves... [02:08:01] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector should indicate link target when applied via keyboard shortcut - 10https://bugzilla.wikimedia.org/67446#c1 (10James Forrester) 5NEW>3RESO/WON No. We chose to not show this as the most common case is making an internal link to the term you've se... [02:15:00] 3VisualEditor / 3Editing Tools: VisualEditor: Link annotation gets cut off when label contains linktrail end characters - 10https://bugzilla.wikimedia.org/67447#c1 (10James Forrester) 5NEW>3RESO/WON You've failed to spot the key part of this – you have to select *to or past the end of the link*. Selecti... [02:15:20] (03PS1) 10Catrope: [WIP] Fix highlights on references in IE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143807 [02:25:40] (03PS1) 10Jforrester: Switch from to in MWReferenceNode to be equivalent to Parsoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143808 [02:31:40] (03PS1) 10Jforrester: build: Merge intro.css and intro.js.txt to intro.txt as they're identical [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143810 [02:32:30] 3VisualEditor / 3Editing Tools: VisualEditor: Link annotation gets cut off when label contains linktrail end characters - 10https://bugzilla.wikimedia.org/67447#c2 (10This, that and the other) (In reply to James Forrester from comment #1) > This is intentional behaviour. Doesn't it strike you as something a... [02:32:43] (03PS1) 10Jforrester: Update OOjs UI to v0.1.0-pre (85cfc2e735) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143812 [02:33:53] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.1.0-pre (85cfc2e735) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143812 (owner: 10Jforrester) [02:34:16] (03CR) 10Catrope: [C: 032] Switch from to in MWReferenceNode to be equivalent to Parsoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143808 (owner: 10Jforrester) [02:34:43] (03CR) 10Catrope: [C: 032] build: Merge intro.css and intro.js.txt to intro.txt as they're identical [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143810 (owner: 10Jforrester) [02:35:56] (03Merged) 10jenkins-bot: Update OOjs UI to v0.1.0-pre (85cfc2e735) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143812 (owner: 10Jforrester) [02:37:06] (03Merged) 10jenkins-bot: build: Merge intro.css and intro.js.txt to intro.txt as they're identical [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143810 (owner: 10Jforrester) [02:37:19] (03Merged) 10jenkins-bot: Switch from to in MWReferenceNode to be equivalent to Parsoid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143808 (owner: 10Jforrester) [02:55:56] (03CR) 10Jforrester: Grunt: Create a distribution files for the ve module (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/137367 (https://bugzilla.wikimedia.org/66117) (owner: 10Jforrester) [02:56:40] (03PS1) 10Catrope: Followup 54458c8: make newly RTFified icons actually work everywhere [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143817 [02:57:36] (03CR) 10Jforrester: [C: 032] Followup 54458c8: make newly RTFified icons actually work everywhere [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143817 (owner: 10Catrope) [02:59:17] (03Merged) 10jenkins-bot: Followup 54458c8: make newly RTFified icons actually work everywhere [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143817 (owner: 10Catrope) [03:03:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: Title is not updated on save if DISPLAYTITLE changed - 10https://bugzilla.wikimedia.org/50341#c14 (10James Forrester) (In reply to Alex Monk from comment #13) > So this appears to actually be working now. Woo-hoo. :-) [03:03:15] 3VisualEditor / 3Technical Debt: VisualEditor: Create distribution files for VE core - 10https://bugzilla.wikimedia.org/66117 (10James Forrester) 5PATC>3RESO/FIX [03:04:15] 3VisualEditor / 3Editing Tools: VisualEditor: Link annotation gets cut off when label contains linktrail end characters - 10https://bugzilla.wikimedia.org/67447#c3 (10James Forrester) (In reply to This, that and the other from comment #2) > (In reply to James Forrester from comment #1) > > This is intentiona... [03:26:39] mooeypoo: BTW, clearly media search/etc. isn't complete 'til we can easily do https://www.mediawiki.org/w/index.php?title=Help:VisualEditor/User_guide&diff=next&oldid=1030329 right? :-) File name evaluated as a concat of a string with a parser function reporting on a string with a magic word returning a string or a magic word. [03:26:42] mooeypoo: Simple, right? [04:19:18] James_F|Away, O.O [06:00:22] (03PS7) 10Mooeypoo: MWImageModel unit tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/141749 [07:07:05] (03CR) 10Divec: [C: 032] ve.ce.Surface: Prevent incorrect pawning in Opera 12 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143322 (https://bugzilla.wikimedia.org/63630) (owner: 10Bartosz Dziewoński) [07:08:46] (03Merged) 10jenkins-bot: ve.ce.Surface: Prevent incorrect pawning in Opera 12 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143322 (https://bugzilla.wikimedia.org/63630) (owner: 10Bartosz Dziewoński) [10:03:15] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262#c8 (10Ed Sanders) OS update is not an issue, just app. [10:08:31] 3VisualEditor / 3MediaWiki integration: VisualEditor: On a redirected page, VE URL retains original searched title instead of redirect title - 10https://bugzilla.wikimedia.org/67330 (10Bartosz Dziewoński) [10:33:15] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing Escape or Tab in an empty line inserts pawn symbol (♙) in Opera 12 - 10https://bugzilla.wikimedia.org/63630 (10Bartosz Dziewoński) 5PATC>3RESO/FIX [13:42:30] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036#c8 (10Ed Sanders) This is clearly a browser bug, will file upstream, but we may have to find a workaround. [13:52:45] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036#c9 (10Ed Sanders) Upstream: https://code.google.com/p/chromium/issues/detail?id=391271 [14:23:40] hi there! is there someone that can help me with finding how I can make a short script that adds an internal link in a VisualEditor instance ? [14:24:07] kind of https://www.mediawiki.org/wiki/VisualEditor_gadgets#adding_templates but for a link [14:34:01] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - 10https://bugzilla.wikimedia.org/48789 (10Krinkle) [14:34:01] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to create auto-numbered external links and to convert them to real links (with an explicit anchor) - 10https://bugzilla.wikimedia.org/51309 (10Krinkle) [14:34:46] 3VisualEditor / 3Data Model: VisualEditor: Converting a numbered external link to a regular one from the link inspector drops the annotations - 10https://bugzilla.wikimedia.org/67377 (10Krinkle) [14:34:46] 3VisualEditor / 3Editing Tools: VisualEditor: Improvements and behaviour changes to the link input widget (tracking) - 10https://bugzilla.wikimedia.org/48789 (10Krinkle) [14:38:38] Toto_Azero: it'll probably be rather different, because links are 'annotations' instead of 'nodes' in VE [14:39:11] Toto_Azero: 'annotation' by VE's definition is something that can be applied to text, usually text style like bold or italic, but links also work this way [14:39:41] while 'node' is a separate , "atomic" element, like an image or inline template [14:40:04] (03CR) 10Krinkle: "Making it possible and setting it as default behaviour are not the same thing. I'm not sure we should encourage users to create external l" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [14:40:17] MatmaRex: ok! do you think there is a way using ve.ui.AnnotationAction.js? [14:41:15] 3VisualEditor / 3Editing Tools: VisualEditor: Support creation of auto-numbered external links and to convert them to labeled ones - 10https://bugzilla.wikimedia.org/51309 (10Krinkle) [14:41:40] actually I’m looking to add a button to VE’s toolbar on a local wiki, so I can make changes in VE’s sources (and that’s what I’m doing) [14:41:41] there definitely is *a* way, let me try to figure out how to do that [14:42:50] thanks :) [14:58:45] 3VisualEditor / 3Data Model: VisualEditor: Edit led to a DEFAULTSORT entry being removed(?) - 10https://bugzilla.wikimedia.org/65200#c1 (10Elitre) Here https://fr.wikipedia.org/w/index.php?title=Henri_D%C3%A8s&diff=105153393&oldid=104979477 and here https://fr.wikipedia.org/w/index.php?title=Henri_D%C3%A8s&d... [15:01:30] MatmaRex: is http://www.mediawiki.org/wiki/VisualEditor/Node_types up-to-date? Because I get the error "No class registered by that name: link/wikiLink" when I try to use the link/wikiLink type for annotations [15:02:35] Toto_Azero: try link/mwInternal [15:02:59] and link/extLink is now link/mwExternal [15:03:03] MatmaRex: I get « TypeError: dataElement.attributes is undefined » [15:03:36] then apparently we're at the same point :P [15:03:43] it looks like you'll want to use surfaceModel.getFragment().annotateContent(…) [15:03:55] but i'm not sure how to use it [15:04:14] hum… :/ [15:05:20] oooooh, this worked. [15:05:50] Toto_Azero: http://pastebin.com/Nh1br7NQ [15:06:17] each of the four occurences of 'VisualEditor' (this is the link target page) apparently has to be encoded slightly differently [15:07:02] the above probably only works if the link target page only consists of ASCII letters [15:07:49] MatmaRex: I confirm! Wonderful, many thanks :) [15:08:07] and anyways I’ll only use ASCII letters I think ^^ [15:08:30] Toto_Azero: the code that normally generates the data model (linkAnnotation variable in my snippet) is here: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/dm/annotations/ve.dm.MWInternalLinkAnnotation.js#L37-L77 [15:09:24] but it seems to be impossible to get a working 'converter' to pass to that method unless you're converting an entire HTML document to VisualEditor's data model format [15:10:14] MatmaRex: ok, I’ll have a look at it… actually I’m trying to add a button to VE’s toolbar to make adding links to others namespaces easier (I know that’s already esay, but I’m prettyt sure the people that will use it will find it too hard :p) [15:12:19] anyway thank you again :) [15:16:30] 3VisualEditor / 3Mobile: VisualEditor Mobile: Chrome for mobile keyboard doesn't fire useful key events for backspace - 10https://bugzilla.wikimedia.org/67262#c9 (10Brion Vibber) Note that Android 4.4's WebView is based on the Chromium engine, and unlike the standalone Chrome app it only gets updated with th... [15:33:30] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing Escape or Tab in an empty line inserts pawn symbol (♙) in Opera 12 - 10https://bugzilla.wikimedia.org/63630 (10James Forrester) [15:37:15] 3VisualEditor / 3MediaWiki integration: VisualEditor: On a redirected page, VE URL retains original searched title instead of redirect title - 10https://bugzilla.wikimedia.org/67330#c6 (10James Forrester) 5PATC>3ASSI Likely to be made WORKSFORME by gerrit 143852 but isn't actually a patch for VE. :-) [15:48:00] 3VisualEditor / 3ContentEditable: VisualEditor: Clearing float from a template like {{-}} doesn't work - 10https://bugzilla.wikimedia.org/65249 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3minor [15:48:31] 3VisualEditor / 3ContentEditable: VisualEditor: Adjacent floating tables are offset by vertical space because of intervening - 10https://bugzilla.wikimedia.org/57372 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal s:5normal>3minor [15:59:34] (03CR) 10Bartosz Dziewoński: "This only happens if the user has no selection (just the cursor) and tries to insert an external link. I don't think that's common, and I " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143346 (https://bugzilla.wikimedia.org/51309) (owner: 10Bartosz Dziewoński) [16:08:13] (03PS1) 10Cmcmahon: [BrowserTest] change search criteria for beta labs issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143895 [16:09:56] (03CR) 10Cmcmahon: [C: 032] [BrowserTest] change search criteria for beta labs issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143895 (owner: 10Cmcmahon) [16:11:35] (03Merged) 10jenkins-bot: [BrowserTest] change search criteria for beta labs issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143895 (owner: 10Cmcmahon) [16:38:32] 3VisualEditor / 3Editing Tools: VisualEditor: Media dialog search box is blank after the first use; should instead be reset to the page name - 10https://bugzilla.wikimedia.org/65038#c2 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal s:5normal>3enhanc a:3Moriel Schottlender Re-writing the b... [16:45:45] 3VisualEditor / 3Data Model: VisualEditor: Converting a numbered external link to a regular one from the link inspector drops the annotations - 10https://bugzilla.wikimedia.org/67377 (10James Forrester) [17:23:59] RoanKattouw_away: https://bugzilla.wikimedia.org/67420#c28 was the bug I mentioned. [17:28:58] MatmaRex: I should really document the attributes of internal links better [17:29:18] hrefPrefix and origTitle are only used for links that came from Parsoid, where we have to preserve things from the original HTML [17:29:30] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error: Offset could not be translated to a DOM element and offset: 55 while changing Image type from Thumbnail to Basic and getting stuck in VE - 10https://bugzilla.wikimedia.org/66604#c6 (10Ed Sanders) On test 2 wiki: the first case still throws an excep... [17:29:30] title is required for obvious reasons [17:29:41] normalizedTitle is the title normalized to getPrefixedText() format and is required [17:29:46] Krinkle: so, what can I do to help you with the CSS janus stuff? [17:29:54] lookupTitle is the title normalized to ... something and is required [17:30:19] Oh, I see [17:30:30] TrevorParscal: on github in your cssjanus repo grant me admin access, and on the command line when in that repo's directory, npm owner add krinkle [17:30:36] ok [17:30:42] normalizedTitle and lookupTitle are both getPrefixedText()-style normalizations, but normalizedTitle includes the #fragment while lookupTitle doesn't [17:30:49] I'll be careful, of course :) [17:31:31] TrevorParscal: Word of warning: do not drive into SF. Take BART [17:31:52] TrevorParscal: 280 is closed for construction, 101 is rumored to be backed up from Brisbane [17:32:13] Krinkle: ok, done [17:32:19] i gotta come in now [17:32:22] cyall in a bit [17:32:45] 3VisualEditor / 3Editing Tools: VisualEditor: Getting Error: Offset could not be translated to a DOM element and offset: 55 while changing Image type from Thumbnail to Basic and getting stuck in VE - 10https://bugzilla.wikimedia.org/66604#c7 (10Ed Sanders) 5RESO/FIX>3REOP first case works perfectly in ma... [17:33:19] edsanders: Which case are you talking about exactly? [17:33:30] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by slugs - 10https://bugzilla.wikimedia.org/66604 (10Ed Sanders) [17:33:36] RoanKattouw, Comment 2 [17:34:30] OK, so I put that wikitext on a page [17:34:39] Then I edit it in VE and change the first image to Basic? [17:35:08] yeah [17:35:21] WFM [17:35:27] Is this an initial selection (1,1) problem maybe? [17:35:37] Because initially the context does not appear for the image, only after I click [17:36:11] I get that too [17:36:20] * edsanders updates master etc. [17:36:38] * RoanKattouw goes away for metrics but will be on gchat [17:36:56] It works if there isn't an image in an image caption on the second node [17:37:26] so could well be a problem with handlesOwnChildren nodes and offset searching [17:38:42] Sure [17:38:47] But I *do* have an image there [17:38:57] Although the second image is frameless so the caption isn't visible [17:43:01] (03PS1) 10Jforrester: Update VE core submodule to master (a2709b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143919 [17:44:01] James_F, feed me bugs [17:44:25] mooeypoo: https://gerrit.wikimedia.org/r/#/c/140773/ :-) [17:44:29] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (a2709b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143919 (owner: 10Jforrester) [17:46:22] James_F, just to make sure, in 'comments' you mean in the wikitext? what wikitext should I use to test this? [17:46:29] (03Merged) 10jenkins-bot: Update VE core submodule to master (a2709b5) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/143919 (owner: 10Jforrester) [17:46:55] mooeypoo: Yes, HTML comments like FooBar. [17:47:01] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] Link Suggestions are now not appearing for Desktop VE - 10https://bugzilla.wikimedia.org/67437#c3 (10ryasmeen) Verified the fix in Betalabs [17:48:46] 3VisualEditor / 3Editing Tools: VisualEditor: For all templates , "Template:" is getting added as a prefix while searching from Template dialog box - 10https://bugzilla.wikimedia.org/67384#c3 (10ryasmeen) Verified the fix in Betalabs [17:48:55] * mooeypoo nods [17:49:38] mooeypoo: It's pretty free-form right now in design. [17:50:27] James_F, i wasn't even aware people use that in articles. [17:57:07] mooeypoo: Only occasionally, but sadly mostly for important messages for editors like "Don't change this!". [17:57:19] * mooeypoo nods [18:03:17] TrevorP|Away: thx [18:16:59] (03PS1) 10Catrope: [WIP] Disable triple-click handling with a hack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/143929 [18:25:41] (03PS5) 10Mooeypoo: [WIP] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [18:45:16] James_F, there's a problem in parsoid-side as far as I could see with comments [18:45:48] James_F, if I try directly in parsoid, this: "FooBar" just gets outputted as

FooBar

[18:45:52] err [18:46:06] What's the problem? [18:46:14] ok this is weird [18:46:23] When I inspect, I don't see the comment [18:46:26] when I copy/paste, it's there [18:46:28] ...wtf [18:46:34] Oh, your browser might be hiding it. [18:46:41] Some of them do that sometimes. [18:46:58] That is extremely confusing [18:47:09] In VE's CE rendering, the comment won't be there, I don't think? [18:47:17] Depending on what James's WIP change does [18:47:39] RoanKattouw_away, yeah they won't be, I think I should add a ve.dm for them [18:47:52] which is another interesting challenge, since the comment tage isn't exactly a tag [18:48:09] I'm not entirely sure how to tell the dm to pick up the tag. [18:48:44] There's ve.dm.CommentMetaItem [18:48:51] So it gets pulled into metadata [18:48:58] oh, I see. hmm. [18:49:01] The solution might be as simple as changing CommentMetaItem to be a Node instead of a MetaItem [18:49:15] (Make it an inline node for now, we'll make it a hybrid later) [18:49:18] * mooeypoo nods [18:51:41] RoanKattouw, ok, I'm a little confused about something with our extending of objects [18:52:14] in some cases I see currentObject.super.call( ... ) and in others parentObject.apply( ... ) [18:52:23] is there a real difference, or is this just inconsistency in the code? [18:52:45] mooeypoo: We're meant to use .super [18:52:53] mooeypoo: But no-one's gone through and transitioned them all. [18:52:59] oh, okay [18:53:15] so it's just inconsistencies, not actual intended difference [18:53:24] Yeah. [18:53:34] Except very occasionally you use a non-parent method like that. [18:53:36] So be careful. [18:54:55] mooeypoo: Also, in oojs-ui we consistently use .super but in the VE repos I don't think we've migrated everything yet [18:55:20] * mooeypoo nods [18:55:21] Indeed. [18:55:36] And yes, be careful with mixins [18:55:44] When you override a method from a mixin, .super won't be right [18:56:55] so we removed so jQuery 1.8 hacks after the upgrade, which means VE is now *dependent* on jQuery 1.11 [18:57:09] we should probably mention this somewhere [18:57:31] and Wikia may not thank us for it :) [18:58:40] needs more $.noConflict()! [18:58:59] Oh god [18:59:01] You remember $j? [18:59:20] although I guess we have an MW requirement for VE which implies that [19:00:33] edsanders: Ha. Whoops. [19:19:40] RoanKattouw_away, I have a bit of a convoluded idea for the comments (but it doesn't work) .. I can't see a way to stylize the actual original so I want to transform it into a with the comment in some attribute or data. Thing is, I can't manage to get the DM to replace it, and I don't understand why. [19:20:11] (03PS1) 10Esanders: Skip over nested handlesOwnChildren nodes in getRelativeOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144004 (https://bugzilla.wikimedia.org/66604) [19:20:39] mooeypoo: Doesn't my patch do that? [19:21:47] James_F, no, it doesn't translate the element [19:21:53] it leaves it as is [19:21:57] Hmm. It should have. [19:22:06] I want it to be a span. I am pretty sure the DM should do that though, no? [19:22:10] No, that's CE's job. [19:22:16] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10Ed Sanders) [19:22:24] the CE seems to have added style, but the style can't be added to that type of node [19:22:26] https://gerrit.wikimedia.org/r/#/c/140773/5/modules/ve/ce/nodes/ve.ce.CommentNode.js says output this as a
[19:22:34] James_F, isn't it a "toDomElement" in the dm ? [19:22:40] No. [19:22:47] DM methods are badly named. [19:23:04] toDomElement is "take the linear model and make it into Parsoid HTML". [19:23:13] hrm [19:23:20] CE does the "take the linear model and make into CE HTML". [19:23:21] the images threw me off; we translate a lot of stuff there [19:23:36] I was sure it is giving the basis for the CE to then manipulate [19:27:17] (03PS15) 10Trevor Parscal: [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 [19:28:41] (03PS5) 10Trevor Parscal: Update OOjs UI to v0.1.0-pre (bcde5fd0bd) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 [19:28:44] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (bcde5fd0bd) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141088 (owner: 10Trevor Parscal) [19:28:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP|BREAKING CHANGE] The great and terrible dialog refactor [oojs/ui] - 10https://gerrit.wikimedia.org/r/139550 (owner: 10Trevor Parscal) [19:29:11] (03PS5) 10Trevor Parscal: [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 [19:29:34] mooeypoo: What I think you need to do is make dm.CommentMetaItem a Node so that it doesn't jump out of the linear model [19:29:42] RoanKattouw_away, I did. [19:29:44] Don't touch the toDomElement stuff, because that's for sending things back to Parsoid [19:29:49] * mooeypoo nods [19:29:54] Then in the ce.Node is where rendering takes place [19:29:55] I did. I changed it to a node -- a leaf node [19:30:01] What you're doing is unexplored territory though [19:30:05] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Dialog Rewrite [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141089 (owner: 10Trevor Parscal) [19:30:08] but I am not sure how to get the CE to "pick it up" though [19:30:12] it seems to go by tag names [19:30:14] and this isn't a tag, per say [19:30:22] No tagName is for rendering too [19:30:27] Well, first question is, is is it in the linmod [19:31:00] just checking that out too [19:31:05] hang on [19:33:07] RoanKattouw, it has 'aliennode' [19:33:11] ok, linear model picks stuff up by their tags, no? [19:33:30] So the comment is an alienNode in the DM? [19:33:36] the dm has matchTagNames = [ '#comment' ] [19:33:48] Yes [19:34:02] yeah, so I took the old ve.dm.CommentMetaItem and turned it into ve.dm.CommentNode [19:34:05] Hmm I sure hope there isn't a converter bug here [19:34:20] and OO.inheritClass( ve.dm.CommentNode, ve.dm.LeafNode ); [19:34:47] it should work *if* the matchTagNames is correct... how's #comment a tag name? [19:34:51] Nooo [19:34:53] dm.LeafNode is a mixing [19:34:53] nooo? [19:35:03] Or not [19:35:06] Sorry, ignore me [19:35:08] Carry on [19:35:09] it.. is? [19:35:11] oh [19:35:15] mooeypoo: Can you pastebin your dm.CommentNode file? [19:35:20] yep hang on [19:35:34] Also, check if it's loaded by running "ve.dm.CommentNode" in a console [19:35:43] And checking that that displays something other than undefinerd [19:36:27] http://pastebin.com/sAXSPd2A [19:36:46] ve.dm.Comment.super.call( this, element ); [19:36:48] That'll fail [19:36:58] Because there is no such thing as ve.dm.Comment [19:37:01] I get this -- function VeDmCommentNode( element ) { [19:37:02] ve.dm.Comment.super.call( this, element ); [19:37:02] } [19:37:12] when I run ve.dm.CommentNode in the console. So it seems to be loaded [19:37:22] oh crapola [19:37:24] seriously, me [19:37:34] Other than that your file seems fine [19:38:12] Another useful debugging thing is to run the following in the console: [19:38:14] ve.dm.modelRegistry.matchElement(document.createComment('foo')) [19:38:15] should return "comment" [19:38:23] ok, still getting 'aliennode' though [19:38:40] Hmm [19:38:43] and that did. [19:38:48] Did what? [19:38:50] Return 'comment'? [19:38:58] also, I'm getting an error in the console that I am not sure what it's about [19:39:32] ok ,one by one. the line above returned 'comment'. The linear model still shows "aliennode" even after my silly typo change. And now I have a weird error in the console: [19:39:52] Uncaught TypeError: undefined is not a function ve.ce.FocusableNode.js:442 [19:39:53] ... [19:40:19] RoanKattouw, that happens when i mark the entire line of the text in VE [19:40:42] BTW, https://www.mediawiki.org/wiki/VisualEditor/status#2014-07-03_.28MW_1.24wmf12.29 is rather impressive. [19:41:08] 37 bugs in VE alone. [19:41:16] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [19:42:17] btw, images in captions are a problem in general James_F .. they are a problem in the php parser, too [19:42:28] mooeypoo: OK let's forget about that error for now... what does your linear model look like? [19:43:15] RoanKattouw, 'paragraph', 'f','o','o','alieninline','/alieninline','b','a','r','/paragraph' [19:43:21] wtf [19:43:30] RoanKattouw, want me to push what I have to gerrit? [19:44:02] I get that too [19:44:04] Yes please do [19:44:07] it makes no sense. :\ [19:44:08] ok hang on [19:44:08] Trying to figure out why this happens [19:44:25] I changed the name of the file and the node, so lots of trivial changes in different files [19:44:45] (03PS6) 10Mooeypoo: [WIP] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [19:45:12] Trying to figure out if this is a converter bug [19:45:36] (03PS1) 10Esanders: Restrict get relative offset to movements of +/-1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144046 [19:46:24] I'm trying to see if I may have missed something [19:46:26] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [19:46:31] but it should work, I think [19:48:38] Ooooooh [19:48:45] Try setting .static.isContent = true; [19:49:17] RoanKattouw, in the dm ? [19:49:19] Yes [19:49:30] dm.CommentNode was implicitly registered as a block node without that line [19:49:40] And you can't have block nodes inside of paragraphs [19:50:24] how is it a block node? Isn't a leaf node not a block? [19:50:29] So the converter wraps it in an alienInline instead out of self-defense [19:50:42] No, leaf/branch has to do with whether they can have children [19:50:46] A BranchNode must be block [19:50:51] But a LeafNode can be either block or inline [19:50:57] oh, I didn't know leaf node can be either [19:51:02] Example: alienBlock [19:51:06] Does not have children, is block [19:51:17] hmmm [19:51:21] In VE terminology, inline nodes are called "content" [19:51:49] Then things like paragraphs and headings are called "content branch nodes", they're branch nodes whose children must be content [19:51:57] ah [19:52:02] Also, all content nodes must be the children of a content branch node (CBN), [19:52:08] wtf.. I'm getting "Uncaught Error: No class registered by that name: comment " [19:52:10] If only we had documentation, hmm? ;-) [19:52:11] how did that happen [19:52:13] so in other words, normal branch nodes (e.g. table) cannot contain content directly [19:52:23] mooeypoo: You apparently didn't register a CE node for 'comment' with the ce.nodeFactory [19:52:27] That's the same error I got [19:52:39] (when I ran just your DM code) [19:52:49] James_F's code has it though [19:52:58] ve.ce.CommentNode.static.name = 'comment'; [19:53:02] ve.ce.nodeFactory.register( ve.ce.CommentNode ); [19:53:02] Yeah but does it /load/ that file? [19:53:09] You have to add it to VisualEditor.php and stuff [19:53:09] ... ahha [19:53:17] that is a pretty good point, right there. [19:53:52] Or, like James is suggesting, work in standalone first :) [19:56:41] \o/ now it works [20:07:13] Sweet [20:13:43] (03CR) 10Catrope: [C: 032] Skip over nested handlesOwnChildren nodes in getRelativeOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144004 (https://bugzilla.wikimedia.org/66604) (owner: 10Esanders) [20:15:13] (03CR) 10Catrope: [C: 032] Restrict get relative offset to movements of +/-1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144046 (owner: 10Esanders) [20:15:15] (03Merged) 10jenkins-bot: Skip over nested handlesOwnChildren nodes in getRelativeOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144004 (https://bugzilla.wikimedia.org/66604) (owner: 10Esanders) [20:15:16] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) 5PATC>3RESO/FIX [20:16:54] (03Merged) 10jenkins-bot: Restrict get relative offset to movements of +/-1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144046 (owner: 10Esanders) [20:43:25] (03PS1) 10Jforrester: [WIP] Put "re-use reference" in the toolbar "Cite" menu, and give it an icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144058 [20:53:37] (03PS1) 10Cmcmahon: Revert "[BrowserTest] change search criteria for beta labs issue" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144060 [20:54:02] (03CR) 10Cmcmahon: [C: 032] "Reverting unnecessary change" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144060 (owner: 10Cmcmahon) [20:55:46] (03Merged) 10jenkins-bot: Revert "[BrowserTest] change search criteria for beta labs issue" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144060 (owner: 10Cmcmahon) [21:02:00] 3VisualEditor / 3ContentEditable: VisualEditor: Drag and drop inserted the relocatable node image marker as a data:image/gif;base64 string - 10https://bugzilla.wikimedia.org/62728#c2 (10James Forrester) 5ASSI>3RESO/WOR I can't replicate; I've not seen any other reports like this; and we re-wrote this sys... [21:07:31] 3VisualEditor / 3Editing Tools: VisualEditor: For all templates , "Template:" is getting added as a prefix while searching from Template dialog box - 10https://bugzilla.wikimedia.org/67384#c4 (10ryasmeen) Verified the fix in test2 [21:08:38] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf12] Link Suggestions are now not appearing for Desktop VE - 10https://bugzilla.wikimedia.org/67437#c4 (10ryasmeen) Verified the fix in test2 [21:17:32] 3VisualEditor / 3Editing Tools: VisualEditor:Disable "Apply changes" button on Media Search dialog now that the Edit and search dialog both are merged - 10https://bugzilla.wikimedia.org/67443#c3 (10ryasmeen) Verified the fix in test2 [21:21:10] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326 (10ryasmeen) [21:22:18] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] The Math Inspector loses its focus each time a character is inserted when it tries to parse the new value - 10https://bugzilla.wikimedia.org/67326 (10James Forrester) p:5Unprio>3High [21:34:14] (03PS1) 10Esanders: Check that the surface has a selection after focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144067 [21:36:24] (03CR) 10Inez: "I'm testing it now." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144067 (owner: 10Esanders) [21:52:45] 3VisualEditor / 3MediaWiki integration: VisualEditor: The Help menu does not scroll on small screens while using Monobook - 10https://bugzilla.wikimedia.org/67370 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [22:07:11] Any idea why condition in this if statement: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/master/modules/ve-mw/dm/models/ve.dm.MWImageModel.js#L183 is specifically for type of 'mwBlockImage' instead of just checking if node is a block node? [22:07:53] InezK: No good reason, I think [22:07:59] Feel free to change it [22:08:12] (by which I mean submit a change to Gerrit) [22:08:21] :-) [22:09:17] (03CR) 10Esanders: "The bug this fixes only appears on Wiki where they have disabled slugs. To recreate:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144067 (owner: 10Esanders) [22:11:39] RoanKattouw: how would you check if something is a block? by checking instanceof BranchNode? [22:16:52] No, there's a thing [22:16:54] Let me check [22:17:16] InezK: .isContent() [22:17:21] Returns false for "block" and true for "inline" [22:17:39] (03CR) 10Catrope: [C: 032] Check that the surface has a selection after focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144067 (owner: 10Esanders) [22:19:06] (03Merged) 10jenkins-bot: Check that the surface has a selection after focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144067 (owner: 10Esanders) [22:29:48] (03PS1) 10Catrope: Use addClass() correctly, otherwise references don't get the 'reference' class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144076 [22:30:14] (03CR) 10Jforrester: [C: 032] Use addClass() correctly, otherwise references don't get the 'reference' class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144076 (owner: 10Catrope) [22:30:40] (03PS1) 10Jforrester: Use addClass() correctly, otherwise references don't get the 'reference' class [extensions/VisualEditor] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144077 [22:30:45] RoanKattouw: ^^^ [22:32:33] (03Merged) 10jenkins-bot: Use addClass() correctly, otherwise references don't get the 'reference' class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144076 (owner: 10Catrope) [22:54:03] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf12] The highlight for centered images is taking 100% width - 10https://bugzilla.wikimedia.org/67507 (10ryasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 15839 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15839&action=e... [23:01:53] James_F, I do hope that what you will approve of what i'm doing to your commit. [23:05:07] (03CR) 10Mwalker: [C: 032] Use addClass() correctly, otherwise references don't get the 'reference' class [extensions/VisualEditor] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144077 (owner: 10Jforrester) [23:06:50] (03Merged) 10jenkins-bot: Use addClass() correctly, otherwise references don't get the 'reference' class [extensions/VisualEditor] (wmf/1.24wmf12) - 10https://gerrit.wikimedia.org/r/144077 (owner: 10Jforrester) [23:11:05] (03PS1) 10Krinkle: ve.ce.MWReferenceListNode: Fix broken jQuery#addClass call (variadic arguments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144082 [23:15:37] mooeypoo: I have trust in you. :-) [23:15:43] mooeypoo: And I also have -2 rights. :-) [23:15:48] haha [23:16:23] James_F, I'm going at the inspector route... it is less cluttered when/if the comment is big. [23:16:42] Less cluttered than a small icon? [23:16:53] small icon that opens an inspector? [23:16:58] Yeah. [23:17:02] Rather than the context. [23:17:02] yeah, that's what I'm doing [23:17:13] wait, define "rather than the context" [23:17:15] :D [23:18:00] James_F, I made the CommentNode a focusable node that pops up a comment inspector [23:18:05] you can read the comment and edit it [23:18:18] and I am trying to figure out why it won't let me delete it properly, but it should do that too [23:18:22] I think Kaity and I were thinking of a small yellow box inline (ish, superscript) with just an icon, with the text available through an inspector. [23:18:39] * mooeypoo nods [23:18:44] So it's really really obvious that there's a note, but it doesn't take over your life. [23:19:07] yeah, I'll need to replace the lovely yellow box (nice choice of colors, btw) with an icon once we have it [23:19:19] is this the disabled parameters thing? [23:19:35] it's the comment [23:19:45] [23:20:43] James_F, for the moment, there's a yellow block in the middle of the text, but that's just because I don't have an icon [23:24:05] oh yes [23:24:17] (03CR) 10Jforrester: [C: 04-1] ve.ce.MWReferenceListNode: Fix broken jQuery#addClass call (variadic arguments) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144082 (owner: 10Krinkle) [23:24:34] mooeypoo: oo-ui-icon-alert [23:25:47] mooeypoo: I think we said "PostIt note yellow" or something similar (Google claims that's #FFFFA5) [23:26:04] yeah I figured that's what you were going for [23:28:51] I'm having a lot of problems with the way theinspector "fits" into the stuff inside it [23:28:56] it's eating at my elements. I don't get it [23:31:08] (03PS2) 10Krinkle: ve.ce.MWReferenceListNode: Add class 'references' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144082 [23:33:51] mooeypoo: What do you mean? [23:34:03] (03CR) 10Jforrester: [C: 032] ve.ce.MWReferenceListNode: Add class 'references' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144082 (owner: 10Krinkle) [23:35:42] mooeypoo: Is it sitting on top of the node? [23:35:44] (03Merged) 10jenkins-bot: ve.ce.MWReferenceListNode: Add class 'references' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/144082 (owner: 10Krinkle) [23:37:46] (03PS1) 10Inez: Blur contentEditable node while destroying surface. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144089 [23:39:35] ugh [23:40:00] blocks in VE show html-escaped '>' instead of > after editing [23:40:20] (the saved content is correct at least) [23:40:32] MatmaRex: I know :( [23:40:35] There's a bug about it already [23:40:52] (or rather, the other way that i wrote) [23:40:54] okay [23:40:57] thanks :) [23:41:11] maybe i'll fix it… [23:43:06] * James_F hunts. [23:43:50] MatmaRex: Yeah, I know, it saves correctly, but previews incorrectly. It was too much of a headache for me to try to fix so I chickened out and threw it in BZ instead [23:44:00] MatmaRex: https://bugzilla.wikimedia.org/show_bug.cgi?id=66456 [23:44:20] RoanKattouw, James_F I added a (and also tried it as

) to my inspector and a button. They're supposed to be inside the inspector -- but the inspector opens up as too small (the button doesn't appear) and the text runs outside of the border of the inspector itself [23:44:23] it's very annoying. [23:44:24] (i'm doing some cleanup of https://www.mediawiki.org/wiki/Manual:Skinning?veaction=edit#Skin_structure ) [23:44:34] James_F: thanks, will look later [23:44:51] MatmaRex: Also https://bugzilla.wikimedia.org/show_bug.cgi?id=57429 [23:47:23] (03PS7) 10Mooeypoo: [WIP] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [23:48:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Show comments inline to the user [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140773 (https://bugzilla.wikimedia.org/49603) (owner: 10Jforrester) [23:49:17] interesting. [23:50:03] anyways RoanKattouw / TrevorParscal any ideas what's wrong with my inspector? The is going outside f the confines of the the inspector, and the button isn't showing.. Must be some CSS I'm missing here. [23:50:26] mooeypoo: When are you creating that span? [23:50:32] in the $form [23:50:36] this.$form [23:50:39] like in the language inspector [23:50:45] Maybe you're creating it after the inspector has already been measured? [23:50:51] (03CR) 10Esanders: "*on Wikia" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/144067 (owner: 10Esanders) [23:51:06] RoanKattouw, I thought I was supposed to do it in .initialize ? [23:51:18] That should work [23:51:19] oh! maybe I should have the super at the end [23:51:36] Huh? [23:51:38] no [23:51:48] no [23:51:52] that will break terribly [23:52:00] wait, no, I won't have the bits of it [23:52:01] yeah [23:52:05] i just realized [23:52:09] no. So. meh. [23:52:12] What I *think* is happening is that $view is initially empty, so the measurement is made based on it being empty [23:52:20] But then you put stuff in it, so it pushes everything down [23:52:30] hmmm [23:52:42] how can I fix that? The content can change -- it can be really big or really small... [23:52:53] Which, we really should not measure based on initialized state rather than setup state, but for all inspectors we have so far, they're the same [23:52:56] I don't know [23:53:01] Let me ask Trevor real quick [23:53:05] thanks! [23:53:23] I wonder if there's some css rule to make the display conform [23:55:01] Trevor says it's a mess and it should be fixed with his window rewrite [23:55:31] * mooeypoo nods [23:55:46] so for the moment I'll concentrate on the other issues, like why it won't delete [23:56:13] deletion should be trivial.. i don't understand... am I supposed to do something special for delete?