[00:00:21] I'll be interested to see how much was actually in it [00:00:27] heading to the store in a bit [00:00:58] I'll check back when I return [00:36:12] (03PS1) 10Catrope: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) [00:37:40] (03CR) 10jenkins-bot: [V: 04-1] Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) (owner: 10Catrope) [00:42:33] (03PS2) 10Catrope: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) [00:43:50] (03CR) 10jenkins-bot: [V: 04-1] Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) (owner: 10Catrope) [00:45:18] (03PS1) 10Jforrester: [BREAKING CHANGE] Tool: Use the LabelElement and TitledElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 [00:45:20] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Tool: Use the LabelElement and TitledElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 (owner: 10Jforrester) [00:53:27] (03PS4) 10Jforrester: Tool: Use FlaggedElement mixin to let tools be flagged [oojs/ui] - 10https://gerrit.wikimedia.org/r/163653 [00:54:24] (03CR) 10Catrope: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163783 (https://bugzilla.wikimedia.org/71373) (owner: 10Catrope) [00:58:35] (03PS2) 10Jforrester: [BREAKING CHANGE] Tool: Use the LabelElement and TitledElement mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/163785 [01:06:03] (03CR) 10Jforrester: [C: 032] Declared missing var, fixed php doc & spelling, spacing [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/161896 (owner: 10Yurik) [01:06:07] (03Merged) 10jenkins-bot: Declared missing var, fixed php doc & spelling, spacing [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/161896 (owner: 10Yurik) [01:13:20] 3VisualEditor / 3Editing Tools: VisualEditor: Be able to set an item's size in upright terms in the media edit dialog - 10https://bugzilla.wikimedia.org/62671#c9 (10James Forrester) (In reply to Spinningspark from comment #8) > One point about the upright parameter is that it does something sensible > with a... [01:15:32] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf1] "Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': .." while inserting a comment - 10https://bugzilla.wikimedia.org/71418 (10James Forrester) 5PATC>3RESO/FIX a:3Roan Kattouw [01:19:20] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134 (10James Forrester) [01:25:46] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c2 (10James Forrester) a:3Roan Kattouw I believe this has now been fixed and backported as part of the fix for bug 71418. [01:26:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417 (10James Forrester) 5ASSI>3RESO/FIX [02:07:15] (03PS1) 10Catrope: Add localsettings.js file [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163792 [02:07:16] (03PS1) 10Catrope: Add localsettings.js file [services/citoid/deploy] - 10https://gerrit.wikimedia.org/r/163792 [02:08:32] WTF why did grrrit-wm report that twice [02:08:46] James_F: What have you wrought? -----^^ [02:09:35] (03PS1) 10Catrope: Add --config to override path to localsettings.js [services/citoid] - 10https://gerrit.wikimedia.org/r/163793 [02:21:56] RoanKattouw: Hmm… [02:21:58] RoanKattouw: Ooooooooh. [02:22:01] Whoops. [02:22:42] RoanKattouw: https://gerrit.wikimedia.org/r/163795 fixes. [02:32:31] Hi. Can i get help in visualeditor setup? Currently on mw 1.25, parsoid is running. [02:33:21] The visualeditor is not loading.. I can't seeit when i tried to edit my pages [02:34:20] Special:version shows it load [02:37:20] (03PS2) 10Jforrester: Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope) [02:40:57] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope) [02:43:45] (03PS3) 10Jforrester: Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope) [02:45:09] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.1.0-pre (a6d3197df2) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163759 (owner: 10Catrope) [06:57:37] 3VisualEditor / 3ContentEditable: VisualEditor: Table with attribute border=0 is displayed as if border=1 - 10https://bugzilla.wikimedia.org/57295#c3 (10Raimond Spekking) 5RESO/FIX>3REOP Maybe a regression: the VE renders the table in https://de.wikipedia.org/w/index.php?title=Landschaftsversammlung_Rhei... [11:08:48] 3VisualEditor: ISBN ending in X is not shown as a link - 10https://bugzilla.wikimedia.org/71462 (10Spinningspark) 3NEW p:3Unprio s:3normal a:3None Intention: ISBN ending in X is not shown as a link Reproducible: Didn't try [13:00:03] (03CR) 10Bartosz Dziewoński: [C: 032] Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope) [13:01:36] (03CR) 10jenkins-bot: [V: 04-1] Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope) [14:15:24] (03PS1) 10Jforrester: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163852 (https://bugzilla.wikimedia.org/71373) [14:15:48] (03CR) 10Jforrester: [C: 032] Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163852 (https://bugzilla.wikimedia.org/71373) (owner: 10Jforrester) [14:17:37] (03Merged) 10jenkins-bot: Followup b149390: fix dm.Surface's concept of "selectedNode" to match SurfaceFragment's [VisualEditor/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163852 (https://bugzilla.wikimedia.org/71373) (owner: 10Jforrester) [14:52:10] (03PS1) 10Jforrester: Update VE core sub-module to wmf/1.25wmf1 for cherry-pick (560f89e) [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163859 [14:52:30] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf1] "Uncaught NotFoundError: Failed to execute 'insertBefore' on 'Node': .." while inserting a comment - 10https://bugzilla.wikimedia.org/71418#c6 (10Ritu Swain) Issue resolved in test2, but can be reproduced in beta. [14:58:35] (03PS1) 10Jforrester: Update VE core submodule to master (0677c3b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163861 [14:58:49] MatmaRex: Feel like +2ing that? [14:59:08] sure [14:59:19] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (0677c3b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163861 (owner: 10Jforrester) [14:59:42] (03CR) 10Chad: [C: 032] Update VE core sub-module to wmf/1.25wmf1 for cherry-pick (560f89e) [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163859 (owner: 10Jforrester) [15:00:21] (03CR) 10Bartosz Dziewoński: Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope) [15:00:27] (03CR) 10Bartosz Dziewoński: [C: 032] Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope) [15:00:40] Thanks. :-) [15:00:49] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c3 (10Ritu Swain) (In reply to James Forrester from comment #2) > I believe this has now been fixed and backported as part of the fix... [15:01:03] (03Merged) 10jenkins-bot: Update VE core submodule to master (0677c3b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163861 (owner: 10Jforrester) [15:01:17] (03Merged) 10jenkins-bot: Update VE core sub-module to wmf/1.25wmf1 for cherry-pick (560f89e) [extensions/VisualEditor] (wmf/1.25wmf1) - 10https://gerrit.wikimedia.org/r/163859 (owner: 10Jforrester) [15:02:03] (03Merged) 10jenkins-bot: Fix JS error in mostly-dead Opera compat code [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163660 (owner: 10Catrope) [15:21:00] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Link inspector does not close when clicking out into non-linked text - 10https://bugzilla.wikimedia.org/71373 (10James Forrester) 5PATC>3RESO/FIX [15:21:35] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Link inspector does not close when clicking out into non-linked text - 10https://bugzilla.wikimedia.org/71373#c8 (10James Forrester) a:5Ed Sanders>3Roan Kattouw Merged into master and deployed to wmf1. [15:45:02] 3VisualEditor: style issue: Cite/Basic/General references text misaligned in Chrome especially - 10https://bugzilla.wikimedia.org/71470 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None Created attachment 16632 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16632&action=edit Truncated text Chr... [15:46:17] 3VisualEditor: style issue: Cite/Basic/General references text misaligned in Chrome especially - 10https://bugzilla.wikimedia.org/71470#c1 (10James Forrester) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 71178 *** [15:46:17] 3VisualEditor / 3Editing Tools: VisualEditor: "Use this Group" menu items, in Reference / Reference list dialogs, have a cut-off display - 10https://bugzilla.wikimedia.org/71178#c7 (10James Forrester) *** Bug 71470 has been marked as a duplicate of this bug. *** [15:49:47] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf1]: “Uncaught TypeError: Cannot read property 'disconnect' of undefined” on closing the Options dialog, after inserting and deleting categories. - 10https://bugzilla.wikimedia.org/71471 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Create... [15:50:15] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf1]: “Uncaught TypeError: Cannot read property 'disconnect' of undefined” on closing the Options dialog, after inserting and deleting categories. - 10https://bugzilla.wikimedia.org/71471#c1 (10Ritu Swain) Created attachment 16634 --> https://bugzil... [15:50:46] 3VisualEditor / 3Editing Tools: VisualEditor[Regression wmf1]: “Uncaught TypeError: Cannot read property 'disconnect' of undefined” on closing the Options dialog, after inserting and deleting categories. - 10https://bugzilla.wikimedia.org/71471 (10Ritu Swain) [16:16:52] MatmaRex, is the fact my stylesheet isn't outputting mw-wiki-logo to do with your Vector refactoring? [16:17:57] edsanders: nope [16:18:07] hm [16:18:10] edsanders: if you're sure you're running latest core and skin, blame krinkle [16:18:20] I'll do some updates [16:18:59] that's better [16:30:48] Corruption alert: visualeditor-needcheck on svwiki: https://sv.wikipedia.org/?diff=27732757 [16:30:48] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107837420 [16:30:48] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107843916 [16:30:48] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107850370 [16:30:48] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107852604 [16:30:49] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107856011 [16:30:49] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107856797 [16:30:49] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107856919 [16:30:49] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107856976 [16:30:50] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32823756 [16:30:51] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32823809 [16:30:51] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=32824743 [16:31:05] Ick. [16:35:23] (03PS1) 10Esanders: Update to use new selection/range API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 [16:35:25] (03PS2) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 [16:36:25] (03CR) 10jenkins-bot: [V: 04-1] Update to use new selection/range API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163873 (owner: 10Esanders) [16:37:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c4 (10James Forrester) I can't; have you refreshed? The citation template now opens as expected. [16:38:00] (03PS45) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [16:40:11] (03PS3) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 [16:40:13] (03PS2) 10Esanders: Handle triple click with surface fragments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163849 [16:40:51] (03PS46) 10Divec: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 [16:43:01] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them, then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined”. - 10https://bugzilla.wikimedia.org/71471 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Normal s:5norm... [16:47:38] (03CR) 10Esanders: "FIXME: this causes horizontal scrolling in the main document" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [16:53:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c5 (10Ritu Swain) (In reply to James Forrester from comment #4) > > > I checked with a clear history.It still does not open the "A... [16:54:17] 3VisualEditor / 3ContentEditable: VisualEditor: Table with attribute border=0 is displayed as if border=1 - 10https://bugzilla.wikimedia.org/57295#c4 (10James Forrester) 5REOP>3RESO/FIX (In reply to Raimond Spekking from comment #3) > Maybe a regression: the VE renders the table in > https://de.wikipedia... [16:54:28] (03CR) 10Bartosz Dziewoński: "Ugh, indeed, but that's not this, that's the OOjs UI dependency. :/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [16:55:55] (03CR) 10Bartosz Dziewoński: "I'll fix it later today (or at least patch it up), I know what's causing it." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [16:56:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c6 (10James Forrester) (In reply to Ritu Swain from comment #5) > I checked with a clear history.It still does not open the "Add a Te... [17:01:30] 3VisualEditor / 3ContentEditable: VisualEditor: Table with attribute border=0 is displayed as if border=1 - 10https://bugzilla.wikimedia.org/57295#c5 (10Raimond Spekking) 5RESO/FIX>3REOP Sorry, but border=1 is very different from border=0. Your "some light default styling" shows a border. This means, thi... [17:06:20] 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900#c1 (10Roan Kattouw) Here's a novel one: https://sv.wikipedia.org/?diff=27732757 [17:12:30] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c7 (10Ritu Swain) (In reply to James Forrester from comment #6) > (In reply to Ritu Swain from comment #5) > > I checked with a clear... [17:22:06] (03PS4) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 [17:34:59] (03PS1) 10Bartosz Dziewoński: PopupWidget: Position body/anchor using 'margin-left' instead of 'left' [oojs/ui] - 10https://gerrit.wikimedia.org/r/163883 [17:35:11] (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/163883" [oojs/ui] - 10https://gerrit.wikimedia.org/r/163280 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [17:35:21] (03CR) 10Bartosz Dziewoński: "Fixed in https://gerrit.wikimedia.org/r/163883 (I hope)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163228 (https://bugzilla.wikimedia.org/52526) (owner: 10Bartosz Dziewoński) [17:35:29] edsanders: https://gerrit.wikimedia.org/r/163883 [17:36:11] why is PopupWidget so weird :( [17:38:00] (03CR) 10Bartosz Dziewoński: "This ought to be reviewed and pulled into VE before next branch cut. I really hope I'm not breaking any other things with this patch, eh." [oojs/ui] - 10https://gerrit.wikimedia.org/r/163883 (owner: 10Bartosz Dziewoński) [17:39:46] TrevorParscal: Please review https://gerrit.wikimedia.org/r/#/c/163883, it's black magic to me [17:41:32] it just *is* black magic. [17:42:13] (03CR) 10Trevor Parscal: [C: 032] PopupWidget: Position body/anchor using 'margin-left' instead of 'left' [oojs/ui] - 10https://gerrit.wikimedia.org/r/163883 (owner: 10Bartosz Dziewoński) [17:43:15] (03Merged) 10jenkins-bot: PopupWidget: Position body/anchor using 'margin-left' instead of 'left' [oojs/ui] - 10https://gerrit.wikimedia.org/r/163883 (owner: 10Bartosz Dziewoński) [17:43:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c8 (10James Forrester) (In reply to Ritu Swain from comment #7) > (In reply to James Forrester from comment #6) > > (In reply to Ritu... [17:43:55] RoanKattouw: Note that pull-through is blocked on fixing up the MediaWiki theme pull-through. [17:44:04] Right [17:44:10] (/cc TrevorParscal – are you close on that?) [17:44:15] I'll see if the MW core one is mergeable [17:44:23] RoanKattouw: Not without breaking VE. [17:44:34] RoanKattouw: Trevor said there needed to be local changes in VE-core and VE-MW. [17:44:45] can I get links to those really quickly so I can inspect them [17:44:46] ? [17:44:51] Sure. [17:44:53] I just know they need to be done carefully [17:45:04] TrevorParscal: The VE-core pull-through is https://gerrit.wikimedia.org/r/#/c/163759/ [17:45:07] I think VE-MW may well keep working with Trevor's MW core pull-through [17:45:08] So I'll test that [17:45:37] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/163763/ is the MW-core one; that needs skin-scripts line added. Want me to fix up? [17:45:46] yeah, sure [17:45:51] OK, one second. [17:45:54] thanks [17:46:50] Uhm [17:47:01] Context anchoring is broken in VE with that change [17:48:08] http://i.imgur.com/vVeevFI.png [17:48:37] RoanKattouw: With which change? MediaWiki theme or "Position body/anchor using 'margin-left' instead of 'left'" [17:48:38] ? [17:48:49] 163763 [17:48:59] (MW core pull-through of Trevor's theme commit) [17:48:59] RoanKattouw: Ah, OK. Yeah, sounds like we need local changes in VE. [17:49:08] (163763 now updated.) [17:51:12] GET http://127.0.0.1/w/resources/lib/oojs-ui/images/textures/pending.gif 404 (Not Found) [17:51:37] That sounds odd. Shouldn't it be using a theme-dependent URL? [17:51:59] Yeah.... [17:52:11] that's what grep tells me too [17:52:21] Except, no [17:52:28] resources/lib/oojs-ui/oojs-ui-apex.svg.css [17:52:30] 1085: background-image: /* @embed */ url(images/textures/pending.gif); [17:52:31] 1210: background-image: /* @embed */ url(images/textures/pending.gif); [17:52:33] 1613: background-image: /* @embed */ url(images/textures/pending.gif); [17:52:34] Oh dear. [17:52:34] 2065: background-image: /* @embed */ url(themes/apex/images/textures/pending.gif); [17:52:42] Want me to fix? [17:53:04] I found the culprits in OOUI [17:53:17] TextInputWidget.less , ActionWidget.less and Dialog.less [17:53:19] "'@{oo-ui-default-image-path}/textures/pending.gif" [17:53:21] Yeah. [17:53:22] Look at how they use pending.gif [17:53:23] Exactly [17:53:29] * James_F tsks TrevorParscal. [17:53:55] Also, this is why it doesn't work in MediaWiki theme either, presumably? [17:53:55] Are you guys in the office today? [17:54:06] Speaking of the office, I should head in [17:54:07] I'm not [17:54:11] InezK: Krinkle and I am; RoanKattouw will be; TrevorParscal isn't. [17:54:15] I will be passing by around 1pm, was thinking about stopping by to say hi [17:54:19] InezK: Do so! [17:54:38] RoanKattouw: you don't like the many pending images of doom? [17:54:55] Ok, see you after 1pm [17:55:28] TrevorParscal: I like them, they're just hiding very well [17:55:41] TrevorParscal: Also have you seen http://i.imgur.com/vVeevFI.png ? [17:56:01] i just noticed that in the ve pull through [17:56:16] have you identified the culprit yet? [17:57:02] I think it's to do with using the wrong css prop post 163883 [17:57:21] TrevorParscal: How do you actually /use/ images in CSS now? [17:57:43] TrevorParscal: I haven't debugged it, was hoping you could [17:58:05] James_F: what do you mean? [17:58:23] like the new icon stuff? [17:58:36] The pending texture in particular [17:58:39] TrevorParscal: 'Cos ".oo-ui-background-image('@{oo-ui-default-image-path}/textures/pending.gif');" looks right. [17:58:56] TrevorParscal: But it generates images/textures/pending.gif rather than themes/apex/images/textures/pending.gif in some cases. [17:59:03] No, in all cases [17:59:13] RoanKattouw: "2065: background-image: /* @embed */ url(themes/apex/images/textures/pending.gif); " [17:59:15] default-image-path doesn't have any images in it any more, all images are theme-specific now AFAIK [17:59:24] why do we have to use a variable? [17:59:29] RoanKattouw: No, "@oo-ui-default-image-path: 'themes/apex/images'; " [17:59:35] RoanKattouw: See images.less in Apex. [17:59:36] even aside from that [17:59:45] TrevorParscal: I don't know, you wrote it. :-) [17:59:50] there are no images in the core styles anymore [18:00:08] There are [18:00:12] Three uses of pending.gif [18:00:14] TrevorParscal: So Dialog.less etc. shouldn't have this, it should be moved into each theme? [18:00:28] yeah [18:00:43] i thought I already made that change... [18:00:44] ugh [18:00:54] TrevorParscal: Grep for @{oo-ui-default-image-path} [18:00:58] TrevorParscal: Three hits. [18:02:28] Also what's up with .icon(); [18:02:39] Minerva's elements.less calls it but it doesn't seem to be defined anywhere [18:02:51] that's just a whole other messy thing they did [18:04:02] so, the popup anchor needs shifting.. [18:05:24] -1.125em on Apex and -1.5em on MediaWiki [18:07:46] and https://gerrit.wikimedia.org/r/#/c/163883 seems to have no effect on this [18:08:01] No but it's needed separately [18:08:07] I can see why in my local VE now [18:08:20] The popups for the edit notice and stuff cause a horizontal scrollbar [18:08:40] Because their parent is positioned where they would be if the anchor was left-aligned, then the popup is relatively positioned from there [18:09:01] So it renders correctly (except for that adjustment) but it takes up space as if it was left-anchored [18:09:34] yeah, I'm trying to figure out how to not need to special case the styling for each theme, that seems crap [18:10:57] i think it's due to the way I ended up doing the triangle stuff [18:11:06] working on an alternate approach [18:12:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Add a Template dialog does not open, when adding a new Basic reference - 10https://bugzilla.wikimedia.org/71417#c9 (10Ritu Swain) Thank you once again :), will keep that in mind. [18:14:50] (03PS1) 10Catrope: Account for categories being removed twice in MWCategoryWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163887 (https://bugzilla.wikimedia.org/71471) [18:15:46] RoanKattouw: I thought Krenair was going to work on that, and you were going to come in? :-P [18:15:56] (Sorry Krenair.) [18:16:17] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them, then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined”. - 10https://bugzilla.wikimedia.org/71471 (10James Forrester) a:5Alex Monk>3Roan Kattouw [18:16:53] Yeah I'll head in now [18:18:05] (03CR) 10Catrope: [C: 032] Handle triple click with surface fragments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163849 (owner: 10Esanders) [18:18:48] Sorry I didn't realize that bug had been assigned to Krenair [18:19:36] (03Merged) 10jenkins-bot: Handle triple click with surface fragments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163849 (owner: 10Esanders) [18:36:45] hey James_F [18:36:51] Hey. [18:37:06] should we send that survey soon or wait until after quarterly review? [18:37:29] Maybe wait? [18:38:35] James_F: ok cool [18:42:01] James_F, RoanKattouw: I had been planning to, but okay. [18:42:11] (I hadn't started work on it. Just finished dinner.) [18:43:11] (03PS1) 10Trevor Parscal: Correct the left positioning of a popup wrapper [oojs/ui] - 10https://gerrit.wikimedia.org/r/163893 [18:43:22] ok, that should do it [18:43:31] a detail that got lost in the theme changes [18:49:57] RoanKattouw_away: https://gerrit.wikimedia.org/r/#/c/163893/ needs to be merged and included in the ve core pull through [18:51:53] (03PS2) 10Catrope: Correct the left positioning of a popup wrapper [oojs/ui] - 10https://gerrit.wikimedia.org/r/163893 (owner: 10Trevor Parscal) [18:52:04] OK [18:52:36] TrevorParscal: So your commit message says something about "a theme-independent way" [18:52:42] but your commit only touches theme-specific files [18:53:05] Is the body of the commit message describing something you would like to happen rather than what you actually did? [18:56:29] well, maybe it reads a little odd [18:56:49] the point is that themes should not move the wrapper, just align things relative to it [18:57:07] so the wrapper can always be set in software to the right place, and all themes will work correctly [18:57:44] Oh OK [18:57:49] (03CR) 10Catrope: [C: 032] Correct the left positioning of a popup wrapper [oojs/ui] - 10https://gerrit.wikimedia.org/r/163893 (owner: 10Trevor Parscal) [18:58:38] I will rebuild the pull-throughs to include that commit once it merges [18:59:00] (03Merged) 10jenkins-bot: Correct the left positioning of a popup wrapper [oojs/ui] - 10https://gerrit.wikimedia.org/r/163893 (owner: 10Trevor Parscal) [18:59:56] thanks man [19:00:02] TrevorParscal: What about pending.gif? [19:00:50] i can put another commit together that moves that to themes [19:01:05] That'd be good. [19:05:44] OK there you go [19:05:50] https://gerrit.wikimedia.org/r/163763 [19:06:01] I gotta go to lunch now [19:10:08] (03PS1) 10Trevor Parscal: Move references to pending.gif to the themes that provide it [oojs/ui] - 10https://gerrit.wikimedia.org/r/163900 [19:16:46] (03CR) 10Jforrester: [C: 032] Move references to pending.gif to the themes that provide it [oojs/ui] - 10https://gerrit.wikimedia.org/r/163900 (owner: 10Trevor Parscal) [19:16:49] TrevorParscal: Nice. Thanks. [19:17:20] been eating while I work... going to go get some fresh air - be back soon [19:17:53] (03Merged) 10jenkins-bot: Move references to pending.gif to the themes that provide it [oojs/ui] - 10https://gerrit.wikimedia.org/r/163900 (owner: 10Trevor Parscal) [19:18:05] TrevorParscal: Kk. [19:24:24] (03PS5) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 [19:25:52] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders) [19:46:00] RoanKattouw_away, TrevorParscal I have a question for you slackers [19:54:10] (03PS6) 10Esanders: [BREAKING CHANGE] The Great Selection Rewrite of 2014 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 [20:15:13] edsanders: sup? [20:20:29] table selections [20:20:47] and how to describe them [20:21:21] my current draft is [tableNode, (row, col)From, (row, col)To ] [20:22:06] which leaves two questions [20:22:12] 1. How do you serialize that [20:22:37] 2. How do you preserve it through transactions (cf. tx.translateRange) [20:26:45] maybe replace tableNode with tableNode.getOuterRange().start ? [20:28:20] is there a special jsDoc way to denote a method that's being overriden ? [20:28:29] Other than saying it in the method description, of course. [20:29:28] as in, purposefully overriding behavior [20:40:44] ping TrevorParscal [20:40:45] mooeypoo: No. [20:41:35] hi [20:43:54] mooeypoo: Can you explain what you want to document exactly? [20:44:02] I feel like I'm abusing OOUI with this code. [20:44:25] RoanKattouw, I'm just overriding a base behavior of the select widget and an event along with it [20:44:46] edsanders: Yeah you'd probably need to store tableNode's start offset anyway, because nodes are ephemeral so onTransact you might have to update / invalidate the node refernce [20:45:01] yes [20:45:18] so, instead of it emitting select (and doing nothing else) on clicking an item, I'm building an info window when it's selected, and I'm not emiting the 'select' until the user actually approves the selection. [20:45:19] but also a transaction might delete your table [20:45:41] Rigtht [20:46:07] mooeypoo: I think you just redefine the documentation in that case. You can use @inheritdoc to inherit the things you don't redefine [20:46:38] edsanders: Yeah, hmm, how do you translate across that, or a row in the middle of your selection getting removed, or split/merge operations [20:46:40] Yeah, I rewrote the documentation, but it's a relatively big behavior change, I thought there might be a way to emphasize it [20:46:43] thanks [20:48:03] re @inheritdoc I'm not sure but Krinkle can correct me if I'm wrong [20:48:19] mooeypoo: what is the use case where you need this? [20:49:39] TrevorParscal, the media search dialog. The images appear in the box -- when the user clicks one, it shouldn't be picked, but rather expand an info box (like Google images, more or less) and then the image can be selected only after the user approves the selection [20:49:44] this is for the new dialog redesign [20:49:49] edsanders: I'm thinking maybe we can store the start offset of the selection, I feel like that might be more stable than row/col coordinates [20:49:56] Because those coords get weird with merged cells [20:50:05] So, it means that the selection is "broken" into 2 parts -- displaying info about the object and only afterwards actually performing "select" [20:50:23] hence overriding the parent [20:51:10] RoanKattouw, we only let the user create bounding rectangles [20:51:10] mooeypoo: are you familiar with the difference between select and choose? [20:51:36] edsanders: Hmm, so here's an idea. A table selection from (r1,c1) to (r2,c2) could theoretically be represented as a selection from (linmod offset of r1c1, linmod offset of r2c2) with gaps that are relatively predictable, is that right? [20:51:40] TrevorParscal, oh. ah! Now that you say it, yes, I remember you have it in the other widgets. [20:51:42] select is a by-product of choose, choose is performed when the user takes action (clicking) [20:51:52] But the user clicks in this case [20:52:02] you really only need to override the choose behavior though [20:52:36] chooseItem selects and then emits choose [20:52:53] TrevorParscal, OO.ui.SearchWidget.prototype.onResultsSelect = function ( item ) [20:53:00] there is no "choose" in that widget? am I missing something? [20:53:07] well... hold up [20:53:13] there's only select, because the user actively clicks the widget result. [20:53:20] so, you really need to just stop closing the dialog on choose [20:53:23] that's more my point [20:53:35] I want to perform another action, too [20:53:54] right, so on choose you can show the infobox thing [20:54:05] edsanders: So only bounding rectangles, what simplifications does that allow? [20:54:09] and then there is another button somewhere (i presume) you want to use for ACTUAL choosing? [20:54:21] this also makes it work correctly with keyboard [20:54:22] yeah [20:54:35] so, don't change the selection model of the widget [20:54:41] well you said the coords get weird with merged cells [20:54:46] just respond to different events [20:54:47] yeah? [20:55:12] hm, but the event of the user clicking the result is "select" event. [20:55:18] mooeypoo: RoanKattouw: @inheritdoc all or nothing. [20:55:30] edsanders: I guess maybe not [20:55:35] mooeypoo: the user clicking will emit both select and choose [20:55:41] you want to behave on choose [20:55:45] TrevorParscal, so, either I emit select but I ignore it in the dialog and then emit "choose" and work on *that* [20:56:01] TrevorParscal, it ... doesn't seem to emit choose though? I'm missing something I think. [20:56:01] Oooh because our coord system double-counts (or triple-counts or whatever) merged cells, so it's fine? [20:56:21] TrevorParscal, in ooui: [20:56:22] OO.ui.SearchWidget.prototype.onResultsSelect = function ( item ) { [20:56:22] this.emit( 'select', item ? item.getData() : null ); [20:56:22] }; [20:56:22] it happens where there's deliberate action taken on an item, unlike highlight or select which are used for hovering/keying through or setting the state programatically [20:56:23] the table model breaks it down into a full grid [20:56:31] Right, yeah [20:56:38] then for a given start/end works out a rectangle that doesn't cut up merged cells [20:56:39] see OO.ui.SelectWidget.prototype.chooseItem [20:56:50] I think it's odd to use a range to define the start/end [20:57:03] OK, yeah, so then maybe we don't need that [20:57:07] So let's see what can happen [20:57:08] ahha [20:57:14] it feels fragile [20:57:16] Rows or columns can be inserted [20:57:31] Then we would potentially have to translate the selection's coords for that [20:57:34] like if with some translations the end offset ends up inside a nested table [20:58:00] I'm thinking to begin with the only translation we do is clipping [20:58:18] Clipping? [20:58:18] and converting to null when the table is deleted [20:58:24] mooeypoo: the trick is that choose is an event only emitted when the user makes a choice [20:58:28] you select all and the table gets smaller [20:58:35] Oh I see [20:58:35] select is emitted when the control is changed (by the user or the software) [20:59:07] So clipping in the graphics processing sense: you fix out-of-bound coords by setting them to the new boundary value [20:59:29] right [20:59:32] That's sensible [20:59:55] TrevorParscal, hmmm. Okay, this makes sense [21:00:05] I think using a (r1,c1),(r2,c2) representation and translating that is sensible [21:00:15] I just hope that translating for column insertions won't be too hard [21:00:22] I don't think it matters so much if you destroy a table selection, mostly because insert/delete row/col is pretty uncommon [21:00:57] We'd also have to define what happens when a cell at the boundary gets split/merged, in theory, but in practice that probably can't arise except in collaboration cases [21:01:24] Right and if we select the inserted row/col after inserting it or just clear the selection, that would be fine too [21:01:31] right [21:01:41] For removing rows/cols, you could assume that the thing being removed was previously selected, so you clear the selection [21:03:10] I think in translateTableSelection we will have to check if any transactions happened inside the tableNode @ tableNodeOffset (fetched from DM tree) [21:03:14] TrevorParscal, \o/ it works! thanks! [21:03:20] RoanKattouw: are you gonna regenerate this? 163759 [21:03:28] mooeypoo: n/p [21:04:23] TrevorParscal: Oh yes I should do that [21:05:15] RoanKattouw, will probably go with tableNodeRange, because we already have translateRange methods, and it may be useful to have the end offset [21:05:31] edsanders: Right. Which is just foreach ( tx ) { intersect( tx.getAffectedRange(), table.getOuterRange() ) not empty } [21:05:41] Yeah tha's sensible [21:08:45] RoanKattouw, https://docs.google.com/document/d/1yBE_086jqPDoG9YMYykSJwurxPifGhRsOCZl7cf6b2o/edit [21:08:55] what happens if you insert a col into the middle of the bottom table [21:08:59] I have a row selected [21:09:31] ah, I did it with a private window [21:09:39] they expand the table selection [21:10:27] Can you merge/split cells in gdocs? [21:10:57] Because, if so, what happens if I split the cell your selection starts in? [21:11:03] I mean I think I know what should happen but still [21:11:10] it appears to have a left bias too [21:11:28] insert left expands the range, but not right [21:12:09] can't see any merge/split tools [21:13:42] you can't even paste one in [21:23:04] 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900#c2 (10Alex Monk) I wonder if we can just do something like this $( newDoc ) .remove( '[id=myEventWatcherDiv]' ) // Bug 51423 .remove( 'object[t... [21:23:04] 3OOjs UI: OOjs UI: Issues with button placement and sizing on first open - 10https://bugzilla.wikimedia.org/70061#c4 (10Bartosz Dziewoński) Are there are particular issues known? Or reproduction instructions? This is "high priority" and completely not actionable :( [21:26:00] 3VisualEditor / 3MediaWiki integration: VisualEditor: Put in hacks to scrub plugin garbage (e.g. myEventWatcherDiv) - 10https://bugzilla.wikimedia.org/68900#c3 (10Roan Kattouw) (In reply to Alex Monk from comment #2) > I wonder if we can just do something like this > > $( newDoc ) > .remove( '[id=myEventWa... [21:26:06] Krenair: Yes let's do that [21:27:01] I guess I'll upload a patch then [21:27:26] Cool [21:29:38] https://bugzilla.wikimedia.org/show_bug.cgi?id=67006 and https://bugzilla.wikimedia.org/show_bug.cgi?id=69513 look harder to deal with, leaving those for now [21:30:14] (first one: eh, we could div[id^=kloutify], but that wouldn't be complete) [21:34:30] Yeah