[00:12:54] Hey everyone, I'm running VE on a client wiki, and I have a bunch of parser hook extensions that output plain HTML. Right now VE seems to show some version of that raw HTML instead of the actual content. Is there some way I can customise the display of a parser hook, or that I can modify that parser hook such that it displays correctly? [00:13:22] See: https://www.dropbox.com/s/yb7tu7jzm3vb7t4/Screenshot%202014-10-03%2010.13.12.png?dl=0 [00:14:23] I guess this is a parsoid question gwicke [00:24:16] werdna: which page & revision is this? [00:25:49] gwicke: it's on a client wiki. In this specific case, we have a "button" parser function that emits a specifically styled button, and similar stuff to that. [00:26:21] I guess it could be wikitextified in this case, but I do want to have parser functions that emit HTML anyway, so I guess I'm asking about how to make that work. [00:27:25] ahh, now I notice that it's an a tag [00:27:49] 'a' tags aren't normally allowed in wikitext, so are escaped [00:27:52] in the sanitizer [00:27:59] I found ext.core.ExtensionHandler.js which seemed relevant [00:28:18] right, buut my extension declares its output as HTML, not WikiText [00:28:22] so it should handle it as HTML. [00:28:56] I'm not sure that this information is exposed in expandtemplates [00:29:15] if it is, then it'd be very new [00:32:24] huh, this is weird output http://wiki.cancer.org.au/australiawiki_test/api.php?action=expandtemplates&text=%7B%7B#button:Foo%7CBar%7D%7D&prop=wikitext%7Cparsetree [00:32:37] I give it a prop argument and it tells me I didn't provide one, and then the expansion is quite strange [00:35:21] gwicke: hmm, for now, could you tell me where this part is handled and I could try to work around it (for example, with a list of whitelisted extensions that return HTML) [00:37:14] werdna: tag extensions with HTML output should work fine [00:37:41] parser function extension is handled in action=expandtemplates [00:38:00] finally, sanitization is handled in Parsoid sanitizer [00:38:10] look for sanitizer in lib/ [00:39:05] hmm, so what are the differing code paths for tag extensions and parser functions? It looked to me like parser functions come out of ext.core.TemplateHandler.js and tags come out of ext.core.ExtensionHandler.js [00:40:23] hmm, looks relevant * Tokens from extensions which should not be sanitized can bypass sanitation by setting their rank to 3. [00:51:41] hmm, after staring at this for a while, I might as well just make my parser functions return tags, and add tag extensions [01:05:28] werdna: that should indeed work [01:06:17] there is a bug on expandtemplates integration & some work on that [01:08:46] werdna: https://bugzilla.wikimedia.org/show_bug.cgi?id=71490 [01:09:36] it looks like the content being html is not exposed currently [01:23:21] gwicke: hmph, looks like returning a tag from the parser extension makes the *tag* appear raw in the Parsoid output [01:23:23] which, I guess, is better. [01:28:12] werdna: if the tag is registered as an extension, then it should normally be expanded [01:28:22] I think I found the issue [01:28:28] I wasn't setting the close tag correctly [01:28:30] does it work if you place the tag into the normal page content? [01:28:35] ahh [01:29:52] werdna: I added the need to expose 'isHTML' info from expandtemplates to the bug [01:29:59] ah excellent [01:30:20] nope, still displaying as tags [01:30:34] did you restart parsoid? [01:30:43] nope [01:30:45] it loads the list of registered extension tags once on startup [01:31:06] first request per wiki, to be precise [01:31:20] still doesn't work [01:31:38] hmm [01:31:43] my parser functions are returning $parser->extensionSubstitution() like #tag does [01:31:47] does it work in normal content? [01:31:59] ? [01:32:19] that was going to be my next test [01:33:16] nope, it does not [01:33:21] if your tag is already expanded in the parser function output, then parsoid won't know about it [01:33:26] it'll just see a bunch of html [01:33:39] I tried both #tag:button and [01:34:35] ? [01:34:41] or are you only inserting [01:34:46] but yeah [01:34:59] hmmz [01:35:03] weird [01:35:09] let me try other tags [01:35:13] is this publicly available? [01:35:14] what's a tag that uses the same functionality? [01:35:46] a tag extension? [01:35:51] yeah [01:35:59] any of them I'd think [01:36:00] it mentions nowiki, pre on my Special:Version [01:36:03] but that doesn't sound right [01:36:09] I know ref and references have special handling [01:36:23] InputBox, I guess [01:36:26] as good as any [01:36:30] yup [01:36:34] or hiero [01:36:40] math [01:37:13] gah! InputBox works! [01:38:37] if you can't get it to work, could you open a bug against parsoid describing what your extension is doing differently? [01:38:52] yeah, I'll have to figure out what that is first [01:38:56] I gotta run [01:39:01] thanks! [01:39:07] just quickly: is there a way I can check if that tag extension is known to parsoid? [01:39:30] werdna: you could dump the list in environment [01:39:39] that's where it [01:39:41] 's set up [01:40:09] lib/environment? [01:40:47] mediawiki.parser.environment.js [01:41:02] really got to run, good luck! [01:41:35] seeya [01:41:40] thanks for your help so far [02:30:17] (03PS1) 10Mattflaschen: In first-time dialog, explain how to switch to source without lost work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164503 [03:24:47] (03PS2) 10Mooeypoo: [WIP] Transform the search widget into masonry fit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 [03:26:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Transform the search widget into masonry fit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo) [05:48:14] (03PS15) 10Catrope: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [05:49:02] (03PS1) 10Catrope: Followup 2fcc4c0: fix bugs with selection-only polling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164514 [05:49:28] (03PS16) 10Catrope: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [05:49:57] (03PS1) 10Catrope: Get rid of trigger-happy slugChange event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 [05:50:14] (03PS1) 10Catrope: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 [05:51:17] (03CR) 10jenkins-bot: [V: 04-1] Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [05:51:27] (03CR) 10jenkins-bot: [V: 04-1] Followup 2fcc4c0: fix bugs with selection-only polling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164514 (owner: 10Catrope) [05:51:31] (03PS3) 10Catrope: [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [05:53:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [05:55:37] (03CR) 10jenkins-bot: [V: 04-1] Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 (owner: 10Catrope) [05:56:09] (03CR) 10jenkins-bot: [V: 04-1] Get rid of trigger-happy slugChange event. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 (owner: 10Catrope) [12:06:33] 3OOjs UI: OOjs UI: Scrolling elements into view does not work in most cases - 10https://bugzilla.wikimedia.org/71609 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3major a:3None Scrolling elements into view does not work in most cases; in fact it seems to depend on some Blink-specific behaviors and thus only... [12:06:46] 3OOjs UI: OOjs UI: Scrolling elements into view does not work in most cases - 10https://bugzilla.wikimedia.org/71609 (10Bartosz Dziewoński) [12:06:46] 3VisualEditor / 3ContentEditable: VisualEditor: Left-aligning a large image causes horizontal scrolling past the context menu on Chrome - 10https://bugzilla.wikimedia.org/71540 (10Bartosz Dziewoński) [12:08:00] 3VisualEditor / 3ContentEditable: VisualEditor: Left-aligning a large image causes horizontal scrolling past the context menu on Chrome - 10https://bugzilla.wikimedia.org/71540#c8 (10Bartosz Dziewoński) 5NEW>3ASSI I filed bug 71609 in OOjs UI about scrolling into view not working. [13:04:46] (03PS5) 10Bartosz Dziewoński: ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) [13:09:33] (03PS6) 10Bartosz Dziewoński: ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) [13:11:32] (03PS7) 10Bartosz Dziewoński: ve.ui.CommentInspector: Update size when the textarea gets resized [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) [13:12:29] (03CR) 10Bartosz Dziewoński: "Fixed now. Sorry for delayed response." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163674 (https://bugzilla.wikimedia.org/71427) (owner: 10Bartosz Dziewoński) [13:15:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 2] Deleting any focusable node throws "error:NS_ERROR_FAILURE:" in Firefox and wrong context menu starts appearing for other nodes - 10https://bugzilla.wikimedia.org/71580#c1 (10Bartosz Dziewoński) Reproducible in standalone with comment nodes too. [13:25:44] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 2] Deleting any focusable node throws "error:NS_ERROR_FAILURE:" in Firefox and wrong context menu starts appearing for other nodes - 10https://bugzilla.wikimedia.org/71580#c2 (10Bartosz Dziewoński) Caused by 0d7eaf51767c4061b478610a035a3bc387c0973... [13:26:32] (03PS1) 10Bartosz Dziewoński: Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164548 (https://bugzilla.wikimedia.org/71580) [13:28:15] 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724#c8 (10Bartosz Dziewoński) 5RESO/FIX>3REOP Workaround reverted, caused bug 71580 (ugly-looking "NS_ERROR_FAILURE" exceptions in some cases). [14:35:47] 3VisualEditor: VisualEditor: Add an option to Paste as plain text - 10https://bugzilla.wikimedia.org/71612 (10Elitre) 3NEW p:3Unprio s:3enhanc a:3None This suggestion comes from Gebruiker:Stratoprutser at nl.wp. [15:17:22] 3OOjs UI: OOjs UI: ClippableElement does not work in certain cases - 10https://bugzilla.wikimedia.org/67444 (10Bartosz Dziewoński) 5ASSI>3UNCO [15:17:22] 3OOjs UI: OOjs UI: Issues with button placement and sizing on first open - 10https://bugzilla.wikimedia.org/70061 (10Bartosz Dziewoński) 5ASSI>3UNCO [16:21:17] Ah, here is everyone again! [16:22:36] Yeah. Boo to ZNC crashing. :-( [16:26:43] hi all! [16:27:07] hi [16:29:30] Guest24746, hi [16:30:30] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107931353 [16:30:30] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=107936819 [16:30:30] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=65933530 [16:30:30] Corruption alert: visualeditor-needcheck on nlwiki: https://nl.wikipedia.org/?diff=42201306 [16:30:30] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40198317 [16:40:15] 3VisualEditor: VisualEditor: Add an option to Paste as plain text - 10https://bugzilla.wikimedia.org/71612#c1 (10James Forrester) This is already available via the standard shortcut (Ctrl/Cmd+Shift+V), and it's listed in the dialog of all keyboard shortcuts. Is this asking for a button to do this as well? [16:41:28] James_F: VE retains some formatting (even links and more if you copy/paste from another VE instance) when you paste. The user asks it doesn't. [16:43:39] Elitre: Not if you press Ctrl+Shift+V. [16:50:21] James_F: users not noticing/remembering keyboard shortcuts seems to be a wide issue ;) [16:50:22] Elitre: Is that what they wanted? [16:50:35] Elitre: So they want something in the toolbar for this? [16:50:50] we'll see what he says. he might be happy with the shortcut. [16:50:54] OK. [16:52:15] (03CR) 10Jforrester: In first-time dialog, explain how to switch to source without lost work (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164503 (owner: 10Mattflaschen) [16:57:04] (03PS2) 10Jforrester: In first-time dialog, explain how to switch to source without lost work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164503 (owner: 10Mattflaschen) [16:57:39] (03CR) 10Jforrester: [C: 031] In first-time dialog, explain how to switch to source without lost work [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164503 (owner: 10Mattflaschen) [16:57:58] James_F: hey, is there a design/mockup for https://bugzilla.wikimedia.org/show_bug.cgi?id=70568 ? "OOjs UI: Toolbar menus should be collapsible" [17:37:22] MatmaRex: Hey, yes. [17:37:24] MatmaRex: It was in https://commons.wikimedia.org/w/index.php?title=File%3AEditing_Team_-_2014%E2%80%9315_Q1_quarterly_review.pdf&page=19 [17:37:26] MatmaRex: The "More v" bit. Also, having a way to put an
in menus to separate sub-groups would be awesome too. Not sure if there's a bug for that, though. [17:37:54] MatmaRex: Does that make sense? [17:38:27] James_F: ha, yeah. i was just playing with it and arrived at this currently: https://dl.dropboxusercontent.com/u/10983006/tmp/2014-10-03%2019_37_40-OOjs%20UI%20Demos%20-%20Opera.png [17:39:29] MatmaRex: Ooh. I think the idea is to have an explicit point where it grows, rather than being automatic based on space. [17:39:33] MatmaRex: But nice. :-) [17:40:04] (03PS1) 10Bartosz Dziewoński: [WIP] ListToolGroup: Collapsible/expandable tools [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) [17:40:25] James_F: yes, the little arrow thingy is clickable ^ [17:40:30] * James_F nods. [17:40:42] How does it pick where to show the arrow? [17:40:48] at the end? [17:41:06] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ListToolGroup: Collapsible/expandable tools [oojs/ui] - 10https://gerrit.wikimedia.org/r/164590 (https://bugzilla.wikimedia.org/70568) (owner: 10Bartosz Dziewoński) [17:41:14] How does it pick after which item to show the arrow? :-P [17:41:21] the arrow just appears at the very bottom of the list, always [17:41:26] * James_F sighs. [17:41:35] (regardless of the position of the hideable tools) [17:41:35] How does it know how many items to show before the arrow? [17:41:40] D: [17:41:41] ah [17:41:52] you define which tools are hideable (collapsible) [17:42:02] inside a tool group [17:42:02] Ooooh. [17:42:03] Hmm. [17:42:22] Normally we use a pattern of promoting (selecting the important ones) rather than demoting. [17:42:24] * James_F isn't sure. [17:42:25] i assumed this would be used for "advanced" tools [17:42:51] and yeah, i followed that promote/demote pattern a bit [17:43:12] could be switched around easily, to define which ones are *not* hideable [17:43:13] It'd probably be used for everything that isn't ultra-priority. [17:43:15] Yeah. [17:43:39] E.g. for styling, we might only make bold and italic "important", and the rest are collapsed by default. [17:43:45] anyway, the code needs some more love, i hacked up some thing that i couldn't get to work sanely; but it works and i like it ;) [17:43:53] some things* [17:44:06] * James_F nods. [17:44:09] Nice work. :-) [17:44:30] * James_F will have to create a bunch of OOUI bugs for you. :-) [17:45:32] hah [17:45:35] 3OOjs UI: OOjs UI: Toolbar menus should be collapsible - 10https://bugzilla.wikimedia.org/70568#c2 (10Bartosz Dziewoński) https://commons.wikimedia.org/w/index.php?title=File%3AEditing_Team_-_2014%E2%80%9315_Q1_quarterly_review.pdf&page=19 [17:46:17] 3OOjs UI: OOjs UI: Trying to close a window before it's ready causes a JS error - 10https://bugzilla.wikimedia.org/69918 (10James Forrester) a:3Bartosz Dziewoński [17:46:19] 3OOjs UI: OOjs UI: Dialogs should be repositionable/draggable - 10https://bugzilla.wikimedia.org/49969 (10James Forrester) p:5Low>3Normal a:3Bartosz Dziewoński [17:46:46] 3OOjs UI: OOjs UI: InlineMenuWidget should behave as a menu widget - 10https://bugzilla.wikimedia.org/70968 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Bartosz Dziewoński [17:48:02] 3OOjs UI: OOjs UI: Toolbar menus should use sub-groups with a separator (
?) between them for splitting up longer lists - 10https://bugzilla.wikimedia.org/71616 (10James Forrester) 3NEW p:3Unprio s:3enhanc a:3Bartosz Dziewoński See e.g. in the mock-up in https://commons.wikimedia.org/w/index.php?tit... [17:48:05] James_F: by the way, i marked a few bugs i couldn't reproduce / understand as UNCONFIRMED today; do we have a "process" for that? [17:48:15] 3OOjs UI: OOjs UI: Toolbar menus should use sub-groups with a separator (
?) between them for splitting up longer lists - 10https://bugzilla.wikimedia.org/71616 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [17:48:28] MatmaRex: Generally I'll get to them and mark them as FIXED, WORKSFORME, or INVALID/WONTFIX as appropriate. [17:48:30] (that = WONTFIXing bugs, in general) [17:48:35] okay [17:48:47] MatmaRex: I do it so you lot can focus on actual work, i.e. coding. :-) [17:49:10] i enjoy taking breaks from coding to do some bug management ;) [17:49:18] 3OOjs UI: OOjs UI: Toolbar menus should be collapsible - 10https://bugzilla.wikimedia.org/70568 (10James Forrester) a:3Bartosz Dziewoński [17:49:46] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.3 and 7.0.5 - 10https://bugzilla.wikimedia.org/64388 (10James Forrester) p:5Low>3Normal a:3Bartosz Dziewoński [17:49:51] MatmaRex: That's allowed. :-) [17:49:59] :D [17:50:02] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.3 and 7.0.5 when zoomed in - 10https://bugzilla.wikimedia.org/64388 (10James Forrester) [17:50:07] James_F: quick question about that design - should the expandable tools appear above or below the "More" tool? [17:50:42] MatmaRex: Generally if I've not looked at a bug yet it might be an idea to let it be (or ping me here) rather than work on it, just in case I come along and WONTFIX (or more normally, re-direct) it. [17:51:11] MatmaRex: You mean, when you click "more" (and it turns into "fewer"), should the new items appear above the "fewer" marker? Yes. [17:52:00] 3OOjs UI: OOjs UI: Scrolling elements into view does not work in most cases - 10https://bugzilla.wikimedia.org/71609 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High [17:52:11] (03CR) 10Jforrester: [C: 032] Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164548 (https://bugzilla.wikimedia.org/71580) (owner: 10Bartosz Dziewoński) [17:52:31] hmm. i'll need to think about it. it feels weird to make the marker look exactly the same as the tools in the list [17:53:15] (03PS1) 10Jforrester: Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring" [VisualEditor/VisualEditor] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164593 (https://bugzilla.wikimedia.org/71580) [17:53:29] Yeah, feel free to style it a bit differently. [17:53:41] (03CR) 10Jforrester: [C: 032] Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring" [VisualEditor/VisualEditor] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164593 (https://bugzilla.wikimedia.org/71580) (owner: 10Jforrester) [17:53:50] (03Merged) 10jenkins-bot: Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164548 (https://bugzilla.wikimedia.org/71580) (owner: 10Bartosz Dziewoński) [17:55:16] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf 2] Deleting any focusable node throws "error:NS_ERROR_FAILURE:" in Firefox and wrong context menu starts appearing for other nodes - 10https://bugzilla.wikimedia.org/71580 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Highes s:5normal>... [17:55:23] (03Merged) 10jenkins-bot: Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring" [VisualEditor/VisualEditor] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164593 (https://bugzilla.wikimedia.org/71580) (owner: 10Jforrester) [17:55:46] 3VisualEditor / 3ContentEditable: VisualEditor: Safari scrolls one line for every character typed - 10https://bugzilla.wikimedia.org/71561 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3major [17:56:14] 3VisualEditor: VisualEditor: Add an option to Paste as plain text - 10https://bugzilla.wikimedia.org/71612#c2 (10Stratoprutser) Ah! In Firefox ctrl shift v opens Ad blocks' blockable items dialog, but disabling adblocker indeed pastes unformated. Not sure if it needs a button or an entry under "Insert", but i... [17:57:15] 3VisualEditor / 3Mobile: VisualEditor Mobile: Backspace issue on Windows 8.1 phone(?) - 10https://bugzilla.wikimedia.org/71119#c2 (10James Forrester) 5UNCO>3ASSI p:5Unprio>3Low Marking as "Low" priority until more details are provided. [17:57:30] 3VisualEditor: VisualEditor: Cutting (removing) last sections on page, and then pasting them back in, results in increased indentation in Chrome - 10https://bugzilla.wikimedia.org/59849#c4 (10WhatamIdoing) I don't understand why editors aren't allowed free use of indenting, either. But "free use of indentin... [18:00:02] 3VisualEditor / 3ContentEditable: VisualEditor: Overlay doesn't close, elements aren't clickable when copying dir="auto" values - 10https://bugzilla.wikimedia.org/70831#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3High a:3Roan Kattouw Fixed as part of the fixes for 70731. [18:04:30] 3VisualEditor / 3Editing Tools: Template editor freezes when trying to re-edit a template - 10https://bugzilla.wikimedia.org/69769#c1 (10James Forrester) 5UNCO>3RESO/WOR I can't replicate this using Chrome on Mac or Linux using the English Wikipedia template {{Main}} (which I'm guessing is what you were... [18:05:46] 3VisualEditor / 3ContentEditable: VisualEditor: Up/down arrow in Firefox broken after using left/right - 10https://bugzilla.wikimedia.org/70724#c9 (10James Forrester) 5REOP>3ASSI p:5High>3Normal a:5Bartosz Dziewoński>3None Possibly not anything we can actually fix… [18:06:24] (03PS4) 10Ori.livneh: [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [18:07:00] 3OOjs UI: OOjs UI: Issues with button placement and sizing on first open - 10https://bugzilla.wikimedia.org/70061#c5 (10James Forrester) 5UNCO>3ASSI p:5High>3Low Bumping down priority until Roan gives reproductions steps. [18:08:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP] PHP Implementation of OOjs UI [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [18:12:01] 3OOjs UI: OOjs UI: ClippableElement does not work in certain cases - 10https://bugzilla.wikimedia.org/67444#c3 (10James Forrester) 5UNCO>3ASSI p:5High>3Low a:5Trevor Parscal>3None Bumping down priority until Roan gives reproductions steps. [18:13:59] 3VisualEditor / 3Data Model: VisualEditor: Getting "Error: Inserted data is trying to close the root node (at index 0)" while trying to go the next line after inserting a Hiero in Firefox - 10https://bugzilla.wikimedia.org/66691#c4 (10James Forrester) 5REOP>3RESO/FIX Looks like it is now. [18:14:31] 3OOjs UI: OOjs UI: Issues with button placement and sizing on first open - 10https://bugzilla.wikimedia.org/70061 (10James Forrester) a:5Roan Kattouw>3None [18:28:58] RoanKattouw: do you know how specCache is defined ve.dm.MWTransclusionModel? [18:29:15] so it is shared among all instances of that class [18:30:45] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - 10https://bugzilla.wikimedia.org/51154#c20 (10Pine) p:5Lowest>3High I am raising the priority of this bug. VisualEditor is now enabled for talk pages on Meta, yet I can't insert my signatu... [18:34:45] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf 22] Selection does not work while trying to select multiples lines after dragging the selection horizontally over a focusable node - 10https://bugzilla.wikimedia.org/71139#c3 (10Rummana Yasmeen) Verified the fix in test2 [18:38:01] (03PS15) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [18:38:03] (03PS18) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [18:38:05] (03PS19) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [18:38:07] (03PS20) 10Esanders: Actions and toolbar for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [18:38:09] (03PS1) 10Esanders: WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 [18:38:29] Something for you to play with James_F ^^ [18:39:25] (03CR) 10jenkins-bot: [V: 04-1] WIP non-native table handling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164616 (owner: 10Esanders) [18:40:30] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [18:43:32] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - 10https://bugzilla.wikimedia.org/51154#c21 (10James Forrester) p:5High>3Lowest (In reply to Pine from comment #20) > I am raising the priority of this bug. VisualEditor is now enabled for... [18:46:00] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - 10https://bugzilla.wikimedia.org/51154#c22 (10Pine) Perhaps someone enabled VE on talk pages when they shouldn't have? It's enabled on https://meta.wikimedia.org/wiki/Grants:APG/Comments [18:47:15] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - 10https://bugzilla.wikimedia.org/51154#c23 (10Pine) Ah, I see. That's not really labeled as a talk page on Meta, but it probably should be. I'll try to take care of that. [18:47:30] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - 10https://bugzilla.wikimedia.org/51154#c24 (10James Forrester) (In reply to Pine from comment #22) > Perhaps someone enabled VE on talk pages when they shouldn't have? > > It's enabled on htt... [18:48:15] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Adding categories, removing them, then cancelling the dialog throws “Uncaught TypeError: Cannot read property 'disconnect' of undefined” - 10https://bugzilla.wikimedia.org/71471#c6 (10Rummana Yasmeen) Verified the fix in test2 [18:49:07] (03PS1) 10Jforrester: Update VE core submodule to master (a1c190c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164620 [18:49:51] 3VisualEditor / 3Editing Tools: VisualEditor: Provide a tool to insert a talk signature in namespaces that need it - 10https://bugzilla.wikimedia.org/51154#c25 (10Pine) Yes, I've moved it to talk space. Sorry I didn't catch that earlier. [18:53:33] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.25wmf2 master (25f5787) [extensions/VisualEditor] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164623 [18:57:29] 3VisualEditor: VisualEditor: Add an option to Paste as plain text - 10https://bugzilla.wikimedia.org/71612#c3 (10James Forrester) (In reply to Stratoprutser from comment #2) > Ah! In Firefox ctrl shift v opens Ad blocks' blockable items dialog, but > disabling adblocker indeed pastes unformated. > > Not sure... [19:01:18] 3VisualEditor / 3ContentEditable: VisualEditor: Safari scrolls one line for every character typed - 10https://bugzilla.wikimedia.org/71561#c1 (10WhatamIdoing) Update: An editing session may start normally and have this problem appear later, so perhaps I just didn't spend enough time in Firefox to trigger i... [19:05:43] (03PS4) 10Catrope: [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [19:07:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [19:07:16] 3VisualEditor: VisualEditor: Add an option to Paste as plain text - 10https://bugzilla.wikimedia.org/71612#c4 (10Stratoprutser) ok my bad, thanks for the follow-up, closing [19:07:26] (03PS47) 10Catrope: POC DONTMERGE: Unicorn [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/125937 (owner: 10Divec) [19:08:25] (03PS5) 10Catrope: [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 [19:10:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use a single unicorn instead of  in inline slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [19:26:41] (03CR) 10Catrope: [C: 032] Make buttons respond to :active events [oojs/ui] - 10https://gerrit.wikimedia.org/r/164474 (owner: 10Trevor Parscal) [19:30:03] (03CR) 10Catrope: [C: 04-1] Move window overlay up to be a sibling of the frame (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/164361 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk) [19:37:28] RoanKattouw, it's in setManager [19:39:16] 3VisualEditor / 3Editing Tools: VisualEditor: Make it easier to see that there is an option to paste as plain text - 10https://bugzilla.wikimedia.org/71612#c5 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal (In reply to Stratoprutser from comment #4) > ok my bad, thanks for the follow-up, closing I... [19:39:22] but yeah, it makes much more sense to put it in the constructor [19:39:35] Sorry setManager [19:40:12] Sorry about that, I was up for 27 hours then slept for 4 and just woke up again [19:40:18] So I might not be 100% coherent :) [19:45:09] (03PS7) 10Alex Monk: ComboBoxWidget: Append menu to $overlay option [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) [19:45:11] (03PS3) 10Alex Monk: Move window overlay up to be a sibling of the frame [oojs/ui] - 10https://gerrit.wikimedia.org/r/164361 (https://bugzilla.wikimedia.org/71178) [19:45:47] RoanKattouw: You're never coherent. :-) [19:47:47] 3VisualEditor: VisualEditor: Wikilinks with a final space - 10https://bugzilla.wikimedia.org/71620 (10Elitre) 3NEW p:3Unprio s:3normal a:3None This bug has been observed for a while on fr.wp and thus unofficially reported time ago, but now User:Drongou has kindly provided instructions to replicate it,... [19:48:03] (03PS8) 10Alex Monk: ComboBoxWidget: Append menu to $overlay option [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) [19:53:00] 3VisualEditor / 3Data Model: VisualEditor: Strip annotations (e.g. bold, italics, link) from terminal whitespace - 10https://bugzilla.wikimedia.org/52037 (10James Forrester) [19:53:32] 3VisualEditor: VisualEditor: Wikilinks with a final space - 10https://bugzilla.wikimedia.org/71620#c1 (10James Forrester) 5NEW>3RESO/DUP This is already covered in bug 52037 – it's really messy, yeah. *** This bug has been marked as a duplicate of bug 52037 *** [19:53:32] 3VisualEditor / 3Data Model: VisualEditor: Strip annotations (e.g. bold, italics, link) from terminal whitespace - 10https://bugzilla.wikimedia.org/52037#c4 (10James Forrester) *** Bug 71620 has been marked as a duplicate of this bug. *** [19:58:27] RoanKattouw: Could I grab +2 on https://gerrit.wikimedia.org/r/#/c/164620/ and https://gerrit.wikimedia.org/r/#/c/164623/ please? [19:59:55] (03CR) 10Catrope: [C: 04-1] Move window overlay up to be a sibling of the frame (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/164361 (https://bugzilla.wikimedia.org/71178) (owner: 10Alex Monk) [20:02:02] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (a1c190c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164620 (owner: 10Jforrester) [20:02:09] Thanks. [20:02:25] (03CR) 10Catrope: [C: 032 V: 032] Update VE core submodule to wmf/1.25wmf2 master (25f5787) [extensions/VisualEditor] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/164623 (owner: 10Jforrester) [20:02:34] 3OOjs UI: OOjs UI: Menus appearing behind page content in Safari 6.1.3 and 7.0.5 when zoomed in - 10https://bugzilla.wikimedia.org/64388#c28 (10Bartosz Dziewoński) a:5Bartosz Dziewoński>3None I'd love to help but I don't own a Mac. :( [20:10:49] MatmaRex: BrowserStack.com is your friend… :-) But OK. [20:11:53] James_F: well sure, i could probably do it after spending enough effort on the set up [20:12:03] if you want me to… [20:12:05] in other news [20:12:10] VE mobile doesn't load on IE11 [20:12:25] MatmaRex: Given your expertise on browser-specific issues like Opera, I thought it might be a good fit. [20:12:29] unknown dependency "ext.visualEditor.iehacks" [20:12:41] (that's in prod, on pl.wp) [20:13:02] Well, yeah, the iehacks are desktop-focussed. [20:13:18] I guess we could add them to the mobile target too, but… [20:14:06] i have no opinion on whether they're needed, but right now the entire editor is not loading at all [20:15:22] * MatmaRex files a bug [20:16:05] (03PS4) 10Alex Monk: Move window overlay up to be a sibling of the frame [oojs/ui] - 10https://gerrit.wikimedia.org/r/164361 (https://bugzilla.wikimedia.org/71178) [20:17:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: Does not load at all on IE 11 (unknown dependency "ext.visualEditor.iehacks") - 10https://bugzilla.wikimedia.org/71622 (10Bartosz Dziewoński) 3NEW p:3Unprio s:3major a:3None VisualEditor Mobile does not load at all on IE 11 right now (unknown dependency "... [20:19:03] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] Link inspector does not close when clicking out into non-linked text - 10https://bugzilla.wikimedia.org/71373#c9 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in test2 and production [20:19:03] 3VisualEditor / 3Mobile: VisualEditor Mobile: Does not load at all on IE 11 (unknown dependency "ext.visualEditor.iehacks") - 10https://bugzilla.wikimedia.org/71622 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5major>3normal [20:20:26] (03PS9) 10Alex Monk: ComboBoxWidget: Append menu to $overlay option [oojs/ui] - 10https://gerrit.wikimedia.org/r/163300 (https://bugzilla.wikimedia.org/71178) [20:20:28] Oh, hah [20:20:51] MatmaRex: My fault. Just add 'target' => array( 'desktop', 'mobile' ) to the definition of that module [20:21:23] i know, James_F implied we might not want to do that [20:21:28] but we actually do [20:21:44] most of the issues affect mobile too, like the highlights opacity thing [20:21:55] i just tested. :D [20:22:55] (03PS1) 10Bartosz Dziewoński: Add mobile target to 'ext.visualEditor.iehacks' module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164649 (https://bugzilla.wikimedia.org/71622) [20:23:18] MatmaRex: No, it's just not crisis-urgent. :-) [20:23:38] MatmaRex: Desktop users of IE11 hitting the mobile site aren't a common issue. [20:23:41] indeed [20:23:53] (03CR) 10Jforrester: [C: 032] Add mobile target to 'ext.visualEditor.iehacks' module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164649 (https://bugzilla.wikimedia.org/71622) (owner: 10Bartosz Dziewoński) [20:24:15] 3VisualEditor / 3Data Model: VisualEditor: Strip annotations (e.g. bold, italics, link) from terminal whitespace - 10https://bugzilla.wikimedia.org/52037#c5 (10WhatamIdoing) Bug 71620 has instructions on how to replicate this for wikilinks. [20:25:32] 3VisualEditor / 3Mobile: VisualEditor Mobile: Does not load at all on IE 11 (unknown dependency "ext.visualEditor.iehacks") - 10https://bugzilla.wikimedia.org/71622 (10James Forrester) a:3Bartosz Dziewoński [20:26:01] 3VisualEditor / 3Editing Tools: VisualEditor: Link inspector UI gets broken if the link target suggestion dropdown overlaps with the border of the page - 10https://bugzilla.wikimedia.org/71371#c2 (10Rummana Yasmeen) Verified the fix in test2 [20:36:52] RoanKattouw: Are you going to write a commit summary for https://gerrit.wikimedia.org/r/#/c/125937/ that doesn't scream "don't merge me" if you really want Ed to merge it today? ;-) [20:41:35] Oh that's not quite done yet, I found a bug [20:41:46] Ah. Boo. [20:41:53] But I would like my stage slugs-related work looked at [20:42:00] That's independent of the unicorn stuff [20:42:28] Well, I mean unicorns need it to function properly but it itself does not depend on unicorns or anything, it's a drop-in replacement for our existing slugging approach [20:42:48] * James_F nods. [20:43:44] Hopefully with a day of fully-rested Roan poking at it (Monday) the two unicorn patches will be in much better shape [20:50:25] Will they be one patch? [20:50:37] Also, take advantage of being in the same timezone as divec. :-) [20:52:17] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing "Backspace" causes the page to abruptly scroll up on IE 11 - 10https://bugzilla.wikimedia.org/71119#c3 (10Bartosz Dziewoński) Testing VE (both mobile and desktop) on a tablet (not phone) with both Windows 7 and 8.1, backspacing (both using software or... [20:53:36] They will probably remain separate patches [20:54:07] The unicorn patch works by itself, it just doesn't fully accomplish the goals of the change, the second patch completes that [20:54:23] And I'm loath to squash even more things into such a big change [20:55:16] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing "Backspace" causes the page to abruptly scroll up on IE 11 - 10https://bugzilla.wikimedia.org/71119#c4 (10James Forrester) p:5Low>3High Added possibly-related bug 71561? [20:55:30] 3VisualEditor / 3ContentEditable: VisualEditor: Safari scrolls one line for every character typed - 10https://bugzilla.wikimedia.org/71561 (10James Forrester) [20:57:16] (03PS2) 10Jforrester: Followup 2fcc4c0: fix bugs with selection-only polling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164514 (owner: 10Catrope) [20:59:00] 3VisualEditor / 3ContentEditable: VisualEditor: Pressing "Backspace" causes the page to abruptly scroll up on IE 11 - 10https://bugzilla.wikimedia.org/71119#c5 (10Bartosz Dziewoński) For me it scrolled abruptly almost to the top of the page (but not quite) and stayed there when I continued backspacing. I was... [21:00:48] (03PS17) 10Jforrester: Stage slugs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/135131 (https://bugzilla.wikimedia.org/65052) (owner: 10Esanders) [21:00:59] (03PS2) 10Jforrester: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 (owner: 10Catrope) [21:01:03] (03PS3) 10Jforrester: Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 (owner: 10Catrope) [21:01:17] (03PS2) 10Jforrester: Make slug animations work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164516 (owner: 10Catrope) [21:02:29] (03CR) 10jenkins-bot: [V: 04-1] Get rid of trigger-happy slugChange event [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/164515 (owner: 10Catrope) [21:02:37] (03CR) 10Jforrester: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163850 (owner: 10Esanders) [21:05:49] 3VisualEditor / 3Editing Tools: highlights on reflist is incorrect - 10https://bugzilla.wikimedia.org/71625 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16664 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16664&action=edit highlight extends outside object wh... [21:07:15] 3VisualEditor / 3Editing Tools: highlights on reflist is incorrect - 10https://bugzilla.wikimedia.org/71625#c1 (10Bartosz Dziewoński) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 50036 *** [21:07:30] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036#c10 (10Bartosz Dziewoński) *** Bug 71625 has been marked as a duplicate of this bug. *** [21:07:45] 3VisualEditor / 3ContentEditable: VisualEditor: Focus highlights for elements using CSS column-count are too tall in Chrome - 10https://bugzilla.wikimedia.org/50036 (10Bartosz Dziewoński) [21:09:50] 3VisualEditor / 3Data Model: VisualEditor: [Regression] When an image is the first item of the document , trying to delete it right after opening VE throws "Error: offset was inside a handlesOwnChildren node" - 10https://bugzilla.wikimedia.org/71187#c5 (10Rummana Yasmeen) Verified the fix in test2 [21:10:02] 3VisualEditor / 3Editing Tools: allow in-line editing/suggesting/flagging of template labels which are unclear - 10https://bugzilla.wikimedia.org/71626 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Created attachment 16665 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16665&acti... [21:20:51] TrevorParscal, you around? [21:21:46] hi [21:21:51] i'm finally out of meetings [21:21:52] !!! [21:21:54] omg [21:25:02] yay! [21:25:12] and now I jump on you, how inconsiderate of me [21:25:13] :D [21:25:38] you want a bit of time to relax in between ? I'm around. And it shouldn't take long, I don't think [21:28:48] mooeypoo: If you need to wait, entertain yourself with pictures of the water fun that broke out in front of the office [21:28:52] (I leave for ONE DAY and this happens) [21:29:04] i'm gonna eat [21:29:06] then we will talk [21:30:58] What water fun [21:31:17] oh! [21:31:18] haha [21:41:45] 3VisualEditor / 3Data Model: VisualEditor: [Regression] When an image is the only item of the document , trying to delete it right after opening VE throws "Error: offset was inside a handlesOwnChildren node" - 10https://bugzilla.wikimedia.org/71187 (10Ed Sanders) [21:50:00] mooeypoo: howdy [21:50:04] you good to talk now? [21:50:08] aye aye [21:50:41] can we hangout-chat quickly? [21:50:44] or do you prefer here [21:53:28] RoanKattouw, btw, that water fun looks fun indeed, but coming from a drought-filled country, I can't help but cringe at it. Especially in California now [21:55:51] Yeah [21:56:16] Well, at least it's not 10 million gallons, like with the fire in Mission Bay this past winter (February?) [21:56:18] TrevorParscal, hangout? here? the general (still highly WIP) code in question is here: https://gerrit.wikimedia.org/r/#/c/161342/ but I'd like to talk around it quickly, more about the implementation of the widget [21:56:28] wow 10 million?! [21:56:30] Just when everyone started freaking out over the drought, a fire broke out in a building under construction [21:56:44] ouch [21:56:45] It had window holes but no windows, and no fire suppression system, so it burned like crazy [21:56:49] but you can use salt-water for that [21:56:56] Fortunately the workers had just gone home, because the steel scaffolding was melting [21:57:07] you have the bay, no? you don't need to waste actual drinking water for this [21:57:32] Yeah I'm sure the fire suppression water system isn't potable quality water [21:57:42] And in emergencies there is a fire boat that can pump water out of the bay [21:57:45] was looking at https://en.wikipedia.org/wiki/Drought_in_the_United_States#2010s [21:57:49] last line in the section [21:57:58] basically, the dust bowl v2 is upon us [21:58:22] to be fair: https://en.wikipedia.org/wiki/Drought_in_the_United_States#mediaviewer/File:Average_Drought_Conditions_in_the_Contiguous_48_States,_1895-2011.png [21:58:26] In this case the regular fire water system didn't provide enough pressure, so SFFD did what they could while people working at the UCSF hospital across the street were standing on the roof with fire extinguishers dealing with burning pieces of rubble blowing over [21:58:36] the 1930s were significantly drier [21:58:43] mooeypoo: looking at patch [21:58:46] Then a fireman hauled a firehose a few blocks to the nearest emergency hydrant, and that system had more pressure [21:58:50] ouch yeah [21:59:00] So ironically the 1900s tech of "put a big tank on a hill and rig up some pipes" worked better than modern stuff [21:59:01] TrevorParscal, what bugs me most about this is that I am starting to have to do a lot of workarounds [21:59:13] and that, I thnk, means that at this point, there's gotta be a better way [21:59:21] point me to one in particular and we can start there [21:59:39] I don't know if they ended up using 10M gallons but it was definitely millions. The big tanks are about that size, too [22:00:10] ok, so here's the bigger issue that I just ran into; the search widget displays the results individually and is meant to be selectable. I changed it so instead of "just" selectable, it will also display extra info. So, you click on an item, it opens up and shows you info, and then you can click 'choose me' (with better phrasing) [22:00:35] problem is, the item itself is emitting clicks, so if I put a button in the item itself, it won't click on its own -- because the entire element is clickable [22:00:37] this makes sense? [22:00:39] I can work around this [22:00:41] TrevorParscal: https://xkcd.com/1410/ , look at 2009-2012 in particular [22:00:51] but this is the third "workaround" adjustment I'm doing for the search widget already [22:02:03] TrevorParscal, the best thing is to take a look at how it works, but please rmeember that it's ugly for now; i concentrated on the API and sizing and stuff, not yet on the design -- but still, when you click the item, it expands and shows you info [22:02:19] but it isn't *quite* meant for that in the SearchWidget code, because the item is supposedly static and clickable [22:02:20] mooeypoo: worse than that - it's a select widget [22:02:24] indeed [22:02:41] There are ways to work around it, but that seems to be silly at this point, no? [22:02:46] which means it's being handled at the group level [22:02:58] let me run this, one sec [22:03:19] Well, I'm dealing with the individual items through the ve.ui.MWMediaResultWidget [22:03:22] but yes [22:04:51] TrevorParscal, also, the "expand" behavior is similar to Google images, but we don't have to do it this way [22:05:04] we could instead have a sort of panel that displays whatever information of whatever selected image [22:06:02] yeah, one sec [22:07:41] my mediawiki checkout was 882 commits behind [22:08:16] ha, oi [22:08:42] TrevorParscal, it's really pretty ugly... ignore the view, just the usability. [22:10:16] ok, so 2 things [22:11:43] don't look at the google desktop product as an example, look at the mobile version [22:12:00] ooh, okay [22:12:14] if you turn on mobile emulation in chrome [22:12:24] and go here: https://www.google.com/search?site=&tbm=isch&source=hp&biw=1280&bih=1125&q=wikipedia&oq=wiki&gs_l=img.3.0.0l10.1979.2922.0.3677.6.5.1.0.0.0.87.281.5.5.0....0...1ac.1.54.img..0.6.282.TiedvEYZhtU#tbm=isch&q=wikipedia&imgdii=_ [22:12:35] how do I turn on the mobile emulator? [22:12:59] it's a little smart phone icon on the top left of the web inspector [22:13:07] select iphone 5 or something [22:13:33] you got it? [22:13:53] Got it [22:13:54] it also helps to move the inspector to the right side (button on the top right of the inspector switches it's placement) [22:14:05] the reason I say this is a better example [22:14:12] is because you are working in a smaller area [22:14:20] the google desktop product is designed for large screens [22:14:25] we are rendering in a small window [22:14:33] relative to the whole screen anyway [22:14:45] yeah [22:14:48] so, either we make the window way huge, or we change to a different look [22:14:54] thta was another issue there, the dialog seemed to be tiny for that. [22:15:01] * mooeypoo nods [22:15:33] maybe click the orientation flip button [22:15:40] (between the two resolution inputs) [22:16:01] maybe render for ipad mini [22:16:04] but still [22:16:04] hm, something's not right in my google emulation, i'll check it later ... it doesn't seem to work. But I have it in my phone now [22:16:17] sure [22:16:18] ok [22:16:26] so, my point is, I support just doing an overlay [22:16:28] But on the phone it jumps up like a new screen [22:16:29] right [22:16:31] don't try and do it in place [22:16:34] I see [22:16:48] it's imageviewer-esque [22:17:01] Okay, that makes sense. The design schema showed in-place, but yeah, that seemed to be a bit wonky [22:17:10] also, if the image grows, it sometimes gets pushed down a line [22:17:13] maybe look at the imageviewer UI -> https://en.wikipedia.org/wiki/Drought_in_the_United_States#mediaviewer/File:Average_Drought_Conditions_in_the_Contiguous_48_States,_1895-2011.png [22:17:28] where are the designs you are working from? [22:17:31] that's annoying. I was planning to see how to scroll to it, etc, but yeah -- seems to get more troublesome than it might be worth dealing with [22:17:35] let me find it again [22:18:12] https://www.mediawiki.org/wiki/VisualEditor/Design/Media [22:18:28] ... not that what I did looks anywhere close to that, but the idea seemed to be expanding in place [22:19:00] This: https://www.mediawiki.org/wiki/VisualEditor/Design/Media#mediaviewer/File:Media-12.png and then selection: https://www.mediawiki.org/wiki/VisualEditor/Design/Media#mediaviewer/File:Media-13.png [22:19:05] I have 2 ideas for you [22:19:15] 1, we talk to kaity and reconsider the design [22:19:22] (probably the slowest option) [22:19:32] 2, we reconsider how you are doing this design [22:19:34] let's start with 2 [22:20:03] Instead of expanding in-place, we can have a static sort of panel above that is visible on click. So, a semi-overlay. [22:20:04] the design she did has some problems [22:20:05] thta makes sense? [22:20:19] the search appears to not be persistent [22:20:36] and we only see an example of what it looks like when the first image is selected [22:20:56] and there's no indication as to how we transition between states [22:21:08] right. [22:22:06] because of how select works, you are using inline-block (text-flow) [22:22:15] not rendering into separate divs for each row [22:22:29] is this how the masonry plugin you are using is meant to work? [22:23:00] the masonry plugin is not working at the moment [22:23:08] ah [22:23:15] you are just letting it flow [22:23:20] with a fixed height [22:23:23] The sizing you see are my fallback masonry [22:23:23] right [22:23:45] not really masonry. Fixed height with a better way to present images, and if the image is too small, adding a bit of extra padding [22:24:10] Also it's supposed to minimize images that are too wide [22:26:40] ok, so unlike google, what kaity seems to have designed here is to not inject a row (preserving the flow), but replace the image and interrupt the flow with the panel [22:26:47] I think that's a big problem with the design [22:26:51] TrevorParscal, https://gerrit.wikimedia.org/r/#/c/161342/2/modules/ve-mw/ui/widgets/ve.ui.MWMediaResultWidget.js #233 downwards are the sizing rules, if you want to peek at that [22:28:02] TrevorParscal, hm. Okay. How should we do it instead, then? At least for start, you want to work with a second screen? As in, select -> screen with image + info + 'back to results' etc ? [22:28:03] so, I have a suggestion [22:28:46] I think we should schedule a design meeting for monday with kaity to address the issues and ask for clarification because I do not believe the design as it is provides enough information, and probably has issues [22:29:02] in the mean time [22:29:09] work on it in a separate panel [22:29:17] because we can always move that panel somewhere [22:29:22] * mooeypoo nods [22:29:23] sounds good [22:29:40] I'll also not need to rebuild the widget this way :) [22:30:54] btw, when you have a second, take a look at this demo: http://erikjohanssonphoto.com/work/imagecats/personal/ -- that uses the masonry fit js library I plan to try and implement. The library is here: http://masonry.desandro.com/ [22:31:36] But I'll concentrate on the info and panel first before playing around with that. I think we might be able to get away with the basic flow we have in this patch as a first step, if the info is okay. [22:31:48] Then we can "upgrade" to full masonry. [22:32:59] (03CR) 10Inez: "Very happy to see code in ve.ce.Surface.js be simplified." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151046 (owner: 10Catrope) [22:33:08] that's cropping to square (like we already do) [22:33:16] is that what we are planning on doing? [22:33:56] no no [22:34:07] We won't crop [22:34:22] Here, better example: http://iam.beyonce.com/tagged/my_work [22:34:29] (it just has flashing images, I tried to save you from that) [22:35:04] And this (see the 'append items') http://masonry.desandro.com/methods.html [22:36:00] with the gaps? [22:36:04] TrevorParscal, actually, the "destroy" section in here has a nice 'toggle' button showing with and without the plugin http://masonry.desandro.com/methods.html , and the good thing is that it works on
s so it should work on the search widget as-is [22:36:07] the gaps are controllable [22:36:10] it's a setting [22:36:17] sure [22:36:38] You can also set it up with a column grid [22:40:53] mooeypoo: in all honesty, I think that these grids are not very nice to use, they are neat for collages of photos, but if you are actually trying to find the thing you want to insert, all the fancy stuff becomes a problem and you get down to bare bones (where we are at) pretty fast [22:41:20] we had Rob Moen do this same thing (the masonry flow bit) originally [22:41:35] and I ended up redoing it the way it is now, because it never really worked well [22:41:50] the size of the images would often end up too small to be able to decide if it's what you want [22:42:00] people don't like looking at tiny pictures [22:42:08] anyway, I will have james set something up for monday [22:42:19] Yeah the masonry fit looks great, but i do agree that there are issues with it. For instance, for it to work well, images must move places -- and in searches, especially in Cirrus when it is used, there' sprobably a good reason for the order [22:42:48] Okay, the idea was just not to reinvent the wheel -- since a library that seems to do the job exists already. But I agree about the problems. [22:43:15] TrevorParscal, do you think the basic flow (more or less what the search results look like in my new WIP you just looked at) is a better direction? [22:43:30] it's pretty jagged [22:43:37] not criticizing you [22:43:48] i just don't think it makes it easier to find the image I want [22:43:49] no no, I agree. [22:44:05] But the problem with squares is that you don't know what size or ratio it is. [22:44:22] that was supposed to somewhat fix that problem, but then we have less control over a nice grid. [22:44:29] I'm not sure what the right thing to do is [22:44:30] right, so there's 2 problems here [22:44:46] finding the right picture, and conveying details about the picture [22:45:11] we are planning on revealing details on click [22:45:27] Right. But the details of ratio and whether it's portrait or landscape (especially if it's very wide or very tall) is different than general details like name and license, I think. [22:45:43] is it? [22:45:49] I can see value in seeing that quick detail in advanc, like you see in Google images for instance. [22:46:12] well, google is actually fibbing about the aspect [22:46:27] if you size the browser a bit, you will notice that the widths adjust [22:46:35] they are cropping in HTML a bit [22:46:48] I think so -- it might affect which picture to go with. For instance, if I want to add an image to some article on the side, I might not want a really wide one, and prefer a high/long one instead, etc. [22:46:59] but I see your point on that too. I guess you can also see that after you click the image. [22:47:25] TrevorParscal, yeah, I noticed that. It explains a LOT, because they seem to magically fit pictures that they shouldn't be able to [22:47:40] also, it takes a while to find a search where the pictures are not *very* similar in aspect ratio in google search [22:48:07] I had to force the search with things like "32px icon" to find varied sizes. They have to be doing some serious scaling/adjusting [22:48:12] either that, or all the pictures online are the same ratio [22:48:16] :D [22:49:00] 3VisualEditor / 3Editing Tools: VisualEditor: Allow in-line editing/suggesting/flagging of TemplateData when labels are unclear - 10https://bugzilla.wikimedia.org/71626#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Low s:5normal>3enhanc This could get very tricky, but could be useful. [22:55:58] TrevorParscal, another idea I had about the flow was to use some nice math to calculate how much spacing is left in each row, and then space the images across that row a little better [22:56:48] Google does that too, btw. The padding between each image aren't always the same. But it's either doing something clever/sneaky like that, or reverting to use perfect squares and letting the user see the aspect ratio only after the click [23:20:30] 3VisualEditor / 3MediaWiki integration: VisualEditor: after dismissing the little pink saving error window, the Save page button remains disabled - 10https://bugzilla.wikimedia.org/68460 (10Alex Monk) 5ASSI>3RESO/INV [23:21:14] 3VisualEditor / 3MediaWiki integration: VisualEditor: The show/hide text a collapsed navbox disappear afted have edited - 10https://bugzilla.wikimedia.org/68279#c7 (10Alex Monk) Gabrasca, please respond. [23:22:32] (03CR) 10Trevor Parscal: [WIP] Transform the search widget into masonry fit (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161342 (owner: 10Mooeypoo) [23:22:45] 3MediaWiki extensions / 3Cite: Cite: Support multi-column and alternative list-style for tag (like enwiki {{reflist}}) - 10https://bugzilla.wikimedia.org/51260 (10Alex Monk) 5ASSI>3PATC [23:23:39] James_F, the following bugs assigned to me are awaiting response from someone else: https://bugzilla.wikimedia.org/show_bug.cgi?id=71249 https://bugzilla.wikimedia.org/show_bug.cgi?id=70674 https://bugzilla.wikimedia.org/show_bug.cgi?id=67385 https://bugzilla.wikimedia.org/show_bug.cgi?id=67218 https://bugzilla.wikimedia.org/show_bug.cgi?id=51141 [23:24:26] Maybe we should assign bugs to the person they're actually waiting for. [23:46:04] Krenair: Possibly. [23:46:19] Also, some of them are you :p [23:47:30] Krenair: Bugging me in IRC is more effective. :-) [23:47:35] :) [23:48:46] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164649 (https://bugzilla.wikimedia.org/71622) (owner: 10Bartosz Dziewoński) [23:48:56] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164620 (owner: 10Jforrester) [23:53:10] (03CR) 10Jforrester: [C: 032] "Oy." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164649 (https://bugzilla.wikimedia.org/71622) (owner: 10Bartosz Dziewoński) [23:54:41] (03Merged) 10jenkins-bot: Add mobile target to 'ext.visualEditor.iehacks' module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164649 (https://bugzilla.wikimedia.org/71622) (owner: 10Bartosz Dziewoński) [23:55:30] 3VisualEditor / 3Mobile: VisualEditor Mobile: Does not load at all on IE 11 (unknown dependency "ext.visualEditor.iehacks") - 10https://bugzilla.wikimedia.org/71622 (10James Forrester) 5PATC>3RESO/FIX [23:55:58] (03CR) 10Jforrester: [C: 032] "Go go Jenkins." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164620 (owner: 10Jforrester) [23:57:30] (03Merged) 10jenkins-bot: Update VE core submodule to master (a1c190c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/164620 (owner: 10Jforrester)