[00:25:00] (03PS1) 10Jforrester: Mark action=visualeditor as an internal API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166519 [00:26:28] (03PS2) 10Jforrester: Mark action=visualeditor as an internal API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166519 (https://bugzilla.wikimedia.org/62452) [00:26:46] (03CR) 10Legoktm: [C: 032] Mark action=visualeditor as an internal API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166519 (https://bugzilla.wikimedia.org/62452) (owner: 10Jforrester) [00:28:23] (03Merged) 10jenkins-bot: Mark action=visualeditor as an internal API [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166519 (https://bugzilla.wikimedia.org/62452) (owner: 10Jforrester) [00:31:46] 3VisualEditor: VisualEditor: Hide action=visualeditor from the api.php documentation output, given it's internal and not intended for third party use - 10https://bugzilla.wikimedia.org/62452 (10Alex Monk) 5PATC>3RESO/FIX a:5Alex Monk>3James Forrester [07:52:06] (03CR) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [07:52:18] (03CR) 10Paladox: [C: 031] WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) (owner: 10Paladox) [09:30:44] (03PS1) 10Esanders: Fix paste by never polling while pasting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166539 [09:35:37] (03CR) 10jenkins-bot: [V: 04-1] Fix paste by never polling while pasting [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166539 (owner: 10Esanders) [15:04:00] 3VisualEditor / 3Mobile: VisualEditor Mobile: For long drop down menus the options are not at all accessible when the screen is set to landscape in iOS device - 10https://bugzilla.wikimedia.org/67340#c5 (10Bartosz Dziewoński) (In reply to Roan Kattouw from comment #3) > Juliusz explained to me that there's a... [15:15:00] Heya. [15:17:04] (03PS2) 10Esanders: Add content-heavy table to demo HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166444 [15:17:06] (03PS24) 10Esanders: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [15:17:08] (03PS26) 10Esanders: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [15:17:10] (03PS2) 10Esanders: More flexible selection reporting in the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166443 [15:17:12] (03PS3) 10Esanders: Don't force focus after history action [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166424 [15:17:14] (03PS28) 10Esanders: Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [15:17:16] (03PS29) 10Esanders: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [15:17:18] (03PS1) 10Esanders: Add CollapseToFrom/To to Selection API [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166579 [15:17:21] edsanders: Getting close? [15:17:42] it's pretty much done [15:17:46] Nice. [15:17:51] Thursday, perhaps? [15:19:26] (03CR) 10jenkins-bot: [V: 04-1] Add content-heavy table to demo HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166444 (owner: 10Esanders) [15:19:36] http://92.60.127.23:8080/ve/demos/ve/desktop-dist.html#!/src/pages/tables.html [15:20:14] Is the red bar for a slug? [15:21:44] edsanders: Hmm. Is copy-paste meant to not work? [15:21:54] no [15:22:11] I've got a WIP for single cell [15:22:16] Right. [15:22:28] anything more complex is potentially structural changing [15:22:29] I think it'd be nice but not vital to get that working. [15:22:40] (03CR) 10jenkins-bot: [V: 04-1] Provisional fix to prevent structural changes to a table via delete+merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159317 (owner: 10Oliverb) [15:22:47] and .'. 10x more complicated [15:23:03] What about dragging of columns/rows? [15:24:26] (03CR) 10jenkins-bot: [V: 04-1] More flexible selection reporting in the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166443 (owner: 10Esanders) [15:24:59] (03CR) 10jenkins-bot: [V: 04-1] ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [15:25:01] (03CR) 10jenkins-bot: [V: 04-1] Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [15:26:51] edsanders: Oh, also, you should trap the tab character to move between cells (and to insert a new row when at the terminal cell). [15:27:02] Helpful, aren't I? [15:27:51] and how do you deselect a table? [15:28:52] edsanders: Cursor key. [15:28:56] Or click elsewhere. [15:29:08] for keyboard accessibility [15:29:13] Yeah. [15:29:30] so cursoring off the side does what? [15:30:18] Deselects. [15:30:40] to null selection? [15:31:55] an arrow key movement should usually be (approximately) undo-able with its inverse [15:32:11] Usually, sure. [15:32:18] But this is standard editor expectation. [15:33:08] edsanders: Also, fatal JS on inserting a table makes me sad. [15:34:14] edsanders: surfaceModel.setSelection( fragment.adjustRange( 5 ).collapseRangeToStart().getRange() ); fails because fragment is apparently not defined. [15:34:40] I haven't worked on the insert tool [15:34:45] Right, OK. :-) [15:35:28] edsanders: And Firefox pawns when you type into a slug in a table cell. [15:37:18] RoanKattouw_away: https://www.mediawiki.org/w/index.php?title=VisualEditor/status&diff=prev&oldid=1219730 [16:10:08] (03CR) 10Jforrester: [C: 032] Fix icon opacity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166292 (owner: 10Esanders) [16:10:16] (03CR) 10Jforrester: [C: 032] Fix icon opacity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166293 (owner: 10Esanders) [16:10:57] (03PS1) 10Esanders: Fix typo in getSelectionBoundingRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166591 [16:11:29] edsanders: Ick. Can that be broken off? [16:11:43] what? [16:11:50] 166591 [16:11:57] Rebase onto master? [16:12:32] 3VisualEditor / 3Editing Tools: VisualEditor: The icons for Media and Comment are appearing a bit darker in Insert menu - 10https://bugzilla.wikimedia.org/71541#c1 (10James Forrester) 5NEW>3RESO/FIX p:5Unprio>3Normal a:3Ed Sanders Fixed with gerrit 166292 and gerrit 166293. [16:12:34] (03Merged) 10jenkins-bot: Fix icon opacity [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166292 (owner: 10Esanders) [16:12:35] it could - it's just a local stack I'm working on [16:12:36] (03Merged) 10jenkins-bot: Fix icon opacity [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166293 (owner: 10Esanders) [16:12:47] it's actually an unused codepath [16:12:50] at the moment [16:13:48] OK, in that case, let's not stress. :-) [16:17:45] 3OOjs UI: OOjs UI: InlineMenuWidget should behave as a menu widget - 10https://bugzilla.wikimedia.org/70968 (10Bartosz Dziewoński) 5ASSI>3UNCO [16:29:42] well, the weirdest thing just happened, one of the tree objects in my oojs/ui repo disappeared. huh. [16:30:53] Corruption alert: visualeditor-needcheck on viwiki: https://vi.wikipedia.org/?diff=19850656 [16:30:53] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40281003 [16:44:14] mooeypoo: In case you haven't found this out yet: if you have a panel or other absolutely-positioned thins in your dialog, you need to override getBodyHeight(). Grep for other dialogs that do this to see how it's done [16:51:59] RoanKattouw: https://meta.wikimedia.org/wiki/VisualEditor/Newsletter/2014/October/nl [16:56:15] RoanKattouw, I did see it, but there's a different issue with the dialog I'm working on. The dialog doesn't seem to recognize the panels at all; if I append this.panels.$element the dialog is showing empty (not even small with scrollbars) ... the panels *only* appear if I append some empty div before it. So then, it seems that the dialog recognizes only the empty div, and with getBodyHeight it returns a tiny tiny heigh [16:56:15] t (because the div is just  ) [16:56:49] Yeah you need to override getBodyHeight to measure the height of the panel instead of the dialog itself [16:56:50] I am at a loss :( I'm literally copy/pasted the entire initialize method from media dialog to see if I can duplicate it (removed events and ve-specific widgets) and it *still* won't show the panels at all [16:57:02] Because the panel is absolutely positioned so it doesn't contribute to the dialog's height [16:57:03] but why would I need to append anything else in there for the panels to show? [16:58:21] I understand the height thing (though we need to add this to the docs) -- but it won't show unless I "trick it" with this.$body.append( $( '
' ).html( ' '), this.panels.$element ); [16:59:12] RoanKattouw, also, I think we should reorganize the way panels show in general. There's a method "setItem" but it doesn't properly *show* it [16:59:47] so, in the media dialog for example, the 'switchPanels' method has panels.setItem( item ) and then otherPanel.$element.hide(); thisPanel.$element.show() [16:59:51] otherwise they appear overlapped [17:00:00] wtf [17:00:10] RoanKattouw, same goes with the other dialogs that use panels [17:00:20] the save dialog,for example, hides/shows the diff panel iirc [17:00:25] That sounds like either a bug in PanelLayout or a problem with the way it's used [17:00:32] I should go to the standup, but let's talk more after [17:00:36] * mooeypoo nods [17:00:49] 3VisualEditor: file permissions cause lintian warnings - 10https://bugzilla.wikimedia.org/71933 (10Sam Reed (reedy)) [17:19:37] edsanders, TrevorP|Away RoanKattouw_away ooooookay, just tested this -- adding a link in RTL into a surface inside a dialog is messed up too (like adding a link to an image caption). Something's happening with the way we calculate overlays now after the sibling fix. [17:22:57] (03CR) 10Trevor Parscal: "Could we add support for accessing a mixin's ${mixin-name} properties to the __get magic getter so the mix-ins could expose those properti" [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [17:26:02] woah… [17:28:06] hmm, I see the problem. RoanKattouw_away TrevorParscal it seems the popup doesn't adjust its left/right position properly in RTL, so inside a dialog, if you mark a word that's close to the edge (like if you have a single word in the caption surface and make it a link) the popup pushes the frame to the left and scrolls the surface out of view. [17:28:36] that's right [17:28:50] the popup positioning logic is not smart about RTL [17:29:19] this is something I noted, but didn't fix, when i was fixing popups a bit for theming [17:29:30] * mooeypoo nods [17:30:12] Also, wasn't the surfaces adjusting to RTL in the past? [17:30:27] oh, scratch that, I'm in *ui* hebrew, not document hebrew. [17:30:44] btw, that is making the popup even worse. [17:33:35] (03CR) 10Bartosz Dziewoński: "Probably… I haven't written enough PHP to know whether that's a good idea." [oojs/ui] - 10https://gerrit.wikimedia.org/r/160996 (owner: 10Trevor Parscal) [17:34:16] 3VisualEditor / 3Initialisation: VisualEditor: Some file permissions are causing lintian warnings - 10https://bugzilla.wikimedia.org/71933 (10James Forrester) p:5Unprio>3Low [17:34:40] ryasmeen|Away: James_F is it known that the Cite inspector is busted right now on beta labs? [17:34:51] chrismcmahon: Yeah there's a bug about that [17:35:00] https://bugzilla.wikimedia.org/show_bug.cgi?id=71997 [17:35:03] thanks RoanKattouw [17:36:03] RoanKattouw, yay! I overrode getBodyHeight() to read the panels height and now it appears brilliantly. [17:36:25] mooeypoo: Sweet [17:36:32] Although it appears really long now, heh [17:36:53] You're measuring the panel's scrollHeight, right? [17:36:58] yeah [17:37:06] return this.panels.$element.scrollHeight; [17:37:12] Ahm [17:37:17] I shouldn't, irhgt? [17:37:17] $element[0].scrollHeight I hope? [17:37:28] No scrollHeight is right. It looks weird but it's a trick [17:37:37] hmmm [17:37:41] it works without [0] [17:37:43] Clear! [17:37:45] checking with it, though [17:37:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] Clicking in the document where an inspector was opened doesn't close the inspector - 10https://bugzilla.wikimedia.org/68679 (10James Forrester) [17:37:45] 3VisualEditor / 3MediaWiki integration: VisualEditor: After saving a page reference list gets missing (unless it is refreshed again) and the page gets categorized as "Pages with missing reference list" - 10https://bugzilla.wikimedia.org/68182 (10James Forrester) [17:37:46] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] When the inspector is still open for a selected node, after placing the cursor in a different position, inspector flickers there - 10https://bugzilla.wikimedia.org/71151 (10James Forrester) [17:37:46] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249 (10James Forrester) [17:37:47] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852 (10James Forrester) [17:37:51] (Sorry.) [17:38:00] 3VisualEditor / 3Editing Tools: VisualEditor: Problems changing image type from Thumbnail to Basic when surrounded by images with images in captions - 10https://bugzilla.wikimedia.org/66604 (10James Forrester) [17:38:01] 3VisualEditor / 3Editing Tools: VisualEditor: In the media insertion dialog, give a tooltip on each item saying what will happen when you click it (i.e., "Click to insert as a thumbnail" or whatever) - 10https://bugzilla.wikimedia.org/52219 (10James Forrester) [17:38:01] 3VisualEditor / 3Editing Tools: VisualEditor: In the media selector show name in a tooltip on mouseover - 10https://bugzilla.wikimedia.org/52459 (10James Forrester) [17:38:01] 3VisualEditor / 3Editing Tools: VisualEditor: Support "substituting" templates in transclusion dialog - 10https://bugzilla.wikimedia.org/49904 (10James Forrester) [17:38:02] 3VisualEditor / 3Data Model: VisualEditor: Undoing a change of group on a reference throws "Uncaught TypeError: Cannot read property 'length' of undefined" - 10https://bugzilla.wikimedia.org/69119 (10James Forrester) [17:38:03] 3VisualEditor / 3Editing Tools: VisualEditor: Applying link to the caption of an image does not enable "Apply Changes" button - 10https://bugzilla.wikimedia.org/71065 (10James Forrester) [17:38:04] 3VisualEditor / 3MediaWiki integration: VisualEditor: Link existence checker in LinkTargetInputWidget doesn't work for interwikis, language links - 10https://bugzilla.wikimedia.org/70504 (10James Forrester) [17:38:05] 3VisualEditor / 3Mobile: VisualEditor Mobile: Toolbar does not float while tapping towards the end of the screen - 10https://bugzilla.wikimedia.org/68832 (10James Forrester) [17:38:06] 3VisualEditor / 3Data Model: VisualEditor: Pasting in image caption with a repeated reference causes VE to crash - 10https://bugzilla.wikimedia.org/71214 (10James Forrester) [17:38:17] 3VisualEditor / 3ContentEditable: VisualEditor: Reference & cite tooltips should show content snippets, instead of generic labels - 10https://bugzilla.wikimedia.org/69474 (10James Forrester) [17:38:18] 3VisualEditor / 3Editing Tools: VisualEditor: If you click out of a link inspector to somewhere else in the document, the link gets inserted and selected, moving your cursor away from where you clicked - 10https://bugzilla.wikimedia.org/68590 (10James Forrester) [17:38:18] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf22] Resizing the window adds an extra padding below the "Choose a different image" button in Media Settings dialog - 10https://bugzilla.wikimedia.org/70895 (10James Forrester) [17:38:19] 3VisualEditor / 3Data Model: VisualEditor: Make transaction processing exception-safe - 10https://bugzilla.wikimedia.org/68892 (10James Forrester) [17:38:19] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression pre-wmf3] For every Math expression, it is not appearing on CE when its gets evaluated for the first time - 10https://bugzilla.wikimedia.org/71829 (10James Forrester) [17:38:20] 3VisualEditor / 3Mobile: VisualEditor Mobile: Getting stuck inside Link inspector while trying to clear the link text when there was no match for it in the inspector - 10https://bugzilla.wikimedia.org/66696 (10James Forrester) [17:38:30] 3VisualEditor / 3ContentEditable: VisualEditor: Safari scrolls one line for every character typed - 10https://bugzilla.wikimedia.org/71561 (10James Forrester) [17:38:31] 3VisualEditor / 3Editing Tools: VisualEditor: Highlight missing parameters in template dialog when complaining about them - 10https://bugzilla.wikimedia.org/70957 (10James Forrester) [17:38:31] 3VisualEditor / 3Editing Tools: VisualEditor: "Categories" dialog behaves differently for existing values and entered values - 10https://bugzilla.wikimedia.org/71921 (10James Forrester) [17:38:31] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf1] The subst: autovalue for a template field does not return any value (Parsoid issue?) - 10https://bugzilla.wikimedia.org/71157 (10James Forrester) [17:38:32] 3VisualEditor / 3Data Model: VisualEditor: [Regression wmf1] Increasing indentation to a bullet/numbered list is also adding a slug with a new bullet/numbered point each time - 10https://bugzilla.wikimedia.org/71134 (10James Forrester) [17:38:33] 3VisualEditor / 3Data Model: VisualEditor: [Regression?] Save button stays disabled after inserting a character in some cases. - 10https://bugzilla.wikimedia.org/71732 (10James Forrester) [17:38:34] 3VisualEditor / 3Editing Tools: VisualEditor: Append references list to bottom of pages when first reference is added - 10https://bugzilla.wikimedia.org/54906 (10James Forrester) [17:38:35] 3VisualEditor / 3Editing Tools: VisualEditor: In production, sometimes page scrolling is not working and in the console Getting Error: offset was inside a handlesOwnChildren node - 10https://bugzilla.wikimedia.org/68537 (10James Forrester) [17:38:36] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression pre-wmf15] Pressing backspace to delete the link target inside link inspector closes the inspector - 10https://bugzilla.wikimedia.org/68195 (10James Forrester) [17:38:37] 3VisualEditor / 3Editing Tools: VisualEditor: There should be help links in every context - dialog boxes, inspectors, etc. - 10https://bugzilla.wikimedia.org/51798 (10James Forrester) [17:38:37] 3VisualEditor / 3Editing Tools: VisualEditor: Reference group input combo box does not populate the Reference group names if created from Reference list dialog - 10https://bugzilla.wikimedia.org/70365 (10James Forrester) [17:38:45] 3VisualEditor / 3ContentEditable: VisualEditor: Deleting from an empty paragraph to the end of an inline node throws an exception - 10https://bugzilla.wikimedia.org/70375 (10James Forrester) [17:38:45] 3VisualEditor / 3ContentEditable: VisualEditor: Trying to insert anything in the slug inside a media dialog box throws Uncaught Error: Offset could not be translated to a DOM element and offset: 63 - 10https://bugzilla.wikimedia.org/63025 (10James Forrester) [17:38:46] 3VisualEditor / 3Editing Tools: VisualEditor: MWLink nodes inside sub-editor dialogs appear as zero-width - 10https://bugzilla.wikimedia.org/71652 (10James Forrester) [17:38:46] 3VisualEditor / 3Mobile: VisualEditor Mobile: Text should remain selected after leaving link dialogue in iOS Safari - 10https://bugzilla.wikimedia.org/64580 (10James Forrester) [17:38:47] 3VisualEditor / 3Mobile: VisualEditor: Selecting templates on iOS < 8 causes the on-screen keyboard to close, so they cannot be deleted - 10https://bugzilla.wikimedia.org/60110 (10James Forrester) [17:39:59] RoanKattouw, "return this.panels.$element[0].scrollHeight;" <-- this shows the dialog tiiiiny again (and the panels aren't showing because it's so small).. but "return this.panels.$element.scrollHeight;" this works (though it shows a very long window) [17:40:35] It probably shows the window at the size of the screen or something, because you're returning undefined [17:41:42] Oh, crap [17:41:52] this.panels is a StacckLayout? [17:41:55] *StackLayout [17:42:10] Because that will also have zero height, because the panels inside it are absolutely positioned [17:42:24] yes [17:42:26] :\ [17:42:33] Instead you need the scrollHeight of the active panel I think? [17:42:40] hm [17:42:43] Or ask TrevorParscal [17:42:54] Because a lot of dialogs that have this kind of layout seem to use a hardcoded body height [17:43:10] this is an annoying thing about using grids [17:43:21] and panels [17:43:22] I'm having a really weird problem now, too.. I put 'debugger' statement in my overrided getBodyHeight method (before the return) and it doesn't pop [17:43:32] .... what the hell... but it does seem to affect things when I change it [17:43:48] grids are percentage based, and panels are absolutely positioned with innner-scrolling (usually) [17:44:18] TrevorParscal, should I just add in a hard-coded value (relative to the window height with some margins) ? [17:44:27] mooey, that's odd, maybe something catches it? [17:44:30] try console.log() [17:44:38] see if it produces output [17:44:57] it does produce output [17:45:10] That's really weird [17:46:52] (03PS3) 10Jforrester: Update VE core submodule to master (0dd43dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166057 [17:47:14] oooooookay! this works: this.panels.getCurrentItem().$element[0].scrollHeight [17:48:11] TrevorParscal, maybe we should add something like "this.panels.getHeight()" or something to make this easier to use? [17:48:36] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (0dd43dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166057 (owner: 10Jforrester) [17:48:57] mooeypoo: yeah, maybe a stack could have this interface? [17:49:43] Yeah. Also, I'm having problems with the setItem() method. I dont know if it's something I'm doing wrong or an issue with the stack layout, but .setItem() still shows all my panels stacked on top of one another, and I need to literally do .show() and .hide() on each [17:49:48] getScrollHeight() on the stack will just get the scroll height of the current panel, or if contiguous, the scroll height of all of them? [17:49:51] I am doing this in the media dialog as well, in switchPanels [17:49:55] that can't be right [17:50:16] mooeypoo: are you paying attention to the continuous option? [17:50:39] Ahha... apparently not [17:50:54] Let me see [17:52:26] hm [17:52:34] that makes all of them appear one after the other, but still all visible [17:52:47] (Plus now I get 2 sets of scrollbars :\ ) [17:53:11] I still need to manually go unusedPanel.$element.hide(); usedPanel.$element.show() when I switch from one to the other [17:54:10] TrevorParscal: if you respond at http://etherpad.wikimedia.org/p/OOUIPHP today (or get someone to respond), i'll probably get the things i commented on done before tomorrow. otherwise i might not have a lot of time during wednesday/thursday [17:54:39] i could also just go ahead and do what i think, but a confirmation that i'm not doing silly things would help [17:58:15] (03PS4) 10Catrope: Update VE core submodule to master (0dd43dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166057 (owner: 10Jforrester) [17:59:25] TrevorParscal, I'm not sure if I'm doing this right, because the save dialog that uses panels too seems to do things slightly differently -- but still semi hides/shows things. Then again, I get all the panels either stacked on top of one another (all visible) or continuous (all visible) so I have to manually hide them, [18:00:05] Very weird. It's either me not understanding the way to use it right, or something is wonky in the way they're presented. [18:00:58] it may be that the panels aren't configured to expand? [18:01:16] normally they are asbolute top: 0, right: 0, bottom: 0, left: 0 [18:01:19] but that can be disabled [18:01:38] also, other panels should be hidden [18:01:46] unless it's continuous [18:01:50] so, that sound messed up [18:02:06] MatmaRex: awesome, will go over this in a min [18:02:10] great work man [18:02:21] cool [18:02:32] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (0dd43dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166057 (owner: 10Jforrester) [18:03:57] (03Merged) 10jenkins-bot: Update VE core submodule to master (0dd43dc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166057 (owner: 10Jforrester) [18:07:16] RoanKattouw: feature or bug? edit a page in VE, choose Insert/Template, resulting inspector is an iframe. type "s" in the box, see a list of suggestions starting with "s". the list of suggestions is NOT in the iframe, it's in the root page [18:07:41] chrismcmahon: New feature. [18:08:02] chrismcmahon: Ah, has this been causing browser test failures? Whoops, sorry. :-( [18:08:11] Oh, yeah, that's a new feature [18:08:29] thanks James_F RoanKattouw I never did like those iframes :-) [18:08:42] chrismcmahon: The iframes are still there. :-) [18:08:43] The iframe might be quite small, or the text box might be at the bottom of the iframe (like the group in the reference / reference list dialogs) [18:08:58] So we need for the suggestions to be able to go beyond the iframe's boundaries [18:09:44] sounds good, I'll update the test. looks a little weird though, I wanted to make sure that was by design [18:10:43] (03CR) 10Jforrester: [C: 032] Also make transitions when leaving slugs work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165936 (owner: 10Catrope) [18:12:33] (03Merged) 10jenkins-bot: Also make transitions when leaving slugs work again [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165936 (owner: 10Catrope) [18:13:31] (03PS1) 10Cmcmahon: [BrowserTest] suggest list is no longer in the iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166612 [18:13:59] (03CR) 10Catrope: [C: 032] Remove unicorn debug styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166215 (owner: 10Esanders) [18:14:42] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166612 (owner: 10Cmcmahon) [18:15:34] (03CR) 10Catrope: [C: 032] Remove unused wrongly named class from ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166445 (owner: 10Esanders) [18:15:49] (03Merged) 10jenkins-bot: Remove unicorn debug styling [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166215 (owner: 10Esanders) [18:16:01] (03PS1) 10Bartosz Dziewoński: WindowManager: Wait for window to open before trying to close it [oojs/ui] - 10https://gerrit.wikimedia.org/r/166613 (https://bugzilla.wikimedia.org/69918) [18:16:18] (03Merged) 10jenkins-bot: [BrowserTest] suggest list is no longer in the iframe [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166612 (owner: 10Cmcmahon) [18:17:27] (03Merged) 10jenkins-bot: Remove unused wrongly named class from ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166445 (owner: 10Esanders) [18:19:02] 3VisualEditor: Parser function #ref: used for footnotes display with extra newline after being edited - 10https://bugzilla.wikimedia.org/72045 (10WhatamIdoing) 3NEW p:3Unprio s:3normal a:3None This might be related to bug 72006 (but probably not?). A normal, successful edit to an explanatory footnote... [18:19:03] (03CR) 10Catrope: [C: 032] Fix typo in getSelectionBoundingRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166591 (owner: 10Esanders) [18:21:46] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166443 (owner: 10Esanders) [18:25:38] (03PS2) 10Divec: POC: Don't calculate DOM hash in SurfaceObserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/165975 [18:30:04] mooeypoo: Re https://gerrit.wikimedia.org/r/#/c/166279 , you said something about how Ed didn't like .css( 'direction' ) but you had trouble reaching ui.Surface.getDir() ? [18:31:02] RoanKattouw, indeed [18:31:18] but I may have had a brainfart moment. I think I tried to reach this.frame.getDir() instead of ui surface [18:31:21] * mooeypoo doesn't remember [18:31:25] I have to try it again [18:31:28] (Also I think there might be some code for positioning a popup correctly in ooui, let me find it) [18:31:52] I think the positioning was taken out of oo.ui.context? I remembered it was there [18:31:58] or in ve.ui.context at least? IIRC [18:32:11] Maybe it was TextInputMenuWidget [18:32:36] that's fr the suggestions, but it's also relative to the popup, if I remember that right [18:32:44] Yeah, see OO.ui.TextInputMenuWidget#position [18:32:44] so the calculations were somewhat different [18:32:50] * mooeypoo looks [18:33:38] There it is [18:33:47] that's what I rmembered that existed in the ve.ui.Context a while back [18:34:11] RoanKattouw, btw, why is it this.$.$frame, and this.input.$.$frame ? [18:34:19] Oh yeah, that [18:34:27] wasn't this.$ the $() function? [18:34:30] Yes [18:34:37] But it also has properties attached to it [18:34:48] It has a .$iframe which is set only if you're in an iframe [18:34:59] is there a way to get the actual frame object? [18:35:00] And it has .context which is the document it's bound to [18:35:05] from a widget that is in a frame? [18:35:19] Well OO.ui.Frame doesn't exist any more, it' s been merged into OO.ui.Window [18:35:23] Why would you need it? [18:35:25] oh, right, window [18:35:37] Actually, I may not, if the ui surface getDir works [18:35:55] Yeah that function appears to still exist [18:36:08] we had getDir in frame too, so it propogates [18:36:19] but I believe it was also fixed to be in the surface ui [18:36:27] * mooeypoo will look into it [18:36:42] The only thing is, how the hell do you get to the surface from an MWCategoryWidget [18:36:48] So maybe .css('direction') is fine, let me see [18:37:05] yeah that's what I got confused with [18:37:14] but I tried a bunch of things, I may have been confusing myself slightly. [18:37:41] Yeah no I think you've got it right [18:37:42] The positioning in the RTL (with the mismatching arrow/indicator) was also driving me crazy [18:38:17] I couldn't manage to get to the actual surface it's attached to, since it was a widget inside another, calling some widget outside the frame [18:38:37] I do wonder what the difference is between your use of this.$.$iframe.offset().left vs TextInputMenuWidget's use of OO.ui.Element.getRelativePosition( this.input.$.$iframe, this.$element.offsetParent() ); [18:38:38] css( 'direction' ) was the quickest reliable fix, but there might be another. [18:38:48] No I think you did that part right [18:39:07] I didn't try the getRelativePosition [18:39:19] I honestly don't know how they differ [18:39:25] but it sounds like it would calculate the relative position from the current element to the frame [18:39:35] and it seems a bit meh when the element is *outside* the frame, no? [18:39:39] I'll try it out, though [18:39:45] Oh, I think I see [18:39:57] It's for if your offsetParent is not the entire iframe I think [18:40:11] So it's probably more robust against future changes to that UI [18:41:28] (03CR) 10Catrope: [C: 032] Style required but currently-invalid parameters on the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [18:41:44] all these relative-to relative to another relative-to and then *flip for RTL* calculations are making my brain do loop-de-loops in my skull [18:41:45] 3VisualEditor / 3Technical Debt: VisualEditor: Transclusion nodes should re-evaluate their block/inline status on every update - 10https://bugzilla.wikimedia.org/49784#c9 (10James Forrester) *** Bug 72045 has been marked as a duplicate of this bug. *** [18:41:46] 3VisualEditor: Parser function #ref: used for footnotes display with extra newline after being edited - 10https://bugzilla.wikimedia.org/72045#c1 (10James Forrester) 5NEW>3RESO/DUP This is bug 49784 sadly. :-( *** This bug has been marked as a duplicate of bug 49784 *** [18:42:07] mooeypoo: Yeah I didn't even try to understand the RTL flipping parts [18:42:22] RoanKattouw, another thing is that the current "flip for rtl" code seems to have to take the *entire* window into account, now that the overlay is outside the frame [18:42:30] 3VisualEditor / 3Editing Tools: VisualEditor: Highlight missing parameters in template dialog when complaining about them - 10https://bugzilla.wikimedia.org/70957 (10James Forrester) 5PATC>3RESO/FIX [18:42:44] and that only half works, because the layout is mirrored outside the frame, and not-quite-mirrored inside the frame. [18:42:49] MATH! :D [18:43:01] +s [18:43:03] s [18:43:06] (03Merged) 10jenkins-bot: Style required but currently-invalid parameters on the template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/161613 (https://bugzilla.wikimedia.org/70957) (owner: 10Alex Monk) [18:43:07] :-) [18:43:29] ... to which word? [18:43:48] maths [18:43:56] You're right. It should be "MATH! :S" [18:52:49] 3VisualEditor / 3Editing Tools: VisualEditor: Place page meta-data in expected order - 10https://bugzilla.wikimedia.org/50882 (10WhatamIdoing) [18:57:49] (03PS1) 10Jforrester: Update VE core submodule to master (25b398c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166623 [19:08:40] hmm, i just needed display: inline-table; to get stuff to behave, and i can't decide if it's myself or CSS that's the problem here. [19:09:10] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (25b398c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166623 (owner: 10Jforrester) [19:10:33] (03Merged) 10jenkins-bot: Update VE core submodule to master (25b398c) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166623 (owner: 10Jforrester) [19:24:16] (03PS1) 10Bartosz Dziewoński: [WIP] Display keyboard shortcuts in right gutter of toolbar menus [oojs/ui] - 10https://gerrit.wikimedia.org/r/166627 (https://bugzilla.wikimedia.org/71855) [19:27:57] (03PS1) 10Catrope: Followup 1fc13cc: fix JS errors caused by incorrect context binding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166628 (https://bugzilla.wikimedia.org/71997) [19:29:16] (03CR) 10Catrope: [C: 032] Add CollapseToFrom/To to Selection API [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166579 (owner: 10Esanders) [19:29:43] (03CR) 10Catrope: [C: 032] Don't force focus after history action [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166424 (owner: 10Esanders) [19:31:35] (03Merged) 10jenkins-bot: Add CollapseToFrom/To to Selection API [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166579 (owner: 10Esanders) [19:32:03] (03Merged) 10jenkins-bot: Fix typo in getSelectionBoundingRect [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166591 (owner: 10Esanders) [19:32:05] (03Merged) 10jenkins-bot: Don't force focus after history action [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166424 (owner: 10Esanders) [19:32:12] (03CR) 10Catrope: [C: 032] More flexible selection reporting in the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166443 (owner: 10Esanders) [19:32:37] (03CR) 10Catrope: [C: 032] Add content-heavy table to demo HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166444 (owner: 10Esanders) [19:34:27] (03Merged) 10jenkins-bot: More flexible selection reporting in the debug bar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166443 (owner: 10Esanders) [19:34:29] (03Merged) 10jenkins-bot: Add content-heavy table to demo HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166444 (owner: 10Esanders) [19:57:17] MatmaRex: I responded to your questions: http://etherpad.wikimedia.org/p/OOUIPHP [20:07:25] (03CR) 10Jforrester: [C: 031] Followup 1fc13cc: fix JS errors caused by incorrect context binding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166628 (https://bugzilla.wikimedia.org/71997) (owner: 10Catrope) [20:07:32] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249#c4 (10Alex Monk) (In reply to James Forrester from comment #3) > (In reply to Alex Monk from comment #1) > > Currently the redirect section of the page settings dialog and the templa... [20:11:15] TrevorParscal, when you open a dialog with some config attached, where does this data go -- to the initialize method? re this in the docs -- windowManager.openWindow( myDialog, { url: 'http://www.mediawiki.org' } ); [20:11:31] mooeypoo: Passed into the setup function, I think [20:12:08] right, initialize is once per session.. that makes sense. [20:12:24] yep [20:13:49] mooeypoo: setup [20:13:54] and also ready [20:14:00] ah, got it [20:14:01] thanks1 [20:14:02] ! [20:14:06] closeWindow( data ) goes to hold and teardown [20:14:26] initialize is one time, setup/ready/hold/teardown happen each open/close cycle [20:14:50] https://www.mediawiki.org/wiki/OOjs_UI [20:14:55] actual documentation as of last week [20:19:19] oooo [20:19:32] wait, I've been looking at that page [20:20:06] oh, TrevorParscal I think there's a missing ", this );" at the end of MyDialog.prototype.getSetupProcess = function ( data ) { [20:20:37] .next( function () { ... }, this ) <-- the example didn't work for me, and I saw that the 'this' exists in VE's use of the dialog [20:20:37] in the example? [20:20:49] yeah, possibly, I admit I haven't run that code [20:20:57] yeah, in etSetupProcess [20:21:02] getSetupProcess [20:21:43] oh, yeah there's a way to bind this, but I should probably fix that... [20:21:49] it kept telling me it doesn't understand "this.$element" and this.panels (that were set in initialization). Adding "this" fixed it, though it doesn't have $.proxy or bind, so I wasn't sure what went on there... I guess .next() assumes a second variable for context? [20:22:19] Yes [20:22:24] It's .next( func, context ) [20:22:34] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3 ]The context menus for Categories are not closing - 10https://bugzilla.wikimedia.org/72052 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16766 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16766&action=e... [20:22:46] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3 ]The context menus for Categories are appearing in an incoorect position and also not closing - 10https://bugzilla.wikimedia.org/72052 (10Rummana Yasmeen) [20:22:58] ah, okay. I was looking for it, but next() appears as 1 variable function in jquery docs [20:23:08] http://api.jquery.com/next/ [20:23:42] mooeypoo: Are you still working on https://gerrit.wikimedia.org/r/#/c/166279/1 or shall I just merge it? [20:23:55] mooeypoo: Oh, yeah this isn't jQuery's next() [20:24:00] This is a ui.Process object as opposed to a jQuery object [20:24:05] Yeah exactly [20:24:08] oh [20:24:10] 'next' is a common function name, it turns out [20:24:14] ha, okay, that explains that [20:24:16] https://doc.wikimedia.org/oojs-ui/master/#!/api/OO.ui.Process [20:24:19] #next [20:24:24] :) [20:24:33] RoanKattouw, oh, I started to and got distracted once more with the templatedata dialog when I got into ooui [20:24:45] It's OK [20:24:58] The only big thing that's bad in there is the indicator being in the wrong place in RTL, though [20:25:07] * RoanKattouw tests [20:25:09] the rest should be okay -- and I htink the "bigger" problem is generalized? [20:25:22] as in, the placement of the popup [20:25:24] (03PS2) 10Catrope: Correctly place CategoryPopupWidget in LTR and RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 (https://bugzilla.wikimedia.org/72052) (owner: 10Mooeypoo) [20:26:15] wtf it's still in the wrong place for me even with your code [20:26:37] Oh I know why [20:26:41] You're fixing left but not top [20:26:43] * RoanKattouw fixes [20:26:46] top? why top? [20:27:03] wait, that worked for me before.. hmm. [20:27:23] * RoanKattouw updates his MW core just to be sure [20:28:48] top shouldn't be different between rtl and ltr [20:29:31] holy crap, you're right [20:29:46] .. it wasn't like that before, though. did we change anything again? this is weird. [20:30:03] No this is because Krenair and I moved oo-ui-window-overlay [20:30:17] And as ryasmeen points out it also causes the popup to not close [20:30:20] Unless you click *outside* the dialog [20:30:34] interesting [20:31:07] Ah, it happens in LTR too now [20:31:51] RoanKattouw, is this a bug inside the calculation (not calculating top right) or a bug with the oo-ui-window-overlay move that is fixed regardless? [20:32:20] RoanKattouw, As in, I can probably recalculate the top, but if you're going to fix things with oo-ui-window-overlay, it might clash [20:32:39] I'm thinking [20:33:13] I will fix the top calculation [20:33:32] But I also need to come up with something for the mousedown binding problem [20:34:02] * mooeypoo nods [20:34:14] The reason the popup isn't closing is because it's listening for mousedown on its document, and mousedowns inside the iframe go to a different document [20:34:18] * RoanKattouw throws things at iframes [20:34:24] heh [20:34:35] Can you propogate it? [20:35:01] Can the parent document listen ot a click event in the frame, then emit its own event ? [20:35:03] (03CR) 10SuchetaG: [C: 032] Followup 1fc13cc: fix JS errors caused by incorrect context binding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166628 (https://bugzilla.wikimedia.org/71997) (owner: 10Catrope) [20:35:39] TrevorParscal: thanks [20:36:25] (03Merged) 10jenkins-bot: Followup 1fc13cc: fix JS errors caused by incorrect context binding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166628 (https://bugzilla.wikimedia.org/71997) (owner: 10Catrope) [20:36:32] mooeypoo: No I think I just need to be listening to a different document; that's what we were doing before [20:36:48] Or just override the popup's $container to be the iframe's body, that would fix all of our problems at once [20:36:50] Or to both documents [20:37:19] ah, yes, though the click event is probably something you need to listen to all over, no? [20:37:21] both documents? [20:37:45] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The context menus for Categories are appearing in an incorrect position and also not closing - 10https://bugzilla.wikimedia.org/72052 (10James Forrester) [20:37:47] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] The context menus for Categories are appearing in an incoorect position and also not closing - 10https://bugzilla.wikimedia.org/72052 (10James Forrester) p:5Unprio>3High a:3Moriel Schottlender [20:38:02] We didn't use to listen to the outer document before [20:38:31] Oh, so clicking outside the dialog wouldn't close the popup? [20:38:37] I guess that makes sense [20:38:53] Yeah it makes sense in some twisted iframe-y sort of way [20:39:02] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf4] “Uncaught TypeError: undefined is not a function” when Citation dialog opens - 10https://bugzilla.wikimedia.org/71997 (10James Forrester) 5PATC>3RESO/FIX p:5Unprio>3Highes s:5normal>3major a:3Roan Kattouw [20:50:02] (03CR) 10Jforrester: [C: 031] ButtonWidget: Fix titled button [oojs/ui] - 10https://gerrit.wikimedia.org/r/166214 (owner: 10Bartosz Dziewoński) [20:51:08] RoanKattouw: :-) [20:53:50] (03Abandoned) 10Jforrester: Jenkins job validation (DO NOT SUBMIT) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [20:53:59] (03Abandoned) 10Jforrester: Jenkins job validation (DO NOT SUBMIT) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/163846 (owner: 10Hashar) [21:12:47] TrevorParscal: I need your brain [21:12:53] yo [21:13:03] So, you remember us moving oo-ui-window-overlay? [21:13:08] That was a great idea for textbox dropdowns [21:13:14] It was less of a great idea for popups [21:13:42] Problem 1 is it broke positioning, but I intend on fixing that by putting positioning in PopupWidget itself [21:14:01] It's stupid that every user of PopupWidget has its own, different, special snowflake logic for positioning popups, that should just be core functionality [21:14:20] Problem 2 is nastier: it broke autoClose [21:14:40] because autoClose works by listening for mousedown on this.getElementDocument() [21:15:09] which for those popups is now the main document, because oo-ui-window-overlay moved from the iframe to the main document [21:15:27] So now we are in a situation where clicking away in the dialog doesn't close the popup, but clicking on the click block around the dialog does [21:15:30] it used to be the reverse [21:15:45] I think I have a handle on #1 but I was wondering if you had any great ideas for #2 [21:15:46] yeah [21:16:08] let me think [21:16:10] I also tried $overlay: this.$( 'body' ) as a cop-out but that has z-index problems, so I'd have to have a real overlay inside the iframe [21:16:18] in addition to the one outside the iframe [21:16:29] overlay-overlay-overlay? [21:16:30] lol [21:18:05] so, with autoClose [21:18:20] the problem is that we are capturing events at the document level, right? [21:24:05] Yeah, kind of [21:26:26] so, in the case where we need the events in the overlay to not be captured, we would need to add logic to that handler which notices that the event's e.target caem from a place not "really" considered to be part of the root [21:27:01] Well, here's the thing [21:27:07] Even if we capture these events at the overlay level [21:27:16] The iframe is its own little world [21:27:28] A mousedown event inside the iframe will bubble up to the iframe's document, then stop [21:27:42] it will never be observed by anything in the main document [21:27:48] Hmm, no I guess that isn't true [21:27:57] The overlay will be the first to receive it because it's on top of the iframe [21:28:27] I don't know -- I guess I'd have to check how these events actually get emitted [21:28:43] yeah, and the listener for autoClose which is capturing just needs to pass on events originating from such an overlay [21:29:15] Well, but hold on [21:29:19] Which overlay are you talking about? [21:29:30] The current one which is in the main document, or the hypothetical one that's in the iframe? [21:31:36] the latter [21:31:55] Well if I have that overlay, I'll just put the popup in there and all my problems go awa [21:31:57] y [21:34:45] OK so maybe I'll just do that? Create yet another overlay, and put popup-like stuff in there while dropdown-like stuff goes in the other one? [21:35:25] the overlay overlay [21:35:27] :) [21:38:49] won't that make at least one of them an underlay? [21:40:18] and overlay doesn't nessecarily block clicks though [21:40:29] it's abs positioned, but like 0x0 in the top left or whatever [21:43:07] Yeah true [21:43:13] I'll just listen for mousedown on document as usual [21:43:25] In fact I won't even touch that code [22:08:25] 3VisualEditor / 3Editing Tools: VisualEditor: Make it easy to identify the file type (e.g., .png versus .svg) when adding an image - 10https://bugzilla.wikimedia.org/72061 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None Commons has many identical images in multiple formats, especially combinations... [22:12:09] 3VisualEditor / 3Editing Tools: VisualEditor: Make it easy to identify the file type (e.g., .png versus .svg) when adding an image - 10https://bugzilla.wikimedia.org/72061#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal a:3Moriel Schottlender Yes, this is part of Moriel's work on the new media... [22:24:25] 3MediaWiki extensions / 3TemplateData: TemplateData: Have the GUI editor warn the user if a related page already contains a TemplateData block - 10https://bugzilla.wikimedia.org/72062 (10WhatamIdoing) 3NEW p:3Unprio s:3enhanc a:3None This is Salix alba's idea about how to deal with the problem of mu... [22:26:07] 3MediaWiki extensions / 3TemplateData: TemplateData: Have the GUI editor warn the user if a related page already contains a TemplateData block - 10https://bugzilla.wikimedia.org/72062 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [23:33:09] 3VisualEditor / 3Language: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - 10https://bugzilla.wikimedia.org/67367#c1 (10James Forrester) a:3Bartosz Dziewoński Is this now fixed, given that we've k... [23:34:07] 3VisualEditor / 3Language: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - 10https://bugzilla.wikimedia.org/67367#c2 (10Roan Kattouw) (In reply to James Forrester from comment #1) > Is this now fixe... [23:34:22] 3VisualEditor / 3Language: VisualEditor: Pawning prevention code in ve.ce.Surface sometimes prevents some legit keypresses from being handled (e.g. typing “ą” in Polish on a new line) - 10https://bugzilla.wikimedia.org/67367#c3 (10Roan Kattouw) (In reply to Roan Kattouw from comment #2) > (In reply to James... [23:34:53] 3VisualEditor / 3ContentEditable: VisualEditor: Backwards cursoring of an image inside an image's caption selects the sub-image, not the main image (and then breaks nastily) - 10https://bugzilla.wikimedia.org/62395#c1 (10James Forrester) 5ASSI>3RESO/FIX This was fixed a while ago by Ed's selection/node w... [23:39:22] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression wmf16] Cannot scroll the link suggestions inside link inspector - 10https://bugzilla.wikimedia.org/69038 (10James Forrester) [23:43:53] 3VisualEditor / 3MediaWiki integration: VisualEditor: Flaggedrevs edit notice saying that changes must be reviewed appears even when the user has autoreview rights - 10https://bugzilla.wikimedia.org/58057#c9 (10James Forrester) 5UNCO>3RESO/WOR Marking as WFM given lack of replication steps. [23:47:20] (03PS3) 10Catrope: Correctly place CategoryPopupWidget in RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 (https://bugzilla.wikimedia.org/72052) (owner: 10Mooeypoo) [23:47:37] 3VisualEditor / 3MediaWiki integration: VisualEditor: Reference should use system messages to work out their rendering style (e.g. 1.0, 1.1 / a,b,c) - 10https://bugzilla.wikimedia.org/49346#c3 (10James Forrester) I74d4878 will let us fix this. [23:48:29] (03PS4) 10Catrope: Correctly place CategoryPopupWidget in RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 (https://bugzilla.wikimedia.org/72052) (owner: 10Mooeypoo) [23:48:35] (03CR) 10jenkins-bot: [V: 04-1] Correctly place CategoryPopupWidget in RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 (https://bugzilla.wikimedia.org/72052) (owner: 10Mooeypoo) [23:49:52] (03PS5) 10Catrope: Correctly place CategoryPopupWidget in RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 (https://bugzilla.wikimedia.org/72052) (owner: 10Mooeypoo) [23:49:55] 3VisualEditor / 3MediaWiki integration: VisualEditor: The Help menu does not scroll on small screens while using Monobook - 10https://bugzilla.wikimedia.org/67370#c1 (10James Forrester) 5ASSI>3RESO/FIX a:3Trevor Parscal This was fixed a while ago. [23:50:34] (03CR) 10Catrope: [C: 032] Correctly place CategoryPopupWidget in RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 (https://bugzilla.wikimedia.org/72052) (owner: 10Mooeypoo) [23:50:51] (03PS6) 10Catrope: Correctly place CategoryPopupWidget in RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 (owner: 10Mooeypoo) [23:50:59] (03CR) 10Catrope: [C: 032] Correctly place CategoryPopupWidget in RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 (owner: 10Mooeypoo) [23:51:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct - 10https://bugzilla.wikimedia.org/66885 (10James Forrester) a:5Ed Sanders>3Alex Monk [23:52:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Sometimes the HotCat gadget appears at the top of the CE surface - 10https://bugzilla.wikimedia.org/43335 (10James Forrester) a:3Alex Monk [23:52:34] (03Merged) 10jenkins-bot: Correctly place CategoryPopupWidget in RTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/166279 (owner: 10Mooeypoo) [23:55:08] TrevorParscal: OK so I wrote all the inner-overlay stuff and it's working fine but I've decided that it's the wrong way to do things [23:55:17] yeah? [23:55:20] I want popups to be able to protrude out. If dropdowns can do that, popups should too [23:55:39] So I'm saving the inner-overlay code (calling it "underlay") and starting from scratch on a different approach [23:55:49] but they have to sync with the scroll of the document, no? [23:56:02] I mean, that seems /possible/ [23:56:15] Yeah isn't oo-ui-window-overlay position: fixed? [23:56:38] Or do you mean scrolling inside the iframe? [23:59:07] I'm thinking of handling this all with a mixin [23:59:15] To be shared between TextInputMenuWidget and PopupWidget [23:59:31] I don't know what I'll call it yet, but the idea is that you can mix in the behavior of positioning against an element