[00:00:15] So your wakeup time shifted 13 hours in one day? [00:00:24] That's more than the time difference between India and SF [00:00:35] I don't really calculate anymore [00:00:40] Were you practicing for beating jetlag? :P [00:01:18] I am actually intrigues to see how jetlag is going to affect me this time [00:01:38] *intrigued [00:01:57] Well as you requested I will be keeping you awake [00:01:59] (and active) [00:02:52] Yes! Seafood! [00:03:16] Yes! [00:03:22] Yes! [00:03:27] oh.. sorry, just wanted to join in. [00:03:29] ...they also have non-seafood there, but if you get excited about seafood, then yes, seafood! [00:03:42] mooeypoo, Please do. [00:03:56] mooeypoo will be leading me from restaurant to restaurant the week after next actually [00:04:01] * mooeypoo nods [00:04:07] The week after I do the same to sucheta [00:04:46] We're switching hosting roles [00:05:16] Yup [00:06:31] The universe gets a shade brighter when I think about good food. Oh joy [00:06:34] mooeypoo: BTW just to confirm I will be showing up at JFK at 3:27pm on November 8th with the plan of staying at your place that night [00:06:43] * mooeypoo nods [00:06:56] Do you need me to pick you up from JFK ? [00:06:56] So could you send me transit directions or an address or something (in private obviously) some time before that? [00:07:01] yup [00:08:34] Maybe mooeypoo should make a trip to Boston as well [00:08:46] ^_^ [00:09:58] When are you in Boston sucheta ? [00:10:09] Nov 7 - Nov 23 [00:10:26] Nov 8 - Nov 23 [00:10:52] ooo [00:10:54] I was thinking of Boltbussing up for a day [00:11:01] That's when Roan's here. Partially [00:11:01] Like, maybe Nov 12 or 13 [00:11:25] But I have been lazy about asking people if I can crash [00:14:41] I should send out an email to all our Boston folks; add RoanKattouw and mooeypoo to the list; figure out a date when we could have some wmf fun [00:14:59] Yeah [00:15:40] That would be cool [00:15:52] I'll do that [00:16:27] RoanKattouw, so for https://bugzilla.wikimedia.org/show_bug.cgi?id=63341 I'm wondering if we actually just want to remove the transclusion node if it contains only empty content parts [00:16:34] I just messaged a mutual friend of ours in Boston; if the response is good then I think I'll have crash plans for both myself and mooeypoo [00:16:50] ooh [00:16:54] Boston is beautiful [00:17:02] also, sucheta, it ALSO has seafood! [00:17:18] Krenair: My idea there was that such transclusions should not be insertable from scratch, but if you apply changes it should remove the node [00:17:27] ok [00:17:46] Krenair: I think that's the same as what you already did for when there are 0 parts? [00:18:14] to make it remove an existing node like that... [00:18:59] It's similar to inspectors where, say, setting a comment's contents to empty removes the comment [00:19:28] MWTransclusionModel#updateTransclusionNode removes if getPlainObject returns null. getPlainObject will return null if all parts serialize to undefined (or there were no parts). could make an empty content part serialize to undefined? [00:19:41] I guess so? [00:19:48] But why would anything ever serialize to undefined? [00:19:55] Seems like a strange value to unserialize to [00:19:58] yeah... [00:20:30] mooeypoo: Alternatively, if you're also interested in going to Boston, then car rental might be cheaper than Boltbus and then we wouldn't have to stay the night [00:21:37] template placeholders do that, actually [00:22:10] Ooh rigth [00:22:13] That's clever [00:22:34] Yeah in that spirit, maybe templates with no params, and content parts with no content should serialize to undefined? [00:22:43] (MWTransclusionPartModel#serialize returns undefined, and template placeholders don't override this) [00:22:45] Sorry, not templates with no params obviously [00:22:47] Ignore that [00:22:58] :) [00:22:58] (You need to be able to do {{done}}) [00:23:27] or we can make getPlainObject check for serialize returning '' [00:23:40] Yes [00:23:43] That would probably be better [00:24:33] as for preventing you from inserting a new transclusion containing only empty content parts, by disabling the 'Insert' button... [00:24:35] (03PS3) 10Catrope: Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 [00:24:57] Wouldn't that all fall in the same category? [00:25:21] The parts all serialize to '' or undefined, so we both disable insert, and make apply changes remove [00:25:28] I feel like the former was done like last week? [00:25:52] (03CR) 10jenkins-bot: [V: 04-1] Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope) [00:26:43] I was only checking number of parts [00:29:01] and wouldn't we need to check this on every content part input change..? [00:31:06] Urgh I guess so [00:31:18] Which I guess we don't currently have the event infrastructure for? [00:32:37] I don't think so [01:05:58] (03PS4) 10Jforrester: [WIP] MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://bugzilla.wikimedia.org/49452) [01:07:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] MWHeading: Don't put self in output if contents are blank or whitespace [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/162310 (https://bugzilla.wikimedia.org/49452) (owner: 10Jforrester) [01:08:38] 3VisualEditor / 3Editing Tools: VisualEditor: Remove transclusion node if we were just going to set it to empty content - 10https://bugzilla.wikimedia.org/63341 (10Alex Monk) [01:10:20] (03CR) 10Catrope: [C: 04-1] "Code looks good, but:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders) [01:10:35] (03PS1) 10Alex Monk: MWTransclusionModel: Exclude parts serialising to '' from the plain object [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169638 (https://bugzilla.wikimedia.org/63341) [01:16:55] (03CR) 10Catrope: [C: 04-1] "I present to you, the most nitpicky -1 of all time" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG) [01:20:24] (03PS4) 10Catrope: Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 [01:46:00] (03PS1) 10Alex Monk: Remove more references to ve.bind [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) [02:24:53] 3VisualEditor / 3Technical Debt: VisualEditor: Remove ve.bind() - 10https://bugzilla.wikimedia.org/72156 (10James Forrester) [02:42:08] 3VisualEditor / 3Editing Tools: In HTML+RDFa DOM, make the 'params' block give a 'normalised' version of the parameter name (like done for template) - 10https://bugzilla.wikimedia.org/67657 (10James Forrester) a:3Alex Monk [02:45:42] 3VisualEditor / 3MediaWiki integration: VisualEditor: When user is saving a page subsequently deleted after they started editing, show them - 10https://bugzilla.wikimedia.org/52073 (10James Forrester) a:3Alex Monk [02:46:54] 3VisualEditor / 3MediaWiki integration: VisualEditor: Invocation of "lastmodifiedat" message is not updated when page is saved - 10https://bugzilla.wikimedia.org/52403 (10James Forrester) a:3Alex Monk [02:47:40] 3VisualEditor / 3MediaWiki integration: VisualEditor: When editing a file/category page, show the non-page composite components outside the VE surface in their "normal" place - 10https://bugzilla.wikimedia.org/56289 (10James Forrester) a:3Alex Monk [02:48:55] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/123875/2 [02:51:38] 3VisualEditor / 3MediaWiki integration: VisualEditor: Implement some form of auto-save - 10https://bugzilla.wikimedia.org/55370 (10James Forrester) [02:51:40] 3VisualEditor / 3Data Model: VisualEditor: Be able to serialise the linear model - 10https://bugzilla.wikimedia.org/72658 (10James Forrester) 3ASSI p:3Unprio s:3enhanc a:3None For bug 55370 and others. [02:51:53] 3VisualEditor / 3Data Model: VisualEditor: Be able to serialise the linear model - 10https://bugzilla.wikimedia.org/72658 (10James Forrester) p:5Unprio>3High [03:04:09] 3VisualEditor / 3Editing Tools: VisualEditor: Create dedicated input methods for transclusion parameters (using "Param#type" from TemplateData) - 10https://bugzilla.wikimedia.org/53613 (10Alex Monk) a:3Alex Monk [03:37:05] (03CR) 10Krinkle: [C: 032] Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope) [03:38:18] (03Merged) 10jenkins-bot: Convince jsduck mw.Title exists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169617 (owner: 10Catrope) [03:49:01] (03CR) 10Krinkle: [C: 04-1] Remove more references to ve.bind (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) (owner: 10Alex Monk) [04:26:09] 3VisualEditor / 3ContentEditable: VisualEditor: Applying a rich annotation to an image causes inspector to open then close quickly in Chrome; die in Firefox - 10https://bugzilla.wikimedia.org/72431#c3 (10Ritu Swain) (In reply to James Forrester from comment #2) > I believe that this is describing intentional... [04:27:39] 3VisualEditor / 3ContentEditable: VisualEditor: Applying a rich annotation to an image causes inspector to open then close quickly in Chrome; die in Firefox - 10https://bugzilla.wikimedia.org/72431#c4 (10Ritu Swain) Created attachment 16939 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16939&action=... [04:49:55] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660 (10Ritu Swain) 3UNCO p:3Unprio s:3normal a:3None Created attachment 16940 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16940&actio... [04:50:08] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660 (10Ritu Swain) [04:50:23] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660#c1 (10Ritu Swain) Also see 72431. [04:50:52] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660#c2 (10Ritu Swain) (In reply to Ritu Swain from comment #1) > Also see 72431. https://bugzilla.wikimedia.org/show_bug.cgi?id=72431 [04:51:37] 3VisualEditor / 3ContentEditable: VisualEditor: Applying a rich annotation to an image causes inspector to open then close quickly in Chrome; die in Firefox - 10https://bugzilla.wikimedia.org/72431#c5 (10Ritu Swain) Also see 72660, https://bugzilla.wikimedia.org/show_bug.cgi?id=72660 [05:58:54] (03PS6) 10Divec: WIP: Show entire expandable call tree in ve.Filibuster [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167021 [06:48:02] (03PS5) 10Mooeypoo: [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [06:48:05] (03CR) 10jenkins-bot: [V: 04-1] [Extremely WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [07:45:56] (03PS12) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) [08:18:44] (03PS13) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) [09:03:08] (03CR) 10Esanders: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [09:04:33] (03CR) 10Esanders: [C: 032] Apex, MediaWiki themes: Move colour definitions into LESS variables [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [09:06:34] (03Merged) 10jenkins-bot: Apex, MediaWiki themes: Move colour definitions into LESS variables [oojs/ui] - 10https://gerrit.wikimedia.org/r/164389 (owner: 10Jforrester) [09:07:26] (03CR) 10Esanders: [C: 031] "LGTM but Roan doesn't want to merge yet?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [09:08:19] (03CR) 10Esanders: Factor out class <-> attribute mappings from BlockImageNode (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders) [09:14:10] 3VisualEditor: make page titles editable - 10https://bugzilla.wikimedia.org/72665 (10Martijn Hoekstra) 3NEW p:3Unprio s:3enhanc a:3None An often encountered hurdle for new editors is that they can't find out how to move a page. Generally they ask how to "change the title". Apparently - and understandab... [09:17:21] (03PS1) 10Esanders: Provide a generic mechanism for mapping classes to attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169661 [09:20:15] (03PS2) 10Esanders: Provide a generic mechanism for mapping classes to attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169661 [09:25:13] (03PS6) 10Esanders: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 [09:25:15] (03PS9) 10Esanders: Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 [09:25:17] (03PS3) 10Esanders: Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 [09:25:21] (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [09:25:25] (03CR) 10jenkins-bot: [V: 04-1] Files and messages for table editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [09:26:28] (03CR) 10jenkins-bot: [V: 04-1] Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders) [09:28:39] (03CR) 10Esanders: [C: 04-1] "comment on PS11 (ve.ce.surface.js)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [09:37:25] (03CR) 10Esanders: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [09:41:07] (03CR) 10Esanders: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [09:43:02] (03PS1) 10Amire80: Disable two failing scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169664 [09:44:56] (03PS2) 10Zfilipin: [BrowserTest] Disable two failing scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169664 (owner: 10Amire80) [09:45:10] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Disable two failing scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169664 (owner: 10Amire80) [09:46:24] (03Merged) 10jenkins-bot: [BrowserTest] Disable two failing scenarios [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169664 (owner: 10Amire80) [10:21:39] Hello! [10:21:41] :) [10:22:00] Guess who can't get Visual Editor to work. [10:23:06] If there is anyone around with some advice for further debugging, that would be cool and it would WMDE staff happy because it's for the internal wiki. [10:24:00] I did a successful edit yesterday, but it no longer works now. [10:35:06] (Alternatively, thanks for pointing me at any sort of help place which is not the talk page with dozens ofquestions and no answers. ;) [10:50:26] Hi [10:50:34] Silke_WMDE, what's the problem? [10:54:35] hi edsanders. [10:55:19] the editor tries to load but fails. I read the debugging hints and the [10:55:30] curl -L http://127.0.0.1:8142/localhost/Hauptseite fails [10:55:32] (03CR) 10Zfilipin: [BrowserTest] WIP adding cases to test other options under Page Settings to options.feature (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169251 (owner: 10Ryasmeen) [10:55:56] it says API response is missing query for: Hauptseite [10:56:28] it's a private wiki, parsoid is running on the same server as the wiki [10:56:40] the cookie setting is turned on [10:57:08] 3VisualEditor / 3Language: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - 10https://bugzilla.wikimedia.org/33126 (10Amir E. Aharoni) [10:57:10] 3VisualEditor / 3MediaWiki integration: VisualEditor: A template editing bubble appears off-screen for a left-aligned infobox in the Hebrew Wikipedia - 10https://bugzilla.wikimedia.org/72668 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None To reproduce: 1. Edit the Hebrew Wikipedia article about... [11:01:38] 3VisualEditor / 3Editing Tools: VisualEditor: automatically convert URLs to readable links - 10https://bugzilla.wikimedia.org/65540#c2 (10marielle.volz) This could potentially inform the VE UI for citoid; I.e. we could have have one reference dialog, (i.e. the basic reference dialog) and then if a user past... [11:01:39] right now, I'm reading the parsoid talk page to make the api accessible on localhost [11:04:49] hmm [11:05:20] is the parsoid web service working? [11:05:40] yes [11:06:16] erm... I think so. [11:08:22] edsanders: how do I check that? parsoid is running, but what web service? [11:08:48] I think the default is port 8000 [11:08:52] localhost:8000 [11:12:44] ah. so no. not working [11:15:19] edsanders: I followed the Ubuntu instructions, so I'm on port 8142 -> if that's the thing we are talking about. [11:15:34] and that one is working [11:22:58] edsanders: parsoid log tells me that it parses the page I'm trying to edit. I see bits of the content so it can access the wiki at least. [11:23:32] sounds promising [11:23:51] what is the exact error message? [11:25:56] I don't get any error message. The last thing is "[info][localhost/Benutzer:Silke_Meyer/Notizen?oldid=75607] completed parsing in 65 ms" [11:26:30] then the editor loads and loads but no more messages [12:26:17] Silke_WMDE: were you able to get it working? if not, are there any javascript errors reported in the browser when you try to edit a page? [12:29:00] burntsushi__: yes. "TypeError: $(...).inputAutoExpand is not a function" (load.php:7) [12:31:40] Silke_WMDE: that's strange. i haven't seen that one before. what version of mediawiki/VE are you running? [12:32:00] (03PS58) 10Paladox: WikiEditor: Convert .css to .less and also fixes SVG issues. [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/151203 (https://bugzilla.wikimedia.org/35342) [12:34:47] burntsushi__: mediawiki 1.23.5 (tag) and VE REL1_23 branch [12:36:13] Silke_WMDE: ah, yeah, i've never been able to get REL1_23 working. i'm running everything on 1.25wmf3. [12:36:22] lol [12:36:27] (i try to keep pace with Wikipedia) [12:37:06] ok, so maybe I'll switch versions, too. [12:37:27] (I did ONE edit yesterday, though.) [12:38:26] 3VisualEditor / 3Language: VisualEditor: Support for right-to-left (rtl) / bidirectional content (tracking) - 10https://bugzilla.wikimedia.org/33126 (10Amir E. Aharoni) [12:38:28] 3VisualEditor / 3Editing Tools: VisualEditor: Edit notices popup shows out of screen in RTL - 10https://bugzilla.wikimedia.org/72673 (10Amir E. Aharoni) 3NEW p:3Unprio s:3normal a:3None Created attachment 16941 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16941&action=edit a screenshot with... [12:57:05] (03PS1) 10Mvolz: Restructured url endpoint calls, fixed unshorten [services/citoid] - 10https://gerrit.wikimedia.org/r/169690 [13:37:09] "non-standard systems like Windows or Debian" is an interesting wording btw. [13:40:20] (03PS1) 10Esanders: Replace native range rectangle hacks with RangeFix library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 [13:43:08] (03PS2) 10Esanders: Replace native range rectangle hacks with RangeFix library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 [13:49:29] (03CR) 10Esanders: "Maybe I should call this library Rangier?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders) [14:13:07] (03PS2) 10Alex Monk: Remove more references to ve.bind [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169644 (https://bugzilla.wikimedia.org/72156) [15:45:54] hello. is anybody around to help me add a character to a special character list? [15:51:17] Elitre, hi [15:52:43] hi :) [15:53:55] Isn't that a case of simply modifying MediaWiki:MediaWiki:Visualeditor-specialcharinspector-characterlist-insert? (I haven't had to do this myself before...) [15:54:23] I must have done something horribly wrong at https://de.wikipedia.org/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert though... [15:55:59] I mean, it works, but the code doesn't look right. [15:58:02] well, if it works... [15:59:47] I'm sure James_F|Away will take a look when he's back and if he needs to change anything there, he'll scold me in the edit summary :) [16:15:44] * James_F waves. [16:16:06] Elitre: Looks fine from my POV… what's wrong about it? [16:30:45] Corruption alert: visualeditor-needcheck on nowiki: https://no.wikipedia.org/?diff=13487851 [16:30:45] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108607536 [16:30:45] Corruption alert: visualeditor-needcheck on frwiki: https://fr.wikipedia.org/?diff=108632549 [16:30:45] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33113171 [16:30:45] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33113246 [16:30:46] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33114185 [16:30:46] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33114204 [16:30:47] Corruption alert: visualeditor-needcheck on zhwiki: https://zh.wikipedia.org/?diff=33114220 [16:30:47] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66480316 [16:30:48] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=66484569 [16:30:48] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40400835 [16:30:49] Corruption alert: visualeditor-needcheck on ptwiki: https://pt.wikipedia.org/?diff=40406528 [16:31:14] * James_F sighs. [16:33:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Provide a way to move pages through interacting with the displayed title - 10https://bugzilla.wikimedia.org/72665#c1 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal Hmm. I like this idea. Could get a bit complicated where "sometimes" it is moving... [16:34:23] that first ptwiki one with s is strange [16:34:56] You mean "[http://www.centrofic.org/intencionalidade/ |Intencionalidade – John Searle] - Edição brasileira: Intencionalidade, São Paulo, Mar­tins Fontes, 1995. Estudo: F. Recanati, Les enoncés performatifs, Éd. de Minuit, 1983."? [16:35:16] * Elitre pats James_F back. [16:35:34] It looks to me like they pasted in some content (s are a clue), and that content broke somehow? [16:35:45] Or they literally pasted in some pre-written wikitext. [16:36:30] James_F: https://de.wikipedia.org/w/index.php?title=MediaWiki%3AVisualeditor-specialcharinspector-characterlist-insert&diff=135331574&oldid=131793525 looked "odd" to me. but if you say it's fine, it's fine. [16:37:23] 3VisualEditor / 3Editing Tools: VisualEditor: Edit notices popup shows out of screen in RTL - 10https://bugzilla.wikimedia.org/72673#c1 (10etonkovidova) p:5Unprio>3Normal Confirmed on https://he.wikipedia.org/w/index.php?title=ASCII&oldid=15904477&veaction=edit Both 'Page options' and 'Help' boxes are... [16:37:32] Elitre: Oh, that's just the JSON editor being fussy. [16:37:47] Elitre: We should probably investigate and fix, I suppose. [16:37:50] * James_F sighs. [16:39:29] it was too good to be true :( [16:44:04] Elitre: It's fine, just clunky. [16:55:05] (03PS14) 10Divec: Make setSelection emit activeAnnotationChange if continuation unicorns may be needed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) [17:34:26] (03CR) 10Esanders: "Bill and Ted guessed my patch number." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders) [17:36:40] edsanders: :-) [17:37:23] 3VisualEditor / 3MediaWiki integration: VisualEditor: Category input box is too small (sometimes) - 10https://bugzilla.wikimedia.org/69574 (10James Forrester) 5NEW>3ASSI p:5Unprio>3Normal [17:40:16] (03CR) 10Divec: "Greatly improves readability :-)" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders) [17:50:51] Krinkle|detached: Do we still need @static @inheritable for static properties? [17:50:56] (03CR) 10Catrope: [C: 032] Provide a generic mechanism for mapping classes to attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169661 (owner: 10Esanders) [17:52:49] (03Merged) 10jenkins-bot: Provide a generic mechanism for mapping classes to attributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169661 (owner: 10Esanders) [17:53:31] (03CR) 10Catrope: [C: 04-1] Replace native range rectangle hacks with RangeFix library (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders) [18:04:25] 3VisualEditor / 3ContentEditable: VisualEditor:[Regression]clicking on an image with wikilink , opens up link inspector - 10https://bugzilla.wikimedia.org/72660#c3 (10etonkovidova) 5UNCO>3NEW p:5Unprio>3Normal Confirmed that the bug exists in betalabs and test2. [18:04:25] 3VisualEditor: Backspace key at end of document moves the cursor up a line - 10https://bugzilla.wikimedia.org/72689#c1 (10Adam Wight) Correction to the previous comment: this is the key I'm talking about. [18:04:25] 3VisualEditor: Delete key at end of document moves the cursor up a line - 10https://bugzilla.wikimedia.org/72689 (10Adam Wight) 3NEW p:3Unprio s:3normal a:3None * Document contains lots of text. The last two lines are a heading, then one line of body. * Place the cursor at the end of the final line, a... [18:04:27] 3VisualEditor: Forward delete key does crazy things - 10https://bugzilla.wikimedia.org/72690 (10Adam Wight) 3NEW p:3Unprio s:3major a:3None Pressing forward delete start randomly undoing my changes (with no way to redo them) and causing other bad crap to happen. My document is trashed... Hence I'm ma... [18:04:28] 3VisualEditor: Backspace key at end of document moves the cursor up a line - 10https://bugzilla.wikimedia.org/72689 (10Adam Wight) [18:10:19] (03CR) 10Catrope: "Removing -2 because wmf6 branch has been cut now" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [18:10:49] (03CR) 10Catrope: [BREAKING CHANGE] Unisolate dialogs (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [18:11:34] (03CR) 10Catrope: [BREAKING CHANGE] Unisolate dialogs (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [18:12:06] (03PS6) 10Catrope: Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [18:12:34] (03PS4) 10Catrope: Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG) [18:12:50] (03CR) 10Catrope: [C: 032] Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [18:13:12] (03CR) 10Esanders: [C: 04-1] "same as 13" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168327 (https://bugzilla.wikimedia.org/72108) (owner: 10Divec) [18:13:59] (03PS5) 10Catrope: Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG) [18:14:07] (03CR) 10Catrope: [C: 032] Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG) [18:14:09] (03Merged) 10jenkins-bot: Introducing getTitle() in MWTitleInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169603 (https://bugzilla.wikimedia.org/72468) (owner: 10SuchetaG) [18:15:24] (03Merged) 10jenkins-bot: Introducing isValid() in MWTitileInputWidget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169623 (https://bugzilla.wikimedia.org/71249) (owner: 10SuchetaG) [18:16:01] (03CR) 10Esanders: Replace native range rectangle hacks with RangeFix library (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 (owner: 10Esanders) [18:16:23] (03PS1) 10Catrope: Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 [18:16:40] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope) [18:16:44] (03PS3) 10Esanders: Replace native range rectangle hacks with RangeFix library [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169696 [18:17:23] 3VisualEditor: Backspace key at end of document moves the cursor up a line - 10https://bugzilla.wikimedia.org/72689#c2 (10Adam Wight) Page being edited: https://www.mediawiki.org/w/index.php?title=Extension:CentralNotice/Banner_loading&veaction=edit Browser: Linux, FireFox 30.0 [18:17:39] 3VisualEditor / 3Editing Tools: VisualEditor: TitleInputWidget should validate inputs - 10https://bugzilla.wikimedia.org/71249 (10James Forrester) 5PATC>3RESO/FIX [18:17:48] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope) [18:18:00] Bah. [18:18:10] 3VisualEditor: Forward delete key does crazy things - 10https://bugzilla.wikimedia.org/72690#c1 (10Adam Wight) Page being edited: https://www.mediawiki.org/w/index.php?title=Extension:CentralNotice/Banner_loading&veaction=edit Browser: Linux, FireFox 30.0 [18:19:41] (03PS2) 10Jforrester: Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope) [18:20:58] (03CR) 10Jforrester: [C: 032] "PS2 fixes the pull-through." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope) [18:22:18] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope) [18:23:35] * James_F grumbles at mw.cookie. [18:24:23] (03CR) 10Catrope: [C: 032] "Go go Jenkins" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope) [18:25:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (545d8db) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169764 (owner: 10Catrope) [18:26:02] 3VisualEditor / 3Technical Debt: VisualEditor: MWTitleInputWidget should return titles - 10https://bugzilla.wikimedia.org/72468 (10James Forrester) 5PATC>3RESO/FIX [18:27:16] 3VisualEditor / 3MediaWiki integration: VisualEditor: A template editing bubble appears off-screen for a left-aligned infobox in the Hebrew Wikipedia - 10https://bugzilla.wikimedia.org/72668 (10etonkovidova) p:5Unprio>3Normal [18:28:35] (03PS4) 10Jforrester: Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders) [18:29:12] (03CR) 10Jforrester: [C: 031] "Ah, sorry, misunderstanding." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169286 (owner: 10Catrope) [18:36:19] (03CR) 10Catrope: [C: 032] Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders) [18:37:34] (03Merged) 10jenkins-bot: Use ClassAttributeNode mixin in MWBlockImageNode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169517 (owner: 10Esanders) [18:38:46] (03CR) 10Catrope: [C: 032] Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [18:39:10] There goes nothing... [18:41:05] (03Merged) 10jenkins-bot: Data model implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159310 (owner: 10Oliverb) [18:42:50] (03Merged) 10jenkins-bot: ContentEditable implementation for tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159311 (owner: 10Oliverb) [18:43:36] (03Merged) 10jenkins-bot: Actions and context menus for manipulating tables [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/159312 (owner: 10Oliverb) [18:43:39] (03Merged) 10jenkins-bot: Support annotation tool on table selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/166774 (owner: 10Esanders) [18:43:41] (03Merged) 10jenkins-bot: Supporting copy paste of single table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167559 (owner: 10Esanders) [18:43:43] (03Merged) 10jenkins-bot: Table header/data format tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168060 (owner: 10Esanders) [18:43:45] (03Merged) 10jenkins-bot: Merge cells tool [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/167631 (owner: 10Esanders) [18:43:47] (03Merged) 10jenkins-bot: Allow custom type and attributes when creating a table [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/168960 (owner: 10Esanders) [18:44:14] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf6]There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693 (10Rummana Yasmeen) 3NEW p:3Unprio s:3normal a:3None Created attachment 16945 --> https://bugzilla.wikimedia.org/attachment.cg... [18:49:28] (03PS10) 10Jforrester: Update VE core submodule to master (f4ff1d6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [18:50:28] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf6]There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693#c1 (10Roan Kattouw) a:3Bartosz Dziewoński This is because of the mw-indicators div. It's empty if there are no indicators, but the fac... [18:51:08] (03CR) 10Catrope: [C: 04-1] Update VE core submodule to master (f4ff1d6) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [18:52:13] (03PS11) 10Jforrester: Update VE core submodule to master (f4ff1d6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [18:52:42] 3VisualEditor / 3Editing Tools: VisualEditor:[Regression wmf6]There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693#c2 (10Bartosz Dziewoński) Butbutbut wasn't that supposed to be fixed with c81ed82f? [18:56:58] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf6] There is an extra space appearing at the top of the toolbar inside VE - 10https://bugzilla.wikimedia.org/72693#c3 (10James Forrester) 5NEW>3ASSI p:5Unprio>3High s:5normal>3minor (In reply to Bartosz Dziewoński from comment #2) > Butb... [19:03:12] 3VisualEditor / 3Editing Tools: VisualEditor: When auto-filling citations using citoid, don't add any empty parameters - 10https://bugzilla.wikimedia.org/72007 (10James Forrester) [19:04:29] 3VisualEditor / 3ContentEditable: VisualEditor: Be able to merge table cells (setting colspan/rowspan as appropriate) - 10https://bugzilla.wikimedia.org/52179 (10James Forrester) 5ASSI>3PATC a:3Ed Sanders [19:10:27] 3VisualEditor / 3ContentEditable: VisualEditor: Content menu is embedding off-screen for left-floated node in RTL environment - 10https://bugzilla.wikimedia.org/72668#c1 (10James Forrester) 5NEW>3ASSI Did we fix this in master? It looks "fine" (different breakage) on http://he.wikipedia.beta.wmflabs.org/... [19:12:37] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (f4ff1d6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [19:13:04] RoanKattouw: Fun. [19:14:01] (03Merged) 10jenkins-bot: Update VE core submodule to master (f4ff1d6) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/167189 (owner: 10Esanders) [19:25:11] Sooo I need to make sure I delete all my "I'm with stupid: " console comments I shoved into my code to debug, since Chrome's been a real annoyance with the debugger lately. [19:33:16] RoanKattouw_away: RE needing @static @inheritable, Yes. Unless I'm missing something, why would it not need that / how would it know? [19:34:56] 3VisualEditor / 3ContentEditable: [Regression] VisualEditor: Clicking on an image with wikilink opens up link inspector - 10https://bugzilla.wikimedia.org/72660 (10Krinkle) [19:37:27] 3VisualEditor / 3Data Model: VisualEditor: [Regression] Clicking on an image with wikilink opens up link inspector - 10https://bugzilla.wikimedia.org/72660 (10James Forrester) 5NEW>3ASSI [19:38:58] (03PS7) 10Jforrester: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [19:39:21] (03CR) 10Jforrester: [C: 031] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [19:40:02] (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [19:47:49] (03PS8) 10Jforrester: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [19:48:16] edsanders: https://gerrit.wikimedia.org/r/#/c/169546/ [19:49:09] (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [19:49:11] (03CR) 10Catrope: [C: 032] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [19:49:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf3] In Firefox, Cursor is appearing in Read mode at the end of the document after saving a page and after discarding the current edit in Firefox - 10https://bugzilla.wikimedia.org/71852 (10James Forrester) p:5Highes>3Normal [19:50:28] (03CR) 10jenkins-bot: [V: 04-1] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [19:50:35] Eurgh. [19:51:42] (03PS1) 10Catrope: Don't create tables with a thead [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169784 [19:51:47] edsanders: ---^^ [19:53:20] (03PS9) 10Jforrester: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [19:53:35] (03CR) 10Jforrester: [C: 032] Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [19:54:55] (03Merged) 10jenkins-bot: Create mwTables with wikitable attribute by default [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/168961 (owner: 10Esanders) [20:08:14] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] Scroll bar is appearing while opening a link inspector - 10https://bugzilla.wikimedia.org/72338#c5 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:13:12] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression wmf4] Red border is appearing around required parameters before focus moves away - 10https://bugzilla.wikimedia.org/72096#c8 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:17:28] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression] "Make full size" is not enabling "Apply Changes" button when the image has been set to a custom size - 10https://bugzilla.wikimedia.org/72155#c4 (10Rummana Yasmeen) 5RESO/?>3VERI Verified the fix in production [20:21:27] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278#c6 (10Rummana Yasmeen) Verified the fix in production [20:21:42] 3VisualEditor / 3Editing Tools: VisualEditor: [Regression pre-wmf5] The "Show Options" inside Transclusion dialog box is blank, not bringing up the other options to add parameter/template/content - 10https://bugzilla.wikimedia.org/72278 (10Rummana Yasmeen) 5RESO/?>3VERI [20:24:16] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf6] deleting text formatted as computer code produces: Failed to load resource: The operation couldn’t be completed. (kCFErrorDomainCFNetwork error -10.) - 10https://bugzilla.wikimedia.org/72698 (10etonkovidova) 3NEW p:3Unprio s:3normal a:3... [20:27:12] James_F, I wonder what an OOUI NumberInputWidget would look like [20:28:36] Krenair: Yeah, I was thinking that too. Maybe leave off for now? TrevorParscal? [20:28:59] On mobiles I guess it could trigger the numbers-only keyboard. [20:29:02] because it's probably not like how chrome shows :) [20:29:14] 3VisualEditor / 3ContentEditable: VisualEditor: [Regression wmf6] deleting text formatted as computer code produces: Failed to load resource: The operation couldn’t be completed. (kCFErrorDomainCFNetwork error -10.) - 10https://bugzilla.wikimedia.org/72698#c1 (10etonkovidova) Actually, the console error: "Fa... [20:29:58] Krenair: http://caniuse.com/#feat=input-number [20:30:07] we are aiming OOjs UI to work on IE8 [20:30:12] (not saying it does yet) [20:30:16] * James_F nods. [20:30:23] so, we can totally do a number input type [20:30:45] but remember that you need to come up with a way to check if that's supported in the browser, and select the type based on that [20:30:48] falling back to text [20:31:13] Isn't that what browsers which don't support type=number will do? [20:31:52] since type=text is the default [20:32:58] well, there are bugs around that [20:33:08] technically yes, but it's freaking IE man [20:33:14] in any case [20:33:27] our general approach to adding widgets in the past has been, when someone needs it [20:33:51] because otherwise it adds resistance to system-wide changes and widgets that don't get used get ignored, and then when they are finally used they don't work [20:33:59] 3VisualEditor / 3Mobile: VisualEditor Mobile: Disable the context menu for the Basic reference - 10https://bugzilla.wikimedia.org/68897#c7 (10Rummana Yasmeen) 5VERI>3REOP a:5Juliusz Gonera>3Ed Sanders This is again appearing in mobile. [20:34:00] so, don't bother unless we are going to use it somewhere [20:34:29] and there are some existing exceptions, like the toggle crap, but we used them at one point and I didn't want to delete them given how complex they were to build [20:35:07] I'm looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=53613 [20:35:20] and one of the types TD provides is 'number' [20:36:27] 3VisualEditor / 3Mobile: VisualEditor Mobile: Disable the context menu for the Basic reference - 10https://bugzilla.wikimedia.org/68897#c8 (10Rummana Yasmeen) 5REOP>3ASSI The context menu for math and references list started appearing too. [20:36:57] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression]Disable the context menu for the Basic reference/Group Reference/Math/Reference list for mobile - 10https://bugzilla.wikimedia.org/68897 (10Rummana Yasmeen) [20:37:12] 3VisualEditor / 3Mobile: VisualEditor Mobile: [Regression]Disable the context menu for the Basic reference/Group Reference/Math/Reference list for mobile - 10https://bugzilla.wikimedia.org/68897 (10Rummana Yasmeen) [20:48:43] (03PS1) 10Anomie: Add i18n for API module help [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 [20:49:05] (03PS1) 10Anomie: Add i18n for API module help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 [20:50:49] ryasmeen: heya, I might be a few minutes late, my usb ports aren't working on my laptop right now (so no external keyboard nor camera, which is annoying when working at home at my desk). [20:51:39] (03CR) 10Jforrester: [C: 04-1] "i18n files should be in alphabetical order, per coding conventions." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 (owner: 10Anomie) [20:52:56] (03PS1) 10Bartosz Dziewoński: Hide page status indicators even if they aren't :visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169860 (https://bugzilla.wikimedia.org/72693) [20:53:31] (03CR) 10Catrope: [C: 032] Hide page status indicators even if they aren't :visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169860 (https://bugzilla.wikimedia.org/72693) (owner: 10Bartosz Dziewoński) [20:54:09] (03PS1) 10Jforrester: Hide page status indicators even if they aren't :visible [extensions/VisualEditor] (wmf/1.25wmf6) - 10https://gerrit.wikimedia.org/r/169861 (https://bugzilla.wikimedia.org/72693) [20:54:47] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 (owner: 10Anomie) [20:58:07] ryasmeen|Away: fixed it :) be there on time [20:58:36] (03CR) 10Anomie: "Note: If any reviewer sees any errors that need fixing, please feel free to fix it and upload a new patchset." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [20:59:04] (03Merged) 10jenkins-bot: Hide page status indicators even if they aren't :visible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169860 (https://bugzilla.wikimedia.org/72693) (owner: 10Bartosz Dziewoński) [20:59:59] (03PS2) 10Jforrester: Add i18n for API module help [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169846 (owner: 10Anomie) [21:01:36] (03CR) 10Jforrester: [C: 04-1] Add i18n for API module help (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [21:09:04] (03CR) 10Catrope: "Because of https://bugzilla.wikimedia.org/show_bug.cgi?id=72702" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/169784 (owner: 10Catrope) [21:09:53] (03CR) 10Anomie: Add i18n for API module help (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/169837 (owner: 10Anomie) [21:09:55] do you guys remember ve-no-shield? what was it replaced with? [21:11:35] RoanKattouw, hm, I think ther'es an unexpected bonus from my code [21:12:20] InezK: There's something like that I think... [21:12:31] RoanKattouw, OO.compare( undefined, [] ); <-- true (meh!) [21:12:45] also true with pairs of null, undefined or null anything [21:12:46] InezK: ve-ce-noHighlight [21:13:03] mooeypoo: Yeah that is really horrible [21:13:07] however, TemplateDataModel.static.compare( undefined, [] ); <-- false [21:13:09] I've been trying to convince Krinkle that this is a bug [21:13:14] and also false with the undefined and null [21:13:17] What is? [21:13:27] Or maybe it was edsanders that disagrees with me [21:13:29] i had to find a way to do this right for TDG comparisons since a lot of the input is written by hand [21:13:39] RoanKattouw: thx [21:14:12] RoanKattouw: I think I considered it a bug, but you or Ed convinced me because you wanted to tolerate null/undefined in some cases for some reason. [21:14:21] I think undefined should not cause a crash [21:14:24] ideally [21:14:29] I recall thinking that's sloppy code, but that ship already sailed and you needed a way to tolerate it [21:14:37] But I also think that claiming that undefined and [] are the same is unreasonable [21:14:46] to compare the existing models that had that value in it [21:14:49] Indeed [21:14:51] MatmaRex: how's it going? [21:14:55] RoanKattouw: What is making them equal? [21:15:00] I don't know! [21:15:07] Maybe it's because both contain 0 sub-values? [21:15:15] https://github.com/wikimedia/oojs/blob/master/src/core.js#L220-L252 [21:15:16] RoanKattouw, well, mine seems to cover those cases [21:15:22] And OO.compare() at the top level only descends and doesn't do any other comparison [21:15:28] RoanKattouw: Falsye values cast to empty object [21:15:32] RoanKattouw, Krinkle as far as I saw it's not really checking types propely [21:15:37] hi TrevorParscal. you have a stack of OOUI PHP changes to review, that's how ;) [21:15:49] mooeypoo: It is. [21:15:49] nice [21:16:00] (03PS6) 10Mooeypoo: [Just WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 [21:16:03] (03CR) 10jenkins-bot: [V: 04-1] [Just WIP] Eventify TemplateDataGenerator and use oojs-ui [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/167046 (owner: 10Mooeypoo) [21:16:15] there are JS/PHP comparison tests in there, and they pass [21:16:17] RoanKattouw: So there's your answer. I support making it not cast falsy to empty object, and instead do a falsy check around the for-loop and make it not loop or whatever. [21:16:36] RoanKattouw, Krinkle see line #85 https://gerrit.wikimedia.org/r/#/c/167046/6/modules/ext.templateDataGenerator.data.js [21:16:38] for-in on null/undefined throws [21:16:48] actually, it doesn't [21:17:02] >> for ( key in undefined ) { return 1; } return 2; [21:17:02] Krinkle: SyntaxError: Illegal return statement [21:17:08] >> for ( key in undefined ) { 1; } 2; [21:17:08] Krinkle: (number) 2 [21:17:10] lol [21:17:17] Krinkle: That always returns 2 [21:17:24] I Know [21:17:32] >> var obj = { 1: 2 }; for ( key in undefined ) { 1; } 2; [21:17:32] RoanKattouw: (number) 2 [21:17:38] >> (function(){ for ( key in undefined ) { return 1; } return 2; }()); [21:17:39] Krinkle: (number) 2 [21:17:40] Oh you're pointing out there's no error [21:17:48] Indeed [21:18:00] I think Ed was trying to reduce the error handling and just cast it to avoid extra code [21:18:03] but it's not needed [21:18:03] There might not be an error, but it means we can't compare values that might be undefined [21:18:13] or null [21:18:25] RoanKattouw: https://github.com/wikimedia/oojs/commit/b6f3320aa7fa0250eb1cc1dffbe0db7c0175ca59 [21:18:27] and that's just inconvenient, hence me making another comparison method for templatedata [21:18:57] RoanKattouw: I think you had some models in VE where a proprety might not exist, so you can do compare( foo.thing, bar.thing ) where one of foo or bar might not even have .thing [21:19:06] That might be right [21:19:09] I think that's sloppy code, but it was already established and needed a way to check it [21:19:32] Well, best example is the image dialog initHash [21:19:35] RoanKattouw: In ve.ce.FocusableNode.prototype.computeRects you use this.$element.find( '*' ) - it would be nice to use recursion, and if node has class ve-ce-noHighlight then do not go into it's children [21:19:36] since the method is recursive, you screw yourself in the end [21:19:44] https://gerrit.wikimedia.org/r/#/c/155047/ [21:19:53] it's supposed to be undefined if the image is brand new (no 'old' hash to compare to) but I can' tmake it undefined because then compare fails [21:20:01] then don't compare in that case? [21:20:11] InezK: AIUI that's not what noHighlight is for. Instead it makes it so that it isn't highlighted but its children are. Or something. Ask edsanders [21:20:15] Well, I need to figure out if it changed in hasBeenChanged() [21:20:33] I could not compare, but I don't quite understand why not have a comparison method that actually compares values, whether they're set or not [21:20:38] it shouldn't be up to the compare method to fix that code, if you're not initalised yet, there should be no reason to compare any values. seems like a case of specialising for a use case for inappropiate convenience. [21:20:49] comparing undefined to anything else is false; comparing undefined to null is false... why is that a problem? [21:20:51] * Krinkle stack.pop() [21:21:17] It makes sense that a comparison will return a proper comparison, imho... not sure I understand why not? [21:21:32] (03CR) 10Trevor Parscal: [C: 032] "I'm approving this because label, unlike fieldset and legend, has no special rendering - it's a very generic container, and is equivalent " [oojs/ui] - 10https://gerrit.wikimedia.org/r/169218 (https://bugzilla.wikimedia.org/72587) (owner: 10Bartosz Dziewoński) [21:22:00] as in, how is it a good comparison method if it returns *true* to comparing anything with undefined? [21:22:01] MatmaRex: so, I'm ready to +2 https://gerrit.wikimedia.org/r/#/c/169218/ [21:22:09] I have, but your -2 is blocking of course [21:22:13] TrevorParscal: i have literally not tested it at all [21:22:24] well, i checked whether the widgets.php page blows up [21:22:37] but it's a proof-of-concept [21:22:39] label is the same as span, it's not like fieldset and legend with all it's tricky crap [21:22:54] i'll do some testing to prove it [21:22:58] i know we have simulateLabelClick() function somewhere that does its things, i don't know if they cooperate [21:23:17] i am pretty sure this should be harmless, but i haven't verified it anywhere near well enough [21:24:07] simulateLabelClick may be able to go away, but we need to audit it's use [21:24:16] (if we find this to actually cause problems, we could probaly do