[00:00:02] (03CR) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [00:00:04] 10VisualEditor, 5§ VisualEditor Q3 Blockers: [Regression wmf18] Deleting the text inside a bullet/numbered item throws error - https://phabricator.wikimedia.org/T90478#1064422 (10Jdforrester-WMF) [00:00:18] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10UI-Standardization, 5§ VisualEditor Q3 Blockers: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1064423 (10Jdforrester-WMF) [00:00:32] 10VisualEditor, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Stash VisualEditor edits using edit stash - https://phabricator.wikimedia.org/T90040#1064424 (10Jdforrester-WMF) [00:00:33] (03CR) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [00:00:47] 10VisualEditor, 7Performance, 5§ VisualEditor Q3 Blockers: Load HTML in parallel with JSON metadata - https://phabricator.wikimedia.org/T90304#1064427 (10Jdforrester-WMF) [00:00:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: Move media to top level icon on toolbar - https://phabricator.wikimedia.org/T90299#1064428 (10Jdforrester-WMF) [00:02:26] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 5§ VisualEditor Q3 Blockers: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#1064432 (10Jdforrester-W... [00:02:31] 10VisualEditor, 10VisualEditor-EditingTools, 7Browser-Support-Firefox, 5§ VisualEditor Q3 Blockers: In the template dialog, the boxes for pre-existing, long parameters should be expanded before you click on them in Firefox - https://phabricator.wikimedia.org/T64084#1064434 (10Jdforrester-WMF) [00:03:28] 10VisualEditor, 10Continuous-Integration, 6Mobile-Web, 10Wikimedia-Hackathon-2015: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1064441 (10greg) [00:04:13] (03CR) 10Cscott: "Ok, I think I have addressed all the reviewer's comments now." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [00:16:10] (03PS1) 10Amire80: [BrowserTest] Update Gemfile lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192729 [00:16:12] (03PS1) 10Amire80: [BrowserTest] Update the scenario for Cite screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192730 [00:16:14] (03PS1) 10Amire80: [BrowserTest] Fix VisualEditor_More_Settings scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192731 [00:16:42] (03PS2) 10Amire80: [BrowserTest] Update Gemfile.lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192729 [00:16:54] (03PS2) 10Amire80: [BrowserTest] Update the scenario for Cite screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192730 [00:17:16] (03PS2) 10Amire80: [BrowserTest] Fix VisualEditor_More_Settings scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192731 [00:18:07] Krinkle: What's the tool to search in MediaWiki:*.js pages cross-wiki? [00:18:12] 10VisualEditor, 10Wikimedia-Hackathon-2015, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1064455 (10Jdforrester-WMF) Possibly worth playing with this at the MediaWiki Hackathon, if I can find peop... [00:18:19] RoanKattouw: mwgrep, tin [00:18:45] Thanks [00:18:53] RoanKattouw: That sounds bad. [00:19:08] Basically I'm trying to figure out if I can break the VE plugin interface by removing the target parameter passed to plugin functions [00:19:15] James_F: You mean like, where are the bullets for the footgun? [00:19:53] Krinkle: "Ominous", yes. [00:20:14] 10VisualEditor, 10Continuous-Integration, 10Flow, 6Mobile-Web, 10Wikimedia-Hackathon-2015: Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc) - https://phabricator.wikimedia.org/T90647#1064461 (10Jdforrester-WMF) [00:20:25] James_F: Thx for that new word. It's been a while since I recorded one in my list [00:20:34] And in its definition another new one: inauspicious [00:20:52] (03CR) 10jenkins-bot: [V: 04-1] [BrowserTest] Update Gemfile.lock [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192729 (owner: 10Amire80) [00:21:04] Krinkle: :-) [00:21:19] Krinkle: It augers well for the rest of the day. [00:31:13] Hey TrevorParscal. [00:31:19] TrevorParscal: Commit coming? :-) [00:40:38] Krinkle: Holy crap that script is fast [00:40:47] mwscript? [00:40:48] yeah [00:40:53] ElasticSearch :) [00:41:06] It's one pool, not fragmented by wiki [00:41:12] namespace or wiki or both is all the same to it [00:41:14] (well, almost) [00:41:19] RoanKattouw: How many people have ever used the interface? [00:41:21] It's really nice yeah [00:41:28] It doesn't scale for web access though [00:41:29] 8 [00:41:38] https://ca.wikipedia.org/wiki/MediaWiki:Gadget-visualeditor-signature.js [00:41:40] RoanKattouw: Ha. [00:41:44] (also on cawikibooks) [00:41:51] mwgrep*, I mean [00:42:55] It sends off a pretty simple looking query to http://search.svc.eqiad.wmnet:9200/_all/page/_search [00:43:12] Oh right [00:43:18] We have modern search stuff now [00:43:23] :D [00:44:49] Also https://fa.wikipedia.org/wiki/%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Gadget-VeDirectionMarkTool.js [00:46:07] Oh God [00:46:11] False positive: https://fr.wikisource.org/wiki/MediaWiki:Gadget-annotator.js [00:46:18] Because it has an addPlugin function [00:46:20] Fun [00:46:28] But seriously, Closure-compiled JS on a wiki page? [00:46:51] RoanKattouw: any feedback on the WIP patches? [00:47:00] ori: Not looked at them yet sorry [00:47:05] Will look in a minute [00:47:22] From git diff on osmium I did glance that you were reaching into store.valueStore from another object [00:47:37] yeah, that's a small detail; it's not an issue to use .value() instead. [00:47:56] the value conferred by that entire abstraction layer is highly dubious, IMO [00:48:00] Please do use function interfaces rather than property interfaces where available [00:48:14] yes yes, but that's cosmetic [00:48:23] the deeper question is whether I'm violating some consistency guarantees [00:48:31] Well it's the only thing I noticed by looking at it for 5 seconds :) [00:48:37] I'll take a closer look once I finish this thing in a few minutes [00:48:59] * RoanKattouw declares victory [00:49:04] Nobody uses the target parametr [00:49:06] I'm killing it [00:49:30] RoanKattouw: Focus. :=P [00:49:33] I wrote mwgrep, now you owe me the hours it saved you :P mwahaha [00:49:35] Krinkle: fyi https://phabricator.wikimedia.org/T18691#1064544 [00:49:52] ori: You wrote mwgrep? [00:49:55] I did not know that [00:50:04] RoanKattouw: Isn't ori amazing? [00:50:05] i mwdid [00:50:16] 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064549 (10Whatamidoing-WMF) It might be desriable to do T90665 ("Prompt existing users to enable VisualEditor for... [00:51:27] ori: :-D [00:51:35] ori: OK so the changes in ce.GeneratedContentNode greatly diminish the effectiveness of the cache [00:51:57] Because ce.*Node objects are relatively ephemeral, and there are multiple instances of them [00:52:14] So if I, say, take a template and copy it somewhere else on the page, its rendering won't be reused with your code [00:52:20] Because it's a different GCN instance [00:52:43] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Categories go at the bottom, so please place the cursor above the categories - https://phabricator.wikimedia.org/T71802#1064551 (10Etonkovidova) The saved page will display the text above categories. Only "Difference between revisions" misleadingly pl... [00:52:51] I've always disliked using IVStore for the GCN cache, but I would like some sort of document-level GCN cache to continue to exist [00:52:56] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Categories go at the bottom, so please place the cursor above the categories - https://phabricator.wikimedia.org/T71802#1064552 (10Etonkovidova) p:5Triage>3Low [00:54:25] 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064554 (10Jdforrester-WMF) >>! In T90667#1064549, @Whatamidoing-WMF wrote: > It might be desriable to do T90665 ("... [00:55:05] (03CR) 10Catrope: [C: 04-1] [WIP] Reduce reliance of IndexValueStore hashing (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192694 (owner: 10Ori.livneh) [00:55:24] So if I, say, take a template and copy it somewhere else on the page, its rendering won't be reused with your code [00:55:28] how often does that happen? [00:55:41] Copying templates/references? [00:55:47] yes [00:55:52] Not hugely often, but making it fast is a nice user win. [00:56:18] I'm not at all persuaded that the perf benefit for copying a reference is tangible [00:56:20] With Moriel's cite inspector this is about to be more common [00:56:34] We'll have a preview rendering of the citation before it's inserted [00:56:43] And previews in the context when they're selected [00:56:51] Along with the permanent rendering in the reference list [00:56:52] And the ambition there is for it to be instantaneous. [00:57:04] Could we do a hack/simpler solution just for that one use case? [00:57:25] the decision of what to cache (and at what cost) was (as far as i can tell) made on the basis of hunches about what the performance bottlenecks are going to be, but if my poking around today is anything to go by, these hunches don't match reality [00:57:35] 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064559 (10Whatamidoing-WMF) Perhaps an initial invitation should use other methods, then, like watchlist notices,... [00:57:36] MatmaRex: Hm.. So if we end up changing it how will we deploy the css change and html change? Do we keep it hidden for another 30 days after we updated it? [00:58:24] Krinkle: the proposed HTML change only changes the tooltip, no big deal if you ask me. i'm not quite sure if it should be merged, anyway [01:00:26] ori: GCN previews are rendered using an API request [01:00:57] Well, template previews at least, that's the main use of GCN in VE-MW [01:01:28] I think it's valuable to not request the same thing from the API over and over [01:01:51] yes, but the caching strategy has to be different [01:02:16] I'm happy to have a different caching stategy for them [01:02:24] Especially one that doesn't involve IVStore, I'm all for that [01:02:35] I'm just saying that I want to have *a* caching strategy [01:02:40] 10VisualEditor, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1064561 (10Jdforrester-WMF) >>! In T90667#1064559, @Whatamidoing-WMF wrote: > Perhaps an initial invitation should... [01:03:18] instead of a content-agnostic cache that performs lookup by generating a hash from any arbitrary object, we need to have multiple cache objects that are specific for the type of data that they are meant to contain (like API responses by URL, etc.) [01:03:28] Yup [01:03:35] In fact, we already have this for link metadata and image metadata [01:03:49] You could write an ApiResponseCache subclass for template renderings as well [01:05:03] OK, I'll file tasks, though for now I'll shift focus to asyncifying getModelFromDom, which this was a bit of a digression from [01:05:07] OK [01:05:09] Sounds good [01:05:13] something else I wanted to discuss quickly [01:05:25] Why getModelFromDom? Why not the CE tree? [01:05:38] err, right [01:05:47] * ori mis-remembered, but I have this written down correctly :) [01:05:51] :-) [01:05:51] Oh irght [01:06:04] anyways, we've sort of danced around this topic a few times, but here's my question [01:06:21] are we going to *ever* have the performance we desire when there is so much work for the client to do? [01:06:38] and if not, is it time to get serious about making the linear model serializable and generating it server-side? [01:06:55] ori: Trivially, yes, in 20 years' time the computation we're asking for will be simple for any tool. [01:07:05] Well, didn't we see though that the CE tree build is 4x slower than the linmod build? [01:07:09] ori: The question is can we make it a simple workload for the tools of today or near-today. [01:07:25] RoanKattouw: yeah, so perhaps I should rephrase [01:07:39] ori: Being "fast enough" for the world's top-50% of devices may be "good enough". [01:07:42] should we find a way to serialize the result of the work the client currently has to do [01:07:45] I don't have a particular view. [01:08:44] ori: Maybe [01:09:17] However I think that asyncifying the CE tree build is a much easier way to achieve a lot of that gain [01:09:43] there's something really crazy about DOM -> linear model -> CE DOM [01:10:04] yeah, maybe that's right [01:10:06] I agree. And they're mostly the same DOM, but not entirely [01:10:57] what are the salient differences? [01:10:59] My preferred course of action would be to focus on asyncifying the CE DOM build for now, maybe throw in some "only render once scrolled into view" smartness [01:11:29] Then once infusion in OOUI is stable, experiment with moving CE DOM generation to the server and using infusion to bring it to life on the client [01:11:54] how does OOUI fit in? (I am rather clueless about this part) [01:11:57] RoanKattouw: I thought the CE tree was browser-specific? [01:12:06] RoanKattouw: Did that change, or was I wrong? [01:12:07] James_F: It's not really [01:12:12] ori: ce.Node is a subclass of OO.ui.Element [01:12:20] RoanKattouw: So it is sort-of? [01:12:33] So in theory, once infusion is implemented, ce.Nodes should be infusable [01:12:41] in English? [01:12:46] haha sorry [01:12:51] MatmaRex: In that case, how's your review of Infusion coming? ;-) [01:13:00] once server-side generation of OOUI nodes is implemented, server-side generation of the CE dom should be doable? [01:13:01] RoanKattouw: woah. hmm. [01:13:08] ori: Pretty much [01:13:20] ori: "Infusion" is the process by which server-side generated OOUI elements are brought to life on the client [01:13:21] that sounds rad [01:13:22] ori: Client-side JS-ification of server-side generated nodes. [01:13:29] It's something csc.ott is currently working on [01:13:36] ori: Right now, server-side is done in PHP, but we could do it in Node too. [01:13:42] MatmaRex: Indeed. [01:14:00] Because ce.Nodes use the same interface as OO.ui widgets (they more or less *are* OO.ui widgets), in theory infusion should Just Work for them [01:14:00] I still don't get what the relevant difference is between the Parsoid DOM and the CE DOM [01:14:02] James_F: gonna review the new updates tomorrow [01:14:05] With a heck of a lot of support code I suppose [01:14:13] ori: Sorry, I got sidetracked from that, let me try and answer that [01:14:19] MatmaRex: Slacker! ;-) [01:14:32] Those differences aren't as big now as they once were [01:14:43] i didn't get much done today, some things are falling over on me today and i'm having to prop them up [01:14:55] Right now it's mainly how multi-sibling about groups are handled [01:15:47] Some things, mainly templates, output things like
....
...
...
etc [01:15:47] * ori stares blankly. [01:16:03] Where adjacent sibling nodes with the same about attribute are grouped together and treated as one [01:16:26] I would like the Parsoid DOM to have wrappers for those, but it doesn't, and instead about groups is what we use [01:16:29] RoanKattouw: slugs don't exist in Parsoid naturally. And special line breaks may have a visual representation. As well as html comments. [01:16:45] Oh yes HTML comments, of coures [01:16:49] That's a much better example [01:16:55] There is basically data model, view model (future parsoid serving read traffic) and then there is the UI equiv (CE) [01:17:22] ah yeah, grouped templates [01:17:38] what about HTML comments? [01:17:44] (03PS1) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [01:17:48] They are editable [01:17:48] ori: Let me get you a demo link real quick [01:17:53] but you can't make a comment display block [01:18:12] TrevorParscal: Gosh. [01:18:14] (03PS2) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [01:18:24] ? [01:18:29] James_F: got mobile looking nice [01:18:35] TrevorParscal: It actually landed! [01:18:44] ye of little faith [01:18:46] ori: https://en.wikipedia.org/w/extensions/VisualEditor/lib/ve/demos/ve/desktop.html#!pages/comments.html [01:19:14] TrevorParscal: Want to add the Phab task? [01:19:21] Oh also I suppose newline characters are mapped to weird symbols [01:19:23] tabs, too [01:19:38] And == Hello == maps to

Hello

but

Hello

in CE [01:19:52] We hide leading and trailing whitespace from the user [01:20:03] why? [01:20:05] All these things are not to say that building the CE DOM directly from the Parsoid DOM is infeasible [01:20:07] TrevorParscal: T88337 / T89054 [01:20:08] It probably isn't [01:21:21] But the way I would advocate for doing it is by doing something like this.$element = $( ve.copyDomElements( this.model.element.originalDomElements, window.document ) ); [01:21:27] And then enriching it from there [01:21:34] (03CR) 10Krinkle: Context refactor (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [01:21:42] i.e. start with a clone of the Parsoid DOM element [01:22:14] Alternatively you could do server-side processing and then infusion and build everything in reverse (view first, then model), but that would take some work, and possibly be awkward in places [01:22:38] but fast [01:23:17] OK, I'm going back to asyncification for now, but let's talk about this more tomorrow [01:23:54] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [01:25:31] ori: Sure [01:26:00] ori: Meanwhile, I'm working on ve.init.mw.TargetLoader which will take over responsibility for loading RL modules and API/Parsoid/RESTbase stuff from mw.Target/mw.ViewPageTarget [01:26:18] It'll depend on pretty much nothing, so we can load it early, and kill two tasks with one stone [01:26:37] RoanKattouw: cool! maybe use the opportunity to make the API URL override hack less hacky? [01:26:50] ve.init.mw.TargetLoader.setBaseUrl() [01:26:59] 1) Load the HTML immediately (via the API for now, splitting that up is next) and 2) fix the age old task about getting rid of the two-stage rocket for RL requests [01:27:06] ori: Oooh excellent suggestion [01:28:30] Working on Flow integration. [01:28:34] Is there a way to check if the document is empty, or should I just serialize it? [01:28:57] I know you can check if it's dirty, but I also want to prevent posting blank posts (even if they typed something then erased it). [01:29:32] superm401: Transaction stack being zero isn't enough, I guess, as you say. [01:30:03] superm401: We currently in VE only prevent blank edits with a zero-length transaction stack (except on old-revision edits). [01:30:40] Okay, I'll just do it using serialization for now. [01:31:27] superm401: The hacky way we use in places is checking whether the length of the linear model is <= 4 [01:31:35] RoanKattouw: Eww. [01:31:53] Oh here we go [01:31:55] OK it's slightly better [01:32:03] document.data.countNonInternalElements() > 2 [01:32:24] That's what ve.ui.MWReferenceDialog uses for not letting you insert an empty reference [01:32:35] Although in theory you could have a document that's just an image or something [01:33:10] Cool, I'll give that a shot. [01:34:14] (where document instanceof ve.dm.Document) [01:34:21] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1064580 (10kaldari) @Prtksxna: This bug is currently blocking adoption of OOjs UI on mobile. Anything we do to help this along? [01:34:53] RoanKattouw, is that dmDoc? [01:35:35] Yes [01:35:42] Thanks [01:35:43] That sounds like a variable that would contain a dm.Document [01:36:09] RoanKattouw, yeah that used to be something like data.length <= 4 [01:36:14] we fixed it at some point last year [01:36:33] Yeah I remember you doing that [01:39:45] in https://gerrit.wikimedia.org/r/#/c/136505/2 [01:39:59] (03PS10) 10Krinkle: Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [01:42:02] (03PS1) 10Krinkle: test: Reduce timeout in Process test from 100 to 10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/192740 [01:42:48] (03CR) 10Krinkle: [C: 031] "Since index.php is not auto-generated, added a check on top to prevent a PHP Warning and a qunit syntax error." [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [01:43:20] (03CR) 10Bartosz Dziewoński: [C: 031] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [01:49:06] Krinkle, MatmaRex: OK, should I +2? [01:49:23] James_F: Sure [01:49:37] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1064591 (10Jdforrester-WMF) Is this bug now "MW-UI button designs are out of sync with OOjs UI and need to be updated"? [01:49:45] (03CR) 10Jforrester: [C: 032] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [01:50:51] 10OOjs-UI, 5OOjs-UI-next-release, 10Continuous-Integration: Run the OOjs UI PHP test code on patchsets - https://phabricator.wikimedia.org/T87724#1064592 (10Jdforrester-WMF) 5Open>3Resolved a:3matmarex [01:51:20] (03CR) 10jenkins-bot: [V: 04-1] test: Reduce timeout in Process test from 100 to 10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/192740 (owner: 10Krinkle) [01:51:56] (03PS15) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) [01:52:02] (03CR) 10jenkins-bot: [V: 04-1] Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [01:52:20] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Technical-Debt: Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1064598 (10Krenair) a:3Krenair [01:53:46] mooeypoo: https://phabricator.wikimedia.org/T89880 [01:54:16] Hey James_F, was someone working on https://phabricator.wikimedia.org/T89878 ? [01:54:39] Krenair: mooeypoo's about to submit a commit in a few seconds' time. [01:54:42] There's nothing to indicate it on the task but I thought Moriel or someone mentioned it earlier. [01:54:45] Ah. :D [01:55:00] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10UI-Standardization, 5§ VisualEditor Q3 Blockers: mediawiki.feedback should use OOjs UI dialog - https://phabricator.wikimedia.org/T89878#1064612 (10Jdforrester-WMF) a:3Mooeypoo [01:55:01] Assigned now. :_) [01:55:22] I need to rebase https://gerrit.wikimedia.org/r/#/c/186548/ [01:55:25] This is ridiculous. [01:55:37] Eurgh. :-( [01:55:52] Krenair: Shout at edsanders tomorrow to get it merged ASAP? [01:57:35] I think Timo was going to do it. [01:58:39] (03PS16) 10Alex Monk: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) [01:58:51] Krenair: Yeah, I'll do it [01:59:40] https://github.com/karma-runner/karma/issues/1321 [01:59:42] (that's why Firefox fails sometimes) [01:59:50] (03CR) 10Krinkle: "recheck" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192740 (owner: 10Krinkle) [02:00:04] Krinkle: Fun. [02:00:42] If I'm right about https://phabricator.wikimedia.org/T76715#831981 then I should really talk to Roan next time he's not as busy as he is now. [02:01:17] (03CR) 10jenkins-bot: [V: 04-1] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [02:01:26] Or perhaps Trevor/Bartosz as it's related to GroupElement... hm [02:03:01] (03CR) 10Bartosz Dziewoński: [C: 032] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [02:03:06] (03CR) 10Bartosz Dziewoński: [C: 031] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [02:03:28] (03CR) 10Krinkle: [C: 032] Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [02:03:51] slave1006 has drive issues [02:03:52] ugh [02:05:43] (03Merged) 10jenkins-bot: Run JS/PHP comparison tests using karma [oojs/ui] - 10https://gerrit.wikimedia.org/r/191899 (https://phabricator.wikimedia.org/T87724) (owner: 10Bartosz Dziewoński) [02:05:47] Woo. [02:06:09] Krinkle: Your +2 was unnecessary there. [02:06:53] Krinkle: It had V-1'ed the patchset check pipeline, not the gate-and-submit one. ;-) [02:07:19] James_F: No, it failed the gate pipeline from your +2 [02:07:36] however mine was still redundant since Bartosz redid it already [02:07:41] Oh, sorry, yes. [02:07:52] Anyway. [02:08:55] * James_F heads off. [02:10:51] (03CR) 10Jforrester: [C: 032] test: Reduce timeout in Process test from 100 to 10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/192740 (owner: 10Krinkle) [02:10:57] 10VisualEditor, 10Continuous-Integration, 5§ VisualEditor Q3 Blockers: Investigate browser disconnect failures when running MediaWiki tests on labs slaves - https://phabricator.wikimedia.org/T89075#1064658 (10Krinkle) [02:11:07] 10VisualEditor, 10Continuous-Integration, 5§ VisualEditor Q3 Blockers: Investigate browser disconnect failures when running MediaWiki tests on labs slaves - https://phabricator.wikimedia.org/T89075#1027004 (10Krinkle) [02:14:31] (03PS1) 10Alex Monk: Check whether template is altered before allowing apply [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192750 (https://phabricator.wikimedia.org/T89913) [02:14:55] (03CR) 10Alex Monk: "Caused https://phabricator.wikimedia.org/T89913" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/189593 (owner: 10Trevor Parscal) [02:15:29] (03CR) 10Alex Monk: "(See also I1500f480)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/179002 (https://phabricator.wikimedia.org/T76926) (owner: 10Alex Monk) [02:16:04] 10VisualEditor, 5Patch-For-Review: [Regression wmf18] Reference and template dialog boxes display 'Apply changes' button as active upon opening - https://phabricator.wikimedia.org/T89913#1064664 (10Krenair) a:3Krenair [02:21:40] 10VisualEditor: [Regression pre-wmf19] Getting error "Cannot read property 'addMessages' of undefined" while switching to edit source mode - https://phabricator.wikimedia.org/T90248#1064666 (10Krenair) 5Open>3Invalid a:3Krenair Error occurred on the wikitext editor page, and it came straight from an on-wik... [02:21:58] (03CR) 10jenkins-bot: [V: 04-1] test: Reduce timeout in Process test from 100 to 10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/192740 (owner: 10Krinkle) [02:22:20] ^ because I took the slave offline (it was going to time out [02:22:34] re-do should make it go to a differenet slave [02:23:30] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: All inspectors get broken after VE tab is idle for a while - https://phabricator.wikimedia.org/T63078#1064670 (10Krenair) Has anyone run into this issue recently? [02:25:10] 10VisualEditor, 10Wikimedia-Hackathon-2015, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1064672 (10Jaredzimmerman-WMF) What does this mean exactly? given that this is post larger rollout(?) does... [02:25:25] 10VisualEditor, 10Wikimedia-Hackathon-2015, 10Wikimedia-Site-requests: Prompt existing users to enable VisualEditor for their account on the English Wikipedia - https://phabricator.wikimedia.org/T90665#1064673 (10Jaredzimmerman-WMF) [02:28:46] 10VisualEditor, 10VisualEditor-MediaWiki: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1064682 (10Krenair) Ran into this myself. Sorry. [02:32:37] (03PS1) 10Alex Monk: Set redirect enabled checkbox correctly when setting up the page settings UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192751 (https://phabricator.wikimedia.org/T89511) [02:32:49] 10VisualEditor, 5Patch-For-Review: [Regression wmf17]'Redirect this page to' checkbox is unchecked with pre-filled 'Target page for redirection' - https://phabricator.wikimedia.org/T89511#1064698 (10Krenair) a:3Krenair [02:36:15] (03CR) 10Alex Monk: [BrowserTest] Restore page settings language screenshots (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 (owner: 10Amire80) [02:38:15] https://github.com/karma-runner/karma-qunit/issues/24 [02:41:16] (03PS1) 10Alex Monk: Follow-up I5636e744: Only set noeditsection class for no edit checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192753 [02:41:49] (03CR) 10Alex Monk: [BrowserTest] Restore page settings language screenshots (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/187086 (owner: 10Amire80) [02:43:26] (03CR) 10jenkins-bot: [V: 04-1] Follow-up I5636e744: Only set noeditsection class for no edit checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192753 (owner: 10Alex Monk) [02:50:27] 10VisualEditor, 7Browser-Support-Apple-Safari: Displaytitle can't be selected until you have typed something or made other changes in Safari - https://phabricator.wikimedia.org/T89617#1064713 (10Krenair) [02:51:22] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192753 (owner: 10Alex Monk) [03:42:27] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1064748 (10Ricordisamoa) >>! In T88449#1064591, @Jdforrester-WMF wrote: > Is this bug now "MW-UI button designs are out of sync with OOjs UI and need to be... [04:10:53] (03PS1) 10Mattflaschen: VisualEditorDataModule depends on ext.visualEditor.mediaWiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192754 [04:13:10] (03CR) 10Catrope: [C: 032] "Sorry :S" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192754 (owner: 10Mattflaschen) [04:13:41] superm401: Sorry about that missing dependency :( I'm in the middle of writing a loader class that you guys should be able to use too [04:14:07] RoanKattouw, no need to apologize. [04:14:19] Basically I'm factoring out the code for doing the initial API request and loading RL modules [04:14:22] We'll have to look together at how Flow can use MW-specific stuff properly though (the existing classes have some stuff we can't use). [04:14:33] Well it's just that we never noticed because we're using a stupid way of loading things [04:14:35] Which I'm improving [04:14:44] What kind of MW-specific stuff can't you use? [04:15:08] If it's just a matter of splitting the existing massive RL modules into stuff you want and stuff you don't want, be my guest and split away [04:15:11] Random examples: Minor edit checkbox, submit logic, revids (we have them, but they work differently). [04:15:12] (03Merged) 10jenkins-bot: VisualEditorDataModule depends on ext.visualEditor.mediaWiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192754 (owner: 10Mattflaschen) [04:15:18] Ooh right [04:15:27] So you need some different mw.*Target stuff [04:15:38] Yeah we need to look at how to share that properly [04:15:54] Probably. For the initial spike, I'm just using standalone, but that's not going to work long-term (I hear links are used a lot on talk pages) [04:16:00] ;) [04:16:15] Once I stop being in "ZOMG VE PERF IS THE MOST IMPORTANT THING EVAR" mode (6 weeks from now?) I hope to be able to sit down with you and work on this [04:16:18] Actually [04:16:24] How high priority is this for you guys? [04:16:39] Is it backburner-y enough that we can make it a Lyon Hackathon project? [04:17:01] Probably not. [04:17:20] We can probably work something out before then, even if it is slightly duplicative (e.g. implementing a whole new target). [04:17:40] Hmm yeah [04:17:50] I'm just looking for a hackathon task is all :) [04:20:00] \\\\- [04:21:11] But yeah I hope you'll be able to use the code I'm working on now [04:31:54] RoanKattouw, you know why I would get "ConfigException from line 100 of /vagrant/mediawiki/includes/config/ConfigFactory.php: No registered builder available for visualeditor." from PHPUnit? [04:33:10] No idea [04:33:18] Sounds like a question for legoktm [04:39:45] hi [04:40:03] superm401: are you using master? [04:40:15] legoktm, of VisualEditor? [04:40:19] yes [04:40:29] Yes, with my VisualEditorDataModule fix. [04:40:47] Now on straight master. [04:42:00] the extension.json and VisualEditor.php in master look fine to me, so the only thing I can think of is that something is calling ConfigFactory::getDefaultInstance() too early, so VE doesn't have a chance to register in time [04:50:29] legoktm, I should clarify, it's from maintenance/checkLess.php specifically (which uses PHPUnit). [04:50:57] hmm, let me test [04:52:52] oh fun, the VE vagrant role is going to install everything >.> [04:54:04] superm401: yay, I can reproduce :P [04:54:13] Cool [04:55:26] 10VisualEditor, 6Release-Engineering, 7Browser-Tests: Create VisualEditor tests targeting the older version of browsers (Chrome and Firefox for now) for better backward compatibility - https://phabricator.wikimedia.org/T90678#1064772 (10Ryasmeen) 3NEW a:3Ryasmeen [04:55:39] superm401: it's just that maint script right? [04:55:51] As far as I know. [04:56:05] That script is a wrapper around PHPUnit tests, though. [04:57:22] yeah...it's doing weird stuff. Why is this a maintence script again? :P [04:58:49] 10VisualEditor, 10Wikimedia-Site-requests, 7Epic: Run test of having VisualEditor on for some newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90666#1064792 (10Eloquence) [04:58:50] legoktm, it was originally. It was changed to PHPUnit so Jenkins could run it, then the maint script was rewritten for back-compat. [04:59:17] oh no [04:59:27] this is a bug in extension registration.......argh [04:59:32] evilllllllllll [05:00:00] ? [05:00:10] it's my fault :P [05:00:16] I gathered that part. ;) [05:00:21] So does that make you evil? [05:01:52] just a little bit [05:02:46] I'm now trying to figure out how maintenance scripts work at all [05:06:26] the answer is they don't! [05:12:18] superm401: https://phabricator.wikimedia.org/T90680?workflow=create [05:12:59] Thanks [05:17:15] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1064805 (10Mattflaschen) [05:25:15] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1005540 (10Mattflaschen) [06:58:16] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 5WMF-deploy-2015-02-25_(1.25wmf19): VisualEditor: Clicking on somewhere else in the document after opening a link inspector inside a slug throws error "TypeError: Cannot read proper... - https://phabricator.wikimedia.org/T74494#1064912 [06:58:34] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-02-25_(1.25wmf19): Position event not emitted after slug close - https://phabricator.wikimedia.org/T85014#1064913 (10Ryasmeen) [06:58:55] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-02-25_(1.25wmf19): VisualEditor: Left/right cursoring into block slug doesn't trigger animations - https://phabricator.wikimedia.org/T67742#1064914 (10Ryasmeen) [07:04:20] (03CR) 10Amire80: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192729 (owner: 10Amire80) [07:44:22] (03PS1) 10Amire80: [BrowserTest] WIP: Update the Edit tab scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192770 [07:45:38] (03PS2) 10Amire80: [BrowserTest] WIP: Update the Edit tab scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192770 [08:48:44] (03PS3) 10Amire80: [BrowserTest] WIP: Update the Edit tab scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192770 [09:06:38] (03CR) 10Legoktm: "If1e8eab864ec2726afd36ac4565a9c30193a32f0 is the CI change." [oojs/ui] - 10https://gerrit.wikimedia.org/r/192272 (owner: 10Legoktm) [09:17:57] 10Cite, 10Wikimedia-Hackathon-2015: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#1064999 (10Qgil) [10:15:25] hello i am applying for outreach program for women this year. and want to work for mediawiki. i have the environment set up now. [15:01:14] 10VisualEditor: Allow carriage returns (↵ marks) to be found and replaced via the Search tool - https://phabricator.wikimedia.org/T90721#1065795 (10Elitre) 3NEW [15:11:34] 10VisualEditor: Keyboard shortcut for superscript from numerical keypad is not working - https://phabricator.wikimedia.org/T90723#1065835 (10Elitre) 3NEW [15:49:09] 10VisualEditor: Interlanguage links should only be visible in the page left column, not among the article's contents, immediately after they're created - https://phabricator.wikimedia.org/T90729#1065976 (10Elitre) 3NEW [16:06:43] Heya. [16:24:34] (03CR) 10Jforrester: [C: 032] "Whoops. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192753 (owner: 10Alex Monk) [16:25:13] James_F, whoops indeed :p [16:25:35] (03CR) 10Jforrester: [C: 032] "Double-whoops." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192750 (https://phabricator.wikimedia.org/T89913) (owner: 10Alex Monk) [16:25:38] Are the browsertests people expected to be +2ing changes to VE's JS like that? [16:26:06] Not really. [16:26:19] That was a follow-up to a patch we did merge for them earlier. [16:26:44] (03Merged) 10jenkins-bot: Follow-up I5636e744: Only set noeditsection class for no edit checkbox [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192753 (owner: 10Alex Monk) [16:26:46] (03PS1) 10Jforrester: Check whether template is altered before allowing apply [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192813 (https://phabricator.wikimedia.org/T89913) [16:26:59] 10VisualEditor, 5Patch-For-Review, 5WMF-deploy-2015-02-18_(1.25wmf18), 5WMF-deploy-2015-02-25_(1.25wmf19): [Regression wmf18] Reference and template dialog boxes display 'Apply changes' button as active upon opening - https://phabricator.wikimedia.org/T89913#1066060 (10Jdforrester-WMF) 5Open>3Resolved [16:27:16] Krenair: Want to make a core patch with that for this afternoon's SWAT? [16:27:39] (03Merged) 10jenkins-bot: Check whether template is altered before allowing apply [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192750 (https://phabricator.wikimedia.org/T89913) (owner: 10Alex Monk) [16:28:48] James_F, do we need to deploy that fix early..? [16:29:06] Krenair: "Early"? It's a regression in wmf18… [16:29:16] Oh, right. Point. [16:29:19] Maybe. [16:29:30] Ask Greg for permission? [16:30:12] Yeah but does it need to go in swat or can it not just wait for the train? [16:30:27] wmf18 his production in an hour or so. [16:30:47] Given that the feature was advertised as new in wmf17 it'd be a shame to break it after just a week. :-) [16:30:57] Okay, that makes sense I guess [16:31:10] I don't think I need Greg's permission... hm [16:32:58] James_F, according to the roadmap, it's wmf19 that's going out for new deployment today, and wmf18 is going to wikipedias [16:33:56] If we want it to get out before it goes to Wikipedias we do, [16:34:22] wmf19 has not been cut yet, I don't think. So we'd just want to update wmf18 before the train so that it doesn't break on wikipedias [16:34:26] And it's already broken on meta/etc. [16:34:37] Yes. Hence my cherry-pick to wmf18. [16:36:09] we're in a swat window already so I'll make the core change and deploy it [16:36:40] Kk. [16:44:53] (03CR) 10Esanders: "Can you give an example of where you might use this. Static methods already have the 'static' property of the class available as 'this'. W" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [16:45:42] (03CR) 10Esanders: "Oh, I see the attached bug" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [16:46:25] (03CR) 10Alex Monk: [C: 032] Check whether template is altered before allowing apply [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192813 (https://phabricator.wikimedia.org/T89913) (owner: 10Jforrester) [16:47:30] (03CR) 10Jforrester: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [16:48:24] (03Merged) 10jenkins-bot: Check whether template is altered before allowing apply [extensions/VisualEditor] (wmf/1.25wmf18) - 10https://gerrit.wikimedia.org/r/192813 (https://phabricator.wikimedia.org/T89913) (owner: 10Jforrester) [16:53:21] (03PS2) 10Jforrester: Follow-up I0b4b8dca: Set redirect checkbox correctly on page setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192751 (https://phabricator.wikimedia.org/T89511) (owner: 10Alex Monk) [16:53:48] (03CR) 10Jforrester: [C: 032] Follow-up I0b4b8dca: Set redirect checkbox correctly on page setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192751 (https://phabricator.wikimedia.org/T89511) (owner: 10Alex Monk) [16:54:21] Worth cherry-picking too? Or should we leave it? Page settings isn't really a common use case… [16:54:48] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2015-02-25_(1.25wmf19): [Regression wmf17] 'Redirect this page to' checkbox is unchecked with pre-filled 'Target page for redirection' - https://phabricator.wikimedia.org/T89511#1066129 (10Jdforrester-WMF) 5Open>3Resolved [16:55:14] James_F, probably not worth it [16:55:30] * James_F nods. [16:55:31] WFM. [16:57:16] (03Merged) 10jenkins-bot: Follow-up I0b4b8dca: Set redirect checkbox correctly on page setup [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192751 (https://phabricator.wikimedia.org/T89511) (owner: 10Alex Monk) [17:01:41] Krenair: Confirmed fixed in wmf18. [17:02:10] yeah [17:21:04] 10TemplateData: TemplateData GUI needs to let users set a string as the (secondary) value for 'deprecated' (as a description), not just boolean - https://phabricator.wikimedia.org/T90734#1066169 (10Krenair) [17:24:08] (03CR) 10Krinkle: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [17:24:16] (03CR) 10Krinkle: [C: 032] Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [17:24:40] Krenair: Whoops, thanks. [17:26:29] (03Merged) 10jenkins-bot: Use mw.Api to run requests rather than our own stuff in ve.init.mw.Target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/186548 (https://phabricator.wikimedia.org/T58659) (owner: 10Alex Monk) [17:30:42] Corruption alert: visualeditor-needcheck on ruwiki: https://ru.wikipedia.org/?diff=68865881 [17:31:03] hi. [17:32:47] 10VisualEditor, 10VisualEditor-MediaWiki: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1066210 (10Krenair) Looks like we'd need to load styles for mediawiki.action.view.redirectPage. [17:32:54] hey MatmaRex [17:40:18] 10VisualEditor, 10VisualEditor-MediaWiki: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1066245 (10Krenair) And probably also add redirectsub to contentSub. [17:42:07] 10VisualEditor, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-02-25_(1.25wmf19): VisualEditor: Use mw.Api library in mw.Target instead of our own functions - https://phabricator.wikimedia.org/T58659#1066275 (10Jdforrester-WMF) 5Open>3Resolved [17:42:07] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: mw.Target / ViewPageTarget re-write - https://phabricator.wikimedia.org/T75593#1066278 (10Jdforrester-WMF) [17:42:19] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-02-25_(1.25wmf19): Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1066292 (10Jdforrester-WMF) [17:42:25] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-02-25_(1.25wmf19): Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1036214 (10Jdforrester-WMF) Now fixed? [17:44:26] 10VisualEditor, 10VisualEditor-MediaWiki: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1066317 (10matmarex) It looks like we don't load the RL modules required for the new content after saving a page… Surely there must be a bug or five filed about that. [17:52:19] (03CR) 10Esanders: [C: 04-1] "We should make the header of the inspector consistent with the header of the context, i.e. left aligned, not bold and with an icon." (0313 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [17:53:45] Hey MatmaRex. [17:55:42] 10VisualEditor, 7Technical-Debt, 5WMF-deploy-2015-02-25_(1.25wmf19): VisualEditor: Use mw.Api library in mw.Target instead of our own functions - https://phabricator.wikimedia.org/T58659#1066396 (10Ricordisamoa) [17:56:29] 10VisualEditor: Search tool should show "No results found" message when appropriate - https://phabricator.wikimedia.org/T86317#1066399 (10Elitre) The one you launch with CTRL + F. It will say how many results were found for a successful search (in light grey, at the end of the search line), but it won't say anyt... [18:02:45] (03CR) 10Krinkle: [C: 032] test: Reduce timeout in Process test from 100 to 10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/192740 (owner: 10Krinkle) [18:05:15] (03Merged) 10jenkins-bot: test: Reduce timeout in Process test from 100 to 10 [oojs/ui] - 10https://gerrit.wikimedia.org/r/192740 (owner: 10Krinkle) [18:29:54] RoanKattouw_away: https://gerrit.wikimedia.org/r/#/c/192616/ [18:30:30] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (31fb72a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192616 (owner: 10Jforrester) [18:32:16] (03PS15) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [18:33:19] (03CR) 10jenkins-bot: [V: 04-1] Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [18:33:52] James_F, Did you say you sent me an email? Because I didn't see any. [18:33:56] (03Merged) 10jenkins-bot: Update VE core submodule to master (31fb72a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192616 (owner: 10Jforrester) [18:39:44] sucheta: Oh, yeah, no, you'd already filed so I didn't need to send you one, never mind. :-) [18:42:52] 10VisualEditor, 10VisualEditor-DataModel, 5§ VisualEditor Q3 Blockers: [Regression wmf18] Deleting the text inside a bullet/numbered item, heading, other nodes throws error - https://phabricator.wikimedia.org/T90478#1066624 (10Jdforrester-WMF) [18:43:40] MatmaRex: Is https://phabricator.wikimedia.org/T90478 caused by your canHandleOwnChildren change? (Or whatever it's called.) [18:45:19] (03PS3) 10Jforrester: Promisify ve.init.mw.Target#load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192495 (owner: 10Catrope) [18:45:27] James_F: which wiki gets the highest volume of ve edits? frwiki? [18:45:36] ori: frwiki, yes. [18:45:41] ori: Then I think itwiki. [18:47:23] 10VisualEditor, 5§ VisualEditor Q3 Blockers: Adding a template to an article on it.wp means VE gets "frozen" - https://phabricator.wikimedia.org/T90757#1066662 (10Elitre) 3NEW [18:47:54] (03CR) 10Catrope: [C: 032] "Fixes the bug I reported" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192785 (owner: 10Divec) [18:48:12] RoanKattouw: Do you want that to get put into wmf19? [18:48:48] 10VisualEditor, 5§ VisualEditor Q3 Blockers: Adding a template to an article on it.wp means VE gets "frozen" - https://phabricator.wikimedia.org/T90757#1066671 (10Jdforrester-WMF) What template? I just added five templates to https://it.wikipedia.org/wiki/Foo?veaction=edit without incident… [18:49:19] James_F: If it hasn't been cut yet, let's do it [18:49:26] Kk. [18:49:36] (03PS1) 10Kmenger: ButtonSelectwidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/192846 [18:49:42] 10VisualEditor, 5§ VisualEditor Q3 Blockers: Adding a template to an article on it.wp means VE gets "frozen" - https://phabricator.wikimedia.org/T90757#1066673 (10Jdforrester-WMF) Sorry, I also added `{{C|boh|pesca|gennaio 2012}}` without issue either. [18:50:06] (03Merged) 10jenkins-bot: Guess annotations better for complex changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192785 (owner: 10Divec) [18:50:53] (03PS1) 10Jforrester: Update VE core submodule to master (f81b990) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192847 [18:50:56] RoanKattouw: ^^^ [18:51:11] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (f81b990) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192847 (owner: 10Jforrester) [18:51:28] 10VisualEditor, 5§ VisualEditor Q3 Blockers: Adding a template to an article on it.wp means VE gets "frozen" - https://phabricator.wikimedia.org/T90757#1066687 (10Elitre) What if you add it at the very top (before the 2 disambiguation ones)? Freezes for me. [18:52:20] James_F: probably not. why would it? i can investigate [18:52:47] MatmaRex: Bug in handles-own-children nodes hence my suspicion. [18:53:03] my change, assuming our code is not entirely awful, should only affect the process of turning parsoid HTML into an editable page [18:53:19] (03Merged) 10jenkins-bot: Update VE core submodule to master (f81b990) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192847 (owner: 10Jforrester) [18:54:04] anyway, i touched it, i own it? ;) i'll look at it. [18:54:09] 10VisualEditor, 10MediaWiki-extensions-Translate, 7I18n: not able to mark a page for translation at mediawiki.org - https://phabricator.wikimedia.org/T90704#1066694 (10Amire80) p:5Normal>3Unbreak! [18:54:37] MatmaRex: Don't stress too much. :-) [18:55:13] 10VisualEditor, 10VisualEditor-MediaWiki: Newly created redirect looks different from its standard form - https://phabricator.wikimedia.org/T89449#1066698 (10Jdforrester-WMF) >>! In T89449#1066317, @matmarex wrote: > It looks like we don't load the RL modules required for the new content after saving a page… S... [18:55:16] 10VisualEditor, 10MediaWiki-extensions-Translate, 7I18n, 3LE-Sprint-83: not able to mark a page for translation at mediawiki.org - https://phabricator.wikimedia.org/T90704#1065381 (10Amire80) [18:56:28] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1066714 (10kaldari) @Jdforrester-WMF There are 4 issues identified in the bug description. I think the 3rd one may be fixed now. The first 2 are open quest... [19:04:00] (03PS1) 10Kmenger: ButtonOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192851 [19:04:04] 10OOjs-UI, 10UI-Standardization, 6WMF-Design, 7Design: button styles differ between OOjs UI and mediawiki UI - https://phabricator.wikimedia.org/T88449#1066746 (10kaldari) @Jdforrester-WMF Regarding the 1st issue (constructive, destructive, progressive buttons), it looks like the OOjs UI buttons are not in... [19:05:21] 10VisualEditor, 10Continuous-Integration, 5Patch-For-Review, 5§ VisualEditor Q3 Blockers: Jenkins: Convert mwext qunit from grunt-contrib-qunit (PhantomJS) to grunt-karma (Chromium) - https://phabricator.wikimedia.org/T74063#1066749 (10Jdforrester-WMF) [19:05:22] 10VisualEditor, 10VisualEditor-MediaWiki, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-02-25_(1.25wmf19): Test failure: Circular dependency between mw.Target and mw.ImageInfoCache - https://phabricator.wikimedia.org/T89435#1066748 (10Jdforrester-WMF) 5Open>3Resolved [19:06:12] 10VisualEditor, 10VisualEditor-ContentEditable, 5§ VisualEditor Q3 Blockers: Scroll to an item when it is selected e.g. when it has been newly inserted - https://phabricator.wikimedia.org/T53911#1066760 (10Jdforrester-WMF) [19:06:19] 10VisualEditor, 10VisualEditor-ContentEditable: Scroll highlighted node into view - https://phabricator.wikimedia.org/T90371#1066762 (10Jdforrester-WMF) [19:09:03] 10VisualEditor, 10VisualEditor-EditingTools: Allow carriage returns (↵ marks) to be found and replaced via the Search tool - https://phabricator.wikimedia.org/T90721#1066771 (10Jdforrester-WMF) p:5Triage>3Lowest [19:10:00] 10VisualEditor, 10VisualEditor-EditingTools: Keyboard shortcut for superscript from numerical keypad is not working - https://phabricator.wikimedia.org/T90723#1066777 (10Jdforrester-WMF) p:5Triage>3Low [19:10:55] 10VisualEditor, 10VisualEditor-Performance: Evaluate VisualEditor smoothness - https://phabricator.wikimedia.org/T90531#1066793 (10Jdforrester-WMF) p:5Triage>3Normal [19:11:21] 10VisualEditor, 10Beta-Cluster, 10Wikimedia-Search: File search on beta labs returns results from production commons and beta commons. VE search results are in unexpected order also. - https://phabricator.wikimedia.org/T90650#1064118 (10Jdforrester-WMF) [19:12:15] 10VisualEditor, 10Flow: Change detection for VE in Flow - https://phabricator.wikimedia.org/T90761#1066811 (10Mattflaschen) 3NEW [19:12:30] 10VisualEditor, 6Collaboration-Team, 10Flow: Change detection for VE in Flow - https://phabricator.wikimedia.org/T90761#1066818 (10Mattflaschen) [19:13:00] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1066820 (10Mattflaschen) [19:13:42] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1066825 (10DannyH) [19:13:50] 10VisualEditor, 10Flow: Sometimes VE toolbar gets stuck in upper left until reflow/resize window - https://phabricator.wikimedia.org/T90762#1066828 (10Mattflaschen) 3NEW [19:14:03] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1005540 (10DannyH) [19:14:13] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1066838 (10Mattflaschen) [19:16:00] (03PS3) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [19:16:31] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow: Implement VE layout from Pau's mockups - https://phabricator.wikimedia.org/T90764#1066862 (10Mattflaschen) 3NEW [19:17:16] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1066876 (10Mattflaschen) [19:17:58] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [19:18:06] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1005540 (10Mattflaschen) [19:18:44] (03PS1) 10Divec: Recurse more frugally in oo.compare [oojs/core] - 10https://gerrit.wikimedia.org/r/192861 [19:19:26] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1066888 (10Mattflaschen) [19:19:57] (03CR) 10Divec: "Is the unit test really worth anything?" [oojs/core] - 10https://gerrit.wikimedia.org/r/192861 (owner: 10Divec) [19:20:00] 10VisualEditor, 6Collaboration-Team, 10Flow: Add relevant MW features to VE on Flow - https://phabricator.wikimedia.org/T90760#1066890 (10Mattflaschen) [19:23:01] ori: https://gerrit.wikimedia.org/r/#/c/192861 :) [19:26:22] 10VisualEditor, 6Collaboration-Team, 10Flow: Add relevant MW features to VE on Flow (spike) - https://phabricator.wikimedia.org/T90760#1066917 (10Mattflaschen) [19:27:02] 10VisualEditor, 6Collaboration-Team, 10Flow: Add relevant MW features to VE on Flow (spike) - https://phabricator.wikimedia.org/T90760#1066920 (10DannyH) [19:27:32] 10VisualEditor, 6Collaboration-Team, 10Flow: Add relevant MW features to VE on Flow (spike) - https://phabricator.wikimedia.org/T90760#1066794 (10DannyH) [19:28:42] 10VisualEditor, 6Collaboration-Team, 10Flow: Change detection for VE in Flow - https://phabricator.wikimedia.org/T90761#1066931 (10DannyH) [19:29:28] 10VisualEditor, 6Collaboration-Team, 10Flow: Change detection for VE in Flow - https://phabricator.wikimedia.org/T90761#1066933 (10DannyH) p:5Triage>3Normal [19:31:48] (03Abandoned) 10Catrope: Promisify ve.init.mw.Target#load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192495 (owner: 10Catrope) [19:38:55] MatmaRex, you think there are other places in core relying on similar modules to https://phabricator.wikimedia.org/T89449#1066317 ? [19:39:13] (03PS17) 10Cscott: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [19:39:15] (03PS16) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [19:39:17] (03PS1) 10Cscott: Teach docparser about @member, @see, and PHP pass-by-reference (&$foo). [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 [19:40:50] (03CR) 10Cscott: "We seem to be running bin/testsuitegenerator.rb from jenkins now, and it's started breaking my patches. :( This fixes it." [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 (owner: 10Cscott) [19:41:00] Krenair: define 'similar' [19:41:04] and define 'core' [19:41:18] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow: Implement VE layout from Pau's mockups - https://phabricator.wikimedia.org/T90764#1066998 (10DannyH) [19:41:25] (03CR) 10jenkins-bot: [V: 04-1] Teach docparser about @member, @see, and PHP pass-by-reference (&$foo). [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 (owner: 10Cscott) [19:41:37] if you mean that content requires RL modules, and mediawiki core, then yes, plenty [19:41:52] like, say, galleries [19:42:18] but redirects might be somewhat unique [19:43:33] 10VisualEditor, 6Collaboration-Team, 10Flow: Flow: Implement VE layout from Pau's mockups - https://phabricator.wikimedia.org/T90764#1067012 (10DannyH) p:5Triage>3Normal [19:44:55] (03PS18) 10Cscott: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [19:44:57] (03PS17) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [19:44:59] (03PS2) 10Cscott: Teach docparser about @member, @see, and PHP pass-by-reference (&$foo). [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 [19:49:54] MatmaRex, yeah, content from MW core that relies on RL modules [19:50:36] (03CR) 10Cscott: "So the only thing that's not done is moving OO.ui.infuse to OO.ui.Element.static.infuse, but I might do that as a follow-up patch because " [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [19:51:12] (03CR) 10Ori.livneh: [C: 032] Recurse more frugally in oo.compare [oojs/core] - 10https://gerrit.wikimedia.org/r/192861 (owner: 10Divec) [19:51:50] Krenair: What about LivePreview in WikiEditor when you add a redirect. What happens there? [19:52:27] (03CR) 10Bartosz Dziewoński: "Oh, thanks. Sorry for breaking stuff, the parser is indeed rather poor. Isn't @member the same as @method or @property?" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 (owner: 10Cscott) [19:53:46] James_F, the same issue as with VE, I think [19:54:25] Ha. [19:54:32] yep. [19:54:33] (03CR) 10Cscott: "No, @member is used to name the class associated with a method: https://github.com/senchalabs/jsduck/wiki/@member" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 (owner: 10Cscott) [19:56:34] (03CR) 10Esanders: [C: 04-1] "PS2" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [19:56:36] (03Merged) 10jenkins-bot: Recurse more frugally in oo.compare [oojs/core] - 10https://gerrit.wikimedia.org/r/192861 (owner: 10Divec) [19:56:51] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References: References in media captions do not appear in Re-Use Reference list - https://phabricator.wikimedia.org/T87134#1067069 (10Jdforrester-WMF) [19:58:03] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Technical-Debt, 5§ VisualEditor Q3 Blockers: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#1067084 (10Jdforrester-WMF) [19:59:47] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Technical-Debt, 5§ VisualEditor Q3 Blockers: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#484277 (10Jdforrester-WMF) [19:59:48] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References: References in media captions do not appear in Re-Use Reference list - https://phabricator.wikimedia.org/T87134#1067098 (10Jdforrester-WMF) [20:02:20] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References: References in media captions do not appear in Re-Use Reference list - https://phabricator.wikimedia.org/T87134#1067127 (10Jdforrester-WMF) [20:02:21] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: If a reference is defined in a template, and re-used outside of it, and you delete the template, then the reference contents get lost - https://phabricator.wikimedia.org/T67301#1067126 (10Jdforrester-WMF) [20:02:30] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Please strip trailing spaces and returns from media or image captions - https://phabricator.wikimedia.org/T68736#1067130 (10Jdforrester-WMF) [20:02:31] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References: References in media captions do not appear in Re-Use Reference list - https://phabricator.wikimedia.org/T87134#984484 (10Jdforrester-WMF) [20:03:01] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Please strip trailing spaces and returns from media or image captions - https://phabricator.wikimedia.org/T68736#700795 (10Jdforrester-WMF) [20:03:01] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: If you open the image inspector, and the image doesn't have a type specified (like thumb), then you can't get out again - https://phabricator.wikimedia.org/T67166#1067135 (10Jdforrester-WMF) [20:03:02] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: When inserting an image, set its caption by default to be the Commons image description - https://phabricator.wikimedia.org/T53032#1067134 (10Jdforrester-WMF) [20:03:03] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Media: VisualEditor: Be able to set a non-image multi-paged item's display page (page=) in the media dialog - https://phabricator.wikimedia.org/T64673#1067140 (10Jdforrester-WMF) [20:03:04] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Media: VisualEditor: Be able to set a multimedia item's thumb position (thumbtime=) in the media dialog - https://phabricator.wikimedia.org/T64676#1067142 (10Jdforrester-WMF) [20:03:05] 10VisualEditor: VisualEditor: Be able to search for an existing image by name - https://phabricator.wikimedia.org/T72243#1067136 (10Jdforrester-WMF) [20:03:06] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Support non-image media - https://phabricator.wikimedia.org/T69690#1067138 (10Jdforrester-WMF) [20:03:07] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Media: VisualEditor: Make CE-surface fixes to make TMH's media items display correctly - https://phabricator.wikimedia.org/T64678#1067139 (10Jdforrester-WMF) [20:03:08] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Media: VisualEditor: Be able to set a multimedia item's start position (start=) in the media dialog - https://phabricator.wikimedia.org/T64675#1067141 (10Jdforrester-WMF) [20:03:09] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to set an item's size in upright terms in the media edit dialog - https://phabricator.wikimedia.org/T64671#1067137 (10Jdforrester-WMF) [20:03:10] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Please show the file name in the media dialog, and make it easy to copy it - https://phabricator.wikimedia.org/T71726#1067147 (10Jdforrester-WMF) [20:03:11] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Media: VisualEditor: Be able to set a multimedia item to not show an icon (noicon) in the media dialog - https://phabricator.wikimedia.org/T64674#1067143 (10Jdforrester-WMF) [20:03:12] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Design a good solution for image alignment "none" vs "default" - https://phabricator.wikimedia.org/T68460#1067146 (10Jdforrester-WMF) [20:03:13] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Centred images can appear in VE as overlapped by another image, then can't be selected - https://phabricator.wikimedia.org/T64590#1067145 (10Jdforrester-WMF) [20:03:14] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to copy the name of an image - https://phabricator.wikimedia.org/T72244#1067148 (10Jdforrester-WMF) [20:03:15] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0, 7Verified-in-Phase2: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#1067144 (10Jdforrester-WMF) [20:03:15] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Don't specify the default alignment for images (in the resulting wikitext) - https://phabricator.wikimedia.org/T63324#1067152 (10Jdforrester-WMF) [20:03:16] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Block-level media items' placement is incorrect (no clear after thumbs) - https://phabricator.wikimedia.org/T50845#1067150 (10Jdforrester-WMF) [20:03:17] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Why doesn't the Insert menu in the main editor have the same order as the Insert menu in the Image caption editor? - https://phabricator.wikimedia.org/T64286#1067153 (10Jdforrester-WMF) [20:03:18] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Groups of images are alienated under certain circumstances - https://phabricator.wikimedia.org/T52165#1067151 (10Jdforrester-WMF) [20:03:19] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Have a "remove from page" button in media settings dialog - https://phabricator.wikimedia.org/T53764#1067149 (10Jdforrester-WMF) [20:03:20] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Provide a button in the image dialog box's advanced settings to set "default" alignment for images - https://phabricator.wikimedia.org/T63323#1067154 (10Jdforrester-WMF) [20:03:21] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Double-clicking on a node (image/template/reference/…) should open its dialog - https://phabricator.wikimedia.org/T52996#1067159 (10Jdforrester-WMF) [20:03:22] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Set image alignment in the media dialog - https://phabricator.wikimedia.org/T53293#1067157 (10Jdforrester-WMF) [20:03:23] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Changing a media item type from "thumbnail" to "frame" doesn't hide the zoom icon - https://phabricator.wikimedia.org/T64139#1067156 (10Jdforrester-WMF) [20:03:24] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Pressing "enter"/"return" on a selected node should open its dialog - https://phabricator.wikimedia.org/T56827#1067160 (10Jdforrester-WMF) [20:03:25] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: [Regression pre-wmf17] Please round image sizes to whole numbers - https://phabricator.wikimedia.org/T64279#1067155 (10Jdforrester-WMF) [20:03:26] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Dialog to manipulate image properties (type, alignment, border, size, caption, alt text) - https://phabricator.wikimedia.org/T40129#1067158 (10Jdforrester-WMF) [20:03:27] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Highlights triggered while resizing aren't moved correctly - https://phabricator.wikimedia.org/T57787#1067162 (10Jdforrester-WMF) [20:03:28] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Double-clicking on an image in the image finder inserts it twice - https://phabricator.wikimedia.org/T53823#1067161 (10Jdforrester-WMF) [20:03:29] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: It should be clearer to users that they are inserting a media item in an odd place (e.g. into the middle of a word, middle of a paragraph) - https://phabricator.wikimedia.org/T53292#1067166 (10Jdforrester-WMF) [20:03:30] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Highlights, resize handles, etc. not repositioned on window resize - https://phabricator.wikimedia.org/T57789#1067165 (10Jdforrester-WMF) [20:03:31] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified: VisualEditor: When an image has a full size which is smaller than the default size, it does not set the default size to the value of full size - https://phabricator.wikimedia.org/T64293#1067163 (10Jdforrester-WMF) [20:03:32] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified: VisualEditor: Media insertion dialog should display a message if no media is found for the given search - https://phabricator.wikimedia.org/T54463#1067164 (10Jdforrester-WMF) [20:03:33] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame - https://phabricator.wikimedia.org/T64681#1067171 (10Jdforrester-WMF) [20:03:34] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Ability to switch image used whilst maintaining the caption and other settings - https://phabricator.wikimedia.org/T53033#1067167 (10Jdforrester-WMF) [20:03:35] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified: VisualEditor: Image flickers but shield stays in the correct position while dragging the page on Mac - https://phabricator.wikimedia.org/T64898#1067170 (10Jdforrester-WMF) [20:03:36] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified: VisualEditor: Image resizing handlers appear on all four corners (not just one / two) if image is in another image's caption editor - https://phabricator.wikimedia.org/T63968#1067172 (10Jdforrester-WMF) [20:03:37] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Too many draggable image resizing handlers for frameless, frame, and basic images (thumbnails working as intended) - https://phabricator.wikimedia.org/T64283#1067169 (10Jdforrester-WMF) [20:03:38] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Image size is shrinking to a dot size after exceeding a specific value while setting the image size - https://phabricator.wikimedia.org/T63282#1067168 (10Jdforrester-WMF) [20:03:39] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Backwards cursoring of an image inside an image's caption selects the sub-image, not the main image (and then breaks nastily) - https://phabricator.wikimedia.org/T64395#1067177 (10Jdforrester-WMF) [20:03:40] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Node API re-write - https://phabricator.wikimedia.org/T47062#1067179 (10Jdforrester-WMF) [20:03:41] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to specify a file name in the media or image dialog, even if search can't find the file - https://phabricator.wikimedia.org/T68046#1067175 (10Jdforrester-WMF) [20:03:42] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Link tool is too small when adding captions to new images - https://phabricator.wikimedia.org/T71511#1067176 (10Jdforrester-WMF) [20:03:43] 10VisualEditor, 10VisualEditor-EditingTools, 7Accessibility, 7Browser-Support-Apple-Safari: VisualEditor: Can't tab from Caption to Alt text fields in image media dialog box, in Safari only - https://phabricator.wikimedia.org/T69162#1067174 (10Jdforrester-WMF) [20:03:44] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Inserting media dialog has no confirmation button - https://phabricator.wikimedia.org/T53905#1067178 (10Jdforrester-WMF) [20:03:45] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Insert media dialog lets you select an image via mouseup even if mousedown occurred elsewhere - https://phabricator.wikimedia.org/T58648#1067173 (10Jdforrester-WMF) [20:03:46] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: When image search results are returned very slowly, remove the "No results found" error message - https://phabricator.wikimedia.org/T72273#1067182 (10Jdforrester-WMF) [20:03:47] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to access a display file's description page from within VE (e.g. in the media settings dialog) - https://phabricator.wikimedia.org/T63367#1067185 (10Jdforrester-WMF) [20:03:48] 10VisualEditor, 7Technical-Debt: VisualEditor: Merge the media editing and gallery editing dialogs - https://phabricator.wikimedia.org/T64677#1067184 (10Jdforrester-WMF) [20:03:49] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: When using browser zoom, image overlays (resize, edit) become too small and inaccesible - https://phabricator.wikimedia.org/T65171#1067180 (10Jdforrester-WMF) [20:03:50] 10VisualEditor, 10VisualEditor-EditingTools, 7Tracking: VisualEditor: Support non-image media (tracking) - https://phabricator.wikimedia.org/T69689#1067181 (10Jdforrester-WMF) [20:03:51] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Links added to captions for new images not quite working - https://phabricator.wikimedia.org/T71510#1067183 (10Jdforrester-WMF) [20:03:52] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Adding an image at the top of a list puts the image inside the list; instead it should insert it in the previous position (in the

) - https://phabricator.wikimedia.org/T57767#1067186 (10Jdforrester-WMF) [20:03:53] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog - https://phabricator.wikimedia.org/T51662#1067187 (10Jdforrester-WMF) [20:03:54] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to set a over-ride thumbnail (thumb=…) in the media edit dialog - https://phabricator.wikimedia.org/T64669#1067191 (10Jdforrester-WMF) [20:03:55] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Media settings dialog should show a preview of the media item - https://phabricator.wikimedia.org/T54461#1067189 (10Jdforrester-WMF) [20:03:56] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Caption of nested image is centered in image dialog box - https://phabricator.wikimedia.org/T64287#1067188 (10Jdforrester-WMF) [20:03:57] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Allow re-positioning of selected media items using arrow keys - https://phabricator.wikimedia.org/T56472#1067190 (10Jdforrester-WMF) [20:03:58] 10OOjs-UI: OOjs UI: Dialogs do not horizontally scroll in narrow windows - https://phabricator.wikimedia.org/T53755#1067198 (10Jdforrester-WMF) [20:03:59] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Centre floated image next to right floated image means image is shown partially offscreen, and shield is put in the wrong place - https://phabricator.wikimedia.org/T64850#1067195 (10Jdforrester-WMF) [20:04:00] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Don't allow users to insert images inside images' captions inside images' captions, as MediaWiki can't cope with that - https://phabricator.wikimedia.org/T63564#1067194 (10Jdforrester-WMF) [20:04:01] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Some images not displayed in the correct place ? due to floating - https://phabricator.wikimedia.org/T68228#1067196 (10Jdforrester-WMF) [20:04:02] 10VisualEditor: VisualEditor: Odd removal of table inside an image caption - https://phabricator.wikimedia.org/T63064#1067197 (10Jdforrester-WMF) [20:04:03] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to set a over-ride link target (link=…) in the media edit dialog - https://phabricator.wikimedia.org/T64672#1067192 (10Jdforrester-WMF) [20:04:04] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Be able to set an item's alignment (baseline/middle/…) in the media edit dialog - https://phabricator.wikimedia.org/T64670#1067193 (10Jdforrester-WMF) [20:04:07] 10VisualEditor: Users unintentionally add line breaks when inserting or moving images - https://phabricator.wikimedia.org/T54657#1067200 (10Jdforrester-WMF) [20:04:10] 10VisualEditor, 7Browser-Support-Firefox: VisualEditor: No vertical scrollbar on insert media (Firefox) - https://phabricator.wikimedia.org/T62966#1067199 (10Jdforrester-WMF) [20:04:11] 10VisualEditor: Stop specifying the (default) size of media items in VisualEditor - https://phabricator.wikimedia.org/T63565#1067201 (10Jdforrester-WMF) [20:04:12] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Plugins, 7Tracking: VisualEditor: Support media (tracking) - https://phabricator.wikimedia.org/T39870#1067132 (10Jdforrester-WMF) [20:04:13] 10VisualEditor, 10VisualEditor-ContentEditable: Provide true nested, inheriting surfaces - https://phabricator.wikimedia.org/T76550#1067206 (10Jdforrester-WMF) [20:04:14] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Technical-Debt, 5§ VisualEditor Q3 Blockers: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#1067207 (10Jdforrester-WMF) [20:04:15] 10VisualEditor, 10VisualEditor-DataModel, 5§ VisualEditor Q3 Blockers: [Regression wmf18] Deleting the text inside a bullet/numbered item, heading, other nodes throws error - https://phabricator.wikimedia.org/T90478#1067208 (10matmarex) James guilted me into debugging this a bit. A good place to put a break... [20:05:35] (03CR) 10Bartosz Dziewoński: "Oh, right, it's the stupidly named one. ;)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 (owner: 10Cscott) [20:07:08] (03PS1) 10Kmenger: OptionWidget: Add description and descriptions of methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/192869 [20:10:58] (03PS35) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [20:11:10] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Citoid: Citoid: Reopening the Web Reference in media shows the details of the first entry(valid/ invalid-URL /DOI; whatever was entered first in the "Autofill from URL" dialog upon initialization) - https://phabricator.wikimedia.org/T90480#1067258 (10Jdfo... [20:11:12] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References: References in media captions do not appear in Re-Use Reference list - https://phabricator.wikimedia.org/T87134#1067259 (10Jdforrester-WMF) [20:11:25] (03CR) 10Paladox: "@Mattflaschen please review." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) (owner: 10Paladox) [20:12:08] (03CR) 10Bartosz Dziewoński: [C: 032] Allow passing positional parameters inside the config object [oojs/ui] - 10https://gerrit.wikimedia.org/r/192722 (https://phabricator.wikimedia.org/T89687) (owner: 10Cscott) [20:12:10] (03PS23) 10Paladox: Convert .css to .less [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 [20:12:25] woot! [20:12:25] (03CR) 10Bartosz Dziewoński: "For future reference, I generally don't mind people amending my patches. :)" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński) [20:12:32] (03Abandoned) 10Bartosz Dziewoński: Allow passing positional parameters inside the config object [oojs/ui] - 10https://gerrit.wikimedia.org/r/191214 (https://phabricator.wikimedia.org/T89687) (owner: 10Bartosz Dziewoński) [20:12:48] (03CR) 10Paladox: "@Someone please review. I think I have sorted out all the issue. I have tested it on my site and seems to be working." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/189333 (owner: 10Paladox) [20:13:47] (03Merged) 10jenkins-bot: Allow passing positional parameters inside the config object [oojs/ui] - 10https://gerrit.wikimedia.org/r/192722 (https://phabricator.wikimedia.org/T89687) (owner: 10Cscott) [20:14:25] 10WikiEditor, 7Easy, 5Patch-For-Review, 7Upstream: WikiEditor: Add SVG versions of editing toolbar icons - https://phabricator.wikimedia.org/T37342#1067277 (10Paladox) Thankyou. your really good at it. [20:15:17] (03CR) 10Jforrester: [C: 031] "Shall we put this in the new release?" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [20:16:08] (03CR) 10Jforrester: "… fails the tests. Are the tests wrong?" [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 (owner: 10Ori.livneh) [20:17:54] (03PS2) 10Bartosz Dziewoński: FormLayout: Allow adding child layouts via config [oojs/ui] - 10https://gerrit.wikimedia.org/r/191832 (https://phabricator.wikimedia.org/T89750) [20:18:32] (03CR) 10Bartosz Dziewoński: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 (owner: 10Ori.livneh) [20:19:30] (03CR) 10Cscott: "Seems good. This will require some small tweaks to https://gerrit.wikimedia.org/r/190367 I think. Let's be careful about patch sequencin" [oojs/ui] - 10https://gerrit.wikimedia.org/r/191832 (https://phabricator.wikimedia.org/T89750) (owner: 10Bartosz Dziewoński) [20:20:13] cscott: feel like merging that, maybe? :) [20:20:27] MatmaRex: Tsk. :-) [20:21:13] (03CR) 10Bartosz Dziewoński: "They're not wrong, merely broken." [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 (owner: 10Ori.livneh) [20:22:17] (03CR) 10Jforrester: [C: 031] Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 (owner: 10Ori.livneh) [20:22:46] TrevorP|Away: When you get back, +2s on https://gerrit.wikimedia.org/r/#/q/status:open+project:oojs/core,n,z would be good so I can do a release. [20:24:29] 10VisualEditor, 10VisualEditor-EditingTools, 5Patch-For-Review: VisualEditor: Show a user's recent uploads in the MW insert media dialog - https://phabricator.wikimedia.org/T62398#1067311 (10MarkAHershberger) This issue (can't see recent uploads in the selection) was pointed out to me by a client. At first... [20:34:09] 10VisualEditor, 5§ VisualEditor Q3 Blockers: Adding a template to an article on it.wp means VE gets "frozen" - https://phabricator.wikimedia.org/T90757#1067370 (10Jdforrester-WMF) Worked fine for me… Chrome and Firefox both. Do you have a local gadget enabled that breaks it? What happens if you do it in an in... [20:34:43] (03CR) 10Cscott: "recheck" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [20:35:27] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I'm fairly sure that `new OO.ui.HtmlSnippet( foo )` could be replaced by `$( $.parseHTML( foo ) )` in 100% of cases. But, I guess it does " (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192723 (owner: 10Cscott) [20:36:14] (03CR) 10Bartosz Dziewoński: [C: 032] Teach docparser about @member, @see, and PHP pass-by-reference (&$foo). [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 (owner: 10Cscott) [20:37:58] cscott: out of curiosity, do you usually do things in ruby? or was that motivated just by the necessity? ;) [20:38:18] necessity. i program in ruby when i have to. [20:38:31] my throwaway scripts are all written in javascript these days :) [20:39:01] how bad was it? these scripts are rather… barebones [20:39:12] (03CR) 10Cscott: "Huh. jscs didn't like this on my localhost, but an `npm install` fixed things. Never mind, carry on." [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [20:39:36] i just had to look up what the line continuation syntax was in ruby, since rubocop yelled at me [20:40:29] the hard part was figuring out that it was jenkins who had changed, not my patch. [20:41:32] rubocop is stupid, if you ask me. (i'm not the one who added it to the repo ;) ) [20:47:57] (03PS1) 10Cscott: DON'T PUSH: update ooui-core to include .static.class property. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192877 [20:47:59] (03PS1) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 [20:49:26] (03CR) 10jenkins-bot: [V: 04-1] Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott) [20:50:53] cscott: Neat. [20:55:16] 10VisualEditor, 5§ VisualEditor Q3 Blockers: Adding a template to an article on it.wp means VE gets "frozen" - https://phabricator.wikimedia.org/T90757#1067434 (10Elitre) I still get it, just tried (I knew it wasn't going to change because this was originarily reported by an IP). [20:56:40] James_F: is now a good time to deploy the oojs/ui phpcs change? [20:57:06] (03CR) 10Trevor Parscal: [C: 032] Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [20:57:39] (03CR) 10Cscott: [C: 032] FormLayout: Allow adding child layouts via config [oojs/ui] - 10https://gerrit.wikimedia.org/r/191832 (https://phabricator.wikimedia.org/T89750) (owner: 10Bartosz Dziewoński) [20:57:44] ooh, what change? [20:57:58] https://gerrit.wikimedia.org/r/#/c/192272/ [20:58:04] now I just need https://gerrit.wikimedia.org/r/191100 brought over into oojs-ui [20:58:49] (03CR) 10jenkins-bot: [V: 04-1] Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [20:59:10] (03CR) 10Trevor Parscal: [C: 032] Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 (owner: 10Ori.livneh) [20:59:32] phpcs is passing? huh. [20:59:52] :P [21:02:13] (03Merged) 10jenkins-bot: FormLayout: Allow adding child layouts via config [oojs/ui] - 10https://gerrit.wikimedia.org/r/191832 (https://phabricator.wikimedia.org/T89750) (owner: 10Bartosz Dziewoński) [21:03:19] Hello [21:03:48] 10OOjs-UI, 5OOjs-UI-next-release, 5Patch-For-Review: Inconsistency in how child content is added to widgets - https://phabricator.wikimedia.org/T89750#1067470 (10Jdforrester-WMF) 5Open>3Resolved [21:04:01] Hello evariste. [21:04:10] (03Merged) 10jenkins-bot: Use Node#isEqualNode to compare node objects [oojs/core] - 10https://gerrit.wikimedia.org/r/192479 (owner: 10Ori.livneh) [21:04:23] I managed to install VE on a private wiki for a non-profit but I still have one problem: when clicking Insert > Media, there are no media available... [21:04:56] evariste: Ah, this is a common issue related to how the wiki is set up. [21:05:08] (03PS3) 10Jforrester: Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [21:05:34] James_F: is there a way to fix it ? [21:05:55] evariste: I'm trying to find documentation. [21:07:17] evariste, do you have any images at all in your local wiki? [21:07:25] or are you intending to search from commons ? [21:07:30] (03CR) 10Jforrester: [C: 032] Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [21:08:43] mooeypoo: I have images on the wiki. If I enable instant commons, I can find images from there but still not my local images [21:09:04] (03CR) 10jenkins-bot: [V: 04-1] Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [21:09:33] Oy. [21:09:39] James_F: so, when are we enabling manual merges? [21:09:48] MatmaRex: That's a real failure. [21:10:10] MatmaRex: IE11. [21:10:15] it happily passed just minutes ago. [21:10:22] 10VisualEditor, 6Collaboration-Team, 10Flow: Spike: Add relevant MW features to VE on Flow - https://phabricator.wikimedia.org/T90760#1067510 (10DannyH) [21:10:26] MatmaRex: We only run the actual browser ones on gate. [21:10:41] that's silly. why do we do that? [21:10:45] MatmaRex: To make the tests faster. You can run them locally with karma:ci1. [21:10:49] evariste, okay .Hm. Any errors in the console? [21:10:49] And karma:ci2. [21:10:53] they're already fast [21:11:12] MatmaRex: Not when you spend 3+ minutes shelling out to SauceLabs. [21:11:47] also, we have, on average, about one patch a week in that repo [21:12:07] Nowadays. [21:12:26] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-R-2015-03-11, 10Flow: R1. Spike: Add relevant MW features to VE on Flow - https://phabricator.wikimedia.org/T90760#1067514 (10DannyH) [21:12:26] When we did this originally it had more traffic. [21:12:37] 10VisualEditor, 10Collaboration-Team-Sprint-R-2015-03-11, 10Flow: R1. Spike: Add relevant MW features to VE on Flow - https://phabricator.wikimedia.org/T90760#1066794 (10DannyH) [21:12:41] MatmaRex: https://saucelabs.com/tests/6a75f1d88c244b8a963c67efa3593f38 [21:13:04] (Not that that's very helpful.) [21:13:09] mooeypoo: no, nothing. (I'm assuming we're talking about the browser console...) [21:13:12] i'm checking it out locally right now, actually. [21:14:26] evariste, yeah, the browser console. Hm. Give me a second, I'm testing [21:15:14] MatmaRex: IE6 and IE9 tests also fail (`grunt karma:ci2`). [21:16:15] (03CR) 10Bartosz Dziewoński: Serialize PHP widget state into data-ooui attribute (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [21:16:50] cscott: just some light comments. i think that's all good. i'm going to try extending our test suite to verify that roundtripping configs works. [21:17:14] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1067564 (10DannyH) This spike is resolved, and tickets are in Spri... [21:17:21] 10VisualEditor, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q2. Define and estimate work for Minimum Viable Product of VisualEditor in Flow (spike) (Catalan, Translatewiki) - https://phabricator.wikimedia.org/T88182#1067565 (10DannyH) 5Open>3Resolved [21:20:02] mooeypoo: I can find my local images when I use the regular mediawiki search box [21:20:33] do they have to be indexed in some special way?? [21:22:08] evariste, can you do me a favor? In your browser's console, can you type: mw.util.wikiScript( 'api' ) [21:22:21] does this give you a sensible result? [21:24:53] mooeypoo: I get "//wiki.tillsammansodlingen.se/api.php" [21:25:04] looks right. [21:25:13] could the problem be that I don't have a url in the address? [21:25:24] (03PS1) 10Kmenger: SelectWidget: Add description for config, methods, events [oojs/ui] - 10https://gerrit.wikimedia.org/r/192890 [21:25:27] *not url, protocol [21:25:27] what do you mean? [21:25:29] oh [21:25:30] no no [21:25:33] I don't have a protocol [21:25:33] it should still work [21:25:39] ok... [21:25:44] I'm checking a couple of things, hang on [21:30:16] evariste, O [21:30:24] (sorry, enter slipped) [21:30:49] evariste, i'm testing this issue and I hope to figure it out. I am going to get lunch and come back. [21:31:32] evariste, you can check back later if you want, I don't want to keep you waiting. If you want to open a Phabricator task on it, share the link, I'll make sure I update it with details when I have them [21:31:52] mooeypoo: I might not be there when you come back (22:30 here...) I'lll open a task [21:31:53] Thanks [21:33:53] evariste, awesome, send me the link (or feel free to assign it to me, just "Mooeypoo" on phabricator) and I'll update there [21:33:57] and ask questions if I need more details [21:34:11] bbiab [21:34:16] RoanKattouw_away, James_F: http://people.wikimedia.org/~ori/ve/ [21:34:32] keep in mind that since this is frwiki only, it is also wmf17 only [21:35:15] you can see that median perf is OK, but we do catastrophically bad relatively often [21:35:28] those are presumably parsoid cache misses. we have to make sure those don't happen with restbase. [21:36:50] 10VisualEditor: Cannot insert local picture in visual editor - https://phabricator.wikimedia.org/T90795#1067690 (10gregoire) 3NEW a:3Mooeypoo [21:36:54] i also don't entirely trust the way duration was calculated before roan and i fixed it earlier this week, so i think the jump is attributable to that [21:36:56] data loss in restbase would be a serious bug [21:37:11] (03PS4) 10Cscott: Element: Add `content` config option, matching PHP side. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192723 [21:37:13] (03PS2) 10Cscott: DON'T PUSH: update ooui-core to include .static.class property. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192877 [21:37:15] (03PS19) 10Cscott: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) [21:37:17] (03PS2) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 [21:37:19] (03PS18) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [21:37:21] (03PS3) 10Cscott: Teach docparser about @member, @see, and PHP pass-by-reference (&$foo). [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 [21:37:33] 10VisualEditor: Cannot insert local picture in visual editor - https://phabricator.wikimedia.org/T90795#1067698 (10gregoire) [21:37:35] (03CR) 10Cscott: Serialize PHP widget state into data-ooui attribute (035 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [21:37:39] gwicke: well, what about new revisions made via the wikitext editor? [21:38:12] they are processed through the job queue [21:38:28] what happens if i request a revision from restbase before the job has executed? [21:38:31] with a high-prio queue which normally has a latency of few seconds [21:38:55] (03CR) 10jenkins-bot: [V: 04-1] Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 (owner: 10Cscott) [21:39:08] but what happens if i request during that time? [21:39:15] MatmaRex: rebased on top of your FormLayout change. [21:39:20] if the html is requested before it's created it'll be created by that request [21:39:43] so it'd be a storage miss [21:40:04] mooeypoo: here's my phabricator task: https://phabricator.wikimedia.org/T90795 [21:40:10] with the current varnish I typically get a cache miss for large pages that weren't edited in a while [21:40:17] (03CR) 10Bartosz Dziewoński: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [21:40:25] cscott: final comments [21:40:33] in my occasional manual testing Obama for example has been mostly a miss [21:40:34] (03PS3) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 [21:40:37] i think this is lovely [21:40:57] MatmaRex: I'm fixing things up behind you, so when you are done you can go back to the beginning and start again. ;) [21:41:28] (03CR) 10Bartosz Dziewoński: "I think it's fine to just not document the dontReplace parameter." [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [21:42:17] cscott: my comments were pretty minor, so that should be easy [21:42:22] :) [21:46:05] MatmaRex: I forked a @private method in https://gerrit.wikimedia.org/r/192878 which avoided the whole 'undocumented parameters' issue. [21:47:54] oh, neat [22:02:35] MatmaRex: You had any insights about https://gerrit.wikimedia.org/r/#/c/191100/ ? [22:03:16] James_F: the `npm install` i fired off back then is still running… [22:03:24] MatmaRex: Wow, really? [22:03:41] i'm not sure if it's npm or my connection, both are equally likely in my experience [22:03:45] :-( [22:06:31] (03CR) 10Bartosz Dziewoński: [C: 032] Teach docparser about @member, @see, and PHP pass-by-reference (&$foo). [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 (owner: 10Cscott) [22:08:13] (03Merged) 10jenkins-bot: Teach docparser about @member, @see, and PHP pass-by-reference (&$foo). [oojs/ui] - 10https://gerrit.wikimedia.org/r/192864 (owner: 10Cscott) [22:08:52] James_F: as usually, wiping node_modules helped. [22:09:00] MatmaRex: Fun. [22:10:43] (03PS3) 10Cscott: DON'T PUSH: update ooui-core to include .static.class property. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192877 [22:10:45] (03PS4) 10Cscott: Move `OO.ui.infuse` to `OO.ui.Element.static.infuse`. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192878 [22:10:47] (03PS19) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) [22:11:08] (03PS4) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [22:11:35] (03CR) 10Cscott: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS (033 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [22:12:30] James_F: hmm, it does fail for me locally too (after commenting out saucelabs stuff and using local IE) [22:13:06] (03CR) 10Cscott: Element: Add `content` config option, matching PHP side. (034 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192723 (owner: 10Cscott) [22:13:08] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [22:14:16] (03CR) 10Cscott: [C: 04-2] "This is just a placeholder until I5b2e19b76dfead5b0e3055bdf11e86d22d53a99e (a patch to ooui-core) gets merged into oojs-ui." [oojs/ui] - 10https://gerrit.wikimedia.org/r/192877 (owner: 10Cscott) [22:15:05] MatmaRex: Yeah. [22:15:27] MatmaRex: I think I've addressed all your comments now. [22:15:59] James_F: ah, mystery solved. it's a test issue. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/name#Browser_compatibility [22:16:00] James_F: what's the schedule for releasing oojs-core into oojs-ui? That https://gerrit.wikimedia.org/r/192878 patch wants the latest tasty oojs-core bits. [22:16:15] easily fixed. on it. [22:16:22] cscott: If MatmaRex can fix that patch, I was planning to do a release in the next hour. [22:16:33] works for me. [22:16:35] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage, 5Patch-For-Review: interface to support extensions that provide on-screen keyboards for Visual Editor - https://phabricator.wikimedia.org/T86479#1067828 (10Etonkovidova) p:5Triage>3Normal [22:16:41] cscott: And an OOjs UI one later today. [22:17:12] sometimes i do wish that jenkins could express dependencies on multiple patches. But maybe that would just be too complicated to grok. [22:17:33] cscott: If you make a "spider" patch it will try (badly) to visualise the dependency tree. [22:17:35] If OOjs UI is being released, this is the last time to bicker about what color the bikeshed will be infused with? [22:17:43] cscott: :-D [22:17:52] cscott: You wrote it, you call it. [22:18:03] s/\?/!/ [22:18:30] (03PS4) 10Bartosz Dziewoński: Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) [22:18:32] I don't actually have any strong preference one way or the other, I just picked a name so i could get on with the actual, y'know, coding. That's the fun part. :) [22:18:37] James_F: that should work [22:19:04] MatmaRex: Hmm. OK… [22:19:18] (03CR) 10Jforrester: [C: 032] "Here we go again." [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [22:19:24] cscott: iyou *can* submit an octopus merge to gerrit. doesn't mean you should, unless you like pain [22:19:54] octopus merge? [22:19:55] But then the merge commit would have to be separately +2'ed, and my 'real' patch would depend on the merge commit? Hm. [22:20:08] cscott: no, the real commit is the octopus merge. [22:20:12] and yeah, that's as awful as it sounds. [22:20:14] Krenair: with eight little dependent arms stretching in all directions with dastardly suckers. [22:20:15] i tried it once or twice in the past [22:20:39] it basically means you can't rebase it without a three-way merge conflict [22:20:45] or at least that's what always happened for me [22:20:50] well, i'll stick with my manual DONT PUSH patch for now. ;) [22:21:18] Krenair: a commit with multiple parent commits [22:21:33] i actually should have said just "merge", as two parents usually suffice to experience the pain [22:22:39] I guess what I'd want is to write a separate merge patch, and have my patch depend on that. The merge patch should be automatically committed when its dependencies are committed, or something like that. [22:23:28] (03CR) 10jenkins-bot: [V: 04-1] Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [22:23:31] 10OOjs-UI, 10UI-Standardization, 5Patch-For-Review: OOjs UI: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1067839 (10cscott) Getting close! Last call for bikeshed painting! [22:23:47] what now [22:23:55] oh, the usual. [22:24:28] (03CR) 10Bartosz Dziewoński: [C: 032] "fiddle diddle dee" [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [22:26:33] cscott: Ideally we'd be able to have cross-repo commits, but… [22:27:11] (03CR) 10jenkins-bot: [V: 04-1] Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [22:27:42] MatmaRex: Hmm. Possible something up with our SauceLabs link. [22:27:45] okay, what [22:27:58] D: [22:28:03] why are we using them, anyway? [22:28:21] if you say "ie 6 support" i won't believe you [22:28:46] MatmaRex: IE6 support. [22:29:34] * MatmaRex grumbles [22:30:53] (03PS4) 10Amire80: [BrowserTest] WIP: Update the Edit tab scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192770 [22:39:43] (03CR) 10Krinkle: Provide .static.class property on OOjs classes (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [22:39:57] MatmaRex: TrevorParscal: Did you see my comment on the bug? [22:40:20] Using native static wouldn't break compat. We'd deprecate old .static and start using new static where we need it [22:40:35] instead of introducing a new API (.static.class) that is basically deprecated on arrival [22:40:39] Added some basic documentation to https://www.mediawiki.org/wiki/OOjs_UI/PHP_Examples [22:41:24] I'm happy to go this way, but a reply of sorts would be nice since the basis of your last reply was incorrrect. [22:41:25] (03CR) 10Bartosz Dziewoński: Provide .static.class property on OOjs classes (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [22:41:33] (03CR) 10Trevor Parscal: Context refactor (0315 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [22:41:36] (on phabricator) [22:41:47] (03PS5) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [22:42:20] (03PS5) 10Bartosz Dziewoński: Provide .static.class property on OOjs classes [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) [22:43:48] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [22:45:01] (03CR) 10Krinkle: Provide .static.class property on OOjs classes (031 comment) [oojs/core] - 10https://gerrit.wikimedia.org/r/191100 (https://phabricator.wikimedia.org/T89721) (owner: 10Bartosz Dziewoński) [22:45:51] Krinkle: Want me to set es3: true; ? [22:45:57] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Dialog for inserting new templates doesn't play well with search results - https://phabricator.wikimedia.org/T71358#1067957 (10Etonkovidova) I am inclined to close as Resolved: the feedback to a user for inserting templates has improved - there is no... [22:46:05] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Dialog for inserting new templates doesn't play well with search results - https://phabricator.wikimedia.org/T71358#1067958 (10Etonkovidova) 5Open>3Resolved [22:46:40] Krinkle: There are a bunch of failures. [22:46:52] James_F: Anything in particular? [22:46:58] "targetFn.static = Object.create( originFn.static );" [22:47:08] "name = constructor.static && constructor.static.name;" [22:47:18] Etc. [22:47:20] James_F: Oh, right [22:47:35] That's a false positive I think [22:47:45] It's just static. [22:47:51] Yeah [22:48:01] Can you submit as failing patch? [22:48:03] I'll check later [22:48:03] Sure. [22:48:17] I guess JShint re-added 'static' as reserved word for es3, after I had it removed 3 times. [22:48:33] They keep forgetting to look at why it was removed and then an unknowing contributor adds it back [22:48:47] (03PS1) 10Jforrester: build: Re-assert ES3 compatibility [oojs/core] - 10https://gerrit.wikimedia.org/r/192969 [22:48:59] (03PS1) 10Kmenger: RadioOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192970 [22:49:22] (03CR) 10jenkins-bot: [V: 04-1] build: Re-assert ES3 compatibility [oojs/core] - 10https://gerrit.wikimedia.org/r/192969 (owner: 10Jforrester) [22:53:38] evariste, are you still around? [22:54:42] (03CR) 10Trevor Parscal: Context refactor (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [22:54:53] (03PS6) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [22:56:21] (03CR) 10Jforrester: [C: 04-1] RadioOptionWidget: Add description (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192970 (owner: 10Kmenger) [22:56:46] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [22:56:59] (03CR) 10Jforrester: [C: 032] SelectWidget: Add description for config, methods, events [oojs/ui] - 10https://gerrit.wikimedia.org/r/192890 (owner: 10Kmenger) [22:57:15] (03CR) 10Jforrester: [C: 032] OptionWidget: Add description and descriptions of methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/192869 (owner: 10Kmenger) [22:57:18] (03PS1) 10Trevor Parscal: Context refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 [22:57:54] TrevorParscal: https://integration.wikimedia.org/ci/job/VisualEditor-jsduck/4691/console [22:57:58] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [22:58:39] (03Merged) 10jenkins-bot: SelectWidget: Add description for config, methods, events [oojs/ui] - 10https://gerrit.wikimedia.org/r/192890 (owner: 10Kmenger) [22:58:52] (03CR) 10Jforrester: [C: 04-1] ButtonOptionWidget: Add description (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192851 (owner: 10Kmenger) [22:59:06] (03Merged) 10jenkins-bot: OptionWidget: Add description and descriptions of methods [oojs/ui] - 10https://gerrit.wikimedia.org/r/192869 (owner: 10Kmenger) [22:59:17] (03PS2) 10Jforrester: ButtonSelectWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/192846 (owner: 10Kmenger) [22:59:23] (03CR) 10Jforrester: [C: 032] ButtonSelectWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/192846 (owner: 10Kmenger) [23:00:02] (03CR) 10EBernhardson: Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (https://phabricator.wikimedia.org/T1218) (owner: 10Alex Monk) [23:00:47] (03PS2) 10Jforrester: RadioOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192970 (owner: 10Kmenger) [23:01:03] (03CR) 10Jforrester: [C: 032] RadioOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192970 (owner: 10Kmenger) [23:01:33] (03PS2) 10Jforrester: ButtonOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192851 (owner: 10Kmenger) [23:01:41] (03Merged) 10jenkins-bot: ButtonSelectWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/192846 (owner: 10Kmenger) [23:01:50] (03CR) 10Jforrester: RadioOptionWidget: Add description (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192970 (owner: 10Kmenger) [23:01:58] (03CR) 10Jforrester: ButtonOptionWidget: Add description (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/192851 (owner: 10Kmenger) [23:02:04] (03CR) 10Jforrester: [C: 032] ButtonOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192851 (owner: 10Kmenger) [23:02:58] (03Merged) 10jenkins-bot: RadioOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192970 (owner: 10Kmenger) [23:03:56] (03Merged) 10jenkins-bot: ButtonOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192851 (owner: 10Kmenger) [23:04:07] (03CR) 10GWicke: Use ParsoidVirtualRESTService (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/181011 (https://phabricator.wikimedia.org/T1218) (owner: 10Alex Monk) [23:04:39] James_F: cscott: we're doing a OOUI release today, and we want infusability in it, right? [23:04:50] MatmaRex: That's the plan. [23:04:56] MatmaRex: Or tomorrow at worst. [23:06:23] 10VisualEditor, 10VisualEditor-EditingTools: Selected text disappear after click on „“ - https://phabricator.wikimedia.org/T71140#1068050 (10Etonkovidova) I tried google docs Insert-> Special character->Punctuation - you cannot insert a pair characters in one click: a pair of quotation marks will require two c... [23:09:30] 10VisualEditor, 10VisualEditor-EditingTools: Selected text disappear after click on „“ - https://phabricator.wikimedia.org/T71140#1068060 (10Etonkovidova) 5Open>3declined [23:10:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 5§ VisualEditor Q3 Blockers: Send Parsoid API request immediately when user clicks edit - https://phabricator.wikimedia.org/T90372#1068063 (10Catrope) [23:10:34] MatmaRex: You looked at https://phabricator.wikimedia.org/T89721#1056637 ? [23:10:58] 10VisualEditor, 10VisualEditor-Performance, 7Performance, 7Technical-Debt, 5§ VisualEditor Q3 Blockers: Reduce number of load.php calls on VisualEditor open (down from 3) - https://phabricator.wikimedia.org/T53569#1068064 (10Catrope) a:3Catrope [23:11:44] James_F: yes. i liked it. [23:12:01] MatmaRex: Do you want to implement it before we cut OOjs [23:12:03] ? [23:13:19] James_F: not very. i'm somewhat afraid that we might be relying on the current non-copying behavior somewhere. [23:13:29] MatmaRex: I'm not dying for infusability, if we're holding up the release for it, it can probably wait for the next train. [23:13:34] Is it backwards-compatibility? [23:13:39] Umm. [23:13:46] Is it OK backwards-compatibility-wise? [23:13:59] James_F: what Krinkle proposed is backwards-compatible, assuming that all users were sticking to the documented interface and best practices [23:14:06] OK… [23:14:42] MatmaRex: .static would remain inherited. [23:15:09] MatmaRex: So unless you suspect someone is already putting properties directly onto the constructor and things breaking if those are copied, we're good. [23:16:05] anyway, i do like the idea of getting rid of .static, which would make .static.class a moot point too, but it's a non-trivial change and i'm not going to implement it today [23:16:22] OK. [23:16:32] Krinkle: i don't know our codebase well enough, but we have some weird stuff in places in VE. [23:16:43] Krinkle: Are you OK with merging https://gerrit.wikimedia.org/r/#/c/191100/ and cutting OOjs now, then? [23:17:15] James_F: Krinkle: i do not *need* .static right now, we can do (and we did) infusability without it [23:17:37] OK, should we wait on it then and try next week? [23:17:39] so as far as i'm concerned this can wait a week [23:17:41] Rather than rush this? [23:17:42] OK. [23:17:43] Done. [23:17:48] Yeah [23:17:51] (03PS1) 10Kmenger: RadioSelectWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/192979 [23:17:52] cscott: right? [23:18:10] MatmaRex: I took some of your improvements to the test suite (e.g. initClass not being tested at all..) into a separate patch. [23:18:14] That test really needed improving. [23:18:18] Good to have a spotlight on it [23:18:40] pushing later, will cc you. [23:21:06] alright [23:21:36] i'm going to give infusion lsat look, merge it and check out for tonight [23:21:38] (03PS1) 10Mooeypoo: Correctly validate a provider for local api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192981 (https://phabricator.wikimedia.org/T90795) [23:21:43] (03CR) 10jenkins-bot: [V: 04-1] Correctly validate a provider for local api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192981 (https://phabricator.wikimedia.org/T90795) (owner: 10Mooeypoo) [23:21:47] (03PS1) 10Jforrester: Tag v1.1.5 [oojs/core] - 10https://gerrit.wikimedia.org/r/192982 [23:22:04] gwicke: if the requested revision is not in storage, will restbase fetch it from the parsoid API itself? [23:22:19] MatmaRex: Have fun. [23:22:53] (03CR) 10Bartosz Dziewoński: [C: 032] Element: Add `content` config option, matching PHP side. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192723 (owner: 10Cscott) [23:23:42] (03PS2) 10Mooeypoo: Correctly validate a provider for local api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192981 (https://phabricator.wikimedia.org/T90795) [23:23:44] ori: yes [23:24:04] users don't have to know that parsoid even exists [23:24:15] for the most part that is already the case [23:24:18] (03CR) 10Trevor Parscal: [C: 032] Tag v1.1.5 [oojs/core] - 10https://gerrit.wikimedia.org/r/192982 (owner: 10Jforrester) [23:24:22] (sorry, couldn't resist) [23:24:41] (03Merged) 10jenkins-bot: Element: Add `content` config option, matching PHP side. [oojs/ui] - 10https://gerrit.wikimedia.org/r/192723 (owner: 10Cscott) [23:25:03] (03PS7) 10Trevor Parscal: Context refactor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 [23:25:06] the domain still gives it away ;) [23:25:16] (03CR) 10jenkins-bot: [V: 04-1] Correctly validate a provider for local api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192981 (https://phabricator.wikimedia.org/T90795) (owner: 10Mooeypoo) [23:25:22] (03PS2) 10Trevor Parscal: Context refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 [23:25:43] (03CR) 10jenkins-bot: [V: 04-1] Context refactor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192972 (owner: 10Trevor Parscal) [23:25:52] is the restbase/parsoid update job dispatched on successful save? can it be dispatched earlier, before the php parser is even invoked, and then committed on save? [23:26:20] for wikitext edits, that is [23:26:34] ori: I thought it read from the revisions table via the public API… [23:27:28] (03CR) 10jenkins-bot: [V: 04-1] Tag v1.1.5 [oojs/core] - 10https://gerrit.wikimedia.org/r/192982 (owner: 10Jforrester) [23:27:32] ori: I think the easiest way would be to read the editor's mind & start parsing as early as the first clear thought has formed [23:27:34] when an edit is saved via the wikitext editor, parsoid doesn't know that there is a revision it hasn't yet parsed [23:27:43] (03CR) 10Bartosz Dziewoński: [C: 032] Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:27:44] * James_F sighs. [23:27:48] so a job has to be dispatched [23:28:00] Krinkle: https://gerrit.wikimedia.org/r/#/c/192982/ failing is unhelpful… [23:28:09] gwicke: branch prediction 2.0! [23:28:30] James_F: Try locally [23:28:33] (grunt ci) [23:29:11] (03CR) 10Jforrester: [C: 031] "Product/design sign-off." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/192738 (owner: 10Trevor Parscal) [23:29:26] (03Merged) 10jenkins-bot: Serialize PHP widget state into data-ooui attribute [oojs/ui] - 10https://gerrit.wikimedia.org/r/190367 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:29:30] ori: do you have reason to believe that misses caused by ve-edit-after-wikitext-edit are common? [23:29:32] (03PS3) 10Mooeypoo: Correctly validate a provider for local api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192981 (https://phabricator.wikimedia.org/T90795) [23:29:43] (03CR) 10Bartosz Dziewoński: [C: 032] Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:29:51] Krinkle: I think the API key is exhausted, or something's wrong with SauceLabs. [23:29:57] Krinkle: It fails in both. [23:30:12] the editor would need to click on ve edit within 2-3 seconds after wikitext save on average [23:30:13] Krinkle: (Both == local and on the cluster.) [23:30:15] I'm fixing another outage that afects mwcore/mwext* [23:30:26] Krinkle: Yeah, that's the issue mooeypoo is facing I guess. [23:30:30] James_F: would be nice to also get these two merged, for demo prettiness. not very important, just nice. https://gerrit.wikimedia.org/r/191833 https://gerrit.wikimedia.org/r/192088 [23:30:35] (03CR) 10jenkins-bot: [V: 04-1] Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:30:36] possibly even before getting the PHP parser's response [23:30:49] (03PS2) 10Jforrester: Set proper spacing between interleaved FieldsetLayouts and FormLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/191833 (owner: 10Bartosz Dziewoński) [23:30:55] gwicke: it doesn't have to be the same person, right? [23:30:58] (03CR) 10jenkins-bot: [V: 04-1] Correctly validate a provider for local api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192981 (https://phabricator.wikimedia.org/T90795) (owner: 10Mooeypoo) [23:31:04] (03CR) 10Jforrester: [C: 031] Set proper spacing between interleaved FieldsetLayouts and FormLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/191833 (owner: 10Bartosz Dziewoński) [23:31:12] (03CR) 10Jforrester: [C: 031] MediaWiki theme: Simplify spacing of checkboxes/radios in FieldLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/192088 (owner: 10Bartosz Dziewoński) [23:31:14] ori: yup, but there's diminishing returns [23:31:29] if another user hits edit 100ms after the db save went through [23:31:37] you can perhaps save 1s? [23:31:52] James_F, Krinkle the issue i'm facing seems to be with something about wikicache [23:33:19] ori, on enwiki right now: ParsoidCacheUpdateJobOnEdit: 3 queued; 1 claimed [23:33:26] it's a very short queue [23:33:27] (03CR) 10Jforrester: [C: 032] "…" [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:33:46] 10OOjs-UI, 10VisualEditor: Implement a way to squish toolbars when there's not enough horizontal space - https://phabricator.wikimedia.org/T90815#1068188 (10matmarex) 3NEW a:3matmarex [23:33:59] 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 5Patch-For-Review: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1068197 (10Jdforrester-WMF) [23:34:04] i'll look at that tomorrow ^^ [23:34:08] i want to instrument this better to get a handle on how often this happens [23:34:23] and then a bunch of OOUI things that are annoying me [23:34:56] (03CR) 10Jforrester: [C: 032] Remove loop length check [oojs/ui] - 10https://gerrit.wikimedia.org/r/192576 (owner: 10Esanders) [23:35:05] mooeypoo: yeah,fixed already [23:35:10] (03Merged) 10jenkins-bot: Implement OO.ui.infuse to reconstitute PHP widgets in client-side JS [oojs/ui] - 10https://gerrit.wikimedia.org/r/190368 (https://phabricator.wikimedia.org/T74716) (owner: 10Cscott) [23:35:40] 10OOjs-UI, 10UI-Standardization, 7Tracking: Get OOUI PHP to be good to go - https://phabricator.wikimedia.org/T74713#1068207 (10Jdforrester-WMF) [23:35:42] 10OOjs-UI, 5OOjs-UI-next-release, 10UI-Standardization, 5Patch-For-Review: Enhancement of OOUI PHP widgets with JS - https://phabricator.wikimedia.org/T74716#1068205 (10Jdforrester-WMF) 5Open>3Resolved [23:35:56] (03CR) 10Bartosz Dziewoński: [C: 04-1] ButtonElement: Remove conditionals for 'this.$button' [oojs/ui] - 10https://gerrit.wikimedia.org/r/192182 (owner: 10Krinkle) [23:36:14] ori: if we can find some generic stashing mechanism for wt2html and html2wt conversions then that could be interesting [23:36:32] the other option would be to save through restbase [23:36:49] (03Merged) 10jenkins-bot: Remove loop length check [oojs/ui] - 10https://gerrit.wikimedia.org/r/192576 (owner: 10Esanders) [23:36:52] saving through restbase is not a bad idea in principle [23:37:02] James_F: and one last thing, should we close https://phabricator.wikimedia.org/T73085 maybe? [23:37:06] easy to tee off the request to parsoid while attempting to save to the php api in that case [23:37:11] yes [23:37:33] night [23:37:38] bye MatmaRex [23:37:40] MatmaRex: Hmm. I think it'd be Q3 anyway. [23:37:54] 10VisualEditor, 10VisualEditor-EditingTools, 5§ VisualEditor Q3 Blockers: Comment is not getting added after Citation, Template,Gallery,Math node and Table - https://phabricator.wikimedia.org/T90517#1068222 (10Jdforrester-WMF) [23:37:59] 10VisualEditor, 5Patch-For-Review, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: [Regression wmf18] Reference and template dialog boxes display 'Apply changes' button as active upon opening - https://phabricator.wikimedia.org/T89913#1068225 (10Etonkovidova) [23:38:00] ori: but my feeling is that the case we are worried about isn't very common [23:38:13] there are lower hanging fruit to pick still [23:38:24] 10VisualEditor, 10VisualEditor-DataModel, 5WMF-deploy-2015-02-25_(1.25wmf19), 5§ VisualEditor Q3 Blockers: Comments in "unsafe" content locations are not displayed in VisualEditor - https://phabricator.wikimedia.org/T73085#1068226 (10Jdforrester-WMF) 5Open>3Resolved [23:38:41] 10VisualEditor, 10VisualEditor-EditingTools, 5§ VisualEditor Q3 Blockers: Comment is not getting added after Citation, Template,Gallery,Math node and Table - https://phabricator.wikimedia.org/T90517#1061082 (10Jdforrester-WMF) [23:39:08] (03PS1) 10Kmenger: MenuOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192991 [23:39:28] ori: we do plan to venture into section editing next though, and at that point it should be interesting to think about saving through restbase [23:40:59] (03PS2) 10Jforrester: Unbreak form submission in JavaScript [oojs/ui] - 10https://gerrit.wikimedia.org/r/191834 (owner: 10Bartosz Dziewoński) [23:41:08] TrevorParscal: https://gerrit.wikimedia.org/r/#/c/191833/ https://gerrit.wikimedia.org/r/#/c/191834/ https://gerrit.wikimedia.org/r/#/c/192088/ [23:41:17] TrevorParscal: And https://gerrit.wikimedia.org/r/#/c/188289/ afterwards [23:45:28] 10OOjs-UI, 5OOjs-UI-0.7.0, 10VisualEditor, 5WMF-deploy-2015-02-18_(1.25wmf18): Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1068255 (10Etonkovidova) True. Closing this one - verified in Chrome/Safari. [23:45:51] 10OOjs-UI, 5OOjs-UI-0.7.0, 10VisualEditor, 7Verified-in-Phase0, and 2 others: Text input area in template editing modal is too small - https://phabricator.wikimedia.org/T89015#1068256 (10Etonkovidova) [23:52:30] (03CR) 10Trevor Parscal: [C: 032] Set proper spacing between interleaved FieldsetLayouts and FormLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/191833 (owner: 10Bartosz Dziewoński) [23:53:47] (03CR) 10Trevor Parscal: [C: 032] MediaWiki theme: Simplify spacing of checkboxes/radios in FieldLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/192088 (owner: 10Bartosz Dziewoński) [23:54:15] (03CR) 10Trevor Parscal: [C: 032] Unbreak form submission in JavaScript [oojs/ui] - 10https://gerrit.wikimedia.org/r/191834 (owner: 10Bartosz Dziewoński) [23:54:37] (03CR) 10Jforrester: [C: 032] MenuOptionWidget: Add description [oojs/ui] - 10https://gerrit.wikimedia.org/r/192991 (owner: 10Kmenger) [23:54:50] (03CR) 10Jforrester: [C: 032] RadioSelectWidget: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/192979 (owner: 10Kmenger) [23:57:55] (03Merged) 10jenkins-bot: Set proper spacing between interleaved FieldsetLayouts and FormLayouts [oojs/ui] - 10https://gerrit.wikimedia.org/r/191833 (owner: 10Bartosz Dziewoński) [23:59:16] (03PS4) 10Mooeypoo: Correctly validate a provider for local api [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/192981 (https://phabricator.wikimedia.org/T90795)