[00:00:05] superm401: Yes. [00:00:17] superm401: Maybe we should rename ve.ui.Action to be SurfaceAction or something. [00:00:22] (03PS5) 10Mooeypoo: Add directionality classes to window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196661 [00:00:23] EditAction? Meh. [00:00:56] superm401: Yeah, ActionWidgets are in no way related to Actions :( [00:01:03] Or rename the other one to be buttons. [00:01:23] (03Merged) 10jenkins-bot: Remove basetimestamp/starttimestamp from ApiVisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196636 (owner: 10Catrope) [00:01:25] (03PS4) 10Trevor Parscal: Allow access to surface through window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196655 [00:01:34] (03CR) 10Legoktm: [C: 032] Don't try to log a boolean for page.revid [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/196724 (owner: 10Alex Monk) [00:01:38] (03Merged) 10jenkins-bot: Don't try to log a boolean for page.revid [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/196724 (owner: 10Alex Monk) [00:02:00] someone's been writing too much JS :P [00:02:14] (03CR) 10jenkins-bot: [V: 04-1] Add directionality classes to window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196661 (owner: 10Mooeypoo) [00:02:17] (03PS2) 10Trevor Parscal: Update VE core submodule to a0fe2e065caef4474fcb26de550842fbec69f630 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196723 [00:02:23] James_F: there's also a Command to make it a bit more confusing. [00:02:34] MatmaRex: Yup. [00:02:35] (03PS6) 10Mooeypoo: Add directionality classes to window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196661 [00:02:42] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to a0fe2e065caef4474fcb26de550842fbec69f630 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196723 (owner: 10Trevor Parscal) [00:03:02] (03PS1) 10Jforrester: Don't try to log a boolean for page.revid [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196727 [00:03:43] legoktm: Wooooow :D [00:04:16] superm401: Yeah you will need to create a command, that maps to a window action with parameters. language and comment are both good examples of that [00:04:31] The tool then executes that command [00:04:34] (03CR) 10jenkins-bot: [V: 04-1] Add directionality classes to window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196661 (owner: 10Mooeypoo) [00:04:35] Krenair: let me know if you need help i will be here for another couple hours [00:04:46] in other news, https://phabricator.wikimedia.org/T91349#1117681 is so terrible [00:05:04] MatmaRex: Eww. [00:05:24] i spent about five hours on it now, all the time thinking that i'll have it working within next 30 minutes [00:05:32] 10VisualEditor, 10VisualEditor-DataModel, 7Technical-Debt: Don't wrap text in paragraphs when avoidable (especially inside
  • , ) - https://phabricator.wikimedia.org/T92441#1118439 (10Jdforrester-WMF) p:5Triage>3Normal [00:05:50] RoanKattouw, yeah, so far I have https://phabricator.wikimedia.org/P399 but that's probably not quite right (I'm not sure what the naming conventions are either). [00:06:02] (i am still thinking that) [00:06:16] superm401: It should be 'window', 'open' [00:06:33] ve.ui.commandRegistry.register( [00:06:35] new ve.ui.Command( [00:06:36] 'comment', 'window', 'open', [00:06:38] { args: ['comment'], supportedSelections: ['linear'] } [00:06:39] ) [00:06:41] ); [00:06:42] s/'comment'/'flowMention'/g , done [00:06:58] we sure love copying and pasting 'round here [00:07:04] Yeah... [00:07:28] Thanks. [00:07:46] Anyway superm401 , I'm gonna leave you in the care of these lovely people while I get some sleep [00:07:53] The args don't need to be globally unique names, right? [00:07:56] superm401: hmm, this might be inspirational: https://meta.wikimedia.org/wiki/User:Matma_Rex/visualeditor-signature.js [00:07:59] RoanKattouw, have a good night. [00:08:23] superm401: args in this case refers to the arguments to WindowAction#open. It takes one argument which is the name of a window [00:08:31] ("window" means "inspector or dialog") [00:08:32] not sure how much of it will match what you're writing, but it might be useful [00:08:58] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, 6operations: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118444 (10Krinkle) ``` [16:03 CET] krinkle at KrinkleMac in ~ $ host saucelabs.com saucel... [00:09:01] Oh, I see. [00:09:23] MatmaRex, yeah, it's a little different, since I don't think I need a plugin (this is for the Flow VE toolbar). [00:09:46] yeah. but it can be a good source for copying and pasting ;) [00:09:48] VE people: I'll be working from the plane on Monday, I'll try to be on IRC insofar as crappy airplane wifi permits. I'll be back in the office on Tuesday [00:10:17] superm401: The only real difference between plugins and not-plugins is the addPlugin( function () { ... } ) wrapper, everything else is pretty much the same [00:10:36] Actually you are probably using $wgVisualEditorPluginModules, which uses the same mechanism [00:10:50] RoanKattouw, so far, no. We'll see if I have to. [00:10:57] Hmm although I suppose for flowMention I guess you don't need to [00:11:20] We have a whole separate surface and everything. I'm implemented a target (so far, simple), too. [00:11:27] I've got to go too, though. [00:11:40] OK, have fun with your flowMention code [00:11:42] You seem to be on the right track [00:11:43] Thanks [00:15:05] (03CR) 10Alex Monk: [C: 032] Move parseWikitext from ApiVisualEditor.php to ApiVisualEditorEdit.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196650 (owner: 10Catrope) [00:16:09] (03PS7) 10Mooeypoo: Add directionality classes to window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196661 [00:18:04] (03CR) 10jenkins-bot: [V: 04-1] Add directionality classes to window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196661 (owner: 10Mooeypoo) [00:19:41] (03PS5) 10Mooeypoo: Allow access to surface through window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196655 (owner: 10Trevor Parscal) [00:20:04] (03PS8) 10Mooeypoo: Add directionality classes to window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196661 [00:20:47] (03Merged) 10jenkins-bot: Move parseWikitext from ApiVisualEditor.php to ApiVisualEditorEdit.php [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196650 (owner: 10Catrope) [00:22:50] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, 6operations: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118458 (10Dzahn) I found the root cause to be this option in /etc/resolv.conf ``` option... [00:24:17] (03CR) 10Mooeypoo: [C: 031] "This works well now." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196655 (owner: 10Trevor Parscal) [00:24:19] nuria, yeah, confirmed the server-side events go through to deployment-eventlogging02:/var/log/eventlogging/all-events.log [00:24:36] (03CR) 10Alex Monk: [C: 032] Default user.editCount to 0 in the Edit schema [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196715 (owner: 10Jforrester) [00:24:40] (03Merged) 10jenkins-bot: Default user.editCount to 0 in the Edit schema [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196715 (owner: 10Jforrester) [00:24:43] (03CR) 10Alex Monk: [C: 032] Fix name of editingSessionId [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196716 (owner: 10Jforrester) [00:24:46] (03Merged) 10jenkins-bot: Fix name of editingSessionId [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196716 (owner: 10Jforrester) [00:24:49] (03CR) 10Alex Monk: [C: 032] Don't try to log a boolean for page.revid [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196727 (owner: 10Jforrester) [00:24:52] Krenair: Good. Then they are valid according to the schema. [00:24:52] (03Merged) 10jenkins-bot: Don't try to log a boolean for page.revid [extensions/WikiEditor] (wmf/1.25wmf21) - 10https://gerrit.wikimedia.org/r/196727 (owner: 10Jforrester) [00:25:02] hmm [00:25:12] why do we allow empty list nodes to exist? :o [00:26:49] MatmaRex: Because they occur in wikitext? [00:27:16] let me rephrase [00:27:24] why do we allow empty list nodes to exist, while not making it possible to edit them? :o [00:27:36] MatmaRex: Eh. [00:27:49] Try to edit an empty
    if you want misery. [00:28:01] shouldn't we have slugs for
  • s or something? [00:28:05] We did. [00:28:08] We removed them. [00:28:13] "Efficiency". [00:28:33] uh, and why did we remove them? [00:28:59] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118464 (10coren) ndots:2 is necessary for something else, the actual bug is that the dnsma... [00:29:23] (03PS6) 10Jforrester: [BREAKING CHANGE] Allow access to surface through window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196655 (owner: 10Trevor Parscal) [00:29:30] MatmaRex: Ask Trevor/Ed/Roan. [00:29:34] None of whom are here. :-) [00:31:07] (03CR) 10Jforrester: [C: 032] "Per Moriel, Trevor (eh)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196655 (owner: 10Trevor Parscal) [00:31:49] (03PS2) 10Mooeypoo: Add a link to the reference dialog in Citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/196644 [00:33:17] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Allow access to surface through window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196655 (owner: 10Trevor Parscal) [00:34:03] James_F, we should schedule https://gerrit.wikimedia.org/r/196733 for swat on monday I guess, [00:34:16] Krenair: Yeah, was going to work on it on Saturday/Sunday. [00:34:20] I won't be around for the morning. will you? [00:34:26] Krenair: I will, yes. [00:34:36] Krenair: I'll do it, worry not. :-) [00:34:43] ok [00:34:55] (03CR) 10Jforrester: [C: 031] Add directionality classes to window manager [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196661 (owner: 10Mooeypoo) [00:37:13] James_F, milimetric did this to check it: https://www.irccloud.com/pastebin/5D6374eV [00:37:26] except the server-side logs into a different table because it uses a different version of the schema [00:38:00] 11448630 instead [00:38:09] Krenair: Right. [00:38:15] Krenair: Should we bump that too? [00:38:19] that is the latest [00:38:41] the client-side (schema version controlled centrally by WikimediaEvents) is using the older version before I edited it [00:40:24] The client-side in WE? [00:40:42] WE and VE, they both get the schema from WikimediaEvents [00:40:56] the diff: https://meta.wikimedia.org/w/index.php?title=Schema:Edit&diff=11448630&oldid=11319708 [00:40:56] Oh, so do we need to fix WikimediaEvents and back-port? [00:41:04] * James_F nods. [00:41:06] "need" [00:41:06] not sure [00:41:14] Putting them all in one table sounds easier. [00:41:15] But eh. [00:41:22] it's probably a safe change [00:41:23] Anyway, I need to go. [00:41:28] I tink that field I added is not required [00:41:30] think* [00:41:30] Sure. [00:41:41] assuming it defaults to required: false [00:41:43] Speak tomorrow, if you're around. :-) [00:41:53] yeah [00:41:54] * Krenair waves [00:45:01] (03CR) 10Esanders: "You'd need to justify creating a new colour (pale blue)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196583 (https://phabricator.wikimedia.org/T90622) (owner: 10Esanders) [00:47:53] huh, the hamburger menu displays underneath the find+replace fields [00:48:37] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Transclusion handling - https://phabricator.wikimedia.org/T92695#1118498 (10Krenair) [00:49:38] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118500 (10scfc) The error doesn't seem to lie with dnsmasq. On `tools-login`, the look-up... [00:54:51] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables: Table cells can be removed by backspacing/deleting - https://phabricator.wikimedia.org/T92702#1118530 (10matmarex) 3NEW [00:55:56] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118537 (10coren) No, it's just that the Precise libresolv seems to be a little more forgiv... [00:56:33] (03CR) 10Bartosz Dziewoński: "I think we abandoned the idea of semantic colors when we did focus highlights on text inputs in "progressive" color, and most definitely w" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196583 (https://phabricator.wikimedia.org/T90622) (owner: 10Esanders) [01:03:16] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118547 (10coren) To wit: ``` marc@tools-trusty:~$ host notexist Host notexist.eqiad.wmflab... [01:03:21] 10VisualEditor: "Hamburger" menu shows underneath the find+replace dialog - https://phabricator.wikimedia.org/T92704#1118548 (10Krenair) 3NEW [01:03:43] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118555 (10Krinkle) I suspect this error got introduced when I switched over the CI pool fr... [01:10:01] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118565 (10Krinkle) [01:13:04] * Krinkle receives pings from RoanKattouw_away for CR [01:25:05] James_F|Away: RoanKattouw_away: The WIP-needs of https://gerrit.wikimedia.org/r/#/c/196466/ are specified in the comment there. [01:25:56] James_F|Away: RoanKattouw_away: The underlying commit to omit empty notices would be a good start and would already require changes in the "template:Editnotice load" system. I've done that fix on mediawiki.org just now to see if that'll work (once https://gerrit.wikimedia.org/r/#/c/196426/1 goes live) [01:36:27] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118579 (10scfc) @Coren: But there are you querying the Labs server, and (I think) dnsmasq... [01:39:24] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118580 (10scfc) And: ``` scfc@tools-login:~$ dig @10.68.16.1 tools-login.eqiad.wmflabs ;... [01:41:03] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118589 (10scfc) (Or a host name that does not exist.) [01:41:38] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118590 (10coren) >>! In T92351#1118579, @scfc wrote: > So (from a distance) it appears as... [01:55:13] (03CR) 10Krinkle: [C: 032] jsduck: Set --processes=0 to fix warnings-exit-nonzero [oojs/core] - 10https://gerrit.wikimedia.org/r/194813 (owner: 10Krinkle) [01:56:11] (03CR) 10jenkins-bot: [V: 04-1] jsduck: Set --processes=0 to fix warnings-exit-nonzero [oojs/core] - 10https://gerrit.wikimedia.org/r/194813 (owner: 10Krinkle) [02:00:17] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118610 (10scfc) http://www.linuxquestions.org/questions/linux-networking-3/powerdns-servfa... [02:02:24] (03PS42) 10Paladox: Re add svg images [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/181786 (https://phabricator.wikimedia.org/T37342) [02:03:00] (03PS10) 10Paladox: Add svg to LESS file [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/195529 (https://phabricator.wikimedia.org/T37342) [02:08:39] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-Tables: Table cells can be removed by backspacing/deleting - https://phabricator.wikimedia.org/T92702#1118628 (10matmarex) a:3matmarex [02:08:47] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: Weird behavior when backspacing over the end of a list with empty last item - https://phabricator.wikimedia.org/T91349#1118629 (10matmarex) a:3matmarex [02:08:58] (03PS1) 10Bartosz Dziewoński: Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) [02:09:00] (03PS1) 10Bartosz Dziewoński: Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) [02:11:17] (03CR) 10jenkins-bot: [V: 04-1] Prevent backspacing/deleting over table cells [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński) [02:11:19] (03CR) 10jenkins-bot: [V: 04-1] Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński) [02:43:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Tests were testing for incorrect behavior, need updating (and more cases). There's no support for non-linear selections there, though." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196740 (https://phabricator.wikimedia.org/T92702) (owner: 10Bartosz Dziewoński) [03:01:42] (03CR) 10Krinkle: Load RL modules in one load.php request, rather than in two stages (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope) [03:02:25] (03CR) 10Krinkle: "Short of minor code issues, will give this one more look tomorrow morning and merge if it all works. Let's get to phase 2." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope) [03:49:35] (03PS1) 10Legoktm: jenkins job validation, do not submit [oojs/ui] - 10https://gerrit.wikimedia.org/r/196742 [03:52:26] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [oojs/ui] - 10https://gerrit.wikimedia.org/r/196742 (owner: 10Legoktm) [04:21:15] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118720 (10Dzahn) about workarounds: /etc/nsswitch says: hosts: files dns so to... [08:56:37] hello,i was going through the code of visual editor, in which directory i can find code related to the find and replace functionality? [10:18:46] Hello everyone.I am new to mediawiki and have just started working on visual editor.In visualeditor.php all files such as js and css are registered but from where does all the icons and text come.any different file for that? [10:38:36] How json messages such as "visualeditor-commentinspector-edit": "Edit comment", are retrived to show on visual editor? [10:38:55] this one is from en.json [13:21:49] (03CR) 10Umherirrender: [C: 04-1] "some comments" (033 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [13:33:16] 10VisualEditor: Keyboard shortcuts dialog should be scrollable - https://phabricator.wikimedia.org/T92723#1118958 (10tarlocesilion) 3NEW [13:36:19] (03PS8) 10Gerrit Patch Uploader: Style code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 [13:36:22] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [13:43:06] (03CR) 10Umherirrender: [C: 04-1] "Sorry found some other points." (037 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [13:51:15] how json files are used for setting label? [13:51:30] 10OOjs, 10Continuous-Integration, 6Labs, 10Wikimedia-Labs-Infrastructure, and 2 others: Jenkins failing with "Error: GET https://saucelabs.com: Couldn't resolve host name." - https://phabricator.wikimedia.org/T92351#1118965 (10scfc) Has someone looked at whether there is an SOA record in LDAP? If that is... [14:04:04] !logs [15:38:15] (03CR) 10Fomafix: "It is impossible to upload without rebase through Gerrit Patch Uploader." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [15:49:05] (03PS9) 10Gerrit Patch Uploader: Style code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 [15:49:09] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [15:50:02] (03CR) 10Catrope: Load RL modules in one load.php request, rather than in two stages (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/193026 (https://phabricator.wikimedia.org/T53569) (owner: 10Catrope) [15:52:54] (03CR) 10Fomafix: Style code (033 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [15:54:57] (03CR) 10Fomafix: Style code (037 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [16:25:04] (03CR) 10Umherirrender: [C: 032] Style code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [16:25:09] (03Merged) 10jenkins-bot: Style code [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187732 (owner: 10Gerrit Patch Uploader) [17:16:13] Could some OOjs UI wizard make a quick pastebin on how to init a tool and register with toolFactory? [17:16:30] Its the only thing that's holding me up [18:01:59] (03PS2) 10Umherirrender: Reuse variable profile instead of $.client.profile() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/193861 (owner: 10Gerrit Patch Uploader) [18:02:06] (03CR) 10Umherirrender: [C: 032] Reuse variable profile instead of $.client.profile() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/193861 (owner: 10Gerrit Patch Uploader) [18:02:09] (03Merged) 10jenkins-bot: Reuse variable profile instead of $.client.profile() [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/193861 (owner: 10Gerrit Patch Uploader) [18:10:54] (03PS18) 10Umherirrender: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [18:11:00] (03CR) 10Umherirrender: [C: 032] Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [18:11:04] (03Merged) 10jenkins-bot: Reformat the license warning only if available [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/98249 (owner: 10Dev-zero) [18:19:31] (03PS6) 10Umherirrender: Replace 104px by 102px for width of thumbnail div [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [18:19:37] (03CR) 10Umherirrender: [C: 032] Replace 104px by 102px for width of thumbnail div [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [18:19:42] (03Merged) 10jenkins-bot: Replace 104px by 102px for width of thumbnail div [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/183254 (owner: 10Gerrit Patch Uploader) [18:26:11] (03PS3) 10Gerrit Patch Uploader: Move result of thumb from i18n to config [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 [18:26:14] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader) [18:44:51] (03PS2) 10Bartosz Dziewoński: Insert a new references list immediately, rather than showing a dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196366 (https://phabricator.wikimedia.org/T71727) [18:58:43] Hey, what css files should I be looking at if I am trying to alter the UI design of the toolbar? [18:58:45] thanks! [18:59:36] MatmaRex : would you be able to help? [19:00:47] 10OOjs-UI, 10VisualEditor, 7Design: MediaWiki theme: Alter the toolbar and dropdown menu design - https://phabricator.wikimedia.org/T86693#1119196 (10Ankita-ks) What css files should I be looking at if I want to work on this? [19:03:04] (03CR) 10Krinkle: "Only remove the message from 'en' and 'qqq'. https://www.mediawiki.org/wiki/Localisation#Removing_existing_messages" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader) [19:07:56] (03CR) 10Krinkle: "I see it's converting a message. Not sure what the procedure is for that." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader) [19:29:54] 10VisualEditor: Inaccurate audio file preview for [[en:Template:Listen]] - https://phabricator.wikimedia.org/T92740#1119209 (10Tbayer) 3NEW [19:36:06] 10VisualEditor: Inaccurate audio file preview for [[en:Template:Listen]] - https://phabricator.wikimedia.org/T92740#1119224 (10Tbayer) Possibly related: T51689 [19:41:14] (03PS4) 10Krinkle: Move hardcoded parsed thumbnail html from i18n to config [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader) [19:42:04] (03CR) 10Krinkle: "Fixed a few more bugs and updated the "qqq" entry that was left out. Also reduced i18n updates to just "en"." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader) [19:42:13] (03CR) 10Krinkle: [C: 031] Move hardcoded parsed thumbnail html from i18n to config [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader) [19:59:59] 10MediaWiki-Page-editing, 10MediaWiki-extensions-TimedMediaHandler, 6Multimedia, 7JavaScript, 5Patch-For-Review: Dynamically loading TimedMediaHandler for new content (preview) - https://phabricator.wikimedia.org/T74675#1119249 (10TheDJ) Patches deployed at http://multimedia-alpha.wmflabs.org/wiki/Video_... [20:11:07] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Adding a template to an article on it.wp causes VE to freeze - https://phabricator.wikimedia.org/T90757#1119253 (10Ricordisamoa) Chromium 41 works for me (logged in). [20:16:01] (03CR) 10Fomafix: [C: 031] Move hardcoded parsed thumbnail html from i18n to config [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/187338 (owner: 10Gerrit Patch Uploader) [20:23:01] hello, i am a bit confused about the functionality of this piece of code http://pastebin.com/Ah3u3FAU, its from file ve.ui.FindAndReplaceDialog.js [20:25:52] hi [20:28:55] rits: it looks like it's finding inside the data model, and then making sure that you scroll to the rendered element corresponding to it. [20:29:07] loading any match that has not been rendered yet. [20:29:48] loading a fragment for a match that has not been rendered. [20:30:30] ok then these two lines are for scrolling purpose to that particular elemnt position of the screen [20:30:38] offset = top + surfaceView.$element.offset().top; [20:30:40] windowScrollTop = surfaceView.$window.scrollTop() + this.surface.toolbarHeight; [20:31:19] yes [20:33:19] ok thank you for clearing :) [20:38:16] ankita-ks: https://github.com/wikimedia/oojs-ui/tree/master/src/styles and https://github.com/wikimedia/oojs-ui/tree/master/src/themes [20:39:00] thedj : looking at it. thanks! :) [20:40:59] ankita-ks: that's for oojs ui, which is used by VE. VE also has some 'private css' some of which is here: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/tree/master/modules/ve-mw/ui/styles [20:41:59] ah..okay [20:42:23] it's a bit of a puzzle :) [21:54:44] thedj : sure seems like that by now. :'( [22:42:16] hello i was working on this bug https://phabricator.wikimedia.org/T86459, as working on it i found that the cursor moving out of the focus only happens for the first time [22:42:39] when the word found is first time out of the window view port [22:45:24] working on it the code i think the situation was created due to this http://pastebin.com/8gRPUAvh, but working on it does'nt seems to resolve the issue [22:51:07] 10MediaWiki-ResourceLoader, 7JavaScript: CSS modules should be considered "ready" when they are applied to a page - https://phabricator.wikimedia.org/T92747#1119327 (10He7d3r) 3NEW [22:52:03] 10MediaWiki-ResourceLoader, 7JavaScript: CSS modules should be considered "ready" when they are applied to a page - https://phabricator.wikimedia.org/T92747#1119334 (10He7d3r) Feel free to close this as invalid if I misunderstood the intended behavior... (an explanation is welcome in that case) [22:54:08] if(offset < windowScrollTop || offset > windowScrollTop + windowScrollHeight) this happens the cursor just moves by a height of the this.surface.toolbarheight, so the problem might be in the offset or windowscrollheight/windowscrolltop,is that true? [23:25:24] 10MediaWiki-ResourceLoader, 6Mobile-Web, 10MobileFrontend-Feature-requests: ResourceLoaderImage module css rules should be more configurable - https://phabricator.wikimedia.org/T78215#1119368 (10matmarex) p:5Triage>3Normal a:3matmarex