[00:02:04] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1151739 (10ssastry) Scratch all that. Those are all false positives .. I just confirmed by trying to serialize some of these reports and they serialize just fine but... [00:30:44] 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1151804 (10TheDJ) [00:30:45] 10MediaWiki-Page-editing, 7JavaScript: LivePreview should not replace title message with displaytitle value in firstHeading - https://phabricator.wikimedia.org/T85784#1151802 (10TheDJ) 5Open>3Resolved [00:39:58] 10VisualEditor, 10Utilities-UnicodeJS, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Wordbreak detection is faulty for selection starting just down-page of a single character - https://phabricator.wikimedia.org/T78202#1151850 (10Ryasmeen) Verified the fix in Betalabs and test2 [00:40:10] 10VisualEditor, 10Utilities-UnicodeJS, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-25_(1.25wmf23): Wordbreak detection is faulty for selection starting just down-page of a single character - https://phabricator.wikimedia.org/T78202#1151851 (10Ryasmeen) [00:40:40] 10Citoid, 10VisualEditor, 5WMF-deploy-2015-03-25_(1.25wmf23): More user-friendly message for 520s (when the service is unable to obtain metadata about the resource) - https://phabricator.wikimedia.org/T93005#1151854 (10Ryasmeen) verified in Betalabs and test2 [00:41:30] 10Citoid, 10VisualEditor, 7Verified-in-Phase0, 5WMF-deploy-2015-03-25_(1.25wmf23): More user-friendly message for 520s (when the service is unable to obtain metadata about the resource) - https://phabricator.wikimedia.org/T93005#1151855 (10Ryasmeen) [00:43:58] 10VisualEditor, 10VisualEditor-EditingTools, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22), 5WMF-deploy-2015-03-25_(1.25wmf23): [Regression wmf22] Link removal doesn't work on first click anymore - https://phabricator.wikimedia.org/T93363#1151859 (10Ryasmeen) Verified the fix in b... [00:44:10] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers, and 2 others: [Regression wmf22] Link removal doesn't work on first click anymore - https://phabricator.wikimedia.org/T93363#1151860 (10Ryasmeen) [00:54:04] (03PS1) 10Jforrester: Update AUTHORS.txt, $wgExtensionCredits and .mailmap based on git shortlog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199809 [01:04:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Kill $wmgUseVisualEditorNamespace - https://phabricator.wikimedia.org/T92797#1151944 (10Jdforrester-WMF) p:5Triage>3Low [01:30:28] (03CR) 10Jforrester: [C: 032] BookletLayout: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/199797 (owner: 10Kmenger) [01:32:47] (03Merged) 10jenkins-bot: BookletLayout: Add description and example [oojs/ui] - 10https://gerrit.wikimedia.org/r/199797 (owner: 10Kmenger) [01:45:15] (03CR) 10Divec: [C: 032] "Welcome to the world, ve.dm.ContentBranchNode :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199565 (https://phabricator.wikimedia.org/T93461) (owner: 10Catrope) [01:46:21] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2015-04-01_(1.25wmf24): "Error: offset was inside an ignoreChildren node" appears while triple-clicking on an empty line when an image is the first item of the page - https://phabricator.wikimedia.org/T93461#1152016 (10Jdforrester-WMF) 5Open>3Res... [01:47:36] (03Merged) 10jenkins-bot: Make triple-click expand to CBNs, not BranchNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/199565 (https://phabricator.wikimedia.org/T93461) (owner: 10Catrope) [01:56:05] (03PS5) 10Jforrester: Ensure that selection is not lost inside block slugs after backspace/delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński) [01:58:22] (03CR) 10jenkins-bot: [V: 04-1] Ensure that selection is not lost inside block slugs after backspace/delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński) [03:40:41] 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 10Wikidata, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1152084 (10aaron) a:3aaron [04:00:54] 10MediaWiki-ResourceLoader: Bug: jquery.jStorage saved data lost on logout - https://phabricator.wikimedia.org/T92937#1152112 (10Mattflaschen) >>! In T92937#1126038, @Cumbril wrote: > Just did some tests and now the data is not lost on https://test2.wikipedia.org/ server after logging out and back in. In the liv... [05:10:35] 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, 5Patch-For-Review: ResourceLoader slow under MediaWiki-Vagrant with VirtualBox - https://phabricator.wikimedia.org/T78733#1152247 (10Mattflaschen) >>! In T78733#1130869, @Yurik wrote: > i wonder if enabling "zend" role (switch back to PHP engine) would have so... [05:56:49] 10MediaWiki-ResourceLoader: Bug: jquery.jStorage saved data lost on logout - https://phabricator.wikimedia.org/T92937#1152295 (10Cumbril) I have tested saving data with using Javascript localStorage.setItem directly (without using jquery.jStorage wrapper). In this case data is consistently recorded and survives... [06:24:02] 10WikiEditor, 6Editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript, and 2 others: WikiEditor toolbar is loaded twice when editing - https://phabricator.wikimedia.org/T93384#1152313 (10Ricordisamoa) [[ //it.wikiquote.org/w/index.php?title=Wikiquote:Bar&diff=701390 | Similar issue ]] on the Italian Wi... [06:40:37] (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199831 [06:40:45] (03CR) 10jenkins-bot: [V: 04-1] jenkins job validation, do not submit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199831 (owner: 10Legoktm) [06:48:12] (03CR) 10Legoktm: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199831 (owner: 10Legoktm) [06:51:58] (03CR) 10jenkins-bot: [V: 04-1] jenkins job validation, do not submit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199831 (owner: 10Legoktm) [06:52:32] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/199831 (owner: 10Legoktm) [06:54:23] ^ everything passed \o/ [08:21:15] 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1152426 (10Prtksxna) [08:22:07] 10OOjs-UI, 6Mobile-Web, 10UI-Standardization, 6WMF-Design, 7Design: Hover styles differ between MediaWiki UI buttons and OOjs UI buttons - https://phabricator.wikimedia.org/T92566#1114885 (10Prtksxna) >>! In T92566#1150009, @Nirzar wrote: > @kaldari I don't think the screenshots attached in task descript... [08:22:37] 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1152431 (10TheDJ) [08:22:38] 10MediaWiki-Page-editing, 7JavaScript: LivePreview should give feedback when failing - https://phabricator.wikimedia.org/T90490#1152428 (10TheDJ) 5Open>3Resolved [08:43:58] 10VisualEditor, 6Community-Liaison, 10Wikimedia-Site-requests: Plan to re-enable VisualEditor by default for all logged-out and newly-created users of the English Wikipedia - https://phabricator.wikimedia.org/T90667#1152441 (10Nemo_bis) > This was more planned as a pop-up in/on the editor for logged-in users... [08:47:28] 10OOjs-UI, 10UI-Standardization, 7Design: Remove the yellow autofill background on inputs that chrome and other browsers add - https://phabricator.wikimedia.org/T94010#1152442 (10Prtksxna) 3NEW [08:54:36] 10OOjs-UI, 10UI-Standardization, 7Design: Create tag list / tokenizer / capsule controls widget - https://phabricator.wikimedia.org/T88250#1152453 (10Rillke) [08:56:16] 10OOjs-UI, 10UI-Standardization, 7Design: Remove the yellow autofill background on inputs that chrome and other browsers add - https://phabricator.wikimedia.org/T94010#1152457 (10Prtksxna) Initial Googling shows that this isn't as straightforward as it should be. Webkit browsers provide the `-webkit-autofi... [10:03:07] 10Citoid, 6Services, 5Patch-For-Review: Promisify Citoid and base it on service-template-node / service-runner - https://phabricator.wikimedia.org/T75993#1152524 (10mobrovac) [10:40:46] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1152593 (10ferdbold) [10:42:16] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 6Services, 3Google-Summer-of-Code-2015: GraphData extension for VisualEditor (GSoC 2015 Proposal) - https://phabricator.wikimedia.org/T93585#1140552 (10ferdbold) I'm not done writing this, but feel free to tell me if you guys think I'm not on the r... [11:57:31] 10VisualEditor, 10Continuous-Integration, 7Browser-Tests: language screenshot job for Persian (fa) seems to run correctly, but marked as failure - https://phabricator.wikimedia.org/T93742#1152700 (10zeljkofilipin) [12:41:28] (03CR) 10Esanders: "FIXME: This breaks editing of new pages" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198393 (https://phabricator.wikimedia.org/T92993) (owner: 10Alex Monk) [12:44:52] 10OOjs-UI, 10UI-Standardization: Flags can only be applied to buttons - https://phabricator.wikimedia.org/T93890#1152798 (10werdna) a:5werdna>3None [12:51:37] mvolz, what is going on with the citation toolbar setup? [12:53:12] In master and beta labs I get a citoid button, and next to it a separate menu for the other cite options which has an indicator but not icon [12:53:43] 10OOjs-UI, 10UI-Standardization, 7Design: Remove the yellow autofill background on inputs that chrome and other browsers add - https://phabricator.wikimedia.org/T94010#1152815 (10Ricordisamoa) Is this really needed? [12:54:56] edsanders: no idea, mooeypoo was doing those changes :) [12:55:11] That's what I see in deploy too. [12:55:22] I think Trevor was the reviewer on that. [12:56:36] do you know the patch? [13:01:29] 10VisualEditor, 10Continuous-Integration, 7Browser-Tests: language screenshot job for Persian (fa) seems to run correctly, but marked as failure - https://phabricator.wikimedia.org/T93742#1152831 (10Amire80) 5Open>3Resolved One of the files was a redirect to another file. This confused the uploading API,... [13:01:38] not off the top of my head, although come to think of it, the changes might be in VE [13:01:58] looking through the patches the last one I remember didn't have that change... [13:02:22] but yeah probably don't know better than you. I do know the tool does some hackery to insert itself into the toolbar [13:04:54] I just assumed that was the intended effect :) [13:09:18] (03PS1) 10Esanders: Skip revId check for new pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199868 [13:09:51] 10OOjs-UI, 10OOjs-UI-0.9.1, 10UI-Standardization, 7Design, 5WMF-deploy-2015-03-18_(1.25wmf22): Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1152849 (10APerson) I really liked the old focus indicator and think that the new one looks pretty bad. We abandoned a great d... [13:14:15] (03PS1) 10Amire80: [BrowserTest] Capture the whole Insert button in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199872 [13:24:15] (03PS1) 10Amire80: [BrowserTest] Add padding to Insert button screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199877 [13:28:40] edsanders, oops [13:28:53] I'm not convinced by the fix though [13:29:05] you know it better than I [13:29:35] you're checking that we got data.content, which would be determined by parsoid/restbase... [13:30:50] ah, maybe not [13:30:58] at least not right now [13:31:34] I guess if the API thinks a title exists but the parsoid/restbase call it makes fails... [13:31:39] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to Insert button screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199877 (owner: 10Amire80) [13:31:46] RoanKattouw, ^ [13:32:01] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Capture the whole Insert button in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199872 (owner: 10Amire80) [13:32:45] (03PS1) 10Esanders: Fix documentation of 'choose' event [oojs/ui] - 10https://gerrit.wikimedia.org/r/199878 [13:34:16] (03Merged) 10jenkins-bot: [BrowserTest] Capture the whole Insert button in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199872 (owner: 10Amire80) [13:34:17] (03Merged) 10jenkins-bot: [BrowserTest] Add padding to Insert button screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199877 (owner: 10Amire80) [13:34:25] (03PS2) 10Esanders: Choose can't emit with a null item [oojs/ui] - 10https://gerrit.wikimedia.org/r/199878 [13:42:23] (03PS1) 10Amire80: [BrowserTest] Add padding to editing tabs screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199882 [13:42:25] (03PS1) 10Amire80: [BrowserTest] Add padding to the Formatting menu screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199883 [13:46:01] (03PS1) 10Esanders: Move append to after list builder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199884 [13:46:04] (03PS1) 10Esanders: Remove this.fragment setting from ReferenceDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199885 [14:00:13] (03PS1) 10Amire80: [BrowserTest] Fix the lists and indentation screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199887 [14:00:15] (03PS1) 10Amire80: [BrowserTest] Add padding to the lists and indentation screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199888 [14:10:23] (03PS1) 10Esanders: Balance padding now that focus highlight is balanced [oojs/ui] - 10https://gerrit.wikimedia.org/r/199891 (https://phabricator.wikimedia.org/T73150) [14:13:50] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to the lists and indentation screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199888 (owner: 10Amire80) [14:14:13] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Fix the lists and indentation screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199887 (owner: 10Amire80) [14:14:37] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to editing tabs screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199882 (owner: 10Amire80) [14:16:45] (03Merged) 10jenkins-bot: [BrowserTest] Fix the lists and indentation screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199887 (owner: 10Amire80) [14:20:48] (03PS1) 10Amire80: [BrowserTest] Add the toolbar to the special chars screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199899 [14:24:12] (03PS1) 10Esanders: Fix opacity of icons/indicators in disabled DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/199901 [14:26:10] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add the toolbar to the special chars screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199899 (owner: 10Amire80) [14:26:22] (03CR) 10Zfilipin: [C: 032] [BrowserTest] Add padding to the Formatting menu screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199883 (owner: 10Amire80) [14:28:42] (03Merged) 10jenkins-bot: [BrowserTest] Add the toolbar to the special chars screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199899 (owner: 10Amire80) [14:28:47] (03Merged) 10jenkins-bot: [BrowserTest] Add padding to the Formatting menu screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199883 (owner: 10Amire80) [14:29:56] 10VisualEditor, 6Editing, 6Engineering-Community, 10Possible-Tech-Projects, and 2 others: GSoC'15/Outreachy Proposal for Unified language proofing tools integration framework - https://phabricator.wikimedia.org/T93752#1153022 (10Qgil) [14:31:12] (03PS1) 10Werdna: Enable VisualEditor for Blueprint skin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199904 [14:36:15] (03CR) 10Jforrester: [C: 032] Enable VisualEditor for Blueprint skin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199904 (owner: 10Werdna) [14:36:25] ty James_F [14:38:15] (03Merged) 10jenkins-bot: Enable VisualEditor for Blueprint skin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199904 (owner: 10Werdna) [15:12:58] werdna: Always. :-) [15:29:41] (03CR) 10Jforrester: [C: 031] Skip revId check for new pages (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199868 (owner: 10Esanders) [15:41:28] James_F, I wanted to get Roan to look at that [15:41:36] * James_F nods. [15:41:45] S'why I didn't +2. [15:47:49] https://lists.wikimedia.org/pipermail/mediawiki-l/2015-March/044176.html [15:48:04] probably wrong version combination? [15:48:49] Maybe? Or some odd local code? [15:48:53] (03PS1) 10Mvolz: [WIP] Restructure requestFromDOI + tests [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) [15:49:29] He says extensions are disabled, but what about Common.js? But it seems unlikely. [15:54:09] (03PS1) 10Esanders: Vertially centre cite-web icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199924 [15:54:40] (03PS1) 10Esanders: Replace buttons with select widgets in GeneralReferenceDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199925 [16:08:23] (03CR) 10Mobrovac: [WIP] Restructure requestFromDOI + tests (033 comments) [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) (owner: 10Mvolz) [16:11:33] (03CR) 10Alex Monk: Skip revId check for new pages (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199868 (owner: 10Esanders) [16:48:44] (03CR) 10Mooeypoo: "Isn't the node already attached at that stage, though? It works consistently." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198397 (https://phabricator.wikimedia.org/T92868) (owner: 10Rits) [16:53:28] 10Citoid: Accept and serve cookies - https://phabricator.wikimedia.org/T93877#1153551 (10Mvolz) [16:53:43] 10Citoid, 5Patch-For-Review, 7Technical-Debt: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1153552 (10Mvolz) [16:53:44] 10Citoid, 3Editing Department 2014/15 Q4 blockers: DOI lookup returns a scraped "missing cookie" page instead of desired content - https://phabricator.wikimedia.org/T93785#1146107 (10Mvolz) [16:54:00] 10Citoid, 3Editing Department 2014/15 Q4 blockers: DOI lookup returns a scraped "missing cookie" page instead of desired content - https://phabricator.wikimedia.org/T93785#1146107 (10Mvolz) [16:54:01] 10Citoid, 5Patch-For-Review, 7Technical-Debt: Restructure requestFromDOI - https://phabricator.wikimedia.org/T93876#1148402 (10Mvolz) [16:54:35] (03PS2) 10Mvolz: Restructure requestFromDOI + tests [services/citoid] - 10https://gerrit.wikimedia.org/r/199921 (https://phabricator.wikimedia.org/T93876) [16:56:44] 10Citoid, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: DOI lookup returns a scraped "missing cookie" page instead of desired content - https://phabricator.wikimedia.org/T93785#1153570 (10Mvolz) @Jdforrester-WMF, this specific case is resolved by https://gerrit.wikimedia.org/r/199921, but the g... [16:57:39] 10Citoid: Http error encountered when scraping http://www.tandfonline.com/ urls with native scraper - https://phabricator.wikimedia.org/T91875#1153574 (10Mvolz) [16:57:40] 10Citoid: Accept and serve cookies - https://phabricator.wikimedia.org/T93877#1153575 (10Mvolz) [16:57:51] 10Citoid: Accept and serve cookies - https://phabricator.wikimedia.org/T93877#1153577 (10Mvolz) a:3Mvolz [17:18:50] (03CR) 10Catrope: [C: 04-1] Skip revId check for new pages (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199868 (owner: 10Esanders) [17:22:24] (03PS2) 10Jforrester: "Delete row"/"Delete column" messages now using the plural when multiple rows/columns are selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (owner: 10Pratikbsp) [17:22:31] (03CR) 10Jforrester: "PS2 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (owner: 10Pratikbsp) [17:24:06] (03CR) 10jenkins-bot: [V: 04-1] "Delete row"/"Delete column" messages now using the plural when multiple rows/columns are selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (owner: 10Pratikbsp) [17:25:50] 10VisualEditor, 10VisualEditor-ContentEditable, 3VisualEditor 2014/15 Q3 blockers: Scroll to an item when it is selected e.g. when it has been newly inserted - https://phabricator.wikimedia.org/T53911#1153675 (10Jdforrester-WMF) a:3Mooeypoo [17:26:23] 10VisualEditor, 5Patch-For-Review: Fix styling inconsistencies between context item and inspector - https://phabricator.wikimedia.org/T90896#1153680 (10Jdforrester-WMF) a:3Rits [17:27:09] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: All inspectors get broken after VE tab is idle for a while - https://phabricator.wikimedia.org/T63078#1153681 (10Jdforrester-WMF) a:3Mooeypoo [17:27:34] mooeypoo, if you insert a template that contains no text, e.g. just an image, you get the template icon [17:28:05] 10VisualEditor, 10MediaWiki-extensions-ProofreadPage, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1153688 (10Jdforrester-WMF) p:5Triage>3Low [17:28:12] (03PS2) 10Alex Monk: Fix revId check on new pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199868 (owner: 10Esanders) [17:28:37] RoanKattouw, is that what you mean? ^ [17:28:48] 10VisualEditor, 10MediaWiki-extensions-ProofreadPage, 6Wikisource: Add Visual Editor to Wikisource - https://phabricator.wikimedia.org/T93525#1139268 (10Jdforrester-WMF) >>! In T93525#1144241, @Ricordisamoa wrote: >>>! In T93525#1140648, @Jdforrester-WMF wrote: >> Is this task asking for VisualEditor to be e... [17:28:57] it makes sense to me [17:29:01] edsanders, we've tested on those, though, and it worked -- in fact, that's why we added the sizing test [17:29:04] Krenair: Not really [17:29:08] Krenair: I should have been clearer [17:29:15] I don't like using this.originalHtml as a proxy [17:30:05] Instead, you could just check directly whether this.doc.children[0] (I think that needs to be this.doc.documentNode BTW) has an about attribute that matches the regex [17:30:16] That's what we really care about [17:30:16] 10VisualEditor, 10VisualEditor-ContentEditable: Slugs should not be visible through context menu - https://phabricator.wikimedia.org/T93042#1153699 (10Jdforrester-WMF) a:3Mooeypoo [17:30:51] You did do what I meant regarding the defaulting to 0 stuff [17:32:19] 10VisualEditor: VisualEditor: Using the VE toolbar in MSIE causes the cursor to jump to the start of the page - https://phabricator.wikimedia.org/T75294#1153715 (10MarkAHershberger) Related bug/fix? T66041 [17:33:09] mooeypoo, fails locally for me [17:33:59] (03PS3) 10Alex Monk: Fix revId check on new pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199868 (owner: 10Esanders) [17:34:48] edsanders, what template are you using? I'll test it again [17:34:51] RoanKattouw, why does it need to be documentNode? [17:35:11] mooeypoo, a custom one that renders a plain inline image [17:35:36] ve.init.target.doc.documentNode [17:35:36] undefined [17:36:06] Sorry, documentElement [17:36:11] ok [17:36:13] My bad [17:36:17] edsanders, okay. I'm testing. So what is the alternative code-wise? If we only do this on "setup" (which is emitted only when the node is live) then I'm worried the event might not get emitted at all if the node is rendered before it's attached -- and then after we can't know if it's attached... [17:40:18] (03PS4) 10Alex Monk: Fix revId check on new pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199868 (owner: 10Esanders) [17:41:10] (03CR) 10Alex Monk: "If170a367" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198393 (https://phabricator.wikimedia.org/T92993) (owner: 10Alex Monk) [17:44:37] (03CR) 10Catrope: [C: 032] Fix revId check on new pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199868 (owner: 10Esanders) [17:49:04] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1153763 (10Catrope) >>! In T93045#1151739, @ssastry wrote: > Scratch all that. There are false positives .. I just confirmed by trying to serialize some of these repo... [17:50:07] (03Merged) 10jenkins-bot: Fix revId check on new pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199868 (owner: 10Esanders) [17:50:32] (03PS3) 10Jforrester: "Delete row"/"Delete column" messages now using the plural when multiple rows/columns are selected [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [17:50:38] mooey|away, setup always emits when the node gets attached [17:51:13] you can also update on 'render' but only if this.live is true [17:51:33] (03CR) 10Jforrester: "PS3 folds in the changes done in Iceb7c57." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [17:51:48] mooey|away, but GCN#render does this already [17:51:59] if ( this.live ) { this.emit( 'setup' ) } [17:52:02] Oh right, render emits setup [17:52:07] So you can just do this on setup then [17:52:33] 10VisualEditor, 10VisualEditor-Tables, 5Patch-For-Review: "Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multiple rows/columns) - https://phabricator.wikimedia.org/T87234#1153776 (10Jdforrester-WMF) a:3Pratikbsp [17:57:49] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/199768/ [17:58:16] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/199809/ BTW. [18:03:24] (03CR) 10Catrope: [C: 04-1] Update AUTHORS.txt, $wgExtensionCredits and .mailmap based on git shortlog (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199809 (owner: 10Jforrester) [18:05:16] (03PS2) 10Jforrester: Update AUTHORS.txt, $wgExtensionCredits and .mailmap based on git shortlog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199809 [18:06:00] (03CR) 10Jforrester: Update AUTHORS.txt, $wgExtensionCredits and .mailmap based on git shortlog (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199809 (owner: 10Jforrester) [18:06:38] (03CR) 10jenkins-bot: [V: 04-1] Update AUTHORS.txt, $wgExtensionCredits and .mailmap based on git shortlog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199809 (owner: 10Jforrester) [18:13:33] (03PS1) 10Esanders: Move template icon code to setup event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199959 [18:16:17] 10WikiEditor: Wikieditor (Revert making installable via composer) - https://phabricator.wikimedia.org/T93616#1153844 (10mwjames) > Is this an actual bug report? What action do you want to be taken? If you're running "dev-*", I don't understand how you would expect it to be stable. Yes, because you arbitrarily d... [18:16:41] (03CR) 10jenkins-bot: [V: 04-1] Move template icon code to setup event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199959 (owner: 10Esanders) [18:19:33] I was working yesterday with hexmode and RoanKattouw re VE issues. I have been trying different version permutations: symptoms range from being unable to load VE to editing the wrong page when it does work. hexmode that that might have been fixed in Phabricator T74480. Is there an online summary of dev branches and tags that I could use to determine which code to pull? [18:20:02] Pickle-san: Are you using Internet Explorer? [18:20:12] Cause IIRC T74480 was IE-specific [18:21:50] Krenair: I'm just checking in about the caching issue. I'm still seeing over a million events in the old schema [18:21:54] (per day) [18:22:52] ori: have you had a chance to look at this? Last conversation I saw, Krinkle was thinking the edit schema is cached and not evicted when a new revision is requested? Or ... something [18:22:59] RoanKattouw: Mostly Firefox, some Chrome. The console errors seems to revolve around missing dependencies or "invalid features." I think these errors would be unlikely if I had a self-compatible set of software in that directory. For example, if there is a "successful nightly build" that I could baseline everything to, hopefully the incompatibilities would go away. [18:23:16] milimetric, we think that the edit schema module loaded by clients is not being updated [18:23:19] edsanders, so the solution would be to move the logic of the size check + icon to an onSetup method ? [18:23:24] Pickle-san: Master is always self-compatible. [18:23:33] Pickle-san: It doesn't happen nightly but constantly. [18:23:34] milimetric, if so, this is probably an issue with EventLogging rather than the schema [18:23:35] Krenair: right, I saw some of that conversation, but any update on whether there's anything we can do about it? [18:23:47] yep, agreed [18:23:53] I know nothing about it :) [18:24:01] Yeah it's a bug in EL [18:24:02] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199809 (owner: 10Jforrester) [18:24:06] edsanders, I know that the setup is emitted if this.live, what I was worried about is whether we always set this.live when we're attaching? I remember a conversation about how hard it is to know whether an item is ever attachd to the DOM [18:24:08] oh ok, did you guys file an issue? [18:24:20] I hadn't heard back so I assumed you were still looking into it. I'll open a T [18:24:42] James_F: Should I be able to run 'git checkout origin/master' in my MW and VE directories? [18:25:26] Pickle-san: Well, yes, but it exposes you to risk of breakage that most aren't comfortable. [18:25:46] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199959 (owner: 10Esanders) [18:26:31] https://phabricator.wikimedia.org/T94059 [18:26:38] milimetric, the issue you filed here? https://phabricator.wikimedia.org/T93586 [18:26:39] ori, thoughts about: https://phabricator.wikimedia.org/T94059 are appreciated [18:27:02] ... you created a dupe? [18:27:25] Krenair: no that's separate. The issue I created was for you guys to update the reference, which is done. This is an issue with El [18:27:34] Pickle-san: Especially in production. :o) I do realize that 1.25 is still in the oven. If I wanted to achieve more stability, either with 1.25 or with an earlier release, what would be my best option? We chose 1.25 because the Parsoid extension is shipped "on-board." [18:27:57] James_F:Especially in production. :o) I do realize that 1.25 is still in the oven. If I wanted to achieve more stability, either with 1.25 or with an earlier release, what would be my best option? We chose 1.25 because the Parsoid extension is shipped "on-board." [18:28:00] milimetric, we updated the reference before your task was made [18:28:18] right, but I didn't know that :) [18:28:23] Pickle-san: Master is pretty good; you can see it running on en.wikipedia.org amongst others. ;-) We're happy with it, but we're experts. [18:28:31] Pickle-san: Just want to make sure that you're going in eyes-open. [18:28:43] milimetric, in https://gerrit.wikimedia.org/r/#/q/Ia7b328bd442fb1a41bab837e35ceedf419d1d8dc,n,z [18:29:01] James_F: O-O [18:29:11] Pickle-san: Anyway, yes, if you upgrade MediaWiki and VisualEditor-MediaWiki to master (and composer update in MediaWiki, and git submodule update in VisualEditor-MediaWiki) it /should/ be great. [18:29:18] Well, when he says we run master in production he means like a one-to-two-week-old version of master [18:29:25] Krenair: yeah, I believe you, I just didn't know what the status was because last I left you we were still not sure why it was using the old schema [18:29:27] 1.25wmf23 now I think? [18:29:35] @seen rits [18:29:36] Niharika: Last time I saw rits they were joining the channel, they are still in the channel #mediawiki at 3/26/2015 5:22:41 PM (1h6m54s ago) [18:29:58] 10MediaWiki-Page-editing, 7JavaScript: LivePreview: duplicate 'templates used on this page' list - https://phabricator.wikimedia.org/T78834#1153914 (10TheDJ) 5Open>3Resolved [18:29:59] 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1153916 (10TheDJ) [18:31:01] RoanKattouw, enwiki would be wmf22 still [18:31:16] wmf23 is on group0 wikis (zerowiki, testwiki, test2wiki and mediawikiwiki) [18:32:36] Krenair: test.wikipedia.org is still production [18:32:40] Krenair: But yes. [18:33:06] right, I noticed you mention en.wikipedia.org [18:33:43] milimetric, I think you meant to use a proper phabricator quote in https://phabricator.wikimedia.org/T94059#1153921 [18:33:45] 10VisualEditor, 10WikiEditor, 10Analytics-EventLogging, 10MediaWiki-extensions-WikimediaEvents: Make all Event Logging instrumentation target the same Schema:Edit revision - https://phabricator.wikimedia.org/T93586#1153930 (10Milimetric) 5Open>3Resolved a:3Milimetric The instrumentation from the Edit... [18:33:49] Krinkle made that post [18:33:50] Not me [18:34:15] 10VisualEditor, 10WikiEditor, 10Analytics-EventLogging, 10MediaWiki-extensions-WikimediaEvents: Make all Event Logging instrumentation target the same Schema:Edit revision - https://phabricator.wikimedia.org/T93586#1153933 (10Milimetric) the EL task is: https://phabricator.wikimedia.org/T94059 [18:34:43] milimetric: Yeah, could you Edit :D ? [18:34:56] James_F: Please forgive the git newbie: "Please specify which remote branch you want to use on the command line and try again (e.g. 'git pull ')." [18:35:29] Pickle-san: What happens when you type `git remote -v`? (Not the `?). [18:36:13] James_F: # git remote -v origin https://gerrit.wikimedia.org/r/p/mediawiki/core.git (fetch) origin https://gerrit.wikimedia.org/r/p/mediawiki/core.git (push) [18:36:58] edsanders: Could you please reply to the CR on https://gerrit.wikimedia.org/r/#/c/198729/3 which is blocking merge? [18:37:17] Pickle-san: Hmm. In that case, `git checkout origin/master` should do it. [18:37:21] 10VisualEditor, 10VisualEditor-ContentEditable: Insertion annotation not rendered correctly when coming from the "wrong side" - https://phabricator.wikimedia.org/T94062#1153946 (10Catrope) 3NEW a:3dchan [18:38:08] James_F: # git checkout origin/master Previous HEAD position was 1725858... Merge "Remove never thrown UploadStashNotAvailableException" HEAD is now at b999ccf... Merge "Update OOjs UI to v0.9.4" [18:38:11] Pickle-san: James_F: You'll need to run 'git fetch' first, *then* run 'git checkout origin/master' [18:38:24] To ensure you've got the latest version [18:38:30] I didn't know about the quoting thing, fixed and apologies for mixing up the Kr* [18:38:49] RoanKattouw: Thanks, maybe that's what I'm missing. I've done the checkout a bunch of times. [18:42:44] 10MediaWiki-Page-editing: Error with rollback - https://phabricator.wikimedia.org/T93819#1153975 (10Umherirrender) [18:45:25] (03PS1) 10Jforrester: Update VE core submodule to master (754d3eb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199963 [18:46:18] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (754d3eb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199963 (owner: 10Jforrester) [18:46:56] (03CR) 10Trevor Parscal: [C: 032] Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński) [18:48:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools, 5WMF-deploy-2015-04-01_(1.25wmf24): Weird behavior when backspacing over the end of a list with empty last item - https://phabricator.wikimedia.org/T91349#1153990 (10Jdforrester-WMF) 5Open>3Resolved [18:48:18] edsanders, RoanKattouw what's the best way to get the $element of a selected node through ve.ce.Surface? I have the range through this.model.selection.range but I can't manage to get the ce node or its element. Any advice or general direction? [18:48:24] actually, not RoanKattouw. You're busy. edsanders ? [18:48:46] where is this code? [18:49:01] edsanders, in my computer...? i'm working on a feature/bug. [18:49:13] James_F: RoanKattouw: VisualEditor now loads. No console errors. The only problem is that the loaded page happens to be different than the one I was on: that is, while on page A, click Edit, and page B appears. Edit Source does not share this problem This behavior occurs only after running maintenance/update.php. I wonder whether some data corruption has occurred. [18:49:28] yeah - where is the patch going, what is it for? [18:49:34] divec: MatmaRex: I'm wondering how this (https://gerrit.wikimedia.org/r/#/c/198656/) is going to interact with work divec is doing on https://phabricator.wikimedia.org/T89352 [18:49:55] edsanders, I'm trying to scroll the screen when content is inserted to the page. From tests I ran so far, I think my best bet would be to listen to 'position' on ve.ce.Surface since that is emitted when things are inserted to the dm [18:50:27] Eww don't use the position event for that [18:50:27] edsanders, there, I can have the range of the newly inserted node because it's selected. I just want to get its element now so I can calculate if it's in the screen and if not, scroll to it. [18:50:32] no? why? [18:50:34] That's for repositioning overlayed things [18:50:37] (overlain?) [18:50:50] it seems to be emitted whenever a new thing is added, though [18:50:58] the only event I could see that's consistently emitted with all cases? [18:51:51] you can just use model events for that [18:52:30] TrevorParscal: divec: no idea, that was a drive-by patch [18:52:33] edsanders, I thought about that, but then I'd have a lot more events, no? There's insertionAnnotation event, and a different event for branch node and focusable node [18:53:26] Why not just listen for documentUpdate on dm.Surface? [18:53:31] That happens every time a transaction occurs [18:53:36] (03Merged) 10jenkins-bot: Update VE core submodule to master (754d3eb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199963 (owner: 10Jforrester) [18:53:40] Then check the selection is in view and if not scroll it into view [18:53:54] (You need documentUpdate instead of transact, because when transact is emitted the selection hasn't been updated yet) [18:53:55] MatmaRex: given he +1'd, i'm cool with it [18:54:36] (03CR) 10Jforrester: "So, is the test incorrect and needs fixing, or the test is correct and this needs fixing?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński) [18:54:44] RoanKattouw, documentUpdate is fired way more than I need, though [18:54:53] (03Merged) 10jenkins-bot: Improve backspacing over the end of a list with empty last item [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/196741 (https://phabricator.wikimedia.org/T91349) (owner: 10Bartosz Dziewoński) [18:55:32] That was the first place I tried to examine. I ended up having the event trigger a bunch of times while a node was inserted and after. I was trying to see if I can listen to an event that's after the content was inserted but when the CE was updated [18:55:38] is that not the right strategy? [18:55:47] MatmaRex: but there are failing tests in https://gerrit.wikimedia.org/r/#/c/198656/ [18:55:56] mooeypoo: Well the task says "scroll to nodes when inserted" but really shouldn't be ensure the selection is always visible, regardless of how that selection came to be? [18:56:01] *shouldn't we [18:56:03] "ve.ce.Surface handleLinearDelete FAILED" [18:56:10] yeah. i'm just looking [18:56:11] "Selection is not lost inside block slug after backspace: selection" [18:56:14] cool, thanks [18:56:21] they used to pass when i submitted it, eh [18:56:39] RoanKattouw, yes, hence why I was trying to work on the update event [18:56:50] But apparently that's not the right place [18:56:52] TrevorParscal: so, you're in CR mode now? can you look at https://gerrit.wikimedia.org/r/#/c/197135/ again, and my last comment? [18:57:12] MatmaRex: He's got a list of 16 things to work on from me first. :-) [18:57:24] Krenair: So have you done anything re https://gerrit.wikimedia.org/r/#/c/196720/ (RESTbase) recently? [18:57:25] 10OOjs-UI, 10UI-Standardization, 7Design: Remove the yellow autofill background on inputs that chrome and other browsers add - https://phabricator.wikimedia.org/T94010#1154024 (10Jaredzimmerman-WMF) We're not removing the Autofill predictions, only the yellow background which causes inconsistency between fie... [18:57:31] aight [18:57:56] Krenair: If not I'm just gonna go ahead and try and get it to work with your revid comparison code [18:58:50] 10OOjs-UI, 10UI-Standardization, 7Design: Remove the yellow autofill background on inputs that chrome and other browsers add - https://phabricator.wikimedia.org/T94010#1154043 (10Jdforrester-WMF) This seems like an anti-pattern, breaking a standard Web feature in the name of design consistency on a page that... [18:59:14] (03PS6) 10Bartosz Dziewoński: Ensure that selection is not lost inside block slugs after backspace/delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 [19:00:27] (03PS5) 10Catrope: [WIP] Send requests to RESTbase directly when so configured [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) [19:00:56] RoanKattouw, mooeypoo do we want to do that on every transaction/insert? [19:01:21] I mean I guess that depends on how expensive it is [19:01:34] Maybe we could do it while rendering the selection instead? [19:01:40] for example what if the transaction came from elsewhere (e.g. multi-user) [19:02:15] Like in ve.ce.Surface#showSelection [19:02:21] right [19:02:28] edsanders: Over-optimisation? [19:02:50] James_F: No he's right, we don't want the page to scroll back to the cursor constantly because someone else is typing [19:03:29] James_F: Here is an error preceding our issue that might have relevance: Query: INSERT IGNORE INTO `dxwiki2_pagelinks` (pl_from,pl_from_namespace,pl_namespace,pl_title) VALUES ('16669','2','0','CiteExample'),('16669','2','0','AnotherExample') Function: LinksUpdate::incrTableUpdate Error: 1054 Unknown column 'pl_from_namespace' in 'field list' (localhost) [19:04:35] (03CR) 10Trevor Parscal: [C: 032] ve.ui.SurfaceWidget: Insert toolbar dialog manager into toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197135 (https://phabricator.wikimedia.org/T91600) (owner: 10Bartosz Dziewoński) [19:05:33] I think showSelection covers it [19:05:52] edsanders, well, isn't that what position is for? the docs say " * When the surface changes its position (only if it happens after initialize has already been called)" [19:05:56] am i misunderstanding? [19:06:30] position means something on the surface may have moved [19:07:04] either via transaction, or the viewport resizing, or some CE component changing size [19:07:34] if *anything* moves relative to the top left corner of the surface, then a position event should me emitted [19:07:38] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References, 5WMF-deploy-2015-04-01_(1.25wmf24): [Regression wmf20] Special Character inserter does not work in Media captions or basic references - https://phabricator.wikimedia.org/T91600#1154074 (10Jdforrester-WMF) 5Open>3Resolved [19:07:42] (03CR) 10Trevor Parscal: [C: 032] Ensure that selection is not lost inside block slugs after backspace/delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński) [19:07:49] 'position' means "if you drew overlays on top of the surface based on the position of a thing in the surface, you need to redraw those overlays now" [19:08:16] Pickle-san: Oh, whoops. Run update.php. [19:09:07] Krinkle: can I run this by you to make sure I understand the EL bug? [19:09:22] milimetric: OK [19:09:24] context? [19:09:35] 10VisualEditor, 7Technical-Debt: SurfaceWidget should be called TargetWidget - https://phabricator.wikimedia.org/T94066#1154079 (10Esanders) 3NEW [19:09:35] the problem with getModifiedTime in EL [19:09:46] so module Schema:Edit has timestamp NOW + revision as the modified time [19:10:05] Pickle-san: `composer update` and then `php maintenance/update.php`. [19:10:12] and let's say module "Nice" has timestamp NOW as the modified time [19:10:38] edsanders: https://gerrit.wikimedia.org/r/#/c/198258/1 doesn't this mean floated things in RTL will not follow the text direction correctly? [19:10:53] or... I guess, float left in RTL is interpreted as right [19:10:58] so.. we don't need to flip it [19:11:00] (03CR) 10Esanders: [C: 04-2] ve.ui.SurfaceWidget: Insert toolbar dialog manager into toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197135 (https://phabricator.wikimedia.org/T91600) (owner: 10Bartosz Dziewoński) [19:11:13] when both of these modules are requested together, you're saying that the timestamp for Nice is going to be used, and since it's < NOW + revision, the revision schema wouldn't be updated? [19:11:19] edsanders: ignore me [19:11:22] I'm slow this morning [19:11:25] that was a horrible explanation [19:11:27] :) [19:11:53] (03CR) 10Trevor Parscal: [C: 032] Add clears to default floats [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198258 (owner: 10Esanders) [19:12:01] Basically, you're saying if getModifiedTime returned the actual timestamp of the schema revision, everything should work out [19:12:17] James_F: Already done. I had previously run the 1.23 update.php on this installation, then 1.25. I believe running the 1.25 version is the point at which the problem was introduced. [19:12:31] TrevorParscal, yeah - unfortunately MW doesn't use 'before' and 'after', but 'left' and 'right' and it appears ve core is doomed to follow :/ [19:12:47] (this is the first time I've ever looked at ResourceLoader, it kind of makes sense but I want to make sure I get it) [19:12:49] Pickle-san: Done since you updated git to master? [19:13:09] edsanders: lame :( [19:13:27] (03CR) 10Esanders: ve.ui.SurfaceWidget: Insert toolbar dialog manager into toolbar (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197135 (https://phabricator.wikimedia.org/T91600) (owner: 10Bartosz Dziewoński) [19:13:43] James_F: Yes. Updated MW and VE, git submodule update --init, composer update, php maintenance/update.php. [19:14:10] Pickle-san: Hmm. `pl_from_namespace` should exist? [19:14:29] mooeypoo, so position will fire on every keystroke [19:15:24] James_F: This error occurred *before* the 1.25 update. Did pl_from_namespace exist in 1.23? [19:15:37] [12:12] milimetric Basically, you're saying if getModifiedTime returned the actual timestamp of the schema revision, everything should work out [19:15:41] milimetric: So, the problem is this [19:16:01] (03CR) 10Bartosz Dziewoński: ve.ui.SurfaceWidget: Insert toolbar dialog manager into toolbar (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197135 (https://phabricator.wikimedia.org/T91600) (owner: 10Bartosz Dziewoński) [19:16:23] milimetric: The schema module doesn't have a convenient way to access the real timestamp of the schema revision, so instead it fakes it by returning epoch + revid, where epoch is some time in 2011 and revid is small enough in practice that you still end up somewhere in 2011 [19:16:36] Now this is monotonically increasing, so if the schema were requested by itself then this would be fine [19:16:37] yep [19:16:48] that makes sense [19:17:11] And in fact if the schema module had a getGroup() method that returned 'eventlogging' or really any other value that's not '' and not used by anyone else, that is in fact what would happen and everything would be fine [19:17:13] I got it wrong that $wgCacheEpoch == NOW then [19:17:45] Yeah no, $wgCacheEpoch is basically the last time we did something so spectacularly earth-shattering that any cache entries before that are just laughably invalid [19:17:56] (03Merged) 10jenkins-bot: Ensure that selection is not lost inside block slugs after backspace/delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198656 (owner: 10Bartosz Dziewoński) [19:17:59] (03Merged) 10jenkins-bot: Add clears to default floats [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198258 (owner: 10Esanders) [19:18:14] But the problem is, requests for schema modules get combined with requests for other modules [19:18:41] For a multi-module request, the timestamp that's used for cache invalidation is max(timestamps of the requested modules) [19:19:13] So if an EL schema module is requested together with pretty much anything else, that other module will probably have a timestamp later than 2011 [19:19:20] And so the schema module's timestamp is effectively ignored [19:19:23] yep, that makes sense [19:19:43] If you update the revid and the schema module timestamp moves a few minutes into the future, it'll still be in 2011 and whatever it's combined with will still be in 2015, so the max() doesn't change [19:19:48] hm, so do you suggest implementing getGroup() or finding a way of making getModifiedTime return something more sensible? [19:19:54] Ideally, the latter [19:19:59] But that might be difficult [19:20:05] gotcha [19:20:15] Doing the getGroup() thing harms performance, because it segregates schemas and makes them be requested separately [19:20:18] 10Citoid, 6Services: Configure OCG, Parsoid and Citoid to report counter metrics - https://phabricator.wikimedia.org/T94053#1154127 (10Mvolz) [19:20:41] (schemas would still be combined with other schemas, but that would be OK because the timestamp scheme used here is at least self-compatible) [19:21:15] RoanKattouw: ok, I'll try to see if there's a way to make a better getModifiedTime and if not I'll look at examples of getGroup [19:21:25] * milimetric rolls up his sleeves and gets ready to do his first PHP work [19:21:37] The getGroup thing is something that I just came up with, and I'd want Krinkle's blessing before going with that strategy [19:21:44] James_F: Comparing my production environment (1.23) with staging (1.25) I do see that pl_from_namespace is a new column in dxwiki2_pagelinks. I suspect what is going on is that this column is populated in 1.25 with information from somewhere else when update.php is run. However, since we are running into errors in the 1.23 environment, the starting point is flawed, which translates into bad data in the new colu [19:21:44] ack [19:22:12] milimetric: catching up [19:22:29] Krinkle: no worries, Roan explained it well. What you said in the comment made sense [19:22:34] but I had no context or experience with this stuff [19:22:36] thx both [19:22:41] edsanders, oy. That's not good. But if I go with model changes, that's not reflecting selection changes. Then again, selection change seems to be fired whenever we click on anything, which isn't exactly useful either. Any idea how to approach this, then, or should I put this aside for a much bigger strategic assessment? [19:23:05] Krinkle: I would like your input on my getGroup() suggestion though. I realize it's horrible but I'm wondering how acceptable you think it is as a workaround [19:23:27] milimetric: Server-side cache is done based on content-hashing, never based on timestamps. So as long as your access url has never been used before, you get the absolute freshest. If part of it was used before, you'll get minification from cache, otehrwise we'll minify it and then cache it. [19:23:35] Pickle-san: But doesn't update.php correct for this? [19:23:53] milimetric: The client-side hits Varnish, based on unique urls. The urls have a 'version' parameter what is generally the max() of all requested modules. [19:24:21] milimetric: So yeah, if a module was changed just now, but it timestamp doesn't surface out of max(), the url will remain the same and it won't get a fresh url to create a new varnish entry. [19:24:22] yep, and that max() is going to be > the EL schema module's getModifiedTime [19:24:56] milimetric: If you request foo + schema.Edit and you change foo with proper modified timestamp (e.g. a File module), then everything is fine because they're requested together. [19:25:20] milimetric: But if Foo is already changed, deployed and *after* you change schema.Edit and *only* schema.Edit, it's deployment will likely not do much. [19:25:28] because it has a tiemstamp from 1970 [19:25:29] Krinkle: So we need to touch VE wmf22 and WE wmf22 branches and it will get magically fixed? [19:25:41] schemas are not files, can't be touched. [19:26:37] sounds like we need to fix getModifiedTime [19:27:38] milimetric: Yeah. Its' not super trivial to do that because the class the schema module uses doesn't expose it right now [19:27:40] James_F: I've run update.php a lot. I just now re-ran it and confirmed the "page skew" still occurs. [19:27:42] milimetric: Sure, I meant more as a can-we-fix-this-for-now-in-a-few-seconds. [19:27:47] MatmaRex: could you take a look at fixing the font sizes in ve.init.mw.ViewPageTarget-monobook.css ? [19:27:48] Pickle-san: Huuh. [19:28:02] inspectors, dialogs, the welcome dialog and toolbar dialogs are all different sizes :( [19:28:08] normal dialogs look correct [19:28:15] inspectors and toolbar dialogs are too big [19:28:16] James_F: I welcome any quick fix here, I really just want the data and to finish crunchign it [19:28:19] milimetric: James_F: This came up > 24h ago. Is this currently broken in production anywhere? [19:28:22] TrevorParscal: sounds like a sub-case of https://phabricator.wikimedia.org/T91152 [19:28:33] the welcome dialog is too small (when applying https://gerrit.wikimedia.org/r/#/c/199755) [19:28:45] Krinkle: this is the first I hear of it, I missed the Phab ping [19:29:03] if ( !isset( $parserParams['oldid'] ) || $parserParams['oldid'] === 0 ) { [19:29:04] MatmaRex: no, this is like the diff between 0.8 and 0.6 or 0.8 and 1.5 [19:29:04] $parserParams['oldid'] = $latestRevision->getId(); [19:29:05] but it seems like this would be broken all over the place since the beginning of time [19:29:13] Krenair: Well I guess that ----^^ is why we don't currently have a race condition [19:29:14] Silly me [19:29:30] TrevorParscal: well, yeah. [19:29:35] Krinkle: milimetric mentioned over a million events a day being wrong. [19:29:37] Krinkle, RoanKattouw (sorry, late to all this) can you explain then why the schema will be correctly retrieved in some instances? [19:29:41] we apply font-size in ems in a ton of places [19:29:42] James_F: OK [19:29:48] and it accumulates in the weirdest ways [19:29:58] nuria: I can explain separately so as not to duplicate that here [19:30:00] MatmaRex: Should we spec instead in rems? [19:30:05] nuria: Things are requested in batches. If the schema happens to tag along, the clieint gets a fresh one [19:30:09] Krenair: So have you done anything re https://gerrit.wikimedia.org/r/#/c/196720/ (RESTbase) recently? [19:30:11] monobook sure looks messed up [19:30:13] haven't since we last spoke about it [19:30:16] nuria: It also works when we introduce a new schema, as there wouldn't be an old version. [19:30:21] James_F: Does update.php perform a sanity check on this column and correct it, if out-of-sorts? [19:30:26] James_F: possibly, but i think we should just not specify it. [19:30:28] nuria: new schema by differnet name I mean. [19:30:34] Pickle-san: I think so. [19:30:42] it involved moving stuff from the server to the client... sigh :/ [19:30:45] Pickle-san: But apparently it's not working for you? [19:30:53] ooui was designed with body { font-size: 0.8em; } in mind [19:30:59] nuria: Imagine Wikipedia always returning the first revision of a page. If you create a new page, you'll see the right version. [19:31:20] Pickle-san: (I'm assuming that the error is happening since you ran update.php and isn't just an old log line. :-)) [19:31:22] but instead the font-size: 0.8em is applied in various funny places. like on toolbars and dialogs, but not popups, for example. [19:31:35] so we have a layer on hacks on top of it in VE [19:31:53] and the tiniest changes in DOM of surface and related things break stuff [19:32:13] milimetric: So yeah, the ApiSchema in EL will need to expose rev_timetamp (should be trivial), then propagate in RemoteSchema with a getter, and then in the getModifiedTimstamp, take that into account instead of rev id. [19:32:16] Krenair: OK, I'm working on it now [19:32:45] Krinkle: ok, so is it the user path through user site: if the requested "+schema" things are ok [19:33:08] TrevorParscal: is this a recent regression? [19:33:27] nuria: Yeah, it's not reflecting an old version of the world, just old version within the scope of a single schema or module. [19:33:31] MatmaRex: Recent-ish. Monobook was fine a few weeks ago last I looked. [19:33:43] I don't know when it started, but I just noticed it when working on z-index issues with https://gerrit.wikimedia.org/r/#/c/199755 [19:33:53] James_F: The error is from turning on debug in production, where folks are routinely getting a "Database error" when saving commits. In the test/staging area, I am updating the software, importing the latest data, and then running update.php. Until I run update.php I see the "Database erorr;" after running update.php, I see the page skew. [19:34:00] I'm taking care of the welcome dialog font-sizing in a patch to https://gerrit.wikimedia.org/r/#/c/199755 right now [19:34:03] Krinkle: Exposing rev_timestamp cross-wiki isn't that trivial [19:34:13] RoanKattouw: It isn't. [19:34:17] but inspectors and toolbar dialogs need to be targeted too I think [19:34:18] can you guys give me a bit of context? [19:34:19] i vaguely recall that it had font size inconsistencies like a month or two ago already; but i'm not sure if it had inspectors with double the normal font size then [19:34:19] Krinkle: Oh, I see, through the API module, I get it [19:34:23] :) [19:34:23] re: RoanKattouw, Krinkle [19:34:37] ori: EL uses epoch+revision id as timestamp, which is wrong. [19:35:13] ori: yea, we basically want getModifiedTime to return schema->rev_timestamp [19:35:41] here: https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/master/includes/ResourceLoaderSchemaModule.php#L91 [19:36:13] I was going to start messing with it in vagrant, btw, unless someone else wants to [19:36:32] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor's interface on MonoBook has crazy font sizes - https://phabricator.wikimedia.org/T94071#1154162 (10matmarex) 3NEW a:3matmarex [19:36:37] TrevorParscal: ^ will fix tomorrow [19:36:49] (03PS5) 10Trevor Parscal: Show beta welcome dialog before surface is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) (owner: 10Mooeypoo) [19:36:52] MatmaRex: thanks [19:37:01] i think i need to sleep now or something, i'm completely useless right now [19:37:08] (03CR) 10Trevor Parscal: [C: 032] Show beta welcome dialog before surface is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) (owner: 10Mooeypoo) [19:37:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24): Load and display the welcome dialog straight after the toolbar, without waiting for the content area - https://phabricator.wikimedia.org/T90454#1154183 (10TrevorPars... [19:39:53] milimetric, Krinkle: OK, sounds right to me. [19:40:01] please allow me to review the patch, when it is submitted [19:40:08] of course [19:40:57] (03Merged) 10jenkins-bot: Show beta welcome dialog before surface is ready [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199755 (https://phabricator.wikimedia.org/T90454) (owner: 10Mooeypoo) [19:41:09] RoanKattouw: I think James_F has signed out. As far as you know, should update.php be able to sanity-check or regenerate the data in *pagelinks.pl_from_namespace? I think some errors currently occurring in our database are causing skewed results in this column when running update.php. [19:42:05] 10MediaWiki-ResourceLoader, 10OOjs-UI, 7Technical-Debt: Get rid of 'type' stuff in ResourceLoaderImageModule and OOUI's colorize-svg.js - https://phabricator.wikimedia.org/T94073#1154192 (10matmarex) 3NEW a:3matmarex [19:42:12] RoanKattouw: Is there another way to sanity-check or regenerate this column? [19:42:19] 10MediaWiki-ResourceLoader, 10OOjs-UI, 7Technical-Debt: Get rid of 'type' stuff in ResourceLoaderImageModule and OOUI's colorize-svg.js - https://phabricator.wikimedia.org/T94073#1154202 (10matmarex) [19:42:43] 10MediaWiki-ResourceLoader, 10Gather, 6Mobile-Web, 10MobileFrontend-Feature-requests, 5Patch-For-Review: ResourceLoaderImage module css rules should be more configurable - https://phabricator.wikimedia.org/T78215#1154208 (10matmarex) [19:42:44] 10MediaWiki-ResourceLoader, 10OOjs-UI, 7Technical-Debt: Get rid of 'type' stuff in ResourceLoaderImageModule and OOUI's colorize-svg.js - https://phabricator.wikimedia.org/T94073#1154192 (10matmarex) [19:42:48] 10MediaWiki-ResourceLoader: Refactor ResourceLoader versioning system to use hashes instead of timestamps - https://phabricator.wikimedia.org/T94074#1154210 (10Krinkle) 3NEW [19:42:54] RoanKattouw_away: ori: ^ [19:42:56] TrevorP|Away: might be of interest to you: https://phabricator.wikimedia.org/T94073#1154192 [19:43:15] ori: fyi, Roan and I discussed hashes many times but never got around to it [19:44:11] 10MediaWiki-ResourceLoader: Refactor ResourceLoader versioning system to use hashes instead of timestamps - https://phabricator.wikimedia.org/T94074#1154231 (10Krinkle) [19:44:18] Krinkle: yes, that's a much better model. [19:45:27] ori: Hm.. as quick fix I suppose we could already do + operation on the timestamps client-side, right? [19:45:37] Who cares it'll look like a timestamp from the year 3000 [19:46:08] what do you mean? [19:46:15] ori: right now we max() timesamps [19:46:16] just using a base date set far in the future? [19:46:37] if we instead add them up in a sum, deploying old changes would work properly [19:46:45] because the sum would be higher, even if the max isn't [19:47:07] essentially what I proposed with hashes, but with numbers [19:47:49] not sure if that's worth the risk doing as quick fix [19:48:25] this wouldn't be for EL, but more reliability in general when deploying changes. [19:48:46] I imagine we'll still have this problem when someone edits Meta-Wiki and we only deploy it some time later [19:49:02] if anything else is deployed before that, that's another risk of hitting a similar bug [19:49:11] there's also localStorage versioning [19:49:14] yeah [19:49:30] hashes seem like a better model [19:49:32] so this maxing issue should be minimal [19:49:36] Krinkle, milimetric note that we have A LOT of events on the new schema so this shouldn't require a quick fix [19:49:38] ori: no doubt but I mean for short term [19:49:56] ori: so where do those millions of events come from? [19:50:07] Even with the current EL 1970 timestamp, localStorage should be working [19:50:23] maybe from browsers without localStorage support? [19:50:34] i have no idea what the millions of events are, I don't have the context for this conversation [19:50:37] i tuned in late [19:50:38] nuria: Is there any commonality between those events compared to proper events? [19:50:50] nuria: e.g. older browsers maybe? [19:50:55] that would help a lot :) [19:51:23] we have two schemas, revids are like 113... and 114... [19:51:27] Krinkle: i can look at that but I thinkthe "majority" of events are ok that is why the explanation leaves a little to be desired [19:52:01] the 113... one is getting a steady stream of 1.3 million events daily [19:52:16] so nuria, no, the majority are not ok [19:52:22] nuria: yeah, we'll definitely bring EL in line with other ResourceLoader modules. Whatever it causing it, milimetric's patch (not the "quick fix") will address that. [19:52:46] (03CR) 10Esanders: [C: 032] ve.ui.SurfaceWidget: Insert toolbar dialog manager into toolbar (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197135 (https://phabricator.wikimedia.org/T91600) (owner: 10Bartosz Dziewoński) [19:52:59] milimetric: Ah, so you reckon even latest Chrome is spewing some of those millions of events? [19:53:05] btw guys, if any of you can knock this patch out quickly, go ahead [19:53:17] I don't even have the dev environment set up, this is the first PHP work literally I would ever do [19:53:25] milimetric: changing RL itself will take a few days at least. I'd rather help you with EL [19:53:33] milimetric: Oh, right. I didn't know that. [19:53:34] milimetric: That might have to do with invalid events, please check my numbers for today [19:53:39] on ticket: [19:53:57] https://phabricator.wikimedia.org/T94059 cause (dislexia aside) [19:54:00] I'm not set up to test EL very well, but I know know what the patch shoul look like I think [19:54:07] I'll have ori review then [19:54:12] OK. Patching :) [19:54:51] there are 2.4 million events and 1.4 million of those have the right 11448630 schema [19:55:08] Krinkle: lemme look at UAs [19:55:14] (03Merged) 10jenkins-bot: ve.ui.SurfaceWidget: Insert toolbar dialog manager into toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/197135 (https://phabricator.wikimedia.org/T91600) (owner: 10Bartosz Dziewoński) [19:57:22] Krinkle: ya, plenty of chrome 41 on requests with schema 11448630 (latest) [20:01:38] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Outreachy and GSoC 2015 Proposal for Graph editing in Visual Editor - https://phabricator.wikimedia.org/T93788#1154306 (10Rits) [20:06:37] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Right floated elements other than images and info boxes are not placed correctly - https://phabricator.wikimedia.org/T59296#1154318 (10TheDJ) This seems mostly fixed to me. Is that correct team ? [20:18:45] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Right floated elements other than images and info boxes are not placed correctly - https://phabricator.wikimedia.org/T59296#1154369 (10Etonkovidova) I checked in production some samples from https://en.wikipedia.org/wiki/Template:Stack: {{stack |[... [20:22:30] 10OOjs-UI, 10OOjs-UI-0.9.1, 10UI-Standardization, 7Design, and 2 others: Use a new focus indicator on text fields - https://phabricator.wikimedia.org/T73150#1154377 (10Jaredzimmerman-WMF) @APerson thank you for the feedback, it is appreciated, there are two reasons that we changed the focus state for the i... [20:28:11] 10VisualEditor, 10VisualEditor-EditingTools: Oldid notice in VisualEditor is shown below the header - https://phabricator.wikimedia.org/T94082#1154441 (10TheDJ) 3NEW [20:31:55] 10VisualEditor: oldid is not added to the VE edittab link, when opening an oldid in the Wikitext Editor. - https://phabricator.wikimedia.org/T94084#1154472 (10TheDJ) 3NEW [20:32:14] (03PS2) 10Jforrester: [WIP] Make IE opacity hack not double-apply opacity once IE bug is fixed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179242 (owner: 10Catrope) [20:32:22] (03PS2) 10Jforrester: Link inspector: Set href of open button to new value, not old. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182432 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk) [20:32:43] (03PS2) 10Jforrester: Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [20:32:48] (03PS2) 10Jforrester: Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [20:33:25] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari: VisualEditor: Clearing float from a template like {{-}} doesn't work - https://phabricator.wikimedia.org/T67249#1154489 (10TheDJ) This problem seems fixed, as far as I can assess... [20:34:43] Pickle-san: Sorry for going |Away; I suspect something's off with how config now works, then. Someone else reported the "wrong page's content comes back when I click edit" issue, I believe. [20:36:19] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Right floated elements other than images and info boxes are not placed correctly - https://phabricator.wikimedia.org/T59296#1154512 (10TheDJ) If I remember correctly, it would be that the right floating stack, was opened in VE as full width and left... [20:36:35] (03CR) 10Trevor Parscal: [C: 032] Move template icon code to setup event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199959 (owner: 10Esanders) [20:37:10] (03CR) 10jenkins-bot: [V: 04-1] Add ve.ce.View#initialize to eliminate constructor/onSetup duplication [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195236 (owner: 10Catrope) [20:37:13] 10VisualEditor, 10VisualEditor-ContentEditable, 7Browser-Support-Apple-Safari: VisualEditor: Clearing float from a template like {{-}} doesn't work - https://phabricator.wikimedia.org/T67249#1154518 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF Confirmed, now seems fixed (tested in Safari 8.0.4). [20:37:18] (03CR) 10jenkins-bot: [V: 04-1] Render HTML attributes in ce.View#initialize rather than in the constructor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/195238 (owner: 10Catrope) [20:38:56] (03Merged) 10jenkins-bot: Move template icon code to setup event [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199959 (owner: 10Esanders) [20:39:08] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 6Security: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - https://phabricator.wikimedia.org/T53423#1154534 (10csteipp) [20:40:25] 10MediaWiki-ResourceLoader, 6Security: using "<" in as a value in the lang query string throws exception - https://phabricator.wikimedia.org/T48332#1154610 (10csteipp) [20:40:41] 10MediaWiki-Page-editing, 6Security: Cross-site scripting at page editing - https://phabricator.wikimedia.org/T48085#1154625 (10csteipp) [20:41:11] 10MediaWiki-ResourceLoader, 6Security: CSRF token-stealing attack (user.tokens) - https://phabricator.wikimedia.org/T36907#1154656 (10csteipp) [20:42:46] (03CR) 10Trevor Parscal: [C: 032] Vertially centre cite-web icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199924 (owner: 10Esanders) [20:43:05] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - https://phabricator.wikimedia.org/T53423#1154687 (10csteipp) [20:44:03] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 7Tracking: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#1154697 (10Jdforrester-WMF) [20:44:05] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - https://phabricator.wikimedia.org/T53423#1154694 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF >>! In T53423#1031831, @Ak... [20:44:34] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 7Tracking: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#583191 (10Jdforrester-WMF) [20:44:35] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Yet Another Broken Browser Plugin Injecting Garbage in Pages (Norton?) - https://phabricator.wikimedia.org/T65229#1154705 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF We believe that this is now worked around. [20:44:36] (03Merged) 10jenkins-bot: Vertially centre cite-web icon [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199924 (owner: 10Esanders) [20:45:00] (03CR) 10Trevor Parscal: [C: 032] Move append to after list builder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199884 (owner: 10Esanders) [20:45:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - https://phabricator.wikimedia.org/T53423#1154713 (10csteipp) 5Resolved>3Open a:5Jdforrester-WMF>3None [20:45:05] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 7Tracking: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#1154715 (10csteipp) [20:45:26] (03CR) 10Trevor Parscal: [C: 032] Remove this.fragment setting from ReferenceDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199885 (owner: 10Esanders) [20:47:34] (03Merged) 10jenkins-bot: Move append to after list builder [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199884 (owner: 10Esanders) [20:47:36] (03CR) 10Trevor Parscal: [C: 032] Replace buttons with select widgets in GeneralReferenceDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199925 (owner: 10Esanders) [20:47:55] (03Merged) 10jenkins-bot: Remove this.fragment setting from ReferenceDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199885 (owner: 10Esanders) [20:48:42] (03CR) 10Trevor Parscal: [C: 032] Fix opacity of icons/indicators in disabled DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/199901 (owner: 10Esanders) [20:49:01] (03CR) 10Trevor Parscal: [C: 032] Balance padding now that focus highlight is balanced [oojs/ui] - 10https://gerrit.wikimedia.org/r/199891 (https://phabricator.wikimedia.org/T73150) (owner: 10Esanders) [20:49:02] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 7Tracking: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#1154735 (10Jdforrester-WMF) [20:49:43] (03CR) 10Trevor Parscal: [C: 032] Choose can't emit with a null item [oojs/ui] - 10https://gerrit.wikimedia.org/r/199878 (owner: 10Esanders) [20:50:03] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki, 7Tracking: Broken browser plugins cause cruft to be injected into the page - https://phabricator.wikimedia.org/T54327#583191 (10Jdforrester-WMF) [20:50:05] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: VisualEditor: Broken DivX browser plugin causes "myEventWatcherDiv" to be injected into the page - https://phabricator.wikimedia.org/T53423#1154736 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF [20:52:37] (03Merged) 10jenkins-bot: Replace buttons with select widgets in GeneralReferenceDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199925 (owner: 10Esanders) [20:53:36] (03PS7) 10Trevor Parscal: Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 (owner: 10Mooeypoo) [20:53:39] (03Merged) 10jenkins-bot: Fix opacity of icons/indicators in disabled DecoratedOptionWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/199901 (owner: 10Esanders) [20:53:55] (03Merged) 10jenkins-bot: Balance padding now that focus highlight is balanced [oojs/ui] - 10https://gerrit.wikimedia.org/r/199891 (https://phabricator.wikimedia.org/T73150) (owner: 10Esanders) [20:54:21] (03Merged) 10jenkins-bot: Choose can't emit with a null item [oojs/ui] - 10https://gerrit.wikimedia.org/r/199878 (owner: 10Esanders) [20:57:25] (03CR) 10Trevor Parscal: [C: 032] Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 (owner: 10Mooeypoo) [21:00:21] (03Merged) 10jenkins-bot: Use 'rerender' event for generated content in citoid inspector [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/197774 (owner: 10Mooeypoo) [21:02:15] edsanders: how's it going? [21:02:35] all good, what's up? [21:03:14] so, this whole events vs. method thing for initialize [21:03:17] for ce nodes [21:03:21] yeah [21:03:43] what I really believe is the right choice is to not allow this.$element to be swapped out, but instead to just replace the CE node [21:03:47] with a new one [21:04:12] I've gotten the impression you and Roan estimate this to be a lot of work [21:04:18] I was hoping you could help me size it up [21:04:31] um - I hadn't thought how much work it would be [21:04:42] Also BTW I just realized [21:04:44] I'm also interested in you challenging my idea [21:04:49] This isn't just about GeneratedContentNode [21:04:56] It's also about vs ,

vs

, etc [21:05:00] (updateTagName) [21:05:06] yeah [21:05:08] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Right floated elements other than images and info boxes are not placed correctly - https://phabricator.wikimedia.org/T59296#1155047 (10Etonkovidova) >>! In T59296#1154512, @TheDJ wrote: > If I remember correctly, it would be that the right floating... [21:05:49] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Right floated elements other than images and info boxes are not placed correctly - https://phabricator.wikimedia.org/T59296#1155051 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [21:05:49] I think the allowing this.$element to be replaced has a lot of unintended conciquences, whereas we already assume ce nodes in the tree are ephemeral so replacing them as needed is safe [21:05:52] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: Add original dimensions information from the API to data-mw - https://phabricator.wikimedia.org/T64881#1155054 (10cscott) Should missing/error images have `data-file-width`/`data-file-height` attributes? Right now I'... [21:06:16] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Right floated elements other than images and info boxes are not placed correctly - https://phabricator.wikimedia.org/T59296#619151 (10Jdforrester-WMF) I vaguely think there was another task (since fixed) which this duplicates, but I have no idea wha... [21:06:31] yes - I'm trying to think of where else we might be doing something similar [21:07:12] we do use the init/setup/teardown pattern quite a lot [21:07:31] ve.ce.BranchNode.prototype.updateTagName (as roan said) [21:07:32] but this is really init/attach/detach [21:08:04] in addition to ve.ce.GeneratedContentNode.prototype.render [21:08:13] hm. James_F TrevorParscal I'm going over this bug, and I think there's a "worse" thing in there that requires a bit of product / design thinking: https://phabricator.wikimedia.org/T93042 [21:08:37] I'm trying to think why we might want to keep mutable $elements [21:09:07] can you justify it for any other reason than this event problem? [21:09:46] James_F, TrevorParscal, since we allow for practically anything in those basic references, there can be cases of completely weirdness. For the moment, the context allows hte user to click and interact with the rendered node so that the user can click a link, but that also means we can interact with slugs and weirdly aligned images. Maybe that's not a good idea? Should we block interaction on the context, and have it as a preview-only? [21:09:49] (specifically that 'setup' is actually 'afterAttach' and therefore too late to add a class) [21:10:05] mooeypoo: No, we want it to be interacted with. [21:10:16] I just think making this.$element mutable is dangerous, and makes everything more complex, so if it's avoidable (maybe it's not) we should avoid it [21:10:20] (03PS3) 10Jforrester: Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [21:11:05] James_F, all of it, always? this isn't just about links, it's images, templates, etc? [21:11:13] mooeypoo: we shouldn't include slugs in the renderings - we need to filter them out or something [21:11:27] But is it just the slugs, or is this exposing a bigger issue? [21:11:34] but we want the contents to be able to be clicked on (but not selected) [21:11:46] hmm. [21:11:48] I believe it's just slugs, personally [21:11:54] * mooeypoo nods [21:11:55] they get rendered into CE trees [21:12:00] (03CR) 10Jforrester: Add an example property to parameters (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [21:12:00] we copy them [21:12:03] (03PS4) 10Jforrester: Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [21:12:09] (03CR) 10Jforrester: [C: 032] Add an example property to parameters [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [21:12:22] 10TemplateData, 5Patch-For-Review, 7user-notice: TemplateData: Provide property "example" for template parameters - https://phabricator.wikimedia.org/T53049#1155069 (10Jdforrester-WMF) 5Open>3Resolved [21:12:23] Okay [21:12:43] 10TemplateData, 5WMF-deploy-2015-04-01_(1.25wmf24), 7user-notice: TemplateData: Provide property "example" for template parameters - https://phabricator.wikimedia.org/T53049#577562 (10Jdforrester-WMF) [21:13:17] either figure out a way to not generate them in certain cases (a config option perhaps) or just filter them out of the rendering [21:13:28] I think the latter is totally defensible, esp. in the short term [21:13:32] James_F: (Just returning myself) OK, thanks, good to know. The code is rather straightforward and seems to reside in maintenance/archives/patch-pl_from_namespace.sql. I suppose one question on my mind would be whether it should be possible to reconstruct this column someday if we are currently failing to perform desirable inserts elsewhere in the table. [21:13:38] we do other DOM manipulation already (link targets) [21:14:20] Pickle-san: I don't know much about the interwiki database table, sorry. [21:14:22] James_F: That is, the 1.25 software can't perform inserts into the 1.23 schema and will not be able to until we run update.php -- which will result in the error we have been discussing. [21:14:53] Pickle-san: No, I'm almost certain that the update.php action isn't causing the breakage in VE pointing to the wrong page. [21:15:09] James_F: OK, thanks. [21:15:29] (03CR) 10Jforrester: [C: 031] "Whoops, I still want Timo to OK this." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/194386 (https://phabricator.wikimedia.org/T53049) (owner: 10Mooeypoo) [21:16:54] 10VisualEditor, 10VisualEditor-ContentEditable: Slugs should not be visible through context menu - https://phabricator.wikimedia.org/T93042#1155123 (10Etonkovidova) [21:16:55] 10VisualEditor: Nonfunctional slugs appear in reference context item - https://phabricator.wikimedia.org/T92572#1155122 (10Etonkovidova) [21:17:12] TrevorParscal: Hi. Some VE pull-down menus have a "More" element at the bottom. Would it be correct to say that in normal circumstances only one of those will be visible on the screen? [21:17:13] edsanders: where I'm at is this: Roan is going to add an event to his patch to support FocusableNode and we are going to go that route in the short term [21:17:28] TrevorParscal, yeah. Okay, I can do that. I'm still a little concerned that this is just a symptom, but I can gloat^W^W fix it when we find something bigger. [21:17:35] shalom mooeypoo [21:17:39] haya aharoni [21:17:40] James_F: Still, the problem is not observed until running update.php. I am not suggesting that update.php is *causing* the corruption, but that it is revealing corruptiong that we are continually compounding because our database is incompatible. I wonder whether it would be better to run the more current update.php now and deal with problems as they occur. [21:17:50] 10VisualEditor, 10VisualEditor-Performance, 5Patch-For-Review, 3VisualEditor 2014/15 Q3 blockers: Retrieve page HTML directly from RESTbase - https://phabricator.wikimedia.org/T90374#1155135 (10Catrope) [21:18:02] aharoni: well, it's a toolbar list toolgroup [21:18:22] so, within the toolbar the lists are mutually exclusive [21:18:24] aharoni: There is a bug in OOUI that makes it possible to show multiple, especially on a tablet, but under normal circumstances yes [21:19:22] so if we disregard the bugs, is '.oo-ui-popupToolGroup-active .oo-ui-tool-name-more-fewer' a reasonable selector for the "More" element that is currently active? [21:19:28] (it's for browser tests) [21:19:29] yeah, there's a problem where we show the already open and the one being opened while the mouse is down [21:19:41] that is probably the issue in mobile, or at least related [21:19:58] aharoni: yes [21:20:03] TrevorParscal: cool, thank you [21:20:07] n/p [21:21:14] TrevorParscal, ok - I think your idea is ok - but I'm not strongly opposed to a solution which did allow mutation of $element either [21:21:42] we can revisit the "should $element be mutable" after the release [21:21:50] I'm still open to being challenged there [21:22:06] I just want to do as little collateral damage in the mean time [21:26:02] sure [21:26:21] James_F: Is there an IRC feed for development on the interwiki table? The might actually be the nexus of our problem, and I might need to look for some help in that forum. [21:34:05] hey aharoni [21:35:18] Pickle-san: The best would be #mediawiki-core or #wikimedia-dev but really that area doesn't get many changes so I don't know how helpful they'll be. [21:36:50] 10Citoid, 10VisualEditor, 7Verified-in-Phase0, 7Verified-in-Phase2, 5WMF-deploy-2015-03-18_(1.25wmf22): [Regression pre-wmf22] Cannot switch to VE in beta - "Cannot read property 'mw' of undefined {stack: (...)" by Citoid - https://phabricator.wikimedia.org/T92866#1155239 (10Ryasmeen) [21:38:30] 10VisualEditor, 10VisualEditor-EditingTools, 7Verified-in-Phase0, 7Verified-in-Phase2, and 3 others: [Regression wmf22] Link removal doesn't work on first click anymore - https://phabricator.wikimedia.org/T93363#1155243 (10Ryasmeen) [21:39:31] (03PS4) 10Jforrester: TemplateData: add PLURAL to message Templatedata-modal-notice-import-numparams [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199224 (owner: 10Purodha) [21:39:49] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 7Verified-in-Phase0, 7Verified-in-Phase2, and 3 others: Focusable hIghlight logic is broken, only rendering for the root element - https://phabricator.wikimedia.org/T93322#1155244 (10Ryasmeen) [21:42:31] (03CR) 10Trevor Parscal: [C: 032] Update AUTHORS.txt, $wgExtensionCredits and .mailmap based on git shortlog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199809 (owner: 10Jforrester) [21:43:13] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 3VisualEditor 2014/15 Q3 blockers, 5WMF-deploy-2015-03-18_(1.25wmf22): Wordbreak detection is faulty for selection starting just up-page of a link annotation - https://phabricator.wikimedia.org/T86399#1155253 (10Ryasmeen) Fixed... [21:44:21] (03CR) 10Trevor Parscal: [C: 032] Fixed the empty Transclusion Box problem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198131 (owner: 10Ankita-ks) [21:44:49] (03CR) 10Trevor Parscal: [C: 032] TemplateData: add PLURAL to message Templatedata-modal-notice-import-numparams [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199224 (owner: 10Purodha) [21:45:29] (03PS3) 10Jforrester: Fixed the empty Transclusion Box problem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198131 (https://phabricator.wikimedia.org/T52281) (owner: 10Ankita-ks) [21:45:52] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Verified-in-Phase0, and 2 others: Wordbreak detection is faulty for selection starting just up-page of a link annotation - https://phabricator.wikimedia.org/T86399#1155260 (10Ryasmeen) [21:45:55] 10VisualEditor, 10VisualEditor-EditingTools, 5WMF-deploy-2015-04-01_(1.25wmf24): VisualEditor: Empty transclusion editor is empty, needs some kind of reassuring message - https://phabricator.wikimedia.org/T52281#1155261 (10Jdforrester-WMF) 5Open>3Resolved [21:45:56] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Improve the UX of the template editor - https://phabricator.wikimedia.org/T63822#1155263 (10Jdforrester-WMF) [21:46:16] James_F: Looks like the file in question was added by aschulz almost exactly a year ago. It it possible to determine which IRC he's on? Perhaps I can just try the two you suggest and see whether there's a nick that could be him. [21:46:19] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 7Verified-in-Phase0, and 3 others: Wordbreak detection is faulty for selection starting just up-page of a link annotation - https://phabricator.wikimedia.org/T86399#967881 (10Ryasmeen) [21:46:23] (03CR) 10Jforrester: "PS3: Adjust qqq message to compensate; correct $1 to $2; fix indenting." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199224 (owner: 10Purodha) [21:48:59] Pickle-san: That's AaronSchulz who is in #wikimedia-dev. [21:52:58] 10VisualEditor, 10MediaWiki-extensions-Graph, 10Parsoid, 10Possible-Tech-Projects, and 3 others: Outreachy and GSoC 2015 Proposal for Graph editing in Visual Editor - https://phabricator.wikimedia.org/T93788#1155281 (10Rits) [21:54:39] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: [[Mediawiki:Badtitletext]] being added to articles - https://phabricator.wikimedia.org/T93045#1155290 (10ssastry) Okay, I slurped the relevant log entries from kibana via curl and extracted the HTML snippets and ran them through parsoid html2wt and found a few... [21:54:40] James_F: Yep, I see him on there, thanks. [21:56:42] 10VisualEditor: Tables: when a table needs to wrap up input text, typing white spaces entered in front of the text mak a cursor go forward and back - https://phabricator.wikimedia.org/T94103#1155293 (10Etonkovidova) 3NEW [21:57:21] mvolz: please review my task https://phabricator.wikimedia.org/T93788 , thanks and mooey will not come today now ? :( [22:03:07] Krenair: hallo [22:03:11] hi! [22:03:36] mvolz:^ [22:03:37] for https://gerrit.wikimedia.org/r/#/c/197357/3 we'll want to move all wikieditor-toolbar-characters-page-* messages into MW core [22:03:44] (03CR) 10Mattflaschen: "Updated" (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/198473 (https://phabricator.wikimedia.org/T93465) (owner: 10Mattflaschen) [22:03:50] how can we do this sanely without losing translations etc. aharoni? [22:04:40] Krenair: hmm hmm hmm [22:05:03] keys would need changing of course [22:05:26] I *think* that there's a way to rename keys and move them from group to group, [22:05:56] but siebrand and Raimond are usually doing these exports, imports and keys maintenance, [22:06:10] I don't know all the intricacies. [22:06:15] it's best to ask on the mediawiki-i18n mailing list. [22:07:14] ok, thanks aharoni [22:09:47] 10MediaWiki-Page-editing, 7JavaScript, 7Tracking: Live preview (requires JavaScript) feature bugs (tracking) - https://phabricator.wikimedia.org/T41272#1155367 (10TheDJ) [22:09:49] 10MediaWiki-Page-editing, 10MediaWiki-extensions-ProofreadPage, 7JavaScript: New improved LivePreview incompatible with ProofreadPage's fancy forms for Index: namespace pages - https://phabricator.wikimedia.org/T78709#1155363 (10TheDJ) 5Resolved>3Open Reopen due to causing regression T94089 [22:11:49] (03Merged) 10jenkins-bot: Update AUTHORS.txt, $wgExtensionCredits and .mailmap based on git shortlog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/199809 (owner: 10Jforrester) [22:11:51] (03Merged) 10jenkins-bot: TemplateData: add PLURAL to message Templatedata-modal-notice-import-numparams [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/199224 (owner: 10Purodha) [22:17:00] aharoni, I sent an email [22:23:52] RoanKattouw: please review my proposal https://phabricator.wikimedia.org/T93788 , thanks for your time [22:24:50] rits: BTW did you see mooey|away and edsanders|away reviewed your commit ( https://gerrit.wikimedia.org/r/#/c/198397/ ) and left a bunch of comments on patchset 2? [22:25:20] (03CR) 10Catrope: [C: 032] Fixed the empty Transclusion Box problem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198131 (https://phabricator.wikimedia.org/T52281) (owner: 10Ankita-ks) [22:27:17] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review, and 3 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1155447 (10Mattflaschen) [22:27:18] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1155448 (10Mattflaschen) [22:27:27] RoanKattouw: yes i did see it , actually i was having my exams by that time and now i focused on the proposal as the deadline has just a day left, i have started working on their reviews , sorry for the late [22:27:34] OK no worries [22:27:50] Just making sure you saw, because the comments weren't on the latest patchset and that often confuses people (even staff) [22:28:45] RoanKattouw: ya a bad patchset by me :( [22:29:04] 10VisualEditor, 10Flow: Click outside to close doesn't always work as intended for mention inspector - https://phabricator.wikimedia.org/T94109#1155450 (10Mattflaschen) 3NEW [22:29:34] RoanKattouw: i will surely grab it now [22:32:08] 10Cite, 7I18n: Superscript reference numbers cause increase in line height with devanagari text - https://phabricator.wikimedia.org/T43442#1155477 (10kaldari) @Siddhartha-Ghai: Yes, sup.reference {line-height:1;} can be removed from the common.css now. I went ahead and did so. [22:32:18] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review: Toolbar should appear to be within text area - https://phabricator.wikimedia.org/T94112#1155479 (10Mattflaschen) 3NEW a:3Mattflaschen [22:33:38] (03PS1) 10Amire80: [BrowserTest] Show the full Formatting pull-down in the screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200055 [22:34:19] 10VisualEditor, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review, and 3 others: S5. Flow: Implement VE toolbar layout - https://phabricator.wikimedia.org/T90764#1155499 (10Mattflaschen) >>! In T90764#1140523, @Pginer-WMF wrote: > It is great to see this live. Thanks (and thanks to Matth... [22:38:07] (03Merged) 10jenkins-bot: Fixed the empty Transclusion Box problem [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/198131 (https://phabricator.wikimedia.org/T52281) (owner: 10Ankita-ks) [22:44:12] (03PS6) 10Catrope: Send requests to RESTbase directly when so configured [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) [22:44:14] (03PS1) 10Catrope: ApiVisualEditor: Rename $page to $title, since it's a Title, not a WikiPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200058 [22:44:23] (03PS2) 10Catrope: ApiVisualEditor: Rename $page to $title, since it's a Title, not a WikiPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200058 [22:44:29] (03PS7) 10Catrope: Send requests to RESTbase directly when so configured [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) [22:46:00] (03PS3) 10Catrope: ApiVisualEditor: Rename $page to $title, since it's a Title, not a WikiPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200058 [22:49:34] need little help! [22:50:04] normal button in oojsui has a 1px solid border but quiet buttons don't have that. resulting in different sizes for normal button and quiet button. [22:50:16] is it okay to add 1px solid transparent border to quiet buttons. [22:50:17] ? [22:51:01] nzr: That's really a question for Trevor who went home to deal with the fact that his kid is headed to the hospital [22:51:16] probably [22:51:22] But probably yes [22:51:31] it's better not to use quiet buttons :/ [22:52:07] 10VisualEditor: oo-ui-clippableElement misaligned - https://phabricator.wikimedia.org/T94114#1155533 (10Etonkovidova) 3NEW [22:53:51] 10VisualEditor: Category popup misaligned - https://phabricator.wikimedia.org/T94114#1155543 (10Catrope) [22:54:45] (03PS3) 10Physikerwelt: wip live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/199886 [22:55:03] Krenair: If you're still awake, I have https://gerrit.wikimedia.org/r/#/c/200058 for you [22:55:12] (03PS8) 10Catrope: Send requests to RESTbase directly when so configured [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) [22:55:30] Krenair: and https://gerrit.wikimedia.org/r/#/c/196720/ which is now ready (I am still doing a bit more testing on it) [22:55:36] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 10Parsoid, 7Design: Spaces at the start of a paragraph aren't very obvious - https://phabricator.wikimedia.org/T68628#1155548 (10Whatamidoing-WMF) I'm having second thoughts about my earlier all-clear. It's possible that this prob... [22:55:40] I didn't do the two-way checking thing, I kept your code that just reloads both [22:56:47] lolwtf [22:56:51] Good think I tested [22:57:01] I get a revids don't match warning but the revids are the same [22:57:36] intval() to the rescue [22:57:41] (one was a string, the other a number) [22:57:42] RoanKattouw, have been busy doing some college stuff (due on the last day of term - i.e. tomorrow) [22:57:43] (03CR) 10jenkins-bot: [V: 04-1] wip live index update [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/199886 (owner: 10Physikerwelt) [22:57:45] but I'll take a look [22:57:54] Krenair: OK don't worry man [22:58:07] Krenair: School stuff due tomorrow is higher priority [23:00:14] (03CR) 10Alex Monk: [C: 032] ApiVisualEditor: Rename $page to $title, since it's a Title, not a WikiPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200058 (owner: 10Catrope) [23:01:05] (03PS9) 10Catrope: Send requests to RESTbase directly when so configured [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) [23:02:21] (03Merged) 10jenkins-bot: ApiVisualEditor: Rename $page to $title, since it's a Title, not a WikiPage [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200058 (owner: 10Catrope) [23:03:10] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 7Verified-in-Phase0, 3VisualEditor 2014/15 Q3 blockers: Cite: 'Autofill from URL' initially shows Basic as a type for inserted citation in context menu, then corrects when re-selected - https://phabricator.wikimedia.org/T88152#1155581 (10Etonk... [23:07:49] (03PS1) 10Catrope: When content and metadata have different revids, explicitly retry the higher one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200064 [23:08:50] 10VisualEditor, 10VisualEditor-ContentEditable, 7Verified-in-Phase0, 7Verified-in-Phase2, and 2 others: Deleting through a list throws an exception - https://phabricator.wikimedia.org/T92286#1155594 (10Etonkovidova) [23:08:53] (03PS1) 10Amire80: [BrowserTest] Add padding to the page settings item screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200065 [23:08:55] (03PS1) 10Amire80: [BrowserTest] Add padding to the Edit Links screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200066 [23:08:57] (03PS1) 10Amire80: [BrowserTest] Add padding to screenshots of the page settings dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200067 [23:08:59] (03PS1) 10Amire80: [BrowserTest] Add padding to the "Apply changes" button screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200068 [23:09:15] woah I managed to get the new loading bar to go backwards [23:09:49] (03CR) 10Alex Monk: [C: 032] Send requests to RESTbase directly when so configured [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) (owner: 10Catrope) [23:10:23] lol [23:10:40] Krenair: I noticed that that ---^^ breaks pretty often without https://gerrit.wikimedia.org/r/200064 [23:10:43] Thanks for +2ing though :) [23:11:43] RoanKattouw, with or without restbase being involved? [23:11:49] Oh only with RB, sorry [23:11:52] I can only test without restbase, obviously [23:12:31] relying on the beta cluster to confirm it with restbase [23:12:49] Right [23:12:54] I actually managed to get RESTbase running locally [23:13:06] After a bit of fighting with it and getting Gabriel to explain things to me [23:13:19] Because it turns out nobody had tried it before, not even them [23:13:25] Hey folks, what's the status of Citoid? Was it deployed to enwp after it. and frwp? [23:13:28] (They have local instances but they run against WMF wikis, not local wikis) [23:13:38] guillom: Let me check real quick [23:13:43] thanks! [23:14:03] Last I heard was "we don't know yet if we'll deploy it" but that was over a week ago [23:14:21] guillom: Best I can tell it's .... deployed everywhere? :O [23:14:28] Oh. [23:14:35] Well, that's new :D [23:14:35] But maybe it requires a config page in the MediaWiki namespace that's not present everywhere [23:14:45] Ah, yes. There's some configuration involved. [23:14:46] Yeah [23:14:50] I think I put it on all wmf22 wikis [23:14:53] which is now everywhere [23:14:55] Yeah, it needs https://fr.wikipedia.org/wiki/MediaWiki:Citoid-template-type-map.json [23:15:00] You just need to configure it per-wiki [23:15:03] Which is empty on enwiki [23:15:56] Thank you both! [23:16:29] * Krenair prods jenkins [23:16:32] Unfortunately the mwgrep tool only searches .js and .css files in the MW namespace it seems, not .json files [23:16:37] So I can't easily tell you which wikis have it [23:16:41] (03Merged) 10jenkins-bot: Send requests to RESTbase directly when so configured [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/196720 (https://phabricator.wikimedia.org/T90374) (owner: 10Catrope) [23:17:02] RoanKattouw, mwgrep is trivial to modify to your needs [23:17:14] RoanKattouw: I know frwp and itwp have it, and the next one in line AFAIK is enwp, so if enwp doesn't have it, that's probably it. [23:17:31] It's enough for tech news anyway :) [23:17:47] guillom: Locally patched version of mwgrep says frwiki, itwiki, test2wiki [23:17:59] great. Thank you! [23:23:50] (03CR) 10Alex Monk: When content and metadata have different revids, explicitly retry the higher one (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200064 (owner: 10Catrope) [23:25:27] (03CR) 10Alex Monk: When content and metadata have different revids, explicitly retry the higher one (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200064 (owner: 10Catrope) [23:28:18] (03CR) 10Catrope: When content and metadata have different revids, explicitly retry the higher one (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200064 (owner: 10Catrope) [23:33:07] 10VisualEditor, 10VisualEditor-EditingTools, 7Design, 7Epic, and 5 others: Cite: Auto-filled references based on destination URL / DOI etc. - https://phabricator.wikimedia.org/T62768#1155657 (10gpaumier) [23:37:15] (03CR) 10Alex Monk: [C: 032] When content and metadata have different revids, explicitly retry the higher one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200064 (owner: 10Catrope) [23:48:26] (03Merged) 10jenkins-bot: When content and metadata have different revids, explicitly retry the higher one [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200064 (owner: 10Catrope) [23:52:34] 10VisualEditor, 3VisualEditor 2014/15 Q3 blockers: Internal links [[Xxx]] replaced by [[./Xxxx]] - https://phabricator.wikimedia.org/T93754#1155700 (10ssastry) [23:56:37] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, and 2 others: Add original dimensions information from the API to data-mw - https://phabricator.wikimedia.org/T64881#1155712 (10ssastry) This will go out on Monday. Roan confirmed that there are no VE changes that are required. Als... [23:57:59] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 7Blocked-on-Parsoid, 3VisualEditor 2014/15 Q3 blockers: Make available original image dimensions info from the API in Parsoid DOM. - https://phabricator.wikimedia.org/T64881#1155713 (10ssastry) 5Open>3Resolved [23:58:46] so, Blaise seems to be OK