[00:00:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: When typing {{ in iOS, the surface scrolls down - https://phabricator.wikimedia.org/T95248#1184371 (10Catrope) [00:01:32] 10VisualEditor: Lets not have "Delete" option enabled when the only item inside Transclusion Dialog is "Add template" , as that cannot be deleted - https://phabricator.wikimedia.org/T95252#1184374 (10Ryasmeen) 3NEW [00:01:48] 10VisualEditor, 10VisualEditor-DataModel, 10Parsoid, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1184381 (10Catrope) 5Open>3Resolved [00:02:03] 10VisualEditor: Lets not have "Delete" option enabled when the only item inside Transclusion Dialog is "Add template" , as that cannot be deleted - https://phabricator.wikimedia.org/T95252#1184383 (10Ryasmeen) [00:02:07] 10VisualEditor, 10VisualEditor-DataModel, 10Parsoid, 3Editing Department 2014/15 Q4 blockers, and 2 others: Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1178622 (10Catrope) [00:02:39] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): [Regression wmf 24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1184388 (10Catrope) [00:03:02] 10VisualEditor: Lets not have "Delete" option enabled when the only item inside Transclusion Dialog is "Add template" , as that cannot be deleted - https://phabricator.wikimedia.org/T95252#1184374 (10Ryasmeen) Also trash icon is red on the right side panel and black on the left side [00:05:09] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, and 4 others: S5. Flow: Integrate VE toolbar in Flow entry fields - https://phabricator.wikimedia.org/T90764#1184398 (10DannyH) [00:05:12] 10VisualEditor, 6Collaboration-Team, 10Collaboration-Team-Sprint-T-2015-04-08, 10Flow, 5Patch-For-Review: S6. Flow: Switching from VE to wikitext and back without losing content - https://phabricator.wikimedia.org/T90763#1184396 (10DannyH) 5Open>3Resolved Done [00:05:57] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Link context item appears when selecting image whose entire caption is a link - https://phabricator.wikimedia.org/T95246#1184400 (10Catrope) [00:10:11] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Link context item appears when selecting image whose entire caption is a link - https://phabricator.wikimedia.org/T95246#1184407 (10Catrope) That inspector shouldn't even **be** there. Seems to be because `getAnnotationsFromRange()` doesn't take `ignoreC... [00:15:14] 10OOjs-UI: MediaWiki theme: Checkboxes and radios look oversized on desktop - https://phabricator.wikimedia.org/T86003#1184423 (10violetto) It's a normal practice for designers to create within context so it works like you mentioned, no worries there. We upload clean specs because it's clearer for production usa... [00:22:09] 10VisualEditor, 10VisualEditor-ContentEditable: Insertion annotation not rendered correctly when coming from the "wrong side" - https://phabricator.wikimedia.org/T94062#1184435 (10dchan) Also, in Firefox, if you click just left of the annotation boundary then you land inside the annotation; whereas if you clic... [01:05:48] (03CR) 10Prtksxna: "Thanks Ed! I'll set this up for May!" [oojs/ui] - 10https://gerrit.wikimedia.org/r/201639 (owner: 10Violetto) [01:27:32] (03PS2) 10Krinkle: fixupInsertion: Don't attempt to call .getClonedElement() on the DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200644 (owner: 10Catrope) [01:29:14] (03CR) 10Krinkle: [C: 032] fixupInsertion: Don't attempt to call .getClonedElement() on the DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200644 (owner: 10Catrope) [01:32:00] (03Merged) 10jenkins-bot: fixupInsertion: Don't attempt to call .getClonedElement() on the DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200644 (owner: 10Catrope) [02:02:36] https://integration.wikimedia.org/cover/visualeditor/ [02:19:18] (03PS1) 10Cscott: Encode and decode HTML entities in comment nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202311 (https://phabricator.wikimedia.org/T95040) [02:21:25] (03CR) 10jenkins-bot: [V: 04-1] Encode and decode HTML entities in comment nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202311 (https://phabricator.wikimedia.org/T95040) (owner: 10Cscott) [02:24:46] (03PS2) 10Cscott: Encode and decode HTML entities in comment nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202311 (https://phabricator.wikimedia.org/T95040) [02:25:07] (03PS1) 10Krinkle: gitignore: Update test-coverage to coverage (follows-up 04fb668) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202312 [02:32:47] (03CR) 10Krinkle: "https://integration.wikimedia.org/cover/visualeditor/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201939 (owner: 10Krinkle) [02:36:38] (03CR) 10Catrope: [C: 032] gitignore: Update test-coverage to coverage (follows-up 04fb668) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202312 (owner: 10Krinkle) [02:40:05] (03PS2) 10Krinkle: build: Add 'doc' entry point [unicodejs] - 10https://gerrit.wikimedia.org/r/201944 [02:44:27] (03Merged) 10jenkins-bot: gitignore: Update test-coverage to coverage (follows-up 04fb668) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202312 (owner: 10Krinkle) [03:00:32] (03CR) 10Krinkle: Defer loading easy-deflate (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [03:07:52] (03PS1) 10Krinkle: build: Run lint before build in grunt-test [oojs/ui] - 10https://gerrit.wikimedia.org/r/202315 [03:09:18] (03PS1) 10Krinkle: build: Run lint before build in grunt-test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202316 [03:23:43] (03CR) 10Krinkle: [C: 04-1] "If I understand correctly, this parses arbitrary html client-side. Which violates out security and sanitizer restrictions." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202311 (https://phabricator.wikimedia.org/T95040) (owner: 10Cscott) [05:44:20] 10OOjs-UI, 10UI-Standardization, 7Accessibility, 7Design, 5Patch-For-Review: Return focus to the last location when a modal dialog is dismissed - https://phabricator.wikimedia.org/T87714#1184742 (10Prtksxna) Thanks for the explanation @thedj! I knew only a fraction of the things that you mentioned. I am... [05:49:57] (03PS2) 10Prtksxna: WindowManager: Add a $giveFocus property [oojs/ui] - 10https://gerrit.wikimedia.org/r/201680 (https://phabricator.wikimedia.org/T87714) [05:54:25] (03CR) 10jenkins-bot: [V: 04-1] WindowManager: Add a $giveFocus property [oojs/ui] - 10https://gerrit.wikimedia.org/r/201680 (https://phabricator.wikimedia.org/T87714) (owner: 10Prtksxna) [05:56:51] (03PS3) 10Prtksxna: WindowManager: Add a $giveFocus property [oojs/ui] - 10https://gerrit.wikimedia.org/r/201680 (https://phabricator.wikimedia.org/T87714) [06:03:23] (03CR) 10Catrope: "While in theory explicit decoding should never be necessary, the relevant Parsoid change side-steps a bug in HTML5 by encoding in :en:Microsoft [19:42:56] (03PS2) 10Esanders: [BREAKING CHANGE] Give the converter a 'fromClipboard' mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202437 (https://phabricator.wikimedia.org/T94724) [19:43:03] cscott:
xy
works fine in Chrome [19:43:04] Krinkle: in that case, it's the -- which needs to be escaped. [19:43:46] Krinkle: not when you parse it as XML (which VE does) [19:44:03] Krinkle: and there are a number of other crazy cases in the HTML5 comment parser [19:44:54] itemized in https://gerrit.wikimedia.org/r/#/c/202058/12/lib/mediawiki.DOMUtils.js [19:44:58] cscott: OK. So if we'd decode it on the client (to then use as text node value in a span), would VE send it to Parsoid as span or convert back to comment? [19:45:12] (03CR) 10Esanders: [C: 031] Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [19:45:27] Krinkle: the patch under consideration uses comments for both sides of the round trip. [19:45:44] VE just needs to HTML-decode on input and HTML-encode certain evil characters on output [19:45:51] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Give the converter a 'fromClipboard' mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202437 (https://phabricator.wikimedia.org/T94724) (owner: 10Esanders) [19:45:51] cscott: I'd like to see how the browser escapes it when creating such comment in an XML DOM. [19:45:54] s/HTML/entity/ [19:45:59] Krinkle: it doesn't. [19:46:09] e.g. usnig document.createComment [19:46:09] Krinkle: it happily creates unserializable DOM. [19:46:12] Krinkle: yes. [19:46:31] Krinkle: it is a bug in the spec, RoanKattouw and I discussed this at some length the other day. [19:46:49] document.createComment("-->") will happily serialize to --> [19:46:51] cscott: so what happens when you serialise an XML DOM with such comment in it [19:46:55] ^ [19:46:59] Interesting [19:47:00] (03PS3) 10Esanders: [BREAKING CHANGE] Give the converter a 'fromClipboard' mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202437 (https://phabricator.wikimedia.org/T94724) [19:47:08] in theory it's supposed to throw an exception. but then they took that out of the spec. [19:47:26] RoanKattouw found all the skeletons buried in mozilla's bugzilla for this. [19:47:47] links? [19:47:51] I'd like to file it at whatwg [19:47:54] this can be fixed. [19:48:16] we'll still need patches on our end fo rnow [19:48:19] I have a Mozilla bug for this, hold on [19:48:38] Krinkle: https://bugzilla.mozilla.org/show_bug.cgi?id=1150991 [19:49:04] (03PS1) 10Esanders: [PULL THROUGH] Update getModelFromDom signature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202477 [19:49:14] 10MediaWiki-Page-editing, 7Testme: Log events occasionally not logged - https://phabricator.wikimedia.org/T14129#1187260 (10aaron) Is this still a problem? [19:49:19] That links to the older Firefox bug where they removed an exception from createComment() (which was still documented on MDN until I removed that last week) and to the equivalent Chrome bug [19:49:29] http://paste.debian.net/165550/ has RoanKattouw and my conversation from the other day [19:49:33] To be fair, I only included the --> part, I didn't include the other stuff in cscott's comment [19:49:53] Partly though that's because Parsoid has the additional concern of emitting polyglot HTML (HTML that is also valid XML) [19:50:28] is no problem in regular HTML, but it's a problem for polyglot because XML is stricter and doesn't allow -- anywhere in a comment (or - at the end) [19:50:39] The HTML5 parsing spec has a bunch of weird compatibility cases for comments as well. [19:50:42] Like --!> [19:50:48] and '-' as the first character in the comment [19:51:00] so it's not like XML is the only bad guy here [19:51:10] it just so happens that we get the worse of both worlds [19:51:26] but just escaping - and > makes unicorns and rainbows reappear [19:54:04] (XML would only need - escaped. But HTML5 needs > escaped as well, because is a valid HTML5 comment (!)) [19:54:11] cscott: RoanKattouw: https://gist.github.com/Krinkle/1437de41481789ac6c96 [19:55:41] What the ... [19:55:58] And window.document had there?! [19:56:11] that seems like a firefox bug, clearly. [19:57:06] unless firefox is trying to use XML comment rules, maybe? still weird, though. [19:57:13] https://gist.github.com/Krinkle/1437de41481789ac6c96?r2 [19:57:16] that's worse [19:58:10] Yeah that's expected [19:58:16] What happens with div.innerHTML = "x"; ? [19:58:17] That's what my bug is about [19:58:29] x = document.createComment( 'Foo-->Bar' ); [19:58:33] div.appendChild(x); [19:58:38] x.innerHTML; [19:58:47] Bar [19:58:50] div.childNodes; [19:59:01] [CommentNode "Foo-->Bar"] [19:59:10] (Sorry, x.innerHTML is Bar-->) [19:59:18] div.innerHTML = div.innerHTML; // (!) [19:59:18] Comment has innerHTML? [19:59:34] Sorry, *div*.innerHTML is ... [19:59:37] div.childNodes [19:59:40] chrome's behavior is more-or-less expected, since document.createComment is "known" to let you create bogus stuff. [19:59:48] [CommentNode "Foo", TextNode "Bar-->"] [19:59:57] (which is why we should be entity-escaping what we give to document.createComment, as my patch does, hint hint) [20:00:06] Yeah createComment can create comment nodes that on round-trip leak some of their text into a text node [20:00:29] This whole comment thing is a total nightmare [20:00:39] RoanKattouw found the mozilla bug listing innerHTML round-tripping failures, this would be one of them. [20:01:07] Yeah I tagged it against that one [20:01:10] For that reason [20:01:38] anyway, i hope you now agree that comments are a nightmare and we should be more careful about what we try to put into them. :) [20:03:28] I'm chatting in #whatwg now [20:03:48] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor on Mobile web doesn't detect wikitext insertion - https://phabricator.wikimedia.org/T95335#1187298 (10gpaumier) 3NEW [20:03:51] But yeah, seems like escaping html special chars and '-' is inevitable [20:04:06] cscott: I'm worried about round tripping though a valid DOM is more important. [20:04:10] ambiguity [20:04:31] double escape/decode [20:04:43] Krinkle: Parsoid takes care of that so you don't have to. (tm) [20:05:04] cscott: For wikitext yes, but it means VisualEditor will be no longer round tripping with general HTML5 content [20:05:04] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24), 5WMF-deploy-2015-04-08_(1.25wmf25): [Regression wmf24] Hitting return deletes the text even after deselecting it - https://phabricator.wikimedia.org/T94931#1187306 (10Ryasmeen) Verified the fix [20:05:12] cscott: ™ for future copy-and-paste. ;-) [20:05:18] it woudl assume that comments are escape fully [20:05:49] Krinkle: you already convert the comments to nodes for cut-and-paste, shouldn't affect that. [20:05:50] again, integrity of the DOM is more important in the immediate future, but the story doesn't end there. [20:06:18] there is a "true value" of the comment, which is what the user entered. that true value already gets serialized/deserialized to nodes correctly for cut-and-paste. [20:06:32] cscott: how do we differentiate between Parsoid DOM comments that need decoding and non-Parsoid HTML that should not be (fully) decoded. [20:06:37] once the parsoid and VE patches land, that true value will also get serialized/deserialized safely as comment nodes. [20:06:57] Krinkle: you will never see non-Parsoid comment nodes. [20:07:01] right? [20:07:09] copy paste? [20:07:09] that's why you have to use for cut-and-paste in the first place. [20:07:13] and VisualEditor standalone [20:07:53] as I wrote for Roan -- it is best to use a safe mechanism for the generic VE. If a standalone editor wants to use a different convention for encoding HTML comments, they can create a CommentNode subclass. [20:08:14] they'll have to come up with some convention, though, since otherwise there is no way to encode arbitrary data in an HTML comment. [20:09:05] 10MediaWiki-Page-editing: Category and image description pages not purged from file cache or squid cache on link update - https://phabricator.wikimedia.org/T26575#1187315 (10Bawolff) [20:09:12] entity escapes is the logical thing to do for HTML. We are very conservative in what we escape. And the standard HTML parsing rules will save us in almost all cases if we encounter an orphan & in the wild. [20:10:08] if you've got the ear of whatwg, i'd even suggest writing this into the DOM spec as a standard convention. It would just require adding a 'text' accessor to CommentNode. [20:10:12] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Be able to convert DOM->data differently for paste data vs initial conversion - https://phabricator.wikimedia.org/T94724#1187320 (10Jdforrester-WMF) [20:10:14] 10VisualEditor, 10VisualEditor-ContentEditable: VisualEditor: Pasting content into a VE-MW surface should down-convert s to s (and s to s) - https://phabricator.wikimedia.org/T70928#1187319 (10Jdforrester-WMF) [20:10:22] 10VisualEditor, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: When the user pastes in an , we should probably convert it to an ? - https://phabricator.wikimedia.org/T85377#1187321 (10Jdforrester-WMF) [20:11:36] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Pasting content into a VE-MW surface should down-convert s to s (and s to s) - https://phabricator.wikimedia.org/T70928#1187330 (10Jdforrester-WMF) a:3Esa... [20:11:42] and then document.createComment() should probably be deprecated in favor of some safer constructor. [20:11:48] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 3Editing Department 2014/15 Q4 blockers: VisualEditor: Pasting content into a VE-MW surface should down-convert s to s (and s to s) - https://phabricator.wikimedia.org/T70928#740208 (10Jdforrester-WMF) [20:11:56] but that's a harder road to hoe [20:11:57] 10VisualEditor, 10VisualEditor-CopyPaste: When the user pastes in an , we should probably convert it to an ? - https://phabricator.wikimedia.org/T85377#945297 (10Jdforrester-WMF) [20:14:31] (03PS1) 10Esanders: Add core tests for annotation merging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202519 [20:18:28] cscott: Yeah, good suggestions. I'll see what I can do. [20:18:38] I've got a few ears over there, though tied hands usually. [20:19:18] (03CR) 10Manybubbles: "It looks like Cirrus breaks this feature by removing all the tags from the text. I imagine this is a side effect of HTML clearing." [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:19:22] Hallo. [20:19:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor on Mobile web doesn't detect wikitext insertion - https://phabricator.wikimedia.org/T95335#1187348 (10gpaumier) [20:19:52] Did anybody consider what should red links be doing when VE is available? [20:20:06] Clicking a red link today leads to the source editor. [20:21:09] (03CR) 10Manybubbles: "For the record I haven't run it without Cirrus but I assume it works there well. I think the right thing to do is make this a feature fla" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:22:40] (03CR) 10Krinkle: Encode and decode HTML entities in comment nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202311 (https://phabricator.wikimedia.org/T95040) (owner: 10Cscott) [20:24:15] (03CR) 10Physikerwelt: "That's strange. For me it worked with cirrus search as well." [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:24:45] Krinkle, RoanKattouw_away: woot, i've gained +2 on the review. But it came as two -1 -> 0 transitions. ;) [20:26:46] (03CR) 10Manybubbles: "Oh! Its because I was doing a text search instead of insource: search. With insource: it works! Cool! OK. Let me rethink my response " [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:29:01] (03CR) 10Jforrester: [C: 032] "Code coverage for CE before is 63.51% and after is 63.75%." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202519 (owner: 10Esanders) [20:30:09] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#1187412 (10Whatamidoing-WMF) A few images to add to this problem (images show Russian): - save... [20:32:17] 10VisualEditor, 7Design: clicking a red link should (optionally) lead to the VisualEditor - https://phabricator.wikimedia.org/T95342#1187413 (10Amire80) 3NEW [20:32:31] 10VisualEditor, 7Design: clicking a red link should (optionally) lead to the VisualEditor - https://phabricator.wikimedia.org/T95342#1187423 (10Amire80) This may well be a dupe, but I couldn't find anything relevant with Phabricator's search ;) [20:36:09] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1187432 (10gpaumier) 2015-04-07: * [[ https://en.wikipedia.org/w/index.php?oldid=655382562#Tue_Apr_07_2015_10:39:07_GMT-0700_.28P... [20:36:55] (03CR) 10Manybubbles: [C: 031] "OK. I'm +1 after some trying. I wonder if we're going to see a little bump in load during the render but that'll probably be fine." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:37:27] 10VisualEditor, 10WMF-Product-Strategy, 3Editing Department 2014/15 Q4 blockers: Perform a weekly review of edits made with VisualEditor - https://phabricator.wikimedia.org/T94767#1187436 (10gpaumier) [20:37:50] (03Merged) 10jenkins-bot: Add core tests for annotation merging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202519 (owner: 10Esanders) [20:40:19] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Heading of template editor is centered; hence most text currently covered by "Apply changes" button in some languages - https://phabricator.wikimedia.org/T76947#1187461 (10matmarex) >>! In T76947#1187412, @Whatamidoing-WMF wrote: > A few images to add to this... [20:40:25] (03PS4) 10Cscott: Introduce oo.ui.mixin namespace for mixins, and put them src/mixins [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 [20:41:48] (03CR) 10Cscott: "Ok, this should be good to go now." [oojs/ui] - 10https://gerrit.wikimedia.org/r/200195 (owner: 10Cscott) [20:48:23] 10MediaWiki-Page-editing: Category and image description pages not purged from file cache or squid cache on link update - https://phabricator.wikimedia.org/T26575#1187487 (10Kulmanseidl) Is anybody aware of a workaround for this? Not even purging pages seems to help. Only fully clearing the cache (through whatev... [20:50:05] MatmaRex, are you aware of how broken dialogs are on mobile? [20:50:29] no [20:53:41] MatmaRex, I'm not sure it's an OOUI thing, but try typing {{ at http://en.m.wikipedia.beta.wmflabs.org/wiki/0.8251019806486972#/editor/0 [20:53:47] in chrome it flashes a lot while opening the dialog [20:53:55] then everything gets rendered weirdly [20:54:55] Krenair: well, you're not supposed to be able to open dialogs there. so that might be why. [20:55:26] same problem with inspectors [20:55:40] e.g. citations or links [20:55:40] link inspector is mostly sane [20:55:56] and i see no way to insert a citation [20:56:07] aharoni: There is a task somewhere complaining about the fact that redlinks should go to VE on wikis where VE is the default [20:56:43] RoanKattouw: What do you mean by "VE is default"? Not beta? [20:56:54] Yeah [20:57:07] It's a boldish assumption :) [20:59:09] cscott: OK that comment change just needs unit tests and then it's good to go [20:59:14] cscott: I can add those if you're busy [20:59:22] RoanKattouw: if you could, i'd appreciate it [20:59:41] i'm going through all my older patches today, trying to give them all a bump [21:00:19] eg https://gerrit.wikimedia.org/r/200195 in ooui land, but i think that's TrevorParscal's [21:00:44] (and i've got a robla meeting right now, so i wouldn't get to it until tomorrow in any case) [21:02:10] 10VisualEditor, 7Design: clicking a red link should (optionally) lead to the VisualEditor - https://phabricator.wikimedia.org/T95342#1187540 (10matmarex) [21:06:25] OK I'll do it [21:09:29] (03CR) 10Trevor Parscal: [C: 032] Set default size to category popup widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201621 (owner: 10Mooeypoo) [21:14:07] (03CR) 10Trevor Parscal: [C: 04-1] Close inspectors when dialog opens (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201632 (https://phabricator.wikimedia.org/T93638) (owner: 10Mooeypoo) [21:18:15] (03Merged) 10jenkins-bot: Set default size to category popup widgets [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201621 (owner: 10Mooeypoo) [21:24:13] 10OOjs-UI, 10UI-Standardization, 7Design: Update wikifont set with new icons - https://phabricator.wikimedia.org/T94461#1187624 (10violetto) @trevorparscal / @matmarex I'm looking to update icons in the set and was wondering what method did you guys use to compress the svg file so I can do the same on my side? [21:29:45] oh, MatmaRex went [21:31:28] (03PS3) 10Catrope: Encode and decode HTML entities in comment nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202311 (https://phabricator.wikimedia.org/T95040) (owner: 10Cscott) [21:31:47] (03CR) 10Catrope: [C: 032] Encode and decode HTML entities in comment nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202311 (https://phabricator.wikimedia.org/T95040) (owner: 10Cscott) [21:32:25] RoanKattouw: nice tests, thanks. [21:33:22] out of curiosity, what does `normalizedBody` do? [21:33:59] cscott: Sometimes, convert(convert(body)) !== body [21:34:19] linmod2html(html2linmod(body)) !== body I mean [21:34:28] normalizedBody covers those cases [21:34:31] They're supposed to be rare [21:34:41] In this case we have them because your code doesn't preserve the type of escaping that was used [21:35:02] Any normalizedBody test case is a bit of a red flag because it's a dirty diff, but in some cases it's acceptable [21:35:04] I think this one is fine [21:35:05] (03Merged) 10jenkins-bot: Encode and decode HTML entities in comment nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202311 (https://phabricator.wikimedia.org/T95040) (owner: 10Cscott) [21:35:33] in this case parsoid will ensure that the wikitext isn't dirty diff'ed [21:36:01] (03PS2) 10Trevor Parscal: Flip popup alignment in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [21:36:07] that is, parsoid doesn't care what html escapes you use in the DOM representation, they result in the same wikitext [21:36:09] Good [21:36:15] Does selser also know that? [21:36:23] yep [21:36:25] Cool [21:37:14] there's a bit of an essay in https://gerrit.wikimedia.org/r/#/c/202058/12/lib/mediawiki.DOMUtils.js [21:38:43] and we use decodedCommentLength in selser, which decodes the entities (and stuff) before taking the length. [21:39:38] RoanKattouw: what's your deploy schedule, now that 202311 is merged? [21:40:10] is the parsoid change ok to go out in our wednesday deploy window? [21:42:19] (03PS1) 10Mooeypoo: Followup Iaf15561409b: Correctly position popups in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/202599 [21:42:46] cscott: The normal schedule would be that that change goes to group0 on Wednesday, group1 on Tuesday (7 days from now) and group2 next Wednesday (8 days from now) [21:42:58] cscott: But if you want, we can accelerate it and deploy to all of them at 4pm PDT today [21:52:11] (03CR) 10Trevor Parscal: [C: 04-1] "Seems to not be inverting the left/right value." [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 (owner: 10Mooeypoo) [21:52:53] 10VisualEditor: If a GeneratedContentNode is destroyed before it finished parsing, its promise isn't aborted - https://phabricator.wikimedia.org/T95354#1187695 (10Mooeypoo) 3NEW [21:53:34] 10MediaWiki-Page-editing, 6MediaWiki-Core-Team, 7I18n, 5Patch-For-Review: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?) - https://phabricator.wikimedia.org/T85700#1187702 (10Umherirrender) 5Open>3Resolved The problem with new too long comments is solve... [21:59:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1187736 (10Krenair) So I tried VE on mobile using the latest MobileFrontend master with "Experimental" (alpha) enabled. It looks to me like it's still ge... [22:09:55] RoanKattouw_away: we'd like to do the parsoid deploy first. so the "normal schedule" for VE should be fine. [22:10:27] RoanKattouw_away: some users might see some anomalous html entities in their comments in the next 8 days, but it shouldn't cause any dirty diffs. [22:10:40] RoanKattouw_away: we can SWAT if users notice and complain. [22:11:09] (03CR) 10Physikerwelt: "> "I wonder if we're going to see a little bump in load during the render but that'll probably be fine."" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [22:13:34] (03CR) 10Physikerwelt: Render math tags in search results (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [22:25:25] 10VisualEditor: Spurious scrolling when creating links at the top of the screen in long articles - https://phabricator.wikimedia.org/T95360#1187818 (10AxelBoldt) 3NEW [22:32:20] 10VisualEditor, 6Analytics-Kanban: Schema:Edit seems to incorrectly set users as anonymous {lion} - https://phabricator.wikimedia.org/T92596#1187827 (10Milimetric) [22:32:44] (03CR) 10Manybubbles: "I'd adjust the commit message about how its best effort for finding the tags but otherwise its fine." [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [22:34:21] (03PS8) 10Mooeypoo: Create a preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [22:37:01] (03CR) 10jenkins-bot: [V: 04-1] Create a preview widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) (owner: 10Mooeypoo) [22:37:53] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Pop-up context menu shows redlinks in Citoid-created citation - https://phabricator.wikimedia.org/T95247#1187839 (10Mooeypoo) Can you tell me what input you put into citoid to get this? I think I know what may be happening, but for some reaso... [22:48:24] (03PS1) 10Mooeypoo: Use the new MWPreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 [22:48:58] (03CR) 10jenkins-bot: [V: 04-1] Use the new MWPreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 (owner: 10Mooeypoo) [22:52:36] (03CR) 10Alex Monk: "So the issue lies in the difference between getValue and getHref on MWLinkTargetInputWidget. getValue is updated before the change event i" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182432 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk) [22:54:20] (03Abandoned) 10Alex Monk: Link inspector: Set href of open button to new value, not old. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182432 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk) [22:56:29] 10VisualEditor: Popup for newly added cite-by-url citation doesn't show full citation - https://phabricator.wikimedia.org/T95363#1187872 (10Ragesoss) 3NEW [22:57:21] (03CR) 10Alex Monk: "So it's fine when you're only updating the input by selecting items, but typing in the box will cause the stored href to be updated too la" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/182432 (https://phabricator.wikimedia.org/T85619) (owner: 10Alex Monk) [22:59:22] (03PS2) 10Mooeypoo: Close inspectors when dialog opens [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201632 (https://phabricator.wikimedia.org/T93638) [23:03:14] cscott: OK sounds good to me [23:04:30] 10VisualEditor: Popups get disconnected from their targets when page zoom is changed - https://phabricator.wikimedia.org/T95366#1187915 (10Ragesoss) 3NEW [23:04:37] 10OOjs-UI, 10UI-Standardization, 7Design: Update wikifont set with new icons - https://phabricator.wikimedia.org/T94461#1187921 (10Prtksxna) >>! In T94461#1187624, @violetto wrote: > @trevorparscal / @matmarex I'm looking to update icons in the set and was wondering what method did you guys use to compress t... [23:07:27] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: VisualEditor on Mobile web doesn't detect wikitext insertion - https://phabricator.wikimedia.org/T95335#1187933 (10Catrope) Which browser were you using? Because T95248 claims this **does** work. [23:07:38] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 5Patch-For-Review: "Open" button in the Link tool can sometimes lead to a broken or incorrect target - https://phabricator.wikimedia.org/T85619#1187935 (10Krenair) a:5Krenair>3None After posting my comments about what I was tr... [23:11:31] (03PS4) 10Mooeypoo: Allow for citation tools to work under the reference dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/202465 (https://phabricator.wikimedia.org/T94621) [23:11:39] 10Citoid, 10VisualEditor: Popup for newly added cite-by-url citation doesn't show full citation - https://phabricator.wikimedia.org/T95363#1187946 (10Ragesoss) [23:13:12] I'm late to the party, perhaps, but... congrats on shipping Citoid! [23:13:35] \o/ thanks ragesoss [23:13:47] James_F et al: why did you decide to go back to the icon instead of "Cite"? [23:14:23] 10OOjs-UI, 10UI-Standardization, 7Design: Update wikifont set with new icons - https://phabricator.wikimedia.org/T94461#1187953 (10violetto) Okay when do you think it will be ready? [23:25:09] 10VisualEditor, 10VisualEditor-ContentEditable: VE does not break a line before text expanded from a template - https://phabricator.wikimedia.org/T95368#1187961 (10AxelBoldt) 3NEW [23:25:46] (03PS1) 10Mooeypoo: Change html dir property when direction change in demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/202616 [23:28:11] (03PS2) 10Catrope: Change html dir property when direction changes in demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/202616 (owner: 10Mooeypoo) [23:30:18] (03CR) 10Catrope: [C: 032] Change html dir property when direction changes in demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/202616 (owner: 10Mooeypoo) [23:38:01] (03Merged) 10jenkins-bot: Change html dir property when direction changes in demo [oojs/ui] - 10https://gerrit.wikimedia.org/r/202616 (owner: 10Mooeypoo) [23:42:14] (03PS3) 10Mooeypoo: Flip popup alignment in RTL [oojs/ui] - 10https://gerrit.wikimedia.org/r/201617 [23:43:08] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web: Inspector titles clipped in VisualEditor on mobile - https://phabricator.wikimedia.org/T85068#1188024 (10Jdlrobson) I'm waiting for a reply here: https://phabricator.wikimedia.org/T86366#1136772 [23:43:33] 10VisualEditor, 10VisualEditor-DataModel, 10Parsoid, 3Editing Department 2014/15 Q4 blockers, and 2 others: Links aren't merged aggressively enough - https://phabricator.wikimedia.org/T95028#1188027 (10Etonkovidova) Checked the fix in beta. [23:48:40] 5OOjs-UI-0.9.5, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.25wmf25): [Regression wmf24]: Firefox: the computed font size is too small for 'Insert template' text-area boxes - https://phabricator.wikimedia.org/T94450#1188062 (10Etonkovidova) Verified the fix in beta. [23:57:03] (03PS1) 10Catrope: Skip ignoreChildren nodes in getAnnotatedRangeFromSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/202624 (https://phabricator.wikimedia.org/T95246)