[00:00:25] (03CR) 10Catrope: [C: 04-1] [wip] Find first focusable element in booklet and add focusable utility (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 (owner: 10Mooeypoo) [00:04:45] (03CR) 10Mooeypoo: [wip] Find first focusable element in booklet and add focusable utility (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 (owner: 10Mooeypoo) [00:07:27] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1208489 (10Jdforrester-WMF) p:5Triage>3High a:3Krenair [00:07:40] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: action.abort.type in Shema:Edit not populated for Wikitext - https://phabricator.wikimedia.org/T95938#1208492 (10Jdforrester-WMF) p:5Triage>3Normal [00:16:08] James_F: Did you remove the "blockers" tag on https://phabricator.wikimedia.org/T68628 because it was rejected as a blocker, or was it as part of the revert to the previously described task? [00:17:59] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: action.abort.type in Schema:Edit not populated for Wikitext - https://phabricator.wikimedia.org/T95938#1208499 (10Catrope) [00:18:12] guillom: Both. It was rejected as a blocker in the weekly triage, and I reverted to the previous task for sanity. [00:18:29] James_F: Thanks; that way I know not to re-nominate it :) [00:19:13] (03CR) 10Krinkle: [wip] Find first focusable element in booklet and add focusable utility (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 (owner: 10Mooeypoo) [00:19:19] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1208501 (10Catrope) >>! In T95919#1205423, @Halfak wrote: > I just ran some tests and I was able to reproduce this issue on enwiki. > > Steps to reproduce... [00:19:26] guillom: If you have a good argument we missed feel free. :-) [00:19:48] (03PS6) 10Krinkle: Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [00:20:04] James_F: My only argument is "This is one of the few issues I keep seeing in my weekly reviews" :) [00:20:10] * James_F nods. [00:20:26] Krinkle, uhm, oops, I thought 'return' statements inside .each() break the loop? IF not, then how do I break it? [00:20:43] guillom: What do you keep seeing? at the start of a line? [00:20:51] RoanKattouw: yes [00:20:59] Looks like a common mistake [00:21:02] mooeypoo: I think return false; in an each callback breaks it [00:21:10] guillom: That's really weird though because we have code stripping those spaces [00:21:21] And I haven't been able to reproduce [00:21:34] Me either [00:21:43] I just keep finding diffs with them :) [00:21:45] Best I can tell this logic is working, except clearly it isn't because we see these nowikied spaces in diffs [00:22:23] mooeypoo: But there's a difference between return; and return false; [00:22:30] (the former is equivalent to return undefined; ) [00:22:34] RoanKattouw, yes, I'm reading the docs, you're right [00:22:38] seems 'return false' should do it [00:24:55] (03CR) 10Mooeypoo: [wip] Find first focusable element in booklet and add focusable utility (032 comments) [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 (owner: 10Mooeypoo) [00:25:26] (03PS3) 10Mooeypoo: [wip] Find first focusable element in booklet and add focusable utility [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 [00:25:33] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1208503 (10Halfak) Sorry. Good question. I am using Google Chrome 41.0.2272.118 (64-bit) on Ubuntu 14.04. [00:26:29] Krinkle: Were you thinking to merge https://gerrit.wikimedia.org/r/#/c/201583/ ? [00:26:56] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1208506 (10Catrope) Hmm so even Chrome retains hidden form field data on back? That actually surprises me a bit. I was expecting this to be a Firefox issue b... [00:29:02] (03CR) 10Krinkle: Trim leading and trailing whitespace from annotations (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [00:31:02] (03CR) 10Catrope: Trim leading and trailing whitespace from annotations (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [00:32:51] James_F: When I saw the commit message in the dashbaord yes. [00:33:04] But when I saw the code complexity, I'm not sure I should in the middle of the night. [00:34:12] RoanKattouw: Could you refer or write a quick step to reproduce the behaviour that commit changes? I was able to produce trailing whitespace by adding spaces to a bolded paragraph and then adding a letter and unbolding that. Producing

sdsdf    x

. On latest master. [00:34:16] goodnight [00:36:21] Krinkle|detached: Bah. [00:40:52] (03PS1) 10Mooeypoo: [wip] Focus on the first focusable element in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 [00:40:58] (03CR) 10jenkins-bot: [V: 04-1] [wip] Focus on the first focusable element in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 (owner: 10Mooeypoo) [00:41:56] Krinkle|detached: It has unit tests you know :P but here's how you reproduce: [00:42:03] Krinkle|detached: Actually I'll add it to the Gerrit change [00:42:37] (03PS2) 10Mooeypoo: [wip] Focus on the first focusable element in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 [00:42:41] (03CR) 10Krinkle: [wip] Find first focusable element in booklet and add focusable utility (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 (owner: 10Mooeypoo) [00:44:19] (03CR) 10Mooeypoo: [wip] Find first focusable element in booklet and add focusable utility (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 (owner: 10Mooeypoo) [00:44:35] (03CR) 10Catrope: "Reproduction steps:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [00:44:43] (03CR) 10Krinkle: [wip] Find first focusable element in booklet and add focusable utility (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 (owner: 10Mooeypoo) [00:49:28] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203990 (owner: 10Mattflaschen) [00:52:32] (03Merged) 10jenkins-bot: Remove obsolete comment; this functionality is now in place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203990 (owner: 10Mattflaschen) [00:53:41] (03PS4) 10Mooeypoo: [wip] Find first focusable element in booklet and add focusable utility [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 [01:02:35] 10VisualEditor, 6Analytics-Kanban: Schema:Edit seems to incorrectly set users as anonymous {lion} - https://phabricator.wikimedia.org/T92596#1208537 (10Krenair) a:5Krenair>3None [01:03:57] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1208539 (10Krenair) When I tried this yesterday in Chrome, I would get a new session when I went back. [01:07:35] (03CR) 10Catrope: [C: 031] "I wrote most of this code so I can't merge this. Timo?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [01:10:40] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1208541 (10Krenair) Though it seems to be retaining the session now. I wonder what's different. [01:11:01] RoanKattouw, either way I'm not sure what we can do about this [01:14:35] (03PS7) 10Catrope: Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) [01:15:55] (03CR) 10Catrope: [C: 04-1] "Needs rebase because this has allowed to rot for two weeks? :(" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200575 (owner: 10Esanders) [01:17:06] (03PS3) 10Catrope: ve.ui.Toolbar: Allow setting positioning offset from the top of the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203010 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [01:17:13] (03CR) 10Catrope: [C: 032] ve.ui.Toolbar: Allow setting positioning offset from the top of the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203010 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [01:22:31] (03Merged) 10jenkins-bot: ve.ui.Toolbar: Allow setting positioning offset from the top of the window [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/203010 (https://phabricator.wikimedia.org/T95528) (owner: 10Florianschmidtwelzow) [01:32:02] (03CR) 10Catrope: [C: 04-1] Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 (owner: 10Krinkle) [05:20:26] (03PS4) 10Florianschmidtwelzow: Allow skin developers to set an offset for toolbar floating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203011 (https://phabricator.wikimedia.org/T95528) [06:24:35] 10VisualEditor, 10Parsoid, 3Editing Department 2014/15 Q4 blockers: nowiki added around the opening {{ of an existing template - https://phabricator.wikimedia.org/T96090#1208727 (10TheDJ) [06:33:48] 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari, 5WMF-deploy-2015-04-01_(1.25wmf24), and 2 others: Insufficient span tags stripping from copy-and-paste in Safari - https://phabricator.wikimedia.org/T71494#1208734 (10NicoV) Other example of problems still occurring, this time with sp... [06:45:23] 10VisualEditor: One user often can't create new articles in VisualEditor while logged in - https://phabricator.wikimedia.org/T96115#1208740 (10Whatamidoing-WMF) 3NEW [06:46:34] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: tags added around closing bracket of an external link - https://phabricator.wikimedia.org/T96064#1208747 (10NicoV) Other examples https://fr.wikipedia.org/w/index.php?title=%C5%92uf_%28cuisine%29&diff=113846801&oldid=113846663 https://fr.wikipedia... [06:51:28] 10VisualEditor: Make adding sortkeys for DEFAULTSORT easier - https://phabricator.wikimedia.org/T96116#1208748 (10Whatamidoing-WMF) 3NEW [06:55:29] 10MediaWiki-Page-editing, 6Availability-Team, 10Wikidata, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1208762 (10aaron) So is this resolved? [06:58:19] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1208764 (10Whatamidoing-WMF) 3NEW [07:01:34] 10Citoid, 10VisualEditor: Change the label that says "Or use the full citation dialog to fill in the details yourself" - https://phabricator.wikimedia.org/T96119#1208772 (10Whatamidoing-WMF) 3NEW [07:13:05] 10Citoid, 10VisualEditor: "Undo" only undoes Citoid's addition of content, not the whole ref (aka Citoid inserts empty tags) - https://phabricator.wikimedia.org/T96120#1208780 (10Whatamidoing-WMF) 3NEW [07:16:50] 10Citoid, 10VisualEditor, 10VisualEditor-ContentEditable: Put Citoid in the regular Cite menu anyway - https://phabricator.wikimedia.org/T96118#1208797 (10Mvolz) [07:18:09] 10Citoid, 10VisualEditor: Change the label that says "Or use the full citation dialog to fill in the details yourself" - https://phabricator.wikimedia.org/T96119#1208799 (10Mvolz) [07:18:54] 10Citoid, 10VisualEditor: "Undo" only undoes Citoid's addition of content, not the whole ref (aka Citoid inserts empty tags) - https://phabricator.wikimedia.org/T96120#1208801 (10Mvolz) [07:47:46] 10MediaWiki-Page-editing, 6Availability-Team, 10Wikidata, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1208831 (10aude) I think this is fixed now. Don't see it in the logs. [07:47:56] 10MediaWiki-Page-editing, 6Availability-Team, 10Wikidata, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1208832 (10aude) 5Open>3Resolved [12:44:21] 10Cite: Extension Cite messed up my indentation - https://phabricator.wikimedia.org/T95386#1209070 (10Gadget850) When I copy this to the English Wikipedia (1.25wmf24), this does not occur. The ordered lists end and restart at the headings. On Halachipedia (1.24.2), the second heading Obligation and subsequent h... [12:47:50] 10Cite: make displaying reference group names optional - https://phabricator.wikimedia.org/T94410#1209074 (10Gadget850) On the English Wikipedia, I would use {{efn}}/{{notelist}} or a variant for this type of use. [13:55:25] 10VisualEditor: VisualEditor: Paste from Word to MSIE fails to insert anything - https://phabricator.wikimedia.org/T75293#1209203 (10MarkAHershberger) 5Open>3Resolved a:3MarkAHershberger Closing this for now since it has been solved elsewhere. At least *some* pasting works. [14:16:36] (03CR) 10Jforrester: [C: 031] Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [14:18:07] (03PS4) 10Jforrester: TableContent: Use plural message to delete multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [14:18:19] (03CR) 10Jforrester: [C: 032] TableContent: Use plural message to delete multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [14:18:48] 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): "Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multiple rows/columns) - https://phabricator.wikimedia.org/T87234#1209249... [14:18:55] 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): "Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multiple rows/columns) - https://phabricator.wikimedia.org/T87234#986652 (... [14:22:48] (03CR) 10Esanders: [C: 04-2] TableContent: Use plural message to delete multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [14:23:13] (03CR) 10Esanders: "Patch incoming to better support this." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [14:24:30] (03PS1) 10Esanders: Rename Context to LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204267 [14:24:32] (03PS1) 10Esanders: Split generic functionality out of LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204268 [14:24:34] (03PS1) 10Esanders: Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 [14:25:49] (03CR) 10Hcohl: "Added some clarifications of Moritz's comments." (0310 comments) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/203954 (owner: 10Sharmaans) [14:25:51] edsanders: Really? You do nothing for two weeks until I press +2, then arrive with code? ;-) [14:26:02] good timing [14:26:21] Uh-huh. [14:26:31] (03CR) 10Esanders: "If we rebase on I3b9804b00 then we can override the getTitle method for the Delete(Column|Row)ContextItem" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [14:26:36] (03CR) 10jenkins-bot: [V: 04-1] Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 (owner: 10Esanders) [14:26:40] 10VisualEditor, 10VisualEditor-Tables, 3Editing Department 2014/15 Q4 blockers: "Delete row"/"Delete column" messages do not use the plural when multiple rows/columns are selected (but they do delete multiple rows/columns) - https://phabricator.wikimedia.org/T87234#1209266 (10Jdforrester-WMF) 5Resolved>3O... [14:27:14] (03CR) 10jenkins-bot: [V: 04-1] Rename Context to LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204267 (owner: 10Esanders) [14:33:06] (03PS1) 10Esanders: Add get(Col|Row)Count to TableSelection and use in isFull* [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204271 [14:33:49] (03PS1) 10Jforrester: Update VE core submodule to master (077c741) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204272 [14:33:57] edsanders: Could I grab a +2 on that? [14:35:10] James_F: could I get your input on https://phabricator.wikimedia.org/T95945 ?? [14:35:51] hexmode: I have none. DM stuff is dark magic. [14:36:01] heh [14:36:32] James_F: so... could you recommend a dark magic specialist who might know? edsanders?/ [14:36:51] Yes. [14:37:02] you'll need to cross my palm with silver [14:37:22] * hexmode transmutes the air above edsanders palm [14:37:59] I assume exception is thrown by the sanitizer? [14:38:14] what is the linear model data before? [14:38:44] I don't know how to answer your question. What should I look for? [14:42:22] edsanders: The exception is just thrown when ve.copy( element ) returns undef and then clone.internal tries to access the property on an undef value [14:44:40] look through the stack trace [14:46:49] (03PS2) 10Esanders: Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 [14:46:51] (03PS2) 10Esanders: Refactor ve.ui.Context to create ve.ui.LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204268 [14:47:28] (03Abandoned) 10Esanders: Rename Context to LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204267 (owner: 10Esanders) [14:49:19] (03PS3) 10Esanders: Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 [14:51:30] (03CR) 10jenkins-bot: [V: 04-1] Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 (owner: 10Esanders) [14:58:07] so the font tag gets wrapped in a paragraph [14:58:31] hexmode, so your html is essentially

  • Foo

[14:58:54] and the converter doesn't like that [14:59:00] k [14:59:01] or rather fixUpInsertion doesn't like it [15:00:10] (sorry, got distracted while waiting for page to reload so I could give you a backtrace) [15:00:36] minimal failing case is:
    A
  • B
[15:01:22] heh... I was happy to get it that far. Thought about that... [15:01:42] where is this HTML coming from? [15:01:54] It is from an outlook message [15:02:07] I can dig it up if you want [15:02:17] may have to sanitize, but probably not [15:03:55] well it's invalid HTML [15:04:10] yep [15:04:13] but we should be able to have the converter recognise that

is not allowed inside

    [15:05:34] it looks like the converter is not checking childNodeTypes of the parent (list has childNodeTypes of 'listItem' only), I blame RoanKattouw_away [15:05:57] always blame the guy who isn't here ;) [15:08:41] 10VisualEditor, 10VisualEditor-CopyPaste: ve.dm.Node.static.cloneElement can be called w/o a ve.clone-able element in IE or FF - https://phabricator.wikimedia.org/T95945#1209377 (10Esanders) The root of the problem is that we convert

      Foo

    to [ list, paragraph, F, o, o, /paragraph, /list ] which... [15:10:56] 10VisualEditor, 10VisualEditor-CopyPaste: Converter lets you put a paragraph directly in a list, which shouldn't be allowed and breaks fixUpInsertion - https://phabricator.wikimedia.org/T95945#1209378 (10Esanders) [15:11:14] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel: Converter lets you put a paragraph directly in a list, which shouldn't be allowed and breaks fixUpInsertion - https://phabricator.wikimedia.org/T95945#1204415 (10Esanders) [15:31:28] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: Converter lets you put a paragraph directly in a list, which shouldn't be allowed and breaks fixUpInsertion - https://phabricator.wikimedia.org/T95945#1209436 (10Jdforrester-WMF) p:5Triage>3Normal [15:46:06] James_F: Hm.. ran into a weird bug when testing Roan's whitespace change. Given a paragraph of bolded text (3 words), add some spaces to the end, then a letter. Unbold the letter. Move cursor to into the (for now) bolded spaces, hit enter. Type. This text is bold. Now move the cursor out of the paragraph elsewhere. Boom! The entire paragraph is now unbolded! [15:46:14] Both on master and after his change [15:46:41] Krinkle: … yes? [15:46:59] Krinkle: This is the epic annotations re-working thing that David's been doing (on and off) for six months. [15:46:59] Text that is in the editor bold changes by itself [15:47:13] OK [15:47:15] Actually, it gets re-rendered to be correct. [15:47:23] It's been the subject of a lot of angst. [15:47:25] Right. Our reflection is incorrect. [15:47:28] Didn't realise it hadn't reached you. [15:47:50] The browser sets it to be the wrong style in CE, and we very rarely over-write the CE to be correct. [15:47:52] Yeah, it hadn't. Not this way anyway. [15:48:29] So the browser incorrectly reflects the DM, and we've not come up with a way to stop it yet without breaking IMEs. [15:48:35] Browser does it wrong? What do you mean. If you split a paragraph in the middle of a bold sequence, surly there's no reason the new paragraph would now be unbold. [15:48:56] From the user perspective, it looks right until we re-render. [15:49:19] It looks right because the user has been misled. The text isn't bold in the DM (it never was), generally. [15:49:20] angst is an English word? [15:49:25] It's Dutch for fear. Interesting. [15:49:47] Yeah, in English it means anxiety/upset without focus. [15:50:00] Interesting. [15:50:02] So fear of a general kind rather than targeted on something specific. [15:50:05] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: Converter lets you put a paragraph directly in a list, which shouldn't be allowed and breaks fixUpInsertion - https://phabricator.wikimedia.org/T95945#1209483 (10MarkAHershberger) The content I got... [15:50:16] It does sound like *anx*iety [15:50:25] Yup. [15:50:47] Same root. [16:18:18] (03PS6) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 [16:23:57] 10VisualEditor, 10VisualEditor-EditingTools, 6Collaboration-Team, 6Mobile-Web, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1209584 (10Jdlrobson) 3NEW [16:24:01] 10VisualEditor, 10VisualEditor-EditingTools, 6Collaboration-Team, 6Mobile-Web, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1209593 (10Jdlrobson) [16:24:32] (03CR) 10Esanders: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 (owner: 10Krinkle) [16:27:08] 10MediaWiki-ResourceLoader, 10MediaWiki-Database, 7Performance: MessageBlobStore::clear queries take 40+ seconds - https://phabricator.wikimedia.org/T89550#1209606 (10Aklapper) 5Open>3stalled p:5Normal>3Lowest [16:27:55] (03PS7) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 [16:27:58] (03CR) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 (owner: 10Krinkle) [16:29:25] (03PS4) 10Esanders: Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 [16:34:42] Good morning, VE people. I have a question for you. Would it not be wonderful to port HTMLForm to OOUI? Well, I want to do that in the next three days. Who's in? [16:35:06] Mostly I'm just a little hesitant to commit to doing it before I know I have support... [16:35:41] (03PS1) 10Esanders: Rename config to toolbarConfig in sa.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204292 [16:36:20] 10VisualEditor, 10VisualEditor-EditingTools, 6Collaboration-Team, 6Mobile-Web, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1209648 (10Krinkle) Cookies should only be used for things that the server needs to read when handling an HTTP request. Anything... [16:37:29] (03PS1) 10Esanders: Simplify OO.ui.SelectWidget#getTargetItem [oojs/ui] - 10https://gerrit.wikimedia.org/r/204293 [16:37:50] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1209651 (10csteipp) >>! In T95229#1207763, @GWicke wrote: >> Graphoid is 530 kloc's of javascript. > > If the codebase is too large to review, then why don't w... [16:40:08] James_F, should I fix the table plural commit or do you want the student to do it? [16:40:20] edsanders: Could you? It'd be faster. [16:40:24] k [16:40:43] (03CR) 10Jforrester: [C: 031] Rename config to toolbarConfig in sa.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204292 (owner: 10Esanders) [16:41:41] 10Cite: Extension Cite makes headers become part of ordered lists and indented - https://phabricator.wikimedia.org/T95386#1209654 (10Aklapper) [16:43:59] I see matmarex filed https://phabricator.wikimedia.org/T85291 for it [16:48:24] (03PS5) 10Esanders: TableContent: Use plural message to delete multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [16:48:24] (03PS5) 10Esanders: Rewrite the table context as an actual ve.ui.Context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204269 [16:48:24] (03PS3) 10Esanders: Refactor ve.ui.Context to create ve.ui.LinearContext [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204268 [16:48:26] (03CR) 10Jforrester: [C: 031] TableContent: Use plural message to delete multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [16:48:39] (03PS6) 10Esanders: Use plural grammar in table context for deleting multiple rows/columns [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/198738 (https://phabricator.wikimedia.org/T87234) (owner: 10Pratikbsp) [16:49:47] James_F, so the only problem with making the TableContext a Context is that it's no longer a SelectWidget [16:50:31] so the context items are now full width frameless buttons [16:50:53] (repurposing the 'edit' buttons of a regular context item) [16:51:08] edsanders: Ah. Full width? [16:51:21] well full width of the context [16:51:45] Which is already width-limited? [16:51:48] 150px [16:52:14] px? not ems? Ew. [16:53:29] PopupWidget [16:53:53] so in Apex, the context is now light blue text (the actions are progressive) with no hover styles [16:54:11] Yeah, that's not great. [16:54:18] Can we over-ride back to clear? [16:54:21] and in MW they are bold dark grey, hovering to blue [16:54:24] (Or is there a better way?) [16:55:11] The problem is the OOUI widgets which are visually suitable are not semantically suitable [16:56:18] one could question the suitability of using a ContextItem for each of these actions [16:56:40] we could have one contextItem, which contains a select widget with three options [16:56:52] but it depends in which direction we're going to take the table context [16:57:38] (03PS8) 10Krinkle: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 [16:58:49] (03CR) 10Krinkle: [C: 032] "Matching the already named parameter for Target base class." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204292 (owner: 10Esanders) [16:59:00] (03CR) 10Mooeypoo: Create a preview widget for generated content nodes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204129 (owner: 10Mooeypoo) [16:59:13] (03CR) 10Esanders: [C: 032] Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 (owner: 10Krinkle) [16:59:20] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/204272/ [16:59:34] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (077c741) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204272 (owner: 10Jforrester) [16:59:37] (03PS3) 10Jforrester: [BREAKING CHANGE] Fix font sizes and padding in Surface and SurfaceWidget [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200575 (owner: 10Esanders) [16:59:48] (03CR) 10Jforrester: "PS3 is a rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/200575 (owner: 10Esanders) [17:01:22] (03Merged) 10jenkins-bot: Rename config to toolbarConfig in sa.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204292 (owner: 10Esanders) [17:01:27] 10Citoid: Accept and serve cookies - https://phabricator.wikimedia.org/T93877#1209726 (10Elitre) [[ https://en.wikipedia.org/wiki/Wikipedia:TWL/Citoid#/media/File:Wikipedia_sandbox_screenshot._Testing_citoid_1.png | Direct link here ]], [17:01:27] (03Merged) 10jenkins-bot: Fix broken ve.init.sa.Platform @example (ve.init.platform undefined) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204003 (owner: 10Krinkle) [17:04:51] (03Merged) 10jenkins-bot: Update VE core submodule to master (077c741) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204272 (owner: 10Jforrester) [17:05:51] (03CR) 10Krinkle: [C: 031] Trim leading and trailing whitespace from annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/201583 (https://phabricator.wikimedia.org/T54037) (owner: 10Catrope) [17:06:01] (03CR) 10Krinkle: [C: 04-1] Defer loading easy-deflate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [17:06:05] (03PS9) 10Krinkle: Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [17:06:31] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1209731 (10GWicke) @csteipp, it's not an either-or. If we have doubts about the XSS cleanliness of the output, then additional sanitization can help to further... [17:09:29] (03CR) 10Krinkle: "Will amend and test a bit more." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [17:11:43] RoanKattouw: I can't load VE on my localhost anymore after hte latest git-pull for mwext-VisualEditor [17:11:48] ( ! ) Fatal error: Maximum execution time of 10 seconds exceeded in /Users/krinkle/Development/mediawiki/core/includes/libs/JavaScriptMinifier.php on line 588 [17:11:59] For this payload: [17:11:59] http://alpha.wikipedia.krinkle.dev/w/load.php?debug=false&lang=en&modules=Base64.js%7Ceasy-deflate.core%2Cdeflate%7Cext.visualEditor.base%2Ccore%2Cdata%2Cexperimental%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlink%2Cmwmeta%2Cmwreference%2Cmwtransclusion%2CviewPageTarget%7Cext.visualEditor.core.desktop%7Cext.visualEditor.mwimage.core%7Ce [17:12:00] xt.visualEditor.mwreference.core%7Cext.visualEditor.mwtransclusion.core%7Cjquery.autoEllipsis%2CbyteLimit%7Cjquery.uls.data%7Cmediawiki.language.names%2CspecialCharacters%7Cmediawiki.skinning.content.parsoid%7Cmoment%2Coojs%2Coojs-ui%2Cpapaparse%2Crangefix%2Cunicodejs%7Coojs-ui.styles%7Coojs-ui.styles.icons-editing-core&skin=vector&version=20150415T170937Z&* [17:12:36] Not sure how to get out of this one. [17:12:39] (03CR) 10Catrope: Defer loading easy-deflate (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [17:12:51] Krenair: Revert core? [17:12:54] Bah. [17:12:57] Krinkle: Revert core? [17:13:00] (Sorry, Krenair.) [17:13:03] James_F: Revert what where in which core? [17:13:11] ^ exactly what I was wondering [17:13:38] Krinkle: Oh, you're saying the flaw was introduced in VE-MW not in MW-core? [17:13:44] We've added too much JavaScript between mwext-VE master of 2 days ago and now (including the ve submdule) [17:13:48] James_F: Yes. [17:14:03] Git bisect not helping? [17:14:17] It's about how long it takes to minify [17:14:24] We didn't add one thing. We [17:14:28] ve been adding stuff for a year [17:14:46] Make the modules smaller by splitting them up? [17:15:12] Apparently our size at this point in time is too much to minify in under 10 seconds on my MacBook 2.6Ghz that's doing barely anything else at the same time. [17:15:15] Also, 10 seconds?! [17:15:34] It runs a sight faster than that on my local machine. [17:16:43] Krinkle: With Ori's easy-deflate change, though, this problem should go away ,right? [17:17:03] Since Base64.js, easy-deflate.core and easy-deflate.deflate will be loaded separately [17:17:33] That'll fix it temporarily until we add more code :P [17:18:26] * James_F grins. [17:18:40] RoanKattouw: So you're saying, Timo should merge code unseen so he can test it? ;-) [17:18:50] haha [17:19:07] I'm saying that if he git review -d 's, then his wiki should work again [17:19:27] * James_F nods. [17:21:04] Krinkle: Are you trying to test https://gerrit.wikimedia.org/r/#/c/201583/ in VE-MW and have run into this issue? [17:21:11] James_F, Requests for SoS? [17:21:35] edsanders: Working with Analytics on stuff around A/B test; other than that, it's quiet. [17:21:41] k [17:22:16] ooui releases? [17:22:36] edsanders: One second. [17:23:44] edsanders: We probably won't do one this week; no code merged. [17:23:59] In OOjs UI, if I have an unframed buttonwidget and it's not vertically centered do I fix it with CSS or something else? [17:24:02] (And nothing urgent in the review queue.) [17:29:39] RoanKattouw: Maybe, but we should seriously reconsider how we minify code in RL. This doesn't scale [17:29:41] Per module maybe. [17:29:43] And re-use [17:29:47] Not for the entire request every time [17:30:24] Yes [17:30:25] 10VisualEditor: One user often can't create new articles in VisualEditor while logged in - https://phabricator.wikimedia.org/T96115#1209793 (10Aklapper) 5Open>3stalled How blank is the page? Entirely blank? Could the affected user open the [[ http://msdn.microsoft.com/en-us/library/ie/dn255006 | browser's co... [17:30:32] Wait don't we already do that? [17:30:36] I think it's cached per module [17:30:43] Do you have $wgMainCacheType = CACHE_DB; set? [17:31:27] $wgMainCacheType = CACHE_ANYTHING; [17:31:37] Which is DB I think [17:31:45] RoanKattouw: Where do we minify per module [17:31:53] That's the first I hear about that :-) [17:32:10] Maybe just in my imagination? [17:32:14] But I thought we did [17:32:24] Guest29384, can you give some more context? [17:32:56] RoanKattouw: At the every end of response in RL.php do we call filter(minify-js) [17:33:04] That is literally the only place in the entire code base where we minify js [17:33:15] With filter() that is [17:33:36] makeModuleResponse [17:33:39] Which takes multiple modules [17:33:55] Oh I thought that was in a loop [17:33:57] edsanders, ButtonWidget in toolbar with framed: false is vert. aligned to top instead of middle [17:34:23] RoanKattouw: So conceptually, you don't forsee any problems with doing it in a loop? [17:34:27] Maybe it's faster to parse/minify once [17:34:49] I don't foresee any conceptual problems [17:34:56] It should increase the minifier cache hit rate [17:34:58] Also, I'm seeing our progress bar go from 100% down to 70% pretty much every single time I use VE locally. [17:35:11] Yeah there's a bug filed about that that's assigned to edsanders [17:35:35] Guest29384, I don't think we've ever written the CSS to support that case [17:35:41] I ran out of power so my CPU was maybe on low-power mode [17:35:46] It's loading now. Barely [17:35:51] the problem is toolbars could span multiple rows [17:36:07] in that case should the frameless button be full height? [17:36:29] edsanders, I'll probably just go with framed again. It would be better for frameless to be full height [17:36:31] RoanKattouw: So I'm reviewing the deflate change atm [17:36:36] OK [17:37:08] RoanKattouw: I've +1'ed https://gerrit.wikimedia.org/r/#/c/201583/ but not really sure about the converter code. I can observe it, but not really my area. It's magic to me unless I spend more time on it. [17:37:08] Ed can probably review that better [17:38:21] Pretty much the entire converter passed me by. I havent' gotten around to familiarising myself with it. [17:38:53] edsanders: Do you have a phab task for that? [17:38:58] You're not the only one [17:41:28] (03PS2) 10Physikerwelt: Use namespaced \MediaWiki\Logger\LoggerFactory [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [17:42:54] (03CR) 10Krinkle: "On localhost with few extensions besides VisualEditor, this reduces the main payload from 370KB to 361KB, in favour of 1 extra 10.1KB http" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [17:44:09] (03PS3) 10Physikerwelt: Use namespaced \MediaWiki\Logger\LoggerFactory [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [17:44:19] (03PS10) 10Krinkle: Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [17:44:27] (03CR) 10Physikerwelt: [C: 031 V: 032] Use namespaced \MediaWiki\Logger\LoggerFactory [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [17:44:46] RoanKattouw: Hm.. interesting. we're aldo loading mediawiki.action.history.diff on-load [17:45:06] Yes [17:45:08] Separately [17:45:09] why does the Cite Web citation form have *access date* as a suggested field but it's empty by default? Can VE be made to autopopulate that with the current date? [17:45:10] grr [17:45:28] I've been meaning to clean up the history.diff mess but I keep forgetting [17:45:37] neilpquinn: Hey. :-) [17:45:39] Dependency of ext.visualEditor.mwcore. [17:45:50] RoanKattouw: we can probably defer that to when opening Save dialog? [17:45:51] mooeypoo: ---^^ (ragesoss's question) [17:46:01] and then another using() just in case it's slow before showing the diff. [17:46:03] ragesoss: She's not at her desk right this minute so you may have to wait for an answer [17:46:12] Guest29384, unlikely - if you could make one with screenshots that would be good [17:46:13] Krinkle: Seems sensible [17:46:13] RoanKattouw: :-) [17:46:14] (03CR) 10Krinkle: [C: 032] Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [17:46:20] yay [17:47:34] (03CR) 10jenkins-bot: [V: 04-1] Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [17:47:39] :( [17:48:14] edsanders: Probably should have also told you that I'm Negative24 but ZNC is hijacking that one atm :( [17:49:26] 10VisualEditor: Auto-populate current date in citation dialog "URL access date" field - https://phabricator.wikimedia.org/T96171#1209857 (10Capt_Swing) 3NEW [17:53:27] (03CR) 10Physikerwelt: "I had some problems with auto-completation in my IDE (I have no root rights so I can not run composer)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/204098 (owner: 10Legoktm) [17:55:56] MatmaRex: Oh hiiiii [17:56:07] …hi? [17:56:09] * MatmaRex hides [17:56:27] MatmaRex: So I was just saying, "Gosh, I'd love it if the OAuth pages were OOUI-ified" [17:56:35] Then I found out they're all HTMLForm. [17:56:47] Then I noticed you had filed a bug about adding OOUI support to HTMLForm. [17:56:59] Well, naturally I thought I'd ask if you wanted to do that with me [17:57:27] man, i really need to work on that at some point. [17:57:32] unless you want to do the job [17:57:43] in which case go right ahead, i'll be happy to help [17:58:06] marktraceur: i wanted to get https://phabricator.wikimedia.org/T91152 done first, otherwise icons in these forms will be all blurry [17:58:09] Yeah, mostly I'd be happy to do it [17:58:16] (03CR) 10Physikerwelt: "@TheDJ did you watch them all https://en.wikipedia.org/wiki/List_of_Game_of_Thrones_episodes :-p" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [17:58:17] (and sizes of everything will be off, but that's less noticeable perhaps) [18:01:22] marktraceur: i did some groundwork for this a few months ago, HTMLForm is now subclassable and hopefully it will be straightforward to add a subclass using OOUI widgets [18:01:28] MatmaRex: Well, I can delve in and expect that blocker to be done eventually. Or I can try to unblock the blocker. Up to you, really, I don't know what's best [18:01:39] MatmaRex: Oh, as opposed to an output format? [18:01:58] yeah. it's kind of both still, but it's less bad than it used to be [18:02:09] Ohhhh [18:02:23] I get it, HTMLForm::factory returns a subclass if you pass it something meaningful. [18:02:32] you won't need to if() everything in the default methods [18:02:36] So I'd need to write the subclass *and* add it to factory [18:02:56] OK, fair enough [18:03:09] yeah, and the weird part too: add a getOOUI() method to HTMLFormField [18:03:18] because *that* is not subclassable [18:03:32] and there's a method for every output format instead [18:04:04] then you can override that in HTMLFormField subclasses like HTMLTextField [18:04:40] 'vform' implementation is probably a good template to follow (i reworked that to be such a subclass) [18:06:39] (03CR) 10Catrope: [C: 031] Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [18:06:48] (03CR) 10Catrope: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [18:13:58] ragesoss, yes, templatedata has an autofill field where you can define a timestamp template [18:14:25] mooeypoo: so that would be just a change to the templatedata to make that autofill? cool! [18:15:02] ragesoss, yep. I'm not entirely sure what template, but you should define a substitution template in that field and VE should substitute it [18:15:59] Krinkle knows more about the exact process, I don't have a lot of experience with about how subst: things work, but that's the point of the auto value field [18:16:25] mooeypoo can you use magic words directly, or do you have to use a template? [18:16:26] 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, 7Epic, 7Technical-Debt: VisualEditor: Rewrite converter to be bottom-up - https://phabricator.wikimedia.org/T53501#1209969 (10Jdforrester-WMF) p:5Normal>3Low [18:16:48] okay. know how to wrk subst templates, so I think I can fix this. thanks! [18:18:07] J-Mo: ragesoss: Doesn't have to be a template per se. It will use whatever is in autofill as-is. using subst: is up to the author. But it's unlikely you'll want to put something in there that isn't using subst: or ~~~ [18:18:13] RoanKattouw, any idea how we can work around the issues in https://phabricator.wikimedia.org/T95919 ? I've got nothing... [18:18:27] because if the value is static, you might as well use a default value in the template itself instead of where you use the template. [18:19:07] thanks Krinkle [18:20:40] (03PS4) 10Mooeypoo: Create a preview widget for generated content nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/204129 [18:20:43] * Krinkle can smell a barbecue outside :D [18:21:07] mooeypoo, Krinkle... apparently this is the problem? https://phabricator.wikimedia.org/T58772 [18:21:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 3Editing Department 2014/15 Q4 blockers, 7user-notice: VisualEditor: Provide a way for the user to switch between VisualEditor and wikitext source editor modes without saving - https://phabricator.wikimedia.org/T49779#486013 (10Jdforrester-WMF) [18:21:20] or rather, https://phabricator.wikimedia.org/T4700 [18:21:29] (03PS13) 10Mooeypoo: [PULL THROUGH] Use the preview widget in context items [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/200762 (https://phabricator.wikimedia.org/T93042) [18:21:29] mooeypoo: From the title of that ticket, I'd say autofill is an excellent use case [18:21:44] ragesoss: [18:21:49] I'm not sure how T4700 is related though [18:22:20] Krinkle: I'll try it out and see, I guess. [18:22:26] Krinkle, yeah that's what it looks like [18:23:12] ragesoss: You'd have autofill do something like {{subst:CURRENTDAY}}{{subst::CURRENTMONTH}} etc. or {{subst:#time: Y-m-d}} [18:23:23] depending on how flexible you need to be, #time is probably more readable [18:23:24] Krinkle: yeah, that's my plan. [18:23:43] MatmaRex: Then I guess I can start with no-op patches to add "getOOUI" to the relevant things... [18:24:52] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Icons for redirects, disambig, red link suggestions; default icon when there is no image - https://phabricator.wikimedia.org/T93694#1143589 (10Jdforrester-WMF) [18:24:54] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: When using citation templates, the page title and access date fields should be filled automatically - https://phabricator.wikimedia.org/T58772#1209997 (10Mooeypoo) Web page title is done by citoid, I'm not sure if we can migrate the operation to the Ci... [18:24:58] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Page images in link suggestions - https://phabricator.wikimedia.org/T93693#1209998 (10Jdforrester-WMF) [18:25:20] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Wikidata descriptions in link suggestions - https://phabricator.wikimedia.org/T93696#1143605 (10Jdforrester-WMF) [18:25:27] ragesoss, auto filling the page title is a bit more complex; that's what Citoid is doing (the auto fill extension) - that would actually auto fill everything for you, including the title, the access date and the url. [18:25:49] Krinkle, can the autofill be overridden btw ? [18:25:56] marktraceur: yeah. i think you could make getOOUI() fall back to getDiv() in the HTMLFormField implementation [18:26:00] mooeypoo: by whom? [18:26:01] mooeypoo: I'm just trying now to make the 'Cite web' autopopulate the current date for access date. [18:26:06] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Underline matching parts of link suggestions - https://phabricator.wikimedia.org/T93697#1210004 (10Jdforrester-WMF) This seems like a large amount of work for little gain. What's the user benefit? [18:26:09] Some users may want to add something that was accessed 2 days ago, and override current date ? [18:26:22] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Page images in context item (ve.ui.LinkContextItem) - https://phabricator.wikimedia.org/T93695#1143597 (10Jdforrester-WMF) [18:26:22] not sure how prevalent this need is, but it might be for old sites..? [18:26:39] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Replace current, sectioned, order of link inspector suggestions (new, existing, redirect, disambig) with new order - https://phabricator.wikimedia.org/T93698#1143621 (10Jdforrester-WMF) [18:26:48] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Use 'search' icon (magnifying glass) in link inspector text input - https://phabricator.wikimedia.org/T93699#1210013 (10Jdforrester-WMF) [18:26:59] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Split interfaces for internal and external links - https://phabricator.wikimedia.org/T93700#1210015 (10Jdforrester-WMF) [18:27:10] well, if they're adding the citation now, they can open the site again to see if the info is still there. Seems unlikely you'd open a new article in a browser and then 2 days later from memory enter the url and add the citation. [18:27:12] MatmaRex: I don't suppose you put each FormField class in its own file while you were down there, did you? :D [18:27:24] I remember that being a huge mess [18:27:39] mooeypoo: But yes, autovalue is a default value. [18:27:42] Not the final value [18:27:55] mooeypoo: ragesoss: https://github.com/wikimedia/mediawiki-extensions-TemplateData/blob/master/Specification.md#329-autovalue [18:27:58] Krinkle, fair enough. I remember adding citations to my school work with old dates sometimes (rarely,but still) [18:28:14] just wanted to make sure we're not creating a secondary issue [18:28:18] mooeypoo: Access date is not publication date. [18:28:23] Krinkle, I know [18:28:53] mooeypoo: For anything not published online there aren't access dates anyway. [18:29:06] It seems quite reasonable to look up something in a book an add the citation later [18:29:06] marktraceur: i think that was done earlier [18:29:17] zomg yay [18:29:22] This will be awesome [18:29:25] :D [18:29:37] Krinkle, but if you read a page and summarized (or took points from it) a week ago, and now you're moving whatever you wrote to the article, then even though you can access the page again, you *technically* accessed it (or based your facts on) the previous date, especially for web pages that seem to update a lot? [18:29:40] but we don't have access dates for books, since we generally consider those to not change randomly. And if they do, the ISBN wouldn't suffice anyway to know how you looked at it [18:30:43] Right, yeah. I don't think this is a common problem ,but I can see cases where it might arise. But the date can be changed anyways, so that's a nonissue. [18:30:48] mooeypoo: Yup, which is all the more reason to look at the url you're adding to a citation on the day of adding it [18:31:30] Indeed. But not everyone would. I assume sometimes people add citations after the fact. It's not that good, but it probably happens. [18:31:53] I'd be curious if they're the kind of people that bother with access dates. [18:31:58] Or to change it in a visual interface [18:32:01] Adds a barrier. [18:32:11] Anyway, it's possible. And they can. same as before VE. [18:32:24] * mooeypoo nods [18:35:03] hmm [18:35:10] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#1210051 (10cscott) We are emitting the mw:Error markup in Parsoid, I believe, and that hasn't changed. What @mooeypo... [18:35:16] fairly sure we have automatic access dates via templatedata on pl.wp. [18:36:03] MatmaRex: So I tend towards smaller commits, should I attempt to keep things small and no-oppy for as long as possible, or should I do a big patch adding getOOUI for all of the fields and then do the real stuff in a second patch? [18:36:33] oh no, we don't [18:36:41] because {{subst:}} doesn't work inside [18:36:48] stupid useless mediawiki [18:36:57] https://pl.wikipedia.org/w/index.php?title=Szablon:Cytuj_stron%C4%99/opis&diff=40994579&oldid=40983541 [18:37:40] I don't have a lot of experience with core patches, I always seem to get tied up in CR for months, so I guess it would be better to have one patch tied up for the same amount of months than many patches tied up for varying amounts [18:38:46] marktraceur: doesn't seem to be much point in having no-op code. whatever you do shouldn't be able to break existing forms anyway, since you'll only be adding stuff [18:39:19] Yeah [18:39:23] OK then! [18:39:27] marktraceur: so i say it would make sense to have working 'ooui' forms immediately? yeah [18:39:32] * marktraceur charges recklessly into the fray [18:41:07] 10VisualEditor, 10Continuous-Integration: Concurrent builds using local Chromium/Firefox browsers on Linux host fail - https://phabricator.wikimedia.org/T90673#1210074 (10Jdforrester-WMF) [18:41:35] Krinkle: Autovalue is a pre-populated value. [18:41:54] Krinkle: Not the fallback value if you don't set it (which is what we mean by "default" value). [18:42:02] edsanders, how do we handle staging stuff with "undo" ? we have this bug ,and I think it might have to do witht eh fact that we first insert a and later the template, but inserting the ref is done in staging -- yet, it's still 2 stages sort of thing, so "Undo" seems to only remove one. https://phabricator.wikimedia.org/T96120 [18:42:08] edsanders, is there a way to group staging for undo operations? [18:43:02] 10VisualEditor, 10Continuous-Integration: Concurrent builds using local Chromium/Firefox browsers on Linux host fail - https://phabricator.wikimedia.org/T90673#1064651 (10Jdforrester-WMF) At the weekly triage meeting today, we decided that this wasn't urgent for this quarter, so declined to accept it. [18:43:11] mooeypoo: surface.stopHistoryTracking(); do stuff; surface.breakpoint(); surface.startHistoryTracking(); [18:43:34] James_F: Yes, that's the default value in a form. [18:43:37] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: Reconsider location, interaction pattern of search field in Category dialog - https://phabricator.wikimedia.org/T91469#1210078 (10Jdforrester-WMF) At the weekly triage meeting today, we decided that this wasn't urgent for this... [18:43:39] RoanKattouw, hm. So I need to ad this when i stage? [18:43:41] 10VisualEditor, 10VisualEditor-MediaWiki: Reconsider location, interaction pattern of search field in Category dialog - https://phabricator.wikimedia.org/T91469#1210079 (10Jdforrester-WMF) [18:44:09] Krinkle: Sure, but let's be cautious about throwing around the 'd' word. :-) [18:44:11] if that's the case, shouldn't we have a more robust "startStaging" / "stopStaging" method that does the pushStaging +stop history and then pops + start history ? [18:45:21] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Underline matching parts of link suggestions - https://phabricator.wikimedia.org/T93697#1210080 (10Jdforrester-WMF) At the weekly triage meeting today, we decided that this wasn't urgent for this quarter, so d... [18:45:28] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design: Underline matching parts of link suggestions - https://phabricator.wikimedia.org/T93697#1210081 (10Jdforrester-WMF) [18:45:57] RoanKattouw: https://phabricator.wikimedia.org/T95945 edsanders|away looked at this some and said the issue seems to be in your wheelhouse. [18:46:12] mooeypoo: surface.stopHistoryTracking(); surface.breakpoint(); stage and do stuff; unstage; surface.breakpoint(); surface.startHistoryTracking(); [18:46:17] mooeypoo, Krinkle, it looks like that bug T4700 (or something else) does indeed stop me from setting up today's date as the autofill for the cite web template. [18:46:36] ragesoss: Yeah, I didn't realise it was inside a tag. [18:46:43] 10VisualEditor, 10VisualEditor-ContentLanguage, 10MediaWiki-extensions-UniversalLanguageSelector, 3Editing Department 2014/15 Q4 blockers, and 2 others: Make ULS input methods work in content editable divs of VisualEditor - https://phabricator.wikimedia.org/T51569#1210084 (10Jdforrester-WMF) [18:48:05] ragesoss: In cases like inserting {{delete|date=...}} or {{citation needed|date=..}} it works fine [18:48:23] Not much we can do about this from VE. Requires a Parser change. [18:48:32] (03PS7) 10Mooeypoo: Show template description in the template search [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203459 (https://phabricator.wikimedia.org/T53436) [18:48:58] 10VisualEditor: Auto-populate current date in citation dialog "URL access date" field - https://phabricator.wikimedia.org/T96171#1210087 (10Capt_Swing) [18:49:00] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: When using citation templates, the page title and access date fields should be filled automatically - https://phabricator.wikimedia.org/T58772#1210088 (10Capt_Swing) [18:50:12] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: [Regression] Ctrl+A no longer working since staging of slugs because a selection starting from a CE=false node in Chrome - https://phabricator.wikimedia.org/T74725#1210098 (10Jdforrester-WMF) [18:50:31] (03PS1) 10Mooeypoo: Add .jshintignore to Citoid extension [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/204316 [18:50:37] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: When using citation templates, the page title and access date fields should be filled automatically - https://phabricator.wikimedia.org/T58772#605263 (10Capt_Swing) @ragesoss tried this on enwiki beta, and it doesn't work: the subst; template is not re... [18:50:53] (03CR) 10Jforrester: [C: 032] Add .jshintignore to Citoid extension [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/204316 (owner: 10Mooeypoo) [18:51:47] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel, 3Editing Department 2014/15 Q4 blockers: Converter lets you put a paragraph directly in a list, which shouldn't be allowed and breaks fixUpInsertion - https://phabricator.wikimedia.org/T95945#1210101 (10Jdforrester-WMF) [18:52:34] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#1210103 (10Jdforrester-WMF) [18:52:42] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#544114 (10Jdforrester-WMF) >>! In T52788#1210051, @cscott wrote: > We are emitting the mw:Error markup in Parsoid, I... [18:52:54] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: VisualEditor: ISBN link labels (from magic words) can be changed, but not the underlying links - https://phabricator.wikimedia.org/T63558#1210105 (10Jdforrester-WMF) p:5Normal>3Low [18:53:02] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links, 3Editing Department 2014/15 Q4 blockers: Copying link between wikis cause url linking errors - https://phabricator.wikimedia.org/T95141#1210107 (10Jdforrester-WMF) [18:53:18] 10OOjs-UI, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Scrolling vertically the dialog for template in a ref fails and scrolls the visual content instead on iOS Safari - https://phabricator.wikimedia.org/T95159#1210108 (10Jdforrester-WMF) [18:53:29] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 3Editing Department 2014/15 Q4 blockers: Media search dialog should allow for dynamic reflow of the images when the screen changes dimensions - https://phabricator.wikimedia.org/T95017#1210109 (10Jdforrester-WMF) [18:54:27] (03PS8) 10Mooeypoo: Use the new ve.ui.PreviewWidget to display citation previews [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/202607 [18:54:57] 10Citoid, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers: Empty tag added using Citoid in VisualEditor (?) - https://phabricator.wikimedia.org/T96052#1210111 (10Jdforrester-WMF) p:5Triage>3Normal [18:55:25] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1210116 (10KHammerstein) [18:55:52] 10VisualEditor, 10VisualEditor-EditingTools, 3Editing Department 2014/15 Q4 blockers: tags added around closing bracket of an external link - https://phabricator.wikimedia.org/T96064#1210117 (10Jdforrester-WMF) p:5Triage>3Normal [18:57:04] (03CR) 10Krinkle: [C: 032] Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [18:57:31] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 3Editing Department 2014/15 Q4 blockers: Search interface for link dialogue - https://phabricator.wikimedia.org/T76397#1210126 (10KHammerstein) Based on usability testing, this is rated a 3 - Major usability problem: important to fix, so should be gi... [18:57:43] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: VE should prompt user to log in if they are not logged in and their IP is blocked (unless the IP is hard blocked?) - https://phabricator.wikimedia.org/T95752#1210128 (10Jdforrester-WMF) p:5Triage>3Low [18:57:48] where can I check the use cases for tables in VE? [18:58:11] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: VE should prompt user to log in if they are not logged in and their IP is blocked (unless the IP is hard blocked?) - https://phabricator.wikimedia.org/T95752#1199504 (10Jdforrester-WMF) > "You have been blocked from editing" s... [18:58:11] James_F: ---^^ [18:58:31] nzr: There isn't a single list of all the hundreds of use cases. [18:58:53] nzr: "The Wikipedia corpus" is an unhelpful answer. :-( [18:59:57] (03Merged) 10jenkins-bot: Add .jshintignore to Citoid extension [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/204316 (owner: 10Mooeypoo) [19:00:50] is there a way to look at 99% of the major cases? [19:01:19] there are always hundreds of use cases. but not all are used equally, that's why the term edge cases :) [19:02:00] MatmaRex: I fear there are more than just getDiv that I need to mimic. getHelpTextHtmlDiv, getLabelHtml, getInputHtml...will probably each need their own special thing [19:02:13] nzr: "There isn't a single list of any of the use cases, because there are hundreds of non-edge use cases." [19:02:57] nzr: However, https://www.mediawiki.org/wiki/VisualEditor:TableCaptionTest and https://www.mediawiki.org/wiki/VisualEditor:Tables! were the early test pages. [19:03:15] marktraceur: yeah, but aren't all of those called by getDiv() and similar methods only? [19:03:36] Yeah, but I'll need each of them [19:04:00] Or I could shove all of the results into getOOUI. [19:04:04] Maybe that's "better"? [19:04:35] fairly sure many of these shouldn't be public [19:07:54] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: VE should prompt user to log in if they are not logged in and their IP is anononly blocked - https://phabricator.wikimedia.org/T95752#1210148 (10Krenair) [19:07:58] James_F: Do you know if Aaron is around? [19:08:12] Krinkle: Which Aaron? [19:08:31] Krinkle: (Also, no, don't see either on IRC.0 [19:12:43] neilpquinn: https://meta.wikimedia.org/wiki/User:Jdforrester_(WMF) [19:12:49] neilpquinn: -> https://meta.wikimedia.org/wiki/User:NQuinn_(WMF)?veaction=edit [19:22:59] (03Merged) 10jenkins-bot: Defer loading easy-deflate [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/201008 (owner: 10Ori.livneh) [19:28:00] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers: VisualEditor: We need a representation of red-linked images - https://phabricator.wikimedia.org/T52788#1210187 (10Etonkovidova) The current handling of red-linked images in wmf1.25/1.26 - the non-existing images can be... [19:28:17] 10VisualEditor, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Defer the loading of ResourceLoader modules for features that are inactive on editor load - https://phabricator.wikimedia.org/T94616#1210188 (10Jdforrester-WMF) 5Open>3Resolved p:5Tr... [19:28:44] 10VisualEditor, 10VisualEditor-Performance, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-22_(1.26wmf3): Defer the loading of ResourceLoader modules for features that are inactive on editor load - https://phabricator.wikimedia.org/T94616#1168165 (10Jdforrester-WMF) a:5Catrope>3ori [19:29:24] 10VisualEditor, 10VisualEditor-EditingTools, 6Collaboration-Team, 6Mobile-Web, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1210199 (10matmarex) (By the way, what is the use case for settings which are not saved in MediaWiki user preferences, other tha... [19:30:05] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review, and 2 others: MWExtensionInspector should inherit from NodeInspector - https://phabricator.wikimedia.org/T93592#1210200 (10Jdforrester-WMF) 5Open>3Resolved [19:32:21] (03PS1) 10Kmenger: MenuLayout: Add example [oojs/ui] - 10https://gerrit.wikimedia.org/r/204326 [19:34:45] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-15_(1.26wmf2): Allow use of Citoid auto-fill citation inspector when editing a basic reference - https://phabricator.wikimedia.org/T94621#1210206 (10Jdforrester-WMF) [19:34:57] 10VisualEditor, 10VisualEditor-ContentEditable, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): [Regression pre-wmf1] Surface can't be blurred - https://phabricator.wikimedia.org/T95422#1210207 (10Jdforrester-WMF) [19:35:20] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt, 5WMF-deploy-2015-04-15_(1.26wmf2): MWExtensionInspector should inherit from NodeInspector - https://phabricator.wikimedia.org/T93592#1210208 (10Jdforrester-WMF) [19:35:20] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-01_(1.25wmf24), and 2 others: Saved edits are displayed only after additional page refresh - https://phabricator.wikimedia.org/T95466#1210209 (10Jdforrester-WMF) [19:35:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, and 2 others: Unbreak VE-MF - https://phabricator.wikimedia.org/T95044#1210210 (10Jdforrester-WMF) [19:35:26] 10OOjs-UI, 5OOjs-UI-0.9.5, 3Editing Department 2014/15 Q4 blockers, 5WMF-deploy-2015-04-08_(1.26wmf1): Be able to specify languages for icons (not just use ltr -> rtl substitution) - https://phabricator.wikimedia.org/T76539#1210211 (10Jdforrester-WMF) [19:35:27] (03PS1) 10Mooeypoo: Move 'applyStaging' after the operation is done in Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/204327 (https://phabricator.wikimedia.org/T96120) [19:35:32] 10OOjs-UI, 5OOjs-UI-0.9.5, 3Editing Department 2014/15 Q4 blockers, 7Technical-Debt, 5WMF-deploy-2015-04-08_(1.26wmf1): colorize-svg.js must support the same configuration format as MediaWiki's ResourceLoaderImageModule - https://phabricator.wikimedia.org/T93669#1210215 (10Jdforrester-WMF) [19:36:46] (03PS2) 10Mooeypoo: Move 'applyStaging' after the operation is done in Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/204327 (https://phabricator.wikimedia.org/T96120) [19:43:00] (03PS1) 10Physikerwelt: Prepare math extension for mathoid PNG support [extensions/Math] - 10https://gerrit.wikimedia.org/r/204328 (https://phabricator.wikimedia.org/T78056) [19:57:58] 10WikiEditor: Non-technical way to customize the WikiEditor editing tools - https://phabricator.wikimedia.org/T27068#1210286 (10Strainu) [20:02:48] (03CR) 10TheDJ: [C: 04-1] Render math tags in search results (037 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:04:21] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1210296 (10csteipp) @gwicke and I talked in person and agreed that if all service output that is html, svg, or any other xml-derived format is run through an ex... [20:05:21] (03CR) 10TheDJ: "@csteipp: this is gonna be accessible to all users. There is so much content escaping going on here, I really think that we should make su" [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [20:06:45] 10VisualEditor, 10VisualEditor-MediaWiki, 3Editing Department 2014/15 Q4 blockers: VE should prompt user to log in if they are not logged in and their IP is anononly blocked - https://phabricator.wikimedia.org/T95752#1210300 (10Esanders) Yes, the error message is not detailed enough, and provides no way to r... [20:10:23] TrevorP|Away: i guess we cancelled the FSG meeting ? [20:12:37] (trevor marked himself as not going to attend on the calendar, so busy i guess) [20:12:45] timo is firefighting releng stuff, i think [20:13:11] Yeah, though that's mostly burning to the ground by itself. Can't restart until it's all the way down. [20:13:13] What's up? [20:13:24] thedj: there's a presentation event happening at the office right now, so people might be there [20:13:35] Krinkle: we just had a meeting :P [20:13:38] Ah, indeed. [20:13:49] fairly sure there's not much to discuss anyway [20:28:59] 10VisualEditor, 10VisualEditor-EditingTools, 6Collaboration-Team, 6Mobile-Web, 7JavaScript: Add user settings frontend JavaScript API - https://phabricator.wikimedia.org/T96155#1210324 (10TheDJ) @matmarex, i can think of two things: * session specific settings (so sessionStorage over session cookies) * U... [20:36:11] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1210328 (10Krenair) a:5Krenair>3None I have no idea how we can work around this. [20:42:11] (03CR) 10Physikerwelt: Render math tags in search results (037 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) (owner: 10Physikerwelt) [21:00:42] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.Dialog - https://phabricator.wikimedia.org/T88559#1014685 (10Jdlrobson) [21:01:15] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Rewrite VisualEditorOverlay header using oojs ui. - https://phabricator.wikimedia.org/T96187#1210396 (10Jdlrobson) 3NEW [21:01:25] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1210402 (10Jdlrobson) [21:02:51] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Rewrite the edit summary screen of VisualEditorOverlay in oojs ui - https://phabricator.wikimedia.org/T96188#1210403 (10Jdlrobson) 3NEW [21:03:02] (03PS3) 10Mooeypoo: [wip] Keep the parameter list expanded after it was expanded once [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/203965 (https://phabricator.wikimedia.org/T95696) [21:03:16] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: Rewrite VisualEditorOverlay header using oojs ui. - https://phabricator.wikimedia.org/T96187#1210409 (10Jdlrobson) [21:05:07] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1210411 (10Jdlrobson) [21:05:38] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1014685 (10Jdlrobson) [21:07:06] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1014685 (10Jdlrobson) [21:07:44] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1210426 (10Jdlrobson) [21:10:02] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers, 5Patch-For-Review: VisualEditorOverlay should be written as an OO.ui.ProcessDialog - https://phabricator.wikimedia.org/T88559#1210430 (10Jdlrobson) [21:13:52] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1210443 (10BBlack) >>! In T95229#1210296, @csteipp wrote: > Ops, from my perspective, it would be really great to be able to plan for using alternate, unauthent... [21:20:55] Krinkle: so, is there a reason to believe https://gerrit.wikimedia.org/r/201267 ("ResourceLoaderImageModule: Implement cache invalidation") is not an improvement over current state of not having cache logic at all, or can you merge it? [21:21:33] I looked at the code and it looks good. I'll verify later. [21:21:40] I'm currently debugging failures in npm and qunit and jenkins [21:24:13] 10VisualEditor: When inserting a comment in VisualEditor, selected text should be transformed into text of comment - https://phabricator.wikimedia.org/T96190#1210485 (10pajz) 3NEW [21:37:43] (03CR) 10Jforrester: [C: 032] Try to unbreak WikiEditor modules [extensions/WikiEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/204173 (https://phabricator.wikimedia.org/T93384) (owner: 10Alex Monk) [21:39:39] MatmaRex: It's not about them being public, just need to reimplement them for the different format - or do it all in one, which seems not as nice [21:40:07] (03PS1) 10Mooeypoo: Add autoAddToCatchall=false to Citoid tool [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/204354 [21:40:10] RoanKattouw, ^^ [21:40:30] (03CR) 10Catrope: [C: 032] Add autoAddToCatchall=false to Citoid tool [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/204354 (owner: 10Mooeypoo) [21:41:12] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1210586 (10csteipp) > What we're already possibly-planning around is including *.wikimedia.org in all of the certs so that potentially one IP + one cert can han... [21:44:53] 10VisualEditor, 10RESTBase, 6operations, 7Performance: Set up an API base path for REST and action APIs - https://phabricator.wikimedia.org/T95229#1210595 (10GWicke) It would be great to use this for upload especially. [21:46:23] 10VisualEditor: Nested references cause infinite loop - https://phabricator.wikimedia.org/T96193#1210602 (10Mooeypoo) [21:46:56] etonkovidova, ^^ [21:47:16] mooeypoo: ok [21:47:27] See if it's the same bug or a different bug [21:49:31] 10OOjs-UI: Create a simpler API into SelectWidget - https://phabricator.wikimedia.org/T87602#1210608 (10matmarex) I thought about it for a bit and I can't come up with an API that won't suck or be confusing. I really don't want setValue()/getValue() to avoid confusion with InputWidgets; selectItemByData()/getSel... [21:49:50] 10OOjs-UI: Create a simpler API into SelectWidget - https://phabricator.wikimedia.org/T87602#1210609 (10matmarex) a:5matmarex>3None [21:52:13] (03PS16) 10Paladox: Add collapsiblenav back [skins/Vector] - 10https://gerrit.wikimedia.org/r/190717 (https://phabricator.wikimedia.org/T69954) [21:54:33] (03Merged) 10jenkins-bot: Try to unbreak WikiEditor modules [extensions/WikiEditor] (REL1_25) - 10https://gerrit.wikimedia.org/r/204173 (https://phabricator.wikimedia.org/T93384) (owner: 10Alex Monk) [21:54:36] (03Merged) 10jenkins-bot: Add autoAddToCatchall=false to Citoid tool [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/204354 (owner: 10Mooeypoo) [21:54:38] 10MediaWiki-ResourceLoader, 10OOjs-UI, 10VisualEditor, 3Editing Department 2014/15 Q4 blockers, and 2 others: RL manifest for OOjs UI icon packs should be better - https://phabricator.wikimedia.org/T92551#1210638 (10matmarex) [21:54:41] 10MediaWiki-ResourceLoader, 6Mobile-Web, 3Editing Department 2014/15 Q4 blockers: ResourceLoaderImageModule does no cache invalidation after icons change - https://phabricator.wikimedia.org/T94733#1210635 (10matmarex) 5Open>3Resolved [21:58:19] (03PS17) 10Paladox: Add collapsiblenav back [skins/Vector] - 10https://gerrit.wikimedia.org/r/190717 (https://phabricator.wikimedia.org/T69954) [21:59:37] (03PS12) 10Physikerwelt: Render math tags in search results [extensions/Math] - 10https://gerrit.wikimedia.org/r/197737 (https://phabricator.wikimedia.org/T93075) [22:17:01] (03PS1) 10Catrope: Add autoAddToCatchall=false to Citoid tool [extensions/Citoid] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204398 [22:17:13] (03PS1) 10Catrope: Add autoAddToCatchall=false to Citoid tool [extensions/Citoid] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204399 [22:17:17] (03CR) 10Catrope: [C: 032] Add autoAddToCatchall=false to Citoid tool [extensions/Citoid] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204399 (owner: 10Catrope) [22:17:27] (03CR) 10Catrope: [C: 032] Add autoAddToCatchall=false to Citoid tool [extensions/Citoid] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204398 (owner: 10Catrope) [22:19:08] (03Merged) 10jenkins-bot: Add autoAddToCatchall=false to Citoid tool [extensions/Citoid] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204399 (owner: 10Catrope) [22:19:22] (03Merged) 10jenkins-bot: Add autoAddToCatchall=false to Citoid tool [extensions/Citoid] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204398 (owner: 10Catrope) [22:23:31] (03PS1) 10Mooeypoo: Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204400 [22:23:59] RoanKattouw, ^^ [22:27:32] (03PS2) 10Paladox: Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [22:27:52] (03PS3) 10Paladox: Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [22:28:16] (03CR) 10jenkins-bot: [V: 04-1] Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [22:28:38] (03PS4) 10Paladox: Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [22:28:45] (03CR) 10jenkins-bot: [V: 04-1] Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [22:29:03] (03PS5) 10Paladox: Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [22:29:09] (03CR) 10jenkins-bot: [V: 04-1] Replace step-by-step publishing with publish-staying-in-editmode [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/71617 (owner: 10VitaliyFilippov) [22:41:22] (03CR) 10Catrope: [C: 032] Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204400 (owner: 10Mooeypoo) [22:43:02] (03CR) 10Catrope: [C: 04-1] Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204400 (owner: 10Mooeypoo) [22:43:43] (03PS2) 10Mooeypoo: Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204400 [22:48:24] If I set a DropdownInputWidget's value config to the value of one of the options, will it be smart enough to do that all on its own? [22:48:49] Or will I need to set 'selected' on one of the options or something [22:50:05] It should remember your selection [22:51:11] Uhh [22:51:22] marktraceur, you need to use "chooseItem" [22:51:26] mooeypoo: Meaning if I have a new one, and it has a bunch of options, one of which has the same...oh [22:51:29] Right [22:51:30] I remember that hell now [22:51:51] Yeah [22:51:58] We need to add an easier wrapper interface for that [22:52:03] That's more HTML-like [22:52:12] marktraceur, here is the line from TemplateDataDialog to get it to show the currently chosen language: this.languageDropdownWidget.getMenu().chooseItem( this.languageDropdownWidget.getMenu().getItemFromData( language ) ); [22:52:14] Right now you have to find an item by value, then select that item [22:52:36] (03CR) 10Catrope: [C: 032] Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204400 (owner: 10Mooeypoo) [22:52:45] mooeypoo: Don't suppose you have that in PHP? :P [22:52:49] I can translate [22:52:58] marktraceur, uh... no? :P but MatmaRex might? [22:53:13] I'm kidding, it's the same, just s/\./->/g pretty much [22:53:28] And some things are missing but they make no sense anyway [22:53:44] it should be the same API, technically, yeah [22:56:18] (03Merged) 10jenkins-bot: Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204400 (owner: 10Mooeypoo) [22:56:38] 10OOjs-UI: Selecting a value from DropdownInputWidget should have an easier API - https://phabricator.wikimedia.org/T96198#1210824 (10Mooeypoo) 3NEW [22:56:47] marktraceur, ^^ [22:58:15] Sweet, ta [22:58:29] (03CR) 10Mooeypoo: "(added a forgotten reply to ps2)" (031 comment) [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 (owner: 10Mooeypoo) [22:58:32] I'm glad I can be a mildly effective canary for you guys [22:58:47] 10OOjs-UI: Selecting a value from DropdownInputWidget should have an easier API - https://phabricator.wikimedia.org/T96198#1210831 (10Mooeypoo) a:3Mooeypoo [22:59:46] (03PS1) 10Catrope: Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204406 [22:59:56] (03PS1) 10Catrope: Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204407 [23:00:01] (03CR) 10Catrope: [C: 032] Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204407 (owner: 10Catrope) [23:00:11] (03CR) 10Catrope: [C: 032] Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204406 (owner: 10Catrope) [23:01:52] mooeypoo: that's a dupe [23:02:01] marktraceur: DropdownWidget and DropdownInputWidget are not the same thing [23:02:11] mooeypoo: ^ [23:03:19] 10OOjs-UI: Create a simpler API into SelectWidget - https://phabricator.wikimedia.org/T87602#1210836 (10matmarex) [23:03:21] 10OOjs-UI: Selecting a value from DropdownInputWidget should have an easier API - https://phabricator.wikimedia.org/T96198#1210835 (10matmarex) [23:03:24] James_F|Away: Interesting, upstream Phabricator's own workboards (the /tag/ view I mean) all filter by open tasks by default. Which makes sense since some projects wil have 10,000s of closed tags in history. Maybe we've got our setup misconfigured. I don't see any task or commit upstream that changed this. [23:03:30] marktraceur: DropdownWidget is the one that has the weird stuff, and which also doesn't exist in PHP [23:03:31] MatmaRex, ... bah. [23:03:45] marktraceur: DropdownInputWidget does exist in PHP and has a very simple API [23:04:19] (you just call setValue($val)/getValue(), and you don't even have access to individual Option object) [23:04:25] (because there aren't any) [23:05:06] DropdownInputWidget has a nested dropdownWidget... [23:05:45] in JS. in PHP, it has a s [23:06:13] MatmaRex, I see. So this bug is only valid to the JS side ? [23:06:26] MatmaRex, I already have a tentative patchset to add this to dropdowninput widget [23:06:32] should I bother? [23:06:42] add what? [23:07:05] a wrapper function to select an item by its data [23:07:28] (03Merged) 10jenkins-bot: Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/204407 (owner: 10Catrope) [23:07:30] (03CR) 10jenkins-bot: [V: 04-1] Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204406 (owner: 10Catrope) [23:07:57] mooeypoo: but DropdownInputWidget already has it [23:08:02] setValue() [23:08:08] MatmaRex, what? where? [23:08:11] (03CR) 10Catrope: [C: 032] "Come on Jenkins" [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204406 (owner: 10Catrope) [23:08:18] are you talking about DropdownWidget? [23:08:28] MatmaRex, ha! I totally missed that [23:10:00] mooeypoo: so yeah, we could add a very similar method to DropdownWidget, or preferably SelectWidget too/instead [23:10:10] MatmaRex: Well that's better, yeah. [23:10:29] (i might have been wrong to dupe the bugs, since DropdownWidget doesn't inherit from SelectWidget, it uses a SelectWidget inside instead) [23:12:37] MatmaRex, you mean menu select widget? [23:12:46] yeah [23:16:50] #toomanywidgets [23:17:15] Select, Dropdown, MenuSelect, DropdownInput, arglebargleflarg [23:17:39] (03CR) 10jenkins-bot: [V: 04-1] Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204406 (owner: 10Catrope) [23:19:14] (03CR) 10Catrope: [V: 032] Correctly use mwcite action and hide basic/existing ref inside basic reference [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204406 (owner: 10Catrope) [23:22:32] MatmaRex, I'm almost done with a preliminary commit, just let me know if that's what you werei thnking about? i see there's a bit of a discussion in the bug about naming stuff [23:24:22] 10OOjs-UI, 10VisualEditor, 5WMF-deploy-2015-04-15_(1.26wmf2): betalabs displays oo-ui-icon-help icon as mirrored right-to-left in Hebrew - https://phabricator.wikimedia.org/T95636#1210851 (10Jdforrester-WMF) [23:24:45] mooeypoo: if you come up with a good name, then i think that'll be good to go :) [23:24:59] we already have too many similarly named things, heh [23:25:02] 10WikiEditor, 3Editing Department 2014/15 Q4 blockers: editSessionID is duplicated in Edit:Schema for Wikitext - https://phabricator.wikimedia.org/T95919#1210856 (10Halfak) Maybe you could check if the current version of the page matches the parentRevId field and update the sessionId if it doesn't. [23:25:07] MatmaRex, well, I think that the name should be different between the functionalities [23:25:25] in the select widget, it's items and data. In the dropdown widget and dropdown input widget, it's value [23:25:35] (03PS1) 10Mooeypoo: Add an option to select an item by its value to SelectWidget [oojs/ui] - 10https://gerrit.wikimedia.org/r/204414 (https://phabricator.wikimedia.org/T87602) [23:25:40] MatmaRex, what do you think of this? ^^ [23:27:41] mooeypoo: why "dropdown widget and dropdown input widget"? (why "and"?) [23:28:09] mooeypoo: i think we should only use 'value' for InputWidgets and actual tags [23:28:50] otherwise we're making the distinction between FooWidget and FooInputWidget even more confusing [23:31:16] MatmaRex, I think that's my issue [23:31:19] what IS the difference? [23:31:35] I thought the main difference was whether they're in forms or not [23:35:05] 10Citoid, 10VisualEditor, 5Patch-For-Review: "Undo" only undoes Citoid's addition of content, not the whole ref (aka Citoid inserts empty tags) - https://phabricator.wikimedia.org/T96120#1210897 (10Mooeypoo) a:3Mooeypoo [23:38:29] (the distinction being, FooInputWidget can be placed within HTML form and submitting the form will include widget's name/value) [23:38:29] (sorry, i got disconnected, please repeat if you said anything to me) [23:38:29] mooeypoo: i need to go, can we continue tomorrow or by email? i dumped these comments on the change [23:40:06] (03PS5) 10Mooeypoo: Find first focusable element in booklet and add focusable utility [oojs/ui] - 10https://gerrit.wikimedia.org/r/204197 [23:41:26] (03PS3) 10Mooeypoo: Focus on the first focusable element in template dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/204204 [23:42:09] (03PS1) 10Catrope: Revert "Correctly use mwcite action and hide basic/existing ref inside basic reference" [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204420 [23:42:16] (03CR) 10Catrope: [C: 032 V: 032] Revert "Correctly use mwcite action and hide basic/existing ref inside basic reference" [extensions/VisualEditor] (wmf/1.26wmf1) - 10https://gerrit.wikimedia.org/r/204420 (owner: 10Catrope) [23:42:26] * marktraceur looks, bleary-eyed, at HTMLCheckMatrix [23:42:30] I don't wanna [23:43:02] I'll leave that for the next brave soul. [23:43:25] marktraceur, isn't that the motto of open source? [23:43:33] Pretty much [23:43:38] mooeypoo: Well, *I* don't need it. [23:43:47] There you go [23:43:56] I support it unless the next brave soul is me. [23:43:58] Only Echo and OAuth...oh, wait, I started this because OAuth is what I'm working on. [23:44:01] FUCK. [23:44:03] I forgot. [23:44:13] lol [23:44:24] Fate is cruel [23:45:04] marktraceur: :-) [23:45:46] (03CR) 10Mooeypoo: "If that's the only difference between FooWidget and FooInputWidget then why should their APIs be different at all? Their function seems to" [oojs/ui] - 10https://gerrit.wikimedia.org/r/204414 (https://phabricator.wikimedia.org/T87602) (owner: 10Mooeypoo) [23:45:53] Oh, wait, it's not as bad as I thought. [23:46:06] It's just a bunch of checkboxes. I thought it was a 2D array of them. [23:46:22] marktraceur: You're in a maze of checkboxen, all alike. [23:47:29] Yeah [23:48:46] (03CR) 10Mooeypoo: "To be perfectly honest, if we really need a separation of API naming at all between these two, then we might as well name it "setValue" fo" [oojs/ui] - 10https://gerrit.wikimedia.org/r/204414 (https://phabricator.wikimedia.org/T87602) (owner: 10Mooeypoo) [23:49:45] I'm going to need a new widget for this I think. [23:49:49] This is a bad design [23:50:02] Bad design? Where?? [23:50:19] MediaWiki core, of course [23:50:37] (03PS3) 10Mooeypoo: Move 'applyStaging' after the operation is done in Citoid [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/204327 (https://phabricator.wikimedia.org/T96120)