[00:06:23] legoktm: It should be prefixed with "build: " rather than "test: " but looks good; could it do the other devDependencies? [00:10:38] James_F: none of them have updates [00:10:42] legoktm: Oh, I see. [00:10:54] legoktm: Want the script to update the title or should I? [00:11:03] (03PS2) 10Legoktm: build: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/216342 [00:11:20] That answers that. :-) [00:11:25] (03CR) 10Jforrester: [C: 032] build: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/216342 (owner: 10Legoktm) [00:11:26] script can't really amend stuff, so I did it manually and updated the script to use build from now on [00:11:31] * James_F nods. [00:11:35] ok, submitting the rest :) [00:11:39] Also, would be nice if the script set a topic. [00:11:41] But eh. [00:11:52] * legoktm checks [00:12:20] James_F: what do you want the topic to be? [00:12:32] legoktm: "bump-dev-deps" is traditional, but whatever you like. [00:13:15] Also, some of them will need careful manual testing. [00:13:30] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/216342 (owner: 10Legoktm) [00:14:59] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/216353 [00:15:48] legoktm: Whee. [00:16:20] (03CR) 10Jforrester: [C: 032] "Hmm. We should switch over to grunt-jscs; will do a follow-up." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/216353 (owner: 10Legoktm) [00:17:05] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/216353 (owner: 10Legoktm) [00:17:17] James_F: how should the script handle ~ and ^ versions? [00:17:30] (because it's not) [00:17:32] legoktm: Remove them. We pin versions for security reasons. [00:17:39] security/stability/blah. [00:18:12] 10VisualEditor, 7Epic: Make improvements to the VisualEditor team's processes - https://phabricator.wikimedia.org/T101207#1342883 (10Neil_P._Quinn_WMF) [00:18:25] James_F: https://gerrit.wikimedia.org/r/#/q/status:open+topic:bump-dev-deps,n,z [00:18:26] 10VisualEditor: Publish VisualEditor process report on mediawiki.org - https://phabricator.wikimedia.org/T101209#1332700 (10Neil_P._Quinn_WMF) [00:20:02] legoktm: Yeah, doing. [00:20:13] :D [00:20:24] I will start working on fixing the ones that didn't pass locally [00:20:38] * James_F nods. [00:46:52] (03PS1) 10Legoktm: Add explicit dependeny upon grunt-cli [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216373 [00:46:54] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216374 [00:47:16] (03PS2) 10Jforrester: build: Add explicit dependency upon grunt-cli [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216373 (owner: 10Legoktm) [00:47:23] (03CR) 10Jforrester: [C: 032] build: Add explicit dependency upon grunt-cli [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216373 (owner: 10Legoktm) [00:47:29] (03PS2) 10Jforrester: build: Updating development dependencies [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216374 (owner: 10Legoktm) [00:47:38] (03Merged) 10jenkins-bot: build: Add explicit dependency upon grunt-cli [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216373 (owner: 10Legoktm) [00:47:40] (03CR) 10Jforrester: [C: 032] build: Updating development dependencies [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216374 (owner: 10Legoktm) [00:47:55] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216374 (owner: 10Legoktm) [01:22:06] (03PS1) 10Jforrester: build: Switch from grunt-jscs-checker to grunt-jscs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/216393 [01:22:15] (03CR) 10Jforrester: "Done in I1923b39." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/216353 (owner: 10Legoktm) [01:26:37] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1342942 (10MZMcBride) >>! In T96323#1280134, @Elitre wrote: > How difficult would it be to get one for another wiki (the Spanish Wikipe... [01:27:36] 10VisualEditor: Automatic Cite generation results in malformed URL after fed valid LeMonde.fr link - https://phabricator.wikimedia.org/T101589#1342943 (10Stesmo) 3NEW [01:28:24] 10VisualEditor: Automatic Cite generation results in malformed URL after fed valid LeMonde.fr link - https://phabricator.wikimedia.org/T101589#1342951 (10Stesmo) [01:32:13] 10VisualEditor, 10VisualEditor-Performance: Compute initial toolbar offsets by inspecting div#content - https://phabricator.wikimedia.org/T91417#1083133 (10Stesmo) Accidentally dragged this item into another workboard... Hopefully didn't mess up everything too much here. [01:34:54] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1342972 (10MZMcBride) >>! In T96323#1342044, @Whatamidoing-WMF wrote: > A simple search-and-replace operation won't be able to tell the... [01:44:11] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1342978 (10MZMcBride) >>! In T96323#1342972, @MZMcBride wrote: > The counts are coming from the use of `uniq -c`. I guess I could do a... [01:48:08] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1342986 (10MZMcBride) >>! In T96323#1278415, @Whatamidoing-WMF wrote: > If by "you", you mean "someone who is not me", then that sounds... [05:42:38] (03PS1) 10Ricordisamoa: Use a valid "license" in package.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216399 [05:46:21] (03CR) 10Legoktm: [C: 032] Use a valid "license" in package.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216399 (owner: 10Ricordisamoa) [05:46:38] (03Merged) 10jenkins-bot: Use a valid "license" in package.json [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/216399 (owner: 10Ricordisamoa) [06:22:46] (03CR) 10Legoktm: [C: 032] build: Switch from grunt-jscs-checker to grunt-jscs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/216393 (owner: 10Jforrester) [06:24:37] (03Merged) 10jenkins-bot: build: Switch from grunt-jscs-checker to grunt-jscs [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/216393 (owner: 10Jforrester) [07:22:38] eranroz : hi, i'm looking at ve.ui.HistoryCommand.js . Can you tell me what this.check does? [07:25:59] ankita-ks: hi. I think it is used internally specificly for this command (in isExecutable) [07:26:28] okay.. so when I create an action for LanguageTool I can ignore this option? [07:26:53] yes, this isn't infrastracture but specific to that command [07:27:20] okay [10:29:32] 10VisualEditor: Major Visual Editor bug on fr.wiktionary: sections titles sabotage - https://phabricator.wikimedia.org/T101599#1343138 (10JackPotte) 3NEW [10:31:27] 10VisualEditor: Major Visual Editor bug on fr.wiktionary: sections titles sabotage - https://phabricator.wikimedia.org/T101599#1343156 (10JackPotte) [10:32:19] 10VisualEditor: Major Visual Editor bug on fr.wiktionary: sections titles sabotage - https://phabricator.wikimedia.org/T101599#1343138 (10JackPotte) [10:46:39] 10VisualEditor, 10MediaWiki-skins-Chameleon: Dropdowns in the VE toolbar opening "under" the content area in the Chameleon skin - https://phabricator.wikimedia.org/T72678#1343163 (10Foxtrott) 5Open>3Resolved [10:47:18] 10VisualEditor, 10MediaWiki-skins-Chameleon: Dropdowns in the VE toolbar opening "under" the content area in the Chameleon skin - https://phabricator.wikimedia.org/T72678#757650 (10Foxtrott) Works with latest versions of VE and Chameleon skin. [10:59:46] 10VisualEditor, 10VisualEditor-MediaWiki, 7Regression: Page title should not shrink when opening editor - https://phabricator.wikimedia.org/T101538#1343165 (10matmarex) Regression from https://gerrit.wikimedia.org/r/#/c/206103/ per T91152, previous attempt to fix was https://gerrit.wikimedia.org/r/#/c/208509... [11:13:36] 10VisualEditor, 10VisualEditor-MediaWiki: Input field oversized in "Add a template" dialog - https://phabricator.wikimedia.org/T101600#1343180 (10matmarex) 3NEW a:3matmarex [11:18:31] (03PS1) 10Bartosz Dziewoński: ve.ui.MWTitleInputWidget: Restore 've-ui-mwTitleInputWidget' CSS class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/216409 (https://phabricator.wikimedia.org/T101600) [11:19:27] (03CR) 10Bartosz Dziewoński: "Followup: https://gerrit.wikimedia.org/r/#/c/216409/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/213561 (owner: 10Catrope) [11:21:54] 10VisualEditor, 10VisualEditor-EditingTools, 7Accessibility: In Firefox, tabbing in the template dialog skips parameter actions - https://phabricator.wikimedia.org/T101466#1343203 (10matmarex) I can't reproduce using Firefox 38.0.5 on Windows 7. Tabbing highlights the icons and they work as expected. Shift-t... [13:06:46] 10Cite, 5Patch-For-Review: Edit preview doesn't let you preview cite.php footnotes. - https://phabricator.wikimedia.org/T7984#1343285 (10TheDJ) I've updated this patch a bit. Anyone wanna try it out ? [14:06:57] 10Cite, 5Patch-For-Review: Cite extension's styles are JS loaded - https://phabricator.wikimedia.org/T101559#1343325 (10TheDJ) 5Open>3Resolved a:3TheDJ [14:09:16] 10TemplateData, 6Community-Liaison, 10WMF-Product-Strategy: Please make me a list of commonly used templates in Wikipedia articles - https://phabricator.wikimedia.org/T96323#1343328 (10MZMcBride) >>! In T96323#1342942, @MZMcBride wrote: >>>! In T96323#1280134, @Elitre wrote: >> How difficult would it be to g... [14:10:30] 10Cite: Cite extension's styles are JS loaded - https://phabricator.wikimedia.org/T101559#1343329 (10TheDJ) [14:17:56] (03CR) 10Jforrester: [C: 032] ve.ui.MWTitleInputWidget: Restore 've-ui-mwTitleInputWidget' CSS class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/216409 (https://phabricator.wikimedia.org/T101600) (owner: 10Bartosz Dziewoński) [14:19:56] (03Merged) 10jenkins-bot: ve.ui.MWTitleInputWidget: Restore 've-ui-mwTitleInputWidget' CSS class [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/216409 (https://phabricator.wikimedia.org/T101600) (owner: 10Bartosz Dziewoński) [14:45:06] eranroz : how to i determine the language of text in visualeditor? [14:47:33] MatmaRex : do you know how to do that? Is there any variable or property or function that can just give me the language the text is in? [14:49:41] ankita-ks: you would have to check if the text has a 'meta/language' annotation (LanguageAnnotation), and check the annotation's 'lang' attribute. sorry, i don't know off-hand how to do this [14:49:49] otherwise, you can assume that all text is in wiki content language. [14:49:58] which is? [15:33:11] 10VisualEditor: Editing fr.wiktionary: Duplicated template categories in Section titles (custom template "S") - https://phabricator.wikimedia.org/T101599#1343399 (10Aklapper) [16:11:59] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: OpenSearch results aren't perfect for searching for pages (some don't come up) - https://phabricator.wikimedia.org/T56361#1343424 (10Krinkle) [16:12:00] 10VisualEditor, 7Technical-Debt: VisualEditor: OpenSearch results aren't perfect for checking for page existence - https://phabricator.wikimedia.org/T53013#1343425 (10Krinkle) [16:19:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 7Regression: User input wrongly described as "page does not exist" - https://phabricator.wikimedia.org/T101611#1343443 (10Krinkle) 3NEW [16:20:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 7Regression: Link inspector input wrongly shown as "does not exist" when redirect exists - https://phabricator.wikimedia.org/T101611#1343454 (10Krinkle) [19:18:11] Hi, i am stuck with this issue. I collect all the text from the editing section in visualeditor and then query LanguageTool server with the text. [19:18:32] But I get this error : XMLHttpRequest cannot load http://tools.wmflabs.org/languageproofing/. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://127.0.0.1' is therefore not allowed access. The response had HTTP status code 500. [19:21:53] MatmaRex , RoanKattouw_away , eranroz : could you help me with this? [19:22:32] I can share the error logs from the server and the script I use to query the server. [19:27:26] ankita-ks: are you setting the 'Access-Control-Allow-Origin' header on the labs tool? [19:27:41] How do I do that? [19:27:42] (by the way, http://tools.wmflabs.org/languageproofing/ appears to be down right now?) [19:27:54] Oh no it's not [19:28:00] a curl request works fine [19:28:11] curl --data "language=en&text=a simple test" http://tools.wmflabs.org/languageproofing/ [19:28:18] MatmaRex ^ this works [19:30:19] ankita-ks: i don't know what language/framework the labs tool is written in, so i have no idea how to add the header [19:30:42] but you need to send some Access-Control-Allow-Origin that will allow other sites to sent XHR requests to your tool [19:30:47] the simplest way would be "Access-Control-Allow-Origin: *" [19:31:07] hmm..okay. [19:31:14] ankita-ks: you can see the headers in curl output if you add the -i flag [19:31:18] curl -i --data "language=en&text=a simple test" http://tools.wmflabs.org/languageproofing/ [19:32:35] Access-Control-Allow-Origin is only required when the call is made via a browser right? [19:32:39] MatmaRex [19:32:59] also, how do these response headers help (I can see them) [19:33:42] ankita-ks: yes. a cross-domain xmlhttprequest is only allowed when the target site sets the right 'Access-Control-Allow-Origin' header to allow the origin site to access it [19:34:19] otherwise you could send XHR requests form anywhere to anywhere, with the user's cookies, possibly accessing other sites with their credentials [19:34:47] ankita-ks: you can try out the MediaWiki API for an example, too [19:35:30] okay [19:36:15] So I will have to figure out a way to set Access-Control-Allow-Origin. Is there a workaround for this? [19:36:37] what if instead of querying from the browser I trigger another script that does it? [19:36:43] a php script? [19:37:30] ankita-ks: but you still need to query *something* from the browser, to get the data? [19:38:07] ankita-ks: is the source of the labs tool public somewhere? [19:38:17] yes [19:38:43] can't you just log into tools and look at it that way? [19:39:08] Krenair : what do you mean? [19:39:16] I was talking to MatmaRex [19:39:24] he was asking where the source was [19:39:30] Krenair: you mean me? no idea. i don't really understand/use tools [19:39:34] oh, ok [19:39:35] tool labs* [19:40:24] MatmaRex : https://github.com/ankita-kumari/languagetool [19:40:36] Here it is if you want to take a look [19:40:46] java :o [19:40:50] yes :) [19:41:43] That is why i was looking for a workaround. I don't know how to set the options here. I will ask Daniel Naber (he maintains languageTool) if it can be done. [19:44:31] ankita-ks: this looks interesting: https://github.com/languagetool-org/languagetool/blob/6ad2ac03f6b14271e2e3e56546da24f745aecde7/languagetool-server/src/main/java/org/languagetool/server/Server.java#L122 [19:45:35] looks like this already exists, you just need to start the server with the parameter [19:45:49] MatmaRex : oh yes, so it seems. Thank you so much. I will try this. :) [19:51:27] :) [20:15:51] MatmaRex : I am getting the same error even after setting the option. :| [20:16:05] Here is the action i have defined : https://github.com/ankita-kumari/VisualEditor-LanguageTool/blob/master/modules/ext.LanguageToolAction.js#L117 [20:16:11] Is there something I am doing wrong? [20:17:25] ankita-ks: i don't know [21:13:50] 10VisualEditor: Editing fr.wiktionary: Duplicated template categories in Section titles (custom template "S") - https://phabricator.wikimedia.org/T101599#1343647 (10JackPotte) Now we have cleaned nearly a hundred of these bugs, like https://fr.wiktionary.org/w/index.php?title=ben&diff=19914527&oldid=19908652. S... [21:34:49] 10VisualEditor: Editing fr.wiktionary: Duplicated template categories in Section titles (custom template "S") - https://phabricator.wikimedia.org/T101599#1343660 (10JackPotte) To answer Dereckson on the IRC, the very first occurrence of this bug is https://fr.wiktionary.org/w/index.php?title=avenir&curid=4915&di... [21:36:49] 10VisualEditor, 10Parsoid: Editing fr.wiktionary: Duplicated template categories in Section titles (custom template "S") - https://phabricator.wikimedia.org/T101599#1343662 (10Krenair) Seems relatively close to this entry in SAL for the 3rd of June: `20:19 subbu: deployed parsoid sha ab675400` [21:48:18] 10VisualEditor, 10Parsoid: Editing fr.wiktionary: Duplicated template categories in Section titles (custom template "S") - https://phabricator.wikimedia.org/T101599#1343666 (10Dereckson) According [[ https://www.mediawiki.org/w/index.php?title=Parsoid/Deployments&oldid=1665401#Wednesday.2C_June_3.2C_2015_aroun... [21:48:37] 10VisualEditor, 10Parsoid, 7Regression: Editing fr.wiktionary: Duplicated template categories in Section titles (custom template "S") - https://phabricator.wikimedia.org/T101599#1343668 (10Dereckson) [22:00:16] 10VisualEditor, 10Parsoid, 7Regression: Editing fr.wiktionary: Duplicated template categories in Section titles (custom template "S") - https://phabricator.wikimedia.org/T101599#1343671 (10ssastry) I just got home and saw the bug report. I checked and it seems to be an old bug that got triggered by gerrit 21... [23:58:07] 10VisualEditor, 10Parsoid, 5Patch-For-Review, 7Regression: Editing fr.wiktionary: Duplicated template categories in Section titles (custom template "S") - https://phabricator.wikimedia.org/T101599#1343704 (10Dereckson) a:3ssastry **Parse test** ``` [subbu@earth lib] echo '=={{S|nom|fr}}==' | node parse... [23:58:22] 10VisualEditor, 10Parsoid, 5Patch-For-Review, 7Regression: Editing fr.wiktionary: Duplicated template categories in Section titles (custom template "S") - https://phabricator.wikimedia.org/T101599#1343706 (10Dereckson) 5Open>3Resolved