[00:03:04] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Verified-in-Phase0, 5WMF-deploy-2015-09-08_(1.26wmf22): [Regression pre-wmf22] Cancelling link inspector crashes VE - https://phabricator.wikimedia.org/T111241#1600381 (10Ryasmeen) [00:06:34] James_F, which versions of the schema did you guys look through? [00:16:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Merge MobileWebEditing schema into Edit schema - https://phabricator.wikimedia.org/T110272#1600404 (10Krenair) Re funnel - ctaSignup is very gone (last seen December 2013, a few weeks after the aforementioned commit was merged), but leftNavSignup is... [00:23:18] Krenair: Which schemata? [00:23:27] Krenair: MobileWebEdit or Edit? Or both? [00:26:15] MobileWebEdit [00:28:52] Krenair: I think just the current version. neilpquinn? [00:29:56] Yep, just the most current version. Is there anything in the old versions we should look at? [00:33:30] You pulled up data that I was only able to find going back to MobileWebEditing_6077315. Current version is MobileWebEditing_8599025. [00:33:59] event_funnel='ctaSignup' [00:56:17] 10VisualEditor: After undoing edit inside a cell for a table cannot type anymore in that cell although the cursor is active there - https://phabricator.wikimedia.org/T111295#1600539 (10Ryasmeen) 3NEW [01:06:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1600557 (10Neil_P._Quinn_WMF) [01:08:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1574002 (10Neil_P._Quinn_WMF) Okay, I've taken another pass as the task description to take into account some of the c... [01:21:40] thanks neilpquinn [01:24:52] (03PS1) 10Jforrester: mw.trackSubscriber: Log platform as phone vs. desktop [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235661 [01:25:04] RoanKattouw: ^^ [01:25:52] I thought we weren't going to log that? [01:26:04] I disagree with Neil. :-) [01:27:46] :) [01:28:26] modules/ve-mw/init/ve.init.mw.Target.js:ve.init.mw.Target.static.name = 'mwTarget'; [01:28:33] modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js:ve.init.mw.MobileArticleTarget.static.name = 'mobile'; [01:28:53] we already log that [01:29:37] so platform → integration? [01:30:04] oh, right [01:30:12] name, not integration. [01:30:31] integration is just 'page' [01:30:35] helpfully [01:30:56] still, no need for a new static property James_F? [01:56:27] 10Citoid: Attempt to parse archive.org URLs? - https://phabricator.wikimedia.org/T95389#1600665 (10jayvdb) archive.org support Memento (RFC 7089), so if Citeoid can do a HEAD request on the URL, rich metadata can be obtained from the headers. I dont know if there is a Memento client in Node.js, but example code... [02:05:52] Krenair: 'mwTarget' is the parent name of all MW integrations, it's nothing to do with the platform. [02:06:26] Krenair: E.g. Flow should be (but aren't yet) using 'mwTarget' but they'd be a different integration ('flow') and platform would be independent of that. [02:07:13] So theoretically mwTarget would be inherited by mwDesktopTarget which would be implemented by mwDesktopArticleTarget and mwDesktopFlowTarget and … [02:07:16] But meh. [02:08:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1600689 (10Krenair) >`switch` → `abort.switchwith` or `abort.switchwithout` >Have to start distinguishing between the... [02:09:03] Krenair: Yup, they're all abort.switchwithout. [02:09:31] I don't think either makes sense. [02:10:21] switch... without making any changes because then you wouldn't be able to switch at all? [02:10:23] They clicked edit and then switched editors. [02:10:29] They aborted the edit they could have made. [02:10:40] Technically it's abort.switchnochange but that state doesn't exist. :-) [02:11:05] I guess we could add it to the Edit schema as part of removing page.length [02:11:30] (We should also remove page.name or whatever it's called, as it's duplicative.) [02:13:38] Can't we just edit the schema page as much as we want, and then when we think it's good, bump the revision number in each editor? [02:14:47] We can, but I like to have as few edits to it as possible. [02:15:00] And for the current page revision to match what's implemented. [02:15:12] Otherwise it's even more confusing. [03:22:03] 10VisualEditor, 6Discovery, 10MediaWiki-API, 10MediaWiki-Search, and 4 others: Prefix search API doesn't return "index" field when "redirects" is enabled. - https://phabricator.wikimedia.org/T92796#1600796 (10Deskana) >>! In T92796#1599220, @ksmith wrote: > I spoke with @anomie, and while he would prefer a... [03:44:35] 10VisualEditor, 10Wikimedia-Site-Requests, 5WMF-deploy-2015-09-01_(1.26wmf21), 7user-notice: Enable the visual editor in the Wikipedia namespace on the English Wikipedia - https://phabricator.wikimedia.org/T100067#1600820 (10Risker) Okay...please undo this. Contrary to what is suggested above, Wikipedia s... [04:10:20] slightly weird things happen if I paste text from into another [04:13:06] Well, TIL you can nest [04:48:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: "Value null is the wrong type for property "action.saveIntent.timing" (integer expected) " appears upon opening the Save dialog in mobile VE - https://phabricator.wikimedia.org/T109525#1600926 (10Krenair) a:3Krenair [06:24:03] 10VisualEditor: VE adds 10Citoid: Attempt to parse archive.org URLs? - https://phabricator.wikimedia.org/T95389#1601169 (10Mvolz) Thanks @jayvb! If there's no suitable Node library we can build one... We've already done some of that already with different types of metadata ( see http://github.com/wikimedia/html-metadata ) [09:16:13] 10TemplateData, 10VisualEditor: TD editor: proposed parameters already in aliases - https://phabricator.wikimedia.org/T111320#1601341 (10Sunpriat) 3NEW [09:30:43] 10VisualEditor, 7Browser-Support-Internet-Explorer, 7Browser-Support-Microsoft-Edge, 7Technical-Debt: Check if IE hacks are still required in Edge - https://phabricator.wikimedia.org/T111081#1601371 (10Esanders) 3. Opacity bug is **still present** in Edge: http://jsfiddle.net/1p6grjpe/ [09:37:47] 10VisualEditor, 7Browser-Support-Internet-Explorer, 7Browser-Support-Microsoft-Edge, 7Technical-Debt: Check if IE hacks are still required in Edge - https://phabricator.wikimedia.org/T111081#1601372 (10Esanders) [11:15:41] 10VisualEditor: VE adds tags:

or

- https://phabricator.wikimedia.org/T111312#1601816 (10Aklapper) [11:22:23] 10Citoid, 10VisualEditor, 6Community-Liaison: Recurring checks for Citoid's status - https://phabricator.wikimedia.org/T110597#1601832 (10Elitre) All's good. [11:24:38] anybody has ideas re https://phabricator.wikimedia.org/T110597#1593722 ? It's happening for me as well, and obviously can't be reproduced reliably, or I'd check if it's just a problem of that wiki loading slower (maybe longer pages). [13:34:31] James_F|Away, I can reproduce https://phabricator.wikimedia.org/T111230 ATM, but you're away and I don't see matmarex around. [13:39:12] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-Templates: VisualEditor is intermittently failing to load TemplateData for en.wp's [[Template:Citation needed]] (possibly others?) - https://phabricator.wikimedia.org/T111230#1602122 (10Elitre) It's not working for me ATM as well, in both articles and... [14:07:54] 10VisualEditor, 6Editing-Analysis, 6Editing-Department: Investigate why visual editor users have a higher save rate in EventLogging data but didn't in the A/B test - https://phabricator.wikimedia.org/T108241#1602214 (10Halfak) Are you taking these measurements based on the staged deployment to newcomers? Th... [14:08:24] 10VisualEditor, 6Community-Liaison: VisualEditor translathon at Wikimania Mexico - https://phabricator.wikimedia.org/T91108#1602215 (10Elitre) If winners agree, I may share their feedback re: the initiative (attached to a longer slideshow). Will keep you posted. [16:32:43] 10VisualEditor, 3Discovery-Analysis-Sprint: Help requested from an R expert to help tweak phlogiston (burnup chart scripts) - https://phabricator.wikimedia.org/T110080#1602843 (10ksmith) [16:45:35] James_F: going to 100% today for new en.wiki users? [16:48:02] ragesoss: No, happened two days ago. [16:48:16] James_F: awesome, thanks! [16:48:24] and congrats! [16:48:49] ragesoss: Thanks. See https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(proposals)#Enabling_VisualEditor_for_existing_accounts_which_are_dormant_or_inexperienced which may be of interest – enabling VE for existing accounts (other than extremely active ones). [16:49:50] James_F: yes! [17:31:00] (03PS1) 10Esanders: VisualEditorDataModule: remove $msgKeys [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 [17:31:51] 10VisualEditor, 10Wikimedia-Site-Requests, 5WMF-deploy-2015-09-01_(1.26wmf21), 7user-notice: Enable the visual editor in the Wikipedia namespace on the English Wikipedia - https://phabricator.wikimedia.org/T100067#1603315 (10Whatamidoing-WMF) It looks like 41% of the pages in the Wikipedia: namespace at en... [17:34:06] (03CR) 10jenkins-bot: [V: 04-1] VisualEditorDataModule: remove $msgKeys [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 (owner: 10Esanders) [17:43:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1603386 (10Neil_P._Quinn_WMF) [17:44:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1574002 (10Neil_P._Quinn_WMF) [17:44:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1603388 (10Krenair) [17:45:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1603390 (10Neil_P._Quinn_WMF) @Krenair, okay, in that case, it will either be `abort.switchwith` or a value I just add... [17:46:34] 10VisualEditor, 6Editing-Analysis, 7Schema-change: Switch the visual editor to use the version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111420#1603409 (10Neil_P._Quinn_WMF) 3NEW [17:47:38] 10VisualEditor, 6Editing-Analysis, 7Schema-change: Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1603418 (10Neil_P._Quinn_WMF) 3NEW [17:49:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1603425 (10Neil_P._Quinn_WMF) [17:52:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1603430 (10Neil_P._Quinn_WMF) [17:52:09] 10VisualEditor, 6Editing-Analysis: Switch the visual editor to use the version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111420#1603434 (10Krenair) [17:52:15] 10VisualEditor, 6Editing-Analysis: Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1603436 (10Krenair) [17:52:47] neilpquinn, schema-change is for database schema changes, i.e. add/remove x column to/from y table in production [17:53:08] they require manual sysadmin work, usually from an actual DBA in ops [17:53:21] EventLogging schema stuff is automatic AFAIK [17:53:42] Krenair: okay, cool. I'll take that off. [17:53:50] I already did :P [17:54:07] Haha, thanks. [17:54:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use the Edit schema insted of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1603442 (10Neil_P._Quinn_WMF) [18:40:16] Hi, one small question on translating TemplateData for the new reference dialog in VE ... is there someone knowledgeable? :) [18:52:33] 10Citoid: Attempt to parse archive.org URLs? - https://phabricator.wikimedia.org/T95389#1603625 (10Ocaasi) [18:58:31] 10VisualEditor, 10Wikimedia-Site-Requests, 5WMF-deploy-2015-09-01_(1.26wmf21): Enable the visual editor in the Wikipedia namespace on the English Wikipedia - https://phabricator.wikimedia.org/T100067#1603630 (10Johan) [18:58:47] 10VisualEditor, 10Wikimedia-Site-Requests, 5WMF-deploy-2015-09-01_(1.26wmf21), 7notice: Re-enable VisualEditor by default for all newly-created accounts on the English Wikipedia - https://phabricator.wikimedia.org/T90664#1603631 (10Johan) [19:22:55] Czech citation templates only include three author names, if there are more, we write "et al." after the third. is it possible to do? [19:23:14] (in autofill templates i am just adapting for VE) [19:43:46] (03PS29) 10Divec: Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [19:44:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10MobileFrontend: Instrument MobileFrontend to use version 13457736 of the Edit schema instead of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1603783 (10Jdforrester-WMF) [19:45:22] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Switch the visual editor to use the version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111420#1603786 (10Jdforrester-WMF) p:5Triage>3Normal [19:45:32] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1603789 (10Jdforrester-WMF) p:5Triage>3Normal [19:46:01] (03CR) 10jenkins-bot: [V: 04-1] Explicitly enter/exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [19:46:23] 10TemplateData, 10VisualEditor: Don't propose parameters which are just used as aliases instead - https://phabricator.wikimedia.org/T111320#1603797 (10Jdforrester-WMF) p:5Triage>3Low [19:47:05] (03PS22) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [19:47:20] well this was helpful [19:48:02] (03PS19) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [19:49:09] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [19:50:08] (03CR) 10jenkins-bot: [V: 04-1] Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 (owner: 10Divec) [20:06:55] 10VisualEditor: If the user types or pastes a DOI, auto-link it to the relevant dx.doi.org page - https://phabricator.wikimedia.org/T111442#1603885 (10Jdforrester-WMF) 3NEW [20:07:00] 10VisualEditor: If the user types or pastes a DOI, auto-link it to the relevant dx.doi.org page - https://phabricator.wikimedia.org/T111442#1603892 (10Jdforrester-WMF) [20:09:21] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 10MobileFrontend: Instrument MobileFrontend to use version 13457736 of the Edit schema instead of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1603909 (10Neil_P._Quinn_WMF) [20:42:35] (03PS2) 10Alex Monk: VisualEditorDataModule: remove $msgKeys [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 (owner: 10Esanders) [20:43:42] (03CR) 10Alex Monk: [C: 032] VisualEditorDataModule: remove $msgKeys [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 (owner: 10Esanders) [20:44:49] anyone knows about this jshint error? 'setLoadingProgress' was used before it was defined. [20:45:20] (03CR) 10jenkins-bot: [V: 04-1] VisualEditorDataModule: remove $msgKeys [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 (owner: 10Esanders) [20:48:19] InezK: New breaking change in jshint. [20:48:24] InezK: We need to fix it. [20:48:44] Ok, in jshint processor itself? [20:48:48] or in your configuration? [20:50:02] grunt-contrib-jshint silently upgraded from jshint 2.8 to 2.9. [20:50:07] 2.9 has some new rules. [20:50:13] (Ordering of JS.) [20:50:15] We'll fix it. [21:01:47] (03CR) 10Krinkle: [C: 032] "I removed use of 'keys' in 2e050ff4981b1a. It existed to populate getMessages() which would automatically invalidate the module if one of " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 (owner: 10Esanders) [21:02:36] James_F: It doesn't have new rules, it improved a rule that already existed (and we enabled it in our jshintrc) [21:02:41] Declaring functions before use [21:02:55] It previously didn't pick up function declarations, only function expressions and variables. [21:03:26] Yeah, grunt-contrib-jshint got sick of being a blocker to having to update JSHint for every release so they pinned to 2.x effectiely relying on semver [21:03:51] InezK: ^ [21:04:26] InezK: Upgrade to grunt-contrib-jshint 0.11.3 to go back to JSHint 2.8 [21:04:53] 0.11.2 uses ^2.8.0 instead of ~2.8.0. ^ allows minor versions, ~ allows patches only [21:04:54] Krinkle: Helpful. [21:05:03] Krinkle: Can we do that? [21:07:12] 10VisualEditor, 10Wikimedia-Site-Requests, 5WMF-deploy-2015-09-01_(1.26wmf21): Enable the visual editor in the Wikipedia namespace on the English Wikipedia - https://phabricator.wikimedia.org/T100067#1604224 (10TheDJ) Either disable, or at least make it conditional on the presence of __NEWSECTIONLINK__ ? [21:07:45] James_F: Sure [21:08:05] (03CR) 10jenkins-bot: [V: 04-1] VisualEditorDataModule: remove $msgKeys [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 (owner: 10Esanders) [21:08:10] Krinkle: thanks for info [21:08:17] Krinkle: Didn't 0.11.2 -> 0.11.3 have an issue we had to revert? [21:08:22] No [21:08:27] Krinkle: Or am I thinking of a different devDependency? [21:08:28] 0.11.3 was released 20 minutes ago [21:08:34] Ha OK. [21:08:44] Specifically for this purpose [21:08:48] Whoops. [21:08:53] OK, mass run coming. [21:08:53] It changes deps ^2.8.0 to ~2.8.0 [21:09:05] Have you done it for any repos yet? [21:09:09] mediawiki-core [21:09:15] By... wait for it... Paladox [21:09:19] And I merged it! [21:09:21] And I liked it! [21:09:22] :P [21:10:34] (03PS1) 10Jforrester: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235869 [21:11:07] (03PS1) 10Jforrester: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235870 [21:11:12] Krinkle: Gosh. [21:11:18] Krinkle, James_F: Don't you want to change the code, so it actually passed the check? [21:11:21] *passes [21:11:26] (03CR) 10Paladox: [C: 031] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235869 (owner: 10Jforrester) [21:11:27] InezK: Later. [21:12:14] Krinkle: Have we also changed the default jenkins one? [21:12:44] InezK: The error we saw in VE was genuine. But there are also bad ones. in mediawiki-core it added a warning that was a false positive. 2.9.0 has bugs. I've filed them upstream [21:12:59] https://github.com/jshint/jshint/issues [21:13:08] https://github.com/jshint/jshint/issues/2656 [21:13:11] at least three regressions [21:13:53] This is the first time Grunt is trying auto-update for jshint, and we immediately see the impact of 1000s of open source projects getting a new jshint version on the day of release unannounced. [21:13:58] Good bug reports at least :) [21:14:45] (03CR) 10Krinkle: [C: 032] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235869 (owner: 10Jforrester) [21:15:06] Well, we already knew what that looked like from the time jshint made a breaking change in a patch release :P [21:15:20] RoanKattouw: ha, yeah [21:18:27] 10VisualEditor, 3Discovery-Analysis-Sprint, 3Team-Practices-This-Week: Help requested from an R expert to help tweak phlogiston (burnup chart scripts) - https://phabricator.wikimedia.org/T110080#1604304 (10ksmith) [21:21:05] (03CR) 10Krinkle: [C: 032] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235870 (owner: 10Jforrester) [21:21:38] (03PS1) 10Jforrester: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/235881 [21:21:44] (03Merged) 10jenkins-bot: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235869 (owner: 10Jforrester) [21:27:53] (03PS1) 10Jforrester: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/235889 [21:28:39] (03Merged) 10jenkins-bot: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235870 (owner: 10Jforrester) [21:29:52] (03PS3) 10Krinkle: VisualEditorDataModule: remove $msgKeys [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 (owner: 10Esanders) [21:30:04] 10VisualEditor: Improve quality of Python code in Phlogiston - https://phabricator.wikimedia.org/T110977#1604370 (10JAufrecht) [21:30:17] 10VisualEditor: Show master burnup in Phlogiston with interrupt removed or below the axis - https://phabricator.wikimedia.org/T110085#1604373 (10JAufrecht) [21:30:48] 10VisualEditor: Generate master burnup in Phlogiston that accurately communicates backlog, burnup, and maintenance fraction trends and status. - https://phabricator.wikimedia.org/T110085#1568498 (10JAufrecht) [21:32:59] 10VisualEditor: Create third version of VE burnup report - https://phabricator.wikimedia.org/T107482#1604397 (10JAufrecht) All work either done or moved to subtask, but not sure if it should be Resolved since that would suggest that the 40 points of work was done. [21:37:19] (03CR) 10Alex Monk: [C: 032] VisualEditorDataModule: remove $msgKeys [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 (owner: 10Esanders) [21:39:31] (03PS1) 10Divec: Declare functions before use in ve.demo.init.js [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235895 [21:44:17] (03CR) 10Divec: "I believe this is the simplest consistent way to fix the jshint error that is currently blocking every commit." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235895 (owner: 10Divec) [21:45:29] Can someone review https://gerrit.wikimedia.org/r/235895/ , which unblocks the CI failure? [21:46:20] (03Merged) 10jenkins-bot: VisualEditorDataModule: remove $msgKeys [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/235767 (owner: 10Esanders) [21:46:43] divec_, I think Krinkle just did it [21:47:05] I'm not quite sure how that commit would help [21:48:34] Krenair: jshint 2.9.0 fixed a bug in how latedef antirule works. It used to not pick up on certain types of functions. [21:48:51] grunt-contrib-jshint depended on ^2.8.0 which auto-updates until <3.0 [21:49:38] (03CR) 10Krinkle: [C: 04-1] "This worksaround the issue instead of fixing it. Understandable since it was breaking master, but we've resolved the jshint issue since by" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235895 (owner: 10Divec) [21:51:03] (03CR) 10Divec: "Oh - good :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235895 (owner: 10Divec) [21:56:35] (03PS30) 10Divec: Explicitly enter and exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [21:59:57] (03CR) 10jenkins-bot: [V: 04-1] Explicitly enter and exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [22:02:40] (03PS4) 10Divec: Don't call setInsertionAnnotations on handleInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/235054 (https://phabricator.wikimedia.org/T111047) [22:03:18] (03PS31) 10Divec: Explicitly enter and exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) [22:04:10] (03PS23) 10Divec: ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 [22:04:37] (03PS20) 10Divec: Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 [22:06:43] (03CR) 10jenkins-bot: [V: 04-1] Explicitly enter and exit link annotations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/217257 (https://phabricator.wikimedia.org/T91285) (owner: 10Divec) [22:07:26] (03CR) 10jenkins-bot: [V: 04-1] ve.ce.adjustLinkSelection: fixup link-bisecting selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222488 (owner: 10Divec) [22:08:54] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis, 10MobileFrontend: Instrument MobileFrontend to use version 13457736 of the Edit schema instead of the MobileWebEditing schema - https://phabricator.wikimedia.org/T110272#1604539 (10Krenair) ```mysql> select count(*) from MobileWebEditing_8599025... [22:09:37] (03CR) 10jenkins-bot: [V: 04-1] Fixup link selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/222619 (owner: 10Divec) [22:16:26] (03CR) 10Krinkle: [C: 032] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/235889 (owner: 10Jforrester) [22:16:31] (03CR) 10Krinkle: [C: 032] build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/235881 (owner: 10Jforrester) [22:17:38] (03Merged) 10jenkins-bot: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/235889 (owner: 10Jforrester) [22:17:49] (03Merged) 10jenkins-bot: build: Bump grunt-contrib-jshint from 0.11.2 to 0.11.3 to fix upstream issue [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/235881 (owner: 10Jforrester) [22:20:33] edsanders|away: you around? https://gerrit.wikimedia.org/r/#/c/218620/ broke my gadget. how do i "beat" TranclusionNodes when matching again? [22:20:38] Uh... Hm. [22:20:44] * @cfg {Number} defaults.pageId The value of the wgArticleId config variable [22:20:51] pageId needs changing to 'page.id' [22:21:29] but... wouldn't mean you have an object called defaults.page with an 'id' key? [22:21:56] not sure about the proper way to document that [22:24:58] hmm. or maybe that's not the problem i'm having. hmmmmm. [22:26:15] 10VisualEditor, 10VisualEditor-Tables: Cannot scroll down when editing long tables - https://phabricator.wikimedia.org/T76891#1604645 (10EBernhardson) 5Open>3Resolved a:3EBernhardson Tried editing a table today, this is no longer happening. [22:30:32] 10VisualEditor, 6Analytics-Backlog, 10Analytics-Dashiki, 6Editing-Analysis, 6Research-and-Data: Start generating a visual editor adoption metric - https://phabricator.wikimedia.org/T109158#1604667 (10Halfak) I think I need a better notion of what is meant/desired by "adoption" before I can comment effect... [22:33:44] Krinkle, please see my messages above ^ [22:34:20] Krenair: I did. [22:34:29] Krenair: Not sure I follow. What are you running into? [22:34:40] * @cfg {Object} defaults Default options hash. [22:34:58] Need to name one of the keys with a . in it [22:35:05] Mobile? [22:35:17] How'd you guess? :p [22:35:31] Phrasing and var naming [22:35:41] also [22:35:41] https://github.com/search?q=%22defaults+Default+options+hash%22+%40wikimedia&type=Code [22:36:06] But I think defaults.page.id would mean you have defaults = { page: { id: 123 } } [22:36:08] yeah, you can define multiple objects if you need [22:36:15] Krenair: yes. [22:36:15] I have defaults = { 'page.id': 123 } [22:36:20] Don't do that [22:36:36] That's not a valid identifier [22:36:45] you wouldn't be able to access it in dot notation [22:37:01] nor camelCase [22:37:11] I don't think I get to choose the name at this point. [22:37:20] If this is about Schema:Edit, then you will need a key like that [22:37:20] It's part of an eventlogging schema [22:37:24] yes [22:37:27] And you'll just have to use blah['page.id'] [22:37:41] That's what all of that code does, because it's responsible for delivering those exact field names to EL [22:38:02] And you're documenting the whole object as a parameter? [22:39:12] Event objects should be declaring in a single place (not composed from other objects) to avoid mistakes and to reflect the fact that it isn't flexible (it follows a schema). I'd use pageId internally and only use 'page.id' in the code that adds it to the object (object literal or property set) [22:39:25] so you wouldn't have it as parameter in your own code [22:39:41] https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/resources/mobile.loggingSchemas/SchemaMobileWebEditing.js#L17 [22:40:01] We are moving MobileFrontend from using Schema:MobileWebEditing to using Schema:Edit [22:40:34] this kind of abstraction seems like a bad idea [22:40:44] 'pageId' in MobileWebEditing = 'page.id' in Edit [22:40:49] Yeah [22:41:02] I wasn't planning on rewriting the MobileFrontend Schema system for this, Krinkle. [22:41:16] I understand, but I can't help you. [22:41:29] Perhaps not document it then, and just point to Schema:Edit url [22:41:49] JSDuck is very strict about this, there is no other way [22:42:35] JSDuck refuses to make support everything JavaScript supports to discourage "stupid" things. [22:43:12] Could use page_id as work around, we do that in MediaWIki core for "wikipage.content" events and mw.notification/mw.Notification [22:44:41] 10VisualEditor, 10Wikimedia-Site-Requests, 5WMF-deploy-2015-09-01_(1.26wmf21): Enable the visual editor in the Wikipedia namespace on the English Wikipedia - https://phabricator.wikimedia.org/T100067#1604700 (10matmarex) >>! In T100067#1600820, @Risker wrote: > Okay...please undo this. Contrary to what is s... [22:44:58] okay, my problem was this: https://meta.wikimedia.org/w/index.php?title=User:Matma_Rex/visualeditor-signature.js&diff=13461327&oldid=13312496 [22:54:34] Krinkle: I'm working with DesktopArticleTarget.init [22:54:45] It's very "promisy"... I think you were touching it ;) [23:35:53] 10VisualEditor, 6Analytics-Backlog, 10Analytics-Dashiki, 6Editing-Analysis, 5Patch-For-Review: Improve the edit analysis dashboard {lion} - https://phabricator.wikimedia.org/T104261#1604805 (10Neil_P._Quinn_WMF) p:5High>3Normal [23:41:29] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Switch the wikitext editor to use version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111421#1604831 (10Neil_P._Quinn_WMF) [23:42:06] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Switch the visual editor to use the version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111420#1604833 (10Neil_P._Quinn_WMF) [23:48:15] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Switch the visual editor to use the version 13457736 of the Edit schema - https://phabricator.wikimedia.org/T111420#1604864 (10Neil_P._Quinn_WMF) [23:50:06] 10VisualEditor, 6Analytics-Backlog, 10Analytics-Dashiki, 6Editing-Analysis, 6Research-and-Data: Start generating a visual editor adoption metric - https://phabricator.wikimedia.org/T109158#1604878 (10Neil_P._Quinn_WMF) p:5High>3Normal [23:51:29] 10VisualEditor, 6Editing-Analysis: Provide VE-related data for the Galician Wikipedia - https://phabricator.wikimedia.org/T86944#1604895 (10Neil_P._Quinn_WMF) p:5Normal>3Low [23:54:01] 10VisualEditor, 6Editing-Analysis, 6Editing-Department: Define metrics for the VisualEditor team - https://phabricator.wikimedia.org/T107351#1604906 (10Neil_P._Quinn_WMF) p:5High>3Normal