[00:02:11] ugh, hadn't even thought about the section edit buttons [00:02:25] I guess since we aren't unifying those... they can stay [00:02:37] James_F, I don't think so [00:02:41] We aren't? [00:03:03] they're not tabs [00:03:16] Not literally, sure. [00:03:25] James, please don't tell me at this stage that you want to add yet another thing into this. [00:04:33] I can write it. [00:04:43] the code? [00:04:47] Sure. [00:04:57] I wrote most of the bad code in ve-init-init. [00:05:00] That's why it's bad. [00:07:07] ooh, hang on [00:07:13] I had done some messing with those links [00:07:48] We do leave them as one link when VisualEditorUseSingleEditTab is true and the user hasn't specified the multi-tab preference [00:07:54] I wonder if it actually works or just breaks horribly [00:07:57] * James_F nods. [00:08:03] Certainly untested [00:08:30] I was hoping to help with some of the TODOs but I never know when you're not mid-edit and would break it. :-( [00:09:23] like detecting incompatibility and looking at params we check for to rule out VE? [00:09:29] we should check* [00:09:49] Yeah. [00:09:57] Detecting incompatibility should be easy. [00:10:03] He says. [00:10:07] Famous last words [00:10:13] Indeed. :-) [00:10:36] The thing I hate about this code is that we're covering for a ton of different cases [00:11:14] Yeah. [00:11:21] Loads of different combinations of "Can the user load VE at all if they want to?", "Has the user opted into VE?", "Can VE load on this page at all?", etc. etc. etc. [00:11:24] The ambition is to use this code as the way to kill things off. [00:12:02] Once single-edit-tab is live everywhere, we'll kill visualeditor-betatempdisable and visualeditor-autodisable and instead migrate them to visualeditor-editor=prefer-wt [00:12:02] (03PS6) 10DLynch: Limit the height of desktop-context popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/254195 (https://phabricator.wikimedia.org/T114614) [00:12:09] Etc. [00:13:17] I kind of want to see what we need to get section editing working at some point [00:13:48] That's the 'experiment' goal for Q3. [00:14:01] and whether that's something I can do on the MW side, or if it'd be blocked on services/parsoid [00:15:31] ugh, that last PS broke things [00:15:40] For incompatibility, /theoretically/ we just need to run UA through a PHP version of the no-JS stuff ("Grade C") and against VisualEditorBrowserBlacklist and we're done. [00:17:32] $this->getRequest()->getHeader( 'User-agent' ) is the source. [00:17:47] Krenair: Want me to write some crap in a gist? [00:17:54] yes please [00:17:57] Kk. [00:18:00] that'd be very helpful [00:31:42] (03PS32) 10Alex Monk: [WIP] Single edit tab [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) [00:47:38] Meh. [00:48:14] Krenair: https://phabricator.wikimedia.org/P2373 [00:48:14] that PS changed it to use a class on the edit tab [00:48:28] I wrote it as a proper get-from-config. [00:48:33] need to change the client code that actually opens the dialog to run in the wikitext editor [00:48:44] But then I gave up because each RegEx needs to be manually tweaked per browser. [00:48:52] with a bunch of weird changes to the dialog code, like we had to do with the WT->VE switch dialog [00:49:10] We can make it tech debt to add this to MW-core, which ori suggested as a way to do things 'easily' a couple of months ago. [00:49:17] * James_F nods. [00:50:42] I'll look at integrating that code after I'm done with dialogs [00:50:48] Cool. [00:51:03] Worth double-checking it works, though it's mostly just a re-typed version of the JS code. [00:52:15] yeah [00:52:18] will do that [00:52:21] + uri.query.veswitched === undefined && // TODO: other params too? [00:52:52] Which other params? `vesection` can't work… `debug` shouldn't be used… [00:53:13] Because this commit involves loading VE on action=edit page load, we need to detect several cases where VE won't be able to do what the wikitext editor does on that action [00:53:43] e.g. preloading templates [00:53:45] Oh, like preload and editintro and all that stuff? [00:53:48] yep [00:53:49] * James_F nods. [00:54:57] Am going to attempt to attend standup tomorrow [00:55:00] Emphasis on attempt [00:55:35] Had a video call with a family member earlier and it worked well enough on the third try [00:55:56] * Krenair goes afk for a bit [00:56:10] Yay. [03:08:27] 10VisualEditor, 10Graph: Migrate ext.graph.VisualEditor to Vega 2 - https://phabricator.wikimedia.org/T120319#1851347 (10ferdbold) @Krenair I was talking about a graph edit specifically. If the user opens the graph dialog of a graph made with Vega 1, the tool should automagically convert it to Vega 2. Of cour... [03:17:29] (03CR) 10Esanders: [C: 032] Limit the height of desktop-context popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/254195 (https://phabricator.wikimedia.org/T114614) (owner: 10DLynch) [03:21:31] (03Merged) 10jenkins-bot: Limit the height of desktop-context popups [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/254195 (https://phabricator.wikimedia.org/T114614) (owner: 10DLynch) [03:27:01] (03PS1) 10Jforrester: Update VE core submodule to master (df9f41d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256888 [03:29:04] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (df9f41d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256888 (owner: 10Jforrester) [03:30:05] Oh, yeah, will need to change the deletion tests. [03:30:41] (03CR) 10Jforrester: "todo: adjust the tests in mw so this merges. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256888 (owner: 10Jforrester) [03:31:21] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 7Design, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Maximum height of the link editor should take into account the toolbar height too - https://phabricator.wikimedia.org/T114614#1851394 (10Jdforrester-WMF) 5Open>3Resolved [04:53:37] 10VisualEditor, 10Parsoid, 10Wikidata, 10Wikidata-Page-Banner: Parsoid has no special handling for the properties set by WikidataPageBanner - https://phabricator.wikimedia.org/T107941#1851481 (10ssastry) [07:58:38] 10Cite, 10MediaWiki-extensions-ContentTranslation, 7Tracking: ContentTranslation issues with references (tracking) - https://phabricator.wikimedia.org/T115045#1851691 (10Nemo_bis) [11:32:11] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: After selecting table cell by single clicking, typing with any IME does not work - https://phabricator.wikimedia.org/T86589#1851919 (10dchan) The problem as it affects VE amounts to doing blur();focus() in a compositionstart list... [12:42:31] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-ContentLanguage: After selecting table cell by single clicking, typing with any IME does not work - https://phabricator.wikimedia.org/T86589#1852055 (10dchan) See also https://bugzilla.mozilla.org/show_bug.cgi?id=1230520 and http://jsfiddle.net/r... [15:06:54] (03CR) 10Esanders: "Looking pretty good." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) (owner: 10Alex Monk) [15:09:03] 10Cite, 7JavaScript, 7Regression: Reference tooltips broken - https://phabricator.wikimedia.org/T120374#1852325 (10TheDJ) 3NEW [15:11:26] 10Cite, 7JavaScript, 7Regression: Reference tooltips broken - https://phabricator.wikimedia.org/T120374#1852341 (10matmarex) I think it always worked this way when the reference was visible on-screen. Also, I think this is still a gadget. :D [15:13:50] 10Cite, 7JavaScript, 7Regression: Reference tooltips broken - https://phabricator.wikimedia.org/T120374#1852344 (10TheDJ) 5Open>3Invalid a:3TheDJ Nvmd, you are right. I just never use this feature on such a large screen :) [15:48:58] 10VisualEditor, 10Math: Make math dialog optional - https://phabricator.wikimedia.org/T120382#1852436 (10Tchanders) 3NEW a:3Tchanders [15:50:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1852454 (10Tchanders) [15:50:21] 10VisualEditor, 10Math: Make math dialog optional - https://phabricator.wikimedia.org/T120382#1852455 (10Tchanders) [17:50:13] 5up3r53kr!7 [17:50:34] Dangit, now I have to change this computer's password. [17:52:36] (For the first time ever, I feel rewarded for having unique passwords for all my computers!) [17:55:55] you typed your password and it went into IRC? [17:56:58] I was quickly switching between two computers, and I assumed-without-paying-attention that I'd been away from this one long enough for it to lock. Typing without looking at the screen is clearly a bad idea. [17:57:33] hah, yep [18:04:06] Kemayo: Ha. [18:42:36] yeah, that way i recently accidently almost typed my work computer's password into a skype session... but the screen was just dimmed, not yet locked (both on 5 minute timers, but apparently i managed to hit a sweetspot) [18:55:51] Kemayo: Hmm. Have you seen the unit test failures in MW with https://gerrit.wikimedia.org/r/#/c/256888/ (i.e., with your changes to forward-delete)? I can't determine quickly whether the changed behaviour is fine or something we should worry about. [18:57:02] I haven't. I'll take a look after I get back from lunch. [19:17:14] Okay, in "Backspace in a list next to a block image doesn't merge into the caption" [19:17:45] Yeah. [19:18:48] We had backspace from `

Foo

Bar

|

` put the cursor right of Bar and not select the figure. [19:23:30] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Newlines after bolded text in tables lost on save - https://phabricator.wikimedia.org/T104032#1853032 (10Esanders) Minimal failing test case for Parsoid: ```
Foo

bar

``` -> ``` {| |'''Foo'''bar |} ``` [19:25:48] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Newlines after bolded text in tables lost on save - https://phabricator.wikimedia.org/T104032#1853041 (10Esanders) Interestingly if a newline character is inserted between and

in the HTML the bug goes away. [19:31:35] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Newlines after bolded text in tables lost on save - https://phabricator.wikimedia.org/T104032#1853060 (10ssastry) Must be some broken newline constraint in the serializer .. or at least an unhandled edge case. [19:40:38] 10WikiEditor: WikiEditor's CSS hiding of editHelp and the pipe separator throws a flash of unstyled content - https://phabricator.wikimedia.org/T120408#1853093 (10Jdforrester-WMF) 3NEW [19:47:29] James_F: I think the changed behavior isn't harmful, per-se. But it'd be more consistent with the behavior at the start/end of the document if it remained how it was before. [19:47:49] OK. [19:49:34] I'll make an actual ve test case for it, since the existing ones only cover the start/end of the document. [19:52:23] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Newlines after bolded text in tables lost on save - https://phabricator.wikimedia.org/T104032#1853130 (10ssastry) This is a more general issue: ``` [subbu@earth bin] echo 'Foo

bar

' | node parse --html2wt '''Foo'''bar ``` With --debug wts, we see... [19:58:34] (03PS1) 10Esanders: Use wgNamespaceIds constants instead of hard-coded numbers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256970 [19:59:07] (03CR) 10Jforrester: [C: 032] Use wgNamespaceIds constants instead of hard-coded numbers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256970 (owner: 10Esanders) [20:02:17] (03Merged) 10jenkins-bot: Use wgNamespaceIds constants instead of hard-coded numbers [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/256970 (owner: 10Esanders) [20:42:03] 10VisualEditor, 10WikiEditor, 6Editing-Department, 10MediaWiki-Page-editing, and 3 others: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#1853488 (10Jdforrester-WMF) 3NEW [20:42:51] 10VisualEditor, 10WikiEditor, 6Editing-Department, 10MediaWiki-Page-editing, and 3 others: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#1853498 (10Jdforrester-WMF) [21:25:05] 10VisualEditor, 10Graph, 7Epic, 7Milestone: [Objective] It's easier to create and edit charts from within VisualEditor - https://phabricator.wikimedia.org/T119233#1853703 (10Jdforrester-WMF) [21:25:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 7Epic, 7Milestone: [Objective] Improve support for math editing by improving the UX of the Math extension and researching its usability - https://phabricator.wikimedia.org/T118616#1853704 (10Jdforrester-WMF) [21:26:44] 10VisualEditor, 10Wikimedia-Site-Requests, 7Milestone, 5Patch-For-Review, and 2 others: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#1853705 (10Jdforrester-WMF) [21:27:15] 10VisualEditor, 10VisualEditor-MediaWiki, 7Design, 7Epic: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#1853707 (10Jdforrester-WMF) [21:27:18] 10VisualEditor, 10Wikimedia-Site-Requests, 7Milestone, 5Patch-For-Review, and 2 others: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#1064321 (10Jdforrester-WMF) [21:27:56] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Run experiment defaulting anonymous editors to the visual editor on the English Wikipedia - https://phabricator.wikimedia.org/T119269#1853710 (10Jdforrester-WMF) p:5Triage>3Normal [21:28:06] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Run experiment defaulting anonymous editors to the visual editor on the English Wikipedia - https://phabricator.wikimedia.org/T119269#1822373 (10Jdforrester-WMF) [21:28:08] 10VisualEditor, 10Wikimedia-Site-Requests, 7Milestone, 5Patch-For-Review, and 2 others: Re-enable VisualEditor by default for all logged-out users of the English Wikipedia - https://phabricator.wikimedia.org/T90663#1064321 (10Jdforrester-WMF) [21:36:25] 10VisualEditor, 10Graph: Migrate ext.graph.VisualEditor to Vega 2 - https://phabricator.wikimedia.org/T120319#1853755 (10Jdforrester-WMF) >>! In T120319#1851347, @ferdbold wrote: > @Krenair I was talking about a graph edit specifically. If the user opens the graph dialog of a graph made with Vega 1, the tool s... [21:36:48] 10VisualEditor, 10Graph: Migrate graphs from Vega 1 to Vega 2 syntax on edit with VE - https://phabricator.wikimedia.org/T120319#1853759 (10Jdforrester-WMF) [21:45:23] (03PS1) 10Florianschmidtwelzow: Follow up change for EditPage::getCheckboxes() in mediawiki core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/257005 [21:45:54] Hmm. [21:58:52] (03PS33) 10Alex Monk: [WIP] Single edit tab and section links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) [21:58:57] edsanders, you're fully testing this against all of the items on the task right? [22:00:36] aiming to [22:06:33] 10VisualEditor, 10MediaWiki-extensions-RelatedArticles: RelatedArticles conflicts with VisualEditor - https://phabricator.wikimedia.org/T120443#1853969 (10Florian) 3NEW [22:16:12] 10VisualEditor, 10MediaWiki-extensions-RelatedArticles: RelatedArticles conflicts with VisualEditor - https://phabricator.wikimedia.org/T120443#1854041 (10Jdforrester-WMF) Oops. Normally code like this inserts into the contentSub which VE carefully removes, but that doesn't exist in Minerva so "just do that" m... [22:16:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-RelatedArticles: RelatedArticles conflicts with VisualEditor - https://phabricator.wikimedia.org/T120443#1854042 (10Jdforrester-WMF) [22:37:00] 10VisualEditor, 10Flow, 3Collaboration-Team-Current, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1854214 (10Catrope) I reproduced the curl error locally, and it was caused by... [22:55:35] Grr. Why is MW claiming to save my preferences, and then not [23:04:39] Krenair: A hook returning false? [23:05:34] No, difference between 1 and true James_F [23:05:44] Because true is 0 and 1 is "1" [23:05:47] Naturally [23:05:52] Oh, fun. [23:05:56] Yeah, MW is so sucky. [23:09:14] (03PS34) 10Alex Monk: [WIP] Single edit tab and section links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/248369 (https://phabricator.wikimedia.org/T58337) [23:16:08] I think I also need to: [23:16:11] * rename cookie per ori [23:16:50] * replace text with the text you wrote [23:17:03] in addition to the TODO lists in the commit message and the individual TODO entries in the code [23:17:06] list* [23:17:15] Clearly I need a list of lists [23:18:07] Eventually, something like this will happen: https://en.wikipedia.org/wiki/List_of_lists_of_lists [23:20:12] (03PS1) 10Catrope: Fix JS error when unselected GeneratedContentNode rerenders [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/257025 (https://phabricator.wikimedia.org/T119773) [23:25:53] 10VisualEditor, 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1854339 (10Catrope) a:3Catrope [23:26:29] 10VisualEditor, 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1835424 (10Catrope) p:5Unbreak!>3Triage [23:26:37] 10VisualEditor, 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1835424 (10Catrope) p:5Unbreak!>3Triage [23:26:43] 10VisualEditor, 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1835424 (10Catrope) p:5Unbreak!>3Triage [23:27:36] 10VisualEditor, 10Flow, 3Collaboration-Team-Current, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1835424 (10Catrope) p:5Triage>3Unbreak! [23:30:20] gj phabricator [23:32:03] Krenair: I'm going to blame RoanKattouw's use of Firefox, but yes. [23:39:27] [19:42:34] ori: Aha. OK. What about `ed` (short for 'preferred editor')? Krenair ^^^ [23:39:37] Krenair: Yeah. [23:39:38] ed is short for preferred editor? [23:39:42] Very short. :-) [23:40:21] I think I'm going with VEE [23:40:44] That's one character longer. [23:41:35] Let's call it e then? [23:42:01] Sure, but might be a bit too gnomic [23:42:02] ? [23:42:04] * James_F shrugs. [23:42:15] (That wasn't a 100% serious suggestion) [23:42:46] :_) [23:50:49] "Always give me the visual editor if possible" [23:50:52] if -> where? [23:54:07] I wanted it to be shorter. [23:54:21] * James_F is difficult. [23:56:59] k