[00:16:18] Not sure if this is known thing or not. I was editing a section on mw.o when the config change hit to consolidate edit tabs. On preview I got the pop-up for picking how the edit tab should behave. I picked "both" but was landed into VE editing just the section. When I switched to wikitext edit it was proposing to blank the rest of the page and only leave the section I had open for edits previously. [00:17:29] bd808: Yeah, sorry about that, it's an RL caching issue we can't really fix. :-( [00:17:54] no worries. I handled it. The page blanking attempt was yucky though [00:17:54] bd808: For normal wikis we try to swap their configuration at their down time; for MW.org that doesn't really exist. [00:17:59] Yeah. :-( [00:18:12] is this because of the change in preferences? [00:18:28] Krenair: Yeah. I managed briefly to get two "Edit source" tabs. [00:18:39] preferences cached in RL and the actual preferences on the server = stuff will break [00:18:44] server not matching* [00:19:01] Each time we change the config it's a risk. Goes away in a few seconds though. [00:19:05] It mostly seemed to get confused about if I was doing a page edit or a section edit [00:19:19] * James_F nods. [00:19:19] Top tip: Don't change these preferences unless the pain is worth it. [00:19:20] it does sound like there may be a bug in there though [00:20:10] although... [00:20:27] the pref changing was probably the trigger for that I'd guess. section edit in text editor -> change backend default -> preview -> confusion [00:20:32] bd808, so you picked preview, and VE loaded behind the pref dialog? [00:20:42] yeah [00:20:53] but VE loaded just the section? [00:20:59] *nod* [00:21:01] VE should never load with just a section... [00:27:35] 10VisualEditor, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2078324 (10Jdforrester-WMF) [00:33:55] 10VisualEditor, 10VisualEditor-Links, 13Patch-For-Review: Moving focus from a link to a focusable node doesn't hide the cartouche - https://phabricator.wikimedia.org/T114912#2078337 (10Jdforrester-WMF) a:5dchan>3DLynch [00:34:21] (03CR) 10Jforrester: [C: 032] CategoryWidget: Remove reorder event fix after upstream fix [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273383 (owner: 10Esanders) [00:37:06] (03PS1) 10Jforrester: Update VE core submodule to master (6b85afc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274320 [00:38:46] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 7Design, 7Technical-Debt: Alas, alack, won't someone rid me of this grievous PNG? - https://phabricator.wikimedia.org/T128542#2078349 (10Jdforrester-WMF) [00:57:00] James_F, dewiki autodisable preference script has started [00:57:42] Krenair: Awesome. Thank you. :-) [00:58:55] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 10Internet-Archive: VisualEditor automatic citation tool wrongly escapes url and title (breaks url) - https://phabricator.wikimedia.org/T128544#2078414 (10Krinkle) [00:58:58] Filed ^ [00:59:51] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 10Internet-Archive: VisualEditor automatic citation tool breaks url escaping and mangles title - https://phabricator.wikimedia.org/T128544#2078427 (10Krinkle) [01:02:06] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki, 10Internet-Archive: VisualEditor automatic citation tool breaks url escaping and mangles title - https://phabricator.wikimedia.org/T128544#2078432 (10Jdforrester-WMF) p:5Triage>3High [01:03:12] So it's been going for 10 minutes and has done 12k [01:03:31] I'm guessing about 12 hours total [01:07:55] so many emails... :S [01:28:24] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia, 13Patch-For-Review: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#2078525 (10matmarex) 5Open>3Resolved [01:29:09] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (6b85afc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274320 (owner: 10Jforrester) [01:46:41] RoanKattouw, around? [01:48:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (6b85afc) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274320 (owner: 10Jforrester) [01:49:50] Krenair: Yeah [01:50:38] When undoing the addition of a MetaItem... .remove is not called? [01:51:45] .remove on what? The MetaItem? [01:52:11] yes [01:53:48] Yeah that's rigbht [01:53:57] .remove() is one way to remove a meta item, but it's not the only way it can be removed [01:54:10] Do you have code that overrides .remove() to be notified of removals? [01:54:15] yes [01:54:50] Then what you should do instead is listen to the 'remove' event emitted by MetaList [01:55:08] I said "oh, this doesn't look too hard" before writing it. [01:55:10] That will be emitted regardless of how a meta item ends up being removed, because it's fired from onTransact [01:55:24] Hmm yeah this should be documented better :/ [01:55:42] time to move all my code around again [02:05:59] 10VisualEditor, 10OOjs-UI: Consistent closing of menu items by clicking - https://phabricator.wikimedia.org/T105199#2078607 (10Jdforrester-WMF) p:5Triage>3Normal [02:50:18] (03CR) 10Alex Monk: [C: 04-1] DesktopArticleTarget: Add Edge and MSIE to whitelist (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274181 (https://phabricator.wikimedia.org/T128447) (owner: 10Jforrester) [02:52:20] (03CR) 10Jforrester: DesktopArticleTarget: Add Edge and MSIE to whitelist (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274181 (https://phabricator.wikimedia.org/T128447) (owner: 10Jforrester) [02:53:13] (03CR) 10Alex Monk: DesktopArticleTarget: Add Edge and MSIE to whitelist (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274181 (https://phabricator.wikimedia.org/T128447) (owner: 10Jforrester) [02:54:42] (03CR) 10Jforrester: DesktopArticleTarget: Add Edge and MSIE to whitelist (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274181 (https://phabricator.wikimedia.org/T128447) (owner: 10Jforrester) [03:05:04] (03PS9) 10Alex Monk: Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) [03:05:22] 10WikiEditor, 10MediaWiki-extensions-ProofreadPage, 6Wikisource: Extension or User based elements added to the default WikiEditor toolbar are not loaded in certain namespaces and/or instances - https://phabricator.wikimedia.org/T119324#2078745 (10GOIII) >>! In T119324#2070849, @TheDJ wrote: > It has nothing... [03:09:42] (03CR) 10jenkins-bot: [V: 04-1] Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [03:10:19] (03CR) 10Alex Monk: "are you aware of If04944d6 ?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246862 (owner: 10Florianschmidtwelzow) [03:11:48] (03PS10) 10Alex Monk: Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) [03:31:05] 10VisualEditor, 10MediaWiki-extensions-Translate: Find/replace dialog in VE overlaps "translateable page" warning - https://phabricator.wikimedia.org/T128523#2078782 (10santhosh) [03:32:22] 10VisualEditor, 10MediaWiki-extensions-Translate: Find/replace dialog in VE overlaps "translateable page" warning - https://phabricator.wikimedia.org/T128523#2077794 (10santhosh) @brion, I think you meant the Translate extension, not ContentTranslation which is not installed in mediawiki.org. Edited the descri... [05:01:51] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Internet-Explorer, 13Patch-For-Review: Move IE10 and IE11 from the greylist to the whitelist to avoid the pop-up warning - https://phabricator.wikimedia.org/T128447#2075101 (10GOIII) As far as EDGE goes there are two issues to consider... //First/... [07:42:26] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia, and 3 others: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#2078906 (10Pginer-WMF) Can we get a screenshot of how this fi... [07:55:41] 10VisualEditor: VisualEditor character map not available in dialogs - https://phabricator.wikimedia.org/T128560#2078935 (10Tgr) [08:06:21] 10VisualEditor: Changing file names in VisualEditor should be easier - https://phabricator.wikimedia.org/T128561#2078961 (10Peachey88) [08:21:43] 10VisualEditor, 10VisualEditor-Media: Changing file names in VisualEditor should be easier - https://phabricator.wikimedia.org/T128561#2079012 (10Krenair) [08:38:54] 10VisualEditor: After creating a page using VE, left with ugly ?venotify=created appended to URL - https://phabricator.wikimedia.org/T128565#2079046 (10Legoktm) [10:04:11] 10VisualEditor: VisualEditor single tab popup should keep appearing until you use it - https://phabricator.wikimedia.org/T128573#2079240 (10Tgr) [10:25:46] 10VisualEditor: VisualEditor should work or be disabled on non-Vector skins - https://phabricator.wikimedia.org/T128574#2079280 (10Tgr) [10:29:06] (03PS5) 10Divec: WIP: Refactor getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270315 [10:29:17] 10VisualEditor, 10UI-Standardization: VisualEditor dialog button placement should be consistent with rest of MediaWiki - https://phabricator.wikimedia.org/T128576#2079308 (10Tgr) [10:29:45] 10Citoid, 10VisualEditor, 6Discovery, 6Editing-Department, and 4 others: Create a system to store and query links to books - https://phabricator.wikimedia.org/T90852#2079320 (10Qgil) This task is assigned to @Ladsgroup so I wonder whether it is a #possible-tech-projects candidate at all. [10:31:16] 10VisualEditor: VisualEditor progressive buttons are not visually distinct on Monobook - https://phabricator.wikimedia.org/T128577#2079324 (10Tgr) [10:31:25] (03PS6) 10Divec: WIP: Refactor getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270315 [10:31:37] 10VisualEditor, 10MonoBook: VisualEditor progressive buttons are not visually distinct on Monobook - https://phabricator.wikimedia.org/T128577#2079338 (10Tgr) [10:32:19] 10VisualEditor, 10UI-Standardization: VisualEditor dialog button placement should be consistent with rest of MediaWiki - https://phabricator.wikimedia.org/T128576#2079308 (10Tgr) [10:35:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270315 (owner: 10Divec) [10:49:43] (03PS7) 10Divec: WIP: Refactor getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270315 (https://phabricator.wikimedia.org/T124318) [10:51:50] 10VisualEditor, 10VisualEditor-ContentEditable, 13Patch-For-Review: getNodeAndOffset has incorrect returns if given the offset after the close of a non-focusable node - https://phabricator.wikimedia.org/T124318#2079395 (10dchan) The above patch fixes the offset calculation bug. (Cursoring rightwards off the... [10:53:04] (03CR) 10jenkins-bot: [V: 04-1] WIP: Refactor getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270315 (https://phabricator.wikimedia.org/T124318) (owner: 10Divec) [11:15:49] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-General-or-Unknown, 6Multimedia, and 3 others: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#2079458 (10Prtksxna) @Pginer-WMF, the blue bar shows progress... [11:34:13] 10Cite, 10MediaWiki-API, 10MobileFrontend, 13Patch-For-Review, 3Reading-Web-Sprint-67-i: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2079483 (10jcrespo) Performing the 24-hour profiling of s2 master and a s2 slave. [11:44:58] 10VisualEditor, 10VisualEditor-MediaWiki: Preserve edit summary, minor edit, watchlist checkboxes when switching from VE-MW to WT or back - https://phabricator.wikimedia.org/T128529#2077915 (10AlexMonk-WMF) Presumably only when keeping changes? [11:46:25] 10Cite, 10MediaWiki-API, 10MobileFrontend, 13Patch-For-Review, 3Reading-Web-Sprint-67-i: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2079509 (10jcrespo) ```lang=sql,name=db1061 *************************** 56. row *************************** Name: page_props... [11:49:41] 10Cite, 10MediaWiki-API, 10MobileFrontend, 13Patch-For-Review, 3Reading-Web-Sprint-67-i: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2079511 (10jcrespo) (Note the rows do not match because they were taken at a different time, plus those are not updated in real time- o... [11:56:39] (03PS1) 10Alex Monk: Keep summary and checkbox selections when swtiching WTE->VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274369 (https://phabricator.wikimedia.org/T128529) [11:56:47] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Preserve edit summary, minor edit, watchlist checkboxes when switching from VE-MW to WT or back - https://phabricator.wikimedia.org/T128529#2079521 (10AlexMonk-WMF) a:3AlexMonk-WMF [12:12:46] 10VisualEditor, 10VisualEditor-MediaWiki: Second item in Single Edit Tab dialog box is not properly centered - https://phabricator.wikimedia.org/T127918#2058411 (10AlexMonk-WMF) This `.oo-ui-messageDialog-actions .oo-ui-actionWidget.oo-ui-labelElement .oo-ui-labelElement-label` CSS rule sets both `text-align:... [12:31:32] (03PS1) 10Zfilipin: [BrowserTest] Fix `ve.init is undefined` and `ve.init.target is undefined` error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274376 (https://phabricator.wikimedia.org/T126966) [12:50:51] (03PS2) 10Zfilipin: [BrowserTest] Fix `ve.init is undefined` and `ve.init.target is undefined` error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274376 (https://phabricator.wikimedia.org/T126966) [12:53:54] 10VisualEditor, 7I18n: In single edit tab wikis, MediaWiki:Visualeditor-preference-tabs-prefer-ve/it looks broken in Preferences menu - https://phabricator.wikimedia.org/T128584#2079680 (10Elitre) [13:01:16] 10VisualEditor, 10VisualEditor-MediaWiki: Don't give the user the option to discard changes when changing editor - https://phabricator.wikimedia.org/T128585#2079698 (10Esanders) [13:01:56] 10VisualEditor, 10VisualEditor-MediaWiki: Don't give the user the option to discard changes when changing editor - https://phabricator.wikimedia.org/T128585#2079710 (10Esanders) [13:04:53] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#2079713 (10Esanders) @Ironholds the page has become a disambig since you filed. Looking at the history were... [13:12:47] edsanders, max & i have been discussing it for a while, and we really cannot come up with a way to avoid having a page context for what is required. I will think of a way to do it in VE - there is a number of ways to work around it. [13:14:16] only if you support the status quo on WV [13:15:25] you embed the map data in the frame: { place1: [ 45,-1, 'Hotel' ], place2: [46,-2, 'Museum'] } [13:16:03] if you want to link to a place, you can use some sort of hashlink: [13:16:21] just like section linking [13:17:09] if wikivoyage need an auto-numbering system, they could build a gadget for it [13:32:38] edsanders, this might work, i will need to think further about it, but we need to start with migrating them to the stable platform. Currently there are tens of thousands of pages that already use this method, so it is simply not possible to develop a drop-in replacement without context support. [13:33:23] re counting - not sure how that can happen with a gadget [13:34:25] edsanders, if you have a sec, could you remove "mode" from the VE maps? We have just merged the updated code with all the new tags [13:35:07] yurik_, I don't think developing a drop-in replacement is our priority [13:35:54] I appreciate the WV community are supportive, but the use case for maps on other projects is orders of magnitude bigger [13:36:21] edsanders, it is because otherwise they are violating our privacy policy by embeddeding non-production resources into pages [13:37:01] that's true, and for them I am not sure if we will support cross-tag data yet [13:37:32] can't you just change the tile server they are using? [13:48:07] edsanders, they are using wmflabs to host all the javascript and database and php code [13:49:07] why do they have a database? [13:59:25] 10VisualEditor, 10VisualEditor-ContentEditable: Unable to edit table cell after double click on cell - https://phabricator.wikimedia.org/T128588#2079812 (10Nnvu) [14:24:44] edsanders, they pull data from wiki pages, parse them, and i think they cache it in a db [14:27:25] i might be mistaken, and it is being done on each request [14:38:49] (03PS1) 10Esanders: Pass command and sequence registries to the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274395 [14:38:51] (03PS1) 10Esanders: Abstract target widget creation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274396 [14:44:42] (03CR) 10jenkins-bot: [V: 04-1] Abstract target widget creation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274396 (owner: 10Esanders) [14:45:14] (03CR) 10jenkins-bot: [V: 04-1] Pass command and sequence registries to the surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274395 (owner: 10Esanders) [14:51:12] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Adding a citation manually causes it to be inserted at the top of the page, not where the cursor is, sometimes(?) - https://phabricator.wikimedia.org/T126437#2079924 (10Elitre) This hasn't gone away. Furthermore, I can't recommend one o... [15:20:42] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#2079963 (10Ironholds) I have literally no idea, it was in 2014. [15:26:41] 10VisualEditor, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2079967 (10Jdforrester-WMF) [15:31:49] (03CR) 10Subramanya Sastry: API: Send Accept: header to RESTbase (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273997 (https://phabricator.wikimedia.org/T128233) (owner: 10Alex Monk) [15:38:07] (03PS1) 10Alex Monk: Change Accept header a bit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274408 (https://phabricator.wikimedia.org/T128233) [15:44:54] edsanders, and btw, most of them already use our tile server, so that part is not a problem [15:49:26] 10VisualEditor, 10WikiEditor: Please allow us to use wikieditor - https://phabricator.wikimedia.org/T128597#2080028 (10Paladox) [15:50:10] 10VisualEditor, 10WikiEditor: Please allow us to use wikieditor - https://phabricator.wikimedia.org/T128597#2080059 (10Jdforrester-PERSONAL) 5Open>3Invalid Click the switch button. [15:52:08] (03CR) 10Subramanya Sastry: [C: 031] Change Accept header a bit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274408 (https://phabricator.wikimedia.org/T128233) (owner: 10Alex Monk) [15:52:20] (03CR) 10Jforrester: [C: 032] Change Accept header a bit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274408 (https://phabricator.wikimedia.org/T128233) (owner: 10Alex Monk) [15:58:45] (03CR) 10Jforrester: [C: 04-1] Pass command and sequence registries to the surface (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274395 (owner: 10Esanders) [15:59:50] 10VisualEditor, 10WikiEditor: Please allow us to use wikieditor - https://phabricator.wikimedia.org/T128597#2080074 (10Paladox) Oh ok thanks. It says internet explorer is not supported. [16:00:11] 10VisualEditor, 10WikiEditor: Please allow us to use wikieditor - https://phabricator.wikimedia.org/T128597#2080076 (10Paladox) It also says the same thing with Microsoft Edge. [16:03:37] (03Merged) 10jenkins-bot: Change Accept header a bit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274408 (https://phabricator.wikimedia.org/T128233) (owner: 10Alex Monk) [16:07:35] 10VisualEditor, 10VisualEditor-MediaWiki, 7Browser-Support-Internet-Explorer, 7Browser-Support-Microsoft-Edge, 13Patch-For-Review: Move IE10, IE11 and Edge from the greylist to the whitelist to avoid the pop-up warning - https://phabricator.wikimedia.org/T128447#2080116 (10Jdforrester-WMF) [16:07:55] 10VisualEditor, 10WikiEditor: Please allow us to use wikieditor - https://phabricator.wikimedia.org/T128597#2080028 (10Jdforrester-WMF) >>! In T128597#2080076, @Paladox wrote: > It also says the same thing with Microsoft Edge. See {T128447} for us promoting those browsers to the whitelist. [16:12:58] 10VisualEditor, 10UI-Standardization: VisualEditor dialog button placement should be consistent with rest of MediaWiki - https://phabricator.wikimedia.org/T128576#2079308 (10Jdforrester-WMF) They're in the top-left (top-right in RTL) because that's where they are in mobile interfaces where the surrounding cues... [16:17:05] edsanders, i just added https://gerrit.wikimedia.org/r/#/c/274419/ to remove the mode, but i would really love to have the alignment capability [16:17:13] any tips on how to quickly get it in? [16:17:17] copy it from somewhere? [16:21:19] (03PS8) 10Esanders: [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) [16:21:21] (03PS1) 10Esanders: Use new surface executeCommand method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274421 [16:21:23] (03PS1) 10Esanders: Use abstract target widget creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274422 [16:21:28] yurik, it depends what we need [16:21:47] edsanders, i think we should go the "image" path - left, right, inline [16:22:01] there's probably no point providing an alignment without a frame and caption [16:22:11] edsanders, we could add that too [16:22:21] easy enough to add [16:22:46] Parsoid uses
and
[16:22:57] if there is an html that we should have, i will simply add that to the generation [16:23:31] edsanders, i will create a phab ticket, can you add the exact HTML that needs to be generated in each case, with CSS? [16:23:38] if you have a second of course :) [16:23:46] i will be happy to implement it all [16:25:05] (03CR) 10Paladox: DesktopArticleTarget: Add Edge and MSIE to whitelist (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274181 (https://phabricator.wikimedia.org/T128447) (owner: 10Jforrester) [16:26:23] edsanders, actually we already have a phab ticket for that - https://phabricator.wikimedia.org/T125301 [16:26:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) (owner: 10Esanders) [16:26:35] ah, you already commented there :) [16:26:57] it also mentions mw-halgin-left etc [16:26:58] which will give you alignment [16:27:42] you'll want to use ClassAttributeNode though which is a bit fiddly [16:27:54] if you write a patch that adds a control to the dialog [16:28:14] in fact - I think I had that code in a early version [16:28:44] edsanders, any way you could re-add it to VE, and i will do the html portion? [16:28:51] you know VE much better :) [16:29:04] (03CR) 10jenkins-bot: [V: 04-1] Use abstract target widget creation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274422 (owner: 10Esanders) [16:29:45] edsanders, feel free to +2 the mode removal code - it seems to work for me [16:30:05] edsanders, but it had some mentioning of inline, which is a bit odd - i would think it was not mode-related [16:32:39] (03CR) 10Esanders: DesktopArticleTarget: Add Edge and MSIE to whitelist (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274181 (https://phabricator.wikimedia.org/T128447) (owner: 10Jforrester) [16:33:27] (03CR) 10Jforrester: DesktopArticleTarget: Add Edge and MSIE to whitelist (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274181 (https://phabricator.wikimedia.org/T128447) (owner: 10Jforrester) [16:33:50] map links and map data rendered as inline nodes [16:34:06] if you've changed the names, the will now be unsupported [16:36:12] yurik, is there a static/interative switch? [16:36:13] edsanders, correct. Should we keep the mode, but make it internal? or should it be some subclassing system? They all share geojson editing capability. mapframe and maplink has location+zoom, mapframe has image size [16:36:16] no [16:36:30] how is it controlled? [16:36:33] its not [16:36:34] always click to interact? [16:36:51] per-wiki setting? [16:36:56] it will be an automatic thing [16:37:02] per wiki, and eventually per client [16:37:08] e.g. if its fast enough [16:37:38] no point in adding that to wiki markup [16:38:23] 10TemplateData, 10VisualEditor, 13Patch-For-Review: Mediawiki API should not return a format:inline for templatedata if the format information is missing - https://phabricator.wikimedia.org/T128337#2080275 (10Vituzzu) Dunno if it's related but I noticed also addition of spaces between | and template paramete... [16:38:25] so we may eventually make it user configurable in their settings, and also try to decide based on their network speed [16:41:42] 10TemplateData, 10VisualEditor, 13Patch-For-Review: Mediawiki API should not return a format:inline for templatedata if the format information is missing - https://phabricator.wikimedia.org/T128337#2080284 (10ssastry) >>! In T128337#2080275, @Vituzzu wrote: > Dunno if it's related but I noticed also addition... [16:45:46] edsanders, i think you had the alignment thing in the openlayers patch you had in VE git [16:46:13] it's here: https://gerrit.wikimedia.org/r/#/c/262448/1/modules/ve-maps/ve.ui.MWMapsDialog.js [16:46:19] will submit [16:47:41] edsanders, thanks!!! can i bug you with just one more thing - something that neither max nor i have the slightest idea - how should we make the "click to make full screen" link for the tag? [16:47:59] something similar to mediaviewer i guess [16:48:20] we can do it kartographer.js [16:49:04] when we iterate over all .mw-kartographer-interactive, instead of calling createMap immediately, just bind a click event to the image [16:51:01] (03CR) 10Paladox: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274271 (owner: 10L10n-bot) [16:51:26] (03CR) 10Paladox: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274271 (owner: 10L10n-bot) [16:52:55] edsanders, but this wouldn't be .mw-kartographer-interactive, it would be some sort of an anchor tag i would think, with some custom on click processing [16:54:10] and the bigger question - what code would create this overlay frame that is escapable, plus have some extra button to close it, etc? [16:54:49] just use a different className then if you are in clickToInteract instead of iteract [16:55:07] well if you it's click to interact in place you don't need a dialog [16:55:10] if you then want to go fullscreen [16:55:42] you could either use an OOUI dialog, or write your own CSS [16:56:01] I guess an OOUI dialog would be better [16:56:04] edsanders, its more like "on click, load the needed resources, create a popup and show the map there. On escape, close it" [16:56:06] then you get a title bar and buttons for free [16:56:17] (and escape to close) [16:56:46] any sample code for that? i should probably learn the OOJS (btw, in russian its pronounced as "horror") [16:58:06] mediawiki.feedback.js launches an OOUI window [16:58:25] we should really get around to making a module the just creates a global window manager [16:58:33] atm everyone is creating their own window manager [16:58:51] ( pages MatmaRex James_F ) [16:59:13] there is one [16:59:23] used by OO.ui.alert() and .confirm() [16:59:39] it's currently "private" [17:00:29] OO.ui.getWindowManager() ? [17:00:48] yeah [17:00:58] should that be used? [17:01:00] no [17:01:02] :P [17:01:18] depending on what's in your dialog, you might want to just use OO.ui.alert() [17:04:50] 10VisualEditor: On meta, Alt+Shift+V is bound to VE edit and to diff view - https://phabricator.wikimedia.org/T128610#2080402 (10Yurik) [17:17:39] 10VisualEditor, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-CodeEditor, 7Regression: Ace editor doesn't load in debug mode (local 'require' var ends up removed half-way) - https://phabricator.wikimedia.org/T127643#2080453 (10Esanders) [17:18:35] 10VisualEditor, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-CodeEditor, 7Regression: Ace editor doesn't load in debug mode (local 'require' var ends up removed half-way) - https://phabricator.wikimedia.org/T127643#2049389 (10Esanders) This also affects the SyntaxHighlight, Math and Maps plugins in V... [17:20:17] 10VisualEditor, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-CodeEditor, 7Regression: Ace editor doesn't load in debug mode (local 'require' var ends up removed half-way) - https://phabricator.wikimedia.org/T127643#2080461 (10Krinkle) [17:25:56] yurik, if I have a mapframe with no geojson it hoovers up all the geojson from other maps on the page [17:32:09] edsanders, is that a question or is that how you want to make it? [17:32:30] it seems like a bug [17:32:42] mapframe should show all geojson from all data/link/maps [17:32:55] at the moment, there are no groups, so all geojson gets combined [17:33:14] so if I have {geoJSON}... [17:33:16] that doesn't make sense [17:34:31] yeah, i was trying to fix it with the "private" groups, where the mapframe only shows whatever it itself has, plus whatever is defined in the mapdata and maplink [17:35:38] but than it got really confusing when you do want data to be shared between mapframes [17:35:50] still not sure of the best way here [17:37:00] i will probably revert back to mapframe adding to the private group, whereas mapdata & maplink adding to all [17:37:10] will probably be more straightforward [17:38:24] 10TemplateData, 10VisualEditor, 7HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2061803 (10Esanders) It also appears to support single quotes: https://en.wikipedia.org/w/index.php?title=Template:Multip... [17:48:26] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#2080570 (10TrevorParscal) [17:48:54] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#542145 (10TrevorParscal) >>! In T52355#2079713, @Esanders wrote: > @Ironholds the page has become a disambig... [17:53:24] Is the edit tab supposed to look like this, is it a bug, or is it my custom .css? http://i.imgur.com/3vsjqiG.png [17:54:12] * cursive guesses it's a part of the single edit tab after clicking around [17:59:10] (03PS1) 10DLynch: FindAndReplaceDialog: don't use tabindex [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274453 (https://phabricator.wikimedia.org/T123957) [18:00:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10Vector, 13Patch-For-Review: VisualEditor find-and-replace should use the Tab key to move from the Find input to the Replace input - https://phabricator.wikimedia.org/T123957#1941912 (10DLynch) @maiden_taiwan Only to the extent that using tabindex > 0 anywhere is... [18:00:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10Vector, 13Patch-For-Review: VisualEditor find-and-replace should use the Tab key to move from the Find input to the Replace input - https://phabricator.wikimedia.org/T123957#2080638 (10DLynch) a:3DLynch [18:05:17] (03PS2) 10Jforrester: FindAndReplaceDialog: don't use tabindex [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274453 (https://phabricator.wikimedia.org/T123957) (owner: 10DLynch) [18:06:14] The `s might be raw force of habit in my fingers at this point. [18:08:43] 10TemplateData, 10VisualEditor, 13Patch-For-Review: Mediawiki API should not return a format:inline for templatedata if the format information is missing - https://phabricator.wikimedia.org/T128337#2070940 (10Esanders) In case you were in doubt, I encountered this too with {{multiple image}} converting param... [18:09:28] (03CR) 10Jforrester: [C: 031] FindAndReplaceDialog: don't use tabindex [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274453 (https://phabricator.wikimedia.org/T123957) (owner: 10DLynch) [18:13:00] edsanders: hmm, wanna merge that patch then? and then we could backport! [18:15:41] (03PS8) 10Divec: WIP: Refactor getNodeAndOffset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270315 (https://phabricator.wikimedia.org/T124318) [18:21:13] Kemayo: :-) [18:22:51] 10VisualEditor, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-CodeEditor, 7Regression: [Regression wmf.15] Ace editor doesn't load in debug mode (local 'require' var ends up removed half-way) - https://phabricator.wikimedia.org/T127643#2080707 (10Jdforrester-WMF) [18:31:59] 10VisualEditor: "Insert paragraph" won't show up where user expects it to - https://phabricator.wikimedia.org/T128622#2080734 (10Elitre) [18:33:23] 10VisualEditor: "Insert paragraph" won't show up where user expects it to - https://phabricator.wikimedia.org/T128622#2080746 (10Elitre) [19:05:57] (03CR) 10Florianschmidtwelzow: "No, haven't seen this so far :)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246862 (owner: 10Florianschmidtwelzow) [19:06:08] (03Abandoned) 10Florianschmidtwelzow: Use mw.widgets.DateInputWidget or ToggleSwitchWidget for parameters with appropriate type [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/246862 (owner: 10Florianschmidtwelzow) [19:08:36] (03CR) 10Florianschmidtwelzow: "If I have a user template field, UserInputWidget isn't used :/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/169936 (https://phabricator.wikimedia.org/T55613) (owner: 10Alex Monk) [19:13:08] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#2080888 (10Jdforrester-WMF) [19:14:40] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add support for editing templates' parameters as DOM elements, including supporting nested templates - https://phabricator.wikimedia.org/T52355#542145 (10Jdforrester-WMF) Comments from discussion about this: * Wikitext button should look depressed whe... [19:21:01] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): SET: Switching to VE from Wikitext editor does not work in case of discarding the changes if user is prefer-wt - https://phabricator.wikimedia.org/T128402#2080929 (10Ryasmeen) This is now working fine for the above mentioned sc... [19:21:43] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): SET: Switching to VE from Wikitext editor does not work in case of discarding the changes if user is prefer-wt - https://phabricator.wikimedia.org/T128402#2080938 (10Jdforrester-WMF) >>! In T128402#2080929, @Ryasmeen wrote: > T... [19:30:57] (03CR) 10Paladox: "Ok done here https://gerrit.wikimedia.org/r/274466" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/261041 (https://phabricator.wikimedia.org/T25914) (owner: 10Paladox) [19:52:46] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): SET: Switching to VE from Wikitext editor does not work in case of discarding the changes if user is prefer-wt - https://phabricator.wikimedia.org/T128402#2081123 (10Ryasmeen) [19:52:54] 10VisualEditor, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2081055 (10Elitre) [19:56:00] 10Cite, 10MediaWiki-API, 10MobileFrontend, 13Patch-For-Review, 3Reading-Web-Sprint-67-If, Then, Else...?: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2081134 (10Jdlrobson) SWAT arranged for Monday. TODO: [] Confirm with @jcrespo he can make that. [] Me to e-mail ops l... [19:59:48] 10VisualEditor, 10UI-Standardization: VisualEditor dialog button placement should be consistent with rest of MediaWiki - https://phabricator.wikimedia.org/T128576#2081155 (10Tgr) MediaViewer has hand-crafted dialogs with buttons mostly at bottom ([[https://commons.wikimedia.org/wiki/File:Media_Viewer_-_New_Des... [20:11:35] (03CR) 10Subramanya Sastry: "gwicke: FYI as to what VE will send RESTBase in the context of trying to simplify this with the next version bump." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274408 (https://phabricator.wikimedia.org/T128233) (owner: 10Alex Monk) [20:11:43] 10VisualEditor, 10MediaWiki-extensions-Translate: Find/replace dialog in VE overlaps "translateable page" warning - https://phabricator.wikimedia.org/T128523#2081205 (10brion) @santhosh thanks, I get them mixed up sometimes. :) [20:12:24] Krinkle: so, can we make https://gerrit.wikimedia.org/r/#/c/274138/ happen? [20:12:59] MatmaRex: With VE, Parsoid and TDGenerator working, yes :) [20:13:33] so, yes then? :D [20:13:44] If those have been updated to account for it, or they have agreed to do and merge the fixes before Monday, then it can be merged. [20:14:10] i think parsoid already assumed the behavior i'm implementing, subbu seems to be saying it works [20:14:21] generator is okay too [20:14:22] tdgenerator i checked pretty thoroughly [20:14:23] what about VE widgets? [20:14:32] VE seemed fine [20:14:36] ok [20:14:40] i don't think it looks at format at all [20:14:43] (03CR) 10Krinkle: [C: 031] [BREAKING CHANGE] Change default format to null instead of 'inline' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/274138 (https://phabricator.wikimedia.org/T128337) (owner: 10Bartosz Dziewoński) [20:15:26] oh come on. [20:17:13] Yes, Parsoid works with missing / null format values. [20:19:54] James_F: edsanders: so, can we get that merged? you okay with me backporting it? [20:19:56] I explicitly check for 'block' and 'inline' format values and everything else defaults to inline. In all cases, existing formatting is preserved (modulo bugs which we've been fixing as we encounter them). [20:20:54] (03CR) 10Jforrester: [C: 032] ":-(" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/274138 (https://phabricator.wikimedia.org/T128337) (owner: 10Bartosz Dziewoński) [20:23:03] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Change default format to null instead of 'inline' [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/274138 (https://phabricator.wikimedia.org/T128337) (owner: 10Bartosz Dziewoński) [20:23:33] (03PS1) 10Jforrester: [BREAKING CHANGE] Change default format to null instead of 'inline' [extensions/TemplateData] (wmf/1.27.0-wmf.15) - 10https://gerrit.wikimedia.org/r/274482 (https://phabricator.wikimedia.org/T128337) [20:23:40] (03CR) 10Eranroz: "Good patch." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/274138 (https://phabricator.wikimedia.org/T128337) (owner: 10Bartosz Dziewoński) [20:32:04] 10Citoid, 10VisualEditor, 6Discovery, 6Editing-Department, and 4 others: Create a system to store and query links to books - https://phabricator.wikimedia.org/T90852#2081300 (10Ladsgroup) Hey, I had plans to work on this, but not right now. I already have a lot in my plate. And I'm not sure what would be t... [20:33:08] 10Citoid, 10VisualEditor, 6Discovery, 6Editing-Department, and 4 others: Create a system to store and query links to books - https://phabricator.wikimedia.org/T90852#2081305 (10Ladsgroup) a:5Ladsgroup>3None [20:33:33] 10VisualEditor, 10UI-Standardization: VisualEditor dialog button placement should be consistent with rest of MediaWiki - https://phabricator.wikimedia.org/T128576#2081309 (10Jdforrester-WMF) >>! In T128576#2081155, @Tgr wrote: > MediaViewer has hand-crafted dialogs with buttons mostly at bottom ([[https://comm... [20:56:01] 10VisualEditor: VisualEditor single tab popup should keep appearing until you use it - https://phabricator.wikimedia.org/T128573#2081484 (10AlexMonk-WMF) @Jdforrester-WMF: thoughts? [21:11:07] 10VisualEditor, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2081599 (10Cirdan) The community was informed about the planned schedule at [[ https://de.wikipedia.org/wiki/Wikipedia:K... [21:19:38] 10VisualEditor, 10VisualEditor-MediaWiki, 7Verified, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): SET: Switching to VE from Wikitext editor does not work in case of discarding the changes if user is prefer-wt - https://phabricator.wikimedia.org/T128402#2081641 (10AlexMonk-WMF) That works for me in beta enwiki... [21:28:54] (03CR) 10Alex Monk: [C: 04-1] [WIP] Make it possible to enable for a proportion of logged-out users (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274158 (https://phabricator.wikimedia.org/T128484) (owner: 10Jforrester) [21:49:38] 10VisualEditor, 10VisualEditor-MediaWiki: Discrepancy between hover/mousedown and click behavior in EducationPopupTool - https://phabricator.wikimedia.org/T128440#2081813 (10AlexMonk-WMF) a:3AlexMonk-WMF Noticed something else - should we also have the cursor be a pointer while hovering over the education po... [21:49:45] (03PS1) 10Alex Monk: Education popup: Also handle clicks on dots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274499 (https://phabricator.wikimedia.org/T128440) [22:01:15] James_F, did something change over the last week that doubled the # of html -> wt reqs to parsoid .. https://grafana.wikimedia.org/dashboard/db/parsoid-perf-trends?panelId=37&fullscreen .. look at the 30 day window. [22:01:33] and select the html2wt graph [22:02:22] maybe it is flow .. anyway, mostly curious. [22:02:29] subbu: Possibly Hungarian single edit tab? [22:05:47] subbu: Is it a concern? [22:06:24] did that go out last week? a bit skeptical that just huwiki single edit tab would double the html -> wt reqs from all other wikis. [22:06:39] no, it isn't a concern. [22:06:59] but, trying to stay on top of changes to graphs and be able to explain them. [22:07:51] (If that's the cause, it's likely to jump much much further when we deploy to additional wikis.) [22:07:51] Yeah, I'm also sceptical. [22:08:09] huwiki change went live at 16:18 UTC on 2016-02-23. [22:08:34] So, three days before the spike. Probably not that then. [22:09:37] so, noticeable blip from that single edit tab deploy .. [22:10:00] grr .. *not a* noticeable blip i mean. [22:10:03] Yeah. [22:10:33] The blip mostly happened on 2016-02-26. [22:11:06] The train went out at some point on 25/26. [22:11:40] Hmm, no, it didn't. [22:12:31] RoanKattouw_away, matt_flaschen anything change with Flow last week that might increase the rate of html -> wt reqs to parsoid? [22:12:47] it is not a problem .. just trying to explain the increase. [22:13:05] Aha. [22:13:23] Revert "Revert "all wikis to 1.27.0-wmf.14"" [22:13:25] That went out at Thu Feb 25 21:23:15 2016 +0000 [22:13:41] (And would have been on group1 before then, explaining a ramp-up.) [22:13:45] 10Citoid, 10VisualEditor, 6Discovery, 6Editing-Department, and 3 others: Create a system to store and query links to books - https://phabricator.wikimedia.org/T90852#2081905 (10Qgil) Thank you for your explanation, which shows that is indeed not a good candidate for #possible-tech-projects right now. [22:13:46] * James_F looks at VE wmf.14 code. [22:14:41] subbu, not that I can think of. [22:15:01] subbu: https://gerrit.wikimedia.org/r/#/c/252345/ might have encouraged people to switch back instead of being stranded? [22:18:03] But that would have been wt2html, nevermind. [22:18:03] interesting ... but, 2x the req rate .. seems a bit unlikely (from enabling ve -> wt -> ve) .. will check with gwicke / mobrovac to see if they any additional info in restbase logs. [22:18:53] We didn't enable it, just added a dialog highlighting that you could go back from wt2html having already done html2wt. [22:18:53] I don't have a reason, sorry. [22:22:05] that is fine. will dig into this later. [22:32:05] 10VisualEditor, 10ArchCom-RfC, 6Parsing-Team, 10Parsoid: [RFC] Introduce notion of DOM scopes in wikitext - https://phabricator.wikimedia.org/T114444#2081980 (10RobLa-WMF) a:3tstarling Per E146 [22:35:38] subbu: https://grafana.wikimedia.org/dashboard/db/restbase?panelId=15&fullscreen might have clues, and there's also data for wmf-internal requests [22:37:03] jaufrecht_: https://grafana.wikimedia.org/dashboard/db/visualeditor-load-save [22:38:15] Is load rate the total number of uses of VE per time period? [22:39:01] or are you pointing to a data visualization platform to consider for Phlogiston? [22:40:07] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 6Editing-Department, and 3 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2082028 (10RobLa-WMF) 5Open>3stalled a:3daniel Per E146. @Daniel may be willing to take this on [22:41:27] jaufrecht_: I was mostly pointing out that the data is pretty dead-flat. [22:41:54] (The top two are load/save use rates per minute, yeah.) [22:42:50] dead flat in terms of change in VE usage since last week, or in median VE performance during the day? [22:43:45] jaufrecht_: The former. The lines are today, yesterday, and last week – it's surprising how close they are. [22:44:06] want to start a demand generation project, run some ads? [22:45:31] jaufrecht_: It's called Single Edit Tab. :-) [22:45:47] can you filter the query by wiki to see hu only? [22:45:51] gwicke, https://grafana.wikimedia.org/dashboard/db/restbase?panelId=13&fullscreen&from=1454366367096&to=1456958367097 .. selecting html2wt POST all .. shows that they all come through restbase .. so couldn't be flow for sure [22:46:06] separately, James_F gwicke .. there are discrepancies between VE save rate / RESTBase html2wt rate to Parsoid / Parsoid's html2wt rate ... which is strange ... [22:46:40] subbu: You'd expect RB -> Parsoid html2wt to be higher. [22:46:40] ve save rate is 360 / minute .. restbase says ~1.5 req / sec total and Parsoid says ~1 req / sec total. [22:46:40] go figure. [22:46:57] Oh. Hmm. [22:47:00] s/total/peak/ [22:47:12] Hmm, is the string "SPACE" in the shortcuts dialog not translatable? [22:47:40] (03CR) 10Alex Monk: [C: 032] FindAndReplaceDialog: don't use tabindex [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274453 (https://phabricator.wikimedia.org/T123957) (owner: 10DLynch) [22:48:41] RoanKattouw: I would have thought it was… [22:49:00] qqx doesn't show keys for CTRL, SHIFT, etc, nor SPACE [22:49:17] But I can try to find it in the i18n file I guess [22:50:09] I can't see them in non-i18n either. [22:53:49] (03Merged) 10jenkins-bot: FindAndReplaceDialog: don't use tabindex [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/274453 (https://phabricator.wikimedia.org/T123957) (owner: 10DLynch) [22:56:00] 10VisualEditor, 10VisualEditor-MediaWiki: Use different preferences for the seen state of each of the educational pop-ups - https://phabricator.wikimedia.org/T117638#2082123 (10AlexMonk-WMF) Would we want some sort of "never show these popups" button? [22:59:54] 10VisualEditor, 10ArchCom-RfC, 6Parsing-Team, 10Parsoid: [RFC] Introduce notion of DOM scopes in wikitext - https://phabricator.wikimedia.org/T114444#2082147 (10ssastry) >>! In T114444#1695661, @cscott wrote: > Works for me. Let's let T114445 be all the "controversial" questions that require broader discu... [23:00:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10Vector, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): VisualEditor find-and-replace should use the Tab key to move from the Find input to the Replace input - https://phabricator.wikimedia.org/T123957#2082149 (10Jdforrester-WMF) 5Open>3Resolved [23:03:02] 10VisualEditor, 10ArchCom-RfC, 6Parsing-Team, 10Parsoid: [RFC] Introduce notion of DOM scopes in wikitext - https://phabricator.wikimedia.org/T114444#1695497 (10Boshomi) A fully reversible wikitext2json and json2wikitext would be nice. Each object of wikitext (section, paragraph, magicword, transclusion, w... [23:17:12] 10VisualEditor, 10ArchCom-RfC, 6Parsing-Team, 10Parsoid: [RFC] Introduce notion of DOM scopes in wikitext - https://phabricator.wikimedia.org/T114444#2082210 (10GWicke) @Boshomi: We already have that, as Parsoid's HTML can fairly easily be represented as JSON. See https://www.mediawiki.org/wiki/Parsoid/Med... [23:24:27] (03CR) 10Ryasmeen: [C: 032] [BrowserTest] Fix `ve.init is undefined` and `ve.init.target is undefined` error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274376 (https://phabricator.wikimedia.org/T126966) (owner: 10Zfilipin) [23:33:34] (03Merged) 10jenkins-bot: [BrowserTest] Fix `ve.init is undefined` and `ve.init.target is undefined` error messages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274376 (https://phabricator.wikimedia.org/T126966) (owner: 10Zfilipin) [23:49:48] 10VisualEditor, 10ArchCom-RfC, 6Parsing-Team, 10Parsoid: [RFC] Introduce notion of DOM scopes in wikitext - https://phabricator.wikimedia.org/T114444#2082447 (10Boshomi) Is there a API for parasoid?