[07:01:54] 10VisualEditor: docserver-http: HTTP 400 trying to save an article on fr.wp - https://phabricator.wikimedia.org/T141226#2491226 (10Aklapper) [09:28:27] (03CR) 10Zfilipin: Run language screenshots from Jenkins (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299159 (https://phabricator.wikimedia.org/T139613) (owner: 10Zfilipin) [09:31:46] (03PS10) 10Zfilipin: Run language screenshots from Jenkins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299159 (https://phabricator.wikimedia.org/T139613) [09:35:31] (03PS11) 10Zfilipin: Run language screenshots from Jenkins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299159 (https://phabricator.wikimedia.org/T139613) [09:44:05] (03PS12) 10Zfilipin: Run language screenshots from Jenkins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299159 (https://phabricator.wikimedia.org/T139613) [09:46:01] (03CR) 10Zfilipin: "Apologies for three trivial edits (instead of one), I was testing Gerrit's new online editing feature." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299159 (https://phabricator.wikimedia.org/T139613) (owner: 10Zfilipin) [10:12:47] (03PS1) 10Zfilipin: WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) [10:13:49] (03PS1) 10Esanders: Use innerText for setting clipboard plain text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300845 [10:16:07] (03CR) 10jenkins-bot: [V: 04-1] WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) (owner: 10Zfilipin) [10:19:01] (03PS1) 10Zfilipin: Remove Ruby implementation of language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300846 (https://phabricator.wikimedia.org/T132574) [10:19:26] (03CR) 10Divec: [C: 032] "Nice" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300845 (owner: 10Esanders) [10:22:33] (03Merged) 10jenkins-bot: Use innerText for setting clipboard plain text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300845 (owner: 10Esanders) [10:30:40] (03CR) 10Esanders: [C: 04-1] "Add a test case for the actual bug." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/299570 (https://phabricator.wikimedia.org/T140538) (owner: 10Divec) [10:31:48] 10VisualEditor, 10VisualEditor-ContentEditable, 13Patch-For-Review: Link with annotations gets split on re-render - https://phabricator.wikimedia.org/T140538#2491548 (10dchan) You can do it in core with the following example: 1. Edit

foobar

2. Observe that there is a single lin... [10:38:23] (03PS2) 10Zfilipin: WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) [10:38:44] (03PS2) 10Esanders: Allow newDocRange to be passed to SurfaceFragment#insertDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300258 [10:38:46] (03PS2) 10Esanders: Make no change to selection if insertDocument is a no-op [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300259 [10:38:48] (03PS2) 10Esanders: Check surface is set up in toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300257 [10:38:50] (03PS2) 10Esanders: Use more surface fragments in paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300262 (https://phabricator.wikimedia.org/T140924) [10:38:52] (03PS2) 10Esanders: Annotate pasted external text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300263 [10:38:54] (03PS2) 10Esanders: Fix table paste tests to use dynamic retain-to-end operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300260 [10:38:56] (03PS2) 10Esanders: Add test for internal copy/paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300261 [10:41:51] (03CR) 10Esanders: [C: 032] Run language screenshots from Jenkins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299159 (https://phabricator.wikimedia.org/T139613) (owner: 10Zfilipin) [10:42:28] (03CR) 10jenkins-bot: [V: 04-1] WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) (owner: 10Zfilipin) [10:47:44] (03Merged) 10jenkins-bot: Run language screenshots from Jenkins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299159 (https://phabricator.wikimedia.org/T139613) (owner: 10Zfilipin) [10:55:28] (03PS4) 10Esanders: Use surface fragments in IndentationAction methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/299564 [11:02:37] (03PS3) 10Divec: TransactionProcessor: Apply annotations to ranges at the highest uniform offset [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/299570 (https://phabricator.wikimedia.org/T140538) [11:04:47] (03PS3) 10Zfilipin: WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) [11:10:47] (03CR) 10jenkins-bot: [V: 04-1] WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) (owner: 10Zfilipin) [11:13:42] (03PS4) 10Zfilipin: WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) [11:30:13] (03PS3) 10Esanders: Use more surface fragments in paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300262 (https://phabricator.wikimedia.org/T140924) [11:30:15] (03PS3) 10Esanders: Annotate pasted external text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300263 [11:30:17] (03PS1) 10Esanders: Fix internal paste sanitization to not remove empty branch nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300852 [11:33:32] (03PS5) 10Zfilipin: WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) [11:33:45] (03CR) 10Divec: [C: 032] Check surface is set up in toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300257 (owner: 10Esanders) [11:34:42] (03CR) 10Divec: [C: 032] Allow newDocRange to be passed to SurfaceFragment#insertDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300258 (owner: 10Esanders) [11:36:27] (03Merged) 10jenkins-bot: Check surface is set up in toolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300257 (owner: 10Esanders) [11:36:44] (03CR) 10Divec: [C: 032] Make no change to selection if insertDocument is a no-op [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300259 (owner: 10Esanders) [11:37:22] (03Merged) 10jenkins-bot: Allow newDocRange to be passed to SurfaceFragment#insertDocument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300258 (owner: 10Esanders) [11:38:29] (03CR) 10Divec: [C: 032] Fix table paste tests to use dynamic retain-to-end operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300260 (owner: 10Esanders) [11:39:07] (03Merged) 10jenkins-bot: Make no change to selection if insertDocument is a no-op [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300259 (owner: 10Esanders) [11:40:52] (03Merged) 10jenkins-bot: Fix table paste tests to use dynamic retain-to-end operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300260 (owner: 10Esanders) [11:52:38] (03PS6) 10Zfilipin: WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) [11:55:54] (03CR) 10Divec: [C: 032] Add test for internal copy/paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300261 (owner: 10Esanders) [11:58:03] (03Merged) 10jenkins-bot: Add test for internal copy/paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300261 (owner: 10Esanders) [12:07:53] (03Abandoned) 10Zfilipin: WIP Use languages from build/screenshots.yml instead of build/screenshotLangs.json [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300844 (https://phabricator.wikimedia.org/T139613) (owner: 10Zfilipin) [13:35:03] Krenair: can you point me to an example of the onUpdate? [13:35:09] i can't find anything about [13:41:27] (03PS6) 10Esanders: Create SourceSurfaceFragment for editing source documents [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/298285 [14:01:36] 10VisualEditor, 10VisualEditor-MediaWiki: Context has wrong font size inside dialog - https://phabricator.wikimedia.org/T141262#2491948 (10Esanders) [14:02:01] (03PS1) 10Esanders: Only apply font fix to global overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300871 (https://phabricator.wikimedia.org/T141262) [14:11:49] 10VisualEditor, 10VisualEditor-MediaWiki: Context has wrong font size inside dialog - https://phabricator.wikimedia.org/T141262#2491948 (10matmarex) Issues like these will only continue happening until someone gears up and fixes T97631, so that we don't need to override font sizes everywhere. [14:12:47] 10VisualEditor, 10VisualEditor-MediaWiki: Context has wrong font size inside dialog - https://phabricator.wikimedia.org/T141262#2492001 (10matmarex) I think this is like seventh or eighth that I've seen. I really wish someone prioritized that. [14:30:34] (03PS2) 10Esanders: Fix internal paste sanitization to not remove empty branch nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300852 [14:30:36] (03PS4) 10Esanders: Use more surface fragments in paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300262 (https://phabricator.wikimedia.org/T140924) [14:30:38] (03PS4) 10Esanders: Annotate pasted external text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300263 [15:09:37] (03PS1) 10Zfilipin: WIP Run all language screenshots script for VisualEditor in Jenkins [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300882 (https://phabricator.wikimedia.org/T139613) [15:33:06] (03CR) 10Jforrester: [C: 04-1] Fix internal paste sanitization to not remove empty branch nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300852 (owner: 10Esanders) [15:58:10] (03CR) 10Jforrester: [C: 032] Only apply font fix to global overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300871 (https://phabricator.wikimedia.org/T141262) (owner: 10Esanders) [16:04:20] (03CR) 10Jforrester: [C: 031] "It'd be nice to find a way to use (and keep) the i18n, but…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300846 (https://phabricator.wikimedia.org/T132574) (owner: 10Zfilipin) [16:06:03] (03CR) 10jenkins-bot: [V: 04-1] Only apply font fix to global overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300871 (https://phabricator.wikimedia.org/T141262) (owner: 10Esanders) [16:32:45] (03CR) 10Jforrester: Only apply font fix to global overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300871 (https://phabricator.wikimedia.org/T141262) (owner: 10Esanders) [16:32:57] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300871 (https://phabricator.wikimedia.org/T141262) (owner: 10Esanders) [16:37:32] (03CR) 10Jforrester: [C: 032] Only apply font fix to global overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300871 (https://phabricator.wikimedia.org/T141262) (owner: 10Esanders) [16:45:30] (03Merged) 10jenkins-bot: Only apply font fix to global overlay [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300871 (https://phabricator.wikimedia.org/T141262) (owner: 10Esanders) [16:51:59] 10VisualEditor, 10VisualEditor-MediaWiki: Context has wrong font size inside dialog - https://phabricator.wikimedia.org/T141262#2492642 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [16:59:26] (03PS1) 10Jforrester: Update VE core submodule to master (2939527) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300904 [17:05:12] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (2939527) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300904 (owner: 10Jforrester) [17:05:29] Ooh, one button up-front approval. That'll never backfire on me. :D [17:12:09] (03Merged) 10jenkins-bot: Update VE core submodule to master (2939527) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300904 (owner: 10Jforrester) [17:51:40] (03CR) 10Alex Monk: Trigger a custom event on #wpTextbox1 when we need to get the latest wikitext out of it (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295444 (https://phabricator.wikimedia.org/T135747) (owner: 10Alex Monk) [17:51:55] yeah... the new review UI is going to take some getting used to [18:24:44] James_F, I was asked to bug people about this: https://phabricator.wikimedia.org/T138956 Is this VE or multimedia? Also, making sure you're aware of it since it seems to be happening frequently (on hewiki at least) [18:24:59] (03PS5) 10Jforrester: [BREAKING CHANGE] Drop support for contacting Parsoid without VirtualRestConfig [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268736 [18:26:10] (03CR) 10Jforrester: "PS5: Rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268736 (owner: 10Jforrester) [18:27:19] mooeypoo: It's VE. No need to bug people. [18:27:32] James_F, also, they all seem to be .docx [18:28:47] mooeypoo: Yeah. [18:28:51] (03CR) 10jenkins-bot: [V: 04-1] [BREAKING CHANGE] Drop support for contacting Parsoid without VirtualRestConfig [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/268736 (owner: 10Jforrester) [18:30:17] ... which [18:30:34] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2414935 (10matmarex) This could be just users pasting these into the link dialog and expecting them to work, not realizing that the URL refers to som... [18:48:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: Link to original template page broken when "template" is actually a relative sub-page - https://phabricator.wikimedia.org/T139135#2420521 (10AlexMonk-WMF) Looks like we're not properly accounting for everything the parser's maybeDo... [18:48:42] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2493293 (10Amire80) This is quite possible, but file:/// links are probably not useful in any case. (Maybe on some Intranet MediaWiki installations,... [19:03:17] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Link to original template page broken when "template" is actually a relative sub-page - https://phabricator.wikimedia.org/T139135#2493332 (10AlexMonk-WMF) I actually think this is a #Parsoid problem, from view-source:h... [19:07:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Link to original template page broken when "template" is actually a relative sub-page - https://phabricator.wikimedia.org/T139135#2493340 (10ssastry) 05Open>03Resolved a:03ssastry This is fixed in current master... [19:07:57] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2414935 (10DLynch) Just to confirm, pasting the link into the link inspector considers it valid, so it's not implausible that this is how it's happen... [19:08:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Link to original template page broken when "template" is actually a relative sub-page - https://phabricator.wikimedia.org/T139135#2493348 (10ssastry) But, the catch is, even after deploy, the stored HTML won't refresh... [19:21:56] (03PS2) 10DLynch: [WIP] Use "publish" instead of "save" in toolbar and save-dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281462 (https://phabricator.wikimedia.org/T131132) [19:22:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use "publish" instead of "save" in toolbar and save-dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281462 (https://phabricator.wikimedia.org/T131132) (owner: 10DLynch) [20:04:05] (03PS1) 10Alex Monk: Fix check for non-template-namespace transclusions [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/300952 [20:08:43] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2493641 (10Esanders) I think what happens is that we only switch to the external link tab if the protocol matches the list of allowed protocols in MW... [20:26:52] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2414935 (10Jdforrester-WMF) >>! In T138956#2493641, @Esanders wrote: > I think what happens is that we only switch to the external link tab if the pr... [20:55:34] 10Citoid, 10VisualEditor: [Regression pre-wmf.12] Automatic insertion of citation is failing with error "Cannot read property 'internal' of null" - https://phabricator.wikimedia.org/T141306#2493824 (10Ryasmeen) [21:44:33] (03PS1) 10DLynch: MWLinkAnnotationInspector: switch to external tab on any schema [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/301005 (https://phabricator.wikimedia.org/T138956) [21:44:53] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2493958 (10DLynch) a:03DLynch [22:08:18] 10Citoid, 10VisualEditor: [Regression pre-wmf.12] Automatic insertion of citation and inserting math function is failing with error "Cannot read property 'internal' of null" - https://phabricator.wikimedia.org/T141306#2494059 (10Ryasmeen) [22:19:25] ryasmeen: That's a very odd bug. [22:20:24] yeah, I thought its related with Citoid initially [22:21:31] 10VisualEditor: [Regression pre-wmf.12] Automatic insertion of citation and inserting math function is failing with error "Cannot read property 'internal' of null" - https://phabricator.wikimedia.org/T141306#2494080 (10Ryasmeen) [22:22:13] ryasmeen: No changes this month to that file (ve.dm.Node); no changes this year to that particular bit of the method (last change was in the first week of May). I guess we've changed something upstream. [22:24:28] 10VisualEditor: [Regression pre-wmf.12] Automatic insertion of citation and inserting math function is failing with error "Cannot read property 'internal' of null" from ve.dm.Node#cloneElement - https://phabricator.wikimedia.org/T141306#2494087 (10Jdforrester-WMF) p:05Triage>03Unbreak! [22:31:35] 10VisualEditor: [Regression pre-wmf.12] Automatic insertion of citation and inserting math function is failing with error "Cannot read property 'internal' of null" from ve.dm.Node#cloneElement - https://phabricator.wikimedia.org/T141306#2494097 (10Jdforrester-WMF) OK, so #cloneElement is getting called with `nul...