[01:29:35] 10Cite, 10MediaWiki-Internationalization, 07I18n, 13Patch-For-Review, 07RTL: parser tags such as , , etc. cannot be localized - https://phabricator.wikimedia.org/T30980#329856 (10Huji) @Amire80 I see you had abandoned this back in April. Any chance "some other time" could be Decembe... [02:32:47] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 10 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2867141 (10GWicke) Considering the upcoming deployment freezes and relatively low priority, the start of the roll-out is looking like January at this point. [06:46:32] 10Cite, 10MediaWiki-Internationalization, 07I18n, 13Patch-For-Review, 07RTL: parser tags such as , , etc. cannot be localized - https://phabricator.wikimedia.org/T30980#2867245 (10Amire80) Yes, I want to revive it very soon, at least for . [08:07:23] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editing a section in NWE scrolls to somewhere in the middle of the section - https://phabricator.wikimedia.org/T152946#2867354 (10Schnark) As far as I can see this is caused by hiding the TOC when switching into edit mode. This scrolls the page up (i... [08:41:54] 10VisualEditor, 10VisualEditor-MediaWiki-Links: When inserting link in VE, automatically convert referer links copied from Google search results into actual/proper URLs - https://phabricator.wikimedia.org/T153046#2867433 (10Schnark) [09:05:40] 10VisualEditor, 10VisualEditor-MediaWiki: List of pages in a missing category not visible when creating it in VE - https://phabricator.wikimedia.org/T153047#2867476 (10Schnark) [10:14:23] 10VisualEditor, 10WikiEditor, 06Editing-Department, 07Bengali-Sites: Request amendment of Bangla character set in WikiEditor - https://phabricator.wikimedia.org/T96494#2867653 (10MarcoAurelio) [10:19:34] 10VisualEditor, 10VisualEditor-MediaWiki: "Tech Talk" about visual diffs - https://phabricator.wikimedia.org/T152948#2864366 (10Qgil) Thank you for this proposal. Do you envision this talk as more user oriented or developer oriented? [10:32:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: Middle click / open in new tab/window doesn't work for NWE - https://phabricator.wikimedia.org/T153054#2868030 (10Esanders) [10:40:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: Middle click / open in new tab/window doesn't work for NWE - https://phabricator.wikimedia.org/T153054#2868030 (10Schnark) It does work with SET enabled, though, at least partially: With "Always give me visual editor if po... [10:44:26] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2868061 (10Esanders) 05Open>03Invalid From a random sample of about 20 images on it.wiki I only f... [10:47:10] 10VisualEditor, 10VisualEditor-MediaWiki: "Tech Talk" about visual diffs - https://phabricator.wikimedia.org/T152948#2868075 (10Elitre) I for one obviously need the user oriented thing. I am told that the developer oriented for this one requires a PhD or something to be understood... [10:47:46] (03PS6) 10Esanders: Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) [10:51:26] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2868101 (10Elitre) Maybe I failed to make my point here? I don't care about whether Immagine becomes... [10:53:18] (03CR) 10jenkins-bot: [V: 04-1] Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) (owner: 10Esanders) [10:56:47] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid, 07Regression: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2868121 (10Peachey88) [11:02:12] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid, 07Regression: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2865379 (10matmarex) It seems that "file" is genuinely considered an Italian word by... [11:05:23] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid, 07Regression: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2868166 (10matmarex) "File" is also translated to "File" in the names of some special... [11:15:55] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid, 07Regression: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2868236 (10Elitre) I appreciate your insight, although it does not answer my question. [11:21:23] 10VisualEditor, 10VisualEditor-MediaWiki, 06Community-Liaisons: "Tech Talk" about visual diffs - https://phabricator.wikimedia.org/T152948#2868267 (10Qgil) [11:21:30] 10VisualEditor: Editor dialog option for all wikis at once - https://phabricator.wikimedia.org/T153062#2868268 (10Aklapper) [11:21:55] 10VisualEditor: "Start editing" popup should probably say "Continue editing" - https://phabricator.wikimedia.org/T135938#2868270 (10Aklapper) 05Open>03declined [11:27:38] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid, 07Regression: [Regression] Editing a gallery converts localized name for "File:" to English one - https://phabricator.wikimedia.org/T152981#2868287 (10matmarex) This is happening because: 1. "File" is the canonical name for... [11:30:01] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid, 07Regression: [Regression] Editing a gallery converts any alias name for "File:" namespace to canonical localized one - https://phabricator.wikimedia.org/T152981#2868302 (10matmarex) 05Invalid>03Open p:05High>03Normal [11:30:59] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid, 07Regression: [Regression] Editing a gallery converts any alias name for "File:" namespace to canonical localized one - https://phabricator.wikimedia.org/T152981#2865379 (10matmarex) (There's clearly a bug here. This might be... [12:00:25] (03CR) 10Bartosz Dziewoński: [C: 04-1] "OK, looks fine, I can merge this. But tests are failing now (stylelint, and missing API documentation messages)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) (owner: 10Esanders) [12:06:14] (03PS1) 10Esanders: Resize save dialog after showing captcha [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326925 [12:10:20] (03PS7) 10Esanders: Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) [12:21:09] (03PS8) 10Esanders: Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) [12:24:02] (03CR) 10Esanders: "Fixed #4. #3 would be a lot of effort, and then we'd have to disable all the tools except italic and special character. Probably best to j" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) (owner: 10Esanders) [12:57:58] (03PS1) 10Esanders: Don't focus save dialog during setup to avoid scroll jumping [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326930 (https://phabricator.wikimedia.org/T153010) [13:33:37] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2868735 (10Mvolz) [13:43:26] (03CR) 10Bartosz Dziewoński: [C: 032] Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) (owner: 10Esanders) [13:55:34] (03Merged) 10jenkins-bot: Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) (owner: 10Esanders) [14:37:07] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2868955 (10Mvolz) [14:37:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Support 'Add topic' in NWE - https://phabricator.wikimedia.org/T150709#2794061 (10Dvorapa) Is there some similar task for VE? [14:38:16] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#1845065 (10Mvolz) [15:19:49] (03PS1) 10Esanders: Follow-up I6eda4a7c: Fix typos in #updateTabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326968 [15:20:59] (03CR) 10Jforrester: [C: 032] Follow-up I6eda4a7c: Fix typos in #updateTabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326968 (owner: 10Esanders) [15:22:47] (03CR) 10Jforrester: [C: 032] Don't focus save dialog during setup to avoid scroll jumping [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326930 (https://phabricator.wikimedia.org/T153010) (owner: 10Esanders) [15:28:49] (03PS1) 10Esanders: Add section= param to URL after loading target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326969 [15:31:23] (03Merged) 10jenkins-bot: Follow-up I6eda4a7c: Fix typos in #updateTabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326968 (owner: 10Esanders) [15:31:25] (03Merged) 10jenkins-bot: Don't focus save dialog during setup to avoid scroll jumping [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326930 (https://phabricator.wikimedia.org/T153010) (owner: 10Esanders) [15:37:05] (03PS2) 10Esanders: Add section= param to URL after loading target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326969 [15:37:07] (03PS1) 10Esanders: Fix action=editsource URL rewriting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326975 (https://phabricator.wikimedia.org/T153054) [15:45:29] (03PS1) 10Esanders: Don't restore scroll position when doing real section editing (NWE) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326977 (https://phabricator.wikimedia.org/T152946) [15:46:22] 10VisualEditor: Editing mode option does not change anything in hywiktionary - https://phabricator.wikimedia.org/T152768#2869115 (10Ashot1997) p:05Triage>03High [16:04:59] (03CR) 10Jforrester: [C: 032] Add section= param to URL after loading target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326969 (owner: 10Esanders) [16:07:34] (03PS1) 10Esanders: Fix logic for create accesskey=v, and bind to onEditTabClick [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326981 [16:07:36] (03CR) 10Jforrester: [C: 032] Fix action=editsource URL rewriting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326975 (https://phabricator.wikimedia.org/T153054) (owner: 10Esanders) [16:09:10] (03CR) 10Jforrester: [C: 032] Don't restore scroll position when doing real section editing (NWE) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326977 (https://phabricator.wikimedia.org/T152946) (owner: 10Esanders) [16:12:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design: Add a "only available in visual mode" tooltip to disabled tools in NWE? - https://phabricator.wikimedia.org/T151260#2812493 (10Esanders) We currently only have tooltips for menu groups, not individual menu items - which blocks this. [16:13:33] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Support 'Add topic' in NWE - https://phabricator.wikimedia.org/T150709#2869199 (10Jdforrester-WMF) 05Open>03Resolved >>! In T150709#2868956, @Dvorapa wrote: > Is there some similar task for VE? No; we ca... [16:14:14] 10VisualEditor, 10VisualEditor-MediaWiki, 07Browser-Support-Apple-Safari, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Clicking the Save button in the toolbar scrolls the page to the end in Safari 10 - https://phabricator.wikimedia.org/T153010#2869202 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [16:14:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editing a section in NWE scrolls to somewhere in the middle of the section - https://phabricator.wikimedia.org/T152946#2869206 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [16:15:46] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: Middle click / open in new tab/window doesn't work for NWE - https://phabricator.wikimedia.org/T153054#2869209 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [16:16:55] 10VisualEditor, 10VisualEditor-MediaWiki: List of pages in a missing category not visible when creating it in VE - https://phabricator.wikimedia.org/T153047#2869216 (10Jdforrester-WMF) p:05Triage>03Low [16:24:05] (03Merged) 10jenkins-bot: Add section= param to URL after loading target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326969 (owner: 10Esanders) [16:24:07] (03Merged) 10jenkins-bot: Fix action=editsource URL rewriting [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326975 (https://phabricator.wikimedia.org/T153054) (owner: 10Esanders) [16:25:16] 10VisualEditor: Editing mode option does not change anything in hywiktionary - https://phabricator.wikimedia.org/T152768#2869235 (10Jdforrester-WMF) 05Open>03stalled It seems to work for me. What you describe sounds like the visual editor is not loading because it thinks your browser is unsupported. Do you... [16:33:17] (03Merged) 10jenkins-bot: Don't restore scroll position when doing real section editing (NWE) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326977 (https://phabricator.wikimedia.org/T152946) (owner: 10Esanders) [16:34:07] Getting an alert with a curl timeout error when the blue progress bar is like 75% across [16:34:15] Any idea how to find what's timing out? :) [16:35:16] 10VisualEditor, 10UI-Standardization, 07Accessibility, 03UI-Standardization-Kanban: Apply color palette colors to VE save changes dialog and ensure color contrast - https://phabricator.wikimedia.org/T153086#2869258 (10Volker_E) [16:36:06] Reedy: That'd be the RB call failing, I think. [16:36:33] Hmm [16:36:39] https://www.mediawiki.org/wiki/Extension:VisualEditor#Setting_VisualEditor_up of course doesn't mention restbase ;) [16:37:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 07Accessibility, 03UI-Standardization-Kanban: Apply color palette colors to VE save changes dialog and ensure color contrast - https://phabricator.wikimedia.org/T153086#2869280 (10Jdforrester-WMF) p:05Triage>03Low [16:38:09] Reedy: s/RB/Virtual REST Service/ [16:38:27] It could be RB-backed or direct-onto-Parsoid-backed or something else. [16:41:26] Reedy, what error? [16:42:07] "(curl error: 28) Timeout was reached" [16:42:10] in an alert [16:42:21] and trying to got onother page then gives "http" [16:42:26] that'll be our server-side code failing to contact parsoid [16:42:36] paste your settings [16:43:18] (03PS1) 10Esanders: Allow switching between 'edit source' and 'add topic' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326990 [16:44:23] IIRC, 'http' is the error code giving by MW's JS API client [16:44:36] and we have a task open about making it more specific [16:44:40] given* [16:45:19] (03CR) 10Esanders: [C: 04-1] "refactoring" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326990 (owner: 10Esanders) [16:45:56] Which parts? [16:46:18] whichever parts you've added for VE [16:46:31] there's a bunch of different ways to configure this [16:46:41] lol [16:47:51] $wgVirtualRestConfig['modules']['parsoid'] = array( [16:47:52] 'url' => 'http://35.185.22.106:8142', [16:47:52] ); [16:47:54] Literally that [16:48:12] And changing it from localhost in /etc/mediawiki/parsoid/settings.js [16:48:17] can you "curl 'http://35.185.22.106:8142'" from the server MW runs on? [16:49:31] Nope.. Seems not [16:49:33] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Support 'Add topic' in NWE - https://phabricator.wikimedia.org/T150709#2869378 (10Dvorapa) >>! In T150709#2869199, @Jdforrester-WMF wrote: > No; we can't support `section=new` in VE for the same reason we can... [16:50:08] Reedy, well... that'll probably be the issue. are MW and parsoid on the same machine? [16:50:11] Are the docs right about port 8142? [16:50:12] Yup [16:50:23] and if it's not *the* issue, it'll at least be *a* issue [16:50:36] is parsoid actually running on that port? check with lsof [16:51:52] nodejs 1716 parsoid 11u IPv6 17727 0t0 TCP *:8142 (LISTEN) [16:51:55] Only on IPv6? [16:52:09] interesting [16:52:12] you sure about that? [16:52:21] huh... [16:52:37] lsof | grep parsoid | grep 8142 [16:52:42] all of them say IPv6 [16:53:56] in the parsoid log it doesn't like an IP as the domain it seems [16:53:57] {"name":"parsoid","hostname":"catalog-wikibase","pid":1960,"level":60,"err":{"message":"Invalid domain: 35.185.22.106","name":"../src/lib/index.js","stack":"../src/lib/index.js: Invalid domain: 35.185.22.106 [16:54:20] how exactly is that not a valid domain? [16:54:33] * Krenair sighs [16:54:38] fuck node? [16:55:08] It's only on an IP till things are setup [16:55:23] I could ask we move it to a proper domain... As it's in more of a working state than the old wiki was :P [16:55:56] Parsoid shouldn't (and indeed, doesn't) need a domain pointing to anything to work [16:56:09] at least, with the two week old version I run [16:56:30] parsoid is from the wmf deb [16:56:47] wait [16:57:09] this is erroring due to the config pointing it to mediawiki? [16:57:31] scratch the "doesn't", it may or may not. hm [16:59:16] okay [16:59:19] lib/config/ParsoidConfig.js [16:59:36] line 462 in whatever version this is I'm looking at [16:59:41] apiConf.domain = url.parse(apiConf.uri).host [16:59:55] Reedy, paste your parsoid config? [17:00:02] Krenair: oh look [17:00:10] curl 'http://[::1]:8142' [17:00:12] that works fine [17:00:22] well [17:00:30] you could just point it at that [17:00:38] Seems a shit fix though [17:00:41] indeed [17:01:09] (03PS2) 10Esanders: Allow switching between 'edit source' and 'add topic' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326990 [17:01:24] # Allow override of port/interface: [17:01:24] #serverPort: 8000 [17:01:24] #serverInterface: '127.0.0.1 [17:02:27] the whole config [17:02:37] /etc/mediawiki/parsoid/config.yaml ? [17:02:43] yeah [17:03:03] https://p.defau.lt/?_Fc4VHgTtDcLQnD2w1gCrg [17:03:32] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Empty lines are deleted when pasting text - https://phabricator.wikimedia.org/T152671#2869406 (10Esanders) WFM in Chrome, but not Firefox. Are you using Firefox? [17:03:46] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 07Accessibility, 03UI-Standardization-Kanban: Apply color palette colors to VE save changes dialog and ensure color contrast - https://phabricator.wikimedia.org/T153086#2869407 (10Volker_E) [17:03:52] ii parsoid 0.6.1all all Web service converting HTML+RDFa to MediaWiki wikitext and back [17:03:54] well [17:04:22] this is a different config format to mine [17:04:38] wait, you set domain explicitly in there? [17:04:57] did you just do that or was it like that when you had the error about invalid domains? [17:05:46] I didn't change the domain [17:05:51] just hte uri [17:06:15] from what? [17:06:42] http://localhost/w/api.php [17:08:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Browser-Support-Firefox: NWE: Empty lines are deleted when pasting text in Firefox - https://phabricator.wikimedia.org/T152671#2869429 (10Jdforrester-WMF) [17:08:28] well [17:08:32] that's not what it had problems with [17:09:01] The documentation is hardly great :P [17:09:52] but you set domain: 'localhost', and it thinks the domain is the IP still [17:10:05] yeah, maybe ask in #mediawiki-parsoid [17:10:17] I didn't set domain: 'localhost' it defaulted to that [17:10:19] oh [17:10:31] Isn't it a unix "bug" that localhost favours ipv6? [17:10:43] And maybe node/parsoid just does that too [17:11:00] don't you still see the invalid domain error though? [17:11:03] (03CR) 10Jforrester: [C: 032] Resize save dialog after showing captcha [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326925 (owner: 10Esanders) [17:12:15] seemingly not [17:13:11] so wait, which was the change that made that go away? [17:14:04] I didn't change anything [17:14:23] last timestamp of that is 17:07 [17:16:06] (03PS1) 10DLynch: DesktopArticleTarget: Generate the original page title if needed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326999 (https://phabricator.wikimedia.org/T126077) [17:16:15] you changed nothing and got two different behaviours [17:16:20] well [17:16:23] that's helpful [17:16:38] * Reedy shrugs [17:17:02] Lots of helpful messages going on :P [17:17:07] ^^^ There's actually a few other differences there, if loading on top of the classic editor. Most notably the categories are missing. [17:17:13] (error messages) [17:17:30] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 10Parsoid: Editing a gallery with pre-native code converts any alias name for "File:" namespace to canonical localized one - https://phabricator.wikimedia.org/T152981#2869451 (10Jdforrester-WMF) 05Open>03declined [17:18:04] It made my debugging life much easier when I snuck `$wgVisualEditorFullRestbaseURL = false;` into my settings. [17:19:21] (03Merged) 10jenkins-bot: Resize save dialog after showing captcha [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326925 (owner: 10Esanders) [17:24:14] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Browser-Support-Firefox: NWE: Empty lines are deleted when pasting text in Firefox - https://phabricator.wikimedia.org/T152671#2869498 (10Esanders) Looks like Firefox pastes `

Foo

Bar

` instead of `

Foo


Bar

` w... [17:24:29] (03PS1) 10Esanders: WIP Failing tests for Firefox linebreaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/327004 (https://phabricator.wikimedia.org/T152671) [17:28:11] (03CR) 10jenkins-bot: [V: 04-1] WIP Failing tests for Firefox linebreaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/327004 (https://phabricator.wikimedia.org/T152671) (owner: 10Esanders) [17:43:42] (03PS2) 10Esanders: Fix
sanitization. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/327004 (https://phabricator.wikimedia.org/T152671) [17:49:49] 10VisualEditor, 10MediaWiki-API, 07Verified, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): [Regression pre-wmf.6] Cannot save any edit with VisualEditor getting error "The parameters "page" and "oldid" can not be used together." - https://phabricator.wikimedia.org/T152547#2869605 (10Ryasmeen) [17:51:44] 10VisualEditor, 10VisualEditor-MediaWiki, 07Verified, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Category link at the bottom of a page does not get updated in the same session when I add/delete category from Options - https://phabricator.wikimedia.org/T151651#2869610 (10Ryasmeen) [17:53:43] (03PS1) 10VolkerE: Apply color palette colors and ensure sufficient contrast [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327011 (https://phabricator.wikimedia.org/T153086) [17:56:54] 10VisualEditor, 10Beta-Cluster-Infrastructure: Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869638 (10Ryasmeen) [18:10:24] (03PS1) 10Esanders: Show save button on show preview page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327014 (https://phabricator.wikimedia.org/T151261) [18:11:43] (03CR) 10Jforrester: [C: 04-1] Apply color palette colors and ensure sufficient contrast (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327011 (https://phabricator.wikimedia.org/T153086) (owner: 10VolkerE) [18:12:08] (03CR) 10Jforrester: [C: 032] Show save button on show preview page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327014 (https://phabricator.wikimedia.org/T151261) (owner: 10Esanders) [18:12:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: In NWE, provide a "save" button in preview mode - https://phabricator.wikimedia.org/T151261#2869707 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [18:14:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-FlaggedRevs: NWE: Hide reviewbox (from extension FlaggedRevisions) while in source mode - https://phabricator.wikimedia.org/T151615#2822841 (10Esanders) Can you give an example URL with the box showing? [18:18:32] edsanders, the URL in the screenshot shows it [18:22:16] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10RESTBase: Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869746 (10AlexMonk-WMF) [18:22:32] (03Merged) 10jenkins-bot: Show save button on show preview page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327014 (https://phabricator.wikimedia.org/T151261) (owner: 10Esanders) [18:23:27] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10RESTBase: Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869638 (10AlexMonk-WMF) https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/User%3ARYasmeen_(... [18:24:32] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Parsoid, 06Services (watching): Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869755 (10Pchelolo) According to the logs it's a #parsoid problem: ``` Cannot... [18:26:12] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Parsoid, 06Services (watching): Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869757 (10ssastry) p:05Triage>03Normal a:03Legoktm [18:26:38] 10VisualEditor, 10Parsoid, 07Beta-Cluster-reproducible, 06Services (watching): Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869763 (10AlexMonk-WMF) [18:27:24] (03CR) 10VolkerE: Apply color palette colors and ensure sufficient contrast (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327011 (https://phabricator.wikimedia.org/T153086) (owner: 10VolkerE) [18:28:18] (03PS2) 10VolkerE: Apply color palette colors and ensure sufficient contrast [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327011 (https://phabricator.wikimedia.org/T153086) [18:28:36] (03CR) 10VolkerE: Apply color palette colors and ensure sufficient contrast (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327011 (https://phabricator.wikimedia.org/T153086) (owner: 10VolkerE) [18:28:53] 10VisualEditor: Editing mode option does not change anything in hywiktionary - https://phabricator.wikimedia.org/T152768#2869776 (10Ashot1997) Thanks for your response, @Jdforrester-WMF ․ Can you restore all default settings in hywiktionary, please? I don't think so :/ because I use VisualEditor in other wikis w... [18:33:06] 10VisualEditor, 10Parsoid, 07Beta-Cluster-reproducible, 06Services (watching): Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869638 (10ssastry) Reproducible as: ``` $ parse.js --lint --apiURL https://en.w... [18:39:04] 10VisualEditor, 10Parsoid, 07Beta-Cluster-reproducible, 06Services (watching): Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869821 (10ssastry) [18:44:33] 10VisualEditor: Editor dialog option for all wikis at once - https://phabricator.wikimedia.org/T153062#2869866 (10AlexMonk-WMF) [18:59:37] 10VisualEditor: Visual Editor creates unnecessary pipelinks - https://phabricator.wikimedia.org/T153107#2869956 (10Cirdan) [19:04:15] 10VisualEditor: Visual Editor creates unnecessary pipelinks - https://phabricator.wikimedia.org/T153107#2869977 (10Cirdan) [19:11:56] 10VisualEditor: Visual Editor creates unnecessary pipelinks - https://phabricator.wikimedia.org/T153107#2870002 (10Jdforrester-WMF) [19:20:14] (03CR) 10Jforrester: [C: 032] getlanglinks: Get rid of backwards-compat stuff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309360 (owner: 10Alex Monk) [19:26:44] (03PS3) 10Jforrester: SaveDialog: Align colour palette and ensure sufficient contrast [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327011 (https://phabricator.wikimedia.org/T153086) (owner: 10VolkerE) [19:26:48] (03CR) 10Jforrester: [C: 032] SaveDialog: Align colour palette and ensure sufficient contrast [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327011 (https://phabricator.wikimedia.org/T153086) (owner: 10VolkerE) [19:29:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 07Accessibility, and 2 others: Apply color palette colors to VE save changes dialog and ensure color contrast - https://phabricator.wikimedia.org/T153086#2870081 (10Esanders) Can you post an 'after' screenshot? [19:29:54] (03Merged) 10jenkins-bot: getlanglinks: Get rid of backwards-compat stuff [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309360 (owner: 10Alex Monk) [19:38:53] (03Merged) 10jenkins-bot: SaveDialog: Align colour palette and ensure sufficient contrast [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327011 (https://phabricator.wikimedia.org/T153086) (owner: 10VolkerE) [19:44:40] 10VisualEditor, 10WikiEditor: Redlinks should open the respective editor that's set in the user or global settings - https://phabricator.wikimedia.org/T152593#2870139 (10Jdforrester-WMF) There is no bug here beyond {T55441}. It is a serious issue, which is why we've put so much effort into that fix for it. Ho... [20:07:09] 10VisualEditor, 10VisualEditor-MediaWiki: With VisualEditor beta-disabled, pipes are missing on other extensions using SkinEditSectionLinks - https://phabricator.wikimedia.org/T146564#2870272 (10Jdforrester-WMF) p:05Triage>03Low Ah, interesting, we upstreamed that CSS class a little prematurely. Let's fix... [20:08:31] 10VisualEditor: Edit notices box not displaying all the items or not displaying them well? - https://phabricator.wikimedia.org/T153118#2870277 (10Elitre) [20:08:51] 10VisualEditor: VisualEditor does not respect trailing chars - https://phabricator.wikimedia.org/T129778#2870293 (10Jdforrester-WMF) [20:09:54] 10VisualEditor: Insertion of nowiki tags at the nowiki project - https://phabricator.wikimedia.org/T150140#2870296 (10Jdforrester-WMF) 05Open>03stalled At this point everything posted is marked as Resolved or merged into {T50463}; close in lieu of that? [20:10:27] 10VisualEditor: Insertion of out of sync link text at the no.wiki project - https://phabricator.wikimedia.org/T150141#2870304 (10Jdforrester-WMF) [20:10:34] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2870302 (10Jdforrester-WMF) [20:12:02] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VE silently alters the HTML of an invalid wikitext sequence of a link with an image in the label, which dirty-diffs - https://phabricator.wikimedia.org/T150196#2870306 (10Jdforrester-WMF) p:05Triage>03Low [20:15:28] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10VisualEditor-MediaWiki-Templates, 07Design: Come up with a nice way to edit the target of a link whose anchor is a node - https://phabricator.wikimedia.org/T150197#2870319 (10Jdforrester-WMF) p:05Triage>03Low [20:16:39] 10TemplateData, 10VisualEditor: Parameters are sometimes(?) being rearranged randomly instead of following the expected order, defined in TemplateData - https://phabricator.wikimedia.org/T150763#2870324 (10Jdforrester-WMF) 05Open>03stalled p:05Triage>03High [20:17:04] 10TemplateData, 10VisualEditor: Parameters are sometimes(?) being rearranged randomly instead of following the expected order, defined in TemplateData - https://phabricator.wikimedia.org/T150763#2795725 (10Jdforrester-WMF) We've got several reports (on different wikis), but no-one can figure out what the cause... [20:21:19] 10VisualEditor: Categories moved by VE from the bottom of the article to a content section - https://phabricator.wikimedia.org/T151035#2870336 (10Jdforrester-WMF) 05Open>03declined This is because the user cut-and-pasted the category section and the visual editor did what they "told" it to (but probably didn... [20:24:26] 10VisualEditor, 10VisualEditor-MediaWiki: Edit notices box not displaying all the items or not displaying them well? - https://phabricator.wikimedia.org/T153118#2870339 (10Jdforrester-WMF) p:05Triage>03Normal Can confirm, `titleprotectedwarning` isn't getting populated, and, it looks like `recreate-movedde... [20:28:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: enable visual editor in Wikiprojects spaces on English Wikipedia - https://phabricator.wikimedia.org/T152794#2870346 (10Jdforrester-WMF) 05Open>03stalled p:05Triage>03Normal @Stryn is correct, we can only enable the visual editor in... [20:29:01] 10VisualEditor, 10VisualEditor-MediaWiki-Links: When inserting link in VE, automatically convert referer links copied from Google search results into actual/proper URLs - https://phabricator.wikimedia.org/T153046#2867433 (10Jdforrester-WMF) Interesting idea. I'm a bit worried about the potential for this to ge... [20:42:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 07Accessibility, and 2 others: Apply color palette colors to VE save changes dialog and ensure color contrast - https://phabricator.wikimedia.org/T153086#2870444 (10Volker_E) 05Open>03Resolved [20:45:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 07Accessibility, and 2 others: Apply color palette colors to VE save changes dialog and ensure color contrast - https://phabricator.wikimedia.org/T153086#2870454 (10Jdforrester-WMF) 05Resolved>03Open [20:45:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 07Accessibility, and 2 others: Apply color palette colors to VE save changes dialog and ensure color contrast - https://phabricator.wikimedia.org/T153086#2870457 (10Volker_E) 05Open>03Resolved [20:45:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 07Accessibility, and 2 others: Apply color palette colors to VE save changes dialog and ensure color contrast - https://phabricator.wikimedia.org/T153086#2869258 (10Jdforrester-WMF) Ha. [20:45:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10UI-Standardization, 07Accessibility, and 2 others: Apply color palette colors to VE save changes dialog and ensure color contrast - https://phabricator.wikimedia.org/T153086#2870463 (10Volker_E) @Esanders Just realized, that the before featured a already patched... [21:03:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: enable visual editor in Wikiprojects spaces on English Wikipedia - https://phabricator.wikimedia.org/T152794#2870524 (10Mrjohncummings) @Jdforrester-WMF thanks for your reply, a couple of questions: * How much work would be needed to allow... [21:12:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: enable visual editor in Wikiprojects spaces on English Wikipedia - https://phabricator.wikimedia.org/T152794#2870555 (10Jdforrester-WMF) >>! In T152794#2870524, @Mrjohncummings wrote: > @Jdforrester-WMF thanks for your reply, a couple of qu... [21:37:16] (03CR) 10Jforrester: [C: 032] "Let's merge this. Use by Parsoid is close but not complete yet, but there's three weeks until the next deploy, plenty of time to clean thi" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/306975 (https://phabricator.wikimedia.org/T138492) (owner: 10C. Scott Ananian) [21:52:47] (03Merged) 10jenkins-bot: Extend 'format' spec to include custom format strings. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/306975 (https://phabricator.wikimedia.org/T138492) (owner: 10C. Scott Ananian) [21:55:31] 10TemplateData, 10VisualEditor, 13Patch-For-Review, 07User-notice: Add support for actual format strings to TemplateData's "format" parameter - https://phabricator.wikimedia.org/T138492#2870759 (10Jdforrester-WMF) The change to add this to TemplateData is now merged; I'll wait to mark this Resolved once th... [22:11:19] (03PS1) 10Esanders: Add shortcut for show preview and resolve access key conflicts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327111 (https://phabricator.wikimedia.org/T149914) [22:17:31] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: enable visual editor in Wikiprojects spaces on English Wikipedia - https://phabricator.wikimedia.org/T152794#2870871 (10Mrjohncummings) Thanks @Jdforrester-WMF , really helpful, two more follow ups: * Where would be best to propose the ide... [22:18:08] (03CR) 10jenkins-bot: [V: 04] Add shortcut for show preview and resolve access key conflicts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327111 (https://phabricator.wikimedia.org/T149914) (owner: 10Esanders) [22:28:04] Krenair: I went to that URL but didn't see the tool mentioned [22:28:29] did you have nwe enabled? [22:28:45] yes [22:28:47] https://de.wikipedia.beta.wmflabs.org/wiki/Katze%20Muse?veaction=editsource [22:29:10] is that box shown to all users? [22:29:40] The "Diese Version erneut sichten" box? [22:29:58] yeah [22:30:02] it's not there for me [22:30:10] assumed it's shown to all users who can edit and therefore undo, haven't read the FlaggedRevs code [22:33:02] apparently you need review rights [22:34:20] and... apparently my account is in the Sichter group. okay... [22:34:38] which has review rights, it's the 'editor' group [22:35:50] https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Spezial%3ALogbuch&type=&user=&page=Benutzer%3AKrenair&year=&month=-1&tagfilter=&hide_thanks_log=1&hide_patrol_log=1&hide_tag_log=1&hide_review_log=1 [22:35:51] okay [22:36:05] edsanders, want me to put that on your account? [22:47:55] thanks [22:53:50] done: https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Spezial:Benutzerrechte/ESanders_(WMF) [23:04:37] 'Unaccept' eh :/ [23:08:18] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-FlaggedRevs: NWE: Hide reviewbox (from extension FlaggedRevisions) while in source mode - https://phabricator.wikimedia.org/T151615#2871040 (10Esanders) I don't see any reason why it should be visible in VE, but not source. I... [23:09:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-FlaggedRevs: NWE: Hide reviewbox (from extension FlaggedRevisions) while in source mode - https://phabricator.wikimedia.org/T151615#2871048 (10Jdforrester-WMF) 05Open>03declined Agreed. [23:11:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-extensions-FlaggedRevs: NWE: Hide reviewbox (from extension FlaggedRevisions) while in source mode - https://phabricator.wikimedia.org/T151615#2871068 (10Esanders) That said it's not our extension. If FlaggedRevs wants to hide itself wh... [23:20:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design, 07Epic: Provide a second version of a beta modern wikitext editor integrated into the visual editor - https://phabricator.wikimedia.org/T142523#2871100 (10Jdforrester-WMF) [23:20:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Round-trip transformations applied in NWE end up adding - https://phabricator.wikimedia.org/T147767#2871096 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders Fixed... [23:21:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Beta-Feature, and 2 others: Provide a Beta Feature of a modern wikitext editor integrated into the visual editor - https://phabricator.wikimedia.org/T141149#2871102 (10Jdforrester-WMF) a:03Jdforrester-WMF [23:23:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Getting "Error loading data from server: [object Object]" while trying to save an empty page with NWE - https://phabricator.wikimedia.org/T151022#2871121 (10Jdforrester-WMF) 05Open>03Resolved a:03AlexMonk-WMF Indeed. [23:25:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Clicking on section link opens OWE instead of NWE when Editing mode is set to "Always Source Editor" - https://phabricator.wikimedia.org/T151021#2871157 (10Jdforrester-WMF) p:05Normal>03High I can't replicate step 2 — now when "always source mode... [23:26:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Browser-Support-Firefox, 13Patch-For-Review: NWE: Empty lines are deleted when pasting text in Firefox - https://phabricator.wikimedia.org/T152671#2871160 (10Jdforrester-WMF) a:03Esanders [23:26:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Add Keyboard shortcuts for show changes (VE + NWE) and show preview (NWE) - https://phabricator.wikimedia.org/T149914#2871161 (10Jdforrester-WMF) a:03DLynch