[02:34:32] 10TemplateData, 10VisualEditor, 10Community-Tech: Ignore multiple same-name fields when guessing template params - https://phabricator.wikimedia.org/T193265#4166974 (10Samwilson) I think this is completely within TemplateData, and TemplateWizard doesn't need to do anything. Anyone using the `includeMissingTi... [02:50:25] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-TemplateWizard, 10Community-Tech-Sprint, and 2 others: Guess parameters for templates without TemplateData - https://phabricator.wikimedia.org/T191756#4166977 (10Samwilson) https://gerrit.wikimedia.org/r/#/c/427853/ is ready for review. But I was wond... [05:56:37] (03PS1) 10Santhosh: MWLinkAnnotationInspector: Allow customization of annotation inputs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429712 [05:57:33] (03CR) 10Santhosh: "Required by: https://gerrit.wikimedia.org/r/c/429405/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429712 (owner: 10Santhosh) [06:32:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429715 (owner: 10L10n-bot) [08:00:46] 10VisualEditor, 10ContentTranslation, 10Language-2018-Apr-June, 10Language-2018-Jan-Mar, and 3 others: CX2 translation view: JQMIGRATE: jQuery.fn.offset() requires an element connected to a document - https://phabricator.wikimedia.org/T188077#4167324 (10Pginer-WMF) 05Open>03Resolved [09:33:17] 10VisualEditor, 10VisualEditor-Tables: Make it possible to convert from a list to a table (and vice versa) - https://phabricator.wikimedia.org/T193362#4167463 (10Esanders) p:05Triage>03Low This seems like a somewhat specialist use case. Even if we did have a tool it would not be obvious how to expose it to... [09:34:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Section edit links on file pages for Commons images don't work - https://phabricator.wikimedia.org/T193323#4167466 (10Esanders) [09:58:22] (03PS1) 10Esanders: Check link 'host' in onEditSectionLinkClick [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429757 (https://phabricator.wikimedia.org/T193323) [09:59:02] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Section edit links on file pages for Commons images don't work - https://phabricator.wikimedia.org/T193323#4167493 (10Esanders) [09:59:04] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): Section edit links on file pages for Commons images don't work - https://phabricator.wikimedia.org/T193323#4165995 (10Esanders) a:03Esanders [10:00:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, and 2 others: Ctrl+Shift+X is ignored when using Syntax Highlighting on 2017 wikitext editor - https://phabricator.wikimedia.org/T193288#4167496 (10Esanders) [10:06:41] (03PS1) 10Esanders: Follow-up Ib7e769e: Fix typos in static method calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429759 (https://phabricator.wikimedia.org/T193217) [10:07:31] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Patch-For-Review, 10VisualEditor (Current work): The 2017 wikitext editor throws `this.buildRedirectSub is not a function` when making edits on redirects - https://phabricator.wikimedia.org/T193217#4167511 (10Esanders) a:03Esanders [10:20:16] 10TemplateData, 10VisualEditor, 10Community-Tech: Ignore multiple same-name fields when guessing template params - https://phabricator.wikimedia.org/T193265#4164628 (10Esanders) The problem is you can't really know for sure if one variable in an alias of another without fully parsing the template syntax. Us... [10:23:32] 10VisualEditor: Switching to VE from NWE while keeping the link inspector/Add Citation dialog open throws error "Uncaught TypeError: Cannot read property 'model' of undefined" - https://phabricator.wikimedia.org/T193103#4159845 (10Esanders) This is probably a duplicate of T122910 and fixed by https://gerrit.wiki... [10:49:57] 10VisualEditor, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-This-Quarter): Flow with VE breaks when trying to insert links - https://phabricator.wikimedia.org/T172634#4167621 (10MarcoAurelio) [11:20:10] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Simply cloning diff header doesn't seem like a good idea - https://phabricator.wikimedia.org/T192755#4148714 (10Deskana) >>! In T192755#4165632, @TheDJ wrote: > Many people complaining about missing twinkle links in the diff view. https://en.wikipedia.... [11:24:05] 10VisualEditor: Intermittent "Error loading data from server" error using VE in Firefox and Chrome on officewiki - https://phabricator.wikimedia.org/T187951#4167697 (10Deskana) [11:26:04] 10VisualEditor: Intermittent "Error loading data from server" error using VE in Firefox and Chrome on officewiki - https://phabricator.wikimedia.org/T187951#3991118 (10Deskana) I'm going to rescope this to only be about officewiki. The bulk of the reports here are about that, and it seems very possible that the... [11:46:15] (03PS1) 10Esanders: Fully disable the surface before teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429772 (https://phabricator.wikimedia.org/T193103) [13:18:40] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual differences beta feature breaks Twinkle - https://phabricator.wikimedia.org/T193397#4167880 (10Waddie96) [13:25:19] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Simply cloning diff header doesn't seem like a good idea - https://phabricator.wikimedia.org/T192755#4167909 (10Deskana) [13:25:21] 10VisualEditor, 10VisualEditor-VisualDiffs: Visual differences beta feature breaks Twinkle - https://phabricator.wikimedia.org/T193397#4167911 (10Deskana) [13:25:45] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): Simply cloning diff header disrupts user scripts and causes other issues - https://phabricator.wikimedia.org/T192755#4148714 (10Deskana) [14:20:44] 10VisualEditor, 10VisualEditor-MediaWiki: Pasting reference from one surface into another creates ☂ - https://phabricator.wikimedia.org/T193110#4168052 (10Esanders) [14:49:33] (03CR) 10Jforrester: [C: 032] Fully disable the surface before teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429772 (https://phabricator.wikimedia.org/T193103) (owner: 10Esanders) [14:50:11] 10VisualEditor-EditingTools, 10Patch-For-Review, 10VisualEditor (Current work): Switching to VE from NWE while keeping the link inspector/Add Citation dialog open throws error "Uncaught TypeError: Cannot read property 'model' of undefined" - https://phabricator.wikimedia.org/T193103#4168118 (10Jdforrester-WMF... [14:51:19] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Replace isForClipboard with tri-state clipboard mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429555 (owner: 10Esanders) [14:52:08] (03CR) 10Jforrester: [C: 032] Follow-up Ib7e769e: Fix typos in static method calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429759 (https://phabricator.wikimedia.org/T193217) (owner: 10Esanders) [14:52:44] (03Merged) 10jenkins-bot: Fully disable the surface before teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429772 (https://phabricator.wikimedia.org/T193103) (owner: 10Esanders) [14:53:11] (03CR) 10Jforrester: [C: 031] Check link 'host' in onEditSectionLinkClick [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429757 (https://phabricator.wikimedia.org/T193323) (owner: 10Esanders) [14:54:46] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Lineheight out of sync for long articles in NWE with syntaxhig... - https://phabricator.wikimedia.org/T193219#4168129 [14:55:07] (03CR) 10Jforrester: [C: 032] "Whoops. Lame." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429705 (https://phabricator.wikimedia.org/T193043) (owner: 10Esanders) [14:55:20] 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): [Regression pre-wmf.2] Styling for all the heading formats in the toolbar menu is missing - https://phabricator.wikimedia.org/T193098#4168132 (10Deskana... [14:57:06] (03CR) 10jerkins-bot: [V: 04-1] [BREAKING CHANGE] Replace isForClipboard with tri-state clipboard mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429555 (owner: 10Esanders) [14:59:00] 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Verified, 10VisualEditor (Current work): When you create a page and then click "edit source" you get "Resume your edit... - https://phabricator.wikimedia.org/T192770#4168143 [14:59:41] (03Merged) 10jenkins-bot: Follow-up Ib7e769e: Fix typos in static method calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429759 (https://phabricator.wikimedia.org/T193217) (owner: 10Esanders) [14:59:53] (03CR) 10jenkins-bot: Fully disable the surface before teardown [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429772 (https://phabricator.wikimedia.org/T193103) (owner: 10Esanders) [15:00:21] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10I18n, and 5 others: Enable CodeMirror in 2017 Wikitext editor in all wikis without the beta feature - https://phabricator.wikimedia.org/T191923#4168146 (10Deskana) 05Open>03Resolved a:03Deskana [15:00:23] 10VisualEditor-Tables, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Insertion link into an empty table cell causes scroll jump - https://phabricator.wikimedia.org/T191878#4168149 (10Deskana) 05Open>03Resolved [15:01:04] 10VisualEditor-Tables, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): Users can't tab into or out of table captions - https://phabricator.wikimedia.org/T192163#4168155 (10Deskana) 05Open>03Resolved p:05Triage>03Normal [15:01:47] (03CR) 10jenkins-bot: Follow-up Ib7e769e: Fix typos in static method calls [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429759 (https://phabricator.wikimedia.org/T193217) (owner: 10Esanders) [15:03:07] (03CR) 10Jforrester: [C: 032] "Dear CI…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429555 (owner: 10Esanders) [15:04:31] (03CR) 10DLynch: [C: 032] ve.ce.Surface: Control-drag should keep the dragged text in original location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428073 (https://phabricator.wikimedia.org/T192605) (owner: 10Bartosz Dziewoński) [15:05:03] (03CR) 10Jforrester: [C: 032] Use comment HTML helper in all tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429574 (owner: 10Esanders) [15:05:28] (03CR) 10Jforrester: [C: 032] Use CE rendering when showing comments in preview mode (e.g. visual diff) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429569 (https://phabricator.wikimedia.org/T170134) (owner: 10Esanders) [15:06:07] (03Merged) 10jenkins-bot: Follow-up Iea7ad832: Fix context in MWPopupTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429705 (https://phabricator.wikimedia.org/T193043) (owner: 10Esanders) [15:06:12] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Replace isForClipboard with tri-state clipboard mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429555 (owner: 10Esanders) [15:06:15] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Pasting reference from one surface into another creates ☂ - https://phabricator.wikimedia.org/T193110#4159998 (10Esanders) For some reason the browser is deciding to move the reference into a new paragraph on paste: `

☀|☂

` *paste* `... [15:06:26] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Pasting reference from one surface into another creates ☂ - https://phabricator.wikimedia.org/T193110#4168177 (10Jdforrester-WMF) [15:07:06] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Pasting reference from one surface into another creates ☂ - https://phabricator.wikimedia.org/T193110#4168179 (10Esanders) a:03Esanders [15:07:16] 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Visual editor's "leave feedback about this software" doesn't open - https://phabricator.wikimedia.org/T193043#4168182 (10Jdforrester-WMF) [15:08:02] 10VisualEditor-MediaWiki-2017WikitextEditor, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): The 2017 wikitext editor throws `this.buildRedirectSub is not a function` when making edits on redirects - https://phabricator.wikimedia.org/T193217#4168186 (10Jdforreste... [15:08:04] (03PS1) 10Esanders: Use clipboard API if paste context wasn't all cleaned up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) [15:09:00] (03CR) 10jenkins-bot: [BREAKING CHANGE] Replace isForClipboard with tri-state clipboard mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429555 (owner: 10Esanders) [15:09:07] (03CR) 10Jforrester: "Testable?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) (owner: 10Esanders) [15:10:14] (03CR) 10DLynch: [C: 032] Check link 'host' in onEditSectionLinkClick [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429757 (https://phabricator.wikimedia.org/T193323) (owner: 10Esanders) [15:11:21] (03CR) 10jerkins-bot: [V: 04-1] Use clipboard API if paste context wasn't all cleaned up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) (owner: 10Esanders) [15:11:35] (03CR) 10jenkins-bot: Follow-up Iea7ad832: Fix context in MWPopupTool [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429705 (https://phabricator.wikimedia.org/T193043) (owner: 10Esanders) [15:17:46] (03Merged) 10jenkins-bot: Check link 'host' in onEditSectionLinkClick [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429757 (https://phabricator.wikimedia.org/T193323) (owner: 10Esanders) [15:19:43] (03CR) 10jenkins-bot: Check link 'host' in onEditSectionLinkClick [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429757 (https://phabricator.wikimedia.org/T193323) (owner: 10Esanders) [15:26:24] (03PS4) 10Jforrester: ve.ce.Surface: Control-drag should keep the dragged text in original location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428073 (https://phabricator.wikimedia.org/T192605) (owner: 10Bartosz Dziewoński) [15:26:27] (03CR) 10Jforrester: [C: 032] ve.ce.Surface: Control-drag should keep the dragged text in original location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428073 (https://phabricator.wikimedia.org/T192605) (owner: 10Bartosz Dziewoński) [15:26:47] (03PS2) 10Jforrester: Use clipboard API if paste context wasn't all cleaned up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) (owner: 10Esanders) [15:30:25] (03CR) 10jerkins-bot: [V: 04-1] Use clipboard API if paste context wasn't all cleaned up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) (owner: 10Esanders) [15:34:36] (03Merged) 10jenkins-bot: Use comment HTML helper in all tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429574 (owner: 10Esanders) [15:34:38] (03Merged) 10jenkins-bot: Use CE rendering when showing comments in preview mode (e.g. visual diff) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429569 (https://phabricator.wikimedia.org/T170134) (owner: 10Esanders) [15:38:08] (03CR) 10jenkins-bot: Use comment HTML helper in all tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429574 (owner: 10Esanders) [15:38:11] (03Merged) 10jenkins-bot: ve.ce.Surface: Control-drag should keep the dragged text in original location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428073 (https://phabricator.wikimedia.org/T192605) (owner: 10Bartosz Dziewoński) [15:40:52] (03PS3) 10Esanders: Use clipboard API if paste context wasn't all cleaned up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) [15:41:02] (03CR) 10jenkins-bot: Use CE rendering when showing comments in preview mode (e.g. visual diff) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429569 (https://phabricator.wikimedia.org/T170134) (owner: 10Esanders) [15:43:50] (03CR) 10jenkins-bot: ve.ce.Surface: Control-drag should keep the dragged text in original location [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428073 (https://phabricator.wikimedia.org/T192605) (owner: 10Bartosz Dziewoński) [15:45:13] (03PS4) 10Esanders: Use clipboard API if paste context wasn't all cleaned up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) [15:46:41] (03CR) 10Bartosz Dziewoński: [C: 031] "Thanks." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/428073 (https://phabricator.wikimedia.org/T192605) (owner: 10Bartosz Dziewoński) [15:51:06] (03CR) 10Jforrester: [C: 032] Use clipboard API if paste context wasn't all cleaned up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) (owner: 10Esanders) [15:52:40] 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Undo/redo on citations doesn't work correctly - https://phabricator.wikimedia.org/T193062#4168344 (10Deskana) 05Open>03Resolved Testing on the beta cluster, that seems to have fixed... [15:54:04] (03Merged) 10jenkins-bot: Use clipboard API if paste context wasn't all cleaned up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) (owner: 10Esanders) [15:57:01] (03CR) 10jenkins-bot: Use clipboard API if paste context wasn't all cleaned up [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429821 (https://phabricator.wikimedia.org/T193110) (owner: 10Esanders) [15:57:45] (03PS5) 10DLynch: SurfaceFragment: tell insertDocument whether it's from a paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/425462 (https://phabricator.wikimedia.org/T190079) [16:01:32] 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Visual editor's "leave feedback about this software" doesn't open - https://phabricator.wikimedia.org/T193043#4168370 (10Deskana) 05Open>03Resolved Maybe another try at the deployment... [16:05:01] (03CR) 10Esanders: [C: 04-1] "I think we need a more generic approach for localising APIs & link renderers, otherwise you're going to end up sub-classing most of our to" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429712 (owner: 10Santhosh) [16:09:59] (03PS1) 10Jforrester: Update VE core submodule to master (099902ddb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429832 (https://phabricator.wikimedia.org/T170134) [16:10:29] (03PS2) 10Jforrester: Convert most uses of isForClipboard to doesModeNeedRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429564 (owner: 10Esanders) [16:10:36] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (099902ddb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429832 (https://phabricator.wikimedia.org/T170134) (owner: 10Jforrester) [16:17:16] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (099902ddb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429832 (https://phabricator.wikimedia.org/T170134) (owner: 10Jforrester) [16:18:03] (03CR) 10jerkins-bot: [V: 04-1] Convert most uses of isForClipboard to doesModeNeedRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429564 (owner: 10Esanders) [16:18:06] (03CR) 10jerkins-bot: [V: 04-1] Update VE core submodule to master (099902ddb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429832 (https://phabricator.wikimedia.org/T170134) (owner: 10Jforrester) [16:24:34] (03CR) 10DLynch: "@Krinkle: Design seems happier with the concept behind Iad48fb559f3dae16cc0013791b79ec71308a1f9f (which is ultimately similar, just differ" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278284 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [16:37:10] (03PS12) 10DLynch: LinkContextItem: add a button to select the entire label [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) [16:57:17] (03CR) 10Jforrester: [C: 032] "Try again." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429832 (https://phabricator.wikimedia.org/T170134) (owner: 10Jforrester) [17:09:05] (03Merged) 10jenkins-bot: Update VE core submodule to master (099902ddb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429832 (https://phabricator.wikimedia.org/T170134) (owner: 10Jforrester) [17:09:42] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429564 (owner: 10Esanders) [17:11:07] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): New comment shows up as an added space in the content in the VisualDiff - https://phabricator.wikimedia.org/T170134#4168693 (10Jdforrester-WMF) a:03Esanders [17:11:14] 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10VisualEditor (Current work): Copy and paste via Control-Drag doesn't work - https://phabricator.wikimedia.org/T192605#4168695 (10Jdforrester-WMF) [17:11:17] 10VisualEditor-VisualDiffs, 10VisualEditor (Current work): New comment shows up as an added space in the content in the VisualDiff - https://phabricator.wikimedia.org/T170134#3420267 (10Jdforrester-WMF) [17:11:26] (03CR) 10jenkins-bot: Update VE core submodule to master (099902ddb) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429832 (https://phabricator.wikimedia.org/T170134) (owner: 10Jforrester) [17:11:47] 10VisualEditor-EditingTools, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Undo/redo on citations doesn't work correctly - https://phabricator.wikimedia.org/T193062#4168699 (10Jdforrester-WMF) [17:12:08] 10VisualEditor-EditingTools, 10VisualEditor (Current work): Switching to VE from NWE while keeping the link inspector/Add Citation dialog open throws error "Uncaught TypeError: Cannot read property 'model' of undefined" - https://phabricator.wikimedia.org/T193103#4168701 (10Jdforrester-WMF) [17:13:03] 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 10VisualEditor (Current work): Pasting reference from one surface into another creates ☂ - https://phabricator.wikimedia.org/T193110#4168704 (10Jdforrester-WMF) [17:17:35] 10VisualEditor, 10Mobile-Content-Service, 10RESTBase, 10RESTBase-API, and 3 others: Support flagged revisions in RESTBase - https://phabricator.wikimedia.org/T169116#3387536 (10stjn) >>! In T169116#3643929, @bearND wrote: > How do we display in the clients that a user is not looking at the latest revision?... [17:19:25] (03CR) 10Jforrester: [C: 032] Convert most uses of isForClipboard to doesModeNeedRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429564 (owner: 10Esanders) [17:24:21] (03PS1) 10Bartosz Dziewoński: ve.init.mw.DiffPage.init: Do not duplicate diff table header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429845 (https://phabricator.wikimedia.org/T192755) [17:26:21] 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Simply cloning diff header disrupts user scripts and causes other issues - https://phabricator.wikimedia.org/T192755#4168754 (10matmarex) Sorry, I didn't anticipate this breaking other scripts, and I wasn't checking my bugmail ove... [17:29:48] (03Merged) 10jenkins-bot: Convert most uses of isForClipboard to doesModeNeedRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429564 (owner: 10Esanders) [17:31:29] (03CR) 10Jforrester: "https://phabricator.wikimedia.org/T191095#4133683" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429529 (owner: 10Jforrester) [17:31:49] (03CR) 10jenkins-bot: Convert most uses of isForClipboard to doesModeNeedRendering [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429564 (owner: 10Esanders) [17:33:06] 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Inspector's popup handle misplaced when close to edge of surface in Flow+VE - https://phabricator.wikimedia.org/T166217#4168795 (... [17:34:04] 10VisualEditor-EditingTools, 10Collaboration-Team-Triage, 10StructuredDiscussions, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Link/Mention inspector: 'Uncaught Type Error' if the link inspector Edit is ... - https://phabricator.wikimedia.org/T122910#4168799 [17:53:03] (03PS1) 10Esanders: Simplify usage of dummy target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429847 [17:54:58] (03PS1) 10Esanders: Simplify usage of dummy target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429849 [18:01:38] edsanders: Kemayo: can you review https://gerrit.wikimedia.org/r/#/c/429845/ today? i would like to backport it [18:02:16] (03CR) 10jerkins-bot: [V: 04-1] Simplify usage of dummy target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429849 (owner: 10Esanders) [19:06:34] 10VisualEditor: Intermittent "Error loading data from server" error using VE in Firefox and Chrome on officewiki - https://phabricator.wikimedia.org/T187951#4169119 (10Quiddity) Note: I've tried using Chromium in an Private window, with all extensions disabled, all gadgets disabled, and all user-scripts disabled... [19:21:45] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10User-Ryasmeen: Codemirror makes text align left when editing in 2017 WTE on RTL wikis - https://phabricator.wikimedia.org/T193260#4169175 (10Niharika) 05Open>03Resolved a:03Esanders P... [19:37:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10User-Ryasmeen: Codemirror makes text align left when editing in 2017 WTE on RTL wikis - https://phabricator.wikimedia.org/T193260#4169292 (10Guycn2) >>! In T193260#4169175, @Niharika wrote:... [19:46:32] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), and 3 others: Add ellipsis to "Publish changes" button when editing to in... - https://phabricator.wikimedia.org/T189803#4169337 [19:48:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page - https://phabricator.wikimedia.org/T44138#4169349 (10Nirzar) [19:48:12] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Design, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), and 3 others: Add ellipsis to "Publish changes" button when editing to in... - https://phabricator.wikimedia.org/T189803#4053939 [19:57:35] 10VisualEditor-MediaWiki-2017WikitextEditor, 10Community-Tech, 10MediaWiki-extensions-CodeMirror, 10User-Ryasmeen, 10VisualEditor (Current work): Codemirror makes text align left when editing in 2017 WTE on RTL wikis - https://phabricator.wikimedia.org/T193260#4169403 (10Jdforrester-WMF) [19:59:46] (03CR) 10Jforrester: [C: 032] Simplify usage of dummy target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429847 (owner: 10Esanders) [20:02:53] (03Merged) 10jenkins-bot: Simplify usage of dummy target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429847 (owner: 10Esanders) [20:06:06] (03CR) 10jenkins-bot: Simplify usage of dummy target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/429847 (owner: 10Esanders) [20:07:30] (03PS2) 10Jforrester: Update VE core submodule to master (a8e0eef6d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429849 (owner: 10Esanders) [20:08:10] (03CR) 10Jforrester: Update VE core submodule to master (a8e0eef6d) (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429849 (owner: 10Esanders) [20:12:58] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (a8e0eef6d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429849 (owner: 10Esanders) [20:17:56] (03PS1) 10Bartosz Dziewoński: VisualEditorDataModule: Remove origin restriction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429872 (https://phabricator.wikimedia.org/T185303) [20:19:21] (03Merged) 10jenkins-bot: Update VE core submodule to master (a8e0eef6d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429849 (owner: 10Esanders) [20:20:15] (03PS1) 10Bartosz Dziewoński: CitoidDataModule: Remove origin restriction [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/429876 (https://phabricator.wikimedia.org/T185303) [20:22:23] (03CR) 10jenkins-bot: Update VE core submodule to master (a8e0eef6d) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429849 (owner: 10Esanders) [20:27:42] (03CR) 10Jforrester: [C: 032] VisualEditorDataModule: Remove origin restriction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429872 (https://phabricator.wikimedia.org/T185303) (owner: 10Bartosz Dziewoński) [20:28:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429968 (owner: 10L10n-bot) [20:28:05] (03CR) 10Jforrester: [C: 032] CitoidDataModule: Remove origin restriction [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/429876 (https://phabricator.wikimedia.org/T185303) (owner: 10Bartosz Dziewoński) [20:36:33] (03Merged) 10jenkins-bot: VisualEditorDataModule: Remove origin restriction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429872 (https://phabricator.wikimedia.org/T185303) (owner: 10Bartosz Dziewoński) [20:36:35] (03Merged) 10jenkins-bot: CitoidDataModule: Remove origin restriction [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/429876 (https://phabricator.wikimedia.org/T185303) (owner: 10Bartosz Dziewoński) [20:38:41] (03CR) 10jenkins-bot: VisualEditorDataModule: Remove origin restriction [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429872 (https://phabricator.wikimedia.org/T185303) (owner: 10Bartosz Dziewoński) [20:39:12] (03CR) 10Esanders: [C: 04-2] "@DChan I'm guessing we should just abandon this" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/354659 (owner: 10Esanders) [20:59:02] 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome, 10VisualEditor (Current work): Pasting long content is many times slower than inserting the same content in a different way - https://phabricator.wikimedia.org/T189556#4169654 (10matmarex) [20:59:42] 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Browser-Support-Google-Chrome, 10VisualEditor (Current work): Pasting long content is many times slower than inserting the same content in a different way - https://phabricator.wikimedia.org/T189556#4045502 (10matmarex) 05Open>03Re... [21:10:17] (03CR) 10Jforrester: [C: 031] ve.init.mw.DiffPage.init: Do not duplicate diff table header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429845 (https://phabricator.wikimedia.org/T192755) (owner: 10Bartosz Dziewoński) [21:19:22] (03CR) 10Esanders: [C: 032] ve.init.mw.DiffPage.init: Do not duplicate diff table header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429845 (https://phabricator.wikimedia.org/T192755) (owner: 10Bartosz Dziewoński) [21:22:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/429959 (owner: 10L10n-bot) [21:23:33] 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Simply cloning diff header disrupts user scripts and causes other issues - https://phabricator.wikimedia.org/T192755#4169697 (10Jdforrester-WMF) [21:26:55] (03Merged) 10jenkins-bot: ve.init.mw.DiffPage.init: Do not duplicate diff table header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429845 (https://phabricator.wikimedia.org/T192755) (owner: 10Bartosz Dziewoński) [21:28:47] (03PS1) 10Jforrester: ve.init.mw.DiffPage.init: Do not duplicate diff table header [extensions/VisualEditor] (wmf/1.32.0-wmf.1) - 10https://gerrit.wikimedia.org/r/429986 (https://phabricator.wikimedia.org/T192755) [21:29:04] (03CR) 10jenkins-bot: ve.init.mw.DiffPage.init: Do not duplicate diff table header [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/429845 (https://phabricator.wikimedia.org/T192755) (owner: 10Bartosz Dziewoński) [21:29:32] 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Simply cloning diff header disrupts user scripts and causes other issues - https://phabricator.wikimedia.org/T192755#4148714 (10Jdforrester-WMF) I've scheduled this for SWAT in 90 minutes' time. [21:35:38] 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10Patch-For-Review, 10VisualEditor (Current work): Simply cloning diff header disrupts user scripts and causes other issues - https://phabricator.wikimedia.org/T192755#4169719 (10matmarex) [22:24:50] 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10Patch-For-Review, 10VisualEditor (Current work): Simply cloning diff header disrupts user scripts and causes other issues - https://phabricator.wikimedia.org/T192755#4169821 (10matmarex... [22:24:55] 10Editing-team, 10MediaWiki-Page-editing, 10Patch-For-Review: Only show edit summary remaining character countdown for last 99 characters - https://phabricator.wikimedia.org/T190570#4169822 (10matmarex) p:05Triage>03Normal [23:13:30] (03CR) 10Catrope: [C: 032] ve.init.mw.DiffPage.init: Do not duplicate diff table header [extensions/VisualEditor] (wmf/1.32.0-wmf.1) - 10https://gerrit.wikimedia.org/r/429986 (https://phabricator.wikimedia.org/T192755) (owner: 10Jforrester) [23:24:20] (03Merged) 10jenkins-bot: ve.init.mw.DiffPage.init: Do not duplicate diff table header [extensions/VisualEditor] (wmf/1.32.0-wmf.1) - 10https://gerrit.wikimedia.org/r/429986 (https://phabricator.wikimedia.org/T192755) (owner: 10Jforrester) [23:25:12] 10Editing-team, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-FlaggedRevs, 10VisualEditor (Current work): Editing a page with unflagged changes should edit latest version in VE, even if you view the stable version - https://phabricator.wikimedia.org/T165283#4169951 (10matmarex) The current behavior for... [23:43:19] 10VisualEditor-MediaWiki, 10VisualEditor-VisualDiffs, 10MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), 10VisualEditor (Current work): Simply cloning diff header disrupts user scripts and causes other issues - https://phabricator.wikimedia.org/T192755#4169975 (10Jdforrester-WMF) Now deployed...