[00:17:30] (03CR) 10Bartosz Dziewoński: [C: 04-1] "On second thought, I don't think this is quite right. This code will not insert a slug between meta and block node, but will insert one be" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440391 (https://phabricator.wikimedia.org/T196921) (owner: 10Divec) [01:08:18] (03PS3) 10Bartosz Dziewoński: Ignore meta items when computing slug positions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440391 (https://phabricator.wikimedia.org/T196921) (owner: 10Divec) [01:10:10] (03CR) 10Bartosz Dziewoński: "PS3: Rewrote ve.dm.BranchNode#setupBlockSlugs completely, added some more examples to slugs.html demo. David, can you review this approach" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440391 (https://phabricator.wikimedia.org/T196921) (owner: 10Divec) [01:12:24] (03CR) 10Bartosz Dziewoński: Ignore meta items when computing slug positions (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440391 (https://phabricator.wikimedia.org/T196921) (owner: 10Divec) [01:44:27] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Looks good. However, it will need a follow-up patch in VE-MW:" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [01:46:31] (03PS2) 10DLynch: DesktopArticleTarget: view click handler should only run for active target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440907 (https://phabricator.wikimedia.org/T197445) [01:50:43] 10VisualEditor: [office wiki] Tabs in inspectors are not floated - https://phabricator.wikimedia.org/T197590#4298609 (10matmarex) This looks like the same issue as {T195544}, which according to @ryasmeen "periodically keeps re-surfacing on Beta cluster even though it temporarily fixes itself after clearing the c... [02:55:42] (03CR) 10DLynch: "I have a patch with most of that, fortunately. I just don't have it up, because I didn't want to mess with merging it into a proper update" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [03:13:47] (03PS1) 10DLynch: Update link contexts with label info from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440985 (https://phabricator.wikimedia.org/T124305) [03:24:19] (03CR) 10jerkins-bot: [V: 04-1] Update link contexts with label info from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440985 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [05:04:24] 10TemplateData, 10VisualEditor: Proposal for more sophisticated "required" parameter option - https://phabricator.wikimedia.org/T197634#4298688 (10Aklapper) [07:42:07] (03CR) 10Divec: [C: 031] "Thanks - that code is a lot better (and very clear). +2 to the parts I didn't write." (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440391 (https://phabricator.wikimedia.org/T196921) (owner: 10Divec) [08:03:52] (03PS1) 10Petar.petkovic: Prevent null being treated as "object" with typeof operator [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440996 (https://phabricator.wikimedia.org/T197139) [08:05:01] 10VisualEditor, 10VisualEditor-DataModel, 10Patch-For-Review: Cannot read property 'constructor' of null - https://phabricator.wikimedia.org/T197139#4279886 (10Petar.petkovic) [08:31:02] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10WikiEditor, 10MediaWiki-extensions-CodeMirror, 10Accessibility: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4298900 (10TheDJ) @matmarex the state is, it works, it's accessible, but... [08:57:42] 10VisualEditor: "ve.dm.Document.getBranchNodeFromOffset(): offset -1 is out of bounds" error - https://phabricator.wikimedia.org/T197651#4298959 (10Petar.petkovic) [09:10:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Slow typing on large pages - https://phabricator.wikimedia.org/T197652#4298987 (10Elitre) [09:19:28] (03CR) 10Bartosz Dziewoński: [C: 032] Ignore meta items when computing slug positions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440391 (https://phabricator.wikimedia.org/T196921) (owner: 10Divec) [09:23:33] (03Merged) 10jenkins-bot: Ignore meta items when computing slug positions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440391 (https://phabricator.wikimedia.org/T196921) (owner: 10Divec) [09:27:59] (03CR) 10jenkins-bot: Ignore meta items when computing slug positions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440391 (https://phabricator.wikimedia.org/T196921) (owner: 10Divec) [09:35:20] 10VisualEditor-MediaWiki, 10ProofreadPage, 10Patch-For-Review, 10VisualEditor (Current work): Three slugs in every header/footer on Wikisource VisualEditor, two of them don't work (cause an exception) - https://phabricator.wikimedia.org/T196921#4299045 (10matmarex) Note for testing – similar issue also occ... [10:23:11] 10VisualEditor: VisualEditor occasionally opens a link within a template instead of the template's settings when clicked - https://phabricator.wikimedia.org/T197659#4299137 (10SUM1) [10:23:41] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: VisualEditor occasionally opens a link within a template instead of the template's settings when clicked - https://phabricator.wikimedia.org/T197659#4299148 (10Aklapper) [10:29:14] 10VisualEditor: Template highlighting gets stuck when template is shifted - https://phabricator.wikimedia.org/T197661#4299166 (10SUM1) [10:36:34] 10VisualEditor: Template highlighting gets stuck when template is shifted (but the highlighting corrects itself as soon as you move the mouse) - https://phabricator.wikimedia.org/T168633#4299244 (10Deskana) [10:36:36] 10VisualEditor: Template highlighting gets stuck when template is shifted - https://phabricator.wikimedia.org/T197661#4299246 (10Deskana) [10:40:02] 10VisualEditor: [office wiki] Tabs in inspectors are not floated - https://phabricator.wikimedia.org/T197590#4299274 (10Deskana) [10:49:45] 10VisualEditor: Templates blocking editing of adjacent image captions - https://phabricator.wikimedia.org/T197670#4299312 (10SUM1) [11:49:38] (03CR) 10Esanders: "As per the commit message, the MW override would be mw.message().parseDom(). That version parses HTML in the message (and treats string pa" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440664 (https://phabricator.wikimedia.org/T195243) (owner: 10Esanders) [11:52:27] 10VisualEditor: Templates blocking editing of adjacent image captions - https://phabricator.wikimedia.org/T197670#4299421 (10matmarex) [11:56:50] 10VisualEditor: Templates blocking editing of adjacent image captions - https://phabricator.wikimedia.org/T197670#4299312 (10matmarex) Thank you for filing a task. This is a special case of {T104540}, so I'm going to merge them (feel free to improve the description of that other task if you wish). This is actu... [11:56:59] 10VisualEditor: Templates blocking editing of adjacent image captions - https://phabricator.wikimedia.org/T197670#4299447 (10matmarex) [11:57:01] 10VisualEditor, 10VisualEditor-ContentEditable, 10Wikimedia-Hackathon-2018: Reference list
can overlap a template
because that's how HTML works - https://phabricator.wikimedia.org/T104540#1419815 (10matmarex) [12:01:55] (03CR) 10Bartosz Dziewoński: [C: 04-1] "> If we are concerned about message security in standalone, we could add some whitelisting to the SA implementation, or even use our dompu" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/440664 (https://phabricator.wikimedia.org/T195243) (owner: 10Esanders) [12:12:26] 10Cite, 10Patch-For-Review: Support for a counter-style parameter in the references tag - https://phabricator.wikimedia.org/T196942#4299462 (10Esanders) Per my comment on the originating task we shouldn't mix the semantic group name with the styling. Create a separate attribute. In addition to the reasons pr... [12:31:14] (03PS1) 10Esanders: Implement getHtmlMessage in mw.Platform and use for DiffElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441028 (https://phabricator.wikimedia.org/T195243) [12:38:26] (03CR) 10jerkins-bot: [V: 04-1] Implement getHtmlMessage in mw.Platform and use for DiffElement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441028 (https://phabricator.wikimedia.org/T195243) (owner: 10Esanders) [14:16:32] 10VisualEditor: "ve.dm.Document.getBranchNodeFromOffset(): offset -1 is out of bounds" error - https://phabricator.wikimedia.org/T197651#4299735 (10Esanders) CC @dchan [14:54:52] 10Cite, 10Patch-For-Review: Support for a counter-style parameter in the references tag - https://phabricator.wikimedia.org/T196942#4299870 (10Huji) >>! In T196942#4299462, @Esanders wrote: > Per my comment on the originating task we shouldn't mix the semantic group name with the styling. Create a separate att... [14:59:28] (03PS1) 10Esanders: Replace assert.deepEqual's with more appropriate tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441048 [15:01:03] (03PS1) 10Esanders: Replace deepEqual with strictEqual for non-objects [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441050 [15:04:37] (03PS1) 10Esanders: Remove remaining assert.expect's [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441052 [15:04:58] (03PS1) 10Esanders: Add MW-specific DiffElement tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441053 [15:13:37] (03CR) 10jerkins-bot: [V: 04-1] Add MW-specific DiffElement tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/441053 (owner: 10Esanders) [15:40:36] (03CR) 10DLynch: "As you might imagine, this is going to be broken unless Iad48fb559f3dae16cc0013791b79ec71308a1f9f is merged into the submodule." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/440985 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [15:45:57] (03PS27) 10DLynch: LinkContextItem: add label information to the context [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/272510 (https://phabricator.wikimedia.org/T124305) [16:53:25] 10VisualEditor-MediaWiki-Templates, 10VisualEditor (Current work): VisualEditor occasionally opens a link within a template instead of the template's settings when clicked - https://phabricator.wikimedia.org/T197659#4300280 (10DLynch) a:03DLynch [16:56:56] (03PS1) 10DLynch: ce.FocusableNode: suppress left clicks within the focusable element [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/441067 (https://phabricator.wikimedia.org/T197659) [17:42:58] 10VisualEditor, 10ProofreadPage: VisualEditor/ProofreadPage splitting of the page content into header/section/footer is incompatible with existing content (and more generally, with the layout of physical books) - https://phabricator.wikimedia.org/T196863#4300423 (10matmarex) [17:43:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: Make the VisualEditor/ProofreadPage integration good enough to enable by default - https://phabricator.wikimedia.org/T138966#4300427 (10matmarex) [17:43:32] 10VisualEditor, 10ProofreadPage, 10Wikisource, 10User-Ryasmeen: VisualEditor adds strange
and