[00:03:26] 03(mod) {{int:X}} respects user-defined interface language, breaking link tables etc. (aka {{USERIFCODE}} strikes back) - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=14404 (10brion) [00:06:35] hello all [00:08:11] what would be the best way for an extension to limit itself only to certain categories? i.e., when the extension is invoked, it will only process pages that are part of category "Foo" [00:08:35] or any of its sub-categories [00:14:44] what would be the best way for an extension to limit itself only to certain categories? i.e., when the extension is invoked, it will only process pages that are part of category "Foo", or any of its sub-categories [00:19:05] I can tell everyone this, mediawiki support mysql 5.1 GA [00:19:51] j4zzcat: you'd have to query the db [00:20:00] to figure out what categories the page is in [00:20:08] hmm [00:20:10] thanks [00:20:18] hmmm [00:20:46] since iirc that info isn't accessible through Title or Article [00:20:53] 5.1 is GA already? [00:21:01] yes [00:21:10] final [00:21:50] ybsinaisyyteni, http://techwiki.techman224.com/techwiki/index.php/Special:Version [00:22:02] ah, /me just sucks at searching [00:22:17] j4zzcat: actually, you should be able to use $wgTitle->getParentCategories() [00:23:14] thanks :-) [00:25:32] 03(mod) Support for Chemical Markup Language - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16491 (10brion) [00:27:04] *werdnum waves [00:27:09] <__aib> has anyone considered updating articles using ajax rather than a new get when links are clicked? i guess with client-side caching it's not that big of a save? [00:27:54] 03(NEW) Images break text flow in IE - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16501 normal; normal; MediaWiki: Page rendering; (pastor.castor) [00:29:37] if i have a page on my wiki that is linked via the skin how do i make sure the href is correct? [00:29:44] yksinaisyyteni, why not just use "river" as your nickname :P [00:31:07] i.e the mainpage is $this->data['nav_urls']['mainpage']['href'] [00:31:47] *chuck wonders if there is a guide to make a skin.. [00:35:27] 03siebrand * r44054 10/trunk/extensions/Translate/ (7 files in 2 dirs): Add Special:LanguageStats. As unlisted special page for now, because it still needs some work. [00:37:37] __aib, to many issues is that. There are a whole pile of things other than the content that changed (tabs, toolbox). As well that would break js like that used for show/hide. And to top it off, for all these bits of issues, the address bar will not be returning proper info, and history could get screwed up [00:37:45] All in all, it's not worth the effort [00:58:45] werdnum: why can't kate open two windows with different document lists? [01:00:03] yksinaisyyteni: Two windows with different document lists? [01:00:07] yes [01:00:20] You mean you want two different instances of kate, each having different documents open? [01:00:30] yes, except i want the same instance with two windows [01:02:53] yksinaisyyteni: that is kinda annoying. [01:03:10] yksinaisyyteni: I don't know how to get around it... tried "New Session" et al. [01:03:13] hey brion [01:03:34] what up werdnum [01:03:46] not much [01:04:02] ... and why is qt designer an annoying gimp-like sdi application on unix? [01:04:07] it does proper MDI on windows ;( [01:04:15] Been away with the gf, so I'm starting my friday-saturday work now :) [01:04:30] *werdnum has weird work timetables to sync with you crazy Americans and your thanksgiving. [01:04:36] :D [01:05:03] i'll be back to regular schedule monday [01:05:35] *werdnum wonders which other jobs would let me move my weekend two days forward to take advantage of thanksgiving. [01:06:26] 03(NEW) default skins don't show the mail_icon,gif or external. png with another language file - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16502 15enhancement; normal; MediaWiki: Images; (sia) [01:06:41] :) [01:07:14] brion: Isn't it, you know, the weekend over there? [01:07:27] Shouldn't you be trampling employees at Wal-Mart or something? [01:07:32] *werdnum hides. [01:07:32] :P [01:07:35] just chillin' [01:07:46] thought i'd poke at a bit of the code review backlog while i'm sitting here :) [01:07:48] 03(NEW) Checkuser install script install.php doesn't work - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16503 04CRIT; normal; MediaWiki extensions: CheckUser; (techman224) [01:07:51] fair enough [01:08:05] brion: while you're around, what do I need to do to get this COnfigure stuff ready to deploy. [01:08:49] 14(DUP) default skins don't show the mail_icon,gif or external. png with another language file - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16502 +comment (10brion) [01:08:50] *werdnum is already a week over time on it and ready to get this stuff done and dusted (but the next project should be shorter than budget, so I'm not stressed out) [01:08:50] 03(mod) BiDi: user icon should be displayed properly regardles of the LTR / RTL - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=3956 +comment (10brion) [01:09:37] lemme take a peek at its current state [01:10:32] I'm aware of the following: [01:10:34] ok first note -- i find the expandable sidebar tree generally confusing [01:11:04] okay, so what sort of interface should replace it? I discussed with ialex, and it's a real pain to do tabs, because there are stacks and stacks of options in a default install. [01:11:04] subsections show in multiple places and it's not obvious why at first [01:11:22] so we'd end up with like 10 tabs. [01:11:27] single-subsection sections expand to show just one section, which is very confusing [01:11:40] That can be killed pretty easy. [01:12:03] yes, not showing expando links for things that have nothing to expand to would be a good start :) [01:12:35] "reduction" as a section title is confusing. [01:12:36] html needs an expandable sidebar tag [01:12:45] so everyone doesn't have to reimplement it in JS [01:12:48] Technically it does, but from a user's perspective no, so yeah, I'll fix that. [01:12:53] it seems to combine performance controls with random "disable thsi feature" stuff [01:13:54] okay, I can split that up into 'Performance' and 'Features'. [01:13:54] in "files" consider separating out thumbnail rendering stuff from other stuff? [01:14:51] hang on, let me pull up the interface so I remember what you mean. [01:15:31] ($wgUsePrivateIPs) belongs in squid settings (handling reverse proxy in front of MediaWiki), whereas the "Proxies" section here seems to be for open-proxy scanning for IP blocking [01:15:59] Okay, so a separate "Thumbnail rendering" section under "Files", or a separate top-level section? [01:16:16] brion: just FYI, I finally have emails getting sent and plan to email you a patch for UserMailer tonight. [01:16:28] (there, now I'm committed :)) [01:16:30] Enable Squid ($wgUseSquid) should probably be at the *top* of the squids section? :) [01:16:48] might be a good idea... [01:16:49] :P [01:16:50] i note the lists of squid servers are missing from this section [01:17:05] how can i active the theme like that {{community news|right}} ? [01:17:20] brion: What do you mean? I can see the entry field there... [01:17:21] we still need a UI for $wgRateLimits ... that's one of the settings we might want to be able to configure for Wikimedia stuff [01:17:43] yep, that's on the list :) [01:18:21] werdnum: http://leuksman.com/images/4/47/Picture_20.png [01:18:29] werdnum: i missing intellisense in kate when using Qt. it's a big library ;) [01:18:56] brion: hmm, perhaps you've got $wgConfigureNotEditableSettings or $wgConfigureEditableSettings different from the default. [01:19:03] ($wgAccountCreationThrottle) maybe belongs in rate limits? [01:19:17] werdnum: i have no such setting [01:19:22] yeah, probably does. [01:19:25] require_once( "$IP/extensions/Configure/Configure.php" ); [01:19:25] efConfigureSetup(); [01:19:40] 03(NEW) Less obtrusive anti-spam box on text browsers - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16504 trivial; normal; Wikimedia: General/Unknown; (jidanni) [01:19:57] ditto on ($wgPasswordAttemptThrottle) [01:19:57] brion: Maybe it's got to do with the files handler. [01:20:02] *werdnum checks code. [01:20:25] Spam filter regular expressions ($wgSpamRegex) <- probably should be in a content filtering section? [01:20:38] lemme try removing my old file [01:20:59] no difference [01:21:11] 5.2.6 (apache2handler) [01:21:14] That's a bit weird. [01:21:22] Are you at svn HEAD? [01:21:47] whoops. [01:22:11] yeah [01:22:21] maybe I'm not, and ialex has done something. [01:22:23] *werdnum updates. [01:22:39] I'll check that out. [01:22:46] Does it still take over your screen, or did we fix that? [01:22:58] (horizontal scrollbar) [01:23:07] it's still a bit wide for my taste but not as bad :) [01:23:28] Moving that thing on the side should get us some horizontal space. [01:24:07] any answer? why the template code dont worked for me??!! [01:24:08] Any suggestions for a better way of selecting different sections? [01:24:08] http://www.mediawiki.org/wiki/Help:Templates [01:24:08] a general question -- does it save *every* value or just those which are different from the defaults? [01:24:15] I'm not entirely sure. Let me take a look. [01:24:19] if it saves them all, that's bad since upgrades that change default values (say for safety) will get messed up [01:24:36] a lot of settings are not really meant to be changed in 99% of cases :) [01:24:53] any idea? [01:25:11] brion: If you look in Configure.php, there's a recommended set of settings to set as editable. [01:25:21] Namespace overrides ($wgExtraNamespaces) <- "Nameapce overrides" seems like a strange description here [01:25:28] 03(mod) Checkuser install script install.php doesn't work - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16503 (10techman224) [01:25:33] werdnum: recommendations should probably be the default :) [01:25:33] brion: Try copying those commented-out lines into your LocalSettings.php -- that's what my suggestion was for Wikimedia. [01:25:44] software should be "fire and forget" [01:25:45] brion: They were, but ialex said he wanted everything changeable by default. [01:25:56] well, allow me to override that [01:26:26] Okay, I'll put it back like that. [01:27:22] The default editable settings are basically "Namespaces, groups, some misc customisation like logo, site name, etc" [01:29:12] things like Namespace protection ($wgNamespaceProtection) really should show when they've been customized. right now it just says "[show details]Setting details hidden" [01:29:38] collapsed form should at least indicate what *is* set [01:30:04] It looks like it already has infrastructure to get the defaults, I think to remove the defaults from settings which are saved. [01:30:28] brion: The issue there is updating the 'summary' with JS [01:30:48] Although I suppose it could be done purely in JS, instead of in PHP and JS. [01:31:00] List of interwiki prefixes for transwiki ($wgImportSources) <- this is shown doubled for some reason. ("Wikipedia\nWikipedia") [01:31:06] [after saving] [01:31:24] werdnum: yeah, basically just show the boxes with content in them :) [01:31:29] Yeah, I know about that issue. [01:31:38] It happens for some other things, too. [01:32:26] what happened to wgLogo? i can't find a setting box for it [01:32:38] It's because the arrays are merged, rather than overridden with the defaults. [01:32:53] brion: 'Site Customisation' [01:32:56] I moved it. [01:33:10] it aint there [01:33:30] Hmm.. that's weird. More settings going missing... [01:33:59] can i use Template in mediaWiki or not? [01:34:43] I'll be at HEAD in a few minutes (just updating now), and will see if it's there then. [01:35:38] 03(mod) Less obtrusive anti-spam box on text browsers - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16504 (10brion) [01:35:58] :D [01:36:28] http://www.mediawiki.org/wiki/User:Werdna/Configure_todo [01:36:30] what I have so far. [01:36:36] Default language variant ($wgDefaultLanguageVariant) <- shouldn't this go with localization? [01:36:43] Probably. [01:36:51] Maybe I should just do a review of categorisation. [01:37:04] Hide interlanguage links from the sidebar ($wgHideInterlanguageLinks) <- to interwiki? [01:37:08] see u my text or iam ignored? [01:37:26] S-i-A: people who are around are busy, there are probably others. [01:37:49] aha ok but need any answer. [01:38:20] brion: I'll have a look at categories in general, rather than you spending the next half hour finding every misplaced setting :) [01:38:41] *werdnum thinks you have better things to do. [01:39:04] Valid skin names ($wgValidSkinNames) <- wtf? [01:39:20] this is a global that's autogenerated from the skins present on the system [01:39:29] is useing template need extension install or is total disabled in mediaWiki? [01:39:50] werdnum: looking at yer list :D [01:40:07] brion: ah, shall remove. There were a few like that that I spotted when I first picked up Configure, but obviously one slipped through. [01:40:23] a good start :D [01:40:26] We had globals like $wgDBserver (Tim said it used to hold the MYSQL connection resource) listed as changeable. [01:40:43] for things like logos it might be nice if we have a good clean UI for picking an image name and perhaps displaying the image inline [01:40:55] I've got the former, not the latter. [01:41:20] You click "Convert image name to URL", and it AJAXes the image name into a URL for a thumb of the appropriate size. [01:41:36] Would be trivial to have a 'preview' button which then displays it inline next to the field. [01:41:39] hmm [01:41:49] mmmm. it handle Commons? :D [01:42:00] brion: It uses wfFindFile, so yes. [01:42:11] whee [01:42:38] $wgForeignFileRepo is seriously the sexiest thing ever invented. [01:42:46] *AaronSchulz keeps hearing the Kang & Kodos theme [01:46:28] edit conflict! [01:46:54] oh, sorry :P [01:47:30] Enable highlighting in search results ($wgAdvancedSearchHighlighting) <- inaccurate description. highlighting is *always* on -- this is a fancier, slower, method of highlighting [01:47:46] "Enable fancy search highlighting" [01:52:10] AaronSchulz: is http://www.mediawiki.org/wiki/Special:Code/MediaWiki/43871 resolved? [01:52:11] is there any particular order to the sections? [01:52:13] it seems pretty random to me [01:52:29] brion: They're in an order in the file, and I'm aware that it's totally random. [01:52:55] I'm torn between having them in a "What are you most likely to use" order, and an alphabetical order. [01:53:14] $wgDisableTextSearch presumably belongs under Search [01:53:30] well i spent like a minute trying to find the "Search" section [01:53:42] i ended up using Firefox's in-page search to find the section link so i could click on it [01:54:00] imho this could use a workflow improvement :) [01:54:06] So you think alphabetical? [01:54:15] maybe... [01:54:24] and/or just have a search widget :) [01:54:55] whee [01:55:27] I'm not sure how that would work though. [01:55:33] We could de-section them and rely on search [01:55:41] also if i will use template must i install extention or ?? [01:55:49] mmmmm i'd say keep sectioning [01:55:50] or.... somehow pull the requisite table rows and stick them in a special-purpose section for search results? [01:55:54] otherwise hard to find related items [01:56:03] (search can be all-js) [01:56:05] or... highlight the section where a setting is in? [01:56:53] 03(mod) Less obtrusive anti-spam box on text browsers - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16504 (10textarea rows='1' cols='1'>_Anti-spam check. Do NOT fill this in! [01:56:53] would look less obtrusive in text browsers. I suppose the TAB key will still [01:56:53] find [01:56:53] it, else whatever spam program you are fighting wouldn't, defeating its [01:56:53] purpose. [01:56:55] Produce a list of settings for search results, each result is a link which opens the section and highlights the setting? [01:56:59] -- [01:57:01] Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email [01:57:03] ------- You are receiving this mail because: ------- [01:57:05] You are the assignee for the bug. [01:57:07] You are watching all bug changes. [01:57:08] *werdnum kicks wikibugs [01:57:11] _______________________________________________ [01:57:13] Wikibugs-l mailing list [01:57:15] Wikibugs-l) [01:57:15] heh [01:57:22] heyyyy [01:57:24] I think I'm a bit late... [01:57:28] tx [01:58:55] Anyway, I'd personally go with the last option.. links for each setting, which open up the setting in the view. [02:01:22] i well come morgen again for my answer YES/NO :) [02:01:38] is my question so ...!? [02:02:24] S-i-A: templates work fine without extensions, except some templates on Wikipedia need extensions installed [02:02:31] look at http://en.wikipedia.org/wiki/Special:Version [02:03:00] there are a few extensions that you might need, and all of them are there (although you won't need many of Wikimedia's extensions). Consider installing ParserFunctions, in particular. [02:03:04] https://bugzilla.wikimedia.org/show_bug.cgi?id=16481 werdnum: thanks [02:03:40] ParserFunctions and HTMLTidy are the main ones for wikipedia templates afaik [02:04:55] also werdnum mus install this version and remove the mediawiki 1.12? [02:05:22] Ordinarily, no, but there's a new parser in 1.13 which you probably will need. [02:05:34] S-i-A: the best way to upgrade is not to remove your directory and reinstall. [02:05:43] Just copy the files over the top, and run maintenance/update.php. [02:05:52] brion: is that what you're thinking of with the search widget? [02:06:24] werdnum: and this extiontion dont worked with 1.12 http://www.mediawiki.org/wiki/Extension:ExpandTemplates ? [02:06:40] You shouldn't need it. [02:07:54] also must upgrade and worked. [02:08:40] werdnum: hm? [02:09:39] brion: Just thinking about the behaviour of a JS search widget -- is this what you were after? : search results consist of links for each result, which open up the section and highlight the setting [02:09:58] 04(REOPENED) Special:Statistics does not explain what * means - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16481 +comment (10brion) [02:10:18] hey. [02:10:24] werdnum: could try that and see how it goes [02:10:40] it may, or may not, be nicer to show the full display & edit widget for all results, as a kind of 'virtual section' [02:10:45] on the other hand that might be hard :D [02:10:50] Yeah, that was another option :P [02:10:52] plus it might be harder to then find related settings [02:10:55] yeah [02:11:12] Anyway, looks like I have plenty to do over the next few days. [02:11:21] :D [02:11:37] Should be able to get most of it done by the middle of the week. [02:11:50] then I'll be able to harangue you some more to look at it again. [02:12:14] yay [02:12:16] keep in touch [02:12:31] TTL for HTCP multicast purging ($wgHTCPMulticastTTL) <- belongs in squid settings [02:13:20] *werdnum blames ialex. [02:13:31] Yeah, I'll be on for a few hours every afternoon (your time) [02:13:36] you know when I'm usually around :) [02:13:46] :D [02:14:07] *werdnum wonders why VLC won't work on his iPhone. [02:16:20] werdnum: the extiontion is installed but dosn't work [02:16:40] 03jhsoby * r44055 10/trunk/tools/planet/de/ (config.ini templates/index.nb.html.tmpl): Reverting; the proof-of-concept test worked - Scandinavian Planet Wikimedia one step closer ;) [02:16:41] S-i-A: You'll need to be more precise than "Doesn't work" [02:16:48] *AaronSchulz is always around [02:16:53] {{Thankyou [02:16:53] |reason=all [02:16:53] |signature=Joe}} [02:16:56] AaronSchulz is freaky. [02:17:00] i add that nothing [02:17:04] srsly, he's on like 24 hours a day. [02:17:14] At least I take a break from midnight to 8 or 9am :) [02:18:24] hiya. i've noticed that my wiki site absolutely HATES HTML-based tables, particularly if htey have any options in the tag, such as align="center".. how do i remedy this? [02:18:25] also the template dont worked {{community news|right}} just display the link [02:18:45] *werdnum resists saying "Use wiki tables" [02:19:09] i use wikitables when i can [02:19:42] however, it's annoying when i try to make a custom table, and god help me if i try to use an infobox :P [02:21:22] f** nothing work for me nothing [02:21:27] the tables to [02:21:43] what errors do you get, S-i-A? [02:22:14] nothing i will use template like wikipedia ot tables dont work any thing [02:22:30] i see [02:23:00] got a live link we could look at? [02:24:14] me? http://wiki.mobianlegends.com/wiki/Template:Infobox_settlement or http://wiki.mobianlegends.com/wiki/Template:Infobox_Country [02:24:37] was referring to S-i-A in that instance [02:24:42] oh sorry [02:24:51] well, he's having a similar problem to mine (HTML Tables) [02:28:31] 03(mod) Support for Chemical Markup Language - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16491 (10nospam) [02:32:08] We need to add something like Gmail's "Mail Goggles" to core MediaWiki. :) [02:33:24] so, no one can help S-i-A and i? [02:33:32] Krimpet: why, what happened? [02:33:49] werdnum, it'd be very valuable in general. [02:34:02] Krimpet: Are you talking about committing or editing? :) [02:34:02] what is a mail goggles? [02:35:01] yksinaisyyteni, in the wee hours of night, it makes you answer some arithmetic problems before it'll send your mail, to make sure you aren't drunkenly sending something you'll later regret. :) [02:35:19] Sadly not included in Google Apps. :/ [02:35:29] that doesn't sound very useful, i'm not bad at arith even when i'm drunk [02:35:30] what if you're like me and sober all the time, but ya just suck at math? [02:35:51] RingtailedFox: there's a difficulty setting. [02:35:55] ok [02:36:20] What if you're drunk all the time and have learned how to do math drunk? [02:36:30] Not speaking from experience or anything... [02:36:52] Hmm, maybe Google didn't think this feature completely through. [02:37:02] lol [02:37:11] ^_^ silly silly silly... they should be asking questions about the universe... everyone /knows/ that you can only answer those when completely out of it... heh [02:37:36] perhaps it should make you move the cursor across the window in a straight line [02:37:38] ;) And you can log the answers to those questions [02:37:42] heh [02:37:48] Have I ever mentioned just how awesome VLC is? [02:37:53] *ST47 isn't sure whether Dantman meant for that to be as deep as he was, but if he did, /me applauds him [02:38:06] yksinaisyyteni: nonsense, I can't do that either. [02:38:19] Dantman, on the contrary, when I'm extremely stoned, I seem to be much more philosophical and interested about the universe and all. :p [02:38:24] and don't suggest typing the alphabet backwards. [02:38:35] ;) That's what I said [02:39:06] It's the sober people that don't truly understand the universe [02:39:14] Oh. I thought you were actually punning on 'out of it' >.> [02:39:25] heh [02:39:30] *ST47 needs to stop assuming that people are conspiring to confuse him [02:40:05] Also, saying complex things while under the influence of /me is difficult and sometimes comes our very convoluted. [02:40:07] *Krimpet once fell down dizzily and shattered into a million little blue pieces... [02:40:21] ^_^ Half the time I come up with a joke like that, it ends up coincidentally philosophical or such in some way [02:40:25] *ST47 paints Krimpet green [02:40:51] It was like a big grid of cells or atoms or something. [02:41:03] ;) the trick is not to rely on alcohol...... maddness is where it's at... buahahahahahaha!!! [02:41:47] Hexagons? [02:41:56] Has anyone looked at https://bugzilla.wikimedia.org/show_bug.cgi?id=16503 [02:42:08] *ST47 hasn't, but shall [02:42:22] Like a big [[cellular automaton]]. [02:43:00] eww, windows [02:43:10] You're missing a file somewhere, if you didn't catch that [02:43:25] Early computer builder Zuse once hypothesized our universe was a huge cellular automaton. [02:43:26] techman224, you should probably actually say what command you ran, and what directory you were in when you ran it [02:43:30] ST47, but the files are there [02:43:35] *Krimpet tokes [02:43:36] Also, if you set the MW_INSTALL_PATH variable or not [02:44:07] ST47, I ran php install.php [02:44:16] in the checkuser directory [02:45:02] *werdnum rickrolls #mediawiki, and promptly loses the game. [02:45:19] ST47, The files are there [02:45:57] Well the issue here... is that it's trying to find a file inside the wiki's root, not the checkuser extension folder [02:45:59] *Krimpet rolls werdnum with http://www.youtube.com/watch?v=i3x4C1fJcUk [02:46:10] werdnum: no no, you have to do all of the wiki* channels at once and all of wikipedia as well [02:46:25] Dantman, how do I fix it [02:47:16] Copy the first 15 lines of install.php into a pasty to double check [02:47:38] Krimpet: the 'related videos' for that freak me out [02:47:56] waitasecond... [02:48:08] It's not including from root... it's including from includes [02:48:20] Dantman,that should be changed [02:48:41] You're sure that extensions is actually inside of htdocs\techwiki\extensions\CheckUser\ [02:48:48] I mean yours is including from includes [02:48:52] Dantman, becuase the files install.php and install.inc are in the checkuser extension folder [02:48:55] There is nothing inside of the code that does that [02:49:02] Dantman, yes [02:49:27] The install code finds the absolute directory that the install.php file is inside of, and uses the install.inc file inside that same folder [02:49:41] Krimpet: lol wut [02:49:49] Dantman, wait 1 sec [02:49:57] So there is no reason it should be including from anywhere else unless something of yours is screwed up [02:50:05] Hmmm... wait [02:50:53] I think I know the issue [02:52:11] Dantman, nope, ddn't work [02:52:16] I tried caping the U [02:53:07] Dantman, what is it? [02:53:19] http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CheckUser/install.php?r1=43987&r2=43986&pathrev=43987 [02:53:23] *Dantman slaps siebrand [02:54:18] Just for a bit of microptimization... going and screwing things up [02:55:18] Dantman: That looks fine to me. [02:55:41] Dantman: also, it's good code cleanliness, even if the optimisation does fuck all. [02:56:00] werdnum, I'll revert to that revision to see if it works [02:56:31] Dantman: what did he stuff up? [02:56:49] :/ So... good code breaks horribly if unrelated files happen to make use of the genericly named variable $dir? [02:57:06] because the directory is saved inside the variable $dir [02:57:12] Then a require_once is done [02:57:35] Dantman, before it worded [02:57:53] I've reverted install.php to revision 43986 [02:58:16] If the code included by that require_once just happens to use a variable by the name $dir, when it goes to hit the second include it may have a different value and can break [02:58:54] And would someone please fix it now, thanks [02:59:09] 1. $dir is set [02:59:21] 2. commandLine.inc is included using that [02:59:32] 3. commandLine.inc includes LocalSettings.php [03:00:02] 4. Core code or an extension sets the $dir variable to something else for it's own use [03:00:25] 5. Code finally leaves the require_once and returns back to install.php [03:00:51] 6. The $dir variable has now been changed, and is invalid for use with that require_once to include install.inc [03:02:35] Hmmm... someone else care to revert? [03:02:49] I'm not used to command line reverting... [03:04:21] werdnum, could you do it [03:11:16] techman224: do what? [03:11:41] What Dantman was talking about [03:12:03] checkuser install script doesn't work right doesn't work [03:12:27] http://svn.wikimedia.org/viewvc/mediawiki?view=rev&revision=43987 [03:12:30] werdnum,http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CheckUser/install.php?r1=43987&r2=43986&pathrev=43987 [03:12:33] revert [03:12:45] Breaks inclusion of files for a number of extensions [03:13:05] As I recall, Setup.php or something like it, makes use of the $dir variable [03:13:34] Even if not, that there basically has the bug where including 2 extensions that use $dir will make one extension break the other [03:14:06] Dantman: $dir is just used later on in the same scope to include a bunch of other files. If it gets redefined later on, then who cares? [03:14:53] $dir = dirname(__FILE__); require_once($dir . '/something.php'); $dir = '/some/other/dir'; require_once($dir . '/somethingelse.php'); will still work as expected [03:15:01] *Skizzerz doesn't see the issue here [03:15:03] http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CheckUser/install.php?r1=43987&r2=43986&pathrev=43987 [03:15:12] It doesn't work [03:15:21] 1. $dir is set [03:15:21] 2. commandLine.inc is included using that [03:15:21] 3. commandLine.inc includes LocalSettings.php [03:15:21] 4. Core code or an extension sets the $dir variable to something else for it's own use [03:15:21] 5. Code finally leaves the require_once and returns back to install.php [03:15:22] 6. The $dir variable has now been changed, and is invalid for use with that require_once to include install.inc [03:15:28] *werdnum stabs Dantman [03:15:31] anyway, I'm reverting now. [03:15:37] 03werdna * r44056 10/trunk/ (53 files in 40 dirs): [03:15:37] Revert "Follow up on r43982. Reduce dirname(__FILE__) calls in core and extensions." [03:15:37] Uses $dir in extension files, and assumes that it remains unchanged in require_once( 'maintenance/commandLine.inc' ). [03:15:37] In fact, it is likely that '$dir' will be set when setting up command-line, as some extensions will use the same var. [03:15:38] Commit will show up in a moment. [03:15:40] Recommended fix: Use $CentralAuth_dir, $EmailPage_dir, etc. [03:16:20] "Recommended fix: Use $asodifjnasdoifnoawer, $aosdkfjoaierje4, $o2408hq34fnsd, etc." [03:16:34] ^_^ We're not using JavaScript, there is no local scope [03:16:45]