[00:00:58] 03brion * r45470 10/trunk/phase3/includes/parser/Parser.php: [00:00:58] Reverting r45341 " Use Sanitizer::escapeId() in another place Reduce code duplication some more, and fix section redirect after edit [00:00:58] when $wgEnforceHtmlIds is off." [00:00:58] This produces non-matching stuff like "#_Rock_on_dudes_" for == ''Rock on'' dudes ==. [00:03:11] brion-codereview, what "non-matching stuff"? I'm not clear what the problem is. All parser tests pass. [00:03:54] Is it a problem when $wgEnforceHtmlIds is off? [00:03:57] Or on? [00:04:26] $wgEnforceHtmlIds = true; [00:04:31] and try the section name i mentioned [00:04:50] parser tests probably don't catch this since it's not for the stuff that's in the parser [00:04:55] Ah, right. [00:04:59] it's the editing [00:05:04] there *should* be test cases for this [00:05:16] if you can devise a way to test it that'd be awesome :) [00:06:04] Weird. [00:06:18] 03(NEW) FlaggedRevs' talk page patrolling behaves irregular - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16913 15enhancement; normal; MediaWiki extensions: FlaggedRevs; (Wiki.Melancholie) [00:06:23] Hello, is there a way to restrict non-users from reading contents? [00:06:42] !prevacc | Murdoc [00:06:42] --mwbot-- Murdoc: http://www.mediawiki.org/wiki/Manual:Preventing_access [00:06:48] thx [00:06:51] We need a general test suite, not just parser tests. [00:07:07] Simetrical: re CSS files, it might be useful to rationalise the skins so that they return a list of CSS files that they will include, and also any in-line CSS. [00:07:26] HappyDog, why? [00:07:38] brion-codereview, oh, bleh, there's tons of preprocessing that needs to be done for this to be correct. [00:07:49] Should fix it up so that this and formatHeadings() use the same code, probably. [00:08:11] Well, it would help me get my extension working, for a start :-) [00:08:15] yeah, it's a rat's nest in there :D [00:08:49] 03dale * r45471 10/trunk/extensions/MetavidWiki/skins/mv_embed/libRemoteMediaSearch/mv_remote_media_search.js: minor missing width bug fix [00:08:55] It would also tidy up the code a bit, I think, and might well prove useful in creating a 'combined' CSS file, as has been discussed on wikitech-l recently. [00:12:40] Why would it tidy up the code? [00:12:55] It would add on an extra function that does nothing but do this. [00:13:30] It wouldn't be useful for combining. You'd have to adjust all callers in either case. [00:13:55] Combining isn't going to give the combine script a list of URLs, it will give it a list of files and/or raw input. [00:13:59] The independent files probably won't exist. [00:15:50] Need help adding a wikipedia search box to my homepage [00:16:08] can anyone point me to a page with the code? [00:17:09] Copy it from somewhere. [00:17:12] Like a Wikipedia page. [00:17:37] Ugh, this code uses all sorts of intermediate values. Hard to break up. [00:18:00] Simetrical: It would tidy up all the duplicate bits of code that generate @import statements, scattered throughout Skin.php and the individual skin sub-files. You could have a function in the Skin class that generates the style headers by calling (new functions) Skin::getCommonStyles() and SkinXXX::getSkinStyles() to populate an array of relative file names, and then output using a loop. [00:18:06] which is why i was hoping there was a widget [00:19:06] This function could later be rewritten to output a single CSS link, which uses the same functions to combine the files into a single file. [00:19:21] HappyDog, you mean have one function to generate all the