[00:02:13] siebrand: The amount of changes you put in one commit, across many files, makes it difficult to track what you're doing. [00:02:49] hi davidmccabe [00:02:51] Hi. [00:02:57] how's it going? :) [00:03:20] Fine; bug hunting. [00:03:42] mmm, fun [00:03:48] I hear you may start working on Liquid Threads. That's great; I could use the help. [00:04:14] <--- his muted voice issues from the bottom of a pile of hacks. [00:04:27] Yes, I'm hoping to iron out the last few bugs and make it a bit more MediaWiki-ish [00:05:11] If we're lucky we can get it deployed to Wikimedia :) [00:05:28] Do you have a plan of what you're going to work on? [00:06:04] Not really. I've just done some code review so far [00:06:52] Miscellaneous stuff: line breaking, mysql replication compatibility, avoiding too many DB queries, etc. [00:06:57] Generally getting to know the codebase [00:07:06] Let me know if you have any questions. [00:07:10] how can i add a new box in the sidebar via javascript? addPortletLink('p-tb' adds a link into the toolbox but I want to create my own "admin tools" box [00:07:12] It's difficult for me to understand, and I wrote it. [00:07:28] Subfader: you have to create a new portlet [00:07:31] sure thing [00:08:02] I'm sure you noticed that I split it all out into different files. [00:08:05] Please tell me if I broke anything [00:08:06] Subfader: it might be easier for you to just put it in the Sidebar message and display:none; it in site CSS, and then display:block in javascript if the user is admin [00:08:07] had that guess it's the p-tb in addPortlet('p-tb' [00:08:13] werdnum: I strongly object to that, actually. [00:08:21] davidmccabe: oh, really? [00:08:22] werdnum: At least the mini-classes should go in one file together. [00:08:26] Hmm [00:08:33] (Better: find a way to get rid of them.) [00:08:47] Subfader: there is no helper for that alas, you have to document.createElement the div, the

, the inner
, and all the ul/li, as well as .setAttribute every attribute, and appendChild each one [00:08:58] Well, certainly the big classes like Thread, Threads, blah blah need to be in separate files. [00:09:08] It makes the code much easier to navigate [00:09:13] That's fine. [00:09:24] ui ui will display it [00:09:38] wha? [00:09:55] I just did all the splitting in one go with a perl script :P [00:10:06] ui ui @ alternative. will use display:none/block [00:10:16] werdnum: Just as a point of making it easier to collaborate, fixing whitespace and removing code should go in separate commits. [00:10:16] heh, k [00:11:13] Fair enough. So far I've worked mostly on extensions by myself, and then had one big review at the end. Two people on the same extension at once is new to me, so thanks. [00:11:26] Subfader: easiest way... lets say you create * Admin tools , and then find what class it assigns, possibly #p-Admin_tools, but I am not sure how it handles spaces exactly.. so you #p-Admin_tools {display:none;} in MediWiki:Common.css [00:11:31] werdnum: Most of those mini-classes are hacks added quickly to bring certain functions to liquid threads without hacking into them the way I did with EditPage to make the experience nice. I'd like to get rid of them. [00:11:56] davidmccabe: Which ones are we thinking of? [00:11:56] then in MediaWiki:Common.js you add: [00:12:24] if(wgUserGroups && wgUserGroups.join(' ').indexOf('sysop') != -1) appendCSS('#p-Admin_tools {display:block !important;}') [00:12:26] what could be the cause for parse error in any non-english language? I tried fr, pt-br, de and always see a message like: Parse error: syntax error, unexpected $end in /home2/otto/public_html/otto/wiki/languages/messages/MessagesFr.php on line 2592 [00:12:49] Schuenemann: Is that on svn HEAD? [00:12:54] Subfader: then only admins see it by default, you can then add new objects to it with addPortletLink, or by Sidebar [00:13:09] werdnum: Things like IndividualThreadHistoryView, ThreadProtectionFormView, etc. [00:13:21] werdnum, sorry? [00:13:22] a list to Special:Blockip that is static should be added by sidebar, a link to delete the current page should be added via JS as it is dynamic, and so forth [00:13:30] Schuenemann: What version of MediaWiki are you using? [00:13:36] davidmccabe: ah, right. [00:13:46] that's even cooler than my user monobook.ss [00:13:47] werdnum, 1.13.4 [00:13:53] I'm not sure that I've delved in enough to actually understand what they're doing yet :) [00:14:04] c [00:14:05] Mar 1 19:11:27 aryeh-desktop kernel: [2243718.100096] xchat[7363] general protection ip:b71c0412 sp:bfa8bd20 error:0 in libc-2.8.90.so[b714f000+158000] [00:14:05] :( [00:14:08] \o [00:14:14] werdnum, it's a release [00:14:49] Subfader: well, about half the skins use the sidebar portlets with those classes, IIRC, so it'll work on those it works in, heh [00:16:56] werdnum, know anything about it? [00:17:24] no, perhaps a dodgy installation. [00:17:32] Can you paste the last line of MessagesFr.php? [00:18:17] REL1_13_4/phase3/languages/messages/MessagesFr.php is 2784 lines long.. [00:18:22] 'confirmemail_error' => "Un problème est survenu lors de l'enregistrement de la confirmation de votre adresse de courriel.", [00:18:24] looks normal [00:18:49] the other languages look normal too [00:18:53] that is the correct line 2592 [00:18:58] but is that the last line? if so, too short [00:19:26] last line? [00:19:30] should be about 200 more lines [00:19:35] Can you paste the last line of MessagesFr.php? [00:19:42] oops, sorry [00:19:46] last is ); [00:19:56] last line is winky-sad? heh [00:20:22] the one before is 'intentionallyblankpage' => 'Cette page est intentionellement vide et elle est usée comme un test de performance, etc.', [00:20:26] is that comma correct? [00:20:47] werdnum: php doesn't care about trailing array commas, right? [00:21:26] Splarka, right. [00:21:37] Think MediaWiki's default theme could use some touchups? [00:21:48] But there's no ");", if that's really the last line. [00:22:43] Simetrical, all message files have that as the last line [00:23:21] Ah, right. [00:23:37] I found a bug in MediaWiki. [00:23:54] actually I care more about pt-br. It's the one I want [00:25:06] Marybelle, OH TEH NOES. STOP PRESSES!! [00:25:08] Marybelle: congratulations [00:25:23] Yes, I know. This is quite shocking. [00:29:41] do I really need to upload all those language files? Or just the ones I need are enough? [00:31:09] It depends if you'll need them, really. [00:31:56] Splarka: Works now although I'm the only admin. Took me a while to realize that User:Me/monobook.css doesn't override Common.css [00:32:00] Splarka: Works now although I'm the only admin. Took me a while to realize that User:Me/monobook.css doesn't override Common.css [00:32:24] well, wouldn't be common then hrr [00:33:13] It doesn't? It should. [00:33:22] Are you sure? [00:33:43] Of course, "override" here means "come after in the cascade". A more specific rule from the earlier stylesheet will still take precedence. [00:36:34] 03(NEW) Missing "Deletion log" select option in betawiki log with French interface - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=17746 15enhancement; normal; MediaWiki: Special pages; (wiki.pierroman) [00:36:35] Marybelle, I think I'll reupload everything again [00:36:52] SVN is nice. [00:37:40] what? get the latest? [00:37:45] daily build? [00:45:41] Simetrical: It does now. Forgot i need to use monobook2.css [00:45:53] Ah, custom skin. [00:46:00] MonoBook2.php uses #p-by_tracklist_state { display:none !important; } [00:46:05] bah [00:46:12] require_once('MonoBook.php'); [00:47:11] Hey tim, regarding https://bugzilla.wikimedia.org/show_bug.cgi?id=12130 (some browsers treat