[00:00:33] 03(mod) Add border="1" to tables, not just their stylesheets - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=18829 (10happy-melon) [00:07:46] 03(mod) API: support for "tags" - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19004 normal->high; +comment (10matthew.britton) [00:09:28] 03dale * r51773 10/branches/new-upload/phase3/js2/mwEmbed/libClipEdit/mvClipEdit.js: some stand-alone sequencer fixes. [00:15:13] 03(NEW) Can not print out a PDF file of enwiki article Uniforms of the United States Marine Corps - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19167 major; Normal; Wikimedia: wikibugs; (glacierwolf) [00:16:08] <^demon> Summary of the day. [00:18:48] 03(mod) Review-API-Module is not working on WMF-Projects - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19166 (10JSchulz_4587) [00:23:17] 03(mod) Can not print out a PDF file of enwiki article Uniforms of the United States Marine Corps - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19167 (10p858snake) [00:28:52] 03(NEW) is broken inside tags - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19168 normal; Normal; MediaWiki: Templates; (snottygobble) [00:43:20] ^demon|afk, it's supposed to be nasty. AFAIK, having REMOTE_ADDR incorrect means your PHP setup is completely broken. The admin needs to be informed so they can debug or fix it. Has there been a single case presented where mashing everyone's IPs together would actually be the best solution? [00:45:14] <^demon|afk> Simetrical: I can't even get the UI to load to spew the exception there, it throws an exception in itself because the db wont start. [00:45:23] Oh, really? [00:45:28] That *is* pretty nasty, then. [00:45:39] How do early failures in Setup.php or whatnot work? [00:45:40] <^demon|afk> Yes, white screen of death. [00:46:02] Just die()? It's better than silently corrupting the database with bogus IP addresses . . . [00:46:04] <^demon|afk> Hard, like that. But I don't think we should fail _that_ hard just because someone borked the REMOTE_ADDR [00:46:17] We do that for a bunch of cases where we know things are unfixably broken. [00:46:47] <^demon|afk> If I can get the exception in the UI I'll be happy. [00:47:12] Hmm, we don't fail horribly for magic_quotes_runtime? We only seem to abort install. [00:47:34] <^demon|afk> Hmm. [00:47:35] <^demon|afk> Brb [00:49:10] We currently die for some register_globals-related stuff. [00:50:30] And for PHP 5.0.x on 64-bit. [00:51:11] I don't know, any solution that silently puts fake stuff like 0.0.0.0 or 127.0.0.1 into the database is a bad solution, IMO. [00:54:27] maybe we should do explode(',', $_SERVER['REMOTE_ADDR']) [00:54:55] I understand the server admin in question is simply copying the XFF header to the REMOTE_ADDR environment variable [00:55:04] and we do understand XFF headers [00:55:09] <^demon|afk> TimStarling: Special case for someone who tries to do that? [00:55:11] Was that the only case it was reported in, though? [00:55:22] What if it seems to not work even after that? [00:55:24] <^demon|afk> Simetrical: I couldn't find any dupes. [00:55:33] So it's just this one broken free webhost? [00:55:33] i don't think MW should have workarounds for completely broken and non-standard custom setups [00:55:40] copying XFF to REMOTE_ADDR is simply wrong, and won't work [00:55:45] Which copies XFF into REMOTE_ADDR and doesn't even do it properly? [00:55:47] <^demon|afk> Simetrical: It can't establish a username with no IP, then tries to feed a null title into a link function. [00:56:12] I also don't think we should have workarounds for such broken behavior unless it's actually common. [00:56:27] If it's just one webhost, then at best we should die gracefully. [00:56:29] die() is as much a workaround as explode() isn't it? [00:56:34] Possibly we should just ignore the whole issue. [00:56:46] Mark WONTFIX and tell them to beat their webhost with a cluebat. [00:56:55] TimStarling: no, because one provides a clear failure mode, and the other pretends to work with unknown side effects and might break even worse in the future [00:56:58] TimStarling, it's a more general one in case REMOTE_ADDR is bogus in other cases. [00:57:01] <^demon> Simetrical: The base cause needs addressing: we fail badly with malformed REMOT_ADDR [00:57:30] Well, we could sanity-check every global in existence, couldn't we? [00:57:57] The only reason REMOTE_ADDR is malformed is because the server admins deliberately messed it up. [00:58:06] <^demon> I thought about writing a Globals class to handle superglobal things like that with sanity checking. [00:58:09] <^demon> Never got around to it. [00:58:28] there's three reporters on that bug report? [00:58:38] TimStarling, it's a fairly popular free web host, I think. [00:58:48] they might have all come from a forum link [01:00:05] <^demon> Is there another global similar to REMOTE_ADDR we could attempt to fail back to, as a next best guess? [01:00:36] REMOTE_HOST, but it might be a hostname [01:00:51] Resolve it! [01:00:55] \o/ [01:01:16] (that would open up nasty exploits if someone could suppress REMOTE_ADDR at will, of course) [01:01:31] (point your DNS at whoever's IP you want . . .) [01:01:50] that's easy to fix, you just do a forward and reverse lookup [01:01:56] <^demon> gethostbyname()? [01:01:57] (although it's a stupid idea in the first place, of course) [01:02:07] ^demon: that is obsolete [01:02:16] ^demon: getaddrinfo, then pass the result to getnameinfo [01:02:27] Yeah, how about we just stop wasting brain cells and tell Nearly Free Speech to copy XFF properly and only use the first part. [01:02:38] oh, it's NSF? [01:02:39] for the record, what bug is this? [01:02:50] And just leave MediaWiki to behave unpredictably if they break PHP in patently stupid ways. [01:02:51] they're usually not braindead about things [01:03:16] <^demon> !b 18173 [01:03:16] --mwbot-- https://bugzilla.wikimedia.org/show_bug.cgi?id=18173 [01:04:47] Okay, it looks like there are a number of unrelated causes. [01:04:57] So we shouldn't just ignore the issue. [01:05:03] But we shouldn't make up bogus addresses instead. [01:05:16] I say we fail fatally to begin with, printing out the bogus REMOTE_ADDR. [01:05:38] Then if there's a consistent pattern where some particular setup (not specific to a single host) is broken, we work around that like with other PHP bugs. [01:05:40] Okay? [01:06:03] <^demon> Sounds ok. Writing a patch. [01:06:52] 03(mod) Login form barfs on malformed REMOTE_ADDR - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=18173 04BLOCKER->major (10Simetrical+wikibugs) [01:17:20] if they were copying XFF to REMOTE_ADDR, there'd also be a $_SERVER['HTTP_X_FORWARDED_FOR'], and it would give you the IP [01:20:28] <^demon> Tim: Would you suggest trying to determine an IP from that, and then barring that, fail? [01:25:09] $ipchain = array(); [01:25:16] if ( isset( $_SERVER['REMOTE_ADDR'] ) ) { [01:25:26] $ip = IP::canonicalize( $_SERVER['REMOTE_ADDR'] ); [01:25:30] if ( $ip ) { [01:25:36] $ipchain[] = $ip; [01:25:37] } [01:26:07] $ip = false (instead of ipchain[0]) [01:26:37] then later: if ( !$ip ) { throw new MWException( 'Unable to determine IP' ); } [01:26:47] 03(mod) Merge new-upload branch (tracking) - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=18563 (10dale) [01:32:16] I've been thinking about updating wikimedia to r51535 plus patches [01:32:35] 03(WONTFIX) in FF 3.5b4 timer shows full time of original clip - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19030 +comment (10dale) [01:33:34] once I'm done reviewing the collection extension [01:34:58] 03demon * r51774 10/trunk/phase3/ (RELEASE-NOTES includes/ProxyTools.php): [01:34:59] Revert r51725 (fall back to 127.0.0.1 when IP cannot be determined). On further [01:34:59] discussion, it's best if we don't make up a fake IP. Tweak the logic here a bit [01:34:59] (per Tim) to let XFF attempt to determine the actual IP. Throw an exception if [01:34:59] we can't. [01:38:22] the way Collection saves pages is interesting, I'm wondering who came up with the idea [01:38:27] wow, I thought this was something only PHP was supposed to do... var wgNamespaceNumber = 0; if(!window.wgNamespaceNumber) {...} [01:38:32] 03demon * r51775 10/trunk/phase3/RELEASE-NOTES: Tweak RELEASE-NOTES [01:38:49] *Splarka didn't think js globals checked as window.globalname should return false for integer zero [01:48:12] 03dale * r51776 10/branches/new-upload/phase3/js2/mwEmbed/ (4 files in 3 dirs): seek tweeks [01:50:11] installing a new instance of mw. I thought it supported pg8, why is that not an option on the config/index.php form [01:50:55] perhaps I need to install drivers for it [01:50:59] trying that now [02:10:42] 03(mod) Hook to alter upload form - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=8867 (10dale) [02:12:36] it was that the pg drivers were missing for php5, that resolved the issue [02:13:51] 03demon * r51777 10/branches/maintenance-work/maintenance/ (Maintenance.php eval.php): [02:13:51] * Minor tweak to help, only show <> when there's some args to put in [02:13:51] * Port eval.php [02:26:04] 03(mod) Login form barfs on malformed REMOTE_ADDR - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=18173 +comment (10innocentkiller) [02:26:35] is it possible to get mediawiki to use other content as a source? For example, I'd like to automatically pull the contents of a README file for the corresponding wiki page, rather than having to update it by hand. [02:27:18] (readme from svn) [02:33:07] I just got an error reading: "Can't contact the database server: Postgres functions missing, have you compiled PHP with the --with-pgsql option? (Note: if you recently installed PHP, you may need to restart your webserver and database)". [02:33:27] 03dale * r51778 10/branches/new-upload/phase3/js2/mwEmbed/ (3 files in 3 dirs): sequencer updates [02:33:35] However my install is from binaries in the Debian packaging system [02:33:38] TheUni: http://www.mediawiki.org/wiki/Extension:Include maybe [02:34:30] I have php5 installed for apache and the pg driver for php5, but I'm not sure how I would recompile a binary to see it [02:34:31] see http://www.mediawiki.org/wiki/Category:Data_extraction_extensions in general, and even more in general http://www.mediawiki.org/wiki/Extension_Matrix [02:36:32] <^demon> siebrand: You made my merge slow :P [02:37:45] that is a never mind, guess I needed an apache restart [02:37:50] off to the races now [02:37:54] Splarka: great, thanks [02:39:02] 03demon * r51779 10/branches/maintenance-work/ (42 files in 9 dirs): Merging changes from r51680-r51775 from trunk. [02:40:51] Splarka: aha, that looks perfect! [02:44:07] *Splarka hides the women and children [03:25:43] 03demon * r51780 10/branches/maintenance-work/maintenance/ (4 files): [03:25:43] * Port checkUsernames, deleteRevision and waitForSlave [03:25:43] * Prettify help some more [03:25:43] * Add similar has/get for args. [03:27:25] ^demon: Hey, I have a question about your new Maintenance class [03:28:36] Currently, we have a script to search through our database table to grab a list of all wikis, then it uses system() to run the update.php script with the correct arguments. Will there be an easy way to set parameters progmatically for the maintenance script before it runs, or will I still use system()? [03:31:26] <^demon> Not really at this point. [03:32:08] <^demon> You'd have to stick to your current method for the time being. That all being said, I would definitely like to add and improve on the system over time. Step 1 is organization and getting the basics in place :) [03:45:55] 03tstarling * r51781 10/trunk/extensions/Collection/ (Collection.hooks.php Collection.php): Fixed indenting on a few lines. [03:58:35] !b 8867 [03:58:35] --mwbot-- https://bugzilla.wikimedia.org/show_bug.cgi?id=8867 [03:58:49] bah why must someone use a bugmenot account for that >.< [03:59:39] you could change the account name [03:59:58] hmm, maybe someone has already [04:00:56] it says it's banned [04:01:15] its pointless that someone even created it because we already allow freesign up so its stupid [04:02:37] p858snake: that's not the point of bugmenot, the point is so that you don't have to waste time registering to use sites [04:11:14] We should just hack Bugzilla to allow anonymous postings. >:-) [04:11:28] 03tstarling * r51782 10/trunk/phase3/includes/SiteConfiguration.php: Pass the SiteConfiguration object as a parameter to fullLoadCallback. [04:12:13] Marybelle: won't bugzilla show them if you post directly to the mailing list? [04:12:35] Hmm, what? [04:43:15] help! I'm helping someone out with a template,MacMed (he left), but honestly, I don't know much about templates, the problem is is that the template (when inserted to a page) will keep adding text to the template when somethin is written below the template. So, I've tried many things, but can't seem to get the template to stop adding more and more text below it. The page that the template was created on is here: http://en.wikipedia.org/wiki/User [04:44:07] eh? [04:44:10] The page that the template was created on is here: http://en.wikipedia.org/wiki/User:MacMed/Mediationnote [04:48:03] and what's wrong with it? [04:49:23] hi all [04:49:31] when you insert it, the template will continue to add more and more text that is written below it, so if it was at the top of an article then the whole article would be inside of the template [04:50:01] have you been closing the template eg: {{TemplateName}} [04:50:15] I am trying to restrict anonymous access and added $wgGroupPermissions['*']['edit'] = false; to the end of LocalSettings.php but it doesnt work [04:50:17] any idea why? [04:50:30] cubs197: WFM: http://en.wikipedia.org/wiki/User:OverlordQ/Sandbox2 [04:51:09] OverlordQ, yeah awsome! [04:51:09] jono: is localsettings in the right directory? [04:51:20] Prodego, in wiki/config/ [04:51:24] wiki is the main dir [04:51:33] jono: that should work, have you tried to purge your browser cache to make sure its not showing incorrect text lables saying that you can edit? [04:51:56] you need to edit the LocalSettings.php in your wiki root [04:51:59] oh wait, localsettings should be moved to the main directory [04:52:02] OverlordQ, oh [04:52:14] jono: yep, what they said [04:52:20] *Prodego called that one! [04:52:34] thanks OverlordQ, works now :) [04:52:37] you guys rock :) [04:56:31] alright silly question, what's the magic code to add ~~~~ to a template so that it'll put your sig when you add it to a page [04:56:55] OverlordQ: there are many [04:57:12] do you want the simple way or the complicated way [04:57:21] OverlordQ no,no,no,no [04:57:28] there any drawbacks to either? [04:57:45] OverlordQ: when you subst the template? [04:57:57] cubs197: if it's in the main template space, hardcoding somebody's sig in there seems non-optimal [04:57:59] when the template is added notice that the username pops up! No need to change that! [04:58:37] OverlordQ: yes, both are ugly [04:58:48] it is best to just let people sign it [04:58:59] or create an intermediary template [04:59:02] It looks like he's going to use it once, notice: Request for case participation [04:59:12] {{subst:foo}} that would drop {{bar|~~~~}} [04:59:37] or {{bar|{{subst:REVISIONUSER}}}} or such [05:00:28] (the signature/name has to appear somewhere in the page you are saving the template call on, but that can be as a parameter to another template) [05:00:32] yes, I got it, all I needed to notice was that the title was wrong on the page, than the real template! [05:00:34] was just looking at [[w:Template:Mediationnote1]] which should just get burned with fire as it hardcodes both the issue and the sig [05:00:45] *Splarka hardcodes OverlordQ [05:01:37] OverlordQ, It looks like he's going to use it once, notice: Request for case participation [05:02:25] then put it in his userspace putting your personal templates in main template space, I think there's probably a policy on that :P [05:09:26] I don't think it is in the main template space, both of those links WERE in his user space, notice User:MacMed/test, and User:MacMed/Mediationnote, User:MacMed/(page name) will always be on his user space, it just branches out from the main user page. That is true for Wikipedia. I'm not sure about mediawiki, but on Wikipedia that is fine [05:25:09] morroning [06:25:37] 03(mod) Review-API-Module is not working on WMF-Projects - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19166 (10paul.copperman) [06:28:45] 03(mod) Review-API-Module is not working on WMF-Projects - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19166 (10paul.copperman) [06:47:39] 03shinjiman * r51783 10/trunk/phase3/languages/messages/ (4 files): Localisation updates Cantonese, Chinese and Literary Chinese [07:01:49] PHP Notice: Undefined variable: ip in /var/www/w/includes/ProxyTools.php on line 82 [07:01:59] (running commandline tools) [07:02:27] And another notice and a warning: [07:02:28] PHP Notice: Undefined variable: ipchain in /var/www/w/includes/ProxyTools.php on line 98 [07:02:28] PHP Warning: Invalid argument supplied for foreach() in /var/www/w/includes/ProxyTools.php on line 98 [07:03:16] *siebrand pokes the absent ^demon [07:18:56] 03(NEW) Upgrade ogghandler to current version - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19169 normal; Normal; Wikimedia: General/Unknown; (gmaxwell) [08:03:05] hi i have a question with user variables [08:03:22] which is the on which checks, if I'm already logged in or not? [08:03:48] is there something like "user_logged_in=true/false" ? [08:32:17] 03(mod) Dutch month names empty on SMW displays - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=17882 +comment (10rowan) [08:48:03] hi, [08:48:19] i want to remove "www" from my subdomain [08:48:22] what can i do? [08:51:14] i suppose i found it. use "$wgServer" variable [08:51:16] see you [08:59:03] 03(FIXED) Implement user permissions for saving books to the wiki - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=18902 +comment (10support) [09:00:43] 03(NEW) The info on special:Version should follow the direction of the language - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19170 enhancement; Normal; MediaWiki: Internationalization; (Gerard.meijssen) [09:17:35] 03ialex * r51784 10/trunk/phase3/includes/ProxyTools.php: [09:17:35] Fixes for r51774: [09:17:35] * declare $ip and $ipchain so that it doesn't throw notices and warnings [09:17:35] * don't set $ip to false after getting it from $_SERVER['REMOTE_ADDR'], otherwise it won't work when there's no XFF header [09:17:35] * fix logic when throwing the exception: throw it when there's no IP [09:35:02] 03ialex * r51785 10/trunk/phase3/includes/ProxyTools.php: Fix for r51774, r51784: set '127.0.0.1' as IP for CLI, but with explicit check for $wgCommandLineMode so that the exception "Unable to determine IP" is not thrown in this case. [09:36:26] Can FlaggedRevs be used to prefer no article at all over a newly-added, not yet reviewed article? [09:42:22] 03(NEW) Changes to usernames in talk page - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19171 normal; Normal; MediaWiki: General/Unknown; (billreid400) [09:43:27] aloha ... [09:44:54] i have another user question :D i've been coding MW for a year now, but am still a bit weak on actually using it :D ... anyh� ... how do you create a translation of a page ... [09:44:57] 03(mod) set $wgCategoryPrefixedDefaultSortkey=false for en.wiki - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=16552 (10happy-melon) [09:50:54] *Splarka facepalms [09:51:13] 14(INVALID) Changes to usernames in talk page - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19171 +comment (10herd) [09:53:07] chkno: don't know personally, but you could disable or restrict arbitrary page creation: $wgGroupPermissions['*']['createpage'] = false; etc [09:58:58] yo Splarka ... is there a way to add Common.JS but for a single page? [09:59:10] Splarka: Yea, I don't want to lock it down quite that much. Thanks, though. [09:59:38] freakolowsky: no, but you can have js just for one page [09:59:49] do tell [10:00:06] in MediaWiki:Common.js have: if(wgPageName == 'whatever') importScript('MediaWiki:Common.js/something.js') [10:00:33] k ... was thinking in that direction but i was hoping for options [10:00:41] that is options! [10:00:55] you want the html to actually change for that page? a new