[00:00:10] 03demon * r56463 10/trunk/extensions/CodeReview/ui/CodeAuthorListView.php: Fix link to author views. [00:00:21] <^demon> brion: That ^ needs merge+sync too. [00:00:52] also why is there a link to the help page for the user contribs in the top right.... [00:03:35] 03(NEW) remove edit and new page creation privilege of anonyms on id.wikipedia - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=20666 enhancement; Normal; Wikimedia: Site requests; (stanley) [00:03:46] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/releasenotes isn't working :\ [00:05:38] <^demon> Remove edit permissions for anons? [00:05:42] <^demon> o_O [00:07:38] just give them flagged revs [00:08:05] ^demon: You gonna comment? Don't wanna conflict you. [00:08:22] <^demon> I wasn't writing anything. [00:08:24] Vadalism happening with logged in accounts!.... NEVAR! [00:08:29] K. [00:08:30] <^demon> I can think up some good arguments for WONTFIX [00:08:46] my argument would be "stupid idea" wontfix [00:09:36] <^demon> NYT: Wikipedia removes anonymous editors from Indonesian version [00:09:51] anonyms [00:09:58] <^demon> Yeah those [00:11:10] 03(mod) Remove edit and new page creation rights for anons on id.wikipedia - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=20666 summary; +comment (10public) [00:11:17] how do I get rid of the new tool hints [00:11:25] not just the legend [00:11:45] Ryulong, try #wikimedia-social [00:11:57] ... [00:12:03] Just kidding, I just wanted to see how many channels we could push you through. [00:12:12] I do not like you [00:12:20] No, but Annemarie does. [00:12:33] I do. [00:12:36] Annemarie is a whore [00:12:45] *Annemarie solicits charitwo. [00:12:56] 03aaron * r56464 10/trunk/extensions/CodeReview/ (CodeReview.i18n.php ui/CodeReleaseNotes.php): Bump releasenote range limit and actually give a notice when out of it [00:13:01] Ryulong: View the page source, find the appropriate CSS id/class, and hide it. [00:13:32] 03purodha * r56465 10/trunk/extensions/Translate/TranslateEditAddons.php: Show diff of original English message when translation is fuzzied. [00:14:00] I'm seeing [00:14:20] abbr.minor { display: none; } [00:14:36] What a horrible class name... [00:14:51] 03(mod) Remove edit and new page creation rights for anons on id.wikipedia - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=20666 +shell; +comment (10innocentkiller) [00:16:35] that doesn't work [00:16:42] it gets rid of the m, b, and N labels too [00:16:56] hiding that they are minor edits [00:17:12] hmm [[Special:Statistics]] probably shouldn't inculde the brackets as part of the links for the list of members [00:18:00] <^demon> p858snake: Is it? WFM. [00:18:08] <^demon> Oh nevermind. [00:18:12] <^demon> Misread you [00:22:19] 03aaron * r56466 10/trunk/extensions/ReaderFeedback/specialpages/RatedPages_body.php: fixed message error & crappy class name [00:25:57] http://lists.wikimedia.org/pipermail/foundation-l/2009-September/055204.html o: conspiracy! [00:26:46] <^demon> Emufarmers: More like "zomg....it wasn't a conspiracy after all!" [00:26:57] That's what they want you to think! [00:27:28] 03brion * r56467 10/branches/wmf-deployment/languages/LanguageConverter.php: merge r56462 fix from trunk [00:29:40] ^demon: do maintenance scripts use $wgDBuser and $wgDBpassword if $wgDBadminuser and $wgDBadminpassword aren't set? [00:31:38] hmm [00:31:41] I can't use Twinkle [00:32:25] <^demon> Emufarmers: Yes. And using --dbuser and --dbpassword will override either one of those. [00:32:36] 03werdna * r56468 10/trunk/phase3/includes/specials/SpecialContributions.php: Fix regression in r52174 where parameter was not passed to MediaWiki:sp-contributions-footer [00:33:08] why can't I use twinkle [00:33:27] ^demon: so isn't https://bugzilla.wikimedia.org/show_bug.cgi?id=14201 effectively fixed? [00:33:42] "Reverting page: couldn't grab element "editform", aborting, this could indicate failed response from the server" [00:34:47] <^demon> Emufarmers: Eh kinda, but not directly. Fixed in that A) Almost all maintenance scripts don't need $wgDBadminuser anyway, and B) The installer grants the CREATE and UPDATE rights now too, so using $wgDBadminuser is even less necessary than before. [00:35:15] <^demon> But setting $wgDBadminuser in LocalSettings during install got reverted :) [00:36:11] 03(mod) Do not put "diff generator" comments into feeds - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=20601 (10jidanni) [00:36:13] Ryulong: why doesn't it use the damn API? [00:36:21] I don't know [00:36:39] the/dj is looking into it in #mediawiki-scripts [00:36:44] it may be because I don't have it installed via gadgets [00:37:07] but via js [00:37:22] ^demon: sounds fixed to me. [00:37:23] werdna: because its old, huge, and scary [00:37:41] it *deserves* to break then :) [00:37:49] <^demon> Emufarmers: As long as you make some note about how it's fixed in principle :) [00:38:01] Much like Helen Thomas. [00:38:22] not working still [00:38:50] Shocking that your expert detective work failed. [00:38:53] 03werdna * r56469 10/branches/wmf-deployment/includes/specials/SpecialContributions.php: Merge contributions fixes from trunk r56468 [00:39:07] !e Cite [00:39:07] --mwbot-- http://www.mediawiki.org/wiki/Extension:Cite [00:39:08] [andrew@zwinger specials]$ svn up SpecialContributions.php [00:39:08] Permission denied (publickey,password). [00:39:08] svn: Connection closed unexpectedly [00:39:10] :( [00:40:07] ugh [00:40:46] brion: I've merged to wmf-deployment, can you either append authorized_keys from zwinger to the svn server (mayflower?) or svn up yourself? :) [00:40:56] can't seem to svn up :( [00:41:04] <^demon> wfm [00:41:27] moment [00:41:31] no, on zwinger [00:41:41] <^demon> werdna: Yeah I just figured that out :p [00:51:20] 03brion * r56470 10/branches/wmf-deployment/includes/parser/Parser.php: [00:51:20] Revert r53832, r53897, r54145 "(bug 17988) Spaces before [[Category:]] links are no longer ignored" and followup [00:51:20] Causes entire page to go blank under some circumstances. [00:51:53] 03(mod) Calling in a way that it doesn't expect will result in invalid JS - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19581 (10N/A) [00:53:02] 03(mod) Old style x=y parameters should be optional and turned on with a config option, is the default - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=19582 (10hozanji) [00:56:35] Ryulong: twinkle is broken due to the edit page not being proper xml. (and twinkle uses xml parsers). [00:56:41] 03werdna * r56471 10/trunk/phase3/includes/User.php: Fix bug where checking another user's blocked status (like for contributions) would cause you to be autoblocked if that user was blocked. Regression in r56325 [00:57:05] oh [00:57:06] k [00:57:23] 03brion * r56472 10/trunk/phase3/includes/parser/Parser.php: [00:57:23] Revert r53832, r53897, r54145 "(bug 17988) Spaces before [[Category:]] links are no longer ignored" and followup [00:57:23] Causes entire page to go blank under some circumstances. [00:57:30] 03werdna * r56473 10/branches/wmf-deployment/ (extensions/LiquidThreads/classes/Hooks.php includes/User.php): Merge autoblock bug fix r56471 [00:57:36] i think i found an obvious error in the html that might be the problem, and it has been reported. [00:59:29] up'ing [00:59:42] 04(REOPENED) Spaces before [[Category:]] link are ignored - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=17988 +comment (10brion) [00:59:56] thedj: oh goodie :D show me? [01:00:47]
[01:00:48] rofl [01:01:00] brion: did change_tag_rev_tag have an old name? [01:01:42] ok, deploying [01:01:45] AaronSchulz: yes [01:01:48] ct_tag [01:02:35] *werdna slaps Church_of_emacs for good measure [01:03:46] ouch [01:03:59] *Church_of_emacs feels slapped :( [01:04:05] 03aaron * r56475 10/trunk/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php: Check crapy change_tag index variable [01:04:07] brion: & [01:04:15] s/feels/is/ [01:04:15] &what? [01:04:15] 03mrzman * r56474 10/trunk/phase3/includes/api/ApiUpload.php: Actually use the filename supplied by the user. [01:04:17] grr, I mean "^" [01:04:52] sec [01:05:07] *AaronSchulz is surprised that actually made sense [01:06:49] also in other news, the tech blog doesn't say how posted the article [01:07:21] p858snake: who? [01:07:23] 03brion * r56476 10/branches/wmf-deployment/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php: merge r56475 [01:07:37] yes that would be correct brion >.> <.< [01:07:53] p858snake: put it in bugzilla and assign it to rhalsell@wikimedia.org and cc me [01:09:34] Any ideas as to why my wiki would be segfaulting, or where to get actual debugging information? apache error log is http://p.defau.lt/?cP0ui9hE4W2vQ3SftMqa9g [01:09:57] 03brion * r56477 10/branches/wmf-deployment/includes/Linker.php: array() -> '' for string return [01:10:06] build php with debugging get a dump get a backtrace in gdb [01:10:28] hi [01:10:41]
[01:10:44] OverlordQ: can you help me do that? [01:10:48] brion: can you sync r56474 too? a one-line change to ApiUpload [01:11:02] the "Array" shouldn't be there... (de.wikipedia) [01:11:35] datura: brion is already looking at that bug. thx for reporting. [01:11:49] 03(NEW) Tech Blog doesn't show post author - 10https://bugzilla.wikimedia.org/show_bug.cgi?id=20667 enhancement; Normal; Wikimedia: General/Unknown; (p858snake) [01:11:59] Mike_lifeguard: you using distro package or your own compile of php? [01:12:10] the ubuntu package [01:12:10] thedj: that'S good. thx. [01:12:17] Mike_lifeguard: what rev of mediawiki? [01:12:28] whatever we were on yesterday... sec [01:12:42] (r55629) [01:13:34] are you using trunk or wfm-deployment? [01:13:37] *wmf [01:13:57] trunk [01:14:02] MrZ-man: is api uploading enabled currently? [01:14:04] svn up to at least 55644 [01:14:08] brion: yes [01:14:12] 03aaron * r56478 10/trunk/phase3/includes/EditPage.php: partial revert on r55573; livePreview() is still used [01:14:15] how long's it been enabled? [01:14:26] probably since the update [01:14:36] brion: ^ [01:14:38] then if it's not a regression since it didn't exist, let's just turn it off for now [01:14:58] Ryulong: thedj fixed Twinkle. [01:15:04] ok [01:15:26] blah, no way ot disable it? [01:15:27] ah wells then [01:15:44] it works, it just uses the wrong filename [01:16:04] MrZ-man: thanks, that seems to have done it (wonder how wmf was running that rev without issue...) [01:16:10] its getting the filename from the file, rather than what the user said [01:16:24] Mike_lifeguard: wmf uses a special branch [01:16:57] and it was a weird PHP bug that caused segfaults in certain cases [01:17:01] !r 55644 [01:17:01] --mwbot-- http://www.mediawiki.org/wiki/Special:Code/MediaWiki/55644 [01:17:09] fun times [01:17:32] MrZ-man: what happens if you don't provide the filename parameter? [01:17:41] its required [01:18:03] if ( !isset( $this->mParams['filename'] ) ) [01:18:03] $this->dieUsageMsg( array( 'missingparam', 'filename' ) ); [01:18:32] ah there it is [01:18:46] <^demon> Ewww 55644 :) [01:19:17] 03dale * r56479 10/trunk/phase3/ (5 files in 3 dirs): [01:19:17] * Enhanced OutputPage to support js2 style javascript without scriptloader enabled [01:19:17] ** loadGM output [01:19:17] ** unique request id based on wikiTitle revision / file time [01:19:17] * Moved jsAutoLoadClasses to setup.php ( made conditional ) [01:20:18] 03brion * r56480 10/branches/wmf-deployment/includes/api/ApiUpload.php: Merge r56474 fix for api upload filename [01:20:24] 03aaron * r56481 10/trunk/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php: I was given wrong info, old name was ct_rev_id [01:20:34] brion: r56478 and r56481 need merging [01:20:47] no wonder that was going slow [01:20:48] yay [01:21:40] *AaronSchulz merges 56481 [01:22:11] AaronSchulz: where's live preview used? [01:22:54] in EditPage.php [01:23:19] 03aaron * r56482 10/branches/wmf-deployment/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php: Merged r56481 [01:23:33] line 382 [01:23:42] AaronSchulz: isn't that in an option that w've disabled cause it never worked right, and some folks are in the middle of redoing it, but using js2 which we haven't enabled? [01:23:54] so it's like double-disabled? [01:24:04] well it is giving fatas [01:24:06] *fatals [01:24:15] so it should either be re-added or removed completely [01:24:18] where? [01:24:19] was it actually disabled? I thought it just never worked [01:24:25] Sep 17 01:04:04 10.0.2.167 apache2[27746]: PHP Fatal error: Call to undefined method EditPage::livePreview() in /usr/local/apache/common-local/wmf-deployment/includes/EditPage.php on line 382 [01:24:29] lots of those [01:24:32] <^demon> MrZ-man: It never worked so it got disabled :) [01:25:38] <^demon> I remember when it was briefly on :p [01:25:39] AaronSchulz: looks like the code isn't properly guarded, probably somebody decided to 'exploit this wonderful feature' with an editor tool [01:25:45] is there a nice and easy way to check if a specific revision is live on wmf or not? [01:25:57] since it's not expected to work, it should be changed to guard with a check on $wgLivePreview [01:25:58] <^demon> Church_of_emacs: No. [01:26:02] :( [01:26:17] <^demon> Although everything from the branch point back is :) [01:26:46] is there a non-nice way to check except going to the wiki and testing if the features got included? [01:26:50] would be lovely if we could get that somehow [01:27:09] validator now bitches that we leave off the type attributes on