[00:00:34] mostly i just don't like how the "post new thread" is hard to find if your not used to it [00:00:36] 03asher * 10/trunk/debs/varnish3/debian/ (6 files in 3 dirs): upgrade to varnish 3.0.2, varnishncsa: escape spaces in logged request headers [00:01:09] ashley: Where is that comments-extension of yours? I don't find it (still not used to the structure of the extensions-site). [00:01:33] And there's quite a few little things that aren't quite right with it, but by and large lqt gets the job done. [00:03:38] Mrokii: http://www.mediawiki.org/wiki/Extension:Comments -- I can't promise any specific date, but I'll try to work on that 5% to finish that patch so that I can commit it (really, it's just one JavaScript function not working, everything else should be OK...) [00:05:21] Mrokii: heya [00:05:28] Samus_Aran: Hi [00:06:15] 03bsitu * 10/trunk/extensions/MoodBar/ (4 files in 2 dirs): Adding "Show unanswered" filter to feedback dashboard [00:06:34] ashley: So you are the developer of the comments-extension? [00:07:42] that, and many other [[mw:social tools]] (well, not the *original* developer, but the current maintainer) [00:07:56] cool. [00:09:02] :D [00:09:44] The screenshot looks nice. [00:10:34] ashley: What exactly doesn't work with the extension at the moment? [00:11:29] ResourceLoader (http://www.mediawiki.org/wiki/ResourceLoader), a new feature in MediaWiki 1.17+, broke the JavaScript badly (this extension is quite old, dating back to like 2006 or so) as the Comments extension uses plenty of inline JS [00:11:52] I've prepared a patch to fix that, but there's one small thing to fix in that patch (an invalid JS-generated link) [00:12:10] okay [00:12:48] basically, when you click on a "reply" link on a comment, you are taken to the bottom of the page and the text "Reply to Foo (Cancel)" appears above the comment form -- the "Cancel" link doesn't work, but everything else should work after applying my patch; if you're adventurous enough, I can post that patch on-wiki [00:13:42] heh. [00:14:26] I am not yet sure if I want to install it. Have to discuss it with somebody :) [00:14:31] 03(NEW) Search bar doesn't fill out to screen width in landscape mode on ICS - 10https://bugzilla.wikimedia.org/33552 normal; Wikimedia Mobile: android; (brion) [00:14:36] ashley: I think we'd like to try out your patch. [00:14:47] Mrokii: I'm open to trying the currently available ones, before writing my own [00:15:09] At the moment, there won't be many comments on my page anyway, so not much that can be destroyed, heh. [00:16:21] Samus_Aran is that "somebody", btw :) So yeah, we could give it a try, if you'd be so nice to upload the patched version, heh. [00:18:07] 03(mod) Search bar doesn't fill out to screen width in landscape mode on ICS - 10https://bugzilla.wikimedia.org/33552 +comment (10brion) [00:19:06] 03(mod) Search bar doesn't fill out to screen width in landscape mode on ICS - 10https://bugzilla.wikimedia.org/33552 (10Brion Vibber) [00:21:08] Mrokii, Samus_Aran: http://www.mediawiki.org/wiki/User:Jack_Phoenix/Comments_RL_patch -- mind you, GeSHi eats tabs for breakfast, so I suggest going to the edit mode and copypasting the code between and tags into a .patch file and then applying it [00:21:13] Mrokii: that extension is GPL v2+, so it's compatible with how I would be licensing my own comments code, so I could use it as a base [00:22:32] ashley: Tbh, I have no clue what you're talking about (regarding GeSHi), as I've just started using MW and wasn't the one whoe installed it, heh. [00:22:46] Mrokii: I understood, no worries. [00:22:51] Samus_Aran: Okay. [00:23:13] hehe :D [00:26:51] I guess it could be dangerous to install extensions that aren't tested with the current version of MediaWiki, right? Especially if they deal with the database. [00:27:28] 03(mod) It's impossible to type Hebrew characters in the search box until some Latin characters were typed - 10https://bugzilla.wikimedia.org/33518 +comment (10brion) [00:28:04] It's not impossible, but it'd be rare to find ones that mess with the core tables [00:28:20] Okay, thanks. [00:29:14] 14(WFM) Chart row redirect - 10https://bugzilla.wikimedia.org/33550 +comment (10Brion Vibber) [00:31:47] ashley: what version of the code is that patch against, Comments-trunk-r106136.tar.gz ? [00:32:14] 03(mod) Switch from iframe to div using iscroll4 (experimental) - 10https://bugzilla.wikimedia.org/33529 +comment (10brion) [00:34:17] Samus_Aran: it should apply cleanly against trunk, because I developed it against trunk :) [00:34:22] (brb in 20-30 minutes) [00:36:20] 03(mod) Android app doesn't allow search when webview overlaps with an image - 10https://bugzilla.wikimedia.org/32319 +comment (10brion) [00:37:04] 03(mod) It's difficult to tap into the search box - 10https://bugzilla.wikimedia.org/32917 +comment (10brion) [00:37:59] ashley: could you post the patch to omploadr.org or pastie.org? the one I got from the comment field is only returning hunk failure messages when I try to patch [00:38:16] sorry, edit box, not comment field [00:40:03] I think the edit form modified the spacing [00:53:47] New code comment: Bawolff; here's the var_dump from purgeThumbList(): \
 \ array(9) { \ [0]=> \ object(SplFileInfo)#137 (2) { \ ; 
[01:05:33] 	 Samus_Ar1n: are you in the right directory (extensions/Comments)? if you're not, that could explain why it fails
[01:06:13] 	 Samus might be afk at the moment.
[01:08:17] 	 New code comment: Krinkle; See [https://docs.google.com/spreadsheet/ccc?key=0ApsGwg5TzvlwdG11YVBWMU9WYnVYbzI3Rm9lbGd6S2c \ google; 
[01:12:21] 	 are other folks seeing "mw.toolbar is undefined" while editing on trunk, or is it just me?
[01:14:44] 	 ashley: I'm in the right folder, it finds the files, but the patch is broken
[01:15:24] 	 wtf...how's that possible? what file fails to patch?
[01:16:17] 	 New code comment: Krinkle; In very old Firefox versions and all versions of Opera, the document ready event is delayed until af; 
[01:16:48] 	 brion: updating trunk now
[01:17:02] 	 lets see
[01:17:12] 	 brion: yep
[01:17:27] 	 i see undefined for mw.toolbar
[01:18:01] 	 ashley: I suggested how it's possible, if the pasted code is being modified, such as whitespace being altered.
[01:18:07] 	 ashley: http://pastie.org/pastes/3134933/text
[01:18:10] 	 ashley: output of the patch
[01:18:13] 	 Uncaught TypeError: Cannot call method 'addButton' of undefined
[01:18:13] 	 Uncaught TypeError: Cannot call method 'wikiScript' of undefined
[01:18:31] 	 mw.toolbar and mw.util are loaded too late
[01:18:38] 	 or rather, the rest too early
[01:19:14] 	 whee
[01:19:24] 	 this is the patch generated by TortoiseSVN's "Create Patch" command, at least when copypasting from the edit view...so there shouldn't be any whitespace changes :-/
[01:19:35] 	 brion: not caused by RL though
[01:19:43] 	 EditPage is missing something I think
[01:19:51] 	 hmm
[01:19:54] 	 ashley: could you tarball the current version you have, and post it to omploadr.org or /dcc send to me?
[01:19:59] 	 Hm.. maybe not
[01:21:05] 	 mediawiki.action.edit.js needs to be loaded
[01:21:31] 	 mediawiki.action.edit is in the bottom queue
[01:21:43] 	 which was already assumed to be async, but it's for real now
[01:22:03] 	 oooh
[01:22:08] 	 brion: mw.toolbar.addButton is right after the bottom queue
[01:22:10] 	 then that in-place