[00:16:02] New code comment: Krinkle; What problem is attempted to be solved here ? \ If a gadget needs styling, there shuld be no FOUC as ; [00:22:55] 03krinkle * 10/trunk/phase3/resources/mediawiki.special/ (2 files): Re-do svn copy from r106516 preserving history [00:24:31] 03krinkle * 10/trunk/phase3/resources/mediawiki.special/mediawiki.special.changeemail.js: [00:24:31] Re-applying change to code from r106516 [00:24:31] * Diff in r106516 didn't show that these changes where made due to new file creation, fixed now. [00:24:31] * Follows-up r108339 [00:26:56] 03(FIXED) Have buttons that are grayed out disabled completely - 10https://bugzilla.wikimedia.org/33113 +comment (10Krinkle) [00:36:11] 03(FIXED) Ablity to get current action (The Right Way) - 10https://bugzilla.wikimedia.org/27930 +comment (10Krinkle) [00:36:56] 03(mod) Wikiversity interwiki not-local => local - 10https://bugzilla.wikimedia.org/25995 +comment (10krinklemail) [00:44:13] 03(NEW) Remove action "historysubmit" from history pages. - 10https://bugzilla.wikimedia.org/33587 minor; MediaWiki: History/Diffs; (krinklemail) [00:44:45] 03(mod) wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a &action parameter - 10https://bugzilla.wikimedia.org/25800 +comment (10krinklemail) [00:53:08] 03krinkle * 10/trunk/phase3/ (RELEASE-NOTES-1.19 includes/actions/HistoryAction.php): [00:53:08] Remove action=history from submit on HistoryAction [00:53:08] * Not needed, and not used. Is internally converted to "view" as much as possible. [00:53:08] * Fixes bug 33587 [00:53:08] * See also https://bugzilla.wikimedia.org/show_bug.cgi?id=25800#c6 [00:53:08] * Other diff links from MediaWiki don't do this either [00:53:31] 03(FIXED) Remove action "historysubmit" from history pages. - 10https://bugzilla.wikimedia.org/33587 +comment (10Krinkle) [00:59:01] hi [01:07:02] New code comment: Siddhartha Ghai; Maybe bug 2013, bug 11325 and r32382 are relevant here?; [01:09:05] Reedy: Hi, you there / [01:09:22] Ya [01:09:53] two questions: I'm looking for a function that will tell me which action is currently being performed. mediaWiki->getAction() is close, except that it'll return random garbage on action=random%20garbage [01:10:20] There is MediaWiki::performAction which eventually goes to unknownaction, which is good, but this doesn't appear to be stored anywhere [01:10:50] (i'll save the other Q for later) [01:11:04] Is there something like that that you know of ? [01:12:57] Not without going and poking around in the code [01:13:07] Not something I've ever needed to bother about [01:13:08] Sorry [01:13:39] Right now mw.config's wgAction property is doing getValue('action', 'view') which is horrible. [01:13:54] body class "action-" was doing a similar thing and eventually reverted [01:13:55] http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/Skin.php?r1=94131&r2=94130&pathrev=94131 [01:14:04] although the above did sneak into 1.18 [01:15:17] Reedy: How do you feel about letting it be stored in MediaWiki class, and using global $mediaWiki getCurrentAction to retrieve it ? I'm trying to find a more appropriate place for it, since it is request/context related. [01:16:32] are git's commands (not repo management - things like fetch) included with most web server software or does it always need to be added after the fact? [01:17:40] don't necesserily need a webserver [01:19:25] yeah - just troubleshooting someone on a shared apache server [01:19:49] 04(REOPENED) Ablity to get current action (The Right Way) - 10https://bugzilla.wikimedia.org/27930 +comment (10Krinkle) [01:20:03] they got git: command not found when doing a fetch - was wondering if it was just not enabled for jailshell or if their host actually needs to install it - which I didn't think was the case…but haven't run a web server in a long time :) [01:20:06] 03(mod) Magic words localization per the viewing project instead of source - 10https://bugzilla.wikimedia.org/33576 +comment (10Siddhartha.Ghai) [01:21:39] varnent: Are we talking about a web server like apache or nginx or a full linux server that serves linux content? [01:21:54] that serves web content* [01:21:59] johnduhart: apache - pretty standard setup from what I can tell [01:22:07] I wish nginx…but… [01:22:20] varnent: How do you have a Jailshell then? [01:22:41] If you have SSH it's not a webserver, apache is a piece of software that runs on a server [01:23:21] johnduhart: well - okay - it's a shared server running Apache - no clue what the core OS is - probably Linux [01:23:28] Yup [01:23:56] johnduhart: not my server - just trying to troubleshoot something - any clue if their admin needs to "install" git or just enable it for jailshell? [01:24:00] Given that it's a server for web hosting they probably won't have git on it, and I'm not too sure that the jailshell would have access to git [01:24:05] trying to figure out what they need to lobby their web host for :) [01:24:15] varnent: Ask to install git and give access probably :) [01:24:27] hmmm..kk [01:24:31] Who's the host? [01:24:43] not sure actually - some local place they're working with [01:25:03] they're getting free hosting - so trying to make it work for their group rather than jump to a better, but paid, solution [01:25:31] fair enough [01:25:51] I'm more familiar with git than svn - can you cheat git and pull when svn is enabled (which it is in this case and working fine for them) [01:25:56] whoops [01:26:01] more familiar with svn than git :) [01:26:47] What do mean? [01:27:00] Like use svn until git is available? [01:27:48] all they really want to do is fetch and pull updates for some web apps - one of the apps is already on git and I'm thinking about when MW goes git - can they use svn commands to somehow work with git? :) [01:28:11] No [01:28:20] probably trying to push a circle through a square peg - lol - but running down list of possible work-arounds for them other than just - you know - download the darn thing and update yourself :) [01:28:23] And when we go git no one can use svn :) [01:28:33] Well, no one wanting to commit to things moved to git [01:28:44] varnent: Is there code on github though? [01:30:28] I think this app is on github (going from a "got any quick ideas?" phone call) - but when MW goes git - (lol - they'll never commit) are they gonna be forced to go git (or just download old fashioned way) to maintain their mw download [01:30:54] You're in luck :) [01:30:54] https://github.com/blog/966-improved-subversion-client-support [01:31:00] GitHub supports svn [01:31:19] excellent! - so what about their future with MW? [01:31:34] that should make him happy - lol - but I haven't told him MW is going git by March yet :) [01:32:08] varnent: I'm not sure how our use of verison control affects them, mind explaining? [01:32:23] 03krinkle * 10/trunk/phase3/includes/Wiki.php: [01:32:24] Implement MediaWiki::getPerformedAction() [01:32:24] * Fixes: [01:32:24] -- Bug 27930 - Ablity to get current action (The Right Way) [01:33:06] maybe I'm just not familiar enough with git to get it (no pun) - but right now they use svn co to download all their MW installations - so if we go git - will they still be able to get future releases and extensions from svn co or will they now have to use git fetch to download things for MW? that make sense? [01:33:17] !r 94131 [01:33:17] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/`e1 [01:33:39] * johnduhart claps for mw-bot [01:33:57] !r 94131 [01:33:58] https://www.mediawiki.org/wiki/Special:Code/MediaWiki/94131 [01:34:04] yeah, I'm there already :) [01:34:04] varnent: No, they'll have to use git [01:34:45] okay - so basically by march they'll either have to give up updating MW extensions w/o manual downloads - or break into the host facility and install git themselves? :) [01:34:58] varnent: Pretty much :) [01:35:04] 03krinkle * 10/trunk/phase3/includes/OutputPage.php: [01:35:04] [mw.config] wgAction shouldn't use direct URL values [01:35:05] * Fixes bug 25800 [01:35:05] * Depends on r108342 [01:35:08] hmmm [01:35:19] 03(FIXED) Ablity to get current action (The Right Way) - 10https://bugzilla.wikimedia.org/27930 +comment (10Krinkle) [01:35:25] by march? [01:35:26] bahaha [01:35:40] lol - well - okay - by whenever we actually go git [01:35:42] 03(mod) Ablity to get current action (The Right Way) - 10https://bugzilla.wikimedia.org/27930 (10Krinkle) [01:36:20] 03(FIXED) wgAction incorrectly asumes 'view' instead of 'historysubmit' on diff-pages without a &action parameter - 10https://bugzilla.wikimedia.org/25800 +comment (10Krinkle) [01:36:21] which got me thinking actually - is it setup enough that I can work on a new extension off git - or is the MW git not ready for extensions yet? (again - pleading ignorance about git) [01:36:47] we don't have a git repo setup for production use yet [01:37:02] and we only have a trunk clone for testing [01:37:09] /trunk/phase3 [01:37:10] even [01:37:12] okay - so svn it is :) [01:37:32] SVN won't be automatically just stopped [01:37:32] New code comment: Krinkle; This class was requested in bug 4438, re-opened.; [01:37:42] Heh, The Right Way™ [01:37:47] Chances are you'll be able to keep using svn for extensions for a while [01:37:48] 03(mod) No CSS hook exists for distinguishing between actions for a given page title - 10https://bugzilla.wikimedia.org/4438 +comment (10krinklemail) [01:37:53] just to make it even more confusing [01:37:57] lol [01:37:58] nice [01:38:12] There might be a nice way to push git branches into svn tags [01:38:14] no idea [01:38:27] maybe I can find some oddball offline/online hybrid solution for them to auto-update the files - lol or maybe the extension manager's completion will beat git [01:38:33] New code comment: Krinkle; Note that this revert didn't make it into REL1_18, the bad way of getting action- class is in 1.18; [01:39:16] Reedy: I wouldn't be surprised to learn that more shared hosts that allow jailshell don't support git - and I now a lot of low-budget nonprofits use that style webhost [01:40:17] !b 25800 [01:40:17] https://bugzilla.wikimedia.org/show_bug.cgi?id=25800 [01:40:23] Reedy: anything we can do to help those folks with transitioning or delaying their need for git command I imagine would be helpful - at least until git gains the same traction with web host companies…but they're a crazy bunch (I say with love) [01:40:42] One would hope they'd just install git stuff [01:40:44] But god knows [01:40:56] 03(mod) wgAction should contain the actually performed action instead of whatever the query value contains - 10https://bugzilla.wikimedia.org/25800 summary (10Krinkle) [01:40:58] I don't see how that is a issue, very few people should in theory be running their MW install directly from a svn clone [01:41:03] Hell, we still don't know how we're going to do production wikipedia on git [01:41:09] p858snake|l, svn switch [01:41:10] vs [01:41:17] wget, untar, replace [01:41:22] I can see the benefits [01:41:25] 03krinkle * 10/trunk/phase3/RELEASE-NOTES-1.19: release notes for r108343 [01:41:32] well whatever the command is [01:41:54] p858snake|l: until we have a true extension manager - most wikis I work with use svn to maintain at least their extensions if not also the main install (at least main install on their test wikis) [01:42:27] anyway tim is keeping a RO mirror of extensions in svn anyway, so you could probably ask him at the same time to do phase3 as well [01:42:43] otherwise keeping on top of the updates for all your extensions is a pain [01:42:47] if we can get a nice way of getting git revs into svn [01:42:53] p858snake|l: ah - brilliant - that's perfect :) [01:42:57] 04(REOPENED) Add CSS hook for current WikiPage action - 10https://bugzilla.wikimedia.org/4438 summary (10Krinkle) [01:43:34] although i don't know if Tim-away's mirror will be public (because it will be for ED, but you can always ask him to do it when the time comes) [01:43:39] * johnduhart hits the toolserver [01:43:40] yeah - a RO mirror - even if updated regularly rather than instantly (daily, weekly, whatever) would suit this crowd - they don't need commit or anything near that [01:43:54] No reason to make it public [01:43:56] *private [01:49:13] 03krinkle * 10/trunk/phase3/ (RELEASE-NOTES-1.19 includes/OutputPage.php): (log message trimmed) [01:49:14] [Skin] Add CSS hook for action ("action-.." class on body) [01:49:14] * Fixes bug 4438 [01:49:14] * Depends on r108342. See also r108343 which did a similar thing for mw.config wgAction [01:49:14] Previously attempted in r91871, which was reverted in r94131. [01:49:14] Added in OutputPage instead of Skin::getPageClasses, as this is not directly [01:49:15] page nor skin related. It also ensures independency from skins, this CSS class [01:49:42] 03(FIXED) Add CSS hook for current WikiPage action - 10https://bugzilla.wikimedia.org/4438 +comment (10Krinkle) [01:50:23] * varnent very happy the Facebook extension is working again [01:50:48] New code comment: Krinkle; Tagging for backport to 1.18. '''Only merge if r94131 is also merged!''', as that revision removed t; [01:51:33] New code comment: Krinkle; '''Don't merge without merging r108345 as well, other wise a regression occurs'''.; [01:52:49] the git repo for extensions is only 240MB [01:52:53] nbd. [01:53:43] 'the' [01:53:55] ...last I checked we're going to separate extensions into separate repos [01:53:55] yes, the [01:53:58] I know that [01:56:01] 03(mod) Upgrade EtherPad to 1.1.17 - 10https://bugzilla.wikimedia.org/29822 +comment (10krinklemail) [01:56:38] 03(mod) mw.Uri throws error for protocol-relative urls - 10https://bugzilla.wikimedia.org/30712 +comment (10krinklemail) [01:57:28] 03(mod) Upgrade EtherPad to 1.1.17 - 10https://bugzilla.wikimedia.org/29822 +comment (10p858snake) [01:58:04] 03(mod) Upgrade EtherPad to 1.1.17 - 10https://bugzilla.wikimedia.org/29822 +comment (10sam) [02:10:56] Krinkle: around? [02:11:13] Yes [02:11:15] 03(FIXED) Color self-inconsistency causes usability problems - 10https://bugzilla.wikimedia.org/25224 +comment (10Krinkle) [02:13:21] 03(mod) Change logo to gothic wikipedia logo - 10https://bugzilla.wikimedia.org/33584 (10p858snake) [02:15:28] 03(mod) Double layering ForeignAPIRepo's doesn't retrieve descriptions properly - 10https://bugzilla.wikimedia.org/27111 minor->normal; +comment (10Krinkle) [02:16:30] !b 20365 [02:16:30] https://bugzilla.wikimedia.org/show_bug.cgi?id=20365 [02:16:36] liangent: Anything in particular ? [02:17:09] see my new comment [02:17:14] where's codurr? [02:17:18] :) [02:17:28] that's http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100497#c29136 [02:21:19] codurr where were you [02:21:36] Drinking by the smell. [02:24:47] New code comment: Krinkle; * Styling core elements (most likely a CSS-only gadget): \ This will be fixed by RL2, which allows a g; [02:25:04] liangent: granted some arguments are edge cases or theoretical, just thinking out load :) [02:27:43] Krinkle: what about wrapping them in