[00:17:10] 03jamesur * 10/trunk/extensions/DonationInterface/gateway_forms/includes/enets_logo2.jpg: add new enets logo [00:17:35] 03(mod) please include autopatrolled right inside patroller for he.wiki - 10https://bugzilla.wikimedia.org/33592 normal->15enhancement (10Reedy) [00:17:39] 03(mod) Change project namespace for lb.wiktionary - 10https://bugzilla.wikimedia.org/33662 normal->15enhancement (10Reedy) [00:19:26] 03reedy * 10/trunk/extensions/InteractiveBlockMessage/InteractiveBlockMessage.php: The "InteractiveBlockMessage" class doesn't exist, don't try and load it [00:21:37] I should probably do some shell requests [00:22:44] 03mrbluesky * 10/USERINFO/mrbluesky: Adding USERINFO [00:26:41] brion: r108274 [00:26:50] https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/context/RequestContext.php?&pathrev=108274&r1=108273&r2=108274 [00:27:00] * AaronSchulz doesn't like the possible exception throwing there [00:27:55] 03jamesur * 10/trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rtbt/rtbt-enets.html: tweak enets forms to be closer to others [00:28:38] I wonder why codurr keeps dying. [00:28:58] Is TS still having issues? [00:29:27] nfi [00:34:27] 03(FIXED) Please lock *.labs.wikimedia.org - 10https://bugzilla.wikimedia.org/33644 +comment (10Reedy) [00:35:05] 03(NEW) "Save page" enable/disable state doesn't update when navigating to another page via search - 10https://bugzilla.wikimedia.org/33694 normal; Wikimedia Mobile: android; (brion) [00:38:14] through this query https://en.wikipedia.org/w/api.php?format=xml&action=query&titles=january_11&prop=revisions&rvprop=content i have at the beginnig of the xml 3 different templates..there's a way to load one of them? i need the {{Day}} [00:38:23] 03mrbluesky * 10/USERINFO/mrbluesky: fix eol-style [00:38:25] Alright [00:38:48] I made a big update to the Wiki Family page, fully documented with no parts skipped. [00:39:03] I basically copied my setup [00:41:16] New code comment: MrBlueSky; Hmm, I thought I did that. Apparently not. Sorry!; [00:41:36] mBlueSky, nearly everyone screws that up ;) [00:41:44] Even though you might have set them up [00:41:49] You won't have for extensionless files [00:41:53] so needs doing manually [00:42:19] 03(mod) Cleanup old "pagelinks" records which reference deleted pages in the Portuguese Wiktionary - 10https://bugzilla.wikimedia.org/33540 +comment (10sam) [00:43:02] Well, I read it http://www.mediawiki.org/wiki/USERINFO, but still forgot :) [00:43:09] *at [00:49:06] Eh, doubt a reviewer will see this. But if you see a problem with the stuff I added to the Wiki Family page, leave a message on my talkpage [00:49:38] 03(mod) Enable e-mail notifications for watchlist (EnotifWatchlist) on all small wikis - 10https://bugzilla.wikimedia.org/28026 +comment (10mail) [00:50:52] 03(mod) Enable e-mail notifications for watchlist (EnotifWatchlist) on all small wikis - 10https://bugzilla.wikimedia.org/28026 +comment (10sam) [00:52:08] 03(mod) Set $wgPasswordSenderName to $wgSitename to clarify notification emails - 10https://bugzilla.wikimedia.org/32770 +comment (10sam) [00:52:19] 03(mod) Make $wgPasswordSenderName localizable - 10https://bugzilla.wikimedia.org/33601 (10Reedy) [00:52:21] 03(mod) Set $wgPasswordSenderName to $wgSitename to clarify notification emails - 10https://bugzilla.wikimedia.org/32770 (10Reedy) [00:57:14] ![[ Manual:Database_layout [00:57:15] https://www.mediawiki.org/wiki/Manual%3ADatabase_layout [00:57:47] Krinkle, when I properly looked at it, it's mostly up to date [00:58:28] * Reedy eyes werdna [00:59:20] http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki&path=%2Ftrunk%2Fphase3&status=new&author=ialex [00:59:25] * AaronSchulz stands on a pile of commits [00:59:58] * p858snake|l gets teh gladitor pole things and proceeds to knock AaronSchulz off the pile [01:00:33] 349 new [01:00:40] p858snake|l, he's stood on the floor [01:01:00] Floor still works for this :p [01:02:27] 03(FIXED) Email notifications for eswikibooks - 10https://bugzilla.wikimedia.org/33468 +comment (10Reedy) [01:04:45] 03(mod) Change project namespace for lb.wiktionary - 10https://bugzilla.wikimedia.org/33662 +comment (10sam) [01:07:29] 14(WFM) please include autopatrolled right inside patroller for he.wiki - 10https://bugzilla.wikimedia.org/33592 +comment (10Reedy) [01:09:18] 03(mod) Not found installed eAccelerator - 10https://bugzilla.wikimedia.org/29747 (10Joerg) [01:10:23] 03(FIXED) ArticleFeedback settings on Chinese wikipedia - 10https://bugzilla.wikimedia.org/33556 +comment (10Reedy) [01:12:39] 03(mod) SSL client certificate authentication - 10https://bugzilla.wikimedia.org/3729 +comment (10Sumana Harihareswara) [01:13:09] 14(INVALID) Fix outdated interface text in installer - 10https://bugzilla.wikimedia.org/33693 +comment (10Bawolff) [01:17:45] ahhh [01:17:51] Shell request open for 9 days [01:17:55] requesting priority [01:18:00] and they haven't said how they want it doing [01:18:01] wheee [01:19:38] 03(mod) Enable Rollback group on id.wiki - 10https://bugzilla.wikimedia.org/33508 +comment (10sam) [01:20:00] 03(mod) Fix wrong interface text in installer - 10https://bugzilla.wikimedia.org/33693 (10Joerg) [01:21:44] ok, the commit access queue is now empty :-) so we have responded to every commit access request that's ever come in [01:21:57] hey guys, I am trying to predict the performance of a mediawiki installation [01:22:26] would it be fine if text is mostly fetched from disk? and indexes are all in memory? [01:22:46] I am trying to understand the impact of accessing text from disk, rather than memory [01:22:52] it's slower [01:23:12] my guess would be it shouldn't matter that much, because once you know which text to retrieve it should be relatively fast [01:23:25] It can vary on many things [01:23:30] Predicting performance is just guessing random numbers [01:23:33] Try it and see [01:23:48] 03(mod) Fix outdated interface text in installer - 10https://bugzilla.wikimedia.org/33693 summary (10Joerg) [01:24:06] you are right, but I am trying to make some reasonable judgements before trying it out [01:24:41] The faster machine, more ram (faster ram), faster disk, more caching, the faster it'll work [01:24:53] chances are you won't have enough memory for your whole db to be in memory [01:25:17] New code comment: Aaron Schulz; apc.enable_cli = 1 apparently. So maybe all is not lost.; [01:25:52] I did make some measurements, and based on those if the whole data set doesn't fit into memory, it is fine, meaning some text can be left out [01:26:21] Yeah [01:26:31] text in a LRU esk pattern is probably enough (roughly) [01:26:42] pubsez: good luck with your benchmarking, profiling, & optimization [01:26:50] however, indexes are extremely important, and I wonder how can I calculate the size of those indexes, since the data set I will load will be even bigger than I measured [01:27:01] sumanah: thanks :) [01:27:44] pubsez: if you're dealing with a huuuuuuge dataset, you may want to share your findings with the research folks [01:27:46] !research [01:27:46] https://meta.wikimedia.org/wiki/Research [01:28:42] sure, absolutely [01:32:21] 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10sam) [01:35:37] Reedy: boredom: boredom [01:35:42] https://www.mediawiki.org/wiki/Manual:Database_layout * [01:38:22] heh [01:41:02] New code comment: Aaron Schulz; The type is 'rights' not 'right.; [01:41:53] 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10sam) [01:45:37] 03(mod) Fix outdated interface text in installer - 10https://bugzilla.wikimedia.org/33693 +comment (10mueller062001-reg) [01:47:29] 03(FIXED) Enable "rollback" function for "editor" group (in ka.wikipedia org) - 10https://bugzilla.wikimedia.org/33469 +comment (10Reedy) [01:48:10] Bah [01:48:19] Why don't we have the api for setting userprefs [01:49:23] I can't believe it'd be that difficult to do the basic one... [01:52:18] Reedy: It was requested once but delayed/cancelled for security [01:52:53] There's actually a more recent bug saying that one can do a simple POST to Special:Preferences from any wiki page with the editToken change the preferences [01:53:14] Sure [01:53:19] But that's still icky [01:53:26] werdna had a patch and lost it [01:53:35] No, the bug is that that shouldn't be possible, I;m not recommending you use it [01:53:58] ohhh [01:54:19] I've been trying to think of a way to make it secure, can't think of any. [01:54:38] Something that makes it impossible for gadgets to change, but possible for users themselves. [01:54:46] captcha! [01:54:47] ;) [01:54:50] yeah.. [01:55:19] someone suggested a dedicated token that is only outputted by Special:Preferences itself [01:55:35] but one can simply do $.get(' … ', function(rawhtmlstring){ .. }); [01:55:41] and get it anyway [01:56:46] if it's inevitable, try to enjoy it. [01:57:17] How do you enjoy death? [01:57:20] Or taxes? [01:57:33] $.get('//example.org/wiki/Special:Preferences', function(data){ $(data).find('wpPrefToken').val() }) [01:57:41] 03(NEW) Fix wrong interface text in installer - 10https://bugzilla.wikimedia.org/33693 normal; MediaWiki: Installation; (mueller062001-reg) [02:02:03] Even if you'd create a special module for it (a module partially generated by PHP, like startUp) and embed the token there in a local javascript scope (where the gadget can't get at), the module needs to verify that it's on the preference page. The script is safe when it comes from a different domain, however checking the page is almost impossible. [02:02:07] didn't' think it was that hard [02:02:17] wgTitle/wgPageName can be manipulated easily [02:02:45] window.location is harder, but with html5 history.pushState you can put anything in there except for the hostname, without a refresh [02:08:35] Amgine: are you recovered from your illness? [02:08:47] Mostly, yes. [02:08:59] Glad to hear it! [02:09:08] Have I missed IRC conversations? [02:09:45] Amgine: not that I know of [02:09:54] Amgine: nothing in the past 2 or 3 days [02:10:19] At this rate we'll still be waiting on discussions at the conference. [02:10:33] Amgine: would that be so bad? [02:11:26] Amgine: all the students have the information they need to start getting familiar with the platform now [02:11:43] Amgine: general rampup time is good too [02:12:08] No, but it means we will be behind the curve for production. And it means one of the primary goals (working distributed) is not yet being met. [02:13:57] Amgine: http://botwiki.sno.cc/wiki/Pywikipediabot/wishlist might be worth a look [02:14:50] More options... but yes. One of my concerns is Shealen is geographically near me; I may give too much weight/support due to proximity. [02:15:34] Amgine: As long as you're supporting everyone at least adequately, there's no problem in giving extra support to the one who's near you. [02:16:01] I like that transwiki importer... [02:19:03] Pfft [02:19:20] Preferences::getPreferences() needs a users and a context? :/ [02:20:27] [02:21:39] Have to find a way to pull that stuff out without creating a load of duplication... [02:23:51] Reedy: Writing an API module? [02:24:18] Yeah [02:24:23] 2am distraction [02:24:28] "This can't be that hard..." [02:24:30] Reedy: You know the API has context now, right? [02:24:33] Yes [02:24:38] That's what I'm complaining about [02:24:46] oh? [02:24:50] Well, sorta [02:25:00] To get a list of preferences, I shouldn't have to give a valid user object, and a context [02:25:21] ohhh [02:25:49] So it's gonna end up being a lot of refactoring [02:26:17] when all I want is the array key, if that itself doesn't have a type key set with a value of info [02:28:05] 03reedy * 10/trunk/phase3/includes/Preferences.php: [02:28:06] Documentation [02:28:06] As we're using stuff from ContextSource everwhere, limiting stuff to a type hint of IContextSource isn't much use [02:28:33] Now is a time that would be nice having git [02:28:43] else I just stash a patch in my w/c or stick it on the bug [02:29:09] johnduhart, ^ a lot less yellow in PhpStorm now ;) [02:30:15] Reedy: I don't think that was a good idea. [02:30:55] Why? [02:31:13] It requires an object with msg(), which isn't necesserily an IContextSource [02:31:23] so passing something that isn't ContextSource or lower isn't gonna work [02:31:23] 03reedy * 10/trunk/phase3/includes/ (HTMLForm.php Preferences.php filerepo/file/FSFile.php): [02:31:23] A couple more for r108785 [02:31:23] More doucmentations [02:31:28] 03(mod) UploadWizard doesn't highlight errors in "more info" - 10https://bugzilla.wikimedia.org/32408 +comment (10Saibo) [02:31:35] Reedy: IContextSource is an interface, classes can implement that iterface without extending ContextSource [02:31:42] tomaszf: gicode: preilly: thedj: I'm developing a page with ideas of projects that SF hackathon participants can work with you on [02:31:46] Since there's situtations where you cannot extend CS [02:31:50] Sure [02:31:56] But they still won't have msg [02:32:00] 03(mod) UploadWizard doesn't highlight errors in "more info" - 10https://bugzilla.wikimedia.org/32408 +comment (10saibotrash) [02:32:01] Move msg into IContextSource then [02:32:12] sumanah: okay, great! [02:32:42] preilly: https://www.mediawiki.org/wiki/San_Francisco_Hackathon_January_2012/Teams#.28Your_team.29 is it as it is now [02:33:03] sumanah: nice [02:33:04] Reedy: Sure, revert your last 2 commits then. [02:33:39] tomaszf: preilly: are there any ideas I can just move wholesale from the similar Mumbai page? [02:34:06] sumanah: I'm not sure [02:34:35] gicode: thedj: gwicke__ I welcome your ideas -- that page is editable [02:35:51] johnduhart, seems even more sane when both RequestContext and ContextSource implement it [02:36:42] Reedy: Your change or adding msg to the interface? [02:37:04] to the interface [02:37:07] ^ [02:37:11] * Reedy kicks codurr [02:37:40] Puck you. [02:37:40] 03reedy * 10/trunk/phase3/includes/context/IContextSource.php: Push msg from ContextSource/RequestContext into IContextSource [02:38:40] I wonder what other common functions there are [02:38:43] 03(mod) Tutorial language should use the usual language fallback mechanisms - 10https://bugzilla.wikimedia.org/26342 15enhancement->normal; +comment (10Saibo) [02:40:21] 03reedy * 10/trunk/phase3/includes/Preferences.php: Partial revert ContextSource changes from r108785, r108786 [02:44:24] 03(mod) Allow changing preferences via API - 10https://bugzilla.wikimedia.org/18195 (10Reedy) [02:44:26] 03(NEW) Preferences doesn't have a method to get ALL preferences, regardless of user/context - 10https://bugzilla.wikimedia.org/33695 enhancement; MediaWiki: User preferences; (sam) [02:44:51] * varnent pondering if codurr has developed ai.. [02:44:51] Puck you. [02:44:54] 03(mod) Preferences doesn't have a method to get ALL preferences, regardless of user/context - 10https://bugzilla.wikimedia.org/33695 (10Reedy) [02:45:54] MMMM VIEWS https://github.com/johnduhart/mediawiki/commits/views [02:46:43] * codurr pets varnent_. [02:47:19] oh dear... [02:47:46] I suspect 3am being in sight means it's probably bedtime [02:48:38] * varnent for the first time ever - wishing he was in the same state as Arnold Schwarzenegger.. [02:48:54] night, Reedy [02:54:00] 03kaldari * 10/trunk/extensions/CentralNotice/CentralNotice.db.php: adding embargoed countries back [02:59:07] K4-713: https://www.mediawiki.org/wiki/San_Francisco_Hackathon_January_2012/Teams in case you have an idea around gadgets, mobile, or the web API that teams might want to hack on [02:59:17] pgehres: ^^^ for the hackathon next weekend [02:59:46] sumanah: thanks [02:59:59] sumanah: I think we had some ideas, yeah. :) [03:00:50] Get the fun and games of knowing I might have to get up in 4-5 hours.... [03:00:52] Night all [03:01:00] * Reedy wonders how AaronSchulz is at AaronSchulz at the same time... [03:01:33] is at Aaron|home [03:02:18] is there a remote 'away' command, like 'ghost' works? ;) [03:02:31] heh [03:02:32] nope, away is client based [03:12:47] 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10shijualex) [03:14:12] hey pgehres - in https://www.mediawiki.org/wiki/San_Francisco_Hackathon_January_2012/Teams#Central_Notice_API you should really link to resources. like the open bug & any specifications you have [03:16:29] sumanah: will do, was just trying to get something out there. believe it or not, still working :-/ [03:16:41] pgehres: sure, got it. So am I (and I'm in NYC) [03:16:46] and that is a terrible emoticon in Colloquy [03:16:48] *smile* [03:17:06] pgehres: I linked to the bz bug [03:17:14] thanks. [03:17:16] 03(mod) Tutorial language should use the usual language fallback mechanisms - 10https://bugzilla.wikimedia.org/26342 +comment (10saibotrash) [03:17:22] pgehres: since these are mostly newbies who have never worked with MediaWiki before, I predict that no one will want to build this API [03:17:34] pgehres: or at least that those who are interested in it will be busy teaching newbies [03:17:43] yeah, believe it or not, those of us planning on doing it have no API experience [03:17:50] so we will be learning too [03:17:52] :-) [03:18:00] pgehres: hmmmm [03:18:12] but we do have a fair bit of base knowledge [03:18:41] pgehres: if you show up next weekend, the aim is to teach newbies instead of just sitting & hacking with your colleagues on your own project, so people like me may come by and break you up and send you to teach newbies [03:18:42] we are also happy to help teach newbs [03:19:20] yup, we aren't set in stone about doing this next weekend, its on our work todo list as well if it comes to that [03:19:32] ok! just, you know, fair warning :) [03:19:51] sure, fair warning to you, some of us have very little MW experience outside of DonationInterface [03:20:19] and we have been told that some of our code is "interesting" [03:20:56] pgehres: hee! so you will learn as well [03:21:01] yup [03:21:12] pgehres: Saturday morning will be the mobile, web API, and Gadgets tutorials [03:21:31] and i know relatively little about all of those :-) [03:22:09] then there you go! it'll be learningtime for us all [03:22:46] exactly, this will be my first hack-a-thon, so should be fun [03:23:55] oh really? [03:27:17] yeah, i am not in engineering (I am a dev) and have only been with WMF since August [03:30:10] anyway, time to leave the office [03:30:13] thanks sumanah [03:30:25] night pgehres! [03:30:37] rmoen: I mentioned your gadget: https://www.mediawiki.org/wiki/San_Francisco_Hackathon_January_2012/Teams#Keep_track_of_Bugzilla_bugs [03:35:04] 03yaron * 10/trunk/extensions/ApprovedRevs/ApprovedRevs.php: Follow-up to r108577 - fixed name of magic file [03:50:31] 04(REOPENED) Enable input method fails on English interface on a English language wiki - 10https://bugzilla.wikimedia.org/33633 +comment (10Srikanth Logic) [03:57:22] 03(mod) Enable input method fails on English interface on a English language wiki - 10https://bugzilla.wikimedia.org/33633 +comment (10srik.lak) [04:32:15] 03(mod) Browser error message received when accessing namespace pages that don't yet exist - 10https://bugzilla.wikimedia.org/33275 +comment (10insane079) [04:32:35] 03aaron * 10/trunk/phase3/includes/filerepo/backend/ (FSFileBackend.php FileBackend.php): [04:32:35] * Distinguish "does not exist" from failure in FSFileBackend::doGetFileStat(). [04:32:35] * Added clearstatcache() to doConcatenate() to make it safe for callers to stat the file. [04:32:35] * A few minor comment tweaks. [04:37:12] 03(mod) Browser error message received when accessing namespace pages that don't yet exist - 10https://bugzilla.wikimedia.org/33275 +comment (10insane079) [04:48:47] New code comment: Aaron Schulz; What's the point of '_idx'?; [04:58:17] New code comment: ^demon; I did this before, but Tim reverted me because eval.php should be run in the global context.; [05:24:32] New code comment: Skizzerz; possible workaround is to loop through $GLOBALS and global each of them, which will emulate global c; [06:54:09] HI [07:10:50] 03(mod) Page moves into mainspace should appear on Special:Newpages for patrol - 10https://bugzilla.wikimedia.org/12363 +comment (10Derrick Coetzee) [07:19:09] I'm having an odd occurence with my new mediawiki installation. When I click one of my links after not being active on the site for a while it will pause for a bit and download a file "index.gz", once it finishes it will start working as normal. any clue what this could be? [07:35:26] 03(NEW) Warning: ldap_start_tls(): Unable to start TLS: Can't contact LDAP server in LdapAuthentication.php on line 577 - 10https://bugzilla.wikimedia.org/33696 normal; MediaWiki extensions: LdapAuthentication; (i) [07:54:43] 03(mod) Enable input methods on all user languages - 10https://bugzilla.wikimedia.org/33633 summary; +comment (10Siebrand) [08:24:42] 03(NEW) i18n issues with ArticleFeedbackv5 - 10https://bugzilla.wikimedia.org/33697 normal; MediaWiki extensions: ArticleFeedbackv5; (s.mazeland) [08:24:48] 03(mod) i18n issues with ArticleFeedbackv5 - 10https://bugzilla.wikimedia.org/33697 (10Siebrand) [08:32:47] New code comment: Santhosh.thottingal; Forgot to add help.png?; [08:35:29] 03nikerabbit * 10/trunk/extensions/Translate/utils/TranslationHelpers.php: Don't try to show diff of definition if translation doesn't exist. This together with bogus entries in revtag table showd bogus definition diff texts. [08:37:02] New code comment: Nikerabbit; Yes.; [08:37:24] 03nikerabbit * 10/trunk/extensions/Translate/resources/images/ (. help.png): Add image ping r108719 [08:38:47] New code comment: Nikerabbit; Yes it should indeed: \ PHP Fatal error: Call to a member function getPerformedAction() on a non-ob; [08:39:47] 03(mod) Enable Rollback group on id.wiki - 10https://bugzilla.wikimedia.org/33508 +comment (10Sandjaja Kosasih) [08:40:32] New code comment: Santhosh.thottingal; That makes two image directories - one under the extension root and another under resources folder.; [08:41:38] 03nikerabbit * 10/trunk/phase3/includes/specials/SpecialRecentchanges.php: Fix broken indentation [08:42:06] 03(mod) can not get a list of article contributors when using + a SQLite database. - 10https://bugzilla.wikimedia.org/33686 +comment (10richard.kreckel) [08:46:11] 03(mod) Make invalid type parameter in ApiFeedLQTThreads fail more gracefully - 10https://bugzilla.wikimedia.org/22510 minor->normal; +comment (10Niklas Laxström) [08:49:32] New code comment: Nikerabbit; Reproduce-able notices with urls like: http://translatewiki.net/w/i.php?target=1%29%20declare%20%40q; [08:53:05] 03(mod) Enable Rollback group on id.wiki - 10https://bugzilla.wikimedia.org/33508 +comment (10bknliem) [08:53:23] 03laner * 10/trunk/extensions/OpenStackManager/ (OpenStackManager.i18n.php special/SpecialNovaInstance.php): Remove unneeded extra section. [08:55:32] 03raymond * 10/branches/REL1_18/extensions/FCKeditor/ (5 files): MFT r93422: Un-break FCKEditor [08:56:09] 03laner * 10/trunk/extensions/OpenStackManager/OpenStackNovaController.php: Fix a nasty infinite loop. [08:57:02] hi [08:57:16] New code comment: Nikerabbit; Yup. The other images could be moved here.; [08:58:05] anybody encountered the problem, that mediawiki 1.18 seems to save the local ip Adress when installed locally ? [09:04:31] anybody ? [09:05:03] 03(mod) categorylink being dependant on {{REVISIONYEAR}} and friends doesn't work properly, sometimes. - 10https://bugzilla.wikimedia.org/33632 (10jeblad) [09:11:46] 03kaldari * 10/trunk/extensions/Narayam/resources/ext.narayam.core.css: a little bit of space between the arrow and the text [09:14:05] 03laner * 10/trunk/extensions/OpenStackManager/OpenStackNovaController.php: Actually fix the loop problem this time. [09:15:01] 03aaron * 10/trunk/phase3/includes/specials/SpecialRecentchanges.php: r88633: lazy-load 'customFilters' field in SpecialRecentChanges. Almost every function is public here so there no control of the order stuff happens. [09:15:10] Ryan_Lane: why are we still up? [09:15:20] well, I had to fix labs [09:15:28] and am still fixing it [09:15:43] I moved a bunch of services kind of late in the day [09:15:49] this is what I get ;) [09:15:51] I know better [09:16:09] do you? [09:16:32] apparently not [09:17:42] 03(NEW) local ip used for external querys - 10https://bugzilla.wikimedia.org/33698 normal; MediaWiki: Installation; (bugzilla23) [09:17:59] 03(mod) local ip used for external querys - 10https://bugzilla.wikimedia.org/33698 (10bugzilla23) [09:18:31] 03maxsem * 10/trunk/extensions/GeoData/ (CoordinatesParserFunction.php tests/TagTest.php): Handle type:city(population) [09:19:58] 03laner * 10/trunk/extensions/OpenStackManager/OpenStackManager.i18n.php: Ugh. Removed the wrong message. [09:35:36] 03raymond * 10/trunk/extensions/Interwiki/Interwiki.php: [09:35:37] Fix name and URL in extension credits. [09:35:37] Could someone with more knowledge about the resource loader please check if $wgResourceModules['SpecialInterwiki'] could be changed to $wgResourceModules['Interwiki']? Thanks. [09:37:48] 03(mod) "images" directory to be renamed or migrated to "files" - 10https://bugzilla.wikimedia.org/33569 +comment (10Antoine "hashar" Musso) [09:44:29] 03(mod) Create {{SPACEUSER}} to improve detection of page owner in User spaces, also usable in interface messages - 10https://bugzilla.wikimedia.org/32703 +comment (10Antoine "hashar" Musso) [09:51:03] 03(NEW) directionality of the offline error page is not set in RTL - 10https://bugzilla.wikimedia.org/33699 normal; Wikimedia Mobile: android; (amir.aharoni) [09:51:09] 03(mod) RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [09:54:05] 03(mod) Change project namespace for lb.wiktionary - 10https://bugzilla.wikimedia.org/33662 +comment (10hercule.wikipedia) [09:59:59] 03(mod) Add private prefixes for CSS3 properties automatically in CSS processing - 10https://bugzilla.wikimedia.org/27933 +comment (10Antoine "hashar" Musso) [10:10:48] 03(NEW) Text gets garbled/invisible when English and Devanagari used side by side. - 10https://bugzilla.wikimedia.org/33700 major; MediaWiki extensions: WebFonts; (hemantbugzilla) [10:11:56] 03(mod) Some tables lack unique or primary keys, may allow confusing duplicate data - 10https://bugzilla.wikimedia.org/15441 +comment (10wikimedia.org) [10:19:41] 03(mod) Review and deploy VipsScaler extension - 10https://bugzilla.wikimedia.org/28135 +comment (10Rainer@Rillke.eu) [10:20:39] 03(mod) Some tables lack unique or primary keys, may allow confusing duplicate data - 10https://bugzilla.wikimedia.org/15441 +comment (10wikimedia.org) [10:22:42] 03(NEW) After retrying a failed upload preview shows up multiple times - 10https://bugzilla.wikimedia.org/33701 normal; MediaWiki extensions: UploadWizard; (listenleser) [10:30:47] New code comment: Nikerabbit; Confirmed fixed.; [10:42:59] 03(mod) Virus emails reaching otrs queues - 10https://bugzilla.wikimedia.org/17301 +ops; +comment (10p858snake) [10:44:41] 03(mod) Use language code 'zh' in multilingual "Wikimedia Error" page - 10https://bugzilla.wikimedia.org/24161 +easy (10p858snake) [10:45:22] 03(mod) This is a test, don't be alarmed - 10https://bugzilla.wikimedia.org/31789 (10p858snake) [10:47:55] and there is another quirk in Bz [10:48:49] 03(mod) Text gets garbled/invisible when English and Devanagari used side by side. - 10https://bugzilla.wikimedia.org/33700 +comment (10Santhosh Thottingal) [10:49:11] 03(NEW) SF svn rev 108803 - adding multiple instance templates broken - 10https://bugzilla.wikimedia.org/33702 normal; MediaWiki extensions: SemanticForms; (mitchell_neill) [10:49:27] 03(mod) Mobile RTL Wikipedias' main pages are displayed as LTR - 10https://bugzilla.wikimedia.org/27363 +comment (10amir.aharoni) [10:55:49] 03(mod) Page moves into mainspace should appear on Special:Newpages for patrol - 10https://bugzilla.wikimedia.org/12363 +comment (10p858snake) [11:04:16] New code comment: Nikerabbit; Commit says cleanup, but to me it looks like this change behavior when only two forms are provied.; [11:05:50] 03(mod) Create {{SPACEUSER}} to improve detection of page owner in User spaces, also usable in interface messages - 10https://bugzilla.wikimedia.org/32703 +comment (10p858snake) [11:07:32] 03(mod) local ip used for external querys - 10https://bugzilla.wikimedia.org/33698 (10bugzilla23) [11:21:00] 03(mod) [SF] Special:RunQuery error takes down pages using it - 10https://bugzilla.wikimedia.org/33424 (10contrafibularity) [11:23:32] New code comment: Hashar; Where / how to reproduce etc? :-); [11:24:32] New code comment: Nikerabbit; Some API calls.; [11:24:41] 03(VERIFIED) can not get a list of article contributors when using + a SQLite database. - 10https://bugzilla.wikimedia.org/33686 (10Antoine "hashar" Musso) [11:26:17] New code comment: Nikerabbit; http://translatewiki.net/ w/api.php?feedformat=atom&type=%27%29%20declare%20%40q%20varchar%288000%29; [11:29:02] New code comment: Nikerabbit; Discussed on Skype about few minor things: \ * The target of the link in Special:Translate \ * The link ; [11:45:31] New code comment: Santhosh.thottingal; Suppose "one" and "few" are the only given forms. \ if count =1 we get "one". if ( $count % 10 == 1 ; [11:48:32] New code comment: Nikerabbit; How about {{PLURAL:21|first|second}}? It looks like to me that it previous returned; [11:58:25] 03(mod) Page moves into mainspace should appear on Special:Newpages for patrol - 10https://bugzilla.wikimedia.org/12363 +comment (10paolobenve) [12:12:17] New code comment: Santhosh.thottingal; ok, you are correct. But I think, out of ["one", "few", "other" ] 21 becoming "one" or "few" depe; [12:36:40] 03(NEW) remove black border-bottom-color for abbr - 10https://bugzilla.wikimedia.org/33703 normal; MediaWiki: User interface; (fomafix) [12:45:54] 03(mod) E-mail notifications (enotifs) are not sent in the recipient's user interface language - 10https://bugzilla.wikimedia.org/2592 +comment (10s.mazeland) [12:47:27] 03(mod) remove black border-bottom-color for abbr - 10https://bugzilla.wikimedia.org/33703 +design +need-review +patch (10p858snake) [12:55:47] New code comment: Nikerabbit; We should probably get in touch with the lt translators to sort it out. I seem to recall that Russia; [12:55:48] 03(mod) New edit emails should offer a single-diff link - 10https://bugzilla.wikimedia.org/32210 +comment (10Siebrand) [13:00:53] 03(NEW) the nearby function doesn't work in some locales - 10https://bugzilla.wikimedia.org/33704 normal; Wikimedia Mobile: android; (amir.aharoni) [13:02:00] hi siebrand -- got a second to talk about the upcoming Pune hackathon? [13:29:32] New code comment: IAlex; Fixed in r108806.; [13:32:22] 03(mod) Provide additional links on Special:Listusers - 10https://bugzilla.wikimedia.org/12021 +easy; +comment (10Antoine "hashar" Musso) [13:42:06] 03(mod) Some tables lack unique or primary keys, may allow confusing duplicate data - 10https://bugzilla.wikimedia.org/15441 +comment (10mueller062001-reg) [13:43:53] 03(FIXED) bar when creating a category - 10https://bugzilla.wikimedia.org/15837 +comment (10Antoine "hashar" Musso) [13:45:11] <wikibugs> 03(mod) Provide a way to invoke the Parser from within a PHPUnit test - 10https://bugzilla.wikimedia.org/15966 (10Antoine "hashar" Musso) [13:53:27] <wikibugs> 14(WFM) pre formatted text is mal-aligned - 10https://bugzilla.wikimedia.org/16333 (10Antoine "hashar" Musso) [14:05:17] <wikibugs> 03(mod) Provide additional links on Special:Listusers - 10https://bugzilla.wikimedia.org/12021 +comment (10p858snake) [14:06:16] <codurr> 03santhosh * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108804> 10/trunk/extensions/Translate/ (6 files in 3 dirs): [14:06:16] <codurr> Add help links for special pages of Translate. [14:06:16] <codurr> CSS cleanup. [14:08:29] <wikibugs> 03(mod) "Create a book" and "Download as PDF" don't wrap Chinese or Japanese lines - 10https://bugzilla.wikimedia.org/33430 +comment (10volker.haas) [14:21:01] <wikibugs> 03(NEW) Sorting by property drops results where that property value is not set - 10https://bugzilla.wikimedia.org/33705 critical; MediaWiki extensions: Semantic MediaWiki; (niklas.laxstrom) [14:22:48] <wikibugs> 03(mod) Sorting by property drops results where that property value is not set - 10https://bugzilla.wikimedia.org/33705 +comment (10jeroen_dedauw) [14:25:11] <wikibugs> 03(mod) "Create a book" and "Download as PDF" don't wrap Chinese or Japanese lines - 10https://bugzilla.wikimedia.org/33430 +comment (10yaoziyuan) [14:25:14] <sumanah> Daniel_WMDE: MaxSem: toniher: https://www.mediawiki.org/wiki/UCOSP_Spring_2012 see my email just now to wikitech-l in case you are interested in mentoring some students over the next 4 months [14:26:42] <wikibugs> 03(mod) Enabling transwiki import on sa.wiktionary - 10https://bugzilla.wikimedia.org/33215 +shell; +comment (10Siebrand) [14:29:35] <codurr> New code comment: Nikerabbit; ===; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108806#c29462> [14:31:45] <toniher> hi sumanah, thanks for pointing, I'll take a look [14:33:07] <wikibugs> 03(mod) Enabling transwiki import on sa.wiktionary - 10https://bugzilla.wikimedia.org/33215 +comment (10raul.swaroop) [14:35:08] <wikibugs> 03(NEW) html entities are shown in summaries in the "nearby" map - 10https://bugzilla.wikimedia.org/33706 normal; Wikimedia Mobile: android; (amir.aharoni) [14:42:47] <codurr> New code comment: Krinkle; See r108342 CR for discussion/solution.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108343#c29463> [14:45:40] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10Shiju Alex) [14:46:55] <wikibugs> 03(mod) Page moves into mainspace should appear on Special:Newpages for patrol - 10https://bugzilla.wikimedia.org/12363 +comment (10Snottywong) [14:48:17] <codurr> New code comment: Krinkle; In r108343 CR it is suggested to store this in the RequestContext instead. However, I don't think i; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108342#c29464> [14:54:02] <codurr> New code comment: Krinkle; This broke part of JavaScript in <tt>/trunk/extensions/FCKeditor/FCKeditor.body.php </tt> as it was; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/90286#c29465> [14:56:29] <wikibugs> 03(mod) "importScriptURI is not defined" with monobook skin - 10https://bugzilla.wikimedia.org/33669 +comment (10Erwin Dokter) [14:58:47] <codurr> New code comment: IAlex; The only other solution I see is to silently return null, but this will certainly throw a fatal erro; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29466> [14:59:07] <wikibugs> 03(mod) Narayam should default to Tamil-only on Tamil Wiki projects - 10https://bugzilla.wikimedia.org/32257 +comment (10santhosh.thottingal) [14:59:55] <wikibugs> 03(WONTFIX) Narayam should default to Tamil-only on Tamil Wiki projects - 10https://bugzilla.wikimedia.org/32257 +comment (10Srikanth Logic) [15:00:32] <codurr> New code comment: IAlex; What's the difference with the previous code?; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29467> [15:00:38] <MaxSem> sumanah, can't really tell if I'm interested unless I know what projects they will be [15:01:45] <sumanah> MaxSem: you can of course influence the choice of project [15:03:23] <MaxSem> sumanah, then they should introduce themselves to the community and tell us what skills they have and in what projects they're interested [15:04:01] <sumanah> MaxSem: they've already done similar things in personal communication with me & Amgine so I could collate that material & put it on the webpage [15:05:28] * yuvipanda waves at sumanah  [15:05:32] <codurr> New code comment: Rsterbin; Good point, thanks. Fixed in r108812.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108778#c29468> [15:05:33] <sumanah> hi yuvipanda [15:15:13] <wikibugs> 03(mod) Browser error message received when accessing namespace pages that don't yet exist - 10https://bugzilla.wikimedia.org/33275 (10Milan Patel) [15:22:23] <wikibugs> 03(mod) "images" directory to be renamed or migrated to "files" - 10https://bugzilla.wikimedia.org/33569 +comment (10b) [15:26:18] * MaxSem facepalms: [15:26:19] <MaxSem> $attr['scale'] = str_replace(array("km","m"),array("000",""),$attr['dim']) / 0.1; [15:26:51] <MaxSem> geohack is so geohack [15:33:23] <wikibugs> 03(mod) "images" directory to be renamed or migrated to "files" - 10https://bugzilla.wikimedia.org/33569 +comment (10Krinkle) [15:36:48] <sumanah> hi hexmode, how are the test deployment site work and the code review meistering going? [15:37:28] <sumanah> I see that as of today we're at our lowest to-review # on trunk in a long time, under 300 revisions [15:38:15] <sumanah> In August we hit a low of 253 and we're at our lowest since then, 288 or so [15:38:34] * sumanah looks at http://toolserver.org/~robla/crstats/ and https://www.mediawiki.org/wiki/MediaWiki_roadmap/1.19/Revision_report [15:38:39] <wikibugs> 03(NEW) labs.wikimedia.deployment.wmflabs.org - 1.19: Recompile wikidiff2.cpp - 10https://bugzilla.wikimedia.org/33707 normal; Wikimedia: Prototype server; (erwin) [15:38:51] <ashley> we could make it 287 or so if someone marks http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108295 as resolvd ;-) [15:38:57] <ashley> *resolved, even [15:39:01] <sumanah> hexmode: did you end up sending out those "please fix my FIXMEs" emails yesterday? [15:39:01] <wikibugs> 03(mod) User modules not loaded on pages that disallow module origin "ORIGIN_CORE_INDIVIDUAL" - 10https://bugzilla.wikimedia.org/10005 summary; +comment (10Krinkle) [15:39:02] <ashley> and hi sumanah! how's things? [15:39:17] <cneubauer> Is there an easy way to disable a special page in 1.18? [15:39:20] <sumanah> hi ashley! I'm ok. Waiting for a response re those Canadian students [15:39:26] <sumanah> ashley: (UCOSP) [15:39:39] <Nikerabbit> ashley: why resolved? It didn't introduce that xss [15:40:15] <ashley> the XSS issue was resolved in follow-up commits and that commit does what it promises in the commit msg [15:40:22] <ashley> cneubauer: http://www.mediawiki.org/wiki/Extension:DisableSpecialPages maybe? [15:41:17] <ashley> ah, yes...I read the email...it sounded pretty awesome, until I got to the "something that will be deployed on Wikimedia sites" part [15:41:19] <Nikerabbit> ashley: why doesn't it just pass User objects around? [15:42:46] <ashley> now that's a good question...this is old (or should I say ancient?) code that -- to my knowledge -- really hasn't been reviewed too much; I'll probably fix that one day, but that day's not today nor tomorrow [15:45:58] <wikibugs> 03(mod) "images" directory to be renamed or migrated to "files" - 10https://bugzilla.wikimedia.org/33569 +comment (10innocentkiller) [15:47:21] <sumanah> ashley: well, that is preferred, but if someone is willing to be an active and responsive mentor and has an idea for something that isn't, you could add it to the page with that stipulation, and the students can consider it [15:48:38] <cneubauer> ashley: thanks. I was hoping for a global variable or somehting but that'll work [16:05:52] <ashley> sumanah: I just might be able to come up with something social, we'll see ;-) [16:06:04] <sumanah> :) [16:07:08] <ashley> Nikerabbit: what could be causing localized special page aliases to fail? I updated a wiki to MW 1.18.0 (from 1.16.0), now [[Toiminnot:WikiFoorumi]] returns "no such special page", while [[Toiminnot:WikiForum]] works [16:14:34] <Platonides> ashley, someone could have removed the alias [16:14:41] <wikibugs> 03(mod) Inline rendering/thumbnailing for Gimp XCF images - 10https://bugzilla.wikimedia.org/17959 +comment (10Antoine "hashar" Musso) [16:14:42] <Platonides> even though you are not supposed to do so [16:15:53] <ashley> https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/WikiForum/ -- from what I can see, it *should* be working, but... [16:18:16] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 (10wikichaipau) [16:23:50] <Nikerabbit> ashley: try rebuilding l10n cache [16:28:59] <Nikerabbit> codurr: purrrr [16:38:08] <wikibugs> 03(mod) html entities are shown in summaries in the "nearby" map - 10https://bugzilla.wikimedia.org/33706 +comment (10amir.aharoni) [16:39:54] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10Niklas Laxström) [16:40:43] <kghbln> Hi, may it be that ext SpecialUploadLocal was removed from SVN. Is there a way to find out? [16:41:59] <kghbln> Ah, I just saw that it was moved. [16:47:53] <wikibugs> 03(mod) local ip used for external querys - 10https://bugzilla.wikimedia.org/33698 (10bugzilla23) [16:54:02] <sumanah> hey gicode, mind if I split up your project ideas into separate sections on https://www.mediawiki.org/wiki/San_Francisco_Hackathon_January_2012/Teams ? I prefer for the sections to be projects, not people [16:58:32] <codurr> New code comment: Reedy; Hmm. Whenever I used it, I just always did "global $wgUser;" etc first...; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108777#c29469> [16:58:32] <codurr> New code comment: Nikerabbit; svn ci -m?; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108812#c29470> [16:59:53] <OvrLrd-Q|W> \o/ postgres-phpunit isn't broken again [17:00:04] <sumanah> cool! [17:02:40] <wikibugs> 03(mod) Some tables lack unique or primary keys, may allow confusing duplicate data - 10https://bugzilla.wikimedia.org/15441 +comment (10sam) [17:03:58] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10dzahn) [17:04:32] <codurr> New code comment: Nikerabbit; Are these dimensions translatable?; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108819#c29471> [17:06:05] <wikibugs> 03(mod) labs.wikimedia.deployment.wmflabs.org - 1.19: Recompile wikidiff2.cpp - 10https://bugzilla.wikimedia.org/33707 +comment (10Sam Reed (reedy)) [17:06:47] <codurr> New code comment: MaxSem; This parser function reuses stuff intended for geohack, and geohack doesn't localise anything - thus; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108819#c29472> [17:06:52] <wikibugs> 03(mod) labs.wikimedia.deployment.wmflabs.org - 1.19: Recompile wikidiff2.cpp - 10https://bugzilla.wikimedia.org/33707 +comment (10sam) [17:08:38] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 (10wikichaipau) [17:09:58] <wikibugs> 03(mod) PHP Warning on showing Release Notes due to the fact that file does not exist - 10https://bugzilla.wikimedia.org/33691 +easy; +comment (10Sam Reed (reedy)) [17:10:46] <wikibugs> 03(mod) PHP Warning on showing Release Notes due to the fact that file does not exist - 10https://bugzilla.wikimedia.org/33691 normal->minor (10Sam Reed (reedy)) [17:14:03] <wikibugs> 03(mod) Enable Rollback group on id.wiki - 10https://bugzilla.wikimedia.org/33508 +comment (10sam) [17:15:37] <wikibugs> 03(mod) Change project namespace for lb.wiktionary - 10https://bugzilla.wikimedia.org/33662 +comment (10sam) [17:17:34] <wikibugs> 03(mod) Provide additional links on Special:Listusers - 10https://bugzilla.wikimedia.org/12021 (10Sam Reed (reedy)) [17:21:27] <sumanah> I have to head off to lunch, but amgine, I expect some of the UCOSP students will stop in and talk here? I'm hoping to get them to put more ideas on the UCOSP wiki page [17:21:28] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10sam) [17:21:55] <amgine> I'm here. [17:22:02] <sumanah> guillom: in case I don't see you again today, have a good weekend [17:22:02] <amgine> To lunch? [17:22:11] <sumanah> :-) [17:22:41] <codurr> 03santhosh * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108805> 10/trunk/extensions/Translate/specials/SpecialTranslate.php: [17:22:41] <codurr> Add help link to the main page of Special:Translate too. [17:22:41] <codurr> Followup r108804. [17:25:19] <wikibugs> 04(REOPENED) Please lock *.labs.wikimedia.org - 10https://bugzilla.wikimedia.org/33644 +comment (10Thehelpfulone) [17:25:20] <wikibugs> 03(mod) Create {{SPACEUSER}} to improve detection of page owner in User spaces, also usable in interface messages - 10https://bugzilla.wikimedia.org/32703 +comment (10gustronico) [17:25:35] <Thehelpfulone> RobH: ^ hmm it managed to fix it self? [17:25:54] <RobH> we didnt change anything though =P [17:26:00] <RobH> i mean, you saved the same info is all [17:26:04] <RobH> i guess that was enough [17:26:18] <RobH> oddness [17:26:21] <Thehelpfulone> hmm [17:26:26] <Thehelpfulone> but when I saved it and then made a comment [17:26:28] <Thehelpfulone> it was Thehelpfulonewiki [17:26:32] <Thehelpfulone> but today it's Thehelpfulone [17:26:35] <Thehelpfulone> very strange... [17:33:12] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 (10wikichaipau) [17:35:13] <wikibugs> 03(NEW) "ون" -> "ویکی‌نبشته" - 10https://bugzilla.wikimedia.org/33708 normal; Wikimedia: Site requests; (atgigabyte.info) [17:35:47] <codurr> New code comment: Nikerabbit; Which didn't even work.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107422#c29474> [17:36:35] <wikibugs> 03(mod) "ون" -> "ویکی‌نبشته" - 10https://bugzilla.wikimedia.org/33708 +shell (10sahim) [17:37:36] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10Jeremy Baron) [17:39:10] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 (10wikichaipau) [17:40:03] <jeremyb> Suiseiseki: you read devanagri, right? [17:40:06] <jeremyb> gah [17:40:13] <jeremyb> was for sumanah [17:40:28] <jeremyb> [freenode] -!- There is no such nick sumanah [17:40:47] <codurr> New code comment: Siebrand; Yay!; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108809#c29475> [17:40:55] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10shijualex) [17:41:02] <codurr> New code comment: Siebrand; More yay!; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108810#c29476> [17:41:47] <codurr> New code comment: Siebrand; This is now available. See r108809 for example. Adding keyword "jsplural", although IMO it should be; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/78453#c29477> [17:44:02] <codurr> New code comment: Nikerabbit; Typo? openPropertieFile \ The comments are indented weirdly: \ + System.getProperty("user.dir") +T; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107775#c29478> [17:45:12] <Ashex> Any way I can modify a pending change I made to an article on mediawiki? [17:45:16] <Ashex> I forgot to add some stuff in [17:45:30] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 (10wikichaipau) [17:45:56] <Amgine> Ashex: Edit again. [17:46:04] <Ashex> Amgine: fair enough :p [17:46:15] <Ashex> I've already got 2 pending on the page, why not 3 :) [17:46:22] <Amgine> <nods> [17:49:38] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 +comment (10Daniel Zahn) [17:55:46] <codurr> New code comment: Nikerabbit; There are some JS errors in twn log: \ 2012-01-11T03:17:22UTC mw.loader.setBlocking is not a functi; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108184#c29479> [17:56:33] <wikibugs> 03(NEW) History list, when cleared, re-appears when app is re-opened - 10https://bugzilla.wikimedia.org/33709 normal; Wikimedia Mobile: iphone; (philinje) [17:57:16] <codurr> New code comment: Rsterbin; Yeah, that was supposed to be $wgSpamRegex; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108812#c29480> [17:57:56] <codurr> 03ialex * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108806> 10/trunk/phase3/includes/specials/SpecialMovepage.php: Per Aaron, fix for r107776: correct count() check [17:57:57] <codurr> 03ialex * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108807> 10/trunk/phase3/includes/OutputPage.php: Fix for r108376: the whole string is already espcaed on output, no need to escape it twice [17:59:22] <codurr> 03ialex * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108808> 10/trunk/ (7 files in 6 dirs): svn:eol-style native [18:00:38] <ialex> You lag codurr! [18:01:20] <wikibugs> 03(mod) Translation of "Wikipedia" namespace in Assamese for Assamese Wikipedia - 10https://bugzilla.wikimedia.org/33507 (10wikichaipau) [18:11:20] <codurr> 03jeroendedauw * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108809> 10/trunk/extensions/Contest/ (3 files in 2 dirs): follow up to r100274 - plural use in js messages [18:11:49] <codurr> 03jeroendedauw * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108810> 10/trunk/extensions/EducationProgram/ (3 files in 2 dirs): plural in js messages [18:14:33] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108811> 10/trunk/phase3/ (2 files in 2 dirs): Add 'api-error-emptypage'. [18:14:43] <wikibugs> 03(VERIFIED) Search namespaces from [[Special:Preferences]] are ignored - 10https://bugzilla.wikimedia.org/33583 (10Antoine "hashar" Musso) [18:14:54] <codurr> 03rsterbin * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108812> 10/trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php: Do the , SpamBlacklist, and AbuseFilter checks only when those are set up (followup to r108778) [18:14:55] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108813> 10/trunk/extensions/Translate/ (Translate.php resources/ext.translate.quickedit.js): Localise a likely error. Ping r108811. [18:16:34] <codurr> 03rsterbin * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108814> 10/trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js: Put classes directly in html rather than adding them with jquery; Yoni thinks that change did not in fact fix any IE7 bugs, and there's a modest perfomance improvement without it [18:17:45] <wikibugs> 03(mod) Enable Rollback group on id.wiki - 10https://bugzilla.wikimedia.org/33508 +comment (10bknliem) [18:18:32] <wikibugs> 04(REOPENED) failure of PHPUnit tests for revision 108474 under postgres - 10https://bugzilla.wikimedia.org/33663 +comment (10Dan Nessett) [18:19:16] <wikibugs> 03(mod) failure of PHPUnit tests for revision 108474 under postgres - 10https://bugzilla.wikimedia.org/33663 +comment (10dnessett) [18:20:02] <cj> moo [18:20:05] <cj> is this the dev channel? [18:20:14] <cj> I'm trying to add the UserAdministration extension [18:20:17] <cj> I'm getting PHP Fatal error: Call to private method User::loadGroups() from context 'SpecialUADMBase' [18:21:18] <DerJoerg> Hi guys! [18:21:31] <cj> Hi DerJœrg! [18:22:42] <DerJoerg> I use a skin with custom messages. Is there a way to provide the texts for them in a PHP file? [18:22:54] <DerJoerg> E.g. something like these *.i18n.php files in extensions? [18:22:56] <codurr> 03nikerabbit * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108815> 10/trunk/extensions/Translate/tag/TPParse.php: Special:PageTranslation could in some occasions suggest duplicate keys for translation units, because the existing keys were strings "1" and not numbers 1 [18:23:04] <codurr> 03nikerabbit * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108816> 10/trunk/extensions/Translate/ (PageTranslation.i18n.php tag/SpecialPageTranslation.php): [18:23:04] <codurr> Do proper checks for duplicate unit names instead of dying with SQL error. [18:23:04] <codurr> Also check the validity of unit names that come from page source, they can be tampered by users and cannot be trusted. [18:23:04] <codurr> In the non-latest error message, link the revision number to oldid of that page. [18:23:17] <codurr> 03nikerabbit * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108817> 10/trunk/extensions/Translate/README: Update README too [18:24:12] <codurr> 03nikerabbit * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108818> 10/trunk/phase3/languages/messages/MessagesEn.php: Fixing plural. Would "file, which" be clearer? [18:24:40] <codurr> 03maxsem * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108819> 10/trunk/extensions/GeoData/ (CoordinatesParserFunction.php GeoData.php tests/TagTest.php): Fixed dim handling, made it fall back to scale and type [18:24:45] <codurr> 03nikerabbit * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108820> 10/trunk/extensions/Translate/README: Ping r108817 - I'm living a wrong day [18:26:57] <codurr> 03jeroendedauw * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108821> 10/trunk/extensions/EducationProgram/includes/ (EPDBObject.php EPOrg.php): work on logging code [18:30:24] <varnent> so - any volunteers of folks working on MW1.19 core who could type for 2-3 minutes during the upcoming extensions workshop on extension/skin specific changes coming in 1.19? [18:30:34] * varnent not above groveling / begging [18:32:01] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108822> 10/trunk/extensions/Translate/tag/PageTranslationHooks.php: Return message instead of key. [18:32:02] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108823> 10/trunk/extensions/Translate/tag/PageTranslationHooks.php: Fix typo in r108822. [18:33:16] <codurr> New code comment: Aaron Schulz; <pre>$page = WikiPage::factory( $this->getTitle() );</pre> \ It always created a page from the title.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29481> [18:33:31] <wikibugs> 03(mod) html entities are shown in summaries in the "nearby" map - 10https://bugzilla.wikimedia.org/33706 +comment (10brion) [18:35:03] <xixor> Hi everyone, I could use some help setting up "ShortURLs" if anyone has a moment. I have root access and am following http://www.mediawiki.org/wiki/Manual:Short_URL, but can't make it work. My goal is to have www.domain.com/ArticleName, no /wiki/ or any other folder in the URL [18:36:22] <xixor> so I've tried setting: $wgArticlePath = "/$1"; and then setting an Alias / /var/www/wiki_install_dir in the httpd.conf file [18:37:16] <Grzechooo> !nullpath | xixor [18:37:16] <mw-bot> xixor: Don't use the example.com/Page_title URL scheme. It isn't supported by developers and WILL break in ways you can't foresee (and if it doesn't, it might break in the future). Some examples can be found at http://www.mediawiki.org/wiki/Manual:Wiki_in_site_root_directory#Reasons_why_putting_wiki_pages_in_the_root_directory_of_the_web_site_is_bad [18:39:36] <wikibugs> 03(mod) Add alias to fa wikisource - 10https://bugzilla.wikimedia.org/33708 normal->15enhancement; summary (10Sam Reed (reedy)) [18:40:25] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108824> 10/trunk/translatewiki/MediaWiki/mediawiki-defines.txt: Update tags. [18:40:55] <xixor> it seems that there are people who argue in favour of that style of URL below [18:41:49] <wikibugs> 03(mod) html entities are shown in summaries in the "nearby" map - 10https://bugzilla.wikimedia.org/33706 +comment (10brion) [18:41:50] <wikibugs> 03(mod) Add alias to fa wikisource - 10https://bugzilla.wikimedia.org/33708 +comment (10sam) [18:42:39] <codurr> 03rmoen * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108825> 10/trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js: in preparation of concurrencyCheck extension, add concurrency check call to feedback dashboard response items, added method to load tooltip for notification. [18:46:47] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108826> 10/trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.i18n.php: Add a few forgotten words. [18:48:32] <codurr> 03gwicke * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108827> 10/trunk/extensions/VisualEditor/modules/parser/ (3 files): [18:48:33] <codurr> Template expansion now enabled and somewhat working, but template fetching [18:48:33] <codurr> still fails all the time. [18:51:54] <wikibugs> 03(WONTFIX) Detect "extra whitespace" / BOM conditions - 10https://bugzilla.wikimedia.org/9954 +comment (10Antoine "hashar" Musso) [18:52:06] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108828> 10/trunk/extensions/GeoData/GeoData.i18n.php: Remove punctuation from description message. [18:55:41] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108829> 10/trunk/translatewiki/Wikia/extensions.txt: Update supported MediaWiki extensions for Wikia. [18:56:07] <varnent> five minute reminder about MediaWiki Workshop: Preparing extensions for MediaWiki 1.19 in #wikimedia-dev - https://www.mediawiki.org/wiki/Project:WikiProject_Extensions/MediaWiki_Workshops [18:56:30] <xixor> Can httpd.conf alias go to specific files? Alias /someurl /var/www/wiki_install_dir/index.php/SomeArticle ? [19:02:38] <ChrGermany> Hello, I#m from the german wikinews. On the spechial page "Wanted categories" are some categories, with no articles inside. On the page is written "The following data is cached, and was last updated 15:03, 13 January 2012", but the category is empty since 2 weeks. 1. Why? 2. What can I do against it? Thanks for your help, C. [19:03:00] <bawolff> ChrGermany: yay Wikinewsies! [19:03:03] * bawolff is a wikinewsie [19:03:43] <Ashex> There any documentation on automating a wiki install? [19:03:50] <Ashex> progammatically that is [19:04:22] <bawolff> Ashex: there's a cli installer, last i heard it was still very experimental though [19:05:25] <bawolff> Ashex: but at the core, you could probably just install mediawiki once, save the db, save the local settings, then copy the db /localsettings (changing db name/ whatever) to have a hacky automated install [19:05:27] <Yaron> ChrGermany - can you link to this URL? [19:05:45] <ChrGermany> http://de.wikinews.org/wiki/Spezial:Gew%C3%BCnschte_Kategorien [19:06:10] <Ashex> bawolff: In my case I'm using the same database just with prefixes [19:06:15] <Ashex> Part of the wiki family I'm working on [19:06:52] <Yaron> ChrGermany - I don't know what the caching system is for that page, but it's definitely not empty now... [19:07:13] <Yaron> Oh, I see - it was never empty. [19:07:20] <Ashex> Goal is to create a php script that will setup database, create sites LocalSettings file, update the master one, and initialize SMW [19:07:34] <Yaron> ChrGermany - what's the category that's empty? [19:07:48] <ChrGermany> it's Flugunfälle [19:07:59] <ChrGermany> (for example) [19:09:07] <Yaron> Ah, indeed - that looks like a bug. Unfortunately, I can't help with that one, although hopefully someone here can. [19:09:23] <bawolff> ChrGermany: basically we store category counts independantly from whats actually in the category [19:09:28] <Ashex> bawolff: can you point me to the cli installer? [19:09:32] <bawolff> and some times they get out of sync [19:09:59] <bawolff> but they should be auto-regenerated if they have less then 200 items... [19:10:52] <wikibugs> 03(NEW) Android app icon title is not localized under certain conditions - 10https://bugzilla.wikimedia.org/33710 normal; Wikimedia Mobile: android; (amir.aharoni) [19:11:00] <bawolff> Ashex: install.php in the maintinance directory (I'm really unsure as to how "production ready" it is though) [19:11:25] <Amgine> It's good. I've used it. [19:11:46] <Ashex> Okay, I'll take a look at it [19:12:00] <Ashex> Most likely I'll just borrow pieces of code from it and build my own script. [19:12:11] <Ashex> I'll document it in the wiki when I'm done [19:12:22] <Ashex> btw, can you approve my changes to the wiki family page :) [19:12:36] <Ashex> I rewrote the section dealing with mod_rewrite [19:12:56] <bawolff> Not right now, but I'll look at them later [19:13:02] <Ashex> Ok, thanks [19:13:11] <Amgine> I suggest, having just done the same thing, that you just use the cli installer which can be managed in an automated fashion. It will be future-proofed. [19:14:02] <codurr> New code comment: Nikerabbit; Was this supposed to fix API errors? This breaks non-API errors: http://translatewiki.net/sandwiki/i; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108822#c29482> [19:14:03] <Ashex> Hmmm, I would like to but each LocalSettings.php file is going to be customized a bit [19:14:51] <Ashex> I'll look at it and go from there [19:15:11] <Amgine> Customize *after*. [19:20:35] <wikibugs> 03(mod) Change en.labs.wikimedia.org FlaggedRevs settings to the Finnish Wikipedia ones - 10https://bugzilla.wikimedia.org/33617 +comment (10federicoleva) [19:21:27] <codurr> New code comment: Nikerabbit; Try to keep consistent whitespace.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108825#c29483> [19:21:34] <Ashex> Looking at it now, I will need to modify a bit. Currently doesn't support prefixes [19:22:04] <bawolff> --dbprefix option? [19:22:09] <bawolff> or maybe that's new in 1.19 [19:22:20] <Amgine> Ashex: take a look at addWiki.php in WikimediaMaintanence (via Johnduhart) [19:24:16] <Ashex> Amgine: I'll take a look at it [19:24:36] <Amgine> (me too, as soon as I have time) [19:25:05] <wikibugs> 03(mod) Android app icon title is not localized under certain conditions - 10https://bugzilla.wikimedia.org/33710 +comment (10brion) [19:28:31] <codurr> New code comment: Cneubauer; I'm obviously a bit late on this, but what was the rationale for going from the skin based functions; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/85244#c29484> [19:28:32] <akerbeltz> hiya got a question - i have an existing site which i've redone as a mediawiki. cause I didn't want to take it down which I was doing that, i just installed it in a subdir . Now i'm done, I can't find anything that tells me what the best way of replacing the old with the new is. [19:30:15] <bawolff> akerbeltz: Well you can move the subdir into the parent (might have to move the parent somewhere else). Then you'd need to edit LocalSettings.php and modify a couple settings ( $wgScriptPath, $wgArticlePath ) [19:32:23] <akerbeltz> the thought had occurred to me but seemed too simple, I was afraid it'd break every link [19:32:32] <wikibugs> 03(FIXED) Android app icon title is not localized under certain conditions - 10https://bugzilla.wikimedia.org/33710 +comment (10Brion Vibber) [19:32:40] <akerbeltz> what's in the paths that need changing? [19:33:40] <Ashex> $wgScriptPath I think [19:33:58] <Ashex> http://www.mediawiki.org/wiki/$wgScriptPath [19:34:47] <akerbeltz> ok thanks I'll have a bash at that [19:35:52] <varnent> Dantman: ping [19:38:04] <Ashex> Interesting, looks like addwiki.php is going to be rolled into the 1.18.1 release [19:38:07] * Ashex is poking as svn [19:38:38] <Ashex> Or rather, I need to make my putty screen bigger. [19:42:22] <DerJoerg> Hi guys! [19:43:02] <DerJoerg> Remember my question from before? I wanted to know, how I can include custom messages in my skin. [19:43:13] <DerJoerg> Now I found way: [19:43:33] <bawolff> Ashex: It might have been moved into the WikimediaMaintinance extension [19:43:41] <DerJoerg> In LocalSettings.php I set $wgExtensionMessagesFiles['MySkin'] = $IP.'/skins/MySkin.i18n.php'; [19:43:57] <Ashex> bawolff: it was. 1.18 came with it though [19:44:19] <ashley> DerJoerg: you really should write a setup file for your skin and try to keep your skin as self-contained as possible [19:44:53] <ashley> https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/skins/Nimbus/ -- like that ;) [19:45:01] <Ashex> I am going to need to tweak it a bit, but it's definitely a start [19:45:16] <DerJoerg> Hi Ashley! Do you have a....OK ;-) [19:45:48] <Ashex> Looks like I can just replace/heavily modify the foreach loop at line 105 [19:47:01] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108830> 10/trunk/extensions/Translate/ (README scripts/export.php): Add switch "--no-fuzzy" to export.php to will filter out fuzzy messages for file based message groups. [19:47:14] <DerJoerg> Line 105 in which file? Nimbus.skin.php? [19:47:25] <Ashex> DerJoerg: I'm talking about addwiki.php [19:47:28] <Ashex> https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/WikimediaMaintenance/addWiki.php?view=markup [19:47:39] <DerJoerg> ok... [19:48:24] <Ashex> I'm working on a wiki family :) [19:48:40] <DerJoerg> Ashley, the Nimbus skin seems to add its messages also by using $wgExtensionMessagesFiles - the same way I do it. [19:48:46] <akerbeltz> that seems to have worked, thanks guys! [19:48:59] <DerJoerg> What do you mean with "a setup file for your skin"? [19:50:54] <ashley> see Nimbus.php -- I've designed it so that you can download the contents of https://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/skins/Nimbus/ into $IP/skins/Nimbus (note casing) and then require_once($IP.'/skins/Nimbus/Nimbus.php'); and stuff will magically work and it stays self-contained = easy to maintain [19:51:07] <wikibugs> 03(NEW) mw.util.$content is null - 10https://bugzilla.wikimedia.org/33711 normal; MediaWiki: Javascript; (mah) [19:51:53] <DerJoerg> But you do not that one reuqire_once(); line, right? [19:52:24] <Ashex> you accidentally a word [19:53:01] <DerJoerg> I mean "you do NEED that require_once line. ;-) [19:53:08] <wikibugs> 03(mod) mw.util.$content is null - 10https://bugzilla.wikimedia.org/33711 +comment (10Niklas Laxström) [19:53:31] <codurr> New code comment: IAlex; It doesn't have to worry about WikiPage being set since one will be created if needed (and it will s; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29485> [19:53:49] <DerJoerg> Because inside the included file you then do some things, aongst them setting $wgExtensionMessagesFiles. [19:54:25] <DerJoerg> Currently I directly set $wgExtensionMessagesFiles in LocalSettings.php instead of including another file. [19:54:46] <DerJoerg> But apart from that both is the same. [19:55:01] <codurr> 03preilly * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108831> 10/trunk/extensions/MobileFrontend/ (7 files in 3 dirs): fix the style of the zero rated banner [19:55:21] <codurr> 03preilly * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108832> 10/trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php: change h3 to span [19:56:51] <codurr> 03khorn * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108833> 10/branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/ (3 files in 2 dirs): MFT r108780, r108783 [19:57:05] <DerJoerg> But I get what you mean. The way I do it currently "pollutes" LocalSettings.php, because I set those things, which you have in Nimbus.php directly in LocalSettings.php. [19:57:22] <wikibugs> 03(NEW) Javascript errors on deployment - 10https://bugzilla.wikimedia.org/33712 normal; MediaWiki: Resource Loader; (mah) [19:57:32] <ashley> indeed -- you'll want your LS to be easily maintainable and not tl,dr :-) [19:57:54] <wikibugs> 03(mod) Android app icon title is not localized under certain conditions - 10https://bugzilla.wikimedia.org/33710 +comment (10brion) [20:00:33] <codurr> 03preilly * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108834> 10/branches/wmf/1.18wmf1/extensions/ZeroRatedMobileAccess/ (3 files): 1.18wmf1: MFT r108589 - 108831 [20:01:45] <DerJoerg> I have 800 lines currently - at least this includes nice comments. ;-) [20:03:04] <Ashex> Yikes, I use a GlobalSettings.php file to keep mine clean [20:03:49] <DerJoerg> Is it "right" to use $wgExtensionMessagesFiles, although it is a skin and no extension? [20:05:39] <pubsez> does anyone know what is being cached in the memcached and what kind of an impact does it have on the mysql servers? [20:06:33] <ashley> yes, because we don't have $wgSkinMessagesFiles at the time being ;-) because the skin system is a fugly mess [20:07:28] <Ashex> pubsez: objects and data. http://www.mediawiki.org/wiki/Memcached [20:07:47] <codurr> 03preilly * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108835> 10/branches/wmf/1.18wmf1/extensions/MobileFrontend/ (17 files in 4 dirs): 1.18wmf1: MFT r108714 - 108831 [20:10:58] <codurr> 03preilly * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108836> 10/trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.i18n.php: change wikipedia to sitename variable [20:11:43] <codurr> 03preilly * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108837> 10/branches/wmf/1.18wmf1/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.i18n.php: 1.18wmf1: MFT r108836 [20:12:03] <pubsez> thanks Ashex, I actually read that document, what I couldn't understand is, for example for english size like wiki, after which point memcached will not help much, since I assume not everything can be cached and we still have to go to database for many queries [20:12:58] <Ashex> pubsez: It can cache pretty much everything, the cache will expire though [20:12:59] <pubsez> as we increase the memory available to memcached the performance will increase, but after some point it won't increase that much [20:13:07] <Ashex> So when an article expires, it will be fetched from the database [20:13:21] <DerJoerg> Ashley: Al right. Thanks for your help! [20:13:21] <Ashex> pubsez: that all depends on the server load [20:13:34] <DerJoerg> So to sum up how I did it now: [20:13:37] <pubsez> I see, so it is essentially a copy of the database, as much as possible? [20:13:46] <Reedy> Not really [20:13:54] <DerJoerg> As it is done in the Nimbus skin. ;-) [20:14:25] <Ashex> Yep, Memcache doesn't cache the database but the wiki in a way [20:14:31] <Ashex> I'm sure someone else can explain it better then me [20:14:47] <pubsez> do we still have to go to database for queries, e.g. whether if a given title exists in the db ? [20:15:01] <pubsez> I mean, it doesn't cache the list of all titles, right? [20:15:10] <johnduhart> ialex: Is there a reason why SpecialPage doesn't implement that interface btw? [20:15:48] <ialex> johnduhart: it could, but you need to be careful with getWikiPage() in that case [20:16:01] <ialex> since special pages cannot have a WikiPage object [20:16:13] <Ashex> pubsez: have you read this? http://www.mediawiki.org/wiki/Manual:Cache [20:16:24] <Ashex> Take a look at the section on Object Caching [20:16:33] <johnduhart> ialex: That's true. [20:16:33] <Ashex> Also, read up on what memcache actually is, that will help [20:16:42] <johnduhart> ialex: What if we just return null? [20:17:36] * ialex would prefer an Exception... [20:17:40] <wikibugs> 03(mod) failure of PHPUnit tests for revision 108474 under postgres - 10https://bugzilla.wikimedia.org/33663 +comment (10dnessett) [20:19:25] <pubsez> thanks Ashex , yes I read that before, the thing I am not sure about is that by object, does it mean individual records in the db or does it mean more than that, e.g. a sorted list of all titles in the wiki may also be considered an object and cached, but I doubt that it is actually being cached [20:20:16] <pubsez> what I understood from the documentation is records in the table can be cached, e.g. page property of a specific page and possibly the contents of a page, but we still go to db for querying and finding those records [20:20:21] <codurr> 03preilly * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108838> 10/trunk/extensions/MobileFrontend/ApplicationTemplate.php: update version numbers [20:20:35] <pubsez> but not knowing the source code completely, it is difficult for me to be sure [20:20:46] <codurr> New code comment: Reedy; Niklas would you mind resolving this and committing the correct version?; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/98659#c29486> [20:20:52] <codurr> 03preilly * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108839> 10/branches/wmf/1.18wmf1/extensions/MobileFrontend/ApplicationTemplate.php: 1.18wmf1: MFT r108838 [20:21:06] <johnduhart> ialex: That works too [20:21:50] <codurr> 03ialex * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108840> 10/trunk/extensions/Configure/ (14 files in 5 dirs): [20:21:50] <codurr> * Use local context instead of global variables where possible [20:21:50] <codurr> * Call Linker methods statically [20:21:50] <codurr> * Bump version requirement to 1.18 for the above [20:22:14] <Ashex> pubsez: sort of. mediawiki will check the memcache first for the records [20:22:20] <Ashex> If they don't exist it will query the DB [20:22:40] <Ashex> it's the reason why caching apps have to be fast [20:23:07] <pubsez> is there a document which explains this overall process, e.g. for index.php/Title what's the steps taken by mediawiki? [20:23:35] <Ashex> pubsez: you're asking how memcache works, so you'll want to look at their documentation [20:23:46] <Ashex> The Cache wiki page only gives a light explanation [20:24:03] <Ashex> for something indepth you'll want to read up on the caching method, in this case memcache [20:24:23] <pubsez> thanks [20:25:28] <pubsez> by the way, just to clear it out, what I was wondering was not how memcached works but how mediawiki interacts with it, your previous comments helped a lot on that front, but a document explaining the steps taken by mediawiki to render a page would help a little more :) [20:26:03] <codurr> 03jeroendedauw * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108841> 10/trunk/extensions/Contest/specials/SpecialContest.php: fix fail causing the challenge filter to not work [20:26:44] <JeroenDeDauw> Reedy: poke [20:26:56] <JeroenDeDauw> Reedy: can I bug you to review a one-line fix and deploy it? [20:27:06] <JeroenDeDauw> Reedy: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108841 [20:27:15] <JeroenDeDauw> Or if someone else feels like it :) [20:28:31] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108842> 10/trunk/extensions/ (2 files in 2 dirs): [20:28:32] <codurr> userpage_tools/users groups don't exist in Special:Version [20:28:32] <codurr> Just use other [20:28:32] <codurr> Ping r107723 [20:28:39] <Ashex> Side note, is there anything out there that will sync a user in mediawiki with LDAP? [20:28:50] <Ryan_Lane> !ldap | Ashex [20:28:50] <mw-bot> Ashex: http://www.mediawiki.org/wiki/Extension:LDAP_Authentication To get support, open a new thread on the support page http://www.mediawiki.org/wiki/Extension_talk:LDAP_Authentication [20:28:52] <Ashex> As in, mediawiki only imports user profile info for accounts existing [20:29:13] <Ashex> Booo, you're making me read [20:29:24] <Ryan_Lane> well, it's not a simple extension [20:29:35] <Ashex> I know :p [20:29:50] <Ashex> That's why I do SSO through Apache [20:30:43] <Ashex> you know if it's possible though? [20:31:42] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108843> 10/ (3 files in 3 dirs): MFT r108841 [20:32:51] <Reedy> JeroenDeDauw, done [20:34:05] <Ashex> Nevermind, found the option for it. [20:37:23] <jem-> Hi everyone, I want to discuss a change I've made in es.wiki's Common.js that isn't working as expected, is someone available? [20:37:49] <Nikerabbit> Reedy: can't you? I don't AbuseFilter checked out [20:38:02] <codurr> New code comment: Reedy; Do we need to add a deactivating thing still Niklas, or is that enough?; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/97905#c29487> [20:39:09] <Reedy> Nikerabbit, nothing more is needed to fix it? [20:39:31] <codurr> New code comment: Nikerabbit; Looks fine.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/97905#c29488> [20:39:31] <Reedy> literally copy pasta what you put to replace the first one? [20:39:39] <wikibugs> 03(mod) Add alias to fa wikisource - 10https://bugzilla.wikimedia.org/33708 +comment (10atgigabyte.info) [20:39:39] <Nikerabbit> Reedy: not as far as I can see [20:39:50] <Reedy> alright, I will do then [20:40:03] <Nikerabbit> times two though [20:40:14] <Nikerabbit> hm no [20:40:17] <Nikerabbit> just one time is enough [20:41:02] <codurr> New code comment: Aaron Schulz; That works unless we change filecache to work on some special pages :) \ Maybe we can keep the except; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29489> [20:41:21] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108844> 10/trunk/extensions/AbuseFilter/Views/AbuseFilterViewDiff.php: Fix r98659 per Nikerabbit [20:42:55] <ialex> AaronSchulz: if you change code to allow file caching special pages, then both old and new code will crash :) [20:43:16] <codurr> New code comment: Siebrand; Yes, it was. Guess I'll have to find another solution.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108822#c29490> [20:43:28] <jem-> No one who can help? [20:43:36] <AaronSchulz> ialex: if we are adding a new api function, may as well get it right [20:46:31] <codurr> New code comment: Reedy; Well that was fail \ For the ConfirmAccount commit, $spReportDir is unused; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108843#c29491> [20:49:51] <wikibugs> 03(FIXED) Inline rendering/thumbnailing for Gimp XCF images - 10https://bugzilla.wikimedia.org/17959 +comment (10Mark A. Hershberger) [20:51:44] <Nikerabbit> Reedy: little more and we are under 200 in total [20:52:02] <Reedy> Yup! [20:52:10] <Reedy> 230 [20:52:18] <Reedy> 39 fixme though :( [20:52:49] <tr|nn|> jem- though I am sure I am totally not the right guy to ask regards your question, I'd suggest you just ask your question and see if one can answer them or lend a helping hand. [20:53:11] <Reedy> we have a bot for that [20:53:12] <jem-> Ok, tr|nn|, I'll do it [20:53:12] <Reedy> !ask [20:53:12] <mw-bot> Hi, how can we help you? Just ask your question. [20:53:12] <Reedy> ;) [20:53:21] <tr|nn|> thanks Reedy :) [20:53:31] <jem-> I preferred to be sure to have eyes watching :) [20:53:50] <jem-> Ok, I've made this change: http://es.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=prev&oldid=52945150 [20:54:41] <jem-> The idea is to recognize 12 345 as a number and sort properly the sortable wikitables which use that format [20:54:58] <ialex> jem-: use   not   [20:55:05] <jem-> (Which is the recommended one for the Spanish Language Academy, in order to unify) [20:55:18] <jem-> Oh... [20:55:30] <jem-> Ok, ialex, I'm gonna try [20:55:55] <jem-> ialex: In bothe lines, I suppose... [20:55:59] <jem-> both* [20:56:18] <ialex> jem-: yes [20:56:34] <ialex> jem-: MediaWiki replaces   to   in wikitext [20:57:26] <tr|nn|> Reedy, will write that down --> !ask :) [20:57:33] <Reedy> !help [20:57:33] <mw-bot> http://www.mediawiki.org/wiki/Help:`e1 [20:57:42] <Reedy> We have a few other related ones [20:57:43] <Reedy> !hi [20:57:43] <mw-bot> http://www.mediawiki.org/wiki/Help:`e1 [20:57:49] <Reedy> ... [20:57:52] <Reedy> How is that help? [20:57:52] <codurr> 03raymond * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108845> 10/trunk/ (73 files in 48 dirs): Localisation updates for core and extension messages from translatewiki.net [20:57:55] * Reedy kicks mw-bot [20:58:16] <Nikerabbit> Reedy: 5 more! [20:58:29] <tr|nn|> lol [20:58:39] <Reedy> Rarrgh [20:58:57] <Reedy> Nikerabbit, Translate is about 10% of the backlog [20:59:05] <Nikerabbit> Reedy: really? [20:59:15] <Reedy> mmm [20:59:21] <Reedy> 21 new revs [20:59:25] <Nikerabbit> Reedy: ah [20:59:41] <Nikerabbit> Reedy: how many of them not mine? [20:59:48] <Nikerabbit> I've poked my team to have a look at them [20:59:55] <Reedy> 3 [20:59:56] <Reedy> :D [21:00:37] <Reedy> I can probably do some of the non JS ones [21:01:10] <wikibugs> 03(mod) the nearby function doesn't work in some locales - 10https://bugzilla.wikimedia.org/33704 (10Yuvi Panda) [21:02:00] <jem-> ialex: It's still not working :( [21:02:25] <jem-> After http://es.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=52955978&oldid=52945150 [21:02:51] <Nikerabbit> Reedy: you need to learn JS too :) [21:03:51] <Reedy> Indeed [21:05:39] <codurr> New code comment: Reedy; What was all the i18n changes? Seems to have been fixed by a future export; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107698#c29495> [21:06:01] <ialex> jem-: no idea then [21:06:21] <Nikerabbit> Reedy: 48 to go [21:06:51] <Reedy> Have we got a 150 target? [21:08:08] <aharoni> yuvipanda, this problem happens in Hebrew, Czech, Catalan, and maybe more languages. [21:08:15] <aharoni> oops, wrong window [21:09:40] <Nikerabbit> Reedy: yup, fits on one page [21:10:19] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108846> 10/trunk/extensions/Translate/ (7 files in 3 dirs): [21:10:19] <codurr> Move images from root image directory to resources/images [21:10:19] <codurr> Ping r108793 [21:10:19] <JeroenDeDauw> Reedy: thanks! :) [21:10:28] <Amqui> good day [21:10:28] <Amqui> what's that : http://cr.wikipedia.org/wiki/MediaWiki:Sitesupport-url ? [21:11:05] <codurr> New code comment: Ryan lane; That must have been me screwing things up. SVN simply confuses me.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107698#c29496> [21:11:06] <jem-> Ok, has anyone another idea about my problem? [21:11:32] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108847> 10/trunk/phase3/includes/api/ (7 files): Change usage of quotes in API messages from ``x'' to "x". [21:12:46] <codurr> New code comment: Reedy; Haha. It seems some clients don't do conflict resolution.. \ So presumably before you committed (and ; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107698#c29497> [21:13:24] <sumanah> hey jem- -- I just came in, but if you don't get help here, mediawiki-l might help [21:13:27] <sumanah> !lists | jem- [21:13:28] <mw-bot> jem-: mediawiki-l and wikitech-l are the primary mailing lists for MediaWiki-related issues. See http://lists.wikimedia.org/ for details. [21:13:41] <Reedy> 190 new [21:14:48] <sumanah> \o/ [21:15:27] <Reedy> At this rate we can deploy 1.19 on sunday evening ;) [21:15:46] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108848> 10/trunk/extensions/Translate/tag/PageTranslationHooks.php: Revert r108822 and r108823. This fixed an API error message, but caused an issue in the regular UI. [21:16:27] <siebrand> 186/38. It's getting closer... [21:16:45] <sumanah> https://www.mediawiki.org/wiki/MediaWiki_roadmap/1.19/Revision_report & http://toolserver.org/~robla/crstats/ fairly representative? [21:18:08] <Nikerabbit> we should be at 100/14 [21:18:24] <hexmode> robla: I need some help getting some JS errors fixed for deployment [21:19:04] <hexmode> robla: alolita1: https://bugzilla.wikimedia.org/show_bug.cgi?id=33711 [21:19:42] <hexmode> also, https://bugzilla.wikimedia.org/show_bug.cgi?id=33712 [21:19:56] <codurr> 03nikerabbit * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108849> 10/trunk/phase3/includes/api/ApiBase.php: Ping r108847, missed one half quote [21:20:22] <jem-> sumanah: Thanks, I don't know if my problem will fit properly in mediawiki-l, but I'll try if needed [21:21:14] <sumanah> johnduhart: per https://www.mediawiki.org/w/index.php?title=MediaWiki_1.19&curid=60155&diff=484986&oldid=484939 do you think that should go on https://www.mediawiki.org/wiki/1.20 ? :-) [21:21:30] <robla> so....there's one major discrepency between Revision_report and crstats. The former excludes revs tagged "nodeploy", and the latter doesn't [21:21:30] <wikibugs> 03(mod) Javascript errors on deployment - 10https://bugzilla.wikimedia.org/33712 +comment (10Mark A. Hershberger) [21:21:47] <robla> hexmode: you really need a better name for that [21:22:05] <robla> the word "deployment" is *seriously* overloaded [21:22:05] <hexmode> robla: for nodeploy? [21:22:13] <hexmode> an [21:22:37] <hexmode> ah well it is deployment-prep in labs, but yes [21:23:09] <robla> deployment-prep is better [21:23:39] <hexmode> robla: "beta" ... shorter and clearer? [21:24:49] <codurr> 03rmoen * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108850> 10/trunk/phase3/ (8 files in 5 dirs): patch from MrBlueSky, resloves bug 25909. Add dropdown list for tags in recent changes and new pages [21:25:23] <sumanah> rmoen: bsitu -- patch reviewing, thanks [21:25:28] <sumanah> how is that going? [21:25:29] <wikibugs> 03(FIXED) Add a drop-down list for the tags in Recentchanges and Newpages - 10https://bugzilla.wikimedia.org/25909 +comment (10Rob Moen) [21:25:38] <robla> hexmode: sure....I think we've got a legacy use for "beta" (we have "betawiki" somewhere), but I don't think it gets used much [21:25:47] <bsitu> reviewing the patch [21:25:50] <rmoen> sumanah: good. :) [21:26:10] <Nikerabbit> hah, oh the betawiki times :D [21:26:15] <rmoen> sumanah: Thanks for the shout out :) [21:27:06] <robla> hexmode: I'd like a name that actually implies its a website and not a software version (so "betawiki" might be something to steal, or "betaenv" if you want something new) [21:27:34] <sumanah> robla: as of right now our CREDITS file is 192 lines https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/CREDITS?view=markup .. on July 1st 2011 it was at 166 lines https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/CREDITS?revision=91263&view=markup [21:27:47] <robla> anyway, I don't want to bikeshed too much more...just want to keep from really getting confused by using the word "deployment" to mean "this test site over here" [21:29:06] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108851> 10/trunk/phase3/ (2 files in 2 dirs): Add 'api-error-unknownerror' and update punctuation and quotes for api-error-* where needed. [21:29:41] <robla> sumanah: there are so many people that aren't in that CREDITS file that I'd consider that a pretty dubious metric right now [21:30:01] <sumanah> robla: is that so? blah. [21:30:35] <robla> well, we have 70 "developers", yet 200 or so with commit access [21:30:46] <codurr> New code comment: Nikerabbit; maintenance/language/messages.inc needs updating too.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108850#c29499> [21:30:46] <hexmode> robla: bikeshed is painted. I'm getting them to update DNS now [21:30:50] <sumanah> bsitu, rmoen -- if you need suggestions on patches to take on next, please let me know, but those links I gave you in email should be helpful [21:31:18] <Reedy> hexmode, is it blue? [21:31:38] <sumanah> he's from TL;DR so it is the colour of a teal deer [21:31:40] <hexmode> robla: dubious or not, some people may use it for a resume reference [21:32:00] <sumanah> hexmode: well, false positives aren't the problem here, false negatives are, I think [21:32:21] <rmoen> sumanah: Thanks :) [21:32:25] <robla> yeah, I think it's a good todo item to actually make that list more complete [21:32:50] <sumanah> by looking through commit summaries or something? hmmm. [21:33:00] * sumanah adds to her TODO list [21:33:02] <codurr> New code comment: Siebrand; Recommending revert. This is a feature that should only be implemented after 1.19 has been branched.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108850#c29500> [21:33:11] <hexmode> sumanah: Just saying I did see one person complain when their name was (inadvetently?) removed [21:33:27] <sumanah> ah. [21:34:31] <codurr> New code comment: Siebrand; There are two messages that need to be added in the ignored array of messageTypes.inc, too: 'tag-fil; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108850#c29501> [21:36:12] <robla> rmoen: bsitu: sumanah: got a sec to talk about 20% stuff? [21:36:17] <sumanah> yup [21:36:42] <robla> actually, hexmode as well [21:36:50] <hexmode> deployment is now beta [21:36:56] <hexmode> robla: sure [21:36:57] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108852> 10/trunk/extensions/AbuseFilter/api/ (4 files): Fix action= examples from r95572, need abusefilter prefix [21:37:14] * Reedy throws things at johnduhart  [21:37:19] <robla> I think we've given conflicting advice on what to do now, and it might be good to have a quick 10 min phone call or something to sort it out [21:38:05] <sumanah> ok, robla, I can do that now [21:38:23] <robla> lemme walk over to talk to rmoen and bsitu...brb [21:40:32] <AaronSchulz> johnduhart: $log_type is not always defined in apicheckuser [21:40:38] <AaronSchulz> 'if ( IP::isIPAddress( $target ) && isset( $xff ) ) {' [21:42:37] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108853> 10/trunk/phase3/includes/api/ApiFormatBase.php: [21:42:37] <codurr> () are valid in URLs, not sure why we're using them as a finishing point in ApiFormatBase [21:42:37] <codurr> Fixes fixme on r95572 as urls are now complete with () in them [21:43:24] <Reedy> AaronSchulz, eh? [21:43:42] <Reedy> I see it 6 lines furhter down... [21:43:50] <Reedy> it's done in the if, the elseif and in the else... [21:44:42] <AaronSchulz> are you on the wrong line [21:44:55] <AaronSchulz> there are two lines like the one I posted [21:45:03] <Reedy> oh [21:45:14] <Reedy> yes then :p [21:45:45] <Reedy> AaronSchulz, might be easier to comment on the rev and fixme [21:45:48] <Reedy> He seems ot be afk [21:46:01] <AaronSchulz> I don't know what rev it was [21:46:35] <Reedy> hmm [21:46:43] <Ashex> Kinda random, when talking about urls does going up a level been /wiki to /wiki/foo or is it vice versa? [21:46:50] <Reedy> Looking at doIPUsersRequest... [21:46:51] <Ashex> s/been/mean [21:47:01] <Reedy> AaronSchulz, I'll fix it [21:47:15] <Nikerabbit> Reedy: 18 to go, can we make it? [21:47:21] <wikibugs> 04(REOPENED) Inline rendering/thumbnailing for Gimp XCF images - 10https://bugzilla.wikimedia.org/17959 +comment (10Mark A. Hershberger) [21:48:08] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108854> 10/trunk/extensions/CheckUser/api/ApiQueryCheckUser.php: (log message trimmed) [21:48:08] <codurr> Fix missing log_type [21:48:08] <codurr> Worked out from the code in doIPUsersRequest [21:48:08] <codurr> <pre> [21:48:08] <codurr> $logType = 'ipusers'; [21:48:08] <codurr> if ( $xfor ) { [21:48:09] <codurr> $logType .= '-xff'; [21:49:11] <AaronSchulz> sounds right [21:50:20] <codurr> 03nikerabbit * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108855> 10/trunk/phase3/includes/Revision.php: @since, ping r101030 [21:51:26] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108856> 10/trunk/extensions/CheckUser/api/ApiQueryCheckUser.php: Refactored some code (reducing duplication) [21:51:56] <codurr> New code comment: Aaron Schulz; $wgDebugToolbar should have a path-disclosure comment in DefaultSettings.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105123#c29502> [21:52:46] <codurr> New code comment: Reedy; Follows up where it was added in r100165; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108854#c29504> [21:53:03] <sumanah> hi mBlueSky [21:53:17] <mBlueSky> hi sumanah [21:53:41] <AaronSchulz> Reedy: $log_type[] = 'ipeditsxff'; [21:53:45] <AaronSchulz> were did the dash go? [21:54:41] <sumanah> hey bsitu, ready for a patch? :-) https://bugzilla.wikimedia.org/show_bug.cgi?id=33703 [21:54:55] <sumanah> bsitu: not just a one-liner, a one-worder! [21:56:02] <AaronSchulz> I see the old code had $log_type = 'ipusersxff'; sprinkled in too [21:56:04] * AaronSchulz sighs [21:56:24] <bsitu> yes, thank you [21:56:50] <AaronSchulz> should be -xff [21:58:07] <codurr> 03rmoen * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108857> 10/trunk/phase3/ (8 files in 5 dirs): reverted r108850 as patch should be introduced after code freeze [21:58:09] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108858> 10/trunk/extensions/Translate/Translate.php: Add two more messages for use in JavaScript. [21:59:01] <codurr> New code comment: Hashar; back to "new". Aaron can you look at my comment just above?; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101030#c29505> [21:59:18] <hashar> AaronSchulz: can you look at r101030 ^^ ? :) [21:59:34] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108859> 10/trunk/extensions/CheckUser/ (CheckUser_body.php api/ApiQueryCheckUser.php): [21:59:34] <codurr> Fix eaten hyphen from r108856 [21:59:34] <codurr> Quote timestamp (ping r100165) [21:59:34] <codurr> Remove unused variable [22:00:07] <AaronSchulz> '//$xff = $row->cuc_xff;" [22:00:08] <AaronSchulz> why not just delete it? [22:01:16] <codurr> New code comment: Nikerabbit; I think it's followup to comments in r100286.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101030#c29506> [22:01:22] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108860> 10/trunk/extensions/CheckUser/api/ApiQueryCheckUser.php: [22:01:22] <codurr> intval NS from r100165 [22:01:22] <codurr> Fix PARAM_MAX value per Roan [22:02:01] <codurr> New code comment: Siebrand; This change was not addressed in the commit summary. \ <pre> \ - $xff = $row->cuc_xff; \ + //$xff; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108859#c29507> [22:02:47] <codurr> New code comment: Siebrand; Oh, it was... Too much whitespace in your commit summary :).; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108859#c29508> [22:02:47] <codurr> New code comment: Reedy; Bah. That was supposed to be removed, not commented out; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108859#c29509> [22:03:02] <codurr> New code comment: Reedy; Marking new... I think everything is dealt with now. I dealt with a few left over things, and checki; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/100165#c29510> [22:03:04] <codurr> 03aaron * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108861> 10/trunk/extensions/CheckUser/api/ApiQueryCheckUser.php: [22:03:04] <codurr> * Fix another missing hypen (broken since api was added most likely) [22:03:04] <codurr> * Removed commented out code [22:03:16] <codurr> New code comment: Reedy; And I just marked it new again. Bad CR!; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108859#c29511> [22:03:49] <sumanah> hexmode, robla: a few links sent to Benny & Rob [22:03:58] <sumanah> robla: thanks for pulling that chat together [22:03:58] <robla> excellent, thanks! [22:04:10] <Reedy> 171 for 35 [22:04:21] <sumanah> robla: do you have enough stats for the moment? I need to pull together & send a survey to the hackathon participants for next week [22:04:37] <robla> yup, I do. thank you very much! [22:06:11] <robla> Reedy: that's awesome [22:06:24] * johnduhart throws things back at Reedy [22:06:45] <wikibugs> 04(REOPENED) Add a drop-down list for the tags in Recentchanges and Newpages - 10https://bugzilla.wikimedia.org/25909 +comment (10Rob Moen) [22:06:53] <Reedy> johnduhart, most of your fixmes fixed :p [22:07:04] <johnduhart> Oh, thank you [22:07:13] <Reedy> 1 to go [22:07:23] <Reedy> Which roan is saying to call methods that dont exist :D [22:07:43] <robla> we're below our previous low of 254 new revs in trunk on 2011-08-24 [22:08:16] <sumanah> :D [22:08:31] <codurr> New code comment: Aaron Schulz; What's this about?; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101030#c29513> [22:09:17] <codurr> 03hashar * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108862> 10/trunk/phase3/includes/media/XCF.php: [22:09:17] <codurr> XCF: force rendering [22:09:17] <codurr> Browsers do not support GIMP native format (yet?!). So we really need [22:09:17] <codurr> to force rendering. [22:09:17] <codurr> Noticed by Mark while testing the feature on labs. [22:09:22] <codurr> Follow r107351 [22:09:27] <sumanah> btw robla, varnent's extensions dev workshop was evidently pretty useful; maybe 8 ext devs showed up? and they all were glad to have it [22:09:30] <sumanah> thanks varnent [22:09:41] <robla> excellent! [22:10:16] <codurr> New code comment: Reedy; Can you elabourate when the blood stops rushing to your head from you being upside down? \ addModuleS; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/98500#c29514> [22:10:19] <codurr> 03raindrift * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108863> 10/trunk/extensions/ (16 files in 9 dirs): moved ConcurrencyCheck code into its own extension [22:11:24] <Reedy> siebrand, should we fix the fixme on r39787? :p [22:12:49] <Ashex> Making some more changes to the wiki family page and got a question. There's a reference to Admin_Settings.php [22:13:30] <Reedy> That's oooold [22:13:33] <Ashex> Er, AdminSettings.php, I would assume it's safe to remove this reference from the page since it's gone [22:13:35] <Reedy> Phased out in 1.17 maybe? [22:13:39] <Reedy> Yup [22:13:50] <Ashex> Okay, just wanted to check [22:14:16] <codurr> New code comment: Siebrand; Please add basic documentation at https://www.mediawiki.org/wiki/Extension:InterfaceConcurrency; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108863#c29515> [22:14:33] <wikibugs> 03(WONTFIX) Branching forms - 10https://bugzilla.wikimedia.org/30536 +comment (10Yaron Koren) [22:16:16] <codurr> New code comment: Hashar; Clarified on IRC. Thanks Aaron!; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101030#c29516> [22:17:08] <wikibugs> 03(mod) File upload not working right with multiple-instance templates. - 10https://bugzilla.wikimedia.org/31343 +comment (10yaron57) [22:17:43] <codurr> 03siebrand * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108864> 10/trunk/extensions/InterfaceConcurrency/ (7 files in 3 dirs): [22:17:44] <codurr> stylize.php and some minor identation and whitespace updates. [22:17:44] <codurr> L10n update [22:18:01] <codurr> New code comment: Hashar; Demo http://commons.wikimedia.beta.wmflabs.org/wiki/File:Tmp4.xcf; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108862#c29517> [22:19:07] <codurr> 03mrbluesky * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108865> 10/trunk/phase3/includes/HTMLForm.php: [22:19:07] <codurr> Fixing comments [22:19:07] <codurr> Using shell style comments here stops Doxygen from processing the rest of the comments. [22:19:07] <codurr> See http://svn.wikimedia.org/doc/classHTMLForm.html [22:23:56] <wikibugs> 03(mod) ResourceLoader should work around IE's limit on number of <style> tags - 10https://bugzilla.wikimedia.org/31676 +comment (10Krinkle) [22:24:31] <codurr> New code comment: Nikerabbit; <pre>+ * @param $file</pre> \ Really? Is that useful.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108862#c29518> [22:24:58] <Reedy> 165/35 [22:25:00] <Reedy> 200! [22:25:25] <Nikerabbit> Reedy: brilliant! [22:25:51] <Reedy> I wonder which other fixmes we can fix [22:26:10] <Nikerabbit> I haven't even looked at those yet :/ [22:26:34] <Reedy> 9 are phase3 [22:26:58] <Reedy> 5 or so in extensions that we care about [22:27:23] <codurr> 03bsitu * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108866> 10/trunk/phase3/skins/common/shared.css: patch from fomafix - bug33703 - remove black border-bottom-color for abbr [22:28:01] <codurr> New code comment: Reedy; Which has been reverted. (Commenting for completeness, wasn't sure why it had been re-marked as fixm; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105855#c29519> [22:29:11] <wikibugs> 03(mod) remove black border-bottom-color for abbr - 10https://bugzilla.wikimedia.org/33703 (10bsitu) [22:31:06] <Nikerabbit> Reedy: and one of them is mine [22:35:18] <Reedy> suspect we can get 150 [22:36:23] <sumanah> wheee [22:39:01] <codurr> New code comment: Reedy; <pre> \ + $dbr->freeResult( $resultEdits ); \ </pre> \ That's deprecated so no point adding that now; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108602#c29521> [22:39:35] <Nikerabbit> looks like everyone is in SF next week [22:39:50] <Reedy> not quite everyone [22:40:22] <Reedy> I wonder if we should revert 108602 [22:40:22] <Reedy> doing a load of sql queries to fix a minor issue seems silly [22:40:54] <Nikerabbit> shouldn't be too hard to make it do a batch query [22:41:16] <codurr> New code comment: Krinkle; On a German wiki, most sections will be in German. Just make sure we've tested this language change,; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105855#c29522> [22:41:53] <wikibugs> 06(LATER) Text box showing over search bar looks horrible - 10https://bugzilla.wikimedia.org/33202 +comment (10Phil Chang) [22:42:14] <wikibugs> 03(mod) Common border-bottom color for <abbr> should inherit default (text) color - 10https://bugzilla.wikimedia.org/33703 summary (10Krinkle) [22:42:46] <codurr> New code comment: Krinkle; Thanks! Do you mind adding release-notes for this ?; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108866#c29523> [22:42:50] <sumanah> bsitu: hey, got a moment? a preference question re what wiki name you'd like -- I know it's Bsitu on mediawiki.org but is that what you want on labsconsole? [22:43:21] <Krinkle> bsitu: Can you add "(bug 33703) Common border-bottom color for <abbr> should inherit default (text) color" to RELEASE-NOTES under Bugs fixed section ? [22:43:22] <wikibugs> 03(FIXED) Fix Wikipedia icon in Android app - 10https://bugzilla.wikimedia.org/33013 (10Phil Chang) [22:43:36] <bsitu> sumanah: yes, bsitu is fine [22:43:39] <sumanah> great, thx [22:43:43] <Krinkle> Try to make that a habbit in the same commit whenever a bug is fixed (unless it was a regression fix within the same versoin) [22:43:51] <bsitu> Krinkle: I will, thx [22:44:51] <wikibugs> 03(mod) It's impossible to type Hebrew characters in the search box until some Latin characters were typed - 10https://bugzilla.wikimedia.org/33518 +comment (10philinje) [22:45:29] <Krinkle> You may want to change the bug summary for the release notes. The format explaining the problem is preferred so that there is no confusion about what the bug is. For example a bug named "Remove abbr border-bottom black" is ambiguous and should be changed to something like "<abbr> border-bottom color should not be hard coded" [22:45:31] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108867> 10/trunk/extensions/Nuke/Nuke_body.php: [22:45:31] <codurr> Minor stylistic changes [22:45:31] <codurr> Don't attempt to return values returned by void methods [22:45:31] <codurr> Kill freeResult [22:45:31] <codurr> Minor documentation [22:45:33] <Krinkle> bsitu: ^ [22:46:21] <sumanah> hey Ryan_Lane I have a problem when I try to add a labs user; PM? [22:46:38] <Ryan_Lane> sure. gimme a little bit, though [22:46:41] <Ryan_Lane> I need to eat [22:46:43] <Ryan_Lane> badly [22:46:47] <sumanah> ok [22:47:32] <Nikerabbit> Reedy: title in lower case? tsk tsk [22:47:36] <siebrand> hexmode: you have a page somewhere where you add to-be-reviewed-and-fixed revisions based on tags. Which is that again? [22:47:44] <Reedy> Lol [22:47:47] <codurr> New code comment: Krinkle; Removing a preference is, although justified, a significant change. Please add release notes!; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107187#c29524> [22:48:06] <codurr> 03rmoen * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108868> 10/trunk/extensions/InterfaceConcurrency/ (5 files in 3 dirs): added js resources for checking in / out resources via concurrency api. loaded the hooks class [22:48:10] <sumanah> siebrand: the revision report? https://www.mediawiki.org/wiki/MediaWiki_roadmap/1.19/Revision_report ? [22:48:25] <codurr> 03bsitu * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108869> 10/trunk/phase3/RELEASE-NOTES-1.19: Add bug33703 fix to 1.19 release note [22:48:28] <wikibugs> 03(mod) "cols" preference is redundant and should be removed - 10https://bugzilla.wikimedia.org/24430 summary (10Krinkle) [22:48:34] <siebrand> sumanah: ty! [22:48:40] <sumanah> yw [22:49:24] <Krinkle> bsitu: Also, don't forget that CAPITAL-FILES should always beak lines between 80-90 characters. [22:49:46] <Krinkle> the one you committed is good, I'm just saying in advance :) [22:50:00] <bsitu> :) [22:50:23] <bsitu> thx for the reminder [22:50:34] <Krinkle> bsitu: One more tiny thing if you don't mind, add the revision number to which this is a follow-up in the commit message so that it is automatically linked [22:51:14] <Krinkle> that way it is added to this: https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107187#code-references [22:51:17] <Krinkle> I've added it manually now [22:51:56] <bsitu> okay [22:52:47] <sumanah> Krinkle: all this is somewhere in a guide, right? [22:52:54] <sumanah> Krinkle: a Subversion usage guide or something? [22:53:11] <Krinkle> eh.. I'm hoping it's in it already, just badly described or somewhere in a dupe page [22:53:57] <wikibugs> 03(mod) It's impossible to type Hebrew characters in the search box until some Latin characters were typed - 10https://bugzilla.wikimedia.org/33518 +comment (10amir.aharoni) [22:54:46] <codurr> New code comment: Siebrand; Ping?; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/64543#c29525> [22:56:01] <codurr> New code comment: Siebrand; Argh. Please ignore. I looked at an old version...; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/64543#c29526> [22:56:26] <Reedy> Nikerabbit, we should probably revert it for 1.19 unless you want to fix it [22:56:47] <Nikerabbit> Reedy: revert then [22:57:24] <wikibugs> 03(NEW) Show "previous" revisions in addition to follow-ups - 10https://bugzilla.wikimedia.org/33713 normal; MediaWiki extensions: CodeReview; (krinklemail) [22:57:58] <Krinkle> bsitu: Do you have e-mail notifications enabled for mw.org ? [22:58:18] <Reedy> Krinkle, there's an functions to add followups to and to add followups from already coded IIRC [22:58:44] <codurr> 03bsitu * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108870> 10/trunk/phase3/RELEASE-NOTES-1.19: followup to -r107187 - adding bug24430 patch to 1.19 release note [22:58:44] <bsitu> yes [22:58:51] <Ashex> Updated the wiki family page again, if someone can look and approve the edit I would appreciate it [22:59:18] <Krinkle> bsitu: OK :) [22:59:45] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108871> 10/trunk/extensions/Nuke/ (Nuke.php Nuke_body.php): [22:59:45] <codurr> Revert most of r108602 [22:59:45] <codurr> For such a minor cosmetic fix, having to do a query per result row is just daft [23:03:21] <codurr> 03bsitu * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108872> 10/trunk/extensions/MoodBar/MoodBar.hooks.php: remove unnecessary code from MoodBar hooks file [23:05:56] <Reedy> 147/35 [23:07:42] <Nikerabbit> aww [23:07:56] <Nikerabbit> we are getting to the point of diminishing returns? [23:08:16] <codurr> New code comment: Hashar; Some tests added with r108873; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107954#c29527> [23:08:20] <codurr> 03hashar * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108873> 10/trunk/phase3/ (3 files in 2 dirs): [23:08:20] <codurr> some tests for MWDebug [23:08:20] <codurr> Really incomplete. We need better testing. [23:08:20] <codurr> Added two new public methods so we can get or clear the internal logs. [23:08:31] <codurr> New code comment: Siebrand; Changed status to deferred. Extension has been renamed to HelpCommons in r104438.; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/104338#c29528> [23:08:44] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108874> 10/trunk/lucene-search-2/src/org/wikimedia/lsearch/config/Configuration.java: Fix simple fixme on r107775 [23:10:27] <codurr> 03hashar * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108875> 10/trunk/phase3/includes/debug/Debug.php: [23:10:27] <codurr> MWDebug: avoid double count() [23:10:27] <codurr> Follow r107954 [23:11:16] <codurr> New code comment: Dantman; Very late... Linker.php has always hinted that one day it was intended to be split from Skin complet; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/85244#c29529> [23:13:28] <pokeswap> how do i stop the error (require:function) when ever i try to add something to localsettings.php [23:13:46] <codurr> New code comment: Aaron Schulz; The performance effect will simply be that of the overhead of calling a function...the count is trac; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108875#c29530> [23:14:34] <codurr> 03reedy * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108876> 10/trunk/phase3/includes/api/ApiEditPage.php: Rather than using an error code of unknownerror, use the error code returned by EditPage if it's a string, and it has length, else just return the usual "unknownerror" [23:14:36] <mw-jenkinsbot> Project MediaWiki-phpunit build #5656: FAILURE in 3 min 24 sec: http://integration.mediawiki.org/ci/job/MediaWiki-phpunit/5656/ [23:14:50] <mw-jenkinsbot> Project MediaWiki-postgres-phpunit build #99: FAILURE in 3 min 36 sec: http://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/99/ [23:14:54] <sumanah> so, bsitu, for https://bugzilla.wikimedia.org/show_bug.cgi?id=13780 , as you've seen, the patch is now obsolete because the file it was patching doesn't exist anymore. Is the bug still reproducible? [23:15:01] <codurr> New code comment: Krinkle; Wohoo!; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108876#c29531> [23:15:07] <Krinkle> Nikerabbit: siebrand ^ [23:16:19] <bsitu> sumanah: I haven't tried, let me see [23:16:34] <sumanah> bsitu: if the bug is no longer reproducible then you thank the author for his/her patch, say you're sorry it's taken so long to get around to reviewing it, and then close the bug as WORKSFORME because the relevant behavior now works for you [23:17:37] <pokeswap> when i tryed (spyinginc.com/wiki) showed up - go there to c [23:18:01] <robla> rmoen: I think you should be set up on Gerrit & Labs now [23:18:21] <sumanah> bsitu: if the bug is still reproducible, then you thank the author for his/her patch, say you're sorry it's taken so long to get around to reviewing it, and say that the patch is now obsolete because $reason (for example, the file it modifies is no longer around) and suggest that if they have the time and the interest, we'd like for them to revise their patch to work with current trunk [23:18:21] <Reedy> pokeswap, you don't want :, you want ; [23:19:15] <sumanah> bsitu: if you look at their patch and it seems way off and not in good coding style, you also point them to https://www.mediawiki.org/wiki/Coding_conventions and you tell them that before rewriting the patch they should come into IRC (link to https://www.mediawiki.org/wiki/MediaWiki_on_IRC ) and talk about approach [23:19:16] <rmoen> robla: thanks [23:19:49] <mw-jenkinsbot> Project MediaWiki-phpunit build #5657: STILL FAILING in 3 min 26 sec: http://integration.mediawiki.org/ci/job/MediaWiki-phpunit/5657/ [23:20:21] <Reedy> hashar, ^ [23:20:25] <mw-jenkinsbot> Project MediaWiki-postgres-phpunit build #100: STILL FAILING in 4 min 2 sec: http://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/100/ [23:20:42] <AaronSchulz> now we have two fail builds! [23:20:47] <hashar> Reedy: were you referring to jenkins build failing or something else? [23:20:56] <Reedy> jenkins [23:21:12] <siebrand> 147/31 [23:21:47] * siebrand hopes robla looks a little happier by now... [23:22:06] <robla> much happier [23:22:10] <robla> that's really fantastic [23:22:22] <bsitu> sumanah: sorry, the file does exist and it's in an extension [23:22:22] <hashar> hehe assertCount does not exist on gallium :) [23:22:40] <siebrand> well behind on fix me, though. [23:22:48] <siebrand> shiploads to be reverted… ? [23:23:29] <hashar> Reedy: I am adding them to the Broken group [23:24:01] <codurr> New code comment: Reedy; 'selectionsifter-desc' isn't defined in your i18n file either!; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105769#c29532> [23:24:18] <sumanah> bsitu: ok, so are you on your way, or do you need any more advice? I can give more guidance [23:24:31] <wikibugs> 14(WFM) CategoryTree: Retry link in AJAX error message doesn't work - 10https://bugzilla.wikimedia.org/17782 +comment (10Rob Moen) [23:24:56] <Reedy> 13 fixmes we sorta care about [23:25:37] <sumanah> rmoen: do you need more obsolete patches to look at? :-) [23:25:52] <sumanah> (your help is very welcome) [23:26:04] <rmoen> sumanah: sure [23:26:07] <Reedy> siebrand, any ideas how to fix 39787? [23:26:13] <bsitu> sumanah: I will install the extension and see if the patch works [23:26:27] <sumanah> great, thanks bsitu [23:26:31] <sumanah> bsitu: and see whether the bug is still reproducible :-) [23:26:31] <codurr> 03hashar * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108877> 10/trunk/phase3/tests/phpunit/includes/debug/MWDebugTest.php: [23:26:32] <codurr> Disable MWDebug tests for now [23:26:32] <codurr> PHPUnit is too old on gallium so assertCount() is not recognized [23:26:32] <codurr> The other two tests are broken for an unknown reason. [23:29:47] <Nikerabbit> is reviewed state broken in http://toolserver.org/~robla/crstats/ ? [23:29:52] * robla looks [23:29:52] <hashar> Reedy: I am sleeping right now. Hopefully jenkins should be happy again [23:30:25] <sumanah> rmoen: I'm looking for ones that are neither about the parser nor hugely controversial, it's taking me a moment [23:30:25] <Reedy> hashar, you can sleep type? [23:30:41] <hashar> I am in bed almost sleeping already :b [23:30:41] <hashar> so yeah I can! [23:30:41] <robla> Nikerabbit: I changed it to "newly reviewed" earlier today. try shift-reloading the page [23:30:43] <sumanah> oh heck, rmoen, take a look at https://bugzilla.wikimedia.org/show_bug.cgi?id=6833 [23:31:31] <codurr> 03aaron * <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108878> 10/trunk/phase3/ (11 files in 3 dirs): (log message trimmed) [23:31:31] <codurr> In FileBackend: [23:31:31] <codurr> * Made secure() call doPrepare() for caller dummy proofing (especially those that don't check the status). [23:31:31] <codurr> In FSFileBackend: [23:31:31] <codurr> * Removed redundant wfMkdirParents() calls in FSFileBackend, we already have prepare() for this purpose. This also keeps it's behavior more consistent with the other backends. [23:31:31] <codurr> * Made use of 'backend-fail-store' message in doStoreInternal(). [23:31:31] <codurr> Other: [23:31:31] <rmoen> sumanah: ok [23:31:31] <sumanah> rmoen: I believe it doesn't apply to trunk anymore, and you can add a note saying that gwicke would like for this person to join wikitext-l and join in the parser rewrite :-) [23:32:18] <wikibugs> 04(REOPENED) Special:Nuke shows always "1 edit" - 10https://bugzilla.wikimedia.org/16985 +comment (10Sam Reed (reedy)) [23:32:18] <wikibugs> 03(NEW) Update PHPUnit on gallium - 10https://bugzilla.wikimedia.org/33714 normal; Wikimedia: Testing Infrastructure; (hashar) [23:32:40] <wikibugs> 03(mod) Update PHPUnit on gallium - 10https://bugzilla.wikimedia.org/33714 +platformeng (10Antoine "hashar" Musso) [23:32:41] <hashar> this is me dreaming [23:32:41] <gwicke> rmoen: which patch is this about? [23:32:41] <Krinkle> OK. Last try, anyone here who has IE9 in the swarm or Epiphany ? [23:33:05] <rmoen> gwicke: don't really know yet, looking [23:33:16] <mw-jenkinsbot> Yippie, build fixed! [23:33:16] <mw-jenkinsbot> Project MediaWiki-phpunit build #5658: FIXED in 3 min 46 sec: http://integration.mediawiki.org/ci/job/MediaWiki-phpunit/5658/ [23:33:32] <gwicke> k, sumanah? [23:33:37] <AaronSchulz> "in the swarm"? [23:34:29] <sumanah> gwicke: https://bugzilla.wikimedia.org/show_bug.cgi?id=6833 [23:34:30] <Krinkle> Epiphany: Please leave the swarm, IE9: There is an OS issue causing exceptions when text selection is manipulated, fix the computer but both of these are polluting the swarm [23:34:31] <Krinkle> Reedy: brion: siebrand: any of you ? [23:34:31] <mw-jenkinsbot> Yippie, build fixed! [23:34:31] <mw-jenkinsbot> Project MediaWiki-postgres-phpunit build #101: FIXED in 4 min 23 sec: http://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/101/ [23:34:33] <Reedy> I've nothing in the swarm [23:34:33] <brion> wot [23:34:33] <Reedy> lol [23:34:34] <gwicke> sumanah: thanks, looking.. [23:34:37] <rmoen> brion: wide open throttle = wot ? [23:34:37] <Krinkle> http://integration.mediawiki.org/testswarm/user/mediawiki [23:34:37] <brion> i might have an ie9 in the swarm, unless it shut down again [23:34:54] <AaronSchulz> hashar: I want to kill the ParserTest::setUp() call in ParserOptionsTest [23:34:57] <Krinkle> !testswarm | AaronSchulz [23:34:57] <mw-bot> AaronSchulz: http://integration.mediawiki.org/testswarm/ | Automated distribution for trunk: http://integration.mediawiki.org/testswarm/user/mediawiki [23:35:00] <brion> need to put more ram in my desktop and get those running more regularly [23:35:03] <Krinkle> brion: The ie9 one in the swarm is systematically failing this module: http://integration.mediawiki.org/testswarm/?state=runresults&run_id=14946&client_id=5099 [23:35:18] <sumanah> brion: or we need to have a cloudly solution or something [23:35:18] <Krinkle> brion: my own IE9 doesn't do that [23:35:45] <brion> well it's probably failing due to out of memory or some shit [23:35:45] <sumanah> brion: so that individual developers' desktops don't overheat in the glory of testing [23:35:46] <brion> ya [23:36:12] <hashar> AaronSchulz: go ahead. I can't look at it right now :b [23:36:22] <hashar> AaronSchulz: we can talk about it monday morning (your time) if you want [23:36:39] * AaronSchulz will shoot first, ask questions later [23:37:24] <sumanah> Ryan_Lane: you back from lunch? so I can fix my labs godmode issue? [23:37:31] <sumanah> (that is, I'd like to be able to give out labs accounts) [23:55:24] <pubsez> hello [23:55:36] <sumanah> hi pubsez [23:55:46] <codurr> New code comment: Krinkle; For the record, upstream repo is: \ * https://github.com/jaz303/tipsy/ \ Commits: \ * https://github.com/j; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108244#c29536> [23:56:13] <pubsez> sorry, I was having a problem with IRC :) [23:56:55] <wikibugs> 03(mod) Update jquery.tipsy plugin to latest version - 10https://bugzilla.wikimedia.org/33562 summary (10Krinkle) [23:57:12] <sumanah> it happens. [23:57:17] <wikibugs> 03(mod) Update jquery.tipsy plugin to latest version - 10https://bugzilla.wikimedia.org/33562 -upstream ; +comment (10Krinkle) [23:57:47] <sumanah> robla: do you have another test person I can create a labs account for? bsitu is now used up as a guinea pig. [23:58:21] <gwicke> sumanah: I could actually use one ;) [23:58:26] <robla> sold! [23:58:36] <sumanah> gwicke: ok! I will do this, then. What is your preferred wiki username? Gwicke/ [23:58:37] <sumanah> ? [23:58:42] <gwicke> gwicke [23:59:02] <sumanah> huzzah. Once Ryan_Lane has fixed my privileges, I shall attempt to give you a labs account. [23:59:11] <gwicke> cool, thanks! [23:59:16] <codurr> New code comment: Krinkle; ''this'' revision's issues are solved, but there is still a point unanswered. And that is that this ; <https://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c29537>