[00:00:39] robla: ok, I have a second guinea pig. Thanks for getting me to go through this process; it is uncovering some issues and fixing them. [00:00:49] no prob! [00:02:08] Stupid jenkins [00:02:10] deleting old tests [00:02:52] hi [00:03:13] hi westnordost [00:04:01] New code comment: Reedy; Grrr. Jenkins deletes old test results...; [00:04:15] I am trying to create a custom skin for the newest mw-version and it seems mw ignores my skin completely. Even if I put syntax errors in my SomeSkin.php, I get no error even though I set the skin in LocalSettings.php [00:04:36] Good news everybody: debian's oldstable (1.12) is getting killed off in about a fortnight [00:04:45] any clues what I am doing wrong? Manual:Skinning also seems to be a little bit older [00:04:58] they also pushed a updated stable (1.15.5) last night that has a fix for roan's api security bug [00:05:01] !debug [00:05:01] For information on debugging (including viewing errors), see http://www.mediawiki.org/wiki/Manual:How_to_debug [00:05:07] Lol [00:05:17] easy backport is easy [00:05:32] And my phpunit is broken again [00:05:39] hey gwicke, come into #wikimedia-labs for a moment? [00:05:52] sumanah: ok [00:05:52] also conincidently 1.12 isn't vul. to roan's bug either [00:06:25] westnordost: I'm guessing Reedy's debug msg was meant for you. [00:07:40] yes, I already enabled it, checking now [00:08:23] hm, no, no error message at all [00:09:05] (I just typed some dfafadsfaf into the SomeTemplate class) [00:09:35] Reedy: also do we know if debian does anything stupid in their pages, Since I forgot i sit in a irc channel with the packenger, I can probably poke and get these things fixed [00:09:53] s/pages/packages [00:09:55] how does the wiki system recognize new skins at all? It seems that I made something wrong at that point because my php is not executed at all it seems [00:10:08] * p858snake|l wonders if Dantman is around ^ [00:10:15] ... [00:10:30] Dantman: the skin thing, not the debian packages [00:11:01] skins are vodoo [00:11:09] and also voodoo [00:11:43] The list of skins has something like fooskin => FooSkin [00:11:58] May be added there by scanning skins/ for .php files [00:12:01] And formey is hanging [00:12:16] Skin tries to load a SkinFooSkin class [00:12:34] If the class is not in the autoloader it'll try to require a skins/SkinFooSkin.php file [00:12:36] the class has to be named Skin*Skin? [00:12:42] No... [00:12:46] Skin{SkinName} [00:12:58] ok, it is..hm [00:13:00] SkinMonoBook, SkinVector, SkinFoo [00:14:27] Project MediaWiki-phpunit build #5663: FAILURE in 3 min 17 sec: http://integration.mediawiki.org/ci/job/MediaWiki-phpunit/5663/ [00:14:50] Project MediaWiki-postgres-phpunit build #106: FAILURE in 3 min 40 sec: http://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/106/ [00:14:53] the odd thing is that I don't even get an error if I reference a non-existing $template in the Skin[MySkin] [00:17:45] New code comment: Reedy;

 \ phpunit: \ [exec] PHPUnit 3.5.15 by Sebastian Bergmann. \ [exec] \ [exec] .........; 
[00:18:32] 	 Krinkle: Yeah that seems wrong. Hmm.
[00:19:40] 	 ah, I get an error if I additionally turn display_startup_errors on
[00:20:18] 	 hm, now not anymore... is there a cache or something?
[00:20:32] 	 (well, probably my own)
[00:23:03] * Dantman  kicks svn
[00:24:00] 	 yeah - it's hiccuping - http://svn.wikimedia.org/doc
[00:25:38] 	 03reedy *  10/trunk/phase3/includes/Linker.php: Revert out r108882
[00:26:51] 	 what causes error "Node-count limit exceeded" in the middle of a page?
[00:27:10] 	 03(mod) Branching forms - 10https://bugzilla.wikimedia.org/30536  +comment (10fastgoldfish)
[00:27:23] 	 malafaya, too complex a page
[00:27:27] 	 loads of parser functions etc
[00:27:40] 	 I see
[00:27:53] 	 03petrb *  10/trunk/tools/wmib/ (DumpHtm.cs Infobot.cs): removed whitespace on | nick
[00:28:06] 	 something killed it
[00:28:11] 	 i'll have to split it then. thanks
[00:28:15] 	 have I mentioned that I hate viewvc?
[00:28:27] 	 heh
[00:28:40] 	 I see you did the deb at 1.1.7... The site says 1.1.8..
[00:29:03] 	 hmm
[00:29:09] 	 it's 1.0.9
[00:29:30] 	 on ubuntu package
[00:29:38] * Reedy  logs an RT ticket
[00:29:42] 	 03(mod) [SF] Special:RunQuery error takes down pages using it - 10https://bugzilla.wikimedia.org/33424  +comment (10fastgoldfish)
[00:29:44] 	 Yippie, build fixed!
[00:29:44] 	 Project MediaWiki-phpunit build #5664: FIXED in 3 min 34 sec: http://integration.mediawiki.org/ci/job/MediaWiki-phpunit/5664/
[00:30:14] 	 Yippie, build fixed!
[00:30:14] 	 Project MediaWiki-postgres-phpunit build #107: FIXED in 4 min 3 sec: http://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/107/
[00:31:16] 	 New code comment: Johnduhart; Nice to know.; 
[00:33:01] 	 New code comment: Reedy; Amir, if you can confirm these new test results are what you want to happen, we can update the parse; 
[00:33:41] 	 03(mod) Some tables lack unique or primary keys, may allow confusing duplicate data - 10https://bugzilla.wikimedia.org/15441  +comment (10tim)
[00:35:44] 	 it seems I got it working, but I can't remember what I changed
[00:36:16] 	 New code comment: Krinkle; Afaik this is not needed. At least not for regression purposes. On several wikis gadgets were given ; 
[00:36:21] 	 the skin itself, at least. The main.css of the skin is not read still
[00:37:08] 	 westnordost: and this is why you use version control! :)
[00:37:50] 	 is $out->addModuleStyles( 'skins.openclonk' ); in the Skin[MySkin] class not enough to make mw load all CSS files inside the [myskin] directory?
[00:38:15] 	 oh well, given that my skin name is openclonk
[00:38:27] 	 No, that loads a RL module
[00:38:34] 	 You need to actually define the module
[00:38:41] 	 what does RL stand for?
[00:38:45] 	 ResourceLoader
[00:38:51] 	 !resourceloader
[00:38:51] 	 ResourceLoader is a JavaScript/CSS delivery system for MediaWiki, available in MediaWiki version 1.17 and later. See also , and , 
[00:39:05] 	 wow
[00:39:10] 	 a docs-bot
[00:39:36] 	 yeah, our little slave :) mw-bot is always ready to answer :)
[00:39:42] 	 westnordost: yup! you can /query it.
[00:40:07] 	 btw westnordost we also have in-person meetings https://www.mediawiki.org/wiki/MediaWiki_developer_meetings
[00:40:28] 	 westnordost: and we have IRC meetings about once a week about various topics - @MediaWikiMeet is an easy way to keep up
[00:40:54] 	 03krinkle *  10/trunk/phase3/skins/common/IEFixes.js:
[00:40:54] 	 [Core JS] Fix code from r107327 which was broken by r108222
[00:40:54] 	 -- Of course one most not assume the DOM is finished enough for #p-logo to be parsed, simply bind to document ready
[00:40:59] 	 westnordost: there will probably be a developers' meeting in person in Berlin in May
[00:41:22] 	 hmm, since I only need one CSS file, I guess $out->addStyle( 'openclonk/main.css' ); is thebetter solution for me
[00:41:36] 	 No...
[00:41:40] 	 and I'll just toss this at you too, westnordost - https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker
[00:41:46] 	 sumanah: well, I am just a mw user
[00:41:52] 	 ResourceLoader also adds a number of other things like RTL support
[00:42:14] 	 westnordost: if you ever want to turn into something more, we're here to help you learn
[00:42:22] 	 westnordost: Making a module isn't hard. Wanna try ? It's only a few lines in yourExtension.php file
[00:42:24] 	 an old skin I modified and used for my installation just broke with the new installation so I figured I will create a custom skin from scratch - if that breaks, I will at least know what to do
[00:43:04] 	 westnordost: Here's an example: http://www.mediawiki.org/wiki/Manual:$wgResourceModules#Examples
[00:43:23] 	 that's all. Then whenever you need it on a page call $out->addModules('ext.foo.bar')
[00:43:47] 	 ah, works!@$out->addStyle
[00:44:07] 	 With the @!?
[00:44:10] 	 westnordost: Yes, it works but is deprecated/discouraged/ineffecient
[00:44:31] 	 hmm, i only need a CSS, so a module is probably too much
[00:44:36] 	 No
[00:44:45] 	 You then get served minified CSS
[00:44:48] 	 RL does some neat things
[00:44:53] 	 hm
[00:45:03] 	 westnordost: nope a module means it can be loaded in parallel with all other modules. It's saving space, not making more
[00:45:13] 	 but I don't need JS, I don't have dependencies and... that other stuff
[00:45:20] 	 so leave off those keys
[00:45:30] 	 just styles and the directory path you're in
[00:45:32] 	 Krinkle: its not saving space in my code ;-)
[00:45:44] 	 php isn't sent to users ;p
[00:45:47] 	 westnordost: it saves space in the browser output, load time and execution time
[00:45:53] 	 in which path am I?
[00:46:19] 	 westnordost: Copy the example, adjust MyExtension to name of your extension directory
[00:46:57] 	 ok, 'Remove restrictions on restored revisions' totally broke for files
[00:47:07] 	 Krinkle: I don't have an extension directory
[00:47:09] 	 I just have a skin
[00:47:30] 	 Warning:  call_user_func_array() expects parameter 1 to be a valid callback, function 'DeleteLogFormatter' not found or invalid function name in D:\www\MW_trunk\phase3\includes\logging\LogPage.php on line 296

[00:47:33] 	 westnordost: Which is in an extension right ? Or did you put it in the core skins directory ?
[00:47:36] 	 Nikerabbit: ^
[00:47:49] 	 trying to revdelete an archived file version
[00:47:59] 	 Krinkle: I put it in /wiki/skins/
[00:48:27] 	 westnordost: okay, in that case add the three lines of $wgResourceModules to LocalSettings.php
[00:49:24] 	 sorry, I can't follow you - which three lines?
[00:49:35] 	 The module registration
[00:49:53] 	 'skins' => 'openclonk/main.css', 'remoteBasePath' => $wgStylePath, 'localBasePath' => $wgStyleDirectory,
[00:49:57] 	 so every skin is automatically a module?
[00:50:05] 	 the skins resources, yes.
[00:50:23] 	 03aaron *  10/trunk/phase3/includes/filerepo/FileRepo.php: Fixed annoying bug in FileRepo::deleteBatch() when a file is deleted that has multiple identical versions. The operation would fail due to the file already existing.
[00:50:41] 	 $wgResourceModules['skins. openclonk'] = array( ^ )
[00:51:26] 	 sumanah: if a patch has been reviewed but is not a viable solution, should the keywords be altered from 'need-review, patch' to something else ? 
[00:51:58] 	 rmoen: "patch" remains and you change "need-review" to "reviewed"
[00:52:04] 	 Krinkle: wouldn't it make sense to register that module in the skin itself? Since it is part of the skin, not part of my local settings?
[00:52:11] 	 sumanah: Thanks
[00:52:13] 	 rmoen: am I right in inferring that the bug is still reproducible?
[00:52:38] 	 sumanah: yes
[00:52:45] 	 137/30
[00:53:00] 	 westnordost: If you care about mobility/re-usability of a single drop-in directory to plug it into another wiki, then make it into an extension. Extensions have their own settings file, skins don't because they should be either part of core or an extension, not locally put into ./skins/
[00:53:00] 	 rmoen: cool, so you'll tell the patch author what needs changing and improvement, right?
[00:53:15] 	 westnordost: If you want to do it locally, then the settings should also be loca.
[00:53:50] 	 sumanah: yes
[00:53:51] 	 ah
[00:53:56] 	 great, thanks rmoen 
[00:55:29] 	 it's cool that we're at the lowest NEW+FIXME number since 2009
[00:55:36] 	 hmm, and why is the $out->addStyle( 'openclonk/main.css' ); solution deprecated? It seems very straightforward - I have a theme  and a style for that
[00:55:49] 	 Like we said...
[00:56:02] 	 Minification, @embed support, RTL support...
[00:56:09] 	 westnordost: Because adding a script tag for the styling of every single component makes a site slow
[00:56:11] 	 And it's more efficient
[00:56:12] 	 style*
[00:56:35] 	 mh okay
[00:56:55] 	 RL will also cache it properly and load it faster. It's 3 lines in your settings and replace the addStyle call with addModuleStyles
[00:58:03] 	 westnordost: Do you have a setupSkinUserCss function in your skin class ?
[00:58:22] 	 yes
[00:58:26] 	 03gwicke *  10/trunk/extensions/VisualEditor/ (7 files in 2 dirs):
[00:58:26] 	 First template expansion tests start working, and a bug fix in
[00:58:26] 	 DOMPostProcessor paragraph wrapper. 187 parser tests now passing.
[00:58:29] 	 westnordost: What's in it
[00:58:39] 	 currently?
[00:58:42] 	 yup
[00:58:51] 	 parent::setupSkinUserCss( $out ); and the mentioned addStyle
[00:59:18] 	 okay, so that's where out->addModuleStyles( 'skins.openclonk' ); would go instead
[00:59:23] 	 (keeping the parent:: call)
[01:00:00] 	 03(mod) Clickable tabs overlap - 10https://bugzilla.wikimedia.org/20234  -need-review +reviewed; +comment (10Rob Moen)
[01:00:24] 	 yes, I got it there... ok I think the adding the module in the LocalSettings.php would be the easier solution for me. I don't plan to use it in any other than this installation
[01:00:59] 	 03(mod) Admins don't see when page creations match against the blacklist - 10https://bugzilla.wikimedia.org/13780  (10bsitu)
[01:01:15] 	 03(mod) Admins don't see when page creations match against the blacklist - 10https://bugzilla.wikimedia.org/13780  (10bsitu)
[01:01:36] 	 oh, but it doesn't work
[01:02:01] 	 New code comment: Siebrand; {{messagedocumentation}}; 
[01:02:11] 	 westnordost: please paste the code added to LocalSettings.php and the line in that skin class function: http://pastebin.com/
[01:02:13] 	 thanks rmoen & bsitu, we're now down to 125 MW patches and 52 extensions-deployed patches that need review.
[01:02:53] 	 sumanah: morale +1  :)
[01:03:12] 	 yeah, rmoen! and just in time for your Friday drinks
[01:03:29] 	 Krinkle: http://pastebin.com/6FTPzVgU
[01:03:34] 	 sumanah: so true
[01:04:03] 	 westnordost: 'skins' should be 'styles'
[01:04:08] 	 line 3
[01:04:10] 	 line 4
[01:04:40] 	 ah
[01:04:48] 	 http://pastebin.com/PQ94NvjG
[01:05:15] 	 does anyone think it's terribly misleading to add MW 1.20 to https://www.mediawiki.org/wiki/Template:MWReleases ?  There's stuff that is going to be in it that we're postponing from 1.19
[01:06:18] 	 sumanah: 'stuff' ? there's bugs with milestone 1.20 if that's what you mean, but do they need notes/docs before implementation ?
[01:06:38] 	 Krinkle: hmm, the css is still not loaded
[01:06:58] 	 westnordost: Can I see the wiki ?
[01:07:13] 	 sure
[01:07:31] 	 ok, got the PM
[01:07:43] 	 I already found that by googling, but wasn't sure whether you were doing it live
[01:08:01] 	 ^^
[01:08:42] 	 westnordost: Warning:  filemtime() [function.filemtime]: stat failed for /openclonk/main.css in /is/htdocs/wp1144497_5BDDWAFPQY/wiki/includes/resourceloader/ResourceLoaderFileModule.php on line 380

[01:08:57] 	 where are you reading this warning?
[01:09:13] 	 http://wiki.openclonk.org/load.php?debug=true&modules=startup&only=scripts
[01:09:25] 	 03(mod) Special:Contributions - filter to show only the user's last edit to each page - 10https://bugzilla.wikimedia.org/33581  +comment (10smjg)
[01:10:06] 	 westnordost: I guess the path is off ? Are you sure it's in /skins ?
[01:10:09] 	 Krinkle: I figure that page is also for users/admins who want to know what's on the roadmap for 1.20.
[01:10:58] 	 its in /wiki/skins/openclonk/main.css
[01:11:31] 	 westnordost: Are you comfortable doing a var_dump in public ? var_dump($wgStylePath, $wgStyleDirectory);
[01:11:45] 	 I think you perhaps forgot to configure them both (one if the web path, the other is the internal path)
[01:12:19] 	 $wgStylePath and $wgStyleDirectory are not set anywhere in the LocalSettings.php
[01:12:25] 	 03(mod) Displaying alternate information in autocomplete dropdowns - 10https://bugzilla.wikimedia.org/32891  +comment (10fastgoldfish)
[01:12:51] 	 westnordost: isn't it in /w/skins ? Or /wiki/skins ?
[01:12:55] 	 or /wiki/w/skins ?
[01:13:05] 	  /wiki/ being the root of your subdomain
[01:13:15] 	 03(mod) Let AuthPlugin decide whether a specific user (name) can be auto created - 10https://bugzilla.wikimedia.org/23802  (10bsitu)
[01:13:25] 	 yes@root of subdomain
[01:13:44] 	 That explains why the old addStyle() was failing
[01:13:47] 	 also*
[01:13:51] 	 http://wiki.openclonk.org/skins/openclonk/main.css
[01:14:02] 	 yes, by default it was in /w/skins/
[01:14:18] 	 you can't just move directories without configuring them
[01:14:28] 	 why did you move it out of /w/ ?
[01:15:05] 	 Oh, I see. You've installed  mediawiki in the root directory
[01:15:08] 	 I don't remember moving anything, but I have to admit it has almost been two years since I set up that wiki
[01:15:25] 	 But you use /w/ as article path
[01:15:27] 	 erm.. 
[01:15:45] 	 I remember that it was suggested not to have the articles start on the root so I configured to have them in /w/
[01:16:00] 	 Yeah, that's fine
[01:16:04] 	 but I didn't read anything about that installing it in subdomain root would pose a problem
[01:17:36] 	 so basically I just have to set those two variables to the right values?
[01:17:47] 	 westnordost: remove the leading / in 'styles'
[01:18:09] 	 oh you don't have one
[01:18:18] 	 Krinkle: but I'll defer and leave it out, rather than editing the template.  Someone will add it when the time is ripe
[01:20:03] 	 westnordost: Ah, my bad.
[01:20:20] 	 Krinkle: btw, isn't it REALLY late where you are?
[01:20:47] 	 it's earlier than i went to bed yesterday ;)
[01:20:52] 	 it's weekend, am bored, and I switch timezones in weekends where I don't have appointments
[01:21:10] 	 so I get to spend time here and will sleep overlay 
[01:21:13] 	 over day
[01:21:38] 	 its just one hour later than Reedy 's though
[01:21:39] 	 :P
[01:21:49] 	 Krinkle: :-)  If you want to help varnent prepare documentation on ResourceLoader, I bet he would be grateful
[01:21:51] 	 i didn't go till 3.30am yesterday :p
[01:21:54] * AaronSchulz_  wonders why LocalFile::lock doesn't actually have FOR UPDATE
[01:21:55] 	 varnent: Krinkle is one of our RL experts
[01:21:58] 	 well that's useless
[01:22:40] 	 westnordost: you were right, you need to set those wgStyle variables
[01:22:42] 	 Krinkle: indeed - there was a lot of interest in RL during the workshop and I suspect the next one will likely be on that topic - but i think we'll want to spruce up its documentation a bit before that happens  :)
[01:23:04] 	 I tried to join but wasn't home yet, when I got home it was over
[01:23:16] 	 varnent: There is a video about ResourceLoader at https://commons.wikimedia.org/wiki/File:Low-hanging-fruit-vs-micro-optimization.theora.ogv and slides as well
[01:23:21] 	 Krinkle: I have to set them to the default?
[01:23:31] 	 varnent: Trevor Parscal and Roan Kattouw are giving a talk about it at linux.conf.au next week
[01:23:48] 	 varnent: so I am hoping that this leads to better dox as well
[01:24:00] 	 or better raw materials for docs!
[01:24:01] 	 westnordost: $wgStylePath = "$wgScriptPath/skins"; $wgStyleDirectory   = "$IP/skins";
[01:24:22] 	 excellent - yes - I think those would be good resources for docs - if they don't naturally lead to that
[01:24:22] 	 Krinkle: that is the default, isn't it?
[01:24:25] 	 varnent: also there will probably be interest at the San Francisco hackathon so that will lead to teaching, which will (I hope) lead to scribbled notes.
[01:24:36] 	 I mean, I am wondering - shouldnt the default be already set?
[01:24:43] 	 Yes, but those are set after LocalSettings.php so that if you change $wgScriptPath, the default will change
[01:24:47] 	 ok, I should go get a drink and a weekend :)
[01:24:48] 	 night all
[01:25:01] 	 Krinkle: aah, I see
[01:25:15] 	 westnordost: DefaultSettings.php > LocalSettings.php > Setup.php (which does 
[01:25:15] 	 if ( $wgStylePath === false ) $wgStylePath = "$wgScriptPath/skins"; )
[01:25:21] 	 so anything I set in the LocalSettings.php will be overwritten
[01:25:24] 	 k I see
[01:25:28] 	 No, not overridden
[01:25:48] 	 but since we're referring to it within Localsettings (which is unusual) we need to set them
[01:26:02] 	 sumanah: my hunch is the RL workshop will be sometime next month - probably like the 8th (ish?) - so a number of these things will have occurred that may either lead to documentation or resources for it  
[01:26:12] 	 hm
[01:26:15] 	 great, varnent 
[01:26:18] 	 bye!
[01:26:35] 	 American slackers!
[01:26:41] 	 Krinkle: perhaps we can connect at some point to chat about that - I think it'll require a bit more of a workshop format that we were able to get away with today  :)
[01:26:44] 	 westnordost: almost there :)
[01:26:48] 	 odd
[01:26:58] 	 varnent, you know that RL is probably one of the best documented things onwiki, right? ;)
[01:27:08] 	 why is the wgScriptPath includes/
[01:27:22] 	 it is ?
[01:27:33] 	 I don't believe that
[01:27:40] 	 Reedy: that's been my personal impression - I think it may just need some tutorials and further tweaking - as I read it you need to have at least a basic working knowledge of how it works to fully use all the docs
[01:28:05] 	 there seems to be a lot in various places - just maybe not connected in ways that helps a novice user of it
[01:28:22] 	 Krinkle: ah no, I read the error message wrong
[01:29:26] 	 westnordost: okay, I know it's a very minor typo somewhere. Could you paste the entire contents (short of your password) in the paste bin ?
[01:29:56] 	 wait, reload
[01:30:03] 	 I think you switched path and dir
[01:30:09]