[00:03:31] 03yonishostak * 10/trunk/extensions/ArticleFeedbackv5/ (6 files in 4 dirs): AFTv5: bugfixes, styles according to requirements [00:03:33] 03(ASSIGNED) The search box should lose focus when a Go action is performed. - 10https://bugzilla.wikimedia.org/33656 +comment (10Phil Chang) [00:03:33] 03(mod) Android App 1.1 release (tracking) - 10https://bugzilla.wikimedia.org/31805 (10Phil Chang) [00:06:31] New code comment: Johnduhart; If your module uses code from another module, declare it. :); [00:12:54] 03(WONTFIX) html entities are shown in summaries in the "nearby" map - 10https://bugzilla.wikimedia.org/33706 +comment (10Phil Chang) [00:18:41] Ryan_Lane: bugging you again about auto_auth :p [00:18:49] ok, what's up? [00:19:09] Should the extension disable the login/logout links? [00:19:35] well, apache is requiring auth before accessing the wiki, right? [00:19:43] in which case you can't logout [00:19:44] or login [00:19:52] so, yeah [00:19:53] And, if it's not updating the preference data for an existing account it should do it for new ones at least [00:20:02] Ok, because it's not :p [00:20:07] hm [00:20:10] I had to unset them manually in my settings file [00:20:17] I wonder if that's broken [00:20:31] The odd thing is if I remove the line that defined wgLDAPAutoAuthUsername it works [00:22:02] as in removes those links [00:22:23] 03(mod) Wikipedia Android App 1.1 release (tracking) - 10https://bugzilla.wikimedia.org/31805 summary (10Tomasz Finc) [00:22:59] 03(mod) Wikipedia Android App 2.0 release (tracking) - 10https://bugzilla.wikimedia.org/33856 summary (10Tomasz Finc) [00:23:56] 03(mod) Wikipedia Android App 1.2 release (tracking) - 10https://bugzilla.wikimedia.org/33855 summary (10Tomasz Finc) [00:25:37] 03(WONTFIX) Android phonegap app settings dialog: checkbox, dropdown should trigger when tapping anywhere in the list item - 10https://bugzilla.wikimedia.org/32244 (10Phil Chang) [00:27:27] 03(mod) Datatype quantity does not recognize comma - 10https://bugzilla.wikimedia.org/32661 normal->04CRIT; +comment (10Francis Hunger) [00:28:56] 03gregchiasson * 10/trunk/extensions/ArticleFeedbackv5/ (3 files in 2 dirs): ATF5 - fix image links on sort arrows, and a couple of the queries for building the filterCount rollup table. [00:30:53] 03(WONTFIX) wrong parameter name in set_recurring_date - 10https://bugzilla.wikimedia.org/33934 +comment (10Jeroen De Dauw) [00:32:58] 03(mod) Keyboard navigation doesn't work in Android settings dialog - 10https://bugzilla.wikimedia.org/32902 +comment (10philinje) [00:36:44] 03gregchiasson * 10/trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php: [00:36:44] AFT5 feedback page - 'X feedback posts on this article' should always show the [00:36:44] total. There's a known issue here, which is that the total for a logged in user [00:36:44] isn't the same as the total for an editor, which isn't the same as the total for [00:36:44] an oversighter, but that will require new rows in the rollup table - for now, at [00:36:44] least remove the manual filtering. [00:38:05] 03(ASSIGNED) WIkipedia Android app forward button at times does nothing - 10https://bugzilla.wikimedia.org/33280 +comment (10Phil Chang) [00:38:05] 03(mod) Wikipedia Android App 1.1 release (tracking) - 10https://bugzilla.wikimedia.org/31805 (10Phil Chang) [00:43:42] 03yonishostak * 10/trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css: AFTv5: fix for r109970 - missing @embeds [00:45:06] holy shit someone at omnti other than greg listened to codereview [00:46:57] 03(mod) "cols" preference is redundant and should be removed - 10https://bugzilla.wikimedia.org/24430 (10jidanni) [00:49:17] 03(mod) "cols" preference is redundant and should be removed - 10https://bugzilla.wikimedia.org/24430 (10jidanni) [00:52:33] 14(DUP) provide a license statement - 10https://bugzilla.wikimedia.org/33935 +comment (10Derk-Jan Hartman) [00:52:33] 03(mod) Fix up licensing and attribution of the Application and it's contributors - 10https://bugzilla.wikimedia.org/33912 +comment (10Derk-Jan Hartman) [00:52:34] 03krinkle * 10/trunk/phase3/ (includes/Xml.php tests/phpunit/includes/XmlTest.php): [00:52:34] [Unit testing] Re-order attribs to a-z to make testing more reliable [00:52:34] * This is in preparation for deprecating this in favor of an Html:: method soon, making sure here that tests still match afterwards [00:52:34] * Follows-up r109698 [00:52:44] 03yaron * 10/tags/extensions/SemanticInternalObjects/REL_0_6_8/: Tag for version 0.6.8 [00:52:47] 03yonishostak * 10/trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/ (sort-ascending.png sort-descending.png): AFTv5: fix sorting image [00:53:11] 03(mod) Fix up licensing and attribution of the Application and it's contributors - 10https://bugzilla.wikimedia.org/33912 +comment (10hartman) [00:54:07] New code comment: Gregchiasson; Fair enough - I also removed a couple of unused messages while I was in there. Is there an accepted ; [00:54:44] 03(mod) "cols" preference is redundant and should be removed - 10https://bugzilla.wikimedia.org/24430 (10jidanni) [00:56:30] 03(NEW) Network connectivity issues on HTC Desire, possibly others - 10https://bugzilla.wikimedia.org/33939 normal; Wikimedia Mobile: android; (philinje) [00:57:13] 03(ASSIGNED) Network connectivity issues on HTC Desire, possibly others - 10https://bugzilla.wikimedia.org/33939 (10Phil Chang) [00:57:14] 03(mod) Wikipedia Android App 1.1 release (tracking) - 10https://bugzilla.wikimedia.org/31805 (10Phil Chang) [00:57:56] 03(mod) "cols" preference is redundant and should be removed - 10https://bugzilla.wikimedia.org/24430 (10jidanni) [01:00:14] 03kaldari * 10/trunk/extensions/CentralNotice/special/SpecialBannerController.php: fixing bug 33931 with submitted patch - explicitly listing mw.user as a depenancy [01:01:17] New code comment: Krinkle; Yep, modules should declare all and only dependencies used directly in the scripts listed in the mod; [01:01:25] wow, deja vu [01:01:56] also known as the toolserver effect [01:07:07] 03(mod) "cols" preference is redundant and should be removed - 10https://bugzilla.wikimedia.org/24430 +comment (10Krinkle) [01:07:26] 03(mod) "cols" preference is redundant and should be removed - 10https://bugzilla.wikimedia.org/24430 -easy -patch -reviewed (10Krinkle) [01:07:29] 03(FIXED) Missing dependency to mw.user - 10https://bugzilla.wikimedia.org/33931 +comment (10Ryan Kaldari) [01:12:18] 03(mod) Missing dependency to mw.user - 10https://bugzilla.wikimedia.org/33931 normal->major; -need-review +reviewed (10Krinkle) [01:13:51] New code comment: Johnduhart; The comment here is fine, just be sure to note everything changed in your commit message from now on; [01:20:59] 03(mod) Make CentralNotice banner-hiding cookie work cross-site - 10https://bugzilla.wikimedia.org/16821 summary; +comment (10Ryan Kaldari) [01:21:01] 03(NEW) Automatic reference counting - 10https://bugzilla.wikimedia.org/33940 normal; Wikimedia Mobile: iphone; (hartman) [01:21:08] 03yonishostak * 10/trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css: AFTv5: styles for proper implementation of the sorting arrow [01:21:28] 03gregchiasson * 10/trunk/extensions/ArticleFeedbackv5/ (3 files in 2 dirs): [01:21:28] Make the helpful/unhelpful counts update on clicking one of the buttons. This [01:21:28] pulls from the slave/read DB, in the interest of not hitting the master/write [01:21:28] DB, which means the information it pulls might not be 100% up to date, but it [01:21:29] seemed better than allowing selects on the master. I can fix that, if this is a [01:21:29] problem. Update the javascript to support same. [01:26:42] 03(NEW) Create user preferences for hiding CentralNotice banners - 10https://bugzilla.wikimedia.org/33941 enhancement; MediaWiki extensions: CentralNotice; (rkaldari) [01:29:02] 03(WONTFIX) Wide pages do not scroll horizontally in RTL languages - 10https://bugzilla.wikimedia.org/33688 (10Phil Chang) [01:31:28] 03(NEW) Highlight the current language in langlinks - 10https://bugzilla.wikimedia.org/33942 normal; Wikimedia Mobile: generic; (hartman) [01:32:13] 03(ASSIGNED) Android app should support in app donations - 10https://bugzilla.wikimedia.org/31513 +comment (10Phil Chang) [01:32:14] 03(mod) Wikipedia Android App 1.2 release (tracking) - 10https://bugzilla.wikimedia.org/33855 (10Phil Chang) [01:33:22] 03(mod) "Save page" should be re-enabled after the page is deleted from saved pages - 10https://bugzilla.wikimedia.org/33621 (10Phil Chang) [01:33:22] 03(mod) Wikipedia Android App 1.1 release (tracking) - 10https://bugzilla.wikimedia.org/31805 (10Phil Chang) [01:36:23] 03(ASSIGNED) "Save page" should be re-enabled after the page is deleted from saved pages - 10https://bugzilla.wikimedia.org/33621 (10Phil Chang) [01:37:57] 03(mod) Make "Hide" Cookies notice independent - 10https://bugzilla.wikimedia.org/17108 +comment (10rkaldari) [01:38:22] 03(ASSIGNED) Add a feature to clear local cached pages history - 10https://bugzilla.wikimedia.org/32916 summary (10Phil Chang) [01:40:44] 03(FIXED) Wikipedia:About is hard-coded and not language-sensitive in Wikipedia Mobile Android app - 10https://bugzilla.wikimedia.org/33527 (10Phil Chang) [01:42:48] 03(ASSIGNED) Android app has no long-click menu on links: no way to copy-paste links - 10https://bugzilla.wikimedia.org/31485 +comment (10Phil Chang) [01:42:49] 03(mod) Wikipedia Android App 1.2 release (tracking) - 10https://bugzilla.wikimedia.org/33855 (10Phil Chang) [01:50:26] hello all [01:57:43] 03aaron * 10/trunk/phase3/ (7 files in 3 dirs): (log message trimmed) [01:57:43] In FileBackend: [01:57:43] * Use 'b' param in some fopen() calls as needed for Windows and newline handling. [01:57:43] * Removed some useless padding code in FileBackend::getContainerShard(). Initialized $m to make IDE happy. [01:57:43] * Updated some code comments. [01:57:43] In SwiftFileBackend: [01:57:44] * Manually set the ETag when using php-cloudfiles for creating files to avoid https://github.com/rackspace/php-cloudfiles/issues/59. [02:08:02] 03yaron * 10/trunk/extensions/SemanticForms/includes/SF_FormLinker.php: Removed unnecessary MediaWiki check [02:12:03] New code comment: Aaron Schulz; Note: reported upstream in https://github.com/rackspace/php-cloudfiles/issues/59.; [02:12:28] 03(ASSIGNED) Language selector stays open after closing on Honeycomb (Galaxytab 10.1) - 10https://bugzilla.wikimedia.org/33690 +comment (10Phil Chang) [02:14:19] 03rsterbin * 10/trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php: (log message trimmed) [02:14:19] Some cleanup for messages (not yet complete): [02:14:19] - Standardized comment style and spacing [02:14:19] - Put all the special page messages together [02:14:19] - Stripped out messages left over from AFTv4, except for one where I wasn't [02:14:19] sure, which is now commented accordingly [02:14:20] - Updated the message documentation to make use of the msg-mw [02:15:46] 03neilk * 10/trunk/phase3/.gitignore: git should ignore image directories and cache files [02:16:10] 03(ASSIGNED) Android app prompts for compatibility zoom on Honeycomb 3.2 - 10https://bugzilla.wikimedia.org/33692 (10Phil Chang) [02:16:11] 03(mod) Wikipedia Android App 1.2 release (tracking) - 10https://bugzilla.wikimedia.org/33855 (10Phil Chang) [02:18:09] 03(FIXED) Android app should have a better experience with no search results, Did You Mean - 10https://bugzilla.wikimedia.org/31760 +comment (10Phil Chang) [02:19:02] New code comment: Aaron Schulz; The require() statements should also use dirname( __FILE__ ) to avoid the "current directory" pitfal; [02:21:17] New code comment: Aaron Schulz; Gah, that was the md5sum problem actually.; [02:21:32] 03aaron * 10/trunk/extensions/SwiftCloudFiles/ (SwiftCloudFiles.php php-cloudfiles-1.7.10/cloudfiles.php): r109227: Use dirname( __FILE__ ) in php-cloudfiles for code inclusion statements for sanity. Also, set up the extension version number. [02:21:32] New code comment: Tim Starling; Also the tests directory might be slightly scary if the .php files can be executed from the web. Oth; [02:22:59] 03jeroendedauw * 10/trunk/extensions/EducationProgram/ (26 files in 5 dirs): merge master courses with courses [02:24:12] TimStarling: those tests should at least have php_sapi_name checks or something [02:24:20] I guess I can just nuke them [02:26:01] TimStarling: any preference? [02:26:43] Is codurr massively lagged? [02:26:57] Guess so. [02:29:25] * AaronSchulz looks at $wgMathDirectory [02:31:13] 03rsterbin * 10/trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php: Rearranged the order of messages and documentation lines so that they match (and so that I could make a complete list of the messages missing documentation) [02:32:58] rsterbin: require_once( "path/to/ArticleFeedback.i18n.php" ); var_dump(array_keys(array_diff_key($messages['en'], $messages['qqq']))); ? [02:33:02] 03yaron * 10/trunk/extensions/SemanticForms/includes/SF_FormLinker.php: Fix for handling of $sfgRedLinksCheckOnlyLocalProps with SMW 1.7; added "redlink=1" to generated red-link URLs [02:33:19] bzuh [02:33:22] where do you see that? [02:33:40] Oh, no that's what I would suggest you use to build a list of messages with missing docs [02:34:15] 03jeroendedauw * 10/trunk/extensions/EducationProgram/sql/EducationProgram.sql: added missing commas [02:34:34] indeed. :-P [02:34:57] my only excuse is that it's late [02:35:06] Right, it's already 9:30 back East [02:36:34] 9:30! [02:36:40] * hexmode is writing a blog post before bed [02:37:01] * RoanKattouw is writing documentation before dinner [02:39:02] * johnduhart is writing a web service for tracking throwaway email domains [02:40:32] johnduhart: now all you need is a way to spam them! [03:01:31] 03krinkle * 10/trunk/phase3/ (RELEASE-NOTES-1.19 includes/Html.php includes/Xml.php): (log message trimmed) [03:01:31] [Xml/Html] new method Html::namespaceSelector [03:01:31] * Using params and option arrays instead of 4 random parameters like Xml::namespaceSelector did [03:01:31] * Right now it's passing $selectAttribs['name'] to Xml::label, this is done [03:01:31] because that's what Xml::namespaceSelector did. However it's wrong since labels [03:01:31] associate over ID not NAME. Will fix in the next commit, making sure unit tests [03:01:33] stay functional first. This bug has been in Xml::namespaceSelector for a long [03:03:32] New code comment: Peachey88; The messages should probably be blanked and defined elsewhere that is wmf specific, WikimediaMessage; [03:05:02] New code comment: Johnduhart; Ping.; [03:06:04] 03jeroendedauw * 10/trunk/extensions/EducationProgram/ (10 files in 6 dirs): follow up r109985 r109989; updated messages and field names [03:06:21] 03neilk * 10/trunk/extensions/UploadWizard/ (UploadWizard.config.php resources/mw.UploadWizard.js): fix bug 33513, localized alternative upload forms [03:07:54] 03(mod) "Zur�ck zum alten Formular" (back to the old form) links to the wrong page - 10https://bugzilla.wikimedia.org/33513 +comment (10neilk) [03:21:02] New code comment: Krinkle; Hm.. can you elaborate on this ? The only difference I can spot here is that instead of toggling the; [03:25:03] New code comment: Catrope;
 \ + $spam = wfSpamBlacklistObject(); \ 
\ Where is this function defined? I can't find it any; [03:25:32] svn dowm? [03:25:41] s/dowm/down/ [03:26:00] 03krinkle * 10/trunk/phase3/ (3 files in 2 dirs): (log message trimmed) [03:26:00] [Html] Unit test + bugfix Html::namespaceSelector [03:26:00] * Previously it was passing $selectAttribs['name'] to Xml::label, which uses its [03:26:00] value for the