[00:00:14] and play around with it [00:00:27] astra05: thank you so much [00:00:42] triferema: look for some books on ldap, and user logic. that is where your problem is right now [00:00:45] not the actual technology [00:00:55] that will come easier when you understand your true goals [00:01:15] you have just confirmed that my LDAP line of thought was not that wrong [00:01:51] plus you introduce strong scalability [00:03:51] can u check my localfile? http://www1.atwiki.com/ensandbox/pages/1236.html [00:04:26] New patchset: QChris; "Allow closing dump output multiple times" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4066 [00:06:31] it is all right, isnt it? [00:07:45] 03(mod) Cannot scroll low enough to see all content - 10https://bugzilla.wikimedia.org/35551 +comment (10Killiondude) [00:12:08] New patchset: Kaldari; "getting rid of absurd white border" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4067 [00:12:11] New patchset: Kaldari; "follow-up to Change I58bc5847 for bug 27757 - adding support for patrol tokens (and making the rc param in getPatrolToken optional)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3921 [00:12:12] New patchset: Kaldari; "fix for bug Bug 27757, applying John Du Harts patch for an API method for retrieving tokens" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3890 [00:17:49] astra05: i looked at faq and it looks like I had to change the $wgEditPageFrameOptions = 'SAMEORIGIN'; from 'DENY' no it works fine, I just need to figure out the skin staff [00:18:16] triferema: nice :) [00:18:34] and may be we could have a happy client, but I will still give the LDAP a try, I am not sure if the client will be willing to spend [00:19:09] so you are saying for the skin part of the extension I have to dig into [00:19:12] the core? [00:29:19] New review: Krinkle; "(no comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/3890 [00:29:48] New review: Krinkle; "(no comment)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3890 [00:30:02] New review: Krinkle; "(no comment)" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/3890 [00:30:55] New review: Zaran; "(no comment)" [mediawiki/extensions/ProofreadPage] (master) C: 0; - https://gerrit.wikimedia.org/r/4040 [00:58:03] on http://spyinginc.com/wiki/index.php?title=Mission_1 is is a blue background. how do i fix? [00:59:28] on http://spyinginc.com/wiki/index.php?title=Mission_1 is is a blue background. how do i fix? [01:00:28] on http://spyinginc.com/wiki/index.php?title=Mission_1 is is a blue background. how do i fix? [01:03:44] USEagency: You only need to ask the question Once, when someone is around that can answer, they will [01:04:54] new people joined. that way they will here. to anticipate the next question, my localsettings.php http://pastebin.com/B7jF4zE3 [01:05:17] anyone that can help? [01:05:23] it doesn't look blue to me [01:05:51] the paste or address? [01:06:03] http://spyinginc.com/wiki/index.php?title=Mission_1 [01:07:50] odd, in firefox it is normal in chrome... BLUE!! [01:08:31] try clearing your cache [01:08:39] how do i do that? [01:09:00] search for "chrome clear cache" in google and follow the instructions [01:10:18] i took a screen picture http://spyinginc.com/wiki/index.php?title=File:Blueerror.png [01:16:02] still blue [01:16:28] USEagency: try setting your zoom level to 100% using Ctrl-0. It's a bug in Chrome. [01:16:31] !bug 34551 [01:16:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=34551 [01:18:32] * Dantman resists the temptation to sneak a foreign language dirty joke into the test framework [01:19:10] Right before I have to fill out a bug report - can someone please tell me WHY this http://en.wikisource.org/wiki/Portal:English_Statutes/Titles_%28Ruffhead%29_Hen3._to_Hen6. won't format properl? [01:19:19] *properly? [01:20:21] ? [01:21:08] Check the source of the page [01:21:14] I see NO logical reason why it's breaking [01:21:36] and I've checked the transclused pages on BOTH sides for any sign of an unclosed tag [01:22:14] There's a SUPRIOUS also [01:22:44] As I have so far been unable to track down a typing error that would explain it's presence - Perhaps you could explain where it is? [01:22:45] I don't see any page to look at the source for. [01:22:59] Dantman: http://en.wikisource.org/w/index.php?title=Portal:English_Statutes/Titles_(Ruffhead)_Hen3._to_Hen6.&action=edit [01:23:10] http://en.wikisource.org/w/index.php?title=Page:Ruffhead_-_The_Statutes_at_Large,_1763.djvu/31&action=edit [01:24:21] http://en.wikisource.org/wiki/Page:Ruffhead_-_The_Statutes_at_Large,_1763.djvu/32 [01:24:50] Oh great... a whole complex extension [01:27:04] http://en.wikisource.org/w/index.php?title=Page:Ruffhead_-_The_Statutes_at_Large,_1763.djvu/31&action=edit looks pretty obviously broken to me, if you turn off javascript [01:27:12] OK [01:27:28] it has [01:27:42] That's correct [01:27:56] The poem tags should be in a header [01:28:47] ok, maybe that would work, but what about the unclosed in the ? [01:29:02] Examine the footer [01:29:12] There should be an equivalent in the foort [01:29:12] you mean ? [01:29:17] Yes [01:29:25] that's just noinclude, where's the close tag for the includeonly poem? [01:29:38] * USEagency just watched jason aldean's Fly Over States on the CMA [01:29:42] I'm not using Includeon;ly? [01:30:35] [01:30:35] TimStarling [01:30:35] {{c|'''Anno'' 9 {{sc|Henrici}} 3. }} [01:30:44] That shouldn't break it [01:32:01] http://en.wikisource.org/wiki/Portal:English_Statutes/Titles_%28Ruffhead%29_Hen3._to_Hen6. - I'm only now transcluding 2 pages [01:32:06] and the glitch still exists [01:32:14] PLEASE tell me WHERE the typo is [01:32:31] In either of the TWO SPECFIC page [01:33:08] what glitch are you talking about exactly? [01:33:15] View the ***ing page [01:34:04] After Anno 14 is a page break [01:34:11] do you mean "Sanity-1 [01:34:11] Sanity2" [01:34:22] Yep [01:34:24] because that looks like some debugging garbage [01:34:27] you could just search for it [01:34:30] It is [01:34:38] The Noinclude is appearing [01:34:39] so why not search for it and remove it? [01:34:59] Because I've ALREADY tried to findout where the SUPRIOUS text is coming from [01:35:07] you mean spurious? [01:35:10] and I cannot find WHERE it's cominf from [01:35:18] TimStarling: Yes [01:36:35] so are you saying it's not the sanity1/sanity2 you're concerned about? [01:36:46] just the ? [01:36:53] Yes [01:37:19] Because the Sanity1-Sanity were debug markers i put in to try and determine where it was breaking [01:38:44] so is there any other problem apart from the ? [01:39:06] I removed the tag and the vaniahsed [01:39:23] The problem is that it now doesn't doe formatting at all. [01:40:01] Suggesting that doesn't work across page transclusions [01:40:11] which would be a 'pain' to say the least [01:40:59] The code I am using is which could not be any simpler [01:41:12] I don't see why it's NOT formatting [01:41:31] So I'm assuming Mediawiki is broken [01:41:39] no, won't work across page transclusions [01:41:49] Right [01:42:09] It shouldn't take me 48 hours to get that simple answer.. XD [01:42:21] So How do you do poem across multiple pages? [01:44:34] maybe someone who is more able to tolerate your attitude can help you with that [01:46:54] TimStarling: I don't hav an 'attitude' - I just expect things to work. :) [01:47:06] Anyway sorry , I've I got a little heated [01:47:11] *if I [01:48:17] I will consider filing a bug report about not working on transclusin though [01:48:21] * Qcoder00 out [01:54:41] New patchset: Daniel Friesen; "Add a Uri class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4069 [02:03:14] 03(NEW) [SF] file uploads produce notice in SF_UploadWindow.php when upload completes - 10https://bugzilla.wikimedia.org/35641 trivial; MediaWiki extensions: SemanticForms; (fastgoldfish) [02:07:01] 03yaron * 10/trunk/extensions/SemanticForms/specials/SF_UploadWindow.php: Fix for r102888 - $output should be initialized correctly [02:07:36] 03(FIXED) [SF] file uploads produce notice in SF_UploadWindow.php when upload completes - 10https://bugzilla.wikimedia.org/35641 +comment (10Yaron Koren) [02:11:13] 03(mod) Some IPs hidden without any log or apparent reason on frwiki - 10https://bugzilla.wikimedia.org/35578 +comment (10Tim Starling) [02:12:02] 03(mod) replacing "hidden by Article Feedback V5" link with the actual account - 10https://bugzilla.wikimedia.org/35501 +comment (10Elizabeth M Smith) [02:19:38] Is there a way to change the security questions/answers mediawiki uses for spambot filtering? [02:20:01] 03(NEW) [SF] User must be prevented from uploading until JavaScript finishes loading - 10https://bugzilla.wikimedia.org/35642 normal; MediaWiki extensions: SemanticForms; (fastgoldfish) [02:20:43] 03(mod) SF allows multiple file uploads with a single form field - 10https://bugzilla.wikimedia.org/32424 (10badon) [02:25:04] mirage335: yes, it depends on the extension your using to produce those questions. [02:26:35] How about *without* an extension? As in, changing the builtin '1+1=2" questions that wolfram alpha can answer? [02:27:36] They're not built in as far as I know. [02:28:31] I think ConfirmEdit ships with MediaWiki, but it's not enabled by default. [02:29:00] mirage335: more info here: http://www.mediawiki.org/wiki/Extension:ConfirmEdit [02:29:46] mirage335: I'm guessing that your wiki is using SimpleCaptcha [02:30:27] Thank you. [02:30:46] mirage335: no problem [03:02:21] 03(mod) Proofread Page extension setup in Bengali Wikisource - 10https://bugzilla.wikimedia.org/35629 +comment (10Belayet Hossain) [03:05:24] Hi, has anyone made caching support for an extension?, I am doing something similar and it might be helpful [03:08:11] does anybody know if there is a standard way to link a gerrit change from bugzilla ? [03:10:13] 03(NEW) Special:URIResolver gives fatal user when called directly - 10https://bugzilla.wikimedia.org/35643 normal; MediaWiki extensions: Semantic MediaWiki; (nischayn22) [03:10:35] oops, I've just found the answer to this question on [[Bugzilla]] [03:12:11] 03(mod) Links to a pages in Page namespace should be coloured only in Index namespace - 10https://bugzilla.wikimedia.org/35634 +comment (10Zaran) [03:21:14] API 400ing for anyone else? [03:21:21] or is it just that my edits are too close together? [03:48:20] YuviPanda: http://www.checkupdown.com/status/E400.html [03:49:05] Betacommand: i know what a 400 is, but i also get: [03:49:33] damn copy paste [03:49:34] anyway [03:59:07] Betacommand: figured out the bug. Had a parameter wrong, was sending POST as url query string params instead :D [04:05:36] 03(mod) A link to the index is missing for single paged documents - 10https://bugzilla.wikimedia.org/30725 +comment (10Zaran) [04:08:54] 03(mod) Need Icon for market beta version of Wikipedia Android app - 10https://bugzilla.wikimedia.org/35577 +comment (10Heather Walls) [04:09:19] YuviPanda: don't you ever sleep? [04:10:29] aharoni: I asked him the same question and he replied occasionally. [04:10:32] aharoni: it's only like, 9:30 m [04:10:33] *am [04:10:43] 03(mod) Need Icon for market beta version of Wikipedia Android app - 10https://bugzilla.wikimedia.org/35577 +comment (10Heather Walls) [04:11:05] aharoni: plus am hot on the heels of finishing a much needed tool for myself (and hopefully other people who write userscripts/gadgets too) [04:11:21] done YuviPanda :) [04:11:22] aharoni: my head is playing carrot-and-stick with my sleep, so hoping to finish it off before sleeping [04:11:37] let me know if you guys change the name or something [04:12:39] heatherw: do you think the 'beta' would be visible at small sizes? [04:12:49] hmm, I'll put it up in the app tomorrow and we can find out :) [04:12:59] hm [04:13:05] the bar one might not :( [04:13:09] yeah. [04:13:16] but it does look different! :D [04:13:23] it does :) [04:14:15] guys i already have mediawiki installexcd [04:14:22] how can i migrate to git [04:15:29] (revising now, YuviPand_ ) [04:15:31] I need to try Tor again one of these days... [04:17:20] ^_^ That hidden service feature actually looks interesting for some alternate purposes... [04:17:44] Dantman: at the Chennai hackathon we had one of the tor core devs who wanted to set that up... [04:17:59] Set what up? [04:18:02] Dantman: but then he told me it'll take work on ops side to turn that on... [04:18:05] 'hidden service' [04:18:10] Wikipedia on Tor? [04:18:19] as a Tor hidden service [04:18:28] mhmm [04:18:33] 03(mod) Need Icon for market beta version of Wikipedia Android app - 10https://bugzilla.wikimedia.org/35577 +comment (10Heather Walls) [04:19:01] I followed a link from one of the pages on that topic and read an interesting article on "petnames" (technical term) as well [04:19:16] 03(mod) Need Icon for market beta version of Wikipedia Android app - 10https://bugzilla.wikimedia.org/35577 +comment (10Heather Walls) [04:19:39] heatherw: looks more discernable! [04:19:49] awesome YuviPanda [04:19:57] can't get much bigger :P [04:20:00] heatherw: i'll put them on the app tomorrow (or 10 hours from now) and see how it is :) [04:20:26] :) [04:21:10] The idea of a service with no dependence on IPs with pratically all the features of normal TCP that works under few required additional conditions and works even behind NAT and a firewall sounds absolutely beautifull... [04:23:15] ^_^ Screw dynamic dns, ip filtering, bouncing/proxying ssh, and VPNs... I want to start running TOR on my servers and SSHing in through there! [04:26:16] Hell... one of my ideas for doing backups was to setup a small box with a hard drive in another person's house and rsync to it over ssh [04:26:47] Dantman: have you ever browsed through Tor? [04:26:52] it's like 56k modems all over again [04:28:38] Hmmm.... tolerable [04:29:05] For backups just do them continually... [04:29:24] If they're always running in the background the speed won't matter much. [04:30:00] New patchset: Amire80; "Sprint 12 fixes" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/4064 [04:33:04] 56k speeds vs. loosing the ability to have a completely static service that works even from a dynamic ip behind NAT and a firewall with no forwarding. [04:33:49] Right, add in "not tied to another dedicated service" [04:34:44] guys how can i migrate to git when i already have mediawiki installed [04:35:03] New review: Santhosh; "(no comment)" [mediawiki/extensions/TranslationNotifications] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/4064 [04:35:12] Dantman: :) [04:35:37] My other two ideas were either setting up port forwarding and using dynamic dns. Or having said box setup a reverse tunnel do one of my VPS servers. [04:35:52] Unfortunately both have strong flaws. [04:36:20] The first one requires complex setup of the router wherever the box is setup. [04:36:48] The latter pipes bandwidth through vps. [04:37:00] lunaticfaith: https://www.mediawiki.org/wiki/Migrating_from_SVN_to_Git [04:37:15] Which essentially gurantees extra cost because everyone charges by the GB. [04:38:05] Dantman: ipv6 everything :) [04:38:08] so no more NAT. [04:38:18] Heh... beautiful idea... [04:38:20] :D [04:38:28] In fact almost as ideal as TOR.... [04:38:35] every machine is pingable from every other machine [04:38:47] Unfortunately one fatal, fatal, fatal flaw that makes it even more problematic than TOR. [04:39:12] ;) 99% of residential services here in Canada have absolutely no IPv6 [04:39:15] ah [04:39:27] here neither :D [04:39:51] they were proud that they knew how to setup things on 'Apple Computer X' [04:39:55] I can't even do tests of IPv6 sites and giddily test out MV over IPv6 [04:39:57] (that's their way of saying OS X) [04:40:07] so, ipv6 seem wayy too far off [04:41:18] The only IPv6 I get to see is ::1 when I run MW on localhost. [04:44:01] Dantman: :) [04:44:17] also badly configured routing tables -> even on dual stack, try ipv6 first, timeout in 15s, then actually load the thing [04:44:18] sad [04:45:23] I originally started that backup system idea for myself. [04:45:37] But I've actually also been thinking of it for work. [04:48:31] No more static office ip... in fact now it's pure shared Wi-Fi. [04:49:25] check out "happy eyeballs", maybe it gets implemented. [04:52:05] 0 [04:52:33] 03(mod) The scan does not appear when editing pages after update to MW 1.19 on Opera - 10https://bugzilla.wikimedia.org/34732 +comment (10Zaran) [04:52:38] New patchset: Kaldari; "follow-up to Change I58bc5847 for bug 27757 - adding support for patrol tokens (and making the rc param in getPatrolToken optional)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3921 [04:52:40] New patchset: Kaldari; "(bug 27757) API method for retrieving tokens" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3890 [04:53:28] So think of a small startup with little or no resources having a reliable backup system; For a few hundred apiece having separate autonomous mini-boxes setup in various places... small office, the founder's home, etc... [05:07:28] Hi, has anyone made caching support for an extension?, I am doing something similar and it might be helpful [05:10:41] I know a couple custom extensions which *use* caching if available. [05:21:49] Amgine: which ones ? [05:22:39] Brouillant for one. Also a calendaring extension which isn't working yet. [05:26:38] MW.org search found no results [05:26:45] * nischayn22 found http://code.google.com/p/brouillant/ [05:28:45] Amgine: http://code.google.com/p/brouillant/ is not integrated with MW.org ? [05:29:53] No, I won't put my extensions through that. I'm a slow and crappy coder, and I won't live long enough to get anything reviewed. [05:30:10] I'd forgotten about that repo. [05:30:11] nischayn22: RSS feed caches data for an hour. [05:30:13] dumb idea. [05:30:16] Or some configurable amount of time. [05:30:20] I guess it uses the DB. [05:30:26] I've never actually looked. [05:30:35] RSS extension, I mean. [05:30:45] Joan: thanks [05:30:59] Amgine: heh, okay [05:31:08] I'm so helpful. [05:31:47] RSS extension is giving me fits, too. [06:02:11] 14(INVALID) $wgBlockDisablesLogin - effective on a private wiki? - 10https://bugzilla.wikimedia.org/35252 +comment (10Alexandre Emsenhuber [IAlex]) [06:04:38] 03(FIXED) Special:Whatlinkshere spews deprecation warning - 10https://bugzilla.wikimedia.org/35206 +comment (10Alexandre Emsenhuber [IAlex]) [06:16:24] New review: Nikerabbit; "(no comment)" [mediawiki/extensions/Translate] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3374 [06:16:27] Change merged: Nikerabbit; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/3374 [06:21:27] New review: Nikerabbit; "There is no explanation why this needs to be a configuration setting." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4065 [06:25:03] New patchset: Daniel Friesen; "Add $wgPurgeHttp11." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4065 [06:28:59] hi [06:29:20] how to stop bots from editing a page? [06:29:21] New review: Daniel Friesen; "Practically every current setup is expecting the old PURGE $url HTTP/1.0 format. Suddenly making MW ..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/4065 [06:32:56] Juandev: Protect it? [06:33:04] write the bot so it doesn't edit it? [06:33:15] New review: Nikerabbit; "Only found two very minor issues." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/4069 [06:36:54] New patchset: Daniel Friesen; "Add a Uri class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4069 [06:57:33] New patchset: Amire80; "Sprint 12 fixes" [mediawiki/extensions/TranslationNotifications] (master) - https://gerrit.wikimedia.org/r/4064 [07:00:32] protect it? any template? [07:00:45] better using template [07:11:05] 03(mod) Loading of a change for review in Gerrit is often very slow - 10https://bugzilla.wikimedia.org/35612 +comment (10Amir E. Aharoni) [07:35:50] Question - I have a wiki that is going to be shut down soon. Is there a way for me to export the wiki and upload it to another wiki such as a referata wiki? Any advice as to how I would do so? [07:38:13] 03(mod) Special:URIResolver gives fatal user when called directly - 10https://bugzilla.wikimedia.org/35643 +comment (10Nischay Nahata) [07:39:06] 03(mod) Special:URIResolver gives fatal user when called directly - 10https://bugzilla.wikimedia.org/35643 +need-review +patch (10Nischay Nahata) [07:40:31] Is there any good git viewer around? [07:42:41] !export | KTCAOP [07:42:42] KTCAOP: To export pages from a wiki, navigate to Special:Export on the wiki, type in the names of the pages to export, and hit "export". See for an example of this form. See also: !import [07:43:06] vvv: you mean something better than gitweb? [07:43:31] Thank you mw-bot. [07:43:35] saper: well, gitweb isn't really a git viewer. It does not even have syntax highlighter [07:43:58] And it takes five minutes to find gitweb from gerrit's main page [07:46:54] vvv: oh that's the feature definitely not a bug :) [07:47:21] saper: the gerrit was clearly modelled after CVS in matters of usability [07:47:33] vvv as in https://bugzilla.wikimedia.org/35612 ? [07:48:02] Nikerabbit: no, I mean in terms of click [07:48:23] vvv: yeah [07:48:33] To find a gitweb from a repo I have to do Admin -> Projects -> Repo name -> Branches -> (head) of master [07:48:37] That's horrible [07:50:57] * Dantman just types gitweb in his browser to trigger Firefox's awesomebar [07:52:44] Dantman: does Firefox highlight source code for you? [07:52:54] Well... no, not that part [07:55:45] New review: Krinkle; "(no comment)" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/3702 [07:57:37] New review: Hashar; "Thomas told me that he will look again at this change past mid April. So just hold for now :-]" [mediawiki/extensions/RSS] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/3925 [07:58:27] vvv: I can live without highlighing but that only shows my age [08:03:42] Naturally our "I can't believe it's not git" setup leaves much to be deserved. [08:23:55] New review: Hashar; "I don't really understand the point of that new class. To me, it adds a layer of unwanted complexity..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/4069 [08:31:06] New review: Hashar; "I do no think there is a point in using HTTP1/1 for squid purging. You will need the full URL anyway..." [mediawiki/core] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/4065 [08:40:20] New patchset: Hashar; "getting rid of white border around gallery thumbs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4067 [08:41:11] New review: Hashar; "I have added an entry to 1.20 release notes and rewrote the commit message to mention the change app..." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/4067 [08:44:34] New review: Hashar; "(no comment)" [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/4026 [08:49:56] New review: Hashar; "That part of the code was originally wrote by WMF employee Neil Kandalgaonkar. I am not sure who is..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4051 [08:53:24] 03vvv * 10/trunk/php/luasandbox/ (6 files in 2 dirs): Add the initial implementation of the Unicode support. [08:53:58] vvv: lovely :-] [08:54:24] hashar: you mean the Unicode? [08:54:28] yeah [08:54:46] I still think I may add some stuff there [08:54:48] I have no idea why you have to add unicode support though :-D [08:54:55] to me it should just work :-] [08:55:30] hashar: oh, it does. And it honestly think that one Cyrillic letter is two characters [08:55:47] dohh [08:56:09] (and not to mention upper-casing) [09:01:37] good morning hashar! [09:01:46] hello :) [09:01:51] I have a question re labs and gerrit [09:02:00] go ahead [09:02:09] I have a labs account already, but would like to use a different user name for git [09:02:22] labs user is GWicke, git user should be 'gwicke' [09:02:37] ;-) [09:02:55] I am almost sure Gerrit use the labs LDAP [09:03:10] so I don't think we can do that without having labs user renamed to gwicke [09:03:23] ok [09:03:37] ^demon might confirm [09:03:45] or petan in #wikimedia-labs [09:04:17] thanks, will ask there then [09:04:33] have you tried logging on git using 'gwicke' ? [09:04:51] the posix account entry in LDAP seems to use the lower case version [09:05:09] not yet, but will try [09:05:31] Aaaaaaaggggghhhhhh... [09:05:39] * Dantman glares at ^demon [09:05:53] * hashar points Dantman's bed :-D [09:05:58] gwicke: labsconsole and {git|gerrit} can have differnt usernames [09:06:25] ok [09:08:46] nm- I was able to log into gerrit using the labs account just fine, and the user is already lowercase [09:10:16] gwicke: \o/ [09:16:34] bleh... My guide for safely migrating from svn to git is getting massive: https://www.mediawiki.org/wiki/User:Dantman/Migrating_from_SVN_to_Git [09:16:55] I wonder if I should just drop the clean conversion part and use svn diff + patch [09:18:19] it doesn't seem that long to me [09:21:04] It's got the user working around svn -> git conversion artifacts [09:21:09] Dantman: Reedy already started a similar page… 1. Combine 2. Expand 3. ??? 4. Profit? [09:21:35] p858snake|l: https://www.mediawiki.org/wiki/Migrating_from_SVN_to_Git [09:21:44] It's 'supposed' to replace that... [09:22:09] Since those guides are pretty bad ones having the user unsafely overwriting their files [09:22:37] ouch [09:24:49] New patchset: Santhosh; "Add initial version of optional onscreen keyboard support." [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/4070 [09:42:29] 03(NEW) Add option to disable Biography - 10https://bugzilla.wikimedia.org/35644 enhancement; MediaWiki extensions: ConfirmAccount; (christian) [09:45:19] Ahhh extensions... [09:45:23] Our endless hell... [09:45:39] The endless circle... [09:47:09] Installation of V 1.18.2 stopps while creating "secret key" [09:47:27] Show me your error log [09:47:28] on a windows2003 server [09:47:44] which log [09:47:50] php error log [09:47:55] wait [09:47:56] Whatever... [09:48:03] Most webservers combine the error log. [09:48:41] ** Start updating extensions; Get annoyed at how you have to update each one individually; Even more annoyed at dealing with tags and branches of extensions; Decide you want to implement extension updating code; Realizing something like that will probably need better config handling. [09:48:53] Right click my computer, manage, log [09:50:27] Dantman, didn't platonides do something like this already? [09:50:43] No clue... [09:51:24] Did you find the error log? [09:51:36] :-D [09:52:54] No. [09:54:00] New patchset: QChris; "Reintroduce freeing result sets for dumps" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4033 [09:56:25] Dantman, search wikitech-l for "Cloning all the git migrated projects" [09:56:29] New review: Daniel Friesen; "We've already had two people asking for proper HTTP/1.1 handling. One in irc with this getting in th..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/4065 [10:00:19] New patchset: Hashar; "(bug 27757) API method for retrieving tokens" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3890 [10:01:27] New review: Hashar; "Patchset 8 squash in change 3921 which adds support for patrol tokens." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/3890 [10:01:40] Ah, error logging of php was off. I start logging and perhaps ring again..thanks [10:01:42] Change abandoned: Hashar; "squashed / merged in https://gerrit.wikimedia.org/r/3890" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3921 [10:03:28] Notice: A non well formed numeric value encountered in /var/mediawiki/includes/CryptRand.php on line 379 [10:04:51] Only that? [10:05:06] That's only a notice... it shouldn't stop things from running. [10:05:13] What acctually happens? [10:05:44] 03(mod) data-sort-value in broadtable-fields doesn't consider "," as decimal separator - 10https://bugzilla.wikimedia.org/35523 +comment (10Christian Illy) [10:07:24] when I install my wiki [10:10:44] its occurred in mw-config/index.php?page=Install [10:11:00] step 6 [10:12:06] i'm using chinese one and I don't know what it original is [10:12:12] I understand why and where that notice comes from... [10:12:43] hmmm... nowait it might be a little fatal [10:12:44] do you know why ? [10:13:15] There was a bug in the version of MWCryptRand we added into the releases. It'll be fixed in an upcoming release. [10:14:55] So that i must wait for next release or an older one ?>_< [10:15:26] but thanks very much~ [10:18:59] \help [10:50:55] is it safe to change wgSecretKey (let's say, when upgrading) ? (no leakage of wgSecretKey has occurred, as far as i know) [10:54:15] 03(mod) Manually fix blocks from when global oversight log removal problem started - 10https://bugzilla.wikimedia.org/34995 normal->04CRIT; +comment (10James Alexander) [10:56:06] 03(mod) Manually fix blocks from when global oversight log removal problem started - 10https://bugzilla.wikimedia.org/34995 +comment (10James Alexander) [11:00:10] 03(mod) Manually fix blocks from when global oversight log removal problem started - 10https://bugzilla.wikimedia.org/34995 +comment (10James Alexander) [11:17:51] Richlv: yes [11:19:36] New patchset: Santhosh; "Fix Bug 33653 -JqueryMsg parser should support templates without replacements" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4071 [11:19:38] New patchset: Santhosh; "Fix Bug 32748 - Printer friendly version of article must encode URL in unicode." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3897 [11:19:44] New review: GWicke; "Hi Adam, thanks for your patch! It looks generally fine to me, but could be improved in a few places..." [mediawiki/extensions/VisualEditor] (master) C: -1; - https://gerrit.wikimedia.org/r/3729 [11:20:49] p858snake|l, thanks [11:35:36] New review: GWicke; "Reviewed pegTokenizer." [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/3729 [11:39:41] New patchset: Drecodeam; "(bug 26107) Upload Wizard scrolls to top of the wizard div rather than top of the page." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/4072 [11:51:13] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3916 [11:51:19] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3916 [11:52:59] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3917 [11:53:02] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3917 [11:53:31] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3918 [12:00:30] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3990 [12:00:33] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3990 [12:01:32] New patchset: Platonides; "Remove unused $wgDebugDBTransactions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4073 [12:01:49] no, no, no! [12:02:59] why did it choose to send such commit? [12:09:14] why does gerrit changes my commits? [12:09:43] 03jeroendedauw * 10/trunk/extensions/SemanticMediaWiki/ (3 files in 3 dirs): fix bug 35643 plus some extra cleanup [12:10:03] 03(FIXED) Special:URIResolver gives fatal user when called directly - 10https://bugzilla.wikimedia.org/35643 +comment (10Jeroen De Dauw) [12:10:30] New patchset: Platonides; "Remove unused $wgDebugDBTransactions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4074 [12:10:34] Which tutorial should i follow to enable latex in my mediawiki? [12:10:50] you mean use latex for math? [12:10:51] !math | diverdude [12:10:51] diverdude: https://www.mediawiki.org/wiki/Manual:Math [12:11:48] Platonides: yeah....but that says: MediaWiki 1.18 and higher...im running 1.16 [12:12:09] you should really update... [12:12:44] just skip the steps of downloading Math extension [12:12:53] since it was bundled into mediawiki [12:13:01] you still need to compile texvc [12:13:08] Platonides: mmm i have so many pages...if anything goes wrong in the update i would die [12:14:49] for updating mediawiki? [12:14:52] it's not hard [12:14:53] yeah [12:15:10] first you create a backup of the database [12:15:16] then replace mediawiki files [12:15:23] then run maintenance/update.php [12:15:24] done [12:16:32] Platonides: everything i enter on my wikipages, is that stored in the database? [12:16:43] Platonides: nothing is stored in php files or other kind of files? [12:17:15] yes, all the page contents is in the database [12:17:28] the exception are the images, which are in the images folder [12:17:29] 03(mod) Article::delete() calls - 10https://bugzilla.wikimedia.org/35640 +comment (10Jeroen De Dauw) [12:17:46] and LocalSettings.php which contain the wiki configuration [12:18:42] 03(mod) Article::delete() calls - 10https://bugzilla.wikimedia.org/35640 +comment (10Platonides) [12:20:42] 03(mod) Article::delete() calls - 10https://bugzilla.wikimedia.org/35640 +comment (10Jeroen De Dauw) [12:21:23] New patchset: Platonides; "Remove unused $wgDebugDBTransactions" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4073 [12:23:28] 03(mod) Article::delete() calls - 10https://bugzilla.wikimedia.org/35640 +comment (10Platonides) [12:24:14] seems the trick was doing git push gerrit HEAD:refs/for/master/`uuidgen`... [12:27:23] or rather, git push gerrit HEAD:refs/for/master/$(git branch | grep -F "*" | cut -c3-) [12:28:34] 03(mod) "Download as PDF" does not open page as a PDF - download gets stuck. - 10https://bugzilla.wikimedia.org/35645 (10bkoelrich) [12:29:37] Change abandoned: Platonides; "Dupe of https://gerrit.wikimedia.org/r/#change,4073" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4074 [12:29:42] Platonides: what for? [12:30:09] ? [12:31:05] Platonides: git push gerrit HEAD:refs/for/master/`uuidgen` etc. [12:32:59] New review: Platonides; "Sorry?" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4065 [12:33:14] saper, I was trying to send a patchset without getting it rebased [12:34:08] so that I could use the revision introducing the bug as the parent [12:34:16] ah [12:34:29] is "git push" rebasing automatically? strange [12:34:52] I would git reset --soft [12:34:57] git commit and push [12:36:00] New review: Platonides; "I don't see the point, either. " [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/4069 [12:36:08] git-review seems to be doing that [12:36:27] use -R [12:36:33] *always* [12:36:38] or don't use git review :) [12:38:47] Platonides: there is another "what is the point" change by Daniel at https://gerrit.wikimedia.org/r/#change,4065 [12:39:04] anyone in here uses SMW ? willing to give feedback of its performance ? [12:40:11] Platonides: ho you did reply on that one already :°D [12:58:26] New review: Hashar; "> PURGE http://foo/foo HTTP/1.0 Is completely non-standard, it completely violates HTTP. It's ridicu..." [mediawiki/core] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/4065 [13:06:51] New patchset: Santhosh; "Make SITENAME with value mw.config.get( 'wgSiteName' ) available in parser without the need of module users explicitly adding it." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4077 [13:06:52] New patchset: Santhosh; "Fix Bug 33658 - Add support for {{GRAMMAR:}} to the mediawiki.jqueryMsg module" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4078 [13:18:46] 03(mod) Loading of a change for review in Gerrit is often very slow - 10https://bugzilla.wikimedia.org/35612 +comment (10Chad H.) [13:19:03] New patchset: Platonides; "bug35572 Blocks appear to succeed w/DB error" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3977 [13:20:47] New review: Catrope; "You're reimplementing part of AbuseFilter here, but there seems to be no way around that without doi..." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3991 [13:20:49] Change merged: Reedy; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3992 [13:20:51] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3991 [13:22:52] New review: Platonides; "(no comment)" [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/4066 [13:27:34] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3993 [13:28:16] 03netbrain * 10/trunk/extensions/Maps/includes/services/OpenLayers/jquery.openlayers.js: [13:28:16] fixed openlayers js for image layer capability. [13:28:16] and did some minor js optimizations [13:29:52] New review: Catrope; "Looks good but the 'system' parameter is scary the way it's implemented now." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/3994 [13:32:46] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3995 [13:33:05] !seen ialex [13:33:22] !seen iAlex [13:33:30] sumanah: hi [13:33:40] hi there potter [13:33:45] hi Daniel_WMDE [13:33:53] "and so it begins" - -Bab5 reference? [13:34:10] 03jeroendedauw * 10/trunk/extensions/SemanticMediaWiki/RELEASE-NOTES: Follow up to r114651; up rel notes [13:34:24] Nikerabbit: hi! [13:35:01] sumanah: Nikerabbit: i was writing an extension in which user gets top pages of this watchlist . top pages are pages which have maximum hits [13:35:44] New patchset: Hashar; "regroup all API tests in the 'API' PHPUnit group" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4079 [13:36:34] How to get the counter of the page, given that title object is available [13:37:24] Hah, wtf, is this info not in the Title object? [13:37:26] That's strange [13:38:10] Aha [13:38:17] potter: WikiPage::getCount() [13:39:54] RoanKattouw: this info is not there in title [13:39:59] RoanKattouw: thanks for the answer [13:40:35] * sumanah listens to old US presidential campaign songs [13:42:05] Oh hey sumanah , did you see https://www.nytimes.com/2012/04/01/opinion/sunday/a-quantum-theory-of-mitt-romney.html ? [13:42:24] RoanKattouw: I saw lots of links to it and I saw a funny quote from it. Is it worth reading? [13:42:30] Yes absolutely [13:42:49] If you have some vague idea about the basic concepts in quantum physics [13:42:54] * ^demon goes back to reading Drift. [13:44:44] <^demon> I still can't believe she got Roger Ailes to write a review for the back jacket. [13:48:28] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3997 [13:49:33] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3998 [13:52:28] sumanah: ping [13:52:51] hi kevin_brown [13:53:31] 03(mod) Implement Gadgets 2.0 (tracking) - 10https://bugzilla.wikimedia.org/29272 summary; +comment (10Krinkle) [13:53:32] 03(mod) abbr element broken in IE 6 - 10https://bugzilla.wikimedia.org/24778 (10Krinkle) [13:54:06] 03(mod) Implement Gadget Manager (tracking) - 10https://bugzilla.wikimedia.org/29398 (10Krinkle) [13:54:36] kevin_brown: happy April. [13:54:37] 03(mod) Add support for (custom) loadScript sources to ResourceLoader - 10https://bugzilla.wikimedia.org/30022 (10Krinkle) [13:54:39] 03(mod) Implement Gadget Manager (tracking) - 10https://bugzilla.wikimedia.org/29398 (10Krinkle) [13:55:07] yeah, I know, I guess I should be kind of happy the pilot didn't have a sense of humor yesterday [13:55:21] * kevin_brown can't believe it's already april [13:56:17] New review: Hashar; "saper can you confirm?" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4073 [13:58:04] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3999 [14:05:22] kevin_brown: Maybe they fooled you though :P [14:05:34] New review: saper; "It's a leftover from my PgSQL transaction work; sure go ahead to remove it." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/4073 [14:05:36] I once had to convince someone on April 1st that it was April 1st [14:05:53] man, that joke took hours xD it kept coming back that night [14:06:11] a nice paradox to crack your head open with [14:07:49] lol, awesome :D, the most fun I had was telling someone that the fastest way to get to the airport was the turquoise line (just came back from Boston) [14:08:04] New review: Tpt; "(no comment)" [mediawiki/extensions/ProofreadPage] (master) C: 1; - https://gerrit.wikimedia.org/r/4052 [14:13:26] New review: Catrope; "Two minor issues in the flagging class (they were present before, and I'd pointed them out in the ol..." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/4000 [14:13:59] New review: Krinkle; "(no comment)" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/4078 [14:14:00] anyway, kevin_brown - did you need to ping me about something? [14:15:50] is it just me, or is the wikidata mailing list turning into like bikeshedding/yakshaving central? [14:16:46] New review: Krinkle; "(no comment)" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/4078 [14:18:48] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/4000 [14:19:19] am publicizing the Berlin event [14:19:35] (thank you, Twinkle & custom templates) [14:19:55] New review: Krinkle; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3991 [14:22:05] New patchset: MaxSem; "Fixed api.php?action=parse&format=xmlfm hitting PCRE limit. By the way, regexes weren't needed here at all." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4082 [14:22:46] New review: Platonides; "Allows tag injection:" [mediawiki/core] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/3912 [14:24:04] https://www.mediawiki.org/w/index.php?title=Extension:OpenID&oldid=508727&diff=518716 So why is this not acceptable? [14:27:04] New review: MaxSem; "Contains a lot of unrelated empty lines removal" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/4079 [14:27:04] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4001 [14:29:58] New review: Platonides; "Even for untouched files. I recommend recommiting without the WS changes. Otherwise, it looks good." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4079 [14:30:36] I am going to enable Jenkins feedback to Gerrit changes [14:30:49] which means: SPAM! :-D [14:31:01] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4002 [14:31:23] ha [14:31:45] hi Krenair -- could you clarify? [14:32:38] sumanah, it's a pending revision that's not acceptable or unacceptable [14:32:53] New patchset: Hashar; "Regroup all API tests in the 'API' PHPUnit group" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4079 [14:32:54] Krenair: ah. I don't know. [14:32:56] The accept and reject revision buttons are greyed out [14:33:06] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4003 [14:33:23] <^demon> They aren't for me. Maybe you don't have permission to review changes? [14:34:00] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4079 [14:34:42] ^demon, I've got the editor flag [14:34:54] <^demon> Hmm, don't know. [14:35:08] Which has review rights [14:36:31] New review: Catrope; "Scary code was removed in change 4000, approving." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3994 [14:36:54] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4079 [14:37:02] New review: Reha Sterbin; "That parameter was a bad idea, which was why I removed it when I created the flagging class." [mediawiki/extensions/ArticleFeedbackv5] (master) C: 1; - https://gerrit.wikimedia.org/r/3994 [14:37:37] <^demon> hashar: -Misc also includes api tests? [14:37:46] no they are in -API [14:38:04] https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/229/ [14:38:08] there is 4 child jobs [14:38:14] <^demon> https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Misc/4/testReport/(root)/ApiBlockTest/testMakeNormalBlock/ [14:38:25] <^demon> Yeah, -Misc and -API are both failing [14:38:27] <^demon> Same test [14:38:28] though jenkins is bugged somehow and does not give the child build number :-(((( [14:38:43] ohh [14:38:47] so that is a bug!! [14:38:51] API should be excluded [14:39:21] quick gerrit question -- if I've got a -1 code review, and I've fixed the issue, how do I send it back for review? do i mark it +1 myself, or is there some sort of analogous action to the old fixme->new? [14:39:35] <^demon> hashar: No, you've misconfigured. [14:39:51] <^demon> https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Misc/configure - shows 'phpunit-api' as the build target. [14:40:04] and https://gerrit.wikimedia.org/r/#change,4079 is not merged yet [14:40:10] <^demon> rsterbin: If you submit a new patchset, everyone's reviews are reset to 0. [14:40:28] rsterbin: I'm already about to submit an amendment [14:40:59] rsterbin, https://www.mediawiki.org/wiki/Git/Workflow#Amend_your_change [14:41:02] ^demon: what counts as a new patchset? any new commit i send to gerrit? [14:41:07] rsterbin: But if you have one lined up, please do submit that [14:41:24] rsterbin: No, it's an --amend of your existing commit, as per the doc page MaxSem linked [14:41:50] RoanKattouw: not yet; I was stuck on sending back to you the one I had already fixed ;) [14:42:01] Oh Ok [14:42:04] cool, thanks, reading now [14:42:11] The one with the 'system' param? I'd already approved that one [14:42:18] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4079 [14:42:22] I realized it had been fixed later right before you submitted your comment [14:42:38] yeah [14:43:07] The short version of how to fix your commit is this: [14:43:13] git review -d 4000 (the number in the Gerrit URL) [14:43:16] change files [14:43:19] git commit --amend -a [14:43:23] git review -R [14:43:33] what's the -R for? [14:43:39] --no-rebase [14:43:56] By default, git review will rebase your commit onto the most recent state of master [14:44:03] aaah [14:44:06] That's usually not a good idea for amendments, it clutters the diffs [14:44:06] <^demon> Oh, are we recommending -R now? [14:44:11] then i think that wiki page needs an update [14:44:13] ^demon: For amendments I am, yes [14:44:17] It does [14:44:25] I am recommending it but "we" aren't yet [14:44:40] https://www.mediawiki.org/wiki/Git/Workflow#Amend_your_change just says "git review" [14:44:58] Yeah, the doc page isn't updated yet because I haven't discussed this practice with others yet [14:45:07] whoops, apparently language comprehension is not my strong suit today [14:45:17] heh, no worries :) [14:45:22] :) [14:45:31] It's a confusing situation [14:45:46] are you submitting the amendment on that change, or am i? [14:45:59] If you have it lined up, you should do it [14:46:03] it's not [14:46:14] <^demon> RoanKattouw: https://www.mediawiki.org/w/index.php?diff=518900 [14:46:17] OK, I have it ready to go, including a rebase of the commits that build on it [14:46:17] er, I do not have it lined up [14:46:41] hi everybody, can someone teach me how to change individual pages of mediawiki? [14:46:41] New patchset: Catrope; "Updated autoflag to work with new flagging class" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4001 [14:46:42] New patchset: Catrope; "Moved flagging out into its own class" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4000 [14:46:43] New patchset: Catrope; "Added auto-request-oversight custom action to the abuse filter" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4003 [14:46:44] New patchset: Catrope; "Added auto-hide custom AbuseFilter action" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4002 [14:46:54] There, sorry for the spam [14:46:57] hi everybody, can someone teach me how to change individual pages of mediawiki? [14:47:07] I had to update 4001-4003 too because they would otherwise depend on the old version of 4000 [14:47:09] i mean the width [14:47:22] example, i need the width change to 2000px [14:47:26] how to do that? [14:48:03] New patchset: Hashar; "Regroup all API tests in the 'API' PHPUnit group" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4079 [14:48:09] RoanKattouw: I've got a change lined up that depends on that group -- just a verbiage change for Fabrice [14:48:16] Oh [14:48:18] Hmm [14:48:21] how do I make sure it depends on your version, not mine? [14:48:23] Hang on a minute while I merge that entire group [14:48:36] !skin | aryadisetiawan [14:48:36] aryadisetiawan: http://www.mediawiki.org/wiki/Manual:Skins>. Skin usage: . Gallery of CSS styles: . Writing your own: http://blog.redwerks.org/2012/02/08/mediawiki-skinning-tutorial/ and the historical archive [14:48:44] ^demon, sumanah: I noticed the previous revisions had been validated (quality revision) by a coder. Maybe that's why I can't accept them? [14:48:46] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4000 [14:49:00] aryadisetiawan: just one particular page on your MediaWiki installation, right? not all the pages? [14:49:10] accept it* [14:49:12] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4079 [14:49:18] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4001 [14:49:31] @sumanaha: yes [14:49:33] <^demon> aryadisetiawan: Please do not /msg random people in the channel when you're already asking here. [14:49:36] not all pages [14:49:40] but individual pages.. [14:49:54] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4002 [14:49:56] @demon:sorry [14:50:12] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4003 [14:50:20] !tabcompletion | aryadisetiawan [14:50:20] aryadisetiawan: Instead of manually typing another person's nickname in IRC, you can type the beginning of their name and hit TAB on your keyboard to get it autocompleted, like on the command line. This avoids misspellings. Just make sure it's the right person! [14:51:19] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3993 [14:51:38] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4000 [14:51:40] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3997 [14:51:41] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3995 [14:51:42] Change merged: Reedy; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3996 [14:51:43] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3998 [14:51:44] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3999 [14:51:46] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4001 [14:51:47] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4002 [14:51:48] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4003 [14:51:49] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3994 [14:52:32] rsterbin: OK so that whole set of changes is merged now. So now if your working directory is clean (no uncommitted changes), do: [14:52:34] git checkout master [14:52:36] git pull [14:52:43] git checkout mybranchwhereIhavemyotherchanges [14:52:47] ok, will do [14:52:48] git rebase master [14:53:19] That may or may not work properly, you should check the resulting history [14:55:54] New patchset: Hashar; "Regroup all API tests in the 'API' PHPUnit group" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4079 [14:56:09] New patchset: Catrope; "Renamed the bucket parameter to aftv5_form" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3918 [14:56:26] New review: Hashar; "(no comment)" [mediawiki/core] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4079 [14:56:29] Change merged: Hashar; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4079 [14:56:48] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/3918 [14:56:50] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/3918 [14:57:02] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4079 [14:58:00] sumanah: yeah, I've been reading through wikitech-l and catching up. Other than the post you linked me to should I be aware of anyone else who is trying to get in contact with me? [14:58:17] kevin_brown: try grepping? [14:58:45] okay, doing that :) [15:00:51] kevin_brown: a quick search of my email says: Alexis and everyone else from the Internet Archive, the Wikidata-l list, Alolita, Matthew Becker... [15:00:55] How do I send another patch set to gerrit? I want to make some changes based on feedback. [15:01:10] New patchset: Catrope; "Renamed af_bucket_id to af_form_id; added af_experiment field to carry the experiment used for clicktracking" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4030 [15:01:15] !amend [15:01:15] I don't know anything about "amend". [15:01:29] !amend is https://www.mediawiki.org/wiki/Git/Workflow#Amend_your_change [15:01:29] Successfully added keyword: amend [15:01:32] !amend | Beau_ [15:01:32] Beau_: https://www.mediawiki.org/wiki/Git/Workflow#Amend_your_change [15:01:43] RoanKattouw: there was something about not using amend on wikitech, but it was tl;dr [15:02:28] Beau_: Someone suggested not using --amend but there was a lot of resistance [15:02:29] New patchset: Reha Sterbin; "Updated verbiage to match requirements; resize the modal window after adding the response message" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4088 [15:02:55] RoanKattouw: oh okay, so if that page is up to date I will follow it, thanks [15:03:24] ping JeroenDeDauw [15:03:26] RoanKattouw: https://gerrit.wikimedia.org/r/4088 -- dependency is totally wrong. how do i fix that? [15:03:45] harshit14: pong [15:04:05] rsterbin: It's wrong because I was doing stuff in the meantime. I'm fixing it [15:04:15] thx [15:04:19] (Sorry about that, I thought you said it was dependent on the other patch chain) [15:04:46] it is, but i had to cherry-pick it [15:04:46] JeroenDeDauw: Hi, I am Harshit Shrivastava. Wanted to discuss a few projects under SMW. [15:05:12] clearly I was doing something wrong in the rebase, but I don't know what it was. [15:05:19] New patchset: Catrope; "Renamed af_bucket_id to af_form_id; added af_experiment field to carry the experiment used for clicktracking" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4030 [15:05:32] rsterbin: I'll sort it out [15:05:36] thanks [15:06:17] Change abandoned: Catrope; "Squashed into https://gerrit.wikimedia.org/r/4030" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4031 [15:06:22] kevin_brown: all of these are people I have cc'd you on in the past. [15:06:28] or forwarded to you. [15:06:39] 14(INVALID) Monobook user edit buttons go first - 10https://bugzilla.wikimedia.org/35068 +comment (10Danny B.) [15:07:03] ^demon: is https://www.mediawiki.org/wiki/Git/Gerrit_project_ownership#Ownership_structure accurate? [15:08:01] JeroenDeDauw: In the SMW query management and smart updates project, what is expected in the project? [15:08:04] rsterbin: Hah, looks like 4088's parentage isn't as screwed up as we thought, its parent is the latest commit in master [15:08:27] well, it's good to know I did something right! ;) [15:08:54] harshit14: we already have a good student for this project, you are probably better off looking for another task :) [15:09:25] New patchset: Szymon ?wierkosz; "(bug 30725) A link to the index is missing for single paged documents." [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/4040 [15:09:48] JeroenDeDauw: hmm..can i discuss other SMW projects? [15:10:04] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4088 [15:10:07] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4088 [15:10:49] New patchset: GWicke; "Change path to parserTests from phase3 to core after switch to git." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4092 [15:11:19] JeroenDeDauw: In the other SMW project, "More powerful result formatting for SMW", what is expected? [15:12:02] New review: Catrope; "(no comment)" [mediawiki/extensions/VisualEditor] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4092 [15:12:04] Change merged: Catrope; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4092 [15:12:08] Hey gwicke now that you're here [15:12:19] New review: Szymon ?wierkosz; "Zaran, you were right. I have made the change as you suggested." [mediawiki/extensions/ProofreadPage] (master) C: 0; - https://gerrit.wikimedia.org/r/4040 [15:12:19] Why is data-mw-rt not called data-json-mw-rt ? [15:12:27] It's JSON data after all [15:12:43] Also, the way the parser outputs links is broken currently, with respect to WikiDOM / linear model conversion [15:12:47] * RoanKattouw digs up the details [15:13:11] well, I see little point in adding -json if we know it is always going to be json [15:13:44] New patchset: Platonides; "Improve MWCryptRand comments a bit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4093 [15:13:52] gwicke: But there's an attribute conversion function that uses the data-foo vs data-json-foo convention to decode the data correctly [15:14:08] You wrote it ;) [15:14:10] that was just a generic hack [15:14:23] but I think it is easier to just use a single attribute [15:14:45] with an object inside, so we can extend it [15:14:50] OK [15:14:53] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4093 [15:15:12] Could you read convertAttributes() (starts at line 125) in https://gerrit.wikimedia.org/r/#patch,unified,3931,1,modules/parser/mediawiki.LinearModelConverter.js then? [15:15:25] Please also read the FIXME comment on lines 92-94 [15:15:36] It's possible that I'm doing it wrong because I ported some of your old code [15:16:09] JeroenDeDauw, a pointer says 'dynamic and more flexible result views'. What exactly is meant by this? [15:16:33] 03(mod) "Download as PDF" does not open page as a PDF - download gets stuck. - 10https://bugzilla.wikimedia.org/35645 +comment (10Sam Reed (reedy)) [15:16:38] 03(mod) "Download as PDF" does not open page as a PDF - download gets stuck. - 10https://bugzilla.wikimedia.org/35645 04BLOCKER->major (10Sam Reed (reedy)) [15:16:44] 03(mod) "Download as PDF" does not open page as a PDF - download gets stuck. - 10https://bugzilla.wikimedia.org/35645 (10Sam Reed (reedy)) [15:17:08] RoanKattouw: initially I started to add several different attributes for source position, link types, html vs. wikitext source etc [15:17:37] but just stashing everything in a single json objects should be simpler [15:17:41] OK [15:17:49] Yeah I did note data-mw-rt seemed to have some of the info [15:17:59] it is not complete at all [15:18:01] And there's stuff like sourcePos and somethingelsePos that's sometimes there and sometimes isn' [15:18:03] t [15:18:09] HOLY HELL [15:18:09] Yeah I got that impression :) [15:18:09] yep [15:18:13] git bisect is super fast :-D [15:18:20] hashar: The power of binary search ;) [15:18:38] only a handful productions add source positions right now [15:18:39] https://www.mediawiki.org/w/api.php?action=query&meta=siteinfo&siprop=interwikimap [15:18:41] wat [15:19:21] gwicke: What's great though is that my converter (mostly) works! :) [15:19:31] I just need to move it to the client side component per Trevor [15:19:34] very nice ;) [15:19:51] Although... not sure how that'll work [15:19:51] it looks much tidier [15:19:54] I'll discuss that with him later [15:19:58] with the switch removed etc [15:20:06] Yeah I decided to rewrite it from scratch then copy a lot of your code [15:20:14] I think the structure is nicer overall [15:20:21] Also, LM is a simpler format than WD, that simplifies things [15:20:35] Also this means the href->title rewrite is no longer necessasry [15:20:42] Kevin_, are you there? [15:20:54] (at least I don't think it is -- maybe VE does expect that but we can change that) [15:21:21] New patchset: Platonides; "Improve MWCryptRand comments a bit." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4093 [15:21:22] I read somewhere that if we use $wgmemc it works with or without memc, is that right? [15:21:25] hi about css for individual page, i already tried it. so example i want to make a page called mywiki/article_name to be 2000px width i already make a css on mywiki/article_name/theme_name.css but nothing happen. i already edit te LocalSettings.php $wgAllowUserCss to true, but still nothing happen. [15:21:40] New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4030 [15:21:45] Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4030 [15:22:01] 03(NEW) ApiBlockTest::testMakeNormalBlock() broken - 10https://bugzilla.wikimedia.org/35646 major; MediaWiki: API; (hashar) [15:22:09] nischayn22: That's right. It will work with any caching backend available, or a fake cache if there's nothing to use [15:22:10] RoanKattouw: we can also shorten data-mw-rt to just data-mw [15:22:17] That too [15:22:18] New review: Hashar; "Bug logged : https://bugzilla.wikimedia.org/35646" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3434 [15:22:24] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3978 [15:22:27] aryadisetiawan: Yeah Page/vector.css doesn't work [15:22:29] aryadisetiawan: I don't think it works that way.... [15:22:31] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4093 [15:22:50] aryadisetiawan: Every page has its own class, you can generally do stuff like body.Page_name { width: 2000px; } in your CSS pages [15:22:52] why is jenkins so picky? [15:22:54] JeroenDeDauw: see RoanKattouw 's msg ^ [15:22:59] 03(mod) ApiBlockTest::testMakeNormalBlock() broken - 10https://bugzilla.wikimedia.org/35646 +platformeng; +comment (10Antoine "hashar" Musso) [15:23:10] To find the exact class name, see the HTML source of the page in question [15:23:56] New review: Demon; "(no comment)" [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/3987 [15:23:59] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3987 [15:24:26] hashar: Did you break Jenkins? re Platonides's complains and change [15:24:33] hashar: ...4093 [15:24:45] !c 4093 [15:24:45] See http://svn.wikimedia.org/doc/class4093.html [15:24:48] ... [15:24:52] !g 4093 [15:24:52] https://gerrit.wikimedia.org/r/4093 [15:25:18] RoanKattouw: we have an API test failing in master [15:25:25] so that makes everything failing :-D [15:25:28] aha [15:25:36] Then why doesn't Jenkins want to tell me what the cause is? [15:25:37] New review: Demon; "(no comment)" [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/3702 [15:25:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=35646 [15:25:59] <^demon> hashar: You've got changes submitted for shutting up the bot on review, right? [15:26:13] RoanKattouw: thanks, i will try.. but it seems to long. for example at mediawiki.org main page i found the class name is : am i right? [15:26:17] RoanKattouw: jenkins is not smart enough. The change is already in master and it has not really feature to compare failing tests in before and after applying the patch [15:26:45] aryadisetiawan: It's a list of classes, separated by spaces. You can use any of those. The one you want is page-MediaWiki in this case [15:26:53] ^demon: I am not sure I understand what you mean sorry :-( [15:26:57] hashar: I get that, but how do I see what the failure is? [15:27:03] New review: Demon; "(no comment)" [mediawiki/core] (master); V: 1 C: 0; - https://gerrit.wikimedia.org/r/4066 [15:27:06] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4066 [15:27:21] <^demon> hashar: We want gerrt-wm to only report on new patchset and merge, not on every review. [15:27:22] hashar: At https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/234/ I mean [15:27:45] RoanKattouw: yeah and it is broken for some reason :-((((((((((((( [15:27:46] ^demon: What, not for reviews? [15:27:58] <^demon> This was suggested a couple of times to me. [15:28:03] I like seeing what people are saying to each other in real time :) [15:28:04] RoanKattouw: that link should show the children builds numbers as well as aggregated tests results [15:28:20] <^demon> RoanKattouw: Keep the reviews in #mediawiki-codereview for the people who want the noise. [15:28:24] <^demon> But keep it out of #mediawiki [15:28:28] ^demon: does it trigger a change on every review ?? [15:28:37] hashar: No, this is the IRC logger, not Jenkins [15:28:49] hashar: Aha, I see now. However, I have no way to see WHICH of the sub-builds broke [15:28:54] other than looking at all of them one by one [15:29:05] yeah that is a bug [15:29:09] it used to work :-\ [15:29:13] https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/234/aggregatedTestReport/? is supposed to do this but it's useless [15:29:39] and it knows about the build number!!! see the console output at https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/234/console [15:29:47] so I need to find out what is going wrong :-( [15:30:05] rsterbin: My review dashboard for AFTv5 ( https://gerrit.wikimedia.org/r/#q,status:open+project:mediawiki/extensions/ArticleFeedbackv5,n,z ) is empty now, everything you submitted should be merged now. Was that all for Wednesday's deploy? [15:30:18] yep [15:30:28] RoanKattouw: what will be the fake cache? [15:30:32] Sweet [15:30:48] nischayn22: set() does nothing, get() always returns false [15:31:05] hmm, nice [15:33:49] New patchset: GWicke; "Magic links and behavior switch tokenization by Ori Livneh" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4094 [15:34:28] 03(mod) replacing "hidden by Article Feedback V5" link with the actual account - 10https://bugzilla.wikimedia.org/35501 normal->15enhancement (10Yoni Shostak) [15:34:50] coffee break [15:35:23] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4093 [15:36:55] <^demon> RoanKattouw: I like the info too, but it makes this channel too damn noisy :) [15:37:14] True [15:37:24] I withdraw my objection [15:37:45] New patchset: Alex Monk; "Renamed 'metawikipedia' interwiki link prefix to 'metawikimedia' - Meta-Wiki deals with more projects than just Wikipedia. See https://www.mediawiki.org/wiki/Wikipmediawiki" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4095 [15:38:40] uh, --regex doesn't seem to work to run only some parser tests... [15:38:41] 03(mod) Integrate Jenkins with Git - 10https://bugzilla.wikimedia.org/34141 +comment (10Mark A. Hershberger) [15:38:44] is there a trick to it? [15:38:54] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4095 [15:38:56] --regex="" runs a [15:39:28] ...uns all parser tests [15:39:32] *runs [15:39:38] * Daniel_WMDE has a new keyboard [15:40:16] 03(mod) Pages with name ending with '/.' are not accessible - 10https://bugzilla.wikimedia.org/21796 +comment (10Marcin Cieślak) [15:42:02] New review: Demon; "It was called the meta wikipedia back in the day :)" [mediawiki/core] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4095 [15:42:22] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4095 [15:43:02] 03(mod) Problems with UploadWizard stash moving to the target - 10https://bugzilla.wikimedia.org/35354 +comment (10Mark A. Hershberger) [15:43:21] New review: Demon; "(no comment)" [mediawiki/core] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4073 [15:43:24] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4073 [15:44:25] 03(mod) Add message documentation for messages added in gerrit ref 3320 - 10https://bugzilla.wikimedia.org/35517 (10Mark A. Hershberger) [15:45:29] gwicke: https://domain.tld/wiki/Wikidata_set?externaledit=true <- what will the external editors end up with for non-wikitax? [15:46:06] New review: Demon; "(no comment)" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/4093 [15:46:08] RoanKattouw:thank you very much. it works perfectly! [15:46:18] 03(mod) Pages with name ending with '/.' are not accessible - 10https://bugzilla.wikimedia.org/21796 +comment (10Beau) [15:46:47] Amgine: support for a few more mime types could be added to the external editor tools I guess [15:47:08] if it still works similar to the old perl script [15:47:25] They get this: http://www.mediawiki.org/wiki/Manual:External_editors:_control_files [15:48:01] Platonides: i can't reproduce the tag injection you mention in your review of the a-tag stuff [15:48:08] i'm submitting a parser test covering it [15:48:56] Amgine: so the assiciation with an application is based on the file extension? [15:49:27] 03(FIXED) Article Feedback v5 - Text box scroll bar is floating 5 pixels off the border on Firefox - 10https://bugzilla.wikimedia.org/35443 (10Yoni Shostak) [15:49:43] User browser specified, gwicke. [15:49:48] Amgine: I might confuse this with the general external edit capability I used a long time ago [15:49:54] that also supported images etc [15:50:16] Hum. [15:50:23] 03(FIXED) Remove all feedback forms but option 1 - 10https://bugzilla.wikimedia.org/35586 (10Yoni Shostak) [15:50:54] I think Erik wrote a perl script at some stage that you could then configure as a handler for a wiki-specific mime type [15:51:18] This may manage the extension as well, gwicke; I think the examples just happen to be .wiki [15:52:01] 03(FIXED) Add proper bucket field to aft_article_feedback table - 10https://bugzilla.wikimedia.org/35619 (10Yoni Shostak) [15:53:00] 14(INVALID) Article Feedback v5 - "X" Close Button positions the flyover panel in the wrong location on Chrome - 10https://bugzilla.wikimedia.org/35445 (10Yoni Shostak) [15:53:04] Amgine: this should be quite simple to extend with new extensions [15:53:06] New patchset: Platonides; "Alphabetically sort the interwikis. Added a comment about WMF wikis." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4097 [15:53:14] New review: Demon; "I like the idea, to be honest. If we didn't have wfParseUrl(), wfAppendQuery() and the others, we wo..." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/4069 [15:53:14] wikidata+json for example [15:53:26] What edits *that*? [15:54:04] that could start some specialized WikiData editor app [15:54:06] 03(FIXED) Make AFTv5 url parameters work all the time - 10https://bugzilla.wikimedia.org/35587 (10Yoni Shostak) [15:54:15] New review: jenkins-bot; "Build Failed " [mediawiki/core] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/4097 [15:54:34] Platonides: actually, i can confirm it after git pull... something seems to have broken recently. [15:54:35] which reads the JSON, lets the user modify it using some widgets and serializes it out again [15:54:43] Heh, so we start a file type for which there is no editor but the wikidata extension. [15:55:05] you could also edit it using vim [15:55:13] New review: Demon; "Whitespace issues, commit message is really long" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/4051 [15:55:18] I still have a soul, gwicke. [15:55:25] 03(mod) Some IPs hidden without any log or apparent reason on frwiki - 10https://bugzilla.wikimedia.org/35578 +comment (10Mark A. Hershberger) [15:55:27] Amgine: ;) [15:56:14] New review: Demon; "If you're going to fix this, could you also fix interwiki.list if it's not correct?" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4097 [15:56:38] !doc [15:56:38] An overview of available documentation about MediaWiki can be found at [15:56:39] Amgine: Moin IIRC has mime types as well [15:56:51] they might also have more editor support for those [15:57:11] !doxygen [15:57:11] http://svn.wikimedia.org/doc [15:57:48] We need to chat about logo/icon. [15:57:58] Was Code docs moved as part on the Git migration? [15:58:10] Jenkins restarting [15:58:31] okay Amgine [15:58:45] heatherw: #Wiktionary-mobile ?? [15:59:41] New review: Zaran; "(no comment)" [mediawiki/extensions/ProofreadPage] (master) C: 1; - https://gerrit.wikimedia.org/r/4040 [16:00:25] 03(mod) Show/Hide buttons intermittently not working in ICS - 10https://bugzilla.wikimedia.org/35546 (10Mark A. Hershberger) [16:00:35] Daniel_WMDE, it's strange, the fault seems to be in the preg_replace being too simplistic [16:00:46] 03(mod) Unable to scroll horizontally - 10https://bugzilla.wikimedia.org/35548 (10Mark A. Hershberger) [16:01:00] <^demon> Something's not right with docs, hmm. [16:01:06] then you still need to bypass the Sanitizer (that's why I used a ) [16:01:10] 03(mod) When returning from Nearby to article, the search bar moves leaving a one or two pixel gap - 10https://bugzilla.wikimedia.org/35549 (10Mark A. Hershberger) [16:01:20] but doesn't seem anything "new" [16:01:22] I am disabling jenkins comment again [16:01:32] 03(mod) Bad network detection - 10https://bugzilla.wikimedia.org/35550 (10Mark A. Hershberger) [16:01:49] 03(mod) Cannot scroll low enough to see all content - 10https://bugzilla.wikimedia.org/35551 (10Mark A. Hershberger) [16:01:51] hello [16:01:52] ^demon: hashar said jenkins was restarting, but I don't know if it has a link to the docs. [16:01:58] why did git migration break the old parserTests.php ? [16:02:16] <^demon> Platonides: In what way? [16:02:19] 03(mod) Top section isn't automatically expanded - 10https://bugzilla.wikimedia.org/35552 (10Mark A. Hershberger) [16:02:21] <^demon> Soli: No that's unrelated. [16:02:31] it works in svn, but fails in 4b8e45d60472ae6a0b5c4ad8728a476ad530519b (last svn commit in git) [16:02:48] Error: 1146 Table 'my_wiki.parsertest_objectcache' doesn't exist (localhost) [16:03:11] 03(mod) 404 Not Found "legal.html" on dump mirrors - 10https://bugzilla.wikimedia.org/35564 (10Mark A. Hershberger) [16:03:31] <^demon> Does it fail on svn co of that revision? [16:03:38] 03(mod) Progress Icon for Listen In - 10https://bugzilla.wikimedia.org/35573 (10Mark A. Hershberger) [16:03:49] <^demon> Oh, hrm. [16:03:52] <^demon> Bizzare. [16:04:10] indeed [16:06:04] 03(mod) Integrate Jenkins with Git - 10https://bugzilla.wikimedia.org/34141 +comment (10Antoine "hashar" Musso) [16:06:04] 03(mod) ApiBlockTest::testMakeNormalBlock() broken - 10https://bugzilla.wikimedia.org/35646 (10Antoine "hashar" Musso) [16:06:55] ^demon: got a minute for me? i'm at a loss wrt gerrit and stuff.... [16:06:59] hi ^demon [16:07:04] <^demon> Ahhhhhh [16:07:06] * ^demon runs and hides [16:07:06] :P [16:07:12] hehehe [16:07:16] 03(FIXED) Thumbnail not fully rendered - 10https://bugzilla.wikimedia.org/35576 +comment (10Mark A. Hershberger) [16:07:42] aww [16:07:50] I don't want to have that effect to people [16:07:59] 03(mod) Need Icon for market beta version of Wikipedia Android app - 10https://bugzilla.wikimedia.org/35577 (10Mark A. Hershberger) [16:08:15] ^demon: ok, here's the deal. i submitted a patch for review. now i essentailly want to add a parser test to that path. do i work on the feature branch? do i branch the feature branch? how do i check this out, and submit it to review, so gerrit understands? [16:08:18] <^demon> Platonides: I'm not going to dig into it too far right now. Feel free to toss it in BZ and CC me on it. [16:08:27] <^demon> Nikerabbit: Hi :) [16:08:28] Nikerabbit: i think he was reacting to me :) [16:08:51] ^demon: can you get me on the right track? [16:08:53] <^demon> Daniel_WMDE: So you want to submit a patch set 2 for an existing change? [16:08:59] Daniel_WMDE: are you sure? because I've been bugging ^demon for many days now :) [16:09:01] 03(FIXED) Farsi translations are incorrect in the jQuery datepicker - 10https://bugzilla.wikimedia.org/35579 (10Mark A. Hershberger) [16:09:06] ^demon: essentially, yes [16:09:15] ^demon: i don't know if it have it's own branch or not. [16:09:27] 03(mod) Closure of nz.wikimedia.org - 10https://bugzilla.wikimedia.org/35581 (10Mark A. Hershberger) [16:09:27] Nikerabbit: hehehe :) [16:09:28] <^demon> You have git-review, yes? [16:09:31] yes [16:09:37] New patchset: IAlex; "Moved Preferences::trySetUserEmail() to User::setEmailWithConfirmation()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4099 [16:09:41] <^demon> What's the change you're wanting to amend? [16:10:14] ^demon: https://gerrit.wikimedia.org/r/#change,3912 <-- this is the original patch. platonides has a concern. i want to submit a patch that will address his concern. [16:10:23] 03(mod) Jenkins job: universal lint check - 10https://bugzilla.wikimedia.org/35585 (10Mark A. Hershberger) [16:11:07] * Daniel_WMDE think that this is a pretty common use case [16:11:10] <^demon> Daniel_WMDE: Ok, so you do `git review -d 3912` which will fetch your changes and apply them to a new local branch [16:11:45] 03(mod) Disparity between submit clicktracking events and AFTv5 records created - 10https://bugzilla.wikimedia.org/35590 (10Mark A. Hershberger) [16:11:46] <^demon> Then you make your changes, and `git commit -a --amend`. Best practice is to add to the commit summary something like "Patchset 2: I did bla blah" [16:12:08] 03(mod) Parsing of dates in Safari does not work - 10https://bugzilla.wikimedia.org/35598 (10Mark A. Hershberger) [16:12:14] ^demon: should i *really* use amend? wasn't there a big discussion discuraging amend for non-trivial changes? [16:12:29] <^demon> The problem isn't with amend, it's with the next step :) [16:12:34] <^demon> Then `git review -R` [16:12:50] <^demon> -R so you don't rebase against origin/master and pollute your patch with unrelated stuff. [16:12:59] ^demon: ok, hold on. does it matter what branch i'm on when i do the git review -d ? [16:13:40] <^demon> It shouldn't matter. [16:13:48] <^demon> It'll check you out to a branch called "review/daniel_kinzler/bug/33886" [16:14:37] You can't set user rights on IPs, right? [16:14:44] New patchset: Hashar; "(bug 32748) unicode URL for articles print version" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3897 [16:14:47] Krenair: i hope not [16:14:55] Okay [16:14:59] ^demon: ok... now i have to make it ignore my local changes first :) [16:15:07] ^demon: what's the equivalent of svn revert? [16:15:16] Daniel_WMDE, git stash to get a clean status [16:15:21] Daniel_WMDE: You can always stash your local changes with git stash [16:15:31] ugh, svn revert would be some git reset --hard [16:15:36] but I think it doesn't accept paths [16:15:50] git checkout is svn revert for files [16:15:53] New review: Hashar; "Patchset 4 just enhances commit message." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/3897 [16:15:58] and git clean is another related command [16:16:14] New patchset: GWicke; "Shorten data-mw-rt to data-mw and clean up whitelist" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4100 [16:16:23] RoanKattouw: looks like Jenkins learned how to track dependencies now : https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/240/ [16:16:35] <^demon> \o/ [16:16:44] RoanKattouw: that is done using a feature know as "fingerprinting". Aka each job will md5sum() some files [16:16:56] RoanKattouw: projects having the same set of md5 sums are considered to be related [16:17:20] ^demon: trying it now, thanks for your help [16:17:26] <^demon> Ok no problem. [16:17:28] RoanKattouw: so I just make every jobs to fingerprint .git/HEAD (which contains the sha1 of the patchset commit) [16:17:30] hashar: Yay! [16:17:53] ^demon: but, err, still... the amend bit... won't it confuse gerrit? i mean, the comments then apply to code that is no longer there, right? [16:17:59] I have a huuuugge backlog to fix up now :-( [16:18:25] <^demon> The --amend lets you adjust the commit summary as needed. [16:18:25] I'm trying to follow the example of variables here: http://www.mediawiki.org/wiki/Manual:Variable#Example -- but I run into this error: http://pastebin.com/FVRRdF9W [16:18:43] <^demon> Just treat it like a branch new commit summary. As long as you keep that Change-Id identical, there won't be a problem. [16:18:47] and that's even after fixing this line: $wgExtensionMessagesFiles['ExampleMagic'] = dirname(__FILE__) . '/Parser_function.i18n.magic.php'; (because it needs to point to Example.i18n.magic.php) [16:18:51] Platonides: i'm a bit confused - i tried to reproduce the tag injection, but couldn't. then i got myself in a muddle trying it with the latest head... [16:18:52] New review: Catrope; "(no comment)" [mediawiki/extensions/VisualEditor] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4100 [16:18:56] Change merged: Catrope; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4100 [16:19:00] <^demon> s/branch/brand/ [16:19:06] Platonides: trying again now. [16:19:19] 03(mod) Watchlist does not show all removed titles - 10https://bugzilla.wikimedia.org/35601 +comment (10Mark A. Hershberger) [16:19:34] 03(mod) Nearby fragile, sometimes starts very zoomed out - 10https://bugzilla.wikimedia.org/35605 (10Mark A. Hershberger) [16:23:22] !redirect [16:23:23] Redirects are used to forward users from one page name to another. They can be useful if a particular article is referred to by multiple names, or has alternative punctuation, capitalization or spellings. See [16:24:30] !doc [16:24:30] An overview of available documentation about MediaWiki can be found at [16:24:39] !svn doc [16:24:40] Subversion is a version control software that allows users to download the very latest version of a branch without having to wait for someone to get around to packaging it. Advantages to using Subversion include the latest version, vastly simplified updating, the ability to roll back an upgrade, the ability to create and submit patches. See http://www.mediawiki.org/wiki/Subversion for more information. [16:25:52] 03(mod) Notes/refs that have separate paragraphs - 10https://bugzilla.wikimedia.org/6311 (10bluehairedlawyer) [16:27:25] New patchset: Reedy; "Fixing up LSB related stuff.. Some code duplication, but meh for the moment (yay for us using static classes for hooks)" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/4102 [16:27:37] Platonides: can't reproduce, will amend my patch with a parser test covering your test case [16:28:52] New patchset: Reedy; "Fixing up LSB related stuff.. Some code duplication, but meh for the moment (yay for us using static classes for hooks)" [mediawiki/extensions/AntiSpoof] (master) - https://gerrit.wikimedia.org/r/4103 [16:29:00] Platonides: is it possible that tag injections are possible in current head, unrelated to the a-tag patch? [16:29:19] hi sumanah. I got done with my GSoC application, please take a look at it and let me know if there is anything i can improve. http://www.mediawiki.org/wiki/User:Drecodeam/GSoC_2012_Application [16:29:31] hi drecodeam - looking now. [16:30:10] drecodeam: you should be committing code THROUGHOUT, not just at the end! [16:30:20] haha, yes [16:30:44] drecodeam: "Also i would be creating a repo for this project on GitHub for my daily progress. When i am done through a part or a section i would commit it to git repository on Gerrit." why/ [16:30:57] why do it like that? why not just commit to a branch in Gerrit, drecodeam ? [16:32:18] sumanah: i was not sure about it, so i thought that when i am done with significant changes, i would be committing to the gerrit. [16:32:21] sumanah, per https://www.mediawiki.org/wiki/Summer_of_Code_Past_Projects#Image_rendering_daemon I think we should make "commit to our repo" a policy [16:32:25] New patchset: Daniel Kinzler; "Introducing support for tags in wikitext as described in bug 33886." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3912 [16:32:33] drecodeam: no description in https://userscripts.org/scripts/show/120006 - you should fix that. [16:32:37] drecodeam: why? [16:32:40] MaxSem: agreed [16:33:27] sumanah: i would change it to be committing directly to the branch [16:33:34] good. :-) [16:33:50] drecodeam: I see https://addons.mozilla.org/en-US/firefox/addon/awesome-bar/?src=search looks like it was contributed by someone other than you. Did you link to the wrong add-on? [16:34:19] no, actually it was a hackathon in which me and my friend made it together. So it was uploaded by his account [16:34:30] ^demon: ok, i see the second change set in gerrit now. but how do i make it clear that I addressed platonied's concern? i can't seem to reply to his comment or comment on his review... [16:34:30] New patchset: Alex Monk; "Remove the user rights link from the Contributions/DeletedContributions pages for anonymous users, as you can't set user rights on anonymous users." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4104 [16:34:35] it was a firefox 4 launch party and we had a hackathon on extension [16:35:00] Daniel_WMDE: You should be able to reply to inline comments by clicking the comment, then clicking Reply [16:35:08] Daniel_WMDE: You can't reply to global comments, but you can submit new ones [16:35:27] RoanKattouw: by performing a 0-review? [16:35:34] this is all so obvious :) [16:35:44] Daniel_WMDE: Yes, a 0-review [16:35:51] And yes, don't you love how intuitive this is? ;) [16:35:53] drecodeam: In open source we take attribution pretty seriously. If you say "I have also contributed a GreaseMonkey Script and an Add-on to the AMO." then you need to be clear about what you actually wrote and avoid implying that you wrote the whole thing. [16:36:04] New review: Daniel Kinzler; "Problems with tag injections suggested by Platonides could not be reproduce, added a parser test to ..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/3912 [16:36:52] sumanah: then in that case i should remove it, or else mention that collaborated on the extension ? [16:37:08] drecodeam: tell me what you think you should do, and I will tell you :-) [16:37:34] 03(mod) Creation of a new mailing list for Kazakh Wikipedia (kk) - 10https://bugzilla.wikimedia.org/35518 +comment (10Thehelpfulone) [16:37:46] New review: GWicke; "Generally quite good, but please see my comments." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/4054 [16:38:12] sumanah: i think i should mention that i collaborated on the developing the extension [16:38:19] drecodeam: good idea :-) [16:38:41] drecodeam: if you can point to the *source code* of the extension so it's clear who wrote what, that's also good [16:40:02] sumanah: i would do that. thanks [16:40:08] Great [16:40:28] drecodeam: have you ever heard of "spell-check"? Your application has some grammar/punctuation errors. [16:40:40] New patchset: preilly; "Remove redirect for my homepage to landing page" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/4105 [16:41:31] sumanah: SMW is still on svn so I have to commit to svn and don't need to learn gerrit now, right? [16:42:08] nischayn22: You should ask the Semantic MediaWiki people what their plans are, and whether they will be switching to Git/Gerrit soon. [16:42:23] nischayn22: They include Yaron, JeroenDeDauw, and others. [16:42:29] New review: MaxSem; "(no comment)" [mediawiki/extensions/ZeroRatedMobileAccess] (master) C: 1; - https://gerrit.wikimedia.org/r/4105 [16:43:04] sumanah: i did proof read it for such errors. I guess i must have missed it at some places. I would look at it again right now [16:43:08] any recommendation what is the easiest way to pull git commits into svn? [16:43:12] New review: GWicke; "Looks good, and makes 14 more tests pass. Thanks!!" [mediawiki/extensions/VisualEditor] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/4094 [16:43:15] Change merged: GWicke; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4094 [16:43:24] sumanah: there have been discussions in the mailing lists about it, I don't think it will happen anytime soon [16:43:29] hashar: do you know what block token it's actually getting? [16:43:40] Reedy: I have investigated the issue [16:43:40] drecodeam: I learned years ago that it's difficult to catch errors in something I wrote. I suggest you ask a friend who has good English skills to look at it. [16:43:44] nischayn22 - yeah, SMW (and related extensions) are on SVN for now, but eventually they'll move to the Git repository. I don't know when. [16:43:50] Reedy: was busy configuring Jenkins today :-D [16:43:51] and I don't have commit access to svn [16:43:51] 03preilly * 10/branches/wmf/1.19wmf1/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php: 1.19wmf: MFG Change-Id: I8eea04193a9fa3c7361e3124981bf55704988030 [16:44:09] sumanah: true that. I think i would ask somebody for it. [16:44:28] nischayn22: have you written patches (that you submitted in Bugzilla) for Semantic MediaWiki? If so, the SMW people might be happy to recommend you for Subversion commit access. [16:44:35] Reedy: if you can have a look at it tonight that would be great. That is most probably a very minor fix thought it could potentially mean we have a bug in MediaWiki version we have released recently :-( [16:45:06] sumanah: yes I have written patches for SMW , will ask them [16:45:08] sumanah - anyone who gets accepted into GSoC gets commit access anyway, no? [16:45:10] drecodeam: And you could also try a mechanical spell-checker [16:45:17] (Assuming this project gets accepted.) [16:45:27] hashar: I guess I should move my trunk wiki install over to git... ;) [16:45:31] Yaron: yes, but while applying for GSoC, one might wish to get commit access earlier than late April. [16:45:39] That's true. [16:45:43] Commit access with git is more liberal too [16:46:00] hashar: there's already some followups needed... (they've been committed) [16:46:21] nischayn22: point me to the discussions (in the SMW community) regarding whether/when to move to git? [16:46:35] Reedy: yeah should actually switch to git [16:46:39] Reedy: like NOW :-D [16:46:50] New review: Reha Sterbin; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4088 [16:46:52] sumanah: I thought JeroenDeDauw had already requested for some projects.. [16:47:05] Reedy: I believe we will have to get the follow up reviewed and merged ASAP to unlock the tests [16:47:18] Reedy: you are right. https://www.mediawiki.org/wiki/Git/Conversion/Extensions_queue [16:47:27] Reedy: or I can mark that test as broken which will immediately solve the issue but I do not like hidding issues [16:48:14] hashar: I've been putting off attempting to migrate my dev installs. I suppose I should jfdi ;) [16:48:50] just start other with a new fresh copy [16:48:57] nischayn22: you might enjoy getting developer access https://www.mediawiki.org/wiki/Developer_access and being able to use Wikimedia Labs, no matter what Semantic MediaWiki has in its future. [16:49:01] I did : mv phase3 phase3-backup && git clone phase3 :-D [16:49:03] sumanah: hi. i am not able to get Mw in git due to proxy settings in my college :( [16:49:06] New review: Nikerabbit; "(no comment)" [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/3880 [16:49:13] Reedy: then copied LocalSettings.php from one to the other dir [16:49:17] Inded, [16:49:19] potter: "get MW in git" -- could you please be clearer? [16:49:20] Plus images [16:49:28] Then relocate some/all of the extensions [16:49:29] potter: do you mean, you can't do a git clone of the MediaWiki codebase? [16:49:32] as some are still in svn [16:49:33] 03(NEW) Retrieve the first image used on a page - 10https://bugzilla.wikimedia.org/35647 enhancement; MediaWiki: Images and files; (subfader) [16:49:38] sumanah: oh..i am not able to clone Mw in git [16:49:43] potter: or you can't submit code to gerrit.wikimedia.org? [16:49:56] potter: can you get around the proxy? [16:49:58] sumanah: the first one [16:50:09] potter: can you go to them and ask them to please give you an exemption, or change the rules? [16:50:12] extensionsgit and extensionssvn [16:50:15] sumanah: https://sourceforge.net/mailarchive/forum.php?thread_name=4F6B3051.2010406%40semantic-mediawiki.org&forum_name=semediawiki-devel [16:50:21] thanks nischayn22 [16:50:22] sumanah: it cannot happen, [16:50:37] sumanah: i will clone it once i am at home [16:51:22] New review: MaxSem; "See inline comments" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/4104 [16:51:36] nischayn22: hmm, I'm not sure you were reading these messages closely if your summary is "there have been discussions in the mailing lists about it, I don't think it will happen anytime soon" -- unless your definition of "soon" is different from mine. [16:51:39] sumanah: i even asked on IRC(ahroni) and i got no solution :( [16:51:53] potter: maybe you could try Tor? [16:52:06] sumanah: i tried it :( [16:52:28] 03(mod) Retrieve the first image used on a page - 10https://bugzilla.wikimedia.org/35647 +comment (10Sam Reed (reedy)) [16:52:36] potter: there must be people out there who are better than we are at evading proxies -- ask them, I guess. [16:52:53] sumanah: the problem is the port in which gerrit.mediawiki listens in blocked by the proxy [16:52:59] MaxSem: re your comment: Are you pointing out that I changed it from "User::newFromId( $id )" to "$userObj"? [16:53:12] yes [16:53:20] hashar: I'm going to end up having like 7 or 8 copies of a MW clone on my machine! [16:53:21] potter: if you want to be a consistent open source contributor, you will need to find a way to circumvent the block, or simply talk to your college administrators and get an exemption or a change. [16:53:30] MaxSem: I don't understand the problem with that change? [16:53:31] VPN? [16:53:49] potter, try using a SSH tunnel or talk to the admins ;) [16:54:00] sumanah: I just have to request an account or do I also need a recommendation for developer access ? [16:54:01] Y U NO LET ME USE INTERNET!? [16:54:16] MaxSem: line 352: $id = $userObj->getID(); [16:54:25] did you read the comment? User::newFromId( $id ) and $userObj->isAnon() are completely unrelated [16:54:27] Reedy: :D [16:54:28] nischayn22: you don't need a recommendation for developer access. [16:54:36] MaxSem: What's the point in then using User::newFromId ( $id )? [16:54:52] sumanah: i will try to evade proxy, but it will not happen soon, so can i submit patches in svn diff for 1-2 weeks [16:55:08] sumanah: and I meant that it won't happen soon because Markus and Jeroen are busy now [16:55:10] nischayn22: you also don't NEED a recommendation to get Subversion commit access, it's just slightly helpful so that it can happen faster [16:55:18] with Wikidata [16:55:21] Reedy: git clone can be made to use hard symbolic links which saves a lot of disk space [16:55:25] MaxSem: yes it's unrelated to the point of the commit [16:55:28] 03(ASSIGNED) Choose main screen menu icons - 10https://bugzilla.wikimedia.org/35620 +comment (10Patrick Hayes) [16:55:28] Reedy: I just git checkout between branches though [16:55:33] It's just something I noticed and fixed. [16:55:38] 03(mod) Unable to install on WAMP server - 10https://bugzilla.wikimedia.org/35606 (10Mark A. Hershberger) [16:55:38] potter: "submit patches in SVN diff" -- what? you're going to diff against the obsolete Subversion repository? [16:55:46] Reedy: out for dinner. will be back later for conference calls [16:56:00] Krenair, what's the point of passing bool to a function that expects a user object? [16:56:05] sumanah: oh...sad [16:56:21] 03(mod) MediaWiki incorrectly detects OOXML types of files saved by OpenOffice - 10https://bugzilla.wikimedia.org/35607 (10Mark A. Hershberger) [16:56:27] MaxSem: I'm not passing a bool, $userObj is a User object [16:56:29] sumanah: i thought even svn will run parallely for some time [16:56:44] potter: why did you think that? [16:57:10] potter: https://www.mediawiki.org/wiki/Git_conversion clearly states that starting March 21st, MediaWiki core development is happening in Git, not in SVN. [16:57:22] potter: We're not syncing back to Subversion with updates. SVN is now read-only. [16:57:32] Krenair, damn, I misread the diff [16:57:46] 03(mod) Wikimedia databases contains categorylinks with type "page" for media files - 10https://bugzilla.wikimedia.org/35609 +comment (10Mark A. Hershberger) [16:57:52] sumanah: ok.then i have to find my own way. I'll try out cyber cafe [16:58:17] New review: MaxSem; "Disregard that, I'm an idiot, Gerrit and FF suck." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/4104 [16:58:21] 03(mod) Wikimedia databases contains categorylinks with type "page" for media files - 10https://bugzilla.wikimedia.org/35609 +comment (10Mark A. Hershberger) [16:58:21] potter: as ashish_d suggests, and as Reedy suggests -- SSH tunnel, VPN, or TALK to the admins! [16:58:22] New review: Hashar; "This patch is fine to me. Might need Timo and Sam to review the latest squash then we can merge this..." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/3890 [16:58:25] sumanah: ^demon and I realised you can do git pull over https... But git clone doesn't seem to work well [16:58:34] Not sure why though [16:58:38] Reedy: when you have time, can you take a look at https://gerrit.wikimedia.org/r/#change,3890 ? (api tokens) [16:58:43] Reedy: I am out for dinner now. See you [16:58:47] New code comment: Nikerabbit;
'pagetriage-article-count' => 'A description of the number of articles in the list. $1 is the c; 
[17:00:02] 	 Reedy: so if i clone it once, i can start working right?(cause git pull works)
[17:00:09] 	 potter: quite likely
[17:00:22] 	 sumanah: link to get svn access please ?
[17:00:31] 	 potter: Do you need an initial clone grabbable via http?
[17:00:32] 	 Reedy: this will make situation simpler
[17:00:54] 	 Reedy: yes
[17:01:04] 	 nischayn22: https://www.mediawiki.org/wiki/Developer_access/Subversion gives you info.  https://www.mediawiki.org/wiki/Developer_access/Subversion#Requesting_commit_access has instructions.
[17:01:04] 	 potter: You can't submit things for review from an https clone, but you can make local commits and submit them later if your school relaxes the firewall, or if/when you move the data to another machine that's not firewalled
[17:01:23] 	 sumanah: thanks
[17:01:28] 	 nischayn22: you're welcome
[17:02:03] 	 RoanKattouw: ok. I have patches for 3 bugs, but not able to submit :(
[17:02:19] 	 sorry 2 bugs..
[17:02:52] 	 New patchset: Reha Sterbin; "Drop custom actions from this release (can pick these up in a later release)" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4106
[17:02:57] 	 nischayn22: did you clone the git repo?
[17:03:10] 	 potter: even you hjave proxy right?
[17:03:10] 	 potter: I still didn't try git
[17:03:15] 	 New review: Nikerabbit; "You accidentally the branch :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3879
[17:03:24] 	 New review: GWicke; "The general approach looks very good. The tokenizer portion could be merged with commit 199d07f01af5..." [mediawiki/extensions/VisualEditor] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/4050
[17:03:31] 	 potter: asking yourself? :D
[17:03:31] 	 potter: You can only submit from an SSH clone, yes. But you should be able to move commits from one clone to the other
[17:03:37] 	 RoanKattouw: sorry, one last (hopefully) AFT commit for the abuse filter release on wednesday -- https://gerrit.wikimedia.org/r/4106
[17:03:50] 	 nischayn22: what about proxy in NIITK?
[17:04:18] 	 RoanKattouw: thanks for the info, this has made the situation simpler
[17:04:23] 	 potter: Its NITK, I still didn't try, when I do i will let you know :)
[17:04:41] 	 potter: you also have problems with github?
[17:04:43] 	 New review: Catrope; "(no comment)" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4106
[17:04:45] 	 Change merged: Catrope; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4106
[17:04:52] 	 nischayn22: github works superbly
[17:05:04] 	 potter: hmm
[17:05:27] 	 New review: Nikerabbit; "(no comment)" [mediawiki/extensions/Narayam] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/3900
[17:05:29] 	 Change merged: Nikerabbit; [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/3900
[17:05:45] 	 New patchset: Reedy; "(bug 27757) API method for retrieving tokens" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3890
[17:06:23] 	 sumanah: any specifc reason mediawiki's updated codeBase isnt there in GitHub ?
[17:06:43] 	 potter: It will take work to do that, and no one has taken the time to do that work yet.
[17:06:47] 	 potter: would you like to do it?
[17:06:56] 	 potter: https://bugzilla.wikimedia.org/show_bug.cgi?id=35497 
[17:07:01] 	 sumanah: surely :)
[17:07:03] 	 potter: https://bugzilla.wikimedia.org/show_bug.cgi?id=35429
[17:07:15] 	 potter: but i have to first get it in my comp :P
[17:07:28] 	 sumanah: i wolud love to do it cause i faced this problem
[17:07:44] 	 potter: We aim to have good syncing between GitHub and Gerrit.wikimedia.org but no one has taken the time to do it yet.  
[17:08:17] 	 New code comment: Nikerabbit; Could you run code-utils/stylize.php on the files? Currently the indentation and other whitespace is; 
[17:09:14] 	 potter: is there a way gerrit and github can by synced ?
[17:09:27] 	 nischayn22: dont know dude
[17:09:31] 	 is there a tool/way to repair permissions on an installation?
[17:10:13] 	 potter: thought you knew, as you said you wanted it in github
[17:10:34] 	 03(mod) Loading of a change for review in Gerrit is often very slow - 10https://bugzilla.wikimedia.org/35612  +comment (10Mark A. Hershberger)
[17:10:38] 	 nischayn22: i want doet mean i know :P :D
[17:10:54] 	 lol
[17:10:56] 	 New review: Tpt; "(no comment)" [mediawiki/extensions/ProofreadPage] (master) C: 1;  - https://gerrit.wikimedia.org/r/4040
[17:11:45] 	 03(mod) Redirect for file on repository is not reflected on local projects - 10https://bugzilla.wikimedia.org/35615  (10Mark A. Hershberger)
[17:12:23] 	 03(mod) Bad link on "CC BY-SA 3.0" in page footer when viewed on Android - 10https://bugzilla.wikimedia.org/35617  (10Mark A. Hershberger)
[17:12:54] 	 03(mod) Choose main screen menu icons - 10https://bugzilla.wikimedia.org/35620  (10Mark A. Hershberger)
[17:14:04] 	 New patchset: preilly; "Fix data charges link for yes" [mediawiki/extensions/ZeroRatedMobileAccess] (master) - https://gerrit.wikimedia.org/r/4107
[17:14:22] 	 03(NEW) parserTests.php doesn't like git - 10https://bugzilla.wikimedia.org/35648 normal; MediaWiki: Unit tests; (Platonides)
[17:14:22] 	 03(mod) userPromote.php: Grants an account administrator rights (maintenance) - 10https://bugzilla.wikimedia.org/35623  +comment (10Mark A. Hershberger)
[17:14:32] 	 Hello
[17:15:19] 	 03preilly *  10/branches/wmf/1.19wmf1/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php: 1.19wmf: MFG Change-Id: I4d6fd913f7581db6c05f1b2399d232a1a86c47c2
[17:15:33] 	 Amgine: Daniel_WMDE: This page has a nice overview about mime type support in different wikis: http://foswiki.org/Development/MIMETypeForWikiSyntax
[17:15:52] 	 I have a question about my wiki my old one got spammed and griefed a lot so i'm making a new one now and need to protect it better is it possible to create like a new group called wikimod who can edit pages and don't let default users edit things? i don't want to give everyone adming who can edit the wiki but i want them to apply to edit the wiki.
[17:15:57] 	 03(mod) Gerrit needs better unicode support - 10https://bugzilla.wikimedia.org/35626  summary; +comment (10Mark A. Hershberger)
[17:16:41] 	 03(mod) autocompletion of reviewer names barely works when inviting a reviewer to look at a change in Gerrit - 10https://bugzilla.wikimedia.org/35630   +upstream (10Mark A. Hershberger)
[17:17:00] 	 New patchset: Reha Sterbin; "Cleanup: spacing, docblock comments, minor updates to make variable names conform to standard" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/4109
[17:17:32] 	 03(mod) Gerrit needs better unicode support - 10https://bugzilla.wikimedia.org/35626  +comment (10Niklas Laxström)
[17:17:46] 	 03(mod) Allow references to be listed with letters - 10https://bugzilla.wikimedia.org/22265  (10bluehairedlawyer)
[17:17:53] 	 03(mod) Set $wgCategoryCollation to 'uca-default' and rebuild category sort keys on Portuguese Wikipedia - 10https://bugzilla.wikimedia.org/35632  (10Mark A. Hershberger)
[17:18:13] 	 03(mod) Top Bar is inconsistent between screens - 10https://bugzilla.wikimedia.org/35633  (10Mark A. Hershberger)
[17:18:17] 	 hello?
[17:18:23] 	 hi?
[17:18:30] 	 hi hexmode
[17:18:33] 	 I have a question about my wiki my old one got spammed and griefed a lot so i'm making a new one now and need to protect it better is it possible to create like a new group called wikimod who can edit pages and don't let default users edit things? i don't want to give everyone adming who can edit the wiki but i want them to apply to edit the wiki.
[17:18:49] 	 Nikerabbit: !
[17:18:51] 	 fantasywar, yes, it is
[17:19:07] 	 Any page with info about that? or could you explan?
[17:19:16] 	 You might find https://www.mediawiki.org/wiki/Help:User_rights useful
[17:19:19] 	 i have searched for 2 hours but can't find anything
[17:19:21] 	 hexmode: I noticed you changed fixme from highest to high
[17:19:54] 	 but you can't add a group?
[17:20:11] 	 fantasywar, should be able to.
[17:20:20] 	 hm k
[17:20:25] 	 Nikerabbit: 1s
[17:21:27] 	 fantasywar: Try these: $wgGroupPermissions['wikimod']['edit'] = true; $wgGroupPermissions['user']['edit'] = false;
[17:21:47] 	 k will try
[17:21:58] 	 New review: GWicke; "Inspected the code, but did not test it." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/4056
[17:21:59] 	 and $wgGroupPermissions['*']['edit'] = false;
[17:22:10] 	 You might already have $wgGroupPermissions['user']['edit'] set to true, so you can just change it to false
[17:23:59] 	 03(mod) Extended characters show up as "?" in Gerrit user names - 10https://bugzilla.wikimedia.org/35626  summary; +comment (10Rob Lanphier)
[17:24:17] 	 Nikerabbit: so, not highest b/c it isn't super-urgent.  Also, you should assign the FIXME to the person who needs to make the change.
[17:24:18] 	 Think it's not adding the group wikimod
[17:25:25] 	 hexmode: in agile when something breaks (=fixme) everyone is supposed to start fixing it immediately
[17:26:00] 	 http://svn.wikimedia.org/doc is not working
[17:26:33] 	 fantasywar, it's working for me... Where are you adding it to?
[17:26:41] 	 Nikerabbit: ok, but we don't seem to be operating at agile on a inter-team level.
[17:26:41] 	 localsettings
[17:26:57] 	 potter: What are you trying to do?
[17:27:05] 	 fantasywar, at the bottom of it?
[17:27:08] 	 yeah
[17:27:22] 	 Joan: ?
[17:27:57] 	 potter:  http://svn.wikimedia.org/doc is not working
[17:28:00] 	 What are you trying to do?
[17:28:07] 	 hexmode: if fixme isn't "highest" I can as well not report the issues or revert them from git... neither is something I'd like to do
[17:28:33] 	 Joan: the given site is not function as it does generally
[17:28:47] 	 potter: I don't understand you.
[17:29:00] 	 krenair, When i go to user rights management then it don't show up wikimod only administrator and bot and bureucrast
[17:29:00] 	 03(NEW) Special:Version doesn't list git versions of extensions - 10https://bugzilla.wikimedia.org/35649 normal; MediaWiki: Special pages; (sam)
[17:29:22] 	 Joan: what do you see on the site?
[17:30:04] 	 Nikerabbit: understood.  If you want to put it back to highest, I won't fight you.  But then, you need to make sure any "highest" bugs you create are assigned to someone.
[17:30:15] 	 potter: A directory index with a README.
[17:31:00] 	 Joan: it had doxygen documenatatin till yesterday
[17:31:04] 	 documentation*
[17:31:05] 	 Right.
[17:31:09] 	 File a bug?
[17:31:15] 	 It may be intentional, though. Git is the new SVN.
[17:32:08] 	 fantasywar, how is userrights set up on your wiki? Can bureaucrats assign any group they want?
[17:32:15] 	 New patchset: Reedy; "Rather than messing about git-svn or something, just bringing a copy of https://geshi.svn.sourceforge.net/svnroot/geshi/tags/RELEASE_1_0_8_10/geshi-1.0.X/src into svn" [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) - https://gerrit.wikimedia.org/r/4110
[17:32:15] 	 Or only some groups?
[17:32:30] 	 Joan: yeah my be intentional
[17:32:41] 	 i don't have much changed i'm just the administarator and i wan't like 10 users be able to edit and others not
[17:32:42] 	 03(mod) Wikipedia:Contact us page is horribly formatted - new contact/feedback page - 10https://bugzilla.wikimedia.org/31591  (10Jon)
[17:33:01] 	 Joan: then where is the "new" documentation?
[17:33:14] 	 I think there's a missing puppet merge or 2
[17:33:22] 	 so i think they can edit all groups krenair
[17:33:25] 	 potter: That'd be a question for ^demon or Krinkle or someone.
[17:33:27] 	 I have no idea.
[17:33:35] 	 Reedy: Is there a replacement for the doxygen docs?
[17:33:39] 	 Or some reason they're broken?
[17:33:54] 	 Joan: there should be doxygen running from git rather than svn
[17:33:54] 	 Joan: i guess they are broken
[17:33:55] 	 fantasywar, well, after you've put $wgGroupPermissions['wikimod']['edit'] = true; into LocalSettings.php, wikimod shows as a group in Special:UserRights
[17:34:09] 	 Reedy: http://svn.wikimedia.org/doc/
[17:34:13] 	 I know
[17:34:15] 	 potter: Can you file a bug?
[17:34:15] 	 Some revisions were merged on friday, but I'm guessing they didn't work
[17:34:22] 	 And Chad did another checkin too
[17:34:31] 	 Groups you can change  bot  administrator  bureaucrat
[17:34:36] 	 thats all that are listed
[17:34:41] 	 New review: Reedy; "(no comment)" [mediawiki/extensions/SyntaxHighlight_GeSHi] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4110
[17:34:43] 	 Change merged: Reedy; [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) - https://gerrit.wikimedia.org/r/4110
[17:35:24] 	 fantasywar, check Special:ListGroupRights. does wikimod show up as a group there?
[17:35:26] 	 Krenair, this are my settings: http://pastie.org/3715738
[17:35:51] 	 http://fantasy-war.net/index.php?title=Special:ListGroupRights
[17:35:53] 	 not showing
[17:36:01] 	 fantasywar: Well, it should work...
[17:36:03] <^demon>	 The doxygen docs are broken until the cron runs again
[17:36:06] <^demon>	 potter: ^
[17:36:31] 	 fantasywar: By the way, generally making your DB login info public is a bad idea. Though MySQL is probably configured to only allow localhost access anyway
[17:36:37] 	 ^demon: oh. when iwll it happen?
[17:36:39] 	 will*
[17:36:42] 	 i changed pass
[17:36:52] <^demon>	 potter: Sometime in the next 24h. It runs daily.
[17:36:57] 	 fantasywar: You've got $wgGroupPermissions['*']['edit'] = false; twice
[17:37:09] 	 yeah with 1 it didn't work either
[17:37:19] 	 Well putting it twice wont fix that
[17:37:19] 	 and when i go to users they can still edit
[17:37:21] 	 ^demon: oh.peace....
[17:37:23] 	 Edit pages (edit)
[17:37:34] 	 When you go to users?
[17:37:40] 	 ??
[17:37:49] 	 yeah
[17:37:55] 	 http://fantasy-war.net/index.php?title=Special:ListGroupRights
[17:37:59] <^demon>	 potter: Midnight UTC tonight :)
[17:38:23] 	 03nikerabbit *  10/branches/wmf/1.19wmf1/languages/Names.php: MFG https://gerrit.wikimedia.org/r/#change,3805
[17:39:43] 	 03(mod) Links to a pages in Page namespace should be coloured only in Index namespace - 10https://bugzilla.wikimedia.org/35634  (10Mark A. Hershberger)
[17:40:04] 	 03(mod) Allow references to be listed with letters - 10https://bugzilla.wikimedia.org/22265  +comment (10Gadget850)
[17:40:20] 	 fantasywar: Well I'm not sure what's going on. Are you sure the settings are being updated on the server?
[17:40:32] 	 yeah they are
[17:40:40] 	 03(mod) Loss of newuser/create API components with recent upgrade - 10https://bugzilla.wikimedia.org/35635  (10Mark A. Hershberger)
[17:41:00] 	 omg
[17:41:02] 	 sorry fail
[17:41:08] 	 uploaded tot he old wiki :S
[17:41:16] 	 03(mod) Etherpad does not work on https - 10https://bugzilla.wikimedia.org/35637  (10Mark A. Hershberger)
[17:41:16] 	 03(mod) Allow references to be listed with letters - 10https://bugzilla.wikimedia.org/22265  +comment (10Allen Stambaugh)
[17:41:16] 	 New patchset: Platonides; "SqlBagOStuff opens a new connection when using a MySQL db, to avoid deadlocks, but that produces failures when using temporary tables on tests, as those temporary tables are not available for other connections. As it's the only process using those tables," [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4111
[17:41:35] 	 fantasywar: Looks like it's fixed now. Try Special:UserRights again
[17:41:57] 	 yeah! :) worked
[17:42:12] 	 thanks a lot :D
[17:42:17] 	 fantasywar, * and user still have a bunch of rights which you probably want to disable
[17:42:19] 	 New patchset: Platonides; "SqlBagOStuff opens a new connection when using a MySQL db, to avoid deadlocks, but that produces failures when using temporary tables on tests, as those temporary tables are not available for other connections. As it's the only process using those tables," [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4111
[17:42:22] 	 ^demon: I am applying for GSoC 2012 for mediawiki. Could you please check my proposal and give me suggestions upon how to improve it :)
[17:42:23] 	 http://www.mediawiki.org/wiki/User:Bagariavivek/GSoC_Application
[17:42:24] 	 But I'm sure you can figure that out for yourself
[17:42:29] 	 yeah i will
[17:42:35] 	 and yeah won't be to hard now :)
[17:42:41] 	 thanks for the help
[17:42:55] 	 New review: Aaron Schulz; "Can we have a more proper setting or global for this. It's odd to have such a hack in the core just ..." [mediawiki/core] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/4111
[17:43:06] 	 New review: Platonides; "Behavior in Oracle needs to be checked" [mediawiki/core] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/4111
[17:44:26] 	 AaronSchulz, I had considered storing the state in the LoadBalancer
[17:44:33] 	 would you prefer that?
[17:44:51] 	 and how to call it? temporaryTables? runningTests?
[17:45:49] 	 changing the LoadBalancer status didn't seem too appropiate either
[17:46:30] 	 03(FIXED) Enable WebFonts for fr.wikisource.org - 10https://bugzilla.wikimedia.org/35328  +comment (10Niklas Laxström)
[17:47:54] 	 New review: Hashar; "(no comment)" [mediawiki/core] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/3890
[17:48:11] 	 03(mod) Etherpad does not work on https - 10https://bugzilla.wikimedia.org/35637  +comment (10Mark A. Hershberger)
[17:48:12] * YuviPanda  pokes Reedy about ShortUrl
[17:48:17] 	 what more needs to be done?
[17:48:19] 	 srikanthlogic: ^
[17:49:00] 	 03(mod) Article::delete() calls - 10https://bugzilla.wikimedia.org/35640  (10Mark A. Hershberger)
[17:49:18] 	 YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=1450
[17:49:22] 	 There's outstanding questions
[17:49:27] 	 New patchset: Platonides; "Alphabetically sort the interwikis. Added a comment about WMF wikis." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4097
[17:49:35] 	 03(mod) parserTests.php doesn't like git - 10https://bugzilla.wikimedia.org/35648  (10Mark A. Hershberger)
[17:49:59] 	 YuviPanda: What's this?
[17:50:26] 	 Reedy: hmm, the two things I see are brion signing off + a 'list to enable at'
[17:50:36] 	 Reedy: brion said he was okay with this on IRC, but I'll wait for him to comment there
[17:50:37] 	 Still needs doing ;)
[17:50:39] 	 Oh, 'that' kind of short url.
[17:50:40] 	 iirc he's sick
[17:50:45] 	 Dantman: not your kind :)
[17:51:21] 	 ;) Well, partially....
[17:51:28] 	 New patchset: Platonides; "Alphabetically sort the interwikis. Added a comment about WMF wikis." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4097
[17:51:31] 	 For the record, I don't like those RewriteRules in the bug.
[17:51:42] 	 YuviPanda: also mind giving an UI for it?
[17:51:56] 	 Dantman: IIRC that was just a sample one.
[17:52:08] 	 srikanthlogic: can you collate list of wikis + on wiki consensus?
[17:52:30] 	 Oh... btw, theoretically ShortURl could already start implementing the hook to modify the PathRouter.
[17:52:36] 	 YuviPanda: I shall update the bug (I think are already marked as dependent bugs)
[17:52:41] 	 srikanthlogic: please do
[17:53:04] 	 03(mod) extension distributer -- now MW is git and that is SVN - 10https://bugzilla.wikimedia.org/35574  +comment (10Mark A. Hershberger)
[17:53:36] 	 Offer a config variable to set the path that a ShortURL uses and then register it with something like $router->add( $myConfigVar, array( 'title' => '-', 'oldid' => '$1' ) );
[17:53:40] 	 YuviPanda: a popup like UI similar to moodbar will help for shorturl too, than cluttering screen
[17:53:57] 	 03(mod) Unable to revert edits - 10https://bugzilla.wikimedia.org/35582  (10Mark A. Hershberger)
[17:54:07] 	 New review: Aaron Schulz; "Can we just change the $id !== null checks to account for 0 $ids. Actually I can't even find anythin..." [mediawiki/core] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/4104
[17:54:22] 	 03raindrift *  10/trunk/extensions/PageTriage/includes/PageTriageUtil.php: fixed the invalid argument bug when visiting a page that doesn't exist
[17:54:43] 	 srikanthlogic: one step at a time :)
[17:54:46] 	 let's first get this deployed
[17:54:47] 	 Actually $router->add( $myConfigVar, array( 'title' => 'Special:ShortURL/$1' ) );
[17:54:54] 	 03(mod) Article::delete() calls - 10https://bugzilla.wikimedia.org/35640  +comment (10Alexandre Emsenhuber [IAlex])
[17:55:01] 	 YuviPanda: :)
[17:55:08] 	 Dantman: haven't played around with the url routing code...
[17:55:34] 	 03(FIXED) Enable Narayam at Hindi Wikipedia - 10https://bugzilla.wikimedia.org/35436  +comment (10Niklas Laxström)
[17:55:55] * Dantman  envisions a future where you just set MW as your 404 handler and everything starts working.
[17:56:20] 	 03(mod) Retire AFTv5 "bucket" url parameter - 10https://bugzilla.wikimedia.org/35589  (10Mark A. Hershberger)
[17:56:48] 	 03(mod) Gerrit: Preferences: change "reviewed" preference when visiting changes to unchecked - 10https://bugzilla.wikimedia.org/35592  (10Mark A. Hershberger)
[17:56:51] 	 Implicit 404s, trivial short urls, and automatic 404 thumbnail handling
[17:57:51] 	 03(mod) userPromote.php: Grants an account administrator rights (maintenance) - 10https://bugzilla.wikimedia.org/35623  (10Mark A. Hershberger)
[17:57:58] 	 New review: Aaron Schulz; "(no comment)" [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4097
[17:58:00] 	 Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4097
[17:58:24] 	 03(mod) Wiki page does not reflect edit page - 10https://bugzilla.wikimedia.org/35625  (10Mark A. Hershberger)
[18:00:05] 	 AaronSchulz: So I saw your comment and changed what I had done to use $id instead. Just got to figure out how to send it to gerrit now
[18:00:42] 	 03(mod) Enable WebFonts for fr.wikisource.org - 10https://bugzilla.wikimedia.org/35328  (10thomaspt)
[18:02:19] 	 Dantman: any web application could be defined as "404 handler" or "preventer":)
[18:03:13] 	 New patchset: Alex Monk; "Remove the user rights link from the Contributions/DeletedContributions pages for anonymous users, as you can't set user rights on anonymous users." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4104
[18:04:02] 	 AaronSchulz: Okay, done :)
[18:06:44] 	 03(mod) #switch or #ifeq: {{PAGENAME}} doesn't work with title containing apostrophe - 10https://bugzilla.wikimedia.org/35628  +comment (10Mark A. Hershberger)
[18:06:51] 	 New review: Platonides; "The four parser tests are failing for me." [mediawiki/core] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/3912
[18:07:00] 	 03(mod) "Download as PDF" does not open page as a PDF - download gets stuck. - 10https://bugzilla.wikimedia.org/35645  (10Mark A. Hershberger)
[18:07:14] 	 03(mod) Special:Version doesn't list git versions of extensions - 10https://bugzilla.wikimedia.org/35649  (10Mark A. Hershberger)
[18:09:06] 	 03(mod) ApiBlockTest::testMakeNormalBlock() broken - 10https://bugzilla.wikimedia.org/35646  +comment (10Sam Reed (reedy))
[18:09:27] 	 Hello, who can I talk to for bug 16794 (PostgreSQL - $wgSharedDB) ?
[18:09:29] 	 hrm, git.exe just randomly crashed
[18:10:11] 	 I'd like some feedback/ someone who can tell me where/how it need more work on the patch
[18:11:40] 	 New patchset: Reedy; "Bug 35646 - ApiBlockTest::testMakeNormalBlock() broken" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4114
[18:12:18] 	 03(FIXED) ApiBlockTest::testMakeNormalBlock() broken - 10https://bugzilla.wikimedia.org/35646  +comment (10Sam Reed (reedy))
[18:14:13] 	 Luker: What do you want to know?
[18:14:40] 	 well, why it was reverted to start, so that i have something to work on
[18:14:42] 	 03(NEW) Quick search bar is not respecting phone language settings - 10https://bugzilla.wikimedia.org/35650 normal; Wikipedia App: Generic; (tfinc)
[18:14:54] 	 hey i got 1 more question how do i remove the view source for users
[18:15:04] 	 You can't
[18:15:08] 	 03(mod) {{#time | + time interval}} does not give satisfying results at the end of a month - 10https://bugzilla.wikimedia.org/35608  +comment (10Mark A. Hershberger)
[18:15:10] 	 Wait, view source of an article?
[18:15:25] 	 03(mod) Creation of a new mailing list for Kazakh Wikipedia (kk) - 10https://bugzilla.wikimedia.org/35518  +comment (10Bolatbek)
[18:15:27] 	 Why are we testing git head every time somoene commits, even though the commit isn't in trunk? :/
[18:16:27] 	 Luker: Couldn't say. But I agree that the ugly regex test needs to go.
[18:16:29] 	 hashar: ^
[18:16:42] 	 Reedy: I am not here sorry.
[18:16:48] 	 lol
[18:17:21] 	 G_SabinoMullane: we want to test submitted patches before merging them in master
[18:17:34] 	 G_SabinoMullane: because once it is merged, we cannot remove it :-)))
[18:18:08] 	 just consider the tests is some kind of pre validation. Eventually we will automatically reject submitted patches whenever tests fails
[18:18:10] 	 New patchset: Platonides; "Also add some entropy from the container folders." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4115
[18:18:11] 	 hashar: ITYM Reedy
[18:18:18] 	 yeah the view source button on every page
[18:18:19] 	 Reedy: So when someone pushes something for review, what actually gets tested was the last merged code? Is that why I got a weird failure on change 4095??
[18:18:35] 	 G_SabinoMullane: oops sorry
[18:18:36] 	 It seems to be
[18:18:51] 	 Reedy: so well yes read what I wrote above.  We do tests pre merge to make sure we are going to merge something that works
[18:19:01] 	 the regex is taken from the main Database.php, it can be removed, but I felt safer to keep it. tableName() before just called the main tableName, which had the same regexp.
[18:19:03] 	 lol
[18:19:05] 	 Reedy: then one day we will be able to automatically deploy live :-]]
[18:19:10] 	 Krenair, jenkins were failing good tests...
[18:19:14] 	 dinner time anyway. talk to you soon
[18:19:18] 	 IT's not testing the patch though
[18:19:23] 	 *good patchsets
[18:19:32] 	 so what's the point of testing head everytime there's a non merged commit then? :/
[18:19:34] 	 03(mod) Quick search bar is not respecting phone language settings - 10https://bugzilla.wikimedia.org/35650  +comment (10Yuvi Panda)
[18:19:56] 	 well, I think that happened because hashar merged a failing patchset
[18:20:02] 	 Krenair: 4095 was marked as failing because master has a failing test already ;-\   So I have disabled jenkins bot for now
[18:20:16] 	 Krenair: until someone fix the faulty bug. 
[18:20:26] 	 03(mod) Creation of a new mailing list for Kazakh Wikipedia (kk) - 10https://bugzilla.wikimedia.org/35518  +comment (10Thehelpfulone)
[18:20:38] 	 hashar: ok. I did wonder how those changes could possibly fail tests :p
[18:21:16] 	 Krenair: here is the bug which is now fixed: https://bugzilla.wikimedia.org/show_bug.cgi?id=35646
[18:21:34] 	 Krenair: so I will be able to enable again the bot 
[18:21:56] 	 shouldn't git checkout master origin/master move my master to the server one?
[18:22:33] 	 dinner time for real sorry :-D
[18:22:34] 	 seems I need -B there
[18:22:42] 	 -b  to create branch locally
[18:22:51] 	 Platonides: yes, -b but it shouldn't exist
[18:22:55] 	 git -b local name  -t  remote/remotebranch
[18:22:57] 	 ;)
[18:23:00] 	 see you later
[18:26:41] 	 03kaldari *  10/trunk/extensions/PageTriage/tools/ (. importNewPages.php): adding importing script for testing
[18:27:36] 	 New review: Aaron Schulz; "(no comment)" [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4115
[18:27:38] 	 Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4115
[18:28:43] 	 03raindrift *  10/trunk/extensions/PageTriage/includes/ArticleMetadata.php: deletion actually works now.
[18:32:17] 	 03raindrift *  10/trunk/extensions/PageTriage/tools/importNewPages.php: fixed the usage message
[18:33:10] 	 03(mod) Wikipedia pages violating CC-BY-SA license - 10https://bugzilla.wikimedia.org/35616  +comment (10Mark A. Hershberger)
[18:34:53] 	 03(mod) Loading of a change for review in Gerrit is often very slow - 10https://bugzilla.wikimedia.org/35612  +comment (10Mark A. Hershberger)
[18:35:49] 	 03(mod) The XSS filter in IE8/9 breaks certain tools - 10https://bugzilla.wikimedia.org/32013  (10Mark A. Hershberger)
[18:38:11] 	 03(NEW) Searching on Mobile site shows different result labels than desktop site - 10https://bugzilla.wikimedia.org/35651 normal; MediaWiki extensions: MobileFrontend; (jrobson)
[18:39:22] 	 03(mod) Searching on Mobile site shows different result labels than desktop site - 10https://bugzilla.wikimedia.org/35651  +comment (10Jon)
[18:39:46] 	 03(mod) Wikipedia pages violating CC-BY-SA license - 10https://bugzilla.wikimedia.org/35616  +comment (10Tomasz Finc)
[18:39:46] 	 03(mod) Redesign mobile layout to accommodate new features like language switching, contributions, etc - 10https://bugzilla.wikimedia.org/32117  (10Tomasz Finc)
[18:39:47] 	 New review: Brion VIBBER; "(no comment)" [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/3897
[18:39:50] 	 Change merged: Brion VIBBER; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/3897
[18:44:00] 	 srikanthlogic: poke brion :)
[18:44:45] 	 brion: some love for bug 1450 please
[18:45:15] 	 YuviPanda mentioned you had agreed over IRC, but a bug update is needed
[18:46:30] 	 03(mod) Wikipedia pages violating CC-BY-SA license - 10https://bugzilla.wikimedia.org/35616  +comment (10Mark A. Hershberger)
[18:46:31] 	 03(mod) Redesign mobile layout to accommodate new features like language switching, contributions, etc - 10https://bugzilla.wikimedia.org/32117  (10Mark A. Hershberger)
[18:46:59] 	 03(mod) Enable Extension:ShortUrl on or.wikipedia, ta.wikipedia... - 10https://bugzilla.wikimedia.org/1450  +comment (10Brion Vibber)
[18:49:19] 	 03bsitu *  10/trunk/extensions/PageTriage/includes/ArticleMetadata.php: fix pagetriage article snippet
[18:51:24] 	 brion: thanks ! :)
[18:51:32] 	 good luck :D
[18:52:53] 	 03(mod) "Forward" is permanently disabled in Android 4.x - 10https://bugzilla.wikimedia.org/35530  +comment (10sheac)
[18:56:31] 	 back
[18:56:47] 	 Reedy: somehow you fixed the faulty test but jenkins does not manage to catch the fix :-(((
[18:57:00] 	 Reedy: something must be severely broken when fetching the change :-/
[18:57:07] 	 Inded
[18:57:11] 	 That's what I was saying earlier
[18:57:25] 	 it seems it's not pulled the revision in for testing.. or something
[18:58:43] 	 03(mod) Provide a list of unsuccessful searches - 10https://bugzilla.wikimedia.org/6373  +comment (10Tisza Gergő)
[18:59:15] 	 03(mod) Extended characters show up as "?" in Gerrit user names - 10https://bugzilla.wikimedia.org/35626  +comment (10MZMcBride)
[18:59:39] 	 03(mod) Manually fix blocks from when global oversight log removal problem started - 10https://bugzilla.wikimedia.org/34995   +shell (10Mark A. Hershberger)
[18:59:45] 	 03(mod) The XSS filter in IE8/9 breaks certain tools - 10https://bugzilla.wikimedia.org/32013  +comment (10Daniel Friesen)
[19:01:28] 	 03(mod) Enable Extension:ShortUrl on or.wikipedia, ta.wikipedia... - 10https://bugzilla.wikimedia.org/1450  +comment (10Srikanth Logic)
[19:02:05] 	 Reedy: the test run fine on gallium :-(
[19:02:11] 	 will have a look at that tomorrow
[19:02:14] 	 something is really screwed
[19:02:18] 	 03(mod) Manually fix blocks from when global oversight log removal problem started - 10https://bugzilla.wikimedia.org/34995  +comment (10Mark A. Hershberger)
[19:02:22] 	 Merge it to master so it passes? ;)
[19:02:58] 	 just hold that patch for now
[19:03:13] 	 entering conf call
[19:04:27] 	 03(mod) Special:Version doesn't list git versions of extensions - 10https://bugzilla.wikimedia.org/35649  +comment (10Sam Reed (reedy))
[19:05:40] 	 03(mod) Enable Extension:ShortUrl on or.wikipedia, ta.wikipedia... - 10https://bugzilla.wikimedia.org/1450   +shell (10Srikanth Logic)
[19:08:09] 	 03(mod) Enable Extension:ShortUrl on or.wikipedia, ta.wikipedia... - 10https://bugzilla.wikimedia.org/1450  +comment (10MZMcBride)
[19:16:17] 	 14(DUP) Show Hide buttons not rendering properly - 10https://bugzilla.wikimedia.org/35504  +comment (10Patrick Hayes)
[19:16:18] 	 03(mod) Show/Hide buttons intermittently not working in ICS - 10https://bugzilla.wikimedia.org/35546  +comment (10Patrick Hayes)
[19:17:41] 	 03(NEW) SemanticFormsInputs: Datepicker and timepicker: wrong tab order - 10https://bugzilla.wikimedia.org/35652 normal; MediaWiki extensions: SemanticFormsInputs; (van.de.bugger)
[19:22:17] 	 03(mod) Enable Extension:ShortUrl on or.wikipedia, ta.wikipedia... - 10https://bugzilla.wikimedia.org/1450  +comment (10Srikanth Logic)
[19:22:52] 	 New review: Brion VIBBER; "(no comment)" [mediawiki/core] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/4099
[19:24:20] * potter  pokes ialex 
[19:24:33] 	 gwicke: thanks for those reviews!
[19:27:57] 	 03(mod) Searching on Mobile site shows different result labels than desktop site - 10https://bugzilla.wikimedia.org/35651  +comment (10Brion Vibber)
[19:28:12] 	 03(mod) Enable Extension:ShortUrl on or.wikipedia, ta.wikipedia... - 10https://bugzilla.wikimedia.org/1450  +comment (10Sam Reed (reedy))
[19:30:53] 	 I wonder if reading that petname article was such a good idea... My head is afire examining petnames, keys, domains, ssl, convergence, etc... and trying to come up with an idea on how to integrate petnames into the web.
[19:31:12] 	 New review: Platonides; "The other three tests were failing because $wgAllowATag was not being picked." [mediawiki/core] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/3912
[19:32:14] 	 Dantman: anything named Rover I'm blaming on you.
[19:32:30] 	 03(mod) Searching on Mobile site shows different result labels than desktop site - 10https://bugzilla.wikimedia.org/35651  +comment (10Jon)
[19:32:37] 	 :/ Is that supposed to be a joke, or do you just not know about petnames...
[19:33:16] 	 New review: IAlex; "(no comment)" [mediawiki/core] (master) C: 0;  - https://gerrit.wikimedia.org/r/4099
[19:33:22] 	 It's a joke, but no I don't.
[19:34:20] 	 http://www.skyhunter.com/marcs/petnames/IntroPetNames.html
[19:35:37] 	 03(mod) Remove IP throttle for account creation - 10https://bugzilla.wikimedia.org/25000  +comment (10HJ Mitchell)
[19:36:24] 	 
[19:36:29] 	 New patchset: IAlex; "Use local context to get messages and time formatting methods of Language class" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4121
[19:36:48] 	 03(mod) Wikipedia:Contact us page is horribly formatted - new contact/feedback page - 10https://bugzilla.wikimedia.org/31591  +comment (10Jon)
[19:53:18] 	 Bah... soo close...
[19:54:44] 	 Declaring a key without using https by signing the response text with a trailer header...
[19:55:03] 	 ...but most web apps don't let you send trailers
[20:01:28] 	 The key would be verified by checking it against the content; Then it would be used in a browser petname scheme...
[20:03:48] 	 03(FIXED) MobileFrontend extension outputting invalid HTML in footer - 10https://bugzilla.wikimedia.org/30406  +comment (10Jon)
[20:04:58] 	 New review: Greg Sabino Mullane; "More inline comments would be nice." [mediawiki/core] (master) C: 1;  - https://gerrit.wikimedia.org/r/3977
[20:13:50] 	 You know... thinking about that makes me think of one thing...
[20:14:37] 	 What's needed is probably some sort of key introduction system... some way of using the authority of one key to introduce other keys with the same authority...
[20:17:22] 	 03(mod) Extended characters show up as "?" in Gerrit user names - 10https://bugzilla.wikimedia.org/35626  +comment (10Chad H.)
[20:18:57] 	 Dantman: ... like facebook? :)
[20:19:03] 	 03(mod) Retrieve the first image used on a page - 10https://bugzilla.wikimedia.org/35647  +comment (10Bawolff)
[20:20:00] 	 New review: Aaron Schulz; "(no comment)" [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4121
[20:20:03] 	 Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4121
[20:22:38] 	 03(mod) Thumbnail not fully rendered - 10https://bugzilla.wikimedia.org/35576  +comment (10Bawolff)
[20:28:32] 	 New patchset: Trevor Parscal; "Add links in sandbox and demo to ve.dm.DocumentSychronizer.js" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4125
[20:28:45] 	 03(mod) Wikipedia pages violating CC-BY-SA license - 10https://bugzilla.wikimedia.org/35616  +comment (10Phil Chang)
[20:30:32] 	 New review: Robmoen; "(no comment)" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/4125
[20:30:54] 	 New review: Robmoen; "(no comment)" [mediawiki/extensions/VisualEditor] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4125
[20:31:02] 	 Change merged: Robmoen; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4125
[20:34:18] 	 03(mod) Wikipedia pages violating CC-BY-SA license - 10https://bugzilla.wikimedia.org/35616  +comment (10Pete F)
[20:34:40] 	 Useful for letting a petname system work in the context of multiple servers with the same site but different keys; potentially useful for 'upgrading' self-signed certificates; Maybe useful for making convergence more user friendly.
[20:35:45] 	 and mostly over my head, but I'm off to grab a bite.
[20:35:46] 	 saper: Facebook's certificate separation betwen load balanced servers? Yeah. I think Google does it too.
[20:37:32] 	 I think a key introduction protocol should probably use a multiple peer model.
[20:38:14] 	 When sending something verified with one key the user trusts introduce a portion of your other keys (eg: If you have 3 servers introduce the 2 other keys, if you have 15 introduce 5).
[20:38:44] 	 do files like this have to do with mediawiki? not exact files but they look something like this http://pastebin.com/imwaarcQ
[20:39:19] 	 pokeswap: That has absolutely nothing to do with MediaWiki.
[20:40:17] 	 ** Estabishing trust would be done by asking multiple peers if the key is valid. If the majority of them say yes then the key is trusted.
[20:40:56] 	 do files like this have to do with mediawiki? not exact files but they look something like this http://pastebin.com/imwaarcQ
[20:41:28] 	 pokeswap, USEagency: That has absolutely nothing to do with MediaWiki.
[20:42:37] 	 odd, it is on my mediawiki directory and i think i have include_once($IP/'filename.spy;) in locaqlsettings.php
[20:43:20] <^demon>	 Well, nobody can help what you may type in your LocalSettings.
[20:43:42] 	 i did not put it there
[20:44:38] <^demon>	 Well you, or your friend or somebody did.
[20:44:44] 	 i was just looking at my files and i noticed 10 files like that and require_once and include_once
[20:45:22] 	 ** The idea being that by working with majority rule instead of trust of one key would allow for a compromised key to be revoked by making the rest of the servers say that it's not a trusted key.
[20:45:49] 	 CRLs without a central point.
[20:47:33] 	 I can't make a connection right now... but I have a feeling some of these ideas could be useful in something like our OAuth and related plan...
[20:49:01] 	 USEagency, could that be ruby?
[20:49:12] <^demon>	 Dantman: Are you coming to Wikimania?
[20:49:26] 	 Either that... ^_^ or some sort of distributed set of wikis establishing secure channels with each other.
[20:49:38] 	 ^demon: I don't travel, so that answer is always going to be a no.
[20:49:50] 	 New patchset: Robmoen; "Fixed surfaceView undefined error" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4129
[20:49:59] <^demon>	 Ah. Was going to say that OAuth/related stuff would make a good topic for the developer days.
[20:50:20] 	 Oh... That wouldn't be a good topic for me...
[20:50:39] 	 There's a remote chance of some of the other stuff like skins that are actually 'my' area...
[20:50:53] 	 OAuth/related I have some notes I strongly advocate for...
[20:51:08] 	 But that's really just a chunk
[20:51:11] 	 03raindrift *  10/trunk/extensions/PageTriage/ (2 files in 2 dirs): change "non-autoconfirmed" to "new editor"
[20:51:33] 	 03(mod) Wikipedia pages violating CC-BY-SA license - 10https://bugzilla.wikimedia.org/35616  +comment (10Phil Chang)
[20:51:39] 	 what is ruby
[20:51:41] 	 ?
[20:53:41] 	 ^demon: That doesn't look anything like ruby
[20:53:46] 	 03(mod) Wikipedia pages not complying with CC-BY-SA license - 10https://bugzilla.wikimedia.org/34673  +comment (10Phil Chang)
[20:53:56] <^demon>	 I didn't say that, Platonides did.
[20:54:15] 	 what is ruby
[20:54:17] 	 ?
[20:54:32] <^demon>	 Ruby is a programming language.
[20:54:39] 	 Whoops
[20:55:21] 	 The key points of my OAuth involvement:
[20:55:52] 	 03(mod) Quick search bar is not respecting phone language settings - 10https://bugzilla.wikimedia.org/35650  +comment (10Yuvi Panda)
[20:56:03] 	 03(mod) Quick search bar is not respecting phone language settings - 10https://bugzilla.wikimedia.org/35650  (10Yuvi Panda)
[20:56:21] 	 - Needs to be broken up into core and extensions; There are things like associating revisions with an application, registering them, etc... that MUST be part of core.
[20:57:56] 	 - Should be pluggable. We should not just implement OAuth <1 or 2>; It should be an interface that extensions can implement OAuth 1 and OAuth 2 on top of, and additionally support any other protocol or custom protocol we think of... one possible custom protocol that could work for fallbacks or wikis without https could be a system that works like Google's "Application Passwords"
[20:58:22] 	 And lastly of course ;) "- Yes, I do wish I could implement this... like a pile of other things"
[20:59:49] 	 03van-de-bugger *  10/trunk/extensions/SemanticTitle/SemanticTitle.class.php: Bug fixed: Sometimes array is not rmpty, but there is no element with zero index. This causes an exception. array_shift is used to avoid such a problem.
[21:01:41] 	 03van-de-bugger *  10/trunk/extensions/SemanticTitle/SemanticTitle.class.php: Do not use semantic title on redirection pages to avoid confusing subtitles like "Page Title. Redirected from Title."
[21:02:17] 	 New patchset: MaxSem; "test" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/4130
[21:03:57] 	 New review: Daniel Friesen; "We call it SquidPurgeClient for legacy purposes because it was originally written for Squid. In our ..." [mediawiki/core] (master) C: 0;  - https://gerrit.wikimedia.org/r/4065
[21:04:01] 	 New review: Trevor Parscal; "Looks good to me, damn you copy paste!" [mediawiki/extensions/VisualEditor] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/4129
[21:04:09] 	 03(mod) Quick search bar is not respecting phone language settings - 10https://bugzilla.wikimedia.org/35650  (10Tomasz Finc)
[21:04:41] 	 xqt: https://www.mediawiki.org/wiki/Berlin_Hackathon_2012 it would be cool if you could come
[21:04:42] 	 New review: Trevor Parscal; "Looks good to me, damn you copy paste!" [mediawiki/extensions/VisualEditor] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4129
[21:04:44] 	 Change merged: Trevor Parscal; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4129
[21:05:56] 	 New patchset: MaxSem; "test" [test/mediawiki/extensions/examples] (master) - https://gerrit.wikimedia.org/r/4130
[21:07:19] 	 New review: Platonides; "> The other three tests were failing because $wgAllowATag was not being picked" [mediawiki/core] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/3912
[21:09:06] 	 03(NEW) add to core - 10https://bugzilla.wikimedia.org/35653 normal; MediaWiki extensions: CheckUser; (jdk370)
[21:09:20] 	 !b 35653
[21:09:21] 	 https://bugzilla.wikimedia.org/show_bug.cgi?id=35653
[21:12:43] 	 03(mod) Merge CheckUser into core - 10https://bugzilla.wikimedia.org/35653  summary (10Sam Reed (reedy))
[21:12:44] 	 03(mod) Extensions that should really be core functionality (tracking) - 10https://bugzilla.wikimedia.org/26751  (10Sam Reed (reedy))
[21:18:55] 	 03(mod) Don't load some (default) modules if they've been loaded before - 10https://bugzilla.wikimedia.org/32537  +comment (10Lupo)
[21:18:56] 	 New patchset: Daniel Friesen; "Add a Uri class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4069
[21:19:44] 	 03(mod) Show/Hide buttons intermittently not working in ICS - 10https://bugzilla.wikimedia.org/35546  +comment (10Yuvi Panda)
[21:20:00] 	 03(mod) Don't load some (default) modules if they've been loaded before - 10https://bugzilla.wikimedia.org/32537   +need-review +patch (10Lupo)
[21:20:49] 	 New patchset: Robmoen; "On selection, update selection in the model.  Fixes selection.clone() error." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4132
[21:24:21] 	 03(mod) Don't load some (default) modules if they've been loaded before - 10https://bugzilla.wikimedia.org/32537  +comment (10Lupo)
[21:24:23] 	 New review: Trevor Parscal; "(no comment)" [mediawiki/extensions/VisualEditor] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4132
[21:24:25] 	 Change merged: Trevor Parscal; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4132
[21:30:09] 	 03(mod) Return the scroll to the correct position when you save a page - 10https://bugzilla.wikimedia.org/35431  +comment (10Andrea Stagi)
[21:31:46] 	 03awjrichards *  10/branches/wmf/1.19wmf1/extensions/MobileFrontend/ (19 files in 6 dirs): MFG at Change-Id: Id5cbd690142171aaa516b48f2da7655da73185f2 plus minified js files to pick up changes
[21:37:09] 	 03raindrift *  10/trunk/extensions/PageTriage/ (2 files in 2 dirs): fixed a small localization bug, followup to r114589
[21:37:32] 	 New code comment: Raindrift; It was. Fixed in r114666.; 
[21:41:23] 	 ack what happened to http://svn.wikimedia.org/doc ?
[21:41:37] 	 New patchset: Aaron Schulz; "Added a simple script to clone/pull all wikis" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/4137
[21:42:35] 	 ^demon: ^
[21:43:03] <^demon>	 All wikis?
[21:43:03] <^demon>	 :p
[21:43:22] 	 one handed typing fail
[21:43:22] 	 RESOLVED DUPLICATE of Gerrit-2.3  ;-D
[21:44:02] <^demon>	 awjr: Broken until midnight.
[21:44:14] <^demon>	 We switched svn -> git and we're waiting for a cron to run
[21:44:31] 	 doh
[21:44:32] 	 ok
[21:44:35] 	 thanks ^demon
[21:44:40] <^demon>	 no problem.
[21:45:03] 	 New patchset: Aaron Schulz; "Added a simple script to clone/pull all extensions" [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/4137
[21:45:03] 	 New review: Hashar; "(no comment)" [mediawiki/extensions] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/4137
[21:45:57] 	 New review: Hashar; "(no comment)" [mediawiki/extensions] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/4137
[21:50:01] 	 03(FIXED) MediaWiki 1.19 post WMF deployment actions (tracking) - 10https://bugzilla.wikimedia.org/33996  (10Sam Reed (reedy))
[21:50:58] 	 03(FIXED) 1.19 post-deployment actions (tracking) - 10https://bugzilla.wikimedia.org/31211  (10Sam Reed (reedy))
[21:51:02] 	 03(mod) Category sorting should be case-sensitive on iswiktionary - 10https://bugzilla.wikimedia.org/30722  (10Sam Reed (reedy))
[21:54:06] 	 03(mod) Need Icon for market beta version of Wikipedia Android app - 10https://bugzilla.wikimedia.org/35577  +comment (10Yuvi Panda)
[21:54:18] 	 03(NEW) API edit of translate page gives Unknown error: "tpt-target-page" - 10https://bugzilla.wikimedia.org/35654 minor; MediaWiki extensions: Translate; (sam)
[22:01:08] 	 03platonides *  10/trunk/tools/code-utils/check-vars.php:
[22:01:08] 	 Detect when tests call $this->hideDeprecated() when they're about to
[22:01:08] 	 call a deprecated function, and place those usage-of-deprecated in a
[22:01:08] 	 different class disabled by default.
[22:01:09] 	 Currently, there's only one function benefitted by this, which is
[22:01:10] 	 BlockTest::testBug29116LoadWithEmptyIp(), testing the old block interface.
[22:08:19] 	 New review: Krinkle; "Just for the record, I rest my case regarding attribute escaping. It's an existing issue that just c..." [mediawiki/core] (master) C: 0;  - https://gerrit.wikimedia.org/r/3912
[22:08:44] 	 03platonides *  10/trunk/tools/code-utils/check-vars.php:
[22:08:44] 	 CryptRand can take advantage of openssl and mcrypt extensions
[22:08:44] 	 to generate entropy.
[22:10:43] 	 New review: Daniel Friesen; "We don't have a clean way to return just path + query. If you want to get path + query this is what ..." [mediawiki/core] (master) C: 0;  - https://gerrit.wikimedia.org/r/4069
[22:12:32] 	 Dantman: No, I meant Facebook as the identity management technology of these days
[22:12:45] 	 Bah...
[22:12:53] 	 ...I don't even know how that's related
[22:15:34] 	 Dantman: I have a feeling that Facebook attempts at solving identity problem of the Internet
[22:15:59] 	 where other schemes like PKI failed
[22:16:59] 	 Hi. What characters are allowed in uploaded file names? I've been searching but can't find anything on that topic.
[22:18:00] 	 03(mod) parserTests.php doesn't like git - 10https://bugzilla.wikimedia.org/35648  +comment (10Platonides)
[22:18:23] 	 nois0x, a lot of them, mostly based on what is allowed for page titles
[22:19:19] 	 Platonides: are % \ ' " allowed?
[22:19:36] 	 % ' and " certainly are
[22:19:53] 	 not sure about \, it might not be, for compatibility with Windows servers
[22:21:25] <^demon>	 Also, cyrillic characters on Windows.
[22:21:41] 	 New review: Brion VIBBER; "I'm not sure that the appending case is so necessary; most usages of wfAppendQuery() seem to take a ..." [mediawiki/core] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/4069
[22:21:57] 	 03awjrichards *  10/branches/wmf/1.19wmf1/extensions/MobileFrontend/MobileFrontend.body.php: MFG change-id: I590b2185df9ca1be287835cb8901fef020fd026a
[22:22:11] * Dantman  is trying to come up with a problem that can be solved with a web of wikis that know about each other
[22:23:11] 	 New review: Brion VIBBER; "(no comment)" [mediawiki/extensions] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/4137
[22:25:33] 	 YuviPanda: is it worth just enabling shorturl, and then log a seperate bug to decide what to do about the actual prefix?
[22:25:57] 	 Reedy: not sure, those things can be unsightly when long
[22:26:19] 	 New review: Hashar; "I still have an issue on gallium host, could it be related to the file loading order? :-(" [mediawiki/core] (master); V: -1 C: 0;  - https://gerrit.wikimedia.org/r/4114
[22:26:40] 	 Hmmmm... anti-spam network?
[22:26:53] 	 ...all these fancy ideas end up back there
[22:27:32] 	 03(NEW) Project creation should be limited to wiki admin rather than cloudadmin - 10https://bugzilla.wikimedia.org/35655 normal; MediaWiki extensions: OpenStackManager; (rlane32)
[22:28:48] 	 New patchset: Trevor Parscal; "Cleanup of white space, missing semi-colons, line breaks, etc." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4139
[22:30:19] 	 New review: Brion VIBBER; "(no comment)" [mediawiki/core] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/4104
[22:34:02] 	 New patchset: Reedy; "Module prefix 'ct' is shared between ApiQueryContestants and ApiQueryCodeTag" [mediawiki/extensions/Contest] (master) - https://gerrit.wikimedia.org/r/4141
[22:35:10] 	 New review: Brion VIBBER; "(no comment)" [mediawiki/core] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/4082
[22:36:26] 	 New review: Hashar; "merging and see what happens on gallium :-/" [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4114
[22:36:29] 	 Change merged: Hashar; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4114
[22:37:05] 	 New review: Demon; "(no comment)" [mediawiki/extensions/ProofreadPage] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4052
[22:37:07] 	 Change merged: Demon; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/4052
[22:37:49] 	 New review: Robmoen; "(no comment)" [mediawiki/extensions/VisualEditor] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4139
[22:37:54] 	 Change merged: Robmoen; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/4139
[22:38:01] 	 New review: Demon; "(no comment)" [mediawiki/extensions/ProofreadPage] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4040
[22:38:04] 	 Change merged: Demon; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/4040
[22:38:45] 	 03awjrichards *  10/branches/wmf/1.19wmf1/extensions/MobileFrontend/MobileFrontend.body.php: MFG change-id: I031286e302a24c124a10b86a6b3ddbff60fab496
[22:39:04] 	 New review: Brion VIBBER; "It might be better to have a function that can be called here which does the mw.config.get(), rather..." [mediawiki/core] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/4077
[22:43:23] 	 UserrightsPage::userCanChangeRights - anyone know how that return statement works?
[22:47:11] 	 New review: Brion VIBBER; "It feels wrong to be freeing the result sets inside these output functions; the output functions don..." [mediawiki/core] (master); V: 0 C: -2;  - https://gerrit.wikimedia.org/r/4033
[22:47:38] 	 03(mod) Manually fix blocks from when global oversight log removal problem started - 10https://bugzilla.wikimedia.org/34995  +comment (10Aaron Schulz)
[22:47:53] 	 New patchset: Reedy; "Add a few more image related directories to ignore" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4142
[22:48:16] 	 03(mod) Manually fix blocks from when global oversight log removal problem started - 10https://bugzilla.wikimedia.org/34995  +comment (10Aaron Schulz)
[22:52:35] 	 New review: Brion VIBBER; "Looks good! Tested with en content & he view and vice versa, things seem consistent." [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4062
[22:52:38] 	 Change merged: Brion VIBBER; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4062
[22:53:11] 	 New review: Aaron Schulz; "(no comment)" [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4142
[22:53:14] 	 Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4142
[22:54:35] 	 brion: Sorry to distract you but that function you mentioned - UserrightsPage::userCanChangeRights - do you understand how it works?
[22:55:13] 	 Krenair: iirc it checks if you have global rights, or rights to change your own rights, o rsomething
[22:55:52] 	 The bit that confuses me is this:
[22:55:54] 	 return !empty( $available['add'] ) || !empty( $available['remove'] ) || ( ( $this->isself || !$checkIfSelf ) && ( !empty( $available['add-self'] ) || !empty( $available['remove-self'] ) ) );
[22:59:08] 	 03awjrichards *  10/branches/wmf/1.19wmf1/extensions/MobileFrontend/templates/ApplicationTemplate.php: Reverting change from change-id: Ib2cad740d11d29d1c9e7f7786120cff7a3f566a0
[22:59:54] 	 I might just stick a if ( $user->getId() == 0 ) { return false; } in there :/
[23:00:07] * AaronSchulz  bangs his head on the wall
[23:00:45] 	 AaronSchulz: What's wrong?
[23:00:47] 	 Does anybody know what the errors on http://testwiki.org/wiki/Main_Page mean? Google shows a few results, but no fixes
[23:01:03] 	 What errors?
[23:01:45] 	 wtf, they disappeared
[23:01:50] 	 robla: so the CA fix didn't quite fix everything, instead of having wrong IDs and right names it just has wrong names and right IDs in block rows...
[23:02:17] 	 its kind of hard to work around the 1.17 block refactoring
[23:03:06] 	 d'oh!
[23:03:10] 	 :)
[23:03:11] * AaronSchulz  hacks
[23:03:12] 	 hmmm
[23:03:21] 	 "API documentation is automatically generated and updated daily at:
[23:03:21] 	   http://svn.wikimedia.org/doc/
[23:03:35] 	  /docs/README :D
[23:03:38] 	 !b 34995
[23:03:38] 	 https://bugzilla.wikimedia.org/show_bug.cgi?id=34995
[23:03:49] 	 thedj: it might take 10 minutes or so
[23:04:25] 	 03(mod) Manually fix blocks from when global oversight log removal problem started - 10https://bugzilla.wikimedia.org/34995  (10Rob Lanphier)
[23:04:45] 	 Reedy: oh, it's in its daily update cycle now ?
[23:04:59] 	 yeah, or it should be..
[23:05:07] 	 though it was broken due to git changeover stuff
[23:05:11] 	 New review: Brion VIBBER; "Patch seems to be missing \varstigma." [mediawiki/extensions/Math] (master); V: -1 C: -1;  - https://gerrit.wikimedia.org/r/4060
[23:05:20] 	 Oh
[23:05:24] 	 It might be an hour before..
[23:05:58] 	 anyway probably time for a hostname switch to apidoc.mediawiki.org
[23:06:18] 	 heh, yeah...
[23:06:50] 	 It's at 00:00 UTC
[23:06:52] 	 so 54 minutes
[23:07:12] 	 AaronSchulz: apologies in advance for being a process wonk here, but here's what I'd like to do.  I'd like to reopen 35011, and use that to keep track of the second problem you discovered.
[23:07:34] 	 I'd like to keep 34995 open, since that is what we'll use for making sure that the cleanup is done
[23:07:43] 	 does that make sense?
[23:08:06] 	 sure
[23:10:38] 	 How about one of http://docs.mediawiki.org/doxygen/ http://docs.mediawiki.org/php/ http://docs.mediawiki.org/phpapi/ http://docs.mediawiki.org/classes/
[23:11:31] 	 +branch prefix :-D
[23:11:49] 	 ex: http://nodejs.org/docs/v0.7.7/
[23:12:02] 	 and http://nodejs.org/docs/latest/
[23:12:24] 	 We also need to work out somewhere to put doxygen output from extensions
[23:12:30] 	 maybe something to do after we restructure ;)
[23:12:32] 	 http://docs.mediawiki.org/core/master/ http://docs.mediawiki.org/core/1.18.3
[23:12:47] 	 that too
[23:13:01] 	 and all of that need to be migrated to Jenkins
[23:13:04] 	 http://docs.mediawiki.org/extensions/ParserFunctions/master
[23:14:13] 	 heading bed, have a good day
[23:14:25] 	 03(mod) Allow references to be listed with letters - 10https://bugzilla.wikimedia.org/22265  (10bluehairedlawyer)
[23:16:12] 	 New review: Brion VIBBER; "I'm not 100% sure what this does, but I'll trust you guys that it's been pre-reviewed and makes sens..." [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4071
[23:16:51] 	 AaronSchulz: just so that I'm clear, the general problem is with global user id numbers being used locally?  or is it the other way around?
[23:17:08] 	 New review: Hashar; "Please note this is going to be built in Gerrit 2.3 :-]" [mediawiki/extensions] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/4137
[23:17:12] 	 the user IDs are correct, the names are wrong
[23:17:21] 	 New review: Hashar; "Please note this is going to be built in Gerrit 2.3 :-]" [mediawiki/extensions] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4137
[23:17:24] 	 Change merged: Hashar; [mediawiki/extensions] (master) - https://gerrit.wikimedia.org/r/4137
[23:17:24] * AaronSchulz  is already about to commit
[23:22:16] 	 03aaron *  10/branches/wmf/1.19wmf1/includes/Block.php: (log message trimmed)
[23:22:16] 	 (bug 35011) Use the correct user name & ID for crosswiki blocks.
[23:22:16] 	 Previously (r112563), using setId() ensured the correct ID, but caused a reload of the name from the DB the script is running on (metawiki), which was broken as it was inserting blocks into other wikis.
[23:22:16] 	 Instead, the User object is now always made from the name, which works since
[23:22:17] 	 Block uses User::newFromName() and that still returns a User object regardless
[23:22:18] 	 of whether a user with the name exists on the wiki (metawiki). Additionally, if
[23:22:19] 	 a user ID is passed into the Block constructor, a special 'forcedTargetID' field
[23:22:23] 	 Reedy: ^
[23:25:31] 	 03(mod) $wgBlockDisablesLogin - effective on a private wiki? - 10https://bugzilla.wikimedia.org/35252  (10jasper)
[23:25:35] 	 03awjrichards *  10/branches/wmf/1.19wmf1/extensions/MobileFrontend/templates/ApplicationTemplate.php: Revert r114671
[23:28:51] 	 New review: Daniel Friesen; "(no comment)" [mediawiki/core] (master) C: 0;  - https://gerrit.wikimedia.org/r/4071
[23:29:21] 	 03kaldari *  10/trunk/extensions/PageTriage/ (5 files in 3 dirs): revising the styling of the filter dropdown and tweaking some other styling
[23:30:00] 	 New review: Daniel Friesen; "(:/ Looks like making a comment doesn't comment till you review)" [mediawiki/core] (master) C: 0;  - https://gerrit.wikimedia.org/r/4016
[23:30:39] 	 New review: Daniel Friesen; "(:/ Looks like making a comment doesn't comment till you review)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4065
[23:31:17] 	 03(mod) Thumbnail not fully rendered - 10https://bugzilla.wikimedia.org/35576  +comment (10Ben Hartshorne)
[23:32:28] 	 Can someone please enlighten me on this situation ?           http://mywiki.everythingfoodanddrink.org/wiki/MyWiki:Project_noticeboard#Upgrade_question
[23:33:08] 	 ^demon: or maybe you can check r114672?
[23:34:02] 	 AaronSchulz: is that a reply to me ?
[23:36:42] 	 New review: Brion VIBBER; "Looks good; tried the various edit/create/section edit/section new cases, seems reasonably consisten..." [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4035
[23:36:45] 	 Change merged: Brion VIBBER; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4035
[23:37:00] 	 Mlpearc: "The directory for that extension is empty" isn't a MediaWiki error
[23:37:27] 	 THats my wording not the error it's self
[23:37:44] 	 MediaWiki won't empty any directories
[23:37:57] 	 OK thants wierd
[23:38:20] 	 how do these directories get emptied
[23:38:45] 	 I mean it's jnothing I can't fix
[23:39:09] 	 but If I was doing something wrong I'd rather fix that :P
[23:39:18] 	 Likely copying the wrong extensions dir. You can download the extension into the empty directory.
[23:39:20] 	 are you copying it correctly?
[23:39:54] 	 I use net2FTP that's installed in my farm
[23:40:39] 	 Can I do the upgrade then copy over the extension directory after running the update script
[23:41:06] 	 yeah, but depending on the extensions, they also might need updates
[23:41:36] 	 true, but thats basically what I'm having to do anyway :P
[23:42:18] 	 Thanx I thought it might be something common and a better way of avoiding it
[23:43:08] * Mlpearc  It does give me a chance to evaluate the extension and if I reaally need it :)
[23:45:49] 	 New review: Brion VIBBER; "Confirmed this removes visible white border on something like this:" [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4067
[23:46:36] 	 ugh, bad dependencies on that
[23:46:49] 	 needs a rebase...
[23:47:17] 	 ;) That just tells me yet again that gerrit's review model is fundamentally wrong
[23:49:48] 	 brion: Me and Roan threw some ideas back and forth on what we'd do if we wrote a review system from scratch awhile ago in irc... did you see it?
[23:50:14] 	  /msg werdna ping
[23:50:16] 	 err.
[23:50:45] 	 03tstarling *  10/branches/wmf/1.19wmf1/extensions/ConfirmEdit/FancyCaptcha.class.php: Fix infinite loop, apparently readdir(false) === null
[23:50:51] 	 Dantman: no, don't think i have
[23:50:53] 	 03bsitu *  10/trunk/extensions/PageTriage/ (3 files in 2 dirs): format the date in stats nav
[23:50:54] 	 could be nice reading :D
[23:51:34] 	 ok i've got a rebase, now how in the hell to i reattach it to the commit…. wheeee
[23:52:10] 	 put the Change-Id line from gerrit in the commit message as a footer
[23:52:23] 	 assuming you mean what I think you mean
[23:54:18] 	 brion: It's mixed somewhere in here http://bots.wmflabs.org/~petrb/logs/%23mediawiki/20120329.txt
[23:54:29] 	 tx
[23:55:11] 	 New patchset: Brion VIBBER; "getting rid of white border around gallery thumbs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4067
[23:55:25] 	 it thinks it's a new patchset. oh well
[23:55:39] 	 oh wait! no that was the right thing
[23:55:42] 	 score
[23:56:46] 	 New review: Brion VIBBER; "Rebased/cherry-picked, seems like it should merge now." [mediawiki/core] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/4067
[23:56:49] 	 Change merged: Brion VIBBER; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/4067
[23:56:54] 	 \o/
[23:58:52] 	 brion: ;) There was a lot of Gerrit hate that day so it might be hard to find; Looks like it starts around [20:18:33]