[00:01:00] vamega: well, maybe you ask also on other related channels, or your provider - which is the best place [00:01:53] umm Sunday moorning - time to go to sleep [00:02:35] 03(mod) Wikimedia Shop is only available in English - 10https://bugzilla.wikimedia.org/37797 +comment (10Siebrand) [00:02:38] New review: Helder.wiki; "Well, it was working before and isn't now." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16238 [00:05:48] 03(NEW) PHP Warning: fmod() expects parameter 1 to be double, string given - 10https://bugzilla.wikimedia.org/39673 normal; MediaWiki: Internationalization; (s.mazeland) [00:07:32] * Jasper_Deng_sick pokes Betacommand [00:09:42] I'm on the phone with godaddy [00:15:22] …yikes, GoDaddy [00:20:10] You can call GoDaddY? [00:20:13] Do they answer the phone? [00:22:29] 03(mod) Wikimedia Shop is only available in English - 10https://bugzilla.wikimedia.org/37797 +comment (10James Alexander) [00:32:50] 03(mod) Wikimedia Shop is only available in English - 10https://bugzilla.wikimedia.org/37797 +comment (10MZMcBride) [00:34:58] hey [00:35:15] does anybody have any idea how i delete from tiny warz? :( [00:36:16] hi? [00:37:11] try clicking the delete tab while logged in as a sysop? [00:37:36] thx k [00:38:18] if you have issues with a particular wiki, it's better to bring it up with that wiki (unless you're the one assigned to resolve said issues, ofc) [00:38:49] in general, we won't have access here on random wikis in order to assist people (nor know what those wikis even are) [00:38:57] ofc --> of course [00:40:30] New patchset: Adamw; "basic TokenList" [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21139 [00:44:30] New patchset: Tim Starling; "Fix exception on parse due wfMsgExt() -> wfMessage()" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21543 [00:54:03] 03(mod) GlobalBlocking needs API modules - 10https://bugzilla.wikimedia.org/16214 +comment (10Betacommand) [01:05:32] TimStarling: Hi. I was going to file a bug about adding a dedicated Special page for a Scribunto debug console. Special:Scribunto or something. But as I was re-thinking it now, I'm wondering if it needs any persistent storage (for pastebinning problematic code). [01:06:13] I'm also not sure how difficult copy and paste is with the current debug console. And I saw a bug about multi-line inputs. [01:06:55] it should be possible to paste multi-line text into the current debug console [01:07:09] and to press shift-enter to get a line break, instead of evaluating [01:09:40] 03(mod) Write API for CentralAuth extension - 10https://bugzilla.wikimedia.org/23821 +comment (10Betacommand) [01:14:34] New patchset: Tim Starling; "Don't run Preprocessor::preprocessToObj() on cache hits" [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/21544 [01:16:30] TimStarling: do you have any ideas about what we are going to do with Lua script licensing? [01:16:46] 03(mod) CentralAuth/global user rights/groups API; Get global user rights, membership to global groups; and userlist of global groups - 10https://bugzilla.wikimedia.org/16860 +comment (10jeremyb) [01:17:14] what needs to be done? [01:17:38] Change merged: Tim Starling; [mediawiki/extensions/Scribunto] (master) - https://gerrit.wikimedia.org/r/21544 [01:17:49] Well [01:17:53] We now have tons of code [01:17:58] Not tons [01:18:01] But enough [01:18:06] Licensed under CC-BY-SA [01:18:13] CC-BY-SA is not really a code license [01:19:02] it doesn't explictly prohibit the licensing of code does it? [01:19:30] It strongly advises against it, as far as I remember [01:20:28] I remember correctly: http://wiki.creativecommons.org/Frequently_Asked_Questions#Can_I_apply_a_Creative_Commons_license_to_software.3F [01:20:31] TimStarling: https://bugzilla.wikimedia.org/show_bug.cgi?id=39566 is the bug I saw. [01:20:37] About multi-line inputs for the debug console. [01:20:57] yeah, it's wrong though, it's shift-enter and it is already done [01:21:05] Okay. [01:21:09] maybe liangent didn't check the code or try pressing shift [01:21:29] Sounds like he copied and pasted a multi-line block. [01:21:36] But I'm just guessing. [01:22:05] With the escape key trick forthcoming and the shift-enter thing, I wonder if it needs a pop-up window like Gerrit's. [01:22:12] Or at least a help link somewhere. [01:22:21] I think some of this sorcery will be undiscoverable. [01:23:55] Not sure if you want me to comment on the bug or not. [01:24:20] I'm hesitant to mark it resolved until the bug filer can comment back, in any case. [01:26:43] vvv: The lack of a licensing policy sounds like a bug. Is there a bug for that? [01:26:51] No [01:26:57] At least I have not seen one [01:27:07] The code is all namespaced, right? So it should be a simple solution, in theory... [01:27:57] We already have per-namespace licensing changes on MediaWiki.org. Module can just be re-licensed. [01:28:53] > if i knew php (may it forever rot in hell) it would already be done. [01:29:04] That's a pretty great mailing list quote. [01:30:04] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21543 [01:30:27] Brooke: And then, the next quote ("Since I don't, it's up to someone else") is pretty awful.... [01:30:42] It's true. [01:30:47] Someone else will have to do it. [01:31:25] Has it really been five years with CentralAuth? [01:31:39] Four, probably [01:32:11] New review: Aaron Schulz; "Often when I've tried to use CACHE_ACCEL my test wiki (with xcache) became really slow (profiling sh..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/18095 [01:32:48] Tim is the first account. [01:33:00] 14(WFM) Updating the database from 1.11 to 1.19 doesn't apply patch-log_user_text.sql - 10https://bugzilla.wikimedia.org/39657 +comment (10Mark A. Hershberger) [01:33:16] Registered : < 2006 [01:33:20] Useful... [01:33:34] https://toolserver.org/~quentinv57/tools/sulinfo.php?username=Tim+Starling doesn't include global user registration date? That's a bit silly. [01:33:53] https://meta.wikimedia.org/wiki/Special:CentralAuth/Tim_Starling [01:34:00] There we are. Registered: 00:16, 13 March 2008 (4 years ago) [01:34:09] Huh. It's been a long time. [01:36:34] vvv: https://bugzilla.wikimedia.org/show_bug.cgi?id=16860 [01:36:37] Should that be assigned to you? [01:37:27] Probably [01:37:39] I am (or was) a default assignee for CA [01:37:46] I worry about cookie-licking. [01:37:58] New review: Parent5446; "Probably. APC, etc. were primarily meant to be opcode caches, and while APC maintains a separate obj..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/18095 [01:38:08] Does CA really have no API at all right now? I thought it had basic read support... [01:38:18] It did [01:38:30] ApiQueryGlobalUserInfo.php [01:39:03] I think we need to encourage more RFCs. [01:39:15] So people can clearly write down what's currently done and what needs doing. [01:40:26] globalblocks exists... [01:40:32] globaluserinfo [01:41:34] Okay. [01:48:46] New patchset: Mtyeh411; "Added a page iterator" [mediawiki/extensions/SemanticPageSeries] (master) - https://gerrit.wikimedia.org/r/21545 [02:05:19] 03(mod) CentralAuth/global user rights/groups API; Get global user rights, membership to global groups; and userlist of global groups - 10https://bugzilla.wikimedia.org/16860 +easy; +comment (10MZMcBride) [02:08:50] quick question, is there an extention or function that can keep trackof an individual user's word count? [02:08:59] 03(mod) Write API for CentralAuth extension - 10https://bugzilla.wikimedia.org/23821 +comment (10MZMcBride) [02:09:04] Okay, I cleaned up the CA bugs. [02:11:28] 03(mod) Write API for CentralAuth extension - 10https://bugzilla.wikimedia.org/23821 +comment (10Betacommand) [02:12:16] Betacommand: Christ that's unhelpful. You program for other people, right? You know you need details about what needs to be done and how. [02:12:39] > the big ones are block/unblock/lock/unlock [02:12:44] That doesn't mean anything to anyone. [02:15:39] Brooke: global (un)blocking and (un)locking of accounts are what are the main missing CA API functions [02:17:56] Brooke: not sure how much more detailed I can get [02:18:14] Betacommand: You need to link to the specific pages you want to replicate via the API. [02:18:24] And file separate bugs. [02:18:28] I'm replying to you on the mailing list. [02:19:07] Brooke: without access to the UI linking is kinda difficult [02:22:47] Betacommand: Why are you interested in this bug? [02:23:25] 03(NEW) User::load() does not account for failure to load from session. - 10https://bugzilla.wikimedia.org/39674 normal; MediaWiki: General/Unknown; (tylerromeo) [02:24:56] Brooke: the issue was brought to my attention that CA lacked key API functionality (Was thinking about using it as a solution to another problem) [02:25:25] With it he's going to fix the spam problems of beta.wmflabs.org [02:25:28] Well, you should look at what I did to the bugs and do that instead. [02:26:57] 03(mod) User::load() does not account for failure to load from session. - 10https://bugzilla.wikimedia.org/39674 +comment (10Tyler Romeo) [02:27:00] New review: Ori.livneh; "Made a few notifications, but reviewing this is made harder by the fact that you have very gratuitou..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/19199 [02:27:29] 03(NEW) Add primary key and log fields to archive table; perhaps also use original page_id when page is restored? - 10https://bugzilla.wikimedia.org/39675 enhancement; MediaWiki: Database; (leucosticte512) [02:28:21] Jasper_Deng_sick: Does beta.wmflabs.org have a working CA system? [02:28:30] Brooke: yes [02:28:32] It would be useful to be able to link to working Special pages. [02:28:44] Or at least give developers access. Though most will just RTFS. [02:31:21] New patchset: Parent5446; "(bug 39674) Fixed loading User from session when hook aborts." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21546 [02:33:53] 03(mod) User::load() does not account for failure to load from session. - 10https://bugzilla.wikimedia.org/39674 +patch-in-gerrit; +comment (10Tyler Romeo) [02:54:11] 03(NEW) The link in the e-mail should use https. - 10https://bugzilla.wikimedia.org/39676 normal; Wikimedia: SSL related; (jack.sns) [02:59:02] 03(mod) The link in the e-mail should use https. - 10https://bugzilla.wikimedia.org/39676 +comment (10MZMcBride) [03:00:51] thedj: Ha, in the top five bug resolvers! :) [03:01:02] 03(mod) Write API for CentralAuth extension - 10https://bugzilla.wikimedia.org/23821 +comment (10MZMcBride) [03:01:12] Useful comment, that. ^ [03:07:04] New patchset: Tim Starling; "Disable Narayam if CodeEditor is requested on a page" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/21547 [03:07:42] 03(mod) CodeEditor does not work with Narayam - 10https://bugzilla.wikimedia.org/39557 +comment (10Tim Starling) [03:15:32] So does mwlib have its own ParserFunctions support, then? [03:15:44] I'm confused about "Support for Lua in mwlib (Collection extension)". [03:15:58] I thought Collection was using MediaWiki for parsing/rendering. [03:30:09] New patchset: Tim Starling; "Add Global Rules" [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/17620 [03:30:17] Change merged: Tim Starling; [mediawiki/extensions/AbuseFilter] (master) - https://gerrit.wikimedia.org/r/17620 [03:32:38] Brooke: I'm not sure exactly what it is doing, but there is a request on my enwiki user talk page about {{hide in print}} [03:33:07] I would not be surprised if it has its own implementation of ParserFunctions [03:33:42] https://en.wikipedia.org/wiki/User_talk:Tim_Starling#Scribunto [03:33:54] Hmmm. I hadn't seen that post. I'll take a look later. [03:35:53] Oh my. Tim used an exclamation mark. [03:35:58] In a non-coding context. [03:37:53] according to my emotional modelling routines, a human would have used an exclamation mark there [03:38:21] and I generally like to appear human [03:38:54] What are your thoughts on profiling tools for template writers? [03:40:29] well, Gabriel reckons they will have a new C++ parser ready by December [03:40:44] not sure whether to believe that [03:41:02] TimStarling: A little faith would be nice :P [03:41:17] but it's probably wise to focus on projects that will be useful either way, just in case [03:41:41] I'm not sure we're talking about the same thing. [03:41:52] I was talking about a tool where you can see how fast a module runs in seconds, for example. [03:42:09] right, so by template writers you mean module writers? [03:42:10] Or compare page render/parse time between the current parser with ParserFunctions and the current parser with Scribunto. [03:42:14] Yes, sorry. [03:42:26] * marktraceur hopes it doesn't take seconds [03:42:44] I'm afraid it does in fact take seconds [03:42:46] Template writers are kind of synonymous with module writers, or will be. [03:43:34] I trying to think about what kind of Special pages you could have. Lua debug console, profiling tool, etc. And how'd they'd interrelate in a UI. [03:43:47] ~3.3 seconds for https://test2.wikipedia.org/wiki/The_Beatles [03:44:36] out of a 10s total rendering time, so maybe we're not doing too badly, but I still want to profile it [03:45:05] That page is missing half the templates. [03:45:22] I can probably do a basic profiling tool in LuaSandbox [03:45:44] Does LuaSandbox have any UI exposure? I thought it was just the PHP extension. [03:46:03] it's just the PHP extension, but profiling is pretty low-level [03:46:19] I can do a sampling profiler, it's said that the backtrace functions are signal-safe [03:46:29] to support this exact application, among other things [03:46:46] then scribunto will have the UI [03:47:17] Maybe just Special:Scribunto is needed. With a big textarea for a debugging console and profiling/debugging output below. [03:48:11] maybe, except that I've been trying to avoid using the name of the extension in the UI [03:48:15] maybe Special:Lua [03:48:24] Heh, I've been going the other way. [03:48:27] I think Lua is bad branding. [03:48:41] I think it's confusing to users because it already exists as a concept in the wild. [03:49:10] sure, but it really is lua, pretty much the same concept [03:49:12] Special:PHP or Special:Python would be equally confusing, I think. [03:49:44] in language-independent user interface messages I used the word "script" mostly [03:50:41] one reason is that "scribunto" is jargon [03:50:55] Well it's all jargon. [03:51:05] it was necessary to have a unique name for internal interfaces, I was the one who insisted on the extension being renamed from "scripting" [03:51:45] Speaking of using script in the UI, I put some note at /Brainstorming about "script error" not being obviously clickable. [03:52:01] It took me a week or so to get that clicking the red text would provide more information. [03:52:47] I was about to start filing bugs about the UI not having any error reporting when I finally realized that it was just hidden. [03:53:02] yeah, Trevor said the features team would be able to help with design work at some point, but they didn't come through with that [03:53:27] There are a few options I brainstormed. CSS might be easiest. [03:53:34] 03(mod) User preference for enforcing HTTPS - 10https://bugzilla.wikimedia.org/29898 (10Liangent) [03:53:35] 03(mod) Secure Server (tracking) - 10https://bugzilla.wikimedia.org/27946 (10Liangent) [03:53:35] 03(mod) Provide HTTPS links in CodeReview emails - 10https://bugzilla.wikimedia.org/29008 (10Liangent) [03:53:50] Or just saying 'script error (click for details)". There's nothing wrong with being explicit, esp. in bold red text. [03:53:52] there's a few UI design choices which I thought of as temporary, pending design review [03:54:16] If there's a list anywhere, that'd be helpful. We can file bugs and mark them as "design". [03:56:40] well, there's the "script error" link, like you said [03:57:00] then there's the styling of the dialog box that pops when you click it [03:57:22] the backtrace formatting [03:57:37] The debug console using a blue font is kind of trippy. [03:57:48] I couldn't tell if that came with some software package or if that was intentional. [03:58:25] yeah, the debug console was mostly modelled on this JS shell: http://www.squarefree.com/shell/shell.html [03:59:38] I took the UI code, replaced the eval() with an XHR request to evaluate Lua, reformatted the code, changed the styling very slightly [03:59:51] .input { color: blue; background: white; } [03:59:58] There it is. [04:00:06] It's not awful, it's just a little weird. [04:00:16] The coloring, I mean. [04:00:19] it's definitely not an upstream project now, we can change it how we want [04:00:24] The console itself seems nice. [04:00:57] I wonder if it should follow the textarea font choice user preference. [04:01:09] so yes, in the debug console there are the font colours, the borders and backgrounds, and the styling of the state reset message [04:01:51] All right. That's simple enough to file as a bug. [04:02:11] The design bugs are all "can have" priority level stuff. [04:02:19] Except the "script error" link one, I think. [04:02:29] I'm not sure mwlib is a must have, but it'll take more investigation. [04:02:34] I did change the cursor you know [04:02:40] Yes, I noticed that. [04:03:03] I'm just not sure clicking red text is obvious at all. It wasn't to me, at least. [04:03:21] When we usually have , I don't think it's ever clickable. [04:03:28] probably wikipedians are trained from birth not to click red text unless they want to create articles [04:03:37] That too. [04:03:51] It's doesn't register as "click for more information," that's for sure. :-) [04:04:35] I'm not really opposed to it being an submit and being hijacked by JS to open the dialog box, but others may not like that. [04:04:42] a submit * [04:05:01] Buttons are obviously clickable. [04:06:04] as long as it doesn't pop up on mouseover, I hate things that pop up on mouseover [04:06:22] Fair enough. [04:08:52] I've changed the standard way to do short urls again! [04:09:29] ((Why is ^demon never around? He was actually interested in this area?)) [04:09:34] The documentation waits with bated breath. [04:09:55] it's past midnight for ^demon [04:10:13] And programmers keep to a strict sleep cycle. (o; [04:10:22] Lies! [04:10:41] Perhaps… but every time I looked before ^demon was out. [04:10:58] Sounds like a conspiracy. [04:12:11] Apparently inside of a block %{REQUEST_FILENAME} does not have the document root on it and hence has the same value as %{REQUEST_URI} [04:13:45] This means that the root path rules we had using `RewriteCond %{REQUEST_FILENAME} !-f` would not work when used directly in a vhost block because Apache would look for things like /load.php in the server filesystem root [04:14:18] As a result skins would not display and images would not work. [04:15:45] Soo… I changed the standard manual to use `RewriteCond %{DOCUMENT_ROOT}%{REQUEST_URI} !-f` which we know will always work [04:16:47] Also apparently sometimes the PT flag causes Apache to turn things like /w/index.php into /var/www/var/www/w/index.php (doubling up the docroot) so I dropped PT and QSA from the flags. [04:17:20] Fascinating. [04:18:12] That said while I recommend the use of %{DOCUMENT_ROOT} some people say it doesn't work sometimes... [04:18:34] And I think I might have figured out why….. not that I enjoy the answer… [04:19:42] APexilI has joined/quit a few times now. [04:20:08] How many? [04:21:16] Mmmm…. note that the doubling up of them isn't actually a quit [04:21:22] APexilI: http://p.defau.lt/?61zFUykSv4NmYiLqL53Z1g [04:21:44] I thought your client might be broken, but you're alive and well, so we're good. [04:22:02] Just twice [04:22:18] some people just have bad internet connections [04:22:22] My internet is whats broken [04:22:24] Though it looks like 4 times because of the way Freenode handles cloaks [04:22:42] yeah, freenode is pretty noisy about it [04:23:01] it didn't always do that fake quit/connect cycle when you identified [04:23:02] We'll… I don't see how else they could cleanly do it [04:23:03] Oh look my pinging isn't going through again, joy [04:23:23] it used to just not do it [04:23:43] The only alternative is to silently start using a different hostname [04:23:55] yes, that's what it used to do [04:24:19] But doing that breaks the consistency that the IRC protocol is supposed to have and I expect it probably caused bugs in some clients [04:24:57] I don't remember seeing any such guarantee in the IRC protocol [04:25:44] Don't know if there is anything de jure… but it's definitely a de facto thing that one expects [04:26:19] When you first join a channel you get a whole list of the nicks and iirc hostmasks [04:26:50] And the combination of NICK, PART, JOIN, and QUIT keeps you up to date with the list of Nicks [04:27:06] your client sends a /who I think [04:27:09] But there is no way to notify that a hostname has changed [04:27:18] Mhmm [04:27:29] …well maybe [04:27:53] I can't remember but I might have seen that slew of nicks when I played around with IRC over telnet [04:28:40] But anyways… I expect that there are clients which will naturally not pester the server with insistent who queries to keep it's user list up to date [04:29:41] …since you'd usually expect the server to keep you up to date, and last I checked there was nothing in the IRC standard saying you should keep poking the server for something that it is presumably keeping you up to date with [04:30:17] nothing in the IRC standard says anything about clients maintaining lists of users [04:30:24] that's not really the issue [04:30:34] Well it sort of is [04:30:42] it's just a question of whether it is more important to keep client lists up to date or to avoid channel noise [04:31:50] I expect that there are a large number of clients, who in the case were someone joins with a hostname, and then silently switches to a cloak, will remember the hostname and display it even when it's not what the user actually has as their hostname. [04:32:22] Naturally this kind of violates one of the points of a cloak… [04:32:27] TimStarling: it all depends on when the user authenticates [04:32:37] And could also potentially get in the way of doing bans [04:32:58] if you do it as part of the connection it doesnt do the double join [04:33:10] ;) Naturally of course auto-join, cloaks, and NickServe were also not part of the IRC standard [04:35:27] my client is actually sending regular /who commands [04:36:23] 03(mod) noc.wikimedia.org/conf/ has a few broken links - 10https://bugzilla.wikimedia.org/39668 +easy +ops +shell (10MZMcBride) [04:37:38] protospam! [04:39:48] One of the two I'm using does that too but disables it when you're in a channel with more than number of peopl. [04:40:50] Colloquy? [04:41:29] Linkinus [05:02:00] New review: Fran; "Looks good to me." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/21196 [05:19:05] 03(mod) Set $wgSecureLogin = true on enwiki - 10https://bugzilla.wikimedia.org/39380 +comment (10MZMcBride) [05:23:40] 03(mod) url parsing does not recognize mixed case protocols - 10https://bugzilla.wikimedia.org/34939 +need-parsertest (10MZMcBride) [05:34:36] New patchset: Santhosh; "Fix Bug 37459 - Uselang parameter should recognize non-existing languages" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21548 [05:36:55] New patchset: Santhosh; "Do not accept invalid codes for setlang" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21548 [05:41:31] New review: Nikerabbit; "Two spaces instead of tab is correct." [mediawiki/extensions/CentralAuth] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21022 [05:50:23] 03(mod) PHP Warning: fmod() expects parameter 1 to be double, string given - 10https://bugzilla.wikimedia.org/39673 normal->minor; +comment (10Niklas Laxström) [05:54:34] New review: Nikerabbit; "Looks suitable for testing at it is. The issues in commit message should be added as TODOs somewhere." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21262 [05:55:24] Change merged: Nikerabbit; [mediawiki/extensions/wikihiero] (master) - https://gerrit.wikimedia.org/r/21469 [05:57:35] Change merged: Nikerabbit; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21196 [06:06:36] New review: Nikerabbit; "When modifying the bundled geshi, please provide a link that shows that the issue has been fixed or ..." [mediawiki/extensions/SyntaxHighlight_GeSHi] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21473 [06:06:51] 04(REOPENED) a lone "0" in a tag disappears - 10https://bugzilla.wikimedia.org/39643 (10Niklas Laxström) [06:10:23] 03(mod) ULS accepts undefined language codes - 10https://bugzilla.wikimedia.org/39623 +comment (10Niklas Laxström) [06:11:32] 03(mod) Wikimedia Shop is only available in English - 10https://bugzilla.wikimedia.org/37797 +comment (10Nemo_bis) [06:14:15] New review: Nikerabbit; "This needs corresponding change for the code that provides list of languages to ULS, doesn't it?" [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21548 [06:21:25] hello [06:23:45] [06:27:52] New review: Nikerabbit; "Both of those codes are deprecated, why should they be in this list?" [mediawiki/extensions/cldr] (master) - https://gerrit.wikimedia.org/r/21308 [06:35:36] New review: Nikerabbit; "http://caniuse.com/#search=datalist and the linked mozilla article says to provide fallback, but I d..." [mediawiki/extensions/WikimediaIncubator] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20668 [06:59:03] Brooke: https://github.com/pediapress/mwlib/blob/master/mwlib/templ/nodes.py [06:59:23] PediaPress's version of part of ParserFunctions [07:00:21] I wonder why they wrote their own code for this... speed reasons? [07:02:06] Yeah, it looks like they did a parser.py and pp.py (preprocessor?). [07:02:45] So you think it's important that mwlib have Lua support? [07:11:20] TimStarling: I don't really understand why PediaPress wrote their own parser, but I don't think it's Scribunto's job to keep it updated. [07:11:44] I'm going to write them an email [07:12:00] I think it'll be pretty simple for them, just a few hundred lines of code, and they have developers on staff [07:12:15] I have to think them writing their own parser has introduced a ton of bugs. [07:13:12] they will have to use Lunatic Python [07:13:14] \/ [07:13:17] o [07:13:40] kind of funny, one embeddable language inside the other! [07:13:43] I just don't see how it's sustainable for them to continue development of their own parser. [07:13:43] New review: Nikerabbit; ".htaccess doesn't do anything in our setup" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21298 [07:14:14] I thought mwlib/Pediapress had a bunch of parsing/rendering bugs against it. [07:15:50] 03(mod) ULS accepts undefined language codes - 10https://bugzilla.wikimedia.org/39623 (10jeblad) [07:21:43] 03(mod) ULS accepts undefined language codes - 10https://bugzilla.wikimedia.org/39623 +comment (10Niklas Laxström) [07:24:03] 03(mod) ULS accepts undefined language codes - 10https://bugzilla.wikimedia.org/39623 (10jeblad) [07:30:27] New patchset: Nikerabbit; "findexportroot: docs and portable" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21549 [07:39:01] New review: Nikerabbit; "Added some notes" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21298 [07:50:53] New patchset: Tobias Gritschacher; "small fix to blocked_user test to be more compatible with chrome;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21550 [07:51:31] 03(mod) ULS accepts undefined language codes - 10https://bugzilla.wikimedia.org/39623 +comment (10Niklas Laxström) [07:54:31] 03(mod) Set $wgSecureLogin = true on enwiki - 10https://bugzilla.wikimedia.org/39380 +comment (10Dereckson) [07:55:27] 03(mod) Set $wgSecureLogin = true on enwiki - 10https://bugzilla.wikimedia.org/39380 (10Dereckson) [08:11:01] New review: Santhosh; "The code that pass languages to ULS is " [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21548 [08:20:02] 03(NEW) Failing tests in WikibaseLib - 10https://bugzilla.wikimedia.org/39677 normal; MediaWiki extensions: WikidataRepo; (jeblad) [08:21:05] New patchset: John Erling Blad; "(Bug 39677) Failing tests in WikibaseLib" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21551 [08:22:47] 03(mod) a lone "0" in a tag disappears - 10https://bugzilla.wikimedia.org/39643 +upstream; +comment (10Dereckson) [08:23:56] 03(mod) a lone "0" in a tag disappears - 10https://bugzilla.wikimedia.org/39643 +comment (10Dereckson) [08:24:11] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21551 [08:30:14] 03(NEW) https://planet.wikimedia.org goes to civiCRM instance. - 10https://bugzilla.wikimedia.org/39678 normal; Wikimedia: General/Unknown; (hartman) [08:38:15] New review: Dereckson; "Thank you for this feature. This is a nice idea." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/11137 [08:39:09] New review: Dereckson; "(see above)" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/11137 [08:40:44] 03(mod) Failing tests in WikibaseLib - 10https://bugzilla.wikimedia.org/39677 +comment (10Dereckson) [08:43:11] 03(mod) The link in the e-mail should use https. - 10https://bugzilla.wikimedia.org/39676 +comment (10Dereckson) [08:43:11] 03(mod) Secure Server (tracking) - 10https://bugzilla.wikimedia.org/27946 (10Dereckson) [08:43:13] 03(mod) User preference for enforcing HTTPS - 10https://bugzilla.wikimedia.org/29898 (10Dereckson) [08:43:18] New review: Liangent; "upstream bugs should be fixed in upstream." [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) C: -1; - https://gerrit.wikimedia.org/r/21473 [08:43:25] 03(mod) ULS accepts undefined language codes - 10https://bugzilla.wikimedia.org/39623 (10jeblad) [08:51:55] How long will it take for a patch to be reviewed? (typically) [08:52:54] 03(ASSIGNED) Add primary key and log fields to archive table; perhaps also use original page_id when page is restored? - 10https://bugzilla.wikimedia.org/39675 +schema-change; +comment (10Dereckson) [08:53:17] koosha: between some 1 hours and 6 weeks [08:53:51] Dereckson: interesting answer! :) [08:54:10] Dereckson: So trivial ones must take a short time, right? [08:54:34] and huge ones are those that probably take longer [08:54:54] New patchset: Tobias Gritschacher; "fixed edit sitelink_test to be compatible with MAC FF;" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21552 [08:54:58] 03(mod) ULS accepts undefined language codes - 10https://bugzilla.wikimedia.org/39623 (10abraham.taherivand) [08:55:05] It's more a question of (1) find a reviewer (2) have the patch reviewed when someone is going to merge already reviewed patch (3) quicker treatment for patch solving urgent needs [08:55:59] New patchset: Nikerabbit; "Validate number input for {{PLURAL}}" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21553 [08:56:00] but yes, a bigger patch will raise more issues [08:57:21] Your review queue is currently empty: https://gerrit.wikimedia.org/r/#/q/koosha.khajeh%2540gmail.com,n,z [08:58:04] Dereckson: Yeah, but I'm getting to know the rules to see if I could contribute [08:58:46] actually, I'm a contributor of Mozilla Bugzilla team, but that project is not so active [08:58:56] because its developers are not so many [09:00:16] You're welcome to contribute here if you like MediaWiki stuff. [09:01:10] the code is really huge! :) [09:01:45] Yes, it is [09:02:34] If you're looking for a bug "easy to solve" (well... that someone else considered easy to solve), which could be a good introduction to our codebase, you've an 'easy' keyword on Bugzilla: https://bugzilla.wikimedia.org/buglist.cgi?keywords=easy [09:03:06] Yes, I know that. Thank you [09:03:15] If you're an unit testing pro, write test could also be a way to be more familiar with code: https://bugzilla.wikimedia.org/buglist.cgi?keywords=need-unittest&list_id=141579 [09:03:21] what if the bug is assigned to someone?! [09:03:44] happens seldomly [09:06:07] HI guys [09:06:09] I have a Q [09:06:28] I have a P! [09:06:46] 1) The table option is not showing when I edit a page [09:06:59] 2) How do I make the link like mydomain/wiki/my_wiki [09:07:08] mydomain.com/wiki/my_wiki* [09:07:51] Change merged: Matthias Mullie; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21498 [09:08:40] New review: Dereckson; "@Liagent: I agree. But GeSHi is an inactive project very slow to publish new releases, we could wait..." [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) C: -1; - https://gerrit.wikimedia.org/r/21473 [09:09:11] no one can help me? [09:09:28] Hi MrSnapp. [09:09:57] HI there. [09:10:03] Oh, a Q is a question. [09:10:19] I am trying to create something like this: http://www.minecraftwiki.net/wiki/Upcoming_features [09:10:32] but there aint a table option when i create/edit a page on MY wiki [09:10:35] 1 [09:10:44] !shorturl | MrSnapp [09:10:45] MrSnapp: To create simple URLs (such as the /wiki/PAGENAME style URLs on Wikimedia sites), follow the instructions at . There are instructions for most different webserver setups. If you have problems getting the rewrite rules to work, see !rewriteproblem [09:11:05] MrSnapp: what is a "table option"? [09:11:24] Okay. The second one is easier to solve. https://www.mediawiki.org/wiki/Manual:Short_URL will list you way to achieve the URL scheme you wish [09:11:44] Already answered. Bots are faster than humans to find pages :) [09:11:54] People have been telling me to do something like the upcoming features page, I have to create a table [09:11:59] is this right? [09:12:25] Tables are good to present tabular data. [09:12:53] Create the table in a notepab, with as separator. Or create it in Excel. Then copy/paste what you have on http://excel2wiki.net/ [09:13:02] It will generate a table output, remove {{table}} and you're done. [09:14:40] thanks. [09:21:04] New patchset: Ori.livneh; "Ensure clicktracking-session cookie is unset" [mediawiki/extensions/ClickTracking] (master) - https://gerrit.wikimedia.org/r/21554 [09:22:01] New patchset: Siebrand; "Maintenance for CentralAuth extension." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/21542 [09:22:29] New patchset: Ori.livneh; "(Bug #34794) Unset clicktracking-session cookie" [mediawiki/extensions/ClickTracking] (master) - https://gerrit.wikimedia.org/r/21554 [09:23:04] 03(ASSIGNED) User::load() does not account for failure to load from session. - 10https://bugzilla.wikimedia.org/39674 +comment (10Dereckson) [09:23:05] New review: Siebrand; "PS2 reverts a change in CentralAuthReadOnlyError.php caused by unclear documentation in core. See I4..." [mediawiki/extensions/CentralAuth] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21542 [09:23:36] New review: Jeroen De Dauw; "Note: requires running update.php" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21328 [09:24:08] Change merged: Ori.livneh; [mediawiki/extensions/ClickTracking] (master) - https://gerrit.wikimedia.org/r/21554 [09:24:37] Who is the MediaWiki session expert? [09:25:23] New patchset: Siebrand; "Maintenance for CentralAuth extension." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/21542 [09:26:35] 03(FIXED) [ClickTracking] cookie persistence after logout - 10https://bugzilla.wikimedia.org/34794 +comment (10Ori Livneh) [09:26:38] hmmm catrope has reviewed 3 of the 4 core login/session patch. [09:30:06] New patchset: Matthias Mullie; "Maintenance for ArticleFeedbackv5." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21479 [09:31:04] New patchset: Ori.livneh; "(Bug 38659) Correct misleading comment" [mediawiki/extensions/ClickTracking] (master) - https://gerrit.wikimedia.org/r/21555 [09:31:33] Change merged: Ori.livneh; [mediawiki/extensions/ClickTracking] (master) - https://gerrit.wikimedia.org/r/21555 [09:31:58] New patchset: Siebrand; "Maintenance for CentralAuth extension." [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/21542 [09:32:29] 03(FIXED) comment wrong in jquery.clickTracking.js - 10https://bugzilla.wikimedia.org/38659 +comment (10Ori Livneh) [09:32:32] Ive installed some extensions. How do i use them? [09:32:40] Such as WikiEditor [09:32:54] 03(NEW) Invalid use of plural - 10https://bugzilla.wikimedia.org/39679 normal; MediaWiki extensions: CleanChanges; (niklas.laxstrom) [09:33:47] New patchset: Siebrand; "Fix documentation." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21540 [09:35:13] Helllooo? [09:36:57] New patchset: Ori.livneh; "(Bug 34965) Remove extraneous period" [mediawiki/extensions/ClickTracking] (master) - https://gerrit.wikimedia.org/r/21557 [09:37:23] Change merged: Ori.livneh; [mediawiki/extensions/ClickTracking] (master) - https://gerrit.wikimedia.org/r/21557 [09:39:15] New patchset: Tobias Gritschacher; "selenium tests console output" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21051 [09:39:20] 03(mod) Clean up grammar in API autodocs - 10https://bugzilla.wikimedia.org/34965 +comment (10Ori Livneh) [09:39:59] 03(mod) Clean up grammar in API autodocs - 10https://bugzilla.wikimedia.org/34965 +comment (10Ori Livneh) [09:41:28] New patchset: Matthias Mullie; "Maintenance for ArticleFeedbackv5." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21479 [09:44:18] New patchset: Siebrand; "Fix documentation." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21540 [09:45:24] I wish I had more editing options [09:47:12] New review: Siebrand; "Feel free to merge when you're done with it :)." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21479 [09:48:56] New patchset: Siebrand; "Fix documentation." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21540 [09:49:31] More editing options would be real niec [09:52:24] Change merged: Siebrand; [mediawiki/extensions/WikimediaMessages] (master) - https://gerrit.wikimedia.org/r/20712 [09:53:11] 03(ASSIGNED) Wrong quotes used in Uri.php on line 121 - 10https://bugzilla.wikimedia.org/39672 +comment (10Dereckson) [09:54:13] 03(NEW) Header of diffs uses obsolete attribute valign (in HTML5) - 10https://bugzilla.wikimedia.org/39680 normal; MediaWiki: History/Diffs; (listenleser) [09:55:14] New patchset: Dereckson; "(bug 39672) Fixing quote." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21559 [09:56:43] 03(mod) Wrong quotes used in Uri.php on line 121 - 10https://bugzilla.wikimedia.org/39672 +patch-in-gerrit; +comment (10Dereckson) [09:59:49] 03(NEW) Babel boxes use obsolete attributes cellspacing and cellpadding (in HTML5) - 10https://bugzilla.wikimedia.org/39681 normal; MediaWiki extensions: Babel; (listenleser) [10:01:35] MrSnapp: you mean, like you have on en.Wikipedia.org? [10:03:59] MrSnapp: if so, please consider install https://www.mediawiki.org/wiki/Extension:WikiEditor [10:06:54] 03(mod) ULS accepts undefined language codes - 10https://bugzilla.wikimedia.org/39623 +comment (10Niklas Laxström) [10:09:48] New patchset: Matthias Mullie; "Bug 39451 - Protect articles to limit feedback on protected or semi-protected articles" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/20899 [10:12:05] Dereckson: I have installed it [10:12:31] All I wanna do is have something like http://www.minecraftwiki.net/wiki/Minecraft_Wiki [10:12:36] Looks god damn awesome [10:14:22] Where do I find my Apache httpd.conf [10:22:19] New patchset: Santhosh; "Circular scrolling through the regions" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21047 [10:33:01] http://www.minecraftwiki.net/index.php?title=MediaWiki:Common.js <-- here how they customize their toolbar [10:34:32] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21559 [10:37:29] New patchset: Jarry1250; "Minor cleanup." [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/21477 [10:37:47] Change merged: Jarry1250; [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/21477 [10:38:12] Change merged: Matthias Mullie; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21479 [10:38:33] koosha: it seems really trivial stuff could be reviewed and merged in 37 minutes: https://gerrit.wikimedia.org/r/#/c/21559/ [10:39:12] Dereckson: Let me look at it :) [10:40:40] Dereckson: Yeah, it really is. So why did you show it to me? It has an author. [10:41:20] koosha: oh I only wanted to amend my previous 1 hour - 6 weeks range and stress on the fact we've a dynamic development review process. [10:42:47] Dereckson: It's really nice of your team [10:44:15] 03(ASSIGNED) Open editing on se.wikimedia.org for any logged-in user - 10https://bugzilla.wikimedia.org/39671 normal->trivial; +patch-in-gerrit +shell; +comment (10Dereckson) [10:45:36] 03(mod) User::load() does not account for failure to load from session. - 10https://bugzilla.wikimedia.org/39674 +comment (10Dereckson) [10:47:01] New patchset: Siebrand; "Move error logging to subfolder." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21562 [10:47:23] New patchset: Matthias Mullie; "Bug 36772 - Article Feedback - Supporting feedback on help pages" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/19649 [10:48:48] 03(mod) https://planet.wikimedia.org goes to civiCRM instance. - 10https://bugzilla.wikimedia.org/39678 normal->major; +shell; +comment (10Dereckson) [10:50:09] New patchset: Matthias Mullie; "Bug 38817 - Feedback page - Hide my post" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/19756 [10:51:15] New patchset: Matthias Mullie; "Bug 39451 - Protect articles to limit feedback on protected or semi-protected articles" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/20899 [10:51:43] New patchset: Matthias Mullie; "Refactor AFT logging" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/20908 [10:53:44] New patchset: Siebrand; "Update paths for new config location." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21563 [10:54:01] New patchset: Tobias Gritschacher; "refactoring selenium: added methods for common tasks to page object." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21564 [10:54:16] 14(WFM) Script rendering error when reverting username with Arabic scripts - 10https://bugzilla.wikimedia.org/34679 summary; +comment (10Santhosh Thottingal) [10:58:58] New patchset: Siebrand; "Update paths for new config location." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21563 [10:59:00] 03(ASSIGNED) Babel boxes use obsolete attributes cellspacing and cellpadding (in HTML5) - 10https://bugzilla.wikimedia.org/39681 normal->15enhancement; +comment (10Dereckson) [11:00:22] New patchset: Nischayn22; "using smw_stats in Special Pages" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21026 [11:01:15] 03(mod) Babel boxes use obsolete attributes cellspacing and cellpadding (in HTML5) - 10https://bugzilla.wikimedia.org/39681 +comment (10Dereckson) [11:15:54] New patchset: Matthias Mullie; "remove config var that's no longer being userd" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21566 [11:16:21] 03(mod) Babel boxes use obsolete attributes cellspacing and cellpadding (in HTML5) - 10https://bugzilla.wikimedia.org/39681 +comment (10Siebrand) [11:17:51] Change merged: Siebrand; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21566 [11:22:17] New patchset: Dereckson; "(bug 39681) HTML5 compliant Babel code." [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/21567 [11:22:52] New review: Dereckson; "Untested code." [mediawiki/extensions/Babel] (master) C: -1; - https://gerrit.wikimedia.org/r/21567 [11:23:53] 03(mod) Database error can garble the page display - 10https://bugzilla.wikimedia.org/39332 +comment (10Antoine "hashar" Musso) [11:24:33] 03(mod) Database error can garble the page display - 10https://bugzilla.wikimedia.org/39332 (10Antoine "hashar" Musso) [11:25:25] 03(WONTFIX) License field ignored in javascript upload - 10https://bugzilla.wikimedia.org/24286 +comment (10Derk-Jan Hartman) [11:26:06] 03(mod) ULS accepts undefined language codes - 10https://bugzilla.wikimedia.org/39623 (10jeblad) [11:26:34] 03(mod) Babel boxes use obsolete attributes cellspacing and cellpadding (in HTML5) - 10https://bugzilla.wikimedia.org/39681 +comment (10Dereckson) [11:28:45] 14(WFM) Randomly get no/little css in Diff views - 10https://bugzilla.wikimedia.org/31318 +comment (10Antoine "hashar" Musso) [11:29:00] New patchset: Joancreus; "Adding a refcount hook to Cite extension." [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/21568 [11:30:43] 03(mod) Babel boxes use obsolete attributes cellspacing and cellpadding (in HTML5) - 10https://bugzilla.wikimedia.org/39681 +comment (10Siebrand) [11:32:36] New patchset: Joancreus; "Adding a refcount hook to Cite extension." [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/21568 [11:33:33] 03(mod) Babel boxes use obsolete attributes cellspacing and cellpadding (in HTML5) - 10https://bugzilla.wikimedia.org/39681 +comment (10Dereckson) [11:34:13] New patchset: Jeroen De Dauw; "use InvalidArgumentException rather then Exception" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21569 [11:35:04] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21350 [11:35:41] 03(mod) Randomly get no/little css in Diff views - 10https://bugzilla.wikimedia.org/31318 +comment (10Nemo_bis) [11:38:59] Dereckson: I don't remember my Gerrit credentials [11:40:58] and there is no "forgot password" solution! [11:42:33] A Gerrit admin can probably help you [11:44:09] Not sure if any are here at the moment [11:44:16] https://gerrit.wikimedia.org/r/#/admin/groups/1,members [11:45:17] 03(NEW) UploadWizard reports phantom error - 10https://bugzilla.wikimedia.org/39682 normal; MediaWiki extensions: UploadWizard; (jarry1250) [11:46:48] 03(mod) Clean up grammar in API autodocs - 10https://bugzilla.wikimedia.org/34965 +comment (10Antoine "hashar" Musso) [11:46:52] 03(mod) Documentation is out of date, incomplete (tracking) - 10https://bugzilla.wikimedia.org/1 (10Antoine "hashar" Musso) [11:50:07] 03(mod) ApiQuery->makeGeneratorList autoloads all query classes - 10https://bugzilla.wikimedia.org/39665 +comment (10Domas Mituzas) [11:53:54] New patchset: Siebrand; "Move error logging to subfolder." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21562 [11:54:32] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21549 [11:54:50] koosha> you should have received a password by mail [11:55:00] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21562 [11:55:25] New patchset: Siebrand; "Update paths for new config location." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21563 [11:55:45] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21563 [11:56:07] New patchset: Hashar; "very basic test for ApiEditPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17513 [11:57:04] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21495 [11:57:29] New patchset: Hashar; "very basic test for ApiEditPage" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17513 [11:58:47] New review: Hashar; "PS2: uses assertNotEquals() instead assertTrue( $a !== $b )" [mediawiki/core] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/17513 [11:59:53] New review: Jeroen De Dauw; "Not completely documented messages is better then missing messages, so I'm merging this. Please eith..." [mediawiki/extensions/SemanticResultFormats] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21482 [11:59:54] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21482 [12:01:34] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21481 [12:02:22] New patchset: Siddhartha Ghai; "(bug 35990) Fix schwa syncope for deva word ends" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/16272 [12:05:07] New patchset: Siddhartha Ghai; "(bug 35990) Fix schwa syncope for deva word ends" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/16272 [12:06:43] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/14295 [12:08:49] New review: Siddhartha Ghai; "Fixed the BOM thing. Sorry, didn't know about that before." [mediawiki/extensions/Narayam] (master) C: 0; - https://gerrit.wikimedia.org/r/16272 [12:10:05] New patchset: Siebrand; "Update scripts." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21571 [12:10:24] New review: Siebrand; "Replied to questions. Other comments addressed in I70a21985." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21298 [12:11:56] Using API, how do I check whether I am still logged in or not? [12:14:07] Change merged: Nikerabbit; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21571 [12:15:21] hi guillom [12:15:32] hello sumanah [12:18:18] New patchset: Jeroen De Dauw; "up gitignore" [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/21572 [12:18:27] New patchset: Jeroen De Dauw; "up gitignore" [mediawiki/extensions/SemanticMaps] (master) - https://gerrit.wikimedia.org/r/21573 [12:18:30] Change merged: Jeroen De Dauw; [mediawiki/extensions/Maps] (master) - https://gerrit.wikimedia.org/r/21572 [12:18:37] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMaps] (master) - https://gerrit.wikimedia.org/r/21573 [12:19:27] New patchset: Jeroen De Dauw; "up gitignore" [mediawiki/extensions/Survey] (master) - https://gerrit.wikimedia.org/r/21574 [12:19:33] New patchset: Jeroen De Dauw; "up gitignore" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21575 [12:19:38] Change merged: Jeroen De Dauw; [mediawiki/extensions/Survey] (master) - https://gerrit.wikimedia.org/r/21574 [12:19:45] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21575 [12:20:47] New patchset: Jeroen De Dauw; "updated gitreview" [mediawiki/extensions/Nuke] (master) - https://gerrit.wikimedia.org/r/21576 [12:22:04] New review: Jeroen De Dauw; "Yes, looks like Aude is right" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21190 [12:26:01] New review: Daniel Kinzler; "thanks hashar" [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/17513 [12:30:33] 03(mod) the meaning of "hide", "delete" and "oversight" rights is unclear - 10https://bugzilla.wikimedia.org/39282 +comment (10Matthias Mullie) [12:30:45] New patchset: Daniel Kinzler; "wfWarn() should cause phpunit tests to fail." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21577 [12:30:46] 14(DUP) the meaning of "hide", "delete" and "oversight" rights is unclear - 10https://bugzilla.wikimedia.org/39282 +comment (10Matthias Mullie) [12:30:46] 03(mod) Improve permissions - 10https://bugzilla.wikimedia.org/39497 +comment (10Matthias Mullie) [12:32:11] New review: Matmarex; "Thanks. I'm going to assume you know what you're doing about the logic, and +1 it, since it's okay f..." [mediawiki/extensions/Narayam] (master) C: 1; - https://gerrit.wikimedia.org/r/16272 [12:35:14] New patchset: Jens Ohlig; "Renamed ItemByLabel to "ItemDisambiguation"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21190 [12:37:04] 03(mod) Review and deploy Score extension to Wikimedia wikis - 10https://bugzilla.wikimedia.org/33193 +comment (10Jarry1250) [12:37:48] New patchset: Daniel Kinzler; "Make LinksUpdate run without a db transaction." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21578 [12:37:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21317 [12:40:18] New patchset: Daniel Kinzler; "Clean up transactions after test." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21579 [12:41:11] New patchset: Siebrand; "Update paths for config changes." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21580 [12:43:25] 03(mod) Set $wgSecureLogin = true on enwiki - 10https://bugzilla.wikimedia.org/39380 +comment (10Tyler Romeo) [12:44:50] Jarry1250: thanks for following up on Score! [12:45:05] New patchset: Amire80; "Get a list of the current user's Accept-Language codes" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21565 [12:45:11] New patchset: Daniel Kinzler; "Removed unmatched commits in Job class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21581 [12:46:30] New patchset: Siebrand; "Update paths for config changes." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21580 [12:46:50] sumanah: I can't remember who it was that mentioned it recently, but yeah, been following that one for years, not about to let it rest now :) [12:47:18] Jarry1250: I've been following up on it by asking the original author to follow up on the code critique, but s/he doesn't have time right now [12:48:14] btw Jarry1250 heads-up - https://www.mediawiki.org/wiki/User_talk:Sumanah#Scribunto_and_fr.wikisource_18569 - might be worth a brief Signpost item? [12:48:31] Change merged: Nikerabbit; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21580 [12:48:33] French Wikisource wants Scribunto! [12:49:14] sumanah: And they weren't even asked ;) Yeah, going to doing an IB about Lua so can put that in. Also ties in with last week's poll result [12:49:42] https://commons.wikimedia.org/wiki/File:Signpost_poll_23_%28Lua%29.png [12:49:48] 50% seems very good to me. [12:49:58] Jarry1250: now up on Commons: https://commons.wikimedia.org/wiki/File:Berlin_Hackathon_2012_-_Lua_introduction_%28Tim_Starling%29.ogv [12:50:13] ... quite a long IB then :) [12:50:20] :) [12:52:02] (normal poll caveats apply with that figure, of course: but we assessed a couple of weeks that the kind of people that answer poll questions are so much developers as just the technically curious) [12:52:09] btw Jarry1250, complete side note, since you do surveys, you might be interested in (for fun) http://tinderbox.homeschooljournal.net/2012/08/13/99-bottles-of-beer-on-the-wall/ and http://tinderbox.homeschooljournal.net/2012/08/16/real-data-this-time/ , and (for more businessy reasons) http://quominus.org/archives/874 [12:54:11] apergos: hey, you should email a link to https://apergos.wordpress.com/2012/08/27/disk-space-the-final-frontier/ to wikitech-l & the dumps list! [12:54:31] well, maybe not the dumps list [12:54:32] New patchset: Daniel Kinzler; "Fix transaction nesting caused by LocalFile." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21582 [12:54:37] well more like I will actually start a discussion on those lists in a little while [12:54:51] oh ok [12:55:33] so someone reads my blog. heh [12:55:42] apergos: it's syndicated on the planet! [12:55:53] yes, but that doesn't mean peple actually read it :-P [12:56:04] heh [12:56:08] sumanah: Bookmarked. I must dig out my copy of "How to Lie with Statistics", written in the 1950s but still relevant. (To avoid lying, I mean! Oh come on now. :) ) [12:56:13] 03(NEW) Current values do not show up in listbox, due to Undefined variable: cur_value - 10https://bugzilla.wikimedia.org/39683 normal; MediaWiki extensions: SemanticForms; (c_b_dvs) [12:56:19] :) [12:56:30] New patchset: Jeroen De Dauw; "Improve documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21583 [12:58:02] New patchset: Daniel Kinzler; "Trigger warning for bad use of transactions." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21584 [13:01:18] New patchset: Jeroen De Dauw; "made snaks immutable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21585 [13:04:53] New patchset: Aude; "Renamed ItemByLabel to "ItemDisambiguation"" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21190 [13:05:18] New review: Aude; "fixed some merge conflicts in the i18n files" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21190 [13:06:05] New patchset: Matthias Mullie; "Cleanup AFT config" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21587 [13:07:37] New review: Platonides; "I would have added warnings a long time before, if this embedded transaction 'usage' wasn't here." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21581 [13:12:59] New review: Daniel Kinzler; "@platonides: there doesn't seem to be any intentional usage, and the usage that exists breaks databa..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21581 [13:13:18] Change merged: Freakolowsky; [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/21183 [13:17:07] New review: Freakolowsky; "only one whitespace issue ... cool :D" [mediawiki/extensions/ConventionExtension] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21474 [13:17:36] 03(mod) Several history entries for the same content and watchlists showing wrong article size changes - 10https://bugzilla.wikimedia.org/37225 +comment (10Daniel Kinzler) [13:19:28] New review: Daniel Kinzler; "Possibly related to bug 37225" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21578 [13:19:55] hi hashar, welcome back to non-vacation-land [13:21:07] ^demon: in Gerrit, can I view the reviewer history of the changeset (like, who added/removed whom as a reviewer)? [13:21:18] (also Chad happy Monday and hope you had a nice weekend!) [13:21:20] <^demon> No, that's not logged. [13:21:23] sumanah: hello :) [13:21:57] <^demon> sumanah: Ok weekend, thanks. Didn't get nearly as much done around the house as I'd have liked. [13:22:16] hashar: back into the beta labs work, or are you on something else? [13:22:21] sumanah, I think I filed that as a bug time ago [13:22:25] also, I bet your daughter loved having more time with you hashar :D [13:22:45] sumanah: I have been doing mail triage since I woke up :-) [13:23:04] Platonides: hi! morning. hope you don't mind that I'm requesting more code review from you now that GSoC is over [13:26:10] Platonides: ah, found it - issue 1300. Also star-worthy: https://code.google.com/p/gerrit/issues/detail?id=764 [13:26:32] hi sumanah [13:27:04] sounds star-worthy, indeed [13:27:32] New review: Daniel Kinzler; "fwiw" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21350 [13:29:07] mlitn: Hi. I am testing AFTv5 on my machine. When I go to Special:ArticleFeedbackv5/PAGE_NAME, I see "5 posts about this page", and the "Showing:Most relevant (0) All comments (0)" headers, but no actual posts. [13:29:25] I'm running the latest trunk from gerrit. [13:35:43] 03(mod) Cannot upload Office 97-2003 DOC and XLS files - 10https://bugzilla.wikimedia.org/34797 (10Andre Klapper) [13:35:45] 03(mod) Upload file: Special Pages does not allow Office 2007 or 2007 saved as 2003 files to be uploaded. - 10https://bugzilla.wikimedia.org/29461 (10Andre Klapper) [13:38:47] aharoni: anything in $wgDebugLog? [13:46:51] 03(mod) Install Free Hebrew fonts, so that they will be available for SVG rendering - 10https://bugzilla.wikimedia.org/38946 +comment (10Antoine "hashar" Musso) [13:49:49] saper: nothing that appears to be related. [13:51:34] New review: Aude; "looks good to me, passes tests, poked around at repo + client with this patch and don't see any prob..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/20924 [13:51:34] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20924 [13:52:22] New patchset: Jeroen De Dauw; "Rewriting SQL store implementation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21328 [13:54:35] New patchset: Matthias Mullie; "Fix flagging feedback for readers" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21589 [13:54:47] 03(mod) Varnish 2.x doesn't like full urls in PURGE requests - 10https://bugzilla.wikimedia.org/39005 +comment (10Antoine "hashar" Musso) [13:56:18] aharoni: is your wiki online, or a local setup? I'd like to go take a look [13:58:11] New patchset: Jeroen De Dauw; "Rewriting SQL store implementation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21328 [13:58:19] mlitn: local. [13:59:37] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21583 [14:03:18] * hashar restarting Jenkins [14:03:51] New review: Nikerabbit; "Wrong hook. See the docs:" [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21565 [14:03:56] mlitn: aharoni: vnc? [14:04:12] New review: Tobias Gritschacher; "all Selenium & PHPUnit tests still working. seems to be ok to me." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21328 [14:04:26] thx for the fix siebrand [14:07:14] sDrewth: her… Which fix? :) [14:09:24] Change merged: Hashar; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17513 [14:10:33] siebot [14:15:44] New patchset: Yaron Koren; "Fix for commit bce97dc50e02288a88cf68d6922dc1750024206f" [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/21590 [14:16:36] Change merged: Yaron Koren; [mediawiki/extensions/SemanticForms] (master) - https://gerrit.wikimedia.org/r/21590 [14:17:51] 03(FIXED) Current values do not show up in listbox, due to Undefined variable: cur_value - 10https://bugzilla.wikimedia.org/39683 +comment (10Yaron Koren) [14:27:12] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21569 [14:27:25] New patchset: Hashar; "remove obsolete Selenium tests" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21591 [14:27:26] New patchset: Hashar; "(UnitTest) Enabling tests based on the UnitTest extension." [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/17039 [14:28:27] New review: Hashar; "Split from I9148c2c3" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21591 [14:28:27] Change merged: Hashar; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21591 [14:29:35] hi hashar welcome back [14:29:37] New review: Hashar; "Deleted Selenium files with https://gerrit.wikimedia.org/r/21591" [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17039 [14:30:41] New patchset: Matthias Mullie; "Cleanup AFT config" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21587 [14:33:10] sumanah: we sorted it out ;) [14:33:10] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21577 [14:33:23] mlitn: great! :) [14:36:15] Change merged: Demon; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/21012 [14:38:04] Change merged: Demon; [mediawiki/extensions/ScanSet] (master) - https://gerrit.wikimedia.org/r/20823 [14:40:35] New review: Krinkle; "Some after-the-fact review." [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/19784 [14:42:24] New review: Hashar; "This script provides a concise output and let you filter out globals using a regex. I think it is an..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17069 [14:42:55] New patchset: Nikerabbit; "Adding our irc relay bots" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21594 [14:43:29] 14(DUP) Cannot upload Office 97-2003 DOC and XLS files - 10https://bugzilla.wikimedia.org/34797 +comment (10Derk-Jan Hartman) [14:43:30] 03(mod) Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file") - 10https://bugzilla.wikimedia.org/38432 +comment (10Derk-Jan Hartman) [14:45:00] New review: Krinkle; "There were inline comments, but they disappeared." [mediawiki/extensions/SyntaxHighlight_GeSHi] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/15781 [14:45:15] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21328 [14:45:43] 03(mod) Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file") - 10https://bugzilla.wikimedia.org/38432 (10Andre Klapper) [14:45:53] sDrewth: Ah, are you the one sending me those e-mails :). Thanks for the regular reminders :). [14:49:20] siebrand: my poking it with hot branding irons fails miserably, your light touch is so much more effective [14:50:28] 03(mod) "Show changes" should not be incorrectly displayed in the Live Preview state - 10https://bugzilla.wikimedia.org/39273 summary (10Krinkle) [14:52:56] New review: Tobias Gritschacher; "Tests running. Looks good to me." [mediawiki/extensions/Wikibase] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/21190 [14:58:39] 03(FIXED) change 15612 to memcached log has issues - 10https://bugzilla.wikimedia.org/38689 +comment (10Antoine "hashar" Musso) [15:01:59] New patchset: Nasirkhan; "Probhat new Bengali layout" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/21595 [15:02:00] New patchset: Nasirkhan; "adding the layout and updated the translation" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/21596 [15:02:01] New patchset: Alex Monk; "Show HTTP error (if any) when scary transclusion fails" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20230 [15:02:25] 03(FIXED) [OPS] labs DNS lacks an entry for deployment-bastion.pmtpa.wmflabs - 10https://bugzilla.wikimedia.org/38846 +comment (10Antoine "hashar" Musso) [15:04:14] 03(mod) Enable AFTv5 on iOS - 10https://bugzilla.wikimedia.org/39372 +comment (10Matthias Mullie) [15:04:22] 14(WFM) InstantCommons is broken on beta.wmflabs.org - 10https://bugzilla.wikimedia.org/38701 +comment (10Antoine "hashar" Musso) [15:06:09] 03(NEW) UI language change preview in display settings - 10https://bugzilla.wikimedia.org/39684 normal; MediaWiki extensions: UniversalLanguageSelector; (pginer) [15:06:20] 03(mod) UI language change preview in display settings - 10https://bugzilla.wikimedia.org/39684 +i18n (10Pau Giner) [15:06:51] i am a tobi [15:09:02] New patchset: Chughakshay16; "Minor modifications" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/21474 [15:10:02] 03(NEW) Apply changes button should be active only if there are changes. - 10https://bugzilla.wikimedia.org/39685 normal; MediaWiki extensions: UniversalLanguageSelector; (pginer) [15:10:18] 03(mod) Apply changes button should be active only if there are changes. - 10https://bugzilla.wikimedia.org/39685 +i18n (10Pau Giner) [15:11:31] Change merged: Freakolowsky; [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/21474 [15:12:28] Hello! I'm trying to figure out why after an upgrade to 1.18.1 - FlaggedRev's Special:Stabilization page has lost the "Stable version selection" box [15:12:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21190 [15:15:34] 03(FIXED) Regenerate deployment-bastion - 10https://bugzilla.wikimedia.org/38777 +comment (10Antoine "hashar" Musso) [15:16:03] hi yuvipanda [15:16:12] hi hecticsc - upgrade from what? [15:16:35] 03(NEW) Cancel button in settings should go to the previous context - 10https://bugzilla.wikimedia.org/39686 normal; MediaWiki extensions: UniversalLanguageSelector; (pginer) [15:16:45] 03(mod) Cancel button in settings should go to the previous context - 10https://bugzilla.wikimedia.org/39686 +i18n (10Pau Giner) [15:16:50] 03(mod) Jenkins can't fingerprint .git/FETCH_HEAD - 10https://bugzilla.wikimedia.org/38260 +comment (10Antoine "hashar" Musso) [15:16:57] it was 1.16.1 i believe [15:17:06] 03(mod) Jenkins can't fingerprint .git/FETCH_HEAD - 10https://bugzilla.wikimedia.org/38260 +comment (10Antoine "hashar" Musso) [15:17:55] im fairly certain the page looked like http://www.mediawiki.org/wiki/File:Flaggedrevs_stabilisation.png in the past, and now that "stable version selection" box isn't there. [15:18:15] New patchset: Daniel Kinzler; "Check prepareSave() before undeleting." [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21597 [15:18:35] 03(mod) Gallery always uses user language (as opposed to say content lang) - 10https://bugzilla.wikimedia.org/38652 -patch -patch-need-review ; +comment (10Sumana Harihareswara) [15:19:01] 03(mod) Gallery always uses user language (as opposed to say content lang) - 10https://bugzilla.wikimedia.org/38652 +comment (10Sumana Harihareswara) [15:19:29] JeroenDeDauw: do you have a moment to look at an upload-related patch? https://bugzilla.wikimedia.org/show_bug.cgi?id=39346 [15:20:52] hecticsc: you've checked the various FlaggedRevs preferences & settings/config files, I presume? [15:22:08] unfortunately i dont have access to the shell but i know that the person that upgraded didnt change any files. Is there anything specific that may disable this feature in the config files? [15:22:47] hecticsc: I don't know, sorry; have you already looked through https://www.mediawiki.org/wiki/Extension_talk:FlaggedRevs ? [15:23:07] * sumanah looks, sees nothing [15:23:21] looked at http://www.mediawiki.org/wiki/Flagged_Revisions and http://www.mediawiki.org/wiki/Help:Extension:FlaggedRevs , didnt see anything that can be used to disable this specific feature [15:23:27] * hecticsc looks at the talk page now [15:23:40] there's a "stablesettings" right - do you have that right? [15:24:23] <^demon> Step 1 is making sure the extension's still enabled--is it listed on Special:Version? [15:24:28] yes it is [15:24:34] and stable settings can be changed by administrators [15:24:44] (ie. making it so pages show either latest, or stable) - that works fine [15:25:02] only the box that can choose which version is considered stable is missing [15:25:09] https://gerrit.wikimedia.org/r/#/c/20230/3/languages/messages/MessagesQqq.php Hmm, those unknown messages were introduced in the rebase. Did I do something wrong? [15:26:19] 03(NEW) Change the language picker title to "Select display language" when accessed from display settings - 10https://bugzilla.wikimedia.org/39687 normal; MediaWiki extensions: UniversalLanguageSelector; (pginer) [15:26:40] 03(mod) Change the language picker title to "Select display language" when accessed from display settings - 10https://bugzilla.wikimedia.org/39687 +i18n (10Pau Giner) [15:32:50] 03(mod) [OPS] puppet has undefined function get_var - 10https://bugzilla.wikimedia.org/38524 summary (10Antoine "hashar" Musso) [15:35:34] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21540 [15:36:13] i dont see anything about this on https://www.mediawiki.org/wiki/Extension_talk:FlaggedRevs [15:36:19] do you guys suggest posting the question there ? [15:37:20] hecticsc: post there, and on mediawiki-l. [15:37:23] !lists | hecticsc [15:37:23] hecticsc: mediawiki-l and wikitech-l are the primary mailing lists for MediaWiki-related issues. See https://www.mediawiki.org/wiki/Mailing_lists for details. [15:37:51] New patchset: Nikerabbit; "Adding our irc relay bots" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21594 [15:38:34] 03(mod) [OPS] migrate to Etherpad Lite - 10https://bugzilla.wikimedia.org/34953 summary (10Antoine "hashar" Musso) [15:39:23] New patchset: Madman; "Bug 38556 - Add header and footer messages to MediaWiki's info action" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21598 [15:40:47] rthanks! [15:40:52] * thanks! :) [15:41:15] 03(WONTFIX) move USERINFO to git - 10https://bugzilla.wikimedia.org/34851 +comment (10Antoine "hashar" Musso) [15:42:33] New review: Krinkle; "I'd like to get this out of mediawiki.util." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/19199 [15:44:14] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21406 [15:44:51] 03(NEW) action=info displays misleading edit history for redlinks - 10https://bugzilla.wikimedia.org/39688 minor; MediaWiki: User interface; (madman.enwiki) [15:46:20] Change merged: IAlex; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21407 [15:46:55] hrm, too bad http://www.mediawiki.org/wiki/Extension:Countdown is unmaintained (and doesn't work for me :) ) [15:47:02] is there a working extension like that ? [15:47:14] New patchset: Jeroen De Dauw; "Changed implementation of References interface to use objectStorage rather then hashArray since we can have elements with duplicate values and elements are mutable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21599 [15:47:16] seems like there could be interest in such a thing [15:47:23] 03(mod) action=info displays misleading edit history for redlinks - 10https://bugzilla.wikimedia.org/39688 +design +easy (10Madman) [15:47:24] 03(mod) Reimplement MediaWiki's info action (tracking) - 10https://bugzilla.wikimedia.org/38450 (10Madman) [15:48:30] actually i too would be interested in such an extension, seems nice :) [15:49:18] 03(mod) Add header and footer messages to MediaWiki's info action - 10https://bugzilla.wikimedia.org/38556 +patch-in-gerrit (10Madman) [15:49:36] 03(mod) ApiQuery->makeGeneratorList autoloads all query classes - 10https://bugzilla.wikimedia.org/39665 +comment (10Sam Reed (reedy)) [15:50:32] hi Richlv - don't know, but you might want to look around, ask on the list [15:50:39] Add http://www.widgetbox.com/widgets/make?code=countdown via !e Widgets (see http://www.mediawikiwidgets.org/Widget:Widgetbox) [15:50:59] (for Richlv & heckticsc) ^ [15:51:25] hi MaxSem [15:51:34] hey [15:53:07] New review: Nikerabbit; "Default is 'mw' (the one used to get the list of languages), but you are filtering based on mwfile. ..." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21548 [15:53:34] Richlv: Also, depending on what you mean by "live", you could do a template which does this with parserfunctions [15:55:13] Amgine, huh, that widget is in flash [15:55:25] Amgine, as for a template, that's probably above my skillset :) [15:55:42] Let me take a quick look... [15:55:43] at best i could test some extension like that... [15:55:54] 03(mod) PHP Warning: fmod() expects parameter 1 to be double, string given - 10https://bugzilla.wikimedia.org/39673 +comment (10Niklas Laxström) [15:56:27] New patchset: Jeroen De Dauw; "patch by Chris Keeline (bug 39346)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21600 [15:56:30] i'd suppose that could be used by quite many mw users. especially if it had features like img/text styling (like that unmaintained extension had), and another image/text when "the time comes" [15:57:26] 03(FIXED) Fix ZipDirectoryReader under Hiphop - 10https://bugzilla.wikimedia.org/39346 +comment (10Jeroen De Dauw) [15:57:57] Richlv: do you have parserFunctions installed? [15:58:53] sumanah: submitted in gerrit - but I cannot approve that myself (as I don't have the rights) [15:58:57] right [15:59:16] JeroenDeDauw: thanks :) [15:59:20] thedj: I should have been paying more attention this weekend, I might have been able to help you a bit more [15:59:27] JeroenDeDauw: so it looks like a good patch to you, I presume? [15:59:35] Amgine, i do, yes [15:59:43] JeroenDeDauw: it seems like we usually don't mark bugs as FIXED until the changeset is *merged*, what do you think? [15:59:54] Okay, let me take a shot on this. [16:00:13] New patchset: Burthsceh; "Escape and describe messages, and fix a typo" [mediawiki/extensions/RevisionCommentSupplement] (master) - https://gerrit.wikimedia.org/r/21601 [16:00:16] <- is a crappy template coder, but...> [16:01:48] 03(mod) Upload Wizard should check for protection status of titles - 10https://bugzilla.wikimedia.org/37107 +comment (10Mark Holmquist) [16:02:14] sumanah: fwiw, that's what I've observed [16:04:18] 03(mod) [OPS] migrate to Etherpad Lite - 10https://bugzilla.wikimedia.org/34953 +ops (10Nemo_bis) [16:05:37] 03(mod) UploadWizard reports phantom error - 10https://bugzilla.wikimedia.org/39682 +comment (10Mark Holmquist) [16:05:51] New patchset: Nasirkhan; "translation update" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/21603 [16:05:54] New review: Nischayn22; "This commits breaks the UI" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21494 [16:07:30] New patchset: Matmarex; "(bug 39273) add diff support to LivePreview" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21296 [16:07:34] 03(mod) [OPS] migrate to Etherpad Lite - 10https://bugzilla.wikimedia.org/34953 +comment (10Mark Holmquist) [16:07:50] Well that was a happy accident, that I saw that bug scroll by [16:08:14] New review: Matmarex; "Rebased and added release notes per Krinkle." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/21296 [16:08:29] New review: Jens Ohlig; "Looks good, but I seem to have problems with the setup after refactoring... Probably my fault, though." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21051 [16:08:57] New review: Nikerabbit; "Pitfall of wfMsgHtml: parameters are not escaped. Needs some rawParams() for tbd parameters." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21494 [16:09:03] New review: Siebrand; "PS3 adds proper file headers." [mediawiki/extensions/Babel] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/18437 [16:09:25] New patchset: Siebrand; "Babel maintenance." [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/18437 [16:13:00] New patchset: MarkTraceur; "Add mw.Time" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16848 [16:13:49] * siebrand has 16 patch sets with 1.482 lines of code waiting for review... https://gerrit.wikimedia.org/r/#/dashboard/92 [16:14:09] siebrand: They each have 1,482 lines of code? [16:14:32] it's the total of "+" of the 16 patch sets, marktraceur. [16:14:37] Ah [16:14:50] Less bad, I suppose [16:14:55] that's lots of work! [16:15:13] I've been reviewing the lqt patchset few files a time [16:15:16] New patchset: Matmarex; "(bug 34556) fix whitespace/scrolling issues due to content:"."" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/20538 [16:15:53] New review: Matmarex; "I went ahead and did it for you." [mediawiki/extensions/LiquidThreads] (master) C: 1; - https://gerrit.wikimedia.org/r/20538 [16:17:37] ^demon|lunch: you beat me to it on https://gerrit.wikimedia.org/r/#/c/21600/1 :) [16:17:47] <^demon|lunch> Great minds and all ;-) [16:18:24] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21594 [16:18:52] Nikerabbit: The Lqt patch is the largest one, indeed. [16:19:44] ^demon: can you give https://gerrit.wikimedia.org/r/#/c/21553/ a quick look? [16:21:58] <^demon> siebrand: I understand it conceptually--but quickly--what is this trying to fix? [16:22:03] <^demon> I'm not sure I understand that :) [16:22:17] New patchset: MarkTraceur; "(bug 32247) Add "remove file" in the details step" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9549 [16:23:54] man, do we have a lot of extensions. [16:24:02] * MatmaRex is trying to check them all out. [16:24:07] New patchset: Nullspoon; "Added $wgWhitelistReadRegexp for regex whitelisting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/11137 [16:25:34] New patchset: Siebrand; "Fix leading mixed whitespace to tabs" [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/21022 [16:25:50] ^demon: a picky parser. Nikerabbit has details. [16:26:28] MatmaRex: Oh hi! Welcome :) [16:26:40] ^demon: fmod bug? [16:26:57] <^demon> https://gerrit.wikimedia.org/r/#/c/21553/1 - whatever this is trying to fix :) [16:27:06] hi marktraceur [16:27:21] hmm that is not fmod bug [16:27:32] siebrand: what are you refering to? [16:27:39] Nikerabbit: btw, commit summary should probably mention https://bugzilla.wikimedia.org/show_bug.cgi?id=39673 [16:28:12] Nikerabbit: I was referring to https://gerrit.wikimedia.org/r/#/c/21553/. You said that was for the fmod bug (!??) [16:28:25] Now I think we may be confusing Chad a bit ... [16:28:38] lol indeed we are [16:29:12] I saw the hiphop commit and was confused [16:29:21] MatmaRex: I remember some folks have come up with Git tricks to check out all the extensions - not sure how though [16:29:46] * ^demon hides until siebrand and Nikerabbit understand what they're asking him to do [16:29:47] ^demon: https://bugzilla.wikimedia.org/39673 this is the bug [16:30:25] sumanah: http://www.mediawiki.org/wiki/Download_from_Git#Download_all_extensions [16:30:27] so something crap which is not an int or float gets all the way down to cldrpluralparser which uses fmod in certain cases [16:30:29] MatmaRex: ^ [16:30:38] New review: Siebrand; "Merged with "2 space" indentation as Niklas suggested." [mediawiki/extensions/CentralAuth] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21022 [16:30:39] Change merged: Siebrand; [mediawiki/extensions/CentralAuth] (master) - https://gerrit.wikimedia.org/r/21022 [16:30:50] oh good, docs! [16:32:10] marktraceur: you had a question for me few days ago, was it solved? [16:32:13] <^demon> Nikerabbit: So with your change, real numbers are converted to ints, and bogus input is turned into floats and we hope for the best? [16:32:18] Uhhh [16:32:22] sumanah: yes, i;m using this trick [16:32:24] marktraceur: ^ [16:32:36] Nikerabbit: IIRC it had to do with the difference between mw.msg and gM [16:32:37] MatmaRex: oh! oh good [16:32:42] it';s just that it's been crunching for like half an hours already, and doesnt seem to be near finishing :P [16:32:47] sorry, I misunderstood [16:32:51] New review: Krinkle; "Thanks" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/18234 [16:32:51] half an hour* [16:32:51] ^demon: "ints" are converted to ints and rest are converted to floats (0.0 for invalid input usually) [16:33:02] Nikerabbit: I tried to convert UploadWizard to use the former, but there were....problems [16:33:07] marktraceur: gM is deprecated, I guess there is no other difference [16:33:07] <^demon> Ok, now I get it :) [16:33:19] <^demon> Nikerabbit: Tests would be nice, if possible. [16:33:33] Probably it had to do with how I converted. I'll get back to it. [16:33:42] ^demon: let me think [16:33:44] <^demon> marktraceur: gM was an awful awful name, and I said so many times. [16:34:02] Agreed. What did it stand for, anyway? [16:34:08] <^demon> get message? [16:34:09] <^demon> I think [16:34:15] Hm. Yeah, nasty. [16:34:22] ^demon: what kind of test should that be? Parser test? [16:34:33] <^demon> Parser test would probably suffice. [16:34:43] or I could call CoreParserFunctions::plural directly [16:34:49] New patchset: Jeroen De Dauw; "Updated gitignore" [mediawiki/extensions/Nuke] (master) - https://gerrit.wikimedia.org/r/21576 [16:35:01] New review: MarkTraceur; "See responses :)" [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20814 [16:35:12] ^demon: do parsertests fail if PHP throws warning? [16:35:18] New patchset: MarkTraceur; "(bug 30625) Work better with duplicate-archive warnings" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/20814 [16:35:36] <^demon> Nikerabbit: phpunit will bail on a php error. Dunno about parserTests.php [16:35:46] New review: MarkTraceur; "TheDJ, I addressed a few of your concerns in patchset 6 and replied to others in the comments of pat..." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20814 [16:35:49] * Nikerabbit sighs [16:36:02] that's the only way I can test it I guess [16:36:42] New patchset: TheDJ; "(bug 39357) Enter in editbox should not submit Search dialog" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/19942 [16:38:14] New patchset: MarkTraceur; "(bug 39087) Limit list of possible defaults by the campaign config" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/20829 [16:38:35] New review: Siebrand; "I'll see if I can fix this." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/20230 [16:39:49] 03(mod) UploadWizard reports phantom error when mixing copyright style - 10https://bugzilla.wikimedia.org/39682 summary (10Jarry1250) [16:40:00] siebrand, https://gerrit.wikimedia.org/r/#/c/20230/3/languages/messages/MessagesQqq.php Hmm, those unknown messages were introduced in the rebase. Did I do something wrong? [16:41:37] 03(mod) UploadWizard reports phantom error when mixing copyright style - 10https://bugzilla.wikimedia.org/39682 +comment (10Jarry1250) [16:42:30] hey Krenair - hope you don't mind that I am suggesting you as a reviewer for some operations/mediawiki-config stuff [16:42:36] as always, no obligation! [16:42:44] New patchset: Nischayn22; "using smw_stats in Special Pages" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21026 [16:42:45] just saw that [16:43:29] 03(mod) UploadWizard reports phantom error when mixing copyright style - 10https://bugzilla.wikimedia.org/39682 +comment (10Mark Holmquist) [16:43:47] Nischayn22: just wanted to say \o/ YAY that SMW 1.8 is likely to be released soon with all your GSoC work! [16:44:58] New patchset: MarkTraceur; "(bug 37302) Only fire startUploads once, after all files are ready" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/10127 [16:45:29] New review: TheDJ; "Reply to the comments about warnings." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/20814 [16:45:38] New review: Sumanah; "Benny, could you please respond to Anomie's code comments and submit again, so we can get this bugfi..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/7986 [16:45:40] New patchset: Siebrand; "Show HTTP error (if any) when scary transclusion fails" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20230 [16:46:15] Krinkle|detached: Would it be good to add a qunit test for .bind? That way Jenkins could tell me that I used the wrong thing, and you wouldn't have to. [16:48:24] New review: Siebrand; "i18n/L10n looks good. Leaving the rest to others." [mediawiki/core] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/20230 [16:50:52] Change merged: Demon; [mediawiki/extensions/Nuke] (master) - https://gerrit.wikimedia.org/r/21576 [16:53:24] New review: Adamw; "Sorry, I wanted to make a few changes. Following Gabriel's advice, this should be a dequeue. Also,..." [mediawiki/extensions/Parsoid] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21139 [16:54:13] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21579 [16:54:41] New review: Siebrand; "+1 for the L10n." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/17442 [16:55:07] 03(mod) PostgreSQL LOCK IN SHARE MODE option is a syntax error - 10https://bugzilla.wikimedia.org/39635 +comment (10Marcin Cieślak) [16:55:26] siebrand: I have a separate commit for that on my local machine, just need to polish it up and send it off [16:55:35] New patchset: Yaron Koren; "New version: 1.2.2" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/21605 [16:55:53] marktraceur: cool. Mergeable after you addressed Niklas' comments? [16:56:27] New review: Mwjames; "I really hoped this change would have been applied after the 1.8 release because there is a bunch of..." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21494 [16:56:52] Change merged: Yaron Koren; [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/21605 [16:56:55] New patchset: Nullspoon; "Added $wgWhitelistReadRegexp for regex whitelisting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/11137 [16:57:08] siebrand: I think I already addressed his comments in the second patchset, Nikerabbit can you check out gerrit 17442? [16:57:16] !g 17442 | Nikerabbit [16:57:16] Nikerabbit: https://gerrit.wikimedia.org/r/#q,17442,n,z [16:57:55] marktraceur: yes, I know you did. That's why I asked if it could be merged. [16:58:13] New patchset: Hoo man; "Adding jStorage to MediaWiki" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20470 [16:58:14] New review: Jeroen De Dauw; "This will fail when using store2 right? If so, it can only go in after store3 is the default" [mediawiki/extensions/SemanticMediaWiki] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21026 [16:58:28] Oh, should be, yeah. If Nikerabbit can confirm that it's OK [16:58:47] marktraceur: If he takes another look at it, he'll probably merge it. [16:58:50] New review: Jeroen De Dauw; "Oh, please ignore my rambling in the last comment :)" [mediawiki/extensions/SemanticMediaWiki] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21026 [16:58:50] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21026 [16:58:51] I'll wait for that. [17:00:43] New patchset: saper; "(bug 39635) PostgreSQL has no LOCK IN SHARE MODE" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21606 [17:01:21] 03(mod) PostgreSQL LOCK IN SHARE MODE option is a syntax error - 10https://bugzilla.wikimedia.org/39635 +comment (10Marcin Cieślak) [17:07:20] fun fact: gerrit repos for all MW extensions take up 563 megabytes. [17:07:24] marktraceur: if it works it is fine apart from one space [17:07:27] New patchset: Jeroen De Dauw; "Fix escaping of params in messages" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21607 [17:07:28] it took me an hour and a half to download them. [17:07:39] and now i'm going to grep them all. *shudder* [17:07:46] New review: Jeroen De Dauw; "Don't panic. https://gerrit.wikimedia.org/r/#/c/21607/" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21494 [17:08:08] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21607 [17:08:21] MatmaRex: I hope you have ssd [17:08:40] ha ha ha. good one [17:09:01] New patchset: MarkTraceur; "(bug 37232) Add in {{PLURAL}} support for copyMetadata messages" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/17442 [17:09:12] the only thing my hard disk has in common with SSDs is small size [17:09:45] MatmaRex: then you can buy small SSD cheaply :) [17:09:49] Nikerabbit: Not to mention the missing semicolon! :) [17:10:06] (emacs JavaScript mode is being good to me) [17:10:12] New patchset: Hoo man; "Adding jStorage to MediaWiki" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20470 [17:10:33] New patchset: Yaron Koren; "Code no longer includes jQuery and jQuery UI" [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/21608 [17:10:35] that reminds me. what would happen if i wrote a stylize.php-like tool for JS, but in Ruby? [17:10:44] New review: Nischayn22; "actually SpecialProperties is already failing for Store2, try out with the new code from master" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21026 [17:10:57] would i get lynched or praised? :P [17:11:05] Change merged: Yaron Koren; [mediawiki/extensions/SemanticDrilldown] (master) - https://gerrit.wikimedia.org/r/21608 [17:11:16] MatmaRex: both [17:11:29] there really isn't existing one for JS? [17:11:32] hard to believe [17:11:35] nope [17:11:35] damn... git checked out of my local master as it seems, meh [17:11:37] but there is huge need for one [17:11:40] yup [17:11:51] oh look, it stopped grepping. [17:11:51] MatmaRex: I'd be in the "praising" group [17:11:59] MatmaRex: really? all the millions of JS projects out there and none of them stylizing their code? [17:12:27] as side note, I'd like to move towards more standard JS style from the current style monkeyed from PHP [17:12:46] Richlv: Here is a simplistic template to give days, hours, minutes, seconds until a target date/time: https://www.mediawiki.org/wiki/User:Amgine/countdown [17:13:06] (If the time is passed, it prints "Past") [17:13:08] Nikerabbit: oh, sure, but none have the same coding conventions as MW [17:13:18] and i found no configurable formatter [17:13:33] oh yes, i despise these conventions [17:13:38] New review: Jeroen De Dauw; "Seems to be working for me, using store2" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21026 [17:15:48] New patchset: Hoo man; "Adding jStorage to MediaWiki" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20470 [17:17:32] has there been any news about the progress with Lua templates? [17:17:43] I am testing mediawiki, how to disable loging failed times limitted [17:18:15] salle[]: I think you might want to checkout recent wikitech-l postings (!lists) [17:18:39] !lists [17:18:39] mediawiki-l and wikitech-l are the primary mailing lists for MediaWiki-related issues. See https://www.mediawiki.org/wiki/Mailing_lists for details. [17:18:59] cheers [17:19:20] hi varnent! [17:19:27] saper: hey there! :) [17:19:47] New patchset: Matmarex; "(bug 25830) fix JS preview causing the page to "jump"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18234 [17:19:49] how is stuff [17:19:54] sumanah: I have to make some calls for an event we just got thrown at us at work - but will send out an email about MW consortium (or whatever) in a few hrs [17:19:57] I wasn't very active recently [17:20:25] saper: hectic - started a new job shortly after Wikimania that has consumed all my time - but I knew that going in - so I can't complain - but I've been more inactive lately than I'd like [17:20:54] thank you varnent [17:21:06] varnent: congratulations! are you still in Washington, D.C. area? [17:21:17] saper: nope - working out of an office in Detroit [17:21:39] I keep thinking "next week things will slow down" and then the WH or someone throws a new thing at us that consumes all my time again :) [17:21:56] so I'm fighting to keep my head above water while we relaunch a bunch of initiatives and such in my "department" [17:22:04] I think I know the feeling :) [17:22:14] December will be better [17:22:31] woah .... one of my templates is mentioned in that list ..... ........... creepy [17:22:33] New patchset: Matmarex; "(bug 25830) fix JS preview causing the page to "jump"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18234 [17:22:34] it's been really fun though - I'm actually back at an org I worked for before leaving for DC - but they've merged with another org and are under a new name [17:23:04] New review: Matmarex; "Well, it turns out that a lot of extensions use this class. Worse, it turns out that some of them re..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/18234 [17:23:14] but it's the same bldg - so I'm in a former collegues office and my old office is "volunteer central" now - so having an out of body experience at times [17:23:15] or I should say where limits the trying to login number [17:23:40] saper: how are things on your end? [17:23:40] New review: Tychay; "Just tests the existence of two objects before acting on them." [mediawiki/extensions/Echo] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/19223 [17:24:24] I'm doing non-stop fundraising - so the good news is my mind is very much in a "how can we get resources for things" - which when I can breathe again I want to bring into the fold of my MW work :) [17:24:28] is it possible to permalink to a gerrit comment? [17:24:49] (comment = review) [17:25:16] varnent: I am frustrated since out of 3 trips to Washington this year none will probably come out [17:25:38] MatmaRex: can't we adopt one with nice coding conventions? [17:25:40] saper: that's a bummer :( [17:25:48] New patchset: Matthias Mullie; "hide oversight requested posts from monitors" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21609 [17:25:57] Nikerabbit: i'd love to, but i'm just a new developer here, who's gonna listen to me? :P [17:26:15] MatmaRex: lol -you'd be surprised :) [17:26:27] thank you I know how todo it now [17:26:31] Nikerabbit: also, i dislike the One True Brace Style, so... yeah. :P [17:26:33] MatmaRex: in a good way [17:26:50] varnent: yeah. I found that participation in *useless* opensource projects is much better to kill work-related frustration. Recently started porting CDE (cdesktopenv.sf.net), just for ... fun and to keep my ANSI C skills alive. [17:27:14] MatmaRex: we only need to convince Krinkle and few others and we have majority [17:27:21] saper: yeah - I've been doing some light and "mindless" coding in evenings - along with killing aliens - to vent some work stress [17:27:35] MatmaRex: I prefer Kernel Normal Form with function name at the beginning of line to search with /^.../ :) [17:27:48] i am yet to find a coding conventions set that i would like ;) [17:28:41] also, worse, for JS i prefer not using semicolons unless necessary. so that completely discredits me in any serious JS coding conventions discussion. :D [17:28:45] varnent: somehow games never work for me, I don't know why. I tried to play some old favourites of mine using emulators (F-19 Stealth Fighter or some old C-64 games) and it does not really suck me in. I don't know why - I feel ungeeky :) [17:28:48] New patchset: Jeroen De Dauw; "Added maintenance script for rebuilding the data and refactored the one for deleting a little" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21610 [17:29:06] saper: *gasp* your geek card may not get renewed this year! [17:29:32] sumanah: Hey, thanks :) [17:30:27] 03(NEW) Canadian provinces showing french names when phone is in english - 10https://bugzilla.wikimedia.org/39689 normal; WikiLoves Monuments Mobile: Browse; (brion) [17:30:39] New patchset: Siebrand; "(bug 39679) Fix invalid use of plural." [mediawiki/extensions/CleanChanges] (master) - https://gerrit.wikimedia.org/r/21611 [17:30:50] *sad that WLM doesn't have an iOS app* [17:31:05] 03(mod) Invalid use of plural - 10https://bugzilla.wikimedia.org/39679 +comment (10Siebrand) [17:31:07] varnent: in the old times, a friend of mine asked me to help to fix some operating system-related problem with his MUD site, #2 in the country (that was mid-1990s); I got a "god" (level 99) privilege as an equivalent of the in-game root access to debug the code but I was totally clueless, I only knew 5 commands or so and people were asking me for help or some "spells". It was then my geek card got revoked :) [17:32:46] saper: just don't let the cabal know or they'll revoke your wikimedian card :) [17:33:04] they don't know how to play MUD either :) [17:33:26] true - but some of them can kill aliens and zombies in their sleep [17:35:24] strange, I don't get emails after doing a review :( [17:36:24] Nischayn22: did you enable "CC Me On Comments I Write" in Settings -> Preferences? [17:36:46] sumanah: I checked in my own (not original submitter's) patch in https://bugzilla.wikimedia.org/show_bug.cgi?id=39635 - what should I do with the keywords? [17:36:52] MatmaRex: No, shouldn't it be default? [17:36:58] * sumanah is in a meeting, back in a few min, sorry saper  [17:37:24] Nischayn22: i dunno, personally i dont need me own comments mailed to me ;) [17:37:28] my* [17:38:38] MatmaRex: but you want others comments on yours comment mailed [17:39:15] argh. is there a way xml hooks can be executed at the same time or before function hooks ({{#:) [17:39:29] 03(mod) [Regression] Performer's username is shown twice in page move entries on the history - 10https://bugzilla.wikimedia.org/34961 +comment (10HJ Mitchell) [17:39:32] so i can do things like {{#ifeq:|||}} [17:39:37] sumanah: this is an absolutely non-urgent item, maybe it should go to wikitech-l [17:39:37] New review: Raimond Spekking; "Question related to removal of a message part (inline)." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21190 [17:39:49] Nischayn22: to be honest, not really either, gerrit interface is enough [17:40:13] MatmaRex: :) [17:40:20] and gerrit mails IMO kinda suck [17:40:26] Nischayn22: so you are not getting comments to your changesets? do you have an example of such a changeset in gerrit? [17:40:30] 03(FIXED) WLMMobile: show native-resolution thumbnail images - 10https://bugzilla.wikimedia.org/39630 (10Jon) [17:40:31] the only useful information there is the link to the changeset [17:40:53] they suck but Nischayn22 is the first person ever to complain getting *too few* gerrit mails [17:41:07] saper: wasn't on my changesets, now fine after preferences [17:41:11] hi StevenW [17:41:20] saper: I love reading mails ;) [17:41:21] lol saper [17:41:26] New review: Alex Monk; "Author should be "Chris Keeline " and the commit message should describe the change..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/21600 [17:42:02] can you change your email address in gerrit now or do we still get that dreaded template error? [17:42:30] <^demon> I still think that's an LDAP problem. [17:42:32] New review: Tychay; "Just tests the existence of two objects before acting on them." [mediawiki/extensions/Echo] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/19223 [17:42:36] <^demon> And the template issue is just a symptom. [17:42:40] ok [17:42:51] I also hate 0x0A at the end of a subject [17:43:00] need to check with my git master instance [17:43:29] 04(REOPENED) Fix ZipDirectoryReader under Hiphop - 10https://bugzilla.wikimedia.org/39346 +comment (10Sumana Harihareswara) [17:45:02] New review: Krinkle; "Patch Set 3: Removing 'jquery' from dependencies" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20470 [17:45:02] New patchset: Krinkle; "Adding jStorage to MediaWiki" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20470 [17:45:02] New review: Krinkle; "* Cleaned up commit-msg." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20470 [17:46:57] 03(FIXED) WLMMobile: "select all" button should be disabled when there are no incomplete uploads - 10https://bugzilla.wikimedia.org/39631 (10Jon) [17:47:52] 03(mod) Toolbar buttons don't have IDs - 10https://bugzilla.wikimedia.org/23065 +comment (10Trevor Parscal) [17:48:02] New review: Trevor Parscal; "I'm not convinced this is a reasonable bug. I left my comments on the bug page." [mediawiki/extensions/WikiEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/17150 [17:48:11] or, if it can't be, why am i seeing "invalid magic word" when adding via $parser->setFunctionHook? [17:48:51] New patchset: Krinkle; "Adding ResourceLoader module "jquery.jStorage"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20470 [17:48:55] ^demon: I have a question, I am one of the 1% and I don't like the new gerrit skin; but can the grey lines in table be a bit darker? [17:49:02] varnent: do a little searching, I think I heard some proprietary app :/ has a WLM mode or something [17:49:21] <^demon> saper: Perhaps they can. The CSS is all in the puppet repo. files/gerrit/skin/* [17:50:02] thx [17:50:07] saper: yeah, go ahead & ask in wikitech-l or get opinions from chrismcmahon [17:50:27] New review: Bsitu; "Yes, I will take care of this as soon as I can" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/7986 [17:50:37] 03(mod) No RTL support in the WLM app - 10https://bugzilla.wikimedia.org/39288 +comment (10Jon) [17:50:54] 03(WONTFIX) Toolbar buttons don't have IDs - 10https://bugzilla.wikimedia.org/23065 -patch-need-review ; +comment (10Krinkle) [17:51:08] Change abandoned: Krinkle; "Bug has been marked 'WONTFIX'." [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/17150 [17:51:26] 03(NEW) Cannot cancel batch upload - 10https://bugzilla.wikimedia.org/39690 normal; WikiLoves Monuments Mobile: Upload; (jrobson) [17:51:27] 03(mod) WikiEditor buttons should have IDs - 10https://bugzilla.wikimedia.org/23065 summary (10Krinkle) [17:52:48] 03(NEW) Delay in loading incomplete uploads - 10https://bugzilla.wikimedia.org/39691 normal; WikiLoves Monuments Mobile: Browse; (jrobson) [17:53:19] hey Daniel_WMDE - when I'm done with this meeting in 8 min, can we talk about code review [17:53:20] ? [17:53:50] 03(NEW) Ajax loader icon overlaps text - 10https://bugzilla.wikimedia.org/39692 normal; WikiLoves Monuments Mobile: Browse; (jrobson) [17:54:12] sumanah: hm... we can try, but i don't have long, have to mind the kids. bed time here. [17:54:37] sumanah: it's too bad that gerrit doesn't have a way to show the activity of a group. [17:54:54] all it can do it show the state of tickets, it doesn't seem to have a log as such. [17:55:20] hi Krinkle :) [17:55:50] o hi Krinkle [17:57:23] 03(NEW) Confirm uploads on incomplete uploads page - 10https://bugzilla.wikimedia.org/39693 normal; WikiLoves Monuments Mobile: Upload; (jrobson) [17:58:33] 03(mod) Cannot cancel batch upload - 10https://bugzilla.wikimedia.org/39690 (10Jon) [17:58:45] sumanah: I'll see if I can track something down [17:59:49] sumanah: thanks, posted! [17:59:51] 03(mod) No RTL support in the WLM app - 10https://bugzilla.wikimedia.org/39288 (10Jon) [18:00:29] hi ty, how is it going? [18:00:50] hey Daniel_WMDE -- certain activities get logged and others do not [18:00:53] It's going alright, just got out of classes til later [18:01:09] <^demon> saper: Tried out rc0 yet? [18:01:30] Daniel_WMDE: I tried something clever that did not work https://gerrit.wikimedia.org/r/#/dashboard/221+141 [18:01:44] ty: btw, you know about "Google Summer of Code"? [18:01:45] Change merged: Bsitu; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/19756 [18:01:56] Amgine, hehe, thanks. source looks anything but simple :D [18:02:07] Change merged: Trevor Parscal; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21539 [18:02:09] I've heard of it, but beyond that no [18:02:10] New review: Jeroen De Dauw; "Can we get more -1's? Might be able to get some kind of record here." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/21600 [18:02:32] ^demon: no, master [18:02:35] ty: are you at a college or university? if so, in the summers you're eligible https://blog.wikimedia.org/2012/04/23/wmf-selects-9-students-for-gsoc/ [18:02:39] (basically) [18:02:45] New review: Demon; "Well mine and Siebrand's happened at the same time ;-)" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21600 [18:02:49] ^demon: rebased my very old python patch [18:03:01] <^demon> saper: Ah. Then again, rc0 is barely behind master, so they're really the same. [18:03:23] That's neat [18:03:50] ^demon: yep I guess so. What worries me that my cool gerrit introspection stopped working. [18:03:57] <^demon> :( [18:05:31] hello [18:05:39] Nikerabbit: MatmaRex: regarding braces, it is very simple. There are languages where it matters, there are languages where it doesn't matter. Languages where you have a choice and languages where you don't. [18:05:40] hi [18:05:43] what's the best way to iterate over comma-separated lists in templates? [18:05:46] Nikerabbit: MatmaRex: here's the details of javascript: [18:06:08] Nikerabbit: MatmaRex: It does matter in javascript, and the only choose is to be foolish or wise - in the case of javascript. [18:06:11] I would be happy if I could call a template for each comma-separated portion of a string [18:06:25] Krinkle: dont try to convince me that object braces are the same as "scope"-braces. [18:06:38] New patchset: Amire80; "Get a list of the current user's Accept-Language codes" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21565 [18:06:42] PHP / Java / C: I don't know /care. But JavaScript is a different language and it does matter. Things can mean very different things depending on where the brace is in javascript. [18:07:01] Krinkle: if(stuff) \n { ... } is obviously correct syntax. return \n { ... } is obviouslky wrong syntax. [18:07:01] hi drobbins [18:07:20] MatmaRex: if (...) \n { ... come on [18:07:28] these are different kinds of braces, and should not be treated the same. [18:07:44] sumanah: hello :) [18:07:53] (disregard the spaces around { }, of course) [18:07:59] drobbins: did you already look at the Wikipedia template help pages? those are often complete [18:08:22] MatmaRex: Well, putting them on a new line is exactly what makes your case worse, because then you can't tell whether it is an object literal, or a block of code. [18:08:40] Whereas if blocks are always wrapped in curly braces and the opening is on the relevant line, it is more readable. [18:09:10] ifs, whiles, etc, are followed by blocks of code. returns arent. newline usually ends the statement. that's all the rules one needs to know, imo. [18:09:31] but i'll be happy with any conventions, provided i habe an automated tool to enforce them [18:10:10] Nope, there's a lot more to it. Either way, the discussion is pointless. We've set a convention and agreed on it. Although I'm convinced there is only one "wise" choice in javascript, even if there were more options, we've already choosen. [18:10:11] (which i dont right now, because MW's coding conventions for JS are unlike any others) [18:10:26] yes, i dont mind, and i'm not trying to enforce my own [18:10:29] btw MatmaRex you might also want to help out with Project Milkshake https://www.mediawiki.org/wiki/Milkshake [18:10:40] MatmaRex: Not really, they're the same as jQueries and Crockfords. Except for a few more spaces here and there. [18:10:47] i'm just cheerfully bitchin' ;) [18:10:53] yeah, the spaces. ;_; [18:11:24] also, i personally dislike crockford's conventions\ [18:11:31] (i dont like semicolons where unnecessary) [18:11:34] * marktraceur wonders what happens if you do `if ( condition ) { doStuff: function () {} }.doStuff();` [18:11:49] semicolons are never unnecessary. If you understand how the language works, you'd agree. [18:11:51] marktraceur: syntax error? [18:11:54] Maybe [18:12:07] Yeah [18:12:21] Looks like a one-line if statement at first glance, possibly [18:12:41] Krinkle: i know how to use them, that's why i dont. (unless the conventions make me, in which case i dont mind.) [18:13:15] MatmaRex: So tell me, how does semi colon insertion work in javascript. [18:13:26] * marktraceur listens intently [18:14:05] newlines terminate the statement, unless it's obviously unfinished, or the next line obviously lacks beginning. (tbc) [18:14:17] If it only were that sane. [18:14:24] Krinkle: javascript elves come out at night with sacks full of semicolons, and ... [18:14:33] here's how it works and why you shouldn't call it "unnecessary" [18:14:46] a statement is unfinished, if it ends with a character like "+" or "." thta requires something efter it [18:14:47] andre__: hey, got a moment? [18:15:15] ori-l: "You've been a bad boy, you're going to get DOS-style newlines in your stocking" [18:15:24] When the program is interpreted and the interpreted encounters an illegal token, it backs up 1 character, inserts a semi-colon (unconditionally) and tries again. If it still doesn't work, abort for the original error, otherwise continue. [18:15:25] That's it. [18:15:43] Eugh. [18:15:52] more elaborately / spec-langgy: http://es5.github.com/#x7.9 [18:16:04] [[Category:Bad part]] [18:16:11] Yep [18:16:30] Krinkle: cool, i didn't know that! [18:17:10] JavaScript has too many parts that are not needed, and can simply be treated as non-existent. This is how JSLint is primary intended: List all features that are bad and can be done without and forbid use of them. That's it. [18:17:28] uh, no? it only inserts semicolons on newlines, not anywhere [18:17:35] There's also a lot of good parts, which is why it can manage to do DOM manipulation, server management and interactive programming. [18:17:46] i think the grammar can be described without semicolon insertion... [18:17:54] MatmaRex: Yes, only if the offending token is a new line or a ending curly brace. [18:18:14] Which I consider unconditionally, because in other scenario's it wouldn't be a syntax error (it would simply continue the same line) [18:18:44] MatmaRex: Exactly. [18:19:22] sumanah: i'll look into milkshake, thanks [18:19:26] Richlv_: Well, simple as in it doesn't do anything else. When you take apart the source, it really is fairly simple. I just don't know how to do pretty/readable MW template code. [18:20:03] Especially functions, scope and inheritance is very powerful in JavaScript and unlike how they are in any other language (there's things like some of them in "self" and "scheme"). But all together is quite unique. [18:20:47] Lua does all right, but it's imperfect [18:21:20] New patchset: Adamw; "(FR #595) Adyen payment gateway" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/20467 [18:21:23] Though its function structure is very similar to Python's, I guess [18:22:12] Amgine, thanks, will put up this one. maybe someday a shiny extension will appear :) [18:22:17] sumanah, heja. sure! [18:22:46] New patchset: Siebrand; "More maintenance for CleanChanges extension." [mediawiki/extensions/CleanChanges] (master) - https://gerrit.wikimedia.org/r/21613 [18:26:04] Krinkle: care to re-review these two patches of mine? https://gerrit.wikimedia.org/r/#/dashboard/417 [18:27:07] New review: Aaron Schulz; "I'm leaving the bulk of this (i18n) for Niklas to CR." [mediawiki/extensions/TranslateSvg] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/20295 [18:29:05] New patchset: MarkTraceur; "Make Safari use ignorewarnings" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21614 [18:29:53] 03(mod) VisualEditor: Link-activating/following - 10https://bugzilla.wikimedia.org/33239 (10James Forrester) [18:30:04] Anything in MediaWiki comparable to TWiki's 'Web' feature? [18:30:21] <^demon> What's TWiki's web feature do? [18:30:26] I guess it would be called namespaces or something [18:30:31] 03(mod) VisualEditor: Clicking bold, italic, etc. should set state for newly entered text when no selection - 10https://bugzilla.wikimedia.org/33140 (10James Forrester) [18:30:32] it's like having multiple wikis [18:30:35] <^demon> Yes, we have namespaces :) [18:30:51] Not like multiple wikis, though [18:30:55] 03(mod) VisualEditor: Clicking bold, italic, etc. should set state for newly entered text when no selection - 10https://bugzilla.wikimedia.org/33140 (10James Forrester) [18:30:59] New patchset: Kaldari; "(bug 39087) Limit list of possible defaults by the campaign config" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/20829 [18:31:08] ^demon, http://twiki.org/cgi-bin/view/Main/WebHome up in the top left [18:31:52] Interesting. [18:31:54] Pretty much it is what it looks like: one install, a number of complete wikis under it [18:32:11] however I hate how categories work in TWiki (MediaWiki does it much better) [18:32:49] 03(mod) VisualEditor: Edit summary length counter counts characters instead of bytes - 10https://bugzilla.wikimedia.org/39558 (10James Forrester) [18:32:53] <^demon> Well you'd probably do something with namespaces to get a similar effect in MediaWiki. [18:33:48] I mean, this page http://twiki.org/cgi-bin/view/TWiki05x01/WebTopMenu -> http://twiki.org/cgi-bin/view/TWiki05x01/WebTopMenu?raw=on [18:34:06] This is insane, I have no idea what's going on here. [18:34:32] ^demon, maybe. Could try. Will namespaces isolate similar categories though? [18:34:50] <^demon> They'll isolate pages for searching/etc. [18:34:57] <^demon> But categories can span across namespaces. [18:35:00] like if I have [[Category:Foo]] in two pages in different namespaces, and go to [[Category:Foo]] in each namespace, will I see different lists of pages? [18:35:01] ah [18:35:06] 03(mod) VisualEditor: Interproject links are coloured incorrectly - 10https://bugzilla.wikimedia.org/33084 summary (10James Forrester) [18:35:56] ^demon, I think this feature is more interesting. But, well, limitations. Everything has limitations. [18:38:20] btw bluefoxxx you may enjoy skimming https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture [18:38:48] I may enjoy never using windows again [18:38:55] * bluefoxxx highlight link, middle click, nothing happen. >:| [18:39:01] Tim-away, was there a reason you didn't autoreview this? https://www.mediawiki.org/w/index.php?title=Extension:Scribunto/Deployment_priorities&diff=cur&oldid=575818 [18:39:47] sumanah, nod. Not a feature useful for MediaWiki, so not likely to be implemented? [18:40:02] (or well, relevant more than implemented) [18:40:03] 03(mod) The link in the e-mail should use https. - 10https://bugzilla.wikimedia.org/39676 (10jack.sns) [18:40:38] bluefoxxx: you mean your idea regarding namespace stuff? I don't know enough to say [18:42:13] 03(mod) VisualEditor: Support images (tracking) - 10https://bugzilla.wikimedia.org/37870 summary (10Krinkle) [18:42:15] 03(mod) VisualEditor: Using Mac OS X combination characters such as ˆ , ´ (e.g., más, â, äs) causes weird behaviour in Chrome; Safari - 10https://bugzilla.wikimedia.org/37962 (10James Forrester) [18:42:18] 03(mod) VisualEditor does not allow to type with (at least some) input methods - 10https://bugzilla.wikimedia.org/33076 (10James Forrester) [18:45:00] New patchset: Siebrand; "Replace deprecated wfMsg* calls with Message class calls." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21188 [18:45:55] New patchset: Ryan Lane; "Revert "Check the status of Nova requests, don't just assume they succeed"" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/21616 [18:45:55] New review: Siebrand; "Comments addressed in PS4." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21188 [18:46:09] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/21616 [18:46:32] New review: Siebrand; "Ehr, PS3, of course." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21188 [18:47:09] mlitn: hi. if it's not too late, can you take a look at https://en.wikipedia.org/wiki/Special:ArticleFeedbackv5/Barack_Obama?uselang=he ? In RTL a lot of the styling just disappears. [18:47:44] It may be a Resource Loader problem, but I don't remember ever seeing anything like this. [18:47:56] New review: Parent5446; "Minor docs problem (in comments)." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/14303 [18:48:23] 03(mod) VisualEditor: Invalid titles for link target are not detected by link editor (e.g. "Foo{}bar" is allowed) - 10https://bugzilla.wikimedia.org/33094 +comment (10Krinkle) [18:48:55] New patchset: Kaldari; "(bug 39087) Limit list of possible defaults by the campaign config" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/20829 [18:51:35] When should I add myself as an @author? [18:52:07] lazowik: Whenever you think of it, I suppose, and others approve your patch that does it :) [18:53:10] Thanks, will do [18:56:22] New patchset: Aaron Schulz; "[FileBackend] Bumped Swift auth caching TTL." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21617 [18:58:29] Amgine, hmm, i tried it out, but the time doesn't seem to update as i refresh the page. i assume it's quite aggressively cached ? [18:58:49] 03(NEW) A lot of the styling disappears when Special:ArticleFeedbackv5 is shown in an RLT language - 10https://bugzilla.wikimedia.org/39694 normal; MediaWiki extensions: ArticleFeedbackv5; (amir.aharoni) [18:58:49] 03(mod) RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [18:59:06] Richlv: It will depend entirely on the caching used on your site. [18:59:19] [19:00:46] 03(NEW) Losing position on back - 10https://bugzilla.wikimedia.org/39695 normal; WikiLoves Monuments Mobile: Browse; (jrobson) [19:00:51] Oh, it's an out-of-date extension, https://www.mediawiki.org/wiki/Extension:MagicNoCache [19:04:15] New patchset: Jeroen De Dauw; "Use __DIR__ instead of dirname( __FILE__ )" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21618 [19:07:00] siebrand/Nikerabbit/other 18in people: Are error messages supposed to be i18nized on the client side? [19:07:47] Not like HTML error messages, but JavaScript throw Error( 'Message' ); [19:08:08] <^demon> I'd assume not, just like exceptions aren't localized. [19:08:37] ^demon: In PHP, right? But that's because the users will never see them....users might see a JS error [19:08:39] <^demon> PHP exceptions & wfDebug() stuff aren't localized, at least. [19:08:49] <^demon> Users may very well see your exception, depending on config. [19:08:54] Hm [19:09:04] Guess I won't worry about it then [19:09:07] marktraceur: No, javascript errors may be english only, that's perfectly fine. All errors are english. [19:09:23] New patchset: MarkTraceur; "Make Safari use ignorewarnings" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21614 [19:09:29] New patchset: Jeroen De Dauw; "Fix ZipDirectoryReader under Hiphop" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21600 [19:09:30] Thanks Krinkle! [19:09:32] <^demon> And most users will just copy+paste any error they don't already understand :) [19:09:33] you mean thrown exceptions, right ? [19:09:38] Krinkle: Yup [19:09:47] those must never be shown to users [19:09:53] New review: Jeroen De Dauw; "Happy now? :)" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/21600 [19:10:05] ^demon: Error: The giflooglinator was jinabricated in the fyoooooodespot. [19:10:18] any code that catches exceptions should handle user interface properly, never forward exception messages. Especially not without context since then it won't even be useful to a developer. [19:10:30] bbl [19:10:31] ^demon: what, no -1 for writing to much? :( [19:10:38] I am dissapoint! [19:10:50] <^demon> JeroenDeDauw: I can find a reason to nitpick your commit message, if you'd like. [19:11:03] :D [19:11:52] <^demon> C'mon jenkins...finish your tests so I can go ahead and merge. [19:12:03] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21600 [19:13:11] New patchset: Jeroen De Dauw; "use __DIR__" [mediawiki/extensions/DidYouKnow] (master) - https://gerrit.wikimedia.org/r/21619 [19:13:17] Change merged: Jeroen De Dauw; [mediawiki/extensions/DidYouKnow] (master) - https://gerrit.wikimedia.org/r/21619 [19:13:36] thanks JeroenDeDauw & ^demon [19:14:24] 03(FIXED) Fix ZipDirectoryReader under Hiphop - 10https://bugzilla.wikimedia.org/39346 +comment (10Sumana Harihareswara) [19:16:42] 03(mod) Messages of log entries should support GENDER - 10https://bugzilla.wikimedia.org/24156 +comment (10Umherirrender) [19:16:55] <^demon> JeroenDeDauw: Change 21618 is like 100+ files :p [19:18:29] Krinkle: are you available to debug some JS weirdness (on a non-WMF wiki)? [19:18:48] ashley: i can help [19:19:26] New review: TheDJ; "Both the ignorewarnings and exception tested and confirmed" [mediawiki/extensions/UploadWizard] (master) C: 1; - https://gerrit.wikimedia.org/r/21614 [19:20:20] New review: MarkTraceur; "Well, that about wraps up this episode of the Prairie Home Changeset. Tune in next time, for "fixing..." [mediawiki/extensions/UploadWizard] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21614 [19:20:20] Change merged: MarkTraceur; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21614 [19:20:28] ori-l: yay, thanks :) there's a template on a page, it should look somewhat like this: http://starwars.wikia.com/wiki/Specter_of_the_Past#Appearances -- but it doesn't, see http://fi.starwars.shoutwiki.com/wiki/Specter_of_the_Past#Esiintymiset ; the [show] link isn't showing up at all, though the JS between those two sites should be identical enough (as should the template's structure, too; an editor translated the template, but all the required [19:20:28] elements and classes are present, from what I can see) [19:21:43] 03(FIXED) Allow gender distinction also for user groups - 10https://bugzilla.wikimedia.org/31503 +comment (10Umherirrender) [19:22:38] ashley: to confirm, that's collapsing/expanding the "By type" list, right? [19:23:44] ori-l: yup! on Jedipedia it's open by default and there's no toggle button whereas on Wookieepedia it's collapsed by default and the toggle button is showing up [19:23:49] 03(mod) Invalidate full cache of math image on WMF - 10https://bugzilla.wikimedia.org/24445 +comment (10Umherirrender) [19:23:57] New patchset: MarkTraceur; "(bug 30625) Work better with duplicate-archive warnings" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/20814 [19:24:02] ashley: ok, give me a few to look into it [19:24:48] ori-l: thank you, I appreciate your help :-) it's been a while since I've been beaten by a template, but seems that that happened today... [19:25:15] 03(mod) Clean up table user_newtalk - 10https://bugzilla.wikimedia.org/23847 +comment (10Umherirrender) [19:26:06] Change abandoned: TheDJ; "This will be handled in the big https://gerrit.wikimedia.org/r/20814" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21405 [19:26:14] ^demon: well, still way under 9000... [19:26:38] ^demon: I can also submit a commit per file if you prefer that :p [19:26:52] <^demon> For this, no that'd suck :) [19:27:00] <^demon> I just don't trust copy+paste ;-) [19:27:13] New review: Hoo man; "Furthermore this might be worth a Release note entry..." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/21618 [19:27:23] I did the preview thing, seems all fine [19:27:26] And jenkins is happy [19:28:07] damn, copy and pasted the same typo to all 3 comments :P [19:28:30] hoo: I love your username, because I read your message as "hoo damn," which made me giggle. [19:29:16] Oh, hoo === MatmaRex? [19:29:17] ^demon: should there be a note about that change in rel notes?? [19:29:46] marktraceur: :P hoo == 'Hoo man' :D [19:30:12] hoo: Interesting. Your username (in your host) is "Miranda", which is the same as MatmaRex's. [19:30:18] <^demon> JeroenDeDauw: Can't hurt. [19:30:21] miranda-im.org ;) [19:30:30] huh? [19:30:32] I'm forced to Windows atm... [19:30:35] Change merged: Siebrand; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/17442 [19:30:39] ah, yes. miranda, a fine IM client. [19:30:45] Usually I use pidgin under Fedora ;) [19:31:20] i prefer miranda, it has more config options ;) [19:31:27] New patchset: Jeroen De Dauw; "Use __DIR__ instead of dirname( __FILE__ )" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21618 [19:31:33] Well, that explains a lot I guess [19:32:08] MatmaRex: Yes... I got a ton of Plugins into Miranda :D [19:32:18] ^demon: FYI: 246 files changed [19:32:30] <^demon> JeroenDeDauw: And PS2 takes care of the < 5.3 problem too? [19:32:34] JeroenDeDauw: I'm not 100% sure I catched all... [19:32:44] ^demon: it does [19:32:50] let me have another look] [19:33:03] probably I have :P [19:33:07] <^demon> Ah, missed maintenance/Maintenance.php [19:33:31] i am looking for an rss extension to display rss in "normal" mode and not the default format that media wiki has for diffs. any recommendation ? [19:33:45] oops, forgot to recheck the recursive box >_> [19:34:01] <^demon> Heh, mw-config/index.php doesn't have any of this sort of checking. [19:34:10] <^demon> Heh, it'll explode pretty quickly [19:34:21] New patchset: Jeroen De Dauw; "Use __DIR__ instead of dirname( __FILE__ )" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21618 [19:34:30] New patchset: Matthias Mullie; "Bug 39451 - Protect articles to limit feedback on protected or semi-protected articles" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/20899 [19:35:12] New review: MarkTraceur; "Just a few pending comments." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/20814 [19:35:16] Change merged: Kaldari; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/20829 [19:37:05] New patchset: Aaron Schulz; "[FileBackend] Made Swift clear the auth cache on certain HTTP errors." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21659 [19:37:23] <^demon> JeroenDeDauw: PS3 looks good after you get Hoo's last thing he noted. [19:37:28] <^demon> That's the only thing I noticed too. [19:37:37] 03(FIXED) If a user's default license is set to a license that isn't allowed in a campaign, the UploadWizard breaks - 10https://bugzilla.wikimedia.org/39087 +comment (10Ryan Kaldari) [19:38:43] New patchset: GWicke; "Use tokens instead of strings in attributes; Wrap intrusive_ptr" [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21402 [19:39:00] ashley: the button has to be inside the hidable
[19:39:20] ashley: var button = getElementsByClass( 'hidable-button', box, 'span' ); [19:39:34] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/18209 [19:39:36] New patchset: Siebrand; "Follow-up Id0e3bc27: Prevent double escaping and use numParams()" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21660 [19:39:48] hallo [19:40:00] New review: Siebrand; "Comments addressed in I306c6043." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21607 [19:40:15] it's searching for a that is a child of 'box', where 'box' is an element with the 'hidable' class [19:40:18] codc: Hi! [19:40:35] hi marktraceur [19:41:07] ori-l: ah, now that clears it up a bit :) thanks! [19:41:25] New patchset: Alex Monk; "(bug 39680) Convert valign to CSS vertical-align" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21661 [19:41:37] 03(mod) Header of diffs uses obsolete attribute valign (in HTML5) - 10https://bugzilla.wikimedia.org/39680 +patch-in-gerrit; +comment (10Krenair) [19:41:58] New patchset: Daniel Kinzler; "Fix error display on failing rollback" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21662 [19:42:03] np [19:42:49] New patchset: Jeroen De Dauw; "Make use of numParams method" [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21663 [19:43:02] 14(DUP) A lot of the styling disappears when Special:ArticleFeedbackv5 is shown in an RLT language - 10https://bugzilla.wikimedia.org/39694 +comment (10Robin Pepermans (SPQRobin)) [19:43:03] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 +comment (10Robin Pepermans (SPQRobin)) [19:43:38] New review: Jeroen De Dauw; "numParams was introduced in MW 1.18, so this patch will need to wait a month or two till we're at SM..." [mediawiki/extensions/SemanticMediaWiki] (master); V: -1 C: -2; - https://gerrit.wikimedia.org/r/21663 [19:44:14] New patchset: Ryan Lane; "Bug fixes for essex upgrade" [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/21664 [19:44:30] New review: GWicke; "Addressed most comments with the new patch, see inline replies." [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21402 [19:44:45] New patchset: Adamw; "(FR #595) Adyen payment gateway" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/20467 [19:44:58] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 +i18n (10Amir E. Aharoni) [19:44:58] 03(mod) RTL/bidirectional issues (tracking) - 10https://bugzilla.wikimedia.org/745 (10Amir E. Aharoni) [19:45:01] New patchset: Adamw; "(FR #595) Adyen payment gateway" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/20467 [19:45:14] New patchset: Jeroen De Dauw; "Use __DIR__ instead of dirname( __FILE__ )" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21618 [19:45:16] New review: Demon; "Rather than adding style="vertical-align:top" all over the place, how about adding a .valign-top cla..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21661 [19:45:25] hashar: Are you still on vacation? :) [19:45:30] Change merged: Ryan Lane; [mediawiki/extensions/OpenStackManager] (master) - https://gerrit.wikimedia.org/r/21664 [19:45:53] marktraceur: hello. I am back today :-)) [19:46:07] marktraceur: I have seen you added Javascript unit test to your ether pad extension, you might want to poke Krinkle about it [19:46:09] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 normal->major (10Matthias Mullie) [19:46:14] ^demon: whats the point of the class, then, if it carries no "semantic" meaning? [19:46:23] (ad. https://gerrit.wikimedia.org/r/#/c/21661/) [19:46:49] <^demon> Just a suggestion. [19:46:51] New review: TheDJ; "Works just fine now." [mediawiki/extensions/UploadWizard] (master) C: 1; - https://gerrit.wikimedia.org/r/9549 [19:46:54] hashar: I asked him a while back, never heard anything. Krinkle, ping re: 14153 [19:47:06] !g 14153 | Krinkle [19:47:06] Krinkle: https://gerrit.wikimedia.org/r/#q,14153,n,z [19:47:14] <^demon> MatmaRex: I don't really care--I have no vested interest. [19:47:47] just asking [19:47:49] :) [19:48:10] it's just that basically every suggestion during code review will end up being implemented [19:48:26] especially a suggestion coming from somebody with merge rights ;) [19:49:18] ^demon, for one CSS property there doesn't really seem to be a point in adding a new class [19:50:12] <^demon> I WAS JUST SUGGESTING THE IDEA GOSH GUYS [19:50:14] <^demon> ;-) [19:50:22] we'd have to add class="valign-top" everywhere instead [19:52:11] ^demon: why u no merge? :( [19:52:14] New review: Matmarex; "I don't think a class should be used if it carries no semantic meaning. " [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/21661 [19:52:21] <^demon> JeroenDeDauw: Was there a PS4? [19:52:30] yeah [19:52:47] <^demon> Ah, indeed there was. [19:52:48] <^demon> Moment. [19:53:27] Change merged: Demon; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21618 [19:54:35] 4 patchsets and a merge in an hour. why is code review of my commits moving at such glacial pace? ;_; [19:55:05] New patchset: Kaldari; "(bug 32469) Remove alert message and use callbacks for validation" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/7608 [19:56:16] 03(FIXED) Wrong quotes used in Uri.php on line 121 - 10https://bugzilla.wikimedia.org/39672 +comment (10Antoine "hashar" Musso) [19:56:58] New review: Siebrand; "Hmm. You're right. And that's not documented, unfortunately." [mediawiki/extensions/SemanticMediaWiki] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21663 [19:57:00] MatmaRex, hm. HTML align is CSS text-align isn't it? [19:57:37] yes [19:58:02] 03(NEW) Innocent looking 'Edit deletion reasons' permanently damages interface - 10https://bugzilla.wikimedia.org/39696 normal; MediaWiki: Page deletion; (jidanni) [19:58:04] Change merged: Trevor Parscal; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21338 [19:58:11] 03(mod) robots.txt - 10https://bugzilla.wikimedia.org/38217 +comment (10Antoine "hashar" Musso) [19:58:19] New patchset: MarkTraceur; "(bug 30625) Work better with duplicate-archive warnings" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/20814 [19:58:33] New patchset: Siebrand; "Document that numParms() was introduced in 1.18." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21665 [19:58:50] Woho! [19:59:06] ^demon: thnx [19:59:14] New review: Siebrand; "@since for numParams() added in I5f62c314." [mediawiki/extensions/SemanticMediaWiki] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21663 [19:59:15] <^demon> you're welcome. [19:59:22] <^demon> micro-optimization ftw :) [19:59:30] New review: TheDJ; "Works for me" [mediawiki/extensions/UploadWizard] (master) C: 1; - https://gerrit.wikimedia.org/r/10127 [19:59:33] Change merged: Nikerabbit; [mediawiki/extensions/CleanChanges] (master) - https://gerrit.wikimedia.org/r/21611 [20:00:59] New review: IAlex; "Wrong parent commit." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21665 [20:01:28] New review: MarkTraceur; "I was super-sneaky and put this into I6f213128 in some form." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21412 [20:01:35] 03(mod) Innocent looking 'Edit deletion reasons' permanently damages interface - 10https://bugzilla.wikimedia.org/39696 (10jidanni) [20:02:32] New patchset: Siebrand; "Follow-up Id0e3bc27: Prevent more double escaping." [mediawiki/extensions/SemanticMediaWiki] (master) - https://gerrit.wikimedia.org/r/21660 [20:02:41] lol wut@bug #39696 [20:03:40] New review: Siebrand; "PS2 changes the commit summary and removes the use of numParams(). Only fixing a double escaping iss..." [mediawiki/extensions/SemanticMediaWiki] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21660 [20:04:13] New patchset: Trevor Parscal; "A bit of cleanup in the inspector and suggestion code" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21668 [20:04:17] <^demon> ashley: It's jidanni, what do you expect? [20:04:41] I might be wrong [20:04:52] But I think the problem is "Edit deletion reasons" is misleading?