[07:41:39] No [07:47:48] 03(NEW) WikiEditor builds tables in toolbar using obsolete attribute valign (in HTML5) - 10https://bugzilla.wikimedia.org/39726 normal; MediaWiki extensions: WikiEditor; (listenleser) [07:53:03] New patchset: Nasirkhan; "updated the test cases" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/21704 [07:54:02] New patchset: Nikerabbit; "Fix Icfa371d2: some workaround to avoid unstub exception and typofix" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21705 [07:56:22] 03(FIXED) wikimedia-job-runner should be able to run a specific job type - 10https://bugzilla.wikimedia.org/38455 +comment (10Antoine "hashar" Musso) [07:58:01] 03(FIXED) jobs-loop.sh should be part of wikimedia-job-runner package - 10https://bugzilla.wikimedia.org/37473 +comment (10Antoine "hashar" Musso) [08:02:13] New review: Nasirkhan; "updated the test cases. should be ok now." [mediawiki/extensions/Narayam] (master) C: 0; - https://gerrit.wikimedia.org/r/21700 [08:13:36] 03(NEW) Location should be placed after Information template - 10https://bugzilla.wikimedia.org/39727 normal; MediaWiki extensions: UploadWizard; (hartman) [08:13:41] New patchset: Nikerabbit; "Fix Icfa371d2: some workaround to avoid unstub exception and typofix" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21705 [08:15:33] 03(mod) Location should be placed after Information template - 10https://bugzilla.wikimedia.org/39727 normal->trivial (10Derk-Jan Hartman) [08:22:22] New patchset: Henning Snater; "site links table language code column" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21706 [08:31:20] hi ppl! i have moved my mediawiki installation to new server. And there is a problem - apache suddenly segfault at random time : [Tue Aug 28 12:16:53 2012] [notice] child pid 88735 exit signal Segmentation fault (11) [08:31:36] Please help me to find out reason [08:32:10] this might not be the best channel for that [08:32:21] ather sites on this server and this php working fine, only mediawiki causes apache to segfault [08:33:15] Change merged: Amire80; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21705 [08:33:22] Nikerabbit: please point me to right chan, if u know one [08:34:20] it might be caused by mediawiki code but ultimately it is bug in PHP or apache, likely you would need to get stack traces or or investigate the core dumps [08:34:23] New patchset: Amire80; "Get a list of the current user's Accept-Language codes" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21565 [08:37:31] New patchset: Nikerabbit; "Get a list of the current user's Accept-Language codes" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21565 [08:38:09] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21327 [08:39:03] Change merged: Nikerabbit; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21565 [08:40:13] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21550 [08:42:10] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21552 [08:42:30] Change merged: Nikerabbit; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21262 [08:58:08] https://gerrit.wikimedia.org/r/#/c/21568/ does not work completely it seems. i'd be grateful if someone could help. it seems the tag is "executed" way after {{#: functions, and thus makes it impossible to work with it (and do things like 2 columns if more than x references). if it is done as {{#refcount:, then tags haven't been executed yet, so i see no way to do it. ideas? thanks [09:05:28] 03(NEW) Inputboxes use obsolete attribute align (in HTML5) - 10https://bugzilla.wikimedia.org/39728 normal; MediaWiki extensions: Inputbox; (listenleser) [09:11:10] 03(FIXED) Run jenkins tests with $wgDevelopmentWarnings - 10https://bugzilla.wikimedia.org/38882 +comment (10Antoine "hashar" Musso) [09:11:12] New patchset: Nikerabbit; "1.20wmf10 wikihiero to master: rtl fix" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21708 [09:11:29] Change merged: Nikerabbit; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21708 [09:12:08] 03(mod) [upstream] Jenkins can't fingerprint .git/FETCH_HEAD - 10https://bugzilla.wikimedia.org/38260 summary (10Antoine "hashar" Musso) [09:12:24] 03(mod) [upstream] Dependency graph points to localhost:8080 - 10https://bugzilla.wikimedia.org/35982 summary (10Antoine "hashar" Musso) [09:12:52] 03(mod) [upstream] Jenkins cookie sent without secure flag - 10https://bugzilla.wikimedia.org/34379 summary (10Antoine "hashar" Musso) [09:17:08] New patchset: Daniel Kinzler; "Show link to conflicting item if sitelink exists." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21709 [09:17:52] 03(mod) a lone "0" in a tag disappears - 10https://bugzilla.wikimedia.org/39643 +comment (10Antoine "hashar" Musso) [09:19:06] 03(mod) a lone "0" in a tag disappears - 10https://bugzilla.wikimedia.org/39643 +comment (10Antoine "hashar" Musso) [09:19:40] New patchset: Nikerabbit; "Bundling Solarium 2.4.0 with Translate for easy of use" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/21710 [09:21:03] New patchset: Nikerabbit; "Bundling Solarium 2.4.0 with Translate for ease of use" [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/21710 [09:21:47] Change merged: Siebrand; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/21710 [09:26:05] 03(UNCONFIRMED) Google toolbar spell check not compatible with new toolbar - 10https://bugzilla.wikimedia.org/23518 +comment (10Antoine "hashar" Musso) [09:27:24] New patchset: Nikerabbit; "Cherrypick: Bundling Solarium 2.4.0 with Translate for ease of use" [mediawiki/extensions/Translate] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21711 [09:27:56] Change merged: Nikerabbit; [mediawiki/extensions/Translate] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21711 [09:28:26] 14(WFM) 1.12 (and up) upload fails on Windows Server - 10https://bugzilla.wikimedia.org/14213 +comment (10Antoine "hashar" Musso) [09:29:25] 03(NEW) Tooltipp not closing when pressing ESC while adding new sitelink - 10https://bugzilla.wikimedia.org/39729 normal; MediaWiki extensions: WikidataRepo; (tobias.gritschacher) [09:30:01] 03(mod) Tooltipp not closing when pressing ESC while adding new sitelink - 10https://bugzilla.wikimedia.org/39729 (10tobias.gritschacher) [09:31:00] New patchset: Nikerabbit; "1.20wmf10: Update Translate to 1.20wmf10 branch" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21712 [09:31:20] Change merged: Nikerabbit; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21712 [09:31:31] New review: Daniel Kinzler; "This works nicely, thanks!" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21685 [09:33:10] 14(WFM) Unintuitive nagging for gerrit after review - 10https://bugzilla.wikimedia.org/35883 +comment (10Antoine "hashar" Musso) [09:35:01] 03(mod) Inverted comma character shown incorrectly on Burmese wikis - 10https://bugzilla.wikimedia.org/39627 (10Srikanth Logic) [09:36:41] New patchset: Tobias Gritschacher; "Changed @file into @file" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21011 [09:37:30] 03(FIXED) Categories appearance in Google Chrome - 10https://bugzilla.wikimedia.org/39047 +comment (10Antoine "hashar" Musso) [09:38:17] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21011 [09:41:03] 06(LATER) Bugzilla uses invalid markup or wrong doctype - 10https://bugzilla.wikimedia.org/1463 +comment (10Antoine "hashar" Musso) [09:41:18] 03(mod) Internationalize ULS - 10https://bugzilla.wikimedia.org/39231 summary; +comment (10Srikanth Logic) [09:41:44] 03(mod) UI language change preview in display settings - 10https://bugzilla.wikimedia.org/39684 (10Srikanth Logic) [09:41:46] 03(mod) Internationalize ULS - 10https://bugzilla.wikimedia.org/39231 (10Srikanth Logic) [09:44:29] 03(mod) Change the language picker title to "Select display language" when accessed from display settings - 10https://bugzilla.wikimedia.org/39687 +comment (10Srikanth Logic) [09:46:02] New review: Tobias Gritschacher; "documentation" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21610 [09:48:44] New patchset: Henning Snater; "site links table language code column" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21706 [09:49:34] 03(mod) recover /etc from -feed - 10https://bugzilla.wikimedia.org/38611 +comment (10Antoine "hashar" Musso) [09:50:28] 03(NEW) Database error on de.wikipedia.beta.wmflabs.org (user contributions) - 10https://bugzilla.wikimedia.org/39730 normal; Wikimedia Labs: deployment-prep (beta); (listenleser) [09:51:49] 03(mod) recover /etc from -feed - 10https://bugzilla.wikimedia.org/38611 +comment (10Peter Bena) [09:51:58] New patchset: Tobias Gritschacher; "refactoring selenium: added methods for common tasks to page object." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21564 [09:58:13] 14(WFM) Retrieve the first image used on a page - 10https://bugzilla.wikimedia.org/35647 (10Antoine "hashar" Musso) [09:59:15] Hmm, I need to find an interesting bug to work on :/ [09:59:25] 03(mod) Make Special:Whatlinkshere includable - 10https://bugzilla.wikimedia.org/35486 +easy (10Antoine "hashar" Musso) [10:00:45] 03(mod) Make Special:Whatlinkshere includable - 10https://bugzilla.wikimedia.org/35486 (10Antoine "hashar" Musso) [10:06:37] 03(mod) Make enhanced recentchanges the default - 10https://bugzilla.wikimedia.org/35785 +comment (10Oliver Keyes) [10:07:39] New patchset: Jarry1250; "Rewrite the ThumbnailImage constructor to take parameter array" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21321 [10:09:51] 03(mod) Database error on de.wikipedia.beta.wmflabs.org (user contributions) - 10https://bugzilla.wikimedia.org/39730 +comment (10Peter Bena) [10:09:54] New patchset: Jarry1250; "rm now unnecessary todo" [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/21713 [10:11:06] Change merged: Jarry1250; [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/21713 [10:11:29] 03(mod) Database error on de.wikipedia.beta.wmflabs.org (user contributions) - 10https://bugzilla.wikimedia.org/39730 +comment (10Peter Bena) [10:14:02] New patchset: Platonides; "Refactor countries(), making it a lower-level function suitable for external use." [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/21714 [10:14:05] Change merged: Platonides; [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/21714 [10:15:06] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21564 [10:17:33] New patchset: Jarry1250; "Add Special:TranslateNewSvg, to allow translations from a user-selected source language to be imported." [mediawiki/extensions/TranslateSvg] (master) - https://gerrit.wikimedia.org/r/19767 [10:18:42] New patchset: Platonides; "Follow-up" [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/21715 [10:18:44] Change merged: Platonides; [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/21715 [10:19:34] 03(mod) Change the language picker title to "Select display language" when accessed from display settings - 10https://bugzilla.wikimedia.org/39687 +comment (10Santhosh Thottingal) [10:30:27] New patchset: Henning Snater; "site links table language code column" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21706 [10:30:43] 03(ASSIGNED) Innocent looking 'Edit deletion reasons' permanently damages interface - 10https://bugzilla.wikimedia.org/39696 +comment (10Dereckson) [10:31:10] 03(mod) On deletion page, the 'Edit deletion reasons' link is misleading. - 10https://bugzilla.wikimedia.org/39696 +design; summary (10Dereckson) [10:32:31] I just upgraded from 1.15 to 1.19 and when I load the page there's no graphics, no layout, no custom fonts, etc, everything is text [10:33:30] maybe its my LocalSettings.php ... grr [10:33:43] About preferences, should we be liberal and add them a generous way, or should we ponder each time the complexity code extra if occured? I've a practical case here: https://bugzilla.wikimedia.org/show_bug.cgi?id=39696 [10:34:59] Someone felt (using a text browser) the 'Edit deletions reasons' "innocent looking" (sic) link after the delete form "damages the interface" (sic). We could add a setting to hide it but... I'm not comfortable with the idea to add settings to do anything. [10:35:07] New patchset: IAlex; "Moved warning stuff into MWDebug class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21408 [10:39:08] oskie: is your wiki public or internal? [10:40:17] That sounds like a $wgStylePath type thing? [10:40:22] * Lcawte shrugs [10:43:50] New patchset: Siebrand; "(bug 39723) Use terms "translation unit" and "state" consistently." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/21716 [10:45:13] Change merged: Siebrand; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/21716 [10:45:35] 03(FIXED) Use terms "translation unit" and "state" consistently - 10https://bugzilla.wikimedia.org/39723 +comment (10Siebrand) [10:46:00] Dereckson: internal... it seems all CSS is gone... [10:46:20] /w/load.php?debug=false&lang=en&modules=mediawiki.legacy.commonPrint%252Cshared%257Cskins.vector&only=styles&skin=vector&* loads an empty page [10:47:05] Dereckson: well, its here: https://wiki.psplugin.com/ [10:48:06] Okay. What steps did you follow for the upgrade? [10:49:29] New patchset: Henning Snater; "site links table language code column" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21706 [10:49:54] install new pkg (debian), dump db, create AdminSettings.php, php [dir]/update.php - that's it [10:51:26] Hmmm... I'm not really familiar with the way Debian packages MediaWiki code. I know some files like maintenance scripts could be missing or put in different location. [10:52:49] If you've still an operationnal 1.15 version, maybe could you test with 1.19 release from mediawiki.org? [10:55:20] Dereckson: I don't, unfortunately [10:57:01] I'm totally stumped. I mean, I don't even know how to troubleshot this since there are no error indications anywhere. How can I enable debugging in MediaWiki? I see debug=false in page loads [10:57:23] ah found some info on http://www.mediawiki.org/wiki/Manual:How_to_debug [11:04:48] oskie: in such scenario, I would personnaly use another approach than debug the broken install: backup everything, install a fresh 1.19 copy and then copy data from old database to new one. [11:05:00] oskie: i guess it's just that the script path or style path is wrong. [11:05:18] oskie: had you not just kileld your config, i could probably have told you how ;) [11:06:01] 03(mod) Add primary key and log fields to archive table; perhaps also use original page_id when page is restored? - 10https://bugzilla.wikimedia.org/39675 +comment (10Dereckson) [11:11:28] DanielK_WMDE: my config is there... I just experimented a bit [11:13:30] oskie: try $wgResourceLoaderDebug = true; [11:13:47] that will stop mediawiki from mashing all the CSS into one big request [11:14:08] actually... [11:14:49] huh, looks like that actually fixed the problem [11:15:01] DanielK_WMDE: yes! adding that variable fixed it! strange! [11:15:12] so there may be a problem with the resource loader / combiner / minifier thingummy [11:15:36] New patchset: Henning Snater; "site links table language code column" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21706 [11:15:40] 03(mod) Review and deploy TimedMediaHandler extension (timed media handler) to Wikimedia wikis - 10https://bugzilla.wikimedia.org/27699 +comment (10Jan Kucera (Kozuch)) [11:15:42] oskie: ok, so the problem isn't as simple as I thought. you can keep it like this for now, but i suggest to catch Krinkle when he's online [11:15:50] he probably knows this stuff best [11:16:17] DanielK_WMDE: great, thanks for the help! [11:16:19] New patchset: Matthias Mullie; "RTL improvements" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21717 [11:16:21] np [11:16:36] is it possible to embed mht files in mediawiki? i just get the code text output.. [11:17:49] sry my bad, firefox doesnt support it :D [11:17:54] HadoBrando: you can probably use the HTMLets extension to do that, though you'll have to rename the files to .html [11:18:00] MHT is just html, right? [11:18:11] container [11:18:20] This RFC describes the format: https://tools.ietf.org/html/rfc2557 [11:18:50] at page 7 there is a sample on how several html are aggregated [11:18:52] i try to embed excel(and office in general) files [11:18:56] ah, right, MIME container [11:18:59] mht seems the way to go [11:19:37] HadoBrando: well... *something* needs to take apart the container and make the embedded resources into something the browser understands. [11:19:40] New patchset: John Erling Blad; "(Bug 37685) Initial commit for checking edit conflicts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [11:19:51] HadoBrando: mediawiki doesn't understand the format. nither does the browser. so... [11:19:58] danielK_wmde it works in IE without a problem, its a firefox limitation [11:20:07] probably something with activex security or something [11:20:31] HadoBrando: i'd say it's a very special IE feature, i'd be surprised if any other browser had it. [11:20:52] why, its just opening a mht and displaying hmtl? [11:20:54] whats so special about it [11:21:52] it'S just a non-standard format i guess. not widely used. [11:22:00] HadoBrando: wikipedia to the rescue: http://en.wikipedia.org/wiki/.mht [11:22:17] if you want to rely on browser support, use an iframe to embed the file [11:22:35] proprietary shit damn ;( [11:22:53] iframe, thanks, gonna google that :D [11:22:55] otherwise, you'll need a mediawiki extension to process it and turn it into "plain" html [11:23:37] HadoBrando: you could try "data URLs" for an alternative way to embed resources in an HTML file. Then you can easily use HTMLets to include thise [11:24:11] i just look for an easy way to get my users off the fileserver, i hate using IE for the intranet only [11:24:29] http://en.wikipedia.org/wiki/Data_URI_scheme [11:25:33] DanielK_WMDE: strange, the resource debug setting didn't fix it for Chrome... only IE and FF [11:26:10] I'll have to dig some deeper [11:26:54] http://www.mediawiki.org/wiki/Extension:Website_in_iFrame [11:26:55] brrrrrr [11:28:48] DanielK_WMDE: ah... in IE the page looks broken and it shows "Only secure content is displayed". If I click Show all content then it displays the page correctly. In this case "secure" means served by https [11:29:48] so I think the problem is that the page presents absolute URLs with http header rather than https... (the web server, apache, doesn't handle https - external loadbalancers do) [11:34:19] !wg Protocol | oskie [11:34:20] oskie: https://www.mediawiki.org/wiki/Manual:$wgProtocol [11:34:25] !wg Server | oskie [11:34:25] oskie: https://www.mediawiki.org/wiki/Manual:$wgServer [11:36:35] DanielK_WMDE: got it. yep, setting wgServer to the https URL fixed the problem! [11:36:57] HadoBrando: http://www.mediawiki.org/wiki/Extension:Include#iframe_.28needs_.27iframe.27_feature.29 [11:37:38] oskie: ah, i see $wgProto is finally gone. [11:37:43] ok, great! [11:39:51] New review: Daniel Werner; "very nice" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21706 [11:39:51] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21706 [11:40:12] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20738 [11:40:12] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20738 [11:40:32] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20878 [11:40:33] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20878 [11:40:44] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20882 [11:41:52] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20895 [11:41:53] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20895 [11:42:04] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20896 [11:42:05] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20896 [11:42:19] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20898 [11:42:19] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20898 [11:42:46] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20900 [11:42:47] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20900 [11:43:34] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20904 [11:44:09] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20906 [11:44:09] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20906 [11:44:22] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21345 [11:44:23] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21345 [11:44:44] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21346 [11:44:45] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21346 [11:45:21] New patchset: Siebrand; "More maintenance for CleanChanges extension." [mediawiki/extensions/CleanChanges] (master) - https://gerrit.wikimedia.org/r/21613 [11:45:45] Change merged: Siebrand; [mediawiki/extensions/CleanChanges] (master) - https://gerrit.wikimedia.org/r/21613 [11:48:06] New patchset: Daniel Kinzler; "EditPage cleanup - parser errors, etc" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20882 [11:48:30] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20882 [11:49:15] * siebrand cheers DanielK_WMDE on! [11:49:24] New patchset: Amire80; "Circular scrolling through the regions" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21047 [11:50:23] New patchset: Daniel Kinzler; "Updating of redirect target in Content objects" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20904 [11:50:42] New review: Amire80; "Lazy loading of regions works correctly, but as soon as I get to the last "WW" region, it scrolls al..." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21047 [11:53:11] siebrand: well, self-review is kinda cheating ;) [11:53:44] siebrand: btw, i'm a bit stumped by jenkins. what exactly failed here? https://gerrit.wikimedia.org/r/#/c/20882/ [11:53:59] resp https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/4321/ [11:54:13] hm, where's hashar? [11:54:36] DanielK_WMDE: PHP Parse error: syntax error, unexpected T_SL in includes/EditPage.php on line 1496 [11:54:47] o_O [11:54:59] huh, looks like i screwed up a manual merge there. but... [11:55:14] liangent: how did you find that? i kept klicking around the jenkins output and didn't see anything [11:55:37] DanielK_WMDE: https://integration.mediawiki.org/ci/job/MediaWiki-Universal-Linter/3735/console [11:57:56] New patchset: Platonides; "Sort the country sidebar by country name in local language, instead of sorting by ISO 3166 code." [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/21718 [11:57:59] Change merged: Platonides; [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/21718 [11:58:13] mlitn: Hi. Any ideas about that weird RTL bug? [11:58:54] hi aharoni [11:59:38] no I haven't - on my local setup the styles are applied just fine (fixed some css to improve rtl, but that's it) [12:00:30] parts of the css just doesn't appear to be loaded on en.wp, haven't yet dug deeper into it though [12:05:33] New patchset: Jeroen De Dauw; "Added maintenance script for rebuilding the data and refactored the one for deleting a little" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21610 [12:05:37] New review: Santhosh; "that is why it is called circular. Pau also commented that it should not be circular. Can be fixed i..." [mediawiki/extensions/UniversalLanguageSelector] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21047 [12:07:42] ugh. [12:08:31] the other day, my change that makes tests fail on wfWarn got merged. it also makes tests fail when they use deprecated functions, it seems. [12:08:41] which is fine - unless you are trying to test a deprecated function :/ [12:09:43] DanielK_WMDE, there's a way to avoid that [12:10:23] Platonides: which one? [12:10:25] you call hideDeprecated() just before that function call [12:10:41] there are some tests with that [12:10:44] Platonides: will have a look, thanks [12:11:09] I think they already failed before if you had developmentwarnings on [12:12:07] yes. [12:12:22] my change just forced developmentwarnings for phpunit tests [12:12:25] 03(FIXED) PostgreSQL LOCK IN SHARE MODE option is a syntax error - 10https://bugzilla.wikimedia.org/39635 -easy -patch -patch-need-review ; +comment (10Dereckson) [12:12:34] Platonides: uh... where do i find hideDeprecated? [12:12:41] New patchset: Nikerabbit; "Fix bug: language stuck in English" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21719 [12:13:19] 03(mod) PostgreSQL LOCK IN SHARE MODE option is a syntax error - 10https://bugzilla.wikimedia.org/39635 +comment (10Dereckson) [12:13:51] Platonides: ah, found it in the base class. hm. [12:13:58] unhiding is not supported. not so nice. but oh, well. [12:15:26] http://www.mediawiki.org/wiki/Extension:MHTML im trying to implement this, got it as far as the tags to work and display an iframe, but i dont have the mentioned button nor does the extension really "fill up" the created files... any clue what could be wrong? [12:16:44] People who like answering Git questions: http://dw-dev-training.dreamwidth.org/39065.html [12:16:53] saper: ^ [12:17:43] New patchset: Micha? ?azowik; "(bug 39130) Added (restore) links to old version and history pages." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21685 [12:21:09] any (proposed) lua api to call mw api with a fauxrequest-like stuff or something? [12:21:30] New review: Micha? ?azowik; "Addressed everything but location of the link on old page view." [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/21685 [12:21:37] (with writing api removed) [12:21:45] DanielK_WMDE did you mean the MHTML extension or is there a newer extension which has these functions? [12:22:46] New patchset: Alex Monk; "(bug 39728) Replace obsolete align attribute with CSS" [mediawiki/extensions/InputBox] (master) - https://gerrit.wikimedia.org/r/21720 [12:23:04] 03(mod) Inputboxes use obsolete attribute align (in HTML5) - 10https://bugzilla.wikimedia.org/39728 +comment (10Krenair) [12:25:32] sumanah: do you mean I'm into extreme sports?:) [12:25:39] ha! [12:26:07] HadoBrando: i have no idea, i dodn't even know there was a MHTML extension. if you don't want to require browser support, you have to untangle the mime archive on the server. no trivial at all, mind you [12:26:32] i mean, constructing urls for the extracted resources, making sure you don't infect your box when unpacking them, etc [12:26:36] hi sumanah [12:26:50] mlitn: did you merge the other branch to master? [12:27:30] liangent: not sure, you should ask on the Lua scripting's talk page [12:27:34] or wikitech-l [12:27:51] vvv: ^^ do you know the answer to liangent's question, re an API? [12:28:01] hi DanielK_WMDE, how is your day going? [12:28:24] New patchset: Siebrand; "Maintenance for Wikibase extensions." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21721 [12:28:39] sumanah: I'm asking this just because I see vvv here [12:29:12] sumanah: didn't know that website, do you know what this is more or less? [12:30:31] New review: Siebrand; "Comment fixed in next PS I'll merge." [mediawiki/extensions/Babel] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/18437 [12:30:55] saper: that's a Dreamwidth developer - DW is a blogging platform/community. They just switched to GitHub for their development [12:30:58] New patchset: Siebrand; "Babel maintenance." [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/18437 [12:31:37] New review: Siebrand; "Merge per Niklas with comment on PS3 fixed." [mediawiki/extensions/Babel] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/18437 [12:31:38] Change merged: Siebrand; [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/18437 [12:33:47] sumanah: http://dw-dev-training.dreamwidth.org/39065.html#comments [12:33:49] sumanah: thanks! will check it out [12:34:11] Change merged: Siebrand; [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/21476 [12:34:16] Thanks Dereckson [12:34:25] Change merged: Amire80; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21719 [12:34:35] aharoni: not yet merged to master - hopefully later today [12:34:57] Dereckson: hope you don't mind the code review requests I've been sending your way :) no obligation, of course [12:36:58] hello sumanah [12:37:05] hiya! [12:37:07] yuvipanda! [12:37:11] siebrand! [12:37:30] how's life in education, yuvipanda ? [12:37:41] sumanah: I am indeed back in College - for the last two months! [12:37:47] Yesterday, I counted the amount of changesets on Gerrit we received in 24h. I'm impressed we're at 150+. [12:37:59] siebrand: I think I just went from 'omg-so-horrible-gaaah' to 'meh' [12:38:00] yuvipanda: so, now that you're back at college, I hope I can ask you for some finishing-up of your old GSoC work, and some code review to help out other volunteers [12:38:03] siebrand: so handling it okay :) [12:38:12] Dereckson: Did you remove L10n-bot patch sets from that count? [12:38:30] Dereckson: I'm happy about that, and I'm happy that we're getting more and more code review from *lots of developers* [12:38:46] sumanah: never quick enough :) [12:39:15] siebrand: silly me, I thought August was around when school started..... [12:39:26] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21721 [12:39:38] New review: Jeroen De Dauw; "Awesome, thnx! :)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21721 [12:39:39] siebrand: they appear in https://gerrit.wikimedia.org/r/#/q/status:open,n,z? [12:40:04] Dereckson: Nope. L10n-bot commits are merged from the same script that makes them. [12:40:19] New patchset: Jeroen De Dauw; "fix tabs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21722 [12:40:53] Dereckson: so, they appear as status:merged [12:41:03] sumanah: good point. I've been using this time as "Mobile Wiki experiments!" time, and been working on more Wiki Mobile stuff (https://www.mediawiki.org/wiki/Signpost_Mobile_App) [12:41:07] Oh, yes, I only counted "not merged the same day" ones. [12:41:12] Dereckson: you can find EVERYTHING by doing status:merged OR status:open OR status:abandoned [12:41:21] Change merged: Siebrand; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21722 [12:41:22] and then chuck in "-owner:L10n-bot" [12:41:28] but I think a break to PHP wouldn't be a bad idea, and I'll look into it once I release the app I was working on? (Wikipedia Signpost) [12:41:59] sumanah: and as for review - I've not touched PHP in the last 8 months (been doing purely JS), so can help out with JS review. Do you have anyone particular in mind? [12:42:23] yuvipanda: ULS has tons of JS. [12:42:47] yuvipanda: you mean, any particular coders who could use JS review? marktraceur, Matmarex, Project Milkshake (i18n), & others - I can dig stuff up no prob [12:42:53] yuvipanda: try https://gerrit.wikimedia.org/r/#/c/21047/ and https://gerrit.wikimedia.org/r/#/c/20539/ [12:43:02] * yuvipanda goes over [12:43:35] siebrand: oh, and my 'final year project' will probably be porting Narayam to Native Android :) will keep you guys posted. [12:43:52] mlitn: OK. Maybe it's somehow fixed in your branch. On master it's still broken. What's your branch's name? [12:44:39] yuvipanda: I added you as reviewer for a couple of things. No obligation. [12:44:58] ^demon: is there "waiting for 2.5" tracking bug in our bz? [12:45:23] <^demon> Yeah, bug 39589 [12:45:26] thanks! [12:45:32] <^demon> you're welcome. [12:45:39] sumanah: Hi. Is there now way to search for commits with, ehhh, point-and-click? Only using these ":merged" queries? [12:45:40] aharoni: I can't think of any recent change related to that problem - we'll know soon enough though, changes should be getting deployed later today ;) [12:45:50] both branch prototype & current trunk look decent to me [12:46:01] mlitn: weird. [12:46:40] sumanah: i can click a project name, and then I'll see all the open commits. to see the merged commits I have to type "merged" manually, which kinda sucks. [12:46:52] aharoni: let me look in the settings. [12:47:50] 04(REOPENED) Unintuitive nagging for gerrit after review - 10https://bugzilla.wikimedia.org/35883 +comment (10Marcin Cieślak) [12:47:51] 03(mod) Upgrade Gerrit to 2.5 - 10https://bugzilla.wikimedia.org/39589 (10Marcin Cieślak) [12:48:31] The inverse works: Click on merged, then on a project, you'll get status:merged project:... query [12:49:22] aharoni: yeah, what Dereckson said. sadly there's nothing in the preferences that tells Gerrit "no seriously, when I search, I also by default want to search merged & abandoned changesets" [12:49:23] New review: Siebrand; "How will this look in IE6/7?" [mediawiki/extensions/InputBox] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21720 [12:49:42] aharoni: I recommend you add a feature request for Gerrit at code.google.com - tell me when you have & I'll add my star/vote [12:52:38] danielK_WMDE security isnt much of a concern on this box, as it is intranet only with ldap auth [12:53:13] i need a simple way for my users, a button for mht files which can be saved from office would be perfect, thats why i tried this extension [12:55:17] I've been searching for a while and I might be very stupid - but how do I add templates to my wiki? I'd like the databox one but I can't for the life of me figure out how to do it. explain to me like I'm five if you can :) [12:55:25] <^demon> Argh, where's hashar when I need him. [12:55:26] New patchset: Siebrand; "Follow-up Iacb3dbef: More consistency updates." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/21723 [12:55:29] * ^demon whacks jenkins with a 2x4 [12:55:39] Why are simple to write extension ideas so hard to think of? [12:55:43] Change merged: Siebrand; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/21723 [12:55:43] plop [12:55:53] New review: Siebrand; "Comments followed-up in I25b5d1b7." [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/21716 [12:55:55] <^demon> saper: Also, this: https://integration.mediawiki.org/ci/job/gerrit-war/3/ ;-) [12:56:31] yuvipanda: That would be awesome! [12:57:14] yuvipanda: do remain in touch with santhosh about that. We're going to port the current IME to jQuery in any case; not sure how much easier that will make things for you. [12:57:59] siebrand: I'll be writing native Android keyboards, so this will be an actual full blown port in Java that can not re-use code (but can re-use data!) [12:58:28] yuvipanda: Too bad that re-use of code will not be possible. [12:58:33] siebrand: will do! This entire thing was based off a conversation with srikanth :) [12:58:56] New patchset: Micha? ?azowik; "(bug 39130) Added (restore) links to old version and history pages." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21685 [12:59:15] siebrand: I can actually re-use all the code - but that'll make it unusably slow on less capable devices. Keyboards that are slow are super-irritating [12:59:29] k ;( [12:59:47] ;( indeed. [13:02:05] New review: Amire80; "It's enough to add the message to English. Translations to other languages are done in translatewiki..." [mediawiki/extensions/Narayam] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21603 [13:02:23] sumanah, oh ninetydegrees mother tongue is French :) [13:02:48] hi linkery [13:03:07] Dereckson: :) [13:03:28] linkery: so can you link to the mediawiki.org template-related pages you've already looked at? [13:03:49] also, can you point to your Special:Version page (if your wiki is public) so we can see whether you've already installed the right stuff? [13:03:59] heya.. since I upgraded to mediawiki 1.19 I have mostly random "the wiki requires you to have cookies enabled" errors when trying to log in. Some accounts work, some don't. Then the ones that don't work suddenly start working while others stop to work. Any ideas how to debug this? [13:05:32] sven^, maybe you have problems with you php session storage? [13:06:04] Platonides: maybe. And how do I debug that? ;) [13:07:03] sumanah: wiki is private, I've looked at http://www.mediawiki.org/wiki/Help:Templates but it's nto helping me much [13:07:20] am I supposed to add a page with the template? I'm so confused [13:07:30] New patchset: Jeroen De Dauw; "Fixed type hint docs" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21724 [13:07:41] all I want is to create a databox with stats in the right corner of the screen [13:07:46] linkery: if you look at your own Special:Version page, you can tell us what MediaWiki extensions you have installed. Examples: ParserFunctions, Cite [13:08:27] ok, I just found out my wiki doesn't let me log in via http Oo [13:08:42] none, sumanah [13:09:57] linkery: so, using templates often requires that you install the ParserFunctions extension. https://www.mediawiki.org/wiki/Help:Templates#Extensions mentions that. Have you ever installed an extension on your wiki before? [13:10:02] (I know this is confusing, my sympathies.) [13:10:24] it apperently is included in 1.18 and forward [13:11:02] "This extension is bundled with MediaWiki 1.18 and above. Steps 1 to 3 described below apply to previous versions of MediaWiki." [13:11:10] I have 1.19 [13:12:13] 03(NEW) CryptRand.php - error flooding log files. - 10https://bugzilla.wikimedia.org/39731 major; MediaWiki: User login; (andrzej.kowol) [13:12:56] sumanah: thanks for your help but I'm needed elsewhere for now. sorry for leaving shortly after asking a question but it's a emergency apperently! [13:13:10] bye! [13:13:14] !lists | linkery [13:13:14] linkery: mediawiki-l and wikitech-l are the primary mailing lists for MediaWiki-related issues. See https://www.mediawiki.org/wiki/Mailing_lists for details. [13:16:18] 03(FIXED) Monospace font setting overridden - 10https://bugzilla.wikimedia.org/39560 +comment (10Srikanth Logic) [13:18:44] New patchset: Jeroen De Dauw; "Added maintenance script for rebuilding the data and refactored the one for deleting a little" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21610 [13:23:00] 03(mod) Scrolling down languages changes selection of the area at the top - 10https://bugzilla.wikimedia.org/39285 +comment (10Siebrand) [13:24:34] 14(DUP) Scrolling down languages changes selection of the area at the top - 10https://bugzilla.wikimedia.org/39285 +comment (10Siebrand) [13:24:35] 03(mod) Scrolling in languages when one of the three areas is selected makes the selection jump - 10https://bugzilla.wikimedia.org/39224 +comment (10Siebrand) [13:25:46] 04(REOPENED) Monospace font setting overridden - 10https://bugzilla.wikimedia.org/39560 +comment (10Santhosh Thottingal) [13:28:35] New patchset: Matthias Mullie; "Refactor AFT logging" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/20908 [13:29:13] so apparently magic words in redirect target page name break the redirect functionality (test case: #REDIRECT [[Roadmap {{CURRENTYEAR}}]]) -- is this a known bug or should I file a new bug on BZ? [13:41:18] <^demon> I'm pretty sure it's known. [13:41:25] New patchset: IAlex; "Moved warning stuff into MWDebug class." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21408 [13:41:58] <^demon> I remember talking about it a long time ago. It's not so much a *bug* as "that's not how redirects are implemented" [13:42:01] New review: IAlex; "test fixes." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21408 [13:42:17] <^demon> Redirect parsing happens way higher (Article? Page? something like that), well before the parser is ever invoked. [13:42:31] 03(WONTFIX) Language names in less-relevant languages should have lower priority in autocomplete - 10https://bugzilla.wikimedia.org/39408 +comment (10Siebrand) [13:45:50] 03(mod) MediaWiki:Previewnote on 1.20wmf10 broken - 10https://bugzilla.wikimedia.org/39584 04CRIT->major (10Andreas Praefcke) [13:46:02] 03(mod) MediaWiki:Previewnote on 1.20wmf10 broken - 10https://bugzilla.wikimedia.org/39584 major->04CRIT (10Andreas Praefcke) [13:47:19] New patchset: Tpt; "(bug 37419) Rewriting of Index pages edit form in PHP" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/10741 [13:51:39] 03(NEW) Please provide documentation for LocalSettings.php file - 10https://bugzilla.wikimedia.org/39732 enhancement; MediaWiki extensions: WikidataRepo; (silke.meyer) [13:51:45] hi ashley [13:52:07] 03(mod) Cannot move ULS pop-up around - 10https://bugzilla.wikimedia.org/39414 summary; +comment (10Siebrand) [13:52:36] hi sumanah! how was your vacation? :-) [13:52:46] ashley: it was very very good [13:52:59] ashley: I actually blogged about its longterm effects in case you want a link [13:53:50] sumanah: yes please! [13:54:15] http://www.harihareswara.net/sumana/2012/08/19/0 [13:55:23] New patchset: Alex Monk; "Fix double parsing of "previewnote" message" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21730 [13:56:05] 03(mod) MediaWiki:Previewnote on 1.20wmf10 broken - 10https://bugzilla.wikimedia.org/39584 +comment (10Krenair) [13:59:38] New patchset: Nikerabbit; "Trying to fix language selection once more" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21731 [14:01:09] New patchset: Daniel Kinzler; "Avoid deprecation warnings in test cases." [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21732 [14:02:48] New patchset: Daniel Kinzler; "Replace usage of doEdit() with doEditContent()" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21733 [14:03:20] okay, so that didn't work out well [14:03:27] Platonides, vvv: There? [14:05:11] 03(mod) Cannot move ULS pop-up around - 10https://bugzilla.wikimedia.org/39414 (10Siebrand) [14:05:18] 03(mod) Recent languages in languages settings - 10https://bugzilla.wikimedia.org/39535 (10Srikanth Logic) [14:05:27] 03(mod) Display settings section should be selected by default - 10https://bugzilla.wikimedia.org/39529 (10Siebrand) [14:05:31] 03(mod) Narayam compatibility with ULS - 10https://bugzilla.wikimedia.org/39096 (10Srikanth Logic) [14:05:33] 03(mod) Clicking on region rapidly, multiple times, causes severe lag - 10https://bugzilla.wikimedia.org/39386 (10Siebrand) [14:05:37] 03(mod) Undo popup after changing language must position itself properly - 10https://bugzilla.wikimedia.org/39093 (10Siebrand) [14:05:47] 03(mod) Internationalize ULS - 10https://bugzilla.wikimedia.org/39231 (10Srikanth Logic) [14:06:04] sumanah: it's always good to be able to identify the "pain points" and do whatever is necessary to make things work better and adapt to change...I know that adapting to change can sometimes be very difficult (which probably explains why I do some things today just like how I did them like five years ago...or ten years ago...or...) [14:06:06] 03(mod) Clicking "Worldwide" after clicking some other area first doesn't show all languages - 10https://bugzilla.wikimedia.org/39223 (10Siebrand) [14:06:08] 03(mod) Scrolling in languages when one of the three areas is selected makes the selection jump - 10https://bugzilla.wikimedia.org/39224 (10Siebrand) [14:06:20] PHP Fatal error: require_once(): Failed opening required '/var/lib/jenkins/jobs_shared/InjectExtensions.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/lib/jenkins/jobs/MediaWiki-Tests-Dumps/workspace/LocalSettings.php on line 133 [14:06:24] gah!!! ---^ [14:06:27] 03(mod) Do not show font selection when there is no choice - 10https://bugzilla.wikimedia.org/39531 (10Siebrand) [14:06:31] 03(mod) UI language change preview in display settings - 10https://bugzilla.wikimedia.org/39684 (10Siebrand) [14:06:34] hashar: what's happening with jenkins? [14:06:42] 03(mod) Cancel button in settings should go to the previous context - 10https://bugzilla.wikimedia.org/39686 (10Srikanth Logic) [14:06:44] I broke it again :D [14:06:45] :-(( [14:07:03] DanielK_WMDE: work in progress sorry. I really need a copy on labs [14:07:06] just while i was trying to fix test cases ;) [14:07:46] ashley: yeah. Change costs. [14:07:46] Part of it is mere inertia, and part of it is the urge to authenticity [14:07:46] hashar: no problem, just make sure to re-trigger jenkins of the stuff that is currently failing [14:07:47] consciously choosing which changes actually matter to one's core values [14:08:23] so uh [14:08:31] Was the fail here an error? https://gerrit.wikimedia.org/r/#/c/21730/ [14:08:41] 13:56:27 [exec] Use of Revision::revText was deprecated in MediaWiki 1.17. [Called from RevisionStorageTest::testRevText in /var/lib/jenkins/jobs/MediaWiki-GIT-Fetching/workspace/tests/phpunit/includes/RevisionStorageTest.php at line 219] [14:09:01] Krenair: no, that's legit. [14:09:02] <^demon> We started failing on wfWarn() [14:09:30] Krenair: where are you seeing that? the test case for this function itself was fixed in master to ignore the warning [14:09:42] In https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Misc/4437/console [14:09:52] Krenair: rebase [14:10:01] ... [14:10:07] hm... [14:10:09] I'm trying to port a single bug fix [14:10:22] yea, so rebase the bug fix [14:10:37] Not everything [14:10:44] ^demon: thinking about it... that failure means that everything that is currently awaiting review needs to be rebased? [14:10:50] This is wmf/1.20wmf10 not master [14:11:01] hm... [14:11:16] Krenair: backport the fix? [14:11:49] 03(mod) Apply changes button should be active only if there are changes. - 10https://bugzilla.wikimedia.org/39685 +comment (10Siebrand) [14:12:43] New patchset: Tpt; "Small improvements in the UI of the page edition. Standardisation of file headers. Renaming of ProofreadPage_body.php to ProofreadPage.body.php (naming conventions)" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/21735 [14:12:59] ^demon: the thing that i find odd though is: the change that causes this problem, shouldn't it itself have failed? [14:13:05] i was actually relying on that [14:13:29] i.e. i was relying on the patch for stricter test failing until nothing fails with stricter tests [14:13:53] <^demon> This is the same sort of thing that could happen if someone introduced a failing change and you rebased. [14:14:01] <^demon> The test just needs fixing. [14:15:30] 03(NEW) Setlang should clear uselang - 10https://bugzilla.wikimedia.org/39733 normal; MediaWiki extensions: UniversalLanguageSelector; (srik.lak) [14:15:31] it's already fixed [14:15:40] 03(mod) Setlang should clear uselang - 10https://bugzilla.wikimedia.org/39733 (10Srikanth Logic) [14:16:34] Should I cherry-pick the fix as well? [14:16:57] Krenair: into wmf/1.20wmf10? i'd say yes [14:17:16] Okay, can I have a link to it then please? [14:17:47] have to dig it up, moment [14:17:51] nvm, found it... https://gerrit.wikimedia.org/r/#/c/20926/ [14:17:55] 03(mod) Setlang should clear uselang - 10https://bugzilla.wikimedia.org/39733 +comment (10Niklas Laxström) [14:19:11] Let's hope this works how I'm expecting it to... [14:20:26] Change merged: Siebrand; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21731 [14:20:26] Will submitting multiple commits put them in the same changeset? [14:22:16] New patchset: Jeroen De Dauw; "sites stuff [DNM]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21684 [14:23:16] New patchset: Alex Monk; "Hide deprecated warning for Revision::revText()." [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21736 [14:24:00] No, that didn't work anything like what I had hoped... [14:25:08] New patchset: Raimond Spekking; "Update optinonal message keys for Babel" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21737 [14:25:30] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21737 [14:25:50] New patchset: Daniel Kinzler; "EditPage cleanup - parser errors, etc" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20882 [14:26:44] siebrand, this change doesn't actually make the test fail [14:26:59] Someone changed something so that this change fails [14:27:31] Krenair: you'll need to merge the fixed testcase first. then rebase your patch. [14:27:33] There's a fix in master and I tried to also make it part of the change... But it ended up generating https://gerrit.wikimedia.org/r/#/c/21736/ instead [14:27:45] DanielK_WMDE: I think I fixed jenkins [14:27:50] need to retrigger jobs [14:27:55] ok, great! [14:28:21] Krenair: you can put both changes on the same feature branch, but the test-case-fix must come first. there's no way around the rebase [14:28:26] . [14:28:28] but then, the rebase should be trivial [14:28:53] hashar: any idea how long that takes? do you have to do it manually? [14:29:02] Change abandoned: Alex Monk; "(no reason)" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21736 [14:29:14] DanielK_WMDE: I am doing that manually using https://integration.mediawiki.org/ci/gerrit_manual_trigger/ [14:29:33] I have resubmitted two of your changes: 21732 and 21733 [14:29:38] Change abandoned: Alex Monk; "(no reason)" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21730 [14:29:48] I give up [14:29:48] 03(mod) MediaWiki:Previewnote on 1.20wmf10 broken - 10https://bugzilla.wikimedia.org/39584 +comment (10Krenair) [14:30:21] hashar: this one too, please: https://gerrit.wikimedia.org/r/#/c/20904/ [14:30:24] DanielK_WMDE: did Jenkins warn about deprecations ? [14:30:33] DanielK_WMDE: I have added $wgDeveloppementWarnings this morning [14:31:15] DanielK_WMDE: retriggered them all, now we need to wait for test to finish :) [14:31:53] hashar: yes, it did, but then I couldn't merge the change i made to fix that, because jenkins was broken :D [14:32:04] :))) [14:32:08] that's 21732 actually [14:32:34] New patchset: Matthias Mullie; "Bug 39356 - Article feedback page: Drop-down menus need to be better aligned with title bar" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21739 [14:32:47] ...which just passed! horay! [14:33:28] New review: Daniel Kinzler; "self-review in order to fix problems with test cases that make jenkins reject everything on this branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21732 [14:33:29] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21732 [14:34:07] * DanielK_WMDE waits for 21733 [14:34:19] 03(mod) Article feedback page: Drop-down menus need to be better aligned with title bar - 10https://bugzilla.wikimedia.org/39356 +comment (10Matthias Mullie) [14:35:23] hmpf :( [14:36:51] hashar: 21733 failed, but I don't understand why. I can't find any actual errors in jenkins output [14:36:57] which, i must say, is generally well hidden [14:37:29] thinking about it... 21733 will probably only pass after 21732 has been merged (i.e. now). but. i'd still like to see the error messages :) [14:38:10] checking [14:38:17] ohhh [14:38:20] New patchset: Daniel Kinzler; "EditPage cleanup - parser errors, etc" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20882 [14:38:39] well if 21733 is marked as depending upon 21732, it should work [14:38:49] no it isn't. [14:38:54] it's not a dependency as such [14:39:01] 21732 just fixed the test cases [14:39:08] so Jenkins applied 21733 on top of latest master [14:39:13] (which does not have 21732) [14:39:21] uh... latest *master*? [14:39:28] but that's the Wikidata branch [14:39:31] that can't work. [14:39:36] ohhh [14:39:38] sorry ;) [14:39:39] lol [14:41:14] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20904 [14:41:15] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20904 [14:41:15] DanielK_WMDE: well looks like something is screwed in [14:41:21] need to fix up my hack again [14:41:26] grr I hate ant [14:41:54] hashar: other stuff seems to work though [14:42:04] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20882 [14:42:05] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/20882 [14:42:13] 03(mod) AFT contributions entries are very ugly and confusing - 10https://bugzilla.wikimedia.org/38631 +comment (10Matthias Mullie) [14:43:18] New patchset: Daniel Kinzler; "Replace usage of doEdit() with doEditContent()" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21733 [14:44:37] 03(FIXED) The arrow on the "Edit this page" button points the wrong way in RTL environments - 10https://bugzilla.wikimedia.org/36918 +comment (10Matthias Mullie) [14:44:38] New patchset: Yaron Koren; "New version: 0.6.2" [mediawiki/extensions/ApprovedRevs] (master) - https://gerrit.wikimedia.org/r/21740 [14:45:47] Change merged: Yaron Koren; [mediawiki/extensions/ApprovedRevs] (master) - https://gerrit.wikimedia.org/r/21740 [14:45:48] New patchset: Jeroen De Dauw; "Implemented count" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/21741 [14:46:03] DanielK_WMDE: so the issue was caused by me deleting the extension directory :-( [14:46:29] well, i guess if you delete it, it goes missing :) [14:47:06] https://gerrit.wikimedia.org/r/21742 [14:47:52] :) [14:47:58] hashar: hm... what happened here? https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/4344/console [14:48:05] how is jenkins failing with a merge conflict? [14:48:19] i mean, how can that even be? [14:50:02] <^demon> It's very possible. If your change isn't rebased against master. [14:50:26] so, jenkins jirst tries to merge into latest? [14:50:39] it doesn't test the patch on top of the given base revision? [14:50:56] hm... makes sense I guess, but causes misleading messages, wrong line numbers, etc... [14:51:41] 03(NEW) Prevent page creation in repo? - 10https://bugzilla.wikimedia.org/39734 normal; MediaWiki extensions: WikidataRepo; (silke.meyer) [14:52:17] i hate it when i rebase only to realize that i forgot to pull the base branch first [14:53:47] New patchset: Daniel Kinzler; "Replace usage of doEdit() with doEditContent()" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21733 [14:56:51] DanielK_WMDE: sorry back. So yeah I have made Jenkins to apply the patchset to the very latest branch version [14:57:21] hashar: makes sense, but it would be useful if a merge conflict wouldn't look like "test failed" [14:57:32] is it possible to post a more meaningful comment to gerrit in that case? [14:58:25] I am not sure how to do that :( [15:00:54] 03(mod) Prevent page creation in repo? - 10https://bugzilla.wikimedia.org/39734 (10jeblad) [15:05:17] New review: Daniel Kinzler; "self-reviewing for merge into dev-branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21733 [15:05:17] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21733 [15:05:46] 03(mod) Shorten thumbnail name convention - 10https://bugzilla.wikimedia.org/39697 +comment (10Brion Vibber) [15:08:17] New patchset: Chughakshay16; "Minor fixes for the util classes" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/21743 [15:09:45] New review: Daniel Kinzler; "nice, thank you!" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21685 [15:09:46] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21685 [15:10:06] 03(mod) add a custom field "commit in gerrit" in bugzilla ui. - 10https://bugzilla.wikimedia.org/39399 +comment (10Andre Klapper) [15:10:41] New review: TheDJ; "spelling error in the commit msg, but good for me." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/21319 [15:10:56] 03(NEW) WLMMobile: HTML injection in HTML templating system - 10https://bugzilla.wikimedia.org/39735 normal; WikiLoves Monuments Mobile: General; (brion) [15:12:57] 03(mod) Add two new statuses to the workflow: patch released and patch committed. - 10https://bugzilla.wikimedia.org/39402 +comment (10Andre Klapper) [15:15:26] 03(mod) A single vote confirms a bug - 10https://bugzilla.wikimedia.org/39664 +comment (10Andre Klapper) [15:16:42] 03(mod) a lone "0" in a tag disappears - 10https://bugzilla.wikimedia.org/39643 +comment (10Derk-Jan Hartman) [15:17:32] New patchset: Matthias Mullie; "Bug 38591 - MediaWiki:Articlefeedbackv5-error-abuse prevents localisation" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21746 [15:18:44] New patchset: Chughakshay16; "Minor fixes for the util classes" [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/21743 [15:19:10] 03(mod) Cleanup bz email report output - 10https://bugzilla.wikimedia.org/29355 +comment (10Andre Klapper) [15:21:25] New review: Daniel Kinzler; "great to see someone working on this!" [mediawiki/extensions/BlameMaps] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17972 [15:23:01] New review: Daniel Kinzler; "oh, just to avoid confusion: you are the only owner of this extension, so I guess you are the one wh..." [mediawiki/extensions/BlameMaps] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17972 [15:24:54] 03(mod) Setlang should clear uselang - 10https://bugzilla.wikimedia.org/39733 +comment (10Siebrand) [15:26:44] 03(mod) Don't have URL as a advanced field on new reports - 10https://bugzilla.wikimedia.org/22199 +comment (10Andre Klapper) [15:27:35] 03(mod) a lone "0" in a tag disappears - 10https://bugzilla.wikimedia.org/39643 +comment (10Dereckson) [15:29:13] New review: Daniel Kinzler; "This change seems to contain several unrelated changes - cosmetic changes like whitespace cleanup, g..." [mediawiki/extensions/BlameMaps] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20667 [15:31:54] thanks for that review, DanielK_WMDE [15:34:45] sumanah: well, can't say i understood much of the code. and there's only a little mediawiki glue yet. just tried to give some general advise [15:34:53] i'm really happy to see this happening, though! [15:34:57] yay, blame maps! [15:35:00] yes! [15:35:06] (you should tell the developer that, too!) [15:35:13] (yay enthusiasm!) [15:35:26] i did! [15:35:35] gerrit just hides all but the last comment [15:36:01] ah, and it was the other change, the initial commit [15:36:18] [17:21] New review: Daniel Kinzler; "great to see someone working on this!" [mediawiki/extensions/BlameMaps] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17972 [15:36:27] I was just ... yeah [15:36:34] :) [15:36:53] 03(NEW) Resize image before saving the upload if larger than max dimension - 10https://bugzilla.wikimedia.org/39736 enhancement; MediaWiki: File management; (subfader) [15:37:43] DanielK_WMDE: you can see why I requested that you review it -- no one is 100% expert enough to review it, but you're close [15:37:45] New review: Siebrand; "I think this localises the link target, too, while it shouldn't. Is that correct? I.e. the text shou..." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21746 [15:38:16] sumanah: a real review of this would take a lot of time - and is best done when this has progressed a bit more, i think [15:38:25] but i definitly want to keep an eye on it [15:38:34] is there a way in gerrit to watch projects? i couldn't find any [15:38:55] hashar: hm... if jenkins tests against latest head now, doesn't that when a change is merged, all open changes on that branch have to be re-tested? [15:39:13] New patchset: Hashar; "Testing Jenkins" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21747 [15:39:32] thedj: Morning! (afternoon?) How are you today? [15:39:46] DanielK_WMDE: ideally yeah :-D [15:40:55] ^demon: btw... gerrit confuses me with its usage of "submit". can we replace "submit" by "merge" in the UI? [15:41:10] or at least "submit for merging" [15:42:35] gah! merging latest master into the wikidata branch generated a gazillion conflicts :/ [15:43:16] <^demon> It's not always a merge, if you're doing a cherry pick or fast-forward. [15:43:23] <^demon> (which some repos do) [15:43:35] <^demon> Also: can't change it easily without building our on .war file [15:45:18] http://finance.yahoo.com/echarts?s=USDEUR%3DX+Interactive#symbol=USDEUR=X;range=3m [15:45:19] bah [15:45:29] dollars is falling [15:48:22] marktraceur: hi :D [15:49:09] Oooh, I should look at the bug list and see how we're doing [15:49:36] OK, still pretty bad [15:49:57] But the WLM bug is getting better! [15:50:02] marktraceur: the UW list? [15:50:05] !b 37144 [15:50:05] https://bugzilla.wikimedia.org/show_bug.cgi?id=37144 [15:50:08] sumanah: Yep [15:50:15] wm-bot: *hug* I missed you. [15:50:15] Hi marktraceur, there is some error, I am a stupid bot and I am not intelligent enough to hold a conversation with you :-) [15:50:31] New patchset: MaxSem; "New hook ApiMain::onException" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21748 [15:50:32] It's OK, wm-bot. It's OK. I accept you. [15:50:51] marktraceur: is Ankur (drecodeam) up to anything recently, or has he disappeared? [15:51:05] Euuuu, dunno [15:51:38] (sorry, been thinking in french, that's what they say instead of 'um') [15:51:46] no prob [15:51:53] back in a bit [15:52:40] 03(mod) JavaScript not labeled as free - 10https://bugzilla.wikimedia.org/36866 +comment (10Benjamin Mako Hill) [15:52:40] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21724 [15:57:07] New patchset: Matthias Mullie; "Bug 38591 - MediaWiki:Articlefeedbackv5-error-abuse prevents localisation" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21746 [15:59:03] 03(FIXED) Delay in loading incomplete uploads - 10https://bugzilla.wikimedia.org/39691 (10Jon) [15:59:31] New review: Matthias Mullie; "Indeed, I had overlooked that part and localized all of it. Moved the error message parsing to PHP n..." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21746 [16:00:48] New patchset: John Erling Blad; "(Bug 37685) Initial commit for checking edit conflicts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [16:02:08] 03(NEW) git clone fail with an RPC error - 10https://bugzilla.wikimedia.org/39737 normal; Wikimedia: Git/Gerrit; (hashar) [16:04:34] 03(mod) git clone fail with an RPC error - 10https://bugzilla.wikimedia.org/39737 +comment (10Antoine "hashar" Musso) [16:05:11] 03(NEW) PHP Notice for undefined variables - 10https://bugzilla.wikimedia.org/39738 normal; MediaWiki extensions: SemanticWatchlist; (nischayn22) [16:06:35] 03(mod) Overwrite of the copyright owner in campaigns has no effect - 10https://bugzilla.wikimedia.org/30762 -patch-in-gerrit ; +comment (10Mark Holmquist) [16:07:07] 03(mod) git clone fail with an RPC error - 10https://bugzilla.wikimedia.org/39737 +comment (10Antoine "hashar" Musso) [16:08:20] New review: Nasirkhan; "removed the translations" [mediawiki/extensions/Narayam] (master) C: 0; - https://gerrit.wikimedia.org/r/21603 [16:08:22] 03(FIXED) WLMMobile: new photos are saved to cache space instead of permanent storage - 10https://bugzilla.wikimedia.org/38290 (10Jon) [16:08:29] New patchset: Nasirkhan; "removed the translations" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/21750 [16:09:29] New patchset: Raimond Spekking; "Register new extension TwoFactorAuthentication" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21751 [16:09:54] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21751 [16:13:52] sumanah: We've been assuming that drecodeam is done, kaldari's been polishing his commits up a bit [16:13:57] 03(FIXED) Tracking bug for getting Monuments Database API deployed somewhere on the WMF cluster - 10https://bugzilla.wikimedia.org/37568 (10Max Semenik) [16:14:04] marktraceur: :( [16:14:12] marktraceur: has Ryan tried pinging him? [16:15:01] sumanah: Maybe, maybe not....my understanding is that we want to get things merged for WLM, and Flickr-integration would be a good thing to have [16:15:16] So pinging and waiting for a response may not be his first instinct [16:15:26] New patchset: Siebrand; "Prevent notices. Check is there is a fallback language." [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/21752 [16:15:41] New review: MarkTraceur; "I initially had some concerns, but upon further thought, realized that a catch-all is a good plan. +..." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/16041 [16:16:01] marktraceur: well, sure, waiting would be bad, but pinging and figuring out whether he's Yet Another Abandoner or whether he doesn't realize how valuable he is - that would be nice [16:16:07] and it'll mean more coming from his mentor than from me [16:16:14] *nod* or from me [16:16:25] I'll poke kaldari when he gets in [16:16:26] well, it'd mean something from you, because you're an engineer working on his code [16:16:38] * marktraceur skimmed the surface [16:16:40] But point taken [16:16:42] still. [16:16:43] yeah [16:17:30] yuvipanda: How goes? I saw you volunteered for review this morning :) [16:17:50] New review: Siebrand; "Please amend any unmerged previous commits." [mediawiki/extensions/Narayam] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/21750 [16:18:23] New review: Siebrand; "See https://www.mediawiki.org/wiki/Git/Workflow#Improving_a_change for workflow." [mediawiki/extensions/Narayam] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/21750 [16:21:10] New review: MarkTraceur; "The code looks OK, but I also have no idea about what this extension does or what this patch is supp..." [mediawiki/extensions/DynamicSidebar] (master) C: 1; - https://gerrit.wikimedia.org/r/16807 [16:21:58] New review: MarkTraceur; "Oh, we all had discussions about this and decided that list comprehensions weren't any kind of probl..." [mediawiki/extensions/ConfirmEdit] (master) C: 1; - https://gerrit.wikimedia.org/r/16872 [16:22:30] New review: MarkTraceur; "Great!" [mediawiki/extensions/GraphViz] (master) C: 1; - https://gerrit.wikimedia.org/r/17394 [16:22:34] New review: Siebrand; "Please amend this in I6cc2b6cd." [mediawiki/extensions/Narayam] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/21704 [16:23:27] 03(mod) [Regression] jsMessage should not auto-hide and be narrow (allow to be used as a dialog for user input) - 10https://bugzilla.wikimedia.org/39699 +comment (10Krinkle) [16:24:03] New patchset: Mwalker; "Removing Amazon check signature requirement." [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/21691 [16:24:25] New review: MarkTraceur; "Seems adequate to me, though I wish we could work on the code conventions. Perhaps ping me to either..." [mediawiki/extensions/LiquidThreads] (master) C: 1; - https://gerrit.wikimedia.org/r/17777 [16:25:10] thedj: Woo more case: fallthrough! (gerrit 21698 about the badfilename error) [16:25:19] Change merged: Kaldari; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/16041 [16:25:49] 03(mod) [TestSwarm] 404 Not Found: ./images/hpwos.sm.png/ - 10https://bugzilla.wikimedia.org/38554 +comment (10Krinkle) [16:27:27] New review: MarkTraceur; "I have a minor issue, but otherwise am happy with the patch." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21698 [16:29:57] marktraceur: yes, and I plan on digging into ULS later tonight :) [16:30:10] :) [16:30:14] i18n js stuff, mostly I think [16:30:25] 03(FIXED) [Regression] MediaWiki:Previewnote broken - 10https://bugzilla.wikimedia.org/39584 summary; +comment (10Krinkle) [16:30:39] I did review one of the other commits sumanah pointed me to, and the other one was waiting on API design input from Krinkle. [16:30:58] New review: MarkTraceur; "Good stuff! Move 'em up, move 'em out." [mediawiki/extensions/UploadWizard] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21678 [16:30:58] Change merged: MarkTraceur; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21678 [16:31:17] hmm, no reedy [16:31:26] anyone know when action=tokens was introduced? [16:32:57] yuvipanda: 9ec8e3525bd0b4cf47fd1f59b747a62ef602cd8b 2012-03-28 by kaldari [16:33:06] 03(mod) Make enhanced recentchanges the default - 10https://bugzilla.wikimedia.org/35785 +comment (10James Forrester) [16:33:18] wah that's pretty old! [16:33:30] 5 months, I guess [16:33:30] and no update on https://www.mediawiki.org/wiki/API:Edit [16:33:35] I'll go ahead and do that tonight [16:33:40] if nobody else gets to it before I do [16:33:46] New review: TheDJ; "Was thinking of doing that in a followup." [mediawiki/extensions/UploadWizard] (master) C: 0; - https://gerrit.wikimedia.org/r/21698 [16:33:46] I *hated* the dance with query for getting tokens [16:34:43] thedj: All right, well, let me make sure it works [16:35:05] we have an action=tokens ? [16:35:12] thedj: exactly my reaction! [16:35:29] someone should tell the twinkle devs :D [16:35:33] we've done so since March apparently [16:35:35] 03(mod) [Regression] MediaWiki:Previewnote broken - 10https://bugzilla.wikimedia.org/39584 +comment (10Krenair) [16:36:04] Our API doesn't get as much marketing / publicity as it should [16:36:07] yeah [16:36:11] New review: MarkTraceur; "Works for me, thanks for the patch!" [mediawiki/extensions/UploadWizard] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21698 [16:36:14] Change merged: MarkTraceur; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21698 [16:36:24] yuvipanda: blobaugh was planning on doing a big API marketing and doc cleanup/prettifying push [16:36:29] and then a zillion things came up and he did not [16:36:33] heh [16:36:50] that's how documentation usually goes :D [16:36:59] sumanah: I'm building a bunch of nice API clients in different languages to replace current mess of bitrotten code [16:37:04] python-mwapi is done, am currently doing java-mwapi and that's how I found it [16:37:11] yuvipanda: do you remember how the API docs got a bunch better around January 2012? [16:37:15] 03(FIXED) button row with 'retry' failed sometimes not cleared - 10https://bugzilla.wikimedia.org/39702 +comment (10Mark Holmquist) [16:37:18] hi sumanah [16:37:26] i'll cleanup API:Edit later today, and see what else I can help with later [16:37:26] that was because I found a volunteer specifically to do that in time for the Jan hackathon [16:37:29] thanks yuvipanda [16:37:30] hi Nikerabbit [16:37:33] sumanah: I do! [16:37:43] sumanah: Is there a task-list of 'things missing in API docs' somewhere? [16:37:45] New review: John Erling Blad; "Only some way off warning messages.. seems like phpunit complains about methods from the base class.." [mediawiki/extensions/Diff] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21741 [16:37:45] Change merged: John Erling Blad; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/21741 [16:38:06] APISandbox helped a *lot* in discoverability [16:38:07] I wouldn't have found tokens if not for that [16:38:17] yuvipanda: yeah, thank you MaxSem for that! [16:38:36] yuvipanda: lemme fwd some of blobaugh's work publicly - should have done that a while ago, it got buried under other things [16:38:40] 03(mod) A bad filename should be changed silently instead of stopping the upload with "unknown-warning" - 10https://bugzilla.wikimedia.org/39220 +comment (10Mark Holmquist) [16:38:45] sumanah: that'll be nice! [16:44:03] Hi, how do I enable the extension that are now shipped with the release from 1.19? [16:44:22] hi tyteen4a03 [16:44:42] hi [16:45:04] tyteen4a03: are you familiar with the LocalSettings.php file? [16:45:41] New review: GWicke; "The share, lib etc dirs are now created in build/." [mediawiki/extensions/Parsoid] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21693 [16:46:18] New review: MarkTraceur; "I'm happy with the state of things, a later iteration might want to use the new notification system,..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/6143 [16:47:21] 03(mod) JavaScript not labeled as free - 10https://bugzilla.wikimedia.org/36866 +comment (10Krinkle) [16:52:00] 03(mod) Search broken when location present - 10https://bugzilla.wikimedia.org/39715 +comment (10Jon) [16:52:24] hi DeltaQuad, how's it going? [16:53:35] sumanah: Yes, I included these files before I upgraded to 1.19 [16:53:43] pretty good, not that i'm about to savagely beat my internet connection :P [16:53:47] should I include them again? [16:54:09] tyteen4a03: have you edited LocalSettings.php ever? [16:54:22] I have :) [16:54:36] local settings makes life easy [16:54:48] sumanah: Yes... I told you I included the plugin files in it before I upgraded [16:55:08] tyteen4a03: sorry, I misunderstood "included" there [16:55:23] DeltaQuad: btw how is life in bot land? [16:55:35] DeltaQuad: and did you see https://www.mediawiki.org/wiki/Admin_tools_development ? [16:56:24] sumanah: I updated API:Edit. Will wait for ben's notes and spend some time on it again [16:56:35] 03(mod) Make enhanced recentchanges the default - 10https://bugzilla.wikimedia.org/35785 +comment (10MZMcBride) [16:56:46] * PandaInABus hopes someone is watching the api pages and kicks me if I made a mistake, but I did verify [16:57:07] tyteen4a03: you might need to run update.php https://www.mediawiki.org/wiki/Manual:Update.php ? sorry, I'm reaching the limits of my knowledge. Did you have other extensions already enabled? [16:57:35] hey there Ftrott, got a moment? [16:57:55] sumanah: first chance in a while to get the bots fixed again, and i'm hating IRC RC, because there are millions of log types that I never accounted for, but working to get them up and going with solid code. and I haven't seen that page no [16:57:55] hi sumanah, sure [16:58:16] sumanah: yes, and I've run that once [16:58:22] Ftrott: ashley is working on that stuff, as are csteipp and others [16:58:31] 03(mod) JavaScript not labeled as free - 10https://bugzilla.wikimedia.org/36866 +javascript; +comment (10Mark Holmquist) [16:58:38] * sumanah hopes Amgine or someone else knowledgable will help tyteen4a03  [16:58:42] hi! [16:59:13] I mean, DeltaQuad - ashley, csteipp and others are working on those admin tools [16:59:30] tyteen4a03: What'd you need help with? [16:59:36] Ftrott: have you tried Gerrit? [17:00:01] sumanah: Yes. Supplied some patches [17:00:06] hmmm, bus abount to stop [17:00:22] Ftrott: huh, I couldn't find them - what is your username there? [17:00:23] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21553 [17:00:28] Lcawte: just upgraded to 1.19 but is not sure how to enable the extension that is shipped with the release [17:01:04] What extension are you thinking about in particular, theres a few in the tarball if I remember correctly [17:01:08] Ftrott: wanted to check if you have questions, concerns, wishes, outstanding review requests, interest in reviewing .... [17:01:15] we could totally use some of those tools [17:01:20] :) [17:01:46] also, DeltaQuad, where are you storing your bot code? is it at gerrit.wikimedia.org yet? [17:01:51] yuvipanda: "API design input from Krinkle", what's up? [17:01:52] Lcawte: all of them [17:02:06] Lcawte: I'm not sure if I still need to require_once() them in the LocalSettings.php [17:02:09] sumanah: No problems here. Well apart from that I still find git a bit overcomplicated. [17:02:12] Change merged: Bsitu; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/20899 [17:02:14] tyteen4a03: Yes, you do :) [17:02:22] Lcawte: I see, thanks [17:02:24] my code is running on TS, stored at github. Gerrit confuses the crap out of me [17:02:54] sumanah: username is Foxtrott, btw [17:02:56] (well so does most of labs, but one step at a time) [17:03:24] DeltaQuad: What are you working on? Perhaps the CVN can help out, they/we/I work a lot on the RC parsing bots for IRC they use (#cvn-commons, #cvn-wp-nl etc.) [17:04:14] Ftrott: Maybe not related, but your name is an awesome comic. [17:04:19] the RC feed (irc.wikimedia.org) is pretty bad but it is kept that way for compatibility, there are already plans for a better push feed system with JSON and proper sockets. For now either parse the irc feed or poll the api (format=json&action=recentchanges) [17:04:28] Krinkle: RC stalking, relaying to channels the RC messages from irc.wikimedia.org to here, but based on a certain ruleset and in color [17:04:38] DeltaQuad: https://commons.wikimedia.org/wiki/Category:Hackathon_Berlin_2012 now has some of the videos from the Berlin hackathon [17:04:43] marktraceur: Didn't know. Now I have to look it up :) [17:04:48] DeltaQuad: hasn't that been done dozens of times before? [17:04:51] New patchset: Subramanya Sastry; "WORK-IN-PROGRESS: First pass RT-ing templates." [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21754 [17:05:13] Ftrott: hope you don't mind, I requested a code review from you for one of the codebases you've been contributing to [17:05:21] sumanah: good :) that and wikimania vids I still have to watch :) [17:05:29] Ftrott: Allow me: http://en.wikipedia.org/wiki/FoxTrot_%28comic_strip%29 [17:05:42] sumanah: No problem, will have a looö [17:05:46] *look [17:06:18] Krinkle: yes, but other bots don't have a channel ops helper, and more that's packed into that thing. [17:06:19] Ftrott: if you go to "settings" you can also "watch" particular repositories so you get alerted on your dashboard of new changesets [17:06:41] DeltaQuad: what language is the bot written in, link to src code? [17:06:46] DeltaQuad: it'd be nice if you emailed bots-l with a link to your github repo [17:06:56] sumanah: sounds good, will try [17:07:04] DeltaQuad: and the wiki page about your bot-in-progress [17:07:17] that way I can forward it to other people who want a little project to help out on :) [17:08:22] New review: John Erling Blad; "This produced a lot of errors when I run the tests, but I really can't see a reason for this..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21709 [17:09:00] Ftrott: I see you [17:09:04] Krinkle: Python, though it's still a mess, quite buggy. I haven't had a chance to go from scratch and i don't completely understand the IRC connection code. https://github.com/dqwiki/lisabot [17:09:11] Ftrott: er, I mean, I see you do some frontend stuff [17:09:23] would you mind if I asked you to do some small JS/CSS reviews for core or other extensions as well? [17:09:26] sumanah: email and links? I'm not subscribed to bots-l either [17:09:35] DeltaQuad: https://lists.wikimedia.org/mailman/listinfo/wikibots-l [17:09:52] sumanah: No problem [17:09:53] DeltaQuad: it's a little quiet :/ [17:10:02] sumanah: this is not a wikibot (it doesn't interact with the mediawiki software itself to do edits or something) [17:10:05] thanks Ftrott [17:10:07] (I think) [17:10:27] I do have other bots that work with mediawiki software [17:10:33] but this one is just IRC based [17:10:56] brb [17:11:07] so, it's a bot that's secondarily or tertiarily related to MediaWiki, but it's still a Wikimedia-specific bot :) [17:11:10] * sumanah is inclusive [17:11:17] DeltaQuad: What are you using to do the irc connection itself? [17:11:40] marktraceur: there can be 4 results... [17:12:02] sumanah: its a bot that connects to irc to display information about edits and helps with channel operation. it doesn't have a user account on the wiki. But yeah, inclusive is good :) [17:12:02] marktraceur: apparently, there is also 'Queued' [17:12:39] 03(mod) On deletion page, the 'Edit deletion reasons' link is misleading. - 10https://bugzilla.wikimedia.org/39696 (10jidanni) [17:12:42] hey there multichill - how's it going? [17:12:45] thedj: Context? [17:12:53] api uploads [17:12:55] wtf [17:13:00] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21408 [17:13:02] does jsfiddle.net really not work in IE? [17:13:05] Oh [17:13:16] thedj: So Success, Warning, Error, Queued. [17:13:19] it's for async... /me never tested that. [17:13:25] marktraceur: exactly. [17:13:33] btw Nikerabbit you said hi - just being friendly, or did you want to inform/query me re anything? [17:13:50] sumanah: Bit busy, feel like I'm standing in an email firehose. Just a couple of days for launch of Wiki Loves Monuments so the pre-launch stress is kicking in :P [17:14:04] Krinkle: not sure I understand what your asking, but I have to step out for a bit, will ping when I'm back around [17:14:11] multichill: Hee! and it looks like we have 3+ apps/applications to help people upload [17:14:15] DQ|brb: ok, I'll be here. Got some tips for your [17:14:17] bot [17:14:17] J'aime ca. thedj, we don't need to worry about that gotcha, do we? [17:14:24] multichill: Commonist, Up!, Platonides's prototype, the Android app, and another? [17:14:37] 123point [17:15:08] marktraceur: i don't think so. but not 100% sure [17:15:28] sumanah: And don't forget the UploadWizard [17:15:35] Well, we'll keep an eye out. I don't even know if UW deals with async. [17:15:43] multichill: Been watching the torrent of bugfixes? :) [17:16:06] This weekend I had 40 bugzilla emails ;-) [17:16:38] multichill: That can only be an awesome sign! :) [17:16:56] this weekend had the highest gerrit traffic ever I think. [17:17:01] We did a bit of a sprint to add missing sources [17:17:05] https://bugzilla.wikimedia.org/show_bug.cgi?id=37144 is starting to shift towards "resolved" at least [17:18:34] marktraceur: Did you see https://bugzilla.wikimedia.org/showdependencytree.cgi?id=38648&hide_resolved=0 ? :-D [17:18:56] thedj: I'd point you at http://gerrit-stats.wmflabs.org/ but the analytics team appears to have fallen prey to the labs upgrades last night [17:19:24] Someone should probably ping them [17:19:55] marktraceur: is David not in the SF office? [17:20:17] sumanah: Not immediately near me, I guess I could walk about [17:20:19] New review: John Erling Blad; "If a rebase works out this should be in..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21585 [17:20:19] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21585 [17:20:31] * sumanah joins #wikimedia-analytics [17:20:37] New patchset: Jeroen De Dauw; "sites stuff [DNM]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21684 [17:20:39] sumanah: And how are you these days? [17:21:46] New patchset: MaxSem; "r887-905" [wikimedia/wlm-api] (master) - https://gerrit.wikimedia.org/r/21755 [17:21:49] multichill: I'm pretty good! had a nice long offline vacation, am reading an interesting book about software development, and we're experiencing a welcome uptick in volunteer contributions of code & code review [17:22:18] Good to hear! [17:22:34] Change merged: MaxSem; [wikimedia/wlm-api] (master) - https://gerrit.wikimedia.org/r/21755 [17:22:45] multichill: 38648 is pretty awesome. And I had never seen that view before..../me tries it for bug 2007 [17:23:39] I was going insane with all the different places with problems so I decided to just put everything in bugzilla [17:24:09] multichill: of 123point, Commonist, Up!, UploadWizard, the WLM Android app, Platonides's prototype, and any other apps/methods of uploading, which should we be encouraging people to test and/or use? [17:24:50] right now is a reasonable time to do last-minute testing & publicity to our technical community.... [17:25:02] you know, we have 3 more days to fix things :) [17:25:10] I really like the direct upload links in the lists, see for example https://en.wikipedia.org/wiki/National_Register_of_Historic_Places_listings_in_Allegany_County,_New_York [17:25:21] New review: John Erling Blad; "Works after a lot of pull and a rebase" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21709 [17:25:21] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21709 [17:25:33] That will prefill everything. The mobile app really needs the testing right now [17:25:38] oh that is nice! the direct UPLOAD A PHOTO OF THIS buttons :) [17:25:49] New review: Siebrand; "One thing missing: Messages that are empty by default, should be added to the array with ignored mes..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21598 [17:25:54] multichill: specifically you mean https://www.mediawiki.org/wiki/Wiki_Loves_Monuments_mobile_application right? [17:26:33] multichill: is there a test plan somewhere? I could point people to that [17:26:56] 03(mod) Map view/list view and complete/incomplete toggles are not obvious - 10https://bugzilla.wikimedia.org/39718 +comment (10Arthur Richards) [17:27:11] sumanah: Mobile people hang out in #wikimedia-mobile [17:27:29] 03(mod) Map view/list view and complete/incomplete toggles are not obvious - 10https://bugzilla.wikimedia.org/39718 +comment (10Arthur Richards) [17:27:40] New review: Aaron Schulz; "I commented on that thread, so I am aware of it already." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21582 [17:29:14] matanya: I'm sorry I haven't uploaded any photos to help you yet :/ had a houseguest this past weekend. [17:29:41] it's ok, got a prolonged until sept 2nd [17:29:52] sumanah: The test plan is "Go out and play" AFAIK [17:29:54] oh good :) [17:29:56] Thanks for thinking about it anyway [17:30:20] Would appreciate it if you could try it in your area ;-) [17:30:53] If I had an Android device, I would try it. [17:30:59] I have one [17:31:03] need my help? [17:31:22] Maarten, of course that's a good *start* but it gets better results for edge-case-finding to ask people to test specific areas of functionality, in my experience [17:31:45] 03(NEW) Cannot search with chinese characters - 10https://bugzilla.wikimedia.org/39739 normal; Wikipedia App: Search; (jrobson) [17:32:28] chrismcmahon has helped me understand "test charters" as a good middle ground here, between ultra-specced test plans and mega-vague "just use it" [17:32:41] New review: MarkTraceur; "Tested, does what it says it should. However, see Erik's comment on bug 39553 for some information a..." [mediawiki/extensions/UploadWizard] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/21404 [17:32:52] True, that's up to the mobile team. I did some backend stuff [17:32:58] BTW, sumanah mind a very short pm? [17:33:00] sure [17:33:05] go ahead matanya [17:33:46] multichill: fair :) anyway, thanks for your work on this [17:35:17] multichill: a few months after "National Novel Writing Month" there's a "National Novel Editing Month" -- is there some kind of editing fest after WLM to get people to incorporate those photos into articles? [17:37:07] 03(mod) Confirm uploads on incomplete uploads page - 10https://bugzilla.wikimedia.org/39693 +comment (10Jon) [17:37:35] New patchset: Bsitu; "Adding logic to check if revision is null" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/21756 [17:37:59] sumanah: https://commons.wikimedia.org/wiki/Commons:Monuments_database/Unused_images/Statistics tends to get more activity in September [17:38:06] nod [17:38:30] New review: John Erling Blad; "There were 6 errors (Showing only one of the errors):" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/21599 [17:40:52] sumanah: was looking elsewhere, one sec... [17:40:56] 03(NEW) Opera mobile clicking sub headings jumps to top - 10https://bugzilla.wikimedia.org/39740 normal; MediaWiki extensions: MobileFrontend; (jrobson) [17:41:35] 03(FIXED) Serbia campaigns possible encoding issue - 10https://bugzilla.wikimedia.org/39719 +comment (10Max Semenik) [17:42:08] New review: John Erling Blad; "Rebase" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21610 [17:42:17] New patchset: Bsitu; "Adding logic to check if revision is null" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/21756 [17:43:07] New review: Michael Shavlovsky; "Nikerabbit and Daniel Kinzler, thanks for review!" [mediawiki/extensions/BlameMaps] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17972 [17:43:16] sumanah: http://en.wikipedia.org/wiki/Session-based_testing is a good overview. Also http://en.wikipedia.org/wiki/Software_testing_controversies has some relevant information. [17:43:36] New review: John Erling Blad; "MUahahahahaaa..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21610 [17:43:56] Nikerabbit: Thank you for the wikitech-l post! [17:44:14] Nikerabbit: I don't understand
either. You posted exactly what I was thinking. [17:45:24] Brooke: I'm as confused as you are then [17:46:05] Nikerabbit / Brooke: Also, there's something on the docs page like 'use this' -- isn't 'like' an error? [17:46:35] marktraceur: that's valid in html5 I think [17:46:50] I guess I'm too indoctrinated in XHTML :/ [17:47:11]
is just stupid. [17:47:16] AaronSchulz: thanks for the merge [17:47:18] Not sure about unquoted attributes. [17:47:31] Brooke: No, just valueless ones [17:47:49] New review: John Erling Blad; "PHP Fatal error: Class 'Wikibase\Sites' not found in /home/john/Workspace/Wikibase/lib/includes/Sit..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21684 [17:47:57] Then as the rabbit says, I suppose. Probably valid in HTML5. [17:48:15] * chrismcmahon would like to create a community update-the-software-testing-pages-on-Wikipedia event someday, what exists now is just not adequate [17:48:22] Brooke: In XHTML it should be 'here' [17:48:33] Right. [17:48:37] Change merged: Kaldari; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/21756 [17:48:43] New review: John Erling Blad; "Could be something else that triggers this, if anybody else gets other results feel free!" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21684 [17:48:45] I think we should only ever encourage sane-looking HTML. [17:49:00] Regardless of what's actually allowed by the current or future specs. [17:49:11] 03(mod) Admin levels empty due to no campaign information (e.g. license) - 10https://bugzilla.wikimedia.org/39568 +comment (10Jon) [17:49:19] Brooke: Meaning "none of this re-typing the attribute name in the value" or "none of this valueless attribute crap" [17:49:31] The latter. [17:49:51] New review: John Erling Blad; "Marked wrong.." [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/21684 [17:49:58] is sane. is not. And most of the time is not. [17:50:03] * marktraceur is happy that he's the "sane" one but sad that this means potentially more unnecessary chatting on the subject [17:50:13] Heh. [17:51:32] New patchset: Kaldari; "Addressing problems with jquery.badge mentioned at I0f5e7541" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20224 [17:51:47] Change merged: Michael Shavlovsky; [mediawiki/extensions/BlameMaps] (master) - https://gerrit.wikimedia.org/r/17972 [17:54:54] Change merged: Michael Shavlovsky; [mediawiki/extensions/BlameMaps] (master) - https://gerrit.wikimedia.org/r/20667 [17:57:06] TrevorParscal: Sorry, I wasn't super-clear in that mail. I meant not-for-classes, as you did when suggesting .attr [17:57:32] no worries man [17:57:36] just wanted to help clarify [17:57:49] prop is useful for sure [17:58:30] TrevorParscal: http://javascript.info/tutorial/attributes-and-custom-properties <-- we link to this in our docs, if you haven't read it [17:59:06] Nikerabbit: +1 on your post by the way [17:59:26] New patchset: Nasirkhan; "merging updates" [mediawiki/extensions/Narayam] (master) - https://gerrit.wikimedia.org/r/21757 [17:59:57] New patchset: Nikerabbit; "Fixed logfilter hopefully" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21758 [18:00:10] marktraceur: you referring to the bio-hazard symbol section? lol [18:00:27] TrevorParscal: thanks [18:00:39] Something like that [18:00:50] sumanah: sorry, I was just saying hi [18:01:06] 03(mod) On deletion page, the 'Edit deletion reasons' link is misleading. - 10https://bugzilla.wikimedia.org/39696 normal->15enhancement; +comment (10Dereckson) [18:01:16] np :) [18:01:17] TrevorParscal: Krinkle has admonished me several times for using .attr( 'checked', 'checked' ), so I assume he can explain it better than I can [18:01:25] nice use of "admonish" [18:01:44] lol [18:02:09] yeah, that's a good one [18:02:13] I was just going to say, I know that link, I put it in the docs [18:02:20] it behooves me to abrogate your supererogatory magnaminity, marktraceur [18:02:21] (attrs and props) [18:02:33] another nice one is maxLength (IE recognizes) and maxlength (IE doesn't recognize) [18:03:03] Krinkle: we need you to lay down the law man [18:03:14] New review: Jeroen De Dauw; "This is a bug in core, already fixed by https://gerrit.wikimedia.org/r/#/c/21351/" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21599 [18:03:21] :) [18:03:53] attributes are for setting up the element when the page is parsed (e.g. when writing html syntax in html/php or passing to .innerHTML). When interacting with a Element node object, one should almost always use .prop(). I would even go as far as that you can remove .attr() from jQuery. [18:03:57] sumanah: "admonish" never struck me as an uncommon word...interesting revelation, learn something new every day [18:04:05] but there's probably some remote edge case where you need .attr() [18:04:20] marktraceur: I bet if you look it up in a corpus it would be way down in the ten thousands in terms of use frequency [18:04:48] there's many cases where setting the attribute is a no-operation (does nothing) such as "selected", "checked", "value", "disabled" etc. (they only work in jQuery because it has a whitelist where it then calls .prop() for you) [18:04:55] Maybe, but where relevant, I'd say it ranks with other synonymous terms [18:04:57] New review: Jeroen De Dauw; "John: What?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21610 [18:05:01] Nikerabbit: can you look at https://gerrit.wikimedia.org/r/#/c/18482/ ? [18:05:59] New patchset: Adamw; "Top-level cpp/Makefile will create build directory and run cmake" [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21693 [18:06:03] New review: Siebrand; "Why do you merge without amending the commit to include changes based on the comments made? See http..." [mediawiki/extensions/BlameMaps] (master) - https://gerrit.wikimedia.org/r/17972 [18:06:10] Change merged: Kaldari; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21609 [18:06:11] TrevorParscal: Regarding maxLength, do you remember the bug I encountered when setting .maxLength=undefined ? [18:06:18] New review: Jeroen De Dauw; "John: as I wrote in the description here and told you in person, this is work in progress, currently..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21684 [18:06:26] AaronSchulz: did you mean the revert commit? [18:06:31] Krinkle: not off hand, what was it? [18:06:44] yes [18:06:47] 03(NEW) Post essex-update, /home is not linked properly. - 10https://bugzilla.wikimedia.org/39741 major; Wikimedia Labs: (other); (abogott) [18:06:59] 03(mod) Cache more tiles - 10https://bugzilla.wikimedia.org/39714 +comment (10Tomasz Finc) [18:07:07] TrevorParscal: So in the byteLimit plugin we try to "unset" the native maxLength since the allowed byteLength will be longer, so we need to disable it. [18:07:14] However there's this weird thing [18:07:28] if you set .maxLength=undefined it will be undefined, .maxLength will return undefined [18:07:34] Yet, the effective maxLength is 0 [18:07:38] you can't enter anything anymore [18:07:47] Change merged: Kaldari; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21589 [18:07:50] because it's falsey I guess? [18:07:50] it casts to a Number internally [18:07:55] yeah, lol [18:07:56] ^ [18:08:06] Krinkle: .maxLength = Infinity ? [18:08:10] maybe [18:08:16] The only way to unset it is to unset the attribute [18:08:24] you should instead set it to 4x the actual byte limit [18:08:25] Kind of a ridiculous thing to do, but it could work [18:08:25] removeAttribute('maxlength') [18:08:34] then internally it will sync it with the property and set it to undefined. [18:09:15] well, technically you could just set it to the byte limit, since the character limit will be that, or less (if they use multi-byte chars) [18:09:17] marktraceur: Infinity should work, but that is a work around. Since setting the value from before there was a limit, should restore the situation [18:09:25] AaronSchulz: so the revert was not merged, hmm [18:09:31] e.g. by default it is undefined, you set 5 it is 5, you set undefined, it is not undefined, it is 0. [18:09:39] 03(mod) VisualEditor: Support most common citation templates (special-case) - 10https://bugzilla.wikimedia.org/39600 (10James Forrester) [18:09:42] 03(mod) VisualEditor: Support references - 10https://bugzilla.wikimedia.org/39599 (10James Forrester) [18:09:44] Hm, true [18:09:48] Nasty way to go [18:10:33] AaronSchulz: looks like I have different opinion from Siebrand how much lego is too much [18:10:53] AaronSchulz: do you want help fixing the original commit? [18:11:47] Leggo my eggo? [18:12:20] Nikerabbit: either revert or fix or disagree :) [18:12:34] TrevorParscal: marktraceur http://code.google.com/p/chromium/issues/detail?id=136004 [18:12:35] 03(mod) Make enhanced recentchanges the default - 10https://bugzilla.wikimedia.org/35785 +comment (10Nemo_bis) [18:15:03] AaronSchulz: too many options :) [18:16:01] Krinkle: I feel like delete should work there. [18:16:06] But apparently no. [18:16:11] indeed [18:18:23] ^demon: I'm assuming I can archive the "submit right for everyone" discussion at https://www.mediawiki.org/wiki/Git/Gerrit_project_ownership ? [18:18:46] <^demon> As far as I'm concerned, yes. [18:19:07] New patchset: Bsitu; "Update PageTriage to master" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21760 [18:19:11] OMG OMG OMG OMG OMG [18:19:16] wikitech is exploding while I had dinner [18:19:16] ok. there are a couple of other discussions there that I shall leave alone and that might in fact use your input :) [18:19:25] seriously so much crap over this [18:19:28] this is hilarious [18:19:39] Krinkle: This why we're in here chatting about it :P [18:19:39] post coming up [18:19:53] well, 1 more, Chad [18:20:08] can someone lock the thread while I write a reply :P [18:20:35] Krinkle: I'm sure we can just retroactively ignore the other messages :P [18:21:47] New review: Michael Shavlovsky; "I see, thank you for catching it. I am learning how to use gerrit. I did changes based on Nikerabbit..." [mediawiki/extensions/BlameMaps] (master) - https://gerrit.wikimedia.org/r/17972 [18:22:14] New patchset: Eranroz; "(bug 39357) Enter in editbox should not submit Search dialog" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/19942 [18:23:26] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21758 [18:23:38] New patchset: Parent5446; "Allow edit tokens for anonymous users." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21761 [18:25:32] Change merged: Kaldari; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/19450 [18:26:24] Change merged: Aaron Schulz; [mediawiki/extensions/Cite] (master) - https://gerrit.wikimedia.org/r/21702 [18:27:01] Change merged: Kaldari; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21739 [18:30:30] New patchset: Matthias Mullie; "Merge "Bug 39356 - Article feedback page: Drop-down menus need to be better aligned with title bar"" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21762 [18:30:43] New patchset: Parent5446; "(bug 26585) Handle CSV and array values in $_SERVER['REMOTE_ADDR']." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21135 [18:31:44] Change merged: Kaldari; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21717 [18:35:55] Change abandoned: Matthias Mullie; "oops" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21762 [18:37:07] Krinkle: ping [18:37:13] New patchset: Matthias Mullie; "Cleanup AFT config" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21587 [18:37:18] I have a few while cooking her [18:37:22] *here [18:37:38] Change merged: Matthias Mullie; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21587 [18:38:55] New review: Catrope; "Jenkins must be on crack, this commit is fine. It's complaining about a core test, did we somehow br..." [mediawiki/core] (wmf/1.20wmf10); V: 1 C: 0; - https://gerrit.wikimedia.org/r/21760 [18:41:27] New patchset: Matthias Mullie; "quick fix" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21763 [18:41:50] Change merged: Matthias Mullie; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21763 [18:43:00] New patchset: GWicke; "Top-level cpp/Makefile will create build directory and run cmake" [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21693 [18:43:16] Change merged: Bsitu; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21760 [18:44:39] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.20wmf9) - https://gerrit.wikimedia.org/r/21764 [18:46:38] New review: GWicke; "Rebased for merge." [mediawiki/extensions/Parsoid] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21693 [18:46:38] Change merged: GWicke; [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21693 [18:47:55] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21765 [18:49:08] 03(mod) Cannot cancel batch upload - 10https://bugzilla.wikimedia.org/39690 +comment (10Jon) [18:50:54] Ryan_Lane: I see that the Gerrit internal group "ops-reviewers" is labeled "Group local to Gerrit to work around bug where LDAP groups can't be added as reviewer. Use this group to ask for ops reviews." But "ops-reviewers" is not in the autocomplete when I start typing in the "add reviewer" box, probably because the membership is empty https://gerrit.wikimedia.org/r/#/admin/groups/162,members . Should I delete the group? [18:51:55] Change abandoned: Matthias Mullie; "(no reason)" [mediawiki/core] (wmf/1.20wmf9) - https://gerrit.wikimedia.org/r/21764 [18:52:11] (also, if there's someone else I should have asked this of, please tell me, Ryan_Lane - I asked you because you're my go-to "ops intersecting with Gerrit" dude) [18:52:42] New patchset: Platonides; "Israel website" [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/21766 [18:52:45] Change merged: Platonides; [mediawiki/extensions/WikiLovesMonuments] (master) - https://gerrit.wikimedia.org/r/21766 [18:52:48] sumanah: Do you have a rule in your brain that says "if /postgres/ then $ticket->assign('Andy')" ? :-) [18:53:05] 03(NEW) run tests using a Mediawiki snapshot instead of a clone - 10https://bugzilla.wikimedia.org/39742 normal; Wikimedia: Testing Infrastructure; (hashar) [18:53:08] ^demon: if you know anything about the above, please let me know.... I'm noticing some volunteers' ops patchsets awaiting reviewers and if there's a group they can add as reviewer, that'd be nice [18:53:15] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.20wmf9) - https://gerrit.wikimedia.org/r/21767 [18:53:25] 03(ASSIGNED) run tests using a Mediawiki snapshot instead of a clone - 10https://bugzilla.wikimedia.org/39742 (10Antoine "hashar" Musso) [18:53:33] <^demon> sumanah: No, you can't assign the ops group. [18:53:34] alester: I hope I haven't been straight-up assigning them! but yes, I think of you as a useful PostgreSQL dude to cc on stuff [18:53:51] :) [18:53:56] That's fine. I just go "Oh, I don't know about that aspect of Pg" and hit Delete. [18:54:08] nod [18:54:33] it'd be nice if you had Developer access, alester, so I could ask you to comment on proposed commits [18:55:00] I could at least look at them, no? [18:55:24] alester: yup! https://gerrit.wikimedia.org/r/#/q/status:open+project:^mediawiki.*,n,z [18:55:47] nothing is awaiting comment right now, alester - https://gerrit.wikimedia.org/r/#/q/message:postgres+status:merged,n,z [19:01:10] sumanah: alas it doesn't work. yeah. delete the group [19:02:46] Ryan_Lane: ok. So, is there a group of any kind that people can add, to request ops reviews? [19:03:34] Ryan_Lane: never mind, I'm not a high enough admin to delete the group [19:04:05] Ryan_Lane: "novaadmin " can't be right, can it? [19:06:10] New review: Catrope; "Overriding Jenkins cause it's broken" [mediawiki/core] (wmf/1.20wmf9); V: 1 C: 0; - https://gerrit.wikimedia.org/r/21767 [19:06:26] New review: Catrope; "Overriding Jenkins cause it's broke" [mediawiki/core] (wmf/1.20wmf10); V: 1 C: 0; - https://gerrit.wikimedia.org/r/21765 [19:06:31] can anyone please help getting the MHTML extension to work in 1.19.1? http://www.mediawiki.org/wiki/Extension:MHTML [19:07:50] Change merged: Matthias Mullie; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21765 [19:08:01] Change merged: Matthias Mullie; [mediawiki/core] (wmf/1.20wmf9) - https://gerrit.wikimedia.org/r/21767 [19:08:52] New review: Nasirkhan; "got an error at the time of amend the commit and on the second try submitted a new commit my mistake..." [mediawiki/extensions/Narayam] (master) C: 0; - https://gerrit.wikimedia.org/r/21757 [19:11:36] New patchset: Bsitu; "Update PageTriage to master" [mediawiki/core] (wmf/1.20wmf9) - https://gerrit.wikimedia.org/r/21768 [19:12:13] New patchset: Nischayn22; "Removing the need to enter a name while creating a group" [mediawiki/extensions/SemanticWatchlist] (master) - https://gerrit.wikimedia.org/r/21769 [19:12:13] New patchset: Raimond Spekking; "Move extension descripton message to i18n file" [mediawiki/extensions/SiteMetrics] (master) - https://gerrit.wikimedia.org/r/21770 [19:12:35] Change merged: Bsitu; [mediawiki/core] (wmf/1.20wmf9) - https://gerrit.wikimedia.org/r/21768 [19:13:18] New patchset: Tpt; "Bug fixed: The link to the next page wasn't shown when the searchTerm wasn't empty" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/21771 [19:14:08] saper: am getting too many mails [19:14:11] from gerrit [19:14:35] Nischayn22: some of that is me asking you to review stuff, right? :) [19:15:00] sumanah: I only got one such mail, long long ago [19:15:38] This time gerrit is sending me mails when I add someone to review, not clever enough like bugzilla [19:16:35] Nischayn22: I think there's a setting for that in Settings? [19:16:37] maybe not [19:17:23] there isn't one [19:17:34] New review: Daniel Kinzler; "@Michael as to learning to use gerrit, please read https://www.mediawiki.org/wiki/Git/Workflow - not..." [mediawiki/extensions/BlameMaps] (master) - https://gerrit.wikimedia.org/r/17972 [19:17:48] New review: Aaron Schulz; "CLI scripts run in autocommit mode, so this should be ok." [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21581 [19:17:49] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21581 [19:17:55] * sumanah is wrong [19:18:08] sumanah: just got two mails from you [19:18:15] Nischayn22: yay! [19:18:56] I haven't hacked much into core to review stuff [19:19:15] Nischayn22: now's a good time :) [19:19:34] Nischayn22: basically, the better you understand core, the better bridge you can be to write and maintain extensions [19:19:44] and to argue with core folks on behalf of people who write extensions :) [19:19:58] sumanah: yes, I see that :) [19:20:33] Thehelpfulone: do you have a moment to help bikeshed a HOWTO? [19:22:06] New review: Daniel Kinzler; "the reason the tests failed is that the tests got stricter today. it took me a few hours to fix them..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21709 [19:22:45] heh, nice comment [19:23:54] New patchset: Matthias Mullie; "fix js permissions" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21772 [19:24:23] 03(mod) Prevent page creation in repo? - 10https://bugzilla.wikimedia.org/39734 +comment (10Daniel Kinzler) [19:25:23] Change merged: Bsitu; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21772 [19:25:37] New patchset: Adamw; "(FR #595) Adyen payment gateway" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/20467 [19:25:39] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 +comment (10Roan Kattouw) [19:26:53] RoanKattouw: thanks for the comment at https://bugzilla.wikimedia.org/38294 . [19:27:18] New patchset: Tpt; "Bug fixed: The link to the next page wasn't shown when the searchTerm wasn't empty" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/21771 [19:27:28] New patchset: Dereckson; "Rewrite the ThumbnailImage constructor to take parameter array" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21321 [19:27:33] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.20wmf9) - https://gerrit.wikimedia.org/r/21773 [19:27:42] Change merged: Matthias Mullie; [mediawiki/core] (wmf/1.20wmf9) - https://gerrit.wikimedia.org/r/21773 [19:29:16] New review: Daniel Kinzler; "@aaron yea, realized too late that i had been talking to you about this issue on the list :) anyway,..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21582 [19:29:22] New patchset: Matthias Mullie; "Update ArticleFeedbackv5 to master" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21774 [19:29:31] Change merged: Matthias Mullie; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21774 [19:30:00] New review: Dereckson; "Rebased to master." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/19008 [19:30:39] Change restored: Catrope; "(no reason)" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21736 [19:30:55] New patchset: Catrope; "Hide deprecated warning for Revision::revText()." [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21736 [19:31:09] New review: Catrope; "PS2 fixes dependency issue" [mediawiki/core] (wmf/1.20wmf10); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21736 [19:32:15] New review: Aaron Schulz; "You placed the commit for the Revision insert/updateOn. For CLI scripts (which run in autocommit mod..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21582 [19:35:25] New review: Foxtrott; "I have some questions in/on the php code..." [mediawiki/extensions/SemanticResultFormats] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21697 [19:36:53] New review: Dereckson; "According the Jenkins output, the failed tests seems to be unrelated with this change." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/21321 [19:37:00] 03(mod) add a custom field "commit in gerrit" in bugzilla ui. - 10https://bugzilla.wikimedia.org/39399 +comment (10Krinkle) [19:37:26] New patchset: Catrope; "Work around preg_replace_callback() issue in CSSJanus" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21775 [19:37:39] 03(mod) add a custom field "commit in gerrit" in bugzilla ui. - 10https://bugzilla.wikimedia.org/39399 +comment (10Krinkle) [19:37:59] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 +comment (10Roan Kattouw) [19:38:19] RoanKattouw: when you do Janus stuff I imagine you as Two-Face from Batman, flipping a coin [19:38:28] this is difficult because Two-Face is a villain [19:38:31] hehe [19:38:40] New review: Krinkle; "I introduced a Test suite for CSSJanus a few weeks back. I'd say, add a unit test for it." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21775 [19:38:55] also I don't think you snarl [19:39:04] New review: Tpt; "This bug affect production environment, I think that we can't wait for a review." [mediawiki/extensions/ProofreadPage] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21771 [19:39:04] Change merged: Tpt; [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/21771 [19:39:20] New review: Catrope; "I could do that, but I have no idea what triggers the bug (other than a 20KB real-world example), an..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21775 [19:41:01] Change merged: Catrope; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21736 [19:41:51] plop [19:42:03] can't stop working [19:42:11] Change merged: Foxtrott; [mediawiki/extensions/SemanticPageSeries] (master) - https://gerrit.wikimedia.org/r/21545 [19:42:16] New patchset: Raimond Spekking; "Use standard description message key" [mediawiki/extensions/Phalanx] (master) - https://gerrit.wikimedia.org/r/21801 [19:43:05] New patchset: Catrope; "Update ProofreadPage" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21808 [19:43:17] Nikerabbit: be careful! I don't want you to burn out :) [19:43:43] RoanKattouw: is self::$patterns['bg_horizontal_percentage'] actually set when thats called? [19:43:53] Yes, I var-dumped it [19:44:16] It did contain some literal \r , \n and \f characters, maybe that's it. I cleaned them up but it didn't help, but then maybe I didn't get all of them [19:44:36] There must be /some/ reason for this behavior [19:44:54] But then again it's not failing for all input, and it also doesn't fail on my laptop or on Mathias's [19:45:11] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/21775/ fixes the AFT problem. [19:45:20] sumanah: been close [19:45:30] aharoni: Yes, I know, I tested it on fenari [19:45:53] Nikerabbit: if you ever want to swap anti-burnout tips let me know [19:46:06] AaronSchulz: But it works for simple input: [19:46:10] > echo CSSJanus::transform('.foo { float:left; }', true, false, true ) [19:46:11] .foo { float:right; } [19:46:21] RoanKattouw: you say "" - don't you want to may log it [19:46:29] sorry [19:46:36] I can't parse that sorry :S [19:47:13] RoanKattouw: you say "returns null here for some weird reason" - don't you want to maybe log it or something? [19:47:13] Change merged: Catrope; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21808 [19:47:26] to catch the weird cases. [19:47:36] 03(NEW) Format author field as [[user:|]] instead of just [[user:]] - 10https://bugzilla.wikimedia.org/39743 normal; WikiLoves Monuments Mobile: General; (maarten) [19:47:46] aharoni: Hmm, maybe [19:48:11] sumanah: first tip: keep close track of the hours you work [19:48:49] 03(FIXED) PHP Warning: fmod() expects parameter 1 to be double, string given - 10https://bugzilla.wikimedia.org/39673 (10Niklas Laxström) [19:48:57] 03(NEW) Install Scribunto on fr.wikisource - 10https://bugzilla.wikimedia.org/39744 normal; Wikimedia: Extension setup; (thomaspt) [19:48:58] Nikerabbit: and my first tip: reduce self-imposed standards & scope of responsibility to something more reasonable [19:48:58] RoanKattouw: what is the real-world example? [19:49:17] 03(ASSIGNED) thumbs near the words "Yes" and "No" are on the same side of the words in LTR and RTL - 10https://bugzilla.wikimedia.org/36324 +comment (10Amir E. Aharoni) [19:49:18] AaronSchulz: https://bugzilla.wikimedia.org/show_bug.cgi?id=38294#c5 [19:50:17] 03(NEW) Location where the photo was taken should be added to the upload - 10https://bugzilla.wikimedia.org/39745 normal; WikiLoves Monuments Mobile: General; (maarten) [19:50:40] New patchset: MarkTraceur; "(bug 39608) Check for undefined in many places" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21820 [19:50:49] * marktraceur takes lunch break [19:51:00] (that was a painful patch) [19:51:24] New review: Amire80; "It fixes bug 38294 and maybe some other issues, but maybe the weird cases should be logged for furth..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/21775 [19:51:30] 03(mod) run tests using a Mediawiki snapshot instead of a clone - 10https://bugzilla.wikimedia.org/39742 +comment (10Antoine "hashar" Musso) [19:52:03] sumanah, sorry, I stepped away from my screen, sure [19:52:49] Change merged: Nikerabbit; [mediawiki/extensions/Babel] (master) - https://gerrit.wikimedia.org/r/21752 [19:53:21] Thehelpfulone: https://www.mediawiki.org/wiki/User:Sumanah/GettingReviews - readable? accurate? missing any particularly important steps? [19:55:05] hmm, 1) Respond to feedback. [19:55:05] -> that sounds like an odd first step, reading the description I can see why, but responding to feedback typically comes after you've found a reviewer [19:55:39] Thehelpfulone: I've seen places where people never responded to Jenkins failures [19:55:45] sumanah: one very important thing is missing, i think: make small, consise patches. [19:55:54] that's not alwaqys possible, of course [19:56:02] but it does help with getting reviews [19:56:22] New review: Krinkle; "QUnit test looks fine (not reviewing the other code or whether it actually passes)." [mediawiki/extensions/EtherEditor] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/14153 [19:56:37] well perhaps it shouldn't be feedback - that sounds like it's a human review, "Check for system error messages" might be better? [19:56:46] also, about jenkins... i *today* finally found out how to find the pesky error messages. you know, to see *why* jenklins failed. [19:56:48] Thehelpfulone: Changing header - thanks. [19:56:50] 03(mod) git clone fail with an RPC error - 10https://bugzilla.wikimedia.org/39737 +comment (10Jeff Green) [19:56:54] sure [19:56:58] Change restored: Alex Monk; "(no reason)" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21730 [19:57:13] sumanah: you have to hover over the respective test, wait for the popup to show, and then click console output. [19:57:22] i hadn't seen this once in the previous months. [19:57:26] New patchset: Alex Monk; "Fix double parsing of "previewnote" message" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21730 [19:57:27] this is... arcane [19:57:37] 03(NEW) UploadWizard needs to quit using funky array magic for upload lists - 10https://bugzilla.wikimedia.org/39746 minor; MediaWiki extensions: UploadWizard; (mtraceur) [19:57:50] RoanKattouw: it's PREG_BACKTRACK_LIMIT_ERROR [19:57:54] Yeah Jenkins is unhelpful in showing you why it failed, especially if the merge step failed [19:58:15] AaronSchulz: Really? I thought that would be it too, but the backtrack limit was set really high, like 100k [19:58:16] if anyone knows a better way, i'd be happy to know it. sometimes, the "consolidated failures" or whatever give you the info you need. but quiter often, they don't. [19:58:20] DanielK: "(To see why automated tests fail, click on the link in the "failed" comment in Gerrit, hover over the test, wait for the popup to show, and then click "console output.")" Accurate? [19:58:25] AaronSchulz: (Also, how the hell did you find out? :) ) [19:58:49] now thinking as someone who might be thinking in technical terms: "or hit the Abandon button to get your patchset *completely off the table* while you revise it." - that sounds possibly like something you would say verbally, reading that someone might think it's being removed from some technical table - or is that what you are trying to imply? Maybe "out of code review" might be better [19:58:53] sumanah: yea. i think so. well, try to follow the instructions on a failed jenkins test :)( [19:58:54] ini_set( 'pcre.backtrack_limit', 10000000 ); fixes it [19:58:55] Thehelpfulone: I've also seen where people just did not respond to code reviews they'd already gotten, so that's already not very helpful, even before the "add reviewer" step [19:59:02] DanielK: gimme an example? [19:59:16] Thehelpfulone: +1, wording like "out of the queue" would be better [19:59:31] sumanah: bad example, because different yet: https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/4344/ [19:59:35] New review: Krinkle; "Looks generally OK, though I haven't tested it (we'd definitely need unit tests in the same commit t..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/13366 [19:59:39] guessing why this one failed is really fun [19:59:52] RoanKattouw: Thehelpfulone: changing, thanks! [20:00:00] sumanah: in that case, it's the "console output" in the menu on the left. [20:00:06] DanielK: That's just a merge conflict. Click Console output on the left to se eit [20:00:15] DanielK: can you just give me a link to a more common-case situation? [20:00:23] actually ini_set( 'pcre.backtrack_limit', 1000000 ); works too [20:00:26] * sumanah usually loves outliers, you know that [20:00:27] That *is* a common-ish situation [20:00:29] but not now :) [20:00:34] does gerrit have a pretty recent changes feed or something where people keep an eye on new patches, or is https://gerrit.wikimedia.org/r/#/q/status:open,n,z what everyone uses? [20:00:37] sumanah: here'S anm example where my instructions work: https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/4340/ [20:00:40] RoanKattouw: preg_last_error() [20:00:45] AaronSchulz: Aaaaaaah [20:00:46] (hover over the stuff with a red dot) [20:00:54] it gives 2 (and dumping all the constants shows which one is 2) [20:01:03] Thehelpfulone: hardcore people use mediawiki-commits mailing list [20:01:17] But > echo ini_get('pcre.backtrack_limit') [20:01:18] 100000 [20:01:27] Nikerabbit, that was too much spam for me using iOS's built in mail :P [20:01:31] sumanah: also works here, but for that one, the "aggregated test results" also show the info needed [20:01:37] wow, red dots. not great for the colorblind.... [20:01:40] it'S really confusing and unclear [20:01:44] I guess that regex must just be terribly inefficent then [20:01:54] sumanah: err, here being https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/4328/# [20:02:00] RoanKattouw: https://bugs.php.net/bug.php?id=40846 [20:02:16] though, yeah it's probably also not efficient ;) [20:04:05] Change merged: Siebrand; [mediawiki/extensions/SiteMetrics] (master) - https://gerrit.wikimedia.org/r/21770 [20:04:17] 03(WONTFIX) Install Scribunto on fr.wikisource - 10https://bugzilla.wikimedia.org/39744 normal->15enhancement; +comment (10Sam Reed (reedy)) [20:04:24] hmm.. " The people who write and review those changesets would be good candidates to add as reviewers." - do we have a list of top reviewers or similar for the projects? It's just that people who write changesets may not necessarily be able to review it - especially as quite a chunk of it needs someone from ops/wmf staff [20:04:44] RoanKattouw: on my lappy, the default is 1e6 [20:05:12] its probably the same on yours, which is 10x whats on fenari/apaches [20:05:17] Yeah mine too [20:05:18] Thehelpfulone: well, people who write similar code shold be able to review yours. they are not necessarily able to merge it, though [20:05:25] * RoanKattouw fixes in puppet [20:05:30] that's weird - did Reedy mean to close that "install Scribunto on French Wikisource" request? [20:05:43] I thought that was weird as well [20:05:53] ah fair enough, is there a clean list of people who are able to (and willing to!) merge it that developers can refer to? [20:05:57] In favour of ParserFunctions... [20:06:04] Thehelpfulone: There isn't I don't think, but there should be [20:06:10] Yeah that WONTFIX is weird [20:06:20] Thehelpfulone: everyone should review [20:06:34] all developers should also look over stuff and +1 and -1 it [20:06:42] https://gerrit.wikimedia.org/r/#/c/21730/1/includes/EditPage.php [20:06:42] hm [20:06:45] all project owners can merge [20:06:47] sumanah, yep sure, I actually mean to say merging wise [20:06:59] actually... i apparently can also merge in extensions which i don't own. [20:07:03] DanielK, and if you are gerrit noob finding that out isn't always easy [20:07:07] DanielK: Because you own mediawiki/core [20:07:07] New review: Aaron Schulz; "Looks like the problem is pcre.backtrack_limit (1e5 on production, 1e6 on our test laptops)." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21775 [20:07:08] maybe owners of mediawiki can also merge stuff in extensions? [20:07:08] Should the preview note allow templates and such? [20:07:14] Thehelpfulone: yes, but we could supply a link [20:07:23] and ops members can merge quite a lot of stuff, but that doesn't mean they will [20:07:26] 03(mod) Install Scribunto on fr.wikisource - 10https://bugzilla.wikimedia.org/39744 +comment (10Sumana Harihareswara) [20:07:37] RoanKattouw: that qualifies my to review, say, SMW stuff? [20:07:41] either if they are not comfortable with doing it, or it's not part of their work so they don't want to thread on other's toes [20:07:42] oh, well [20:08:09] Thehelpfulone: so, https://gerrit.wikimedia.org/r/#/admin/groups/11 is the list of people who can merge into MW core [20:08:30] 04(REOPENED) Install Scribunto on fr.wikisource - 10https://bugzilla.wikimedia.org/39744 +comment (10Roan Kattouw) [20:08:59] Thehelpfulone: the answer is to make everyone comfortable and make it a norm that there is no such thing as treading on toes by giving +1 or -1 [20:09:09] in my opinion [20:09:15] sumanah: you beat me to it :) took me a bit to find it, though. maybe put that links somewhere in the docu? [20:09:15] sumanah, I meant treading in terms of +2 [20:09:16] 03(mod) JavaScript not labeled as free - 10https://bugzilla.wikimedia.org/36866 +comment (10Benjamin Mako Hill) [20:09:23] RoanKattouw: I believe the discussion on the mailing lists, testing is happening on mw and test2 then its being pushed to all [20:09:36] so there really isn't a need for indiviual bugs for it [20:09:38] also sumanah, how do I view the list of people in the ops group on gerrit? [20:10:11] Thehelpfulone: so, let me explain why I am specifically suggesting that people look at recent changesets & reviewers, and search and so on, rather than look at lists. [20:10:25] ok [20:10:37] Thehelpfulone: (a) not everyone in a group actually likes to review, so let's not irritate them with possible spam [20:10:59] (b) the exercise of searching educates the searcher by showing them amount of recent activity, names of authors, etc. [20:11:27] (c) it is a bad idea to limit review requests to Gerrit project owners, because we want everyone to request reviews and to have reviews requested of them -- how else will developers learn? [20:11:33] Thehelpfulone: "ops" as in deployment access? https://gerrit.wikimedia.org/r/#/admin/groups/21,members [20:12:07] there's probably more with (some) shell access, but these are able to push config stuff etc via gerrit [20:12:07] (d) everyone can search, even when not logged in. I think you can't look at groups & membership unless you're logged in. Could be wrong and this is minor anyway [20:12:16] i *think* this is how things should work nowadays [20:12:38] DanielK: ops as in the LDAP group ops (but it looks like gerrit isn't able to show LDAP groups) [20:12:54] Thehelpfulone: yea, it's kinda strange about that [20:13:04] Thehelpfulone: and (e) looking at past changesets will also reveal the names of people who are willing and able to merge changesets [20:13:05] there's also ops-reviewers, apparently a workaround, but also empty [20:13:25] DanielK: yes, it doesn't work and ^demon or some similar person will be deleting it [20:13:44] there are people similar to ^demon? [20:13:51] Thehelpfulone: (f) problems like that :-) right now the best way to figure out who can review & merge ops changes is to look at past ops changesets [20:13:54] <^demon> Wait, what am I deleting? [20:14:09] New patchset: Trevor Parscal; "Fixed position and size of toolbar in Apex skin" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21825 [20:14:23] ^demon: the baby server kittahs [20:14:23] ^demon: that "ops-reviewers" group, which Ryan_Lane said is useless and we should delete. I'm not able to do it from my admin interface [20:14:26] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 +comment (10Roan Kattouw) [20:14:37] <^demon> Has to be done in the database. [20:14:41] <^demon> Groups have no UI way of deletion. [20:14:47] .. [20:14:55] ^demon: make a backup ;) [20:15:08] Does 2.5 fix that? [20:15:14] <^demon> No. [20:15:33] sumanah, okay I like your reasoning, now one question with regards to finding people for merging: https://gerrit.wikimedia.org/r/#/q/status:merged,n,z L10n-bot seems to dominate that, is it possible to somehow hide merges from the bot? [20:15:36] Thehelpfulone: so, in summary, I think my suggestion is better, at least right now, than referring to lists. I thought about pointing people to https://www.mediawiki.org/wiki/Developers but I just cannot invest time in updating that right now. Does this make sense? I know it's a harder suggestion to follow, but ultimately far more rewarding for everyone [20:15:43] <^demon> Krenair: http://code.google.com/p/gerrit/issues/detail?id=44 fixes it :) [20:15:51] yes, Thehelpfulone -- "-owner:L10n-bot" [20:15:52] Thehelpfulone: -reviewer:l10n-bot should work I think [20:15:54] <^demon> Thehelpfulone: -Owner:L10n-bot [20:15:55] Oh, right [20:15:56] owner [20:15:57] Change merged: Trevor Parscal; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21825 [20:16:07] Change merged: Katie Horn; [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/21691 [20:16:11] (I see we are all becoming wizards of gerrit search) [20:16:14] heh [20:16:18] <^demon> Suggestions are in 2.5 :D [20:16:22] <^demon> Can't wait. [20:16:22] is that documented somewhere for the n00bs? [20:16:25] <^demon> Where is rc1 [20:16:34] Thehelpfulone: I learned it by looking at the search docs [20:16:40] https://gerrit.wikimedia.org/r/Documentation/user-search.html [20:16:42] <^demon> Thehelpfulone: The entire gerrit search interface is linked from Documentation -> Search in the gerrit header. [20:17:00] <^demon> I might make Documentation size 36 font. Nobody seems to see it :\ [20:17:24] ooh I didn't actually see that myself :P [20:17:55] can we add an extra table in the search results that shows who the merger was? [20:18:25] 03(mod) Make files have different URLs depending on size (so one can stream large files) - 10https://bugzilla.wikimedia.org/39016 (10Aaron Schulz) [20:18:28] <^demon> sumanah: Also, your bug you opened about sorting of projects (W before i)...I believe that might be something that's OS-specific. [20:19:28] <^demon> Thehelpfulone: Don't know if that's a queryable field. [20:19:29] ^demon: "suggestions" for who could review a given changeset? AWESOME [20:19:56] <^demon> No, search suggestions. [20:20:51] ^demon, can you find out? :) [20:21:17] <^demon> I'm kind of busy at the moment. The docs should list every field you can query by. [20:22:07] New patchset: Trevor Parscal; "Finally getting rid of all the es-* stuff and other cruft" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21677 [20:22:34] sumanah, on a slightly unrelated note, is the coder user group in mediawiki.org still actively used? [20:22:37] sumanah: actually, that would be a very neat use for a recommender engine: match reviewers and code patches, both ways. [20:22:47] sumanah: i smell a gsoc project ;) [20:23:01] DanielK: did you read that one Making Software chapter re code review? [20:23:20] turns out a great use for recommendation engines there is "if you're reviewing this patch, here are some code files you'll want to look at" [20:23:23] http://stackoverflow.com/questions/4469281/recommendation-engine [20:23:34] <^demon> sumanah: For deleting groups, we'd need to dust off :) [20:24:02] sumanah: ha, cool! no, no time for reading... i just derived that from your comments ;) [20:24:14] Thehelpfulone: I believe so [20:24:15] The simple start I wanted when I was thinking of Gareth was tags. [20:24:23] Thehelpfulone: because there are still some people using svn. [20:24:32] DanielFriesen: code pretty much tags itself. [20:24:39] ah, the pywikipediabot lot and some extensions? [20:24:45] it's already semi-structured content [20:25:02] <^demon> Thehelpfulone: That's about it at this point, yeah. [20:25:07] we do want tags though [20:25:09] Tag reviews with things like parser, api, i18n, etc… and have people subscribe to whatever tags they specialize in. [20:25:16] because right now I'm workarounding that with "message:" [20:25:47] DanielK, ;) yeah, and my plan was to make Gareth use various rules to automatically tag things [20:25:53] Thehelpfulone: yes, https://www.mediawiki.org/wiki/Special:Code has some ..... [20:26:22] Thehelpfulone: https://www.mediawiki.org/wiki/Special:Code/Wikimedia fundraising! https://www.mediawiki.org/wiki/Git/Conversion#Affected_development_projects [20:26:39] hmm, I was wondering why they haven't moved across yet [20:26:49] ^demon: blergh re OS-specific sorting issue. blergh I say! [20:27:31] <^demon> DanielFriesen: Tagging in gerrit is on my roadmap. [20:27:42] <^demon> And auto-tagging would be trivial with 2.5 extensions. [20:28:02] New patchset: Mwjames; "SRF timeseries, make use of new tableview plugin" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21697 [20:28:33] Thehelpfulone: DanielK - take a look at the new improved HOWTO :-) [20:28:33] anyone know when the CheckUser API was added? [20:28:36] My ideal was. You commit. Push to your personal public remote. Gareth pulls from there. Detects a convention in your push and automatically creates a review branch from what you pushed. Then based on a set of rules automatically adds tags. And finally queues a notification to users who subscribed to new review branches with any of those tags. [20:28:55] 04(REOPENED) WLMMobile: 'cancel' during upload doesn't actually cancel the upload - 10https://bugzilla.wikimedia.org/38317 +comment (10Jon) [20:29:31] ^demon, Is it a simple one-dimension tag list… Or multiple key+value attributes? [20:29:50] biab [20:30:13] After I started posting the ideas about tagging I started thinking it would be useful if those were keyed attributes. [20:30:24] <^demon> DanielFriesen: Not sure yet, haven't gotten to actual implementation. But we're looking at making it lucene-based, so probably they'd be attributes on an indexed changed. [20:30:39] <^demon> *an indexed change [20:30:49] The simple tagging would be handled with something like category:parser, category: api, etc... [20:31:04] sumanah: I cleaned a couple of the links, is gerrit always https://? [20:31:11] oh she's run away :P [20:31:12] Though I'll probably need some more thought before I remember any of the use cases for other keys. [20:31:31] Change merged: Foxtrott; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21697 [20:31:35] New patchset: Robmoen; "Added new mw message 'editpage-head-copy-warn' to EditPage header." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21826 [20:32:00] <^demon> DanielFriesen: You can in theory do them with tracking ids, but that's more for grouping things like "bug 123" and the syntax is kinda stupid. [20:32:20] Ahhhhhh… that might have been it! [20:32:48] <^demon> Yeah, making that system based on the same lucene "tagging" would be nice. [20:33:03] category: parser, category: skinning, bug:123 [20:33:33] 03(NEW) Feedback page - Multiple Unflags - 10https://bugzilla.wikimedia.org/39747 normal; MediaWiki extensions: ArticleFeedbackv5; (fflorin) [20:33:40] <^demon> DanielFriesen: Exactly, that's my plan :) [20:33:41] New review: Siebrand; "Please also add this key to maintenance/languages/messages.inc and maintenance/languages/messageType..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21826 [20:33:43] * Ryan_Lane sighs [20:33:51] 03(mod) Feedback page - Multiple Unflags - 10https://bugzilla.wikimedia.org/39747 normal->major (10Fabrice Florin) [20:33:53] I hate when people disappear from irc [20:33:56] Betacommand, looks like Tue Oct 18 21:37:56 2011 +0000 [20:34:06] New review: Catrope; "See inline comment, and what Siebrand said." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21826 [20:34:12] Aaah… *facepalm* right ^demon is online [20:34:20] Krenair: thanks [20:34:27] Will find the SVN commit for you [20:34:39] ^demon, I changed the short url config recommendations again [20:34:56] Betacommand, https://www.mediawiki.org/wiki/Special:Code/MediaWiki/100165 [20:35:15] 14(DUP) JS error "malformed URI sequence" in Special:BannerController - 10https://bugzilla.wikimedia.org/25846 +comment (10Fomafix) [20:35:15] 03(mod) JavaScript exception thrown by decodeURI on SpecialBannerController should be caught - 10https://bugzilla.wikimedia.org/38805 +comment (10Fomafix) [20:35:18] Krenair: do you know what mediawiki release that would have been with? [20:35:23] RoanKattouw: heh. Comment collision in Gerrit :) [20:35:42] CheckUser is not distributed with MediaWiki as far as I know, Betacommand... [20:36:02] <^demon> Easily checked though. Look at phase3 @ r100165 and see what $wgVersion was. [20:36:05] Krenair: but they are paired with releases [20:36:07] siebrand: Yeah :) [20:38:46] New patchset: Amire80; "Fix flyover positioning for RTL environments" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21827 [20:39:21] Betacommand, 1.18 beta 1 was released November 4th [20:39:32] 03(NEW) Feedback Page - Hide My Post is not tracked in Activity Log - 10https://bugzilla.wikimedia.org/39748 normal; MediaWiki extensions: ArticleFeedbackv5; (fflorin) [20:39:38] Krenair: thanks [20:39:43] 03(mod) Feedback Page - Hide My Post is not tracked in Activity Log - 10https://bugzilla.wikimedia.org/39748 (10Fabrice Florin) [20:39:51] http://lists.wikimedia.org/pipermail/mediawiki-announce/ is a good reference for this sort of thing [20:40:46] Krenair: I just joined it recently [20:40:50] 03(NEW) Uploading non-jpg files - 10https://bugzilla.wikimedia.org/39749 normal; WikiLoves Monuments Mobile: Upload; (jrobson) [20:41:05] Betacommand, the archives I mean [20:42:11] https://www.mediawiki.org/w/index.php?title=Manual:$wgFileExtensions&oldid=573495&diff=cur [20:42:12] um [20:42:14] I highly doubt this [20:42:19] ^demon, I still can't figure out what situation %{DOCUMENT_ROOT} won't be defined in. [20:42:52] …although I have not tested VirtualDocumentRoot yet [20:44:38] New patchset: Robmoen; "Added new mw message 'editpage-head-copy-warn' to EditPage header." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21826 [20:46:25] 03(NEW) Feedback Page on iPad - Hide My Post Flyout Stays Open - 10https://bugzilla.wikimedia.org/39750 normal; MediaWiki extensions: ArticleFeedbackv5; (fflorin) [20:46:47] 03(mod) Feedback Page on iPad - Hide My Post Flyout Stays Open - 10https://bugzilla.wikimedia.org/39750 (10Fabrice Florin) [20:47:54] New patchset: Krinkle; "[mw.notification] Introduce a full fledged notification system into core replacing jsMessage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19199 [20:48:31] 03(mod) Feedback Page on iPad - Hide My Post Flyout Stays Open - 10https://bugzilla.wikimedia.org/39750 (10Fabrice Florin) [20:48:41] New review: Catrope; "Per Siebrand" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21826 [20:49:22] RoanKattouw: can CSSJanus do anything clever with background-position percentage values? or only 'left' and 'right'? [20:49:35] New review: Krinkle; "* Addressed some of the comments in path set 4" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/19199 [20:49:49] aharoni: It does have clever handling for percentage values yes [20:50:05] Where "clever" means x = 100 - x [20:50:41] Which works even for negative values and values over 100% [20:53:55] RoanKattouw: it doesn't seem to actually work in AFTv5 on my local test wiki. [20:55:21] in https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/ArticleFeedbackv5.git;a=blob;f=modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css;hb=HEAD [20:55:35] line 243 [20:56:01] stays "-5px -6px" in RTL. [20:56:29] Hmm that's weird [20:56:36] I suppose that's a bug then [20:56:53] New patchset: Mwjames; "fix double entry" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21828 [20:57:03] 03(FIXED) Canadian provinces showing french names when phone is in english - 10https://bugzilla.wikimedia.org/39689 +comment (10Max Semenik) [20:57:25] Change merged: Mwjames; [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21828 [20:58:42] Change merged: Krinkle; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21661 [20:58:49] 03(mod) WLMMobile: 'cancel' during upload doesn't actually cancel the upload - 10https://bugzilla.wikimedia.org/38317 +comment (10Jon) [20:59:43] New patchset: Trevor Parscal; "Finally getting rid of all the es-* stuff and other cruft" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21677 [20:59:57] 03(NEW) Show Protect Feedback Actions in the Protection Log and My Contributions - 10https://bugzilla.wikimedia.org/39751 normal; MediaWiki extensions: ArticleFeedbackv5; (fflorin) [21:00:09] 03(mod) Show Protect Feedback Actions in the Protection Log and My Contributions - 10https://bugzilla.wikimedia.org/39751 normal->major (10Fabrice Florin) [21:02:02] New patchset: MarkTraceur; "(bug 38022) Check for completeness in confirmCloseWindow" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21829 [21:02:14] New patchset: MaxSem; "r906-909" [wikimedia/wlm-api] (master) - https://gerrit.wikimedia.org/r/21830 [21:02:22] /Yay/, just one hour till I have someone shoving pointy objects into my mouth... [21:02:35] 03(mod) Getting "Warn me when I leave an edit page with unsaved changes" - 10https://bugzilla.wikimedia.org/38022 +patch-in-gerrit; +comment (10Mark Holmquist) [21:02:54] 03(mod) Uploading non-jpg files - 10https://bugzilla.wikimedia.org/39749 +comment (10Jon) [21:03:10] DanielFriesen: I say this sincerely: thank you for taking care of yourself [21:03:36] Heh… this is just a cleaning... [21:03:40] still. [21:03:54] Thehelpfulone: DanielK - your suggestions were very very useful. beaucoup gracias [21:04:07] 03(mod) coords 0, 0 used for monuments without coordinates - 10https://bugzilla.wikimedia.org/39476 +comment (10Jon) [21:04:07] I'll have to go back another day to have metal poured in my mouth and things pulled out. [21:04:12] 03(FIXED) Header of diffs uses obsolete attribute valign (in HTML5) - 10https://bugzilla.wikimedia.org/39680 +comment (10Krenair) [21:04:16] New review: awjrichards; "This looks fine, just minor inline comment." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21748 [21:05:34] Krinkle: I'm not that firm with gerrit... can I alter already merged changes? [21:05:45] No [21:06:03] Ok, so to handle your comments on https://gerrit.wikimedia.org/r/#/c/21682/1 I have to submit a new one? [21:06:09] 03(mod) WLMMobile: 'cancel' during upload doesn't actually cancel the upload - 10https://bugzilla.wikimedia.org/38317 +comment (10Brion Vibber) [21:07:14] I wish the TV in the dentist office had some sort of wireless display port I could plug my laptop into. [21:07:23] 03(mod) MediaWiki:Articlefeedbackv5-error-abuse prevents localisation - 10https://bugzilla.wikimedia.org/38591 +comment (10Matthias Mullie) [21:09:00] Krinkle: ^ [21:09:10] …gerrit makes collaboration on patch sets really annoying [21:10:09] New review: Catrope; "Tests are weird, actual code looks good" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21312 [21:10:47] Someone else makes an amend to one of my commits. And I have to use an ugly fetch command and manually reset my branch to another commit hash. [21:11:27] New review: Catrope; "I'm guessing this is because PHP will try a numerical comparison otherwise?" [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21470 [21:11:28] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21470 [21:11:55] DanielFriesen: Yeah that's annoying, although git review -d 12345 does make it a bit easier [21:11:59] sumanah, de naen :) [21:12:10] :) [21:12:24] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21485 [21:12:47] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21617 [21:13:06] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21659 [21:13:26] 03(mod) JavaScript not labeled as free - 10https://bugzilla.wikimedia.org/36866 +comment (10Krinkle) [21:13:55] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21674 [21:15:27] Change merged: Krinkle; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21677 [21:16:01] New review: Krinkle; "Thanks Hoo." [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/20470 [21:16:02] Change merged: Krinkle; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20470 [21:16:20] 14(DUP) Cannot cancel batch upload - 10https://bugzilla.wikimedia.org/39690 +comment (10Jon) [21:16:21] 03(mod) WLMMobile: 'cancel' during upload doesn't actually cancel the upload - 10https://bugzilla.wikimedia.org/38317 +comment (10Jon) [21:17:23] 03(mod) CentralNotice: decodeURIcomponent doesn't support bad unicode - 10https://bugzilla.wikimedia.org/33098 summary (10Krinkle) [21:17:40] New patchset: Siebrand; "Throw exception instead of fataling on OutputPage::setTitle()" [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/21832 [21:17:47] New patchset: Trevor Parscal; "Switched to using object access for database rows" [mediawiki/extensions/Drafts] (master) - https://gerrit.wikimedia.org/r/21833 [21:18:51] New patchset: Adamw; "order_id is pulled from the session when appropriate" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/21834 [21:19:20] 03(mod) Incomplete uploads listing sometimes doesn't show thumbnails - 10https://bugzilla.wikimedia.org/39717 +comment (10Jon) [21:19:59] New review: Krinkle; "So this means in case of the error/null value, the css string is not flipped. That's a problem." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21775 [21:20:13] 03(mod) Inconsistent state within the internal storage backends - 10https://bugzilla.wikimedia.org/39221 +comment (10Derk-Jan Hartman) [21:21:34] 03(mod) WikiEditor/modules/images/toolbar/example-image.png is missing - 10https://bugzilla.wikimedia.org/39029 (10Krinkle) [21:21:58] New patchset: Kaldari; "Addressing problems with jquery.badge mentioned at I0f5e7541" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20224 [21:23:40] New patchset: Hoo man; "Follow up to dirname( __FILE__ ) clean up" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21836 [21:23:44] New review: Catrope; "I have since discovered this is partly because of a bug in our PHP config, see also the Bugzilla tic..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21775 [21:24:59] New patchset: Bsitu; "Fix the cleanup cron" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/21837 [21:25:00] New patchset: Adamw; "(FR #595) Adyen payment gateway" [mediawiki/extensions/DonationInterface] (master) - https://gerrit.wikimedia.org/r/20467 [21:25:19] New patchset: Hoo man; "Follow up to dirname( __FILE__ ) clean up" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21836 [21:28:56] Change merged: Kaldari; [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/21837 [21:29:09] Okay [21:29:15] Someone pinged me? [21:30:02] T_T the implicit `git gc` isn't going to finish before I leave? [21:31:16] New patchset: Daniel Friesen; "Fix up the preferred way to specify mw.util.$content" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19008 [21:32:34] vvv, ;) you sure someone wasn't just debugging ssh? [21:32:36] 03(mod) Install Scribunto on fr.wikisource - 10https://bugzilla.wikimedia.org/39744 +comment (10Dereckson) [21:33:10] No [21:33:13] 'twas hoo [21:33:18] And Sumana [21:33:42] vvv: Yes [21:33:50] Oh well… time for the dentist [21:33:55] What's up? [21:34:13] https://gerrit.wikimedia.org/r/16922 [21:34:36] I thought about that again and I now think it might not be a good idea to completly block creations [21:34:53] there might be valid uses (users who already own other accounts by that name) [21:37:08] New patchset: Bsitu; "Update PageTriage to master" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21838 [21:37:51] 03(mod) Feedback Page on iPad - Hide My Post Flyout Stays Open - 10https://bugzilla.wikimedia.org/39750 normal->minor; +comment (10Dereckson) [21:38:45] Change merged: Bsitu; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21838 [21:40:32] 03(ASSIGNED) Uploading non-jpg files - 10https://bugzilla.wikimedia.org/39749 +comment (10Dereckson) [21:42:10] 03(mod) When a single file in a batch is invalid, only that file should be rejected - 10https://bugzilla.wikimedia.org/39608 (10Dereckson) [21:45:47] New patchset: TheDJ; "(bug 39029) Correct the path towards the extension directory by prefixing it with wgExtensionAssetsPath" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/17644 [21:46:17] New review: TheDJ; "done in patchset 2" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/17644 [21:47:12] 03(mod) Location where the photo was taken should be added to the upload - 10https://bugzilla.wikimedia.org/39745 +comment (10Jon) [21:48:25] New patchset: Hoo man; "Follow up to dirname( __FILE__ ) clean up" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21836 [21:48:59] New patchset: TheDJ; "(bug 39643) Allow "0" as the content of " [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) - https://gerrit.wikimedia.org/r/21473 [21:49:17] New review: TheDJ; "done in patch set 2" [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) - https://gerrit.wikimedia.org/r/21473 [21:53:59] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21836 [21:56:44] New patchset: Daniel Werner; "introduced a base for frontend representing constructors" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21840 [21:57:07] New review: Dereckson; "I'm in favour of the fix, as it solves a real bug." [mediawiki/extensions/SyntaxHighlight_GeSHi] (master) C: 1; - https://gerrit.wikimedia.org/r/21473 [21:59:18] New review: awjrichards; "Generally looks good except r908 comment suggests there should be ONE magic quotes check, and now th..." [wikimedia/wlm-api] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21830 [22:00:38] New review: Krinkle; "I agree, we should merge it. I'm looking ahead and thinking how to fix the inevitable bug report "co..." [mediawiki/core] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21775 [22:00:39] Change merged: Krinkle; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21775 [22:00:52] New patchset: Kaldari; "Addressing problems with jquery.badge mentioned at I0f5e7541" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20224 [22:02:09] New review: Tychay; "Someone else reviewed in addition to me, so I'm merging." [mediawiki/extensions/Echo] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/19223 [22:02:09] Change merged: Tychay; [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/19223 [22:02:25] marktraceur: what's the requirements for using batch uploading ? [22:04:17] thedj: Requirements in what sense? [22:06:22] well how do i do it. [22:06:23] 03(FIXED) Search broken when location present - 10https://bugzilla.wikimedia.org/39715 (10Arthur Richards) [22:06:40] i can only upload 1 file a time. which browsers allow me to upload a batch ? [22:06:48] New patchset: Trevor Parscal; "Cleaned up uses of jQuery to create and appendTo/prependTo" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21841 [22:06:58] as in, https://bugzilla.wikimedia.org/show_bug.cgi?id=39608 [22:07:33] 03(mod) Increase space between +- on map - 10https://bugzilla.wikimedia.org/39713 +comment (10Jon) [22:21:28] New review: MarkTraceur; "Looks OK, but I can't test it right now--this isn't a verification, but the code looks fine and accu..." [mediawiki/extensions/LiquidThreads] (master) C: 1; - https://gerrit.wikimedia.org/r/16908 [22:22:55] New review: MarkTraceur; "Looks OK, and I'm always in favor of fewer API requests where possible." [mediawiki/extensions/LiquidThreads] (master) C: 1; - https://gerrit.wikimedia.org/r/16907 [22:23:18] marktraceur: Where does "Traceur" come from? (Or where does Holmquist come from?) [22:23:36] 03(NEW) "Unresolved" filter for AFT5 feedback posts - 10https://bugzilla.wikimedia.org/39752 normal; MediaWiki extensions: ArticleFeedbackv5; (erik) [22:24:10] New patchset: Subramanya Sastry; "First pass RT-ing templates." [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21754 [22:25:26] Brooke: "traceur" is a term for "person who does Parkour", a group to which I belong occasionally [22:25:35] Brooke: "Holmquist" is my last name (not as interesting) [22:25:40] Ah, okay. :-) [22:25:57] https://en.wikipedia.org/wiki/Parkour [22:25:59] Got it. [22:26:26] thedj: You should be able to upload a batch with most browsers now.....Safari? [22:27:35] New review: Catrope; "@Krinkle per the other comments this is for authenticating to a 3rd-party service. Specifically, Ash..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/20013 [22:27:42] *nod* but Brooke, I wouldn't use that as the basis for your perception of me--I've been very lazy about running of late [22:27:56] marktraceur: you mean EFFICIENT? [22:28:02] 03(FIXED) "We just broke something we shouldn't have" message is shown for a wrong password - 10https://bugzilla.wikimedia.org/39638 +comment (10Jon) [22:28:09] the easiest place to get to is the place you already are, marktraceur [22:28:09] marktraceur: Is that a polite way of saying you're fat? [22:28:20] sumanah: OK, maybe something a little more abstract like that would work :P [22:28:21] Pfft [22:28:29] Mark is a skinny midwesterner [22:28:31] Wherever you go, there you are. [22:28:34] Brooke: I was going to say "no", but RoanKattouw got it [22:28:43] I'm a skinny midwesterner too! [22:28:43] 03(mod) Location where the photo was taken should be added to the upload - 10https://bugzilla.wikimedia.org/39745 (10Jon) [22:28:47] Sort of. [22:28:51] To the point where you suggesting he might be fat just makes me laugh [22:29:16] *nod* the walking in this city has certainly helped [22:29:32] Yeah I walk a lot more now that I live here [22:30:04] marktraceur: I liked http://blog.marktraceur.info/blog/2012/parkour-and-programming.html btw [22:30:34] 03(mod) Cannot cancel batch upload - 10https://bugzilla.wikimedia.org/39690 +comment (10Arthur Richards) [22:31:01] sumanah: The dying gasps of my blog run :P so much more to do [22:31:12] 03(mod) WLMMobile: 'cancel' during upload doesn't actually cancel the upload - 10https://bugzilla.wikimedia.org/38317 +comment (10Arthur Richards) [22:31:13] the life so short, the craft so long to learn (Chaucer?) [22:31:45] "The lyf so short, the craft so long to lerne." [22:31:54] Ah, middle english. [22:32:39] Funny story, http://en.wikipedia.org/wiki/Main_Page?uselang=enm does not work but http://en.wikipedia.org/wiki/Main_Page?uselang=ang does [22:32:47] (middle and old English respectively) [22:33:10] 03(mod) "Unresolved" filter for AFT5 feedback posts - 10https://bugzilla.wikimedia.org/39752 +comment (10Erik Moeller) [22:33:19] ah, ok https://en.wikisource.org/wiki/The_Parliament_of_Fowles [22:33:36] * marktraceur mumbles "Whan that Aprill with his shoures soote" [22:36:40] 03(mod) font-size of output too small - 10https://bugzilla.wikimedia.org/26204 +comment (10Krinkle) [22:37:09] New patchset: Siebrand; "Maintenance for CategoryTree extension" [mediawiki/extensions/CategoryTree] (master) - https://gerrit.wikimedia.org/r/21842 [22:40:05] New review: Kaldari; "If you remove all the files and get sent back to the upload step, the state of upload 0 is still set..." [mediawiki/extensions/UploadWizard] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/9549 [22:41:15] New patchset: Trevor Parscal; "Cleaned up uses of jQuery to create and appendTo/prependTo" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21841 [22:42:39] Change merged: Krinkle; [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/17683 [22:45:06] New patchset: MarkTraceur; "(bug 32247) Add "remove file" in the details step" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9549 [22:45:42] 03(FIXED) WLMMobile: Completed upload detail page should link to the picture - 10https://bugzilla.wikimedia.org/39624 (10Arthur Richards) [22:45:45] New patchset: Kaldari; "(bug 37468) Call the proper error-correcting methods" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/10995 [22:45:59] Change merged: Kaldari; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/10995 [22:54:51] New patchset: MaxSem; "r906-910" [wikimedia/wlm-api] (master) - https://gerrit.wikimedia.org/r/21830 [22:55:37] 03(mod) Slovakia no monuments styling - 10https://bugzilla.wikimedia.org/39720 +comment (10Jon) [22:56:04] chrismcmahon: saw your decline .... date doesn't work for you? [22:56:43] sumanah: I'll be on a plane to San Francisco Sept 10 [22:56:46] ok [22:56:48] bleh [22:56:59] chrismcmahon: we'll meet up Wed then [22:58:05] chrismcmahon: moved. thanks [22:58:21] sumanah: sorry, thank you [22:59:09] my mistake! [23:00:00] sumanah: I'm around in the morning, but will have to be at the airport mid-day [23:00:08] ok [23:01:09] New review: GWicke; "Great progress!! Rt'ing for unbalanced templates needs some tweaks (see inline comment), but this is..." [mediawiki/extensions/Parsoid] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21754 [23:01:09] Change merged: GWicke; [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21754 [23:02:42] vvv: if you have some time to look at Aaron P's watchlist stuff http://mw-watchlist.tumblr.com/ that'd be cool, as he wants feedback [23:05:05] 03(mod) Set "Add pages I edit to my watchlist" to true by default (for users who didn't set it explicitly) - 10https://bugzilla.wikimedia.org/36316 +comment (10Steven Walling) [23:06:04] 03(mod) Map view/list view and complete/incomplete toggles are not obvious - 10https://bugzilla.wikimedia.org/39718 normal->15enhancement; +comment (10Jon) [23:08:26] 03(mod) Set "E-mail me when a page or file on my watchlist is changed" (enotifwatchlistpages) to true by default for new users - 10https://bugzilla.wikimedia.org/38796 +comment (10Steven Walling) [23:08:54] 03(mod) Change "Return to Monument Detail" to "Take Another Photo" - 10https://bugzilla.wikimedia.org/39706 +comment (10Jon) [23:12:09] New patchset: Robmoen; "Added new mw message 'editpage-head-copy-warn' to EditPage header." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21826 [23:13:27] New review: Jeroen De Dauw; "To be honest I have no time to maintain this extension at present. I requested merge rights for you ..." [mediawiki/extensions/SemanticWatchlist] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21769 [23:14:08] New patchset: Eloquence; "Provide English as a description language if no templates are set up." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21845 [23:14:51] New review: Kaldari; "Still seeing some problems. First problem is that UploadWizardUpload::remove() doesn't seem to be de..." [mediawiki/extensions/UploadWizard] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/9549 [23:15:06] 03(mod) Change "Return to Monument Detail" to "Take Another Photo" - 10https://bugzilla.wikimedia.org/39706 +comment (10Jon) [23:16:29] New review: MarkTraceur; "Short, sweet, to the point." [mediawiki/extensions/UploadWizard] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21845 [23:16:29] Change merged: MarkTraceur; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21845 [23:20:14] 03(FIXED) Post essex-update, /home is not linked properly. - 10https://bugzilla.wikimedia.org/39741 +comment (10Ryan Lane) [23:21:26] New patchset: Kghbln; "additions and changes" [mediawiki/extensions/SemanticBundle] (master) - https://gerrit.wikimedia.org/r/21847 [23:24:28] 03(FIXED) Increase space between +- on map - 10https://bugzilla.wikimedia.org/39713 (10Jon) [23:28:58] 03(FIXED) Change "Return to Monument Detail" to "Take Another Photo" - 10https://bugzilla.wikimedia.org/39706 (10Jon) [23:29:01] 03(mod) Format author field as [[user:|]] instead of just [[user:]] - 10https://bugzilla.wikimedia.org/39743 +comment (10Jon) [23:29:28] 03(FIXED) Slovakia no monuments styling - 10https://bugzilla.wikimedia.org/39720 (10Jon) [23:30:56] 03(FIXED) Format author field as [[user:|]] instead of just [[user:]] - 10https://bugzilla.wikimedia.org/39743 +comment (10Patrick Reilly) [23:34:32] New patchset: Kghbln; "additions and changes" [mediawiki/extensions/SemanticBundle] (master) - https://gerrit.wikimedia.org/r/21847 [23:34:51] RoanKattouw: are you already following this? http://www.neverworkintheory.org/ [23:34:58] 03(mod) UploadWizard does not handle 'duplicate-archive' errors correctly - 10https://bugzilla.wikimedia.org/30625 +comment (10Erik Moeller) [23:35:23] TimStarling, robla, I suspect you are in the target audience for http://www.neverworkintheory.org/ as well [23:36:24] paulproteuss: ^ you, too [23:36:26] 03(mod) Using a post-1.14 image link ([[File:foo|link=bar]]) doesn't add nofollow to external links - 10https://bugzilla.wikimedia.org/24437 +comment (10Chris Steipp) [23:36:51] 03(mod) Using a post-1.14 image link ([[File:foo|link=bar]]) doesn't add nofollow to external links - 10https://bugzilla.wikimedia.org/24437 +comment (10Chris Steipp) [23:36:58] New patchset: Kaldari; "(bug 39553) Comment all altitude elements from UW for now." [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21404 [23:37:13] Change merged: Kaldari; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21404 [23:37:21] * robla adds to feed reader [23:38:10] marktraceur: Tim and RobLa are people whom I successfully got to check out another project by one of those bloggers, Greg Wilson. There's a video of him talking about what *actually works* in software dev (evidence! the audacity!) http://vimeo.com/9270320 [23:38:43] marktraceur: I haven't watched that video yet. [23:38:48] New patchset: Kghbln; "additions and changes" [mediawiki/extensions/SemanticBundle] (master) - https://gerrit.wikimedia.org/r/21847 [23:39:06] marktraceur: the book is http://www.aosabook.org/en/makingsoftware.html and I think there's a copy in the WMF library [23:39:20] I presume they are related (book & video) [23:39:56] marktraceur: another of Greg Wilson's projects: http://software-carpentry.org/ [23:40:04] (the book was in my bag this morning when I spilled coffee all over it) :-( [23:40:04] can you tell this person is a hero to me :) [23:40:11] robla: NOOOOOO [23:41:29] New review: Kghbln; "This is the first time I added i18n. Basically I was imitating what I saw coded in other extensions...." [mediawiki/extensions/SemanticBundle] (master) C: 1; - https://gerrit.wikimedia.org/r/21847 [23:42:06] it's not ruined [23:42:25] I didn't spill coffee *all* over it, but it's not ... pristine anymore [23:42:53] it has character now :) [23:43:22] 03(mod) Ajax loader icon overlaps text - 10https://bugzilla.wikimedia.org/39692 +comment (10Jon) [23:43:44] sumanah: I just ran across Wilson via Michael Feathers on Twitter, interesting stuff. His description of scientific architecture smells a lot like QA done right. [23:44:02] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 +comment (10Tim Starling) [23:44:05] robla: :) I'm happy with character [23:45:07] chrismcmahon: I'm particularly happy that he's wholeheartedly into roles that traditionally get so little status: teaching, curating, documenting, best-practice-sharing [23:51:51] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21826 [23:52:09] New patchset: Kghbln; "additions and changes" [mediawiki/extensions/SemanticBundle] (master) - https://gerrit.wikimedia.org/r/21847 [23:53:27] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21688 [23:54:29] New patchset: RobLa; "Added --git-root option so that local bare repo can be used" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/21849