[00:01:50] New patchset: Aaron Schulz; "[JobQueue] Job queue refactoring and generalizing." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/13194 [00:03:05] New review: Aaron Schulz; "* Fixed job_sha1 base to fit into the field" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/13194 [00:10:47] New patchset: Aaron Schulz; "[FileBackend] Added preloadCache() so callers can trigger cache getMulti()." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21312 [00:13:58] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21312 [00:15:24] Change merged: Kaldari; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21211 [00:16:14] 03(FIXED) file upload error messages don't work sanely - 10https://bugzilla.wikimedia.org/32469 +comment (10Ryan Kaldari) [00:22:01] New patchset: Aaron Schulz; "[JobQueue] Job queue refactoring and generalizing." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/13194 [00:25:50] New review: Aaron Schulz; "Rebased." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/13194 [00:27:04] wiki.movim.eu has removed the mediawiki logo from their skin. [00:28:16] oh, it's dokuwiki. Hrm. [00:28:46] 03(FIXED) Ajax loader icon overlaps text - 10https://bugzilla.wikimedia.org/39692 +comment (10Brion Vibber) [00:36:34] 03(NEW) VisualEditor: UI restores #toc as inline-block instead of block. - 10https://bugzilla.wikimedia.org/39753 normal; VisualEditor: User Interface; (krinklemail) [00:36:47] New patchset: RobLa; "Correcting 1.18 and 1.19 tarball extension lists" [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/21851 [00:47:07] 03(mod) Add jQuery.hotkeys plugin for hooking keyboard events - 10https://bugzilla.wikimedia.org/27493 (10mybugs.mail) [01:04:22] 03(NEW) Feedback Page on iPad - Hide My Post Flyout Issues - 10https://bugzilla.wikimedia.org/39754 normal; MediaWiki extensions: ArticleFeedbackv5; (fflorin) [01:04:44] 03(mod) Feedback Page on iPad - Hide My Post Flyout Issues - 10https://bugzilla.wikimedia.org/39754 (10Fabrice Florin) [01:07:28] 03(mod) Feedback Page on iPad - Hide My Post Flyout Issues - 10https://bugzilla.wikimedia.org/39754 +comment (10Fabrice Florin) [01:09:37] "I unfortunately practice defensive coding. When I write a change I usually include pointless configs to fall back to the old behaviour, alternatives to keep the useless old functionality around, etc… to avoid people complaining about a new feature." [01:10:21] Change abandoned: Ori.livneh; "Agree w/Krinkle -- mw.notification seems like the direction forward." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/13366 [01:13:25] New patchset: Daniel Friesen; "Fix up the preferred way to specify mw.util.$content" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19008 [01:22:10] Gerrit+Jenkins, my great enemy!!! [01:22:41] New review: Helder.wiki; "You may (or may not) want to keep an eye on the repercution of the change on enwiki:" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17605 [01:23:33] Anyone want to tell me why Jenkins is now randomly failing my commit? [01:26:23] 03(mod) Admin levels empty due to no campaign information (e.g. license) - 10https://bugzilla.wikimedia.org/39568 +comment (10Arthur Richards) [01:27:31] 03(mod) Add jQuery.hotkeys plugin for hooking keyboard events - 10https://bugzilla.wikimedia.org/27493 +comment (10Krinkle) [01:34:11] Dantman: link? [01:34:25] Link? [01:34:36] " Jenkins is now randomly failing my commit?" [01:34:40] Ah [01:34:52] https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/4377/console [01:34:56] Krinkle, https://gerrit.wikimedia.org/r/#/c/19008/3 [01:34:57] There is no such thing as random [01:35:26] Merge conflict [01:35:27] There is a link in the gerrit comment, for info on why it failed and where [01:35:51] It didn't even start the unit tests, because of the merge conflict. [01:36:38] It tests the state as it would be after merging in the target branch (e.g. master), not the state as it is in the review branch. That way it is more accurate. [01:36:46] *facepalm* That completely cryptic result comes from merge conflicts [01:36:57] I guess :) [01:37:41] Fine, I'll rebase after I eat [01:37:59] Jenkins should really be smarter than this [01:38:29] Change merged: awjrichards; [wikimedia/wlm-api] (master) - https://gerrit.wikimedia.org/r/21830 [01:38:50] "-1 Unit tests not run due to merge conflict. Please rebase and resolve the conflicts." [01:47:36] 03(mod) Incomplete uploads listing sometimes doesn't show thumbnails - 10https://bugzilla.wikimedia.org/39717 +comment (10Brion Vibber) [01:51:01] New patchset: Robmoen; "Move copyright warning under the edit summary input box." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21852 [01:58:29] Krinkle, we should experiment with using jquery.animate-enhanced [02:03:58] Dantman: I'm not so sure [02:04:23] Dantman: jQuery has tried twice and aborted close for release because request animation frame wasn't reliable or performant enough [02:04:54] Not requestAnimationFrame, css3 transitions. [02:04:56] On this box they're taking up to 20-30 seconds. [02:05:04] Completely hardware accelerated. [02:05:26] Dantman: Yes, and how does it get a callback? [02:07:11] New patchset: Robmoen; "Move copyright warning to directly above buttons." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21852 [02:07:15] Krinkle, I know, it's completely confusing… But css3-transitions, a css spec, defines a transitionend DOM event ;) http://www.w3.org/TR/css3-transitions/#transition-events [02:07:27] I know [02:08:03] They used that too at some point. [02:08:15] Anyway, I think if it is stable enough it will be in jQuery 1.9 [02:09:01] if not, why would we use it? jQuery (and imho therefor us) should only use it if it is stable enough and actually performs better than the manual property fiddling (if it requires lots of javascript overhead to accomplish it isn't worth it). [02:09:19] and if that is the care, jquery will use it in core. [02:09:21] case* [02:09:36] or is that a paradox? [02:10:33] Ok… So our "My animations are slow" solution is "Cross your fingers and wait for jQuery to add hardware accelerated animations." [02:10:36] ? [02:10:55] Yes, they're aware of it and have actively tried to implement it to a very high level [02:10:56] twice [02:11:15] and both times aborted it because of blocking problems, I don't recall what they were (ask in #jquery-dev if you're interested) [02:12:11] I'm confident that they'll implement and ship support as soon as they believe it is stable and performs better. [02:12:33] I'll pass… I still have some negative sarcasm on the topic pent up… [02:13:02] And there seems to be a few open issues (though jquery's core implementation may not be perfect either) [02:13:06] https://github.com/benbarnett/jQuery-Animate-Enhanced/issues/61 [02:13:12] https://github.com/benbarnett/jQuery-Animate-Enhanced/issues/5 [02:13:18] those two in particular. [02:13:51] since it messes with the base .animate() we need to support not just what we consciously use it for but any plugin used in core, extensions and gadgets anywhere. [02:14:54] but yes, lets experiment with it by keeping an eye out for it (/me stars it on github) [02:16:18] Dantman: also $.fn.animate (and underlaying $.Animation constructor) have been fully rewritten in jQuery 1.8.0 with several performance improvements [02:16:23] https://gist.github.com/54829d408993526fe475 [02:16:31] http://blog.jquery.com/2012/08/09/jquery-1-8-released/ http://jsbin.com/odocid/1/edit [02:24:28] 03(mod) Inconsistent state within the internal storage backends - 10https://bugzilla.wikimedia.org/39221 major->04CRIT (10Fastily) [02:30:40] 03(mod) Need a way back when trying to upload a file in UploadWizard that already exists - 10https://bugzilla.wikimedia.org/29594 +comment (10Robin Pepermans (SPQRobin)) [02:31:03] 04(REOPENED) Need a way back when trying to upload a file in UploadWizard that already exists - 10https://bugzilla.wikimedia.org/29594 (10Robin Pepermans (SPQRobin)) [02:35:51] New patchset: Daniel Friesen; "[mw.notification] Introduce a full fledged notification system into core replacing jsMessage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19199 [02:35:51] New patchset: Daniel Friesen; "Fix up the preferred way to specify mw.util.$content" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19008 [02:38:28] 03(NEW) blog post says "3 responses", but none or fewer are shown - 10https://bugzilla.wikimedia.org/39755 minor; Wikimedia: Blog; (spage) [02:43:19] New patchset: Mwjames; "SRF srf.util.uri, outsource methods and minimze redundand code" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21853 [02:46:16] Is it possible to use CSS3 in Mediawiki? [02:51:24] New patchset: Subramanya Sastry; "Improvements to wikitest escaping + accompanying tests." [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21854 [02:52:05] dka: Yes, just use it. [02:52:28] Krinkle: any examples? [02:52:43] dka: What do you mean? CSS3 is just like any other CSS. [02:52:56] how have you tried? [02:53:04] So everything should work? animations and all? [02:53:12] No, I haven't. [02:53:20] yep, MediaWiki isn't a browser, it just serves what you give it. [02:53:30] Will work just fine :) [02:53:44] New review: Mwjames; "Well, it does what it says and if no one objects I'll merge it within the two days." [mediawiki/extensions/SemanticResultFormats] (master); V: 1 C: 1; - https://gerrit.wikimedia.org/r/21853 [02:53:54] There's a fair among of CSS3 being used by MediaWiki core as well (few gradients and shadows) [02:54:01] amount* [02:54:13] and the sidebar has a @media responsive transition animation [02:55:01] Krinkle: Good to know. I asked because HTML is limited in mediawiki. [02:55:26] Nothing insane :) [02:55:45] Anything that MediaWiki limits probably doesn't belong in a page anyway, but in a javascript module or extension. [02:56:25] Krinkle: do you know any mediawiki pages that feature CSS thoroughly? any original user pages or project pages? [02:56:47] https://www.mediawiki.org/wiki/Berlin_Hackathon_2012 [02:57:13] I didn't know you meant wiki pages though, I thought you meant from a developer point of view [02:57:17] but yeah wiki pages work too [02:57:35] oh! yes I meant Wiki [02:58:08] Krinkle: yeah, that's a nice example [02:59:53] New patchset: Mwjames; "SRF srf.util.uri, outsource methods and minimize redundand code" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21853 [03:03:31] Krinkle: unrelated question: When can we expect wikidata to be usable? [03:03:45] don't know, 1 year? [03:03:49] Krinkle: oh, and will it contain only data, or templates as well? [03:04:06] it will not contain templates, certainly not at first [03:04:17] personally I think it shouldn't contain interwiki links either, but that's another debate [03:05:04] 03(mod) jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements - 10https://bugzilla.wikimedia.org/34876 +comment (10Isarra) [03:19:38] I'm trying to get solr running but i keep getting this error [03:19:39] Error occurred during initialization of VM [03:19:39] Could not reserve enough space for object heap [03:19:39] Error: Could not create the Java Virtual Machine. [03:19:39] Error: A fatal exception has occurred. Program will exit. [03:19:50] aynone deal with this before? [03:34:01] 03(mod) Selecting photo from picasa in my gallery causes app to crash - 10https://bugzilla.wikimedia.org/39604 summary; +comment (10Brion Vibber) [03:36:24] Um, you guys hate distro-specific stuff and don't help with anything but stuff installed from source, right? [03:36:53] I was just wondering if anyone knew if an upgrade from Ubuntu 10.04 LTS to 12.04 LTS would go smoothly with regards to Mediawiki... [03:37:14] Hate is a strong word. [03:37:20] The distros have a tendency to move shit around carelessly. [03:37:32] Or move shit around at all. And that can make life more difficult. [03:37:58] 03(NEW) CSV log processing garbled on page names with '@' - 10https://bugzilla.wikimedia.org/39756 normal; MediaWiki extensions: E3 Experiments; (spage) [03:38:22] Yeah, it's a pain for people who expect things to be a certain place (and code that expects it). [03:38:38] at a* [03:39:20] …that's basic programming fact [03:39:33] spade: Our usual suggestion is to switch over to using our install methods....but I'd imagine that you could switch between the two methods relatively easily. Could be wrong [03:39:59] If you put something somewhere and release it that way. Then someone goes and moves it. You expect it to break. [03:40:33] Move meaning separating internal parts of the code from each other. [03:41:12] Web applications are not designed to be treated as system libraries. [03:42:06] This upgrade will be painful no matter what, I suspect... [03:42:09] Which is basically what package managers attempt to do. All while ignoring the fact that when they do that they still gain none of the advantages of system libraries. [03:42:20] You're not Sam Spade, right? [03:42:31] no [03:42:35] Lame. [03:42:54] that guy's been taking my nick sometimes [03:43:07] at least someone with that in his info [03:43:21] https://en.wikipedia.org/wiki/User:Sam_Spade is the one I was thinking of. [03:43:56] Aaahh… my back… right shoulder... [03:44:22] Your autocorrect is a bit irksome. [03:44:37] There's no off switch? [03:44:58] Y u no like unicode? [03:45:20] It's actually the mix that's killing me. [03:45:31] I guess it doesn't auto-correct until there's a space or something? [03:45:42] Not sure [03:45:43] So the trailing periods don't get transformed, while the middle ones do. [03:46:08] There's no off switch in X-Chat Auqa itself... [03:46:10] Hmmm [03:46:17] Let's see. [03:46:25] Some text… then text. [03:46:40] Some text then ellipsis... [03:46:59] Some text ellipsis then a space… [03:47:06] Right. [03:47:19] 03(NEW) change Default CC for E3Extension - 10https://bugzilla.wikimedia.org/39757 normal; Wikimedia: Bugzilla; (spage) [03:47:35] Yup… I bet this isn't part of my IRC client but instead is a function of OS X's built in spellchecker. [03:47:43] Which Aqua happens to use [03:47:59] If it's OS-level, it can definitely be disabled. [03:48:03] Even on a per-input basis, I think. [03:50:10] So it can... [03:50:25] Too bad, I wish it would have worked universally. [03:54:04] 03(mod) the star marker overlaps with the word "FEATURED" in an RTL environment - 10https://bugzilla.wikimedia.org/36327 +comment (10Amir E. Aharoni) [03:55:40] 03(FIXED) thumbs near the words "Yes" and "No" are on the same side of the words in LTR and RTL - 10https://bugzilla.wikimedia.org/36324 (10Amir E. Aharoni) [03:57:14] Dantman: It can be done universally as well, I imagine. Probably in System Preferences under Keyboard. [03:57:25] Well no [03:57:47] I mean I wish that it would apply it to ... at the end of the sentence without a space too. [03:57:54] Oh. [03:58:08] Delimiters are cruel and fickle at times. [03:58:22] Unicode FTW! [03:58:33] 03(mod) Selecting photo from picasa in my gallery causes app to crash - 10https://bugzilla.wikimedia.org/39604 +comment (10Brion Vibber) [03:59:21] New review: Amire80; "Bug 36327 may be related." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21775 [04:05:57] 03(mod) Selecting photo from picasa in my gallery causes app to crash - 10https://bugzilla.wikimedia.org/39604 +comment (10Brion Vibber) [04:26:45] New patchset: Mwjames; "Add various messages" [mediawiki/extensions/SemanticResultFormats] (master) - https://gerrit.wikimedia.org/r/21855 [04:56:09] T_T nooo... we dropped parseHtml [04:56:27] I mean, we dropped jquery-1.8.js [05:19:22] New review: Madman; "Siebrand: It may be because it's 1 a.m. (also, noob), but I'm not sure which array you mean in messa..." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/21598 [05:39:41] I'm sure you'll all be excited to hear that Ubuntu 12.04.1 uses Mediawiki 1.15.5-7. Isn't the latest 1.19? [05:59:22] !packages | spade [05:59:22] spade: Many Linux distributions provide MediaWiki in a packaged format for that distribution. These packages typically contain obsolete and unsupported versions of MediaWiki, also they like to move around files, change the files, and do other batshit insane things. You'll get the best support here if you install MediaWiki directly from one of our tarballs, available at http://www.mediawiki.org/ [06:01:54] spade, You know... what is REALLY amazing... is Debian actually upgraded MediaWiki in wheezy... http://packages.debian.org/wheezy/mediawiki ;) it only took them ~2 years [06:03:13] It would be possible to have the latest Mediawiki in Debian or Ubuntu, if someone does the packaging work. There is backports.debian.org. [06:08:05] New patchset: Santhosh; "Updated webfonts example" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21857 [06:08:45] Change merged: Santhosh; [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21857 [06:43:00] New review: Siebrand; "You've already added to messages.inc, but empty messages like the one you add in this patch set need..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21598 [06:49:11] New review: TheDJ; "This is not just this message. It's half the WikiEditor messages that have this problem." [mediawiki/extensions/WikiEditor] (master) C: 0; - https://gerrit.wikimedia.org/r/17644 [06:50:45] New review: Siebrand; "Just a remark... This is tagged as a micro desk improvement, but I fail to see how an addition of op..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21826 [06:51:05] New review: Siebrand; "Desk should be design :)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21826 [06:53:12] New review: Siebrand; "Those are not changing, this one is." [mediawiki/extensions/WikiEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/17644 [06:59:48] 03(NEW) Request for unblocking IP address block for a wikipedia club - 10https://bugzilla.wikimedia.org/39758 major; Wikimedia: Site configuration; (psubhashish) [07:13:47] 04(REOPENED) Picture doesn't appear any longer - 10https://bugzilla.wikimedia.org/36810 +comment (10Fiable.biz) [07:15:32] New patchset: Henning Snater; "disabling tagadata widget when saving" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21858 [07:19:59] 03(FIXED) change Default CC for E3Extension - 10https://bugzilla.wikimedia.org/39757 normal->15enhancement; +comment (10Thehelpfulone) [07:22:55] New review: John Erling Blad; "Conflicts during rebase" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21610 [07:24:50] New review: John Erling Blad; "Mark it as [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/21684 [07:28:30] 03(mod) Picture doesn't appear any longer - 10https://bugzilla.wikimedia.org/36810 +comment (10Fiable.biz) [07:29:13] New review: Siebrand; "i18n/L10n is all okay." [mediawiki/extensions/CentralAuth] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/17072 [07:32:16] guys, is it normal that codes such as [[File:Adamrise.jpg|]] work on wmf sites? [07:32:54] i smell abuse :) [07:33:01] New patchset: Raimond Spekking; "Register extension SiteMetrics" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21859 [07:33:35] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21859 [07:34:44] 03(FIXED) Database error on de.wikipedia.beta.wmflabs.org (user contributions) - 10https://bugzilla.wikimedia.org/39730 (10Peter Bena) [07:38:06] 14(INVALID) Request for unblocking IP address block for a wikipedia club - 10https://bugzilla.wikimedia.org/39758 +comment (10Peter Bena) [07:39:36] anyone? [07:43:20] New patchset: Raimond Spekking; "Use standard description message key" [mediawiki/extensions/Phalanx] (master) - https://gerrit.wikimedia.org/r/21801 [07:44:18] New review: Kghbln; "Patch Set 5 soon to be committed." [mediawiki/extensions/SemanticBundle] (master) C: 0; - https://gerrit.wikimedia.org/r/21847 [07:44:39] 03(NEW) phase out deployment-backup - 10https://bugzilla.wikimedia.org/39759 normal; Wikimedia Labs: deployment-prep (beta); (hashar) [07:44:40] 03(NEW) "Translation page template" is a confusing term - 10https://bugzilla.wikimedia.org/39760 enhancement; MediaWiki extensions: Translate; (federicoleva) [07:50:44] New patchset: Nikerabbit; "Fixed fallback behaviour for plural rules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21699 [07:50:47] Vito-Genovese, work? [07:51:07] the external image is displayed successfully [07:51:40] there is no Adamrise.jpg [07:52:28] Dantman: is that normal? [07:52:42] in order to get this on my site, do I just need to export the XML and import it on my site? I can't figure out how templates work. http://www.mediawiki.org/wiki/Template:Databox-layout [07:53:21] New review: Nikerabbit; "Added test cases" [mediawiki/core] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21699 [07:53:47] New patchset: John Erling Blad; "Renaming of wikibase.ui.PropertyEditTool.EditableValue.SiteidInterface.tests.js" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21860 [07:54:18] New patchset: Kghbln; "additions and changes" [mediawiki/extensions/SemanticBundle] (master) - https://gerrit.wikimedia.org/r/21847 [07:55:15] 03(mod) Request for unblocking IP address block for a wikipedia club - 10https://bugzilla.wikimedia.org/39758 +comment (10Subhashish Panigrahi (ସୁଭ ପା)) [07:56:04] Hmmm... you're right [07:56:47] New patchset: Nikerabbit; "Fix the incorrect nesting" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21861 [07:57:58] New patchset: Nikerabbit; "Fixed fallback behaviour for plural rules" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21699 [07:59:00] New review: Hashar; "I need to review the API test again and find out how we currently manage to get the normal/sysop ses..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/14305 [07:59:34] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21860 [07:59:47] 03(WONTFIX) Picture doesn't appear any longer - 10https://bugzilla.wikimedia.org/36810 +comment (10Kipmaster) [08:02:36] 03(mod) Request for unblocking IP address block for a wikipedia club - 10https://bugzilla.wikimedia.org/39758 +comment (10Peter Bena) [08:03:51] 03(mod) Picture doesn't appear any longer - 10https://bugzilla.wikimedia.org/36810 (10Kipmaster) [08:04:01] New review: TheDJ; "Well i'm not doing it, so if someone else wants to spend his time on solving that issue, then he's w..." [mediawiki/extensions/WikiEditor] (master) C: 0; - https://gerrit.wikimedia.org/r/17644 [08:06:17] 03(mod) "Translation page template" is a confusing term - 10https://bugzilla.wikimedia.org/39760 +comment (10Niklas Laxström) [08:11:09] 03(NEW) Special:TranslationStats counts for edits includes also reviews - 10https://bugzilla.wikimedia.org/39761 normal; MediaWiki extensions: Translate; (federicoleva) [08:15:18] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21858 [08:23:05] 03(ASSIGNED) Tooltip not closing when pressing ESC while adding new sitelink - 10https://bugzilla.wikimedia.org/39729 summary (10Henning (WMDE)) [08:25:06] 03(mod) "Translation page template" is a confusing term - 10https://bugzilla.wikimedia.org/39760 +comment (10Nemo_bis) [08:25:11] 03(mod) https://planet.wikimedia.org goes to civiCRM instance. - 10https://bugzilla.wikimedia.org/39678 +comment (10Derk-Jan Hartman) [08:42:18] can anyone with mad javascript skillz please help me out getting this button to work in wikieditor: http://dpaste.com/793008/ [08:42:37] New patchset: Henning Snater; "39729: closing tooltip when pressing ESC while adding a site link" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21862 [08:45:41] 03(mod) "Translation page template" is a confusing term - 10https://bugzilla.wikimedia.org/39760 +comment (10Siebrand) [09:04:06] New patchset: John Erling Blad; "(Bug 37685) Initial commit for checking edit conflicts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [09:04:36] New patchset: John Erling Blad; "(Bug 37685) Initial commit for checking edit conflicts" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/20679 [09:09:57] New patchset: Santhosh; "Use jquery.jStorage for saving preferences of anonymous users" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21864 [09:12:07] New patchset: Hashar; "(bug 34787) Sanity check fix for UserLoadAfterLoadFromSession" [mediawiki/extensions/LdapAuthentication] (master) - https://gerrit.wikimedia.org/r/21309 [09:12:36] New review: Hashar; "- rewrote commit message to include bug summary" [mediawiki/extensions/LdapAuthentication] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21309 [09:16:38] New review: Hashar; "Good to me, mailing Ryan as a remember." [mediawiki/extensions/LdapAuthentication] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21309 [09:16:39] how can I change my full name on Gerrit? [09:16:57] I did that on labs but it looks it won't get changed on Gerrit! :( [09:20:00] Hello. [09:20:24] 03(FIXED) Feedback page - Hide my post - 10https://bugzilla.wikimedia.org/38817 (10Matthias Mullie) [09:20:44] anyone?! [09:21:02] koosha: ask ^demon, Ryan_Lane or roan_kattouw [09:21:18] This currently requires admin permission on Gerrit. [09:21:25] 03(FIXED) Restrict feedback posts for protected or semi-protected articles - 10https://bugzilla.wikimedia.org/39448 +comment (10Matthias Mullie) [09:21:31] absurd! [09:21:34] 03(FIXED) Protect articles to limit feedback on protected or semi-protected articles - 10https://bugzilla.wikimedia.org/39451 (10Matthias Mullie) [09:21:41] I wonder too if we shouldn't fill a bug upstream asking this field is settable by user. [09:21:56] I don't know if it's absurd but it's a strange choice. [09:21:57] 03(FIXED) Article Feedback - Supporting feedback on help pages - 10https://bugzilla.wikimedia.org/36772 (10Matthias Mullie) [09:22:09] 03(FIXED) Article Feedback - Feedback from my watched pages - 10https://bugzilla.wikimedia.org/38628 (10Matthias Mullie) [09:22:17] I made the text field writable on client-side, but it doesn't work! :) [09:22:19] 03(FIXED) Article feedback page: Drop-down menus need to be better aligned with title bar - 10https://bugzilla.wikimedia.org/39356 (10Matthias Mullie) [09:23:08] 03(FIXED) Change the "what's this?" link - 10https://bugzilla.wikimedia.org/38483 (10Matthias Mullie) [09:23:15] 03(FIXED) New CTA6 for Teahouse - 10https://bugzilla.wikimedia.org/39401 (10Matthias Mullie) [09:23:54] 03(FIXED) Feedback Page - Relevance Score Update - 10https://bugzilla.wikimedia.org/38821 (10Matthias Mullie) [09:26:09] 03(FIXED) anonymous actions being identified as coming from the feedback tool - 10https://bugzilla.wikimedia.org/38475 (10Matthias Mullie) [09:26:17] 03(FIXED) "Show more activity" link does not work - 10https://bugzilla.wikimedia.org/38688 (10Matthias Mullie) [09:26:46] 03(mod) Enable AFTv5 on iPhone - 10https://bugzilla.wikimedia.org/39372 summary (10Matthias Mullie) [09:27:32] 03(mod) Enable AFTv5 on iPhone - 10https://bugzilla.wikimedia.org/39372 +comment (10Matthias Mullie) [09:32:57] 03(mod) individual feedback page renders then disappears - 10https://bugzilla.wikimedia.org/39355 +comment (10Matthias Mullie) [09:38:42] 03(FIXED) Fonts smaller than normal - 10https://bugzilla.wikimedia.org/39618 +i18n; +comment (10Santhosh Thottingal) [09:50:58] Hi.. I've been using recaptcha for user authentication but the last few weeks it seems this is basically useless.. i'm having a couple dozen accounts spam my Wiki every day now, it's too much for me and the couple other admins to keep up with [09:51:08] so I need some tougher anti-spam strategies [09:53:52] New review: Henning Snater; "You changed "wikibase" and "window.wikibase" doxygen comments to "wb" in some files only. This shoul..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21840 [09:55:27] New review: Tobias Gritschacher; "There seems to be a problem with description and empty aliases:" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/20679 [10:01:01] New patchset: Daniel Kinzler; "merged master" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21866 [10:01:01] New patchset: Daniel Kinzler; "clear magicword cache before testing cleanSig" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21867 [10:02:08] New review: Tobias Gritschacher; "btw.: selenium tests are passing. great job! ;)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21840 [10:02:17] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21597 [10:02:17] New review: Nikerabbit; "Breaks language selection for anonymous users." [mediawiki/extensions/UniversalLanguageSelector] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/21864 [10:02:18] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21597 [10:02:26] New review: Daniel Kinzler; "self-review for merge into dev branch" [mediawiki/core] (Wikidata); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21662 [10:02:27] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21662 [10:02:41] 03(mod) Fonts smaller than normal - 10https://bugzilla.wikimedia.org/39618 +comment (10Siebrand) [10:07:10] New patchset: Daniel Kinzler; "merged master" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21866 [10:14:58] can anyone pls help me fixing the MHTML extension button to work with wikieditor pls? ive tried the easy way by krinkle, unsuccessful ;( http://dpaste.com/793008/ [10:15:16] New patchset: Daniel Kinzler; "clear magicword cache before testing cleanSig" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21867 [10:16:11] 03(mod) Inconsistent behavior of enter key in site-link UI - 10https://bugzilla.wikimedia.org/39318 (10Lydia Pintscher) [10:16:40] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21862 [10:21:20] I want to set my full name on Gerrit. Please sb help me [10:22:27] New patchset: Matthias Mullie; "remove AFTv4 leftover code" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21869 [10:23:14] New patchset: Matthias Mullie; "remove AFTv4 leftover code" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21869 [10:25:53] hashar: is jenkins broken again? i'm getting strange failures [10:26:02] DanielK_away: link ? :-) [10:26:22] hashar: https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/4387/ [10:26:56] can i somehow bapass jenkins on the broken changes? i need to merge these, otherwise things diverge even further [10:27:14] hmm [10:27:48] DanielK_away: if that is on the wikidata branch, go ahead [10:27:54] you have to remove Jenkins as a reviewer [10:28:06] yea. removed jenkins as a reviewer from that change [10:28:12] thanks [10:28:18] any idea what went wrong, though? [10:28:26] not sure [10:28:30] apparently a filesystem issue [10:28:36] New review: Daniel Kinzler; "self-review of merge of latest master" [mediawiki/core] (Wikidata); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21866 [10:28:36] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21866 [10:28:40] or maybe some paths are incorrects [10:28:43] 10:07:59 [exec] PHP Warning: DOMDocument::load(): I/O warning : failed to load external entity "/var/lib/jenkins/jobs/MediaWiki-GIT-Fetching/workspace/languages/data/plurals.xml" in /var/lib/jenkins/jobs/MediaWiki-GIT-Fetching/workspace/includes/LocalisationCache.php on line 539 [10:28:44] this stuff seems rather brittle :/ [10:28:52] might be the stupid l10n cache which has trouble [10:29:30] New review: Daniel Kinzler; "self-review of test fix for wikidata" [mediawiki/core] (Wikidata); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21867 [10:29:31] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21867 [10:30:03] https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Dumps/3928/console [10:30:09] that one is missing languages/data/plurals.xml [10:30:23] triggered by https://gerrit.wikimedia.org/r/21866 [10:30:35] apparently the merge is not complete [10:30:52] DanielK_away: just merge what you need, and make sure tests still somehow work [10:30:59] will give a look at it this afternoon [10:31:09] I guess some commits were not merged in [10:32:11] like bbbcf08 / I58a9cdfe60c7b9027bf031c91370472054f04ae2 [10:32:12] !g I58a9cdfe60c7b9027bf031c91370472054f04ae2 [10:32:12] https://gerrit.wikimedia.org/r/#q,I58a9cdfe60c7b9027bf031c91370472054f04ae2,n,z [10:32:29] New patchset: Daniel Kinzler; "clear magicword cache before testing cleanSig" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21870 [10:32:57] DanielK_away: I am heading lunch [10:33:03] maybe we should disable the l10n cache [10:33:06] not sure [10:33:20] wouldn't that make the tests even slower? [10:33:56] most probably :( [10:34:07] btw, i saw tests failing earlier because CLDRPluralRuleEvaluator.php was missing [10:34:15] may be related to what you mentioned above? [10:34:26] yeah most probably [10:35:30] lunch,brb [10:35:47] 04(REOPENED) Add jStorage as ResourceLoader module to MediaWiki core - 10https://bugzilla.wikimedia.org/35073 +comment (10Rainer@Rillke.eu) [10:38:08] 03(FIXED) Add jStorage as ResourceLoader module to MediaWiki core - 10https://bugzilla.wikimedia.org/35073 +comment (10Rainer@Rillke.eu) [10:42:12] 03(ASSIGNED) "Translation page template" is a confusing term - 10https://bugzilla.wikimedia.org/39760 (10Dereckson) [10:42:27] 03(ASSIGNED) Special:TranslationStats counts for edits includes also reviews - 10https://bugzilla.wikimedia.org/39761 (10Dereckson) [10:46:26] 03(NEW) suggest existing items when creating a new one to prevent duplication - 10https://bugzilla.wikimedia.org/39763 normal; MediaWiki extensions: WikidataRepo; (lydia.pintscher) [10:48:08] 03(mod) blog post says "3 responses", but none or fewer are shown - 10https://bugzilla.wikimedia.org/39755 +comment (10Dereckson) [10:51:32] 03(mod) VisualEditor: UI restores #toc as inline-block instead of block. - 10https://bugzilla.wikimedia.org/39753 +design; +comment (10Dereckson) [10:53:01] 03(mod) suggest existing items when creating a new one to prevent duplication - 10https://bugzilla.wikimedia.org/39763 +wikidata; +comment (10Dereckson) [10:54:12] 03(mod) UploadWizard needs to quit using funky array magic for upload lists - 10https://bugzilla.wikimedia.org/39746 +javascript; +comment (10Dereckson) [10:59:42] Dereckson: hey :) [10:59:56] any particular reason for adding the wikidata keyword? [11:00:52] 03(mod) Make enhanced recentchanges the default - 10https://bugzilla.wikimedia.org/35785 (10Nemo_bis) [11:03:18] Lydia_WMDE: indeed, I were asking myself the same question, because it's rather strange to add wikidata keyword to wikidata specific components [11:03:29] I think it's self-describing it's wikidata related. [11:03:37] Dereckson: hehe exactly [11:04:01] * Lydia_WMDE leaves for lunch [11:04:15] Bon appétit. [11:08:31] 03(mod) Fonts smaller than normal - 10https://bugzilla.wikimedia.org/39618 +comment (10Santhosh Thottingal) [11:20:58] 03(mod) Add jquery.jStorage module to MediaWiki core - 10https://bugzilla.wikimedia.org/35073 summary (10Krinkle) [11:21:16] 03(mod) Add jquery.jStorage module to MediaWiki core - 10https://bugzilla.wikimedia.org/35073 (10Krinkle) [11:21:31] 03(mod) Log entries are difficult to localize; rewrite logs system - 10https://bugzilla.wikimedia.org/24620 +comment (10Nemo_bis) [11:23:17] 03(mod) VisualEditor: UI restores #toc as inline-block instead of block. - 10https://bugzilla.wikimedia.org/39753 +comment (10Krinkle) [11:23:53] 03(mod) AFT contributions entries are very ugly and confusing - 10https://bugzilla.wikimedia.org/38631 +comment (10Nemo_bis) [11:23:53] 03(mod) Log entries are difficult to localize; rewrite logs system - 10https://bugzilla.wikimedia.org/24620 (10Nemo_bis) [11:26:41] 03(mod) VisualEditor: UI restores #toc as inline-block instead of block. - 10https://bugzilla.wikimedia.org/39753 +comment (10Krinkle) [11:41:42] New patchset: Siebrand; "Maintenance for CheckUser extension." [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/21872 [11:44:54] 03(mod) Image alt value '0' should not be removed - 10https://bugzilla.wikimedia.org/38910 +comment (10Koosha K.M.) [11:45:07] 03(NEW) Selection parameters limit= and offset=, like for index.php?action=history - 10https://bugzilla.wikimedia.org/39764 enhancement; MediaWiki extensions: ArticleFeedbackv5; (qq) [11:47:03] hi AHardington [11:47:06] hi aharoni [11:47:29] 03(mod) Image alt value '0' should not be removed - 10https://bugzilla.wikimedia.org/38910 +patch +patch-need-review (10Koosha Khajeh Moogahi [:koosha]) [11:49:25] 03(mod) Image alt value '0' should not be removed - 10https://bugzilla.wikimedia.org/38910 +comment (10Sumana Harihareswara) [11:51:33] New review: Hashar; "1) TemplateCategoriesTest::testTemplateCategories" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/13194 [11:52:07] back [11:55:22] hi chughakshay16 [11:55:28] marktraceur: Hello, [11:55:41] sumanah: Hello sumana, [11:55:53] sumanah: jsut looking for someone to review my change [11:55:56] sumanah: :) [11:56:02] :) good luck! [11:56:23] crap ... sry akshay ... forgot to click review :D [11:57:00] freakolowsky: np [11:58:37] Change merged: Freakolowsky; [mediawiki/extensions/ConventionExtension] (master) - https://gerrit.wikimedia.org/r/21743 [11:58:37] sumanah: I have problem with my email address when trying to commit changes using git [11:59:03] though I configured my git, it still tries to use my local user name [11:59:05] freakolowsky: thanks ! [11:59:15] koosha: maybe one of the folks here can help you with that [11:59:21] koosha: what OS are you on? [11:59:26] Debian [11:59:29] koosha: you may have set that username globally [11:59:54] yeah, I've done that globally [12:00:18] koosha: yeah if you want different usernames for different projects, then you will have to set them individually [12:00:34] how? [12:00:47] it tries to use "koosha@debian" :( [12:00:54] which is not my email [12:00:54] koosha: just go into that particular project in which you wish to change [12:01:27] koosha: by going into that project I mean through terminal.. [12:01:34] I know [12:01:40] koosha: :) [12:02:02] koosha: just set the username now as you would have done globally [12:03:07] I haven't worked with git [12:03:17] it looks bureaucratic [12:03:29] still the same error [12:03:57] I haven't created a branch [12:04:23] koosha: after moving into that project just type this $ git config --global user.name "John Doe" [12:04:42] koosha: dont use the word --global [12:04:53] koosha: just $ git config user.name "John Doe" [12:05:05] didn't solve the issue [12:05:11] koosha: and then you will have a unique username for this repo [12:08:55] Change abandoned: Hashar; "Lets keep the X- prefix :-D" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16631 [12:18:26] 03(ASSIGNED) jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements - 10https://bugzilla.wikimedia.org/34876 +comment (10Krinkle) [12:19:34] Change abandoned: Hashar; "test completed" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21747 [12:20:43] heya... how do I add JavaScript to my wiki pages? I actually only want 1 script on one article... [12:22:35] I tried using AddScriptCss, but that doesn't work [12:23:47] sven^: could you be a bit more specific ? [12:24:22] chughakshay16: I have a script file which I want to include in 1 article. It's script displaying data in a graph [12:24:45] sven^: okay, then how you are attempting to do it now ? [12:24:47] the data changes (most likely I will use a cron job for that) and the script should always display the current data [12:24:58] I tried http://www.mediawiki.org/wiki/Extension:AddScriptCss [12:25:19] but it seems outdated, produces PHP warnings and scrambled page text [12:26:52] sven^: as you can see this extension has a dependency [12:27:02] that's not the problem [12:27:03] sven^: http://www.mediawiki.org/wiki/Extension:AddScriptCss [12:27:42] sven^: could you paste the piece of code that you are using on pastebin ? [12:29:41] chughakshay16: http://pastebin.com/TtFn7h3k [12:30:52] sven^: and where is this file tree located in your directory ? [12:31:28] New patchset: Krinkle; "(bug 34876) Make jquery.makeCollapsible less slow." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21873 [12:31:30] in the folder determined by $bwScriptsDirectory [12:31:49] sven^: one more issue with your code [12:31:51] chughakshay16: but that shouldn't be the problem. The error occurs for the "" command, too [12:32:00] so the extension is just broken [12:32:09] sven^: just check your decalaration of tag [12:32:23] sven^: its wrong [12:32:42] yeah [12:32:51] you mean the leading / that is missing? [12:33:06] sven^: instead it should be like this 03(mod) jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements - 10https://bugzilla.wikimedia.org/34876 +comment (10Krinkle) [12:56:14] New patchset: Hashar; "createContext -> getContext" [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/21876 [12:57:53] vvv: ping around? :-D [12:58:02] vvv: I got a test failing in TitleBlacklist extension [12:59:16] hashar: can you enlighten me about what happend wrt the incomplete/missing merge of the CLDR stuff? [12:59:31] i think i'm seeing something like this locally - files are missing in my clone ?! [12:59:33] can that be? [13:03:05] DanielK_away: maybe you merged an outdated master ? [13:03:37] languages/data/plurals.xml was introduced by bbbcf08 13 days ago [13:03:43] hashar: i have two clones, checkout out master on both, do a pull on both and end up with different files. [13:03:46] so... [13:03:50] right [13:03:58] that thing is missing in one clone [13:04:02] and it is definitely not there [13:04:18] actually, i saw the file earlier, marked as untracked. i deleted it, because git wouldn't let me switch branches otherwise [13:04:25] ohhh [13:04:37] hashar: yes. seems like i merged a *broken* master. not an outdated one [13:04:42] how do you merge master in Wikidata ? [13:04:46] now, how do i fix that?... [13:04:50] 04(REOPENED) MediaWiki should not generate ids that are hard to select - 10https://bugzilla.wikimedia.org/30471 summary; +comment (10Krinkle) [13:04:53] ahh [13:04:57] git merge origin/master [13:05:00] k [13:05:05] well you could revert your merge [13:05:09] 03(mod) MediaWiki should not generate ids that are hard to select - 10https://bugzilla.wikimedia.org/30471 normal->15enhancement (10Krinkle) [13:05:13] hm, i guess. [13:05:15] it is apparently commit 67bfdc7 [13:05:20] made changes after that, though [13:05:36] it's probably best to roll all that back and redo it [13:05:37] gah [13:05:41] i hate to do that [13:05:42] maybe git revert 67bfdc7 ? [13:05:44] that merge took hours [13:05:56] hm... [13:06:00] or rollback to a safe commit and reapply the change that were made after [13:06:07] apparently there is just * 17eb6b8 - (HEAD, gerrit/Wikidata, Wikidata) clear magicword cache before testing cleanSig (3 hours ago) [13:06:17] yea, and that's a one liner [13:06:20] all pending patches in Gerrit will be made obsolete and need to be rebased [13:06:28] right [13:06:29] well... [13:06:39] hashar: but i guess i should start with a fresh clone [13:06:40] you can do the rollback then reapply 17eb6b8 with : git cherry-pick 17eb6b8 [13:06:46] New patchset: Siebrand; "Maintenance for TitleBlacklist extension." [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/20268 [13:06:48] any idea how this one got screwed up? [13:06:49] but maybe git revert 67bfdc7 will let it around [13:07:04] siebrand: hehe :-) [13:07:31] siebrand: I am not sure how Jenkins will react on that extension. I have several tests to fixup too [13:07:36] hashar: is it better to do the revert via gerrit? or directly in git? [13:07:55] DanielK_away: most probably end up doing the same thing [13:08:01] DanielK_away: via gerrit it is just a button [13:08:08] DanielK_away: via git you can know for sure what you are doing [13:08:33] DanielK_WMDE: I would do it in Gerrit :) [13:09:00] hashar: well, I could fix a few things based on the failure. [13:09:07] hashar: ok, will do that then [13:09:44] hashar: But I don't know much about tests. Let me know if you can take a look at it. [13:10:24] hashar: Not sure how to read https://integration.mediawiki.org/ci/job/Ext-TitleBlacklist/4/console. I think it's about this; [13:10:24] 13:07:02 [exec] Failed asserting that two strings are equal. [13:10:25] 13:07:02 [exec] --- Expected [13:10:38] yeah the test don't really make sense [13:10:56] trying to find out what the titleblacklist action is doing [13:11:25] hashar: Do I have to request tests to be added to Jenkins for particular extensions? [13:11:59] siebrand: which ext? The easiest for me is to fill a bug against Wikimedia / Testing Infrastructure [13:12:12] I am validating a few things using TitleBlacklist [13:12:21] then will finish up Wikidata job [13:12:27] and then MobileFrontend. [13:12:47] if the ext is easy and has no dependencies, I can add it in Jenkins in a few minutes [13:12:53] hashar: Can has Translate, UniversalLanguageSelector, WebFonts, Narayam, please? :) [13:14:34] New patchset: Tobias Gritschacher; "selenium: removed hardcoded "index.php" from URL to be compatible with a wider range of setups" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21879 [13:14:52] New patchset: Daniel Kinzler; "Revert "merged master"" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21880 [13:15:19] New review: Daniel Kinzler; "need to revert, bad merge" [mediawiki/core] (Wikidata); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21880 [13:15:20] Change merged: Daniel Kinzler; [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21880 [13:15:37] Change merged: Jeroen De Dauw; [mediawiki/extensions/SemanticBundle] (master) - https://gerrit.wikimedia.org/r/21847 [13:15:47] New review: Jeroen De Dauw; "Awesome thnx :)" [mediawiki/extensions/SemanticBundle] (master) - https://gerrit.wikimedia.org/r/21847 [13:15:56] New patchset: Jens Ohlig; "Added maintenance script for rebuilding the data and refactored the one for deleting a little" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21610 [13:16:37] hashar: oh, also TranslationNotifications [13:18:19] siebrand: sounds good. Can you please fill a bug requesting Jenkins jobs for all those extensions? [13:18:27] New review: Siebrand; "Nice cleanup. Thanks." [mediawiki/extensions/SemanticBundle] (master) - https://gerrit.wikimedia.org/r/21847 [13:18:30] siebrand: will do them all at the sametime, probably next week [13:18:41] siebrand: exact date will depends on my progress this week [13:18:44] hashar: one bug or one for each? [13:18:54] one bug for all is fine [13:19:22] hashar: should that go into Wikimedia->testing infra or elsewhere? [13:19:32] testing infra [13:19:39] will get me in CC automatically [13:20:52] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21610 [13:21:12] 03(NEW) Add some extensions to Jenkins testing - 10https://bugzilla.wikimedia.org/39765 normal; Wikimedia: Testing Infrastructure; (s.mazeland) [13:21:17] hashar: done ^^ [13:25:22] 03(ASSIGNED) Add some extensions to Jenkins testing - 10https://bugzilla.wikimedia.org/39765 normal->minor; +comment (10Antoine "hashar" Musso) [13:25:23] 03(mod) Create Jenkins job(s) for Wikidata extensions - 10https://bugzilla.wikimedia.org/37050 (10Antoine "hashar" Musso) [13:25:24] 03(mod) hack Jenkins to test MobileFrontend (PHPUnit + Qunit) - 10https://bugzilla.wikimedia.org/37276 (10Antoine "hashar" Musso) [13:26:25] hashar: Ow. Now you're using it as a tracking bug :) [13:26:42] New patchset: Jeroen De Dauw; "sites stuff [DNM]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21684 [13:27:11] 03(mod) Add some extensions to Jenkins testing - 10https://bugzilla.wikimedia.org/39765 (10Siebrand) [13:27:11] 03(mod) Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10Siebrand) [13:27:12] New patchset: Tobias Gritschacher; "selenium: removed hardcoded "index.php" from URL to be compatible with a wider range of setups" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21879 [13:27:41] 03(mod) Extensions to add to Jenkins testing (tracking) - 10https://bugzilla.wikimedia.org/39765 summary (10Siebrand) [13:30:20] New review: Siebrand; "This is also part of Ie78fa258, but didn't help. If you can review that one, all deprecated stuff th..." [mediawiki/extensions/TitleBlacklist] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21876 [13:31:30] Change merged: Siebrand; [mediawiki/extensions/Phalanx] (master) - https://gerrit.wikimedia.org/r/21801 [13:40:19] New patchset: Jeroen De Dauw; "Second version of the sites code, made ready for merge with core [DNM]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21684 [13:40:23] New review: Siebrand; "Per +1s of 3 others." [mediawiki/core] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/21319 [13:40:24] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21319 [13:42:12] New review: Madman; "Oh, messageTYPES.inc. Too bad I can't read. :)" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/21598 [13:42:39] New patchset: Hashar; "tests: split listed/unlisted tests" [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/21881 [13:42:39] New patchset: Hashar; "tests: switch parameters in assertEquals()" [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/21882 [13:43:19] siebrand: I think I fixed the TitleBlacklist extension :) [13:46:18] New review: Hashar; "Merging in, the build failure is due to an invalid test which is fixed by I4083c278" [mediawiki/extensions/TitleBlacklist] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21876 [13:46:37] New review: Hashar; "Moaar test fixes" [mediawiki/extensions/TitleBlacklist] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21881 [13:46:52] New review: Hashar; "Trivial change" [mediawiki/extensions/TitleBlacklist] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21882 [13:47:31] Change merged: Hashar; [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/21876 [13:47:39] New patchset: Siebrand; "tests: split listed/unlisted tests" [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/21881 [13:48:06] siebrand: aaaaaaa [13:48:19] hashar: I can imagine... [13:49:15] now it is failing again :-) [13:50:21] 03(mod) Deleted contributions show as empty list items on Special:Contributions - 10https://bugzilla.wikimedia.org/39062 normal->major (10Robin Pepermans (SPQRobin)) [13:50:40] Change merged: Hashar; [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/21881 [13:51:32] hashar: shouldn't it just be: $this->getUser()? AbiBase is a contextsource. [13:51:45] New patchset: Hashar; "tests: switch parameters in assertEquals()" [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/21882 [13:52:34] Change merged: Hashar; [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/21882 [13:53:47] siebrand: maybe, looks like it is what you did in https://gerrit.wikimedia.org/r/#/c/20268/ [13:53:48] New patchset: Siebrand; "Maintenance for TitleBlacklist extension." [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/20268 [13:54:31] 13:54:00 [exec] error: Could not fetch origin [13:54:33] yeahhh [13:54:39] hashar: simplified further (only one use): https://gerrit.wikimedia.org/r/#/c/20268/3/api/ApiQueryTitleBlacklist.php [13:54:46] 13:54:00 [exec] error: Ref refs/remotes/origin/master is at 506470fd796abfdc79cde621b484f565c31970a4 but expected 31c466e0f73573259d55e11c525732e491454d25 [13:54:48] grmblblb [13:55:55] apparently there is a conflictnow [13:56:28] # both modified: tests/ApiQueryTitleBlacklistTest.php [13:57:09] Nikerabbit: you around? [13:57:33] siebrand: rebasing [13:57:35] New patchset: Hashar; "Maintenance for TitleBlacklist extension." [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/20268 [13:58:35] csteipp: I am [13:58:48] Just curious who reported the bug to you last night [13:59:10] csteipp: my noon [13:59:28] Yeah, that's what I get for being on pacific time :) [14:00:55] hashar: heh. Database returned error "5: database is locked" [14:01:29] yeah I should drop the database before installing it [14:06:36] Change merged: Nikerabbit; [mediawiki/extensions/LiquidThreads] (master) - https://gerrit.wikimedia.org/r/21832 [14:07:03] New patchset: Krinkle; "WIP - Pass JSHint on resources/mediawiki.api/*" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21883 [14:07:25] Change abandoned: Matthias Mullie; "will be wrapped in another commit" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21869 [14:07:31] siebrand: sorry for the spam on that change :-( [14:07:40] 14:07:26 [exec] Database returned error "11: database disk image is malformed" [14:07:41] blaa [14:08:59] ahh finaly [14:09:05] New patchset: Matthias Mullie; "refactor AFT allowance checks" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21884 [14:09:49] New patchset: Siebrand; "Add udpcast now that it's running on localhost." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21885 [14:10:10] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21885 [14:10:17] New patchset: Krinkle; "Revert "Revert "jQuery 1.8""" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21886 [14:11:31] New review: Krinkle; "When merging please do backport to 1.20wmf10 (just like the revert was backported) so that we can re..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21886 [14:12:04] New patchset: Hashar; "(bug 36939) Introduce a way to limit username filter to certain sources." [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/8881 [14:13:33] New patchset: Hashar; "(bug 36939) Introduce a way to limit username filter to certain sources." [mediawiki/extensions/TitleBlacklist] (master) - https://gerrit.wikimedia.org/r/8881 [14:14:01] New review: Hashar; "Patchset 3: rebase" [mediawiki/extensions/TitleBlacklist] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/8881 [14:14:14] hashar: It's for the better, so bearable. [14:14:42] so Titleblacklist is officially the first extension working in Jenkins :-))) [14:14:57] * siebrand jumps up and slaps a thundering high5 with hashar ! [14:15:11] it was about time [14:15:19] that been a goal since january or so [14:15:22] * siebrand agrees with hashar  [14:16:04] New patchset: Jeroen De Dauw; "Second version of the sites code, made ready for merge with core [DNM]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21684 [14:17:14] Change merged: Matthias Mullie; [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21827 [14:17:52] woot [14:17:54] New patchset: Parent5446; "Added PHP complement for mw.Time." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/17107 [14:18:07] New patchset: Krinkle; "Revert "Revert "jQuery 1.8""" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21887 [14:20:19] New patchset: Krinkle; "Revert "Revert "jQuery 1.8""" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21887 [14:20:26] hashar: did someone say awesomeness [14:20:29] New review: Krinkle; "wmf backport: Ib8bc0ed39b506988e04575a3ca8a47e83c8e73ec" [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21886 [14:21:15] hashar++ [14:23:12] lo [14:23:29] New patchset: Jeroen De Dauw; "Second version of the sites code, made ready for merge with core [DNM]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21684 [14:24:30] after migrating i get "Exception caught inside exception handler", and absolutely nothing in logs, even after setting all relevant php options, wgDebugLogFile, wgShowExceptionDetails [14:24:43] so i'm completely in the dark :/ [14:28:20] Nikerabbit: now which me luck in completing the Wikidata stuff :) [14:32:14] New patchset: Matthias Mullie; "Bug 39355 - individual feedback page renders then disappears" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21888 [14:32:32] New review: CSteipp; "Just added you to the bug covering this. I'll test this out." [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/21761 [14:33:23] hashar: I'm all for it++ [14:34:45] Change abandoned: Parent5446; "(no reason)" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21761 [14:35:34] 03(mod) Article feedback page: 'Add your feedback' button - 10https://bugzilla.wikimedia.org/39420 +comment (10Matthias Mullie) [14:37:34] New patchset: Matthias Mullie; "Bug 39355 - individual feedback page renders then disappears" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21888 [14:41:56] no tips here? i'm pretty stuck [14:43:15] looks to me like this shouldn't even happen at all [14:43:22] <^demon> It shouldn't. There should be another exception somewhere. An exception couldn't be caused in the exception handler unless an exception was thrown originally. [14:43:24] New patchset: Matthias Mullie; "Refactor AFT logging" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/20908 [14:43:47] well since i get *nothing* in any log it's pretty hard to check :/ [14:44:27] 03(mod) Resource loader should allow loading messages in nonstandard ways (e.g. raw, forcontent, parsed, ...) - 10https://bugzilla.wikimedia.org/25349 +comment (10Eran Roz) [14:44:41] 14(DUP) Collapsing mw-collapsible tables is notably delayed (broken animation) in all browsers - 10https://bugzilla.wikimedia.org/31832 -accessibility -javascript ; +comment (10Krinkle) [14:44:42] 03(mod) jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements - 10https://bugzilla.wikimedia.org/34876 +comment (10Krinkle) [14:47:05] 03(mod) individual feedback page renders then disappears - 10https://bugzilla.wikimedia.org/39355 +comment (10Matthias Mullie) [14:50:23] 03(mod) Create option to disable interface animations - 10https://bugzilla.wikimedia.org/30401 +comment (10Krinkle) [14:51:33] 03(FIXED) jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements - 10https://bugzilla.wikimedia.org/34876 (10Krinkle) [14:54:01] decided to upgrade instead [14:54:18] "Missing rc_timestamp field of recentchanges table. Should not happen." [14:54:25] so update.php failed [14:55:52] New patchset: Krinkle; "Pass JSHint on resources/{mediawiki.api,jquery,mediawiki}/*" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21883 [14:57:33] 03(mod) get rid of getUsekeys setting (1) - 10https://bugzilla.wikimedia.org/39500 (10abraham.taherivand) [14:58:56] New patchset: Raimond Spekking; "Register Phalanx and SemanticBundle" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21889 [14:59:14] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21889 [15:00:41] that install was really behind, 1.6 [15:01:08] but the 1.7.4 update script fails as well, PHP Parse error: syntax error, unexpected T_NAMESPACE, expecting T_STRING in /var/www/mediawiki-1.7.1/includes/Namespace.php on line 46 [15:01:26] doc says that only happens with php4 [15:02:05] New patchset: Hashar; "raise filerepo tests timeout to 10sec" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21890 [15:02:35] Change merged: Hashar; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21890 [15:08:53] New patchset: Siebrand; "Update logging to latest standards, including pretty formatting." [mediawiki/extensions/Renameuser] (master) - https://gerrit.wikimedia.org/r/5288 [15:10:14] could anyone look into this please? [[bugzilla:39569]] [15:10:26] New patchset: Madman; "(bug 38556) Add header and footer messages to MediaWiki's info action" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21598 [15:11:20] … and [[bugzilla:39306]] [15:13:00] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21598 [15:15:22] New review: Matmarex; "See inline." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/19008 [15:23:29] New patchset: Matthias Mullie; "Bug 38631 - AFT contributions entries are very ugly and confusing" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21891 [15:24:11] I note gerrit doesn't like breaking lines. [15:24:24] I put in a review +1 comment "Test procedure followed: (sequence of commands)" [15:24:31] he replaced by \n by spaces. [15:24:36] It replaced. [15:25:02] oh, that could be fixed in css! [15:25:36] Dereckson: using Opera? [15:25:49] The HTML code is

Comment

so we could add a pre: pre-line [15:25:52] Firefox. [15:26:30] eh, i've been hitting some weird sort of bug that eats all of my newlines in any comment/review field in gerrit - in opera, but not in firefox [15:26:45] 03(FIXED) Add header and footer messages to MediaWiki's info action - 10https://bugzilla.wikimedia.org/38556 +comment (10Madman) [15:26:51] (eats when writing it) [15:27:07] (yeah, i did report it upstream) [15:32:47] DIV.GJEA35ODDK.GJEA35ODKB [15:32:52] GWS is fun :) [15:35:53] 03(NEW) string.find only return only a number instead of an array - 10https://bugzilla.wikimedia.org/39766 normal; MediaWiki extensions: Scribunto; (thomaspt) [15:36:44] 03(FIXED) MediaWiki:Articlefeedback contains spurious info - 10https://bugzilla.wikimedia.org/38592 +comment (10Matthias Mullie) [15:37:30] New patchset: John Erling Blad; "(Bug 39262) Slight changes to error messages to make them more readable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/19999 [15:38:07] 03(ASSIGNED) check global constraints on rollback/revert - 10https://bugzilla.wikimedia.org/39552 +comment (10Daniel Kinzler) [15:38:10] MatmaRex: I've the feeling we could safely add p { white-space: pre; } to our Gerrit CSS. I tested it under GreaseMonkey - http://pastebin.espace-win.org/23549 - and that doesn't break any style (well except documentation if you use r/* under Greasemonkey, but I guess the doc CSS and the app CSS aren't identical). [15:39:20] New patchset: Matmarex; "(bug 25830) fix JS preview causing the page to "jump"" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/18234 [15:39:27] 03(ASSIGNED) Fix undeletion of items - 10https://bugzilla.wikimedia.org/38958 +comment (10Daniel Kinzler) [15:39:51] By the way, I see a ".GJEA35ODLB" in our CSS. These CSS elements are stable? [15:40:15] 03(mod) GENDER (tracking) - 10https://bugzilla.wikimedia.org/30443 (10Nemo_bis) [15:40:18] 03(mod) Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 +comment (10Nemo_bis) [15:40:26] I thought they would have been autogenerated recompiling GWT code. [15:40:43] 03(mod) Fix undeletion of items - 10https://bugzilla.wikimedia.org/38958 +comment (10Daniel Kinzler) [15:40:55] Dereckson: hm, that appears to actually fix it. that's... weird. [15:41:09] (because at least some developers' comments show up correctly, with newlines visible) [15:41:28] but it feels wrong to me, p-s are not supposed to be pre-s, are they? [15:42:32] 03(mod) undo/restore may fail due to sitelink conflicts - 10https://bugzilla.wikimedia.org/39428 04CRIT->15enhancement; +comment (10Daniel Kinzler) [15:42:58] Change merged: Demon; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/21849 [15:44:02] Change merged: Demon; [mediawiki/tools/release] (master) - https://gerrit.wikimedia.org/r/21851 [15:44:10] 03(ASSIGNED) Show (restore) link when viewing old revisions of items - 10https://bugzilla.wikimedia.org/39130 +comment (10Daniel Kinzler) [15:44:12] MatmaRex: I think it depends on what you put in a paragraph. In review comments, are we writing text or sometimes code and commands? [15:44:40] just plaintext with paragraph breaks, the same in inline comments and in reviews [15:44:42] I'prefer too
than

[15:44:55] oh, you asked in general [15:45:18] we do sometimes write code there. [15:45:35] ^demon: you awake? i'm trying to repair a broken merge, and i have it sorted, but git review wants to push dozents of changes for review now. [15:45:36] Yes, so we have to break lines and treat as a pre block. [15:45:44] any idea why and when this happens, and how i can fix it? [15:46:02] <^demon> It's git-review being stupid. Try `git remote update` and then try again [15:46:04] Dereckson: i think gerrit lacks something like nl2br() somewhere :P [15:46:07] 14(WFM) string.find only return only a number instead of an array - 10https://bugzilla.wikimedia.org/39766 +comment (10Victor Vasiliev) [15:46:11] ^demon: did that, no dice [15:46:46] hm... [15:47:00] maybe if i make a diff, make a fresh branch, apply the diff... that may work? [15:47:16] MatmaRex: I don't know if add
everywhere is a cleaner solution than tell the browser through CSS how to print that. [15:47:29] <^demon> DanielK_WMDE: Without looking at your history, I'm unsure then. If you're just trying to push your HEAD, try `git push gerrit HEAD:refs/for/branchname` [15:47:38] <^demon> You could go the branching route, but try the above first. [15:47:56] trying to push two changes on that branch, actually [15:48:07] New review: Matmarex; "I don't think it should be circular; while a neat feature, I can't think of any other program or web..." [mediawiki/extensions/UniversalLanguageSelector] (master) C: 0; - https://gerrit.wikimedia.org/r/21047 [15:48:08] i could sqash them though [15:48:11] <^demon> Oh, well then try HEAD~1 and then HEAD :) [15:48:28] <^demon> I think HEAD~1 will work on push. We'll find out :) [15:48:37] Dereckson: but it does add br-s (or p-s) at least sometimes [15:48:41] lemme find an example [15:49:15] ^demon: "branchname" being my local branch name? [15:49:23] in jenkins-bot's comments, for example. [15:49:26] the feature branch? or the base branch? [15:49:29] there are multiple paragraphs [15:49:34] this is an update to the WIkidata branch, not master [15:49:42] i dont know, does gerrit need some arcane syntax for paragraphs? [15:50:08] MatmaRex: like a blank line? [15:50:51] well thats what i've been using, and it doesn work [15:50:54] another example: https://gerrit.wikimedia.org/r/#/c/18224/1/skins/common/preview.js [15:50:56] <^demon> DanielK_WMDE: No, remote branch name. [15:50:59] Krinkle: 's comments [15:51:00] * Dereckson notes CSS class for comments is .GJEA35ODOC [15:51:25] MatmaRex: I refered not to inline comments but to review comments [15:51:29] ^demon: uh. like... what? the corresponding remote branch doesn't exist yet. or do you mean "Wikidata" instead of "master"? [15:51:43] Dereckson: it's the same in both cases, isnt it? [15:51:48] Like in https://gerrit.wikimedia.org/r/#/c/16606/ [15:51:58] (the last comment) [15:52:08] <^demon> DanielK_WMDE: The remote branch doesn't exist yet? So you're not pushing to the Wikidata branch? [15:52:08] Yes, we should break in both. [15:52:11] New patchset: Amire80; "Circular scrolling through the regions" [mediawiki/extensions/UniversalLanguageSelector] (master) - https://gerrit.wikimedia.org/r/21047 [15:52:41] ^demon: yes, i am. but each change also has a branch, right? i guess i'm confused about that. [15:52:47] so, i'll use refs/for/Wikidata [15:52:48] Dereckson: ah, you at least get paragraphs, i cant use paragraphs, either :P [15:53:10] * Dereckson notes .GJEA35ODOC and not p..GJEA35ODOC [15:53:26] Gerrit seems a little bit inconsistent in the output. [15:53:46] this is a little bit of an understatement. [15:53:48] <^demon> DanielK_WMDE: Yes, that. refs/for/BRANCHNAME means the destination branch. [15:53:59] ^demon: help. [15:54:05] <^demon> With? [15:54:11] ^demon: ok, trying that. it's apparently doing lots of.... STUFF now. [15:54:12] please make gerrit convert two linebreaks to paragraphs in my comments. [15:54:22] e.g. https://gerrit.wikimedia.org/r/#/c/18224/1/skins/common/preview.js, my 2nd comment [15:54:25] https://gerrit.wikimedia.org/r/#/c/18224/1/skins/common/preview.js [15:54:44] gah. got an old changeid in one of the commits. will sqash first [15:54:51] 03(mod) Header of diffs uses obsolete attribute valign (in HTML5) - 10https://bugzilla.wikimedia.org/39680 +comment (10Dereckson) [15:55:09] <^demon> MatmaRex: There's nothing *I* can do about it. What browser are you using? [15:56:05] New patchset: Matthias Mullie; "Let tipsy determine it's gravity by itself" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21894 [15:56:35] ^demon: hm... one of the commits is a merge... so it really wants to push all the merged changes too. if i try to sqash, i'm also prompted to sqash all of them. [15:56:46] 03(mod) Canadian provinces showing french names when phone is in english - 10https://bugzilla.wikimedia.org/39689 (10Dereckson) [15:56:48] i'd *hope* all these are closed (merged) gerrit changes [15:56:53] so poshing them again should do nothing [15:56:54] ^demon: opera. for some unexplicable reason it works for other people. if you check the source or add CSS rule "p { white-space: pre; }" the newlines are visible [15:57:13] ^demon: this is strange. i have pushed merged to gerrit before, nothing like this has ever happened. [15:57:18] any idea how to handle this? [15:57:20] 03(mod) Cannot cancel batch upload - 10https://bugzilla.wikimedia.org/39690 (10Dereckson) [15:57:28] (i've reported it as https://code.google.com/p/gerrit/issues/detail?id=1540) [15:57:28] <^demon> MatmaRex: Opera has all kinds of troubles with gerrit. I'd recommend not using it. [15:57:41] gerrit has all kinds of troubles with Opera, not the other way. [15:57:44] MatmaRex and ^demon I'm going to submit a CSS kludge to do that. [15:58:23] 03(mod) Delay in loading incomplete uploads - 10https://bugzilla.wikimedia.org/39691 (10Dereckson) [15:58:48] 03(mod) Ajax loader icon overlaps text - 10https://bugzilla.wikimedia.org/39692 (10Dereckson) [15:59:00] 03(mod) Feedback Page on iPad - Hide My Post Flyout Issues - 10https://bugzilla.wikimedia.org/39754 +comment (10Matthias Mullie) [15:59:05] ^demon: still trying to understand what'S happening here. i mean... when i push a merge to gerrit, it should carry all the merged commits too, somehow. so i guess it would be correct to just push them all? and hope that only my two new changes actually show up as new changes on gerrit? even though the others are from another branch? [15:59:30] i'm really confused about how this is supposed to work. [15:59:49] pushing merges through gerrit seems... awkward, to say the least [16:00:06] <^demon> It should just push the single merge commit. [16:01:59] New patchset: MarkTraceur; "(bug 32247) Add "remove file" in the details step" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9549 [16:02:28] New review: Aaron Schulz; "I'd don't see the point in -1'ing something due to jenkins. I already see the giant red X. I think t..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/13194 [16:02:57] http://en.wikipedia.org/wiki/Special:Undelete/Society_of_Professional_Engineers_and_Associates vs. http://en.wikipedia.org/w/api.php?action=query&titles=Society%20of%20Professional%20Engineers%20and%20Associates&list=deletedrevs&drlimit=max: Is there really no way to get deleted text of revisions through the API? Because that... sucks. [16:03:35] (By which I mean text of revisions that has been deleted through RevisionDelete, not text of deleted pages' revisions... terminology suffers a bit there.) [16:04:18] ^demon: but it doesn't. now what? [16:04:47] <^demon> I have no idea. [16:04:49] RogueMadman: i think this is being developed [16:04:50] https://gerrit.wikimedia.org/r/#/c/4658/ [16:04:58] unless we're talking about different features :) [16:05:33] Ah. Excellent; I was sure someone would have noticed. [16:06:11] It's kind of urgent priority for some research I'm working on... hm. [16:06:25] 03(NEW) Break lines in review Gerrit comments - 10https://bugzilla.wikimedia.org/39767 minor; Wikimedia: Git/Gerrit; (dereckson) [16:06:28] Nothing since June 15 = :( [16:06:39] ^demon: well. i can make a diff and apply it, but that means claiming all the changes for myself. [16:06:54] MatmaRex: for inline comments, you can repro in Firefox a non breaking situation? [16:07:16] New review: Demon; "Does this actually need to depend on the Javascript version? They don't actually affect any of the s..." [mediawiki/core] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/17107 [16:07:17] Dereckson: i tried it once, paragraphs were formatted correctly when i was using firefox. [16:07:21] 03(ASSIGNED) Break lines in review Gerrit comments - 10https://bugzilla.wikimedia.org/39767 +comment (10Dereckson) [16:07:34] RogueMadman: try commenting on the patchset, maybe someone will react :) [16:07:53] Okay, so I offer to currently only fix inline comments and wait a little bit general Opera compatibility is improved in the future before taking actions there. [16:07:58] Dereckson: but i dont remember if it was in a comment or a review [16:08:08] Haha. Will do, or I can even submit some patch sets to amend problems. I'm not sure about the etiquette of doing that though. [16:08:14] New patchset: John Erling Blad; "(Bug 39262) Slight changes to error messages to make them more readable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/19999 [16:08:22] git checkout -b bug/39767 [16:08:24] w/w [16:08:56] 03(mod) Break lines in review Gerrit comments - 10https://bugzilla.wikimedia.org/39767 +comment (10Chad H.) [16:08:58] RogueMadman: you can contact the patchset owner at [[pl:User talk:Beau]] [16:09:10] Ooh, thanks. [16:09:13] * w:pl: [16:09:39] yeah, i only knew about this work by chance, because i know the committer :P [16:09:55] 03(mod) string.find only return only a number instead of an array - 10https://bugzilla.wikimedia.org/39766 +comment (10Tpt) [16:14:00] New review: Siebrand; "i18n/L10n reviewed." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21888 [16:14:21] 03(mod) Break lines in review Gerrit comments - 10https://bugzilla.wikimedia.org/39767 +comment (10Dereckson) [16:14:44] ^demon: sigh. bypassed gerrit on this one, did a direct push [16:16:58] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21699 [16:17:24] <^demon> Dereckson: If we can find the CSS class, we can mark it @external and I'll try to get it snuck into 2.5 :) [16:17:56] New review: Matmarex; "Just a couple of minor nitpicks not worth a -1." [mediawiki/extensions/UploadWizard] (master) C: 0; - https://gerrit.wikimedia.org/r/21820 [16:18:13] Yes, would be nice for other Gerrit users. [16:19:05] I note 2.5 is already RC0. [16:19:12] They've a feature freeze? [16:20:29] <^demon> You can get small stuff snuck in between rc0 and rc1 [16:20:39] <^demon> rc1 is frozen other than major breakages. [16:21:14] Ok. [16:23:08] 03(mod) suggest existing items when creating a new one to prevent duplication - 10https://bugzilla.wikimedia.org/39763 (10jeblad) [16:23:55] New review: Siebrand; "I've also added Niklas as reviewer. I'd like him to sign off on this." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21891 [16:24:38] <^demon> Dereckson: https://gerrit.googlesource.com/gerrit/+/master/gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css - is the file. I'm pretty sure .patchContentTable .commentPanelMessage is what we're looking at. [16:24:50] <^demon> But really, I want to mark everything @external so this isn't as annoying :) [16:24:50] I see gerrit-gwtui/src/main/java/com/google/gerrit/client/gerrit.css isn't as well documentated as I thought [16:25:34] <^demon> I know I can do -Dgwt.style=DETAILED to less-obfuscate JS. I wonder if that would work for CSS too. [16:25:36] * Dereckson wonders why to git clone a repo browseable on the web. [16:25:36] * ^demon ponders [16:25:48] New patchset: Jeroen De Dauw; "Second version of the sites code, made ready for merge with core [DNM]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21684 [16:26:02] <^demon> Anyway, lunch time. [16:26:11] Bon appétit. [16:28:18] New patchset: Matthias Mullie; "Bug 38631 - AFT contributions entries are very ugly and confusing" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21891 [16:29:16] 03(mod) AFT contributions entries are very ugly and confusing - 10https://bugzilla.wikimedia.org/38631 +comment (10Matthias Mullie) [16:29:52] New review: Siebrand; "Wow, that was quick :)." [mediawiki/extensions/ArticleFeedbackv5] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/21891 [16:38:26] New patchset: Krinkle; "Lint CSS, minor js fixes" [mediawiki/extensions/ArticleFeedbackv5] (master) - https://gerrit.wikimedia.org/r/21896 [16:39:20] I already lost the talk page link for the committer I intended to contact. I need to stop OCD-triggering /clear so often. :p [16:39:37] [[w:pl:User:Beau]] [16:39:45] ~ [16:39:51] Haha. Thanks. ^^ [16:43:55] New patchset: Krinkle; "Cleaned up uses of jQuery to create and appendTo/prependTo" [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21841 [16:44:13] Change merged: Krinkle; [mediawiki/extensions/VisualEditor] (master) - https://gerrit.wikimedia.org/r/21841 [16:44:27] New patchset: MaxSem; "New hook ApiMain::onException" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21748 [16:44:49] 03(mod) Break lines in review Gerrit comments - 10https://bugzilla.wikimedia.org/39767 +patch-in-gerrit; +comment (10Dereckson) [16:46:13] koosha: you've just missed ^demon|away who could change your name [16:46:27] When he's back from lunch, ask him to edit your name. [16:46:52] Dereckson: that's not really important right now. [16:47:14] What is important, is my problem with git which is driving me crazy and angry [16:47:35] koosha: What's the problem? [16:47:52] remote: ERROR: committer email address koosha@debian.(none) [16:47:53] remote: ERROR: does not match your user account. [16:48:14] configured git, still not working [16:48:14] koosha: git config --global user.email [16:48:25] didn't work [16:48:33] koosha: git commit --amend and edit the email address in the commit message [16:48:44] (there may be a shorter way, I just can't remember) [16:49:03] koosha: http://www.mediawiki.org/wiki/Git/Workflow#Email_doesn.27t_match [16:49:31] No, never mind [16:49:36] git is really foolishly complex [16:49:58] koosha: Well, to be fair, you tried to use it without proper configuration [16:50:08] Don't worry, in 2-3 weeks, you'll be proficient with git. [16:50:09] To be honest you're the first one I've seen to have such weird problems with it [16:50:40] koosha: git commit --amend --reset-author [16:50:47] (I'll put it in the mw.org article) [16:50:52] Krenair: so I'm either fool or bad-luck [16:50:57] Krenair: I got a funny one too. At the Berlin hackathon, my first gerrit code submission included references to the last 80 commits. [16:51:14] that's a known problem [16:51:31] the fixes are documented somewhere [16:52:30] koosha: you could also be interested by git config --global user.name [16:53:09] koosha: if this helps you any, that's not git you're having problems with, that's gerrit ;) [16:53:16] --global means settings will be save in your /home/koosha/.gitconfig file, and so will be available for every git project [16:53:56] !gitemail is http://www.mediawiki.org/wiki/Git/Workflow#Email_doesn.27t_match [16:53:56] Key was added [16:54:18] Change merged: awjrichards; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21748 [16:55:14] New patchset: Koosha; "Merge "[FileBackend] Added preloadCache() so callers can trigger cache getMulti()."" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21897 [16:55:46] Congratulations koosha for your first submission. [16:56:05] Dereckson: :) [16:56:08] Thanks [16:56:20] not sure if it gets approved [16:56:40] I think there is a little issue with the commit message. [16:56:57] Is 'Merge "[FileBackend] Added preloadCache() so callers can trigger cache getMulti()."' were what you wanted as commit message? [16:57:42] I don't know :P [16:57:46] :-( [16:57:56] The commit message should be something like a description of the modification [16:58:02] I don't have any idea about git terminology yet [16:59:11] Nikerabbit, siebrand, somebody [16:59:24] My server is returning only the plural form of a message to the client [16:59:34] And it makes 0 senses. [16:59:38] 03(mod) Image alt value '0' should not be removed - 10https://bugzilla.wikimedia.org/38910 +comment (10Koosha Khajeh Moogahi [:koosha]) [17:00:14] koosha: you can always edit (in git terms, "amend") the previous commit using "git commit --amend". this will also allow you to modify the commit message. [17:01:15] New review: Dereckson; "Thank you for your submission." [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/21897 [17:01:33] and when you do that, you can update your changeset on gerrit (that is, add a new patchset) using "git review" again [17:01:41] Okay, I reviewed your modification koosha. [17:01:56] Dereckson: and then? [17:02:20] koosha: you can see the comments clicking on patch set 1, then the files, then 1 comment. [17:02:22] Dereckson: ah, I see your comment [17:02:27] 03(NEW) Article Feedback Shows CTA5 to readers too frequently - 10https://bugzilla.wikimedia.org/39768 normal; MediaWiki extensions: ArticleFeedbackv5; (fflorin) [17:02:35] 03(mod) Article Feedback Shows CTA5 to readers too frequently - 10https://bugzilla.wikimedia.org/39768 (10Fabrice Florin) [17:02:51] koosha, MatmaRex, using 'git review -R', rather [17:02:56] (force no rebase) [17:03:07] We know the gerrit change is 21897. To fix a changeset, here's the procedure: [17:03:13] git review -d 2197 [17:03:18] git commit --amend [17:03:25] (there you can change your commit message) [17:03:27] git review -R [17:03:37] and hop, you've a new changeset on Gerrit. [17:03:42] marktraceur: oh, i didnt even know this was an option. never had any rebase-related issues with plain ol' `git review` :) [17:03:57] is there a manpage for git review anywhere? [17:03:59] (-d downloads a new branch to edit a Gerrit changeset, -R will push code with reference to the changeset) [17:04:05] MatmaRex: Maybe you just got lucky with no merge conflicts :) [17:04:14] probably ;) [17:04:16] man git-review should work [17:04:26] Dereckson: Do I need to amend the patch or upload a new one? [17:04:31] amend the patch [17:04:37] Dereckson: git-review uses the Changeset-ID to reference a changeset, the -R option makes sure the server doesn't try to auto-rebase [17:04:40] Dereckson: and now, assuming i'm on windows? :P [17:05:02] (`git help review` doesnt work) [17:05:52] MatmaRex: I created you an account on my FreeBSD semi-public dev machine. [17:06:03] MatmaRex: man git-review ? [17:06:21] you can log in with PuTTY and write man git-review [17:06:25] marktraceur: what if i'm on Windows? [17:06:36] MatmaRex: git review --help ? [17:06:42] If you don't have putty or any other SSH client, you can download it at http://the.earth.li/~sgtatham/putty/latest/x86/putty.exe [17:06:52] Dereckson: huh, i do have access to a linux shell server, easy there [17:06:59] Dereckson: Do I need to delete the |empty ( ... )| check or not? [17:07:02] i can install git review there just fine [17:07:05] only changes $options? [17:07:08] i'm looking for a non-painful way :) [17:07:29] marktraceur: doesnt work either [17:07:35] koosha: I don't know. I'd use $options['alt'] !== '' but it were only a suggestion, it's your code edit, you know better than me what should be used [17:08:01] MatmaRex: to log in a friendly server with man pages already available is a non-painful way :) You've your host/login/pass in private. [17:08:09] MatmaRex: https://arndtroide.homelinux.org/cgi-bin/man/man2html?git-review+1 [17:08:15] https://arndtroide.homelinux.org/cgi-bin/man/man2html?git-review+1 there it is. [17:08:23] ah, a even lesser painful way :) [17:08:25] Muahaha [17:08:25] ah, yes, thanks mark, just found it too :P [17:08:52] Dereckson: it forces me to start another program to do it (or use mingw's ssh which sucks), it is painful :) [17:08:53] "SSL error" !== "less painful" but whatever [17:09:18] MatmaRex: so I delete your account? [17:09:41] Dereckson: yes, feel free to do it [17:09:58] thanks for the help :) [17:10:10] 03(mod) jquery.makeCollapsible() very slow if many collapsible, initially collapsed elements - 10https://bugzilla.wikimedia.org/34876 +comment (10Daniel Friesen) [17:11:32] Dereckson: is this possible to change the ugly font in Gerrit patch shower? [17:13:25] MatmaRex: I was going to tell you "1. Visit http://trisquel.info...." [17:13:25] I guess you can achieve that with GreaseMonkey or other customization way [17:13:36] But I thought better of it :) [17:13:39] New patchset: Daniel Kinzler; "make MessageContent use a Message object" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21898 [17:14:22] Change merged: GWicke; [mediawiki/extensions/Parsoid] (master) - https://gerrit.wikimedia.org/r/21854 [17:15:27] Dereckson: I'm a little confused by your comment! [17:15:39] I don't understand your meaning well enough [17:15:55] marktraceur: i have Ubuntu on a VirtualBox ;) [17:17:16] (turns out there are many more tutorials online for running virtualized Windows on Linux than virtualized Linux on Windows...) [17:18:37] 03(mod) Article Feedback Shows CTA5 to readers too frequently - 10https://bugzilla.wikimedia.org/39768 +comment (10Matthias Mullie) [17:21:37] New patchset: Koosha; "Make toHtml respect '0' value for 'alt' option" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21897 [17:23:14] koosha: GreaseMonkey is a Firefox extension to run custom JS code on arbitrary webpages. You can use GreaseMonkey to customize any website you want. It allows to add easily custom CSS, so it should be easy to change the font. [17:23:24] But it's not. I tried to redefine css pre {}, that doesn't work. [17:24:08] Dereckson: I know Greasemonkey. I meant your comment on the patch :) [17:24:22] oh sorry [17:24:54] New patchset: Kaldari; "Some UI cleanup for UploadWizard" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21900 [17:25:30] New patchset: Jeroen De Dauw; "Second version of the sites code, made ready for merge with core [DNM]" [mediawiki/extensions/Wikibase] (sites) - https://gerrit.wikimedia.org/r/21901 [17:26:05] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21684 [17:26:18] koosha: you currently do two tests (1) empty (2) != '0'. I wonder if one test !== '' wouldn't be easier (= code more readable, maintainable) [17:27:41] Dereckson: I think you're making a mistake: |!==''| should be |===''| [17:27:47] Am I right? [17:28:23] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (sites) - https://gerrit.wikimedia.org/r/21901 [17:28:41] koosha: yep [17:30:30] Dereckson: I should run |git review| once more to upload a new patch? [17:30:36] or something else? [17:30:55] a new patch or a correction to this patch? [17:31:06] a correction [17:31:17] git commit --amend, then git review -R [17:31:45] New patchset: Daniel Kinzler; "make ApiEditPageTest robust against leaked state" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/21902 [17:32:32] &last -clear [17:32:34] oops [17:33:01] marktraceur: what is it? [17:34:39] marktraceur: latest master? [17:35:01] New review: Kaldari; "No longer getting the error from showNext(). Still getting the "TypeError: this.uploads[0].details.c..." [mediawiki/extensions/UploadWizard] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/9549 [17:35:11] Nikerabbit: Yeah, I'm in the process of git-bisecting [17:35:15] [remote rejected] HEAD -> refs/publish/master/newbranch (no changes made) [17:36:33] koosha: git add [17:36:36] git commit --amend, then git review -R [17:37:16] 03(mod) WLMMobile: HTML injection in HTML templating system - 10https://bugzilla.wikimedia.org/39735 +comment (10Arthur Richards) [17:37:18] Nikerabbit: But it's giving me nonsense answers. Is there caching of messages that would prevent me from accurately testing this? [17:37:39] (I'm using debug mode and Ctrl-F5, but maybe that's not enough) [17:38:04] New patchset: Koosha; "Make toHtml respect '0' value for 'alt' option" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21897 [17:39:16] that seems too generic, c [17:39:32] ping ^demon [17:39:35] c on #wikimedia #wikimedia-tech @#mediaw [17:39:58] <^demon> koosha: Yes? [17:40:19] ^demon: Could you please change my full name on Gerrit? [17:40:34] <^demon> No, I can't, it's not currently possible. [17:40:41] <^demon> I want to change mine too :) [17:41:00] :( OK [17:41:09] ^demon: where it's stored? [17:41:15] ^demon: Not even with database surgery? :) [17:41:20] <^demon> account_external_somethings. [17:41:38] <^demon> marktraceur: Yes, but until I have some automated way of doing it, I'm not doing it for anyone (myself included) [17:41:47] *nod* fair 'nuff [17:43:04] Platonides: how many legitimate users connect to this channel from .info tlds [17:43:28] c: I do [17:43:56] c: I have a .info TLD that I might use from time to time [17:43:59] saper: you have a cloak, so if you're identified you should be fine. you're able to speak now [17:44:11] as is marktraceur [17:44:12] yes, just letting know [17:45:01] ok. if it affects legit users i can remove it, just keeping cheap domains used for reverse dns abuse in check [17:47:53] I've seen lots and lots of people with really weird git problems. [17:48:06] (oh, I see I'm responding to a statement from probably days ago. Ahem.) [17:48:25] paulproteuss: Morning! [17:48:29] Morning! [17:48:45] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21886 [17:50:14] 03(mod) Article Feedback Shows CTA5 to readers too frequently - 10https://bugzilla.wikimedia.org/39768 +comment (10Fabrice Florin) [17:50:36] New review: MarkTraceur; "A) I don't get the copyMetaData error, could you show me?" [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/9549 [17:51:10] 03(NEW) Incomplete uploads showing admin level entries not address - 10https://bugzilla.wikimedia.org/39769 normal; WikiLoves Monuments Mobile: General; (philinje) [17:51:11] marktraceur: try with this patch: [17:51:36] https://gerrit.wikimedia.org/r/#/c/21699/ [17:52:22] Nikerabbit: With that patch, it's broken. You think that caused it? [17:52:33] marktraceur: that should fix it [17:52:40] New patchset: Kaldari; "Some UI cleanup for UploadWizard" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21900 [17:52:45] what language? and do run the unit tests [17:52:49] can't help you more at this moment [17:52:50] New patchset: Jeroen De Dauw; "Added default implmentation of instanceProvider to GenericArrayObjectTest" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21903 [17:52:58] Nikerabbit: Well, it's been merged and I still have the problem [17:53:06] Nikerabbit: English, and I will [17:54:14] marktraceur: and rebuild localisation cache! [17:55:04] 03(mod) Incomplete uploads showing admin level entries not address - 10https://bugzilla.wikimedia.org/39769 normal->major (10Phil Chang) [17:57:11] New patchset: MarkTraceur; "(bug 32247) Add "remove file" in the details step" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/9549 [17:57:28] Nikerabbit: Any way to straight-up disable that? [17:59:08] New patchset: Matmarex; "(bug 39273) add diff support to LivePreview" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21296 [17:59:39] New review: Matmarex; "(Patchset 4 is just a rebase.)" [mediawiki/core] (master) C: 0; - https://gerrit.wikimedia.org/r/21296 [18:00:41] New patchset: Daniel Kinzler; "make *ContentTest more robust against leaked state" [mediawiki/core] (Wikidata) - https://gerrit.wikimedia.org/r/21904 [18:01:13] Nikerabbit: Looks like there are a bunch of failures, but no work yet as to what they are. Standby. [18:01:16] Thing I Hate About Gerrit: no way to add a patchset comment when creating it. [18:01:20] Things*. [18:01:32] MatmaRex: +2 Looks good to me, approved. [18:01:41] 03(mod) Location where the photo was taken should be added to the upload - 10https://bugzilla.wikimedia.org/39745 +comment (10Phil Chang) [18:03:27] 03(mod) No way to return 'home' - 10https://bugzilla.wikimedia.org/39709 +comment (10Phil Chang) [18:04:24] MatmaRex: you mean when amending? well, just add to the commit message. i often just add "patchset 3: bla bla bla". [18:04:33] just make sure you put the *above* the change ID [18:05:39] DanielK_away: Some people prefer not to clutter the commit message, some people will actually -1 for that [18:07:29] DanielK_away: what mark said [18:07:48] also it's nice to have this information in one place [18:08:25] Nikerabbit: I can't see anything that's necessarily broken [18:09:09] Nikerabbit: I ran the languages tests, and what I could see of Localisation and ResourceLoader in the includes tests, but no problems [18:10:51] New patchset: Kaldari; "Implement uploading images from Flickr" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/12269 [18:11:01] New review: Krinkle; "Merging, master commit was approved and merged." [mediawiki/core] (wmf/1.20wmf10); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21887 [18:11:01] Change merged: Krinkle; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21887 [18:12:16] * marktraceur $ php maintenance/rebuildLocalisationCache.php # Yeah I'm not doing this again [18:12:18] 03(FIXED) Long file names - 10https://bugzilla.wikimedia.org/39571 (10Jon) [18:15:09] 03(NEW) MediaWiki:Previewnote error - 10https://bugzilla.wikimedia.org/39770 normal; Wikimedia: General/Unknown; (shizhao) [18:17:44] ^ Is that a duplicate of https://bugzilla.wikimedia.org/show_bug.cgi?id=39584 ? [18:18:35] New review: Brian Wolff; "The new global is missing an entry in includes/DefaultSettings.php" [mediawiki/core] (master) C: -1; - https://gerrit.wikimedia.org/r/11137 [18:21:33] New review: MarkTraceur; "Is patchset 16 only a rebase, or are there other changes?" [mediawiki/extensions/UploadWizard] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/12269 [18:27:56] 03(NEW) ResourceLoader is only returning plural versions of mwe-upwiz-deeds-macro-prompt (and others) - 10https://bugzilla.wikimedia.org/39771 major; MediaWiki: Internationalization; (mtraceur) [18:29:30] 03(mod) ResourceLoader is only returning plural versions of mwe-upwiz-deeds-macro-prompt (and others) - 10https://bugzilla.wikimedia.org/39771 +comment (10Mark Holmquist) [18:29:46] Dereckson: What should I do? [18:30:10] New patchset: Nischayn22; "Don't send mails to the editor himself, unless specified in settings" [mediawiki/extensions/SemanticWatchlist] (master) - https://gerrit.wikimedia.org/r/21906 [18:30:47] 03(mod) MediaWiki:Previewnote error - 10https://bugzilla.wikimedia.org/39770 (10shi zhao) [18:33:30] koosha: Solution 1. $alt = $options['alt']; Solution 2. Go back to your first idea. Solution 3. Check how the option is passed in code to see what's the best. [18:35:41] Dereckson: How many reviewers should approve a patch before it could get committed? [18:36:13] koosha, one reviewer giving +2 is enough [18:36:25] (note +2 is different than two +1) [18:36:34] (also note that only some people can +2) [18:36:45] New review: TheDJ; "I think rebasing is smart, because otherwise you keep chasing ghosts or being confused by problems t..." [mediawiki/extensions/UploadWizard] (master) C: 0; - https://gerrit.wikimedia.org/r/9549 [18:37:39] what's the difference between +1 and +2? [18:37:46] New review: Siebrand; "Thanks, Ryan." [mediawiki/extensions/UploadWizard] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/21900 [18:38:18] +1 is "I think it's ok, but someone else must approve" [18:38:21] +2 is an approval [18:38:36] the people who can give +2 depends on the repository [18:38:38] 03(FIXED) Implement wgCrossSiteAJAXdomains in a way that is cache and WMF friendly - 10https://bugzilla.wikimedia.org/30881 +comment (10Hoo man) [18:38:49] OK. I see :) [18:39:01] 03(mod) WLMMobile: HTML injection in HTML templating system - 10https://bugzilla.wikimedia.org/39735 normal->04BLOCKER; +comment (10Arthur Richards) [18:39:50] 03(mod) Enable $wgCrossSiteAJAXdomains for wikimedia sites - 10https://bugzilla.wikimedia.org/20814 +comment (10Roan Kattouw) [18:40:05] 03(mod) Incomplete uploads showing admin level entries not address - 10https://bugzilla.wikimedia.org/39769 major->normal (10Jon) [18:42:00] New patchset: Koosha; "Make toHtml respect '0' value for 'alt' option" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21897 [18:42:57] 03(mod) Map view/list view and complete/incomplete toggles are not obvious - 10https://bugzilla.wikimedia.org/39718 +comment (10Arthur Richards) [18:45:48] 03(mod) No way to return 'home' - 10https://bugzilla.wikimedia.org/39709 +comment (10Arthur Richards) [18:47:39] 03(mod) Background upload all images - 10https://bugzilla.wikimedia.org/39712 +comment (10Arthur Richards) [18:48:26] 03(mod) Cache more tiles - 10https://bugzilla.wikimedia.org/39714 +comment (10Arthur Richards) [18:49:24] marktraceur: I could try to investigate that bug tomorrow [18:50:25] Nikerabbit: Hrm. I'd like to fix it sooner, can you point me to a better way to rebuild the l10n cache so I can properly test it? [18:51:11] (maintenance/rebuildL...nCache.php takes too long) [18:52:01] koosha: i just realized. should be if( === null or === '' ) [18:52:11] koosha:the alt=0 check [18:52:47] man that empty thing is god ugly. you just have to hope that no one ever set the option to false somewhere... [18:53:38] thedj: so what am I supposed to do? [18:54:02] 03(WONTFIX) Confirm uploads on incomplete uploads page - 10https://bugzilla.wikimedia.org/39693 (10Jon) [18:55:12] New patchset: Bsitu; "Log curation toolbar actions" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/21158 [18:55:13] well the most reliable change would probably be. empty && !== "0" it's ugly, but it's the only sure way to know you won't break anything by fixing this. [18:55:32] thedj: Context? [18:55:53] koosha: if you do that, add a comment :D [18:56:16] marktraceur: it's about https://gerrit.wikimedia.org/r/#/c/21897/ [18:56:26] I think I've already done that [18:56:33] New patchset: Kaldari; "Implement uploading images from Flickr" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/12269 [18:56:36] Berk [18:56:56] koosha: that was your first set right ? [18:57:42] yes, why? [18:57:46] in hindsight, that might be the safest solution. or you have to go grep for 'alt' troughout the entire sourcecode to make sure people haven't set 'weird' values on it.. [18:58:12] oh, no...... [18:58:29] * marktraceur gets out the "grep party" banner [18:59:42] fun fact: git repos for MW extensions take over half a gigabyte. [18:59:53] * MatmaRex has recently had to grep them [19:00:00] 03(WONTFIX) Location where the photo was taken should be added to the upload - 10https://bugzilla.wikimedia.org/39745 +comment (10Jon) [19:00:38] Would be nice to see if tar ball bootstrapping would work [19:02:38] marktraceur: depending on your config both l10n cache and rl message blobs should clear automatically... [19:03:31] Nikerabbit: Well, considering that I've done git-bisect twice or so and get totally different results, I'd say something's up. [19:13:03] Nikerabbit: Hm. I can no longer find a good commit. That can't be good. [19:13:55] Nikerabbit: Oh, when I rebuilt the cache, I'm guessing that enabled the cache where it may not have been enabled before? [19:15:05] Or I was using the wrong test, sorry [19:17:33] 03(mod) Map view/list view and complete/incomplete toggles are not obvious - 10https://bugzilla.wikimedia.org/39718 (10Arthur Richards) [19:18:01] 03(FIXED) Echo Call to a member function getText() on a non-object - 10https://bugzilla.wikimedia.org/39085 +comment (10Andrew Garrett) [19:18:06] 03(mod) Login should only be required when uploading photos - 10https://bugzilla.wikimedia.org/39711 (10Arthur Richards) [19:18:41] 03(mod) WLMMobile: should show spinner while doing GPS lookup - 10https://bugzilla.wikimedia.org/39248 (10Arthur Richards) [19:19:55] 03(mod) No RTL support in the WLM app - 10https://bugzilla.wikimedia.org/39288 +comment (10Arthur Richards) [19:20:15] 03(mod) No way to return 'home' - 10https://bugzilla.wikimedia.org/39709 (10Arthur Richards) [19:20:37] 03(mod) Upload progress screen should indicate which part of the batch its on - 10https://bugzilla.wikimedia.org/39705 (10Arthur Richards) [19:20:57] Nikerabbit: First bad commit is e71bf6850cf74dd3133085cb16fba011c5d496e6 [19:21:15] Nikerabbit: Switching from wfMsg* to Message class calls [19:21:18] 06(LATER) Background upload all images - 10https://bugzilla.wikimedia.org/39712 (10Arthur Richards) [19:21:48] 06(LATER) Cache more tiles - 10https://bugzilla.wikimedia.org/39714 normal->15enhancement (10Arthur Richards) [19:22:10] 03(mod) Cache markers - 10https://bugzilla.wikimedia.org/39716 normal->15enhancement (10Arthur Richards) [19:22:32] 03(mod) Losing position on back - 10https://bugzilla.wikimedia.org/39695 (10Arthur Richards) [19:22:45] 03(mod) Cache markers - 10https://bugzilla.wikimedia.org/39716 (10Arthur Richards) [19:23:23] 03(mod) WLMMobile: rounding errors on border around progress bar on hdpi device - 10https://bugzilla.wikimedia.org/38507 +comment (10Arthur Richards) [19:23:57] 03(mod) WLMMobile: rounding errors on lines between list items on hdpi device - 10https://bugzilla.wikimedia.org/38506 +comment (10Arthur Richards) [19:24:23] 03(mod) Categories should be hierarchical and hidden - 10https://bugzilla.wikimedia.org/39721 (10Arthur Richards) [19:24:37] lol, i just went to see open patchsets on gerrit, and suddenly, L10n-bot. [19:25:15] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/16946 [19:25:39] MatmaRex: yes! :) "-owner:L10n-bot" is helpful to me [19:30:18] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21852 [19:32:46] 03(mod) Resize image before saving the upload if larger than max dimension - 10https://bugzilla.wikimedia.org/39736 +comment (10Bawolff) [19:35:44] 03(mod) Specify default language on a per-page basis - 10https://bugzilla.wikimedia.org/9360 +comment (10Bawolff) [19:37:41] New review: Catrope; "I think it would be more sensible if insertContent moved the selection to *after* the insertion, rat..." [mediawiki/extensions/VisualEditor] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/21399 [19:39:11] New patchset: IAlex; "Fix wfGetCaller() and wfFormatStackFrame() documentation" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21948 [19:40:56] 03(NEW) update the mobile app database - 10https://bugzilla.wikimedia.org/39772 blocker; WikiLoves Monuments Mobile: Browse; (ew-nospam) [19:41:09] 03(mod) update the mobile app database - 10https://bugzilla.wikimedia.org/39772 (10elya) [19:41:10] 03(mod) Tracking bug (tracking) - 10https://bugzilla.wikimedia.org/2007 (10elya) [19:43:24] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21948 [19:46:59] New review: Catrope; "Yes, it would, but only for the title, not for the content of the tag. You need to escape $html ..." [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/20500 [19:47:18] New review: MarkTraceur; "This commit appears to have caused bug 39771, siebrand, could you help me figure this out?" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20666 [19:47:36] 03(mod) ResourceLoader is only returning plural versions of mwe-upwiz-deeds-macro-prompt (and others) - 10https://bugzilla.wikimedia.org/39771 +comment (10Mark Holmquist) [19:48:58] New patchset: Raimond Spekking; "Register VoteNY" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21949 [19:49:08] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21949 [19:49:30] 03(ASSIGNED) [Regression] ResourceLoader should not serve parsed {{PLURAL:}} tags but leave raw - 10https://bugzilla.wikimedia.org/39771 -javascript +code-update-regression; summary (10Krinkle) [19:49:43] siebrand: ^ [19:50:59] Krinkle: Thaaaank you [19:53:38] New review: Krinkle; "Release notes" [mediawiki/core] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/20500 [19:55:48] New patchset: Raimond Spekking; "Fix registration of VoteNY" [translatewiki] (master) - https://gerrit.wikimedia.org/r/21950 [19:56:03] Change merged: Raimond Spekking; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21950 [19:58:48] New patchset: Aaron Schulz; "Added post-commit callback support to DB classes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21951 [20:01:54] New patchset: Aaron Schulz; "Added post-commit callback support to DB classes." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21951 [20:02:18] New review: Siebrand; "Can you try to narrow it down to a file or a line? I don't have the environment set up to reproduce ..." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20666 [20:10:40] New review: Alex Monk; "This really should not have been merged until after https://gerrit.wikimedia.org/r/#/c/15746/ is mer..." [mediawiki/extensions/Echo] (master) - https://gerrit.wikimedia.org/r/15757 [20:11:51] New patchset: Jarry1250; "Rewrite the ThumbnailImage constructor to take parameter array" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21321 [20:13:43] marktraceur: hmm [20:14:25] Nikerabbit: siebrand and I are trying to narrow it down [20:15:34] marktraceur: I don't see anything RL related there [20:15:50] Nikerabbit: me neither. [20:16:08] Nikerabbit: I'm beting on gerrit 20006. [20:16:28] 14(WFM) WLMMobile: rounding errors on lines between list items on hdpi device - 10https://bugzilla.wikimedia.org/38506 +comment (10Brion Vibber) [20:17:39] siebrand: um why? marktraceur said that the plural is not there at all (instead of being parsed wronly) [20:19:25] 03(mod) [Regression] ResourceLoader should not serve parsed {{PLURAL:}} tags but leave raw - 10https://bugzilla.wikimedia.org/39771 +comment (10Siebrand) [20:19:38] 03(mod) [Regression] ResourceLoader should not serve parsed {{PLURAL:}} tags but leave raw - 10https://bugzilla.wikimedia.org/39771 (10Siebrand) [20:20:35] marktraceur: can you please check what is stored in the message blobs? [20:20:56] Nikerabbit: You mean mw.messages? [20:21:07] (because that's what I'm using to test it now) [20:21:29] New patchset: Tpt; "(bug 37419) Rewriting of Index pages edit form in PHP" [mediawiki/extensions/ProofreadPage] (master) - https://gerrit.wikimedia.org/r/10741 [20:23:03] marktraceur: resource loader caches the messages in database in some table [20:23:33] Nikerabbit: Could you join us in #wikimedia-dev? [20:23:59] 04(REOPENED) WLMMobile: rounding errors on lines between list items on hdpi device - 10https://bugzilla.wikimedia.org/38506 +comment (10Brion Vibber) [20:27:04] marktraceur: sigh [20:27:14] why not in this channel? [20:27:48] Dunno, ask siebrand [20:28:13] New patchset: Kaldari; "Implement uploading images from Flickr" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/12269 [20:28:28] New review: Aaron Schulz; "Seems OK, and doesn't explode with manual testing." [mediawiki/extensions/CheckUser] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21872 [20:28:28] Change merged: Aaron Schulz; [mediawiki/extensions/CheckUser] (master) - https://gerrit.wikimedia.org/r/21872 [20:29:36] Change merged: Kaldari; [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/21900 [20:31:39] marktraceur: ^^ [20:31:47] * Nikerabbit kicks gerrit-wm  [20:31:51] New patchset: Nikerabbit; "(bug 39771) Regression in Ie349afa5 broke plurals in JavaScript" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21954 [20:32:32] http://lists.wikimedia.org/pipermail/mediawiki-distributors/2012-August/000025.html [20:33:06] Xml::Hidden vs. Html::Hidden [20:33:07] New review: MarkTraceur; "Fight! Go! Win!" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/21954 [20:33:11] rings a bell vaguely [20:33:19] html::hidden [20:33:39] Nikerabbit: click the link? [20:33:58] * jeremyb is also distracted with other stuff [20:34:18] siebrand: https://gerrit.wikimedia.org/r/21954 [20:35:49] jeremyb: xml::hidden was removed in 1.18 [20:36:55] Nikerabbit: so just do a mass substitution? or is there something else to worry about? [20:37:29] does every Xml:: method have a corresponding Html:: method? [20:37:56] New patchset: Bsitu; "Log curation toolbar actions" [mediawiki/extensions/PageTriage] (master) - https://gerrit.wikimedia.org/r/21158 [20:37:59] marktraceur: well, you did almost have the correct patch set... [20:39:19] Change merged: Aaron Schulz; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21321 [20:39:25] New review: Siebrand; "bug 39771 wasn't caused by this patch set, but by Ie349afa5. Niklas made a fix in Iee4e3bdc." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/20666 [20:39:51] jeremyb: should be nothing to worry about [20:40:00] 03(mod) [Regression] ResourceLoader should not serve parsed {{PLURAL:}} tags but leave raw - 10https://bugzilla.wikimedia.org/39771 +comment (10Siebrand) [20:40:04] jeremyb: and no there is no general 1to1 mapping [20:40:29] Change merged: Siebrand; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21954 [20:40:35] marktraceur: merged. [20:40:37] * AaronSchulz tags RoanKattouw for https://gerrit.wikimedia.org/r/#/c/21951/ [20:40:37] Nikerabbit: well then we do have to worry about methods not existing i assume [20:41:01] jeremyb: just replare Xml::hidden only [20:41:19] Nikerabbit: oh, not all of Xml:: went away? [20:41:50] Yay! Nikerabbit, siebrand, thanks for the help, you're amazing. [20:42:02] jeremyb: no, just that one [20:42:07] marktraceur: Can you confirm it is fixed? [20:42:16] Nikerabbit: ok, great [20:43:19] siebrand: Yes, it's fixed after that patch. Thanks so much. [20:43:23] 03(NEW) "You cannot post a blank message" error on every summary edit - 10https://bugzilla.wikimedia.org/39773 normal; MediaWiki extensions: LiquidThreads; (federicoleva) [20:43:48] marktraceur: Cool. Good luck writing tests. [20:44:13] 03(FIXED) [Regression] ResourceLoader should not serve parsed {{PLURAL:}} tags but leave raw - 10https://bugzilla.wikimedia.org/39771 +comment (10Siebrand) [20:44:24] AaronSchulz: Does the "Closure" type hint /require/ that the argument be an anonymous function, or can it point to a class method or something? [20:44:50] $( '
' ).dialog( { buttons: { 'InvisibleBtn': function() {alert( 'Dialogs are broken in wikipedia??' ) } } } ) [20:45:19] Oh grr [20:45:25] Krinkle: ----^^^ I think that's because of jQuery 1.8 [20:45:39] why ? [20:45:44] We had that problem before [20:45:50] EranRoz: What error do you get? [20:45:57] heatherw: I thought you might be interested in answering a question from a friend of mine who is taking a course on (I think) design thinking: http://blog.melchua.com/2012/08/24/what-gives-good-designers-the-assurance-and-courage-to-plunge-into-the-chaos/ "If coping with chaos is part of design, what gives good designers the assurance and courage to plunge into the chaos?" [20:46:01] EranRoz: Which wiki are you on? [20:46:02] Although I think we fixed it by upgrading jQuery UI rather than downgrading jQuery [20:46:04] Krinkle: no button text [20:46:10] enwiki for example [20:46:18] Yeah that bug sounds familiar [20:46:34] Last time I saw it it was because jQuery blanked $.attrFn but JUI was still using it [20:46:37] 03(mod) "You cannot post a blank message" error on every summary edit - 10https://bugzilla.wikimedia.org/39773 (10Nemo_bis) [20:47:25] RoanKattouw: you mean like array( $this, 'func' ) ? [20:47:25] Oh, we *did* fix it by reverting jQuey [20:47:35] And you unreverted it so now it's broken again [20:47:48] Krinkle: Please upgrade jQuery UI dialog to the latest version where this is fixed, or revert the jQuery upgrade [20:47:49] I don't think so...there is a "callable" type hint, though that's 5.4 [20:48:03] Hm.. [20:48:09] Right [20:48:15] jUI update is linked to jQ update [20:48:16] sumanah: necessity and experience (and some chutzpah) [20:48:22] I didn't know jUI was reverted as well [20:48:23] why ? [20:48:28] searching [20:48:30] AaronSchulz: Yeah I meant that, or 'wfFoo', or 'Foo::Bar' or whatever. But yeah if callable is 5.4 then that's out the window, and wrapping around a function with a closure is easy [20:48:33] Krinkle: It was just never updated [20:48:39] Partly because JUI's fix was late [20:48:43] grr [20:48:44] heatherw: got it :) shall I post that comment then? [20:48:48] i think it was because of en-wikinews , some gadget was broken there [20:48:54] We're on JUI .22 but we need .25 [20:49:00] Or wait, I think Sam upgraded it, didn't he? [20:49:01] RoanKattouw: are you think of something like in https://gerrit.wikimedia.org/r/#/c/16696/11/includes/rdbstore/RDBStore.php [20:49:07] sumanah: if you'd like :) [20:49:09] Maybe the JUI upgrade is in core but wasn't cherry-picked to wmf? [20:49:12] in the finish() function [20:49:36] I guess it could support that, but I like the idea of uniformity (just using a closure always) [20:49:45] AaronSchulz: I suppose .... but I was just musing, closures are fine [20:50:13] actually maybe I should make that code require Closure too ;) [20:50:18] 03(FIXED) "You cannot post a blank message" error on every summary edit - 10https://bugzilla.wikimedia.org/39773 +comment (10Nemo_bis) [20:51:22] sumanah: also "what makes someone plunge into a dark underwater cave with the certainty that they’ll find their way through the tunnel into the light before they run out of air?"… you don't. [20:51:36] have certainty, that is. [20:52:26] hmph [20:52:35] * Nikerabbit was supposed to read a book [20:52:44] Nikerabbit: watch TV instead! [20:52:59] * AaronSchulz doesn't even watch TV [20:53:04] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21951 [20:53:20] updating now [20:53:25] AaronSchulz: I just spend 3h watching series/movies and planning to use the remaining 1h for reading [20:53:33] Krinkle: OK. I'm running to the store now [20:53:36] RoanKattouw_away: .23 not .25 [20:53:44] * AaronSchulz does use netflix though [20:54:13] moar David Duchovny! [20:55:12] RoanKattouw_away: it was updated: https://gerrit.wikimedia.org/r/#/c/20927/ [20:55:49] AaronSchulz: X Files or Californication? [20:56:44] New patchset: Krinkle; "Revert "Revert "Update jQuery UI to 1.8.23""" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21955 [20:56:53] siebrand: you'll have to figure that out yourself...the truth is out there [20:56:55] Change merged: Krinkle; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21955 [20:58:17] Wikinaut: Hey! I saw your fix got merged into EPL :) [20:58:26] Congrats an' all that [20:59:06] 03(mod) WLMMobile: rounding errors on border around progress bar on hdpi device - 10https://bugzilla.wikimedia.org/38507 +comment (10Brion Vibber) [20:59:11] Anyone know where tools/code-utils/stylize.php is in git? [20:59:48] AaronSchulz: Have you seen the 4400 [20:59:50] ? [21:00:15] https://gerrit.wikimedia.org/r/#/admin/projects/ "tools" [21:00:21] Krenair: [21:01:24] * sumanah misses the Duchovny TV of the 90s [21:02:53] New patchset: Siebrand; "Change to correct directory." [translatewiki] (master) - https://gerrit.wikimedia.org/r/21956 [21:03:07] or not [21:03:21] <^demon> I don't think code-utils ever got migrated. [21:03:22] it's not in git yet, still in svn(?) [21:03:25] <^demon> We should prolly do that [21:03:30] Change merged: Siebrand; [translatewiki] (master) - https://gerrit.wikimedia.org/r/21956 [21:03:49] hi, we have a bug on the French wiki, with preview notices [21:03:52] Nikerabbit: enjoy your multimedia entertainment experience! :) [21:04:05] hm, nope. can't find it anywhere under mediawiki/tools [21:04:27] hi Od1n - go ahead, please tell us more [21:04:34] <^demon> I'll do a bunch of repo creations tomorrow. [21:04:44] sumanah: alias sleep! [21:04:45] [[:fr:MediaWiki:Previewnote]] contains an image, but the markup is now escaped when doing a preview [21:04:55] <^demon> Would someone mind tossing it on [[mw:Git/Conversion/Extension_queue]] so I don't forget? [21:05:11] Od1n: https://bugzilla.wikimedia.org/39584 [21:05:15] Od1n: quick question - have you already filed a bug report at bugzilla.wikimedia.org ? if so, I can point others to it [21:05:16] oh [21:05:16] siebrand: I was given a 4400 dvd, never watched it yet [21:06:13] Od1n: so, we have found the problem and created a fix, and the wikis will get that fix within 1-2 weeks. is that ok? [21:06:21] ok thanks, so just have to wait for deployment [21:06:33] 03(NEW) Admin levels getting confused - 10https://bugzilla.wikimedia.org/39774 normal; WikiLoves Monuments Mobile: Browse; (philinje) [21:06:53] yes :) https://www.mediawiki.org/wiki/MediaWiki_1.20 has the recent deployments [21:07:05] is there any possibility of quick deployment, or should we temporarly remove the image? [21:07:24] 03(mod) Admin levels getting confused - 10https://bugzilla.wikimedia.org/39774 +comment (10Phil Chang) [21:07:29] New patchset: Krinkle; "Revert "Revert "Update jQuery UI to 1.8.23""" [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21957 [21:07:59] 03(WONTFIX) WLMMobile: rounding errors on lines between list items on hdpi device - 10https://bugzilla.wikimedia.org/38506 +comment (10Brion Vibber) [21:08:07] New review: Krinkle; "Merging because of it jQuery UI depends on jQuery which got updated already. jQuery UI is currently ..." [mediawiki/core] (wmf/1.20wmf10); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21957 [21:08:07] Od1n: in rare cases, when there's an especially critical problem, we deploy fixes before the usual schedule. is this a very critical problem? [21:08:07] Change merged: Krinkle; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21957 [21:08:33] marktr [21:09:02] marktraceur: hi, saw your welcome message just right now [21:09:12] marktraceur: filed a jquery 1.8.0 bug [21:09:35] $(window).height() and .width() is broken in 1.8.0 :-)) [21:09:49] uuuh so maaaannny bugggssss [21:09:50] ^demon, done [21:10:05] New review: Bsitu; "Some more changes need to be bundled together with this patch" [mediawiki/extensions/PageTriage] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/20241 [21:10:08] and then this gerrit/git "issue" [21:10:28] did not contribute a single line of code since the switch over ... [21:10:36] <^demon> Krenair: Thanks. [21:10:38] some people are certainly happy about this [21:11:08] Is there any convention or procedure to run a block of code on pages in specific namespaces only via the LocalSettings.php file? Eg.: [21:11:15] the issue is not "critical", i.e. it is not breaking vital functionnality, nor does it introduces security flaw [21:11:19] global $wgTitle; [21:11:20] if ($wgTitle && ($wgTitle->GetNamespace() == NS_MAIN)){ [21:11:22] .... [21:11:23] } [21:11:46] ... only this above doesn't actually work... [21:12:20] Od1n: ok, then you will probably just want to take precautions/do workarounds till the deployment https://www.mediawiki.org/wiki/MediaWiki_1.20/Roadmap [21:12:25] bye [21:12:41] How is it usually done? [21:12:58] Tuxedo_: http://svn.wikimedia.org/doc/classTitle.html#a17bd50bacfacf339375970d15860861a [21:13:06] EranRoz: Purge cache, does it work now? [21:13:21] jQuery 1.8 and jQuery UI 1.8.23 are deployed now [21:13:24] 03(NEW) mediawiki:Previewnote dosen't accept image! - 10https://bugzilla.wikimedia.org/39775 normal; MediaWiki: General/Unknown; (reza.energy) [21:13:30] (to 1.20wmf10: https://www.mediawiki.org/wiki/MediaWiki_1.20/Roadmap#Schedule_for_the_deployments ) [21:13:38] marktraceur: Thanks! [21:13:49] New patchset: Aaron Schulz; "[JobQueue] Job queue refactoring and generalizing." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/13194 [21:13:50] Tuxedo_: And your original code would probably work if you had the right case [21:14:01] Tuxedo_: It's "getNamespace" not "GetNamespace" [21:14:15] New patchset: Kaldari; "Implement uploading images from Flickr" [mediawiki/extensions/UploadWizard] (master) - https://gerrit.wikimedia.org/r/12269 [21:14:34] nevertheless it would be great to fix it now, but if it is complicated I understand [21:14:42] Krinkle: works now. thanks! [21:15:26] 03(mod) [Regression] MediaWiki:Previewnote no longer accepts a File embed - 10https://bugzilla.wikimedia.org/39775 +code-update-regression; summary (10Krinkle) [21:15:37] Ahhh! Thanks! [21:15:47] 03(mod) MediaWiki:Previewnote error - 10https://bugzilla.wikimedia.org/39770 (10Krinkle) [21:15:53] 14(DUP) [Regression] MediaWiki:Previewnote no longer accepts a File embed - 10https://bugzilla.wikimedia.org/39775 +comment (10Krinkle) [21:15:55] 03(mod) MediaWiki:Previewnote error - 10https://bugzilla.wikimedia.org/39770 +comment (10Krinkle) [21:17:48] New review: Kaldari; "The main things still missing are:" [mediawiki/extensions/UploadWizard] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/12269 [21:18:06] Od1n: so, in https://bugzilla.wikimedia.org/39584 you see that someone says that in order to get the fix deployed NOW someone would have to backport it to the current WMF deployed branch [21:18:19] 03(mod) [Regression] MediaWiki:Previewnote broken (double html escaped) - 10https://bugzilla.wikimedia.org/39770 +code-update-regression; summary; +comment (10Krinkle) [21:18:19] 03(mod) MediaWiki bugs to be fixed for 1.20wmf10 deployment (tracking) - 10https://bugzilla.wikimedia.org/39515 (10Krinkle) [21:18:29] 03(mod) [Regression] MediaWiki:Previewnote broken - 10https://bugzilla.wikimedia.org/39584 (10Krinkle) [21:18:30] 03(mod) MediaWiki bugs to be fixed for 1.20wmf10 deployment (tracking) - 10https://bugzilla.wikimedia.org/39515 (10Krinkle) [21:19:11] 14(DUP) [Regression] MediaWiki:Previewnote broken (double html escaped) - 10https://bugzilla.wikimedia.org/39770 +comment (10Krinkle) [21:19:12] 03(mod) [Regression] MediaWiki:Previewnote broken - 10https://bugzilla.wikimedia.org/39584 +comment (10Krinkle) [21:19:15] 03(mod) MediaWiki bugs to be fixed for 1.20wmf10 deployment (tracking) - 10https://bugzilla.wikimedia.org/39515 (10Krinkle) [21:19:21] Od1n: so, you would need to get someone to volunteer to do that. :-) [21:19:26] 03(mod) [Regression] MediaWiki:Previewnote broken (double html escaped) - 10https://bugzilla.wikimedia.org/39584 summary (10Krinkle) [21:20:16] 03(NEW) Instance creation doesn't actually fail when hosts can't be added to LDAP - 10https://bugzilla.wikimedia.org/39776 normal; MediaWiki extensions: OpenStackManager; (rlane32) [21:21:04] New review: Krinkle; "This commit merges e3fb463eec40458303ba18139da312152103b8d7 from master." [mediawiki/core] (wmf/1.20wmf10); V: 1 C: 2; - https://gerrit.wikimedia.org/r/21730 [21:21:05] Change merged: Krinkle; [mediawiki/core] (wmf/1.20wmf10) - https://gerrit.wikimedia.org/r/21730 [21:21:18] New patchset: Robmoen; "Move cancel link out of editHelp span and wrap in 'cancelLink' span." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21958 [21:22:46] gerrit may break soon [21:22:49] as a warning [21:23:25] 03(NEW) Domain creation doesn't properly invalidate domain cache in memcache - 10https://bugzilla.wikimedia.org/39777 normal; MediaWiki extensions: OpenStackManager; (rlane32) [21:23:34] +1 for the backport, that's a safe one and will be much appreciated [21:24:23] btw, it has just been merged [21:24:42] Od1n: link to the merged backport? [21:25:00] Agh... [21:25:09] https://gerrit.wikimedia.org/r/#/c/21730/ [21:25:52] ok. gerrit restarted, but seems to not be broken :) [21:26:09] sumanah, Od1n I already backported that [21:26:29] yep, it's working now, many thanks [21:26:42] Oh... And Krinkle merged it while I had my email client closed. okay [21:26:51] wow, when did the deploy happen? like 3 min ago? [21:27:39] Close. Two minutes ago :P [21:28:44] 03(mod) A bad filename should be changed silently instead of stopping the upload with "unknown-warning" - 10https://bugzilla.wikimedia.org/39220 +comment (10Derk-Jan Hartman) [21:29:22] New patchset: MaxSem; "r911: don't return coordinates if they aren't known" [wikimedia/wlm-api] (master) - https://gerrit.wikimedia.org/r/21959 [21:30:28] Change merged: MaxSem; [wikimedia/wlm-api] (master) - https://gerrit.wikimedia.org/r/21959 [21:31:35] New patchset: Platonides; "(Bug 38606) Set log_page on uploads to the page_id of its description page" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21960 [21:32:40] New patchset: Daniel Friesen; "[mw.notification] Introduce a full fledged notification system into core replacing jsMessage." [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19199 [21:32:41] New patchset: Daniel Friesen; "Fix up the preferred way to specify mw.util.$content" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/19008 [21:33:22] O_o shouldn't that be the other way around? [21:35:01] Dantman: You'd think so, but I've seen Gerrit put the "Change was successfully merged" comment before the "Looks good to me, approved" comment sometimes so who knows [21:35:01] ashley: https://www.mediawiki.org/wiki/Git/Tutorial#Comparing_patch_sets is that helpful to you? [21:35:55] Change merged: Catrope; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21958 [21:36:46] * AaronSchulz works more on a patcj [21:36:48] *patch [21:36:50] RoanKattouw: Fatal error: Cannot access self:: when no class scope is active in /var/www/DevWiki/core/includes/job/JobQueueDB.php on line 45 [21:36:55] oh PHP 5.3 :) [21:37:06] silly workarounds [21:37:11] Grah really [21:37:23] And I don't suppose using(self) works :D [21:37:25] "if ( $flags & self::QoS_Atomic ) {" [21:37:37] RoanKattouw: well $this doesn't either (as documented) [21:37:53] 03(NEW) If you get a duplicate-archive warning for the first file in a multifile upload it gives a JS error - 10https://bugzilla.wikimedia.org/39778 major; MediaWiki extensions: UploadWizard; (rkaldari) [21:37:59] it worked in early php5.3 but support was removed so they could think it through...then it was added back in 5.4 [21:38:07] * RoanKattouw sighs [21:38:26] I suppose you could do $qos_atomic = self::QoS_Atomic; outside the closure and then use($qos_atomic) [21:38:35] yep [21:38:39] that's what I'm doing [21:39:40] 03(mod) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 +comment (10Platonides) [21:40:03] New review: MarkTraceur; "Good stuff, let's get it merged before WLM!" [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/21960 [21:40:11] RoanKattouw: I guess this is where one could make the argument to loosen it to only need a callable... [21:40:30] I suppose [21:40:36] Does call_user_func() work when passed a closure? [21:40:50] If I recall, yes [21:41:01] closures are callables [21:41:16] and as I said about 5.4, they have a nice unified type hint [21:43:09] I welcome about 5 more minutes of bikeshedding on my "how to get your code reviewed faster" quick guide, currently https://www.mediawiki.org/wiki/User:Sumanah/GettingReviews , before I move it to another page & email it out to wikitech-l [21:44:05] paulproteus: Yaron: EranRoz: Krenair: franny ^^ your comments would be valuable [21:45:30] Sorry, I won't have time for another 30 minutes or so. [21:45:32] sumanah: When rebasing, only rebase. That makes it easier to use the "Old Version History" dropdown, which greatly quickens reviews. [21:46:02] (if non-rebase changes are made inside a rebase changeset, you have to read through a lot more code to find it and it's non-obvious) [21:46:27] ...it's a shame that Gerrit's rebase pattern basically takes us right back to svn. [21:46:33] marktraceur: ok, so, EITHER make substantive changes OR rebase? [21:46:38] Right [21:46:41] I mean, do both [21:46:44] Just not at the same time [21:46:47] ...actually... no... this is worse than svn. [21:46:59] sumanah: Looks good to me, but someone else must approve :) [21:47:05] EranRoz: HA [21:48:31] ok, marktraceur, reload and check whether that is accurate? [21:49:47] lol... this rebase pattern reminds me of svn branches [21:50:34] ^_^ Seriously, it's kinda ammusing [21:51:06] ok, I'm a-movin' to Git/Code review/Getting reviews [21:51:36] "Please do a copy branch and THEN make your changes to the branch. Otherwise it's hard to see what you've modified." [21:52:17] svn copy ; svn commit ; [21:52:28] sumanah: Sounds good! [21:53:18] "Please publish a rebase, and THEN make changes to your commit. Otherwise it's hard to see what you've modified." [21:53:46] git rebase; git review ; git commit; git review ; [21:54:14] Dantman: With the exception that you don't have to rebase in order to make more changes [21:54:24] You can make changes until it's good, then rebase [21:54:45] (But yes, I agree that Gerrit's amend-based workflow is suboptimal compared to what you're proposing for Gareth) [21:54:57] Sure... but of course they will all end up squashed together. [21:55:07] Yeah. [21:56:05] In my --no-ff+reverse-merge ideal the pattern for "I need to resolve conflicts AND I have some bugs to fix" would be: [21:57:09] ok, "5 tips to get your code reviewed faster" is speeding your way, y'all [21:57:16] 03(ASSIGNED) Domain creation doesn't properly invalidate domain cache in memcache - 10https://bugzilla.wikimedia.org/39777 (10Dereckson) [21:57:24] Merge master into your review branch and resolve conflicts; Make changes to your code and commit; Push your changes; 2 commits end up added to the review branch. [21:57:32] 03(ASSIGNED) Instance creation doesn't actually fail when hosts can't be added to LDAP - 10https://bugzilla.wikimedia.org/39776 (10Dereckson) [21:58:12] The beautiful part of course is that I believe most Git GUIs are very polite towards this workflow. [21:58:16] 03(mod) [Regression] MediaWiki:Previewnote broken (double html escaped) - 10https://bugzilla.wikimedia.org/39584 +comment (10Krinkle) [21:58:37] So there is no dropping to the cli at minimum 2 times just to get it done. [21:58:52] sumanah: That page looks reasonable, but I would add more clarity to the rebase section if possible [21:59:06] At least a link for more info [22:00:53] Change merged: Kaldari; [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21960 [22:01:45] sumanah: thanks; I do know how it's supposed to "work" but it doesn't change how I feel about git & gerrit & the current workflow; I feel that we've taken a step or three in the wrong direction and no amount of pretty statistics saying "we got this many new contributors due to the VCS & code review model we nowadays use!" is going to make me change that opinion [22:01:56] 03(mod) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 +comment (10Ryan Kaldari) [22:03:17] 03(mod) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 normal->15enhancement (10Krinkle) [22:04:08] 03(FIXED) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 +comment (10Krinkle) [22:04:46] ashley: I know it doesn't change how you feel. I simply wanted to know whether that particular bit of information was already known to you. [22:04:53] (regarding changeset diffs.) [22:06:10] paulproteus: thanks, linked to a rebase-related page [22:07:14] marktraceur: [22:07:47] Wikinaut: Well put [22:07:57] :) [22:08:41] RoanKattouw, Btw, awhile ago I did reconsider the whole Gareth hosted push model... I settled for a compromise. Possibly at some point I could add a feature where you can have a personal clone inside Gareth itself. A few clicks and you're pulling and pushing with no extra work. Also besides automatic fetching from your personal repo they would have an extra feature where your personal repo automatically fetches from the primary repo. That way when [22:08:47] you pull from origin, make a change, and push to your personal repo you don't end up waiting for uploading of the commits other people made. [22:09:12] 03(mod) Chunked upload fails with internal_api_error_UploadStashFileNotFoundException - 10https://bugzilla.wikimedia.org/36587 +comment (10Erik Moeller) [22:09:38] if you need to run the EPL develop version, I have this feature branch https://github.com/Wikinaut/etherpad-lite/branches/fix-ie8-native-xmlhttp-support-disabled-issues for develop [22:10:39] Right [22:11:06] link corrected: https://github.com/Wikinaut/etherpad-lite/tree/fix-ie8-native-xmlhttp-support-disabled-issues [22:11:13] sorry [22:11:25] Wikinaut: Um, that got merged IIRC, no need to use your branch [22:11:35] (i saw) [22:11:40] good night ! [22:15:14] Are page IDs guaranteed to be unique in all namespaces? [22:15:29] Yes [22:15:39] or will there be two pages with the same ID but differnet namespaces [22:16:02] No, we only have one page table and the page_id is the PRIMARY KEY which is UNIQUE. [22:16:09] good, thanks [22:16:12] that simplifies my queries [22:16:29] trying to see if keeping a cache of filename/ID pairs is faster than looking up the list of categories that a file belongs to by filename [22:16:38] since the filenames to look at come from wikitext [22:16:59] It would actually be harder to deal with what you were describing. [22:17:11] ok [22:17:19] Technically we could put a UNIQUE index on (page_id, page_namespace) [22:17:37] But we allow page moves, and doing a page move can change page_namespace [22:18:08] New patchset: Robmoen; "Adjust margin of wpSummary elements per move of summmary box." [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/21962 [22:18:24] New review: Matmarex; "Let me just ask you for one thing: do not rebase and modify in the same commit. Scanning 50 lines of..." [mediawiki/core] (master) C: 1; - https://gerrit.wikimedia.org/r/19008 [22:18:46] 03(mod) UploadWizard should have more specific error message for files that contain HTML in the EXIF data - 10https://bugzilla.wikimedia.org/30095 +comment (10Derk-Jan Hartman) [22:19:04] 03(mod) UploadWizard should have more specific error message for files that contain HTML in the EXIF data - 10https://bugzilla.wikimedia.org/30095 (10Derk-Jan Hartman) [22:20:01] So if we had a (page_id=1, page_namespace=0, page_title=Foo) and a (page_id=1, page_namespace=1, page_title=Bar) ([[Foo]] and [[Talk:Bar]] respectively) then when you try to move [[Talk:Bar]] to [[Bar]] you would cause a SQL error as Talk:Bar would become page_namespace=0 and violate the UNIQUE constraint. [22:20:52] right [22:20:53] thanks [22:21:25] Ryan_Lane, I know ops needs private repos. But do ops need a repo where most of the repo is public, but one branch is private? [22:24:10] New patchset: Krinkle; "Add cache/ to .gitignore" [mediawiki/core] (master) - https://gerrit.wikimedia.org/r/21963 [22:24:48] hm, switching to using page IDs for the files doesn't improve performance... [22:24:52] Change abandoned: Robmoen; "Moving this into common css" [mediawiki/extensions/WikiEditor] (master) - https://gerrit.wikimedia.org/r/21962 [22:25:02] maybe the problem is that I'm trying to process too many files after all [22:25:12] is 100-200us per query for all categories that a file is part of good? [22:25:29] or is there a better way than using categorylinks [22:26:15] pietro10: Is that microseconds or milliseconds? [22:26:21] If the former, wow. [22:27:20] microseconds [22:28:02] pietro10, You iterating over a list of files and then for each one doing a query of the categories inside of it? [22:28:29] yes [22:28:41] the list of files is determined by examining the wikitext of pages that ransparently include the file via a template [22:29:06] From the DB? [22:29:08] the files represent vidoe game scans - the project I'm working on is a small web thing that shows which scans we have, which scans are in bad state, which scans we need, etc. [22:29:26] I manually parse the wiki text in an ad hoc way, but otherwise yes [22:29:32] Oh, no... [22:30:03] I wish the database would store information abaout template parameters [22:30:05] =P [22:30:07] I thought you were iterating over a db backed list of files and then making s second db query for the categories. [22:30:20] here are the database queries I make [22:30:23] http://pastie.org/pastes/4613021/text?key=4kolrny3qum5wj1wvj3uow [22:31:13] 03(mod) Upload Wizard should check for protection status of titles - 10https://bugzilla.wikimedia.org/37107 +comment (10Derk-Jan Hartman) [22:31:13] scanning every console takes about 5 seconds, but I'm trying to see if I can make it faster [22:31:28] *5 seconds total, not 5 seconds each [22:31:43] pietro10, Well to start with you might be able to use a LIKE query for some of those [22:32:01] Instead of doing a full table scan. [22:32:42] 03(mod) i18n messages for copy category and description need PLURAL support - 10https://bugzilla.wikimedia.org/37232 +comment (10Derk-Jan Hartman) [22:33:22] pietro10, But I think the gist is probably "Never expect something iterating over the entire wiki to be fast." [22:34:09] Once you bring that into the equation, I think I would always turn this into a job queue task dealing with one page at a time. [22:34:14] 03(mod) Upload Wizard should check for protection status of titles - 10https://bugzilla.wikimedia.org/37107 +comment (10Mark Holmquist) [22:34:22] 03(mod) confusing error message when uploading a file with filename is not allowed. - 10https://bugzilla.wikimedia.org/38303 +comment (10Derk-Jan Hartman) [22:34:25] SMW had a nice trick for that. [22:34:47] 03(mod) Interface messages needing rewording or documentation and other issues with existing messages (tracking) - 10https://bugzilla.wikimedia.org/38638 +comment (10Phillip Patriakeas) [22:34:54] You have two classes of jobs. [22:35:16] A job generating job. And actual jobs that do the task of handling an individual page. [22:35:39] You start by generating a job generating job that begins at id=0. [22:36:37] so what do you mean, make this concurrent? [22:36:44] When that job is run it creates a number of jobs for a range of pages in the wiki. And generates a job generating job that starts at the id at the end of the range. [22:38:12] 03(mod) Commons handling "This file was previously uploaded to this wiki." - 10https://bugzilla.wikimedia.org/38618 +comment (10Derk-Jan Hartman) [22:38:20] The job queue will run through the jobs. Handling pages one by one. When it hits the job generating job a number of new task jobs will be run again. [22:38:37] And so on until the final job generating job realizes that it has hit the end of the wiki. [22:38:41] 03(FIXED) Commons handling "This file was previously uploaded to this wiki." - 10https://bugzilla.wikimedia.org/38618 (10Derk-Jan Hartman) [22:39:26] is there an example of this? I don't quite follow [22:39:47] and what do you mean by using LIKE instead of going through the entire table? I hdont know that qualifier... [22:39:59] pietro10, Well I suppose if you ran multiple instances of runJobs at the same time it could be concurrent. But the real goal here is not for it to be concurrent. But rather you just set it and wait for it to finish later. [22:40:23] pietro10, u"se: category titles that first end in "_games" are extracted" [22:40:49] pietro10, I mean in situations like that you can use something like `cat_title LIKE '%_games'` [22:41:02] Then only rows that match the condition will be returned. [22:41:26] oh [22:41:51] and the ORDER BY will be run after the LIKE? [22:42:17] 03(mod) If you get a duplicate-archive warning for the first file in a multifile upload it gives a JS error - 10https://bugzilla.wikimedia.org/39778 +comment (10Derk-Jan Hartman) [22:42:25] I did notice that not using ORDER BY and sorting the extrcted list myself somehow made my thing slower (????????) [22:44:22] It probably gets to just iterate over the index instead of randomly accessing it. [22:44:26] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/SemanticMediaWiki.git;a=blob;f=includes/jobs/SMW_RefreshJob.php;h=519956598b4d71683b144086cbbed607f3d19d7f;hb=master [22:44:48] SMW doesn't seem to use two job types but the idea is similar. [22:45:20] A little complex to read though [22:46:14] 03(FIXED) i18n messages for copy category and description need PLURAL support - 10https://bugzilla.wikimedia.org/37232 (10Siebrand) [22:46:25] Basically the job has a position parameter, and it knows to only do 20 at a time. So when the job runs it does a refresh on 20 pages (the smwfGetStore()->refreshData()) call. And then inserts a new refresh job. [22:46:36] hm [22:46:45] That said this won't run concurrently so you might want two jobs if that's a goal. [22:47:23] 03(mod) UploadWizard: uploading file with colon in name leads to error - 10https://bugzilla.wikimedia.org/26209 +comment (10Derk-Jan Hartman) [22:48:50] ...I still want to write some sort of job queue daemon one of these days. [22:49:10] ok [22:49:21] 03(mod) Need a way back when trying to upload a file in UploadWizard that already exists - 10https://bugzilla.wikimedia.org/29594 +comment (10Derk-Jan Hartman) [22:55:37] 03(mod) Admin levels getting confused - 10https://bugzilla.wikimedia.org/39774 +comment (10Jon) [22:56:14] 03(mod) Show current user location on map - 10https://bugzilla.wikimedia.org/38921 +comment (10Jon) [23:00:46] 14(INVALID) Incomplete uploads showing admin level entries not address - 10https://bugzilla.wikimedia.org/39769 +comment (10Jon) [23:00:47] 03(mod) UploadWizard: uploading file with colon in name leads to error - 10https://bugzilla.wikimedia.org/26209 +comment (10Sage Ross) [23:01:38] 03(mod) duplicate link: is not HTML-linked to file page, not red and points to the wrong URL - 10https://bugzilla.wikimedia.org/32606 +comment (10Derk-Jan Hartman) [23:03:58] adding the like clause reduces that specific case's runtime by an order of magnitude :O [23:04:04] though it's the least frequently run query in the entire system [23:04:22] the other query for every page name in a category, however, cannot be limited - I use all but one of the results :/ [23:05:40] 03(FIXED) Incomplete uploads listing sometimes doesn't show thumbnails - 10https://bugzilla.wikimedia.org/39717 +comment (10Jon) [23:09:57] 03(mod) Revision error on en.wikipedia.org, Internal error: Unknown cluster "cluster16" - 10https://bugzilla.wikimedia.org/24675 +comment (10Roan Kattouw) [23:11:54] 03(FIXED) UploadWizard: uploading file with colon in name leads to error - 10https://bugzilla.wikimedia.org/26209 +comment (10Derk-Jan Hartman) [23:11:54] 03(mod) Query for URL of image (prop=imageinfo&iiprop=url) fails with "Uri::setUri: $uri is not of a valid type." - 10https://bugzilla.wikimedia.org/39670 +comment (10Roan Kattouw) [23:22:50] 03(mod) jquery.articleFeedbackv5.special styles loaded incorrectly in RTL languages - 10https://bugzilla.wikimedia.org/38294 +comment (10Roan Kattouw) [23:23:47] RoanKattouw: I love how just running a few job runners at once on my test wiki (with a good chunk of simple wiki imported) gives: "UPDATE `category` SET cat_pages = cat_pages - 1 WHERE cat_title = 'Pages_with_broken_file_links'" deadlock errors [23:24:55] local transaction management in Category.php is evil [23:25:18] AaronSchulz: Yeah I can only imagine what Commons must be like [23:26:05] I'm running 16 procs now (niced of course) and I'm getting even way more errors [23:26:12] 14(DUP) update the mobile app database - 10https://bugzilla.wikimedia.org/39772 +comment (10Jon) [23:26:12] 03(mod) Admin levels empty due to no campaign information (e.g. license) - 10https://bugzilla.wikimedia.org/39568 +comment (10Jon) [23:28:28] RoanKattouw, are you going to merge https://gerrit.wikimedia.org/r/#/c/17072/ ? [23:28:49] 03(mod) Set log_page to the page_id of its description page for upload actions - 10https://bugzilla.wikimedia.org/38606 +comment (10Platonides) [23:30:13] so many things to do [23:41:47] 03(mod) If you get a duplicate-archive warning for the first file in a multifile upload it gives a JS error - 10https://bugzilla.wikimedia.org/39778 +comment (10Ryan Kaldari) [23:54:50] RoanKattouw: Hi. [23:54:57] RoanKattouw: Gerrit doesn't have a built-in code editor, right?